jro_apps/redmine Commit - r8771:d4e6355eb3f2

Better handling of attachments when issue validation fails (#10253)....

Jean-Philippe Lang -

r8771:d4e6355eb3f2

parent child

Context file:

r8771:d4e6355eb3f2

Collapse all files

app/controllers/issues_controller.rb +2 -1

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
               menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
               before_filter :check_project_uniqueness, :only => [:move, :perform_move]
               before_filter :find_project, :only => [:new, :create]
               before_filter :authorize, :except => [:index]
               before_filter :find_optional_project, :only => [:index]
               before_filter :check_for_default_issue_status, :only => [:new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_rss_auth :index, :show
               accept_api_auth :index, :show, :create, :update, :destroy
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               include ProjectsHelper
               helper :custom_fields
               include CustomFieldsHelper
               helper :issue_relations
               include IssueRelationsHelper
               helper :watchers
               include WatchersHelper
               helper :attachments
               include AttachmentsHelper
               helper :queries
               include QueriesHelper
               helper :repositories
               include RepositoriesHelper
               helper :sort
               include SortHelper
               include IssuesHelper
               helper :timelog
               helper :gantt
               include Redmine::Export::PDF
               verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   case params[:format]
                   when 'csv', 'pdf'
                     @limit = Setting.issues_export_limit.to_i
                   when 'atom'
                     @limit = Setting.feeds_limit.to_i
                   when 'xml', 'json'
                     @offset, @limit = api_offset_and_limit
                   else
                     @limit = per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
                   @offset ||= @issue_pages.current.offset
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @offset,
                                           :limit => @limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index', :layout => !request.xhr? }
                     format.api  {
                       Issue.load_relations(@issues) if include_in_api_response?('relations')
                     }
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
                     format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                   end
                 else
                   respond_to do |format|
                     format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
                     format.any(:atom, :csv, :pdf) { render(:nothing => true) }
                     format.api { render_validation_errors(@query) }
                   end
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.all
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @priorities = IssuePriority.active
                 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 respond_to do |format|
                   format.html {
                     retrieve_previous_and_next_issue_ids
                     render :template => 'issues/show'
                   }
                   format.api
                   format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                 end
               end
               # Add a new issue
               # The new issue will be created from an existing one if copy_from parameter is given
               def new
                 respond_to do |format|
                   format.html { render :action => 'new', :layout => !request.xhr? }
                   format.js {
                     render(:update) { |page|
                       if params[:project_change]
                         page.replace_html 'all_attributes', :partial => 'form'
                       else
                         page.replace_html 'attributes', :partial => 'attributes'
                       end
                       m = User.current.allowed_to?(:log_time, @issue.project) ? 'show' : 'hide'
                       page << "if ($('log_time')) {Element.#{m}('log_time');}"
                     }
                   }
                 end
               end
               def create
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
+                @issue.save_attachments(params[:attachments])
                 if @issue.save
-                  attachments = Attachment.attach_files(@issue, params[:attachments])
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       render_attachment_warning_if_needed(@issue)
                       flash[:notice] = l(:notice_issue_successful_create, :id => "<a href='#{issue_path(@issue)}'>##{@issue.id}</a>")
                       redirect_to(params[:continue] ?  { :action => 'new', :project_id => @issue.project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
                                   { :action => 'show', :id => @issue })
                     }
                     format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html { render :action => 'new' }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               def edit
                 return unless update_issue_from_params
                 respond_to do |format|
                   format.html { }
                   format.xml  { }
                 end
               end
               def update
                 return unless update_issue_from_params
+                @issue.save_attachments(params[:attachments])
                 saved = false
                 begin
                   saved = @issue.save_issue_with_child_records(params, @time_entry)
                 rescue ActiveRecord::StaleObjectError
                   @conflict = true
                   if params[:last_journal_id]
                     if params[:last_journal_id].present?
                       last_journal_id = params[:last_journal_id].to_i
                       @conflict_journals = @issue.journals.all(:conditions => ["#{Journal.table_name}.id > ?", last_journal_id])
                     else
                       @conflict_journals = @issue.journals.all
                     end
                   end
                 end
                 if saved
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                     format.api  { head :ok }
                   end
                 else
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               # Bulk edit/copy a set of issues
               def bulk_edit
                 @issues.sort!
                 @copy = params[:copy].present?
                 @notes = params[:notes]
                 if User.current.allowed_to?(:move_issues, @projects)
                   @allowed_projects = Issue.allowed_target_projects_on_move
                   if params[:issue]
                     @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id]}
                     if @target_project
                       target_projects = [@target_project]
                     end
                   end
                 end
                 target_projects ||= @projects
                 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
                 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
                 @assignables = target_projects.map(&:assignable_users).reduce(:&)
                 @trackers = target_projects.map(&:trackers).reduce(:&)
                 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
                 render :layout => false if request.xhr?
               end
               def bulk_update
                 @issues.sort!
                 @copy = params[:copy].present?
                 attributes = parse_params_for_bulk_issue_attributes(params)
                 unsaved_issue_ids = []
                 moved_issues = []
                 @issues.each do |issue|
                   issue.reload
                   if @copy
                     issue = issue.copy
                   end
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                   if issue.save
                     moved_issues << issue
                   else
                     # Keep unsaved issue ids to display them in flash error
                     unsaved_issue_ids << issue.id
                   end
                 end
                 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
                 if params[:follow]
                   if @issues.size == 1 && moved_issues.size == 1
                     redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
                   elsif moved_issues.map(&:project).uniq.size == 1
                     redirect_to :controller => 'issues', :action => 'index', :project_id => moved_issues.map(&:project).first
                   end
                 else
                   redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
                 end
               end
               verify :method => :delete, :only => :destroy, :render => { :nothing => true, :status => :method_not_allowed }
               def destroy
                 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                     end
                   else
                     # display the destroy form if it's a user request
                     return unless api_request?
                   end
                 end
                 @issues.each do |issue|
                   begin
                     issue.reload.destroy
                   rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
                     # nothing to do, issue was already deleted (eg. by a parent)
                   end
                 end
                 respond_to do |format|
                   format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
                   format.api  { head :ok }
                 end
               end
             private
               def find_issue
                 # Issue.visible.find(...) can not be used to redirect user to the login form
                 # if the issue actually exists but requires authentication
                 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                 unless @issue.visible?
                   deny_access
                   return
                 end
                 @project = @issue.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
                 @project = Project.find(project_id)
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def retrieve_previous_and_next_issue_ids
                 retrieve_query_from_session
                 if @query
                   sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                   sort_update(@query.sortable_columns, 'issues_index_sort')
                   limit = 500
                   issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
                   if (idx = issue_ids.index(@issue.id)) && idx < limit
                     if issue_ids.size < 500
                       @issue_position = idx + 1
                       @issue_count = issue_ids.size
                     end
                     @prev_issue_id = issue_ids[idx - 1] if idx > 0
                     @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
                   end
                 end
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               # TODO: Refactor, not everything in here is needed by #edit
               def update_issue_from_params
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.active
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 @time_entry.attributes = params[:time_entry]
                 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
                 @issue.init_journal(User.current, @notes)
                 issue_attributes = params[:issue]
                 if issue_attributes && params[:conflict_resolution]
                   case params[:conflict_resolution]
                   when 'overwrite'
                     issue_attributes = issue_attributes.dup
                     issue_attributes.delete(:lock_version)
                   when 'add_notes'
                     issue_attributes = {}
                   when 'cancel'
                     redirect_to issue_path(@issue)
                     return false
                   end
                 end
                 @issue.safe_attributes = issue_attributes
                 true
               end
               # TODO: Refactor, lots of extra code in here
               # TODO: Changing tracker on an existing issue should not trigger this
               def build_new_issue_from_params
                 if params[:id].blank?
                   @issue = Issue.new
                   if params[:copy_from]
                     begin
                       @copy_from = Issue.visible.find(params[:copy_from])
                       @copy_attachments = params[:copy_attachments].present? || request.get?
                       @issue.copy_from(@copy_from, :attachments => @copy_attachments)
                     rescue ActiveRecord::RecordNotFound
                       render_404
                       return
                     end
                   end
                   @issue.project = @project
                 else
                   @issue = @project.issues.visible.find(params[:id])
                 end
                 @issue.project = @project
                 @issue.author = User.current
                 # Tracker must be set before custom field values
                 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                 if @issue.tracker.nil?
                   render_error l(:error_no_tracker_in_project)
                   return false
                 end
                 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
                 @issue.safe_attributes = params[:issue]
                 @priorities = IssuePriority.active
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
               end
               def check_for_default_issue_status
                 if IssueStatus.default.nil?
                   render_error l(:error_no_default_issue_status)
                   return false
                 end
               end
               def parse_params_for_bulk_issue_attributes(params)
                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                 attributes
               end
             end

app/models/attachment.rb +37 -24

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require "digest/md5"
             class Attachment < ActiveRecord::Base
               belongs_to :container, :polymorphic => true
               belongs_to :author, :class_name => "User", :foreign_key => "author_id"
-              validates_presence_of :container, :filename, :author
+              validates_presence_of :filename, :author
               validates_length_of :filename, :maximum => 255
               validates_length_of :disk_filename, :maximum => 255
               validate :validate_max_file_size
               acts_as_event :title => :filename,
                             :url => Proc.new {|o| {:controller => 'attachments', :action => 'download', :id => o.id, :filename => o.filename}}
               acts_as_activity_provider :type => 'files',
                                         :permission => :view_files,
                                         :author_key => :author_id,
                                         :find_options => {:select => "#{Attachment.table_name}.*",
                                                           :joins => "LEFT JOIN #{Version.table_name} ON #{Attachment.table_name}.container_type='Version' AND #{Version.table_name}.id = #{Attachment.table_name}.container_id " +
                                                                     "LEFT JOIN #{Project.table_name} ON #{Version.table_name}.project_id = #{Project.table_name}.id OR ( #{Attachment.table_name}.container_type='Project' AND #{Attachment.table_name}.container_id = #{Project.table_name}.id )"}
               acts_as_activity_provider :type => 'documents',
                                         :permission => :view_documents,
                                         :author_key => :author_id,
                                         :find_options => {:select => "#{Attachment.table_name}.*",
                                                           :joins => "LEFT JOIN #{Document.table_name} ON #{Attachment.table_name}.container_type='Document' AND #{Document.table_name}.id = #{Attachment.table_name}.container_id " +
                                                                     "LEFT JOIN #{Project.table_name} ON #{Document.table_name}.project_id = #{Project.table_name}.id"}
               cattr_accessor :storage_path
               @@storage_path = Redmine::Configuration['attachments_storage_path'] || "#{Rails.root}/files"
               before_save :files_to_final_location
               after_destroy :delete_from_disk
+              def container_with_blank_type_check
+                if container_type.blank?
+                  nil
+                else
+                  container_without_blank_type_check
+                end
+              end
+              alias_method_chain :container, :blank_type_check unless method_defined?(:container_without_blank_type_check)
               # Returns an unsaved copy of the attachment
               def copy(attributes=nil)
                 copy = self.class.new
                 copy.attributes = self.attributes.dup.except("id", "downloads")
                 copy.attributes = attributes if attributes
                 copy
               end
               def validate_max_file_size
                 if @temp_file && self.filesize > Setting.attachment_max_size.to_i.kilobytes
                   errors.add(:base, :too_long, :count => Setting.attachment_max_size.to_i.kilobytes)
                 end
               end
               def file=(incoming_file)
                 unless incoming_file.nil?
                   @temp_file = incoming_file
                   if @temp_file.size > 0
                     self.filename = sanitize_filename(@temp_file.original_filename)
                     self.disk_filename = Attachment.disk_filename(filename)
                     self.content_type = @temp_file.content_type.to_s.chomp
                     if content_type.blank?
                       self.content_type = Redmine::MimeType.of(filename)
                     end
                     self.filesize = @temp_file.size
                   end
                 end
               end
               def file
                 nil
               end
               # Copies the temporary file to its final location
               # and computes its MD5 hash
               def files_to_final_location
                 if @temp_file && (@temp_file.size > 0)
                   logger.info("Saving attachment '#{self.diskfile}' (#{@temp_file.size} bytes)")
                   md5 = Digest::MD5.new
                   File.open(diskfile, "wb") do |f|
                     buffer = ""
                     while (buffer = @temp_file.read(8192))
                       f.write(buffer)
                       md5.update(buffer)
                     end
                   end
                   self.digest = md5.hexdigest
                 end
                 @temp_file = nil
                 # Don't save the content type if it's longer than the authorized length
                 if self.content_type && self.content_type.length > 255
                   self.content_type = nil
                 end
               end
               # Deletes the file from the file system if it's not referenced by other attachments
               def delete_from_disk
                 if Attachment.first(:conditions => ["disk_filename = ? AND id <> ?", disk_filename, id]).nil?
                   delete_from_disk!
                 end
               end
               # Returns file's location on disk
               def diskfile
                 "#{@@storage_path}/#{self.disk_filename}"
               end
               def increment_download
                 increment!(:downloads)
               end
               def project
-                container.project
+                container.try(:project)
               end
               def visible?(user=User.current)
-                container.attachments_visible?(user)
+                container && container.attachments_visible?(user)
               end
               def deletable?(user=User.current)
-                container.attachments_deletable?(user)
+                container && container.attachments_deletable?(user)
               end
               def image?
                 self.filename =~ /\.(bmp|gif|jpg|jpe|jpeg|png)$/i
               end
               def is_text?
                 Redmine::MimeType.is_type?('text', filename)
               end
               def is_diff?
                 self.filename =~ /\.(patch|diff)$/i
               end
               # Returns true if the file is readable
               def readable?
                 File.readable?(diskfile)
               end
+              # Returns the attachment token
+              def token
+                "#{id}.#{digest}"
+              end
+              # Finds an attachment that matches the given token and that has no container
+              def self.find_by_token(token)
+                if token.to_s =~ /^(\d+)\.([0-9a-f]+)$/
+                  attachment_id, attachment_digest = $1, $2
+                  attachment = Attachment.first(:conditions => {:id => attachment_id, :digest => attachment_digest})
+                  if attachment && attachment.container.nil?
+                    attachment
+                  end
+                end
+              end
               # Bulk attaches a set of files to an object
               #
               # Returns a Hash of the results:
               # :files => array of the attached files
               # :unsaved => array of the files that could not be attached
               def self.attach_files(obj, attachments)
-                attached = []
+                result = obj.save_attachments(attachments, User.current)
-                if attachments && attachments.is_a?(Hash)
+                obj.attach_saved_attachments
-                  attachments.each_value do |attachment|
+                result
-                    file = attachment['file']
-                    next unless file && file.size > 0
-                    a = Attachment.create(:container => obj,
-                                          :file => file,
-                                          :description => attachment['description'].to_s.strip,
-                                          :author => User.current)
-                    obj.attachments << a
-                    if a.new_record?
-                      obj.unsaved_attachments ||= []
-                      obj.unsaved_attachments << a
-                    else
-                      attached << a
-                    end
-                  end
-                end
-                {:files => attached, :unsaved => obj.unsaved_attachments}
               end
               def self.latest_attach(attachments, filename)
                 attachments.sort_by(&:created_on).reverse.detect {
                   |att| att.filename.downcase == filename.downcase
                  }
               end
+              def self.prune(age=1.day)
+                attachments = Attachment.all(:conditions => ["created_on < ? AND (container_type IS NULL OR container_type = ''", Time.now - age])
+                attachments.each(&:destroy)
+              end
               private
               # Physically deletes the file from the file system
               def delete_from_disk!
                 if disk_filename.present? && File.exist?(diskfile)
                   File.delete(diskfile)
                 end
               end
               def sanitize_filename(value)
                 # get only the filename, not the whole path
                 just_filename = value.gsub(/^.*(\\|\/)/, '')
                 # Finally, replace invalid characters with underscore
                 @filename = just_filename.gsub(/[\/\?\%\*\:\|\"\'<>]+/, '_')
               end
               # Returns an ASCII or hashed filename
               def self.disk_filename(filename)
                 timestamp = DateTime.now.strftime("%y%m%d%H%M%S")
                 ascii = ''
                 if filename =~ %r{^[a-zA-Z0-9_\.\-]*$}
                   ascii = filename
                 else
                   ascii = Digest::MD5.hexdigest(filename)
                   # keep the extension if any
                   ascii << $1 if filename =~ %r{(\.[a-zA-Z0-9]+)$}
                 end
                 while File.exist?(File.join(@@storage_path, "#{timestamp}_#{ascii}"))
                   timestamp.succ!
                 end
                 "#{timestamp}_#{ascii}"
               end
             end

app/models/issue.rb +7 -16

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Issue < ActiveRecord::Base
               include Redmine::SafeAttributes
               belongs_to :project
               belongs_to :tracker
               belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
               belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
               belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
               belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
               belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
               belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
               has_many :journals, :as => :journalized, :dependent => :destroy
               has_many :time_entries, :dependent => :delete_all
               has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
               has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
               has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
               acts_as_nested_set :scope => 'root_id', :dependent => :destroy
               acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
               acts_as_customizable
               acts_as_watchable
               acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                  :include => [:project, :journals],
                                  # sort by id so that limited eager loading doesn't break with postgresql
                                  :order_column => "#{table_name}.id"
               acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                             :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                             :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
               acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                         :author_key => :author_id
               DONE_RATIO_OPTIONS = %w(issue_field issue_status)
               attr_reader :current_journal
               validates_presence_of :subject, :priority, :project, :tracker, :author, :status
               validates_length_of :subject, :maximum => 255
               validates_inclusion_of :done_ratio, :in => 0..100
               validates_numericality_of :estimated_hours, :allow_nil => true
               validate :validate_issue
               named_scope :visible, lambda {|*args| { :include => :project,
                                                       :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
               named_scope :open, lambda {|*args|
                 is_closed = args.size > 0 ? !args.first : false
                 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
               }
               named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
               named_scope :with_limit, lambda { |limit| { :limit => limit} }
               named_scope :on_active_project, :include => [:status, :project, :tracker],
                                               :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
               before_create :default_assign
               before_save :close_duplicates, :update_done_ratio_from_issue_status
               after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
               after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
               after_destroy :update_parent_attributes
               # Returns a SQL conditions string used to find all issues visible by the specified user
               def self.visible_condition(user, options={})
                 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                   case role.issues_visibility
                   when 'all'
                     nil
                   when 'default'
                     user_ids = [user.id] + user.groups.map(&:id)
                     "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                   when 'own'
                     user_ids = [user.id] + user.groups.map(&:id)
                     "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                   else
                     '1=0'
                   end
                 end
               end
               # Returns true if usr or current user is allowed to view the issue
               def visible?(usr=nil)
                 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                   case role.issues_visibility
                   when 'all'
                     true
                   when 'default'
                     !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
                   when 'own'
                     self.author == user || user.is_or_belongs_to?(assigned_to)
                   else
                     false
                   end
                 end
               end
               def initialize(attributes=nil, *args)
                 super
                 if new_record?
                   # set default values for new records only
                   self.status ||= IssueStatus.default
                   self.priority ||= IssuePriority.default
                   self.watcher_user_ids = []
                 end
               end
               # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
               def available_custom_fields
                 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
               end
               # Copies attributes from another issue, arg can be an id or an Issue
               def copy_from(arg, options={})
                 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                 self.status = issue.status
                 self.author = User.current
                 unless options[:attachments] == false
                   self.attachments = issue.attachments.map do |attachement|
                     attachement.copy(:container => self)
                   end
                 end
                 @copied_from = issue
                 self
               end
               # Returns an unsaved copy of the issue
               def copy(attributes=nil)
                 copy = self.class.new.copy_from(self)
                 copy.attributes = attributes if attributes
                 copy
               end
               # Returns true if the issue is a copy
               def copy?
                 @copied_from.present?
               end
               # Moves/copies an issue to a new project and tracker
               # Returns the moved/copied issue on success, false on failure
               def move_to_project(new_project, new_tracker=nil, options={})
                 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
                 if options[:copy]
                   issue = self.copy
                 else
                   issue = self
                 end
                 issue.init_journal(User.current, options[:notes])
                 # Preserve previous behaviour
                 # #move_to_project doesn't change tracker automatically
                 issue.send :project=, new_project, true
                 if new_tracker
                   issue.tracker = new_tracker
                 end
                 # Allow bulk setting of attributes on the issue
                 if options[:attributes]
                   issue.attributes = options[:attributes]
                 end
                 issue.save ? issue : false
               end
               def status_id=(sid)
                 self.status = nil
                 write_attribute(:status_id, sid)
               end
               def priority_id=(pid)
                 self.priority = nil
                 write_attribute(:priority_id, pid)
               end
               def category_id=(cid)
                 self.category = nil
                 write_attribute(:category_id, cid)
               end
               def fixed_version_id=(vid)
                 self.fixed_version = nil
                 write_attribute(:fixed_version_id, vid)
               end
               def tracker_id=(tid)
                 self.tracker = nil
                 result = write_attribute(:tracker_id, tid)
                 @custom_field_values = nil
                 result
               end
               def project_id=(project_id)
                 if project_id.to_s != self.project_id.to_s
                   self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
                 end
               end
               def project=(project, keep_tracker=false)
                 project_was = self.project
                 write_attribute(:project_id, project ? project.id : nil)
                 association_instance_set('project', project)
                 if project_was && project && project_was != project
                   unless keep_tracker || project.trackers.include?(tracker)
                     self.tracker = project.trackers.first
                   end
                   # Reassign to the category with same name if any
                   if category
                     self.category = project.issue_categories.find_by_name(category.name)
                   end
                   # Keep the fixed_version if it's still valid in the new_project
                   if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
                     self.fixed_version = nil
                   end
                   if parent && parent.project_id != project_id
                     self.parent_issue_id = nil
                   end
                   @custom_field_values = nil
                 end
               end
               def description=(arg)
                 if arg.is_a?(String)
                   arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                 end
                 write_attribute(:description, arg)
               end
               # Overrides attributes= so that project and tracker get assigned first
               def attributes_with_project_and_tracker_first=(new_attributes, *args)
                 return if new_attributes.nil?
                 attrs = new_attributes.dup
                 attrs.stringify_keys!
                 %w(project project_id tracker tracker_id).each do |attr|
                   if attrs.has_key?(attr)
                     send "#{attr}=", attrs.delete(attr)
                   end
                 end
                 send :attributes_without_project_and_tracker_first=, attrs, *args
               end
               # Do not redefine alias chain on reload (see #4838)
               alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
               def estimated_hours=(h)
                 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
               end
               safe_attributes 'project_id',
                 :if => lambda {|issue, user|
                   if issue.new_record?
                     issue.copy?
                   elsif user.allowed_to?(:move_issues, issue.project)
                     projects = Issue.allowed_target_projects_on_move(user)
                     projects.include?(issue.project) && projects.size > 1
                   end
                 }
               safe_attributes 'tracker_id',
                 'status_id',
                 'category_id',
                 'assigned_to_id',
                 'priority_id',
                 'fixed_version_id',
                 'subject',
                 'description',
                 'start_date',
                 'due_date',
                 'done_ratio',
                 'estimated_hours',
                 'custom_field_values',
                 'custom_fields',
                 'lock_version',
                 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
               safe_attributes 'status_id',
                 'assigned_to_id',
                 'fixed_version_id',
                 'done_ratio',
                 'lock_version',
                 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
               safe_attributes 'watcher_user_ids',
                 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
               safe_attributes 'is_private',
                 :if => lambda {|issue, user|
                   user.allowed_to?(:set_issues_private, issue.project) ||
                     (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                 }
               safe_attributes 'parent_issue_id',
                 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                   user.allowed_to?(:manage_subtasks, issue.project)}
               # Safely sets attributes
               # Should be called from controllers instead of #attributes=
               # attr_accessible is too rough because we still want things like
               # Issue.new(:project => foo) to work
               def safe_attributes=(attrs, user=User.current)
                 return unless attrs.is_a?(Hash)
                 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                 attrs = delete_unsafe_attributes(attrs, user)
                 return if attrs.empty?
                 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                 if p = attrs.delete('project_id')
                   if allowed_target_projects(user).collect(&:id).include?(p.to_i)
                     self.project_id = p
                   end
                 end
                 if t = attrs.delete('tracker_id')
                   self.tracker_id = t
                 end
                 if attrs['status_id']
                   unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
                     attrs.delete('status_id')
                   end
                 end
                 unless leaf?
                   attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                 end
                 if attrs['parent_issue_id'].present?
                   attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
                 end
                 # mass-assignment security bypass
                 self.send :attributes=, attrs, false
               end
               def done_ratio
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   status.default_done_ratio
                 else
                   read_attribute(:done_ratio)
                 end
               end
               def self.use_status_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_status'
               end
               def self.use_field_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_field'
               end
               def validate_issue
                 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
                   errors.add :due_date, :not_a_date
                 end
                 if self.due_date and self.start_date and self.due_date < self.start_date
                   errors.add :due_date, :greater_than_start_date
                 end
                 if start_date && soonest_start && start_date < soonest_start
                   errors.add :start_date, :invalid
                 end
                 if fixed_version
                   if !assignable_versions.include?(fixed_version)
                     errors.add :fixed_version_id, :inclusion
                   elsif reopened? && fixed_version.closed?
                     errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                   end
                 end
                 # Checks that the issue can not be added/moved to a disabled tracker
                 if project && (tracker_id_changed? || project_id_changed?)
                   unless project.trackers.include?(tracker)
                     errors.add :tracker_id, :inclusion
                   end
                 end
                 # Checks parent issue assignment
                 if @parent_issue
                   if @parent_issue.project_id != project_id
                     errors.add :parent_issue_id, :not_same_project
                   elsif !new_record?
                     # moving an existing issue
                     if @parent_issue.root_id != root_id
                       # we can always move to another tree
                     elsif move_possible?(@parent_issue)
                       # move accepted inside tree
                     else
                       errors.add :parent_issue_id, :not_a_valid_parent
                     end
                   end
                 end
               end
               # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
               # even if the user turns off the setting later
               def update_done_ratio_from_issue_status
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   self.done_ratio = status.default_done_ratio
                 end
               end
               def init_journal(user, notes = "")
                 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                 if new_record?
                   @current_journal.notify = false
                 else
                   @attributes_before_change = attributes.dup
                   @custom_values_before_change = {}
                   self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                 end
                 # Make sure updated_on is updated when adding a note.
                 updated_on_will_change!
                 @current_journal
               end
               # Returns the id of the last journal or nil
               def last_journal_id
                 if new_record?
                   nil
                 else
                   journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
                 end
               end
               # Return true if the issue is closed, otherwise false
               def closed?
                 self.status.is_closed?
               end
               # Return true if the issue is being reopened
               def reopened?
                 if !new_record? && status_id_changed?
                   status_was = IssueStatus.find_by_id(status_id_was)
                   status_new = IssueStatus.find_by_id(status_id)
                   if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Return true if the issue is being closed
               def closing?
                 if !new_record? && status_id_changed?
                   status_was = IssueStatus.find_by_id(status_id_was)
                   status_new = IssueStatus.find_by_id(status_id)
                   if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Returns true if the issue is overdue
               def overdue?
                 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
               end
               # Is the amount of work done less than it should for the due date
               def behind_schedule?
                 return false if start_date.nil? || due_date.nil?
                 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                 return done_date <= Date.today
               end
               # Does this issue have children?
               def children?
                 !leaf?
               end
               # Users the issue can be assigned to
               def assignable_users
                 users = project.assignable_users
                 users << author if author
                 users << assigned_to if assigned_to
                 users.uniq.sort
               end
               # Versions that the issue can be assigned to
               def assignable_versions
                 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
               end
               # Returns true if this issue is blocked by another issue that is still open
               def blocked?
                 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
               end
               # Returns an array of status that user is able to apply
               def new_statuses_allowed_to(user=User.current, include_default=false)
                 statuses = status.find_new_statuses_allowed_to(
                   user.admin ? Role.all : user.roles_for_project(project),
                   tracker,
                   author == user,
                   assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                   )
                 statuses << status unless statuses.empty?
                 statuses << IssueStatus.default if include_default
                 statuses = statuses.uniq.sort
                 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
               end
               def assigned_to_was
                 if assigned_to_id_changed? && assigned_to_id_was.present?
                   @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
                 end
               end
               # Returns the mail adresses of users that should be notified
               def recipients
                 notified = []
                 # Author and assignee are always notified unless they have been
                 # locked or don't want to be notified
                 notified << author if author
                 if assigned_to
                   notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
                 end
                 if assigned_to_was
                   notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
                 end
                 notified = notified.select {|u| u.active? && u.notify_about?(self)}
                 notified += project.notified_users
                 notified.uniq!
                 # Remove users that can not view the issue
                 notified.reject! {|user| !visible?(user)}
                 notified.collect(&:mail)
               end
               # Returns the number of hours spent on this issue
               def spent_hours
                 @spent_hours ||= time_entries.sum(:hours) || 0
               end
               # Returns the total number of hours spent on this issue and its descendants
               #
               # Example:
               #   spent_hours => 0.0
               #   spent_hours => 50.2
               def total_spent_hours
                 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
                   :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
               end
               def relations
                 @relations ||= (relations_from + relations_to).sort
               end
               # Preloads relations for a collection of issues
               def self.load_relations(issues)
                 if issues.any?
                   relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
                   issues.each do |issue|
                     issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                   end
                 end
               end
               # Preloads visible spent time for a collection of issues
               def self.load_visible_spent_hours(issues, user=User.current)
                 if issues.any?
                   hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
                   issues.each do |issue|
                     issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                   end
                 end
               end
               # Finds an issue relation given its id.
               def find_relation(relation_id)
                 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
               end
               def all_dependent_issues(except=[])
                 except << self
                 dependencies = []
                 relations_from.each do |relation|
                   if relation.issue_to && !except.include?(relation.issue_to)
                     dependencies << relation.issue_to
                     dependencies += relation.issue_to.all_dependent_issues(except)
                   end
                 end
                 dependencies
               end
               # Returns an array of issues that duplicate this one
               def duplicates
                 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
               end
               # Returns the due date or the target due date if any
               # Used on gantt chart
               def due_before
                 due_date || (fixed_version ? fixed_version.effective_date : nil)
               end
               # Returns the time scheduled for this issue.
               #
               # Example:
               #   Start Date: 2/26/09, End Date: 3/04/09
               #   duration => 6
               def duration
                 (start_date && due_date) ? due_date - start_date : 0
               end
               def soonest_start
                 @soonest_start ||= (
                     relations_to.collect{|relation| relation.successor_soonest_start} +
                     ancestors.collect(&:soonest_start)
                   ).compact.max
               end
               def reschedule_after(date)
                 return if date.nil?
                 if leaf?
                   if start_date.nil? || start_date < date
                     self.start_date, self.due_date = date, date + duration
                     begin
                       save
                     rescue ActiveRecord::StaleObjectError
                       reload
                       self.start_date, self.due_date = date, date + duration
                       save
                     end
                   end
                 else
                   leaves.each do |leaf|
                     leaf.reschedule_after(date)
                   end
                 end
               end
               def <=>(issue)
                 if issue.nil?
                   -1
                 elsif root_id != issue.root_id
                   (root_id || 0) <=> (issue.root_id || 0)
                 else
                   (lft || 0) <=> (issue.lft || 0)
                 end
               end
               def to_s
                 "#{tracker} ##{id}: #{subject}"
               end
               # Returns a string of css classes that apply to the issue
               def css_classes
                 s = "issue status-#{status.position} priority-#{priority.position}"
                 s << ' closed' if closed?
                 s << ' overdue' if overdue?
                 s << ' child' if child?
                 s << ' parent' unless leaf?
                 s << ' private' if is_private?
                 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                 s
               end
-              # Saves an issue, time_entry, attachments, and a journal from the parameters
+              # Saves an issue and a time_entry from the parameters
-              # Returns false if save fails
               def save_issue_with_child_records(params, existing_time_entry=nil)
                 Issue.transaction do
                   if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                     @time_entry = existing_time_entry || TimeEntry.new
                     @time_entry.project = project
                     @time_entry.issue = self
                     @time_entry.user = User.current
                     @time_entry.spent_on = User.current.today
                     @time_entry.attributes = params[:time_entry]
                     self.time_entries << @time_entry
                   end
-                  if valid?
+                  # TODO: Rename hook
-                    attachments = Attachment.attach_files(self, params[:attachments])
+                  Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
+                  if save
                     # TODO: Rename hook
-                    Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
+                    Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
-                    begin
+                  else
-                      if save
+                    raise ActiveRecord::Rollback
-                        # TODO: Rename hook
-                        Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
-                      else
-                        raise ActiveRecord::Rollback
-                      end
-                    rescue ActiveRecord::StaleObjectError
-                      attachments[:files].each(&:destroy)
-                      raise ActiveRecord::StaleObjectError
-                    end
                   end
                 end
               end
               # Unassigns issues from +version+ if it's no longer shared with issue's project
               def self.update_versions_from_sharing_change(version)
                 # Update issues assigned to the version
                 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
               end
               # Unassigns issues from versions that are no longer shared
               # after +project+ was moved
               def self.update_versions_from_hierarchy_change(project)
                 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                 # Update issues of the moved projects and issues assigned to a version of a moved project
                 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
               end
               def parent_issue_id=(arg)
                 parent_issue_id = arg.blank? ? nil : arg.to_i
                 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
                   @parent_issue.id
                 else
                   @parent_issue = nil
                   nil
                 end
               end
               def parent_issue_id
                 if instance_variable_defined? :@parent_issue
                   @parent_issue.nil? ? nil : @parent_issue.id
                 else
                   parent_id
                 end
               end
               # Extracted from the ReportsController.
               def self.by_tracker(project)
                 count_and_group_by(:project => project,
                                    :field => 'tracker_id',
                                    :joins => Tracker.table_name)
               end
               def self.by_version(project)
                 count_and_group_by(:project => project,
                                    :field => 'fixed_version_id',
                                    :joins => Version.table_name)
               end
               def self.by_priority(project)
                 count_and_group_by(:project => project,
                                    :field => 'priority_id',
                                    :joins => IssuePriority.table_name)
               end
               def self.by_category(project)
                 count_and_group_by(:project => project,
                                    :field => 'category_id',
                                    :joins => IssueCategory.table_name)
               end
               def self.by_assigned_to(project)
                 count_and_group_by(:project => project,
                                    :field => 'assigned_to_id',
                                    :joins => User.table_name)
               end
               def self.by_author(project)
                 count_and_group_by(:project => project,
                                    :field => 'author_id',
                                    :joins => User.table_name)
               end
               def self.by_subproject(project)
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             #{Issue.table_name}.project_id as project_id,
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                             #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                             and #{Issue.table_name}.project_id <> #{project.id}
                                                           group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
               end
               # End ReportsController extraction
               # Returns an array of projects that user can assign the issue to
               def allowed_target_projects(user=User.current)
                 if new_record?
                   Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
                 else
                   self.class.allowed_target_projects_on_move(user)
                 end
               end
               # Returns an array of projects that user can move issues to
               def self.allowed_target_projects_on_move(user=User.current)
                 projects = []
                 if user.admin?
                   # admin is allowed to move issues to any active (visible) project
                   projects = Project.visible(user).all
                 elsif user.logged?
                   if Role.non_member.allowed_to?(:move_issues)
                     projects = Project.visible(user).all
                   else
                     user.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
                   end
                 end
                 projects
               end
               private
               def after_project_change
                 # Update project_id on related time entries
                 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
                 # Delete issue relations
                 unless Setting.cross_project_issue_relations?
                   relations_from.clear
                   relations_to.clear
                 end
                 # Move subtasks
                 children.each do |child|
                   # Change project and keep project
                   child.send :project=, project, true
                   unless child.save
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               def update_nested_set_attributes
                 if root_id.nil?
                   # issue was just created
                   self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                   set_default_left_and_right
                   Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                   if @parent_issue
                     move_to_child_of(@parent_issue)
                   end
                   reload
                 elsif parent_issue_id != parent_id
                   former_parent_id = parent_id
                   # moving an existing issue
                   if @parent_issue && @parent_issue.root_id == root_id
                     # inside the same tree
                     move_to_child_of(@parent_issue)
                   else
                     # to another tree
                     unless root?
                       move_to_right_of(root)
                       reload
                     end
                     old_root_id = root_id
                     self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                     target_maxright = nested_set_scope.maximum(right_column_name) || 0
                     offset = target_maxright + 1 - lft
                     Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                       ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                     self[left_column_name] = lft + offset
                     self[right_column_name] = rgt + offset
                     if @parent_issue
                       move_to_child_of(@parent_issue)
                     end
                   end
                   reload
                   # delete invalid relations of all descendants
                   self_and_descendants.each do |issue|
                     issue.relations.each do |relation|
                       relation.destroy unless relation.valid?
                     end
                   end
                   # update former parent
                   recalculate_attributes_for(former_parent_id) if former_parent_id
                 end
                 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
               end
               def update_parent_attributes
                 recalculate_attributes_for(parent_id) if parent_id
               end
               def recalculate_attributes_for(issue_id)
                 if issue_id && p = Issue.find_by_id(issue_id)
                   # priority = highest priority of children
                   if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
                     p.priority = IssuePriority.find_by_position(priority_position)
                   end
                   # start/due dates = lowest/highest dates of children
                   p.start_date = p.children.minimum(:start_date)
                   p.due_date = p.children.maximum(:due_date)
                   if p.start_date && p.due_date && p.due_date < p.start_date
                     p.start_date, p.due_date = p.due_date, p.start_date
                   end
                   # done ratio = weighted average ratio of leaves
                   unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                     leaves_count = p.leaves.count
                     if leaves_count > 0
                       average = p.leaves.average(:estimated_hours).to_f
                       if average == 0
                         average = 1
                       end
                       done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
                       progress = done / (average * leaves_count)
                       p.done_ratio = progress.round
                     end
                   end
                   # estimate = sum of leaves estimates
                   p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                   p.estimated_hours = nil if p.estimated_hours == 0.0
                   # ancestors will be recursively updated
                   p.save(false)
                 end
               end
               # Update issues so their versions are not pointing to a
               # fixed_version that is not shared with the issue's project
               def self.update_versions(conditions=nil)
                 # Only need to update issues with a fixed_version from
                 # a different project and that is not systemwide shared
                 Issue.scoped(:conditions => conditions).all(
                   :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                     " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                     " AND #{Version.table_name}.sharing <> 'system'",
                   :include => [:project, :fixed_version]
                 ).each do |issue|
                   next if issue.project.nil? || issue.fixed_version.nil?
                   unless issue.project.shared_versions.include?(issue.fixed_version)
                     issue.init_journal(User.current)
                     issue.fixed_version = nil
                     issue.save
                   end
                 end
               end
               # Callback on attachment deletion
               def attachment_added(obj)
                 if @current_journal && !obj.new_record?
                   @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
                 end
               end
               # Callback on attachment deletion
               def attachment_removed(obj)
                 journal = init_journal(User.current)
                 journal.details << JournalDetail.new(:property => 'attachment',
                                                      :prop_key => obj.id,
                                                      :old_value => obj.filename)
                 journal.save
               end
               # Default assignment based on category
               def default_assign
                 if assigned_to.nil? && category && category.assigned_to
                   self.assigned_to = category.assigned_to
                 end
               end
               # Updates start/due dates of following issues
               def reschedule_following_issues
                 if start_date_changed? || due_date_changed?
                   relations_from.each do |relation|
                     relation.set_issue_to_dates
                   end
                 end
               end
               # Closes duplicates if the issue is being closed
               def close_duplicates
                 if closing?
                   duplicates.each do |duplicate|
                     # Reload is need in case the duplicate was updated by a previous duplicate
                     duplicate.reload
                     # Don't re-close it if it's already closed
                     next if duplicate.closed?
                     # Same user and notes
                     if @current_journal
                       duplicate.init_journal(@current_journal.user, @current_journal.notes)
                     end
                     duplicate.update_attribute :status, self.status
                   end
                 end
               end
               # Saves the changes in a Journal
               # Called after_save
               def create_journal
                 if @current_journal
                   # attributes changes
                   if @attributes_before_change
                     (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
                       before = @attributes_before_change[c]
                       after = send(c)
                       next if before == after || (before.blank? && after.blank?)
                       @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                     :prop_key => c,
                                                                     :old_value => before,
                                                                     :value => after)
                     }
                   end
                   if @custom_values_before_change
                     # custom fields changes
                     custom_field_values.each {|c|
                       before = @custom_values_before_change[c.custom_field_id]
                       after = c.value
                       next if before == after || (before.blank? && after.blank?)
                       if before.is_a?(Array) || after.is_a?(Array)
                         before = [before] unless before.is_a?(Array)
                         after = [after] unless after.is_a?(Array)
                         # values removed
                         (before - after).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => value,
                                                                         :value => nil)
                         end
                         # values added
                         (after - before).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => nil,
                                                                         :value => value)
                         end
                       else
                         @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                       :prop_key => c.custom_field_id,
                                                                       :old_value => before,
                                                                       :value => after)
                       end
                     }
                   end
                   @current_journal.save
                   # reset current journal
                   init_journal @current_journal.user, @current_journal.notes
                 end
               end
               # Query generator for selecting groups of issue counts for a project
               # based on specific criteria
               #
               # Options
               # * project - Project to search in.
               # * field - String. Issue field to key off of in the grouping.
               # * joins - String. The table name to join against.
               def self.count_and_group_by(options)
                 project = options.delete(:project)
                 select_field = options.delete(:field)
                 joins = options.delete(:joins)
                 where = "#{Issue.table_name}.#{select_field}=j.id"
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             j.id as #{select_field},
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                               #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{where}
                                                             and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project)}
                                                           group by s.id, s.is_closed, j.id")
               end
             end

app/views/attachments/_form.html.erb +8 0

+            <% if defined?(container) && container && container.saved_attachments %>
+              <% container.saved_attachments.each_with_index do |attachment, i| %>
+                <span class="icon icon-attachment" style="display:block; line-height:1.5em;">
+                  <%= h(attachment.filename) %> (<%= number_to_human_size(attachment.filesize) %>)
+                  <%= hidden_field_tag "attachments[p#{i}][token]", "#{attachment.id}.#{attachment.digest}" %>
+                </span>
+              <% end %>
+            <% end %>
             <span id="attachments_fields">
               <span>
                 <%= file_field_tag 'attachments[1][file]', :size => 30, :id => nil, :class => 'file',
                       :onchange => "checkFileSize(this, #{Setting.attachment_max_size.to_i.kilobytes}, '#{escape_javascript(l(:error_attachment_too_big, :max_size => number_to_human_size(Setting.attachment_max_size.to_i.kilobytes)))}');"  -%>
                 <%= text_field_tag 'attachments[1][description]', '', :id => nil, :class => 'description', :placeholder => l(:label_optional_description) %>
                 <%= link_to_function(image_tag('delete.png'), 'removeFileField(this)', :title => (l(:button_delete))) %>
               </span>
             </span>
             <small><%= link_to l(:label_add_another_file), '#', :onclick => 'addFileField(); return false;' %>
             (<%= l(:label_max_size) %>: <%= number_to_human_size(Setting.attachment_max_size.to_i.kilobytes) %>)
             </small>

app/views/issues/_edit.html.erb +1 -1

             <% labelled_form_for @issue, :html => {:id => 'issue-form', :multipart => true} do |f| %>
                 <%= error_messages_for 'issue', 'time_entry' %>
                 <%= render :partial => 'conflict' if @conflict %>
                 <div class="box">
                 <% if @edit_allowed || !@allowed_statuses.empty? %>
                     <fieldset class="tabular"><legend><%= l(:label_change_properties) %></legend>
                     <div id="all_attributes">
                     <%= render :partial => 'form', :locals => {:f => f} %>
                     </div>
                     </fieldset>
                 <% end %>
                 <% if User.current.allowed_to?(:log_time, @project) %>
                     <fieldset class="tabular"><legend><%= l(:button_log_time) %></legend>
                     <% labelled_fields_for :time_entry, @time_entry do |time_entry| %>
                     <div class="splitcontentleft">
                     <p><%= time_entry.text_field :hours, :size => 6, :label => :label_spent_time %> <%= l(:field_hours) %></p>
                     </div>
                     <div class="splitcontentright">
                     <p><%= time_entry.select :activity_id, activity_collection_for_select_options %></p>
                     </div>
                     <p><%= time_entry.text_field :comments, :size => 60 %></p>
                     <% @time_entry.custom_field_values.each do |value| %>
                       <p><%= custom_field_tag_with_label :time_entry, value %></p>
                     <% end %>
                     <% end %>
                 </fieldset>
                 <% end %>
                 <fieldset><legend><%= l(:field_notes) %></legend>
                 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
                 <%= wikitoolbar_for 'notes' %>
                 <%= call_hook(:view_issues_edit_notes_bottom, { :issue => @issue, :notes => @notes, :form => f }) %>
-                <p><%=l(:label_attachment_plural)%><br /><%= render :partial => 'attachments/form' %></p>
+                <p><%=l(:label_attachment_plural)%><br /><%= render :partial => 'attachments/form', :locals => {:container => @issue} %></p>
                 </fieldset>
                 </div>
                 <%= f.hidden_field :lock_version %>
                 <%= hidden_field_tag 'last_journal_id', params[:last_journal_id] || @issue.last_journal_id %>
                 <%= submit_tag l(:button_submit) %>
                 <%= link_to_remote l(:label_preview),
                                    { :url => preview_edit_issue_path(:project_id => @project, :id => @issue),
                                      :method => 'post',
                                      :update => 'preview',
                                      :with => 'Form.serialize("issue-form")',
                                      :complete => "Element.scrollTo('preview')"
                                    }, :accesskey => accesskey(:preview) %>
             <% end %>
             <div id="preview" class="wiki"></div>

app/views/issues/new.html.erb +1 -1

             <h2><%=l(:label_issue_new)%></h2>
             <%= call_hook(:view_issues_new_top, {:issue => @issue}) %>
             <% labelled_form_for @issue, :url => project_issues_path(@project),
                                          :html => {:id => 'issue-form', :multipart => true} do |f| %>
               <%= error_messages_for 'issue' %>
               <%= hidden_field_tag 'copy_from', params[:copy_from] if params[:copy_from] %>
               <div class="box tabular">
                 <div id="all_attributes">
                 <%= render :partial => 'issues/form', :locals => {:f => f} %>
                 </div>
                 <% if @copy_from && @copy_from.attachments.any? %>
                 <p>
                   <label for="copy_attachments"><%= l(:label_copy_attachments) %></label>
                   <%= check_box_tag 'copy_attachments', '1', @copy_attachments %>
                 </p>
                 <% end %>
-                <p id="attachments_form"><%= label_tag('attachments[1][file]', l(:label_attachment_plural))%><%= render :partial => 'attachments/form' %></p>
+                <p id="attachments_form"><%= label_tag('attachments[1][file]', l(:label_attachment_plural))%><%= render :partial => 'attachments/form', :locals => {:container => @issue} %></p>
                 <% if @issue.safe_attribute? 'watcher_user_ids' -%>
                   <p id="watchers_form"><label><%= l(:label_issue_watchers) %></label>
                   <% @issue.project.users.sort.each do |user| -%>
                     <label class="floating"><%= check_box_tag 'issue[watcher_user_ids][]', user.id, @issue.watched_by?(user), :id => nil %> <%=h user %></label>
                   <% end -%>
                   </p>
                 <% end %>
               </div>
                 <%= submit_tag l(:button_create) %>
                 <%= submit_tag l(:button_create_and_continue), :name => 'continue' %>
                 <%= link_to_remote l(:label_preview),
                                    { :url => preview_new_issue_path(:project_id => @project),
                                      :method => 'post',
                                      :update => 'preview',
                                      :with => "Form.serialize('issue-form')",
                                      :complete => "Element.scrollTo('preview')"
                                    }, :accesskey => accesskey(:preview) %>
                 <%= javascript_tag "Form.Element.focus('issue_subject');" %>
             <% end %>
             <div id="preview" class="wiki"></div>
             <% content_for :header_tags do %>
                 <%= stylesheet_link_tag 'scm' %>
                 <%= robot_exclusion_tag %>
             <% end %>

test/functional/attachments_controller_test.rb +8 0

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'attachments_controller'
             # Re-raise errors caught by the controller.
             class AttachmentsController; def rescue_action(e) raise e end; end
             class AttachmentsControllerTest < ActionController::TestCase
               fixtures :users, :projects, :roles, :members, :member_roles,
                        :enabled_modules, :issues, :trackers, :attachments,
                        :versions, :wiki_pages, :wikis, :documents
               def setup
                 @controller = AttachmentsController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 set_fixtures_attachments_directory
               end
               def teardown
                 set_tmp_attachments_directory
               end
               def test_show_diff
                 ['inline', 'sbs'].each do |dt|
                   # 060719210727_changeset_utf8.diff
                   get :show, :id => 14, :type => dt
                   assert_response :success
                   assert_template 'diff'
                   assert_equal 'text/html', @response.content_type
                   assert_tag 'th',
                     :attributes => {:class => /filename/},
                     :content => /issues_controller.rb\t\(révision 1484\)/
                   assert_tag 'td',
                     :attributes => {:class => /line-code/},
                     :content => /Demande créée avec succès/
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_replcace_cannot_convert_content
                 with_settings :repositories_encodings => 'UTF-8' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_tag 'th',
                       :attributes => {:class => "filename"},
                       :content => /issues_controller.rb\t\(r\?vision 1484\)/
                     assert_tag 'td',
                       :attributes => {:class => /line-code/},
                       :content => /Demande cr\?\?e avec succ\?s/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_latin_1
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_tag 'th',
                       :attributes => {:class => "filename"},
                       :content => /issues_controller.rb\t\(révision 1484\)/
                     assert_tag 'td',
                       :attributes => {:class => /line-code/},
                       :content => /Demande créée avec succès/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_save_diff_type
                 @request.session[:user_id] = 1 # admin
                 user = User.find(1)
                 get :show, :id => 5
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "inline", user.pref[:diff_type]
                 get :show, :id => 5, :type => 'sbs'
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "sbs", user.pref[:diff_type]
               end
               def test_show_text_file
                 get :show, :id => 4
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_text_file_utf_8
                 set_tmp_attachments_directory
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'japanese-utf-8.txt', a.filename
                 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
                 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
                 get :show, :id => a.id
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 assert_tag :tag => 'th',
                            :content => '1',
                            :attributes => { :class => 'line-num' },
                            :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
               end
               def test_show_text_file_replcace_cannot_convert_content
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_tag :tag => 'th',
                              :content => '7',
                              :attributes => { :class => 'line-num' },
                              :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
                 end
               end
               def test_show_text_file_latin_1
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_tag :tag => 'th',
                              :content => '7',
                              :attributes => { :class => 'line-num' },
                              :sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
                   end
               end
               def test_show_text_file_should_send_if_too_big
                 Setting.file_max_size_displayed = 512
                 Attachment.find(4).update_attribute :filesize, 754.kilobyte
                 get :show, :id => 4
                 assert_response :success
                 assert_equal 'application/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_other
                 get :show, :id => 6
                 assert_response :success
                 assert_equal 'application/octet-stream', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_without_permission
                 get :show, :id => 15
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_with_permission
                 @request.session[:user_id] = 2
                 get :show, :id => 15
                 assert_response :success
                 assert_tag 'h2', :content => /private.diff/
                 set_tmp_attachments_directory
               end
+              def test_show_file_without_container_should_be_denied
+                attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
+                @request.session[:user_id] = 2
+                get :show, :id => attachment.id
+                assert_response 403
+              end
               def test_download_text_file
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'application/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_version_file_with_issue_tracking_disabled
                 Project.find(1).disable_module! :issue_tracking
                 get :download, :id => 9
                 assert_response :success
               end
               def test_download_should_assign_content_type_if_blank
                 Attachment.find(4).update_attribute(:content_type, '')
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'text/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_missing_file
                 get :download, :id => 2
                 assert_response 404
                 set_tmp_attachments_directory
               end
               def test_anonymous_on_private_private
                 get :download, :id => 7
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
                 set_tmp_attachments_directory
               end
               def test_destroy_issue_attachment
                 set_tmp_attachments_directory
                 issue = Issue.find(3)
                 @request.session[:user_id] = 2
                 assert_difference 'issue.attachments.count', -1 do
                   delete :destroy, :id => 1
                 end
                 # no referrer
                 assert_redirected_to '/projects/ecookbook'
                 assert_nil Attachment.find_by_id(1)
                 j = issue.journals.find(:first, :order => 'created_on DESC')
                 assert_equal 'attachment', j.details.first.property
                 assert_equal '1', j.details.first.prop_key
                 assert_equal 'error281.txt', j.details.first.old_value
               end
               def test_destroy_wiki_page_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 3
                   assert_response 302
                 end
               end
               def test_destroy_project_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 8
                   assert_response 302
                 end
               end
               def test_destroy_version_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 9
                   assert_response 302
                 end
               end
               def test_destroy_without_permission
                 set_tmp_attachments_directory
                 assert_no_difference 'Attachment.count' do
                   delete :destroy, :id => 3
                 end
                 assert_response 302
                 assert Attachment.find_by_id(3)
               end
             end

test/functional/issues_controller_test.rb +129 0

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'issues_controller'
             class IssuesControllerTest < ActionController::TestCase
               fixtures :projects,
                        :users,
                        :roles,
                        :members,
                        :member_roles,
                        :issues,
                        :issue_statuses,
                        :versions,
                        :trackers,
                        :projects_trackers,
                        :issue_categories,
                        :enabled_modules,
                        :enumerations,
                        :attachments,
                        :workflows,
                        :custom_fields,
                        :custom_values,
                        :custom_fields_projects,
                        :custom_fields_trackers,
                        :time_entries,
                        :journals,
                        :journal_details,
                        :queries,
                        :repositories,
                        :changesets
               include Redmine::I18n
               def setup
                 @controller = IssuesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
               end
               def test_index
                 with_settings :default_language => "en" do
                   get :index
                   assert_response :success
                   assert_template 'index'
                   assert_not_nil assigns(:issues)
                   assert_nil assigns(:project)
                   assert_tag :tag => 'a', :content => /Can't print recipes/
                   assert_tag :tag => 'a', :content => /Subproject issue/
                   # private projects hidden
                   assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                   assert_no_tag :tag => 'a', :content => /Issue on project 2/
                   # project column
                   assert_tag :tag => 'th', :content => /Project/
                 end
               end
               def test_index_should_not_list_issues_when_module_disabled
                 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
                 get :index
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_nil assigns(:project)
                 assert_no_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
               end
               def test_index_should_list_visible_issues_only
                 get :index, :per_page => 100
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
               end
               def test_index_with_project
                 Setting.display_subprojects_issues = 0
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_no_tag :tag => 'a', :content => /Subproject issue/
               end
               def test_index_with_project_and_subprojects
                 Setting.display_subprojects_issues = 1
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
                 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
               end
               def test_index_with_project_and_subprojects_should_show_private_subprojects
                 @request.session[:user_id] = 2
                 Setting.display_subprojects_issues = 1
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
                 assert_tag :tag => 'a', :content => /Issue of a private subproject/
               end
               def test_index_with_project_and_default_filter
                 get :index, :project_id => 1, :set_filter => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 query = assigns(:query)
                 assert_not_nil query
                 # default filter
                 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
               end
               def test_index_with_project_and_filter
                 get :index, :project_id => 1, :set_filter => 1,
                   :f => ['tracker_id'],
                   :op => {'tracker_id' => '='},
                   :v => {'tracker_id' => ['1']}
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 query = assigns(:query)
                 assert_not_nil query
                 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
               end
               def test_index_with_short_filters
                 to_test = {
                   'status_id' => {
                     'o' => { :op => 'o', :values => [''] },
                     'c' => { :op => 'c', :values => [''] },
                     '7' => { :op => '=', :values => ['7'] },
                     '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
                     '=7' => { :op => '=', :values => ['7'] },
                     '!3' => { :op => '!', :values => ['3'] },
                     '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
                   'subject' => {
                     'This is a subject' => { :op => '=', :values => ['This is a subject'] },
                     'o' => { :op => '=', :values => ['o'] },
                     '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
                     '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
                   'tracker_id' => {
                     '3' => { :op => '=', :values => ['3'] },
                     '=3' => { :op => '=', :values => ['3'] }},
                   'start_date' => {
                     '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
                     '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
                     '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
                     '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
                     '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
                     '<t+2' => { :op => '<t+', :values => ['2'] },
                     '>t+2' => { :op => '>t+', :values => ['2'] },
                     't+2' => { :op => 't+', :values => ['2'] },
                     't' => { :op => 't', :values => [''] },
                     'w' => { :op => 'w', :values => [''] },
                     '>t-2' => { :op => '>t-', :values => ['2'] },
                     '<t-2' => { :op => '<t-', :values => ['2'] },
                     't-2' => { :op => 't-', :values => ['2'] }},
                   'created_on' => {
                     '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
                     '<t+2' => { :op => '=', :values => ['<t+2'] },
                     '>t+2' => { :op => '=', :values => ['>t+2'] },
                     't+2' => { :op => 't', :values => ['+2'] }},
                   'cf_1' => {
                     'c' => { :op => '=', :values => ['c'] },
                     '!c' => { :op => '!', :values => ['c'] },
                     '!*' => { :op => '!*', :values => [''] },
                     '*' => { :op => '*', :values => [''] }},
                   'estimated_hours' => {
                     '=13.4' => { :op => '=', :values => ['13.4'] },
                     '>=45' => { :op => '>=', :values => ['45'] },
                     '<=125' => { :op => '<=', :values => ['125'] },
                     '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
                     '!*' => { :op => '!*', :values => [''] },
                     '*' => { :op => '*', :values => [''] }}
                 }
                 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
                 to_test.each do |field, expression_and_expected|
                   expression_and_expected.each do |filter_expression, expected|
                     get :index, :set_filter => 1, field => filter_expression
                     assert_response :success
                     assert_template 'index'
                     assert_not_nil assigns(:issues)
                     query = assigns(:query)
                     assert_not_nil query
                     assert query.has_filter?(field)
                     assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
                   end
                 end
               end
               def test_index_with_project_and_empty_filters
                 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 query = assigns(:query)
                 assert_not_nil query
                 # no filter
                 assert_equal({}, query.filters)
               end
               def test_index_with_query
                 get :index, :project_id => 1, :query_id => 5
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_nil assigns(:issue_count_by_group)
               end
               def test_index_with_query_grouped_by_tracker
                 get :index, :project_id => 1, :query_id => 6
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_not_nil assigns(:issue_count_by_group)
               end
               def test_index_with_query_grouped_by_list_custom_field
                 get :index, :project_id => 1, :query_id => 9
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues)
                 assert_not_nil assigns(:issue_count_by_group)
               end
               def test_index_with_query_id_and_project_id_should_set_session_query
                 get :index, :project_id => 1, :query_id => 4
                 assert_response :success
                 assert_kind_of Hash, session[:query]
                 assert_equal 4, session[:query][:id]
                 assert_equal 1, session[:query][:project_id]
               end
               def test_index_with_cross_project_query_in_session_should_show_project_issues
                 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
                 @request.session[:query] = {:id => q.id, :project_id => 1}
                 with_settings :display_subprojects_issues => '0' do
                   get :index, :project_id => 1
                 end
                 assert_response :success
                 assert_not_nil assigns(:query)
                 assert_equal q.id, assigns(:query).id
                 assert_equal 1, assigns(:query).project_id
                 assert_equal [1], assigns(:issues).map(&:project_id).uniq
               end
               def test_private_query_should_not_be_available_to_other_users
                 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
                 @request.session[:user_id] = 3
                 get :index, :query_id => q.id
                 assert_response 403
               end
               def test_private_query_should_be_available_to_its_user
                 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
                 @request.session[:user_id] = 2
                 get :index, :query_id => q.id
                 assert_response :success
               end
               def test_public_query_should_be_available_to_other_users
                 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
                 @request.session[:user_id] = 3
                 get :index, :query_id => q.id
                 assert_response :success
               end
               def test_index_csv
                 get :index, :format => 'csv'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
                 assert @response.body.starts_with?("#,")
                 lines = @response.body.chomp.split("\n")
                 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
               end
               def test_index_csv_with_project
                 get :index, :project_id => 1, :format => 'csv'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
               end
               def test_index_csv_with_description
                 get :index, :format => 'csv', :description => '1'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
                 assert @response.body.starts_with?("#,")
                 lines = @response.body.chomp.split("\n")
                 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
               end
               def test_index_csv_with_spent_time_column
                 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column')
                 TimeEntry.generate!(:project_id => issue.project_id, :issue_id => issue.id, :hours => 7.33)
                 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
                 assert_response :success
                 assert_equal 'text/csv', @response.content_type
                 lines = @response.body.chomp.split("\n")
                 assert_include "#{issue.id},#{issue.subject},7.33", lines
               end
               def test_index_csv_with_all_columns
                 get :index, :format => 'csv', :columns => 'all'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
                 assert @response.body.starts_with?("#,")
                 lines = @response.body.chomp.split("\n")
                 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
               end
               def test_index_csv_with_multi_column_field
                 CustomField.find(1).update_attribute :multiple, true
                 issue = Issue.find(1)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 get :index, :format => 'csv', :columns => 'all'
                 assert_response :success
                 lines = @response.body.chomp.split("\n")
                 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
               end
               def test_index_csv_big_5
                 with_settings :default_language => "zh-TW" do
                   str_utf8  = "\xe4\xb8\x80\xe6\x9c\x88"
                   str_big5  = "\xa4@\xa4\xeb"
                   if str_utf8.respond_to?(:force_encoding)
                     str_utf8.force_encoding('UTF-8')
                     str_big5.force_encoding('Big5')
                   end
                   issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                     :status_id => 1, :priority => IssuePriority.all.first,
                                     :subject => str_utf8)
                   assert issue.save
                   get :index, :project_id => 1,
                               :f => ['subject'],
                               :op => '=', :values => [str_utf8],
                               :format => 'csv'
                   assert_equal 'text/csv', @response.content_type
                   lines = @response.body.chomp.split("\n")
                   s1 = "\xaa\xac\xbaA"
                   if str_utf8.respond_to?(:force_encoding)
                     s1.force_encoding('Big5')
                   end
                   assert lines[0].include?(s1)
                   assert lines[1].include?(str_big5)
                 end
               end
               def test_index_csv_cannot_convert_should_be_replaced_big_5
                 with_settings :default_language => "zh-TW" do
                   str_utf8  = "\xe4\xbb\xa5\xe5\x86\x85"
                   if str_utf8.respond_to?(:force_encoding)
                     str_utf8.force_encoding('UTF-8')
                   end
                   issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                     :status_id => 1, :priority => IssuePriority.all.first,
                                     :subject => str_utf8)
                   assert issue.save
                   get :index, :project_id => 1,
                               :f => ['subject'],
                               :op => '=', :values => [str_utf8],
                               :c => ['status', 'subject'],
                               :format => 'csv',
                               :set_filter => 1
                   assert_equal 'text/csv', @response.content_type
                   lines = @response.body.chomp.split("\n")
                   s1 = "\xaa\xac\xbaA" # status
                   if str_utf8.respond_to?(:force_encoding)
                     s1.force_encoding('Big5')
                   end
                   assert lines[0].include?(s1)
                   s2 = lines[1].split(",")[2]
                   if s1.respond_to?(:force_encoding)
                     s3 = "\xa5H?" # subject
                     s3.force_encoding('Big5')
                     assert_equal s3, s2
                   elsif RUBY_PLATFORM == 'java'
                     assert_equal "??", s2
                   else
                     assert_equal "\xa5H???", s2
                   end
                 end
               end
               def test_index_csv_tw
                 with_settings :default_language => "zh-TW" do
                   str1  = "test_index_csv_tw"
                   issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                     :status_id => 1, :priority => IssuePriority.all.first,
                                     :subject => str1, :estimated_hours => '1234.5')
                   assert issue.save
                   assert_equal 1234.5, issue.estimated_hours
                   get :index, :project_id => 1,
                               :f => ['subject'],
                               :op => '=', :values => [str1],
                               :c => ['estimated_hours', 'subject'],
                               :format => 'csv',
                               :set_filter => 1
                   assert_equal 'text/csv', @response.content_type
                   lines = @response.body.chomp.split("\n")
                   assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
                   str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
                   if str_tw.respond_to?(:force_encoding)
                     str_tw.force_encoding('UTF-8')
                   end
                   assert_equal str_tw, l(:general_lang_name)
                   assert_equal ',', l(:general_csv_separator)
                   assert_equal '.', l(:general_csv_decimal_separator)
                 end
               end
               def test_index_csv_fr
                 with_settings :default_language => "fr" do
                   str1  = "test_index_csv_fr"
                   issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                     :status_id => 1, :priority => IssuePriority.all.first,
                                     :subject => str1, :estimated_hours => '1234.5')
                   assert issue.save
                   assert_equal 1234.5, issue.estimated_hours
                   get :index, :project_id => 1,
                               :f => ['subject'],
                               :op => '=', :values => [str1],
                               :c => ['estimated_hours', 'subject'],
                               :format => 'csv',
                               :set_filter => 1
                   assert_equal 'text/csv', @response.content_type
                   lines = @response.body.chomp.split("\n")
                   assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
                   str_fr = "Fran\xc3\xa7ais"
                   if str_fr.respond_to?(:force_encoding)
                     str_fr.force_encoding('UTF-8')
                   end
                   assert_equal str_fr, l(:general_lang_name)
                   assert_equal ';', l(:general_csv_separator)
                   assert_equal ',', l(:general_csv_decimal_separator)
                 end
               end
               def test_index_pdf
                 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
                   with_settings :default_language => lang do
                     get :index
                     assert_response :success
                     assert_template 'index'
                     if lang == "ja"
                       if RUBY_PLATFORM != 'java'
                         assert_equal "CP932", l(:general_pdf_encoding)
                       end
                       if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
                         next
                       end
                     end
                     get :index, :format => 'pdf'
                     assert_response :success
                     assert_not_nil assigns(:issues)
                     assert_equal 'application/pdf', @response.content_type
                     get :index, :project_id => 1, :format => 'pdf'
                     assert_response :success
                     assert_not_nil assigns(:issues)
                     assert_equal 'application/pdf', @response.content_type
                     get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
                     assert_response :success
                     assert_not_nil assigns(:issues)
                     assert_equal 'application/pdf', @response.content_type
                   end
                 end
               end
               def test_index_pdf_with_query_grouped_by_list_custom_field
                 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_not_nil assigns(:issue_count_by_group)
                 assert_equal 'application/pdf', @response.content_type
               end
               def test_index_sort
                 get :index, :sort => 'tracker,id:desc'
                 assert_response :success
                 sort_params = @request.session['issues_index_sort']
                 assert sort_params.is_a?(String)
                 assert_equal 'tracker,id:desc', sort_params
                 issues = assigns(:issues)
                 assert_not_nil issues
                 assert !issues.empty?
                 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
               end
               def test_index_sort_by_field_not_included_in_columns
                 Setting.issue_list_default_columns = %w(subject author)
                 get :index, :sort => 'tracker'
               end
               def test_index_sort_by_assigned_to
                 get :index, :sort => 'assigned_to'
                 assert_response :success
                 assignees = assigns(:issues).collect(&:assigned_to).compact
                 assert_equal assignees.sort, assignees
               end
               def test_index_sort_by_assigned_to_desc
                 get :index, :sort => 'assigned_to:desc'
                 assert_response :success
                 assignees = assigns(:issues).collect(&:assigned_to).compact
                 assert_equal assignees.sort.reverse, assignees
               end
               def test_index_group_by_assigned_to
                 get :index, :group_by => 'assigned_to', :sort => 'priority'
                 assert_response :success
               end
               def test_index_sort_by_author
                 get :index, :sort => 'author'
                 assert_response :success
                 authors = assigns(:issues).collect(&:author)
                 assert_equal authors.sort, authors
               end
               def test_index_sort_by_author_desc
                 get :index, :sort => 'author:desc'
                 assert_response :success
                 authors = assigns(:issues).collect(&:author)
                 assert_equal authors.sort.reverse, authors
               end
               def test_index_group_by_author
                 get :index, :group_by => 'author', :sort => 'priority'
                 assert_response :success
               end
               def test_index_sort_by_spent_hours
                 get :index, :sort => 'spent_hours:desc'
                 assert_response :success
                 hours = assigns(:issues).collect(&:spent_hours)
                 assert_equal hours.sort.reverse, hours
               end
               def test_index_with_columns
                 columns = ['tracker', 'subject', 'assigned_to']
                 get :index, :set_filter => 1, :c => columns
                 assert_response :success
                 # query should use specified columns
                 query = assigns(:query)
                 assert_kind_of Query, query
                 assert_equal columns, query.column_names.map(&:to_s)
                 # columns should be stored in session
                 assert_kind_of Hash, session[:query]
                 assert_kind_of Array, session[:query][:column_names]
                 assert_equal columns, session[:query][:column_names].map(&:to_s)
                 # ensure only these columns are kept in the selected columns list
                 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
                                              :children => { :count => 3 }
                 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
                                                 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
               end
               def test_index_without_project_should_implicitly_add_project_column_to_default_columns
                 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
                 get :index, :set_filter => 1
                 # query should use specified columns
                 query = assigns(:query)
                 assert_kind_of Query, query
                 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
               end
               def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
                 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
                 columns = ['tracker', 'subject', 'assigned_to']
                 get :index, :set_filter => 1, :c => columns
                 # query should use specified columns
                 query = assigns(:query)
                 assert_kind_of Query, query
                 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
               end
               def test_index_with_custom_field_column
                 columns = %w(tracker subject cf_2)
                 get :index, :set_filter => 1, :c => columns
                 assert_response :success
                 # query should use specified columns
                 query = assigns(:query)
                 assert_kind_of Query, query
                 assert_equal columns, query.column_names.map(&:to_s)
                 assert_tag :td,
                   :attributes => {:class => 'cf_2 string'},
                   :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
               end
               def test_index_with_multi_custom_field_column
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(1)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
                 assert_response :success
                 assert_tag :td,
                   :attributes => {:class => /cf_1/},
                   :content => 'MySQL, Oracle'
               end
               def test_index_with_multi_user_custom_field_column
                 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
                   :tracker_ids => [1], :is_for_all => true)
                 issue = Issue.find(1)
                 issue.custom_field_values = {field.id => ['2', '3']}
                 issue.save!
                 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
                 assert_response :success
                 assert_tag :td,
                   :attributes => {:class => /cf_#{field.id}/},
                   :child => {:tag => 'a', :content => 'John Smith'}
               end
               def test_index_with_date_column
                 Issue.find(1).update_attribute :start_date, '1987-08-24'
                 with_settings :date_format => '%d/%m/%Y' do
                   get :index, :set_filter => 1, :c => %w(start_date)
                   assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
                 end
               end
               def test_index_with_done_ratio
                 Issue.find(1).update_attribute :done_ratio, 40
                 get :index, :set_filter => 1, :c => %w(done_ratio)
                 assert_tag 'td', :attributes => {:class => /done_ratio/},
                   :child => {:tag => 'table', :attributes => {:class => 'progress'},
                     :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
                   }
               end
               def test_index_with_spent_hours_column
                 get :index, :set_filter => 1, :c => %w(subject spent_hours)
                 assert_tag 'tr', :attributes => {:id => 'issue-3'},
                   :child => {
                     :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
                   }
               end
               def test_index_should_not_show_spent_hours_column_without_permission
                 Role.anonymous.remove_permission! :view_time_entries
                 get :index, :set_filter => 1, :c => %w(subject spent_hours)
                 assert_no_tag 'td', :attributes => {:class => /spent_hours/}
               end
               def test_index_with_fixed_version
                 get :index, :set_filter => 1, :c => %w(fixed_version)
                 assert_tag 'td', :attributes => {:class => /fixed_version/},
                   :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
               end
               def test_index_send_html_if_query_is_invalid
                 get :index, :f => ['start_date'], :op => {:start_date => '='}
                 assert_equal 'text/html', @response.content_type
                 assert_template 'index'
               end
               def test_index_send_nothing_if_query_is_invalid
                 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
                 assert_equal 'text/csv', @response.content_type
                 assert @response.body.blank?
               end
               def test_show_by_anonymous
                 get :show, :id => 1
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:issue)
                 assert_equal Issue.find(1), assigns(:issue)
                 # anonymous role is allowed to add a note
                 assert_tag :tag => 'form',
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Notes/ } }
                 assert_tag :tag => 'title',
                   :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
               end
               def test_show_by_manager
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_tag :tag => 'a',
                   :content => /Quote/
                 assert_tag :tag => 'form',
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Change properties/ } },
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Log time/ } },
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Notes/ } }
               end
               def test_show_should_display_update_form
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_tag 'form', :attributes => {:id => 'issue-form'}
                 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
                 assert_tag 'textarea', :attributes => {:name => 'notes'}
               end
               def test_show_should_display_update_form_with_minimal_permissions
                 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
                 Workflow.delete_all :role_id => 1
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_tag 'form', :attributes => {:id => 'issue-form'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
                 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
                 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
                 assert_tag 'textarea', :attributes => {:name => 'notes'}
               end
               def test_show_should_display_update_form_with_workflow_permissions
                 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_tag 'form', :attributes => {:id => 'issue-form'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
                 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
                 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
                 assert_tag 'textarea', :attributes => {:name => 'notes'}
               end
               def test_show_should_not_display_update_form_without_permissions
                 Role.find(1).update_attribute :permissions, [:view_issues]
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_no_tag 'form', :attributes => {:id => 'issue-form'}
               end
               def test_update_form_should_not_display_inactive_enumerations
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert ! IssuePriority.find(15).active?
                 assert_no_tag :option, :attributes => {:value => '15'},
                                        :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
               end
               def test_update_form_should_allow_attachment_upload
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_tag :tag => 'form',
                   :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
                   :descendant => {
                     :tag => 'input',
                     :attributes => {:type => 'file', :name => 'attachments[1][file]'}
                   }
               end
               def test_show_should_deny_anonymous_access_without_permission
                 Role.anonymous.remove_permission!(:view_issues)
                 get :show, :id => 1
                 assert_response :redirect
               end
               def test_show_should_deny_anonymous_access_to_private_issue
                 Issue.update_all(["is_private = ?", true], "id = 1")
                 get :show, :id => 1
                 assert_response :redirect
               end
               def test_show_should_deny_non_member_access_without_permission
                 Role.non_member.remove_permission!(:view_issues)
                 @request.session[:user_id] = 9
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_deny_non_member_access_to_private_issue
                 Issue.update_all(["is_private = ?", true], "id = 1")
                 @request.session[:user_id] = 9
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_deny_member_access_without_permission
                 Role.find(1).remove_permission!(:view_issues)
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_deny_member_access_to_private_issue_without_permission
                 Issue.update_all(["is_private = ?", true], "id = 1")
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_allow_author_access_to_private_issue
                 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response :success
               end
               def test_show_should_allow_assignee_access_to_private_issue
                 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response :success
               end
               def test_show_should_allow_member_access_to_private_issue_with_permission
                 Issue.update_all(["is_private = ?", true], "id = 1")
                 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response :success
               end
               def test_show_should_not_disclose_relations_to_invisible_issues
                 Setting.cross_project_issue_relations = '1'
                 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
                 # Relation to a private project issue
                 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
                 get :show, :id => 1
                 assert_response :success
                 assert_tag :div, :attributes => { :id => 'relations' },
                                  :descendant => { :tag => 'a', :content => /#2$/ }
                 assert_no_tag :div, :attributes => { :id => 'relations' },
                                     :descendant => { :tag => 'a', :content => /#4$/ }
               end
               def test_show_should_list_subtasks
                 Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
                 get :show, :id => 1
                 assert_response :success
                 assert_tag 'div', :attributes => {:id => 'issue_tree'},
                   :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
               end
               def test_show_should_list_parents
                 issue = Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
                 get :show, :id => issue.id
                 assert_response :success
                 assert_tag 'div', :attributes => {:class => 'subject'},
                   :descendant => {:tag => 'h3', :content => 'Child Issue'}
                 assert_tag 'div', :attributes => {:class => 'subject'},
                   :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
               end
               def test_show_should_not_display_prev_next_links_without_query_in_session
                 get :show, :id => 1
                 assert_response :success
                 assert_nil assigns(:prev_issue_id)
                 assert_nil assigns(:next_issue_id)
                 assert_no_tag 'div', :attributes => {:class => /next-prev-links/}
               end
               def test_show_should_display_prev_next_links_with_query_in_session
                 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
                 @request.session['issues_index_sort'] = 'id'
                 with_settings :display_subprojects_issues => '0' do
                   get :show, :id => 3
                 end
                 assert_response :success
                 # Previous and next issues for all projects
                 assert_equal 2, assigns(:prev_issue_id)
                 assert_equal 5, assigns(:next_issue_id)
                 assert_tag 'div', :attributes => {:class => /next-prev-links/}
                 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
                 assert_tag 'a', :attributes => {:href => '/issues/5'}, :content => /Next/
                 count = Issue.open.visible.count
                 assert_tag 'span', :attributes => {:class => 'position'}, :content => "3 of #{count}"
               end
               def test_show_should_display_prev_next_links_with_saved_query_in_session
                 query = Query.create!(:name => 'test', :is_public => true,  :user_id => 1,
                   :filters => {'status_id' => {:values => ['5'], :operator => '='}},
                   :sort_criteria => [['id', 'asc']])
                 @request.session[:query] = {:id => query.id, :project_id => nil}
                 get :show, :id => 11
                 assert_response :success
                 assert_equal query, assigns(:query)
                 # Previous and next issues for all projects
                 assert_equal 8, assigns(:prev_issue_id)
                 assert_equal 12, assigns(:next_issue_id)
                 assert_tag 'a', :attributes => {:href => '/issues/8'}, :content => /Previous/
                 assert_tag 'a', :attributes => {:href => '/issues/12'}, :content => /Next/
               end
               def test_show_should_display_prev_next_links_with_query_and_sort_on_association
                 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
                 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
                   @request.session['issues_index_sort'] = assoc_sort
                   get :show, :id => 3
                   assert_response :success, "Wrong response status for #{assoc_sort} sort"
                   assert_tag 'a', :content => /Previous/
                   assert_tag 'a', :content => /Next/
                 end
               end
               def test_show_should_display_prev_next_links_with_project_query_in_session
                 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
                 @request.session['issues_index_sort'] = 'id'
                 with_settings :display_subprojects_issues => '0' do
                   get :show, :id => 3
                 end
                 assert_response :success
                 # Previous and next issues inside project
                 assert_equal 2, assigns(:prev_issue_id)
                 assert_equal 7, assigns(:next_issue_id)
                 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
                 assert_tag 'a', :attributes => {:href => '/issues/7'}, :content => /Next/
               end
               def test_show_should_not_display_prev_link_for_first_issue
                 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
                 @request.session['issues_index_sort'] = 'id'
                 with_settings :display_subprojects_issues => '0' do
                   get :show, :id => 1
                 end
                 assert_response :success
                 assert_nil assigns(:prev_issue_id)
                 assert_equal 2, assigns(:next_issue_id)
                 assert_no_tag 'a', :content => /Previous/
                 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Next/
               end
               def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
                 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
                 @request.session['issues_index_sort'] = 'id'
                 get :show, :id => 1
                 assert_response :success
                 assert_nil assigns(:prev_issue_id)
                 assert_nil assigns(:next_issue_id)
                 assert_no_tag 'a', :content => /Previous/
                 assert_no_tag 'a', :content => /Next/
               end
               def test_show_should_display_visible_changesets_from_other_projects
                 project = Project.find(2)
                 issue = project.issues.first
                 issue.changeset_ids = [102]
                 issue.save!
                 project.disable_module! :repository
                 @request.session[:user_id] = 2
                 get :show, :id => issue.id
                 assert_tag 'a', :attributes => {:href => "/projects/ecookbook/repository/revisions/3"}
               end
               def test_show_with_multi_custom_field
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(1)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 get :show, :id => 1
                 assert_response :success
                 assert_tag :td, :content => 'MySQL, Oracle'
               end
               def test_show_with_multi_user_custom_field
                 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
                   :tracker_ids => [1], :is_for_all => true)
                 issue = Issue.find(1)
                 issue.custom_field_values = {field.id => ['2', '3']}
                 issue.save!
                 get :show, :id => 1
                 assert_response :success
                 # TODO: should display links
                 assert_tag :td, :content => 'Dave Lopper, John Smith'
               end
               def test_show_atom
                 get :show, :id => 2, :format => 'atom'
                 assert_response :success
                 assert_template 'journals/index'
                 # Inline image
                 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
               end
               def test_show_export_to_pdf
                 get :show, :id => 3, :format => 'pdf'
                 assert_response :success
                 assert_equal 'application/pdf', @response.content_type
                 assert @response.body.starts_with?('%PDF')
                 assert_not_nil assigns(:issue)
               end
               def test_get_new
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
                 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
                 # Be sure we don't display inactive IssuePriorities
                 assert ! IssuePriority.find(15).active?
                 assert_no_tag :option, :attributes => {:value => '15'},
                                        :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
               end
               def test_get_new_with_minimal_permissions
                 Role.find(1).update_attribute :permissions, [:add_issues]
                 Workflow.delete_all :role_id => 1
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
                 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
               end
               def test_get_new_with_multi_custom_field
                 field = IssueCustomField.find(1)
                 field.update_attribute :multiple, true
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag 'select',
                   :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'},
                   :children => {:count => 3},
                   :child => {:tag => 'option', :attributes => {:value => 'MySQL'}, :content => 'MySQL'}
                 assert_tag 'input',
                   :attributes => {:name => 'issue[custom_field_values][1][]', :value => ''}
               end
               def test_get_new_with_multi_user_custom_field
                 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
                   :tracker_ids => [1], :is_for_all => true)
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag 'select',
                   :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :multiple => 'multiple'},
                   :children => {:count => Project.find(1).users.count},
                   :child => {:tag => 'option', :attributes => {:value => '2'}, :content => 'John Smith'}
                 assert_tag 'input',
                   :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :value => ''}
               end
               def test_get_new_without_default_start_date_is_creation_date
                 Setting.default_issue_start_date_to_creation_date = 0
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
                                                              :value => nil }
               end
               def test_get_new_with_default_start_date_is_creation_date
                 Setting.default_issue_start_date_to_creation_date = 1
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
                                                              :value => Date.today.to_s }
               end
               def test_get_new_form_should_allow_attachment_upload
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_tag :tag => 'form',
                   :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
                   :descendant => {
                     :tag => 'input',
                     :attributes => {:type => 'file', :name => 'attachments[1][file]'}
                   }
               end
               def test_get_new_without_tracker_id
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1
                 assert_response :success
                 assert_template 'new'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_equal Project.find(1).trackers.first, issue.tracker
               end
               def test_get_new_with_no_default_status_should_display_an_error
                 @request.session[:user_id] = 2
                 IssueStatus.delete_all
                 get :new, :project_id => 1
                 assert_response 500
                 assert_error_tag :content => /No default issue/
               end
               def test_get_new_with_no_tracker_should_display_an_error
                 @request.session[:user_id] = 2
                 Tracker.delete_all
                 get :new, :project_id => 1
                 assert_response 500
                 assert_error_tag :content => /No tracker/
               end
               def test_update_new_form
                 @request.session[:user_id] = 2
                 xhr :post, :new, :project_id => 1,
                                  :issue => {:tracker_id => 2,
                                             :subject => 'This is the test_new issue',
                                             :description => 'This is the description',
                                             :priority_id => 5}
                 assert_response :success
                 assert_template 'attributes'
                 issue = assigns(:issue)
                 assert_kind_of Issue, issue
                 assert_equal 1, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 'This is the test_new issue', issue.subject
               end
               def test_post_create
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 3,
                                         :status_id => 2,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :start_date => '2010-11-07',
                                         :estimated_hours => '',
                                         :custom_field_values => {'2' => 'Value for field 2'}}
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                 issue = Issue.find_by_subject('This is the test_new issue')
                 assert_not_nil issue
                 assert_equal 2, issue.author_id
                 assert_equal 3, issue.tracker_id
                 assert_equal 2, issue.status_id
                 assert_equal Date.parse('2010-11-07'), issue.start_date
                 assert_nil issue.estimated_hours
                 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
                 assert_not_nil v
                 assert_equal 'Value for field 2', v.value
               end
               def test_post_new_with_group_assignment
                 group = Group.find(11)
                 project = Project.find(1)
                 project.members << Member.new(:principal => group, :roles => [Role.first])
                 with_settings :issue_group_assignment => '1' do
                   @request.session[:user_id] = 2
                   assert_difference 'Issue.count' do
                     post :create, :project_id => project.id,
                                   :issue => {:tracker_id => 3,
                                              :status_id => 1,
                                              :subject => 'This is the test_new_with_group_assignment issue',
                                              :assigned_to_id => group.id}
                   end
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
                 assert_not_nil issue
                 assert_equal group, issue.assigned_to
               end
               def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
                 Setting.default_issue_start_date_to_creation_date = 0
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 3,
                                         :status_id => 2,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :estimated_hours => '',
                                         :custom_field_values => {'2' => 'Value for field 2'}}
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                 issue = Issue.find_by_subject('This is the test_new issue')
                 assert_not_nil issue
                 assert_nil issue.start_date
               end
               def test_post_create_without_start_date_and_default_start_date_is_creation_date
                 Setting.default_issue_start_date_to_creation_date = 1
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 3,
                                         :status_id => 2,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :estimated_hours => '',
                                         :custom_field_values => {'2' => 'Value for field 2'}}
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                 issue = Issue.find_by_subject('This is the test_new issue')
                 assert_not_nil issue
                 assert_equal Date.today, issue.start_date
               end
               def test_post_create_and_continue
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                     :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
                     :continue => ''
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
                 assert_not_nil flash[:notice], "flash was not set"
                 assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
               end
               def test_post_create_without_custom_fields_param
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5}
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
               end
               def test_post_create_with_multi_custom_field
                 field = IssueCustomField.find_by_name('Database')
                 field.update_attribute(:multiple, true)
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
                 end
                 assert_response 302
                 issue = Issue.first(:order => 'id DESC')
                 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
               end
               def test_post_create_with_empty_multi_custom_field
                 field = IssueCustomField.find_by_name('Database')
                 field.update_attribute(:multiple, true)
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :custom_field_values => {'1' => ['']}}
                 end
                 assert_response 302
                 issue = Issue.first(:order => 'id DESC')
                 assert_equal [''], issue.custom_field_value(1).sort
               end
               def test_post_create_with_multi_user_custom_field
                 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
                   :tracker_ids => [1], :is_for_all => true)
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :custom_field_values => {field.id.to_s => ['', '2', '3']}}
                 end
                 assert_response 302
                 issue = Issue.first(:order => 'id DESC')
                 assert_equal ['2', '3'], issue.custom_field_value(field).sort
               end
               def test_post_create_with_required_custom_field_and_without_custom_fields_param
                 field = IssueCustomField.find_by_name('Database')
                 field.update_attribute(:is_required, true)
                 @request.session[:user_id] = 2
                 assert_no_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5}
                 end
                 assert_response :success
                 assert_template 'new'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_error_tag :content => /Database can't be blank/
               end
               def test_post_create_with_watchers
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 assert_difference 'Watcher.count', 2 do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a new issue with watchers',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :watcher_user_ids => ['2', '3']}
                 end
                 issue = Issue.find_by_subject('This is a new issue with watchers')
                 assert_not_nil issue
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
                 # Watchers added
                 assert_equal [2, 3], issue.watcher_user_ids.sort
                 assert issue.watched_by?(User.find(3))
                 # Watchers notified
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
               end
               def test_post_create_subissue
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a child issue',
                                         :parent_issue_id => 2}
                 end
                 issue = Issue.find_by_subject('This is a child issue')
                 assert_not_nil issue
                 assert_equal Issue.find(2), issue.parent
               end
               def test_post_create_subissue_with_non_numeric_parent_id
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a child issue',
                                         :parent_issue_id => 'ABC'}
                 end
                 issue = Issue.find_by_subject('This is a child issue')
                 assert_not_nil issue
                 assert_nil issue.parent
               end
               def test_post_create_private
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a private issue',
                                         :is_private => '1'}
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert issue.is_private?
               end
               def test_post_create_private_with_set_own_issues_private_permission
                 role = Role.find(1)
                 role.remove_permission! :set_issues_private
                 role.add_permission! :set_own_issues_private
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a private issue',
                                         :is_private => '1'}
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert issue.is_private?
               end
               def test_post_create_should_send_a_notification
                 ActionMailer::Base.deliveries.clear
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1,
                              :issue => {:tracker_id => 3,
                                         :subject => 'This is the test_new issue',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :estimated_hours => '',
                                         :custom_field_values => {'2' => 'Value for field 2'}}
                 end
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                 assert_equal 1, ActionMailer::Base.deliveries.size
               end
               def test_post_create_should_preserve_fields_values_on_validation_failure
                 @request.session[:user_id] = 2
                 post :create, :project_id => 1,
                            :issue => {:tracker_id => 1,
                                       # empty subject
                                       :subject => '',
                                       :description => 'This is a description',
                                       :priority_id => 6,
                                       :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
                 assert_response :success
                 assert_template 'new'
                 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                                       :content => 'This is a description'
                 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                     :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                    :value => '6' },
                                                                   :content => 'High' }
                 # Custom fields
                 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                                     :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                    :value => 'Oracle' },
                                                                   :content => 'Oracle' }
                 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                                     :value => 'Value for field 2'}
               end
               def test_post_create_should_ignore_non_safe_attributes
                 @request.session[:user_id] = 2
                 assert_nothing_raised do
                   post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
                 end
               end
               def test_post_create_with_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   assert_difference 'Attachment.count' do
                     post :create, :project_id => 1,
                       :issue => { :tracker_id => '1', :subject => 'With attachment' },
                       :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
                   end
                 end
                 issue = Issue.first(:order => 'id DESC')
                 attachment = Attachment.first(:order => 'id DESC')
                 assert_equal issue, attachment.container
                 assert_equal 2, attachment.author_id
                 assert_equal 'testfile.txt', attachment.filename
                 assert_equal 'text/plain', attachment.content_type
                 assert_equal 'test file', attachment.description
                 assert_equal 59, attachment.filesize
                 assert File.exists?(attachment.diskfile)
                 assert_equal 59, File.size(attachment.diskfile)
               end
+              def test_post_create_with_failure_should_save_attachments
+                set_tmp_attachments_directory
+                @request.session[:user_id] = 2
+                assert_no_difference 'Issue.count' do
+                  assert_difference 'Attachment.count' do
+                    post :create, :project_id => 1,
+                      :issue => { :tracker_id => '1', :subject => '' },
+                      :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
+                    assert_response :success
+                    assert_template 'new'
+                  end
+                end
+                attachment = Attachment.first(:order => 'id DESC')
+                assert_equal 'testfile.txt', attachment.filename
+                assert File.exists?(attachment.diskfile)
+                assert_nil attachment.container
+                assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
+                assert_tag 'span', :content => /testfile.txt/
+              end
+              def test_post_create_with_failure_should_keep_saved_attachments
+                set_tmp_attachments_directory
+                attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
+                @request.session[:user_id] = 2
+                assert_no_difference 'Issue.count' do
+                  assert_no_difference 'Attachment.count' do
+                    post :create, :project_id => 1,
+                      :issue => { :tracker_id => '1', :subject => '' },
+                      :attachments => {'p0' => {'token' => attachment.token}}
+                    assert_response :success
+                    assert_template 'new'
+                  end
+                end
+                assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
+                assert_tag 'span', :content => /testfile.txt/
+              end
+              def test_post_create_should_attach_saved_attachments
+                set_tmp_attachments_directory
+                attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
+                @request.session[:user_id] = 2
+                assert_difference 'Issue.count' do
+                  assert_no_difference 'Attachment.count' do
+                    post :create, :project_id => 1,
+                      :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
+                      :attachments => {'p0' => {'token' => attachment.token}}
+                    assert_response 302
+                  end
+                end
+                issue = Issue.first(:order => 'id DESC')
+                assert_equal 1, issue.attachments.count
+                attachment.reload
+                assert_equal issue, attachment.container
+              end
               context "without workflow privilege" do
                 setup do
                   Workflow.delete_all(["role_id = ?", Role.anonymous.id])
                   Role.anonymous.add_permission! :add_issues, :add_issue_notes
                 end
                 context "#new" do
                   should "propose default status only" do
                     get :new, :project_id => 1
                     assert_response :success
                     assert_template 'new'
                     assert_tag :tag => 'select',
                       :attributes => {:name => 'issue[status_id]'},
                       :children => {:count => 1},
                       :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
                   end
                   should "accept default status" do
                     assert_difference 'Issue.count' do
                       post :create, :project_id => 1,
                                  :issue => {:tracker_id => 1,
                                             :subject => 'This is an issue',
                                             :status_id => 1}
                     end
                     issue = Issue.last(:order => 'id')
                     assert_equal IssueStatus.default, issue.status
                   end
                   should "ignore unauthorized status" do
                     assert_difference 'Issue.count' do
                       post :create, :project_id => 1,
                                  :issue => {:tracker_id => 1,
                                             :subject => 'This is an issue',
                                             :status_id => 3}
                     end
                     issue = Issue.last(:order => 'id')
                     assert_equal IssueStatus.default, issue.status
                   end
                 end
                 context "#update" do
                   should "ignore status change" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                     end
                     assert_equal 1, Issue.find(1).status_id
                   end
                   should "ignore attributes changes" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
                     end
                     issue = Issue.find(1)
                     assert_equal "Can't print recipes", issue.subject
                     assert_nil issue.assigned_to
                   end
                 end
               end
               context "with workflow privilege" do
                 setup do
                   Workflow.delete_all(["role_id = ?", Role.anonymous.id])
                   Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
                   Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
                   Role.anonymous.add_permission! :add_issues, :add_issue_notes
                 end
                 context "#update" do
                   should "accept authorized status" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                     end
                     assert_equal 3, Issue.find(1).status_id
                   end
                   should "ignore unauthorized status" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
                     end
                     assert_equal 1, Issue.find(1).status_id
                   end
                   should "accept authorized attributes changes" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
                     end
                     issue = Issue.find(1)
                     assert_equal 2, issue.assigned_to_id
                   end
                   should "ignore unauthorized attributes changes" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
                     end
                     issue = Issue.find(1)
                     assert_equal "Can't print recipes", issue.subject
                   end
                 end
                 context "and :edit_issues permission" do
                   setup do
                     Role.anonymous.add_permission! :add_issues, :edit_issues
                   end
                   should "accept authorized status" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                     end
                     assert_equal 3, Issue.find(1).status_id
                   end
                   should "ignore unauthorized status" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
                     end
                     assert_equal 1, Issue.find(1).status_id
                   end
                   should "accept authorized attributes changes" do
                     assert_difference 'Journal.count' do
                       put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
                     end
                     issue = Issue.find(1)
                     assert_equal "changed", issue.subject
                     assert_equal 2, issue.assigned_to_id
                   end
                 end
               end
               def test_new_as_copy
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :copy_from => 1
                 assert_response :success
                 assert_template 'new'
                 assert_not_nil assigns(:issue)
                 orig = Issue.find(1)
                 assert_equal 1, assigns(:issue).project_id
                 assert_equal orig.subject, assigns(:issue).subject
                 assert assigns(:issue).copy?
                 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
                   :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}, :content => 'eCookbook'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
                   :child => {:tag => 'option', :attributes => {:value => '2', :selected => nil}, :content => 'OnlineStore'}
                 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
               end
               def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
                 @request.session[:user_id] = 2
                 issue = Issue.find(3)
                 assert issue.attachments.count > 0
                 get :new, :project_id => 1, :copy_from => 3
                 assert_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
               end
               def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
                 @request.session[:user_id] = 2
                 issue = Issue.find(3)
                 issue.attachments.delete_all
                 get :new, :project_id => 1, :copy_from => 3
                 assert_no_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
               end
               def test_new_as_copy_with_invalid_issue_should_respond_with_404
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :copy_from => 99999
                 assert_response 404
               end
               def test_create_as_copy_on_different_project
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1, :copy_from => 1,
                     :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
                   assert_not_nil assigns(:issue)
                   assert assigns(:issue).copy?
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert_redirected_to "/issues/#{issue.id}"
                 assert_equal 2, issue.project_id
                 assert_equal 3, issue.tracker_id
                 assert_equal 'Copy', issue.subject
               end
               def test_create_as_copy_should_copy_attachments
                 @request.session[:user_id] = 2
                 issue = Issue.find(3)
                 count = issue.attachments.count
                 assert count > 0
                 assert_difference 'Issue.count' do
                   assert_difference 'Attachment.count', count do
                     assert_no_difference 'Journal.count' do
                       post :create, :project_id => 1, :copy_from => 3,
                         :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
                         :copy_attachments => '1'
                     end
                   end
                 end
                 copy = Issue.first(:order => 'id DESC')
                 assert_equal count, copy.attachments.count
                 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
               end
               def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
                 @request.session[:user_id] = 2
                 issue = Issue.find(3)
                 count = issue.attachments.count
                 assert count > 0
                 assert_difference 'Issue.count' do
                   assert_no_difference 'Attachment.count' do
                     assert_no_difference 'Journal.count' do
                       post :create, :project_id => 1, :copy_from => 3,
                         :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
                     end
                   end
                 end
                 copy = Issue.first(:order => 'id DESC')
                 assert_equal 0, copy.attachments.count
               end
               def test_create_as_copy_with_attachments_should_add_new_files
                 @request.session[:user_id] = 2
                 issue = Issue.find(3)
                 count = issue.attachments.count
                 assert count > 0
                 assert_difference 'Issue.count' do
                   assert_difference 'Attachment.count', count + 1 do
                     assert_no_difference 'Journal.count' do
                       post :create, :project_id => 1, :copy_from => 3,
                         :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
                         :copy_attachments => '1',
                         :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
                     end
                   end
                 end
                 copy = Issue.first(:order => 'id DESC')
                 assert_equal count + 1, copy.attachments.count
               end
               def test_create_as_copy_with_failure
                 @request.session[:user_id] = 2
                 post :create, :project_id => 1, :copy_from => 1,
                   :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
                 assert_response :success
                 assert_template 'new'
                 assert_not_nil assigns(:issue)
                 assert assigns(:issue).copy?
                 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
                   :child => {:tag => 'option', :attributes => {:value => '1', :selected => nil}, :content => 'eCookbook'}
                 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
                   :child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}, :content => 'OnlineStore'}
                 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
               end
               def test_create_as_copy_on_project_without_permission_should_ignore_target_project
                 @request.session[:user_id] = 2
                 assert !User.find(2).member_of?(Project.find(4))
                 assert_difference 'Issue.count' do
                   post :create, :project_id => 1, :copy_from => 1,
                     :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert_equal 1, issue.project_id
               end
               def test_get_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
                 assert_not_nil assigns(:issue)
                 assert_equal Issue.find(1), assigns(:issue)
                 # Be sure we don't display inactive IssuePriorities
                 assert ! IssuePriority.find(15).active?
                 assert_no_tag :option, :attributes => {:value => '15'},
                                        :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
               end
               def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
                 @request.session[:user_id] = 2
                 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
                 get :edit, :id => 1
                 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
               end
               def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
                 @request.session[:user_id] = 2
                 Role.find_by_name('Manager').remove_permission! :log_time
                 get :edit, :id => 1
                 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
               end
               def test_get_edit_with_params
                 @request.session[:user_id] = 2
                 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
                     :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
                 assert_response :success
                 assert_template 'edit'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_equal 5, issue.status_id
                 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                                     :child => { :tag => 'option',
                                                 :content => 'Closed',
                                                 :attributes => { :selected => 'selected' } }
                 assert_equal 7, issue.priority_id
                 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                     :child => { :tag => 'option',
                                                 :content => 'Urgent',
                                                 :attributes => { :selected => 'selected' } }
                 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
                 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
                                     :child => { :tag => 'option',
                                                 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
                 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
               end
               def test_get_edit_with_multi_custom_field
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(1)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 @request.session[:user_id] = 2
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
                 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'}
                 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
                   :child => {:tag => 'option', :attributes => {:value => 'MySQL', :selected => 'selected'}}
                 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
                   :child => {:tag => 'option', :attributes => {:value => 'PostgreSQL', :selected => nil}}
                 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
                   :child => {:tag => 'option', :attributes => {:value => 'Oracle', :selected => 'selected'}}
               end
               def test_update_edit_form
                 @request.session[:user_id] = 2
                 xhr :put, :new, :project_id => 1,
                                          :id => 1,
                                          :issue => {:tracker_id => 2,
                                                     :subject => 'This is the test_new issue',
                                                     :description => 'This is the description',
                                                     :priority_id => 5}
                 assert_response :success
                 assert_template 'attributes'
                 issue = assigns(:issue)
                 assert_kind_of Issue, issue
                 assert_equal 1, issue.id
                 assert_equal 1, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 'This is the test_new issue', issue.subject
               end
               def test_update_edit_form_with_project_change
                 @request.session[:user_id] = 2
                 xhr :put, :new, :project_id => 1,
                                          :id => 1,
                                          :project_change => '1',
                                          :issue => {:project_id => 2,
                                                     :tracker_id => 2,
                                                     :subject => 'This is the test_new issue',
                                                     :description => 'This is the description',
                                                     :priority_id => 5}
                 assert_response :success
                 assert_template 'form'
                 issue = assigns(:issue)
                 assert_kind_of Issue, issue
                 assert_equal 1, issue.id
                 assert_equal 2, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 'This is the test_new issue', issue.subject
               end
               def test_update_using_invalid_http_verbs
                 @request.session[:user_id] = 2
                 subject = 'Updated by an invalid http verb'
                 get :update, :id => 1, :issue => {:subject => subject}
                 assert_not_equal subject, Issue.find(1).subject
                 post :update, :id => 1, :issue => {:subject => subject}
                 assert_not_equal subject, Issue.find(1).subject
                 delete :update, :id => 1, :issue => {:subject => subject}
                 assert_not_equal subject, Issue.find(1).subject
               end
               def test_put_update_without_custom_fields_param
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 issue = Issue.find(1)
                 assert_equal '125', issue.custom_value_for(2).value
                 old_subject = issue.subject
                 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 2) do
                     put :update, :id => 1, :issue => {:subject => new_subject,
                                                      :priority_id => '6',
                                                      :category_id => '1' # no change
                                                     }
                   end
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue.reload
                 assert_equal new_subject, issue.subject
                 # Make sure custom fields were not cleared
                 assert_equal '125', issue.custom_value_for(2).value
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
               end
               def test_put_update_with_project_change
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 3) do
                     put :update, :id => 1, :issue => {:project_id => '2',
                                                      :tracker_id => '1', # no change
                                                      :priority_id => '6',
                                                      :category_id => '3'
                                                     }
                   end
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue = Issue.find(1)
                 assert_equal 2, issue.project_id
                 assert_equal 1, issue.tracker_id
                 assert_equal 6, issue.priority_id
                 assert_equal 3, issue.category_id
                 mail = ActionMailer::Base.deliveries.last
                 assert_not_nil mail
                 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                 assert mail.body.include?("Project changed from eCookbook to OnlineStore")
               end
               def test_put_update_with_tracker_change
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 2) do
                     put :update, :id => 1, :issue => {:project_id => '1',
                                                      :tracker_id => '2',
                                                      :priority_id => '6'
                                                     }
                   end
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue = Issue.find(1)
                 assert_equal 1, issue.project_id
                 assert_equal 2, issue.tracker_id
                 assert_equal 6, issue.priority_id
                 assert_equal 1, issue.category_id
                 mail = ActionMailer::Base.deliveries.last
                 assert_not_nil mail
                 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                 assert mail.body.include?("Tracker changed from Bug to Feature request")
               end
               def test_put_update_with_custom_field_change
                 @request.session[:user_id] = 2
                 issue = Issue.find(1)
                 assert_equal '125', issue.custom_value_for(2).value
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 3) do
                     put :update, :id => 1, :issue => {:subject => 'Custom field change',
                                                      :priority_id => '6',
                                                      :category_id => '1', # no change
                                                      :custom_field_values => { '2' => 'New custom value' }
                                                     }
                   end
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue.reload
                 assert_equal 'New custom value', issue.custom_value_for(2).value
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert mail.body.include?("Searchable field changed from 125 to New custom value")
               end
               def test_put_update_with_multi_custom_field_change
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 issue = Issue.find(1)
                 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
                 issue.save!
                 @request.session[:user_id] = 2
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 3) do
                     put :update, :id => 1,
                       :issue => {
                         :subject => 'Custom field change',
                         :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
                       }
                   end
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
               end
               def test_put_update_with_status_and_assignee_change
                 issue = Issue.find(1)
                 assert_equal 1, issue.status_id
                 @request.session[:user_id] = 2
                 assert_difference('TimeEntry.count', 0) do
                   put :update,
                        :id => 1,
                        :issue => { :status_id => 2, :assigned_to_id => 3 },
                        :notes => 'Assigned to dlopper',
                        :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue.reload
                 assert_equal 2, issue.status_id
                 j = Journal.find(:first, :order => 'id DESC')
                 assert_equal 'Assigned to dlopper', j.notes
                 assert_equal 2, j.details.size
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?("Status changed from New to Assigned")
                 # subject should contain the new status
                 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
               end
               def test_put_update_with_note_only
                 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
                 # anonymous user
                 put :update,
                      :id => 1,
                      :notes => notes
                 assert_redirected_to :action => 'show', :id => '1'
                 j = Journal.find(:first, :order => 'id DESC')
                 assert_equal notes, j.notes
                 assert_equal 0, j.details.size
                 assert_equal User.anonymous, j.user
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?(notes)
               end
               def test_put_update_with_note_and_spent_time
                 @request.session[:user_id] = 2
                 spent_hours_before = Issue.find(1).spent_hours
                 assert_difference('TimeEntry.count') do
                   put :update,
                        :id => 1,
                        :notes => '2.5 hours added',
                        :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 issue = Issue.find(1)
                 j = Journal.find(:first, :order => 'id DESC')
                 assert_equal '2.5 hours added', j.notes
                 assert_equal 0, j.details.size
                 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
                 assert_not_nil t
                 assert_equal 2.5, t.hours
                 assert_equal spent_hours_before + 2.5, issue.spent_hours
               end
               def test_put_update_with_attachment_only
                 set_tmp_attachments_directory
                 # Delete all fixtured journals, a race condition can occur causing the wrong
                 # journal to get fetched in the next find.
                 Journal.delete_all
                 # anonymous user
                 assert_difference 'Attachment.count' do
                   put :update, :id => 1,
                     :notes => '',
                     :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
                 end
                 assert_redirected_to :action => 'show', :id => '1'
                 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
                 assert j.notes.blank?
                 assert_equal 1, j.details.size
                 assert_equal 'testfile.txt', j.details.first.value
                 assert_equal User.anonymous, j.user
                 attachment = Attachment.first(:order => 'id DESC')
                 assert_equal Issue.find(1), attachment.container
                 assert_equal User.anonymous, attachment.author
                 assert_equal 'testfile.txt', attachment.filename
                 assert_equal 'text/plain', attachment.content_type
                 assert_equal 'test file', attachment.description
                 assert_equal 59, attachment.filesize
                 assert File.exists?(attachment.diskfile)
                 assert_equal 59, File.size(attachment.diskfile)
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?('testfile.txt')
               end
+              def test_put_update_with_failure_should_save_attachments
+                set_tmp_attachments_directory
+                @request.session[:user_id] = 2
+                assert_no_difference 'Journal.count' do
+                  assert_difference 'Attachment.count' do
+                    put :update, :id => 1,
+                      :issue => { :subject => '' },
+                      :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
+                    assert_response :success
+                    assert_template 'edit'
+                  end
+                end
+                attachment = Attachment.first(:order => 'id DESC')
+                assert_equal 'testfile.txt', attachment.filename
+                assert File.exists?(attachment.diskfile)
+                assert_nil attachment.container
+                assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
+                assert_tag 'span', :content => /testfile.txt/
+              end
+              def test_put_update_with_failure_should_keep_saved_attachments
+                set_tmp_attachments_directory
+                attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
+                @request.session[:user_id] = 2
+                assert_no_difference 'Journal.count' do
+                  assert_no_difference 'Attachment.count' do
+                    put :update, :id => 1,
+                      :issue => { :subject => '' },
+                      :attachments => {'p0' => {'token' => attachment.token}}
+                    assert_response :success
+                    assert_template 'edit'
+                  end
+                end
+                assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
+                assert_tag 'span', :content => /testfile.txt/
+              end
+              def test_put_update_should_attach_saved_attachments
+                set_tmp_attachments_directory
+                attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
+                @request.session[:user_id] = 2
+                assert_difference 'Journal.count' do
+                  assert_difference 'JournalDetail.count' do
+                    assert_no_difference 'Attachment.count' do
+                      put :update, :id => 1,
+                        :notes => 'Attachment added',
+                        :attachments => {'p0' => {'token' => attachment.token}}
+                      assert_redirected_to '/issues/1'
+                    end
+                  end
+                end
+                attachment.reload
+                assert_equal Issue.find(1), attachment.container
+                journal = Journal.first(:order => 'id DESC')
+                assert_equal 1, journal.details.size
+                assert_equal 'testfile.txt', journal.details.first.value
+              end
               def test_put_update_with_attachment_that_fails_to_save
                 set_tmp_attachments_directory
                 # Delete all fixtured journals, a race condition can occur causing the wrong
                 # journal to get fetched in the next find.
                 Journal.delete_all
                 # Mock out the unsaved attachment
                 Attachment.any_instance.stubs(:create).returns(Attachment.new)
                 # anonymous user
                 put :update,
                      :id => 1,
                      :notes => '',
                      :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
                 assert_redirected_to :action => 'show', :id => '1'
                 assert_equal '1 file(s) could not be saved.', flash[:warning]
               end
               def test_put_update_with_no_change
                 issue = Issue.find(1)
                 issue.journals.clear
                 ActionMailer::Base.deliveries.clear
                 put :update,
                      :id => 1,
                      :notes => ''
                 assert_redirected_to :action => 'show', :id => '1'
                 issue.reload
                 assert issue.journals.empty?
                 # No email should be sent
                 assert ActionMailer::Base.deliveries.empty?
               end
               def test_put_update_should_send_a_notification
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 issue = Issue.find(1)
                 old_subject = issue.subject
                 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                 put :update, :id => 1, :issue => {:subject => new_subject,
                                                  :priority_id => '6',
                                                  :category_id => '1' # no change
                                                 }
                 assert_equal 1, ActionMailer::Base.deliveries.size
               end
               def test_put_update_with_invalid_spent_time_hours_only
                 @request.session[:user_id] = 2
                 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                 assert_no_difference('Journal.count') do
                   put :update,
                        :id => 1,
                        :notes => notes,
                        :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
                 end
                 assert_response :success
                 assert_template 'edit'
                 assert_error_tag :descendant => {:content => /Activity can't be blank/}
                 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
                 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
               end
               def test_put_update_with_invalid_spent_time_comments_only
                 @request.session[:user_id] = 2
                 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                 assert_no_difference('Journal.count') do
                   put :update,
                        :id => 1,
                        :notes => notes,
                        :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
                 end
                 assert_response :success
                 assert_template 'edit'
                 assert_error_tag :descendant => {:content => /Activity can't be blank/}
                 assert_error_tag :descendant => {:content => /Hours can't be blank/}
                 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
                 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
               end
               def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
                 issue = Issue.find(2)
                 @request.session[:user_id] = 2
                 put :update,
                      :id => issue.id,
                      :issue => {
                        :fixed_version_id => 4
                      }
                 assert_response :redirect
                 issue.reload
                 assert_equal 4, issue.fixed_version_id
                 assert_not_equal issue.project_id, issue.fixed_version.project_id
               end
               def test_put_update_should_redirect_back_using_the_back_url_parameter
                 issue = Issue.find(2)
                 @request.session[:user_id] = 2
                 put :update,
                      :id => issue.id,
                      :issue => {
                        :fixed_version_id => 4
                      },
                      :back_url => '/issues'
                 assert_response :redirect
                 assert_redirected_to '/issues'
               end
               def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                 issue = Issue.find(2)
                 @request.session[:user_id] = 2
                 put :update,
                      :id => issue.id,
                      :issue => {
                        :fixed_version_id => 4
                      },
                      :back_url => 'http://google.com'
                 assert_response :redirect
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
               end
               def test_get_bulk_edit
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 assert_template 'bulk_edit'
                 assert_tag :select, :attributes => {:name => 'issue[project_id]'}
                 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
                 # Project specific custom field, date type
                 field = CustomField.find(9)
                 assert !field.is_for_all?
                 assert_equal 'date', field.field_format
                 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
                 # System wide custom field
                 assert CustomField.find(1).is_for_all?
                 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
                 # Be sure we don't display inactive IssuePriorities
                 assert ! IssuePriority.find(15).active?
                 assert_no_tag :option, :attributes => {:value => '15'},
                                        :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
               end
               def test_get_bulk_edit_on_different_projects
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2, 6]
                 assert_response :success
                 assert_template 'bulk_edit'
                 # Can not set issues from different projects as children of an issue
                 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
                 # Project specific custom field, date type
                 field = CustomField.find(9)
                 assert !field.is_for_all?
                 assert !field.project_ids.include?(Issue.find(6).project_id)
                 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
               end
               def test_get_bulk_edit_with_user_custom_field
                 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 assert_template 'bulk_edit'
                 assert_tag :select,
                   :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
                   :children => {
                     :only => {:tag => 'option'},
                     :count => Project.find(1).users.count + 1
                   }
               end
               def test_get_bulk_edit_with_version_custom_field
                 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 assert_template 'bulk_edit'
                 assert_tag :select,
                   :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
                   :children => {
                     :only => {:tag => 'option'},
                     :count => Project.find(1).shared_versions.count + 1
                   }
               end
               def test_get_bulk_edit_with_multi_custom_field
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 assert_template 'bulk_edit'
                 assert_tag :select,
                   :attributes => {:name => "issue[custom_field_values][1][]"},
                   :children => {
                     :only => {:tag => 'option'},
                     :count => 3
                   }
               end
               def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
                 Workflow.delete_all
                 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
                 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
                 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
                 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
                 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
                 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
                 @request.session[:user_id] = 2
                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 statuses = assigns(:available_statuses)
                 assert_not_nil statuses
                 assert_equal [1, 3], statuses.map(&:id).sort
                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'},
                   :children => {:count => 3} # 2 statuses + "no change" option
               end
               def test_bulk_update
                 @request.session[:user_id] = 2
                 # update issues priority
                 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
                                                  :issue => {:priority_id => 7,
                                                             :assigned_to_id => '',
                                                             :custom_field_values => {'2' => ''}}
                 assert_response 302
                 # check that the issues were updated
                 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
                 issue = Issue.find(1)
                 journal = issue.journals.find(:first, :order => 'created_on DESC')
                 assert_equal '125', issue.custom_value_for(2).value
                 assert_equal 'Bulk editing', journal.notes
                 assert_equal 1, journal.details.size
               end
               def test_bulk_update_with_group_assignee
                 group = Group.find(11)
                 project = Project.find(1)
                 project.members << Member.new(:principal => group, :roles => [Role.first])
                 @request.session[:user_id] = 2
                 # update issues assignee
                 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
                                                  :issue => {:priority_id => '',
                                                             :assigned_to_id => group.id,
                                                             :custom_field_values => {'2' => ''}}
                 assert_response 302
                 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
               end
               def test_bulk_update_on_different_projects
                 @request.session[:user_id] = 2
                 # update issues priority
                 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
                                                  :issue => {:priority_id => 7,
                                                             :assigned_to_id => '',
                                                             :custom_field_values => {'2' => ''}}
                 assert_response 302
                 # check that the issues were updated
                 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
                 issue = Issue.find(1)
                 journal = issue.journals.find(:first, :order => 'created_on DESC')
                 assert_equal '125', issue.custom_value_for(2).value
                 assert_equal 'Bulk editing', journal.notes
                 assert_equal 1, journal.details.size
               end
               def test_bulk_update_on_different_projects_without_rights
                 @request.session[:user_id] = 3
                 user = User.find(3)
                 action = { :controller => "issues", :action => "bulk_update" }
                 assert user.allowed_to?(action, Issue.find(1).project)
                 assert ! user.allowed_to?(action, Issue.find(6).project)
                 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
                                                  :issue => {:priority_id => 7,
                                                             :assigned_to_id => '',
                                                             :custom_field_values => {'2' => ''}}
                 assert_response 403
                 assert_not_equal "Bulk should fail", Journal.last.notes
               end
               def test_bullk_update_should_send_a_notification
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 post(:bulk_update,
                      {
                        :ids => [1, 2],
                        :notes => 'Bulk editing',
                        :issue => {
                          :priority_id => 7,
                          :assigned_to_id => '',
                          :custom_field_values => {'2' => ''}
                        }
                      })
                 assert_response 302
                 assert_equal 2, ActionMailer::Base.deliveries.size
               end
               def test_bulk_update_project
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
                 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
                 # Issues moved to project 2
                 assert_equal 2, Issue.find(1).project_id
                 assert_equal 2, Issue.find(2).project_id
                 # No tracker change
                 assert_equal 1, Issue.find(1).tracker_id
                 assert_equal 2, Issue.find(2).tracker_id
               end
               def test_bulk_update_project_on_single_issue_should_follow_when_needed
                 @request.session[:user_id] = 2
                 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
                 assert_redirected_to '/issues/1'
               end
               def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
                 @request.session[:user_id] = 2
                 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
                 assert_redirected_to '/projects/onlinestore/issues'
               end
               def test_bulk_update_tracker
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
                 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
                 assert_equal 2, Issue.find(1).tracker_id
                 assert_equal 2, Issue.find(2).tracker_id
               end
               def test_bulk_update_status
                 @request.session[:user_id] = 2
                 # update issues priority
                 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
                                                  :issue => {:priority_id => '',
                                                             :assigned_to_id => '',
                                                             :status_id => '5'}
                 assert_response 302
                 issue = Issue.find(1)
                 assert issue.closed?
               end
               def test_bulk_update_priority
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
                 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
                 assert_equal 6, Issue.find(1).priority_id
                 assert_equal 6, Issue.find(2).priority_id
               end
               def test_bulk_update_with_notes
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
                 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
                 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
                 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
               end
               def test_bulk_update_parent_id
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 3],
                   :notes => 'Bulk editing parent',
                   :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
                 assert_response 302
                 parent = Issue.find(2)
                 assert_equal parent.id, Issue.find(1).parent_id
                 assert_equal parent.id, Issue.find(3).parent_id
                 assert_equal [1, 3], parent.children.collect(&:id).sort
               end
               def test_bulk_update_custom_field
                 @request.session[:user_id] = 2
                 # update issues priority
                 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
                                                  :issue => {:priority_id => '',
                                                             :assigned_to_id => '',
                                                             :custom_field_values => {'2' => '777'}}
                 assert_response 302
                 issue = Issue.find(1)
                 journal = issue.journals.find(:first, :order => 'created_on DESC')
                 assert_equal '777', issue.custom_value_for(2).value
                 assert_equal 1, journal.details.size
                 assert_equal '125', journal.details.first.old_value
                 assert_equal '777', journal.details.first.value
               end
               def test_bulk_update_multi_custom_field
                 field = CustomField.find(1)
                 field.update_attribute :multiple, true
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
                                                  :issue => {:priority_id => '',
                                                             :assigned_to_id => '',
                                                             :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
                 assert_response 302
                 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
                 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
                 # the custom field is not associated with the issue tracker
                 assert_nil Issue.find(2).custom_field_value(1)
               end
               def test_bulk_update_unassign
                 assert_not_nil Issue.find(2).assigned_to
                 @request.session[:user_id] = 2
                 # unassign issues
                 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
                 assert_response 302
                 # check that the issues were updated
                 assert_nil Issue.find(2).assigned_to
               end
               def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
                 assert_response :redirect
                 issues = Issue.find([1,2])
                 issues.each do |issue|
                   assert_equal 4, issue.fixed_version_id
                   assert_not_equal issue.project_id, issue.fixed_version.project_id
                 end
               end
               def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1,2], :back_url => '/issues'
                 assert_response :redirect
                 assert_redirected_to '/issues'
               end
               def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
                 assert_response :redirect
                 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
               end
               def test_bulk_copy_to_another_project
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', 2 do
                   assert_no_difference 'Project.find(1).issues.count' do
                     post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
                   end
                 end
                 assert_redirected_to '/projects/ecookbook/issues'
               end
               def test_bulk_copy_should_allow_not_changing_the_issue_attributes
                 @request.session[:user_id] = 2
                 issue_before_move = Issue.find(1)
                 assert_difference 'Issue.count', 1 do
                   assert_no_difference 'Project.find(1).issues.count' do
                     post :bulk_update, :ids => [1], :copy => '1',
                          :issue => {
                            :project_id => '2', :tracker_id => '', :assigned_to_id => '',
                            :status_id => '', :start_date => '', :due_date => ''
                          }
                   end
                 end
                 issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2})
                 assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id
                 assert_equal issue_before_move.status_id, issue_after_move.status_id
                 assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id
               end
              def test_bulk_copy_should_allow_changing_the_issue_attributes
                 # Fixes random test failure with Mysql
                 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
                 # doesn't return the expected results
                 Issue.delete_all("project_id=2")
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', 2 do
                   assert_no_difference 'Project.find(1).issues.count' do
                     post :bulk_update, :ids => [1, 2], :copy => '1',
                          :issue => {
                            :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
                            :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
                          }
                   end
                 end
                 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
                 assert_equal 2, copied_issues.size
                 copied_issues.each do |issue|
                   assert_equal 2, issue.project_id, "Project is incorrect"
                   assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
                   assert_equal 3, issue.status_id, "Status is incorrect"
                   assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
                   assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
                 end
               end
               def test_bulk_copy_should_allow_adding_a_note
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', 1 do
                   post :bulk_update, :ids => [1], :copy => '1',
                        :notes => 'Copying one issue',
                        :issue => {
                          :project_id => '', :tracker_id => '', :assigned_to_id => '4',
                          :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
                        }
                 end
                 issue = Issue.first(:order => 'id DESC')
                 assert_equal 1, issue.journals.size
                 journal = issue.journals.first
                 assert_equal 0, journal.details.size
                 assert_equal 'Copying one issue', journal.notes
               end
               def test_bulk_copy_to_another_project_should_follow_when_needed
                 @request.session[:user_id] = 2
                 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
                 issue = Issue.first(:order => 'id DESC')
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
               end
               def test_destroy_issue_with_no_time_entries
                 assert_nil TimeEntry.find_by_issue_id(2)
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -1 do
                   delete :destroy, :id => 2
                 end
                 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                 assert_nil Issue.find_by_id(2)
               end
               def test_destroy_issues_with_time_entries
                 @request.session[:user_id] = 2
                 assert_no_difference 'Issue.count' do
                   delete :destroy, :ids => [1, 3]
                 end
                 assert_response :success
                 assert_template 'destroy'
                 assert_not_nil assigns(:hours)
                 assert Issue.find_by_id(1) && Issue.find_by_id(3)
                 assert_tag 'form',
                   :descendant => {:tag => 'input', :attributes => {:name => '_method', :value => 'delete'}}
               end
               def test_destroy_issues_and_destroy_time_entries
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -2 do
                   assert_difference 'TimeEntry.count', -3 do
                     delete :destroy, :ids => [1, 3], :todo => 'destroy'
                   end
                 end
                 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_nil TimeEntry.find_by_id([1, 2])
               end
               def test_destroy_issues_and_assign_time_entries_to_project
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -2 do
                   assert_no_difference 'TimeEntry.count' do
                     delete :destroy, :ids => [1, 3], :todo => 'nullify'
                   end
                 end
                 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_nil TimeEntry.find(1).issue_id
                 assert_nil TimeEntry.find(2).issue_id
               end
               def test_destroy_issues_and_reassign_time_entries_to_another_issue
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -2 do
                   assert_no_difference 'TimeEntry.count' do
                     delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
                   end
                 end
                 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_equal 2, TimeEntry.find(1).issue_id
                 assert_equal 2, TimeEntry.find(2).issue_id
               end
               def test_destroy_issues_from_different_projects
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -3 do
                   delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
                 end
                 assert_redirected_to :controller => 'issues', :action => 'index'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
               end
               def test_destroy_parent_and_child_issues
                 parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
                 child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
                 assert child.is_descendant_of?(parent.reload)
                 @request.session[:user_id] = 2
                 assert_difference 'Issue.count', -2 do
                   delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
                 end
                 assert_response 302
               end
               def test_default_search_scope
                 get :index
                 assert_tag :div, :attributes => {:id => 'quick-search'},
                                  :child => {:tag => 'form',
                                             :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
               end
             end

test/functional/issues_controller_transaction_test.rb +30 -5

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'issues_controller'
             class IssuesControllerTransactionTest < ActionController::TestCase
               fixtures :projects,
                        :users,
                        :roles,
                        :members,
                        :member_roles,
                        :issues,
                        :issue_statuses,
                        :versions,
                        :trackers,
                        :projects_trackers,
                        :issue_categories,
                        :enabled_modules,
                        :enumerations,
                        :attachments,
                        :workflows,
                        :custom_fields,
                        :custom_values,
                        :custom_fields_projects,
                        :custom_fields_trackers,
                        :time_entries,
                        :journals,
                        :journal_details,
                        :queries
               self.use_transactional_fixtures = false
               def setup
                 @controller = IssuesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
               end
               def test_update_stale_issue_should_not_update_the_issue
                 issue = Issue.find(2)
                 @request.session[:user_id] = 2
                 assert_no_difference 'Journal.count' do
                   assert_no_difference 'TimeEntry.count' do
-                    assert_no_difference 'Attachment.count' do
+                    put :update,
+                          :id => issue.id,
+                          :issue => {
+                            :fixed_version_id => 4,
+                            :lock_version => (issue.lock_version - 1)
+                          },
+                          :notes => 'My notes',
+                          :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id }
+                  end
+                end
+                assert_response :success
+                assert_template 'edit'
+                assert_tag 'div', :attributes => {:class => 'conflict'}
+                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'overwrite'}
+                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'add_notes'}
+                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'cancel'}
+              end
+              def test_update_stale_issue_should_save_attachments
+                set_tmp_attachments_directory
+                issue = Issue.find(2)
+                @request.session[:user_id] = 2
+                assert_no_difference 'Journal.count' do
+                  assert_no_difference 'TimeEntry.count' do
+                    assert_difference 'Attachment.count' do
                       put :update,
                             :id => issue.id,
                             :issue => {
                               :fixed_version_id => 4,
                               :lock_version => (issue.lock_version - 1)
                             },
                             :notes => 'My notes',
                             :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}},
                             :time_entry => { :hours => '2.5', :comments => '', :activity_id => TimeEntryActivity.first.id }
                     end
                   end
                 end
                 assert_response :success
                 assert_template 'edit'
-                assert_tag 'div', :attributes => {:class => 'conflict'}
+                attachment = Attachment.first(:order => 'id DESC')
-                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'overwrite'}
+                assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
-                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'add_notes'}
+                assert_tag 'span', :content => /testfile.txt/
-                assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'cancel'}
               end
               def test_update_stale_issue_without_notes_should_not_show_add_notes_option
                 issue = Issue.find(2)
                 @request.session[:user_id] = 2
                 put :update, :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4,
                         :lock_version => (issue.lock_version - 1)
                       },
                       :notes => ''
                 assert_tag 'div', :attributes => {:class => 'conflict'}
                 assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'overwrite'}
                 assert_no_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'add_notes'}
                 assert_tag 'input', :attributes => {:name => 'conflict_resolution', :value => 'cancel'}
               end
               def test_update_stale_issue_should_show_conflicting_journals
                 @request.session[:user_id] = 2
                 put :update, :id => 1,
                       :issue => {
                         :fixed_version_id => 4,
                         :lock_version => 2
                       },
                       :notes => '',
                       :last_journal_id => 1
                 assert_not_nil assigns(:conflict_journals)
                 assert_equal 1, assigns(:conflict_journals).size
                 assert_equal 2, assigns(:conflict_journals).first.id
                 assert_tag 'div', :attributes => {:class => 'conflict'},
                   :descendant => {:content => /Some notes with Redmine links/}
               end
               def test_update_stale_issue_without_previous_journal_should_show_all_journals
                 @request.session[:user_id] = 2
                 put :update, :id => 1,
                       :issue => {
                         :fixed_version_id => 4,
                         :lock_version => 2
                       },
                       :notes => '',
                       :last_journal_id => ''
                 assert_not_nil assigns(:conflict_journals)
                 assert_equal 2, assigns(:conflict_journals).size
                 assert_tag 'div', :attributes => {:class => 'conflict'},
                   :descendant => {:content => /Some notes with Redmine links/}
                 assert_tag 'div', :attributes => {:class => 'conflict'},
                   :descendant => {:content => /Journal notes/}
               end
               def test_update_stale_issue_with_overwrite_conflict_resolution_should_update
                 @request.session[:user_id] = 2
                 assert_difference 'Journal.count' do
                   put :update, :id => 1,
                         :issue => {
                           :fixed_version_id => 4,
                           :lock_version => 2
                         },
                         :notes => 'overwrite_conflict_resolution',
                         :conflict_resolution => 'overwrite'
                 end
                 assert_response 302
                 issue = Issue.find(1)
                 assert_equal 4, issue.fixed_version_id
                 journal = Journal.first(:order => 'id DESC')
                 assert_equal 'overwrite_conflict_resolution', journal.notes
                 assert journal.details.any?
               end
               def test_update_stale_issue_with_add_notes_conflict_resolution_should_update
                 @request.session[:user_id] = 2
                 assert_difference 'Journal.count' do
                   put :update, :id => 1,
                         :issue => {
                           :fixed_version_id => 4,
                           :lock_version => 2
                         },
                         :notes => 'add_notes_conflict_resolution',
                         :conflict_resolution => 'add_notes'
                 end
                 assert_response 302
                 issue = Issue.find(1)
                 assert_nil issue.fixed_version_id
                 journal = Journal.first(:order => 'id DESC')
                 assert_equal 'add_notes_conflict_resolution', journal.notes
                 assert journal.details.empty?
               end
               def test_update_stale_issue_with_cancel_conflict_resolution_should_redirect_without_updating
                 @request.session[:user_id] = 2
                 assert_no_difference 'Journal.count' do
                   put :update, :id => 1,
                         :issue => {
                           :fixed_version_id => 4,
                           :lock_version => 2
                         },
                         :notes => 'add_notes_conflict_resolution',
                         :conflict_resolution => 'cancel'
                 end
                 assert_redirected_to '/issues/1'
                 issue = Issue.find(1)
                 assert_nil issue.fixed_version_id
               end
               def test_index_should_rescue_invalid_sql_query
                 Query.any_instance.stubs(:statement).returns("INVALID STATEMENT")
                 get :index
                 assert_response 500
                 assert_tag 'p', :content => /An error occurred/
                 assert_nil session[:query]
                 assert_nil session[:issues_index_sort]
               end
             end

test/unit/attachment_test.rb +4 0

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AttachmentTest < ActiveSupport::TestCase
               fixtures :users, :projects, :roles, :members, :member_roles,
                        :enabled_modules, :issues, :trackers, :attachments
               class MockFile
                 attr_reader :original_filename, :content_type, :content, :size
                 def initialize(attributes)
                   @original_filename = attributes[:original_filename]
                   @content_type = attributes[:content_type]
                   @content = attributes[:content] || "Content"
                   @size = content.size
                 end
               end
               def setup
                 set_tmp_attachments_directory
               end
+              def test_container_for_new_attachment_should_be_nil
+                assert_nil Attachment.new.container
+              end
               def test_create
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("testfile.txt", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'testfile.txt', a.filename
                 assert_equal 59, a.filesize
                 assert_equal 'text/plain', a.content_type
                 assert_equal 0, a.downloads
                 assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
                 assert File.exist?(a.diskfile)
                 assert_equal 59, File.size(a.diskfile)
               end
               def test_size_should_be_validated_for_new_file
                 with_settings :attachment_max_size => 0 do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("testfile.txt", "text/plain"),
                                      :author => User.find(1))
                   assert !a.save
                 end
               end
               def test_size_should_not_be_validated_when_copying
                 a = Attachment.create!(:container => Issue.find(1),
                                        :file => uploaded_test_file("testfile.txt", "text/plain"),
                                        :author => User.find(1))
                 with_settings :attachment_max_size => 0 do
                   copy = a.copy
                   assert copy.save
                 end
               end
               def test_destroy
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("testfile.txt", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'testfile.txt', a.filename
                 assert_equal 59, a.filesize
                 assert_equal 'text/plain', a.content_type
                 assert_equal 0, a.downloads
                 assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
                 diskfile = a.diskfile
                 assert File.exist?(diskfile)
                 assert_equal 59, File.size(a.diskfile)
                 assert a.destroy
                 assert !File.exist?(diskfile)
               end
               def test_destroy_should_not_delete_file_referenced_by_other_attachment
                 a = Attachment.create!(:container => Issue.find(1),
                                        :file => uploaded_test_file("testfile.txt", "text/plain"),
                                        :author => User.find(1))
                 diskfile = a.diskfile
                 copy = a.copy
                 copy.save!
                 assert File.exists?(diskfile)
                 a.destroy
                 assert File.exists?(diskfile)
                 copy.destroy
                 assert !File.exists?(diskfile)
               end
               def test_create_should_auto_assign_content_type
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("testfile.txt", ""),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'text/plain', a.content_type
               end
               def test_identical_attachments_at_the_same_time_should_not_overwrite
                 a1 = Attachment.create!(:container => Issue.find(1),
                                         :file => uploaded_test_file("testfile.txt", ""),
                                         :author => User.find(1))
                 a2 = Attachment.create!(:container => Issue.find(1),
                                         :file => uploaded_test_file("testfile.txt", ""),
                                         :author => User.find(1))
                 assert a1.disk_filename != a2.disk_filename
               end
               def test_filename_should_be_basenamed
                 a = Attachment.new(:file => MockFile.new(:original_filename => "path/to/the/file"))
                 assert_equal 'file', a.filename
               end
               def test_filename_should_be_sanitized
                 a = Attachment.new(:file => MockFile.new(:original_filename => "valid:[] invalid:?%*|\"'<>chars"))
                 assert_equal 'valid_[] invalid_chars', a.filename
               end
               def test_diskfilename
                 assert Attachment.disk_filename("test_file.txt") =~ /^\d{12}_test_file.txt$/
                 assert_equal 'test_file.txt', Attachment.disk_filename("test_file.txt")[13..-1]
                 assert_equal '770c509475505f37c2b8fb6030434d6b.txt', Attachment.disk_filename("test_accentué.txt")[13..-1]
                 assert_equal 'f8139524ebb8f32e51976982cd20a85d', Attachment.disk_filename("test_accentué")[13..-1]
                 assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', Attachment.disk_filename("test_accentué.ça")[13..-1]
               end
               context "Attachmnet.attach_files" do
                 should "attach the file" do
                   issue = Issue.first
                   assert_difference 'Attachment.count' do
                     Attachment.attach_files(issue,
                       '1' => {
                         'file' => uploaded_test_file('testfile.txt', 'text/plain'),
                         'description' => 'test'
                       })
                   end
                   attachment = Attachment.first(:order => 'id DESC')
                   assert_equal issue, attachment.container
                   assert_equal 'testfile.txt', attachment.filename
                   assert_equal 59, attachment.filesize
                   assert_equal 'test', attachment.description
                   assert_equal 'text/plain', attachment.content_type
                   assert File.exists?(attachment.diskfile)
                   assert_equal 59, File.size(attachment.diskfile)
                 end
                 should "add unsaved files to the object as unsaved attachments" do
                   # Max size of 0 to force Attachment creation failures
                   with_settings(:attachment_max_size => 0) do
                     @project = Project.generate!
                     response = Attachment.attach_files(@project, {
                                                          '1' => {'file' => mock_file, 'description' => 'test'},
                                                          '2' => {'file' => mock_file, 'description' => 'test'}
                                                        })
                     assert response[:unsaved].present?
                     assert_equal 2, response[:unsaved].length
                     assert response[:unsaved].first.new_record?
                     assert response[:unsaved].second.new_record?
                     assert_equal response[:unsaved], @project.unsaved_attachments
                   end
                 end
               end
               def test_latest_attach
                 set_fixtures_attachments_directory
                 a1 = Attachment.find(16)
                 assert_equal "testfile.png", a1.filename
                 assert a1.readable?
                 assert (! a1.visible?(User.anonymous))
                 assert a1.visible?(User.find(2))
                 a2 = Attachment.find(17)
                 assert_equal "testfile.PNG", a2.filename
                 assert a2.readable?
                 assert (! a2.visible?(User.anonymous))
                 assert a2.visible?(User.find(2))
                 assert a1.created_on < a2.created_on
                 la1 = Attachment.latest_attach([a1, a2], "testfile.png")
                 assert_equal 17, la1.id
                 la2 = Attachment.latest_attach([a1, a2], "Testfile.PNG")
                 assert_equal 17, la2.id
                 set_tmp_attachments_directory
               end
             end

vendor/plugins/acts_as_attachable/lib/acts_as_attachable.rb +38 -1

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module Acts
                 module Attachable
                   def self.included(base)
                     base.extend ClassMethods
                   end
                   module ClassMethods
                     def acts_as_attachable(options = {})
                       cattr_accessor :attachable_options
                       self.attachable_options = {}
                       attachable_options[:view_permission] = options.delete(:view_permission) || "view_#{self.name.pluralize.underscore}".to_sym
                       attachable_options[:delete_permission] = options.delete(:delete_permission) || "edit_#{self.name.pluralize.underscore}".to_sym
                       has_many :attachments, options.merge(:as => :container,
                                                            :order => "#{Attachment.table_name}.created_on",
                                                            :dependent => :destroy)
-                      attr_accessor :unsaved_attachments
                       send :include, Redmine::Acts::Attachable::InstanceMethods
+                      before_save :attach_saved_attachments
                     end
                   end
                   module InstanceMethods
                     def self.included(base)
                       base.extend ClassMethods
                     end
                     def attachments_visible?(user=User.current)
                       (respond_to?(:visible?) ? visible?(user) : true) &&
                         user.allowed_to?(self.class.attachable_options[:view_permission], self.project)
                     end
                     def attachments_deletable?(user=User.current)
                       (respond_to?(:visible?) ? visible?(user) : true) &&
                         user.allowed_to?(self.class.attachable_options[:delete_permission], self.project)
                     end
+                    def saved_attachments
+                      @saved_attachments ||= []
+                    end
+                    def unsaved_attachments
+                      @unsaved_attachments ||= []
+                    end
+                    def save_attachments(attachments, author=User.current)
+                      if attachments && attachments.is_a?(Hash)
+                        attachments.each_value do |attachment|
+                          a = nil
+                          if file = attachment['file']
+                            next unless file && file.size > 0
+                            a = Attachment.create(:file => file,
+                                                  :description => attachment['description'].to_s.strip,
+                                                  :author => author)
+                          elsif token = attachment['token']
+                            a = Attachment.find_by_token(token)
+                          end
+                          next unless a
+                          if a.new_record?
+                            unsaved_attachments << a
+                          else
+                            saved_attachments << a
+                          end
+                        end
+                      end
+                      {:files => saved_attachments, :unsaved => unsaved_attachments}
+                    end
+                    def attach_saved_attachments
+                      saved_attachments.each do |attachment|
+                        self.attachments << attachment
+                      end
+                    end
                     module ClassMethods
                     end
                   end
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages