##// END OF EJS Templates
jro_apps » redmine
RSS
fix find_all_by_id(n1, n2) parameter at TimelogCustomFieldsVisibilityTest...
Toshi MARUYAMA -
r12355:d401f86b0d8f
parent child
Show More
Side by Side Unified
Context file:
r12355:d401f86b0d8f Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,118 +1,118
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class TimelogCustomFieldsVisibilityTest < ActionController::TestCase
21 21 tests TimelogController
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issue_statuses,
28 28 :trackers,
29 29 :projects_trackers,
30 30 :enabled_modules,
31 31 :enumerations,
32 32 :workflows
33 33
34 34 def setup
35 35 field_attributes = {:field_format => 'string', :is_for_all => true, :is_filter => true, :trackers => Tracker.all}
36 36 @fields = []
37 37 @fields << (@field1 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 1', :visible => true)))
38 38 @fields << (@field2 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 2', :visible => false, :role_ids => [1, 2])))
39 39 @fields << (@field3 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 3', :visible => false, :role_ids => [1, 3])))
40 40 @issue = Issue.generate!(
41 41 :author_id => 1,
42 42 :project_id => 1,
43 43 :tracker_id => 1,
44 44 :custom_field_values => {@field1.id => 'Value0', @field2.id => 'Value1', @field3.id => 'Value2'}
45 45 )
46 46 TimeEntry.generate!(:issue => @issue)
47 47
48 48 @user_with_role_on_other_project = User.generate!
49 49 User.add_to_project(@user_with_role_on_other_project, Project.find(2), Role.find(3))
50 50
51 51 @users_to_test = {
52 52 User.find(1) => [@field1, @field2, @field3],
53 53 User.find(3) => [@field1, @field2],
54 54 @user_with_role_on_other_project => [@field1], # should see field1 only on Project 1
55 55 User.generate! => [@field1],
56 56 User.anonymous => [@field1]
57 57 }
58 58
59 59 Member.where(:project_id => 1).each do |member|
60 60 member.destroy unless @users_to_test.keys.include?(member.principal)
61 61 end
62 62 end
63 63
64 64 def test_index_should_show_visible_custom_fields_only
65 65 @users_to_test.each do |user, fields|
66 66 @request.session[:user_id] = user.id
67 67 get :index, :project_id => 1, :issue_id => @issue.id, :c => (['hours'] + @fields.map{|f| "issue.cf_#{f.id}"})
68 68 @fields.each_with_index do |field, i|
69 69 if fields.include?(field)
70 70 assert_select 'td', {:text => "Value#{i}", :count => 1}, "User #{user.id} was not able to view #{field.name}"
71 71 else
72 72 assert_select 'td', {:text => "Value#{i}", :count => 0}, "User #{user.id} was able to view #{field.name}"
73 73 end
74 74 end
75 75 end
76 76 end
77 77
78 78 def test_index_as_csv_should_show_visible_custom_fields_only
79 79 @users_to_test.each do |user, fields|
80 80 @request.session[:user_id] = user.id
81 81 get :index, :project_id => 1, :issue_id => @issue.id, :c => (['hours'] + @fields.map{|f| "issue.cf_#{f.id}"}), :format => 'csv'
82 82 @fields.each_with_index do |field, i|
83 83 if fields.include?(field)
84 84 assert_include "Value#{i}", response.body, "User #{user.id} was not able to view #{field.name} in CSV"
85 85 else
86 86 assert_not_include "Value#{i}", response.body, "User #{user.id} was able to view #{field.name} in CSV"
87 87 end
88 88 end
89 89 end
90 90 end
91 91
92 92 def test_index_with_partial_custom_field_visibility_should_show_visible_custom_fields_only
93 93 Issue.delete_all
94 94 TimeEntry.delete_all
95 95 p1 = Project.generate!
96 96 p2 = Project.generate!
97 97 user = User.generate!
98 User.add_to_project(user, p1, Role.find_all_by_id(1,3))
98 User.add_to_project(user, p1, Role.find_all_by_id([1, 3]))
99 99 User.add_to_project(user, p2, Role.find_all_by_id(3))
100 100 TimeEntry.generate!(
101 101 :issue => Issue.generate!(:project => p1, :tracker_id => 1,
102 102 :custom_field_values => {@field2.id => 'ValueA'}))
103 103 TimeEntry.generate!(
104 104 :issue => Issue.generate!(:project => p2, :tracker_id => 1,
105 105 :custom_field_values => {@field2.id => 'ValueB'}))
106 106 TimeEntry.generate!(
107 107 :issue => Issue.generate!(:project => p1, :tracker_id => 1,
108 108 :custom_field_values => {@field2.id => 'ValueC'}))
109 109 @request.session[:user_id] = user.id
110 110 get :index, :c => ["hours", "issue.cf_#{@field2.id}"]
111 111 assert_select 'td', :text => 'ValueA'
112 112 assert_select 'td', :text => 'ValueB', :count => 0
113 113 assert_select 'td', :text => 'ValueC'
114 114
115 115 get :index, :set_filter => '1', "issue.cf_#{@field2.id}" => '*'
116 116 assert_equal %w(ValueA ValueC), assigns(:entries).map{|i| i.issue.custom_field_value(@field2)}.sort
117 117 end
118 118 end
General Comments 0
You need to be logged in to leave comments. Login now