jro_apps/redmine Commit - r15940:d37125dfe98b

replace depricated Net::LDAP::LdapError by Net::LDAP::Error (#24970)...

Toshi MARUYAMA -

r15940:d37125dfe98b

parent child

Context file:

r15940:d37125dfe98b

Collapse all files

Gemfile +1 -1

             source 'https://rubygems.org'
             if Gem::Version.new(Bundler::VERSION) < Gem::Version.new('1.5.0')
               abort "Redmine requires Bundler 1.5.0 or higher (you're using #{Bundler::VERSION}).\nPlease update with 'gem update bundler'."
             end
             gem "rails", "4.2.7.1"
             gem "addressable", "2.4.0" if RUBY_VERSION < "2.0"
             gem "jquery-rails", "~> 3.1.4"
             gem "coderay", "~> 1.1.1"
             gem "request_store", "1.0.5"
             gem "mime-types", (RUBY_VERSION >= "2.0" ? "~> 3.0" : "~> 2.99")
             gem "protected_attributes"
             gem "actionpack-xml_parser"
             gem "roadie-rails"
             gem "mimemagic"
             gem "nokogiri", "~> 1.6.8"
             # Request at least rails-html-sanitizer 1.0.3 because of security advisories
             gem "rails-html-sanitizer", ">= 1.0.3"
             # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
             gem 'tzinfo-data', platforms: [:mingw, :x64_mingw, :mswin, :jruby]
             gem "rbpdf", "~> 1.19.0"
             # Optional gem for LDAP authentication
             group :ldap do
-              gem "net-ldap", "~> 0.12.0"
+              gem "net-ldap", "~> 0.12.1"
             end
             # Optional gem for OpenID authentication
             group :openid do
               gem "ruby-openid", "~> 2.3.0", :require => "openid"
               gem "rack-openid"
             end
             platforms :mri, :mingw, :x64_mingw do
               # Optional gem for exporting the gantt to a PNG file, not supported with jruby
               group :rmagick do
                 gem "rmagick", ">= 2.14.0"
               end
               # Optional Markdown support, not for JRuby
               group :markdown do
                 gem "redcarpet", "~> 3.3.2"
               end
             end
             platforms :jruby do
               # jruby-openssl is bundled with JRuby 1.7.0
               gem "jruby-openssl" if Object.const_defined?(:JRUBY_VERSION) && JRUBY_VERSION < '1.7.0'
               gem "activerecord-jdbc-adapter", "~> 1.3.2"
             end
             # Include database gems for the adapters found in the database
             # configuration file
             require 'erb'
             require 'yaml'
             database_file = File.join(File.dirname(__FILE__), "config/database.yml")
             if File.exist?(database_file)
               database_config = YAML::load(ERB.new(IO.read(database_file)).result)
               adapters = database_config.values.map {|c| c['adapter']}.compact.uniq
               if adapters.any?
                 adapters.each do |adapter|
                   case adapter
                   when 'mysql2'
                     gem "mysql2", "~> 0.3.11", :platforms => [:mri, :mingw, :x64_mingw]
                     gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
                   when 'mysql'
                     gem "activerecord-jdbcmysql-adapter", :platforms => :jruby
                   when /postgresql/
                     gem "pg", "~> 0.18.1", :platforms => [:mri, :mingw, :x64_mingw]
                     gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
                   when /sqlite3/
                     gem "sqlite3", :platforms => [:mri, :mingw, :x64_mingw]
                     gem "jdbc-sqlite3", ">= 3.8.10.1", :platforms => :jruby
                     gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby
                   when /sqlserver/
                     gem "tiny_tds", (RUBY_VERSION >= "2.0" ? "~> 1.0.5" : "~> 0.7.0"), :platforms => [:mri, :mingw, :x64_mingw]
                     gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw, :x64_mingw]
                   else
                     warn("Unknown database adapter `#{adapter}` found in config/database.yml, use Gemfile.local to load your own database gems")
                   end
                 end
               else
                 warn("No adapter found in config/database.yml, please configure it first")
               end
             else
               warn("Please configure your config/database.yml first")
             end
             group :development do
               gem "rdoc", "~> 4.3"
               gem "yard"
             end
             group :test do
               gem "minitest"
               gem "rails-dom-testing"
               gem "mocha"
               gem "simplecov", "~> 0.9.1", :require => false
               # For running UI tests
               gem "capybara"
               gem "selenium-webdriver", "~> 2.53.4"
             end
             local_gemfile = File.join(File.dirname(__FILE__), "Gemfile.local")
             if File.exists?(local_gemfile)
               eval_gemfile local_gemfile
             end
             # Load plugins' Gemfiles
             Dir.glob File.expand_path("../plugins/*/{Gemfile,PluginGemfile}", __FILE__) do |file|
               eval_gemfile file
             end

app/models/auth_source_ldap.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'net/ldap'
             require 'net/ldap/dn'
             require 'timeout'
             class AuthSourceLdap < AuthSource
               NETWORK_EXCEPTIONS = [
-                Net::LDAP::LdapError,
+                Net::LDAP::Error,
                 Errno::ECONNABORTED, Errno::ECONNREFUSED, Errno::ECONNRESET,
                 Errno::EHOSTDOWN, Errno::EHOSTUNREACH,
                 SocketError
               ]
               validates_presence_of :host, :port, :attr_login
               validates_length_of :name, :host, :maximum => 60, :allow_nil => true
               validates_length_of :account, :account_password, :base_dn, :maximum => 255, :allow_blank => true
               validates_length_of :attr_login, :attr_firstname, :attr_lastname, :attr_mail, :maximum => 30, :allow_nil => true
               validates_numericality_of :port, :only_integer => true
               validates_numericality_of :timeout, :only_integer => true, :allow_blank => true
               validate :validate_filter
               before_validation :strip_ldap_attributes
               def initialize(attributes=nil, *args)
                 super
                 self.port = 389 if self.port == 0
               end
               def authenticate(login, password)
                 return nil if login.blank? || password.blank?
                 with_timeout do
                   attrs = get_user_dn(login, password)
                   if attrs && attrs[:dn] && authenticate_dn(attrs[:dn], password)
                     logger.debug "Authentication successful for '#{login}'" if logger && logger.debug?
                     return attrs.except(:dn)
                   end
                 end
               rescue *NETWORK_EXCEPTIONS => e
                 raise AuthSourceException.new(e.message)
               end
               # Test the connection to the LDAP
               def test_connection
                 with_timeout do
                   ldap_con = initialize_ldap_con(self.account, self.account_password)
                   ldap_con.open { }
                   if self.account.present? && !self.account.include?("$login") && self.account_password.present?
                     ldap_auth = authenticate_dn(self.account, self.account_password)
                     raise AuthSourceException.new(l(:error_ldap_bind_credentials)) if !ldap_auth
                   end
                 end
               rescue *NETWORK_EXCEPTIONS => e
                 raise AuthSourceException.new(e.message)
               end
               def auth_method_name
                 "LDAP"
               end
               # Returns true if this source can be searched for users
               def searchable?
                 !account.to_s.include?("$login") && %w(login firstname lastname mail).all? {|a| send("attr_#{a}?")}
               end
               # Searches the source for users and returns an array of results
               def search(q)
                 q = q.to_s.strip
                 return [] unless searchable? && q.present?
                 results = []
                 search_filter = base_filter & Net::LDAP::Filter.begins(self.attr_login, q)
                 ldap_con = initialize_ldap_con(self.account, self.account_password)
                 ldap_con.search(:base => self.base_dn,
                                 :filter => search_filter,
                                 :attributes => ['dn', self.attr_login, self.attr_firstname, self.attr_lastname, self.attr_mail],
                                 :size => 10) do |entry|
                   attrs = get_user_attributes_from_ldap_entry(entry)
                   attrs[:login] = AuthSourceLdap.get_attr(entry, self.attr_login)
                   results << attrs
                 end
                 results
               rescue *NETWORK_EXCEPTIONS => e
                 raise AuthSourceException.new(e.message)
               end
               private
               def with_timeout(&block)
                 timeout = self.timeout
                 timeout = 20 unless timeout && timeout > 0
                 Timeout.timeout(timeout) do
                   return yield
                 end
               rescue Timeout::Error => e
                 raise AuthSourceTimeoutException.new(e.message)
               end
               def ldap_filter
                 if filter.present?
                   Net::LDAP::Filter.construct(filter)
                 end
-              rescue Net::LDAP::LdapError, Net::LDAP::FilterSyntaxInvalidError
+              rescue Net::LDAP::Error, Net::LDAP::FilterSyntaxInvalidError
                 nil
               end
               def base_filter
                 filter = Net::LDAP::Filter.eq("objectClass", "*")
                 if f = ldap_filter
                   filter = filter & f
                 end
                 filter
               end
               def validate_filter
                 if filter.present? && ldap_filter.nil?
                   errors.add(:filter, :invalid)
                 end
               end
               def strip_ldap_attributes
                 [:attr_login, :attr_firstname, :attr_lastname, :attr_mail].each do |attr|
                   write_attribute(attr, read_attribute(attr).strip) unless read_attribute(attr).nil?
                 end
               end
               def initialize_ldap_con(ldap_user, ldap_password)
                 options = { :host => self.host,
                             :port => self.port,
                             :encryption => (self.tls ? :simple_tls : nil)
                           }
                 options.merge!(:auth => { :method => :simple, :username => ldap_user, :password => ldap_password }) unless ldap_user.blank? && ldap_password.blank?
                 Net::LDAP.new options
               end
               def get_user_attributes_from_ldap_entry(entry)
                 {
                  :dn => entry.dn,
                  :firstname => AuthSourceLdap.get_attr(entry, self.attr_firstname),
                  :lastname => AuthSourceLdap.get_attr(entry, self.attr_lastname),
                  :mail => AuthSourceLdap.get_attr(entry, self.attr_mail),
                  :auth_source_id => self.id
                 }
               end
               # Return the attributes needed for the LDAP search.  It will only
               # include the user attributes if on-the-fly registration is enabled
               def search_attributes
                 if onthefly_register?
                   ['dn', self.attr_firstname, self.attr_lastname, self.attr_mail]
                 else
                   ['dn']
                 end
               end
               # Check if a DN (user record) authenticates with the password
               def authenticate_dn(dn, password)
                 if dn.present? && password.present?
                   initialize_ldap_con(dn, password).bind
                 end
               end
               # Get the user's dn and any attributes for them, given their login
               def get_user_dn(login, password)
                 ldap_con = nil
                 if self.account && self.account.include?("$login")
                   ldap_con = initialize_ldap_con(self.account.sub("$login", Net::LDAP::DN.escape(login)), password)
                 else
                   ldap_con = initialize_ldap_con(self.account, self.account_password)
                 end
                 attrs = {}
                 search_filter = base_filter & Net::LDAP::Filter.eq(self.attr_login, login)
                 ldap_con.search( :base => self.base_dn,
                                  :filter => search_filter,
                                  :attributes=> search_attributes) do |entry|
                   if onthefly_register?
                     attrs = get_user_attributes_from_ldap_entry(entry)
                   else
                     attrs = {:dn => entry.dn}
                   end
                   logger.debug "DN found for #{login}: #{attrs[:dn]}" if logger && logger.debug?
                 end
                 attrs
               end
               def self.get_attr(entry, attr_name)
                 if !attr_name.blank?
                   value = entry[attr_name].is_a?(Array) ? entry[attr_name].first : entry[attr_name]
                   value.to_s.force_encoding('UTF-8')
                 end
               end
             end

test/functional/auth_sources_controller_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AuthSourcesControllerTest < Redmine::ControllerTest
               fixtures :users, :auth_sources
               def setup
                 @request.session[:user_id] = 1
               end
               def test_index
                 get :index
                 assert_response :success
               end
               def test_new
                 get :new
                 assert_response :success
                 assert_select 'form#auth_source_form' do
                   assert_select 'input[name=type][value=AuthSourceLdap]'
                   assert_select 'input[name=?]', 'auth_source[host]'
                 end
               end
               def test_new_with_invalid_type_should_respond_with_404
                 get :new, :type => 'foo'
                 assert_response 404
               end
               def test_create
                 assert_difference 'AuthSourceLdap.count' do
                   post :create, :type => 'AuthSourceLdap', :auth_source => {:name => 'Test', :host => '127.0.0.1', :port => '389', :attr_login => 'cn'}
                   assert_redirected_to '/auth_sources'
                 end
                 source = AuthSourceLdap.order('id DESC').first
                 assert_equal 'Test', source.name
                 assert_equal '127.0.0.1', source.host
                 assert_equal 389, source.port
                 assert_equal 'cn', source.attr_login
               end
               def test_create_with_failure
                 assert_no_difference 'AuthSourceLdap.count' do
                   post :create, :type => 'AuthSourceLdap',
                                 :auth_source => {:name => 'Test', :host => '',
                                                  :port => '389', :attr_login => 'cn'}
                   assert_response :success
                 end
                 assert_select_error /host cannot be blank/i
               end
               def test_edit
                 get :edit, :id => 1
                 assert_response :success
                 assert_select 'form#auth_source_form' do
                   assert_select 'input[name=?]', 'auth_source[host]'
                 end
               end
               def test_edit_should_not_contain_password
                 AuthSource.find(1).update_column :account_password, 'secret'
                 get :edit, :id => 1
                 assert_response :success
                 assert_select 'input[value=secret]', 0
                 assert_select 'input[name=dummy_password][value^=xxxxxx]'
               end
               def test_edit_invalid_should_respond_with_404
                 get :edit, :id => 99
                 assert_response 404
               end
               def test_update
                 put :update, :id => 1,
                              :auth_source => {:name => 'Renamed', :host => '192.168.0.10',
                                               :port => '389', :attr_login => 'uid'}
                 assert_redirected_to '/auth_sources'
                 source = AuthSourceLdap.find(1)
                 assert_equal 'Renamed', source.name
                 assert_equal '192.168.0.10', source.host
               end
               def test_update_with_failure
                 put :update, :id => 1,
                              :auth_source => {:name => 'Renamed', :host => '',
                                               :port => '389', :attr_login => 'uid'}
                 assert_response :success
                 assert_select_error /host cannot be blank/i
               end
               def test_destroy
                 assert_difference 'AuthSourceLdap.count', -1 do
                   delete :destroy, :id => 1
                   assert_redirected_to '/auth_sources'
                 end
               end
               def test_destroy_auth_source_in_use
                 User.find(2).update_attribute :auth_source_id, 1
                 assert_no_difference 'AuthSourceLdap.count' do
                   delete :destroy, :id => 1
                   assert_redirected_to '/auth_sources'
                 end
               end
               def test_test_connection
                 AuthSourceLdap.any_instance.stubs(:test_connection).returns(true)
                 get :test_connection, :id => 1
                 assert_redirected_to '/auth_sources'
                 assert_not_nil flash[:notice]
                 assert_match /successful/i, flash[:notice]
               end
               def test_test_connection_with_failure
-                AuthSourceLdap.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::LdapError.new("Something went wrong"))
+                AuthSourceLdap.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::Error.new("Something went wrong"))
                 get :test_connection, :id => 1
                 assert_redirected_to '/auth_sources'
                 assert_not_nil flash[:error]
                 assert_include 'Something went wrong', flash[:error]
               end
               def test_autocomplete_for_new_user
                 AuthSource.expects(:search).with('foo').returns([
                   {:login => 'foo1', :firstname => 'John', :lastname => 'Smith', :mail => 'foo1@example.net', :auth_source_id => 1},
                   {:login => 'Smith', :firstname => 'John', :lastname => 'Doe', :mail => 'foo2@example.net', :auth_source_id => 1}
                 ])
                 get :autocomplete_for_new_user, :term => 'foo'
                 assert_response :success
                 assert_equal 'application/json', response.content_type
                 json = ActiveSupport::JSON.decode(response.body)
                 assert_kind_of Array, json
                 assert_equal 2, json.size
                 assert_equal 'foo1', json.first['value']
                 assert_equal 'foo1 (John Smith)', json.first['label']
               end
             end

test/unit/auth_source_ldap_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AuthSourceLdapTest < ActiveSupport::TestCase
               include Redmine::I18n
               fixtures :auth_sources
               def setup
               end
               def test_initialize
                 auth_source = AuthSourceLdap.new
                 assert_nil auth_source.id
                 assert_equal "AuthSourceLdap", auth_source.type
                 assert_equal "", auth_source.name
                 assert_nil auth_source.host
                 assert_nil auth_source.port
                 assert_nil auth_source.account
                 assert_equal "", auth_source.account_password
                 assert_nil auth_source.base_dn
                 assert_nil auth_source.attr_login
                 assert_nil auth_source.attr_firstname
                 assert_nil auth_source.attr_lastname
                 assert_nil auth_source.attr_mail
                 assert_equal false, auth_source.onthefly_register
                 assert_equal false, auth_source.tls
                 assert_nil auth_source.filter
                 assert_nil auth_source.timeout
               end
               def test_create
                 a = AuthSourceLdap.new(:name => 'My LDAP', :host => 'ldap.example.net', :port => 389, :base_dn => 'dc=example,dc=net', :attr_login => 'sAMAccountName')
                 assert a.save
               end
               def test_should_strip_ldap_attributes
                 a = AuthSourceLdap.new(:name => 'My LDAP', :host => 'ldap.example.net', :port => 389, :base_dn => 'dc=example,dc=net', :attr_login => 'sAMAccountName',
                                        :attr_firstname => 'givenName ')
                 assert a.save
                 assert_equal 'givenName', a.reload.attr_firstname
               end
               def test_replace_port_zero_to_389
                 a = AuthSourceLdap.new(
                        :name => 'My LDAP', :host => 'ldap.example.net', :port => 0,
                        :base_dn => 'dc=example,dc=net', :attr_login => 'sAMAccountName',
                        :attr_firstname => 'givenName ')
                 assert a.save
                 assert_equal 389, a.port
               end
               def test_filter_should_be_validated
                 set_language_if_valid 'en'
                 a = AuthSourceLdap.new(:name => 'My LDAP', :host => 'ldap.example.net', :port => 389, :attr_login => 'sn')
                 a.filter = "(mail=*@redmine.org"
                 assert !a.valid?
                 assert_include "LDAP filter is invalid", a.errors.full_messages
                 a.filter = "(mail=*@redmine.org)"
                 assert a.valid?
               end
               if ldap_configured?
                 test '#authenticate with a valid LDAP user should return the user attributes' do
                   auth = AuthSourceLdap.find(1)
                   auth.update_attribute :onthefly_register, true
                   attributes =  auth.authenticate('example1','123456')
                   assert attributes.is_a?(Hash), "An hash was not returned"
                   assert_equal 'Example', attributes[:firstname]
                   assert_equal 'One', attributes[:lastname]
                   assert_equal 'example1@redmine.org', attributes[:mail]
                   assert_equal auth.id, attributes[:auth_source_id]
                   attributes.keys.each do |attribute|
                     assert User.new.respond_to?("#{attribute}="), "Unexpected :#{attribute} attribute returned"
                   end
                 end
                 test '#authenticate with an invalid LDAP user should return nil' do
                   auth = AuthSourceLdap.find(1)
                   assert_nil auth.authenticate('nouser','123456')
                 end
                 test '#authenticate without a login should return nil' do
                   auth = AuthSourceLdap.find(1)
                   assert_nil auth.authenticate('','123456')
                 end
                 test '#authenticate without a password should return nil' do
                   auth = AuthSourceLdap.find(1)
                   assert_nil auth.authenticate('edavis','')
                 end
                 test '#authenticate without filter should return any user' do
                   auth = AuthSourceLdap.find(1)
                   assert auth.authenticate('example1','123456')
                   assert auth.authenticate('edavis', '123456')
                 end
                 test '#authenticate with filter should return user who matches the filter only' do
                   auth = AuthSourceLdap.find(1)
                   auth.filter = "(mail=*@redmine.org)"
                   assert auth.authenticate('example1','123456')
                   assert_nil auth.authenticate('edavis', '123456')
                 end
                 def test_authenticate_should_timeout
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.timeout = 1
                   def auth_source.initialize_ldap_con(*args); sleep(5); end
                   assert_raise AuthSourceTimeoutException do
                     auth_source.authenticate 'example1', '123456'
                   end
                 end
                 def test_search_should_return_matching_entries
                   results = AuthSource.search("exa")
                   assert_equal 1, results.size
                   result = results.first
                   assert_kind_of Hash, result
                   assert_equal "example1", result[:login]
                   assert_equal "Example", result[:firstname]
                   assert_equal "One", result[:lastname]
                   assert_equal "example1@redmine.org", result[:mail]
                   assert_equal 1, result[:auth_source_id]
                 end
                 def test_search_with_no_match_should_return_an_empty_array
                   results = AuthSource.search("wro")
                   assert_equal [], results
                 end
                 def test_search_with_exception_should_return_an_empty_array
-                  Net::LDAP.stubs(:new).raises(Net::LDAP::LdapError, 'Cannot connect')
+                  Net::LDAP.stubs(:new).raises(Net::LDAP::Error, 'Cannot connect')
                   results = AuthSource.search("exa")
                   assert_equal [], results
                 end
                 def test_test_connection_with_correct_host_and_port
                   auth_source = AuthSourceLdap.find(1)
                   assert_nothing_raised Net::LDAP::Error do
                     auth_source.test_connection
                   end
                 end
                 def test_test_connection_with_incorrect_host
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.host = "badhost"
                   auth_source.save!
                   assert_raise Net::LDAP::Error do
                     auth_source.test_connection
                   end
                 end
                 def test_test_connection_with_incorrect_port
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.port = 1234
                   auth_source.save!
                   assert_raise Net::LDAP::Error do
                     auth_source.test_connection
                   end
                 end
                 def test_test_connection_bind_with_account_and_password
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.account = "cn=admin,dc=redmine,dc=org"
                   auth_source.account_password = "secret"
                   auth_source.save!
                   assert_equal "cn=admin,dc=redmine,dc=org", auth_source.account
                   assert_equal "secret", auth_source.account_password
                   assert_nil auth_source.test_connection
                 end
                 def test_test_connection_bind_without_account_and_password
                   auth_source = AuthSourceLdap.find(1)
                   assert_nil auth_source.account
                   assert_equal "", auth_source.account_password
                   assert_nil auth_source.test_connection
                 end
                 def test_test_connection_bind_with_incorrect_account
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.account = "cn=baduser,dc=redmine,dc=org"
                   auth_source.account_password = "secret"
                   auth_source.save!
                   assert_equal "cn=baduser,dc=redmine,dc=org", auth_source.account
                   assert_equal "secret", auth_source.account_password
                   assert_raise AuthSourceException do
                     auth_source.test_connection
                   end
                 end
                 def test_test_connection_bind_with_incorrect_password
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.account = "cn=admin,dc=redmine,dc=org"
                   auth_source.account_password = "badpassword"
                   auth_source.save!
                   assert_equal "cn=admin,dc=redmine,dc=org", auth_source.account
                   assert_equal "badpassword", auth_source.account_password
                   assert_raise AuthSourceException do
                     auth_source.test_connection
                   end
                 end
               else
                 puts '(Test LDAP server not configured)'
               end
             end

test/unit/user_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class UserTest < ActiveSupport::TestCase
               fixtures :users, :email_addresses, :members, :projects, :roles, :member_roles, :auth_sources,
                         :trackers, :issue_statuses,
                         :projects_trackers,
                         :watchers,
                         :issue_categories, :enumerations, :issues,
                         :journals, :journal_details,
                         :groups_users,
                         :enabled_modules,
                         :tokens
               include Redmine::I18n
               def setup
                 @admin = User.find(1)
                 @jsmith = User.find(2)
                 @dlopper = User.find(3)
               end
               def test_sorted_scope_should_sort_user_by_display_name
                 # Use .active to ignore anonymous with localized display name
                 assert_equal User.active.map(&:name).map(&:downcase).sort,
                              User.active.sorted.map(&:name).map(&:downcase)
               end
               def test_generate
                 User.generate!(:firstname => 'Testing connection')
                 User.generate!(:firstname => 'Testing connection')
                 assert_equal 2, User.where(:firstname => 'Testing connection').count
               end
               def test_truth
                 assert_kind_of User, @jsmith
               end
               def test_should_validate_status
                 user = User.new
                 user.status = 0
                 assert !user.save
                 assert_include I18n.translate('activerecord.errors.messages.invalid'), user.errors[:status]
               end
               def test_mail_should_be_stripped
                 u = User.new
                 u.mail = " foo@bar.com  "
                 assert_equal "foo@bar.com", u.mail
               end
               def test_should_create_email_address
                 u = User.new(:firstname => "new", :lastname => "user")
                 u.login = "create_email_address"
                 u.mail = "defaultemail@somenet.foo"
                 assert u.save
                 u.reload
                 assert u.email_address
                 assert_equal "defaultemail@somenet.foo", u.email_address.address
                 assert_equal true, u.email_address.is_default
                 assert_equal true, u.email_address.notify
               end
               def test_should_not_create_user_without_mail
                 set_language_if_valid 'en'
                 u = User.new(:firstname => "new", :lastname => "user")
                 u.login = "user_without_mail"
                 assert !u.save
                 assert_equal ["Email #{I18n.translate('activerecord.errors.messages.blank')}"], u.errors.full_messages
               end
               def test_should_not_create_user_with_blank_mail
                 set_language_if_valid 'en'
                 u = User.new(:firstname => "new", :lastname => "user")
                 u.login = "user_with_blank_mail"
                 u.mail = ''
                 assert !u.save
                 assert_equal ["Email #{I18n.translate('activerecord.errors.messages.blank')}"], u.errors.full_messages
               end
               def test_should_not_update_user_with_blank_mail
                 set_language_if_valid 'en'
                 u = User.find(2)
                 u.mail = ''
                 assert !u.save
                 assert_equal ["Email #{I18n.translate('activerecord.errors.messages.blank')}"], u.errors.full_messages
               end
               def test_login_length_validation
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "x" * (User::LOGIN_LENGTH_LIMIT+1)
                 assert !user.valid?
                 user.login = "x" * (User::LOGIN_LENGTH_LIMIT)
                 assert user.valid?
                 assert user.save
               end
               def test_generate_password_should_respect_minimum_password_length
                 with_settings :password_min_length => 15 do
                   user = User.generate!(:generate_password => true)
                   assert user.password.length >= 15
                 end
               end
               def test_generate_password_should_not_generate_password_with_less_than_10_characters
                 with_settings :password_min_length => 4 do
                   user = User.generate!(:generate_password => true)
                   assert user.password.length >= 10
                 end
               end
               def test_generate_password_on_create_should_set_password
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "newuser"
                 user.generate_password = true
                 assert user.save
                 password = user.password
                 assert user.check_password?(password)
               end
               def test_generate_password_on_update_should_update_password
                 user = User.find(2)
                 hash = user.hashed_password
                 user.generate_password = true
                 assert user.save
                 password = user.password
                 assert user.check_password?(password)
                 assert_not_equal hash, user.reload.hashed_password
               end
               def test_create
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "jsmith"
                 user.password, user.password_confirmation = "password", "password"
                 # login uniqueness
                 assert !user.save
                 assert_equal 1, user.errors.count
                 user.login = "newuser"
                 user.password, user.password_confirmation = "password", "pass"
                 # password confirmation
                 assert !user.save
                 assert_equal 1, user.errors.count
                 user.password, user.password_confirmation = "password", "password"
                 assert user.save
               end
               def test_user_before_create_should_set_the_mail_notification_to_the_default_setting
                 @user1 = User.generate!
                 assert_equal 'only_my_events', @user1.mail_notification
                 with_settings :default_notification_option => 'all' do
                   @user2 = User.generate!
                   assert_equal 'all', @user2.mail_notification
                 end
               end
               def test_user_login_should_be_case_insensitive
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 u.login = 'newuser'
                 u.password, u.password_confirmation = "password", "password"
                 assert u.save
                 u = User.new(:firstname => "Similar", :lastname => "User",
                              :mail => "similaruser@somenet.foo")
                 u.login = 'NewUser'
                 u.password, u.password_confirmation = "password", "password"
                 assert !u.save
                 assert_include I18n.translate('activerecord.errors.messages.taken'), u.errors[:login]
               end
               def test_mail_uniqueness_should_not_be_case_sensitive
                 set_language_if_valid 'en'
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 u.login = 'newuser1'
                 u.password, u.password_confirmation = "password", "password"
                 assert u.save
                 u = User.new(:firstname => "new", :lastname => "user", :mail => "newUser@Somenet.foo")
                 u.login = 'newuser2'
                 u.password, u.password_confirmation = "password", "password"
                 assert !u.save
                 assert_include "Email #{I18n.translate('activerecord.errors.messages.taken')}", u.errors.full_messages
               end
               def test_update
                 assert_equal "admin", @admin.login
                 @admin.login = "john"
                 assert @admin.save, @admin.errors.full_messages.join("; ")
                 @admin.reload
                 assert_equal "john", @admin.login
               end
               def test_update_should_not_fail_for_legacy_user_with_different_case_logins
                 u1 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser1@somenet.foo")
                 u1.login = 'newuser1'
                 assert u1.save
                 u2 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser2@somenet.foo")
                 u2.login = 'newuser1'
                 assert u2.save(:validate => false)
                 user = User.find(u2.id)
                 user.firstname = "firstname"
                 assert user.save, "Save failed"
               end
               def test_destroy_should_delete_members_and_roles
                 members = Member.where(:user_id => 2)
                 ms = members.count
                 rs = members.collect(&:roles).flatten.size
                 assert ms > 0
                 assert rs > 0
                 assert_difference 'Member.count', - ms do
                   assert_difference 'MemberRole.count', - rs do
                     User.find(2).destroy
                   end
                 end
                 assert_nil User.find_by_id(2)
                 assert_equal 0, Member.where(:user_id => 2).count
               end
               def test_destroy_should_update_attachments
                 attachment = Attachment.create!(:container => Project.find(1),
                   :file => uploaded_test_file("testfile.txt", "text/plain"),
                   :author_id => 2)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, attachment.reload.author
               end
               def test_destroy_should_update_comments
                 comment = Comment.create!(
                   :commented => News.create!(:project_id => 1,
                                              :author_id => 1, :title => 'foo', :description => 'foo'),
                   :author => User.find(2),
                   :comments => 'foo'
                 )
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, comment.reload.author
               end
               def test_destroy_should_update_issues
                 issue = Issue.create!(:project_id => 1, :author_id => 2,
                                       :tracker_id => 1, :subject => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, issue.reload.author
               end
               def test_destroy_should_unassign_issues
                 issue = Issue.create!(:project_id => 1, :author_id => 1,
                                       :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil issue.reload.assigned_to
               end
               def test_destroy_should_update_journals
                 issue = Issue.create!(:project_id => 1, :author_id => 2,
                                       :tracker_id => 1, :subject => 'foo')
                 issue.init_journal(User.find(2), "update")
                 issue.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, issue.journals.first.reload.user
               end
               def test_destroy_should_update_journal_details_old_value
                 issue = Issue.create!(:project_id => 1, :author_id => 1,
                                       :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                 issue.init_journal(User.find(1), "update")
                 issue.assigned_to_id = nil
                 assert_difference 'JournalDetail.count' do
                   issue.save!
                 end
                 journal_detail = JournalDetail.order('id DESC').first
                 assert_equal '2', journal_detail.old_value
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous.id.to_s, journal_detail.reload.old_value
               end
               def test_destroy_should_update_journal_details_value
                 issue = Issue.create!(:project_id => 1, :author_id => 1,
                                       :tracker_id => 1, :subject => 'foo')
                 issue.init_journal(User.find(1), "update")
                 issue.assigned_to_id = 2
                 assert_difference 'JournalDetail.count' do
                   issue.save!
                 end
                 journal_detail = JournalDetail.order('id DESC').first
                 assert_equal '2', journal_detail.value
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous.id.to_s, journal_detail.reload.value
               end
               def test_destroy_should_update_messages
                 board = Board.create!(:project_id => 1, :name => 'Board', :description => 'Board')
                 message = Message.create!(:board_id => board.id, :author_id => 2,
                                           :subject => 'foo', :content => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, message.reload.author
               end
               def test_destroy_should_update_news
                 news = News.create!(:project_id => 1, :author_id => 2,
                                     :title => 'foo', :description => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, news.reload.author
               end
               def test_destroy_should_delete_private_queries
                 query = Query.new(:name => 'foo', :visibility => Query::VISIBILITY_PRIVATE)
                 query.project_id = 1
                 query.user_id = 2
                 query.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Query.find_by_id(query.id)
               end
               def test_destroy_should_update_public_queries
                 query = Query.new(:name => 'foo', :visibility => Query::VISIBILITY_PUBLIC)
                 query.project_id = 1
                 query.user_id = 2
                 query.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, query.reload.user
               end
               def test_destroy_should_update_time_entries
                 entry = TimeEntry.new(:hours => '2', :spent_on => Date.today,
                                       :activity => TimeEntryActivity.create!(:name => 'foo'))
                 entry.project_id = 1
                 entry.user_id = 2
                 entry.save!
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, entry.reload.user
               end
               def test_destroy_should_delete_tokens
                 token = Token.create!(:user_id => 2, :value => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Token.find_by_id(token.id)
               end
               def test_destroy_should_delete_watchers
                 issue = Issue.create!(:project_id => 1, :author_id => 1,
                                       :tracker_id => 1, :subject => 'foo')
                 watcher = Watcher.create!(:user_id => 2, :watchable => issue)
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil Watcher.find_by_id(watcher.id)
               end
               def test_destroy_should_update_wiki_contents
                 wiki_content = WikiContent.create!(
                   :text => 'foo',
                   :author_id => 2,
                   :page => WikiPage.create!(:title => 'Foo',
                                             :wiki => Wiki.create!(:project_id => 3,
                                                                   :start_page => 'Start'))
                 )
                 wiki_content.text = 'bar'
                 assert_difference 'WikiContent::Version.count' do
                   wiki_content.save!
                 end
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_equal User.anonymous, wiki_content.reload.author
                 wiki_content.versions.each do |version|
                   assert_equal User.anonymous, version.reload.author
                 end
               end
               def test_destroy_should_nullify_issue_categories
                 category = IssueCategory.create!(:project_id => 1, :assigned_to_id => 2, :name => 'foo')
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil category.reload.assigned_to_id
               end
               def test_destroy_should_nullify_changesets
                 changeset = Changeset.create!(
                   :repository => Repository::Subversion.create!(
                     :project_id => 1,
                     :url => 'file:///tmp',
                     :identifier => 'tmp'
                   ),
                   :revision => '12',
                   :committed_on => Time.now,
                   :committer => 'jsmith'
                   )
                 assert_equal 2, changeset.user_id
                 User.find(2).destroy
                 assert_nil User.find_by_id(2)
                 assert_nil changeset.reload.user_id
               end
               def test_anonymous_user_should_not_be_destroyable
                 assert_no_difference 'User.count' do
                   assert_equal false, User.anonymous.destroy
                 end
               end
               def test_password_change_should_destroy_tokens
                 recovery_token = Token.create!(:user_id => 2, :action => 'recovery')
                 autologin_token = Token.create!(:user_id => 2, :action => 'autologin')
                 user = User.find(2)
                 user.password, user.password_confirmation = "a new password", "a new password"
                 assert user.save
                 assert_nil Token.find_by_id(recovery_token.id)
                 assert_nil Token.find_by_id(autologin_token.id)
               end
               def test_mail_change_should_destroy_tokens
                 recovery_token = Token.create!(:user_id => 2, :action => 'recovery')
                 autologin_token = Token.create!(:user_id => 2, :action => 'autologin')
                 user = User.find(2)
                 user.mail = "user@somwehere.com"
                 assert user.save
                 assert_nil Token.find_by_id(recovery_token.id)
                 assert_equal autologin_token, Token.find_by_id(autologin_token.id)
               end
               def test_change_on_other_fields_should_not_destroy_tokens
                 recovery_token = Token.create!(:user_id => 2, :action => 'recovery')
                 autologin_token = Token.create!(:user_id => 2, :action => 'autologin')
                 user = User.find(2)
                 user.firstname = "Bobby"
                 assert user.save
                 assert_equal recovery_token, Token.find_by_id(recovery_token.id)
                 assert_equal autologin_token, Token.find_by_id(autologin_token.id)
               end
               def test_validate_login_presence
                 @admin.login = ""
                 assert !@admin.save
                 assert_equal 1, @admin.errors.count
               end
               def test_validate_mail_notification_inclusion
                 u = User.new
                 u.mail_notification = 'foo'
                 u.save
                 assert_not_equal [], u.errors[:mail_notification]
               end
               def test_password
                 user = User.try_to_login("admin", "admin")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
                 user.password = "hello123"
                 assert user.save
                 user = User.try_to_login("admin", "hello123")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
               end
               def test_validate_password_length
                 with_settings :password_min_length => '100' do
                   user = User.new(:firstname => "new100",
                                   :lastname => "user100", :mail => "newuser100@somenet.foo")
                   user.login = "newuser100"
                   user.password, user.password_confirmation = "password100", "password100"
                   assert !user.save
                   assert_equal 1, user.errors.count
                 end
               end
               def test_name_format
                 assert_equal 'John S.', @jsmith.name(:firstname_lastinitial)
                 assert_equal 'Smith, John', @jsmith.name(:lastname_comma_firstname)
                 assert_equal 'J. Smith', @jsmith.name(:firstinitial_lastname)
                 assert_equal 'J.-P. Lang', User.new(:firstname => 'Jean-Philippe', :lastname => 'Lang').name(:firstinitial_lastname)
               end
               def test_name_should_use_setting_as_default_format
                 with_settings :user_format => :firstname_lastname do
                   assert_equal 'John Smith', @jsmith.reload.name
                 end
                 with_settings :user_format => :username do
                   assert_equal 'jsmith', @jsmith.reload.name
                 end
                 with_settings :user_format => :lastname do
                   assert_equal 'Smith', @jsmith.reload.name
                 end
               end
               def test_today_should_return_the_day_according_to_user_time_zone
                 preference = User.find(1).pref
                 date = Date.new(2012, 05, 15)
                 time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                 Date.stubs(:today).returns(date)
                 Time.stubs(:now).returns(time)
                 preference.update_attribute :time_zone, 'Baku' # UTC+4
                 assert_equal '2012-05-16', User.find(1).today.to_s
                 preference.update_attribute :time_zone, 'La Paz' # UTC-4
                 assert_equal '2012-05-15', User.find(1).today.to_s
                 preference.update_attribute :time_zone, ''
                 assert_equal '2012-05-15', User.find(1).today.to_s
               end
               def test_time_to_date_should_return_the_date_according_to_user_time_zone
                 preference = User.find(1).pref
                 time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                 preference.update_attribute :time_zone, 'Baku' # UTC+4
                 assert_equal '2012-05-16', User.find(1).time_to_date(time).to_s
                 preference.update_attribute :time_zone, 'La Paz' # UTC-4
                 assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
                 preference.update_attribute :time_zone, ''
                 assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
               end
               def test_fields_for_order_statement_should_return_fields_according_user_format_setting
                 with_settings :user_format => 'lastname_comma_firstname' do
                   assert_equal ['users.lastname', 'users.firstname', 'users.id'],
                                User.fields_for_order_statement
                 end
               end
               def test_fields_for_order_statement_width_table_name_should_prepend_table_name
                 with_settings :user_format => 'lastname_firstname' do
                   assert_equal ['authors.lastname', 'authors.firstname', 'authors.id'],
                                User.fields_for_order_statement('authors')
                 end
               end
               def test_fields_for_order_statement_with_blank_format_should_return_default
                 with_settings :user_format => '' do
                   assert_equal ['users.firstname', 'users.lastname', 'users.id'],
                                User.fields_for_order_statement
                 end
               end
               def test_fields_for_order_statement_with_invalid_format_should_return_default
                 with_settings :user_format => 'foo' do
                   assert_equal ['users.firstname', 'users.lastname', 'users.id'],
                                User.fields_for_order_statement
                 end
               end
               test ".try_to_login with good credentials should return the user" do
                 user = User.try_to_login("admin", "admin")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
               end
               test ".try_to_login with wrong credentials should return nil" do
                 assert_nil User.try_to_login("admin", "foo")
               end
               def test_try_to_login_with_locked_user_should_return_nil
                 @jsmith.status = User::STATUS_LOCKED
                 @jsmith.save!
                 user = User.try_to_login("jsmith", "jsmith")
                 assert_nil user
               end
               def test_try_to_login_with_locked_user_and_not_active_only_should_return_user
                 @jsmith.status = User::STATUS_LOCKED
                 @jsmith.save!
                 user = User.try_to_login("jsmith", "jsmith", false)
                 assert_equal @jsmith, user
               end
               test ".try_to_login should fall-back to case-insensitive if user login is not found as-typed" do
                 user = User.try_to_login("AdMin", "admin")
                 assert_kind_of User, user
                 assert_equal "admin", user.login
               end
               test ".try_to_login should select the exact matching user first" do
                 case_sensitive_user = User.generate! do |user|
                   user.password = "admin123"
                 end
                 # bypass validations to make it appear like existing data
                 case_sensitive_user.update_attribute(:login, 'ADMIN')
                 user = User.try_to_login("ADMIN", "admin123")
                 assert_kind_of User, user
                 assert_equal "ADMIN", user.login
               end
               if ldap_configured?
                 test "#try_to_login using LDAP with failed connection to the LDAP server" do
                   auth_source = AuthSourceLdap.find(1)
-                  AuthSource.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::LdapError, 'Cannot connect')
+                  AuthSource.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::Error, 'Cannot connect')
                   assert_nil User.try_to_login('edavis', 'wrong')
                 end
                 test "#try_to_login using LDAP" do
                   assert_nil User.try_to_login('edavis', 'wrong')
                 end
                 test "#try_to_login using LDAP binding with user's account" do
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                   auth_source.account_password = ''
                   auth_source.save!
                   ldap_user = User.new(:mail => 'example1@redmine.org', :firstname => 'LDAP', :lastname => 'user', :auth_source_id => 1)
                   ldap_user.login = 'example1'
                   ldap_user.save!
                   assert_equal ldap_user, User.try_to_login('example1', '123456')
                   assert_nil User.try_to_login('example1', '11111')
                 end
                 test "#try_to_login using LDAP on the fly registration" do
                   AuthSourceLdap.find(1).update_attribute :onthefly_register, true
                   assert_difference('User.count') do
                     assert User.try_to_login('edavis', '123456')
                   end
                   assert_no_difference('User.count') do
                     assert User.try_to_login('edavis', '123456')
                   end
                   assert_nil User.try_to_login('example1', '11111')
                 end
                 test "#try_to_login using LDAP on the fly registration and binding with user's account" do
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.update_attribute :onthefly_register, true
                   auth_source = AuthSourceLdap.find(1)
                   auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                   auth_source.account_password = ''
                   auth_source.save!
                   assert_difference('User.count') do
                     assert User.try_to_login('example1', '123456')
                   end
                   assert_no_difference('User.count') do
                     assert User.try_to_login('example1', '123456')
                   end
                   assert_nil User.try_to_login('example1', '11111')
                 end
               else
                 puts "Skipping LDAP tests."
               end
               def test_create_anonymous
                 AnonymousUser.delete_all
                 anon = User.anonymous
                 assert !anon.new_record?
                 assert_kind_of AnonymousUser, anon
               end
               def test_ensure_single_anonymous_user
                 AnonymousUser.delete_all
                 anon1 = User.anonymous
                 assert !anon1.new_record?
                 assert_kind_of AnonymousUser, anon1
                 anon2 = AnonymousUser.create(
                             :lastname => 'Anonymous', :firstname => '',
                             :login => '', :status => 0)
                 assert_equal 1, anon2.errors.count
               end
               def test_rss_key
                 assert_nil @jsmith.rss_token
                 key = @jsmith.rss_key
                 assert_equal 40, key.length
                 @jsmith.reload
                 assert_equal key, @jsmith.rss_key
               end
               def test_rss_key_should_not_be_generated_twice
                 assert_difference 'Token.count', 1 do
                   key1 = @jsmith.rss_key
                   key2 = @jsmith.rss_key
                   assert_equal key1, key2
                 end
               end
               def test_api_key_should_not_be_generated_twice
                 assert_difference 'Token.count', 1 do
                   key1 = @jsmith.api_key
                   key2 = @jsmith.api_key
                   assert_equal key1, key2
                 end
               end
               test "#api_key should generate a new one if the user doesn't have one" do
                 user = User.generate!(:api_token => nil)
                 assert_nil user.api_token
                 key = user.api_key
                 assert_equal 40, key.length
                 user.reload
                 assert_equal key, user.api_key
               end
               test "#api_key should return the existing api token value" do
                 user = User.generate!
                 token = Token.create!(:action => 'api')
                 user.api_token = token
                 assert user.save
                 assert_equal token.value, user.api_key
               end
               test "#find_by_api_key should return nil if no matching key is found" do
                 assert_nil User.find_by_api_key('zzzzzzzzz')
               end
               test "#find_by_api_key should return nil if the key is found for an inactive user" do
                 user = User.generate!
                 user.status = User::STATUS_LOCKED
                 token = Token.create!(:action => 'api')
                 user.api_token = token
                 user.save
                 assert_nil User.find_by_api_key(token.value)
               end
               test "#find_by_api_key should return the user if the key is found for an active user" do
                 user = User.generate!
                 token = Token.create!(:action => 'api')
                 user.api_token = token
                 user.save
                 assert_equal user, User.find_by_api_key(token.value)
               end
               def test_default_admin_account_changed_should_return_false_if_account_was_not_changed
                 user = User.find_by_login("admin")
                 user.password = "admin"
                 assert user.save(:validate => false)
                 assert_equal false, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_password_was_changed
                 user = User.find_by_login("admin")
                 user.password = "newpassword"
                 user.save!
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_account_is_disabled
                 user = User.find_by_login("admin")
                 user.password = "admin"
                 user.status = User::STATUS_LOCKED
                 assert user.save(:validate => false)
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_default_admin_account_changed_should_return_true_if_account_does_not_exist
                 user = User.find_by_login("admin")
                 user.destroy
                 assert_equal true, User.default_admin_account_changed?
               end
               def test_membership_with_project_should_return_membership
                 project = Project.find(1)
                 membership = @jsmith.membership(project)
                 assert_kind_of Member, membership
                 assert_equal @jsmith, membership.user
                 assert_equal project, membership.project
               end
               def test_membership_with_project_id_should_return_membership
                 project = Project.find(1)
                 membership = @jsmith.membership(1)
                 assert_kind_of Member, membership
                 assert_equal @jsmith, membership.user
                 assert_equal project, membership.project
               end
               def test_membership_for_non_member_should_return_nil
                 project = Project.find(1)
                 user = User.generate!
                 membership = user.membership(1)
                 assert_nil membership
               end
               def test_roles_for_project_with_member_on_public_project_should_return_roles_and_non_member
                 roles = @jsmith.roles_for_project(Project.find(1))
                 assert_kind_of Role, roles.first
                 assert_equal ["Manager"], roles.map(&:name)
               end
               def test_roles_for_project_with_member_on_private_project_should_return_roles
                 Project.find(1).update_attribute :is_public, false
                 roles = @jsmith.roles_for_project(Project.find(1))
                 assert_kind_of Role, roles.first
                 assert_equal ["Manager"], roles.map(&:name)
               end
               def test_roles_for_project_with_non_member_with_public_project_should_return_non_member
                 set_language_if_valid 'en'
                 roles = User.find(8).roles_for_project(Project.find(1))
                 assert_equal ["Non member"], roles.map(&:name)
               end
               def test_roles_for_project_with_non_member_with_public_project_and_override_should_return_override_roles
                 project = Project.find(1)
                 Member.create!(:project => project, :principal => Group.non_member, :role_ids => [1, 2])
                 roles = User.find(8).roles_for_project(project)
                 assert_equal ["Developer", "Manager"], roles.map(&:name).sort
               end
               def test_roles_for_project_with_non_member_with_private_project_should_return_no_roles
                 Project.find(1).update_attribute :is_public, false
                 roles = User.find(8).roles_for_project(Project.find(1))
                 assert_equal [], roles.map(&:name)
               end
               def test_roles_for_project_with_non_member_with_private_project_and_override_should_return_no_roles
                 project = Project.find(1)
                 project.update_attribute :is_public, false
                 Member.create!(:project => project, :principal => Group.non_member, :role_ids => [1, 2])
                 roles = User.find(8).roles_for_project(project)
                 assert_equal [], roles.map(&:name).sort
               end
               def test_roles_for_project_with_anonymous_with_public_project_should_return_anonymous
                 set_language_if_valid 'en'
                 roles = User.anonymous.roles_for_project(Project.find(1))
                 assert_equal ["Anonymous"], roles.map(&:name)
               end
               def test_roles_for_project_with_anonymous_with_public_project_and_override_should_return_override_roles
                 project = Project.find(1)
                 Member.create!(:project => project, :principal => Group.anonymous, :role_ids => [1, 2])
                 roles = User.anonymous.roles_for_project(project)
                 assert_equal ["Developer", "Manager"], roles.map(&:name).sort
               end
               def test_roles_for_project_with_anonymous_with_private_project_should_return_no_roles
                 Project.find(1).update_attribute :is_public, false
                 roles = User.anonymous.roles_for_project(Project.find(1))
                 assert_equal [], roles.map(&:name)
               end
               def test_roles_for_project_with_anonymous_with_private_project_and_override_should_return_no_roles
                 project = Project.find(1)
                 project.update_attribute :is_public, false
                 Member.create!(:project => project, :principal => Group.anonymous, :role_ids => [1, 2])
                 roles = User.anonymous.roles_for_project(project)
                 assert_equal [], roles.map(&:name).sort
               end
               def test_roles_for_project_should_be_unique
                 m = Member.new(:user_id => 1, :project_id => 1)
                 m.member_roles.build(:role_id => 1)
                 m.member_roles.build(:role_id => 1)
                 m.save!
                 user = User.find(1)
                 project = Project.find(1)
                 assert_equal 1, user.roles_for_project(project).size
                 assert_equal [1], user.roles_for_project(project).map(&:id)
               end
               def test_projects_by_role_for_user_with_role
                 user = User.find(2)
                 assert_kind_of Hash, user.projects_by_role
                 assert_equal 2, user.projects_by_role.size
                 assert_equal [1,5], user.projects_by_role[Role.find(1)].collect(&:id).sort
                 assert_equal [2], user.projects_by_role[Role.find(2)].collect(&:id).sort
               end
               def test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array
                 user = User.find(2)
                 assert_equal [], user.projects_by_role[Role.find(3)]
                 # should not update the hash
                 assert_nil user.projects_by_role.values.detect(&:blank?)
               end
               def test_projects_by_role_for_user_with_no_role
                 user = User.generate!
                 assert_equal({}, user.projects_by_role)
               end
               def test_projects_by_role_for_anonymous
                 assert_equal({}, User.anonymous.projects_by_role)
               end
               def test_valid_notification_options
                 # without memberships
                 assert_equal 5, User.find(7).valid_notification_options.size
                 # with memberships
                 assert_equal 6, User.find(2).valid_notification_options.size
               end
               def test_valid_notification_options_class_method
                 assert_equal 5, User.valid_notification_options.size
                 assert_equal 5, User.valid_notification_options(User.find(7)).size
                 assert_equal 6, User.valid_notification_options(User.find(2)).size
               end
               def test_notified_project_ids_setter_should_coerce_to_unique_integer_array
                 @jsmith.notified_project_ids = ["1", "123", "2u", "wrong", "12", 6, 12, -35, ""]
                 assert_equal [1, 123, 2, 12, 6], @jsmith.notified_projects_ids
               end
               def test_mail_notification_all
                 @jsmith.mail_notification = 'all'
                 @jsmith.notified_project_ids = []
                 @jsmith.save
                 @jsmith.reload
                 assert @jsmith.projects.first.recipients.include?(@jsmith.mail)
               end
               def test_mail_notification_selected
                 @jsmith.mail_notification = 'selected'
                 @jsmith.notified_project_ids = [1]
                 @jsmith.save
                 @jsmith.reload
                 assert Project.find(1).recipients.include?(@jsmith.mail)
               end
               def test_mail_notification_only_my_events
                 @jsmith.mail_notification = 'only_my_events'
                 @jsmith.notified_project_ids = []
                 @jsmith.save
                 @jsmith.reload
                 assert !@jsmith.projects.first.recipients.include?(@jsmith.mail)
               end
               def test_comments_sorting_preference
                 assert !@jsmith.wants_comments_in_reverse_order?
                 @jsmith.pref.comments_sorting = 'asc'
                 assert !@jsmith.wants_comments_in_reverse_order?
                 @jsmith.pref.comments_sorting = 'desc'
                 assert @jsmith.wants_comments_in_reverse_order?
               end
               def test_find_by_mail_should_be_case_insensitive
                 u = User.find_by_mail('JSmith@somenet.foo')
                 assert_not_nil u
                 assert_equal 'jsmith@somenet.foo', u.mail
               end
               def test_random_password
                 u = User.new
                 u.random_password
                 assert !u.password.blank?
                 assert !u.password_confirmation.blank?
               end
               test "#change_password_allowed? should be allowed if no auth source is set" do
                 user = User.generate!
                 assert user.change_password_allowed?
               end
               test "#change_password_allowed? should delegate to the auth source" do
                 user = User.generate!
                 allowed_auth_source = AuthSource.generate!
                 def allowed_auth_source.allow_password_changes?; true; end
                 denied_auth_source = AuthSource.generate!
                 def denied_auth_source.allow_password_changes?; false; end
                 assert user.change_password_allowed?
                 user.auth_source = allowed_auth_source
                 assert user.change_password_allowed?, "User not allowed to change password, though auth source does"
                 user.auth_source = denied_auth_source
                 assert !user.change_password_allowed?, "User allowed to change password, though auth source does not"
               end
               def test_own_account_deletable_should_be_true_with_unsubscrive_enabled
                 with_settings :unsubscribe => '1' do
                   assert_equal true, User.find(2).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_false_with_unsubscrive_disabled
                 with_settings :unsubscribe => '0' do
                   assert_equal false, User.find(2).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_false_for_a_single_admin
                 User.where(["admin = ? AND id <> ?", true, 1]).delete_all
                 with_settings :unsubscribe => '1' do
                   assert_equal false, User.find(1).own_account_deletable?
                 end
               end
               def test_own_account_deletable_should_be_true_for_an_admin_if_other_admin_exists
                 User.generate! do |user|
                   user.admin = true
                 end
                 with_settings :unsubscribe => '1' do
                   assert_equal true, User.find(1).own_account_deletable?
                 end
               end
               test "#allowed_to? for archived project should return false" do
                 project = Project.find(1)
                 project.archive
                 project.reload
                 assert_equal false, @admin.allowed_to?(:view_issues, project)
               end
               test "#allowed_to? for closed project should return true for read actions" do
                 project = Project.find(1)
                 project.close
                 project.reload
                 assert_equal false, @admin.allowed_to?(:edit_project, project)
                 assert_equal true, @admin.allowed_to?(:view_project, project)
               end
               test "#allowed_to? for project with module disabled should return false" do
                 project = Project.find(1)
                 project.enabled_module_names = ["issue_tracking"]
                 assert_equal true, @admin.allowed_to?(:add_issues, project)
                 assert_equal false, @admin.allowed_to?(:view_wiki_pages, project)
               end
               test "#allowed_to? for admin users should return true" do
                 project = Project.find(1)
                 assert ! @admin.member_of?(project)
                 %w(edit_issues delete_issues manage_news add_documents manage_wiki).each do |p|
                   assert_equal true, @admin.allowed_to?(p.to_sym, project)
                 end
               end
               test "#allowed_to? for normal users" do
                 project = Project.find(1)
                 assert_equal true, @jsmith.allowed_to?(:delete_messages, project)    #Manager
                 assert_equal false, @dlopper.allowed_to?(:delete_messages, project) #Developper
               end
               test "#allowed_to? with empty array should return false" do
                 assert_equal false, @admin.allowed_to?(:view_project, [])
               end
               test "#allowed_to? with multiple projects" do
                 assert_equal true, @admin.allowed_to?(:view_project, Project.all.to_a)
                 assert_equal false, @dlopper.allowed_to?(:view_project, Project.all.to_a) #cannot see Project(2)
                 assert_equal true, @jsmith.allowed_to?(:edit_issues, @jsmith.projects.to_a) #Manager or Developer everywhere
                 assert_equal false, @jsmith.allowed_to?(:delete_issue_watchers, @jsmith.projects.to_a) #Dev cannot delete_issue_watchers
               end
               test "#allowed_to? with with options[:global] should return true if user has one role with the permission" do
                 @dlopper2 = User.find(5) #only Developper on a project, not Manager anywhere
                 @anonymous = User.find(6)
                 assert_equal true, @jsmith.allowed_to?(:delete_issue_watchers, nil, :global => true)
                 assert_equal false, @dlopper2.allowed_to?(:delete_issue_watchers, nil, :global => true)
                 assert_equal true, @dlopper2.allowed_to?(:add_issues, nil, :global => true)
                 assert_equal false, @anonymous.allowed_to?(:add_issues, nil, :global => true)
                 assert_equal true, @anonymous.allowed_to?(:view_issues, nil, :global => true)
               end
               # this is just a proxy method, the test only calls it to ensure it doesn't break trivially
               test "#allowed_to_globally?" do
                 @dlopper2 = User.find(5) #only Developper on a project, not Manager anywhere
                 @anonymous = User.find(6)
                 assert_equal true, @jsmith.allowed_to_globally?(:delete_issue_watchers)
                 assert_equal false, @dlopper2.allowed_to_globally?(:delete_issue_watchers)
                 assert_equal true, @dlopper2.allowed_to_globally?(:add_issues)
                 assert_equal false, @anonymous.allowed_to_globally?(:add_issues)
                 assert_equal true, @anonymous.allowed_to_globally?(:view_issues)
               end
               def test_notify_about_issue
                 project = Project.find(1)
                 author = User.generate!
                 assignee = User.generate!
                 Member.create!(:user => assignee, :project => project, :role_ids => [1])
                 member = User.generate!
                 Member.create!(:user => member, :project => project, :role_ids => [1])
                 issue = Issue.generate!(:project => project, :assigned_to => assignee, :author => author)
                 tests = {
                   author => %w(all only_my_events only_owner selected),
                   assignee => %w(all only_my_events only_assigned selected),
                   member => %w(all)
                 }
                 tests.each do |user, expected|
                   User::MAIL_NOTIFICATION_OPTIONS.map(&:first).each do |option|
                     user.mail_notification = option
                     assert_equal expected.include?(option), user.notify_about?(issue)
                   end
                 end
               end
               def test_notify_about_issue_for_previous_assignee
                 assignee = User.generate!(:mail_notification => 'only_assigned')
                 Member.create!(:user => assignee, :project_id => 1, :role_ids => [1])
                 new_assignee = User.generate!(:mail_notification => 'only_assigned')
                 Member.create!(:user => new_assignee, :project_id => 1, :role_ids => [1])
                 issue = Issue.generate!(:assigned_to => assignee)
                 assert assignee.notify_about?(issue)
                 assert !new_assignee.notify_about?(issue)
                 issue.assigned_to = new_assignee
                 assert assignee.notify_about?(issue)
                 assert new_assignee.notify_about?(issue)
                 issue.save!
                 assert !assignee.notify_about?(issue)
                 assert new_assignee.notify_about?(issue)
               end
               def test_notify_about_news
                 user = User.generate!
                 news = News.new
                 User::MAIL_NOTIFICATION_OPTIONS.map(&:first).each do |option|
                   user.mail_notification = option
                   assert_equal (option != 'none'), user.notify_about?(news)
                 end
               end
               def test_salt_unsalted_passwords
                 # Restore a user with an unsalted password
                 user = User.find(1)
                 user.salt = nil
                 user.hashed_password = User.hash_password("unsalted")
                 user.save!
                 User.salt_unsalted_passwords!
                 user.reload
                 # Salt added
                 assert !user.salt.blank?
                 # Password still valid
                 assert user.check_password?("unsalted")
                 assert_equal user, User.try_to_login(user.login, "unsalted")
               end
               if Object.const_defined?(:OpenID)
                 def test_setting_identity_url
                   normalized_open_id_url = 'http://example.com/'
                   u = User.new( :identity_url => 'http://example.com/' )
                   assert_equal normalized_open_id_url, u.identity_url
                 end
                 def test_setting_identity_url_without_trailing_slash
                   normalized_open_id_url = 'http://example.com/'
                   u = User.new( :identity_url => 'http://example.com' )
                   assert_equal normalized_open_id_url, u.identity_url
                 end
                 def test_setting_identity_url_without_protocol
                   normalized_open_id_url = 'http://example.com/'
                   u = User.new( :identity_url => 'example.com' )
                   assert_equal normalized_open_id_url, u.identity_url
                 end
                 def test_setting_blank_identity_url
                   u = User.new( :identity_url => 'example.com' )
                   u.identity_url = ''
                   assert u.identity_url.blank?
                 end
                 def test_setting_invalid_identity_url
                   u = User.new( :identity_url => 'this is not an openid url' )
                   assert u.identity_url.blank?
                 end
               else
                 puts "Skipping openid tests."
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages