jro_apps/redmine Commit - r15272:d2f7e31951d0

Use .distinct instead of .uniq....

Jean-Philippe Lang -

r15272:d2f7e31951d0

parent child

Context file:

r15272:d2f7e31951d0

Collapse all files

app/controllers/versions_controller.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class VersionsController < ApplicationController
               menu_item :roadmap
               model_object Version
               before_filter :find_model_object, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project_from_association, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project_by_project_id, :only => [:index, :new, :create, :close_completed]
               before_filter :authorize
               accept_api_auth :index, :show, :create, :update, :destroy
               helper :custom_fields
               helper :projects
               def index
                 respond_to do |format|
                   format.html {
                     @trackers = @project.trackers.sorted.to_a
                     retrieve_selected_tracker_ids(@trackers, @trackers.select {|t| t.is_in_roadmap?})
                     @with_subprojects = params[:with_subprojects].nil? ? Setting.display_subprojects_issues? : (params[:with_subprojects] == '1')
                     project_ids = @with_subprojects ? @project.self_and_descendants.collect(&:id) : [@project.id]
                     @versions = @project.shared_versions.preload(:custom_values)
                     @versions += @project.rolled_up_versions.visible.preload(:custom_values) if @with_subprojects
-                    @versions = @versions.uniq.sort
+                    @versions = @versions.to_a.uniq.sort
                     unless params[:completed]
                       @completed_versions = @versions.select(&:completed?)
                       @versions -= @completed_versions
                     end
                     @issues_by_version = {}
                     if @selected_tracker_ids.any? && @versions.any?
                       issues = Issue.visible.
                         includes(:project, :tracker).
                         preload(:status, :priority, :fixed_version).
                         where(:tracker_id => @selected_tracker_ids, :project_id => project_ids, :fixed_version_id => @versions.map(&:id)).
                         order("#{Project.table_name}.lft, #{Tracker.table_name}.position, #{Issue.table_name}.id")
                       @issues_by_version = issues.group_by(&:fixed_version)
                     end
                     @versions.reject! {|version| !project_ids.include?(version.project_id) && @issues_by_version[version].blank?}
                   }
                   format.api {
                     @versions = @project.shared_versions.to_a
                   }
                 end
               end
               def show
                 respond_to do |format|
                   format.html {
                     @issues = @version.fixed_issues.visible.
                       includes(:status, :tracker, :priority).
                       preload(:project).
                       reorder("#{Tracker.table_name}.position, #{Issue.table_name}.id").
                       to_a
                   }
                   format.api
                 end
               end
               def new
                 @version = @project.versions.build
                 @version.safe_attributes = params[:version]
                 respond_to do |format|
                   format.html
                   format.js
                 end
               end
               def create
                 @version = @project.versions.build
                 if params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless attributes.nil? || @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                 end
                 if request.post?
                   if @version.save
                     respond_to do |format|
                       format.html do
                         flash[:notice] = l(:notice_successful_create)
                         redirect_back_or_default settings_project_path(@project, :tab => 'versions')
                       end
                       format.js
                       format.api do
                         render :action => 'show', :status => :created, :location => version_url(@version)
                       end
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'new' }
                       format.js   { render :action => 'new' }
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def edit
               end
               def update
                 if params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                   if @version.save
                     respond_to do |format|
                       format.html {
                         flash[:notice] = l(:notice_successful_update)
                         redirect_back_or_default settings_project_path(@project, :tab => 'versions')
                       }
                       format.api  { render_api_ok }
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'edit' }
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def close_completed
                 if request.put?
                   @project.close_completed_versions
                 end
                 redirect_to settings_project_path(@project, :tab => 'versions')
               end
               def destroy
                 if @version.deletable?
                   @version.destroy
                   respond_to do |format|
                     format.html { redirect_back_or_default settings_project_path(@project, :tab => 'versions') }
                     format.api  { render_api_ok }
                   end
                 else
                   respond_to do |format|
                     format.html {
                       flash[:error] = l(:notice_unable_delete_version)
                       redirect_to settings_project_path(@project, :tab => 'versions')
                     }
                     format.api  { head :unprocessable_entity }
                   end
                 end
               end
               def status_by
                 respond_to do |format|
                   format.html { render :action => 'show' }
                   format.js
                 end
               end
               private
               def retrieve_selected_tracker_ids(selectable_trackers, default_trackers=nil)
                 if ids = params[:tracker_ids]
                   @selected_tracker_ids = (ids.is_a? Array) ? ids.collect { |id| id.to_i.to_s } : ids.split('/').collect { |id| id.to_i.to_s }
                 else
                   @selected_tracker_ids = (default_trackers || selectable_trackers).collect {|t| t.id.to_s }
                 end
               end
             end

app/models/issue_status.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssueStatus < ActiveRecord::Base
               before_destroy :check_integrity
               has_many :workflows, :class_name => 'WorkflowTransition', :foreign_key => "old_status_id"
               has_many :workflow_transitions_as_new_status, :class_name => 'WorkflowTransition', :foreign_key => "new_status_id"
               acts_as_positioned
               after_update :handle_is_closed_change
               before_destroy :delete_workflow_rules
               validates_presence_of :name
               validates_uniqueness_of :name
               validates_length_of :name, :maximum => 30
               validates_inclusion_of :default_done_ratio, :in => 0..100, :allow_nil => true
               attr_protected :id
               scope :sorted, lambda { order(:position) }
               scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
               # Update all the +Issues+ setting their done_ratio to the value of their +IssueStatus+
               def self.update_issue_done_ratios
                 if Issue.use_status_for_done_ratio?
                   IssueStatus.where("default_done_ratio >= 0").each do |status|
                     Issue.where({:status_id => status.id}).update_all({:done_ratio => status.default_done_ratio})
                   end
                 end
                 return Issue.use_status_for_done_ratio?
               end
               # Returns an array of all statuses the given role can switch to
               def new_statuses_allowed_to(roles, tracker, author=false, assignee=false)
                 self.class.new_statuses_allowed(self, roles, tracker, author, assignee)
               end
               alias :find_new_statuses_allowed_to :new_statuses_allowed_to
               def self.new_statuses_allowed(status, roles, tracker, author=false, assignee=false)
                 if roles.present? && tracker
                   status_id = status.try(:id) || 0
                   scope = IssueStatus.
                     joins(:workflow_transitions_as_new_status).
                     where(:workflows => {:old_status_id => status_id, :role_id => roles.map(&:id), :tracker_id => tracker.id})
                   unless author && assignee
                     if author || assignee
                       scope = scope.where("author = ? OR assignee = ?", author, assignee)
                     else
                       scope = scope.where("author = ? AND assignee = ?", false, false)
                     end
                   end
-                  scope.uniq.to_a.sort
+                  scope.distinct.to_a.sort
                 else
                   []
                 end
               end
               def <=>(status)
                 position <=> status.position
               end
               def to_s; name end
               private
               # Updates issues closed_on attribute when an existing status is set as closed.
               def handle_is_closed_change
                 if is_closed_changed? && is_closed == true
                   # First we update issues that have a journal for when the current status was set,
                   # a subselect is used to update all issues with a single query
                   subselect = "SELECT MAX(j.created_on) FROM #{Journal.table_name} j" +
                     " JOIN #{JournalDetail.table_name} d ON d.journal_id = j.id" +
                     " WHERE j.journalized_type = 'Issue' AND j.journalized_id = #{Issue.table_name}.id" +
                     " AND d.property = 'attr' AND d.prop_key = 'status_id' AND d.value = :status_id"
                   Issue.where(:status_id => id, :closed_on => nil).
                     update_all(["closed_on = (#{subselect})", {:status_id => id.to_s}])
                   # Then we update issues that don't have a journal which means the
                   # current status was set on creation
                   Issue.where(:status_id => id, :closed_on => nil).update_all("closed_on = created_on")
                 end
               end
               def check_integrity
                 if Issue.where(:status_id => id).any?
                   raise "This status is used by some issues"
                 elsif Tracker.where(:default_status_id => id).any?
                   raise "This status is used as the default status by some trackers"
                 end
               end
               # Deletes associated workflows
               def delete_workflow_rules
                 WorkflowRule.delete_all(["old_status_id = :id OR new_status_id = :id", {:id => id}])
               end
             end

app/models/journal.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Journal < ActiveRecord::Base
               include Redmine::SafeAttributes
               belongs_to :journalized, :polymorphic => true
               # added as a quick fix to allow eager loading of the polymorphic association
               # since always associated to an issue, for now
               belongs_to :issue, :foreign_key => :journalized_id
               belongs_to :user
               has_many :details, :class_name => "JournalDetail", :dependent => :delete_all, :inverse_of => :journal
               attr_accessor :indice
               attr_protected :id
               acts_as_event :title => Proc.new {|o| status = ((s = o.new_status) ? " (#{s})" : nil); "#{o.issue.tracker} ##{o.issue.id}#{status}: #{o.issue.subject}" },
                             :description => :notes,
                             :author => :user,
                             :group => :issue,
                             :type => Proc.new {|o| (s = o.new_status) ? (s.is_closed? ? 'issue-closed' : 'issue-edit') : 'issue-note' },
                             :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.issue.id, :anchor => "change-#{o.id}"}}
               acts_as_activity_provider :type => 'issues',
                                         :author_key => :user_id,
                                         :scope => preload({:issue => :project}, :user).
                                                   joins("LEFT OUTER JOIN #{JournalDetail.table_name} ON #{JournalDetail.table_name}.journal_id = #{Journal.table_name}.id").
                                                   where("#{Journal.table_name}.journalized_type = 'Issue' AND" +
-                                                        " (#{JournalDetail.table_name}.prop_key = 'status_id' OR #{Journal.table_name}.notes <> '')").uniq
+                                                        " (#{JournalDetail.table_name}.prop_key = 'status_id' OR #{Journal.table_name}.notes <> '')").distinct
               before_create :split_private_notes
               after_create :send_notification
               scope :visible, lambda {|*args|
                 user = args.shift || User.current
                 joins(:issue => :project).
                   where(Issue.visible_condition(user, *args)).
                   where("(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(user, :view_private_notes, *args)}))", false)
               }
               safe_attributes 'notes',
                 :if => lambda {|journal, user| journal.new_record? || journal.editable_by?(user)}
               safe_attributes 'private_notes',
                 :if => lambda {|journal, user| user.allowed_to?(:set_notes_private, journal.project)}
               def initialize(*args)
                 super
                 if journalized
                   if journalized.new_record?
                     self.notify = false
                   else
                     start
                   end
                 end
               end
               def save(*args)
                 journalize_changes
                 # Do not save an empty journal
                 (details.empty? && notes.blank?) ? false : super
               end
               # Returns journal details that are visible to user
               def visible_details(user=User.current)
                 details.select do |detail|
                   if detail.property == 'cf'
                     detail.custom_field && detail.custom_field.visible_by?(project, user)
                   elsif detail.property == 'relation'
                     Issue.find_by_id(detail.value || detail.old_value).try(:visible?, user)
                   else
                     true
                   end
                 end
               end
               def each_notification(users, &block)
                 if users.any?
                   users_by_details_visibility = users.group_by do |user|
                     visible_details(user)
                   end
                   users_by_details_visibility.each do |visible_details, users|
                     if notes? || visible_details.any?
                       yield(users)
                     end
                   end
                 end
               end
               # Returns the JournalDetail for the given attribute, or nil if the attribute
               # was not updated
               def detail_for_attribute(attribute)
                 details.detect {|detail| detail.prop_key == attribute}
               end
               # Returns the new status if the journal contains a status change, otherwise nil
               def new_status
                 s = new_value_for('status_id')
                 s ? IssueStatus.find_by_id(s.to_i) : nil
               end
               def new_value_for(prop)
                 detail_for_attribute(prop).try(:value)
               end
               def editable_by?(usr)
                 usr && usr.logged? && (usr.allowed_to?(:edit_issue_notes, project) || (self.user == usr && usr.allowed_to?(:edit_own_issue_notes, project)))
               end
               def project
                 journalized.respond_to?(:project) ? journalized.project : nil
               end
               def attachments
                 journalized.respond_to?(:attachments) ? journalized.attachments : nil
               end
               # Returns a string of css classes
               def css_classes
                 s = 'journal'
                 s << ' has-notes' unless notes.blank?
                 s << ' has-details' unless details.blank?
                 s << ' private-notes' if private_notes?
                 s
               end
               def notify?
                 @notify != false
               end
               def notify=(arg)
                 @notify = arg
               end
               def notified_users
                 notified = journalized.notified_users
                 if private_notes?
                   notified = notified.select {|user| user.allowed_to?(:view_private_notes, journalized.project)}
                 end
                 notified
               end
               def recipients
                 notified_users.map(&:mail)
               end
               def notified_watchers
                 notified = journalized.notified_watchers
                 if private_notes?
                   notified = notified.select {|user| user.allowed_to?(:view_private_notes, journalized.project)}
                 end
                 notified
               end
               def watcher_recipients
                 notified_watchers.map(&:mail)
               end
               # Sets @custom_field instance variable on journals details using a single query
               def self.preload_journals_details_custom_fields(journals)
                 field_ids = journals.map(&:details).flatten.select {|d| d.property == 'cf'}.map(&:prop_key).uniq
                 if field_ids.any?
                   fields_by_id = CustomField.where(:id => field_ids).inject({}) {|h, f| h[f.id] = f; h}
                   journals.each do |journal|
                     journal.details.each do |detail|
                       if detail.property == 'cf'
                         detail.instance_variable_set "@custom_field", fields_by_id[detail.prop_key.to_i]
                       end
                     end
                   end
                 end
                 journals
               end
               # Stores the values of the attributes and custom fields of the journalized object
               def start
                 if journalized
                   @attributes_before_change = journalized.journalized_attribute_names.inject({}) do |h, attribute|
                     h[attribute] = journalized.send(attribute)
                     h
                   end
                   @custom_values_before_change = journalized.custom_field_values.inject({}) do |h, c|
                     h[c.custom_field_id] = c.value
                     h
                   end
                 end
                 self
               end
               # Adds a journal detail for an attachment that was added or removed
               def journalize_attachment(attachment, added_or_removed)
                 key = (added_or_removed == :removed ? :old_value : :value)
                 details << JournalDetail.new(
                     :property => 'attachment',
                     :prop_key => attachment.id,
                     key => attachment.filename
                   )
               end
               # Adds a journal detail for an issue relation that was added or removed
               def journalize_relation(relation, added_or_removed)
                 key = (added_or_removed == :removed ? :old_value : :value)
                 details << JournalDetail.new(
                     :property  => 'relation',
                     :prop_key  => relation.relation_type_for(journalized),
                     key => relation.other_issue(journalized).try(:id)
                   )
               end
               private
               # Generates journal details for attribute and custom field changes
               def journalize_changes
                 # attributes changes
                 if @attributes_before_change
                   journalized.journalized_attribute_names.each {|attribute|
                     before = @attributes_before_change[attribute]
                     after = journalized.send(attribute)
                     next if before == after || (before.blank? && after.blank?)
                     add_attribute_detail(attribute, before, after)
                   }
                 end
                 if @custom_values_before_change
                   # custom fields changes
                   journalized.custom_field_values.each {|c|
                     before = @custom_values_before_change[c.custom_field_id]
                     after = c.value
                     next if before == after || (before.blank? && after.blank?)
                     if before.is_a?(Array) || after.is_a?(Array)
                       before = [before] unless before.is_a?(Array)
                       after = [after] unless after.is_a?(Array)
                       # values removed
                       (before - after).reject(&:blank?).each do |value|
                         add_custom_value_detail(c, value, nil)
                       end
                       # values added
                       (after - before).reject(&:blank?).each do |value|
                         add_custom_value_detail(c, nil, value)
                       end
                     else
                       add_custom_value_detail(c, before, after)
                     end
                   }
                 end
                 start
               end
               # Adds a journal detail for an attribute change
               def add_attribute_detail(attribute, old_value, value)
                 add_detail('attr', attribute, old_value, value)
               end
               # Adds a journal detail for a custom field value change
               def add_custom_value_detail(custom_value, old_value, value)
                 add_detail('cf', custom_value.custom_field_id, old_value, value)
               end
               # Adds a journal detail
               def add_detail(property, prop_key, old_value, value)
                 details << JournalDetail.new(
                     :property => property,
                     :prop_key => prop_key,
                     :old_value => old_value,
                     :value => value
                   )
               end
               def split_private_notes
                 if private_notes?
                   if notes.present?
                     if details.any?
                       # Split the journal (notes/changes) so we don't have half-private journals
                       journal = Journal.new(:journalized => journalized, :user => user, :notes => nil, :private_notes => false)
                       journal.details = details
                       journal.save
                       self.details = []
                       self.created_on = journal.created_on
                     end
                   else
                     # Blank notes should not be private
                     self.private_notes = false
                   end
                 end
                 true
               end
               def send_notification
                 if notify? && (Setting.notified_events.include?('issue_updated') ||
                     (Setting.notified_events.include?('issue_note_added') && notes.present?) ||
                     (Setting.notified_events.include?('issue_status_updated') && new_status.present?) ||
                     (Setting.notified_events.include?('issue_assigned_to_updated') && detail_for_attribute('assigned_to_id').present?) ||
                     (Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
                   )
                   Mailer.deliver_issue_edit(self)
                 end
               end
             end

app/models/member.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Member < ActiveRecord::Base
               belongs_to :user
               belongs_to :principal, :foreign_key => 'user_id'
               has_many :member_roles, :dependent => :destroy
-              has_many :roles, lambda {uniq}, :through => :member_roles
+              has_many :roles, lambda { distinct }, :through => :member_roles
               belongs_to :project
               validates_presence_of :principal, :project
               validates_uniqueness_of :user_id, :scope => :project_id
               validate :validate_role
               attr_protected :id
               before_destroy :set_issue_category_nil
               scope :active, lambda { joins(:principal).where(:users => {:status => Principal::STATUS_ACTIVE})}
               alias :base_reload :reload
               def reload(*args)
                 @managed_roles = nil
                 base_reload(*args)
               end
               def role
               end
               def role=
               end
               def name
                 self.user.name
               end
               alias :base_role_ids= :role_ids=
               def role_ids=(arg)
                 ids = (arg || []).collect(&:to_i) - [0]
                 # Keep inherited roles
                 ids += member_roles.select {|mr| !mr.inherited_from.nil?}.collect(&:role_id)
                 new_role_ids = ids - role_ids
                 # Add new roles
                 new_role_ids.each {|id| member_roles << MemberRole.new(:role_id => id, :member => self) }
                 # Remove roles (Rails' #role_ids= will not trigger MemberRole#on_destroy)
                 member_roles_to_destroy = member_roles.select {|mr| !ids.include?(mr.role_id)}
                 if member_roles_to_destroy.any?
                   member_roles_to_destroy.each(&:destroy)
                 end
               end
               def <=>(member)
                 a, b = roles.sort, member.roles.sort
                 if a == b
                   if principal
                     principal <=> member.principal
                   else
                   end
                 elsif a.any?
                   b.any? ? a <=> b : -1
                 else
                 end
               end
               # Set member role ids ignoring any change to roles that
               # user is not allowed to manage
               def set_editable_role_ids(ids, user=User.current)
                 ids = (ids || []).collect(&:to_i) - [0]
                 editable_role_ids = user.managed_roles(project).map(&:id)
                 untouched_role_ids = self.role_ids - editable_role_ids
                 touched_role_ids = ids & editable_role_ids
                 self.role_ids = untouched_role_ids + touched_role_ids
               end
               # Returns true if one of the member roles is inherited
               def any_inherited_role?
                 member_roles.any? {|mr| mr.inherited_from}
               end
               # Returns true if the member has the role and if it's inherited
               def has_inherited_role?(role)
                 member_roles.any? {|mr| mr.role_id == role.id && mr.inherited_from.present?}
               end
               # Returns true if the member's role is editable by user
               def role_editable?(role, user=User.current)
                 if has_inherited_role?(role)
                   false
                 else
                   user.managed_roles(project).include?(role)
                 end
               end
               # Returns true if the member is deletable by user
               def deletable?(user=User.current)
                 if any_inherited_role?
                   false
                 else
                   roles & user.managed_roles(project) == roles
                 end
               end
               # Destroys the member
               def destroy
                 member_roles.reload.each(&:destroy_without_member_removal)
                 super
               end
               # Returns true if the member is user or is a group
               # that includes user
               def include?(user)
                 if principal.is_a?(Group)
                   !user.nil? && user.groups.include?(principal)
                 else
                   self.user == user
                 end
               end
               def set_issue_category_nil
                 if user_id && project_id
                   # remove category based auto assignments for this member
                   IssueCategory.where(["project_id = ? AND assigned_to_id = ?", project_id, user_id]).
                     update_all("assigned_to_id = NULL")
                 end
               end
               # Returns the roles that the member is allowed to manage
               # in the project the member belongs to
               def managed_roles
                 @managed_roles ||= begin
                   if principal.try(:admin?)
                     Role.givable.to_a
                   else
                     members_management_roles = roles.select do |role|
                       role.has_permission?(:manage_members)
                     end
                     if members_management_roles.empty?
                       []
                     elsif members_management_roles.any?(&:all_roles_managed?)
                       Role.givable.to_a
                     else
                       members_management_roles.map(&:managed_roles).reduce(&:|)
                     end
                   end
                 end
               end
               # Creates memberships for principal with the attributes
               # * project_ids : one or more project ids
               # * role_ids : ids of the roles to give to each membership
               #
               # Example:
               #   Member.create_principal_memberships(user, :project_ids => [2, 5], :role_ids => [1, 3]
               def self.create_principal_memberships(principal, attributes)
                 members = []
                 if attributes
                   project_ids = Array.wrap(attributes[:project_ids] || attributes[:project_id])
                   role_ids = attributes[:role_ids]
                   project_ids.each do |project_id|
                     members << Member.new(:principal => principal, :role_ids => role_ids, :project_id => project_id)
                   end
                   principal.members << members
                 end
                 members
               end
               # Finds or initilizes a Member for the given project and principal
               def self.find_or_new(project, principal)
                 project_id = project.is_a?(Project) ? project.id : project
                 principal_id = principal.is_a?(Principal) ? principal.id : principal
                 member = Member.find_by_project_id_and_user_id(project_id, principal_id)
                 member ||= Member.new(:project_id => project_id, :user_id => principal_id)
                 member
               end
               protected
               def validate_role
                 errors.add_on_empty :role if member_roles.empty? && roles.empty?
               end
             end

app/models/project.rb +4 -4

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Project < ActiveRecord::Base
               include Redmine::SafeAttributes
               include Redmine::NestedSet::ProjectNestedSet
               # Project statuses
               STATUS_ACTIVE     = 1
               STATUS_CLOSED     = 5
               STATUS_ARCHIVED   = 9
               # Maximum length for project identifiers
               IDENTIFIER_MAX_LENGTH = 100
               # Specific overridden Activities
               has_many :time_entry_activities
               has_many :memberships, :class_name => 'Member', :inverse_of => :project
               # Memberships of active users only
               has_many :members,
                        lambda { joins(:principal).where(:users => {:type => 'User', :status => Principal::STATUS_ACTIVE}) }
               has_many :enabled_modules, :dependent => :delete_all
               has_and_belongs_to_many :trackers, lambda {order(:position)}
               has_many :issues, :dependent => :destroy
               has_many :issue_changes, :through => :issues, :source => :journals
               has_many :versions, lambda {order("#{Version.table_name}.effective_date DESC, #{Version.table_name}.name DESC")}, :dependent => :destroy
               belongs_to :default_version, :class_name => 'Version'
               has_many :time_entries, :dependent => :destroy
               has_many :queries, :class_name => 'IssueQuery', :dependent => :delete_all
               has_many :documents, :dependent => :destroy
               has_many :news, lambda {includes(:author)}, :dependent => :destroy
               has_many :issue_categories, lambda {order("#{IssueCategory.table_name}.name")}, :dependent => :delete_all
               has_many :boards, lambda {order("position ASC")}, :dependent => :destroy
               has_one :repository, lambda {where(["is_default = ?", true])}
               has_many :repositories, :dependent => :destroy
               has_many :changesets, :through => :repository
               has_one :wiki, :dependent => :destroy
               # Custom field for the project issues
               has_and_belongs_to_many :issue_custom_fields,
                                       lambda {order("#{CustomField.table_name}.position")},
                                       :class_name => 'IssueCustomField',
                                       :join_table => "#{table_name_prefix}custom_fields_projects#{table_name_suffix}",
                                       :association_foreign_key => 'custom_field_id'
               acts_as_attachable :view_permission => :view_files,
                                  :edit_permission => :manage_files,
                                  :delete_permission => :manage_files
               acts_as_customizable
               acts_as_searchable :columns => ['name', 'identifier', 'description'], :project_key => "#{Project.table_name}.id", :permission => nil
               acts_as_event :title => Proc.new {|o| "#{l(:label_project)}: #{o.name}"},
                             :url => Proc.new {|o| {:controller => 'projects', :action => 'show', :id => o}},
                             :author => nil
               attr_protected :status
               validates_presence_of :name, :identifier
               validates_uniqueness_of :identifier, :if => Proc.new {|p| p.identifier_changed?}
               validates_length_of :name, :maximum => 255
               validates_length_of :homepage, :maximum => 255
               validates_length_of :identifier, :in => 1..IDENTIFIER_MAX_LENGTH
               # downcase letters, digits, dashes but not digits only
               validates_format_of :identifier, :with => /\A(?!\d+$)[a-z0-9\-_]*\z/, :if => Proc.new { |p| p.identifier_changed? }
               # reserved words
               validates_exclusion_of :identifier, :in => %w( new )
               validate :validate_parent
               after_save :update_inherited_members, :if => Proc.new {|project| project.inherit_members_changed?}
               after_save :remove_inherited_member_roles, :add_inherited_member_roles, :if => Proc.new {|project| project.parent_id_changed?}
               after_update :update_versions_from_hierarchy_change, :if => Proc.new {|project| project.parent_id_changed?}
               before_destroy :delete_all_members
               scope :has_module, lambda {|mod|
                 where("#{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name=?)", mod.to_s)
               }
               scope :active, lambda { where(:status => STATUS_ACTIVE) }
               scope :status, lambda {|arg| where(arg.blank? ? nil : {:status => arg.to_i}) }
               scope :all_public, lambda { where(:is_public => true) }
               scope :visible, lambda {|*args| where(Project.visible_condition(args.shift || User.current, *args)) }
               scope :allowed_to, lambda {|*args|
                 user = User.current
                 permission = nil
                 if args.first.is_a?(Symbol)
                   permission = args.shift
                 else
                   user = args.shift
                   permission = args.shift
                 end
                 where(Project.allowed_to_condition(user, permission, *args))
               }
               scope :like, lambda {|arg|
                 if arg.blank?
                   where(nil)
                 else
                   pattern = "%#{arg.to_s.strip.downcase}%"
                   where("LOWER(identifier) LIKE :p OR LOWER(name) LIKE :p", :p => pattern)
                 end
               }
               scope :sorted, lambda {order(:lft)}
               scope :having_trackers, lambda {
                 where("#{Project.table_name}.id IN (SELECT DISTINCT project_id FROM #{table_name_prefix}projects_trackers#{table_name_suffix})")
               }
               def initialize(attributes=nil, *args)
                 super
                 initialized = (attributes || {}).stringify_keys
                 if !initialized.key?('identifier') && Setting.sequential_project_identifiers?
                   self.identifier = Project.next_identifier
                 end
                 if !initialized.key?('is_public')
                   self.is_public = Setting.default_projects_public?
                 end
                 if !initialized.key?('enabled_module_names')
                   self.enabled_module_names = Setting.default_projects_modules
                 end
                 if !initialized.key?('trackers') && !initialized.key?('tracker_ids')
                   default = Setting.default_projects_tracker_ids
                   if default.is_a?(Array)
                     self.trackers = Tracker.where(:id => default.map(&:to_i)).sorted.to_a
                   else
                     self.trackers = Tracker.sorted.to_a
                   end
                 end
               end
               def identifier=(identifier)
                 super unless identifier_frozen?
               end
               def identifier_frozen?
                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
               end
               # returns latest created projects
               # non public projects will be returned only if user is a member of those
               def self.latest(user=nil, count=5)
                 visible(user).limit(count).
                   order(:created_on => :desc).
                   where("#{table_name}.created_on >= ?", 30.days.ago).
                   to_a
               end
               # Returns true if the project is visible to +user+ or to the current user.
               def visible?(user=User.current)
                 user.allowed_to?(:view_project, self)
               end
               # Returns a SQL conditions string used to find all projects visible by the specified user.
               #
               # Examples:
               #   Project.visible_condition(admin)        => "projects.status = 1"
               #   Project.visible_condition(normal_user)  => "((projects.status = 1) AND (projects.is_public = 1 OR projects.id IN (1,3,4)))"
               #   Project.visible_condition(anonymous)    => "((projects.status = 1) AND (projects.is_public = 1))"
               def self.visible_condition(user, options={})
                 allowed_to_condition(user, :view_project, options)
               end
               # Returns a SQL conditions string used to find all projects for which +user+ has the given +permission+
               #
               # Valid options:
               # * :project => limit the condition to project
               # * :with_subprojects => limit the condition to project and its subprojects
               # * :member => limit the condition to the user projects
               def self.allowed_to_condition(user, permission, options={})
                 perm = Redmine::AccessControl.permission(permission)
                 base_statement = (perm && perm.read? ? "#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED}" : "#{Project.table_name}.status = #{Project::STATUS_ACTIVE}")
                 if perm && perm.project_module
                   # If the permission belongs to a project module, make sure the module is enabled
                   base_statement << " AND #{Project.table_name}.id IN (SELECT em.project_id FROM #{EnabledModule.table_name} em WHERE em.name='#{perm.project_module}')"
                 end
                 if project = options[:project]
                   project_statement = project.project_condition(options[:with_subprojects])
                   base_statement = "(#{project_statement}) AND (#{base_statement})"
                 end
                 if user.admin?
                   base_statement
                 else
                   statement_by_role = {}
                   unless options[:member]
                     role = user.builtin_role
                     if role.allowed_to?(permission)
                       s = "#{Project.table_name}.is_public = #{connection.quoted_true}"
                       if user.id
                         s = "(#{s} AND #{Project.table_name}.id NOT IN (SELECT project_id FROM #{Member.table_name} WHERE user_id = #{user.id}))"
                       end
                       statement_by_role[role] = s
                     end
                   end
                   user.projects_by_role.each do |role, projects|
                     if role.allowed_to?(permission) && projects.any?
                       statement_by_role[role] = "#{Project.table_name}.id IN (#{projects.collect(&:id).join(',')})"
                     end
                   end
                   if statement_by_role.empty?
                     "1=0"
                   else
                     if block_given?
                       statement_by_role.each do |role, statement|
                         if s = yield(role, user)
                           statement_by_role[role] = "(#{statement} AND (#{s}))"
                         end
                       end
                     end
                     "((#{base_statement}) AND (#{statement_by_role.values.join(' OR ')}))"
                   end
                 end
               end
               def override_roles(role)
                 @override_members ||= memberships.
                   joins(:principal).
                   where(:users => {:type => ['GroupAnonymous', 'GroupNonMember']}).to_a
                 group_class = role.anonymous? ? GroupAnonymous : GroupNonMember
                 member = @override_members.detect {|m| m.principal.is_a? group_class}
                 member ? member.roles.to_a : [role]
               end
               def principals
-                @principals ||= Principal.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).uniq
+                @principals ||= Principal.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).distinct
               end
               def users
-                @users ||= User.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).uniq
+                @users ||= User.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).distinct
               end
               # Returns the Systemwide and project specific activities
               def activities(include_inactive=false)
                 t = TimeEntryActivity.table_name
                 scope = TimeEntryActivity.where("#{t}.project_id IS NULL OR #{t}.project_id = ?", id)
                 overridden_activity_ids = self.time_entry_activities.pluck(:parent_id).compact
                 if overridden_activity_ids.any?
                   scope = scope.where("#{t}.id NOT IN (?)", overridden_activity_ids)
                 end
                 unless include_inactive
                   scope = scope.active
                 end
                 scope
               end
               # Will create a new Project specific Activity or update an existing one
               #
               # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
               # does not successfully save.
               def update_or_create_time_entry_activity(id, activity_hash)
                 if activity_hash.respond_to?(:has_key?) && activity_hash.has_key?('parent_id')
                   self.create_time_entry_activity_if_needed(activity_hash)
                 else
                   activity = project.time_entry_activities.find_by_id(id.to_i)
                   activity.update_attributes(activity_hash) if activity
                 end
               end
               # Create a new TimeEntryActivity if it overrides a system TimeEntryActivity
               #
               # This will raise a ActiveRecord::Rollback if the TimeEntryActivity
               # does not successfully save.
               def create_time_entry_activity_if_needed(activity)
                 if activity['parent_id']
                   parent_activity = TimeEntryActivity.find(activity['parent_id'])
                   activity['name'] = parent_activity.name
                   activity['position'] = parent_activity.position
                   if Enumeration.overriding_change?(activity, parent_activity)
                     project_activity = self.time_entry_activities.create(activity)
                     if project_activity.new_record?
                       raise ActiveRecord::Rollback, "Overriding TimeEntryActivity was not successfully saved"
                     else
                       self.time_entries.
                         where(:activity_id => parent_activity.id).
                         update_all(:activity_id => project_activity.id)
                     end
                   end
                 end
               end
               # Returns a :conditions SQL string that can be used to find the issues associated with this project.
               #
               # Examples:
               #   project.project_condition(true)  => "(projects.id = 1 OR (projects.lft > 1 AND projects.rgt < 10))"
               #   project.project_condition(false) => "projects.id = 1"
               def project_condition(with_subprojects)
                 cond = "#{Project.table_name}.id = #{id}"
                 cond = "(#{cond} OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt}))" if with_subprojects
                 cond
               end
               def self.find(*args)
                 if args.first && args.first.is_a?(String) && !args.first.match(/^\d*$/)
                   project = find_by_identifier(*args)
                   raise ActiveRecord::RecordNotFound, "Couldn't find Project with identifier=#{args.first}" if project.nil?
                   project
                 else
                   super
                 end
               end
               def self.find_by_param(*args)
                 self.find(*args)
               end
               alias :base_reload :reload
               def reload(*args)
                 @principals = nil
                 @users = nil
                 @shared_versions = nil
                 @rolled_up_versions = nil
                 @rolled_up_trackers = nil
                 @all_issue_custom_fields = nil
                 @all_time_entry_custom_fields = nil
                 @to_param = nil
                 @allowed_parents = nil
                 @allowed_permissions = nil
                 @actions_allowed = nil
                 @start_date = nil
                 @due_date = nil
                 @override_members = nil
                 @assignable_users = nil
                 base_reload(*args)
               end
               def to_param
                 if new_record?
                   nil
                 else
                   # id is used for projects with a numeric identifier (compatibility)
                   @to_param ||= (identifier.to_s =~ %r{^\d*$} ? id.to_s : identifier)
                 end
               end
               def active?
                 self.status == STATUS_ACTIVE
               end
               def archived?
                 self.status == STATUS_ARCHIVED
               end
               # Archives the project and its descendants
               def archive
                 # Check that there is no issue of a non descendant project that is assigned
                 # to one of the project or descendant versions
                 version_ids = self_and_descendants.joins(:versions).pluck("#{Version.table_name}.id")
                 if version_ids.any? &&
                   Issue.
                     includes(:project).
                     where("#{Project.table_name}.lft < ? OR #{Project.table_name}.rgt > ?", lft, rgt).
                     where(:fixed_version_id => version_ids).
                     exists?
                   return false
                 end
                 Project.transaction do
                   archive!
                 end
                 true
               end
               # Unarchives the project
               # All its ancestors must be active
               def unarchive
                 return false if ancestors.detect {|a| !a.active?}
                 update_attribute :status, STATUS_ACTIVE
               end
               def close
                 self_and_descendants.status(STATUS_ACTIVE).update_all :status => STATUS_CLOSED
               end
               def reopen
                 self_and_descendants.status(STATUS_CLOSED).update_all :status => STATUS_ACTIVE
               end
               # Returns an array of projects the project can be moved to
               # by the current user
               def allowed_parents(user=User.current)
                 return @allowed_parents if @allowed_parents
                 @allowed_parents = Project.allowed_to(user, :add_subprojects).to_a
                 @allowed_parents = @allowed_parents - self_and_descendants
                 if user.allowed_to?(:add_project, nil, :global => true) || (!new_record? && parent.nil?)
                   @allowed_parents << nil
                 end
                 unless parent.nil? || @allowed_parents.empty? || @allowed_parents.include?(parent)
                   @allowed_parents << parent
                 end
                 @allowed_parents
               end
               # Sets the parent of the project with authorization check
               def set_allowed_parent!(p)
                 ActiveSupport::Deprecation.warn "Project#set_allowed_parent! is deprecated and will be removed in Redmine 4, use #safe_attributes= instead."
                 p = p.id if p.is_a?(Project)
                 send :safe_attributes, {:project_id => p}
                 save
               end
               # Sets the parent of the project and saves the project
               # Argument can be either a Project, a String, a Fixnum or nil
               def set_parent!(p)
                 if p.is_a?(Project)
                   self.parent = p
                 else
                   self.parent_id = p
                 end
                 save
               end
               # Returns a scope of the trackers used by the project and its active sub projects
               def rolled_up_trackers(include_subprojects=true)
                 if include_subprojects
                   @rolled_up_trackers ||= rolled_up_trackers_base_scope.
                       where("#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ?", lft, rgt)
                 else
                   rolled_up_trackers_base_scope.
                     where(:projects => {:id => id})
                 end
               end
               def rolled_up_trackers_base_scope
                 Tracker.
                   joins(projects: :enabled_modules).
                   where("#{Project.table_name}.status <> ?", STATUS_ARCHIVED).
                   where(:enabled_modules => {:name => 'issue_tracking'}).
-                  uniq.
+                  distinct.
                   sorted
               end
               # Closes open and locked project versions that are completed
               def close_completed_versions
                 Version.transaction do
                   versions.where(:status => %w(open locked)).each do |version|
                     if version.completed?
                       version.update_attribute(:status, 'closed')
                     end
                   end
                 end
               end
               # Returns a scope of the Versions on subprojects
               def rolled_up_versions
                 @rolled_up_versions ||=
                   Version.
                     joins(:project).
                     where("#{Project.table_name}.lft >= ? AND #{Project.table_name}.rgt <= ? AND #{Project.table_name}.status <> ?", lft, rgt, STATUS_ARCHIVED)
               end
               # Returns a scope of the Versions used by the project
               def shared_versions
                 if new_record?
                   Version.
                     joins(:project).
                     preload(:project).
                     where("#{Project.table_name}.status <> ? AND #{Version.table_name}.sharing = 'system'", STATUS_ARCHIVED)
                 else
                   @shared_versions ||= begin
                     r = root? ? self : root
                     Version.
                       joins(:project).
                       preload(:project).
                       where("#{Project.table_name}.id = #{id}" +
                               " OR (#{Project.table_name}.status <> #{Project::STATUS_ARCHIVED} AND (" +
                                 " #{Version.table_name}.sharing = 'system'" +
                                 " OR (#{Project.table_name}.lft >= #{r.lft} AND #{Project.table_name}.rgt <= #{r.rgt} AND #{Version.table_name}.sharing = 'tree')" +
                                 " OR (#{Project.table_name}.lft < #{lft} AND #{Project.table_name}.rgt > #{rgt} AND #{Version.table_name}.sharing IN ('hierarchy', 'descendants'))" +
                                 " OR (#{Project.table_name}.lft > #{lft} AND #{Project.table_name}.rgt < #{rgt} AND #{Version.table_name}.sharing = 'hierarchy')" +
                               "))")
                   end
                 end
               end
               # Returns a hash of project users grouped by role
               def users_by_role
                 members.includes(:user, :roles).inject({}) do |h, m|
                   m.roles.each do |r|
                     h[r] ||= []
                     h[r] << m.user
                   end
                   h
                 end
               end
               # Adds user as a project member with the default role
               # Used for when a non-admin user creates a project
               def add_default_member(user)
                 role = Role.givable.find_by_id(Setting.new_project_user_role_id.to_i) || Role.givable.first
                 member = Member.new(:project => self, :principal => user, :roles => [role])
                 self.members << member
                 member
               end
               # Deletes all project's members
               def delete_all_members
                 me, mr = Member.table_name, MemberRole.table_name
                 self.class.connection.delete("DELETE FROM #{mr} WHERE #{mr}.member_id IN (SELECT #{me}.id FROM #{me} WHERE #{me}.project_id = #{id})")
                 Member.delete_all(['project_id = ?', id])
               end
               # Return a Principal scope of users/groups issues can be assigned to
               def assignable_users(tracker=nil)
                 return @assignable_users[tracker] if @assignable_users && @assignable_users[tracker]
                 types = ['User']
                 types << 'Group' if Setting.issue_group_assignment?
                 scope = Principal.
                   active.
                   joins(:members => :roles).
                   where(:type => types, :members => {:project_id => id}, :roles => {:assignable => true}).
-                  uniq.
+                  distinct.
                   sorted
                 if tracker
                   # Rejects users that cannot the view the tracker
                   roles = Role.where(:assignable => true).select {|role| role.permissions_tracker?(:view_issues, tracker)}
                   scope = scope.where(:roles => {:id => roles.map(&:id)})
                 end
                 @assignable_users ||= {}
                 @assignable_users[tracker] = scope
               end
               # Returns the mail addresses of users that should be always notified on project events
               def recipients
                 notified_users.collect {|user| user.mail}
               end
               # Returns the users that should be notified on project events
               def notified_users
                 # TODO: User part should be extracted to User#notify_about?
                 members.preload(:principal).select {|m| m.principal.present? && (m.mail_notification? || m.principal.mail_notification == 'all')}.collect {|m| m.principal}
               end
               # Returns a scope of all custom fields enabled for project issues
               # (explicitly associated custom fields and custom fields enabled for all projects)
               def all_issue_custom_fields
                 if new_record?
                   @all_issue_custom_fields ||= IssueCustomField.
                     sorted.
                     where("is_for_all = ? OR id IN (?)", true, issue_custom_field_ids)
                 else
                   @all_issue_custom_fields ||= IssueCustomField.
                     sorted.
                     where("is_for_all = ? OR id IN (SELECT DISTINCT cfp.custom_field_id" +
                       " FROM #{table_name_prefix}custom_fields_projects#{table_name_suffix} cfp" +
                       " WHERE cfp.project_id = ?)", true, id)
                 end
               end
               def project
                 self
               end
               def <=>(project)
                 name.casecmp(project.name)
               end
               def to_s
                 name
               end
               # Returns a short description of the projects (first lines)
               def short_description(length = 255)
                 description.gsub(/^(.{#{length}}[^\n\r]*).*$/m, '\1...').strip if description
               end
               def css_classes
                 s = 'project'
                 s << ' root' if root?
                 s << ' child' if child?
                 s << (leaf? ? ' leaf' : ' parent')
                 unless active?
                   if archived?
                     s << ' archived'
                   else
                     s << ' closed'
                   end
                 end
                 s
               end
               # The earliest start date of a project, based on it's issues and versions
               def start_date
                 @start_date ||= [
                  issues.minimum('start_date'),
                  shared_versions.minimum('effective_date'),
                  Issue.fixed_version(shared_versions).minimum('start_date')
                 ].compact.min
               end
               # The latest due date of an issue or version
               def due_date
                 @due_date ||= [
                  issues.maximum('due_date'),
                  shared_versions.maximum('effective_date'),
                  Issue.fixed_version(shared_versions).maximum('due_date')
                 ].compact.max
               end
               def overdue?
                 active? && !due_date.nil? && (due_date < User.current.today)
               end
               # Returns the percent completed for this project, based on the
               # progress on it's versions.
               def completed_percent(options={:include_subprojects => false})
                 if options.delete(:include_subprojects)
                   total = self_and_descendants.collect(&:completed_percent).sum
                   total / self_and_descendants.count
                 else
                   if versions.count > 0
                     total = versions.collect(&:completed_percent).sum
                     total / versions.count
                   else
                   end
                 end
               end
               # Return true if this project allows to do the specified action.
               # action can be:
               # * a parameter-like Hash (eg. :controller => 'projects', :action => 'edit')
               # * a permission Symbol (eg. :edit_project)
               def allows_to?(action)
                 if archived?
                   # No action allowed on archived projects
                   return false
                 end
                 unless active? || Redmine::AccessControl.read_action?(action)
                   # No write action allowed on closed projects
                   return false
                 end
                 # No action allowed on disabled modules
                 if action.is_a? Hash
                   allowed_actions.include? "#{action[:controller]}/#{action[:action]}"
                 else
                   allowed_permissions.include? action
                 end
               end
               # Return the enabled module with the given name
               # or nil if the module is not enabled for the project
               def enabled_module(name)
                 name = name.to_s
                 enabled_modules.detect {|m| m.name == name}
               end
               # Return true if the module with the given name is enabled
               def module_enabled?(name)
                 enabled_module(name).present?
               end
               def enabled_module_names=(module_names)
                 if module_names && module_names.is_a?(Array)
                   module_names = module_names.collect(&:to_s).reject(&:blank?)
                   self.enabled_modules = module_names.collect {|name| enabled_modules.detect {|mod| mod.name == name} || EnabledModule.new(:name => name)}
                 else
                   enabled_modules.clear
                 end
               end
               # Returns an array of the enabled modules names
               def enabled_module_names
                 enabled_modules.collect(&:name)
               end
               # Enable a specific module
               #
               # Examples:
               #   project.enable_module!(:issue_tracking)
               #   project.enable_module!("issue_tracking")
               def enable_module!(name)
                 enabled_modules << EnabledModule.new(:name => name.to_s) unless module_enabled?(name)
               end
               # Disable a module if it exists
               #
               # Examples:
               #   project.disable_module!(:issue_tracking)
               #   project.disable_module!("issue_tracking")
               #   project.disable_module!(project.enabled_modules.first)
               def disable_module!(target)
                 target = enabled_modules.detect{|mod| target.to_s == mod.name} unless enabled_modules.include?(target)
                 target.destroy unless target.blank?
               end
               safe_attributes 'name',
                 'description',
                 'homepage',
                 'is_public',
                 'identifier',
                 'custom_field_values',
                 'custom_fields',
                 'tracker_ids',
                 'issue_custom_field_ids',
                 'parent_id',
                 'default_version_id'
               safe_attributes 'enabled_module_names',
                 :if => lambda {|project, user| project.new_record? || user.allowed_to?(:select_project_modules, project) }
               safe_attributes 'inherit_members',
                 :if => lambda {|project, user| project.parent.nil? || project.parent.visible?(user)}
               def safe_attributes=(attrs, user=User.current)
                 return unless attrs.is_a?(Hash)
                 attrs = attrs.deep_dup
                 @unallowed_parent_id = nil
                 if new_record? || attrs.key?('parent_id')
                   parent_id_param = attrs['parent_id'].to_s
                   if new_record? || parent_id_param != parent_id.to_s
                     p = parent_id_param.present? ? Project.find_by_id(parent_id_param) : nil
                     unless allowed_parents(user).include?(p)
                       attrs.delete('parent_id')
                       @unallowed_parent_id = true
                     end
                   end
                 end
                 super(attrs, user)
               end
               # Returns an auto-generated project identifier based on the last identifier used
               def self.next_identifier
                 p = Project.order('id DESC').first
                 p.nil? ? nil : p.identifier.to_s.succ
               end
               # Copies and saves the Project instance based on the +project+.
               # Duplicates the source project's:
               # * Wiki
               # * Versions
               # * Categories
               # * Issues
               # * Members
               # * Queries
               #
               # Accepts an +options+ argument to specify what to copy
               #
               # Examples:
               #   project.copy(1)                                    # => copies everything
               #   project.copy(1, :only => 'members')                # => copies members only
               #   project.copy(1, :only => ['members', 'versions'])  # => copies members and versions
               def copy(project, options={})
                 project = project.is_a?(Project) ? project : Project.find(project)
                 to_be_copied = %w(wiki versions issue_categories issues members queries boards)
                 to_be_copied = to_be_copied & Array.wrap(options[:only]) unless options[:only].nil?
                 Project.transaction do
                   if save
                     reload
                     to_be_copied.each do |name|
                       send "copy_#{name}", project
                     end
                     Redmine::Hook.call_hook(:model_project_copy_before_save, :source_project => project, :destination_project => self)
                     save
                   else
                     false
                   end
                 end
               end
               def member_principals
                 ActiveSupport::Deprecation.warn "Project#member_principals is deprecated and will be removed in Redmine 4.0. Use #memberships.active instead."
                 memberships.active
               end
               # Returns a new unsaved Project instance with attributes copied from +project+
               def self.copy_from(project)
                 project = project.is_a?(Project) ? project : Project.find(project)
                 # clear unique attributes
                 attributes = project.attributes.dup.except('id', 'name', 'identifier', 'status', 'parent_id', 'lft', 'rgt')
                 copy = Project.new(attributes)
                 copy.enabled_module_names = project.enabled_module_names
                 copy.trackers = project.trackers
                 copy.custom_values = project.custom_values.collect {|v| v.clone}
                 copy.issue_custom_fields = project.issue_custom_fields
                 copy
               end
               # Yields the given block for each project with its level in the tree
               def self.project_tree(projects, &block)
                 ancestors = []
                 projects.sort_by(&:lft).each do |project|
                   while (ancestors.any? && !project.is_descendant_of?(ancestors.last))
                     ancestors.pop
                   end
                   yield project, ancestors.size
                   ancestors << project
                 end
               end
               private
               def update_inherited_members
                 if parent
                   if inherit_members? && !inherit_members_was
                     remove_inherited_member_roles
                     add_inherited_member_roles
                   elsif !inherit_members? && inherit_members_was
                     remove_inherited_member_roles
                   end
                 end
               end
               def remove_inherited_member_roles
                 member_roles = memberships.map(&:member_roles).flatten
                 member_role_ids = member_roles.map(&:id)
                 member_roles.each do |member_role|
                   if member_role.inherited_from && !member_role_ids.include?(member_role.inherited_from)
                     member_role.destroy
                   end
                 end
               end
               def add_inherited_member_roles
                 if inherit_members? && parent
                   parent.memberships.each do |parent_member|
                     member = Member.find_or_new(self.id, parent_member.user_id)
                     parent_member.member_roles.each do |parent_member_role|
                       member.member_roles << MemberRole.new(:role => parent_member_role.role, :inherited_from => parent_member_role.id)
                     end
                     member.save!
                   end
                   memberships.reset
                 end
               end
               def update_versions_from_hierarchy_change
                 Issue.update_versions_from_hierarchy_change(self)
               end
               def validate_parent
                 if @unallowed_parent_id
                   errors.add(:parent_id, :invalid)
                 elsif parent_id_changed?
                   unless parent.nil? || (parent.active? && move_possible?(parent))
                     errors.add(:parent_id, :invalid)
                   end
                 end
               end
               # Copies wiki from +project+
               def copy_wiki(project)
                 # Check that the source project has a wiki first
                 unless project.wiki.nil?
                   wiki = self.wiki || Wiki.new
                   wiki.attributes = project.wiki.attributes.dup.except("id", "project_id")
                   wiki_pages_map = {}
                   project.wiki.pages.each do |page|
                     # Skip pages without content
                     next if page.content.nil?
                     new_wiki_content = WikiContent.new(page.content.attributes.dup.except("id", "page_id", "updated_on"))
                     new_wiki_page = WikiPage.new(page.attributes.dup.except("id", "wiki_id", "created_on", "parent_id"))
                     new_wiki_page.content = new_wiki_content
                     wiki.pages << new_wiki_page
                     wiki_pages_map[page.id] = new_wiki_page
                   end
                   self.wiki = wiki
                   wiki.save
                   # Reproduce page hierarchy
                   project.wiki.pages.each do |page|
                     if page.parent_id && wiki_pages_map[page.id]
                       wiki_pages_map[page.id].parent = wiki_pages_map[page.parent_id]
                       wiki_pages_map[page.id].save
                     end
                   end
                 end
               end
               # Copies versions from +project+
               def copy_versions(project)
                 project.versions.each do |version|
                   new_version = Version.new
                   new_version.attributes = version.attributes.dup.except("id", "project_id", "created_on", "updated_on")
                   self.versions << new_version
                 end
               end
               # Copies issue categories from +project+
               def copy_issue_categories(project)
                 project.issue_categories.each do |issue_category|
                   new_issue_category = IssueCategory.new
                   new_issue_category.attributes = issue_category.attributes.dup.except("id", "project_id")
                   self.issue_categories << new_issue_category
                 end
               end
               # Copies issues from +project+
               def copy_issues(project)
                 # Stores the source issue id as a key and the copied issues as the
                 # value.  Used to map the two together for issue relations.
                 issues_map = {}
                 # Store status and reopen locked/closed versions
                 version_statuses = versions.reject(&:open?).map {|version| [version, version.status]}
                 version_statuses.each do |version, status|
                   version.update_attribute :status, 'open'
                 end
                 # Get issues sorted by root_id, lft so that parent issues
                 # get copied before their children
                 project.issues.reorder('root_id, lft').each do |issue|
                   new_issue = Issue.new
                   new_issue.copy_from(issue, :subtasks => false, :link => false)
                   new_issue.project = self
                   # Changing project resets the custom field values
                   # TODO: handle this in Issue#project=
                   new_issue.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                   # Reassign fixed_versions by name, since names are unique per project
                   if issue.fixed_version && issue.fixed_version.project == project
                     new_issue.fixed_version = self.versions.detect {|v| v.name == issue.fixed_version.name}
                   end
                   # Reassign version custom field values
                   new_issue.custom_field_values.each do |custom_value|
                     if custom_value.custom_field.field_format == 'version' && custom_value.value.present?
                       versions = Version.where(:id => custom_value.value).to_a
                       new_value = versions.map do |version|
                         if version.project == project
                           self.versions.detect {|v| v.name == version.name}.try(:id)
                         else
                           version.id
                         end
                       end
                       new_value.compact!
                       new_value = new_value.first unless custom_value.custom_field.multiple?
                       custom_value.value = new_value
                     end
                   end
                   # Reassign the category by name, since names are unique per project
                   if issue.category
                     new_issue.category = self.issue_categories.detect {|c| c.name == issue.category.name}
                   end
                   # Parent issue
                   if issue.parent_id
                     if copied_parent = issues_map[issue.parent_id]
                       new_issue.parent_issue_id = copied_parent.id
                     end
                   end
                   self.issues << new_issue
                   if new_issue.new_record?
                     logger.info "Project#copy_issues: issue ##{issue.id} could not be copied: #{new_issue.errors.full_messages}" if logger && logger.info?
                   else
                     issues_map[issue.id] = new_issue unless new_issue.new_record?
                   end
                 end
                 # Restore locked/closed version statuses
                 version_statuses.each do |version, status|
                   version.update_attribute :status, status
                 end
                 # Relations after in case issues related each other
                 project.issues.each do |issue|
                   new_issue = issues_map[issue.id]
                   unless new_issue
                     # Issue was not copied
                     next
                   end
                   # Relations
                   issue.relations_from.each do |source_relation|
                     new_issue_relation = IssueRelation.new
                     new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                     new_issue_relation.issue_to = issues_map[source_relation.issue_to_id]
                     if new_issue_relation.issue_to.nil? && Setting.cross_project_issue_relations?
                       new_issue_relation.issue_to = source_relation.issue_to
                     end
                     new_issue.relations_from << new_issue_relation
                   end
                   issue.relations_to.each do |source_relation|
                     new_issue_relation = IssueRelation.new
                     new_issue_relation.attributes = source_relation.attributes.dup.except("id", "issue_from_id", "issue_to_id")
                     new_issue_relation.issue_from = issues_map[source_relation.issue_from_id]
                     if new_issue_relation.issue_from.nil? && Setting.cross_project_issue_relations?
                       new_issue_relation.issue_from = source_relation.issue_from
                     end
                     new_issue.relations_to << new_issue_relation
                   end
                 end
               end
               # Copies members from +project+
               def copy_members(project)
                 # Copy users first, then groups to handle members with inherited and given roles
                 members_to_copy = []
                 members_to_copy += project.memberships.select {|m| m.principal.is_a?(User)}
                 members_to_copy += project.memberships.select {|m| !m.principal.is_a?(User)}
                 members_to_copy.each do |member|
                   new_member = Member.new
                   new_member.attributes = member.attributes.dup.except("id", "project_id", "created_on")
                   # only copy non inherited roles
                   # inherited roles will be added when copying the group membership
                   role_ids = member.member_roles.reject(&:inherited?).collect(&:role_id)
                   next if role_ids.empty?
                   new_member.role_ids = role_ids
                   new_member.project = self
                   self.members << new_member
                 end
               end
               # Copies queries from +project+
               def copy_queries(project)
                 project.queries.each do |query|
                   new_query = IssueQuery.new
                   new_query.attributes = query.attributes.dup.except("id", "project_id", "sort_criteria", "user_id", "type")
                   new_query.sort_criteria = query.sort_criteria if query.sort_criteria
                   new_query.project = self
                   new_query.user_id = query.user_id
                   new_query.role_ids = query.role_ids if query.visibility == IssueQuery::VISIBILITY_ROLES
                   self.queries << new_query
                 end
               end
               # Copies boards from +project+
               def copy_boards(project)
                 project.boards.each do |board|
                   new_board = Board.new
                   new_board.attributes = board.attributes.dup.except("id", "project_id", "topics_count", "messages_count", "last_message_id")
                   new_board.project = self
                   self.boards << new_board
                 end
               end
               def allowed_permissions
                 @allowed_permissions ||= begin
                   module_names = enabled_modules.loaded? ? enabled_modules.map(&:name) : enabled_modules.pluck(:name)
                   Redmine::AccessControl.modules_permissions(module_names).collect {|p| p.name}
                 end
               end
               def allowed_actions
                 @actions_allowed ||= allowed_permissions.inject([]) { |actions, permission| actions += Redmine::AccessControl.allowed_actions(permission) }.flatten
               end
               # Archives subprojects recursively
               def archive!
                 children.each do |subproject|
                   subproject.send :archive!
                 end
                 update_attribute :status, STATUS_ARCHIVED
               end
             end

app/models/repository.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class ScmFetchError < Exception; end
             class Repository < ActiveRecord::Base
               include Redmine::Ciphering
               include Redmine::SafeAttributes
               # Maximum length for repository identifiers
               IDENTIFIER_MAX_LENGTH = 255
               belongs_to :project
               has_many :changesets, lambda{order("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC")}
               has_many :filechanges, :class_name => 'Change', :through => :changesets
               serialize :extra_info
               before_validation :normalize_identifier
               before_save :check_default
               # Raw SQL to delete changesets and changes in the database
               # has_many :changesets, :dependent => :destroy is too slow for big repositories
               before_destroy :clear_changesets
               validates_length_of :password, :maximum => 255, :allow_nil => true
               validates_length_of :identifier, :maximum => IDENTIFIER_MAX_LENGTH, :allow_blank => true
               validates_uniqueness_of :identifier, :scope => :project_id
               validates_exclusion_of :identifier, :in => %w(browse show entry raw changes annotate diff statistics graph revisions revision)
               # donwcase letters, digits, dashes, underscores but not digits only
               validates_format_of :identifier, :with => /\A(?!\d+$)[a-z0-9\-_]*\z/, :allow_blank => true
               # Checks if the SCM is enabled when creating a repository
               validate :repo_create_validation, :on => :create
               validate :validate_repository_path
               attr_protected :id
               safe_attributes 'identifier',
                 'login',
                 'password',
                 'path_encoding',
                 'log_encoding',
                 'is_default'
               safe_attributes 'url',
                 :if => lambda {|repository, user| repository.new_record?}
               def repo_create_validation
                 unless Setting.enabled_scm.include?(self.class.name.demodulize)
                   errors.add(:type, :invalid)
                 end
               end
               def self.human_attribute_name(attribute_key_name, *args)
                 attr_name = attribute_key_name.to_s
                 if attr_name == "log_encoding"
                   attr_name = "commit_logs_encoding"
                 end
                 super(attr_name, *args)
               end
               # Removes leading and trailing whitespace
               def url=(arg)
                 write_attribute(:url, arg ? arg.to_s.strip : nil)
               end
               # Removes leading and trailing whitespace
               def root_url=(arg)
                 write_attribute(:root_url, arg ? arg.to_s.strip : nil)
               end
               def password
                 read_ciphered_attribute(:password)
               end
               def password=(arg)
                 write_ciphered_attribute(:password, arg)
               end
               def scm_adapter
                 self.class.scm_adapter_class
               end
               def scm
                 unless @scm
                   @scm = self.scm_adapter.new(url, root_url,
                                               login, password, path_encoding)
                   if root_url.blank? && @scm.root_url.present?
                     update_attribute(:root_url, @scm.root_url)
                   end
                 end
                 @scm
               end
               def scm_name
                 self.class.scm_name
               end
               def name
                 if identifier.present?
                   identifier
                 elsif is_default?
                   l(:field_repository_is_default)
                 else
                   scm_name
                 end
               end
               def identifier=(identifier)
                 super unless identifier_frozen?
               end
               def identifier_frozen?
                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
               end
               def identifier_param
                 if is_default?
                   nil
                 elsif identifier.present?
                   identifier
                 else
                   id.to_s
                 end
               end
               def <=>(repository)
                 if is_default?
                   -1
                 elsif repository.is_default?
                 else
                   identifier.to_s <=> repository.identifier.to_s
                 end
               end
               def self.find_by_identifier_param(param)
                 if param.to_s =~ /^\d+$/
                   find_by_id(param)
                 else
                   find_by_identifier(param)
                 end
               end
               # TODO: should return an empty hash instead of nil to avoid many ||{}
               def extra_info
                 h = read_attribute(:extra_info)
                 h.is_a?(Hash) ? h : nil
               end
               def merge_extra_info(arg)
                 h = extra_info || {}
                 return h if arg.nil?
                 h.merge!(arg)
                 write_attribute(:extra_info, h)
               end
               def report_last_commit
                 true
               end
               def supports_cat?
                 scm.supports_cat?
               end
               def supports_annotate?
                 scm.supports_annotate?
               end
               def supports_all_revisions?
                 true
               end
               def supports_directory_revisions?
                 false
               end
               def supports_revision_graph?
                 false
               end
               def entry(path=nil, identifier=nil)
                 scm.entry(path, identifier)
               end
               def scm_entries(path=nil, identifier=nil)
                 scm.entries(path, identifier)
               end
               protected :scm_entries
               def entries(path=nil, identifier=nil)
                 entries = scm_entries(path, identifier)
                 load_entries_changesets(entries)
                 entries
               end
               def branches
                 scm.branches
               end
               def tags
                 scm.tags
               end
               def default_branch
                 nil
               end
               def properties(path, identifier=nil)
                 scm.properties(path, identifier)
               end
               def cat(path, identifier=nil)
                 scm.cat(path, identifier)
               end
               def diff(path, rev, rev_to)
                 scm.diff(path, rev, rev_to)
               end
               def diff_format_revisions(cs, cs_to, sep=':')
                 text = ""
                 text << cs_to.format_identifier + sep if cs_to
                 text << cs.format_identifier if cs
                 text
               end
               # Returns a path relative to the url of the repository
               def relative_path(path)
                 path
               end
               # Finds and returns a revision with a number or the beginning of a hash
               def find_changeset_by_name(name)
                 return nil if name.blank?
                 s = name.to_s
                 if s.match(/^\d*$/)
                   changesets.where("revision = ?", s).first
                 else
                   changesets.where("revision LIKE ?", s + '%').first
                 end
               end
               def latest_changeset
                 @latest_changeset ||= changesets.first
               end
               # Returns the latest changesets for +path+
               # Default behaviour is to search in cached changesets
               def latest_changesets(path, rev, limit=10)
                 if path.blank?
                   changesets.
                     reorder("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC").
                     limit(limit).
                     preload(:user).
                     to_a
                 else
                   filechanges.
                     where("path = ?", path.with_leading_slash).
                     reorder("#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC").
                     limit(limit).
                     preload(:changeset => :user).
                     collect(&:changeset)
                 end
               end
               def scan_changesets_for_issue_ids
                 self.changesets.each(&:scan_comment_for_issue_ids)
               end
               # Returns an array of committers usernames and associated user_id
               def committers
-                @committers ||= Changeset.where(:repository_id => id).uniq.pluck(:committer, :user_id)
+                @committers ||= Changeset.where(:repository_id => id).distinct.pluck(:committer, :user_id)
               end
               # Maps committers username to a user ids
               def committer_ids=(h)
                 if h.is_a?(Hash)
                   committers.each do |committer, user_id|
                     new_user_id = h[committer]
                     if new_user_id && (new_user_id.to_i != user_id.to_i)
                       new_user_id = (new_user_id.to_i > 0 ? new_user_id.to_i : nil)
                       Changeset.where(["repository_id = ? AND committer = ?", id, committer]).
                         update_all("user_id = #{new_user_id.nil? ? 'NULL' : new_user_id}")
                     end
                   end
                   @committers            = nil
                   @found_committer_users = nil
                   true
                 else
                   false
                 end
               end
               # Returns the Redmine User corresponding to the given +committer+
               # It will return nil if the committer is not yet mapped and if no User
               # with the same username or email was found
               def find_committer_user(committer)
                 unless committer.blank?
                   @found_committer_users ||= {}
                   return @found_committer_users[committer] if @found_committer_users.has_key?(committer)
                   user = nil
                   c = changesets.where(:committer => committer).
                         includes(:user).references(:user).first
                   if c && c.user
                     user = c.user
                   elsif committer.strip =~ /^([^<]+)(<(.*)>)?$/
                     username, email = $1.strip, $3
                     u = User.find_by_login(username)
                     u ||= User.find_by_mail(email) unless email.blank?
                     user = u
                   end
                   @found_committer_users[committer] = user
                   user
                 end
               end
               def repo_log_encoding
                 encoding = log_encoding.to_s.strip
                 encoding.blank? ? 'UTF-8' : encoding
               end
               # Fetches new changesets for all repositories of active projects
               # Can be called periodically by an external script
               # eg. ruby script/runner "Repository.fetch_changesets"
               def self.fetch_changesets
                 Project.active.has_module(:repository).all.each do |project|
                   project.repositories.each do |repository|
                     begin
                       repository.fetch_changesets
                     rescue Redmine::Scm::Adapters::CommandFailed => e
                       logger.error "scm: error during fetching changesets: #{e.message}"
                     end
                   end
                 end
               end
               # scan changeset comments to find related and fixed issues for all repositories
               def self.scan_changesets_for_issue_ids
                 all.each(&:scan_changesets_for_issue_ids)
               end
               def self.scm_name
                 'Abstract'
               end
               def self.available_scm
                 subclasses.collect {|klass| [klass.scm_name, klass.name]}
               end
               def self.factory(klass_name, *args)
                 klass = "Repository::#{klass_name}".constantize
                 klass.new(*args)
               rescue
                 nil
               end
               def self.scm_adapter_class
                 nil
               end
               def self.scm_command
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_command if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get command: #{e.message}"
                 end
                 ret
               end
               def self.scm_version_string
                 ret = ""
                 begin
                   ret = self.scm_adapter_class.client_version_string if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get version string: #{e.message}"
                 end
                 ret
               end
               def self.scm_available
                 ret = false
                 begin
                   ret = self.scm_adapter_class.client_available if self.scm_adapter_class
                 rescue Exception => e
                   logger.error "scm: error during get scm available: #{e.message}"
                 end
                 ret
               end
               def set_as_default?
                 new_record? && project && Repository.where(:project_id => project.id).empty?
               end
               # Returns a hash with statistics by author in the following form:
               # {
               #   "John Smith" => { :commits => 45, :changes => 324 },
               #   "Bob" => { ... }
               # }
               #
               # Notes:
               # - this hash honnors the users mapping defined for the repository
               def stats_by_author
                 commits = Changeset.where("repository_id = ?", id).select("committer, user_id, count(*) as count").group("committer, user_id")
                 #TODO: restore ordering ; this line probably never worked
                 #commits.to_a.sort! {|x, y| x.last <=> y.last}
                 changes = Change.joins(:changeset).where("#{Changeset.table_name}.repository_id = ?", id).select("committer, user_id, count(*) as count").group("committer, user_id")
                 user_ids = changesets.map(&:user_id).compact.uniq
                 authors_names = User.where(:id => user_ids).inject({}) do |memo, user|
                   memo[user.id] = user.to_s
                   memo
                 end
                 (commits + changes).inject({}) do |hash, element|
                   mapped_name = element.committer
                   if username = authors_names[element.user_id.to_i]
                     mapped_name = username
                   end
                   hash[mapped_name] ||= { :commits_count => 0, :changes_count => 0 }
                   if element.is_a?(Changeset)
                     hash[mapped_name][:commits_count] += element.count.to_i
                   else
                     hash[mapped_name][:changes_count] += element.count.to_i
                   end
                   hash
                 end
               end
               # Returns a scope of changesets that come from the same commit as the given changeset
               # in different repositories that point to the same backend
               def same_commits_in_scope(scope, changeset)
                 scope = scope.joins(:repository).where(:repositories => {:url => url, :root_url => root_url, :type => type})
                 if changeset.scmid.present?
                   scope = scope.where(:scmid => changeset.scmid)
                 else
                   scope = scope.where(:revision => changeset.revision)
                 end
                 scope
               end
               protected
               # Validates repository url based against an optional regular expression
               # that can be set in the Redmine configuration file.
               def validate_repository_path(attribute=:url)
                 regexp = Redmine::Configuration["scm_#{scm_name.to_s.downcase}_path_regexp"]
                 if changes[attribute] && regexp.present?
                   regexp = regexp.to_s.strip.gsub('%project%') {Regexp.escape(project.try(:identifier).to_s)}
                   unless send(attribute).to_s.match(Regexp.new("\\A#{regexp}\\z"))
                     errors.add(attribute, :invalid)
                   end
                 end
               end
               def normalize_identifier
                 self.identifier = identifier.to_s.strip
               end
               def check_default
                 if !is_default? && set_as_default?
                   self.is_default = true
                 end
                 if is_default? && is_default_changed?
                   Repository.where(["project_id = ?", project_id]).update_all(["is_default = ?", false])
                 end
               end
               def load_entries_changesets(entries)
                 if entries
                   entries.each do |entry|
                     if entry.lastrev && entry.lastrev.identifier
                       entry.changeset = find_changeset_by_name(entry.lastrev.identifier)
                     end
                   end
                 end
               end
               private
               # Deletes repository data
               def clear_changesets
                 cs = Changeset.table_name
                 ch = Change.table_name
                 ci = "#{table_name_prefix}changesets_issues#{table_name_suffix}"
                 cp = "#{table_name_prefix}changeset_parents#{table_name_suffix}"
                 self.class.connection.delete("DELETE FROM #{ch} WHERE #{ch}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{ci} WHERE #{ci}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{cp} WHERE #{cp}.changeset_id IN (SELECT #{cs}.id FROM #{cs} WHERE #{cs}.repository_id = #{id})")
                 self.class.connection.delete("DELETE FROM #{cs} WHERE #{cs}.repository_id = #{id}")
               end
             end

app/models/tracker.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Tracker < ActiveRecord::Base
               CORE_FIELDS_UNDISABLABLE = %w(project_id tracker_id subject description priority_id is_private).freeze
               # Fields that can be disabled
               # Other (future) fields should be appended, not inserted!
               CORE_FIELDS = %w(assigned_to_id category_id fixed_version_id parent_issue_id start_date due_date estimated_hours done_ratio).freeze
               CORE_FIELDS_ALL = (CORE_FIELDS_UNDISABLABLE + CORE_FIELDS).freeze
               before_destroy :check_integrity
               belongs_to :default_status, :class_name => 'IssueStatus'
               has_many :issues
               has_many :workflow_rules, :dependent => :delete_all do
                 def copy(source_tracker)
                   WorkflowRule.copy(source_tracker, nil, proxy_association.owner, nil)
                 end
               end
               has_and_belongs_to_many :projects
               has_and_belongs_to_many :custom_fields, :class_name => 'IssueCustomField', :join_table => "#{table_name_prefix}custom_fields_trackers#{table_name_suffix}", :association_foreign_key => 'custom_field_id'
               acts_as_positioned
               attr_protected :fields_bits
               validates_presence_of :default_status
               validates_presence_of :name
               validates_uniqueness_of :name
               validates_length_of :name, :maximum => 30
               scope :sorted, lambda { order(:position) }
               scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
               # Returns the trackers that are visible by the user.
               #
               # Examples:
               #   project.trackers.visible(user)
               #   => returns the trackers that are visible by the user in project
               #
               #   Tracker.visible(user)
               #   => returns the trackers that are visible by the user in at least on project
               scope :visible, lambda {|*args|
                 user = args.shift || User.current
                 condition = Project.allowed_to_condition(user, :view_issues) do |role, user|
                   unless role.permissions_all_trackers?(:view_issues)
                     tracker_ids = role.permissions_tracker_ids(:view_issues)
                     if tracker_ids.any?
                       "#{Tracker.table_name}.id IN (#{tracker_ids.join(',')})"
                     else
                       '1=0'
                     end
                   end
                 end
-                joins(:projects).where(condition).uniq
+                joins(:projects).where(condition).distinct
               }
               def to_s; name end
               def <=>(tracker)
                 position <=> tracker.position
               end
               # Returns an array of IssueStatus that are used
               # in the tracker's workflows
               def issue_statuses
                 @issue_statuses ||= IssueStatus.where(:id => issue_status_ids).to_a.sort
               end
               def issue_status_ids
                 if new_record?
                   []
                 else
-                  @issue_status_ids ||= WorkflowTransition.where(:tracker_id => id).uniq.pluck(:old_status_id, :new_status_id).flatten.uniq
+                  @issue_status_ids ||= WorkflowTransition.where(:tracker_id => id).distinct.pluck(:old_status_id, :new_status_id).flatten.uniq
                 end
               end
               def disabled_core_fields
                 i = -1
                 @disabled_core_fields ||= CORE_FIELDS.select { i += 1; (fields_bits || 0) & (2 ** i) != 0}
               end
               def core_fields
                 CORE_FIELDS - disabled_core_fields
               end
               def core_fields=(fields)
                 raise ArgumentError.new("Tracker.core_fields takes an array") unless fields.is_a?(Array)
                 bits = 0
                 CORE_FIELDS.each_with_index do |field, i|
                   unless fields.include?(field)
                     bits |= 2 ** i
                   end
                 end
                 self.fields_bits = bits
                 @disabled_core_fields = nil
                 core_fields
               end
               # Returns the fields that are disabled for all the given trackers
               def self.disabled_core_fields(trackers)
                 if trackers.present?
                   trackers.map(&:disabled_core_fields).reduce(:&)
                 else
                   []
                 end
               end
               # Returns the fields that are enabled for one tracker at least
               def self.core_fields(trackers)
                 if trackers.present?
                   trackers.uniq.map(&:core_fields).reduce(:|)
                 else
                   CORE_FIELDS.dup
                 end
               end
             private
               def check_integrity
                 raise Exception.new("Cannot delete tracker") if Issue.where(:tracker_id => self.id).any?
               end
             end

app/models/user.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require "digest/sha1"
             class User < Principal
               include Redmine::SafeAttributes
               # Different ways of displaying/sorting users
               USER_FORMATS = {
                 :firstname_lastname => {
                     :string => '#{firstname} #{lastname}',
                     :order => %w(firstname lastname id),
                     :setting_order => 1
                   },
                 :firstname_lastinitial => {
                     :string => '#{firstname} #{lastname.to_s.chars.first}.',
                     :order => %w(firstname lastname id),
                     :setting_order => 2
                   },
                 :firstinitial_lastname => {
                     :string => '#{firstname.to_s.gsub(/(([[:alpha:]])[[:alpha:]]*\.?)/, \'\2.\')} #{lastname}',
                     :order => %w(firstname lastname id),
                     :setting_order => 2
                   },
                 :firstname => {
                     :string => '#{firstname}',
                     :order => %w(firstname id),
                     :setting_order => 3
                   },
                 :lastname_firstname => {
                     :string => '#{lastname} #{firstname}',
                     :order => %w(lastname firstname id),
                     :setting_order => 4
                   },
                 :lastnamefirstname => {
                     :string => '#{lastname}#{firstname}',
                     :order => %w(lastname firstname id),
                     :setting_order => 5
                   },
                 :lastname_comma_firstname => {
                     :string => '#{lastname}, #{firstname}',
                     :order => %w(lastname firstname id),
                     :setting_order => 6
                   },
                 :lastname => {
                     :string => '#{lastname}',
                     :order => %w(lastname id),
                     :setting_order => 7
                   },
                 :username => {
                     :string => '#{login}',
                     :order => %w(login id),
                     :setting_order => 8
                   },
               }
               MAIL_NOTIFICATION_OPTIONS = [
                 ['all', :label_user_mail_option_all],
                 ['selected', :label_user_mail_option_selected],
                 ['only_my_events', :label_user_mail_option_only_my_events],
                 ['only_assigned', :label_user_mail_option_only_assigned],
                 ['only_owner', :label_user_mail_option_only_owner],
                 ['none', :label_user_mail_option_none]
               ]
               has_and_belongs_to_many :groups,
                                       :join_table   => "#{table_name_prefix}groups_users#{table_name_suffix}",
                                       :after_add    => Proc.new {|user, group| group.user_added(user)},
                                       :after_remove => Proc.new {|user, group| group.user_removed(user)}
               has_many :changesets, :dependent => :nullify
               has_one :preference, :dependent => :destroy, :class_name => 'UserPreference'
               has_one :rss_token, lambda {where "action='feeds'"}, :class_name => 'Token'
               has_one :api_token, lambda {where "action='api'"}, :class_name => 'Token'
               has_one :email_address, lambda {where :is_default => true}, :autosave => true
               has_many :email_addresses, :dependent => :delete_all
               belongs_to :auth_source
               scope :logged, lambda { where("#{User.table_name}.status <> #{STATUS_ANONYMOUS}") }
               scope :status, lambda {|arg| where(arg.blank? ? nil : {:status => arg.to_i}) }
               acts_as_customizable
               attr_accessor :password, :password_confirmation, :generate_password
               attr_accessor :last_before_login_on
               attr_accessor :remote_ip
               # Prevents unauthorized assignments
               attr_protected :login, :admin, :password, :password_confirmation, :hashed_password
               LOGIN_LENGTH_LIMIT = 60
               MAIL_LENGTH_LIMIT = 60
               validates_presence_of :login, :firstname, :lastname, :if => Proc.new { |user| !user.is_a?(AnonymousUser) }
               validates_uniqueness_of :login, :if => Proc.new { |user| user.login_changed? && user.login.present? }, :case_sensitive => false
               # Login must contain letters, numbers, underscores only
               validates_format_of :login, :with => /\A[a-z0-9_\-@\.]*\z/i
               validates_length_of :login, :maximum => LOGIN_LENGTH_LIMIT
               validates_length_of :firstname, :lastname, :maximum => 30
               validates_inclusion_of :mail_notification, :in => MAIL_NOTIFICATION_OPTIONS.collect(&:first), :allow_blank => true
               validate :validate_password_length
               validate do
                 if password_confirmation && password != password_confirmation
                   errors.add(:password, :confirmation)
                 end
               end
               self.valid_statuses = [STATUS_ACTIVE, STATUS_REGISTERED, STATUS_LOCKED]
               before_validation :instantiate_email_address
               before_create :set_mail_notification
               before_save   :generate_password_if_needed, :update_hashed_password
               before_destroy :remove_references_before_destroy
               after_save :update_notified_project_ids, :destroy_tokens, :deliver_security_notification
               after_destroy :deliver_security_notification
               scope :in_group, lambda {|group|
                 group_id = group.is_a?(Group) ? group.id : group.to_i
                 where("#{User.table_name}.id IN (SELECT gu.user_id FROM #{table_name_prefix}groups_users#{table_name_suffix} gu WHERE gu.group_id = ?)", group_id)
               }
               scope :not_in_group, lambda {|group|
                 group_id = group.is_a?(Group) ? group.id : group.to_i
                 where("#{User.table_name}.id NOT IN (SELECT gu.user_id FROM #{table_name_prefix}groups_users#{table_name_suffix} gu WHERE gu.group_id = ?)", group_id)
               }
               scope :sorted, lambda { order(*User.fields_for_order_statement)}
               scope :having_mail, lambda {|arg|
                 addresses = Array.wrap(arg).map {|a| a.to_s.downcase}
                 if addresses.any?
-                  joins(:email_addresses).where("LOWER(#{EmailAddress.table_name}.address) IN (?)", addresses).uniq
+                  joins(:email_addresses).where("LOWER(#{EmailAddress.table_name}.address) IN (?)", addresses).distinct
                 else
                   none
                 end
               }
               def set_mail_notification
                 self.mail_notification = Setting.default_notification_option if self.mail_notification.blank?
                 true
               end
               def update_hashed_password
                 # update hashed_password if password was set
                 if self.password && self.auth_source_id.blank?
                   salt_password(password)
                 end
               end
               alias :base_reload :reload
               def reload(*args)
                 @name = nil
                 @projects_by_role = nil
                 @membership_by_project_id = nil
                 @notified_projects_ids = nil
                 @notified_projects_ids_changed = false
                 @builtin_role = nil
                 @visible_project_ids = nil
                 @managed_roles = nil
                 base_reload(*args)
               end
               def mail
                 email_address.try(:address)
               end
               def mail=(arg)
                 email = email_address || build_email_address
                 email.address = arg
               end
               def mail_changed?
                 email_address.try(:address_changed?)
               end
               def mails
                 email_addresses.pluck(:address)
               end
               def self.find_or_initialize_by_identity_url(url)
                 user = where(:identity_url => url).first
                 unless user
                   user = User.new
                   user.identity_url = url
                 end
                 user
               end
               def identity_url=(url)
                 if url.blank?
                   write_attribute(:identity_url, '')
                 else
                   begin
                     write_attribute(:identity_url, OpenIdAuthentication.normalize_identifier(url))
                   rescue OpenIdAuthentication::InvalidOpenId
                     # Invalid url, don't save
                   end
                 end
                 self.read_attribute(:identity_url)
               end
               # Returns the user that matches provided login and password, or nil
               def self.try_to_login(login, password, active_only=true)
                 login = login.to_s
                 password = password.to_s
                 # Make sure no one can sign in with an empty login or password
                 return nil if login.empty? || password.empty?
                 user = find_by_login(login)
                 if user
                   # user is already in local database
                   return nil unless user.check_password?(password)
                   return nil if !user.active? && active_only
                 else
                   # user is not yet registered, try to authenticate with available sources
                   attrs = AuthSource.authenticate(login, password)
                   if attrs
                     user = new(attrs)
                     user.login = login
                     user.language = Setting.default_language
                     if user.save
                       user.reload
                       logger.info("User '#{user.login}' created from external auth source: #{user.auth_source.type} - #{user.auth_source.name}") if logger && user.auth_source
                     end
                   end
                 end
                 user.update_column(:last_login_on, Time.now) if user && !user.new_record? && user.active?
                 user
               rescue => text
                 raise text
               end
               # Returns the user who matches the given autologin +key+ or nil
               def self.try_to_autologin(key)
                 user = Token.find_active_user('autologin', key, Setting.autologin.to_i)
                 if user
                   user.update_column(:last_login_on, Time.now)
                   user
                 end
               end
               def self.name_formatter(formatter = nil)
                 USER_FORMATS[formatter || Setting.user_format] || USER_FORMATS[:firstname_lastname]
               end
               # Returns an array of fields names than can be used to make an order statement for users
               # according to how user names are displayed
               # Examples:
               #
               #   User.fields_for_order_statement              => ['users.login', 'users.id']
               #   User.fields_for_order_statement('authors')   => ['authors.login', 'authors.id']
               def self.fields_for_order_statement(table=nil)
                 table ||= table_name
                 name_formatter[:order].map {|field| "#{table}.#{field}"}
               end
               # Return user's full name for display
               def name(formatter = nil)
                 f = self.class.name_formatter(formatter)
                 if formatter
                   eval('"' + f[:string] + '"')
                 else
                   @name ||= eval('"' + f[:string] + '"')
                 end
               end
               def active?
                 self.status == STATUS_ACTIVE
               end
               def registered?
                 self.status == STATUS_REGISTERED
               end
               def locked?
                 self.status == STATUS_LOCKED
               end
               def activate
                 self.status = STATUS_ACTIVE
               end
               def register
                 self.status = STATUS_REGISTERED
               end
               def lock
                 self.status = STATUS_LOCKED
               end
               def activate!
                 update_attribute(:status, STATUS_ACTIVE)
               end
               def register!
                 update_attribute(:status, STATUS_REGISTERED)
               end
               def lock!
                 update_attribute(:status, STATUS_LOCKED)
               end
               # Returns true if +clear_password+ is the correct user's password, otherwise false
               def check_password?(clear_password)
                 if auth_source_id.present?
                   auth_source.authenticate(self.login, clear_password)
                 else
                   User.hash_password("#{salt}#{User.hash_password clear_password}") == hashed_password
                 end
               end
               # Generates a random salt and computes hashed_password for +clear_password+
               # The hashed password is stored in the following form: SHA1(salt + SHA1(password))
               def salt_password(clear_password)
                 self.salt = User.generate_salt
                 self.hashed_password = User.hash_password("#{salt}#{User.hash_password clear_password}")
                 self.passwd_changed_on = Time.now.change(:usec => 0)
               end
               # Does the backend storage allow this user to change their password?
               def change_password_allowed?
                 return true if auth_source.nil?
                 return auth_source.allow_password_changes?
               end
               # Returns true if the user password has expired
               def password_expired?
                 period = Setting.password_max_age.to_i
                 if period.zero?
                   false
                 else
                   changed_on = self.passwd_changed_on || Time.at(0)
                   changed_on < period.days.ago
                 end
               end
               def must_change_password?
                 (must_change_passwd? || password_expired?) && change_password_allowed?
               end
               def generate_password?
                 generate_password == '1' || generate_password == true
               end
               # Generate and set a random password on given length
               def random_password(length=40)
                 chars = ("a".."z").to_a + ("A".."Z").to_a + ("0".."9").to_a
                 chars -= %w(0 O 1 l)
                 password = ''
                 length.times {|i| password << chars[SecureRandom.random_number(chars.size)] }
                 self.password = password
                 self.password_confirmation = password
                 self
               end
               def pref
                 self.preference ||= UserPreference.new(:user => self)
               end
               def time_zone
                 @time_zone ||= (self.pref.time_zone.blank? ? nil : ActiveSupport::TimeZone[self.pref.time_zone])
               end
               def force_default_language?
                 Setting.force_default_language_for_loggedin?
               end
               def language
                 if force_default_language?
                   Setting.default_language
                 else
                   super
                 end
               end
               def wants_comments_in_reverse_order?
                 self.pref[:comments_sorting] == 'desc'
               end
               # Return user's RSS key (a 40 chars long string), used to access feeds
               def rss_key
                 if rss_token.nil?
                   create_rss_token(:action => 'feeds')
                 end
                 rss_token.value
               end
               # Return user's API key (a 40 chars long string), used to access the API
               def api_key
                 if api_token.nil?
                   create_api_token(:action => 'api')
                 end
                 api_token.value
               end
               # Generates a new session token and returns its value
               def generate_session_token
                 token = Token.create!(:user_id => id, :action => 'session')
                 token.value
               end
               # Returns true if token is a valid session token for the user whose id is user_id
               def self.verify_session_token(user_id, token)
                 return false if user_id.blank? || token.blank?
                 scope = Token.where(:user_id => user_id, :value => token.to_s, :action => 'session')
                 if Setting.session_lifetime?
                   scope = scope.where("created_on > ?", Setting.session_lifetime.to_i.minutes.ago)
                 end
                 if Setting.session_timeout?
                   scope = scope.where("updated_on > ?", Setting.session_timeout.to_i.minutes.ago)
                 end
                 scope.update_all(:updated_on => Time.now) == 1
               end
               # Return an array of project ids for which the user has explicitly turned mail notifications on
               def notified_projects_ids
                 @notified_projects_ids ||= memberships.select {|m| m.mail_notification?}.collect(&:project_id)
               end
               def notified_project_ids=(ids)
                 @notified_projects_ids_changed = true
                 @notified_projects_ids = ids.map(&:to_i).uniq.select {|n| n > 0}
               end
               # Updates per project notifications (after_save callback)
               def update_notified_project_ids
                 if @notified_projects_ids_changed
                   ids = (mail_notification == 'selected' ? Array.wrap(notified_projects_ids).reject(&:blank?) : [])
                   members.update_all(:mail_notification => false)
                   members.where(:project_id => ids).update_all(:mail_notification => true) if ids.any?
                 end
               end
               private :update_notified_project_ids
               def valid_notification_options
                 self.class.valid_notification_options(self)
               end
               # Only users that belong to more than 1 project can select projects for which they are notified
               def self.valid_notification_options(user=nil)
                 # Note that @user.membership.size would fail since AR ignores
                 # :include association option when doing a count
                 if user.nil? || user.memberships.length < 1
                   MAIL_NOTIFICATION_OPTIONS.reject {|option| option.first == 'selected'}
                 else
                   MAIL_NOTIFICATION_OPTIONS
                 end
               end
               # Find a user account by matching the exact login and then a case-insensitive
               # version.  Exact matches will be given priority.
               def self.find_by_login(login)
                 login = Redmine::CodesetUtil.replace_invalid_utf8(login.to_s)
                 if login.present?
                   # First look for an exact match
                   user = where(:login => login).detect {|u| u.login == login}
                   unless user
                     # Fail over to case-insensitive if none was found
                     user = where("LOWER(login) = ?", login.downcase).first
                   end
                   user
                 end
               end
               def self.find_by_rss_key(key)
                 Token.find_active_user('feeds', key)
               end
               def self.find_by_api_key(key)
                 Token.find_active_user('api', key)
               end
               # Makes find_by_mail case-insensitive
               def self.find_by_mail(mail)
                 having_mail(mail).first
               end
               # Returns true if the default admin account can no longer be used
               def self.default_admin_account_changed?
                 !User.active.find_by_login("admin").try(:check_password?, "admin")
               end
               def to_s
                 name
               end
               CSS_CLASS_BY_STATUS = {
                 STATUS_ANONYMOUS  => 'anon',
                 STATUS_ACTIVE     => 'active',
                 STATUS_REGISTERED => 'registered',
                 STATUS_LOCKED     => 'locked'
               }
               def css_classes
                 "user #{CSS_CLASS_BY_STATUS[status]}"
               end
               # Returns the current day according to user's time zone
               def today
                 if time_zone.nil?
                   Date.today
                 else
                   time_zone.today
                 end
               end
               # Returns the day of +time+ according to user's time zone
               def time_to_date(time)
                 if time_zone.nil?
                   time.to_date
                 else
                   time.in_time_zone(time_zone).to_date
                 end
               end
               def logged?
                 true
               end
               def anonymous?
                 !logged?
               end
               # Returns user's membership for the given project
               # or nil if the user is not a member of project
               def membership(project)
                 project_id = project.is_a?(Project) ? project.id : project
                 @membership_by_project_id ||= Hash.new {|h, project_id|
                   h[project_id] = memberships.where(:project_id => project_id).first
                 }
                 @membership_by_project_id[project_id]
               end
               # Returns the user's bult-in role
               def builtin_role
                 @builtin_role ||= Role.non_member
               end
               # Return user's roles for project
               def roles_for_project(project)
                 # No role on archived projects
                 return [] if project.nil? || project.archived?
                 if membership = membership(project)
                   membership.roles.to_a
                 elsif project.is_public?
                   project.override_roles(builtin_role)
                 else
                   []
                 end
               end
               # Returns a hash of user's projects grouped by roles
               def projects_by_role
                 return @projects_by_role if @projects_by_role
                 hash = Hash.new([])
                 group_class = anonymous? ? GroupAnonymous : GroupNonMember
                 members = Member.joins(:project, :principal).
                   where("#{Project.table_name}.status <> 9").
                   where("#{Member.table_name}.user_id = ? OR (#{Project.table_name}.is_public = ? AND #{Principal.table_name}.type = ?)", self.id, true, group_class.name).
                   preload(:project, :roles).
                   to_a
                 members.reject! {|member| member.user_id != id && project_ids.include?(member.project_id)}
                 members.each do |member|
                   if member.project
                     member.roles.each do |role|
                       hash[role] = [] unless hash.key?(role)
                       hash[role] << member.project
                     end
                   end
                 end
                 hash.each do |role, projects|
                   projects.uniq!
                 end
                 @projects_by_role = hash
               end
               # Returns the ids of visible projects
               def visible_project_ids
                 @visible_project_ids ||= Project.visible(self).pluck(:id)
               end
               # Returns the roles that the user is allowed to manage for the given project
               def managed_roles(project)
                 if admin?
                   @managed_roles ||= Role.givable.to_a
                 else
                   membership(project).try(:managed_roles) || []
                 end
               end
               # Returns true if user is arg or belongs to arg
               def is_or_belongs_to?(arg)
                 if arg.is_a?(User)
                   self == arg
                 elsif arg.is_a?(Group)
                   arg.users.include?(self)
                 else
                   false
                 end
               end
               # Return true if the user is allowed to do the specified action on a specific context
               # Action can be:
               # * a parameter-like Hash (eg. :controller => 'projects', :action => 'edit')
               # * a permission Symbol (eg. :edit_project)
               # Context can be:
               # * a project : returns true if user is allowed to do the specified action on this project
               # * an array of projects : returns true if user is allowed on every project
               # * nil with options[:global] set : check if user has at least one role allowed for this action,
               #   or falls back to Non Member / Anonymous permissions depending if the user is logged
               def allowed_to?(action, context, options={}, &block)
                 if context && context.is_a?(Project)
                   return false unless context.allows_to?(action)
                   # Admin users are authorized for anything else
                   return true if admin?
                   roles = roles_for_project(context)
                   return false unless roles
                   roles.any? {|role|
                     (context.is_public? || role.member?) &&
                     role.allowed_to?(action) &&
                     (block_given? ? yield(role, self) : true)
                   }
                 elsif context && context.is_a?(Array)
                   if context.empty?
                     false
                   else
                     # Authorize if user is authorized on every element of the array
                     context.map {|project| allowed_to?(action, project, options, &block)}.reduce(:&)
                   end
                 elsif context
                   raise ArgumentError.new("#allowed_to? context argument must be a Project, an Array of projects or nil")
                 elsif options[:global]
                   # Admin users are always authorized
                   return true if admin?
                   # authorize if user has at least one role that has this permission
                   roles = memberships.collect {|m| m.roles}.flatten.uniq
                   roles << (self.logged? ? Role.non_member : Role.anonymous)
                   roles.any? {|role|
                     role.allowed_to?(action) &&
                     (block_given? ? yield(role, self) : true)
                   }
                 else
                   false
                 end
               end
               # Is the user allowed to do the specified action on any project?
               # See allowed_to? for the actions and valid options.
               #
               # NB: this method is not used anywhere in the core codebase as of
               # 2.5.2, but it's used by many plugins so if we ever want to remove
               # it it has to be carefully deprecated for a version or two.
               def allowed_to_globally?(action, options={}, &block)
                 allowed_to?(action, nil, options.reverse_merge(:global => true), &block)
               end
               def allowed_to_view_all_time_entries?(context)
                 allowed_to?(:view_time_entries, context) do |role, user|
                   role.time_entries_visibility == 'all'
                 end
               end
               # Returns true if the user is allowed to delete the user's own account
               def own_account_deletable?
                 Setting.unsubscribe? &&
                   (!admin? || User.active.where("admin = ? AND id <> ?", true, id).exists?)
               end
               safe_attributes 'firstname',
                 'lastname',
                 'mail',
                 'mail_notification',
                 'notified_project_ids',
                 'language',
                 'custom_field_values',
                 'custom_fields',
                 'identity_url'
               safe_attributes 'status',
                 'auth_source_id',
                 'generate_password',
                 'must_change_passwd',
                 :if => lambda {|user, current_user| current_user.admin?}
               safe_attributes 'group_ids',
                 :if => lambda {|user, current_user| current_user.admin? && !user.new_record?}
               # Utility method to help check if a user should be notified about an
               # event.
               #
               # TODO: only supports Issue events currently
               def notify_about?(object)
                 if mail_notification == 'all'
                   true
                 elsif mail_notification.blank? || mail_notification == 'none'
                   false
                 else
                   case object
                   when Issue
                     case mail_notification
                     when 'selected', 'only_my_events'
                       # user receives notifications for created/assigned issues on unselected projects
                       object.author == self || is_or_belongs_to?(object.assigned_to) || is_or_belongs_to?(object.assigned_to_was)
                     when 'only_assigned'
                       is_or_belongs_to?(object.assigned_to) || is_or_belongs_to?(object.assigned_to_was)
                     when 'only_owner'
                       object.author == self
                     end
                   when News
                     # always send to project members except when mail_notification is set to 'none'
                     true
                   end
                 end
               end
               def self.current=(user)
                 RequestStore.store[:current_user] = user
               end
               def self.current
                 RequestStore.store[:current_user] ||= User.anonymous
               end
               # Returns the anonymous user.  If the anonymous user does not exist, it is created.  There can be only
               # one anonymous user per database.
               def self.anonymous
                 anonymous_user = AnonymousUser.first
                 if anonymous_user.nil?
                   anonymous_user = AnonymousUser.create(:lastname => 'Anonymous', :firstname => '', :login => '', :status => 0)
                   raise 'Unable to create the anonymous user.' if anonymous_user.new_record?
                 end
                 anonymous_user
               end
               # Salts all existing unsalted passwords
               # It changes password storage scheme from SHA1(password) to SHA1(salt + SHA1(password))
               # This method is used in the SaltPasswords migration and is to be kept as is
               def self.salt_unsalted_passwords!
                 transaction do
                   User.where("salt IS NULL OR salt = ''").find_each do |user|
                     next if user.hashed_password.blank?
                     salt = User.generate_salt
                     hashed_password = User.hash_password("#{salt}#{user.hashed_password}")
                     User.where(:id => user.id).update_all(:salt => salt, :hashed_password => hashed_password)
                   end
                 end
               end
               protected
               def validate_password_length
                 return if password.blank? && generate_password?
                 # Password length validation based on setting
                 if !password.nil? && password.size < Setting.password_min_length.to_i
                   errors.add(:password, :too_short, :count => Setting.password_min_length.to_i)
                 end
               end
               def instantiate_email_address
                 email_address || build_email_address
               end
               private
               def generate_password_if_needed
                 if generate_password? && auth_source.nil?
                   length = [Setting.password_min_length.to_i + 2, 10].max
                   random_password(length)
                 end
               end
               # Delete all outstanding password reset tokens on password change.
               # Delete the autologin tokens on password change to prohibit session leakage.
               # This helps to keep the account secure in case the associated email account
               # was compromised.
               def destroy_tokens
                 if hashed_password_changed? || (status_changed? && !active?)
                   tokens = ['recovery', 'autologin', 'session']
                   Token.where(:user_id => id, :action => tokens).delete_all
                 end
               end
               # Removes references that are not handled by associations
               # Things that are not deleted are reassociated with the anonymous user
               def remove_references_before_destroy
                 return if self.id.nil?
                 substitute = User.anonymous
                 Attachment.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 Comment.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 Issue.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 Issue.where(['assigned_to_id = ?', id]).update_all('assigned_to_id = NULL')
                 Journal.where(['user_id = ?', id]).update_all(['user_id = ?', substitute.id])
                 JournalDetail.
                   where(["property = 'attr' AND prop_key = 'assigned_to_id' AND old_value = ?", id.to_s]).
                   update_all(['old_value = ?', substitute.id.to_s])
                 JournalDetail.
                   where(["property = 'attr' AND prop_key = 'assigned_to_id' AND value = ?", id.to_s]).
                   update_all(['value = ?', substitute.id.to_s])
                 Message.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 News.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 # Remove private queries and keep public ones
                 ::Query.delete_all ['user_id = ? AND visibility = ?', id, ::Query::VISIBILITY_PRIVATE]
                 ::Query.where(['user_id = ?', id]).update_all(['user_id = ?', substitute.id])
                 TimeEntry.where(['user_id = ?', id]).update_all(['user_id = ?', substitute.id])
                 Token.delete_all ['user_id = ?', id]
                 Watcher.delete_all ['user_id = ?', id]
                 WikiContent.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
                 WikiContent::Version.where(['author_id = ?', id]).update_all(['author_id = ?', substitute.id])
               end
               # Return password digest
               def self.hash_password(clear_password)
                 Digest::SHA1.hexdigest(clear_password || "")
               end
               # Returns a 128bits random salt as a hex string (32 chars long)
               def self.generate_salt
                 Redmine::Utils.random_hex(16)
               end
               # Send a security notification to all admins if the user has gained/lost admin privileges
               def deliver_security_notification
                 options = {
                   field: :field_admin,
                   value: login,
                   title: :label_user_plural,
                   url: {controller: 'users', action: 'index'}
                 }
                 deliver = false
                 if (admin? && id_changed? && active?) ||    # newly created admin
                    (admin? && admin_changed? && active?) || # regular user became admin
                    (admin? && status_changed? && active?)   # locked admin became active again
                    deliver = true
                    options[:message] = :mail_body_security_notification_add
                 elsif (admin? && destroyed? && active?) ||      # active admin user was deleted
                       (!admin? && admin_changed? && active?) || # admin is no longer admin
                       (admin? && status_changed? && !active?)   # admin was locked
                       deliver = true
                       options[:message] = :mail_body_security_notification_remove
                 end
                 if deliver
                   users = User.active.where(admin: true).to_a
                   Mailer.security_notification(users, options).deliver
                 end
               end
             end
             class AnonymousUser < User
               validate :validate_anonymous_uniqueness, :on => :create
               self.valid_statuses = [STATUS_ANONYMOUS]
               def validate_anonymous_uniqueness
                 # There should be only one AnonymousUser in the database
                 errors.add :base, 'An anonymous user already exists.' if AnonymousUser.exists?
               end
               def available_custom_fields
                 []
               end
               # Overrides a few properties
               def logged?; false end
               def admin; false end
               def name(*args); I18n.t(:label_user_anonymous) end
               def mail=(*args); nil end
               def mail; nil end
               def time_zone; nil end
               def rss_key; nil end
               def pref
                 UserPreference.new(:user => self)
               end
               # Returns the user's bult-in role
               def builtin_role
                 @builtin_role ||= Role.anonymous
               end
               def membership(*args)
                 nil
               end
               def member_of?(*args)
                 false
               end
               # Anonymous user can not be destroyed
               def destroy
                 false
               end
               protected
               def instantiate_email_address
               end
             end

lib/plugins/acts_as_searchable/lib/acts_as_searchable.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module Acts
                 module Searchable
                   def self.included(base)
                     base.extend ClassMethods
                   end
                   module ClassMethods
                     # Adds the search methods to the class.
                     #
                     # Options:
                     # * :columns - a column or an array of columns to search
                     # * :project_key - project foreign key (default to project_id)
                     # * :date_column - name of the datetime column used to sort results (default to :created_on)
                     # * :permission - permission required to search the model
                     # * :scope - scope used to search results
                     # * :preload - associations to preload when loading results for display
                     def acts_as_searchable(options = {})
                       return if self.included_modules.include?(Redmine::Acts::Searchable::InstanceMethods)
                       options.assert_valid_keys(:columns, :project_key, :date_column, :permission, :scope, :preload)
                       cattr_accessor :searchable_options
                       self.searchable_options = options
                       if searchable_options[:columns].nil?
                         raise 'No searchable column defined.'
                       elsif !searchable_options[:columns].is_a?(Array)
                         searchable_options[:columns] = [] << searchable_options[:columns]
                       end
                       searchable_options[:project_key] ||= "#{table_name}.project_id"
                       searchable_options[:date_column] ||= :created_on
                       # Should we search additional associations on this model ?
                       searchable_options[:search_custom_fields] = reflect_on_association(:custom_values).present?
                       searchable_options[:search_attachments] = reflect_on_association(:attachments).present?
                       searchable_options[:search_journals] = reflect_on_association(:journals).present?
                       send :include, Redmine::Acts::Searchable::InstanceMethods
                     end
                   end
                   module InstanceMethods
                     def self.included(base)
                       base.extend ClassMethods
                     end
                     module ClassMethods
                       # Searches the model for the given tokens and user visibility.
                       # The projects argument can be either nil (will search all projects), a project or an array of projects.
                       # Returns an array that contains the rank and id of all results.
                       # In current implementation, the rank is the record timestamp converted as an integer.
                       #
                       # Valid options:
                       # * :titles_only - searches tokens in the first searchable column only
                       # * :all_words - searches results that match all token
                       # * :
                       # * :limit - maximum number of results to return
                       #
                       # Example:
                       #   Issue.search_result_ranks_and_ids("foo")
                       #   # => [[1419595329, 69], [1419595622, 123]]
                       def search_result_ranks_and_ids(tokens, user=User.current, projects=nil, options={})
                         tokens = [] << tokens unless tokens.is_a?(Array)
                         projects = [] << projects if projects.is_a?(Project)
                         columns = searchable_options[:columns]
                         columns = columns[0..0] if options[:titles_only]
                         r = []
                         queries = 0
                         unless options[:attachments] == 'only'
                           r = fetch_ranks_and_ids(
                             search_scope(user, projects, options).
                             where(search_tokens_condition(columns, tokens, options[:all_words])),
                             options[:limit]
                           )
                           queries += 1
                           if !options[:titles_only] && searchable_options[:search_custom_fields]
                             searchable_custom_fields = CustomField.where(:type => "#{self.name}CustomField", :searchable => true).to_a
                             if searchable_custom_fields.any?
                               fields_by_visibility = searchable_custom_fields.group_by {|field|
                                 field.visibility_by_project_condition(searchable_options[:project_key], user, "#{CustomValue.table_name}.custom_field_id")
                               }
                               clauses = []
                               fields_by_visibility.each do |visibility, fields|
                                 clauses << "(#{CustomValue.table_name}.custom_field_id IN (#{fields.map(&:id).join(',')}) AND (#{visibility}))"
                               end
                               visibility = clauses.join(' OR ')
                               r |= fetch_ranks_and_ids(
                                 search_scope(user, projects, options).
                                 joins(:custom_values).
                                 where(visibility).
                                 where(search_tokens_condition(["#{CustomValue.table_name}.value"], tokens, options[:all_words])),
                                 options[:limit]
                               )
                               queries += 1
                             end
                           end
                           if !options[:titles_only] && searchable_options[:search_journals]
                             r |= fetch_ranks_and_ids(
                               search_scope(user, projects, options).
                               joins(:journals).
                               where("#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(user, :view_private_notes)})", false).
                               where(search_tokens_condition(["#{Journal.table_name}.notes"], tokens, options[:all_words])),
                               options[:limit]
                             )
                             queries += 1
                           end
                         end
                         if searchable_options[:search_attachments] && (options[:titles_only] ? options[:attachments] == 'only' : options[:attachments] != '0')
                           r |= fetch_ranks_and_ids(
                             search_scope(user, projects, options).
                             joins(:attachments).
                             where(search_tokens_condition(["#{Attachment.table_name}.filename", "#{Attachment.table_name}.description"], tokens, options[:all_words])),
                             options[:limit]
                           )
                           queries += 1
                         end
                         if queries > 1
                           r = r.sort.reverse
                           if options[:limit] && r.size > options[:limit]
                             r = r[0, options[:limit]]
                           end
                         end
                         r
                       end
                       def search_tokens_condition(columns, tokens, all_words)
                         token_clauses = columns.map {|column| "(#{search_token_match_statement(column)})"}
                         sql = (['(' + token_clauses.join(' OR ') + ')'] * tokens.size).join(all_words ? ' AND ' : ' OR ')
                         [sql, * (tokens.collect {|w| "%#{w}%"} * token_clauses.size).sort]
                       end
                       private :search_tokens_condition
                       def search_token_match_statement(column, value='?')
                         Redmine::Database.like(column, value)
                       end
                       private :search_token_match_statement
                       def fetch_ranks_and_ids(scope, limit)
                         scope.
                           reorder(searchable_options[:date_column] => :desc, :id => :desc).
                           limit(limit).
-                          uniq.
+                          distinct.
                           pluck(searchable_options[:date_column], :id).
                           # converts timestamps to integers for faster sort
                           map {|timestamp, id| [timestamp.to_i, id]}
                       end
                       private :fetch_ranks_and_ids
                       # Returns the search scope for user and projects
                       def search_scope(user, projects, options={})
                         if projects.is_a?(Array) && projects.empty?
                           # no results
                           return none
                         end
                         scope = (searchable_options[:scope] || self)
                         if scope.is_a? Proc
                           scope = scope.call(options)
                         end
                         if respond_to?(:visible) && !searchable_options.has_key?(:permission)
                           scope = scope.visible(user)
                         else
                           permission = searchable_options[:permission] || :view_project
                           scope = scope.where(Project.allowed_to_condition(user, permission))
                         end
                         if projects
                           scope = scope.where("#{searchable_options[:project_key]} IN (?)", projects.map(&:id))
                         end
                         scope
                       end
                       private :search_scope
                       # Returns search results of given ids
                       def search_results_from_ids(ids)
                         where(:id => ids).preload(searchable_options[:preload]).to_a
                       end
                       # Returns search results with same arguments as search_result_ranks_and_ids
                       def search_results(*args)
                         ranks_and_ids = search_result_ranks_and_ids(*args)
                         search_results_from_ids(ranks_and_ids.map(&:last))
                       end
                     end
                   end
                 end
               end
             end

lib/redmine/helpers/gantt.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module Helpers
                 # Simple class to handle gantt chart data
                 class Gantt
                   class MaxLinesLimitReached < Exception
                   end
                   include ERB::Util
                   include Redmine::I18n
                   include Redmine::Utils::DateCalculation
                   # Relation types that are rendered
                   DRAW_TYPES = {
                     IssueRelation::TYPE_BLOCKS   => { :landscape_margin => 16, :color => '#F34F4F' },
                     IssueRelation::TYPE_PRECEDES => { :landscape_margin => 20, :color => '#628FEA' }
                   }.freeze
                   # :nodoc:
                   # Some utility methods for the PDF export
                   class PDF
                     MaxCharactorsForSubject = 45
                     TotalWidth = 280
                     LeftPaneWidth = 100
                     def self.right_pane_width
                       TotalWidth - LeftPaneWidth
                     end
                   end
                   attr_reader :year_from, :month_from, :date_from, :date_to, :zoom, :months, :truncated, :max_rows
                   attr_accessor :query
                   attr_accessor :project
                   attr_accessor :view
                   def initialize(options={})
                     options = options.dup
                     if options[:year] && options[:year].to_i >0
                       @year_from = options[:year].to_i
                       if options[:month] && options[:month].to_i >=1 && options[:month].to_i <= 12
                         @month_from = options[:month].to_i
                       else
                         @month_from = 1
                       end
                     else
                       @month_from ||= User.current.today.month
                       @year_from ||= User.current.today.year
                     end
                     zoom = (options[:zoom] || User.current.pref[:gantt_zoom]).to_i
                     @zoom = (zoom > 0 && zoom < 5) ? zoom : 2
                     months = (options[:months] || User.current.pref[:gantt_months]).to_i
                     @months = (months > 0 && months < 25) ? months : 6
                     # Save gantt parameters as user preference (zoom and months count)
                     if (User.current.logged? && (@zoom != User.current.pref[:gantt_zoom] ||
                           @months != User.current.pref[:gantt_months]))
                       User.current.pref[:gantt_zoom], User.current.pref[:gantt_months] = @zoom, @months
                       User.current.preference.save
                     end
                     @date_from = Date.civil(@year_from, @month_from, 1)
                     @date_to = (@date_from >> @months) - 1
                     @subjects = ''
                     @lines = ''
                     @number_of_rows = nil
                     @truncated = false
                     if options.has_key?(:max_rows)
                       @max_rows = options[:max_rows]
                     else
                       @max_rows = Setting.gantt_items_limit.blank? ? nil : Setting.gantt_items_limit.to_i
                     end
                   end
                   def common_params
                     { :controller => 'gantts', :action => 'show', :project_id => @project }
                   end
                   def params
                     common_params.merge({:zoom => zoom, :year => year_from,
                                          :month => month_from, :months => months})
                   end
                   def params_previous
                     common_params.merge({:year => (date_from << months).year,
                                          :month => (date_from << months).month,
                                          :zoom => zoom, :months => months})
                   end
                   def params_next
                     common_params.merge({:year => (date_from >> months).year,
                                          :month => (date_from >> months).month,
                                          :zoom => zoom, :months => months})
                   end
                   # Returns the number of rows that will be rendered on the Gantt chart
                   def number_of_rows
                     return @number_of_rows if @number_of_rows
                     rows = projects.inject(0) {|total, p| total += number_of_rows_on_project(p)}
                     rows > @max_rows ? @max_rows : rows
                   end
                   # Returns the number of rows that will be used to list a project on
                   # the Gantt chart.  This will recurse for each subproject.
                   def number_of_rows_on_project(project)
                     return 0 unless projects.include?(project)
                     count = 1
                     count += project_issues(project).size
                     count += project_versions(project).size
                     count
                   end
                   # Renders the subjects of the Gantt chart, the left side.
                   def subjects(options={})
                     render(options.merge(:only => :subjects)) unless @subjects_rendered
                     @subjects
                   end
                   # Renders the lines of the Gantt chart, the right side
                   def lines(options={})
                     render(options.merge(:only => :lines)) unless @lines_rendered
                     @lines
                   end
                   # Returns issues that will be rendered
                   def issues
                     @issues ||= @query.issues(
                       :include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                       :order => "#{Project.table_name}.lft ASC, #{Issue.table_name}.id ASC",
                       :limit => @max_rows
                     )
                   end
                   # Returns a hash of the relations between the issues that are present on the gantt
                   # and that should be displayed, grouped by issue ids.
                   def relations
                     return @relations if @relations
                     if issues.any?
                       issue_ids = issues.map(&:id)
                       @relations = IssueRelation.
                         where(:issue_from_id => issue_ids, :issue_to_id => issue_ids, :relation_type => DRAW_TYPES.keys).
                         group_by(&:issue_from_id)
                     else
                       @relations = {}
                     end
                   end
                   # Return all the project nodes that will be displayed
                   def projects
                     return @projects if @projects
                     ids = issues.collect(&:project).uniq.collect(&:id)
                     if ids.any?
                       # All issues projects and their visible ancestors
                       @projects = Project.visible.
                         joins("LEFT JOIN #{Project.table_name} child ON #{Project.table_name}.lft <= child.lft AND #{Project.table_name}.rgt >= child.rgt").
                         where("child.id IN (?)", ids).
                         order("#{Project.table_name}.lft ASC").
-                        uniq.
+                        distinct.
                         to_a
                     else
                       @projects = []
                     end
                   end
                   # Returns the issues that belong to +project+
                   def project_issues(project)
                     @issues_by_project ||= issues.group_by(&:project)
                     @issues_by_project[project] || []
                   end
                   # Returns the distinct versions of the issues that belong to +project+
                   def project_versions(project)
                     project_issues(project).collect(&:fixed_version).compact.uniq
                   end
                   # Returns the issues that belong to +project+ and are assigned to +version+
                   def version_issues(project, version)
                     project_issues(project).select {|issue| issue.fixed_version == version}
                   end
                   def render(options={})
                     options = {:top => 0, :top_increment => 20,
                                :indent_increment => 20, :render => :subject,
                                :format => :html}.merge(options)
                     indent = options[:indent] || 4
                     @subjects = '' unless options[:only] == :lines
                     @lines = '' unless options[:only] == :subjects
                     @number_of_rows = 0
                     begin
                       Project.project_tree(projects) do |project, level|
                         options[:indent] = indent + level * options[:indent_increment]
                         render_project(project, options)
                       end
                     rescue MaxLinesLimitReached
                       @truncated = true
                     end
                     @subjects_rendered = true unless options[:only] == :lines
                     @lines_rendered = true unless options[:only] == :subjects
                     render_end(options)
                   end
                   def render_project(project, options={})
                     render_object_row(project, options)
                     increment_indent(options) do
                       # render issue that are not assigned to a version
                       issues = project_issues(project).select {|i| i.fixed_version.nil?}
                       render_issues(issues, options)
                       # then render project versions and their issues
                       versions = project_versions(project)
                       self.class.sort_versions!(versions)
                       versions.each do |version|
                         render_version(project, version, options)
                       end
                     end
                   end
                   def render_version(project, version, options={})
                     render_object_row(version, options)
                     increment_indent(options) do
                       issues = version_issues(project, version)
                       render_issues(issues, options)
                     end
                   end
                   def render_issues(issues, options={})
                     self.class.sort_issues!(issues)
                     ancestors = []
                     issues.each do |issue|
                       while ancestors.any? && !issue.is_descendant_of?(ancestors.last)
                         ancestors.pop
                         decrement_indent(options)
                       end
                       render_object_row(issue, options)
                       unless issue.leaf?
                         ancestors << issue
                         increment_indent(options)
                       end
                     end
                     decrement_indent(options, ancestors.size)
                   end
                   def render_object_row(object, options)
                     class_name = object.class.name.downcase
                     send("subject_for_#{class_name}", object, options) unless options[:only] == :lines
                     send("line_for_#{class_name}", object, options) unless options[:only] == :subjects
                     options[:top] += options[:top_increment]
                     @number_of_rows += 1
                     if @max_rows && @number_of_rows >= @max_rows
                       raise MaxLinesLimitReached
                     end
                   end
                   def render_end(options={})
                     case options[:format]
                     when :pdf
                       options[:pdf].Line(15, options[:top], PDF::TotalWidth, options[:top])
                     end
                   end
                   def increment_indent(options, factor=1)
                     options[:indent] += options[:indent_increment] * factor
                     if block_given?
                       yield
                       decrement_indent(options, factor)
                     end
                   end
                   def decrement_indent(options, factor=1)
                     increment_indent(options, -factor)
                   end
                   def subject_for_project(project, options)
                     subject(project.name, options, project)
                   end
                   def line_for_project(project, options)
                     # Skip projects that don't have a start_date or due date
                     if project.is_a?(Project) && project.start_date && project.due_date
                       label = project.name
                       line(project.start_date, project.due_date, nil, true, label, options, project)
                     end
                   end
                   def subject_for_version(version, options)
                     subject(version.to_s_with_project, options, version)
                   end
                   def line_for_version(version, options)
                     # Skip versions that don't have a start_date
                     if version.is_a?(Version) && version.due_date && version.start_date
                       label = "#{h(version)} #{h(version.completed_percent.to_f.round)}%"
                       label = h("#{version.project} -") + label unless @project && @project == version.project
                       line(version.start_date, version.due_date,  version.completed_percent, true, label, options, version)
                     end
                   end
                   def subject_for_issue(issue, options)
                     subject(issue.subject, options, issue)
                   end
                   def line_for_issue(issue, options)
                     # Skip issues that don't have a due_before (due_date or version's due_date)
                     if issue.is_a?(Issue) && issue.due_before
                       label = "#{issue.status.name} #{issue.done_ratio}%"
                       markers = !issue.leaf?
                       line(issue.start_date, issue.due_before, issue.done_ratio, markers, label, options, issue)
                     end
                   end
                   def subject(label, options, object=nil)
                     send "#{options[:format]}_subject", options, label, object
                   end
                   def line(start_date, end_date, done_ratio, markers, label, options, object=nil)
                     options[:zoom] ||= 1
                     options[:g_width] ||= (self.date_to - self.date_from + 1) * options[:zoom]
                     coords = coordinates(start_date, end_date, done_ratio, options[:zoom])
                     send "#{options[:format]}_task", options, coords, markers, label, object
                   end
                   # Generates a gantt image
                   # Only defined if RMagick is avalaible
                   def to_image(format='PNG')
                     date_to = (@date_from >> @months) - 1
                     show_weeks = @zoom > 1
                     show_days = @zoom > 2
                     subject_width = 400
                     header_height = 18
                     # width of one day in pixels
                     zoom = @zoom * 2
                     g_width = (@date_to - @date_from + 1) * zoom
                     g_height = 20 * number_of_rows + 30
                     headers_height = (show_weeks ? 2 * header_height : header_height)
                     height = g_height + headers_height
                     imgl = Magick::ImageList.new
                     imgl.new_image(subject_width + g_width + 1, height)
                     gc = Magick::Draw.new
                     gc.font = Redmine::Configuration['rmagick_font_path'] || ""
                     # Subjects
                     gc.stroke('transparent')
                     subjects(:image => gc, :top => (headers_height + 20), :indent => 4, :format => :image)
                     # Months headers
                     month_f = @date_from
                     left = subject_width
                     @months.times do
                       width = ((month_f >> 1) - month_f) * zoom
                       gc.fill('white')
                       gc.stroke('grey')
                       gc.stroke_width(1)
                       gc.rectangle(left, 0, left + width, height)
                       gc.fill('black')
                       gc.stroke('transparent')
                       gc.stroke_width(1)
                       gc.text(left.round + 8, 14, "#{month_f.year}-#{month_f.month}")
                       left = left + width
                       month_f = month_f >> 1
                     end
                     # Weeks headers
                     if show_weeks
                       left = subject_width
                       height = header_height
                       if @date_from.cwday == 1
                         # date_from is monday
                         week_f = date_from
                       else
                         # find next monday after date_from
                         week_f = @date_from + (7 - @date_from.cwday + 1)
                         width = (7 - @date_from.cwday + 1) * zoom
                         gc.fill('white')
                         gc.stroke('grey')
                         gc.stroke_width(1)
                         gc.rectangle(left, header_height, left + width, 2 * header_height + g_height - 1)
                         left = left + width
                       end
                       while week_f <= date_to
                         width = (week_f + 6 <= date_to) ? 7 * zoom : (date_to - week_f + 1) * zoom
                         gc.fill('white')
                         gc.stroke('grey')
                         gc.stroke_width(1)
                         gc.rectangle(left.round, header_height, left.round + width, 2 * header_height + g_height - 1)
                         gc.fill('black')
                         gc.stroke('transparent')
                         gc.stroke_width(1)
                         gc.text(left.round + 2, header_height + 14, week_f.cweek.to_s)
                         left = left + width
                         week_f = week_f + 7
                       end
                     end
                     # Days details (week-end in grey)
                     if show_days
                       left = subject_width
                       height = g_height + header_height - 1
                       wday = @date_from.cwday
                       (date_to - @date_from + 1).to_i.times do
                         width =  zoom
                         gc.fill(non_working_week_days.include?(wday) ? '#eee' : 'white')
                         gc.stroke('#ddd')
                         gc.stroke_width(1)
                         gc.rectangle(left, 2 * header_height, left + width, 2 * header_height + g_height - 1)
                         left = left + width
                         wday = wday + 1
                         wday = 1 if wday > 7
                       end
                     end
                     # border
                     gc.fill('transparent')
                     gc.stroke('grey')
                     gc.stroke_width(1)
                     gc.rectangle(0, 0, subject_width + g_width, headers_height)
                     gc.stroke('black')
                     gc.rectangle(0, 0, subject_width + g_width, g_height + headers_height - 1)
                     # content
                     top = headers_height + 20
                     gc.stroke('transparent')
                     lines(:image => gc, :top => top, :zoom => zoom,
                           :subject_width => subject_width, :format => :image)
                     # today red line
                     if User.current.today >= @date_from and User.current.today <= date_to
                       gc.stroke('red')
                       x = (User.current.today - @date_from + 1) * zoom + subject_width
                       gc.line(x, headers_height, x, headers_height + g_height - 1)
                     end
                     gc.draw(imgl)
                     imgl.format = format
                     imgl.to_blob
                   end if Object.const_defined?(:Magick)
                   def to_pdf
                     pdf = ::Redmine::Export::PDF::ITCPDF.new(current_language)
                     pdf.SetTitle("#{l(:label_gantt)} #{project}")
                     pdf.alias_nb_pages
                     pdf.footer_date = format_date(User.current.today)
                     pdf.AddPage("L")
                     pdf.SetFontStyle('B', 12)
                     pdf.SetX(15)
                     pdf.RDMCell(PDF::LeftPaneWidth, 20, project.to_s)
                     pdf.Ln
                     pdf.SetFontStyle('B', 9)
                     subject_width = PDF::LeftPaneWidth
                     header_height = 5
                     headers_height = header_height
                     show_weeks = false
                     show_days = false
                     if self.months < 7
                       show_weeks = true
                       headers_height = 2 * header_height
                       if self.months < 3
                         show_days = true
                         headers_height = 3 * header_height
                         if self.months < 2
                           show_day_num = true
                           headers_height = 4 * header_height
                         end
                       end
                     end
                     g_width = PDF.right_pane_width
                     zoom = (g_width) / (self.date_to - self.date_from + 1)
                     g_height = 120
                     t_height = g_height + headers_height
                     y_start = pdf.GetY
                     # Months headers
                     month_f = self.date_from
                     left = subject_width
                     height = header_height
                     self.months.times do
                       width = ((month_f >> 1) - month_f) * zoom
                       pdf.SetY(y_start)
                       pdf.SetX(left)
                       pdf.RDMCell(width, height, "#{month_f.year}-#{month_f.month}", "LTR", 0, "C")
                       left = left + width
                       month_f = month_f >> 1
                     end
                     # Weeks headers
                     if show_weeks
                       left = subject_width
                       height = header_height
                       if self.date_from.cwday == 1
                         # self.date_from is monday
                         week_f = self.date_from
                       else
                         # find next monday after self.date_from
                         week_f = self.date_from + (7 - self.date_from.cwday + 1)
                         width = (7 - self.date_from.cwday + 1) * zoom-1
                         pdf.SetY(y_start + header_height)
                         pdf.SetX(left)
                         pdf.RDMCell(width + 1, height, "", "LTR")
                         left = left + width + 1
                       end
                       while week_f <= self.date_to
                         width = (week_f + 6 <= self.date_to) ? 7 * zoom : (self.date_to - week_f + 1) * zoom
                         pdf.SetY(y_start + header_height)
                         pdf.SetX(left)
                         pdf.RDMCell(width, height, (width >= 5 ? week_f.cweek.to_s : ""), "LTR", 0, "C")
                         left = left + width
                         week_f = week_f + 7
                       end
                     end
                     # Day numbers headers
                     if show_day_num
                       left = subject_width
                       height = header_height
                       day_num = self.date_from
                       wday = self.date_from.cwday
                       pdf.SetFontStyle('B', 7)
                       (self.date_to - self.date_from + 1).to_i.times do
                         width = zoom
                         pdf.SetY(y_start + header_height * 2)
                         pdf.SetX(left)
                         pdf.SetTextColor(non_working_week_days.include?(wday) ? 150 : 0)
                         pdf.RDMCell(width, height, day_num.day.to_s, "LTR", 0, "C")
                         left = left + width
                         day_num = day_num + 1
                         wday = wday + 1
                         wday = 1 if wday > 7
                       end
                     end
                     # Days headers
                     if show_days
                       left = subject_width
                       height = header_height
                       wday = self.date_from.cwday
                       pdf.SetFontStyle('B', 7)
                       (self.date_to - self.date_from + 1).to_i.times do
                         width = zoom
                         pdf.SetY(y_start + header_height * (show_day_num ? 3 : 2))
                         pdf.SetX(left)
                         pdf.SetTextColor(non_working_week_days.include?(wday) ? 150 : 0)
                         pdf.RDMCell(width, height, day_name(wday).first, "LTR", 0, "C")
                         left = left + width
                         wday = wday + 1
                         wday = 1 if wday > 7
                       end
                     end
                     pdf.SetY(y_start)
                     pdf.SetX(15)
                     pdf.SetTextColor(0)
                     pdf.RDMCell(subject_width + g_width - 15, headers_height, "", 1)
                     # Tasks
                     top = headers_height + y_start
                     options = {
                       :top => top,
                       :zoom => zoom,
                       :subject_width => subject_width,
                       :g_width => g_width,
                       :indent => 0,
                       :indent_increment => 5,
                       :top_increment => 5,
                       :format => :pdf,
                       :pdf => pdf
                     }
                     render(options)
                     pdf.Output
                   end
                   private
                   def coordinates(start_date, end_date, progress, zoom=nil)
                     zoom ||= @zoom
                     coords = {}
                     if start_date && end_date && start_date < self.date_to && end_date > self.date_from
                       if start_date > self.date_from
                         coords[:start] = start_date - self.date_from
                         coords[:bar_start] = start_date - self.date_from
                       else
                         coords[:bar_start] = 0
                       end
                       if end_date < self.date_to
                         coords[:end] = end_date - self.date_from
                         coords[:bar_end] = end_date - self.date_from + 1
                       else
                         coords[:bar_end] = self.date_to - self.date_from + 1
                       end
                       if progress
                         progress_date = calc_progress_date(start_date, end_date, progress)
                         if progress_date > self.date_from && progress_date > start_date
                           if progress_date < self.date_to
                             coords[:bar_progress_end] = progress_date - self.date_from
                           else
                             coords[:bar_progress_end] = self.date_to - self.date_from + 1
                           end
                         end
                         if progress_date < User.current.today
                           late_date = [User.current.today, end_date].min
                           if late_date > self.date_from && late_date > start_date
                             if late_date < self.date_to
                               coords[:bar_late_end] = late_date - self.date_from + 1
                             else
                               coords[:bar_late_end] = self.date_to - self.date_from + 1
                             end
                           end
                         end
                       end
                     end
                     # Transforms dates into pixels witdh
                     coords.keys.each do |key|
                       coords[key] = (coords[key] * zoom).floor
                     end
                     coords
                   end
                   def calc_progress_date(start_date, end_date, progress)
                     start_date + (end_date - start_date + 1) * (progress / 100.0)
                   end
                   def self.sort_issues!(issues)
                     issues.sort! {|a, b| sort_issue_logic(a) <=> sort_issue_logic(b)}
                   end
                   def self.sort_issue_logic(issue)
                     julian_date = Date.new()
                     ancesters_start_date = []
                     current_issue = issue
                     begin
                       ancesters_start_date.unshift([current_issue.start_date || julian_date, current_issue.id])
                       current_issue = current_issue.parent
                     end while (current_issue)
                     ancesters_start_date
                   end
                   def self.sort_versions!(versions)
                     versions.sort!
                   end
                   def pdf_new_page?(options)
                     if options[:top] > 180
                       options[:pdf].Line(15, options[:top], PDF::TotalWidth, options[:top])
                       options[:pdf].AddPage("L")
                       options[:top] = 15
                       options[:pdf].Line(15, options[:top] - 0.1, PDF::TotalWidth, options[:top] - 0.1)
                     end
                   end
                   def html_subject_content(object)
                     case object
                     when Issue
                       issue = object
                       css_classes = ''
                       css_classes << ' issue-overdue' if issue.overdue?
                       css_classes << ' issue-behind-schedule' if issue.behind_schedule?
                       css_classes << ' icon icon-issue' unless Setting.gravatar_enabled? && issue.assigned_to
                       css_classes << ' issue-closed' if issue.closed?
                       if issue.start_date && issue.due_before && issue.done_ratio
                         progress_date = calc_progress_date(issue.start_date,
                                                            issue.due_before, issue.done_ratio)
                         css_classes << ' behind-start-date' if progress_date < self.date_from
                         css_classes << ' over-end-date' if progress_date > self.date_to
                       end
                       s = "".html_safe
                       if issue.assigned_to.present?
                         assigned_string = l(:field_assigned_to) + ": " + issue.assigned_to.name
                         s << view.avatar(issue.assigned_to,
                                          :class => 'gravatar icon-gravatar',
                                          :size => 10,
                                          :title => assigned_string).to_s.html_safe
                       end
                       s << view.link_to_issue(issue).html_safe
                       view.content_tag(:span, s, :class => css_classes).html_safe
                     when Version
                       version = object
                       html_class = ""
                       html_class << 'icon icon-package '
                       html_class << (version.behind_schedule? ? 'version-behind-schedule' : '') << " "
                       html_class << (version.overdue? ? 'version-overdue' : '')
                       html_class << ' version-closed' unless version.open?
                       if version.start_date && version.due_date && version.completed_percent
                         progress_date = calc_progress_date(version.start_date,
                                                            version.due_date, version.completed_percent)
                         html_class << ' behind-start-date' if progress_date < self.date_from
                         html_class << ' over-end-date' if progress_date > self.date_to
                       end
                       s = view.link_to_version(version).html_safe
                       view.content_tag(:span, s, :class => html_class).html_safe
                     when Project
                       project = object
                       html_class = ""
                       html_class << 'icon icon-projects '
                       html_class << (project.overdue? ? 'project-overdue' : '')
                       s = view.link_to_project(project).html_safe
                       view.content_tag(:span, s, :class => html_class).html_safe
                     end
                   end
                   def html_subject(params, subject, object)
                     style = "position: absolute;top:#{params[:top]}px;left:#{params[:indent]}px;"
                     style << "width:#{params[:subject_width] - params[:indent]}px;" if params[:subject_width]
                     content = html_subject_content(object) || subject
                     tag_options = {:style => style}
                     case object
                     when Issue
                       tag_options[:id] = "issue-#{object.id}"
                       tag_options[:class] = "issue-subject"
                       tag_options[:title] = object.subject
                     when Version
                       tag_options[:id] = "version-#{object.id}"
                       tag_options[:class] = "version-name"
                     when Project
                       tag_options[:class] = "project-name"
                     end
                     output = view.content_tag(:div, content, tag_options)
                     @subjects << output
                     output
                   end
                   def pdf_subject(params, subject, options={})
                     pdf_new_page?(params)
                     params[:pdf].SetY(params[:top])
                     params[:pdf].SetX(15)
                     char_limit = PDF::MaxCharactorsForSubject - params[:indent]
                     params[:pdf].RDMCell(params[:subject_width] - 15, 5,
                                          (" " * params[:indent]) +
                                            subject.to_s.sub(/^(.{#{char_limit}}[^\s]*\s).*$/, '\1 (...)'),
                                           "LR")
                     params[:pdf].SetY(params[:top])
                     params[:pdf].SetX(params[:subject_width])
                     params[:pdf].RDMCell(params[:g_width], 5, "", "LR")
                   end
                   def image_subject(params, subject, options={})
                     params[:image].fill('black')
                     params[:image].stroke('transparent')
                     params[:image].stroke_width(1)
                     params[:image].text(params[:indent], params[:top] + 2, subject)
                   end
                   def issue_relations(issue)
                     rels = {}
                     if relations[issue.id]
                       relations[issue.id].each do |relation|
                         (rels[relation.relation_type] ||= []) << relation.issue_to_id
                       end
                     end
                     rels
                   end
                   def html_task(params, coords, markers, label, object)
                     output = ''
                     css = "task " + case object
                       when Project
                         "project"
                       when Version
                         "version"
                       when Issue
                         object.leaf? ? 'leaf' : 'parent'
                       else
                         ""
                       end
                     # Renders the task bar, with progress and late
                     if coords[:bar_start] && coords[:bar_end]
                       width = coords[:bar_end] - coords[:bar_start] - 2
                       style = ""
                       style << "top:#{params[:top]}px;"
                       style << "left:#{coords[:bar_start]}px;"
                       style << "width:#{width}px;"
                       html_id = "task-todo-issue-#{object.id}" if object.is_a?(Issue)
                       html_id = "task-todo-version-#{object.id}" if object.is_a?(Version)
                       content_opt = {:style => style,
                                      :class => "#{css} task_todo",
                                      :id => html_id}
                       if object.is_a?(Issue)
                         rels = issue_relations(object)
                         if rels.present?
                           content_opt[:data] = {"rels" => rels.to_json}
                         end
                       end
                       output << view.content_tag(:div, '&nbsp;'.html_safe, content_opt)
                       if coords[:bar_late_end]
                         width = coords[:bar_late_end] - coords[:bar_start] - 2
                         style = ""
                         style << "top:#{params[:top]}px;"
                         style << "left:#{coords[:bar_start]}px;"
                         style << "width:#{width}px;"
                         output << view.content_tag(:div, '&nbsp;'.html_safe,
                                                    :style => style,
                                                    :class => "#{css} task_late")
                       end
                       if coords[:bar_progress_end]
                         width = coords[:bar_progress_end] - coords[:bar_start] - 2
                         style = ""
                         style << "top:#{params[:top]}px;"
                         style << "left:#{coords[:bar_start]}px;"
                         style << "width:#{width}px;"
                         html_id = "task-done-issue-#{object.id}" if object.is_a?(Issue)
                         html_id = "task-done-version-#{object.id}" if object.is_a?(Version)
                         output << view.content_tag(:div, '&nbsp;'.html_safe,
                                                    :style => style,
                                                    :class => "#{css} task_done",
                                                    :id => html_id)
                       end
                     end
                     # Renders the markers
                     if markers
                       if coords[:start]
                         style = ""
                         style << "top:#{params[:top]}px;"
                         style << "left:#{coords[:start]}px;"
                         style << "width:15px;"
                         output << view.content_tag(:div, '&nbsp;'.html_safe,
                                                    :style => style,
                                                    :class => "#{css} marker starting")
                       end
                       if coords[:end]
                         style = ""
                         style << "top:#{params[:top]}px;"
                         style << "left:#{coords[:end] + params[:zoom]}px;"
                         style << "width:15px;"
                         output << view.content_tag(:div, '&nbsp;'.html_safe,
                                                    :style => style,
                                                    :class => "#{css} marker ending")
                       end
                     end
                     # Renders the label on the right
                     if label
                       style = ""
                       style << "top:#{params[:top]}px;"
                       style << "left:#{(coords[:bar_end] || 0) + 8}px;"
                       style << "width:15px;"
                       output << view.content_tag(:div, label,
                                                  :style => style,
                                                  :class => "#{css} label")
                     end
                     # Renders the tooltip
                     if object.is_a?(Issue) && coords[:bar_start] && coords[:bar_end]
                       s = view.content_tag(:span,
                                            view.render_issue_tooltip(object).html_safe,
                                            :class => "tip")
                       style = ""
                       style << "position: absolute;"
                       style << "top:#{params[:top]}px;"
                       style << "left:#{coords[:bar_start]}px;"
                       style << "width:#{coords[:bar_end] - coords[:bar_start]}px;"
                       style << "height:12px;"
                       output << view.content_tag(:div, s.html_safe,
                                                  :style => style,
                                                  :class => "tooltip")
                     end
                     @lines << output
                     output
                   end
                   def pdf_task(params, coords, markers, label, object)
                     cell_height_ratio = params[:pdf].get_cell_height_ratio()
                     params[:pdf].set_cell_height_ratio(0.1)
                     height = 2
                     height /= 2 if markers
                     # Renders the task bar, with progress and late
                     if coords[:bar_start] && coords[:bar_end]
                       params[:pdf].SetY(params[:top] + 1.5)
                       params[:pdf].SetX(params[:subject_width] + coords[:bar_start])
                       params[:pdf].SetFillColor(200, 200, 200)
                       params[:pdf].RDMCell(coords[:bar_end] - coords[:bar_start], height, "", 0, 0, "", 1)
                       if coords[:bar_late_end]
                         params[:pdf].SetY(params[:top] + 1.5)
                         params[:pdf].SetX(params[:subject_width] + coords[:bar_start])
                         params[:pdf].SetFillColor(255, 100, 100)
                         params[:pdf].RDMCell(coords[:bar_late_end] - coords[:bar_start], height, "", 0, 0, "", 1)
                       end
                       if coords[:bar_progress_end]
                         params[:pdf].SetY(params[:top] + 1.5)
                         params[:pdf].SetX(params[:subject_width] + coords[:bar_start])
                         params[:pdf].SetFillColor(90, 200, 90)
                         params[:pdf].RDMCell(coords[:bar_progress_end] - coords[:bar_start], height, "", 0, 0, "", 1)
                       end
                     end
                     # Renders the markers
                     if markers
                       if coords[:start]
                         params[:pdf].SetY(params[:top] + 1)
                         params[:pdf].SetX(params[:subject_width] + coords[:start] - 1)
                         params[:pdf].SetFillColor(50, 50, 200)
                         params[:pdf].RDMCell(2, 2, "", 0, 0, "", 1)
                       end
                       if coords[:end]
                         params[:pdf].SetY(params[:top] + 1)
                         params[:pdf].SetX(params[:subject_width] + coords[:end] - 1)
                         params[:pdf].SetFillColor(50, 50, 200)
                         params[:pdf].RDMCell(2, 2, "", 0, 0, "", 1)
                       end
                     end
                     # Renders the label on the right
                     if label
                       params[:pdf].SetX(params[:subject_width] + (coords[:bar_end] || 0) + 5)
                       params[:pdf].RDMCell(30, 2, label)
                     end
                     params[:pdf].set_cell_height_ratio(cell_height_ratio)
                   end
                   def image_task(params, coords, markers, label, object)
                     height = 6
                     height /= 2 if markers
                     # Renders the task bar, with progress and late
                     if coords[:bar_start] && coords[:bar_end]
                       params[:image].fill('#aaa')
                       params[:image].rectangle(params[:subject_width] + coords[:bar_start],
                                                params[:top],
                                                params[:subject_width] + coords[:bar_end],
                                                params[:top] - height)
                       if coords[:bar_late_end]
                         params[:image].fill('#f66')
                         params[:image].rectangle(params[:subject_width] + coords[:bar_start],
                                                  params[:top],
                                                  params[:subject_width] + coords[:bar_late_end],
                                                  params[:top] - height)
                       end
                       if coords[:bar_progress_end]
                         params[:image].fill('#00c600')
                         params[:image].rectangle(params[:subject_width] + coords[:bar_start],
                                                  params[:top],
                                                  params[:subject_width] + coords[:bar_progress_end],
                                                  params[:top] - height)
                       end
                     end
                     # Renders the markers
                     if markers
                       if coords[:start]
                         x = params[:subject_width] + coords[:start]
                         y = params[:top] - height / 2
                         params[:image].fill('blue')
                         params[:image].polygon(x - 4, y, x, y - 4, x + 4, y, x, y + 4)
                       end
                       if coords[:end]
                         x = params[:subject_width] + coords[:end] + params[:zoom]
                         y = params[:top] - height / 2
                         params[:image].fill('blue')
                         params[:image].polygon(x - 4, y, x, y - 4, x + 4, y, x, y + 4)
                       end
                     end
                     # Renders the label on the right
                     if label
                       params[:image].fill('black')
                       params[:image].text(params[:subject_width] + (coords[:bar_end] || 0) + 5,
                                           params[:top] + 1,
                                           label)
                     end
                   end
                 end
               end
             end

lib/redmine/nested_set/issue_nested_set.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module Redmine
               module NestedSet
                 module IssueNestedSet
                   def self.included(base)
                     base.class_eval do
                       belongs_to :parent, :class_name => self.name
                       before_create :add_to_nested_set, :if => lambda {|issue| issue.parent.present?}
                       after_create :add_as_root, :if => lambda {|issue| issue.parent.blank?}
                       before_update :handle_parent_change, :if => lambda {|issue| issue.parent_id_changed?}
                       before_destroy :destroy_children
                     end
                     base.extend ClassMethods
                     base.send :include, Redmine::NestedSet::Traversing
                   end
                   private
                   def target_lft
                     scope_for_max_rgt = self.class.where(:root_id => root_id).where(:parent_id => parent_id)
                     if id
                       scope_for_max_rgt = scope_for_max_rgt.where("id < ?", id)
                     end
                     max_rgt = scope_for_max_rgt.maximum(:rgt)
                     if max_rgt
                       max_rgt + 1
                     elsif parent
                       parent.lft + 1
                     else
                     end
                   end
                   def add_to_nested_set(lock=true)
                     lock_nested_set if lock
                     parent.send :reload_nested_set_values
                     self.root_id = parent.root_id
                     self.lft = target_lft
                     self.rgt = lft + 1
                     self.class.where(:root_id => root_id).where("lft >= ? OR rgt >= ?", lft, lft).update_all([
                       "lft = CASE WHEN lft >= :lft THEN lft + 2 ELSE lft END, " +
                       "rgt = CASE WHEN rgt >= :lft THEN rgt + 2 ELSE rgt END",
                       {:lft => lft}
                     ])
                   end
                   def add_as_root
                     self.root_id = id
                     self.lft = 1
                     self.rgt = 2
                     self.class.where(:id => id).update_all(:root_id => root_id, :lft => lft, :rgt => rgt)
                   end
                   def handle_parent_change
                     lock_nested_set
                     reload_nested_set_values
                     if parent_id_was
                       remove_from_nested_set
                     end
                     if parent
                       move_to_nested_set
                     end
                     reload_nested_set_values
                   end
                   def move_to_nested_set
                     if parent
                       previous_root_id = root_id
                       self.root_id = parent.root_id
                       lft_after_move = target_lft
                       self.class.where(:root_id => parent.root_id).update_all([
                         "lft = CASE WHEN lft >= :lft THEN lft + :shift ELSE lft END, " +
                         "rgt = CASE WHEN rgt >= :lft THEN rgt + :shift ELSE rgt END",
                         {:lft => lft_after_move, :shift => (rgt - lft + 1)}
                       ])
                       self.class.where(:root_id => previous_root_id).update_all([
                         "root_id = :root_id, lft = lft + :shift, rgt = rgt + :shift",
                         {:root_id => parent.root_id, :shift => lft_after_move - lft}
                       ])
                       self.lft, self.rgt = lft_after_move, (rgt - lft + lft_after_move)
                       parent.send :reload_nested_set_values
                     end
                   end
                   def remove_from_nested_set
                     self.class.where(:root_id => root_id).where("lft >= ? AND rgt <= ?", lft, rgt).
                       update_all(["root_id = :id, lft = lft - :shift, rgt = rgt - :shift", {:id => id, :shift => lft - 1}])
                     self.class.where(:root_id => root_id).update_all([
                       "lft = CASE WHEN lft >= :lft THEN lft - :shift ELSE lft END, " +
                       "rgt = CASE WHEN rgt >= :lft THEN rgt - :shift ELSE rgt END",
                       {:lft => lft, :shift => rgt - lft + 1}
                     ])
                     self.root_id = id
                     self.lft, self.rgt = 1, (rgt - lft + 1)
                   end
                   def destroy_children
                     unless @without_nested_set_update
                       lock_nested_set
                       reload_nested_set_values
                     end
                     children.each {|c| c.send :destroy_without_nested_set_update}
                     reload
                     unless @without_nested_set_update
                       self.class.where(:root_id => root_id).where("lft > ? OR rgt > ?", lft, lft).update_all([
                         "lft = CASE WHEN lft > :lft THEN lft - :shift ELSE lft END, " +
                         "rgt = CASE WHEN rgt > :lft THEN rgt - :shift ELSE rgt END",
                         {:lft => lft, :shift => rgt - lft + 1}
                       ])
                     end
                   end
                   def destroy_without_nested_set_update
                     @without_nested_set_update = true
                     destroy
                   end
                   def reload_nested_set_values
                     self.root_id, self.lft, self.rgt = self.class.where(:id => id).pluck(:root_id, :lft, :rgt).first
                   end
                   def save_nested_set_values
                     self.class.where(:id => id).update_all(:root_id => root_id, :lft => lft, :rgt => rgt)
                   end
                   def move_possible?(issue)
                     new_record? || !is_or_is_ancestor_of?(issue)
                   end
                   def lock_nested_set
                     if self.class.connection.adapter_name =~ /sqlserver/i
                       lock = "WITH (ROWLOCK HOLDLOCK UPDLOCK)"
                       # Custom lock for SQLServer
                       # This can be problematic if root_id or parent root_id changes
                       # before locking
                       sets_to_lock = [root_id, parent.try(:root_id)].compact.uniq
                       self.class.reorder(:id).where(:root_id => sets_to_lock).lock(lock).ids
                     else
                       sets_to_lock = [id, parent_id].compact
                       self.class.reorder(:id).where("root_id IN (SELECT root_id FROM #{self.class.table_name} WHERE id IN (?))", sets_to_lock).lock.ids
                     end
                   end
                   def nested_set_scope
                     self.class.order(:lft).where(:root_id => root_id)
                   end
                   def same_nested_set_scope?(issue)
                     root_id == issue.root_id
                   end
                   module ClassMethods
                     def rebuild_tree!
                       transaction do
                         reorder(:id).lock.ids
                         update_all(:root_id => nil, :lft => nil, :rgt => nil)
                         where(:parent_id => nil).update_all(["root_id = id, lft = ?, rgt = ?", 1, 2])
-                        roots_with_children = joins("JOIN #{table_name} parent ON parent.id = #{table_name}.parent_id AND parent.id = parent.root_id").uniq.pluck("parent.id")
+                        roots_with_children = joins("JOIN #{table_name} parent ON parent.id = #{table_name}.parent_id AND parent.id = parent.root_id").distinct.pluck("parent.id")
                         roots_with_children.each do |root_id|
                           rebuild_nodes(root_id)
                         end
                       end
                     end
                     private
                     def rebuild_nodes(parent_id = nil)
                       nodes = where(:parent_id => parent_id, :rgt => nil, :lft => nil).order(:id).to_a
                       nodes.each do |node|
                         node.send :add_to_nested_set, false
                         node.send :save_nested_set_values
                         rebuild_nodes node.id
                       end
                     end
                   end
                 end
               end
             end

test/integration/issues_test.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class IssuesTest < Redmine::IntegrationTest
               fixtures :projects,
                        :users, :email_addresses,
                        :roles,
                        :members,
                        :member_roles,
                        :trackers,
                        :projects_trackers,
                        :enabled_modules,
                        :issue_statuses,
                        :issues,
                        :enumerations,
                        :custom_fields,
                        :custom_values,
                        :custom_fields_trackers,
                        :attachments
               # create an issue
               def test_add_issue
                 log_user('jsmith', 'jsmith')
                 get '/projects/ecookbook/issues/new'
                 assert_response :success
                 assert_template 'issues/new'
                 issue = new_record(Issue) do
                   post '/projects/ecookbook/issues',
                                              :issue => { :tracker_id => "1",
                                                          :start_date => "2006-12-26",
                                                          :priority_id => "4",
                                                          :subject => "new test issue",
                                                          :category_id => "",
                                                          :description => "new issue",
                                                          :done_ratio => "0",
                                                          :due_date => "",
                                                          :assigned_to_id => "" },
                                              :custom_fields => {'2' => 'Value for field 2'}
                 end
                 # check redirection
                 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
                 follow_redirect!
                 assert_equal issue, assigns(:issue)
                 # check issue attributes
                 assert_equal 'jsmith', issue.author.login
                 assert_equal 1, issue.project.id
                 assert_equal 1, issue.status.id
               end
               def test_create_issue_by_anonymous_without_permission_should_fail
                 Role.anonymous.remove_permission! :add_issues
                 assert_no_difference 'Issue.count' do
                   post '/projects/1/issues', :tracker_id => "1", :issue => {:subject => "new test issue"}
                 end
                 assert_response 302
               end
               def test_create_issue_by_anonymous_with_custom_permission_should_succeed
                 Role.anonymous.remove_permission! :add_issues
                 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [3])
                 issue = new_record(Issue) do
                   post '/projects/1/issues', :tracker_id => "1", :issue => {:subject => "new test issue"}
                   assert_response 302
                 end
                 assert_equal User.anonymous, issue.author
               end
               # add then remove 2 attachments to an issue
               def test_issue_attachments
                 log_user('jsmith', 'jsmith')
                 set_tmp_attachments_directory
                 attachment = new_record(Attachment) do
                   put '/issues/1',
                        :notes => 'Some notes',
                        :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'This is an attachment'}}
                   assert_redirected_to "/issues/1"
                 end
                 assert_equal Issue.find(1), attachment.container
                 assert_equal 'testfile.txt', attachment.filename
                 assert_equal 'This is an attachment', attachment.description
                 # verify the size of the attachment stored in db
                 #assert_equal file_data_1.length, attachment.filesize
                 # verify that the attachment was written to disk
                 assert File.exist?(attachment.diskfile)
                 # remove the attachments
                 Issue.find(1).attachments.each(&:destroy)
                 assert_equal 0, Issue.find(1).attachments.length
               end
               def test_other_formats_links_on_index
                 get '/projects/ecookbook/issues'
                 %w(Atom PDF CSV).each do |format|
                   assert_select 'a[rel=nofollow][href=?]', "/projects/ecookbook/issues.#{format.downcase}", :text => format
                 end
               end
               def test_other_formats_links_on_index_without_project_id_in_url
                 get '/issues', :project_id => 'ecookbook'
                 %w(Atom PDF CSV).each do |format|
                   assert_select 'a[rel=nofollow][href=?]', "/issues.#{format.downcase}?project_id=ecookbook", :text => format
                 end
               end
               def test_pagination_links_on_index
                 with_settings :per_page_options => '2' do
                   get '/projects/ecookbook/issues'
                   assert_select 'a[href=?]', '/projects/ecookbook/issues?page=2', :text => '2'
                 end
               end
               def test_pagination_links_should_preserve_query_parameters
                 with_settings :per_page_options => '2' do
                   get '/projects/ecookbook/issues?foo=bar'
                   assert_select 'a[href=?]', '/projects/ecookbook/issues?foo=bar&page=2', :text => '2'
                 end
               end
               def test_pagination_links_should_not_use_params_as_url_options
                 with_settings :per_page_options => '2' do
                   get '/projects/ecookbook/issues?host=foo'
                   assert_select 'a[href=?]', '/projects/ecookbook/issues?host=foo&page=2', :text => '2'
                 end
               end
               def test_sort_links_on_index
                 get '/projects/ecookbook/issues'
                 assert_select 'a[href=?]', '/projects/ecookbook/issues?sort=subject%2Cid%3Adesc', :text => 'Subject'
               end
               def test_sort_links_should_preserve_query_parameters
                 get '/projects/ecookbook/issues?foo=bar'
                 assert_select 'a[href=?]', '/projects/ecookbook/issues?foo=bar&sort=subject%2Cid%3Adesc', :text => 'Subject'
               end
               def test_sort_links_should_not_use_params_as_url_options
                 get '/projects/ecookbook/issues?host=foo'
                 assert_select 'a[href=?]', '/projects/ecookbook/issues?host=foo&sort=subject%2Cid%3Adesc', :text => 'Subject'
               end
               def test_issue_with_user_custom_field
                 @field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true, :trackers => Tracker.all)
                 Role.anonymous.add_permission! :add_issues, :edit_issues
-                users = Project.find(1).users.uniq.sort
+                users = Project.find(1).users.sort
                 tester = users.first
                 # Issue form
                 get '/projects/ecookbook/issues/new'
                 assert_response :success
                 assert_select 'select[name=?]', "issue[custom_field_values][#{@field.id}]" do
                   assert_select 'option', users.size + 1 # +1 for blank value
                   assert_select 'option[value=?]', tester.id.to_s, :text => tester.name
                 end
                 # Create issue
                 issue = new_record(Issue) do
                   post '/projects/ecookbook/issues',
                     :issue => {
                       :tracker_id => '1',
                       :priority_id => '4',
                       :subject => 'Issue with user custom field',
                       :custom_field_values => {@field.id.to_s => users.first.id.to_s}
                     }
                   assert_response 302
                 end
                 # Issue view
                 follow_redirect!
                 assert_select ".cf_#{@field.id}" do
                   assert_select '.label', :text => 'Tester:'
                   assert_select '.value', :text => tester.name
                 end
                 assert_select 'select[name=?]', "issue[custom_field_values][#{@field.id}]" do
                   assert_select 'option', users.size + 1 # +1 for blank value
                   assert_select 'option[value=?][selected=selected]', tester.id.to_s, :text => tester.name
                 end
                 new_tester = users[1]
                 with_settings :default_language => 'en' do
                   # Update issue
                   assert_difference 'Journal.count' do
                     put "/issues/#{issue.id}",
                         :notes => 'Updating custom field',
                         :issue => {
                             :custom_field_values => {@field.id.to_s => new_tester.id.to_s}
                           }
                     assert_redirected_to "/issues/#{issue.id}"
                   end
                   # Issue view
                   follow_redirect!
                   assert_select 'ul.details li', :text => "Tester changed from #{tester} to #{new_tester}"
                 end
               end
               def test_update_using_invalid_http_verbs
                 subject = 'Updated by an invalid http verb'
                 get '/issues/update/1', {:issue => {:subject => subject}}, credentials('jsmith')
                 assert_response 404
                 assert_not_equal subject, Issue.find(1).subject
                 post '/issues/1', {:issue => {:subject => subject}}, credentials('jsmith')
                 assert_response 404
                 assert_not_equal subject, Issue.find(1).subject
               end
               def test_get_watch_should_be_invalid
                 assert_no_difference 'Watcher.count' do
                   get '/watchers/watch?object_type=issue&object_id=1', {}, credentials('jsmith')
                   assert_response 404
                 end
               end
             end

test/unit/project_members_inheritance_test.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class ProjectMembersInheritanceTest < ActiveSupport::TestCase
               fixtures :roles, :users,
                        :projects, :trackers, :issue_statuses
               def setup
                 @parent = Project.generate!
                 @member = Member.create!(:principal => User.find(2), :project => @parent, :role_ids => [1, 2])
                 assert_equal 2, @member.reload.roles.size
               end
               def test_project_created_with_inherit_members_disabled_should_not_inherit_members
                 assert_no_difference 'Member.count' do
                   project = Project.generate_with_parent!(@parent, :inherit_members => false)
                   assert_equal 0, project.memberships.count
                 end
               end
               def test_project_created_with_inherit_members_should_inherit_members
                 assert_difference 'Member.count', 1 do
                   project = Project.generate_with_parent!(@parent, :inherit_members => true)
                   project.reload
                   assert_equal 1, project.memberships.count
                   member = project.memberships.first
                   assert_equal @member.principal, member.principal
                   assert_equal @member.roles.sort, member.roles.sort
                 end
               end
               def test_turning_on_inherit_members_should_inherit_members
                 Project.generate_with_parent!(@parent, :inherit_members => false)
                 assert_difference 'Member.count', 1 do
                   project = Project.order('id desc').first
                   project.inherit_members = true
                   project.save!
                   project.reload
                   assert_equal 1, project.memberships.count
                   member = project.memberships.first
                   assert_equal @member.principal, member.principal
                   assert_equal @member.roles.sort, member.roles.sort
                 end
               end
               def test_turning_off_inherit_members_should_remove_inherited_members
                 Project.generate_with_parent!(@parent, :inherit_members => true)
                 assert_difference 'Member.count', -1 do
                   project = Project.order('id desc').first
                   project.inherit_members = false
                   project.save!
                   project.reload
                   assert_equal 0, project.memberships.count
                 end
               end
               def test_moving_a_root_project_under_a_parent_should_inherit_members
                 Project.generate!(:inherit_members => true)
                 project = Project.order('id desc').first
                 assert_difference 'Member.count', 1 do
                   project.set_parent!(@parent)
                   project.reload
                   assert_equal 1, project.memberships.count
                   member = project.memberships.first
                   assert_equal @member.principal, member.principal
                   assert_equal @member.roles.sort, member.roles.sort
                 end
               end
               def test_moving_a_subproject_as_root_should_loose_inherited_members
                 Project.generate_with_parent!(@parent, :inherit_members => true)
                 project = Project.order('id desc').first
                 assert_difference 'Member.count', -1 do
                   project.set_parent!(nil)
                   project.reload
                   assert_equal 0, project.memberships.count
                 end
               end
               def test_moving_a_subproject_to_another_parent_should_change_inherited_members
                 other_parent = Project.generate!
                 other_member = Member.create!(:principal => User.find(4), :project => other_parent, :role_ids => [3])
                 other_member.reload
                 Project.generate_with_parent!(@parent, :inherit_members => true)
                 project = Project.order('id desc').first
                 project.set_parent!(other_parent.reload)
                 project.reload
                 assert_equal 1, project.memberships.count
                 member = project.memberships.first
                 assert_equal other_member.principal, member.principal
                 assert_equal other_member.roles.sort, member.roles.sort
               end
               def test_inheritance_should_propagate_to_subprojects
                 project = Project.generate_with_parent!(@parent, :inherit_members => false)
                 subproject = Project.generate_with_parent!(project, :inherit_members => true)
                 project.reload
                 assert_difference 'Member.count', 2 do
                   project.inherit_members = true
                   project.save
                   project.reload
                   subproject.reload
                   assert_equal 1, project.memberships.count
                   assert_equal 1, subproject.memberships.count
                   member = subproject.memberships.first
                   assert_equal @member.principal, member.principal
                   assert_equal @member.roles.sort, member.roles.sort
                 end
               end
               def test_inheritance_removal_should_propagate_to_subprojects
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 subproject = Project.generate_with_parent!(project, :inherit_members => true)
                 project.reload
                 assert_difference 'Member.count', -2 do
                   project.inherit_members = false
                   project.save
                   project.reload
                   subproject.reload
                   assert_equal 0, project.memberships.count
                   assert_equal 0, subproject.memberships.count
                 end
               end
               def test_adding_a_member_should_propagate
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 assert_difference 'Member.count', 2 do
                   member = Member.create!(:principal => User.find(4), :project => @parent, :role_ids => [1, 3])
                   member.reload
                   inherited_member = project.memberships.order('id desc').first
                   assert_equal member.principal, inherited_member.principal
                   assert_equal member.roles.sort, inherited_member.roles.sort
                 end
               end
               def test_adding_a_member_should_not_propagate_if_child_does_not_inherit
                 project = Project.generate_with_parent!(@parent, :inherit_members => false)
                 assert_difference 'Member.count', 1 do
                   member = Member.create!(:principal => User.find(4), :project => @parent, :role_ids => [1, 3])
                   assert_nil project.reload.memberships.detect {|m| m.principal == member.principal}
                 end
               end
               def test_removing_a_member_should_propagate
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 assert_difference 'Member.count', -2 do
                   @member.reload.destroy
                   project.reload
                   assert_equal 0, project.memberships.count
                 end
               end
               def test_adding_a_group_member_should_propagate_with_its_users
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 group = Group.generate!
                 user = User.find(4)
                 group.users << user
                 assert_difference 'Member.count', 4 do
                   assert_difference 'MemberRole.count', 8 do
                     member = Member.create!(:principal => group, :project => @parent, :role_ids => [1, 3])
                     project.reload
                     member.reload
                     inherited_group_member = project.memberships.detect {|m| m.principal == group}
                     assert_not_nil inherited_group_member
                     assert_equal member.roles.sort, inherited_group_member.roles.sort
                     inherited_user_member = project.memberships.detect {|m| m.principal == user}
                     assert_not_nil inherited_user_member
                     assert_equal member.roles.sort, inherited_user_member.roles.sort
                   end
                 end
               end
               def test_removing_a_group_member_should_propagate
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 group = Group.generate!
                 user = User.find(4)
                 group.users << user
                 member = Member.create!(:principal => group, :project => @parent, :role_ids => [1, 3])
                 assert_difference 'Member.count', -4 do
                   assert_difference 'MemberRole.count', -8 do
                     member.destroy
                     project.reload
                     inherited_group_member = project.memberships.detect {|m| m.principal == group}
                     assert_nil inherited_group_member
                     inherited_user_member = project.memberships.detect {|m| m.principal == user}
                     assert_nil inherited_user_member
                   end
                 end
               end
               def test_adding_user_who_use_is_already_a_member_to_parent_project_should_merge_roles
                 project = Project.generate_with_parent!(@parent, :inherit_members => true)
                 user = User.find(4)
                 Member.create!(:principal => user, :project => project, :role_ids => [1, 2])
                 assert_difference 'Member.count', 1 do
                   Member.create!(:principal => User.find(4), :project => @parent.reload, :role_ids => [1, 3])
                   member = project.reload.memberships.detect {|m| m.principal == user}
                   assert_not_nil member
-                  assert_equal [1, 2, 3], member.roles.uniq.sort.map(&:id)
+                  assert_equal [1, 2, 3], member.roles.map(&:id).uniq.sort
                 end
               end
               def test_turning_on_inheritance_with_user_who_is_already_a_member_should_merge_roles
                 project = Project.generate_with_parent!(@parent)
                 user = @member.user
                 Member.create!(:principal => user, :project => project, :role_ids => [1, 3])
                 project.reload
                 assert_no_difference 'Member.count' do
                   project.inherit_members = true
                   project.save!
                   member = project.reload.memberships.detect {|m| m.principal == user}
                   assert_not_nil member
-                  assert_equal [1, 2, 3], member.roles.uniq.sort.map(&:id)
+                  assert_equal [1, 2, 3], member.roles.map(&:id).uniq.sort
                 end
               end
             end

test/unit/project_test.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class ProjectTest < ActiveSupport::TestCase
               fixtures :projects, :trackers, :issue_statuses, :issues,
                        :journals, :journal_details,
                        :enumerations, :users, :issue_categories,
                        :projects_trackers,
                        :custom_fields,
                        :custom_fields_projects,
                        :custom_fields_trackers,
                        :custom_values,
                        :roles,
                        :member_roles,
                        :members,
                        :enabled_modules,
                        :versions,
                        :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions,
                        :groups_users,
                        :boards, :messages,
                        :repositories,
                        :news, :comments,
                        :documents,
                        :workflows
               def setup
                 @ecookbook = Project.find(1)
                 @ecookbook_sub1 = Project.find(3)
                 set_tmp_attachments_directory
                 User.current = nil
               end
               def test_truth
                 assert_kind_of Project, @ecookbook
                 assert_equal "eCookbook", @ecookbook.name
               end
               def test_default_attributes
                 with_settings :default_projects_public => '1' do
                   assert_equal true, Project.new.is_public
                   assert_equal false, Project.new(:is_public => false).is_public
                 end
                 with_settings :default_projects_public => '0' do
                   assert_equal false, Project.new.is_public
                   assert_equal true, Project.new(:is_public => true).is_public
                 end
                 with_settings :sequential_project_identifiers => '1' do
                   assert !Project.new.identifier.blank?
                   assert Project.new(:identifier => '').identifier.blank?
                 end
                 with_settings :sequential_project_identifiers => '0' do
                   assert Project.new.identifier.blank?
                   assert !Project.new(:identifier => 'test').blank?
                 end
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   assert_equal ['issue_tracking', 'repository'], Project.new.enabled_module_names
                 end
               end
               def test_default_trackers_should_match_default_tracker_ids_setting
                 with_settings :default_projects_tracker_ids => ['1', '3'] do
                   assert_equal Tracker.find(1, 3).sort, Project.new.trackers.sort
                 end
               end
               def test_default_trackers_should_be_all_trackers_with_blank_setting
                 with_settings :default_projects_tracker_ids => nil do
                   assert_equal Tracker.all.sort, Project.new.trackers.sort
                 end
               end
               def test_default_trackers_should_be_empty_with_empty_setting
                 with_settings :default_projects_tracker_ids => [] do
                   assert_equal [], Project.new.trackers
                 end
               end
               def test_default_trackers_should_not_replace_initialized_trackers
                 with_settings :default_projects_tracker_ids => ['1', '3'] do
                   assert_equal Tracker.find(1, 2).sort, Project.new(:tracker_ids => [1, 2]).trackers.sort
                 end
               end
               def test_update
                 assert_equal "eCookbook", @ecookbook.name
                 @ecookbook.name = "eCook"
                 assert @ecookbook.save, @ecookbook.errors.full_messages.join("; ")
                 @ecookbook.reload
                 assert_equal "eCook", @ecookbook.name
               end
               def test_validate_identifier
                 to_test = {"abc" => true,
                            "ab12" => true,
                            "ab-12" => true,
                            "ab_12" => true,
                            "12" => false,
                            "new" => false}
                 to_test.each do |identifier, valid|
                   p = Project.new
                   p.identifier = identifier
                   p.valid?
                   if valid
                     assert p.errors['identifier'].blank?, "identifier #{identifier} was not valid"
                   else
                     assert p.errors['identifier'].present?, "identifier #{identifier} was valid"
                   end
                 end
               end
               def test_identifier_should_not_be_frozen_for_a_new_project
                 assert_equal false, Project.new.identifier_frozen?
               end
               def test_identifier_should_not_be_frozen_for_a_saved_project_with_blank_identifier
                 Project.where(:id => 1).update_all(["identifier = ''"])
                 assert_equal false, Project.find(1).identifier_frozen?
               end
               def test_identifier_should_be_frozen_for_a_saved_project_with_valid_identifier
                 assert_equal true, Project.find(1).identifier_frozen?
               end
               def test_to_param_should_be_nil_for_new_records
                 project = Project.new
                 project.identifier = "foo"
                 assert_nil project.to_param
               end
               def test_members_should_be_active_users
                 Project.all.each do |project|
                   assert_nil project.members.detect {|m| !(m.user.is_a?(User) && m.user.active?) }
                 end
               end
               def test_users_should_be_active_users
                 Project.all.each do |project|
                   assert_nil project.users.detect {|u| !(u.is_a?(User) && u.active?) }
                 end
               end
               def test_open_scope_on_issues_association
                 assert_kind_of Issue, Project.find(1).issues.open.first
               end
               def test_archive
                 user = @ecookbook.members.first.user
                 @ecookbook.archive
                 @ecookbook.reload
                 assert !@ecookbook.active?
                 assert @ecookbook.archived?
                 assert !user.projects.include?(@ecookbook)
                 # Subproject are also archived
                 assert !@ecookbook.children.empty?
                 assert @ecookbook.descendants.active.empty?
               end
               def test_archive_should_fail_if_versions_are_used_by_non_descendant_projects
                 # Assign an issue of a project to a version of a child project
                 Issue.find(4).update_attribute :fixed_version_id, 4
                 assert_no_difference "Project.where(:status => Project::STATUS_ARCHIVED).count" do
                   assert_equal false, @ecookbook.archive
                 end
                 @ecookbook.reload
                 assert @ecookbook.active?
               end
               def test_unarchive
                 user = @ecookbook.members.first.user
                 @ecookbook.archive
                 # A subproject of an archived project can not be unarchived
                 assert !@ecookbook_sub1.unarchive
                 # Unarchive project
                 assert @ecookbook.unarchive
                 @ecookbook.reload
                 assert @ecookbook.active?
                 assert !@ecookbook.archived?
                 assert user.projects.include?(@ecookbook)
                 # Subproject can now be unarchived
                 @ecookbook_sub1.reload
                 assert @ecookbook_sub1.unarchive
               end
               def test_destroy
                 # 2 active members
                 assert_equal 2, @ecookbook.members.size
                 # and 1 is locked
                 assert_equal 3, Member.where(:project_id => @ecookbook.id).count
                 # some boards
                 assert @ecookbook.boards.any?
                 @ecookbook.destroy
                 # make sure that the project non longer exists
                 assert_raise(ActiveRecord::RecordNotFound) { Project.find(@ecookbook.id) }
                 # make sure related data was removed
                 assert_nil Member.where(:project_id => @ecookbook.id).first
                 assert_nil Board.where(:project_id => @ecookbook.id).first
                 assert_nil Issue.where(:project_id => @ecookbook.id).first
               end
               def test_destroy_should_destroy_subtasks
                 issues = (0..2).to_a.map {Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test')}
                 issues[0].update_attribute :parent_issue_id, issues[1].id
                 issues[2].update_attribute :parent_issue_id, issues[1].id
                 assert_equal 2, issues[1].children.count
                 assert_nothing_raised do
                   Project.find(1).destroy
                 end
                 assert_equal 0, Issue.where(:id => issues.map(&:id)).count
               end
               def test_destroying_root_projects_should_clear_data
                 Project.roots.each do |root|
                   root.destroy
                 end
                 assert_equal 0, Project.count, "Projects were not deleted: #{Project.all.inspect}"
                 assert_equal 0, Member.count, "Members were not deleted: #{Member.all.inspect}"
                 assert_equal 0, MemberRole.count
                 assert_equal 0, Issue.count
                 assert_equal 0, Journal.count
                 assert_equal 0, JournalDetail.count
                 assert_equal 0, Attachment.count, "Attachments were not deleted: #{Attachment.all.inspect}"
                 assert_equal 0, EnabledModule.count
                 assert_equal 0, IssueCategory.count
                 assert_equal 0, IssueRelation.count
                 assert_equal 0, Board.count
                 assert_equal 0, Message.count
                 assert_equal 0, News.count
                 assert_equal 0, Query.where("project_id IS NOT NULL").count
                 assert_equal 0, Repository.count
                 assert_equal 0, Changeset.count
                 assert_equal 0, Change.count
                 assert_equal 0, Comment.count
                 assert_equal 0, TimeEntry.count
                 assert_equal 0, Version.count
                 assert_equal 0, Watcher.count
                 assert_equal 0, Wiki.count
                 assert_equal 0, WikiPage.count
                 assert_equal 0, WikiContent.count
                 assert_equal 0, WikiContent::Version.count
                 assert_equal 0, Project.connection.select_all("SELECT * FROM projects_trackers").count
                 assert_equal 0, Project.connection.select_all("SELECT * FROM custom_fields_projects").count
                 assert_equal 0, CustomValue.where(:customized_type => ['Project', 'Issue', 'TimeEntry', 'Version']).count
               end
               def test_destroy_should_delete_time_entries_custom_values
                 project = Project.generate!
                 time_entry = TimeEntry.generate!(:project => project, :custom_field_values => {10 => '1'})
                 assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
                   assert project.destroy
                 end
               end
               def test_move_an_orphan_project_to_a_root_project
                 sub = Project.find(2)
                 sub.set_parent! @ecookbook
                 assert_equal @ecookbook.id, sub.parent.id
                 @ecookbook.reload
                 assert_equal 4, @ecookbook.children.size
               end
               def test_move_an_orphan_project_to_a_subproject
                 sub = Project.find(2)
                 assert sub.set_parent!(@ecookbook_sub1)
               end
               def test_move_a_root_project_to_a_project
                 sub = @ecookbook
                 assert sub.set_parent!(Project.find(2))
               end
               def test_should_not_move_a_project_to_its_children
                 sub = @ecookbook
                 assert !(sub.set_parent!(Project.find(3)))
               end
               def test_set_parent_should_add_roots_in_alphabetical_order
                 ProjectCustomField.delete_all
                 Project.delete_all
                 Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(nil)
                 Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(nil)
                 Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(nil)
                 Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(nil)
                 assert_equal 4, Project.count
                 assert_equal Project.all.sort_by(&:name), Project.all.sort_by(&:lft)
               end
               def test_set_parent_should_add_children_in_alphabetical_order
                 ProjectCustomField.delete_all
                 parent = Project.create!(:name => 'Parent', :identifier => 'parent')
                 Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(parent)
                 Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(parent)
                 Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(parent)
                 Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(parent)
                 parent.reload
                 assert_equal 4, parent.children.size
                 assert_equal parent.children.sort_by(&:name), parent.children.to_a
               end
               def test_set_parent_should_update_issue_fixed_version_associations_when_a_fixed_version_is_moved_out_of_the_hierarchy
                 # Parent issue with a hierarchy project's fixed version
                 parent_issue = Issue.find(1)
                 parent_issue.update_attribute(:fixed_version_id, 4)
                 parent_issue.reload
                 assert_equal 4, parent_issue.fixed_version_id
                 # Should keep fixed versions for the issues
                 issue_with_local_fixed_version = Issue.find(5)
                 issue_with_local_fixed_version.update_attribute(:fixed_version_id, 4)
                 issue_with_local_fixed_version.reload
                 assert_equal 4, issue_with_local_fixed_version.fixed_version_id
                 # Local issue with hierarchy fixed_version
                 issue_with_hierarchy_fixed_version = Issue.find(13)
                 issue_with_hierarchy_fixed_version.update_attribute(:fixed_version_id, 6)
                 issue_with_hierarchy_fixed_version.reload
                 assert_equal 6, issue_with_hierarchy_fixed_version.fixed_version_id
                 # Move project out of the issue's hierarchy
                 moved_project = Project.find(3)
                 moved_project.set_parent!(Project.find(2))
                 parent_issue.reload
                 issue_with_local_fixed_version.reload
                 issue_with_hierarchy_fixed_version.reload
                 assert_equal 4, issue_with_local_fixed_version.fixed_version_id, "Fixed version was not keep on an issue local to the moved project"
                 assert_equal nil, issue_with_hierarchy_fixed_version.fixed_version_id, "Fixed version is still set after moving the Project out of the hierarchy where the version is defined in"
                 assert_equal nil, parent_issue.fixed_version_id, "Fixed version is still set after moving the Version out of the hierarchy for the issue."
               end
               def test_parent
                 p = Project.find(6).parent
                 assert p.is_a?(Project)
                 assert_equal 5, p.id
               end
               def test_ancestors
                 a = Project.find(6).ancestors
                 assert a.first.is_a?(Project)
                 assert_equal [1, 5], a.collect(&:id)
               end
               def test_root
                 r = Project.find(6).root
                 assert r.is_a?(Project)
                 assert_equal 1, r.id
               end
               def test_children
                 c = Project.find(1).children
                 assert c.first.is_a?(Project)
                 assert_equal [5, 3, 4], c.collect(&:id)
               end
               def test_descendants
                 d = Project.find(1).descendants
                 assert d.first.is_a?(Project)
                 assert_equal [5, 6, 3, 4], d.collect(&:id)
               end
               def test_allowed_parents_should_be_empty_for_non_member_user
                 Role.non_member.add_permission!(:add_project)
                 user = User.find(9)
                 assert user.memberships.empty?
                 User.current = user
                 assert Project.new.allowed_parents.compact.empty?
               end
               def test_allowed_parents_with_add_subprojects_permission
                 Role.find(1).remove_permission!(:add_project)
                 Role.find(1).add_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert !Project.new.allowed_parents.include?(nil)
                 assert Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert !Project.find(3).allowed_parents.include?(nil)
               end
               def test_allowed_parents_with_add_project_permission
                 Role.find(1).add_permission!(:add_project)
                 Role.find(1).remove_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert Project.new.allowed_parents.include?(nil)
                 assert !Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert Project.find(3).allowed_parents.include?(nil)
               end
               def test_allowed_parents_with_add_project_and_subprojects_permission
                 Role.find(1).add_permission!(:add_project)
                 Role.find(1).add_permission!(:add_subprojects)
                 User.current = User.find(2)
                 # new project
                 assert Project.new.allowed_parents.include?(nil)
                 assert Project.new.allowed_parents.include?(Project.find(1))
                 # existing root project
                 assert Project.find(1).allowed_parents.include?(nil)
                 # existing child
                 assert Project.find(3).allowed_parents.include?(Project.find(1))
                 assert Project.find(3).allowed_parents.include?(nil)
               end
               def test_users_by_role
                 users_by_role = Project.find(1).users_by_role
                 assert_kind_of Hash, users_by_role
                 role = Role.find(1)
                 assert_kind_of Array, users_by_role[role]
                 assert users_by_role[role].include?(User.find(2))
               end
               def test_rolled_up_trackers
                 parent = Project.find(1)
                 parent.trackers = Tracker.find([1,2])
                 child = parent.children.find(3)
                 assert_equal [1, 2], parent.tracker_ids
                 assert_equal [2, 3], child.trackers.collect(&:id)
                 assert_kind_of Tracker, parent.rolled_up_trackers.first
                 assert_equal Tracker.find(1), parent.rolled_up_trackers.first
                 assert_equal [1, 2, 3], parent.rolled_up_trackers.collect(&:id)
                 assert_equal [2, 3], child.rolled_up_trackers.collect(&:id)
               end
               def test_rolled_up_trackers_should_ignore_archived_subprojects
                 parent = Project.find(1)
                 parent.trackers = Tracker.find([1,2])
                 child = parent.children.find(3)
                 child.trackers = Tracker.find([1,3])
                 parent.children.each(&:archive)
                 assert_equal [1,2], parent.rolled_up_trackers.collect(&:id)
               end
               test "#rolled_up_trackers should ignore projects with issue_tracking module disabled" do
                 parent = Project.generate!
                 parent.trackers = Tracker.find([1, 2])
                 child = Project.generate_with_parent!(parent)
                 child.trackers = Tracker.find([2, 3])
                 assert_equal [1, 2, 3], parent.rolled_up_trackers.collect(&:id).sort
                 assert child.disable_module!(:issue_tracking)
                 parent.reload
                 assert_equal [1, 2], parent.rolled_up_trackers.collect(&:id).sort
               end
               test "#rolled_up_versions should include the versions for the current project" do
                 project = Project.generate!
                 parent_version_1 = Version.generate!(:project => project)
                 parent_version_2 = Version.generate!(:project => project)
                 assert_equal [parent_version_1, parent_version_2].sort,
                   project.rolled_up_versions.sort
               end
               test "#rolled_up_versions should include versions for a subproject" do
                 project = Project.generate!
                 parent_version_1 = Version.generate!(:project => project)
                 parent_version_2 = Version.generate!(:project => project)
                 subproject = Project.generate_with_parent!(project)
                 subproject_version = Version.generate!(:project => subproject)
                 assert_equal [parent_version_1, parent_version_2, subproject_version].sort,
                   project.rolled_up_versions.sort
               end
               test "#rolled_up_versions should include versions for a sub-subproject" do
                 project = Project.generate!
                 parent_version_1 = Version.generate!(:project => project)
                 parent_version_2 = Version.generate!(:project => project)
                 subproject = Project.generate_with_parent!(project)
                 sub_subproject = Project.generate_with_parent!(subproject)
                 sub_subproject_version = Version.generate!(:project => sub_subproject)
                 project.reload
                 assert_equal [parent_version_1, parent_version_2, sub_subproject_version].sort,
                   project.rolled_up_versions.sort
               end
               test "#rolled_up_versions should only check active projects" do
                 project = Project.generate!
                 parent_version_1 = Version.generate!(:project => project)
                 parent_version_2 = Version.generate!(:project => project)
                 subproject = Project.generate_with_parent!(project)
                 subproject_version = Version.generate!(:project => subproject)
                 assert subproject.archive
                 project.reload
                 assert !subproject.active?
                 assert_equal [parent_version_1, parent_version_2].sort,
                   project.rolled_up_versions.sort
               end
               def test_shared_versions_none_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'none_sharing', :project => p, :sharing => 'none')
                 assert p.shared_versions.include?(v)
                 assert !p.children.first.shared_versions.include?(v)
                 assert !p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_descendants_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'descendants_sharing', :project => p, :sharing => 'descendants')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert !p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_hierarchy_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'hierarchy_sharing', :project => p, :sharing => 'hierarchy')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert !p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_tree_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'tree_sharing', :project => p, :sharing => 'tree')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert p.siblings.first.shared_versions.include?(v)
                 assert !p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions_system_sharing
                 p = Project.find(5)
                 v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                 assert p.shared_versions.include?(v)
                 assert p.children.first.shared_versions.include?(v)
                 assert p.root.shared_versions.include?(v)
                 assert p.siblings.first.shared_versions.include?(v)
                 assert p.root.siblings.first.shared_versions.include?(v)
               end
               def test_shared_versions
                 parent = Project.find(1)
                 child = parent.children.find(3)
                 private_child = parent.children.find(5)
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [4], child.version_ids
                 assert_equal [6], private_child.version_ids
                 assert_equal [7], Version.where(:sharing => 'system').collect(&:id)
                 assert_equal 6, parent.shared_versions.size
                 parent.shared_versions.each do |version|
                   assert_kind_of Version, version
                 end
                 assert_equal [1,2,3,4,6,7], parent.shared_versions.collect(&:id).sort
               end
               def test_shared_versions_should_ignore_archived_subprojects
                 parent = Project.find(1)
                 child = parent.children.find(3)
                 child.archive
                 parent.reload
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [4], child.version_ids
                 assert !parent.shared_versions.collect(&:id).include?(4)
               end
               def test_shared_versions_visible_to_user
                 user = User.find(3)
                 parent = Project.find(1)
                 child = parent.children.find(5)
                 assert_equal [1,2,3], parent.version_ids.sort
                 assert_equal [6], child.version_ids
                 versions = parent.shared_versions.visible(user)
                 assert_equal 4, versions.size
                 versions.each do |version|
                   assert_kind_of Version, version
                 end
                 assert !versions.collect(&:id).include?(6)
               end
               def test_shared_versions_for_new_project_should_include_system_shared_versions
                 p = Project.find(5)
                 v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                 assert_include v, Project.new.shared_versions
               end
               def test_next_identifier
                 ProjectCustomField.delete_all
                 Project.create!(:name => 'last', :identifier => 'p2008040')
                 assert_equal 'p2008041', Project.next_identifier
               end
               def test_next_identifier_first_project
                 Project.delete_all
                 assert_nil Project.next_identifier
               end
               def test_enabled_module_names
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   project = Project.new
                   project.enabled_module_names = %w(issue_tracking news)
                   assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                 end
               end
               def test_enabled_modules_names_with_nil_should_clear_modules
                 p = Project.find(1)
                 p.enabled_module_names = nil
                 assert_equal [], p.enabled_modules
               end
               test "enabled_modules should define module by names and preserve ids" do
                 @project = Project.find(1)
                 # Remove one module
                 modules = @project.enabled_modules.slice(0..-2)
                 assert modules.any?
                 assert_difference 'EnabledModule.count', -1 do
                   @project.enabled_module_names = modules.collect(&:name)
                 end
                 @project.reload
                 # Ids should be preserved
                 assert_equal @project.enabled_module_ids.sort, modules.collect(&:id).sort
               end
               test "enabled_modules should enable a module" do
                 @project = Project.find(1)
                 @project.enabled_module_names = []
                 @project.reload
                 assert_equal [], @project.enabled_module_names
                 #with string
                 @project.enable_module!("issue_tracking")
                 assert_equal ["issue_tracking"], @project.enabled_module_names
                 #with symbol
                 @project.enable_module!(:gantt)
                 assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
                 #don't add a module twice
                 @project.enable_module!("issue_tracking")
                 assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
               end
               test "enabled_modules should disable a module" do
                 @project = Project.find(1)
                 #with string
                 assert @project.enabled_module_names.include?("issue_tracking")
                 @project.disable_module!("issue_tracking")
                 assert ! @project.reload.enabled_module_names.include?("issue_tracking")
                 #with symbol
                 assert @project.enabled_module_names.include?("gantt")
                 @project.disable_module!(:gantt)
                 assert ! @project.reload.enabled_module_names.include?("gantt")
                 #with EnabledModule object
                 first_module = @project.enabled_modules.first
                 @project.disable_module!(first_module)
                 assert ! @project.reload.enabled_module_names.include?(first_module.name)
               end
               def test_enabled_module_names_should_not_recreate_enabled_modules
                 project = Project.find(1)
                 # Remove one module
                 modules = project.enabled_modules.slice(0..-2)
                 assert modules.any?
                 assert_difference 'EnabledModule.count', -1 do
                   project.enabled_module_names = modules.collect(&:name)
                 end
                 project.reload
                 # Ids should be preserved
                 assert_equal project.enabled_module_ids.sort, modules.collect(&:id).sort
               end
               def test_copy_from_existing_project
                 source_project = Project.find(1)
                 copied_project = Project.copy_from(1)
                 assert copied_project
                 # Cleared attributes
                 assert copied_project.id.blank?
                 assert copied_project.name.blank?
                 assert copied_project.identifier.blank?
                 # Duplicated attributes
                 assert_equal source_project.description, copied_project.description
                 assert_equal source_project.trackers, copied_project.trackers
                 # Default attributes
                 assert_equal 1, copied_project.status
               end
               def test_copy_from_should_copy_enabled_modules
                 source = Project.generate!
                 source.enabled_module_names = %w(issue_tracking wiki)
                 copy = Project.copy_from(source)
                 copy.name = 'Copy'
                 copy.identifier = 'copy'
                 assert_difference 'EnabledModule.count', 2 do
                   copy.save!
                 end
                 assert_equal 2, copy.reload.enabled_modules.count
                 assert_equal 2, source.reload.enabled_modules.count
               end
               def test_activities_should_use_the_system_activities
                 project = Project.find(1)
                 assert_equal project.activities.to_a, TimeEntryActivity.where(:active => true).to_a
                 assert_kind_of ActiveRecord::Relation, project.activities
               end
               def test_activities_should_use_the_project_specific_activities
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project})
                 assert overridden_activity.save!
                 assert project.activities.include?(overridden_activity), "Project specific Activity not found"
                 assert_kind_of ActiveRecord::Relation, project.activities
               end
               def test_activities_should_not_include_the_inactive_project_specific_activities
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.first, :active => false})
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity found"
               end
               def test_activities_should_not_include_project_specific_activities_from_other_projects
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(2)})
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Project specific Activity found on a different project"
               end
               def test_activities_should_handle_nils
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(1), :parent => TimeEntryActivity.first})
                 TimeEntryActivity.delete_all
                 # No activities
                 project = Project.find(1)
                 assert project.activities.empty?
                 # No system, one overridden
                 assert overridden_activity.save!
                 project.reload
                 assert_equal [overridden_activity], project.activities
               end
               def test_activities_should_override_system_activities_with_project_activities
                 project = Project.find(1)
                 parent_activity = TimeEntryActivity.first
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => parent_activity})
                 assert overridden_activity.save!
                 assert project.activities.include?(overridden_activity), "Project specific Activity not found"
                 assert !project.activities.include?(parent_activity), "System Activity found when it should have been overridden"
               end
               def test_activities_should_include_inactive_activities_if_specified
                 project = Project.find(1)
                 overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.first, :active => false})
                 assert overridden_activity.save!
                 assert project.activities(true).include?(overridden_activity), "Inactive Project specific Activity not found"
               end
               test 'activities should not include active System activities if the project has an override that is inactive' do
                 project = Project.find(1)
                 system_activity = TimeEntryActivity.find_by_name('Design')
                 assert system_activity.active?
                 overridden_activity = TimeEntryActivity.create!(:name => "Project", :project => project, :parent => system_activity, :active => false)
                 assert overridden_activity.save!
                 assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity not found"
                 assert !project.activities.include?(system_activity), "System activity found when the project has an inactive override"
               end
               def test_close_completed_versions
                 Version.update_all("status = 'open'")
                 project = Project.find(1)
                 assert_not_nil project.versions.detect {|v| v.completed? && v.status == 'open'}
                 assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
                 project.close_completed_versions
                 project.reload
                 assert_nil project.versions.detect {|v| v.completed? && v.status != 'closed'}
                 assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
               end
               test "#start_date should be nil if there are no issues on the project" do
                 project = Project.generate!
                 assert_nil project.start_date
               end
               test "#start_date should be nil when issues have no start date" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 early = 7.days.ago.to_date
                 Issue.generate!(:project => project, :start_date => nil)
                 assert_nil project.start_date
               end
               test "#start_date should be the earliest start date of it's issues" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 early = 7.days.ago.to_date
                 Issue.generate!(:project => project, :start_date => Date.today)
                 Issue.generate!(:project => project, :start_date => early)
                 assert_equal early, project.start_date
               end
               test "#due_date should be nil if there are no issues on the project" do
                 project = Project.generate!
                 assert_nil project.due_date
               end
               test "#due_date should be nil if there are no issues with due dates" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 Issue.generate!(:project => project, :due_date => nil)
                 assert_nil project.due_date
               end
               test "#due_date should be the latest due date of it's issues" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 future = 7.days.from_now.to_date
                 Issue.generate!(:project => project, :due_date => future)
                 Issue.generate!(:project => project, :due_date => Date.today)
                 assert_equal future, project.due_date
               end
               test "#due_date should be the latest due date of it's versions" do
                 project = Project.generate!
                 future = 7.days.from_now.to_date
                 project.versions << Version.generate!(:effective_date => future)
                 project.versions << Version.generate!(:effective_date => Date.today)
                 assert_equal future, project.due_date
               end
               test "#due_date should pick the latest date from it's issues and versions" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 future = 7.days.from_now.to_date
                 far_future = 14.days.from_now.to_date
                 Issue.generate!(:project => project, :due_date => far_future)
                 project.versions << Version.generate!(:effective_date => future)
                 assert_equal far_future, project.due_date
               end
               test "#completed_percent with no versions should be 100" do
                 project = Project.generate!
                 assert_equal 100, project.completed_percent
               end
               test "#completed_percent with versions should return 0 if the versions have no issues" do
                 project = Project.generate!
                 Version.generate!(:project => project)
                 Version.generate!(:project => project)
                 assert_equal 0, project.completed_percent
               end
               test "#completed_percent with versions should return 100 if the version has only closed issues" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 v1 = Version.generate!(:project => project)
                 Issue.generate!(:project => project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v1)
                 v2 = Version.generate!(:project => project)
                 Issue.generate!(:project => project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v2)
                 assert_equal 100, project.completed_percent
               end
               test "#completed_percent with versions should return the averaged completed percent of the versions (not weighted)" do
                 project = Project.generate!
                 project.trackers << Tracker.generate!
                 v1 = Version.generate!(:project => project)
                 Issue.generate!(:project => project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v1)
                 v2 = Version.generate!(:project => project)
                 Issue.generate!(:project => project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v2)
                 assert_equal 50, project.completed_percent
               end
               test "#notified_users" do
                 project = Project.generate!
                 role = Role.generate!
                 user_with_membership_notification = User.generate!(:mail_notification => 'selected')
                 Member.create!(:project => project, :roles => [role], :principal => user_with_membership_notification, :mail_notification => true)
                 all_events_user = User.generate!(:mail_notification => 'all')
                 Member.create!(:project => project, :roles => [role], :principal => all_events_user)
                 no_events_user = User.generate!(:mail_notification => 'none')
                 Member.create!(:project => project, :roles => [role], :principal => no_events_user)
                 only_my_events_user = User.generate!(:mail_notification => 'only_my_events')
                 Member.create!(:project => project, :roles => [role], :principal => only_my_events_user)
                 only_assigned_user = User.generate!(:mail_notification => 'only_assigned')
                 Member.create!(:project => project, :roles => [role], :principal => only_assigned_user)
                 only_owned_user = User.generate!(:mail_notification => 'only_owner')
                 Member.create!(:project => project, :roles => [role], :principal => only_owned_user)
                 assert project.notified_users.include?(user_with_membership_notification), "should include members with a mail notification"
                 assert project.notified_users.include?(all_events_user), "should include users with the 'all' notification option"
                 assert !project.notified_users.include?(no_events_user), "should not include users with the 'none' notification option"
                 assert !project.notified_users.include?(only_my_events_user), "should not include users with the 'only_my_events' notification option"
                 assert !project.notified_users.include?(only_assigned_user), "should not include users with the 'only_assigned' notification option"
                 assert !project.notified_users.include?(only_owned_user), "should not include users with the 'only_owner' notification option"
               end
               def test_override_roles_without_builtin_group_memberships
                 project = Project.generate!
                 assert_equal [Role.anonymous], project.override_roles(Role.anonymous)
                 assert_equal [Role.non_member], project.override_roles(Role.non_member)
               end
               def test_css_classes
                 p = Project.new
                 assert_kind_of String, p.css_classes
                 assert_not_include 'archived', p.css_classes.split
                 assert_not_include 'closed', p.css_classes.split
               end
               def test_css_classes_for_archived_project
                 p = Project.new
                 p.status = Project::STATUS_ARCHIVED
                 assert_include 'archived', p.css_classes.split
               end
               def test_css_classes_for_closed_project
                 p = Project.new
                 p.status = Project::STATUS_CLOSED
                 assert_include 'closed', p.css_classes.split
               end
-              def test_combination_of_visible_and_uniq_scopes_in_case_anonymous_group_has_memberships_should_not_error
+              def test_combination_of_visible_and_distinct_scopes_in_case_anonymous_group_has_memberships_should_not_error
                 project = Project.find(1)
                 member = Member.create!(:project => project, :principal => Group.anonymous, :roles => [Role.generate!])
                 project.members << member
                 assert_nothing_raised do
-                  Project.uniq.visible.to_a
+                  Project.distinct.visible.to_a
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages