##// END OF EJS Templates
Allows project to be changed from the bulk edit form....
Jean-Philippe Lang -
r8416:d29638845a9c
parent child
Show More
@@ -1,361 +1,388
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
24 24 before_filter :check_project_uniqueness, :only => [:move, :perform_move]
25 25 before_filter :find_project, :only => [:new, :create]
26 26 before_filter :authorize, :except => [:index]
27 27 before_filter :find_optional_project, :only => [:index]
28 28 before_filter :check_for_default_issue_status, :only => [:new, :create]
29 29 before_filter :build_new_issue_from_params, :only => [:new, :create]
30 30 accept_rss_auth :index, :show
31 31 accept_api_auth :index, :show, :create, :update, :destroy
32 32
33 33 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
34 34
35 35 helper :journals
36 36 helper :projects
37 37 include ProjectsHelper
38 38 helper :custom_fields
39 39 include CustomFieldsHelper
40 40 helper :issue_relations
41 41 include IssueRelationsHelper
42 42 helper :watchers
43 43 include WatchersHelper
44 44 helper :attachments
45 45 include AttachmentsHelper
46 46 helper :queries
47 47 include QueriesHelper
48 48 helper :repositories
49 49 include RepositoriesHelper
50 50 helper :sort
51 51 include SortHelper
52 52 include IssuesHelper
53 53 helper :timelog
54 54 helper :gantt
55 55 include Redmine::Export::PDF
56 56
57 57 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
58 58 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
59 59 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
60 60
61 61 def index
62 62 retrieve_query
63 63 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
64 64 sort_update(@query.sortable_columns)
65 65
66 66 if @query.valid?
67 67 case params[:format]
68 68 when 'csv', 'pdf'
69 69 @limit = Setting.issues_export_limit.to_i
70 70 when 'atom'
71 71 @limit = Setting.feeds_limit.to_i
72 72 when 'xml', 'json'
73 73 @offset, @limit = api_offset_and_limit
74 74 else
75 75 @limit = per_page_option
76 76 end
77 77
78 78 @issue_count = @query.issue_count
79 79 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
80 80 @offset ||= @issue_pages.current.offset
81 81 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
82 82 :order => sort_clause,
83 83 :offset => @offset,
84 84 :limit => @limit)
85 85 @issue_count_by_group = @query.issue_count_by_group
86 86
87 87 respond_to do |format|
88 88 format.html { render :template => 'issues/index', :layout => !request.xhr? }
89 89 format.api {
90 90 Issue.load_relations(@issues) if include_in_api_response?('relations')
91 91 }
92 92 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
93 93 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
94 94 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
95 95 end
96 96 else
97 97 respond_to do |format|
98 98 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
99 99 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
100 100 format.api { render_validation_errors(@query) }
101 101 end
102 102 end
103 103 rescue ActiveRecord::RecordNotFound
104 104 render_404
105 105 end
106 106
107 107 def show
108 108 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
109 109 @journals.each_with_index {|j,i| j.indice = i+1}
110 110 @journals.reverse! if User.current.wants_comments_in_reverse_order?
111 111
112 112 if User.current.allowed_to?(:view_changesets, @project)
113 113 @changesets = @issue.changesets.visible.all
114 114 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
115 115 end
116 116
117 117 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
118 118 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
119 119 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
120 120 @priorities = IssuePriority.active
121 121 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
122 122 respond_to do |format|
123 123 format.html {
124 124 retrieve_previous_and_next_issue_ids
125 125 render :template => 'issues/show'
126 126 }
127 127 format.api
128 128 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
129 129 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
130 130 end
131 131 end
132 132
133 133 # Add a new issue
134 134 # The new issue will be created from an existing one if copy_from parameter is given
135 135 def new
136 136 respond_to do |format|
137 137 format.html { render :action => 'new', :layout => !request.xhr? }
138 138 format.js {
139 139 render(:update) { |page|
140 140 if params[:project_change]
141 141 page.replace_html 'all_attributes', :partial => 'form'
142 142 else
143 143 page.replace_html 'attributes', :partial => 'attributes'
144 144 end
145 145 m = User.current.allowed_to?(:log_time, @issue.project) ? 'show' : 'hide'
146 146 page << "if ($('log_time')) {Element.#{m}('log_time');}"
147 147 }
148 148 }
149 149 end
150 150 end
151 151
152 152 def create
153 153 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
154 154 if @issue.save
155 155 attachments = Attachment.attach_files(@issue, params[:attachments])
156 156 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
157 157 respond_to do |format|
158 158 format.html {
159 159 render_attachment_warning_if_needed(@issue)
160 160 flash[:notice] = l(:notice_issue_successful_create, :id => "<a href='#{issue_path(@issue)}'>##{@issue.id}</a>")
161 161 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
162 162 { :action => 'show', :id => @issue })
163 163 }
164 164 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
165 165 end
166 166 return
167 167 else
168 168 respond_to do |format|
169 169 format.html { render :action => 'new' }
170 170 format.api { render_validation_errors(@issue) }
171 171 end
172 172 end
173 173 end
174 174
175 175 def edit
176 176 update_issue_from_params
177 177
178 178 @journal = @issue.current_journal
179 179
180 180 respond_to do |format|
181 181 format.html { }
182 182 format.xml { }
183 183 end
184 184 end
185 185
186 186 def update
187 187 update_issue_from_params
188 188
189 189 if @issue.save_issue_with_child_records(params, @time_entry)
190 190 render_attachment_warning_if_needed(@issue)
191 191 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
192 192
193 193 respond_to do |format|
194 194 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
195 195 format.api { head :ok }
196 196 end
197 197 else
198 198 render_attachment_warning_if_needed(@issue)
199 199 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
200 200 @journal = @issue.current_journal
201 201
202 202 respond_to do |format|
203 203 format.html { render :action => 'edit' }
204 204 format.api { render_validation_errors(@issue) }
205 205 end
206 206 end
207 207 end
208 208
209 209 # Bulk edit a set of issues
210 210 def bulk_edit
211 211 @issues.sort!
212 @available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
213 @custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
214 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
215 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
212
213 if User.current.allowed_to?(:move_issues, @projects)
214 @allowed_projects = Issue.allowed_target_projects_on_move
215 if params[:issue]
216 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id]}
217 if @target_project
218 target_projects = [@target_project]
219 end
220 end
221 end
222 target_projects ||= @projects
223
224 @available_statuses = target_projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
225 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
226 @assignables = target_projects.map(&:assignable_users).inject{|memo,a| memo & a}
227 @trackers = target_projects.map(&:trackers).inject{|memo,t| memo & t}
228
229 @notes = params[:notes]
230 render :layout => false if request.xhr?
216 231 end
217 232
218 233 def bulk_update
219 234 @issues.sort!
220 235 attributes = parse_params_for_bulk_issue_attributes(params)
221 236
222 237 unsaved_issue_ids = []
238 moved_issues = []
223 239 @issues.each do |issue|
224 240 issue.reload
225 241 journal = issue.init_journal(User.current, params[:notes])
226 242 issue.safe_attributes = attributes
227 243 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
228 unless issue.save
244 if issue.save
245 moved_issues << issue
246 else
229 247 # Keep unsaved issue ids to display them in flash error
230 248 unsaved_issue_ids << issue.id
231 249 end
232 250 end
233 251 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
252
253 if params[:follow]
254 if @issues.size == 1 && moved_issues.size == 1
255 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
256 elsif moved_issues.map(&:project).uniq.size == 1
257 redirect_to :controller => 'issues', :action => 'index', :project_id => moved_issues.map(&:project).first
258 end
259 else
234 260 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
235 261 end
262 end
236 263
237 264 verify :method => :delete, :only => :destroy, :render => { :nothing => true, :status => :method_not_allowed }
238 265 def destroy
239 266 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
240 267 if @hours > 0
241 268 case params[:todo]
242 269 when 'destroy'
243 270 # nothing to do
244 271 when 'nullify'
245 272 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
246 273 when 'reassign'
247 274 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
248 275 if reassign_to.nil?
249 276 flash.now[:error] = l(:error_issue_not_found_in_project)
250 277 return
251 278 else
252 279 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
253 280 end
254 281 else
255 282 # display the destroy form if it's a user request
256 283 return unless api_request?
257 284 end
258 285 end
259 286 @issues.each do |issue|
260 287 begin
261 288 issue.reload.destroy
262 289 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
263 290 # nothing to do, issue was already deleted (eg. by a parent)
264 291 end
265 292 end
266 293 respond_to do |format|
267 294 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
268 295 format.api { head :ok }
269 296 end
270 297 end
271 298
272 299 private
273 300 def find_issue
274 301 # Issue.visible.find(...) can not be used to redirect user to the login form
275 302 # if the issue actually exists but requires authentication
276 303 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
277 304 unless @issue.visible?
278 305 deny_access
279 306 return
280 307 end
281 308 @project = @issue.project
282 309 rescue ActiveRecord::RecordNotFound
283 310 render_404
284 311 end
285 312
286 313 def find_project
287 314 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
288 315 @project = Project.find(project_id)
289 316 rescue ActiveRecord::RecordNotFound
290 317 render_404
291 318 end
292 319
293 320 def retrieve_previous_and_next_issue_ids
294 321 retrieve_query_from_session
295 322 if @query
296 323 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
297 324 sort_update(@query.sortable_columns, 'issues_index_sort')
298 325 limit = 500
299 326 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1))
300 327 if (idx = issue_ids.index(@issue.id)) && idx < limit
301 328 @prev_issue_id = issue_ids[idx - 1] if idx > 0
302 329 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
303 330 end
304 331 end
305 332 end
306 333
307 334 # Used by #edit and #update to set some common instance variables
308 335 # from the params
309 336 # TODO: Refactor, not everything in here is needed by #edit
310 337 def update_issue_from_params
311 338 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
312 339 @priorities = IssuePriority.active
313 340 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
314 341 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
315 342 @time_entry.attributes = params[:time_entry]
316 343
317 344 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
318 345 @issue.init_journal(User.current, @notes)
319 346 @issue.safe_attributes = params[:issue]
320 347 end
321 348
322 349 # TODO: Refactor, lots of extra code in here
323 350 # TODO: Changing tracker on an existing issue should not trigger this
324 351 def build_new_issue_from_params
325 352 if params[:id].blank?
326 353 @issue = Issue.new
327 354 @issue.copy_from(params[:copy_from]) if params[:copy_from]
328 355 @issue.project = @project
329 356 else
330 357 @issue = @project.issues.visible.find(params[:id])
331 358 end
332 359
333 360 @issue.project = @project
334 361 @issue.author = User.current
335 362 # Tracker must be set before custom field values
336 363 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
337 364 if @issue.tracker.nil?
338 365 render_error l(:error_no_tracker_in_project)
339 366 return false
340 367 end
341 368 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
342 369 @issue.safe_attributes = params[:issue]
343 370
344 371 @priorities = IssuePriority.active
345 372 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
346 373 end
347 374
348 375 def check_for_default_issue_status
349 376 if IssueStatus.default.nil?
350 377 render_error l(:error_no_default_issue_status)
351 378 return false
352 379 end
353 380 end
354 381
355 382 def parse_params_for_bulk_issue_attributes(params)
356 383 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
357 384 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
358 385 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
359 386 attributes
360 387 end
361 388 end
@@ -1,96 +1,113
1 1 <h2><%= l(:label_bulk_edit_selected_issues) %></h2>
2 2
3 3 <ul><%= @issues.collect {|i|
4 4 content_tag('li',
5 5 link_to(h("#{i.tracker} ##{i.id}"),
6 6 { :action => 'show', :id => i }
7 7 ) + h(": #{i.subject}"))
8 8 }.join("\n").html_safe %></ul>
9 9
10 <% form_tag(:action => 'bulk_update') do %>
10 <% form_tag({:action => 'bulk_update'}, :id => 'bulk_edit_form') do %>
11 11 <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join("\n").html_safe %>
12 12 <div class="box tabular">
13 13 <fieldset class="attributes">
14 14 <legend><%= l(:label_change_properties) %></legend>
15 15
16 16 <div class="splitcontentleft">
17 <% if @allowed_projects.present? %>
18 <p>
19 <label for="issue_project_id"><%= l(:field_project) %></label>
20 <%= select_tag('issue[project_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + project_tree_options_for_select(@allowed_projects, :selected => @target_project)) %>
21 </p>
22 <%= observe_field :issue_project_id, :url => {:action => 'bulk_edit'},
23 :update => 'content',
24 :with => "Form.serialize('bulk_edit_form')" %>
25 <% end %>
17 26 <p>
18 27 <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
19 28 <%= select_tag('issue[tracker_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, :id, :name)) %>
20 29 </p>
21 30 <% if @available_statuses.any? %>
22 31 <p>
23 32 <label for='issue_status_id'><%= l(:field_status) %></label>
24 33 <%= select_tag('issue[status_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@available_statuses, :id, :name)) %>
25 34 </p>
26 35 <% end %>
27 36 <p>
28 37 <label for='issue_priority_id'><%= l(:field_priority) %></label>
29 38 <%= select_tag('issue[priority_id]', "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
30 39 </p>
31 40 <p>
32 41 <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
33 42 <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
34 43 content_tag('option', l(:label_nobody), :value => 'none') +
35 44 principals_options_for_select(@assignables)) %>
36 45 </p>
37 46 <% if @project %>
38 47 <p>
39 48 <label for='issue_category_id'><%= l(:field_category) %></label>
40 49 <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
41 50 content_tag('option', l(:label_none), :value => 'none') +
42 51 options_from_collection_for_select(@project.issue_categories, :id, :name)) %>
43 52 </p>
44 53 <% end %>
45 54 <% #TODO: allow editing versions when multiple projects %>
46 55 <% if @project %>
47 56 <p>
48 57 <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
49 58 <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
50 59 content_tag('option', l(:label_none), :value => 'none') +
51 60 version_options_for_select(@project.shared_versions.open.sort)) %>
52 61 </p>
53 62 <% end %>
54 63
55 64 <% @custom_fields.each do |custom_field| %>
56 65 <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
57 66 <% end %>
58 67
59 68 <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
60 69 </div>
61 70
62 71 <div class="splitcontentright">
63 72 <% if @project && User.current.allowed_to?(:manage_subtasks, @project) %>
64 73 <p>
65 74 <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
66 75 <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
67 76 </p>
68 77 <div id="parent_issue_candidates" class="autocomplete"></div>
69 78 <%= javascript_tag "observeParentIssueField('#{auto_complete_issues_path(:project_id => @project) }')" %>
70 79 <% end %>
71 80 <p>
72 81 <label for='issue_start_date'><%= l(:field_start_date) %></label>
73 82 <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
74 83 </p>
75 84 <p>
76 85 <label for='issue_due_date'><%= l(:field_due_date) %></label>
77 86 <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
78 87 </p>
79 88 <% if Issue.use_field_for_done_ratio? %>
80 89 <p>
81 90 <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
82 91 <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
83 92 </p>
84 93 <% end %>
85 94 </div>
86 95
87 96 </fieldset>
88 97
89 98 <fieldset><legend><%= l(:field_notes) %></legend>
90 99 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
91 100 <%= wikitoolbar_for 'notes' %>
92 101 </fieldset>
93 102 </div>
94 103
95 <p><%= submit_tag l(:button_submit) %></p>
104 <p>
105 <% if @target_project %>
106 <%= submit_tag l(:button_move) %>
107 <%= submit_tag l(:button_move_and_follow), :name => 'follow' %>
108 <% else %>
109 <%= submit_tag l(:button_submit) %>
110 <% end %>
111 </p>
112
96 113 <% end %>
@@ -1,399 +1,399
1 1 ActionController::Routing::Routes.draw do |map|
2 2 # Add your own custom routes here.
3 3 # The priority is based upon order of creation: first created -> highest priority.
4 4
5 5 # Here's a sample route:
6 6 # map.connect 'products/:id', :controller => 'catalog', :action => 'view'
7 7 # Keep in mind you can assign values other than :controller and :action
8 8
9 9 map.home '', :controller => 'welcome', :conditions => {:method => :get}
10 10
11 11 map.signin 'login', :controller => 'account', :action => 'login',
12 12 :conditions => {:method => [:get, :post]}
13 13 map.signout 'logout', :controller => 'account', :action => 'logout',
14 14 :conditions => {:method => :get}
15 15 map.connect 'account/register', :controller => 'account', :action => 'register',
16 16 :conditions => {:method => [:get, :post]}
17 17 map.connect 'account/lost_password', :controller => 'account', :action => 'lost_password',
18 18 :conditions => {:method => [:get, :post]}
19 19 map.connect 'account/activate', :controller => 'account', :action => 'activate',
20 20 :conditions => {:method => :get}
21 21
22 22 map.connect 'projects/:id/wiki', :controller => 'wikis',
23 23 :action => 'edit', :conditions => {:method => :post}
24 24 map.connect 'projects/:id/wiki/destroy', :controller => 'wikis',
25 25 :action => 'destroy', :conditions => {:method => [:get, :post]}
26 26
27 27 map.with_options :controller => 'messages' do |messages_routes|
28 28 messages_routes.with_options :conditions => {:method => :get} do |messages_views|
29 29 messages_views.connect 'boards/:board_id/topics/new', :action => 'new'
30 30 messages_views.connect 'boards/:board_id/topics/:id', :action => 'show'
31 31 messages_views.connect 'boards/:board_id/topics/:id/edit', :action => 'edit'
32 32 end
33 33 messages_routes.with_options :conditions => {:method => :post} do |messages_actions|
34 34 messages_actions.connect 'boards/:board_id/topics/new', :action => 'new'
35 35 messages_actions.connect 'boards/:board_id/topics/preview', :action => 'preview'
36 36 messages_actions.connect 'boards/:board_id/topics/quote/:id', :action => 'quote'
37 37 messages_actions.connect 'boards/:board_id/topics/:id/replies', :action => 'reply'
38 38 messages_actions.connect 'boards/:board_id/topics/:id/edit', :action => 'edit'
39 39 messages_actions.connect 'boards/:board_id/topics/:id/destroy', :action => 'destroy'
40 40 end
41 41 end
42 42
43 43 map.resources :issue_moves, :only => [:new, :create],
44 44 :path_prefix => '/issues', :as => 'move'
45 45
46 46 # Misc issue routes. TODO: move into resources
47 47 map.auto_complete_issues '/issues/auto_complete', :controller => 'auto_completes',
48 48 :action => 'issues', :conditions => { :method => :get }
49 49 # TODO: would look nicer as /issues/:id/preview
50 50 map.preview_issue '/issues/preview/:id', :controller => 'previews',
51 51 :action => 'issue'
52 52 map.issues_context_menu '/issues/context_menu',
53 53 :controller => 'context_menus', :action => 'issues'
54 54
55 55 map.issue_changes '/issues/changes', :controller => 'journals', :action => 'index'
56 56 map.quoted_issue '/issues/:id/quoted', :controller => 'journals', :action => 'new',
57 57 :id => /\d+/, :conditions => { :method => :post }
58 58
59 59 map.connect '/journals/diff/:id', :controller => 'journals', :action => 'diff',
60 60 :id => /\d+/, :conditions => { :method => :get }
61 61 map.connect '/journals/edit/:id', :controller => 'journals', :action => 'edit',
62 62 :id => /\d+/, :conditions => { :method => [:get, :post] }
63 63
64 64 map.with_options :controller => 'gantts', :action => 'show' do |gantts_routes|
65 65 gantts_routes.connect '/projects/:project_id/issues/gantt'
66 66 gantts_routes.connect '/projects/:project_id/issues/gantt.:format'
67 67 gantts_routes.connect '/issues/gantt.:format'
68 68 end
69 69
70 70 map.with_options :controller => 'calendars', :action => 'show' do |calendars_routes|
71 71 calendars_routes.connect '/projects/:project_id/issues/calendar'
72 72 calendars_routes.connect '/issues/calendar'
73 73 end
74 74
75 75 map.with_options :controller => 'reports', :conditions => {:method => :get} do |reports|
76 76 reports.connect 'projects/:id/issues/report', :action => 'issue_report'
77 77 reports.connect 'projects/:id/issues/report/:detail', :action => 'issue_report_details'
78 78 end
79 79
80 80 map.connect 'my/account', :controller => 'my', :action => 'account',
81 81 :conditions => {:method => [:get, :post]}
82 82 map.connect 'my/page', :controller => 'my', :action => 'page',
83 83 :conditions => {:method => :get}
84 84 # Redirects to my/page
85 85 map.connect 'my', :controller => 'my', :action => 'index',
86 86 :conditions => {:method => :get}
87 87 map.connect 'my/reset_rss_key', :controller => 'my', :action => 'reset_rss_key',
88 88 :conditions => {:method => :post}
89 89 map.connect 'my/reset_api_key', :controller => 'my', :action => 'reset_api_key',
90 90 :conditions => {:method => :post}
91 91 map.connect 'my/password', :controller => 'my', :action => 'password',
92 92 :conditions => {:method => [:get, :post]}
93 93 map.connect 'my/page_layout', :controller => 'my', :action => 'page_layout',
94 94 :conditions => {:method => :get}
95 95 map.connect 'my/add_block', :controller => 'my', :action => 'add_block',
96 96 :conditions => {:method => :post}
97 97 map.connect 'my/remove_block', :controller => 'my', :action => 'remove_block',
98 98 :conditions => {:method => :post}
99 99 map.connect 'my/order_blocks', :controller => 'my', :action => 'order_blocks',
100 100 :conditions => {:method => :post}
101 101
102 102 map.connect 'projects/:id/members/new', :controller => 'members',
103 103 :action => 'new', :conditions => { :method => :post }
104 104 map.connect 'members/edit/:id', :controller => 'members',
105 105 :action => 'edit', :id => /\d+/, :conditions => { :method => :post }
106 106 map.connect 'members/destroy/:id', :controller => 'members',
107 107 :action => 'destroy', :id => /\d+/, :conditions => { :method => :post }
108 108 map.connect 'members/autocomplete_for_member/:id', :controller => 'members',
109 109 :action => 'autocomplete_for_member', :conditions => { :method => :post }
110 110
111 111 map.with_options :controller => 'users' do |users|
112 112 users.user_membership 'users/:id/memberships/:membership_id',
113 113 :action => 'edit_membership',
114 114 :conditions => {:method => :put}
115 115 users.connect 'users/:id/memberships/:membership_id',
116 116 :action => 'destroy_membership',
117 117 :conditions => {:method => :delete}
118 118 users.user_memberships 'users/:id/memberships',
119 119 :action => 'edit_membership',
120 120 :conditions => {:method => :post}
121 121 end
122 122 map.resources :users
123 123
124 124 # For nice "roadmap" in the url for the index action
125 125 map.connect 'projects/:project_id/roadmap', :controller => 'versions', :action => 'index'
126 126
127 127 map.connect 'news', :controller => 'news', :action => 'index'
128 128 map.connect 'news.:format', :controller => 'news', :action => 'index'
129 129 map.preview_news '/news/preview', :controller => 'previews', :action => 'news'
130 130 map.connect 'news/:id/comments', :controller => 'comments',
131 131 :action => 'create', :conditions => {:method => :post}
132 132 map.connect 'news/:id/comments/:comment_id', :controller => 'comments',
133 133 :action => 'destroy', :conditions => {:method => :delete}
134 134
135 135 map.connect 'watchers/new', :controller=> 'watchers', :action => 'new',
136 136 :conditions => {:method => [:get, :post]}
137 137 map.connect 'watchers/destroy', :controller=> 'watchers', :action => 'destroy',
138 138 :conditions => {:method => :post}
139 139 map.connect 'watchers/watch', :controller=> 'watchers', :action => 'watch',
140 140 :conditions => {:method => :post}
141 141 map.connect 'watchers/unwatch', :controller=> 'watchers', :action => 'unwatch',
142 142 :conditions => {:method => :post}
143 143
144 144 # TODO: port to be part of the resources route(s)
145 145 map.with_options :conditions => {:method => :get} do |project_views|
146 146 project_views.connect 'projects/:id/settings/:tab',
147 147 :controller => 'projects', :action => 'settings'
148 148 project_views.connect 'projects/:project_id/issues/:copy_from/copy',
149 149 :controller => 'issues', :action => 'new'
150 150 end
151 151
152 152 map.resources :projects, :member => {
153 153 :copy => [:get, :post],
154 154 :settings => :get,
155 155 :modules => :post,
156 156 :archive => :post,
157 157 :unarchive => :post
158 158 } do |project|
159 159 project.resource :project_enumerations, :as => 'enumerations',
160 160 :only => [:update, :destroy]
161 161 # issue form update
162 162 project.issue_form 'issues/new', :controller => 'issues',
163 163 :action => 'new', :conditions => {:method => [:post, :put]}
164 164 project.resources :issues, :only => [:index, :new, :create] do |issues|
165 165 issues.resources :time_entries, :controller => 'timelog',
166 166 :collection => {:report => :get}
167 167 end
168 168
169 169 project.resources :files, :only => [:index, :new, :create]
170 170 project.resources :versions, :shallow => true,
171 171 :collection => {:close_completed => :put},
172 172 :member => {:status_by => :post}
173 173 project.resources :news, :shallow => true
174 174 project.resources :time_entries, :controller => 'timelog',
175 175 :path_prefix => 'projects/:project_id',
176 176 :collection => {:report => :get}
177 177 project.resources :queries, :only => [:new, :create]
178 178 project.resources :issue_categories, :shallow => true
179 179 project.resources :documents, :shallow => true, :member => {:add_attachment => :post}
180 180 project.resources :boards
181 181
182 182 project.wiki_start_page 'wiki', :controller => 'wiki', :action => 'show', :conditions => {:method => :get}
183 183 project.wiki_index 'wiki/index', :controller => 'wiki', :action => 'index', :conditions => {:method => :get}
184 184 project.wiki_diff 'wiki/:id/diff/:version', :controller => 'wiki', :action => 'diff', :version => nil
185 185 project.wiki_diff 'wiki/:id/diff/:version/vs/:version_from', :controller => 'wiki', :action => 'diff'
186 186 project.wiki_annotate 'wiki/:id/annotate/:version', :controller => 'wiki', :action => 'annotate'
187 187 project.resources :wiki, :except => [:new, :create], :member => {
188 188 :rename => [:get, :post],
189 189 :history => :get,
190 190 :preview => :any,
191 191 :protect => :post,
192 192 :add_attachment => :post
193 193 }, :collection => {
194 194 :export => :get,
195 195 :date_index => :get
196 196 }
197 197 end
198 198
199 199 map.resources :queries, :except => [:show]
200 200 map.resources :issues,
201 :collection => {:bulk_edit => :get, :bulk_update => :post} do |issues|
201 :collection => {:bulk_edit => [:get, :post], :bulk_update => :post} do |issues|
202 202 issues.resources :time_entries, :controller => 'timelog',
203 203 :collection => {:report => :get}
204 204 issues.resources :relations, :shallow => true,
205 205 :controller => 'issue_relations',
206 206 :only => [:index, :show, :create, :destroy]
207 207 end
208 208 # Bulk deletion
209 209 map.connect '/issues', :controller => 'issues', :action => 'destroy',
210 210 :conditions => {:method => :delete}
211 211
212 212 map.connect '/time_entries/destroy',
213 213 :controller => 'timelog', :action => 'destroy',
214 214 :conditions => { :method => :delete }
215 215 map.time_entries_context_menu '/time_entries/context_menu',
216 216 :controller => 'context_menus', :action => 'time_entries'
217 217
218 218 map.resources :time_entries, :controller => 'timelog',
219 219 :collection => {:report => :get, :bulk_edit => :get, :bulk_update => :post}
220 220
221 221 map.with_options :controller => 'activities', :action => 'index',
222 222 :conditions => {:method => :get} do |activity|
223 223 activity.connect 'projects/:id/activity'
224 224 activity.connect 'projects/:id/activity.:format'
225 225 activity.connect 'activity', :id => nil
226 226 activity.connect 'activity.:format', :id => nil
227 227 end
228 228
229 229 map.with_options :controller => 'repositories' do |repositories|
230 230 repositories.with_options :conditions => {:method => :get} do |repository_views|
231 231 repository_views.connect 'projects/:id/repository',
232 232 :action => 'show'
233 233 repository_views.connect 'projects/:id/repository/statistics',
234 234 :action => 'stats'
235 235
236 236 repository_views.connect 'projects/:id/repository/revisions',
237 237 :action => 'revisions'
238 238 repository_views.connect 'projects/:id/repository/revisions.:format',
239 239 :action => 'revisions'
240 240 repository_views.connect 'projects/:id/repository/revisions/:rev',
241 241 :action => 'revision'
242 242 repository_views.connect 'projects/:id/repository/revisions/:rev/diff',
243 243 :action => 'diff'
244 244 repository_views.connect 'projects/:id/repository/revisions/:rev/diff.:format',
245 245 :action => 'diff'
246 246 repository_views.connect 'projects/:id/repository/revisions/:rev/raw/*path',
247 247 :action => 'entry',
248 248 :format => 'raw',
249 249 :requirements => { :rev => /[a-z0-9\.\-_]+/ }
250 250 repository_views.connect 'projects/:id/repository/revisions/:rev/:action/*path',
251 251 :requirements => { :rev => /[a-z0-9\.\-_]+/ }
252 252
253 253 repository_views.connect 'projects/:id/repository/raw/*path',
254 254 :action => 'entry', :format => 'raw'
255 255 repository_views.connect 'projects/:id/repository/browse/*path',
256 256 :action => 'browse'
257 257 repository_views.connect 'projects/:id/repository/entry/*path',
258 258 :action => 'entry'
259 259 repository_views.connect 'projects/:id/repository/changes/*path',
260 260 :action => 'changes'
261 261 repository_views.connect 'projects/:id/repository/annotate/*path',
262 262 :action => 'annotate'
263 263 repository_views.connect 'projects/:id/repository/diff/*path',
264 264 :action => 'diff'
265 265 repository_views.connect 'projects/:id/repository/show/*path',
266 266 :action => 'show'
267 267 repository_views.connect 'projects/:id/repository/graph',
268 268 :action => 'graph'
269 269 end
270 270
271 271 repositories.connect 'projects/:id/repository/revision',
272 272 :action => 'revision',
273 273 :conditions => {:method => [:get, :post]}
274 274
275 275 repositories.connect 'projects/:id/repository/committers',
276 276 :action => 'committers',
277 277 :conditions => {:method => [:get, :post]}
278 278 repositories.connect 'projects/:id/repository/edit',
279 279 :action => 'edit',
280 280 :conditions => {:method => [:get, :post]}
281 281 repositories.connect 'projects/:id/repository/destroy',
282 282 :action => 'destroy',
283 283 :conditions => {:method => :post}
284 284 end
285 285
286 286 # additional routes for having the file name at the end of url
287 287 map.connect 'attachments/:id/:filename', :controller => 'attachments',
288 288 :action => 'show', :id => /\d+/, :filename => /.*/,
289 289 :conditions => {:method => :get}
290 290 map.connect 'attachments/download/:id/:filename', :controller => 'attachments',
291 291 :action => 'download', :id => /\d+/, :filename => /.*/,
292 292 :conditions => {:method => :get}
293 293 map.connect 'attachments/download/:id', :controller => 'attachments',
294 294 :action => 'download', :id => /\d+/,
295 295 :conditions => {:method => :get}
296 296 map.resources :attachments, :only => [:show, :destroy]
297 297
298 298 map.resources :groups, :member => {:autocomplete_for_user => :get}
299 299 map.group_users 'groups/:id/users', :controller => 'groups',
300 300 :action => 'add_users', :id => /\d+/,
301 301 :conditions => {:method => :post}
302 302 map.group_user 'groups/:id/users/:user_id', :controller => 'groups',
303 303 :action => 'remove_user', :id => /\d+/,
304 304 :conditions => {:method => :delete}
305 305 map.connect 'groups/destroy_membership/:id', :controller => 'groups',
306 306 :action => 'destroy_membership', :id => /\d+/,
307 307 :conditions => {:method => :post}
308 308 map.connect 'groups/edit_membership/:id', :controller => 'groups',
309 309 :action => 'edit_membership', :id => /\d+/,
310 310 :conditions => {:method => :post}
311 311
312 312 map.resources :trackers, :except => :show
313 313 map.resources :issue_statuses, :except => :show, :collection => {:update_issue_done_ratio => :post}
314 314 map.resources :custom_fields, :except => :show
315 315 map.resources :roles, :except => :show, :collection => {:permissions => [:get, :post]}
316 316 map.resources :enumerations, :except => :show
317 317
318 318 map.connect 'search', :controller => 'search', :action => 'index', :conditions => {:method => :get}
319 319
320 320 map.connect 'mail_handler', :controller => 'mail_handler',
321 321 :action => 'index', :conditions => {:method => :post}
322 322
323 323 map.connect 'admin', :controller => 'admin', :action => 'index',
324 324 :conditions => {:method => :get}
325 325 map.connect 'admin/projects', :controller => 'admin', :action => 'projects',
326 326 :conditions => {:method => :get}
327 327 map.connect 'admin/plugins', :controller => 'admin', :action => 'plugins',
328 328 :conditions => {:method => :get}
329 329 map.connect 'admin/info', :controller => 'admin', :action => 'info',
330 330 :conditions => {:method => :get}
331 331 map.connect 'admin/test_email', :controller => 'admin', :action => 'test_email',
332 332 :conditions => {:method => :get}
333 333 map.connect 'admin/default_configuration', :controller => 'admin',
334 334 :action => 'default_configuration', :conditions => {:method => :post}
335 335
336 336 # Used by AuthSourcesControllerTest
337 337 # TODO : refactor *AuthSourcesController to remove these routes
338 338 map.connect 'auth_sources', :controller => 'auth_sources',
339 339 :action => 'index', :conditions => {:method => :get}
340 340 map.connect 'auth_sources/new', :controller => 'auth_sources',
341 341 :action => 'new', :conditions => {:method => :get}
342 342 map.connect 'auth_sources/create', :controller => 'auth_sources',
343 343 :action => 'create', :conditions => {:method => :post}
344 344 map.connect 'auth_sources/destroy/:id', :controller => 'auth_sources',
345 345 :action => 'destroy', :id => /\d+/, :conditions => {:method => :post}
346 346 map.connect 'auth_sources/test_connection/:id', :controller => 'auth_sources',
347 347 :action => 'test_connection', :conditions => {:method => :get}
348 348 map.connect 'auth_sources/edit/:id', :controller => 'auth_sources',
349 349 :action => 'edit', :id => /\d+/, :conditions => {:method => :get}
350 350 map.connect 'auth_sources/update/:id', :controller => 'auth_sources',
351 351 :action => 'update', :id => /\d+/, :conditions => {:method => :post}
352 352
353 353 map.connect 'ldap_auth_sources', :controller => 'ldap_auth_sources',
354 354 :action => 'index', :conditions => {:method => :get}
355 355 map.connect 'ldap_auth_sources/new', :controller => 'ldap_auth_sources',
356 356 :action => 'new', :conditions => {:method => :get}
357 357 map.connect 'ldap_auth_sources/create', :controller => 'ldap_auth_sources',
358 358 :action => 'create', :conditions => {:method => :post}
359 359 map.connect 'ldap_auth_sources/destroy/:id', :controller => 'ldap_auth_sources',
360 360 :action => 'destroy', :id => /\d+/, :conditions => {:method => :post}
361 361 map.connect 'ldap_auth_sources/test_connection/:id', :controller => 'ldap_auth_sources',
362 362 :action => 'test_connection', :conditions => {:method => :get}
363 363 map.connect 'ldap_auth_sources/edit/:id', :controller => 'ldap_auth_sources',
364 364 :action => 'edit', :id => /\d+/, :conditions => {:method => :get}
365 365 map.connect 'ldap_auth_sources/update/:id', :controller => 'ldap_auth_sources',
366 366 :action => 'update', :id => /\d+/, :conditions => {:method => :post}
367 367
368 368 map.connect 'workflows', :controller => 'workflows',
369 369 :action => 'index', :conditions => {:method => :get}
370 370 map.connect 'workflows/edit', :controller => 'workflows',
371 371 :action => 'edit', :conditions => {:method => [:get, :post]}
372 372 map.connect 'workflows/copy', :controller => 'workflows',
373 373 :action => 'copy', :conditions => {:method => [:get, :post]}
374 374
375 375 map.connect 'settings', :controller => 'settings',
376 376 :action => 'index', :conditions => {:method => :get}
377 377 map.connect 'settings/edit', :controller => 'settings',
378 378 :action => 'edit', :conditions => {:method => [:get, :post]}
379 379 map.connect 'settings/plugin/:id', :controller => 'settings',
380 380 :action => 'plugin', :conditions => {:method => [:get, :post]}
381 381
382 382 map.with_options :controller => 'sys' do |sys|
383 383 sys.connect 'sys/projects.:format',
384 384 :action => 'projects',
385 385 :conditions => {:method => :get}
386 386 sys.connect 'sys/projects/:id/repository.:format',
387 387 :action => 'create_project_repository',
388 388 :conditions => {:method => :post}
389 389 sys.connect 'sys/fetch_changesets',
390 390 :action => 'fetch_changesets',
391 391 :conditions => {:method => :get}
392 392 end
393 393
394 394 map.connect 'robots.txt', :controller => 'welcome',
395 395 :action => 'robots', :conditions => {:method => :get}
396 396
397 397 # Used for OpenID
398 398 map.root :controller => 'account', :action => 'login'
399 399 end
@@ -1,2339 +1,2390
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'issues_controller'
20 20
21 21 class IssuesControllerTest < ActionController::TestCase
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issues,
28 28 :issue_statuses,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries
45 45
46 46 include Redmine::I18n
47 47
48 48 def setup
49 49 @controller = IssuesController.new
50 50 @request = ActionController::TestRequest.new
51 51 @response = ActionController::TestResponse.new
52 52 User.current = nil
53 53 end
54 54
55 55 def test_index
56 56 Setting.default_language = 'en'
57 57
58 58 get :index
59 59 assert_response :success
60 60 assert_template 'index'
61 61 assert_not_nil assigns(:issues)
62 62 assert_nil assigns(:project)
63 63 assert_tag :tag => 'a', :content => /Can't print recipes/
64 64 assert_tag :tag => 'a', :content => /Subproject issue/
65 65 # private projects hidden
66 66 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
67 67 assert_no_tag :tag => 'a', :content => /Issue on project 2/
68 68 # project column
69 69 assert_tag :tag => 'th', :content => /Project/
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79 assert_no_tag :tag => 'a', :content => /Can't print recipes/
80 80 assert_tag :tag => 'a', :content => /Subproject issue/
81 81 end
82 82
83 83 def test_index_should_list_visible_issues_only
84 84 get :index, :per_page => 100
85 85 assert_response :success
86 86 assert_not_nil assigns(:issues)
87 87 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
88 88 end
89 89
90 90 def test_index_with_project
91 91 Setting.display_subprojects_issues = 0
92 92 get :index, :project_id => 1
93 93 assert_response :success
94 94 assert_template 'index'
95 95 assert_not_nil assigns(:issues)
96 96 assert_tag :tag => 'a', :content => /Can't print recipes/
97 97 assert_no_tag :tag => 'a', :content => /Subproject issue/
98 98 end
99 99
100 100 def test_index_with_project_and_subprojects
101 101 Setting.display_subprojects_issues = 1
102 102 get :index, :project_id => 1
103 103 assert_response :success
104 104 assert_template 'index'
105 105 assert_not_nil assigns(:issues)
106 106 assert_tag :tag => 'a', :content => /Can't print recipes/
107 107 assert_tag :tag => 'a', :content => /Subproject issue/
108 108 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
109 109 end
110 110
111 111 def test_index_with_project_and_subprojects_should_show_private_subprojects
112 112 @request.session[:user_id] = 2
113 113 Setting.display_subprojects_issues = 1
114 114 get :index, :project_id => 1
115 115 assert_response :success
116 116 assert_template 'index'
117 117 assert_not_nil assigns(:issues)
118 118 assert_tag :tag => 'a', :content => /Can't print recipes/
119 119 assert_tag :tag => 'a', :content => /Subproject issue/
120 120 assert_tag :tag => 'a', :content => /Issue of a private subproject/
121 121 end
122 122
123 123 def test_index_with_project_and_default_filter
124 124 get :index, :project_id => 1, :set_filter => 1
125 125 assert_response :success
126 126 assert_template 'index'
127 127 assert_not_nil assigns(:issues)
128 128
129 129 query = assigns(:query)
130 130 assert_not_nil query
131 131 # default filter
132 132 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
133 133 end
134 134
135 135 def test_index_with_project_and_filter
136 136 get :index, :project_id => 1, :set_filter => 1,
137 137 :f => ['tracker_id'],
138 138 :op => {'tracker_id' => '='},
139 139 :v => {'tracker_id' => ['1']}
140 140 assert_response :success
141 141 assert_template 'index'
142 142 assert_not_nil assigns(:issues)
143 143
144 144 query = assigns(:query)
145 145 assert_not_nil query
146 146 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
147 147 end
148 148
149 149 def test_index_with_short_filters
150 150
151 151 to_test = {
152 152 'status_id' => {
153 153 'o' => { :op => 'o', :values => [''] },
154 154 'c' => { :op => 'c', :values => [''] },
155 155 '7' => { :op => '=', :values => ['7'] },
156 156 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
157 157 '=7' => { :op => '=', :values => ['7'] },
158 158 '!3' => { :op => '!', :values => ['3'] },
159 159 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
160 160 'subject' => {
161 161 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
162 162 'o' => { :op => '=', :values => ['o'] },
163 163 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
164 164 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
165 165 'tracker_id' => {
166 166 '3' => { :op => '=', :values => ['3'] },
167 167 '=3' => { :op => '=', :values => ['3'] }},
168 168 'start_date' => {
169 169 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
170 170 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
171 171 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
172 172 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
173 173 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
174 174 '<t+2' => { :op => '<t+', :values => ['2'] },
175 175 '>t+2' => { :op => '>t+', :values => ['2'] },
176 176 't+2' => { :op => 't+', :values => ['2'] },
177 177 't' => { :op => 't', :values => [''] },
178 178 'w' => { :op => 'w', :values => [''] },
179 179 '>t-2' => { :op => '>t-', :values => ['2'] },
180 180 '<t-2' => { :op => '<t-', :values => ['2'] },
181 181 't-2' => { :op => 't-', :values => ['2'] }},
182 182 'created_on' => {
183 183 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
184 184 '<t+2' => { :op => '=', :values => ['<t+2'] },
185 185 '>t+2' => { :op => '=', :values => ['>t+2'] },
186 186 't+2' => { :op => 't', :values => ['+2'] }},
187 187 'cf_1' => {
188 188 'c' => { :op => '=', :values => ['c'] },
189 189 '!c' => { :op => '!', :values => ['c'] },
190 190 '!*' => { :op => '!*', :values => [''] },
191 191 '*' => { :op => '*', :values => [''] }},
192 192 'estimated_hours' => {
193 193 '=13.4' => { :op => '=', :values => ['13.4'] },
194 194 '>=45' => { :op => '>=', :values => ['45'] },
195 195 '<=125' => { :op => '<=', :values => ['125'] },
196 196 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
197 197 '!*' => { :op => '!*', :values => [''] },
198 198 '*' => { :op => '*', :values => [''] }}
199 199 }
200 200
201 201 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
202 202
203 203 to_test.each do |field, expression_and_expected|
204 204 expression_and_expected.each do |filter_expression, expected|
205 205
206 206 get :index, :set_filter => 1, field => filter_expression
207 207
208 208 assert_response :success
209 209 assert_template 'index'
210 210 assert_not_nil assigns(:issues)
211 211
212 212 query = assigns(:query)
213 213 assert_not_nil query
214 214 assert query.has_filter?(field)
215 215 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
216 216 end
217 217 end
218 218
219 219 end
220 220
221 221 def test_index_with_project_and_empty_filters
222 222 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
223 223 assert_response :success
224 224 assert_template 'index'
225 225 assert_not_nil assigns(:issues)
226 226
227 227 query = assigns(:query)
228 228 assert_not_nil query
229 229 # no filter
230 230 assert_equal({}, query.filters)
231 231 end
232 232
233 233 def test_index_with_query
234 234 get :index, :project_id => 1, :query_id => 5
235 235 assert_response :success
236 236 assert_template 'index'
237 237 assert_not_nil assigns(:issues)
238 238 assert_nil assigns(:issue_count_by_group)
239 239 end
240 240
241 241 def test_index_with_query_grouped_by_tracker
242 242 get :index, :project_id => 1, :query_id => 6
243 243 assert_response :success
244 244 assert_template 'index'
245 245 assert_not_nil assigns(:issues)
246 246 assert_not_nil assigns(:issue_count_by_group)
247 247 end
248 248
249 249 def test_index_with_query_grouped_by_list_custom_field
250 250 get :index, :project_id => 1, :query_id => 9
251 251 assert_response :success
252 252 assert_template 'index'
253 253 assert_not_nil assigns(:issues)
254 254 assert_not_nil assigns(:issue_count_by_group)
255 255 end
256 256
257 257 def test_index_with_query_id_and_project_id_should_set_session_query
258 258 get :index, :project_id => 1, :query_id => 4
259 259 assert_response :success
260 260 assert_kind_of Hash, session[:query]
261 261 assert_equal 4, session[:query][:id]
262 262 assert_equal 1, session[:query][:project_id]
263 263 end
264 264
265 265 def test_index_with_cross_project_query_in_session_should_show_project_issues
266 266 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
267 267 @request.session[:query] = {:id => q.id, :project_id => 1}
268 268
269 269 with_settings :display_subprojects_issues => '0' do
270 270 get :index, :project_id => 1
271 271 end
272 272 assert_response :success
273 273 assert_not_nil assigns(:query)
274 274 assert_equal q.id, assigns(:query).id
275 275 assert_equal 1, assigns(:query).project_id
276 276 assert_equal [1], assigns(:issues).map(&:project_id).uniq
277 277 end
278 278
279 279 def test_private_query_should_not_be_available_to_other_users
280 280 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
281 281 @request.session[:user_id] = 3
282 282
283 283 get :index, :query_id => q.id
284 284 assert_response 403
285 285 end
286 286
287 287 def test_private_query_should_be_available_to_its_user
288 288 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
289 289 @request.session[:user_id] = 2
290 290
291 291 get :index, :query_id => q.id
292 292 assert_response :success
293 293 end
294 294
295 295 def test_public_query_should_be_available_to_other_users
296 296 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
297 297 @request.session[:user_id] = 3
298 298
299 299 get :index, :query_id => q.id
300 300 assert_response :success
301 301 end
302 302
303 303 def test_index_csv
304 304 get :index, :format => 'csv'
305 305 assert_response :success
306 306 assert_not_nil assigns(:issues)
307 307 assert_equal 'text/csv', @response.content_type
308 308 assert @response.body.starts_with?("#,")
309 309 lines = @response.body.chomp.split("\n")
310 310 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
311 311 end
312 312
313 313 def test_index_csv_with_project
314 314 get :index, :project_id => 1, :format => 'csv'
315 315 assert_response :success
316 316 assert_not_nil assigns(:issues)
317 317 assert_equal 'text/csv', @response.content_type
318 318 end
319 319
320 320 def test_index_csv_with_description
321 321 get :index, :format => 'csv', :description => '1'
322 322 assert_response :success
323 323 assert_not_nil assigns(:issues)
324 324 assert_equal 'text/csv', @response.content_type
325 325 assert @response.body.starts_with?("#,")
326 326 lines = @response.body.chomp.split("\n")
327 327 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
328 328 end
329 329
330 330 def test_index_csv_with_all_columns
331 331 get :index, :format => 'csv', :columns => 'all'
332 332 assert_response :success
333 333 assert_not_nil assigns(:issues)
334 334 assert_equal 'text/csv', @response.content_type
335 335 assert @response.body.starts_with?("#,")
336 336 lines = @response.body.chomp.split("\n")
337 337 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
338 338 end
339 339
340 340 def test_index_csv_big_5
341 341 with_settings :default_language => "zh-TW" do
342 342 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
343 343 str_big5 = "\xa4@\xa4\xeb"
344 344 if str_utf8.respond_to?(:force_encoding)
345 345 str_utf8.force_encoding('UTF-8')
346 346 str_big5.force_encoding('Big5')
347 347 end
348 348 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
349 349 :status_id => 1, :priority => IssuePriority.all.first,
350 350 :subject => str_utf8)
351 351 assert issue.save
352 352
353 353 get :index, :project_id => 1,
354 354 :f => ['subject'],
355 355 :op => '=', :values => [str_utf8],
356 356 :format => 'csv'
357 357 assert_equal 'text/csv', @response.content_type
358 358 lines = @response.body.chomp.split("\n")
359 359 s1 = "\xaa\xac\xbaA"
360 360 if str_utf8.respond_to?(:force_encoding)
361 361 s1.force_encoding('Big5')
362 362 end
363 363 assert lines[0].include?(s1)
364 364 assert lines[1].include?(str_big5)
365 365 end
366 366 end
367 367
368 368 def test_index_csv_cannot_convert_should_be_replaced_big_5
369 369 with_settings :default_language => "zh-TW" do
370 370 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
371 371 if str_utf8.respond_to?(:force_encoding)
372 372 str_utf8.force_encoding('UTF-8')
373 373 end
374 374 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
375 375 :status_id => 1, :priority => IssuePriority.all.first,
376 376 :subject => str_utf8)
377 377 assert issue.save
378 378
379 379 get :index, :project_id => 1,
380 380 :f => ['subject'],
381 381 :op => '=', :values => [str_utf8],
382 382 :c => ['status', 'subject'],
383 383 :format => 'csv',
384 384 :set_filter => 1
385 385 assert_equal 'text/csv', @response.content_type
386 386 lines = @response.body.chomp.split("\n")
387 387 s1 = "\xaa\xac\xbaA" # status
388 388 if str_utf8.respond_to?(:force_encoding)
389 389 s1.force_encoding('Big5')
390 390 end
391 391 assert lines[0].include?(s1)
392 392 s2 = lines[1].split(",")[2]
393 393 if s1.respond_to?(:force_encoding)
394 394 s3 = "\xa5H?" # subject
395 395 s3.force_encoding('Big5')
396 396 assert_equal s3, s2
397 397 elsif RUBY_PLATFORM == 'java'
398 398 assert_equal "??", s2
399 399 else
400 400 assert_equal "\xa5H???", s2
401 401 end
402 402 end
403 403 end
404 404
405 405 def test_index_csv_tw
406 406 with_settings :default_language => "zh-TW" do
407 407 str1 = "test_index_csv_tw"
408 408 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
409 409 :status_id => 1, :priority => IssuePriority.all.first,
410 410 :subject => str1, :estimated_hours => '1234.5')
411 411 assert issue.save
412 412 assert_equal 1234.5, issue.estimated_hours
413 413
414 414 get :index, :project_id => 1,
415 415 :f => ['subject'],
416 416 :op => '=', :values => [str1],
417 417 :c => ['estimated_hours', 'subject'],
418 418 :format => 'csv',
419 419 :set_filter => 1
420 420 assert_equal 'text/csv', @response.content_type
421 421 lines = @response.body.chomp.split("\n")
422 422 assert_equal "#{issue.id},1234.5,#{str1}", lines[1]
423 423
424 424 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
425 425 if str_tw.respond_to?(:force_encoding)
426 426 str_tw.force_encoding('UTF-8')
427 427 end
428 428 assert_equal str_tw, l(:general_lang_name)
429 429 assert_equal ',', l(:general_csv_separator)
430 430 assert_equal '.', l(:general_csv_decimal_separator)
431 431 end
432 432 end
433 433
434 434 def test_index_csv_fr
435 435 with_settings :default_language => "fr" do
436 436 str1 = "test_index_csv_fr"
437 437 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
438 438 :status_id => 1, :priority => IssuePriority.all.first,
439 439 :subject => str1, :estimated_hours => '1234.5')
440 440 assert issue.save
441 441 assert_equal 1234.5, issue.estimated_hours
442 442
443 443 get :index, :project_id => 1,
444 444 :f => ['subject'],
445 445 :op => '=', :values => [str1],
446 446 :c => ['estimated_hours', 'subject'],
447 447 :format => 'csv',
448 448 :set_filter => 1
449 449 assert_equal 'text/csv', @response.content_type
450 450 lines = @response.body.chomp.split("\n")
451 451 assert_equal "#{issue.id};1234,5;#{str1}", lines[1]
452 452
453 453 str_fr = "Fran\xc3\xa7ais"
454 454 if str_fr.respond_to?(:force_encoding)
455 455 str_fr.force_encoding('UTF-8')
456 456 end
457 457 assert_equal str_fr, l(:general_lang_name)
458 458 assert_equal ';', l(:general_csv_separator)
459 459 assert_equal ',', l(:general_csv_decimal_separator)
460 460 end
461 461 end
462 462
463 463 def test_index_pdf
464 464 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
465 465 with_settings :default_language => lang do
466 466
467 467 get :index
468 468 assert_response :success
469 469 assert_template 'index'
470 470
471 471 if lang == "ja"
472 472 if RUBY_PLATFORM != 'java'
473 473 assert_equal "CP932", l(:general_pdf_encoding)
474 474 end
475 475 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
476 476 next
477 477 end
478 478 end
479 479
480 480 get :index, :format => 'pdf'
481 481 assert_response :success
482 482 assert_not_nil assigns(:issues)
483 483 assert_equal 'application/pdf', @response.content_type
484 484
485 485 get :index, :project_id => 1, :format => 'pdf'
486 486 assert_response :success
487 487 assert_not_nil assigns(:issues)
488 488 assert_equal 'application/pdf', @response.content_type
489 489
490 490 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
491 491 assert_response :success
492 492 assert_not_nil assigns(:issues)
493 493 assert_equal 'application/pdf', @response.content_type
494 494 end
495 495 end
496 496 end
497 497
498 498 def test_index_pdf_with_query_grouped_by_list_custom_field
499 499 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
500 500 assert_response :success
501 501 assert_not_nil assigns(:issues)
502 502 assert_not_nil assigns(:issue_count_by_group)
503 503 assert_equal 'application/pdf', @response.content_type
504 504 end
505 505
506 506 def test_index_sort
507 507 get :index, :sort => 'tracker,id:desc'
508 508 assert_response :success
509 509
510 510 sort_params = @request.session['issues_index_sort']
511 511 assert sort_params.is_a?(String)
512 512 assert_equal 'tracker,id:desc', sort_params
513 513
514 514 issues = assigns(:issues)
515 515 assert_not_nil issues
516 516 assert !issues.empty?
517 517 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
518 518 end
519 519
520 520 def test_index_sort_by_field_not_included_in_columns
521 521 Setting.issue_list_default_columns = %w(subject author)
522 522 get :index, :sort => 'tracker'
523 523 end
524 524
525 525 def test_index_sort_by_assigned_to
526 526 get :index, :sort => 'assigned_to'
527 527 assert_response :success
528 528 assignees = assigns(:issues).collect(&:assigned_to).compact
529 529 assert_equal assignees.sort, assignees
530 530 end
531 531
532 532 def test_index_sort_by_assigned_to_desc
533 533 get :index, :sort => 'assigned_to:desc'
534 534 assert_response :success
535 535 assignees = assigns(:issues).collect(&:assigned_to).compact
536 536 assert_equal assignees.sort.reverse, assignees
537 537 end
538 538
539 539 def test_index_group_by_assigned_to
540 540 get :index, :group_by => 'assigned_to', :sort => 'priority'
541 541 assert_response :success
542 542 end
543 543
544 544 def test_index_sort_by_author
545 545 get :index, :sort => 'author'
546 546 assert_response :success
547 547 authors = assigns(:issues).collect(&:author)
548 548 assert_equal authors.sort, authors
549 549 end
550 550
551 551 def test_index_sort_by_author_desc
552 552 get :index, :sort => 'author:desc'
553 553 assert_response :success
554 554 authors = assigns(:issues).collect(&:author)
555 555 assert_equal authors.sort.reverse, authors
556 556 end
557 557
558 558 def test_index_group_by_author
559 559 get :index, :group_by => 'author', :sort => 'priority'
560 560 assert_response :success
561 561 end
562 562
563 563 def test_index_sort_by_spent_hours
564 564 get :index, :sort => 'spent_hours:desc'
565 565 assert_response :success
566 566 hours = assigns(:issues).collect(&:spent_hours)
567 567 assert_equal hours.sort.reverse, hours
568 568 end
569 569
570 570 def test_index_with_columns
571 571 columns = ['tracker', 'subject', 'assigned_to']
572 572 get :index, :set_filter => 1, :c => columns
573 573 assert_response :success
574 574
575 575 # query should use specified columns
576 576 query = assigns(:query)
577 577 assert_kind_of Query, query
578 578 assert_equal columns, query.column_names.map(&:to_s)
579 579
580 580 # columns should be stored in session
581 581 assert_kind_of Hash, session[:query]
582 582 assert_kind_of Array, session[:query][:column_names]
583 583 assert_equal columns, session[:query][:column_names].map(&:to_s)
584 584
585 585 # ensure only these columns are kept in the selected columns list
586 586 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
587 587 :children => { :count => 3 }
588 588 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
589 589 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
590 590 end
591 591
592 592 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
593 593 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
594 594 get :index, :set_filter => 1
595 595
596 596 # query should use specified columns
597 597 query = assigns(:query)
598 598 assert_kind_of Query, query
599 599 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
600 600 end
601 601
602 602 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
603 603 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
604 604 columns = ['tracker', 'subject', 'assigned_to']
605 605 get :index, :set_filter => 1, :c => columns
606 606
607 607 # query should use specified columns
608 608 query = assigns(:query)
609 609 assert_kind_of Query, query
610 610 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
611 611 end
612 612
613 613 def test_index_with_custom_field_column
614 614 columns = %w(tracker subject cf_2)
615 615 get :index, :set_filter => 1, :c => columns
616 616 assert_response :success
617 617
618 618 # query should use specified columns
619 619 query = assigns(:query)
620 620 assert_kind_of Query, query
621 621 assert_equal columns, query.column_names.map(&:to_s)
622 622
623 623 assert_tag :td,
624 624 :attributes => {:class => 'cf_2 string'},
625 625 :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
626 626 end
627 627
628 628 def test_index_with_date_column
629 629 Issue.find(1).update_attribute :start_date, '1987-08-24'
630 630
631 631 with_settings :date_format => '%d/%m/%Y' do
632 632 get :index, :set_filter => 1, :c => %w(start_date)
633 633 assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
634 634 end
635 635 end
636 636
637 637 def test_index_with_done_ratio
638 638 Issue.find(1).update_attribute :done_ratio, 40
639 639
640 640 get :index, :set_filter => 1, :c => %w(done_ratio)
641 641 assert_tag 'td', :attributes => {:class => /done_ratio/},
642 642 :child => {:tag => 'table', :attributes => {:class => 'progress'},
643 643 :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
644 644 }
645 645 end
646 646
647 647 def test_index_with_spent_hours_column
648 648 get :index, :set_filter => 1, :c => %w(subject spent_hours)
649 649
650 650 assert_tag 'tr', :attributes => {:id => 'issue-3'},
651 651 :child => {
652 652 :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
653 653 }
654 654 end
655 655
656 656 def test_index_should_not_show_spent_hours_column_without_permission
657 657 Role.anonymous.remove_permission! :view_time_entries
658 658 get :index, :set_filter => 1, :c => %w(subject spent_hours)
659 659
660 660 assert_no_tag 'td', :attributes => {:class => /spent_hours/}
661 661 end
662 662
663 663 def test_index_with_fixed_version
664 664 get :index, :set_filter => 1, :c => %w(fixed_version)
665 665 assert_tag 'td', :attributes => {:class => /fixed_version/},
666 666 :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
667 667 end
668 668
669 669 def test_index_send_html_if_query_is_invalid
670 670 get :index, :f => ['start_date'], :op => {:start_date => '='}
671 671 assert_equal 'text/html', @response.content_type
672 672 assert_template 'index'
673 673 end
674 674
675 675 def test_index_send_nothing_if_query_is_invalid
676 676 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
677 677 assert_equal 'text/csv', @response.content_type
678 678 assert @response.body.blank?
679 679 end
680 680
681 681 def test_show_by_anonymous
682 682 get :show, :id => 1
683 683 assert_response :success
684 684 assert_template 'show'
685 685 assert_not_nil assigns(:issue)
686 686 assert_equal Issue.find(1), assigns(:issue)
687 687
688 688 # anonymous role is allowed to add a note
689 689 assert_tag :tag => 'form',
690 690 :descendant => { :tag => 'fieldset',
691 691 :child => { :tag => 'legend',
692 692 :content => /Notes/ } }
693 693 assert_tag :tag => 'title',
694 694 :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
695 695 end
696 696
697 697 def test_show_by_manager
698 698 @request.session[:user_id] = 2
699 699 get :show, :id => 1
700 700 assert_response :success
701 701
702 702 assert_tag :tag => 'a',
703 703 :content => /Quote/
704 704
705 705 assert_tag :tag => 'form',
706 706 :descendant => { :tag => 'fieldset',
707 707 :child => { :tag => 'legend',
708 708 :content => /Change properties/ } },
709 709 :descendant => { :tag => 'fieldset',
710 710 :child => { :tag => 'legend',
711 711 :content => /Log time/ } },
712 712 :descendant => { :tag => 'fieldset',
713 713 :child => { :tag => 'legend',
714 714 :content => /Notes/ } }
715 715 end
716 716
717 717 def test_show_should_display_update_form
718 718 @request.session[:user_id] = 2
719 719 get :show, :id => 1
720 720 assert_response :success
721 721
722 722 assert_tag 'form', :attributes => {:id => 'issue-form'}
723 723 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
724 724 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
725 725 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
726 726 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
727 727 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
728 728 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
729 729 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
730 730 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
731 731 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
732 732 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
733 733 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
734 734 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
735 735 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
736 736 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
737 737 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
738 738 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
739 739 assert_tag 'textarea', :attributes => {:name => 'notes'}
740 740 end
741 741
742 742 def test_show_should_display_update_form_with_minimal_permissions
743 743 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
744 744 Workflow.delete_all :role_id => 1
745 745
746 746 @request.session[:user_id] = 2
747 747 get :show, :id => 1
748 748 assert_response :success
749 749
750 750 assert_tag 'form', :attributes => {:id => 'issue-form'}
751 751 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
752 752 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
753 753 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
754 754 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
755 755 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
756 756 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
757 757 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
758 758 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
759 759 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
760 760 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
761 761 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
762 762 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
763 763 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
764 764 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
765 765 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
766 766 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
767 767 assert_tag 'textarea', :attributes => {:name => 'notes'}
768 768 end
769 769
770 770 def test_show_should_display_update_form_with_workflow_permissions
771 771 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
772 772
773 773 @request.session[:user_id] = 2
774 774 get :show, :id => 1
775 775 assert_response :success
776 776
777 777 assert_tag 'form', :attributes => {:id => 'issue-form'}
778 778 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
779 779 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
780 780 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
781 781 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
782 782 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
783 783 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
784 784 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
785 785 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
786 786 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
787 787 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
788 788 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
789 789 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
790 790 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
791 791 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
792 792 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
793 793 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
794 794 assert_tag 'textarea', :attributes => {:name => 'notes'}
795 795 end
796 796
797 797 def test_show_should_not_display_update_form_without_permissions
798 798 Role.find(1).update_attribute :permissions, [:view_issues]
799 799
800 800 @request.session[:user_id] = 2
801 801 get :show, :id => 1
802 802 assert_response :success
803 803
804 804 assert_no_tag 'form', :attributes => {:id => 'issue-form'}
805 805 end
806 806
807 807 def test_update_form_should_not_display_inactive_enumerations
808 808 @request.session[:user_id] = 2
809 809 get :show, :id => 1
810 810 assert_response :success
811 811
812 812 assert ! IssuePriority.find(15).active?
813 813 assert_no_tag :option, :attributes => {:value => '15'},
814 814 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
815 815 end
816 816
817 817 def test_update_form_should_allow_attachment_upload
818 818 @request.session[:user_id] = 2
819 819 get :show, :id => 1
820 820
821 821 assert_tag :tag => 'form',
822 822 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
823 823 :descendant => {
824 824 :tag => 'input',
825 825 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
826 826 }
827 827 end
828 828
829 829 def test_show_should_deny_anonymous_access_without_permission
830 830 Role.anonymous.remove_permission!(:view_issues)
831 831 get :show, :id => 1
832 832 assert_response :redirect
833 833 end
834 834
835 835 def test_show_should_deny_anonymous_access_to_private_issue
836 836 Issue.update_all(["is_private = ?", true], "id = 1")
837 837 get :show, :id => 1
838 838 assert_response :redirect
839 839 end
840 840
841 841 def test_show_should_deny_non_member_access_without_permission
842 842 Role.non_member.remove_permission!(:view_issues)
843 843 @request.session[:user_id] = 9
844 844 get :show, :id => 1
845 845 assert_response 403
846 846 end
847 847
848 848 def test_show_should_deny_non_member_access_to_private_issue
849 849 Issue.update_all(["is_private = ?", true], "id = 1")
850 850 @request.session[:user_id] = 9
851 851 get :show, :id => 1
852 852 assert_response 403
853 853 end
854 854
855 855 def test_show_should_deny_member_access_without_permission
856 856 Role.find(1).remove_permission!(:view_issues)
857 857 @request.session[:user_id] = 2
858 858 get :show, :id => 1
859 859 assert_response 403
860 860 end
861 861
862 862 def test_show_should_deny_member_access_to_private_issue_without_permission
863 863 Issue.update_all(["is_private = ?", true], "id = 1")
864 864 @request.session[:user_id] = 3
865 865 get :show, :id => 1
866 866 assert_response 403
867 867 end
868 868
869 869 def test_show_should_allow_author_access_to_private_issue
870 870 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
871 871 @request.session[:user_id] = 3
872 872 get :show, :id => 1
873 873 assert_response :success
874 874 end
875 875
876 876 def test_show_should_allow_assignee_access_to_private_issue
877 877 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
878 878 @request.session[:user_id] = 3
879 879 get :show, :id => 1
880 880 assert_response :success
881 881 end
882 882
883 883 def test_show_should_allow_member_access_to_private_issue_with_permission
884 884 Issue.update_all(["is_private = ?", true], "id = 1")
885 885 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
886 886 @request.session[:user_id] = 3
887 887 get :show, :id => 1
888 888 assert_response :success
889 889 end
890 890
891 891 def test_show_should_not_disclose_relations_to_invisible_issues
892 892 Setting.cross_project_issue_relations = '1'
893 893 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
894 894 # Relation to a private project issue
895 895 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
896 896
897 897 get :show, :id => 1
898 898 assert_response :success
899 899
900 900 assert_tag :div, :attributes => { :id => 'relations' },
901 901 :descendant => { :tag => 'a', :content => /#2$/ }
902 902 assert_no_tag :div, :attributes => { :id => 'relations' },
903 903 :descendant => { :tag => 'a', :content => /#4$/ }
904 904 end
905 905
906 906 def test_show_should_list_subtasks
907 907 Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
908 908
909 909 get :show, :id => 1
910 910 assert_response :success
911 911 assert_tag 'div', :attributes => {:id => 'issue_tree'},
912 912 :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
913 913 end
914 914
915 915 def test_show_should_list_parents
916 916 issue = Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
917 917
918 918 get :show, :id => issue.id
919 919 assert_response :success
920 920 assert_tag 'div', :attributes => {:class => 'subject'},
921 921 :descendant => {:tag => 'h3', :content => 'Child Issue'}
922 922 assert_tag 'div', :attributes => {:class => 'subject'},
923 923 :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
924 924 end
925 925
926 926 def test_show_should_not_display_prev_next_links_without_query_in_session
927 927 get :show, :id => 1
928 928 assert_response :success
929 929 assert_nil assigns(:prev_issue_id)
930 930 assert_nil assigns(:next_issue_id)
931 931 end
932 932
933 933 def test_show_should_display_prev_next_links_with_query_in_session
934 934 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
935 935 @request.session['issues_index_sort'] = 'id'
936 936
937 937 with_settings :display_subprojects_issues => '0' do
938 938 get :show, :id => 3
939 939 end
940 940
941 941 assert_response :success
942 942 # Previous and next issues for all projects
943 943 assert_equal 2, assigns(:prev_issue_id)
944 944 assert_equal 5, assigns(:next_issue_id)
945 945
946 946 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
947 947 assert_tag 'a', :attributes => {:href => '/issues/5'}, :content => /Next/
948 948 end
949 949
950 950 def test_show_should_display_prev_next_links_with_project_query_in_session
951 951 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
952 952 @request.session['issues_index_sort'] = 'id'
953 953
954 954 with_settings :display_subprojects_issues => '0' do
955 955 get :show, :id => 3
956 956 end
957 957
958 958 assert_response :success
959 959 # Previous and next issues inside project
960 960 assert_equal 2, assigns(:prev_issue_id)
961 961 assert_equal 7, assigns(:next_issue_id)
962 962
963 963 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
964 964 assert_tag 'a', :attributes => {:href => '/issues/7'}, :content => /Next/
965 965 end
966 966
967 967 def test_show_should_not_display_prev_link_for_first_issue
968 968 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
969 969 @request.session['issues_index_sort'] = 'id'
970 970
971 971 with_settings :display_subprojects_issues => '0' do
972 972 get :show, :id => 1
973 973 end
974 974
975 975 assert_response :success
976 976 assert_nil assigns(:prev_issue_id)
977 977 assert_equal 2, assigns(:next_issue_id)
978 978
979 979 assert_no_tag 'a', :content => /Previous/
980 980 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Next/
981 981 end
982 982
983 983 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
984 984 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
985 985 @request.session['issues_index_sort'] = 'id'
986 986
987 987 get :show, :id => 1
988 988
989 989 assert_response :success
990 990 assert_nil assigns(:prev_issue_id)
991 991 assert_nil assigns(:next_issue_id)
992 992
993 993 assert_no_tag 'a', :content => /Previous/
994 994 assert_no_tag 'a', :content => /Next/
995 995 end
996 996
997 997 def test_show_atom
998 998 get :show, :id => 2, :format => 'atom'
999 999 assert_response :success
1000 1000 assert_template 'journals/index'
1001 1001 # Inline image
1002 1002 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1003 1003 end
1004 1004
1005 1005 def test_show_export_to_pdf
1006 1006 get :show, :id => 3, :format => 'pdf'
1007 1007 assert_response :success
1008 1008 assert_equal 'application/pdf', @response.content_type
1009 1009 assert @response.body.starts_with?('%PDF')
1010 1010 assert_not_nil assigns(:issue)
1011 1011 end
1012 1012
1013 1013 def test_get_new
1014 1014 @request.session[:user_id] = 2
1015 1015 get :new, :project_id => 1, :tracker_id => 1
1016 1016 assert_response :success
1017 1017 assert_template 'new'
1018 1018
1019 1019 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
1020 1020 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1021 1021 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1022 1022 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1023 1023 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1024 1024 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1025 1025 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1026 1026 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1027 1027 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1028 1028 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1029 1029 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1030 1030 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1031 1031 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1032 1032 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1033 1033 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1034 1034 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1035 1035
1036 1036 # Be sure we don't display inactive IssuePriorities
1037 1037 assert ! IssuePriority.find(15).active?
1038 1038 assert_no_tag :option, :attributes => {:value => '15'},
1039 1039 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1040 1040 end
1041 1041
1042 1042 def test_get_new_with_minimal_permissions
1043 1043 Role.find(1).update_attribute :permissions, [:add_issues]
1044 1044 Workflow.delete_all :role_id => 1
1045 1045
1046 1046 @request.session[:user_id] = 2
1047 1047 get :new, :project_id => 1, :tracker_id => 1
1048 1048 assert_response :success
1049 1049 assert_template 'new'
1050 1050
1051 1051 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
1052 1052 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1053 1053 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1054 1054 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1055 1055 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1056 1056 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1057 1057 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1058 1058 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1059 1059 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1060 1060 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1061 1061 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1062 1062 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1063 1063 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1064 1064 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1065 1065 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1066 1066 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1067 1067 end
1068 1068
1069 1069 def test_get_new_without_default_start_date_is_creation_date
1070 1070 Setting.default_issue_start_date_to_creation_date = 0
1071 1071
1072 1072 @request.session[:user_id] = 2
1073 1073 get :new, :project_id => 1, :tracker_id => 1
1074 1074 assert_response :success
1075 1075 assert_template 'new'
1076 1076
1077 1077 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1078 1078 :value => nil }
1079 1079 end
1080 1080
1081 1081 def test_get_new_with_default_start_date_is_creation_date
1082 1082 Setting.default_issue_start_date_to_creation_date = 1
1083 1083
1084 1084 @request.session[:user_id] = 2
1085 1085 get :new, :project_id => 1, :tracker_id => 1
1086 1086 assert_response :success
1087 1087 assert_template 'new'
1088 1088
1089 1089 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1090 1090 :value => Date.today.to_s }
1091 1091 end
1092 1092
1093 1093 def test_get_new_form_should_allow_attachment_upload
1094 1094 @request.session[:user_id] = 2
1095 1095 get :new, :project_id => 1, :tracker_id => 1
1096 1096
1097 1097 assert_tag :tag => 'form',
1098 1098 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
1099 1099 :descendant => {
1100 1100 :tag => 'input',
1101 1101 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
1102 1102 }
1103 1103 end
1104 1104
1105 1105 def test_get_new_without_tracker_id
1106 1106 @request.session[:user_id] = 2
1107 1107 get :new, :project_id => 1
1108 1108 assert_response :success
1109 1109 assert_template 'new'
1110 1110
1111 1111 issue = assigns(:issue)
1112 1112 assert_not_nil issue
1113 1113 assert_equal Project.find(1).trackers.first, issue.tracker
1114 1114 end
1115 1115
1116 1116 def test_get_new_with_no_default_status_should_display_an_error
1117 1117 @request.session[:user_id] = 2
1118 1118 IssueStatus.delete_all
1119 1119
1120 1120 get :new, :project_id => 1
1121 1121 assert_response 500
1122 1122 assert_error_tag :content => /No default issue/
1123 1123 end
1124 1124
1125 1125 def test_get_new_with_no_tracker_should_display_an_error
1126 1126 @request.session[:user_id] = 2
1127 1127 Tracker.delete_all
1128 1128
1129 1129 get :new, :project_id => 1
1130 1130 assert_response 500
1131 1131 assert_error_tag :content => /No tracker/
1132 1132 end
1133 1133
1134 1134 def test_update_new_form
1135 1135 @request.session[:user_id] = 2
1136 1136 xhr :post, :new, :project_id => 1,
1137 1137 :issue => {:tracker_id => 2,
1138 1138 :subject => 'This is the test_new issue',
1139 1139 :description => 'This is the description',
1140 1140 :priority_id => 5}
1141 1141 assert_response :success
1142 1142 assert_template 'attributes'
1143 1143
1144 1144 issue = assigns(:issue)
1145 1145 assert_kind_of Issue, issue
1146 1146 assert_equal 1, issue.project_id
1147 1147 assert_equal 2, issue.tracker_id
1148 1148 assert_equal 'This is the test_new issue', issue.subject
1149 1149 end
1150 1150
1151 1151 def test_post_create
1152 1152 @request.session[:user_id] = 2
1153 1153 assert_difference 'Issue.count' do
1154 1154 post :create, :project_id => 1,
1155 1155 :issue => {:tracker_id => 3,
1156 1156 :status_id => 2,
1157 1157 :subject => 'This is the test_new issue',
1158 1158 :description => 'This is the description',
1159 1159 :priority_id => 5,
1160 1160 :start_date => '2010-11-07',
1161 1161 :estimated_hours => '',
1162 1162 :custom_field_values => {'2' => 'Value for field 2'}}
1163 1163 end
1164 1164 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1165 1165
1166 1166 issue = Issue.find_by_subject('This is the test_new issue')
1167 1167 assert_not_nil issue
1168 1168 assert_equal 2, issue.author_id
1169 1169 assert_equal 3, issue.tracker_id
1170 1170 assert_equal 2, issue.status_id
1171 1171 assert_equal Date.parse('2010-11-07'), issue.start_date
1172 1172 assert_nil issue.estimated_hours
1173 1173 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
1174 1174 assert_not_nil v
1175 1175 assert_equal 'Value for field 2', v.value
1176 1176 end
1177 1177
1178 1178 def test_post_new_with_group_assignment
1179 1179 group = Group.find(11)
1180 1180 project = Project.find(1)
1181 1181 project.members << Member.new(:principal => group, :roles => [Role.first])
1182 1182
1183 1183 with_settings :issue_group_assignment => '1' do
1184 1184 @request.session[:user_id] = 2
1185 1185 assert_difference 'Issue.count' do
1186 1186 post :create, :project_id => project.id,
1187 1187 :issue => {:tracker_id => 3,
1188 1188 :status_id => 1,
1189 1189 :subject => 'This is the test_new_with_group_assignment issue',
1190 1190 :assigned_to_id => group.id}
1191 1191 end
1192 1192 end
1193 1193 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1194 1194
1195 1195 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1196 1196 assert_not_nil issue
1197 1197 assert_equal group, issue.assigned_to
1198 1198 end
1199 1199
1200 1200 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1201 1201 Setting.default_issue_start_date_to_creation_date = 0
1202 1202
1203 1203 @request.session[:user_id] = 2
1204 1204 assert_difference 'Issue.count' do
1205 1205 post :create, :project_id => 1,
1206 1206 :issue => {:tracker_id => 3,
1207 1207 :status_id => 2,
1208 1208 :subject => 'This is the test_new issue',
1209 1209 :description => 'This is the description',
1210 1210 :priority_id => 5,
1211 1211 :estimated_hours => '',
1212 1212 :custom_field_values => {'2' => 'Value for field 2'}}
1213 1213 end
1214 1214 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1215 1215
1216 1216 issue = Issue.find_by_subject('This is the test_new issue')
1217 1217 assert_not_nil issue
1218 1218 assert_nil issue.start_date
1219 1219 end
1220 1220
1221 1221 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1222 1222 Setting.default_issue_start_date_to_creation_date = 1
1223 1223
1224 1224 @request.session[:user_id] = 2
1225 1225 assert_difference 'Issue.count' do
1226 1226 post :create, :project_id => 1,
1227 1227 :issue => {:tracker_id => 3,
1228 1228 :status_id => 2,
1229 1229 :subject => 'This is the test_new issue',
1230 1230 :description => 'This is the description',
1231 1231 :priority_id => 5,
1232 1232 :estimated_hours => '',
1233 1233 :custom_field_values => {'2' => 'Value for field 2'}}
1234 1234 end
1235 1235 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1236 1236
1237 1237 issue = Issue.find_by_subject('This is the test_new issue')
1238 1238 assert_not_nil issue
1239 1239 assert_equal Date.today, issue.start_date
1240 1240 end
1241 1241
1242 1242 def test_post_create_and_continue
1243 1243 @request.session[:user_id] = 2
1244 1244 assert_difference 'Issue.count' do
1245 1245 post :create, :project_id => 1,
1246 1246 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1247 1247 :continue => ''
1248 1248 end
1249 1249
1250 1250 issue = Issue.first(:order => 'id DESC')
1251 1251 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1252 1252 assert_not_nil flash[:notice], "flash was not set"
1253 1253 assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
1254 1254 end
1255 1255
1256 1256 def test_post_create_without_custom_fields_param
1257 1257 @request.session[:user_id] = 2
1258 1258 assert_difference 'Issue.count' do
1259 1259 post :create, :project_id => 1,
1260 1260 :issue => {:tracker_id => 1,
1261 1261 :subject => 'This is the test_new issue',
1262 1262 :description => 'This is the description',
1263 1263 :priority_id => 5}
1264 1264 end
1265 1265 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1266 1266 end
1267 1267
1268 1268 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1269 1269 field = IssueCustomField.find_by_name('Database')
1270 1270 field.update_attribute(:is_required, true)
1271 1271
1272 1272 @request.session[:user_id] = 2
1273 1273 post :create, :project_id => 1,
1274 1274 :issue => {:tracker_id => 1,
1275 1275 :subject => 'This is the test_new issue',
1276 1276 :description => 'This is the description',
1277 1277 :priority_id => 5}
1278 1278 assert_response :success
1279 1279 assert_template 'new'
1280 1280 issue = assigns(:issue)
1281 1281 assert_not_nil issue
1282 1282 assert_equal I18n.translate('activerecord.errors.messages.invalid'),
1283 1283 issue.errors[:custom_values].to_s
1284 1284 end
1285 1285
1286 1286 def test_post_create_with_watchers
1287 1287 @request.session[:user_id] = 2
1288 1288 ActionMailer::Base.deliveries.clear
1289 1289
1290 1290 assert_difference 'Watcher.count', 2 do
1291 1291 post :create, :project_id => 1,
1292 1292 :issue => {:tracker_id => 1,
1293 1293 :subject => 'This is a new issue with watchers',
1294 1294 :description => 'This is the description',
1295 1295 :priority_id => 5,
1296 1296 :watcher_user_ids => ['2', '3']}
1297 1297 end
1298 1298 issue = Issue.find_by_subject('This is a new issue with watchers')
1299 1299 assert_not_nil issue
1300 1300 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1301 1301
1302 1302 # Watchers added
1303 1303 assert_equal [2, 3], issue.watcher_user_ids.sort
1304 1304 assert issue.watched_by?(User.find(3))
1305 1305 # Watchers notified
1306 1306 mail = ActionMailer::Base.deliveries.last
1307 1307 assert_kind_of TMail::Mail, mail
1308 1308 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1309 1309 end
1310 1310
1311 1311 def test_post_create_subissue
1312 1312 @request.session[:user_id] = 2
1313 1313
1314 1314 assert_difference 'Issue.count' do
1315 1315 post :create, :project_id => 1,
1316 1316 :issue => {:tracker_id => 1,
1317 1317 :subject => 'This is a child issue',
1318 1318 :parent_issue_id => 2}
1319 1319 end
1320 1320 issue = Issue.find_by_subject('This is a child issue')
1321 1321 assert_not_nil issue
1322 1322 assert_equal Issue.find(2), issue.parent
1323 1323 end
1324 1324
1325 1325 def test_post_create_subissue_with_non_numeric_parent_id
1326 1326 @request.session[:user_id] = 2
1327 1327
1328 1328 assert_difference 'Issue.count' do
1329 1329 post :create, :project_id => 1,
1330 1330 :issue => {:tracker_id => 1,
1331 1331 :subject => 'This is a child issue',
1332 1332 :parent_issue_id => 'ABC'}
1333 1333 end
1334 1334 issue = Issue.find_by_subject('This is a child issue')
1335 1335 assert_not_nil issue
1336 1336 assert_nil issue.parent
1337 1337 end
1338 1338
1339 1339 def test_post_create_private
1340 1340 @request.session[:user_id] = 2
1341 1341
1342 1342 assert_difference 'Issue.count' do
1343 1343 post :create, :project_id => 1,
1344 1344 :issue => {:tracker_id => 1,
1345 1345 :subject => 'This is a private issue',
1346 1346 :is_private => '1'}
1347 1347 end
1348 1348 issue = Issue.first(:order => 'id DESC')
1349 1349 assert issue.is_private?
1350 1350 end
1351 1351
1352 1352 def test_post_create_private_with_set_own_issues_private_permission
1353 1353 role = Role.find(1)
1354 1354 role.remove_permission! :set_issues_private
1355 1355 role.add_permission! :set_own_issues_private
1356 1356
1357 1357 @request.session[:user_id] = 2
1358 1358
1359 1359 assert_difference 'Issue.count' do
1360 1360 post :create, :project_id => 1,
1361 1361 :issue => {:tracker_id => 1,
1362 1362 :subject => 'This is a private issue',
1363 1363 :is_private => '1'}
1364 1364 end
1365 1365 issue = Issue.first(:order => 'id DESC')
1366 1366 assert issue.is_private?
1367 1367 end
1368 1368
1369 1369 def test_post_create_should_send_a_notification
1370 1370 ActionMailer::Base.deliveries.clear
1371 1371 @request.session[:user_id] = 2
1372 1372 assert_difference 'Issue.count' do
1373 1373 post :create, :project_id => 1,
1374 1374 :issue => {:tracker_id => 3,
1375 1375 :subject => 'This is the test_new issue',
1376 1376 :description => 'This is the description',
1377 1377 :priority_id => 5,
1378 1378 :estimated_hours => '',
1379 1379 :custom_field_values => {'2' => 'Value for field 2'}}
1380 1380 end
1381 1381 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1382 1382
1383 1383 assert_equal 1, ActionMailer::Base.deliveries.size
1384 1384 end
1385 1385
1386 1386 def test_post_create_should_preserve_fields_values_on_validation_failure
1387 1387 @request.session[:user_id] = 2
1388 1388 post :create, :project_id => 1,
1389 1389 :issue => {:tracker_id => 1,
1390 1390 # empty subject
1391 1391 :subject => '',
1392 1392 :description => 'This is a description',
1393 1393 :priority_id => 6,
1394 1394 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
1395 1395 assert_response :success
1396 1396 assert_template 'new'
1397 1397
1398 1398 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
1399 1399 :content => 'This is a description'
1400 1400 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1401 1401 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1402 1402 :value => '6' },
1403 1403 :content => 'High' }
1404 1404 # Custom fields
1405 1405 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
1406 1406 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1407 1407 :value => 'Oracle' },
1408 1408 :content => 'Oracle' }
1409 1409 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
1410 1410 :value => 'Value for field 2'}
1411 1411 end
1412 1412
1413 1413 def test_post_create_should_ignore_non_safe_attributes
1414 1414 @request.session[:user_id] = 2
1415 1415 assert_nothing_raised do
1416 1416 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
1417 1417 end
1418 1418 end
1419 1419
1420 1420 def test_post_create_with_attachment
1421 1421 set_tmp_attachments_directory
1422 1422 @request.session[:user_id] = 2
1423 1423
1424 1424 assert_difference 'Issue.count' do
1425 1425 assert_difference 'Attachment.count' do
1426 1426 post :create, :project_id => 1,
1427 1427 :issue => { :tracker_id => '1', :subject => 'With attachment' },
1428 1428 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1429 1429 end
1430 1430 end
1431 1431
1432 1432 issue = Issue.first(:order => 'id DESC')
1433 1433 attachment = Attachment.first(:order => 'id DESC')
1434 1434
1435 1435 assert_equal issue, attachment.container
1436 1436 assert_equal 2, attachment.author_id
1437 1437 assert_equal 'testfile.txt', attachment.filename
1438 1438 assert_equal 'text/plain', attachment.content_type
1439 1439 assert_equal 'test file', attachment.description
1440 1440 assert_equal 59, attachment.filesize
1441 1441 assert File.exists?(attachment.diskfile)
1442 1442 assert_equal 59, File.size(attachment.diskfile)
1443 1443 end
1444 1444
1445 1445 context "without workflow privilege" do
1446 1446 setup do
1447 1447 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1448 1448 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1449 1449 end
1450 1450
1451 1451 context "#new" do
1452 1452 should "propose default status only" do
1453 1453 get :new, :project_id => 1
1454 1454 assert_response :success
1455 1455 assert_template 'new'
1456 1456 assert_tag :tag => 'select',
1457 1457 :attributes => {:name => 'issue[status_id]'},
1458 1458 :children => {:count => 1},
1459 1459 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
1460 1460 end
1461 1461
1462 1462 should "accept default status" do
1463 1463 assert_difference 'Issue.count' do
1464 1464 post :create, :project_id => 1,
1465 1465 :issue => {:tracker_id => 1,
1466 1466 :subject => 'This is an issue',
1467 1467 :status_id => 1}
1468 1468 end
1469 1469 issue = Issue.last(:order => 'id')
1470 1470 assert_equal IssueStatus.default, issue.status
1471 1471 end
1472 1472
1473 1473 should "ignore unauthorized status" do
1474 1474 assert_difference 'Issue.count' do
1475 1475 post :create, :project_id => 1,
1476 1476 :issue => {:tracker_id => 1,
1477 1477 :subject => 'This is an issue',
1478 1478 :status_id => 3}
1479 1479 end
1480 1480 issue = Issue.last(:order => 'id')
1481 1481 assert_equal IssueStatus.default, issue.status
1482 1482 end
1483 1483 end
1484 1484
1485 1485 context "#update" do
1486 1486 should "ignore status change" do
1487 1487 assert_difference 'Journal.count' do
1488 1488 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1489 1489 end
1490 1490 assert_equal 1, Issue.find(1).status_id
1491 1491 end
1492 1492
1493 1493 should "ignore attributes changes" do
1494 1494 assert_difference 'Journal.count' do
1495 1495 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1496 1496 end
1497 1497 issue = Issue.find(1)
1498 1498 assert_equal "Can't print recipes", issue.subject
1499 1499 assert_nil issue.assigned_to
1500 1500 end
1501 1501 end
1502 1502 end
1503 1503
1504 1504 context "with workflow privilege" do
1505 1505 setup do
1506 1506 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1507 1507 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
1508 1508 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
1509 1509 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1510 1510 end
1511 1511
1512 1512 context "#update" do
1513 1513 should "accept authorized status" do
1514 1514 assert_difference 'Journal.count' do
1515 1515 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1516 1516 end
1517 1517 assert_equal 3, Issue.find(1).status_id
1518 1518 end
1519 1519
1520 1520 should "ignore unauthorized status" do
1521 1521 assert_difference 'Journal.count' do
1522 1522 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1523 1523 end
1524 1524 assert_equal 1, Issue.find(1).status_id
1525 1525 end
1526 1526
1527 1527 should "accept authorized attributes changes" do
1528 1528 assert_difference 'Journal.count' do
1529 1529 put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
1530 1530 end
1531 1531 issue = Issue.find(1)
1532 1532 assert_equal 2, issue.assigned_to_id
1533 1533 end
1534 1534
1535 1535 should "ignore unauthorized attributes changes" do
1536 1536 assert_difference 'Journal.count' do
1537 1537 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
1538 1538 end
1539 1539 issue = Issue.find(1)
1540 1540 assert_equal "Can't print recipes", issue.subject
1541 1541 end
1542 1542 end
1543 1543
1544 1544 context "and :edit_issues permission" do
1545 1545 setup do
1546 1546 Role.anonymous.add_permission! :add_issues, :edit_issues
1547 1547 end
1548 1548
1549 1549 should "accept authorized status" do
1550 1550 assert_difference 'Journal.count' do
1551 1551 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1552 1552 end
1553 1553 assert_equal 3, Issue.find(1).status_id
1554 1554 end
1555 1555
1556 1556 should "ignore unauthorized status" do
1557 1557 assert_difference 'Journal.count' do
1558 1558 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1559 1559 end
1560 1560 assert_equal 1, Issue.find(1).status_id
1561 1561 end
1562 1562
1563 1563 should "accept authorized attributes changes" do
1564 1564 assert_difference 'Journal.count' do
1565 1565 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1566 1566 end
1567 1567 issue = Issue.find(1)
1568 1568 assert_equal "changed", issue.subject
1569 1569 assert_equal 2, issue.assigned_to_id
1570 1570 end
1571 1571 end
1572 1572 end
1573 1573
1574 1574 def test_copy_issue
1575 1575 @request.session[:user_id] = 2
1576 1576 get :new, :project_id => 1, :copy_from => 1
1577 1577 assert_template 'new'
1578 1578 assert_not_nil assigns(:issue)
1579 1579 orig = Issue.find(1)
1580 1580 assert_equal orig.subject, assigns(:issue).subject
1581 1581 end
1582 1582
1583 1583 def test_get_edit
1584 1584 @request.session[:user_id] = 2
1585 1585 get :edit, :id => 1
1586 1586 assert_response :success
1587 1587 assert_template 'edit'
1588 1588 assert_not_nil assigns(:issue)
1589 1589 assert_equal Issue.find(1), assigns(:issue)
1590 1590
1591 1591 # Be sure we don't display inactive IssuePriorities
1592 1592 assert ! IssuePriority.find(15).active?
1593 1593 assert_no_tag :option, :attributes => {:value => '15'},
1594 1594 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1595 1595 end
1596 1596
1597 1597 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
1598 1598 @request.session[:user_id] = 2
1599 1599 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
1600 1600
1601 1601 get :edit, :id => 1
1602 1602 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1603 1603 end
1604 1604
1605 1605 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
1606 1606 @request.session[:user_id] = 2
1607 1607 Role.find_by_name('Manager').remove_permission! :log_time
1608 1608
1609 1609 get :edit, :id => 1
1610 1610 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
1611 1611 end
1612 1612
1613 1613 def test_get_edit_with_params
1614 1614 @request.session[:user_id] = 2
1615 1615 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
1616 1616 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
1617 1617 assert_response :success
1618 1618 assert_template 'edit'
1619 1619
1620 1620 issue = assigns(:issue)
1621 1621 assert_not_nil issue
1622 1622
1623 1623 assert_equal 5, issue.status_id
1624 1624 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
1625 1625 :child => { :tag => 'option',
1626 1626 :content => 'Closed',
1627 1627 :attributes => { :selected => 'selected' } }
1628 1628
1629 1629 assert_equal 7, issue.priority_id
1630 1630 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1631 1631 :child => { :tag => 'option',
1632 1632 :content => 'Urgent',
1633 1633 :attributes => { :selected => 'selected' } }
1634 1634
1635 1635 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
1636 1636 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
1637 1637 :child => { :tag => 'option',
1638 1638 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
1639 1639 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
1640 1640 end
1641 1641
1642 1642 def test_update_edit_form
1643 1643 @request.session[:user_id] = 2
1644 1644 xhr :put, :new, :project_id => 1,
1645 1645 :id => 1,
1646 1646 :issue => {:tracker_id => 2,
1647 1647 :subject => 'This is the test_new issue',
1648 1648 :description => 'This is the description',
1649 1649 :priority_id => 5}
1650 1650 assert_response :success
1651 1651 assert_template 'attributes'
1652 1652
1653 1653 issue = assigns(:issue)
1654 1654 assert_kind_of Issue, issue
1655 1655 assert_equal 1, issue.id
1656 1656 assert_equal 1, issue.project_id
1657 1657 assert_equal 2, issue.tracker_id
1658 1658 assert_equal 'This is the test_new issue', issue.subject
1659 1659 end
1660 1660
1661 1661 def test_update_edit_form_with_project_change
1662 1662 @request.session[:user_id] = 2
1663 1663 xhr :put, :new, :project_id => 1,
1664 1664 :id => 1,
1665 1665 :project_change => '1',
1666 1666 :issue => {:project_id => 2,
1667 1667 :tracker_id => 2,
1668 1668 :subject => 'This is the test_new issue',
1669 1669 :description => 'This is the description',
1670 1670 :priority_id => 5}
1671 1671 assert_response :success
1672 1672 assert_template 'form'
1673 1673
1674 1674 issue = assigns(:issue)
1675 1675 assert_kind_of Issue, issue
1676 1676 assert_equal 1, issue.id
1677 1677 assert_equal 2, issue.project_id
1678 1678 assert_equal 2, issue.tracker_id
1679 1679 assert_equal 'This is the test_new issue', issue.subject
1680 1680 end
1681 1681
1682 1682 def test_update_using_invalid_http_verbs
1683 1683 @request.session[:user_id] = 2
1684 1684 subject = 'Updated by an invalid http verb'
1685 1685
1686 1686 get :update, :id => 1, :issue => {:subject => subject}
1687 1687 assert_not_equal subject, Issue.find(1).subject
1688 1688
1689 1689 post :update, :id => 1, :issue => {:subject => subject}
1690 1690 assert_not_equal subject, Issue.find(1).subject
1691 1691
1692 1692 delete :update, :id => 1, :issue => {:subject => subject}
1693 1693 assert_not_equal subject, Issue.find(1).subject
1694 1694 end
1695 1695
1696 1696 def test_put_update_without_custom_fields_param
1697 1697 @request.session[:user_id] = 2
1698 1698 ActionMailer::Base.deliveries.clear
1699 1699
1700 1700 issue = Issue.find(1)
1701 1701 assert_equal '125', issue.custom_value_for(2).value
1702 1702 old_subject = issue.subject
1703 1703 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1704 1704
1705 1705 assert_difference('Journal.count') do
1706 1706 assert_difference('JournalDetail.count', 2) do
1707 1707 put :update, :id => 1, :issue => {:subject => new_subject,
1708 1708 :priority_id => '6',
1709 1709 :category_id => '1' # no change
1710 1710 }
1711 1711 end
1712 1712 end
1713 1713 assert_redirected_to :action => 'show', :id => '1'
1714 1714 issue.reload
1715 1715 assert_equal new_subject, issue.subject
1716 1716 # Make sure custom fields were not cleared
1717 1717 assert_equal '125', issue.custom_value_for(2).value
1718 1718
1719 1719 mail = ActionMailer::Base.deliveries.last
1720 1720 assert_kind_of TMail::Mail, mail
1721 1721 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
1722 1722 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
1723 1723 end
1724 1724
1725 1725 def test_put_update_with_project_change
1726 1726 @request.session[:user_id] = 2
1727 1727 ActionMailer::Base.deliveries.clear
1728 1728
1729 1729 assert_difference('Journal.count') do
1730 1730 assert_difference('JournalDetail.count', 3) do
1731 1731 put :update, :id => 1, :issue => {:project_id => '2',
1732 1732 :tracker_id => '1', # no change
1733 1733 :priority_id => '6',
1734 1734 :category_id => '3'
1735 1735 }
1736 1736 end
1737 1737 end
1738 1738 assert_redirected_to :action => 'show', :id => '1'
1739 1739 issue = Issue.find(1)
1740 1740 assert_equal 2, issue.project_id
1741 1741 assert_equal 1, issue.tracker_id
1742 1742 assert_equal 6, issue.priority_id
1743 1743 assert_equal 3, issue.category_id
1744 1744
1745 1745 mail = ActionMailer::Base.deliveries.last
1746 1746 assert_not_nil mail
1747 1747 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
1748 1748 assert mail.body.include?("Project changed from eCookbook to OnlineStore")
1749 1749 end
1750 1750
1751 1751 def test_put_update_with_tracker_change
1752 1752 @request.session[:user_id] = 2
1753 1753 ActionMailer::Base.deliveries.clear
1754 1754
1755 1755 assert_difference('Journal.count') do
1756 1756 assert_difference('JournalDetail.count', 2) do
1757 1757 put :update, :id => 1, :issue => {:project_id => '1',
1758 1758 :tracker_id => '2',
1759 1759 :priority_id => '6'
1760 1760 }
1761 1761 end
1762 1762 end
1763 1763 assert_redirected_to :action => 'show', :id => '1'
1764 1764 issue = Issue.find(1)
1765 1765 assert_equal 1, issue.project_id
1766 1766 assert_equal 2, issue.tracker_id
1767 1767 assert_equal 6, issue.priority_id
1768 1768 assert_equal 1, issue.category_id
1769 1769
1770 1770 mail = ActionMailer::Base.deliveries.last
1771 1771 assert_not_nil mail
1772 1772 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
1773 1773 assert mail.body.include?("Tracker changed from Bug to Feature request")
1774 1774 end
1775 1775
1776 1776 def test_put_update_with_custom_field_change
1777 1777 @request.session[:user_id] = 2
1778 1778 issue = Issue.find(1)
1779 1779 assert_equal '125', issue.custom_value_for(2).value
1780 1780
1781 1781 assert_difference('Journal.count') do
1782 1782 assert_difference('JournalDetail.count', 3) do
1783 1783 put :update, :id => 1, :issue => {:subject => 'Custom field change',
1784 1784 :priority_id => '6',
1785 1785 :category_id => '1', # no change
1786 1786 :custom_field_values => { '2' => 'New custom value' }
1787 1787 }
1788 1788 end
1789 1789 end
1790 1790 assert_redirected_to :action => 'show', :id => '1'
1791 1791 issue.reload
1792 1792 assert_equal 'New custom value', issue.custom_value_for(2).value
1793 1793
1794 1794 mail = ActionMailer::Base.deliveries.last
1795 1795 assert_kind_of TMail::Mail, mail
1796 1796 assert mail.body.include?("Searchable field changed from 125 to New custom value")
1797 1797 end
1798 1798
1799 1799 def test_put_update_with_status_and_assignee_change
1800 1800 issue = Issue.find(1)
1801 1801 assert_equal 1, issue.status_id
1802 1802 @request.session[:user_id] = 2
1803 1803 assert_difference('TimeEntry.count', 0) do
1804 1804 put :update,
1805 1805 :id => 1,
1806 1806 :issue => { :status_id => 2, :assigned_to_id => 3 },
1807 1807 :notes => 'Assigned to dlopper',
1808 1808 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
1809 1809 end
1810 1810 assert_redirected_to :action => 'show', :id => '1'
1811 1811 issue.reload
1812 1812 assert_equal 2, issue.status_id
1813 1813 j = Journal.find(:first, :order => 'id DESC')
1814 1814 assert_equal 'Assigned to dlopper', j.notes
1815 1815 assert_equal 2, j.details.size
1816 1816
1817 1817 mail = ActionMailer::Base.deliveries.last
1818 1818 assert mail.body.include?("Status changed from New to Assigned")
1819 1819 # subject should contain the new status
1820 1820 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
1821 1821 end
1822 1822
1823 1823 def test_put_update_with_note_only
1824 1824 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
1825 1825 # anonymous user
1826 1826 put :update,
1827 1827 :id => 1,
1828 1828 :notes => notes
1829 1829 assert_redirected_to :action => 'show', :id => '1'
1830 1830 j = Journal.find(:first, :order => 'id DESC')
1831 1831 assert_equal notes, j.notes
1832 1832 assert_equal 0, j.details.size
1833 1833 assert_equal User.anonymous, j.user
1834 1834
1835 1835 mail = ActionMailer::Base.deliveries.last
1836 1836 assert mail.body.include?(notes)
1837 1837 end
1838 1838
1839 1839 def test_put_update_with_note_and_spent_time
1840 1840 @request.session[:user_id] = 2
1841 1841 spent_hours_before = Issue.find(1).spent_hours
1842 1842 assert_difference('TimeEntry.count') do
1843 1843 put :update,
1844 1844 :id => 1,
1845 1845 :notes => '2.5 hours added',
1846 1846 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
1847 1847 end
1848 1848 assert_redirected_to :action => 'show', :id => '1'
1849 1849
1850 1850 issue = Issue.find(1)
1851 1851
1852 1852 j = Journal.find(:first, :order => 'id DESC')
1853 1853 assert_equal '2.5 hours added', j.notes
1854 1854 assert_equal 0, j.details.size
1855 1855
1856 1856 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
1857 1857 assert_not_nil t
1858 1858 assert_equal 2.5, t.hours
1859 1859 assert_equal spent_hours_before + 2.5, issue.spent_hours
1860 1860 end
1861 1861
1862 1862 def test_put_update_with_attachment_only
1863 1863 set_tmp_attachments_directory
1864 1864
1865 1865 # Delete all fixtured journals, a race condition can occur causing the wrong
1866 1866 # journal to get fetched in the next find.
1867 1867 Journal.delete_all
1868 1868
1869 1869 # anonymous user
1870 1870 assert_difference 'Attachment.count' do
1871 1871 put :update, :id => 1,
1872 1872 :notes => '',
1873 1873 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1874 1874 end
1875 1875
1876 1876 assert_redirected_to :action => 'show', :id => '1'
1877 1877 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
1878 1878 assert j.notes.blank?
1879 1879 assert_equal 1, j.details.size
1880 1880 assert_equal 'testfile.txt', j.details.first.value
1881 1881 assert_equal User.anonymous, j.user
1882 1882
1883 1883 attachment = Attachment.first(:order => 'id DESC')
1884 1884 assert_equal Issue.find(1), attachment.container
1885 1885 assert_equal User.anonymous, attachment.author
1886 1886 assert_equal 'testfile.txt', attachment.filename
1887 1887 assert_equal 'text/plain', attachment.content_type
1888 1888 assert_equal 'test file', attachment.description
1889 1889 assert_equal 59, attachment.filesize
1890 1890 assert File.exists?(attachment.diskfile)
1891 1891 assert_equal 59, File.size(attachment.diskfile)
1892 1892
1893 1893 mail = ActionMailer::Base.deliveries.last
1894 1894 assert mail.body.include?('testfile.txt')
1895 1895 end
1896 1896
1897 1897 def test_put_update_with_attachment_that_fails_to_save
1898 1898 set_tmp_attachments_directory
1899 1899
1900 1900 # Delete all fixtured journals, a race condition can occur causing the wrong
1901 1901 # journal to get fetched in the next find.
1902 1902 Journal.delete_all
1903 1903
1904 1904 # Mock out the unsaved attachment
1905 1905 Attachment.any_instance.stubs(:create).returns(Attachment.new)
1906 1906
1907 1907 # anonymous user
1908 1908 put :update,
1909 1909 :id => 1,
1910 1910 :notes => '',
1911 1911 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
1912 1912 assert_redirected_to :action => 'show', :id => '1'
1913 1913 assert_equal '1 file(s) could not be saved.', flash[:warning]
1914 1914
1915 1915 end if Object.const_defined?(:Mocha)
1916 1916
1917 1917 def test_put_update_with_no_change
1918 1918 issue = Issue.find(1)
1919 1919 issue.journals.clear
1920 1920 ActionMailer::Base.deliveries.clear
1921 1921
1922 1922 put :update,
1923 1923 :id => 1,
1924 1924 :notes => ''
1925 1925 assert_redirected_to :action => 'show', :id => '1'
1926 1926
1927 1927 issue.reload
1928 1928 assert issue.journals.empty?
1929 1929 # No email should be sent
1930 1930 assert ActionMailer::Base.deliveries.empty?
1931 1931 end
1932 1932
1933 1933 def test_put_update_should_send_a_notification
1934 1934 @request.session[:user_id] = 2
1935 1935 ActionMailer::Base.deliveries.clear
1936 1936 issue = Issue.find(1)
1937 1937 old_subject = issue.subject
1938 1938 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
1939 1939
1940 1940 put :update, :id => 1, :issue => {:subject => new_subject,
1941 1941 :priority_id => '6',
1942 1942 :category_id => '1' # no change
1943 1943 }
1944 1944 assert_equal 1, ActionMailer::Base.deliveries.size
1945 1945 end
1946 1946
1947 1947 def test_put_update_with_invalid_spent_time_hours_only
1948 1948 @request.session[:user_id] = 2
1949 1949 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1950 1950
1951 1951 assert_no_difference('Journal.count') do
1952 1952 put :update,
1953 1953 :id => 1,
1954 1954 :notes => notes,
1955 1955 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
1956 1956 end
1957 1957 assert_response :success
1958 1958 assert_template 'edit'
1959 1959
1960 1960 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1961 1961 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1962 1962 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
1963 1963 end
1964 1964
1965 1965 def test_put_update_with_invalid_spent_time_comments_only
1966 1966 @request.session[:user_id] = 2
1967 1967 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
1968 1968
1969 1969 assert_no_difference('Journal.count') do
1970 1970 put :update,
1971 1971 :id => 1,
1972 1972 :notes => notes,
1973 1973 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
1974 1974 end
1975 1975 assert_response :success
1976 1976 assert_template 'edit'
1977 1977
1978 1978 assert_error_tag :descendant => {:content => /Activity can't be blank/}
1979 1979 assert_error_tag :descendant => {:content => /Hours can't be blank/}
1980 1980 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
1981 1981 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
1982 1982 end
1983 1983
1984 1984 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
1985 1985 issue = Issue.find(2)
1986 1986 @request.session[:user_id] = 2
1987 1987
1988 1988 put :update,
1989 1989 :id => issue.id,
1990 1990 :issue => {
1991 1991 :fixed_version_id => 4
1992 1992 }
1993 1993
1994 1994 assert_response :redirect
1995 1995 issue.reload
1996 1996 assert_equal 4, issue.fixed_version_id
1997 1997 assert_not_equal issue.project_id, issue.fixed_version.project_id
1998 1998 end
1999 1999
2000 2000 def test_put_update_should_redirect_back_using_the_back_url_parameter
2001 2001 issue = Issue.find(2)
2002 2002 @request.session[:user_id] = 2
2003 2003
2004 2004 put :update,
2005 2005 :id => issue.id,
2006 2006 :issue => {
2007 2007 :fixed_version_id => 4
2008 2008 },
2009 2009 :back_url => '/issues'
2010 2010
2011 2011 assert_response :redirect
2012 2012 assert_redirected_to '/issues'
2013 2013 end
2014 2014
2015 2015 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
2016 2016 issue = Issue.find(2)
2017 2017 @request.session[:user_id] = 2
2018 2018
2019 2019 put :update,
2020 2020 :id => issue.id,
2021 2021 :issue => {
2022 2022 :fixed_version_id => 4
2023 2023 },
2024 2024 :back_url => 'http://google.com'
2025 2025
2026 2026 assert_response :redirect
2027 2027 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
2028 2028 end
2029 2029
2030 2030 def test_get_bulk_edit
2031 2031 @request.session[:user_id] = 2
2032 2032 get :bulk_edit, :ids => [1, 2]
2033 2033 assert_response :success
2034 2034 assert_template 'bulk_edit'
2035 2035
2036 assert_tag :select, :attributes => {:name => 'issue[project_id]'}
2036 2037 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2037 2038
2038 2039 # Project specific custom field, date type
2039 2040 field = CustomField.find(9)
2040 2041 assert !field.is_for_all?
2041 2042 assert_equal 'date', field.field_format
2042 2043 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2043 2044
2044 2045 # System wide custom field
2045 2046 assert CustomField.find(1).is_for_all?
2046 2047 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
2047 2048
2048 2049 # Be sure we don't display inactive IssuePriorities
2049 2050 assert ! IssuePriority.find(15).active?
2050 2051 assert_no_tag :option, :attributes => {:value => '15'},
2051 2052 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2052 2053 end
2053 2054
2054 2055 def test_get_bulk_edit_on_different_projects
2055 2056 @request.session[:user_id] = 2
2056 2057 get :bulk_edit, :ids => [1, 2, 6]
2057 2058 assert_response :success
2058 2059 assert_template 'bulk_edit'
2059 2060
2060 2061 # Can not set issues from different projects as children of an issue
2061 2062 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2062 2063
2063 2064 # Project specific custom field, date type
2064 2065 field = CustomField.find(9)
2065 2066 assert !field.is_for_all?
2066 2067 assert !field.project_ids.include?(Issue.find(6).project_id)
2067 2068 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2068 2069 end
2069 2070
2070 2071 def test_get_bulk_edit_with_user_custom_field
2071 2072 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
2072 2073
2073 2074 @request.session[:user_id] = 2
2074 2075 get :bulk_edit, :ids => [1, 2]
2075 2076 assert_response :success
2076 2077 assert_template 'bulk_edit'
2077 2078
2078 2079 assert_tag :select,
2079 2080 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
2080 2081 :children => {
2081 2082 :only => {:tag => 'option'},
2082 2083 :count => Project.find(1).users.count + 1
2083 2084 }
2084 2085 end
2085 2086
2086 2087 def test_get_bulk_edit_with_version_custom_field
2087 2088 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
2088 2089
2089 2090 @request.session[:user_id] = 2
2090 2091 get :bulk_edit, :ids => [1, 2]
2091 2092 assert_response :success
2092 2093 assert_template 'bulk_edit'
2093 2094
2094 2095 assert_tag :select,
2095 2096 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
2096 2097 :children => {
2097 2098 :only => {:tag => 'option'},
2098 2099 :count => Project.find(1).shared_versions.count + 1
2099 2100 }
2100 2101 end
2101 2102
2102 2103 def test_bulk_update
2103 2104 @request.session[:user_id] = 2
2104 2105 # update issues priority
2105 2106 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
2106 2107 :issue => {:priority_id => 7,
2107 2108 :assigned_to_id => '',
2108 2109 :custom_field_values => {'2' => ''}}
2109 2110
2110 2111 assert_response 302
2111 2112 # check that the issues were updated
2112 2113 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
2113 2114
2114 2115 issue = Issue.find(1)
2115 2116 journal = issue.journals.find(:first, :order => 'created_on DESC')
2116 2117 assert_equal '125', issue.custom_value_for(2).value
2117 2118 assert_equal 'Bulk editing', journal.notes
2118 2119 assert_equal 1, journal.details.size
2119 2120 end
2120 2121
2121 2122 def test_bulk_update_with_group_assignee
2122 2123 group = Group.find(11)
2123 2124 project = Project.find(1)
2124 2125 project.members << Member.new(:principal => group, :roles => [Role.first])
2125 2126
2126 2127 @request.session[:user_id] = 2
2127 2128 # update issues assignee
2128 2129 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
2129 2130 :issue => {:priority_id => '',
2130 2131 :assigned_to_id => group.id,
2131 2132 :custom_field_values => {'2' => ''}}
2132 2133
2133 2134 assert_response 302
2134 2135 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
2135 2136 end
2136 2137
2137 2138 def test_bulk_update_on_different_projects
2138 2139 @request.session[:user_id] = 2
2139 2140 # update issues priority
2140 2141 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
2141 2142 :issue => {:priority_id => 7,
2142 2143 :assigned_to_id => '',
2143 2144 :custom_field_values => {'2' => ''}}
2144 2145
2145 2146 assert_response 302
2146 2147 # check that the issues were updated
2147 2148 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
2148 2149
2149 2150 issue = Issue.find(1)
2150 2151 journal = issue.journals.find(:first, :order => 'created_on DESC')
2151 2152 assert_equal '125', issue.custom_value_for(2).value
2152 2153 assert_equal 'Bulk editing', journal.notes
2153 2154 assert_equal 1, journal.details.size
2154 2155 end
2155 2156
2156 2157 def test_bulk_update_on_different_projects_without_rights
2157 2158 @request.session[:user_id] = 3
2158 2159 user = User.find(3)
2159 2160 action = { :controller => "issues", :action => "bulk_update" }
2160 2161 assert user.allowed_to?(action, Issue.find(1).project)
2161 2162 assert ! user.allowed_to?(action, Issue.find(6).project)
2162 2163 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
2163 2164 :issue => {:priority_id => 7,
2164 2165 :assigned_to_id => '',
2165 2166 :custom_field_values => {'2' => ''}}
2166 2167 assert_response 403
2167 2168 assert_not_equal "Bulk should fail", Journal.last.notes
2168 2169 end
2169 2170
2170 2171 def test_bullk_update_should_send_a_notification
2171 2172 @request.session[:user_id] = 2
2172 2173 ActionMailer::Base.deliveries.clear
2173 2174 post(:bulk_update,
2174 2175 {
2175 2176 :ids => [1, 2],
2176 2177 :notes => 'Bulk editing',
2177 2178 :issue => {
2178 2179 :priority_id => 7,
2179 2180 :assigned_to_id => '',
2180 2181 :custom_field_values => {'2' => ''}
2181 2182 }
2182 2183 })
2183 2184
2184 2185 assert_response 302
2185 2186 assert_equal 2, ActionMailer::Base.deliveries.size
2186 2187 end
2187 2188
2189 def test_bulk_update_project
2190 @request.session[:user_id] = 2
2191 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
2192 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2193 # Issues moved to project 2
2194 assert_equal 2, Issue.find(1).project_id
2195 assert_equal 2, Issue.find(2).project_id
2196 # No tracker change
2197 assert_equal 1, Issue.find(1).tracker_id
2198 assert_equal 2, Issue.find(2).tracker_id
2199 end
2200
2201 def test_bulk_update_project_on_single_issue_should_follow_when_needed
2202 @request.session[:user_id] = 2
2203 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
2204 assert_redirected_to '/issues/1'
2205 end
2206
2207 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
2208 @request.session[:user_id] = 2
2209 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
2210 assert_redirected_to '/projects/onlinestore/issues'
2211 end
2212
2213 def test_bulk_update_tracker
2214 @request.session[:user_id] = 2
2215 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
2216 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2217 assert_equal 2, Issue.find(1).tracker_id
2218 assert_equal 2, Issue.find(2).tracker_id
2219 end
2220
2188 2221 def test_bulk_update_status
2189 2222 @request.session[:user_id] = 2
2190 2223 # update issues priority
2191 2224 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
2192 2225 :issue => {:priority_id => '',
2193 2226 :assigned_to_id => '',
2194 2227 :status_id => '5'}
2195 2228
2196 2229 assert_response 302
2197 2230 issue = Issue.find(1)
2198 2231 assert issue.closed?
2199 2232 end
2200 2233
2234 def test_bulk_update_priority
2235 @request.session[:user_id] = 2
2236 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
2237
2238 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2239 assert_equal 6, Issue.find(1).priority_id
2240 assert_equal 6, Issue.find(2).priority_id
2241 end
2242
2243 def test_bulk_update_with_notes
2244 @request.session[:user_id] = 2
2245 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
2246
2247 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2248 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
2249 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
2250 end
2251
2201 2252 def test_bulk_update_parent_id
2202 2253 @request.session[:user_id] = 2
2203 2254 post :bulk_update, :ids => [1, 3],
2204 2255 :notes => 'Bulk editing parent',
2205 2256 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
2206 2257
2207 2258 assert_response 302
2208 2259 parent = Issue.find(2)
2209 2260 assert_equal parent.id, Issue.find(1).parent_id
2210 2261 assert_equal parent.id, Issue.find(3).parent_id
2211 2262 assert_equal [1, 3], parent.children.collect(&:id).sort
2212 2263 end
2213 2264
2214 2265 def test_bulk_update_custom_field
2215 2266 @request.session[:user_id] = 2
2216 2267 # update issues priority
2217 2268 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
2218 2269 :issue => {:priority_id => '',
2219 2270 :assigned_to_id => '',
2220 2271 :custom_field_values => {'2' => '777'}}
2221 2272
2222 2273 assert_response 302
2223 2274
2224 2275 issue = Issue.find(1)
2225 2276 journal = issue.journals.find(:first, :order => 'created_on DESC')
2226 2277 assert_equal '777', issue.custom_value_for(2).value
2227 2278 assert_equal 1, journal.details.size
2228 2279 assert_equal '125', journal.details.first.old_value
2229 2280 assert_equal '777', journal.details.first.value
2230 2281 end
2231 2282
2232 2283 def test_bulk_update_unassign
2233 2284 assert_not_nil Issue.find(2).assigned_to
2234 2285 @request.session[:user_id] = 2
2235 2286 # unassign issues
2236 2287 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
2237 2288 assert_response 302
2238 2289 # check that the issues were updated
2239 2290 assert_nil Issue.find(2).assigned_to
2240 2291 end
2241 2292
2242 2293 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
2243 2294 @request.session[:user_id] = 2
2244 2295
2245 2296 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
2246 2297
2247 2298 assert_response :redirect
2248 2299 issues = Issue.find([1,2])
2249 2300 issues.each do |issue|
2250 2301 assert_equal 4, issue.fixed_version_id
2251 2302 assert_not_equal issue.project_id, issue.fixed_version.project_id
2252 2303 end
2253 2304 end
2254 2305
2255 2306 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
2256 2307 @request.session[:user_id] = 2
2257 2308 post :bulk_update, :ids => [1,2], :back_url => '/issues'
2258 2309
2259 2310 assert_response :redirect
2260 2311 assert_redirected_to '/issues'
2261 2312 end
2262 2313
2263 2314 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
2264 2315 @request.session[:user_id] = 2
2265 2316 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
2266 2317
2267 2318 assert_response :redirect
2268 2319 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
2269 2320 end
2270 2321
2271 2322 def test_destroy_issue_with_no_time_entries
2272 2323 assert_nil TimeEntry.find_by_issue_id(2)
2273 2324 @request.session[:user_id] = 2
2274 2325 delete :destroy, :id => 2
2275 2326 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2276 2327 assert_nil Issue.find_by_id(2)
2277 2328 end
2278 2329
2279 2330 def test_destroy_issues_with_time_entries
2280 2331 @request.session[:user_id] = 2
2281 2332 delete :destroy, :ids => [1, 3]
2282 2333 assert_response :success
2283 2334 assert_template 'destroy'
2284 2335 assert_not_nil assigns(:hours)
2285 2336 assert Issue.find_by_id(1) && Issue.find_by_id(3)
2286 2337 end
2287 2338
2288 2339 def test_destroy_issues_and_destroy_time_entries
2289 2340 @request.session[:user_id] = 2
2290 2341 delete :destroy, :ids => [1, 3], :todo => 'destroy'
2291 2342 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2292 2343 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2293 2344 assert_nil TimeEntry.find_by_id([1, 2])
2294 2345 end
2295 2346
2296 2347 def test_destroy_issues_and_assign_time_entries_to_project
2297 2348 @request.session[:user_id] = 2
2298 2349 delete :destroy, :ids => [1, 3], :todo => 'nullify'
2299 2350 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2300 2351 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2301 2352 assert_nil TimeEntry.find(1).issue_id
2302 2353 assert_nil TimeEntry.find(2).issue_id
2303 2354 end
2304 2355
2305 2356 def test_destroy_issues_and_reassign_time_entries_to_another_issue
2306 2357 @request.session[:user_id] = 2
2307 2358 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
2308 2359 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
2309 2360 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
2310 2361 assert_equal 2, TimeEntry.find(1).issue_id
2311 2362 assert_equal 2, TimeEntry.find(2).issue_id
2312 2363 end
2313 2364
2314 2365 def test_destroy_issues_from_different_projects
2315 2366 @request.session[:user_id] = 2
2316 2367 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
2317 2368 assert_redirected_to :controller => 'issues', :action => 'index'
2318 2369 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
2319 2370 end
2320 2371
2321 2372 def test_destroy_parent_and_child_issues
2322 2373 parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
2323 2374 child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
2324 2375 assert child.is_descendant_of?(parent.reload)
2325 2376
2326 2377 @request.session[:user_id] = 2
2327 2378 assert_difference 'Issue.count', -2 do
2328 2379 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
2329 2380 end
2330 2381 assert_response 302
2331 2382 end
2332 2383
2333 2384 def test_default_search_scope
2334 2385 get :index
2335 2386 assert_tag :div, :attributes => {:id => 'quick-search'},
2336 2387 :child => {:tag => 'form',
2337 2388 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
2338 2389 end
2339 2390 end
@@ -1,131 +1,136
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../../test_helper', __FILE__)
19 19
20 20 class RoutingIssuesTest < ActionController::IntegrationTest
21 21 def test_issues_rest_actions
22 22 assert_routing(
23 23 { :method => 'get', :path => "/issues" },
24 24 { :controller => 'issues', :action => 'index' }
25 25 )
26 26 assert_routing(
27 27 { :method => 'get', :path => "/issues.pdf" },
28 28 { :controller => 'issues', :action => 'index', :format => 'pdf' }
29 29 )
30 30 assert_routing(
31 31 { :method => 'get', :path => "/issues.atom" },
32 32 { :controller => 'issues', :action => 'index', :format => 'atom' }
33 33 )
34 34 assert_routing(
35 35 { :method => 'get', :path => "/issues.xml" },
36 36 { :controller => 'issues', :action => 'index', :format => 'xml' }
37 37 )
38 38 assert_routing(
39 39 { :method => 'get', :path => "/issues/64" },
40 40 { :controller => 'issues', :action => 'show', :id => '64' }
41 41 )
42 42 assert_routing(
43 43 { :method => 'get', :path => "/issues/64.pdf" },
44 44 { :controller => 'issues', :action => 'show', :id => '64',
45 45 :format => 'pdf' }
46 46 )
47 47 assert_routing(
48 48 { :method => 'get', :path => "/issues/64.atom" },
49 49 { :controller => 'issues', :action => 'show', :id => '64',
50 50 :format => 'atom' }
51 51 )
52 52 assert_routing(
53 53 { :method => 'get', :path => "/issues/64.xml" },
54 54 { :controller => 'issues', :action => 'show', :id => '64',
55 55 :format => 'xml' }
56 56 )
57 57 assert_routing(
58 58 { :method => 'post', :path => "/issues.xml" },
59 59 { :controller => 'issues', :action => 'create', :format => 'xml' }
60 60 )
61 61 assert_routing(
62 62 { :method => 'get', :path => "/issues/64/edit" },
63 63 { :controller => 'issues', :action => 'edit', :id => '64' }
64 64 )
65 65 assert_routing(
66 66 { :method => 'put', :path => "/issues/1.xml" },
67 67 { :controller => 'issues', :action => 'update', :id => '1',
68 68 :format => 'xml' }
69 69 )
70 70 assert_routing(
71 71 { :method => 'delete', :path => "/issues/1.xml" },
72 72 { :controller => 'issues', :action => 'destroy', :id => '1',
73 73 :format => 'xml' }
74 74 )
75 75 end
76 76
77 77 def test_issues_rest_actions_scoped_under_project
78 78 assert_routing(
79 79 { :method => 'get', :path => "/projects/23/issues" },
80 80 { :controller => 'issues', :action => 'index', :project_id => '23' }
81 81 )
82 82 assert_routing(
83 83 { :method => 'get', :path => "/projects/23/issues.pdf" },
84 84 { :controller => 'issues', :action => 'index', :project_id => '23',
85 85 :format => 'pdf' }
86 86 )
87 87 assert_routing(
88 88 { :method => 'get', :path => "/projects/23/issues.atom" },
89 89 { :controller => 'issues', :action => 'index', :project_id => '23',
90 90 :format => 'atom' }
91 91 )
92 92 assert_routing(
93 93 { :method => 'get', :path => "/projects/23/issues.xml" },
94 94 { :controller => 'issues', :action => 'index', :project_id => '23',
95 95 :format => 'xml' }
96 96 )
97 97 assert_routing(
98 98 { :method => 'post', :path => "/projects/23/issues" },
99 99 { :controller => 'issues', :action => 'create', :project_id => '23' }
100 100 )
101 101 assert_routing(
102 102 { :method => 'get', :path => "/projects/23/issues/new" },
103 103 { :controller => 'issues', :action => 'new', :project_id => '23' }
104 104 )
105 105 end
106 106
107 107 def test_issues_form_update
108 108 ["post", "put"].each do |method|
109 109 assert_routing(
110 110 { :method => method, :path => "/projects/23/issues/new" },
111 111 { :controller => 'issues', :action => 'new', :project_id => '23' }
112 112 )
113 113 end
114 114 end
115 115
116 116 def test_issues_extra_actions
117 117 assert_routing(
118 118 { :method => 'get', :path => "/projects/23/issues/64/copy" },
119 119 { :controller => 'issues', :action => 'new', :project_id => '23',
120 120 :copy_from => '64' }
121 121 )
122 122 assert_routing(
123 123 { :method => 'get', :path => "/issues/bulk_edit" },
124 124 { :controller => 'issues', :action => 'bulk_edit' }
125 125 )
126 # For updating the bulk edit form
127 assert_routing(
128 { :method => 'post', :path => "/issues/bulk_edit" },
129 { :controller => 'issues', :action => 'bulk_edit' }
130 )
126 131 assert_routing(
127 132 { :method => 'post', :path => "/issues/bulk_update" },
128 133 { :controller => 'issues', :action => 'bulk_update' }
129 134 )
130 135 end
131 136 end
General Comments 0
You need to be logged in to leave comments. Login now