##// END OF EJS Templates
code layout clean up test/functional/attachments_controller_test.rb...
Toshi MARUYAMA -
r7697:d2811171fd96
parent child
Show More
@@ -1,170 +1,170
1 # encoding: utf-8
1 # encoding: utf-8
2 #
2 #
3 # Redmine - project management software
3 # Redmine - project management software
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
5 #
5 #
6 # This program is free software; you can redistribute it and/or
6 # This program is free software; you can redistribute it and/or
7 # modify it under the terms of the GNU General Public License
7 # modify it under the terms of the GNU General Public License
8 # as published by the Free Software Foundation; either version 2
8 # as published by the Free Software Foundation; either version 2
9 # of the License, or (at your option) any later version.
9 # of the License, or (at your option) any later version.
10 #
10 #
11 # This program is distributed in the hope that it will be useful,
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
14 # GNU General Public License for more details.
15 #
15 #
16 # You should have received a copy of the GNU General Public License
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19
19
20 require File.expand_path('../../test_helper', __FILE__)
20 require File.expand_path('../../test_helper', __FILE__)
21 require 'attachments_controller'
21 require 'attachments_controller'
22
22
23 # Re-raise errors caught by the controller.
23 # Re-raise errors caught by the controller.
24 class AttachmentsController; def rescue_action(e) raise e end; end
24 class AttachmentsController; def rescue_action(e) raise e end; end
25
25
26
27 class AttachmentsControllerTest < ActionController::TestCase
26 class AttachmentsControllerTest < ActionController::TestCase
28 fixtures :users, :projects, :roles, :members, :member_roles, :enabled_modules, :issues, :trackers, :attachments,
27 fixtures :users, :projects, :roles, :members, :member_roles,
28 :enabled_modules, :issues, :trackers, :attachments,
29 :versions, :wiki_pages, :wikis, :documents
29 :versions, :wiki_pages, :wikis, :documents
30
30
31 def setup
31 def setup
32 @controller = AttachmentsController.new
32 @controller = AttachmentsController.new
33 @request = ActionController::TestRequest.new
33 @request = ActionController::TestRequest.new
34 @response = ActionController::TestResponse.new
34 @response = ActionController::TestResponse.new
35 Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
35 Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
36 User.current = nil
36 User.current = nil
37 end
37 end
38
38
39 def test_show_diff
39 def test_show_diff
40 get :show, :id => 14 # 060719210727_changeset_utf8.diff
40 get :show, :id => 14 # 060719210727_changeset_utf8.diff
41 assert_response :success
41 assert_response :success
42 assert_template 'diff'
42 assert_template 'diff'
43 assert_equal 'text/html', @response.content_type
43 assert_equal 'text/html', @response.content_type
44
44
45 assert_tag 'th',
45 assert_tag 'th',
46 :attributes => {:class => /filename/},
46 :attributes => {:class => /filename/},
47 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
47 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
48 assert_tag 'td',
48 assert_tag 'td',
49 :attributes => {:class => /line-code/},
49 :attributes => {:class => /line-code/},
50 :content => /Demande créée avec succès/
50 :content => /Demande créée avec succès/
51 end
51 end
52
52
53 def test_show_diff_should_strip_non_utf8_content
53 def test_show_diff_should_strip_non_utf8_content
54 get :show, :id => 5 # 060719210727_changeset_iso8859-1.diff
54 get :show, :id => 5 # 060719210727_changeset_iso8859-1.diff
55 assert_response :success
55 assert_response :success
56 assert_template 'diff'
56 assert_template 'diff'
57 assert_equal 'text/html', @response.content_type
57 assert_equal 'text/html', @response.content_type
58
58
59 assert_tag 'th',
59 assert_tag 'th',
60 :attributes => {:class => /filename/},
60 :attributes => {:class => /filename/},
61 :content => /issues_controller.rb\t\(rvision 1484\)/
61 :content => /issues_controller.rb\t\(rvision 1484\)/
62 assert_tag 'td',
62 assert_tag 'td',
63 :attributes => {:class => /line-code/},
63 :attributes => {:class => /line-code/},
64 :content => /Demande cre avec succs/
64 :content => /Demande cre avec succs/
65 end
65 end
66
66
67 def test_show_text_file
67 def test_show_text_file
68 get :show, :id => 4
68 get :show, :id => 4
69 assert_response :success
69 assert_response :success
70 assert_template 'file'
70 assert_template 'file'
71 assert_equal 'text/html', @response.content_type
71 assert_equal 'text/html', @response.content_type
72 end
72 end
73
73
74 def test_show_text_file_should_send_if_too_big
74 def test_show_text_file_should_send_if_too_big
75 Setting.file_max_size_displayed = 512
75 Setting.file_max_size_displayed = 512
76 Attachment.find(4).update_attribute :filesize, 754.kilobyte
76 Attachment.find(4).update_attribute :filesize, 754.kilobyte
77
77
78 get :show, :id => 4
78 get :show, :id => 4
79 assert_response :success
79 assert_response :success
80 assert_equal 'application/x-ruby', @response.content_type
80 assert_equal 'application/x-ruby', @response.content_type
81 end
81 end
82
82
83 def test_show_other
83 def test_show_other
84 get :show, :id => 6
84 get :show, :id => 6
85 assert_response :success
85 assert_response :success
86 assert_equal 'application/octet-stream', @response.content_type
86 assert_equal 'application/octet-stream', @response.content_type
87 end
87 end
88
88
89 def test_show_file_from_private_issue_without_permission
89 def test_show_file_from_private_issue_without_permission
90 get :show, :id => 15
90 get :show, :id => 15
91 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
91 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
92 end
92 end
93
93
94 def test_show_file_from_private_issue_with_permission
94 def test_show_file_from_private_issue_with_permission
95 @request.session[:user_id] = 2
95 @request.session[:user_id] = 2
96 get :show, :id => 15
96 get :show, :id => 15
97 assert_response :success
97 assert_response :success
98 assert_tag 'h2', :content => /private.diff/
98 assert_tag 'h2', :content => /private.diff/
99 end
99 end
100
100
101 def test_download_text_file
101 def test_download_text_file
102 get :download, :id => 4
102 get :download, :id => 4
103 assert_response :success
103 assert_response :success
104 assert_equal 'application/x-ruby', @response.content_type
104 assert_equal 'application/x-ruby', @response.content_type
105 end
105 end
106
106
107 def test_download_should_assign_content_type_if_blank
107 def test_download_should_assign_content_type_if_blank
108 Attachment.find(4).update_attribute(:content_type, '')
108 Attachment.find(4).update_attribute(:content_type, '')
109
109
110 get :download, :id => 4
110 get :download, :id => 4
111 assert_response :success
111 assert_response :success
112 assert_equal 'text/x-ruby', @response.content_type
112 assert_equal 'text/x-ruby', @response.content_type
113 end
113 end
114
114
115 def test_download_missing_file
115 def test_download_missing_file
116 get :download, :id => 2
116 get :download, :id => 2
117 assert_response 404
117 assert_response 404
118 end
118 end
119
119
120 def test_anonymous_on_private_private
120 def test_anonymous_on_private_private
121 get :download, :id => 7
121 get :download, :id => 7
122 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
122 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
123 end
123 end
124
124
125 def test_destroy_issue_attachment
125 def test_destroy_issue_attachment
126 issue = Issue.find(3)
126 issue = Issue.find(3)
127 @request.session[:user_id] = 2
127 @request.session[:user_id] = 2
128
128
129 assert_difference 'issue.attachments.count', -1 do
129 assert_difference 'issue.attachments.count', -1 do
130 post :destroy, :id => 1
130 post :destroy, :id => 1
131 end
131 end
132 # no referrer
132 # no referrer
133 assert_redirected_to '/projects/ecookbook'
133 assert_redirected_to '/projects/ecookbook'
134 assert_nil Attachment.find_by_id(1)
134 assert_nil Attachment.find_by_id(1)
135 j = issue.journals.find(:first, :order => 'created_on DESC')
135 j = issue.journals.find(:first, :order => 'created_on DESC')
136 assert_equal 'attachment', j.details.first.property
136 assert_equal 'attachment', j.details.first.property
137 assert_equal '1', j.details.first.prop_key
137 assert_equal '1', j.details.first.prop_key
138 assert_equal 'error281.txt', j.details.first.old_value
138 assert_equal 'error281.txt', j.details.first.old_value
139 end
139 end
140
140
141 def test_destroy_wiki_page_attachment
141 def test_destroy_wiki_page_attachment
142 @request.session[:user_id] = 2
142 @request.session[:user_id] = 2
143 assert_difference 'Attachment.count', -1 do
143 assert_difference 'Attachment.count', -1 do
144 post :destroy, :id => 3
144 post :destroy, :id => 3
145 assert_response 302
145 assert_response 302
146 end
146 end
147 end
147 end
148
148
149 def test_destroy_project_attachment
149 def test_destroy_project_attachment
150 @request.session[:user_id] = 2
150 @request.session[:user_id] = 2
151 assert_difference 'Attachment.count', -1 do
151 assert_difference 'Attachment.count', -1 do
152 post :destroy, :id => 8
152 post :destroy, :id => 8
153 assert_response 302
153 assert_response 302
154 end
154 end
155 end
155 end
156
156
157 def test_destroy_version_attachment
157 def test_destroy_version_attachment
158 @request.session[:user_id] = 2
158 @request.session[:user_id] = 2
159 assert_difference 'Attachment.count', -1 do
159 assert_difference 'Attachment.count', -1 do
160 post :destroy, :id => 9
160 post :destroy, :id => 9
161 assert_response 302
161 assert_response 302
162 end
162 end
163 end
163 end
164
164
165 def test_destroy_without_permission
165 def test_destroy_without_permission
166 post :destroy, :id => 3
166 post :destroy, :id => 3
167 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdestroy%2F3'
167 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdestroy%2F3'
168 assert Attachment.find_by_id(3)
168 assert Attachment.find_by_id(3)
169 end
169 end
170 end
170 end
General Comments 0
You need to be logged in to leave comments. Login now