jro_apps/redmine Commit - r3883:d1a9f81fc6d1

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class IssuesController < ApplicationController

18

class IssuesController < ApplicationController

19

menu_item :new_issue, :only => [:new, :create]

19

menu_item :new_issue, :only => [:new, :create]

20

default_search_scope :issues

20

default_search_scope :issues

21

22

before_filter :find_issue, :only => [:show, :edit, :update]

22

before_filter :find_issue, :only => [:show, :edit, :update]

23

before_filter :find_issues, :only => [:bulk_edit, :move, :perform_move, :destroy]

23

before_filter :find_issues, :only => [:bulk_edit, :move, :perform_move, :destroy]

24

before_filter :find_project, :only => [:new, :create, :update_form, ~~:preview~~]

24

before_filter :find_project, :only => [:new, :create, :update_form]

25

before_filter :authorize, :except => [:index, :changes, ~~:preview~~, :context_menu]

25

before_filter :authorize, :except => [:index, :changes, :context_menu]

26

before_filter :find_optional_project, :only => [:index, :changes]

26

before_filter :find_optional_project, :only => [:index, :changes]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

29

accept_key_auth :index, :show, :changes

29

accept_key_auth :index, :show, :changes

30

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

32

33

helper :journals

33

helper :journals

34

helper :projects

34

helper :projects

35

include ProjectsHelper

35

include ProjectsHelper

36

helper :custom_fields

36

helper :custom_fields

37

include CustomFieldsHelper

37

include CustomFieldsHelper

38

helper :issue_relations

38

helper :issue_relations

39

include IssueRelationsHelper

39

include IssueRelationsHelper

40

helper :watchers

40

helper :watchers

41

include WatchersHelper

41

include WatchersHelper

42

helper :attachments

42

helper :attachments

43

include AttachmentsHelper

43

include AttachmentsHelper

44

helper :queries

44

helper :queries

45

include QueriesHelper

45

include QueriesHelper

46

helper :sort

46

helper :sort

47

include SortHelper

47

include SortHelper

48

include IssuesHelper

48

include IssuesHelper

49

helper :timelog

49

helper :timelog

50

include Redmine::Export::PDF

50

include Redmine::Export::PDF

51

52

verify :method => [:post, :delete],

52

verify :method => [:post, :delete],

53

:only => :destroy,

53

:only => :destroy,

54

:render => { :nothing => true, :status => :method_not_allowed }

54

:render => { :nothing => true, :status => :method_not_allowed }

55

56

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

56

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

57

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

57

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

58

59

def index

59

def index

60

retrieve_query

60

retrieve_query

61

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

61

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

62

sort_update(@query.sortable_columns)

62

sort_update(@query.sortable_columns)

63

64

if @query.valid?

64

if @query.valid?

65

limit = case params[:format]

65

limit = case params[:format]

66

when 'csv', 'pdf'

66

when 'csv', 'pdf'

67

Setting.issues_export_limit.to_i

67

Setting.issues_export_limit.to_i

68

when 'atom'

68

when 'atom'

69

Setting.feeds_limit.to_i

69

Setting.feeds_limit.to_i

70

else

70

else

71

per_page_option

71

per_page_option

72

end

72

end

73

74

@issue_count = @query.issue_count

74

@issue_count = @query.issue_count

75

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

75

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

76

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

76

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

77

:order => sort_clause,

77

:order => sort_clause,

78

:offset => @issue_pages.current.offset,

78

:offset => @issue_pages.current.offset,

79

:limit => limit)

79

:limit => limit)

80

@issue_count_by_group = @query.issue_count_by_group

80

@issue_count_by_group = @query.issue_count_by_group

81

82

respond_to do |format|

82

respond_to do |format|

83

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

83

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

84

format.xml { render :layout => false }

84

format.xml { render :layout => false }

85

format.json { render :text => @issues.to_json, :layout => false }

85

format.json { render :text => @issues.to_json, :layout => false }

86

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

86

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

87

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

87

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

88

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

88

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

89

end

89

end

90

else

90

else

91

# Send html if the query is not valid

91

# Send html if the query is not valid

92

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

92

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

93

end

93

end

94

rescue ActiveRecord::RecordNotFound

94

rescue ActiveRecord::RecordNotFound

95

render_404

95

render_404

96

end

96

end

97

98

def changes

98

def changes

99

retrieve_query

99

retrieve_query

100

sort_init 'id', 'desc'

100

sort_init 'id', 'desc'

101

sort_update(@query.sortable_columns)

101

sort_update(@query.sortable_columns)

102

103

if @query.valid?

103

if @query.valid?

104

@journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",

104

@journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",

105

:limit => 25)

105

:limit => 25)

106

end

106

end

107

@title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)

107

@title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)

108

render :layout => false, :content_type => 'application/atom+xml'

108

render :layout => false, :content_type => 'application/atom+xml'

109

rescue ActiveRecord::RecordNotFound

109

rescue ActiveRecord::RecordNotFound

110

render_404

110

render_404

111

end

111

end

112

113

def show

113

def show

114

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

114

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

115

@journals.each_with_index {|j,i| j.indice = i+1}

115

@journals.each_with_index {|j,i| j.indice = i+1}

116

@journals.reverse! if User.current.wants_comments_in_reverse_order?

116

@journals.reverse! if User.current.wants_comments_in_reverse_order?

117

@changesets = @issue.changesets.visible.all

117

@changesets = @issue.changesets.visible.all

118

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

118

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

119

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

119

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

120

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

120

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

121

@priorities = IssuePriority.all

121

@priorities = IssuePriority.all

122

@time_entry = TimeEntry.new

122

@time_entry = TimeEntry.new

123

respond_to do |format|

123

respond_to do |format|

124

format.html { render :template => 'issues/show.rhtml' }

124

format.html { render :template => 'issues/show.rhtml' }

125

format.xml { render :layout => false }

125

format.xml { render :layout => false }

126

format.json { render :text => @issue.to_json, :layout => false }

126

format.json { render :text => @issue.to_json, :layout => false }

127

format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }

127

format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }

128

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

128

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

129

end

129

end

130

end

130

end

131

132

# Add a new issue

132

# Add a new issue

133

# The new issue will be created from an existing one if copy_from parameter is given

133

# The new issue will be created from an existing one if copy_from parameter is given

134

def new

134

def new

135

render :action => 'new', :layout => !request.xhr?

135

render :action => 'new', :layout => !request.xhr?

136

end

136

end

137

138

def create

138

def create

139

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

139

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

140

if @issue.save

140

if @issue.save

141

attachments = Attachment.attach_files(@issue, params[:attachments])

141

attachments = Attachment.attach_files(@issue, params[:attachments])

142

render_attachment_warning_if_needed(@issue)

142

render_attachment_warning_if_needed(@issue)

143

flash[:notice] = l(:notice_successful_create)

143

flash[:notice] = l(:notice_successful_create)

144

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

144

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

145

respond_to do |format|

145

respond_to do |format|

146

format.html {

146

format.html {

147

redirect_to(params[:continue] ? { :action => 'new', :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

147

redirect_to(params[:continue] ? { :action => 'new', :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

148

{ :action => 'show', :id => @issue })

148

{ :action => 'show', :id => @issue })

149

}

149

}

150

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

150

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

151

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

151

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

152

end

152

end

153

return

153

return

154

else

154

else

155

respond_to do |format|

155

respond_to do |format|

156

format.html { render :action => 'new' }

156

format.html { render :action => 'new' }

157

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

157

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

158

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

158

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

159

end

159

end

160

end

160

end

161

end

161

end

162

163

# Attributes that can be updated on workflow transition (without :edit permission)

163

# Attributes that can be updated on workflow transition (without :edit permission)

164

# TODO: make it configurable (at least per role)

164

# TODO: make it configurable (at least per role)

165

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

165

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

166

167

def edit

167

def edit

168

update_issue_from_params

168

update_issue_from_params

169

170

@journal = @issue.current_journal

170

@journal = @issue.current_journal

171

172

respond_to do |format|

172

respond_to do |format|

173

format.html { }

173

format.html { }

174

format.xml { }

174

format.xml { }

175

end

175

end

176

end

176

end

177

178

def update

178

def update

179

update_issue_from_params

179

update_issue_from_params

180

181

if @issue.save_issue_with_child_records(params, @time_entry)

181

if @issue.save_issue_with_child_records(params, @time_entry)

182

render_attachment_warning_if_needed(@issue)

182

render_attachment_warning_if_needed(@issue)

183

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

183

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

184

185

respond_to do |format|

185

respond_to do |format|

186

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

186

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

187

format.xml { head :ok }

187

format.xml { head :ok }

188

format.json { head :ok }

188

format.json { head :ok }

189

end

189

end

190

else

190

else

191

render_attachment_warning_if_needed(@issue)

191

render_attachment_warning_if_needed(@issue)

192

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

192

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

193

@journal = @issue.current_journal

193

@journal = @issue.current_journal

194

195

respond_to do |format|

195

respond_to do |format|

196

format.html { render :action => 'edit' }

196

format.html { render :action => 'edit' }

197

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

197

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

198

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

198

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

199

end

199

end

200

end

200

end

201

end

201

end

202

203

# Bulk edit a set of issues

203

# Bulk edit a set of issues

204

def bulk_edit

204

def bulk_edit

205

@issues.sort!

205

@issues.sort!

206

if request.post?

206

if request.post?

207

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

207

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

208

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

208

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

209

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

209

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

210

211

unsaved_issue_ids = []

211

unsaved_issue_ids = []

212

@issues.each do |issue|

212

@issues.each do |issue|

213

issue.reload

213

issue.reload

214

journal = issue.init_journal(User.current, params[:notes])

214

journal = issue.init_journal(User.current, params[:notes])

215

issue.safe_attributes = attributes

215

issue.safe_attributes = attributes

216

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

216

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

217

unless issue.save

217

unless issue.save

218

# Keep unsaved issue ids to display them in flash error

218

# Keep unsaved issue ids to display them in flash error

219

unsaved_issue_ids << issue.id

219

unsaved_issue_ids << issue.id

220

end

220

end

221

end

221

end

222

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

222

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

223

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

223

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

224

return

224

return

225

end

225

end

226

@available_statuses = Workflow.available_statuses(@project)

226

@available_statuses = Workflow.available_statuses(@project)

227

@custom_fields = @project.all_issue_custom_fields

227

@custom_fields = @project.all_issue_custom_fields

228

end

228

end

229

230

def destroy

230

def destroy

231

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

231

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

232

if @hours > 0

232

if @hours > 0

233

case params[:todo]

233

case params[:todo]

234

when 'destroy'

234

when 'destroy'

235

# nothing to do

235

# nothing to do

236

when 'nullify'

236

when 'nullify'

237

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

237

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

238

when 'reassign'

238

when 'reassign'

239

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

239

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

240

if reassign_to.nil?

240

if reassign_to.nil?

241

flash.now[:error] = l(:error_issue_not_found_in_project)

241

flash.now[:error] = l(:error_issue_not_found_in_project)

242

return

242

return

243

else

243

else

244

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

244

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

245

end

245

end

246

else

246

else

247

unless params[:format] == 'xml' || params[:format] == 'json'

247

unless params[:format] == 'xml' || params[:format] == 'json'

248

# display the destroy form if it's a user request

248

# display the destroy form if it's a user request

249

return

249

return

250

end

250

end

251

end

251

end

252

end

252

end

253

@issues.each(&:destroy)

253

@issues.each(&:destroy)

254

respond_to do |format|

254

respond_to do |format|

255

format.html { redirect_to :action => 'index', :project_id => @project }

255

format.html { redirect_to :action => 'index', :project_id => @project }

256

format.xml { head :ok }

256

format.xml { head :ok }

257

format.json { head :ok }

257

format.json { head :ok }

258

end

258

end

259

end

259

end

260

261

def context_menu

261

def context_menu

262

@issues = Issue.find_all_by_id(params[:ids], :include => :project)

262

@issues = Issue.find_all_by_id(params[:ids], :include => :project)

263

if (@issues.size == 1)

263

if (@issues.size == 1)

264

@issue = @issues.first

264

@issue = @issues.first

265

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

265

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

266

end

266

end

267

projects = @issues.collect(&:project).compact.uniq

267

projects = @issues.collect(&:project).compact.uniq

268

@project = projects.first if projects.size == 1

268

@project = projects.first if projects.size == 1

269

270

@can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),

270

@can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),

271

:log_time => (@project && User.current.allowed_to?(:log_time, @project)),

271

:log_time => (@project && User.current.allowed_to?(:log_time, @project)),

272

:update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),

272

:update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),

273

:move => (@project && User.current.allowed_to?(:move_issues, @project)),

273

:move => (@project && User.current.allowed_to?(:move_issues, @project)),

274

:copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),

274

:copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),

275

:delete => (@project && User.current.allowed_to?(:delete_issues, @project))

275

:delete => (@project && User.current.allowed_to?(:delete_issues, @project))

276

}

276

}

277

if @project

277

if @project

278

@assignables = @project.assignable_users

278

@assignables = @project.assignable_users

279

@assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)

279

@assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)

280

@trackers = @project.trackers

280

@trackers = @project.trackers

281

end

281

end

282

283

@priorities = IssuePriority.all.reverse

283

@priorities = IssuePriority.all.reverse

284

@statuses = IssueStatus.find(:all, :order => 'position')

284

@statuses = IssueStatus.find(:all, :order => 'position')

285

@back = back_url

285

@back = back_url

286

287

render :layout => false

287

render :layout => false

288

end

288

end

289

290

def update_form

290

def update_form

291

if params[:id].blank?

291

if params[:id].blank?

292

@issue = Issue.new

292

@issue = Issue.new

293

@issue.project = @project

293

@issue.project = @project

294

else

294

else

295

@issue = @project.issues.visible.find(params[:id])

295

@issue = @project.issues.visible.find(params[:id])

296

end

296

end

297

@issue.attributes = params[:issue]

297

@issue.attributes = params[:issue]

298

@allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq

298

@allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq

299

@priorities = IssuePriority.all

299

@priorities = IssuePriority.all

300

301

render :partial => 'attributes'

301

render :partial => 'attributes'

302

end

302

end

303

304

private

304

private

305

def find_issue

305

def find_issue

306

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

306

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

307

@project = @issue.project

307

@project = @issue.project

308

rescue ActiveRecord::RecordNotFound

308

rescue ActiveRecord::RecordNotFound

309

render_404

309

render_404

310

end

310

end

311

312

def find_project

312

def find_project

313

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

313

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

314

@project = Project.find(project_id)

314

@project = Project.find(project_id)

315

rescue ActiveRecord::RecordNotFound

315

rescue ActiveRecord::RecordNotFound

316

render_404

316

render_404

317

end

317

end

318

319

# Used by #edit and #update to set some common instance variables

319

# Used by #edit and #update to set some common instance variables

320

# from the params

320

# from the params

321

# TODO: Refactor, not everything in here is needed by #edit

321

# TODO: Refactor, not everything in here is needed by #edit

322

def update_issue_from_params

322

def update_issue_from_params

323

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

323

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

324

@priorities = IssuePriority.all

324

@priorities = IssuePriority.all

325

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

325

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

326

@time_entry = TimeEntry.new

326

@time_entry = TimeEntry.new

327

328

@notes = params[:notes]

328

@notes = params[:notes]

329

@issue.init_journal(User.current, @notes)

329

@issue.init_journal(User.current, @notes)

330

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

330

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

331

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

331

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

332

attrs = params[:issue].dup

332

attrs = params[:issue].dup

333

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

333

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

334

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

334

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

335

@issue.safe_attributes = attrs

335

@issue.safe_attributes = attrs

336

end

336

end

337

338

end

338

end

339

340

# TODO: Refactor, lots of extra code in here

340

# TODO: Refactor, lots of extra code in here

341

def build_new_issue_from_params

341

def build_new_issue_from_params

342

@issue = Issue.new

342

@issue = Issue.new

343

@issue.copy_from(params[:copy_from]) if params[:copy_from]

343

@issue.copy_from(params[:copy_from]) if params[:copy_from]

344

@issue.project = @project

344

@issue.project = @project

345

# Tracker must be set before custom field values

345

# Tracker must be set before custom field values

346

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

346

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

347

if @issue.tracker.nil?

347

if @issue.tracker.nil?

348

render_error l(:error_no_tracker_in_project)

348

render_error l(:error_no_tracker_in_project)

349

return false

349

return false

350

end

350

end

351

if params[:issue].is_a?(Hash)

351

if params[:issue].is_a?(Hash)

352

@issue.safe_attributes = params[:issue]

352

@issue.safe_attributes = params[:issue]

353

@issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)

353

@issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)

354

end

354

end

355

@issue.author = User.current

355

@issue.author = User.current

356

@issue.start_date ||= Date.today

356

@issue.start_date ||= Date.today

357

@priorities = IssuePriority.all

357

@priorities = IssuePriority.all

358

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

358

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

359

end

359

end

360

361

def check_for_default_issue_status

361

def check_for_default_issue_status

362

if IssueStatus.default.nil?

362

if IssueStatus.default.nil?

363

render_error l(:error_no_default_issue_status)

363

render_error l(:error_no_default_issue_status)

364

return false

364

return false

365

end

365

end

366

end

366

end

367

end

367

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
               menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :move, :perform_move, :destroy]
-              before_filter :find_project, :only => [:new, :create, :update_form, :preview]
+              before_filter :find_project, :only => [:new, :create, :update_form]
-              before_filter :authorize, :except => [:index, :changes, :preview, :context_menu]
+              before_filter :authorize, :except => [:index, :changes, :context_menu]
               before_filter :find_optional_project, :only => [:index, :changes]
               before_filter :check_for_default_issue_status, :only => [:new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_key_auth :index, :show, :changes
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               include ProjectsHelper
               helper :custom_fields
               include CustomFieldsHelper
               helper :issue_relations
               include IssueRelationsHelper
               helper :watchers
               include WatchersHelper
               helper :attachments
               include AttachmentsHelper
               helper :queries
               include QueriesHelper
               helper :sort
               include SortHelper
               include IssuesHelper
               helper :timelog
               include Redmine::Export::PDF
               verify :method => [:post, :delete],
                      :only => :destroy,
                      :render => { :nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   limit = case params[:format]
                   when 'csv', 'pdf'
                     Setting.issues_export_limit.to_i
                   when 'atom'
                     Setting.feeds_limit.to_i
                   else
                     per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new self, @issue_count, limit, params['page']
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @issue_pages.current.offset,
                                           :limit => limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
                     format.xml  { render :layout => false }
                     format.json { render :text => @issues.to_json, :layout => false }
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
                     format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                   end
                 else
                   # Send html if the query is not valid
                   render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def changes
                 retrieve_query
                 sort_init 'id', 'desc'
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",
                                               :limit => 25)
                 end
                 @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)
                 render :layout => false, :content_type => 'application/atom+xml'
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.all
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @priorities = IssuePriority.all
                 @time_entry = TimeEntry.new
                 respond_to do |format|
                   format.html { render :template => 'issues/show.rhtml' }
                   format.xml  { render :layout => false }
                   format.json { render :text => @issue.to_json, :layout => false }
                   format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                 end
               end
               # Add a new issue
               # The new issue will be created from an existing one if copy_from parameter is given
               def new
                 render :action => 'new', :layout => !request.xhr?
               end
               def create
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                 if @issue.save
                   attachments = Attachment.attach_files(@issue, params[:attachments])
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_create)
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       redirect_to(params[:continue] ? { :action => 'new', :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
                                   { :action => 'show', :id => @issue })
                     }
                     format.xml  { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
                     format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html { render :action => 'new' }
                     format.xml  { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Attributes that can be updated on workflow transition (without :edit permission)
               # TODO: make it configurable (at least per role)
               UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
               def edit
                 update_issue_from_params
                 @journal = @issue.current_journal
                 respond_to do |format|
                   format.html { }
                   format.xml  { }
                 end
               end
               def update
                 update_issue_from_params
                 if @issue.save_issue_with_child_records(params, @time_entry)
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                     format.xml  { head :ok }
                     format.json  { head :ok }
                   end
                 else
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   @journal = @issue.current_journal
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.xml  { render :xml => @issue.errors, :status => :unprocessable_entity }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Bulk edit a set of issues
               def bulk_edit
                 @issues.sort!
                 if request.post?
                   attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                   attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                   attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                   unsaved_issue_ids = []
                   @issues.each do |issue|
                     issue.reload
                     journal = issue.init_journal(User.current, params[:notes])
                     issue.safe_attributes = attributes
                     call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                     unless issue.save
                       # Keep unsaved issue ids to display them in flash error
                       unsaved_issue_ids << issue.id
                     end
                   end
                   set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
                   redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
                   return
                 end
                 @available_statuses = Workflow.available_statuses(@project)
                 @custom_fields = @project.all_issue_custom_fields
               end
               def destroy
                 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                     end
                   else
                     unless params[:format] == 'xml' || params[:format] == 'json'
                       # display the destroy form if it's a user request
                       return
                     end
                   end
                 end
                 @issues.each(&:destroy)
                 respond_to do |format|
                   format.html { redirect_to :action => 'index', :project_id => @project }
                   format.xml  { head :ok }
                   format.json  { head :ok }
                 end
               end
               def context_menu
                 @issues = Issue.find_all_by_id(params[:ids], :include => :project)
                 if (@issues.size == 1)
                   @issue = @issues.first
                   @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 end
                 projects = @issues.collect(&:project).compact.uniq
                 @project = projects.first if projects.size == 1
                 @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),
                         :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
                         :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),
                         :move => (@project && User.current.allowed_to?(:move_issues, @project)),
                         :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
                         :delete => (@project && User.current.allowed_to?(:delete_issues, @project))
                         }
                 if @project
                   @assignables = @project.assignable_users
                   @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)
                   @trackers = @project.trackers
                 end
                 @priorities = IssuePriority.all.reverse
                 @statuses = IssueStatus.find(:all, :order => 'position')
                 @back = back_url
                 render :layout => false
               end
               def update_form
                 if params[:id].blank?
                   @issue = Issue.new
                   @issue.project = @project
                 else
                   @issue = @project.issues.visible.find(params[:id])
                 end
                 @issue.attributes = params[:issue]
                 @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
                 @priorities = IssuePriority.all
                 render :partial => 'attributes'
               end
             private
               def find_issue
                 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                 @project = @issue.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
                 @project = Project.find(project_id)
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               # TODO: Refactor, not everything in here is needed by #edit
               def update_issue_from_params
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.all
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @time_entry = TimeEntry.new
                 @notes = params[:notes]
                 @issue.init_journal(User.current, @notes)
                 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
                   attrs = params[:issue].dup
                   attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
                   attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
                   @issue.safe_attributes = attrs
                 end
               end
               # TODO: Refactor, lots of extra code in here
               def build_new_issue_from_params
                 @issue = Issue.new
                 @issue.copy_from(params[:copy_from]) if params[:copy_from]
                 @issue.project = @project
                 # Tracker must be set before custom field values
                 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                 if @issue.tracker.nil?
                   render_error l(:error_no_tracker_in_project)
                   return false
                 end
                 if params[:issue].is_a?(Hash)
                   @issue.safe_attributes = params[:issue]
                   @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
                 end
                 @issue.author = User.current
                 @issue.start_date ||= Date.today
                 @priorities = IssuePriority.all
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
               end
               def check_for_default_issue_status
                 if IssueStatus.default.nil?
                   render_error l(:error_no_default_issue_status)
                   return false
                 end
               end
             end