jro_apps/redmine Commit - r11216:d1244b31a4c2

Fixed that requesting a message from an invalid forum should respond with 404 (#13232)....

Jean-Philippe Lang -

r11216:d1244b31a4c2

parent child

Context file:

r11216:d1244b31a4c2

app/controllers/messages_controller.rb +2 -1

             private
               def find_message
-                find_board
+                return unless find_board
                 @message = @board.messages.find(params[:id], :include => :parent)
                 @topic = @message.root
               rescue ActiveRecord::RecordNotFound
                 @project = @board.project
               rescue ActiveRecord::RecordNotFound
                 render_404
+                nil
               end
             end

test/functional/messages_controller_test.rb +5 0

                 assert_response 404
               end
+              def test_show_message_from_invalid_board_should_respond_with_404
+                get :show, :board_id => 999, :id => 1
+                assert_response 404
+              end
               def test_get_new
                 @request.session[:user_id] = 2
                 get :new, :board_id => 1

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages