jro_apps/redmine Commit - r6027:d0d807caf1ef

Do not journalize blank description changes (#8712)....

Jean-Philippe Lang -

r6027:d0d807caf1ef

parent child

Context file:

r6027:d0d807caf1ef

Collapse all files

app/models/issue.rb +4 -1

              # Redmine - project management software
              # Copyright (C) 2006-2011  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Issue < ActiveRecord::Base
                include Redmine::SafeAttributes
                belongs_to :project
                belongs_to :tracker
                belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
                belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
                belongs_to :assigned_to, :class_name => 'User', :foreign_key => 'assigned_to_id'
                belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
                belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
                belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
                has_many :journals, :as => :journalized, :dependent => :destroy
                has_many :time_entries, :dependent => :delete_all
                has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
                has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
                has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
                acts_as_nested_set :scope => 'root_id', :dependent => :destroy
                acts_as_attachable :after_remove => :attachment_removed
                acts_as_customizable
                acts_as_watchable
                acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                   :include => [:project, :journals],
                                   # sort by id so that limited eager loading doesn't break with postgresql
                                   :order_column => "#{table_name}.id"
                acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                              :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                              :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
                acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                          :author_key => :author_id
                DONE_RATIO_OPTIONS = %w(issue_field issue_status)
                attr_reader :current_journal
                validates_presence_of :subject, :priority, :project, :tracker, :author, :status
                validates_length_of :subject, :maximum => 255
                validates_inclusion_of :done_ratio, :in => 0..100
                validates_numericality_of :estimated_hours, :allow_nil => true
                named_scope :visible, lambda {|*args| { :include => :project,
                                                        :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
                named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status
                named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
                named_scope :with_limit, lambda { |limit| { :limit => limit} }
                named_scope :on_active_project, :include => [:status, :project, :tracker],
                                                :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
                named_scope :without_version, lambda {
                  {
                    :conditions => { :fixed_version_id => nil}
                  }
                }
                named_scope :with_query, lambda {|query|
                  {
                    :conditions => Query.merge_conditions(query.statement)
                  }
                }
                before_create :default_assign
                before_save :close_duplicates, :update_done_ratio_from_issue_status
                after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
                after_destroy :update_parent_attributes
                # Returns a SQL conditions string used to find all issues visible by the specified user
                def self.visible_condition(user, options={})
                  Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      nil
                    when 'default'
                      "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id = #{user.id})"
                    when 'own'
                      "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id = #{user.id})"
                    else
                      '1=0'
                    end
                  end
                end
                # Returns true if usr or current user is allowed to view the issue
                def visible?(usr=nil)
                  (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      true
                    when 'default'
                      !self.is_private? || self.author == user || self.assigned_to == user
                    when 'own'
                      self.author == user || self.assigned_to == user
                    else
                      false
                    end
                  end
                end
                def after_initialize
                  if new_record?
                    # set default values for new records only
                    self.status ||= IssueStatus.default
                    self.priority ||= IssuePriority.default
                  end
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
                def available_custom_fields
                  (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
                end
                def copy_from(arg)
                  issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                  self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                  self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                  self.status = issue.status
                  self
                end
                # Moves/copies an issue to a new project and tracker
                # Returns the moved/copied issue on success, false on failure
                def move_to_project(*args)
                  ret = Issue.transaction do
                    move_to_project_without_transaction(*args) || raise(ActiveRecord::Rollback)
                  end || false
                end
                def move_to_project_without_transaction(new_project, new_tracker = nil, options = {})
                  options ||= {}
                  issue = options[:copy] ? self.class.new.copy_from(self) : self
                  if new_project && issue.project_id != new_project.id
                    # delete issue relations
                    unless Setting.cross_project_issue_relations?
                      issue.relations_from.clear
                      issue.relations_to.clear
                    end
                    # issue is moved to another project
                    # reassign to the category with same name if any
                    new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name)
                    issue.category = new_category
                    # Keep the fixed_version if it's still valid in the new_project
                    unless new_project.shared_versions.include?(issue.fixed_version)
                      issue.fixed_version = nil
                    end
                    issue.project = new_project
                    if issue.parent && issue.parent.project_id != issue.project_id
                      issue.parent_issue_id = nil
                    end
                  end
                  if new_tracker
                    issue.tracker = new_tracker
                    issue.reset_custom_values!
                  end
                  if options[:copy]
                    issue.author = User.current
                    issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                    issue.status = if options[:attributes] && options[:attributes][:status_id]
                                     IssueStatus.find_by_id(options[:attributes][:status_id])
                                   else
                                     self.status
                                   end
                  end
                  # Allow bulk setting of attributes on the issue
                  if options[:attributes]
                    issue.attributes = options[:attributes]
                  end
                  if issue.save
                    if options[:copy]
                      if current_journal && current_journal.notes.present?
                        issue.init_journal(current_journal.user, current_journal.notes)
                        issue.current_journal.notify = false
                        issue.save
                      end
                    else
                      # Manually update project_id on related time entries
                      TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
                      issue.children.each do |child|
                        unless child.move_to_project_without_transaction(new_project)
                          # Move failed and transaction was rollback'd
                          return false
                        end
                      end
                    end
                  else
                    return false
                  end
                  issue
                end
                def status_id=(sid)
                  self.status = nil
                  write_attribute(:status_id, sid)
                end
                def priority_id=(pid)
                  self.priority = nil
                  write_attribute(:priority_id, pid)
                end
                def tracker_id=(tid)
                  self.tracker = nil
                  result = write_attribute(:tracker_id, tid)
                  @custom_field_values = nil
                  result
                end
                # Overrides attributes= so that tracker_id gets assigned first
                def attributes_with_tracker_first=(new_attributes, *args)
                  return if new_attributes.nil?
                  new_tracker_id = new_attributes['tracker_id'] || new_attributes[:tracker_id]
                  if new_tracker_id
                    self.tracker_id = new_tracker_id
                  end
                  send :attributes_without_tracker_first=, new_attributes, *args
                end
                # Do not redefine alias chain on reload (see #4838)
                alias_method_chain(:attributes=, :tracker_first) unless method_defined?(:attributes_without_tracker_first=)
                def estimated_hours=(h)
                  write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
                end
                safe_attributes 'tracker_id',
                  'status_id',
                  'parent_issue_id',
                  'category_id',
                  'assigned_to_id',
                  'priority_id',
                  'fixed_version_id',
                  'subject',
                  'description',
                  'start_date',
                  'due_date',
                  'done_ratio',
                  'estimated_hours',
                  'custom_field_values',
                  'custom_fields',
                  'lock_version',
                  :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
                safe_attributes 'status_id',
                  'assigned_to_id',
                  'fixed_version_id',
                  'done_ratio',
                  :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
                safe_attributes 'is_private',
                  :if => lambda {|issue, user|
                    user.allowed_to?(:set_issues_private, issue.project) ||
                      (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                  }
                # Safely sets attributes
                # Should be called from controllers instead of #attributes=
                # attr_accessible is too rough because we still want things like
                # Issue.new(:project => foo) to work
                # TODO: move workflow/permission checks from controllers to here
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                  attrs = delete_unsafe_attributes(attrs, user)
                  return if attrs.empty?
                  # Tracker must be set before since new_statuses_allowed_to depends on it.
                  if t = attrs.delete('tracker_id')
                    self.tracker_id = t
                  end
                  if attrs['status_id']
                    unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
                      attrs.delete('status_id')
                    end
                  end
                  unless leaf?
                    attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                  end
                  if attrs.has_key?('parent_issue_id')
                    if !user.allowed_to?(:manage_subtasks, project)
                      attrs.delete('parent_issue_id')
                    elsif !attrs['parent_issue_id'].blank?
                      attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
                    end
                  end
                  self.attributes = attrs
                end
                def done_ratio
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    status.default_done_ratio
                  else
                    read_attribute(:done_ratio)
                  end
                end
                def self.use_status_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_status'
                end
                def self.use_field_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_field'
                end
                def validate
                  if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
                    errors.add :due_date, :not_a_date
                  end
                  if self.due_date and self.start_date and self.due_date < self.start_date
                    errors.add :due_date, :greater_than_start_date
                  end
                  if start_date && soonest_start && start_date < soonest_start
                    errors.add :start_date, :invalid
                  end
                  if fixed_version
                    if !assignable_versions.include?(fixed_version)
                      errors.add :fixed_version_id, :inclusion
                    elsif reopened? && fixed_version.closed?
                      errors.add_to_base I18n.t(:error_can_not_reopen_issue_on_closed_version)
                    end
                  end
                  # Checks that the issue can not be added/moved to a disabled tracker
                  if project && (tracker_id_changed? || project_id_changed?)
                    unless project.trackers.include?(tracker)
                      errors.add :tracker_id, :inclusion
                    end
                  end
                  # Checks parent issue assignment
                  if @parent_issue
                    if @parent_issue.project_id != project_id
                      errors.add :parent_issue_id, :not_same_project
                    elsif !new_record?
                      # moving an existing issue
                      if @parent_issue.root_id != root_id
                        # we can always move to another tree
                      elsif move_possible?(@parent_issue)
                        # move accepted inside tree
                      else
                        errors.add :parent_issue_id, :not_a_valid_parent
                      end
                    end
                  end
                end
                # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
                # even if the user turns off the setting later
                def update_done_ratio_from_issue_status
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    self.done_ratio = status.default_done_ratio
                  end
                end
                def init_journal(user, notes = "")
                  @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                  @issue_before_change = self.clone
                  @issue_before_change.status = self.status
                  @custom_values_before_change = {}
                  self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                  # Make sure updated_on is updated when adding a note.
                  updated_on_will_change!
                  @current_journal
                end
                # Return true if the issue is closed, otherwise false
                def closed?
                  self.status.is_closed?
                end
                # Return true if the issue is being reopened
                def reopened?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Return true if the issue is being closed
                def closing?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Returns true if the issue is overdue
                def overdue?
                  !due_date.nil? && (due_date < Date.today) && !status.is_closed?
                end
                # Is the amount of work done less than it should for the due date
                def behind_schedule?
                  return false if start_date.nil? || due_date.nil?
                  done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                  return done_date <= Date.today
                end
                # Does this issue have children?
                def children?
                  !leaf?
                end
                # Users the issue can be assigned to
                def assignable_users
                  users = project.assignable_users
                  users << author if author
                  users.uniq.sort
                end
                # Versions that the issue can be assigned to
                def assignable_versions
                  @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
                end
                # Returns true if this issue is blocked by another issue that is still open
                def blocked?
                  !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
                end
                # Returns an array of status that user is able to apply
                def new_statuses_allowed_to(user, include_default=false)
                  statuses = status.find_new_statuses_allowed_to(
                    user.roles_for_project(project),
                    tracker,
                    author == user,
                    assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                    )
                  statuses << status unless statuses.empty?
                  statuses << IssueStatus.default if include_default
                  statuses = statuses.uniq.sort
                  blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                end
                # Returns the mail adresses of users that should be notified
                def recipients
                  notified = project.notified_users
                  # Author and assignee are always notified unless they have been
                  # locked or don't want to be notified
                  notified << author if author && author.active? && author.notify_about?(self)
                  notified << assigned_to if assigned_to && assigned_to.active? && assigned_to.notify_about?(self)
                  notified.uniq!
                  # Remove users that can not view the issue
                  notified.reject! {|user| !visible?(user)}
                  notified.collect(&:mail)
                end
                # Returns the total number of hours spent on this issue and its descendants
                #
                # Example:
                #   spent_hours => 0.0
                #   spent_hours => 50.2
                def spent_hours
                  @spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours", :include => :time_entries).to_f || 0.0
                end
                def relations
                  (relations_from + relations_to).sort
                end
                def all_dependent_issues(except=[])
                  except << self
                  dependencies = []
                  relations_from.each do |relation|
                    if relation.issue_to && !except.include?(relation.issue_to)
                      dependencies << relation.issue_to
                      dependencies += relation.issue_to.all_dependent_issues(except)
                    end
                  end
                  dependencies
                end
                # Returns an array of issues that duplicate this one
                def duplicates
                  relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
                end
                # Returns the due date or the target due date if any
                # Used on gantt chart
                def due_before
                  due_date || (fixed_version ? fixed_version.effective_date : nil)
                end
                # Returns the time scheduled for this issue.
                #
                # Example:
                #   Start Date: 2/26/09, End Date: 3/04/09
                #   duration => 6
                def duration
                  (start_date && due_date) ? due_date - start_date : 0
                end
                def soonest_start
                  @soonest_start ||= (
                      relations_to.collect{|relation| relation.successor_soonest_start} +
                      ancestors.collect(&:soonest_start)
                    ).compact.max
                end
                def reschedule_after(date)
                  return if date.nil?
                  if leaf?
                    if start_date.nil? || start_date < date
                      self.start_date, self.due_date = date, date + duration
                      save
                    end
                  else
                    leaves.each do |leaf|
                      leaf.reschedule_after(date)
                    end
                  end
                end
                def <=>(issue)
                  if issue.nil?
                    -1
                  elsif root_id != issue.root_id
                    (root_id || 0) <=> (issue.root_id || 0)
                  else
                    (lft || 0) <=> (issue.lft || 0)
                  end
                end
                def to_s
                  "#{tracker} ##{id}: #{subject}"
                end
                # Returns a string of css classes that apply to the issue
                def css_classes
                  s = "issue status-#{status.position} priority-#{priority.position}"
                  s << ' closed' if closed?
                  s << ' overdue' if overdue?
                  s << ' child' if child?
                  s << ' parent' unless leaf?
                  s << ' private' if is_private?
                  s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                  s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                  s
                end
                # Saves an issue, time_entry, attachments, and a journal from the parameters
                # Returns false if save fails
                def save_issue_with_child_records(params, existing_time_entry=nil)
                  Issue.transaction do
                    if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                      @time_entry = existing_time_entry || TimeEntry.new
                      @time_entry.project = project
                      @time_entry.issue = self
                      @time_entry.user = User.current
                      @time_entry.spent_on = Date.today
                      @time_entry.attributes = params[:time_entry]
                      self.time_entries << @time_entry
                    end
                    if valid?
                      attachments = Attachment.attach_files(self, params[:attachments])
                      attachments[:files].each {|a| @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
                      # TODO: Rename hook
                      Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                      begin
                        if save
                          # TODO: Rename hook
                          Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                        else
                          raise ActiveRecord::Rollback
                        end
                      rescue ActiveRecord::StaleObjectError
                        attachments[:files].each(&:destroy)
                        errors.add_to_base l(:notice_locking_conflict)
                        raise ActiveRecord::Rollback
                      end
                    end
                  end
                end
                # Unassigns issues from +version+ if it's no longer shared with issue's project
                def self.update_versions_from_sharing_change(version)
                  # Update issues assigned to the version
                  update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
                end
                # Unassigns issues from versions that are no longer shared
                # after +project+ was moved
                def self.update_versions_from_hierarchy_change(project)
                  moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                  # Update issues of the moved projects and issues assigned to a version of a moved project
                  Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
                end
                def parent_issue_id=(arg)
                  parent_issue_id = arg.blank? ? nil : arg.to_i
                  if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
                    @parent_issue.id
                  else
                    @parent_issue = nil
                    nil
                  end
                end
                def parent_issue_id
                  if instance_variable_defined? :@parent_issue
                    @parent_issue.nil? ? nil : @parent_issue.id
                  else
                    parent_id
                  end
                end
                # Extracted from the ReportsController.
                def self.by_tracker(project)
                  count_and_group_by(:project => project,
                                     :field => 'tracker_id',
                                     :joins => Tracker.table_name)
                end
                def self.by_version(project)
                  count_and_group_by(:project => project,
                                     :field => 'fixed_version_id',
                                     :joins => Version.table_name)
                end
                def self.by_priority(project)
                  count_and_group_by(:project => project,
                                     :field => 'priority_id',
                                     :joins => IssuePriority.table_name)
                end
                def self.by_category(project)
                  count_and_group_by(:project => project,
                                     :field => 'category_id',
                                     :joins => IssueCategory.table_name)
                end
                def self.by_assigned_to(project)
                  count_and_group_by(:project => project,
                                     :field => 'assigned_to_id',
                                     :joins => User.table_name)
                end
                def self.by_author(project)
                  count_and_group_by(:project => project,
                                     :field => 'author_id',
                                     :joins => User.table_name)
                end
                def self.by_subproject(project)
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              #{Issue.table_name}.project_id as project_id,
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                              #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                              and #{Issue.table_name}.project_id <> #{project.id}
                                                            group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
                end
                # End ReportsController extraction
                # Returns an array of projects that current user can move issues to
                def self.allowed_target_projects_on_move
                  projects = []
                  if User.current.admin?
                    # admin is allowed to move issues to any active (visible) project
                    projects = Project.visible.all
                  elsif User.current.logged?
                    if Role.non_member.allowed_to?(:move_issues)
                      projects = Project.visible.all
                    else
                      User.current.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
                    end
                  end
                  projects
                end
                private
                def update_nested_set_attributes
                  if root_id.nil?
                    # issue was just created
                    self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                    set_default_left_and_right
                    Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                    if @parent_issue
                      move_to_child_of(@parent_issue)
                    end
                    reload
                  elsif parent_issue_id != parent_id
                    former_parent_id = parent_id
                    # moving an existing issue
                    if @parent_issue && @parent_issue.root_id == root_id
                      # inside the same tree
                      move_to_child_of(@parent_issue)
                    else
                      # to another tree
                      unless root?
                        move_to_right_of(root)
                        reload
                      end
                      old_root_id = root_id
                      self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                      target_maxright = nested_set_scope.maximum(right_column_name) || 0
                      offset = target_maxright + 1 - lft
                      Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                        ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                      self[left_column_name] = lft + offset
                      self[right_column_name] = rgt + offset
                      if @parent_issue
                        move_to_child_of(@parent_issue)
                      end
                    end
                    reload
                    # delete invalid relations of all descendants
                    self_and_descendants.each do |issue|
                      issue.relations.each do |relation|
                        relation.destroy unless relation.valid?
                      end
                    end
                    # update former parent
                    recalculate_attributes_for(former_parent_id) if former_parent_id
                  end
                  remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
                end
                def update_parent_attributes
                  recalculate_attributes_for(parent_id) if parent_id
                end
                def recalculate_attributes_for(issue_id)
                  if issue_id && p = Issue.find_by_id(issue_id)
                    # priority = highest priority of children
                    if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :include => :priority)
                      p.priority = IssuePriority.find_by_position(priority_position)
                    end
                    # start/due dates = lowest/highest dates of children
                    p.start_date = p.children.minimum(:start_date)
                    p.due_date = p.children.maximum(:due_date)
                    if p.start_date && p.due_date && p.due_date < p.start_date
                      p.start_date, p.due_date = p.due_date, p.start_date
                    end
                    # done ratio = weighted average ratio of leaves
                    unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                      leaves_count = p.leaves.count
                      if leaves_count > 0
                        average = p.leaves.average(:estimated_hours).to_f
                        if average == 0
                          average = 1
                        end
                        done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :include => :status).to_f
                        progress = done / (average * leaves_count)
                        p.done_ratio = progress.round
                      end
                    end
                    # estimate = sum of leaves estimates
                    p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                    p.estimated_hours = nil if p.estimated_hours == 0.0
                    # ancestors will be recursively updated
                    p.save(false)
                  end
                end
                # Update issues so their versions are not pointing to a
                # fixed_version that is not shared with the issue's project
                def self.update_versions(conditions=nil)
                  # Only need to update issues with a fixed_version from
                  # a different project and that is not systemwide shared
                  Issue.all(:conditions => merge_conditions("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                                                              " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                                                              " AND #{Version.table_name}.sharing <> 'system'",
                                                              conditions),
                            :include => [:project, :fixed_version]
                            ).each do |issue|
                    next if issue.project.nil? || issue.fixed_version.nil?
                    unless issue.project.shared_versions.include?(issue.fixed_version)
                      issue.init_journal(User.current)
                      issue.fixed_version = nil
                      issue.save
                    end
                  end
                end
                # Callback on attachment deletion
                def attachment_removed(obj)
                  journal = init_journal(User.current)
                  journal.details << JournalDetail.new(:property => 'attachment',
                                                       :prop_key => obj.id,
                                                       :old_value => obj.filename)
                  journal.save
                end
                # Default assignment based on category
                def default_assign
                  if assigned_to.nil? && category && category.assigned_to
                    self.assigned_to = category.assigned_to
                  end
                end
                # Updates start/due dates of following issues
                def reschedule_following_issues
                  if start_date_changed? || due_date_changed?
                    relations_from.each do |relation|
                      relation.set_issue_to_dates
                    end
                  end
                end
                # Closes duplicates if the issue is being closed
                def close_duplicates
                  if closing?
                    duplicates.each do |duplicate|
                      # Reload is need in case the duplicate was updated by a previous duplicate
                      duplicate.reload
                      # Don't re-close it if it's already closed
                      next if duplicate.closed?
                      # Same user and notes
                      if @current_journal
                        duplicate.init_journal(@current_journal.user, @current_journal.notes)
                      end
                      duplicate.update_attribute :status, self.status
                    end
                  end
                end
                # Saves the changes in a Journal
                # Called after_save
                def create_journal
                  if @current_journal
                    # attributes changes
                    (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
+                     before = @issue_before_change.send(c)
+                     after = send(c)
+                     next if before == after || (before.blank? && after.blank?)
                      @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                    :prop_key => c,
                                                                    :old_value => @issue_before_change.send(c),
-                                                                   :value => send(c)) unless send(c)==@issue_before_change.send(c)
+                                                                   :value => send(c))
                    }
                    # custom fields changes
                    custom_values.each {|c|
                      next if (@custom_values_before_change[c.custom_field_id]==c.value ||
                                (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?))
                      @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                    :prop_key => c.custom_field_id,
                                                                    :old_value => @custom_values_before_change[c.custom_field_id],
                                                                    :value => c.value)
                    }
                    @current_journal.save
                    # reset current journal
                    init_journal @current_journal.user, @current_journal.notes
                  end
                end
                # Query generator for selecting groups of issue counts for a project
                # based on specific criteria
                #
                # Options
                # * project - Project to search in.
                # * field - String. Issue field to key off of in the grouping.
                # * joins - String. The table name to join against.
                def self.count_and_group_by(options)
                  project = options.delete(:project)
                  select_field = options.delete(:field)
                  joins = options.delete(:joins)
                  where = "#{Issue.table_name}.#{select_field}=j.id"
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              j.id as #{select_field},
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                                #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{where}
                                                              and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project)}
                                                            group by s.id, s.is_closed, j.id")
                end
              end

test/unit/issue_test.rb +16 0

              # Redmine - project management software
              # Copyright (C) 2006-2011  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueTest < ActiveSupport::TestCase
                fixtures :projects, :users, :members, :member_roles, :roles,
                         :trackers, :projects_trackers,
                         :enabled_modules,
                         :versions,
                         :issue_statuses, :issue_categories, :issue_relations, :workflows,
                         :enumerations,
                         :issues,
                         :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                         :time_entries
                def test_create
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
                  assert issue.save
                  issue.reload
                  assert_equal 1.5, issue.estimated_hours
                end
                def test_create_minimal
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
                  assert issue.save
                  assert issue.description.nil?
                end
                def test_create_with_required_custom_field
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # No value for the custom field
                  assert !issue.save
                  assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.save
                  assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def assert_visibility_match(user, issues)
                  assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
                end
                def test_visible_scope_for_anonymous
                  # Anonymous user should see issues of public projects only
                  issues = Issue.visible(User.anonymous).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_anonymous_with_own_issues_visibility
                  Role.anonymous.update_attribute :issues_visibility, 'own'
                  Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
                  issues = Issue.visible(User.anonymous).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.author != User.anonymous}
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_anonymous_without_view_issues_permissions
                  # Anonymous user should not see issues without permission
                  Role.anonymous.remove_permission!(:view_issues)
                  issues = Issue.visible(User.anonymous).all
                  assert issues.empty?
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_non_member
                  user = User.find(9)
                  assert user.projects.empty?
                  # Non member user should see issues of public projects only
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_with_own_issues_visibility
                  Role.non_member.update_attribute :issues_visibility, 'own'
                  Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
                  user = User.find(9)
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_without_view_issues_permissions
                  # Non member user should not see issues without permission
                  Role.non_member.remove_permission!(:view_issues)
                  user = User.find(9)
                  assert user.projects.empty?
                  issues = Issue.visible(user).all
                  assert issues.empty?
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_member
                  user = User.find(9)
                  # User should see issues of projects for which he has view_issues permissions only
                  Role.non_member.remove_permission!(:view_issues)
                  Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.project_id != 3}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_admin
                  user = User.find(1)
                  user.members.each(&:destroy)
                  assert user.projects.empty?
                  issues = Issue.visible(user).all
                  assert issues.any?
                  # Admin should see issues on private projects that he does not belong to
                  assert issues.detect {|issue| !issue.project.is_public?}
                  # Admin should see private issues of other users
                  assert issues.detect {|issue| issue.is_private? && issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_with_project
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project).all
                  projects = issues.collect(&:project).uniq
                  assert_equal 1, projects.size
                  assert_equal project, projects.first
                end
                def test_visible_scope_with_project_and_subprojects
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
                  projects = issues.collect(&:project).uniq
                  assert projects.size > 1
                  assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
                end
                def test_visible_and_nested_set_scopes
                  assert_equal 0, Issue.find(1).descendants.visible.all.size
                end
                def test_errors_full_messages_should_include_custom_fields_errors
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.valid?
                  assert_equal 1, issue.errors.full_messages.size
                  assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
                end
                def test_update_issue_with_required_custom_field
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.find(1)
                  assert_nil issue.custom_value_for(field)
                  assert issue.available_custom_fields.include?(field)
                  # No change to custom values, issue can be saved
                  assert issue.save
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def test_should_not_update_attributes_if_custom_fields_validation_fails
                  issue = Issue.find(1)
                  field = IssueCustomField.find_by_name('Database')
                  assert issue.available_custom_fields.include?(field)
                  issue.custom_field_values = { field.id => 'Invalid' }
                  issue.subject = 'Should be not be saved'
                  assert !issue.save
                  issue.reload
                  assert_equal "Can't print recipes", issue.subject
                end
                def test_should_not_recreate_custom_values_objects_on_update
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.find(1)
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  custom_value = issue.custom_value_for(field)
                  issue.reload
                  issue.custom_field_values = { field.id => 'MySQL' }
                  assert issue.save
                  issue.reload
                  assert_equal custom_value.id, issue.custom_value_for(field).id
                end
                def test_assigning_tracker_id_should_reload_custom_fields_values
                  issue = Issue.new(:project => Project.find(1))
                  assert issue.custom_field_values.empty?
                  issue.tracker_id = 1
                  assert issue.custom_field_values.any?
                end
                def test_assigning_attributes_should_assign_tracker_id_first
                  attributes = ActiveSupport::OrderedHash.new
                  attributes['custom_field_values'] = { '1' => 'MySQL' }
                  attributes['tracker_id'] = '1'
                  issue = Issue.new(:project => Project.find(1))
                  issue.attributes = attributes
                  assert_not_nil issue.custom_value_for(1)
                  assert_equal 'MySQL', issue.custom_value_for(1).value
                end
                def test_should_update_issue_with_disabled_tracker
                  p = Project.find(1)
                  issue = Issue.find(1)
                  p.trackers.delete(issue.tracker)
                  assert !p.trackers.include?(issue.tracker)
                  issue.reload
                  issue.subject = 'New subject'
                  assert issue.save
                end
                def test_should_not_set_a_disabled_tracker
                  p = Project.find(1)
                  p.trackers.delete(Tracker.find(2))
                  issue = Issue.find(1)
                  issue.tracker_id = 2
                  issue.subject = 'New subject'
                  assert !issue.save
                  assert_not_nil issue.errors.on(:tracker_id)
                end
                def test_category_based_assignment
                  issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1)
                  assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
                end
                def test_new_statuses_allowed_to
                  Workflow.delete_all
                  Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
                  Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
                  Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
                  Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
                  status = IssueStatus.find(1)
                  role = Role.find(1)
                  tracker = Tracker.find(1)
                  user = User.find(2)
                  issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
                  assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
                  assert_equal [1, 2, 3], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
                  assert_equal [1, 2, 4], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
                  assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                end
                def test_copy
                  issue = Issue.new.copy_from(1)
                  assert issue.save
                  issue.reload
                  orig = Issue.find(1)
                  assert_equal orig.subject, issue.subject
                  assert_equal orig.tracker, issue.tracker
                  assert_equal "125", issue.custom_value_for(2).value
                end
                def test_copy_should_copy_status
                  orig = Issue.find(8)
                  assert orig.status != IssueStatus.default
                  issue = Issue.new.copy_from(orig)
                  assert issue.save
                  issue.reload
                  assert_equal orig.status, issue.status
                end
                def test_should_close_duplicates
                  # Create 3 issues
                  issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
                  assert issue1.save
                  issue2 = issue1.clone
                  assert issue2.save
                  issue3 = issue1.clone
                  assert issue3.save
                  # 2 is a dupe of 1
                  IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 2
                  IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 1 (circular duplicates)
                  IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
                  assert issue1.reload.duplicates.include?(issue2)
                  # Closing issue 1
                  issue1.init_journal(User.find(:first), "Closing issue1")
                  issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
                  assert issue1.save
                  # 2 and 3 should be also closed
                  assert issue2.reload.closed?
                  assert issue3.reload.closed?
                end
                def test_should_not_close_duplicated_issue
                  # Create 3 issues
                  issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
                  assert issue1.save
                  issue2 = issue1.clone
                  assert issue2.save
                  # 2 is a dupe of 1
                  IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # 2 is a dup of 1 but 1 is not a duplicate of 2
                  assert !issue2.reload.duplicates.include?(issue1)
                  # Closing issue 2
                  issue2.init_journal(User.find(:first), "Closing issue2")
                  issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
                  assert issue2.save
                  # 1 should not be also closed
                  assert !issue1.reload.closed?
                end
                def test_assignable_versions
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
                  assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
                  assert !issue.save
                  assert_not_nil issue.errors.on(:fixed_version_id)
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
                  assert !issue.save
                  assert_not_nil issue.errors.on(:fixed_version_id)
                end
                def test_should_be_able_to_assign_a_new_issue_to_an_open_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
                  assert issue.save
                end
                def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  assert_equal 'closed', issue.fixed_version.status
                  issue.subject = 'Subject changed'
                  assert issue.save
                end
                def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  assert !issue.save
                  assert_not_nil issue.errors.on_base
                end
                def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  issue.fixed_version_id = 3
                  assert issue.save
                end
                def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
                  issue = Issue.find(12)
                  assert_equal 'locked', issue.fixed_version.status
                  issue.status_id = 1
                  assert issue.save
                end
                def test_move_to_another_project_with_same_category
                  issue = Issue.find(1)
                  assert issue.move_to_project(Project.find(2))
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category changes
                  assert_equal 4, issue.category_id
                  # Make sure time entries were move to the target project
                  assert_equal 2, issue.time_entries.first.project_id
                end
                def test_move_to_another_project_without_same_category
                  issue = Issue.find(2)
                  assert issue.move_to_project(Project.find(2))
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category cleared
                  assert_nil issue.category_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  assert issue.move_to_project(Project.find(2))
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 4)
                  assert issue.move_to_project(Project.find(5))
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Keep fixed_version
                  assert_equal 4, issue.fixed_version_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  assert issue.move_to_project(Project.find(5))
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 7)
                  assert issue.move_to_project(Project.find(2))
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Keep fixed_version
                  assert_equal 7, issue.fixed_version_id
                end
                def test_move_to_another_project_with_disabled_tracker
                  issue = Issue.find(1)
                  target = Project.find(2)
                  target.tracker_ids = [3]
                  target.save
                  assert_equal false, issue.move_to_project(target)
                  issue.reload
                  assert_equal 1, issue.project_id
                end
                def test_copy_to_the_same_project
                  issue = Issue.find(1)
                  copy = nil
                  assert_difference 'Issue.count' do
                    copy = issue.move_to_project(issue.project, nil, :copy => true)
                  end
                  assert_kind_of Issue, copy
                  assert_equal issue.project, copy.project
                  assert_equal "125", copy.custom_value_for(2).value
                end
                def test_copy_to_another_project_and_tracker
                  issue = Issue.find(1)
                  copy = nil
                  assert_difference 'Issue.count' do
                    copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
                  end
                  copy.reload
                  assert_kind_of Issue, copy
                  assert_equal Project.find(3), copy.project
                  assert_equal Tracker.find(2), copy.tracker
                  # Custom field #2 is not associated with target tracker
                  assert_nil copy.custom_value_for(2)
                end
                context "#move_to_project" do
                  context "as a copy" do
                    setup do
                      @issue = Issue.find(1)
                      @copy = nil
                    end
                    should "not create a journal" do
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
                      assert_equal 0, @copy.reload.journals.size
                    end
                    should "allow assigned_to changes" do
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
                      assert_equal 3, @copy.assigned_to_id
                    end
                    should "allow status changes" do
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
                      assert_equal 2, @copy.status_id
                    end
                    should "allow start date changes" do
                      date = Date.today
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
                      assert_equal date, @copy.start_date
                    end
                    should "allow due date changes" do
                      date = Date.today
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
                      assert_equal date, @copy.due_date
                    end
                    should "set current user as author" do
                      User.current = User.find(9)
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
                      assert_equal User.current, @copy.author
                    end
                    should "keep journal notes" do
                      date = Date.today
                      notes = "Notes added when copying"
                      User.current = User.find(9)
                      @issue.init_journal(User.current, notes)
                      @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
                      assert_equal 1, @copy.journals.size
                      journal = @copy.journals.first
                      assert_equal 0, journal.details.size
                      assert_equal notes, journal.notes
                    end
                  end
                end
                def test_recipients_should_not_include_users_that_cannot_view_the_issue
                  issue = Issue.find(12)
                  assert issue.recipients.include?(issue.author.mail)
                  # move the issue to a private project
                  copy  = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
                  # author is not a member of project anymore
                  assert !copy.recipients.include?(copy.author.mail)
                end
                def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
                  user = User.find(3)
                  issue = Issue.find(9)
                  Watcher.create!(:user => user, :watchable => issue)
                  assert issue.watched_by?(user)
                  assert !issue.watcher_recipients.include?(user.mail)
                end
                def test_issue_destroy
                  Issue.find(1).destroy
                  assert_nil Issue.find_by_id(1)
                  assert_nil TimeEntry.find_by_issue_id(1)
                end
                def test_blocked
                  blocked_issue = Issue.find(9)
                  blocking_issue = Issue.find(10)
                  assert blocked_issue.blocked?
                  assert !blocking_issue.blocked?
                end
                def test_blocked_issues_dont_allow_closed_statuses
                  blocked_issue = Issue.find(9)
                  allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert closed_statuses.empty?
                end
                def test_unblocked_issues_allow_closed_statuses
                  blocking_issue = Issue.find(10)
                  allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert !closed_statuses.empty?
                end
                def test_rescheduling_an_issue_should_reschedule_following_issue
                  issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
                  issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal issue1.due_date + 1, issue2.reload.start_date
                  issue1.due_date = Date.today + 5
                  issue1.save!
                  assert_equal issue1.due_date + 1, issue2.reload.start_date
                end
                def test_overdue
                  assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
                  assert !Issue.new(:due_date => Date.today).overdue?
                  assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
                  assert !Issue.new(:due_date => nil).overdue?
                  assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
                end
                context "#behind_schedule?" do
                  should "be false if the issue has no start_date" do
                    assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
                  end
                  should "be false if the issue has no end_date" do
                    assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
                  end
                  should "be false if the issue has more done than it's calendar time" do
                    assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
                  end
                  should "be true if the issue hasn't been started at all" do
                    assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
                  end
                  should "be true if the issue has used more calendar time than it's done ratio" do
                    assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
                  end
                end
                context "#assignable_users" do
                  should "be Users" do
                    assert_kind_of User, Issue.find(1).assignable_users.first
                  end
                  should "include the issue author" do
                    project = Project.find(1)
                    non_project_member = User.generate!
                    issue = Issue.generate_for_project!(project, :author => non_project_member)
                    assert issue.assignable_users.include?(non_project_member)
                  end
                  should "not show the issue author twice" do
                    assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
                    assert_equal 2, assignable_user_ids.length
                    assignable_user_ids.each do |user_id|
                      assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
                    end
                  end
                end
                def test_create_should_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
                  assert issue.save
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_stale_issue_should_not_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  stale = Issue.find(1)
                  issue.init_journal(User.find(1))
                  issue.subject = 'Subjet update'
                  assert issue.save
                  assert_equal 1, ActionMailer::Base.deliveries.size
                  ActionMailer::Base.deliveries.clear
                  stale.init_journal(User.find(1))
                  stale.subject = 'Another subjet update'
                  assert_raise ActiveRecord::StaleObjectError do
                    stale.save
                  end
                  assert ActionMailer::Base.deliveries.empty?
                end
                def test_journalized_description
                  IssueCustomField.delete_all
                  i = Issue.first
                  old_description = i.description
                  new_description = "This is the new description"
                  i.init_journal(User.find(2))
                  i.description = new_description
                  assert_difference 'Journal.count', 1 do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save!
                    end
                  end
                  detail = JournalDetail.first(:order => 'id DESC')
                  assert_equal i, detail.journal.journalized
                  assert_equal 'attr', detail.property
                  assert_equal 'description', detail.prop_key
                  assert_equal old_description, detail.old_value
                  assert_equal new_description, detail.value
                end
+               def test_blank_descriptions_should_not_be_journalized
+                 IssueCustomField.delete_all
+                 Issue.update_all("description = NULL", "id=1")
+                 i = Issue.first
+                 i.init_journal(User.find(2))
+                 i.subject = "blank description"
+                 i.description = "\r\n"
+                 assert_difference 'Journal.count', 1 do
+                   assert_difference 'JournalDetail.count', 1 do
+                     i.save!
+                   end
+                 end
+               end
                def test_saving_twice_should_not_duplicate_journal_details
                  i = Issue.find(:first)
                  i.init_journal(User.find(2), 'Some notes')
                  # initial changes
                  i.subject = 'New subject'
                  i.done_ratio = i.done_ratio + 10
                  assert_difference 'Journal.count' do
                    assert i.save
                  end
                  # 1 more change
                  i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
                  assert_no_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save
                    end
                  end
                  # no more change
                  assert_no_difference 'Journal.count' do
                    assert_no_difference 'JournalDetail.count' do
                      i.save
                    end
                  end
                end
                def test_all_dependent_issues
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_persistent_circular_dependency
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
                  # Validation skipping
                  assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
                  assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_RELATES)
                  # Validation skipping
                  assert IssueRelation.new(:issue_from => Issue.find(8), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES).save(false)
                  assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_RELATES).save(false)
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                context "#done_ratio" do
                  setup do
                    @issue = Issue.find(1)
                    @issue_status = IssueStatus.find(1)
                    @issue_status.update_attribute(:default_done_ratio, 50)
                    @issue2 = Issue.find(2)
                    @issue_status2 = IssueStatus.find(2)
                    @issue_status2.update_attribute(:default_done_ratio, 0)
                  end
                  context "with Setting.issue_done_ratio using the issue_field" do
                    setup do
                      Setting.issue_done_ratio = 'issue_field'
                    end
                    should "read the issue's field" do
                      assert_equal 0, @issue.done_ratio
                      assert_equal 30, @issue2.done_ratio
                    end
                  end
                  context "with Setting.issue_done_ratio using the issue_status" do
                    setup do
                      Setting.issue_done_ratio = 'issue_status'
                    end
                    should "read the Issue Status's default done ratio" do
                      assert_equal 50, @issue.done_ratio
                      assert_equal 0, @issue2.done_ratio
                    end
                  end
                end
                context "#update_done_ratio_from_issue_status" do
                  setup do
                    @issue = Issue.find(1)
                    @issue_status = IssueStatus.find(1)
                    @issue_status.update_attribute(:default_done_ratio, 50)
                    @issue2 = Issue.find(2)
                    @issue_status2 = IssueStatus.find(2)
                    @issue_status2.update_attribute(:default_done_ratio, 0)
                  end
                  context "with Setting.issue_done_ratio using the issue_field" do
                    setup do
                      Setting.issue_done_ratio = 'issue_field'
                    end
                    should "not change the issue" do
                      @issue.update_done_ratio_from_issue_status
                      @issue2.update_done_ratio_from_issue_status
                      assert_equal 0, @issue.read_attribute(:done_ratio)
                      assert_equal 30, @issue2.read_attribute(:done_ratio)
                    end
                  end
                  context "with Setting.issue_done_ratio using the issue_status" do
                    setup do
                      Setting.issue_done_ratio = 'issue_status'
                    end
                    should "change the issue's done ratio" do
                      @issue.update_done_ratio_from_issue_status
                      @issue2.update_done_ratio_from_issue_status
                      assert_equal 50, @issue.read_attribute(:done_ratio)
                      assert_equal 0, @issue2.read_attribute(:done_ratio)
                    end
                  end
                end
                test "#by_tracker" do
                  User.current = User.anonymous
                  groups = Issue.by_tracker(Project.find(1))
                  assert_equal 3, groups.size
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_version" do
                  User.current = User.anonymous
                  groups = Issue.by_version(Project.find(1))
                  assert_equal 3, groups.size
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_priority" do
                  User.current = User.anonymous
                  groups = Issue.by_priority(Project.find(1))
                  assert_equal 4, groups.size
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_category" do
                  User.current = User.anonymous
                  groups = Issue.by_category(Project.find(1))
                  assert_equal 2, groups.size
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_assigned_to" do
                  User.current = User.anonymous
                  groups = Issue.by_assigned_to(Project.find(1))
                  assert_equal 2, groups.size
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_author" do
                  User.current = User.anonymous
                  groups = Issue.by_author(Project.find(1))
                  assert_equal 4, groups.size
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_subproject" do
                  User.current = User.anonymous
                  groups = Issue.by_subproject(Project.find(1))
                  # Private descendant not visible
                  assert_equal 1, groups.size
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                context ".allowed_target_projects_on_move" do
                  should "return all active projects for admin users" do
                    User.current = User.find(1)
                    assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
                  end
                  should "return allowed projects for non admin users" do
                    User.current = User.find(2)
                    Role.non_member.remove_permission! :move_issues
                    assert_equal 3, Issue.allowed_target_projects_on_move.size
                    Role.non_member.add_permission! :move_issues
                    assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
                  end
                end
                def test_recently_updated_with_limit_scopes
                  #should return the last updated issue
                  assert_equal 1, Issue.recently_updated.with_limit(1).length
                  assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
                end
                def test_on_active_projects_scope
                  assert Project.find(2).archive
                  before = Issue.on_active_project.length
                  # test inclusion to results
                  issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
                  assert_equal before + 1, Issue.on_active_project.length
                  # Move to an archived project
                  issue.project = Project.find(2)
                  assert issue.save
                  assert_equal before, Issue.on_active_project.length
                end
                context "Issue#recipients" do
                  setup do
                    @project = Project.find(1)
                    @author = User.generate_with_protected!
                    @assignee = User.generate_with_protected!
                    @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
                  end
                  should "include project recipients" do
                    assert @project.recipients.present?
                    @project.recipients.each do |project_recipient|
                      assert @issue.recipients.include?(project_recipient)
                    end
                  end
                  should "include the author if the author is active" do
                    assert @issue.author, "No author set for Issue"
                    assert @issue.recipients.include?(@issue.author.mail)
                  end
                  should "include the assigned to user if the assigned to user is active" do
                    assert @issue.assigned_to, "No assigned_to set for Issue"
                    assert @issue.recipients.include?(@issue.assigned_to.mail)
                  end
                  should "not include users who opt out of all email" do
                    @author.update_attribute(:mail_notification, :none)
                    assert !@issue.recipients.include?(@issue.author.mail)
                  end
                  should "not include the issue author if they are only notified of assigned issues" do
                    @author.update_attribute(:mail_notification, :only_assigned)
                    assert !@issue.recipients.include?(@issue.author.mail)
                  end
                  should "not include the assigned user if they are only notified of owned issues" do
                    @assignee.update_attribute(:mail_notification, :only_owner)
                    assert !@issue.recipients.include?(@issue.assigned_to.mail)
                  end
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages