##// END OF EJS Templates
Fixed: invalid format parameter returns a DoubleRenderError on issues index (#4737)....
Jean-Philippe Lang -
r3252:cfe4d0e7db5c
parent child
Show More
@@ -1,572 +1,574
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => :new
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :reply]
23 23 before_filter :find_issues, :only => [:bulk_edit, :move, :destroy]
24 24 before_filter :find_project, :only => [:new, :update_form, :preview]
25 25 before_filter :authorize, :except => [:index, :changes, :gantt, :calendar, :preview, :context_menu]
26 26 before_filter :find_optional_project, :only => [:index, :changes, :gantt, :calendar]
27 27 accept_key_auth :index, :show, :changes
28 28
29 29 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
30 30
31 31 helper :journals
32 32 helper :projects
33 33 include ProjectsHelper
34 34 helper :custom_fields
35 35 include CustomFieldsHelper
36 36 helper :issue_relations
37 37 include IssueRelationsHelper
38 38 helper :watchers
39 39 include WatchersHelper
40 40 helper :attachments
41 41 include AttachmentsHelper
42 42 helper :queries
43 43 include QueriesHelper
44 44 helper :sort
45 45 include SortHelper
46 46 include IssuesHelper
47 47 helper :timelog
48 48 include Redmine::Export::PDF
49 49
50 50 verify :method => [:post, :delete],
51 51 :only => :destroy,
52 52 :render => { :nothing => true, :status => :method_not_allowed }
53 53
54 54 def index
55 55 retrieve_query
56 56 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
57 57 sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h}))
58 58
59 59 if @query.valid?
60 limit = per_page_option
61 respond_to do |format|
62 format.html { }
63 format.xml { }
64 format.atom { limit = Setting.feeds_limit.to_i }
65 format.csv { limit = Setting.issues_export_limit.to_i }
66 format.pdf { limit = Setting.issues_export_limit.to_i }
60 limit = case params[:format]
61 when 'csv', 'pdf'
62 Setting.issues_export_limit.to_i
63 when 'atom'
64 Setting.feeds_limit.to_i
65 else
66 per_page_option
67 67 end
68 68
69 69 @issue_count = @query.issue_count
70 70 @issue_pages = Paginator.new self, @issue_count, limit, params['page']
71 71 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
72 72 :order => sort_clause,
73 73 :offset => @issue_pages.current.offset,
74 74 :limit => limit)
75 75 @issue_count_by_group = @query.issue_count_by_group
76 76
77 77 respond_to do |format|
78 78 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
79 79 format.xml { render :layout => false }
80 80 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
81 81 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
82 82 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
83 83 end
84 84 else
85 85 # Send html if the query is not valid
86 86 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
87 87 end
88 88 rescue ActiveRecord::RecordNotFound
89 89 render_404
90 90 end
91 91
92 92 def changes
93 93 retrieve_query
94 94 sort_init 'id', 'desc'
95 95 sort_update({'id' => "#{Issue.table_name}.id"}.merge(@query.available_columns.inject({}) {|h, c| h[c.name.to_s] = c.sortable; h}))
96 96
97 97 if @query.valid?
98 98 @journals = @query.journals(:order => "#{Journal.table_name}.created_on DESC",
99 99 :limit => 25)
100 100 end
101 101 @title = (@project ? @project.name : Setting.app_title) + ": " + (@query.new_record? ? l(:label_changes_details) : @query.name)
102 102 render :layout => false, :content_type => 'application/atom+xml'
103 103 rescue ActiveRecord::RecordNotFound
104 104 render_404
105 105 end
106 106
107 107 def show
108 108 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
109 109 @journals.each_with_index {|j,i| j.indice = i+1}
110 110 @journals.reverse! if User.current.wants_comments_in_reverse_order?
111 111 @changesets = @issue.changesets.visible.all
112 112 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
113 113 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
114 114 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
115 115 @priorities = IssuePriority.all
116 116 @time_entry = TimeEntry.new
117 117 respond_to do |format|
118 118 format.html { render :template => 'issues/show.rhtml' }
119 119 format.xml { render :layout => false }
120 120 format.atom { render :action => 'changes', :layout => false, :content_type => 'application/atom+xml' }
121 121 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
122 122 end
123 123 end
124 124
125 125 # Add a new issue
126 126 # The new issue will be created from an existing one if copy_from parameter is given
127 127 def new
128 128 @issue = Issue.new
129 129 @issue.copy_from(params[:copy_from]) if params[:copy_from]
130 130 @issue.project = @project
131 131 # Tracker must be set before custom field values
132 132 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
133 133 if @issue.tracker.nil?
134 134 render_error l(:error_no_tracker_in_project)
135 135 return
136 136 end
137 137 if params[:issue].is_a?(Hash)
138 138 @issue.safe_attributes = params[:issue]
139 139 @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
140 140 end
141 141 @issue.author = User.current
142 142
143 143 default_status = IssueStatus.default
144 144 unless default_status
145 145 render_error l(:error_no_default_issue_status)
146 146 return
147 147 end
148 148 @issue.status = default_status
149 149 @allowed_statuses = ([default_status] + default_status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
150 150
151 151 if request.get? || request.xhr?
152 152 @issue.start_date ||= Date.today
153 153 else
154 154 requested_status = IssueStatus.find_by_id(params[:issue][:status_id])
155 155 # Check that the user is allowed to apply the requested status
156 156 @issue.status = (@allowed_statuses.include? requested_status) ? requested_status : default_status
157 157 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
158 158 if @issue.save
159 159 attach_files(@issue, params[:attachments])
160 flash[:notice] = l(:notice_successful_create)
161 160 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
162 161 respond_to do |format|
163 162 format.html {
163 # Displays a link to the newly created issue in the flash message
164 link = @template.link_to("##{@issue.id}", {:controller => 'issues', :action => 'show', :id => @issue})
165 flash[:notice] = l(:notice_issue_created, :value => link)
164 166 redirect_to(params[:continue] ? { :action => 'new', :tracker_id => @issue.tracker } :
165 167 { :action => 'show', :id => @issue })
166 168 }
167 169 format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
168 170 end
169 171 return
170 172 else
171 173 respond_to do |format|
172 174 format.html { }
173 175 format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
174 176 end
175 177 end
176 178 end
177 179 @priorities = IssuePriority.all
178 180 render :layout => !request.xhr?
179 181 end
180 182
181 183 # Attributes that can be updated on workflow transition (without :edit permission)
182 184 # TODO: make it configurable (at least per role)
183 185 UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
184 186
185 187 def edit
186 188 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
187 189 @priorities = IssuePriority.all
188 190 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
189 191 @time_entry = TimeEntry.new
190 192
191 193 @notes = params[:notes]
192 194 journal = @issue.init_journal(User.current, @notes)
193 195 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
194 196 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
195 197 attrs = params[:issue].dup
196 198 attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
197 199 attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
198 200 @issue.safe_attributes = attrs
199 201 end
200 202
201 203 if request.get?
202 204 # nop
203 205 else
204 206 @time_entry = TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today)
205 207 @time_entry.attributes = params[:time_entry]
206 208 if (@time_entry.hours.nil? || @time_entry.valid?) && @issue.valid?
207 209 attachments = attach_files(@issue, params[:attachments])
208 210 attachments.each {|a| journal.details << JournalDetail.new(:property => 'attachment', :prop_key => a.id, :value => a.filename)}
209 211 call_hook(:controller_issues_edit_before_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal})
210 212 if @issue.save
211 213 # Log spend time
212 214 if User.current.allowed_to?(:log_time, @project)
213 215 @time_entry.save
214 216 end
215 217 if !journal.new_record?
216 218 # Only send notification if something was actually changed
217 219 flash[:notice] = l(:notice_successful_update)
218 220 end
219 221 call_hook(:controller_issues_edit_after_save, { :params => params, :issue => @issue, :time_entry => @time_entry, :journal => journal})
220 222 respond_to do |format|
221 223 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
222 224 format.xml { head :ok }
223 225 end
224 226 return
225 227 end
226 228 end
227 229 # failure
228 230 respond_to do |format|
229 231 format.html { }
230 232 format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }
231 233 end
232 234 end
233 235 rescue ActiveRecord::StaleObjectError
234 236 # Optimistic locking exception
235 237 flash.now[:error] = l(:notice_locking_conflict)
236 238 # Remove the previously added attachments if issue was not updated
237 239 attachments.each(&:destroy)
238 240 end
239 241
240 242 def reply
241 243 journal = Journal.find(params[:journal_id]) if params[:journal_id]
242 244 if journal
243 245 user = journal.user
244 246 text = journal.notes
245 247 else
246 248 user = @issue.author
247 249 text = @issue.description
248 250 end
249 251 content = "#{ll(Setting.default_language, :text_user_wrote, user)}\\n> "
250 252 content << text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]').gsub('"', '\"').gsub(/(\r?\n|\r\n?)/, "\\n> ") + "\\n\\n"
251 253 render(:update) { |page|
252 254 page.<< "$('notes').value = \"#{content}\";"
253 255 page.show 'update'
254 256 page << "Form.Element.focus('notes');"
255 257 page << "Element.scrollTo('update');"
256 258 page << "$('notes').scrollTop = $('notes').scrollHeight - $('notes').clientHeight;"
257 259 }
258 260 end
259 261
260 262 # Bulk edit a set of issues
261 263 def bulk_edit
262 264 if request.post?
263 265 tracker = params[:tracker_id].blank? ? nil : @project.trackers.find_by_id(params[:tracker_id])
264 266 status = params[:status_id].blank? ? nil : IssueStatus.find_by_id(params[:status_id])
265 267 priority = params[:priority_id].blank? ? nil : IssuePriority.find_by_id(params[:priority_id])
266 268 assigned_to = (params[:assigned_to_id].blank? || params[:assigned_to_id] == 'none') ? nil : User.find_by_id(params[:assigned_to_id])
267 269 category = (params[:category_id].blank? || params[:category_id] == 'none') ? nil : @project.issue_categories.find_by_id(params[:category_id])
268 270 fixed_version = (params[:fixed_version_id].blank? || params[:fixed_version_id] == 'none') ? nil : @project.shared_versions.find_by_id(params[:fixed_version_id])
269 271 custom_field_values = params[:custom_field_values] ? params[:custom_field_values].reject {|k,v| v.blank?} : nil
270 272
271 273 unsaved_issue_ids = []
272 274 @issues.each do |issue|
273 275 journal = issue.init_journal(User.current, params[:notes])
274 276 issue.tracker = tracker if tracker
275 277 issue.priority = priority if priority
276 278 issue.assigned_to = assigned_to if assigned_to || params[:assigned_to_id] == 'none'
277 279 issue.category = category if category || params[:category_id] == 'none'
278 280 issue.fixed_version = fixed_version if fixed_version || params[:fixed_version_id] == 'none'
279 281 issue.start_date = params[:start_date] unless params[:start_date].blank?
280 282 issue.due_date = params[:due_date] unless params[:due_date].blank?
281 283 issue.done_ratio = params[:done_ratio] unless params[:done_ratio].blank?
282 284 issue.custom_field_values = custom_field_values if custom_field_values && !custom_field_values.empty?
283 285 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
284 286 # Don't save any change to the issue if the user is not authorized to apply the requested status
285 287 unless (status.nil? || (issue.new_statuses_allowed_to(User.current).include?(status) && issue.status = status)) && issue.save
286 288 # Keep unsaved issue ids to display them in flash error
287 289 unsaved_issue_ids << issue.id
288 290 end
289 291 end
290 292 if unsaved_issue_ids.empty?
291 293 flash[:notice] = l(:notice_successful_update) unless @issues.empty?
292 294 else
293 295 flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size,
294 296 :total => @issues.size,
295 297 :ids => '#' + unsaved_issue_ids.join(', #'))
296 298 end
297 299 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
298 300 return
299 301 end
300 302 @available_statuses = Workflow.available_statuses(@project)
301 303 @custom_fields = @project.all_issue_custom_fields
302 304 end
303 305
304 306 def move
305 307 @copy = params[:copy_options] && params[:copy_options][:copy]
306 308 @allowed_projects = []
307 309 # find projects to which the user is allowed to move the issue
308 310 if User.current.admin?
309 311 # admin is allowed to move issues to any active (visible) project
310 312 @allowed_projects = Project.find(:all, :conditions => Project.visible_by(User.current))
311 313 else
312 314 User.current.memberships.each {|m| @allowed_projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
313 315 end
314 316 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:new_project_id]} if params[:new_project_id]
315 317 @target_project ||= @project
316 318 @trackers = @target_project.trackers
317 319 @available_statuses = Workflow.available_statuses(@project)
318 320 if request.post?
319 321 new_tracker = params[:new_tracker_id].blank? ? nil : @target_project.trackers.find_by_id(params[:new_tracker_id])
320 322 unsaved_issue_ids = []
321 323 moved_issues = []
322 324 @issues.each do |issue|
323 325 changed_attributes = {}
324 326 [:assigned_to_id, :status_id, :start_date, :due_date].each do |valid_attribute|
325 327 unless params[valid_attribute].blank?
326 328 changed_attributes[valid_attribute] = (params[valid_attribute] == 'none' ? nil : params[valid_attribute])
327 329 end
328 330 end
329 331 issue.init_journal(User.current)
330 332 if r = issue.move_to(@target_project, new_tracker, {:copy => @copy, :attributes => changed_attributes})
331 333 moved_issues << r
332 334 else
333 335 unsaved_issue_ids << issue.id
334 336 end
335 337 end
336 338 if unsaved_issue_ids.empty?
337 339 flash[:notice] = l(:notice_successful_update) unless @issues.empty?
338 340 else
339 341 flash[:error] = l(:notice_failed_to_save_issues, :count => unsaved_issue_ids.size,
340 342 :total => @issues.size,
341 343 :ids => '#' + unsaved_issue_ids.join(', #'))
342 344 end
343 345 if params[:follow]
344 346 if @issues.size == 1 && moved_issues.size == 1
345 347 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
346 348 else
347 349 redirect_to :controller => 'issues', :action => 'index', :project_id => (@target_project || @project)
348 350 end
349 351 else
350 352 redirect_to :controller => 'issues', :action => 'index', :project_id => @project
351 353 end
352 354 return
353 355 end
354 356 render :layout => false if request.xhr?
355 357 end
356 358
357 359 def destroy
358 360 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
359 361 if @hours > 0
360 362 case params[:todo]
361 363 when 'destroy'
362 364 # nothing to do
363 365 when 'nullify'
364 366 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
365 367 when 'reassign'
366 368 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
367 369 if reassign_to.nil?
368 370 flash.now[:error] = l(:error_issue_not_found_in_project)
369 371 return
370 372 else
371 373 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
372 374 end
373 375 else
374 376 unless params[:format] == 'xml'
375 377 # display the destroy form if it's a user request
376 378 return
377 379 end
378 380 end
379 381 end
380 382 @issues.each(&:destroy)
381 383 respond_to do |format|
382 384 format.html { redirect_to :action => 'index', :project_id => @project }
383 385 format.xml { head :ok }
384 386 end
385 387 end
386 388
387 389 def gantt
388 390 @gantt = Redmine::Helpers::Gantt.new(params)
389 391 retrieve_query
390 392 if @query.valid?
391 393 events = []
392 394 # Issues that have start and due dates
393 395 events += @query.issues(:include => [:tracker, :assigned_to, :priority],
394 396 :order => "start_date, due_date",
395 397 :conditions => ["(((start_date>=? and start_date<=?) or (due_date>=? and due_date<=?) or (start_date<? and due_date>?)) and start_date is not null and due_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to]
396 398 )
397 399 # Issues that don't have a due date but that are assigned to a version with a date
398 400 events += @query.issues(:include => [:tracker, :assigned_to, :priority, :fixed_version],
399 401 :order => "start_date, effective_date",
400 402 :conditions => ["(((start_date>=? and start_date<=?) or (effective_date>=? and effective_date<=?) or (start_date<? and effective_date>?)) and start_date is not null and due_date is null and effective_date is not null)", @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to, @gantt.date_from, @gantt.date_to]
401 403 )
402 404 # Versions
403 405 events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @gantt.date_from, @gantt.date_to])
404 406
405 407 @gantt.events = events
406 408 end
407 409
408 410 basename = (@project ? "#{@project.identifier}-" : '') + 'gantt'
409 411
410 412 respond_to do |format|
411 413 format.html { render :template => "issues/gantt.rhtml", :layout => !request.xhr? }
412 414 format.png { send_data(@gantt.to_image, :disposition => 'inline', :type => 'image/png', :filename => "#{basename}.png") } if @gantt.respond_to?('to_image')
413 415 format.pdf { send_data(gantt_to_pdf(@gantt, @project), :type => 'application/pdf', :filename => "#{basename}.pdf") }
414 416 end
415 417 end
416 418
417 419 def calendar
418 420 if params[:year] and params[:year].to_i > 1900
419 421 @year = params[:year].to_i
420 422 if params[:month] and params[:month].to_i > 0 and params[:month].to_i < 13
421 423 @month = params[:month].to_i
422 424 end
423 425 end
424 426 @year ||= Date.today.year
425 427 @month ||= Date.today.month
426 428
427 429 @calendar = Redmine::Helpers::Calendar.new(Date.civil(@year, @month, 1), current_language, :month)
428 430 retrieve_query
429 431 if @query.valid?
430 432 events = []
431 433 events += @query.issues(:include => [:tracker, :assigned_to, :priority],
432 434 :conditions => ["((start_date BETWEEN ? AND ?) OR (due_date BETWEEN ? AND ?))", @calendar.startdt, @calendar.enddt, @calendar.startdt, @calendar.enddt]
433 435 )
434 436 events += @query.versions(:conditions => ["effective_date BETWEEN ? AND ?", @calendar.startdt, @calendar.enddt])
435 437
436 438 @calendar.events = events
437 439 end
438 440
439 441 render :layout => false if request.xhr?
440 442 end
441 443
442 444 def context_menu
443 445 @issues = Issue.find_all_by_id(params[:ids], :include => :project)
444 446 if (@issues.size == 1)
445 447 @issue = @issues.first
446 448 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
447 449 end
448 450 projects = @issues.collect(&:project).compact.uniq
449 451 @project = projects.first if projects.size == 1
450 452
451 453 @can = {:edit => (@project && User.current.allowed_to?(:edit_issues, @project)),
452 454 :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
453 455 :update => (@project && (User.current.allowed_to?(:edit_issues, @project) || (User.current.allowed_to?(:change_status, @project) && @allowed_statuses && !@allowed_statuses.empty?))),
454 456 :move => (@project && User.current.allowed_to?(:move_issues, @project)),
455 457 :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
456 458 :delete => (@project && User.current.allowed_to?(:delete_issues, @project))
457 459 }
458 460 if @project
459 461 @assignables = @project.assignable_users
460 462 @assignables << @issue.assigned_to if @issue && @issue.assigned_to && !@assignables.include?(@issue.assigned_to)
461 463 @trackers = @project.trackers
462 464 end
463 465
464 466 @priorities = IssuePriority.all.reverse
465 467 @statuses = IssueStatus.find(:all, :order => 'position')
466 468 @back = params[:back_url] || request.env['HTTP_REFERER']
467 469
468 470 render :layout => false
469 471 end
470 472
471 473 def update_form
472 474 if params[:id].blank?
473 475 @issue = Issue.new
474 476 @issue.project = @project
475 477 else
476 478 @issue = @project.issues.visible.find(params[:id])
477 479 end
478 480 @issue.attributes = params[:issue]
479 481 @allowed_statuses = ([@issue.status] + @issue.status.find_new_statuses_allowed_to(User.current.roles_for_project(@project), @issue.tracker)).uniq
480 482 @priorities = IssuePriority.all
481 483
482 484 render :partial => 'attributes'
483 485 end
484 486
485 487 def preview
486 488 @issue = @project.issues.find_by_id(params[:id]) unless params[:id].blank?
487 489 @attachements = @issue.attachments if @issue
488 490 @text = params[:notes] || (params[:issue] ? params[:issue][:description] : nil)
489 491 render :partial => 'common/preview'
490 492 end
491 493
492 494 private
493 495 def find_issue
494 496 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
495 497 @project = @issue.project
496 498 rescue ActiveRecord::RecordNotFound
497 499 render_404
498 500 end
499 501
500 502 # Filter for bulk operations
501 503 def find_issues
502 504 @issues = Issue.find_all_by_id(params[:id] || params[:ids])
503 505 raise ActiveRecord::RecordNotFound if @issues.empty?
504 506 projects = @issues.collect(&:project).compact.uniq
505 507 if projects.size == 1
506 508 @project = projects.first
507 509 else
508 510 # TODO: let users bulk edit/move/destroy issues from different projects
509 511 render_error 'Can not bulk edit/move/destroy issues from different projects'
510 512 return false
511 513 end
512 514 rescue ActiveRecord::RecordNotFound
513 515 render_404
514 516 end
515 517
516 518 def find_project
517 519 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
518 520 @project = Project.find(project_id)
519 521 rescue ActiveRecord::RecordNotFound
520 522 render_404
521 523 end
522 524
523 525 def find_optional_project
524 526 @project = Project.find(params[:project_id]) unless params[:project_id].blank?
525 527 allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true)
526 528 allowed ? true : deny_access
527 529 rescue ActiveRecord::RecordNotFound
528 530 render_404
529 531 end
530 532
531 533 # Retrieve query from session or build a new query
532 534 def retrieve_query
533 535 if !params[:query_id].blank?
534 536 cond = "project_id IS NULL"
535 537 cond << " OR project_id = #{@project.id}" if @project
536 538 @query = Query.find(params[:query_id], :conditions => cond)
537 539 @query.project = @project
538 540 session[:query] = {:id => @query.id, :project_id => @query.project_id}
539 541 sort_clear
540 542 else
541 543 if api_request? || params[:set_filter] || session[:query].nil? || session[:query][:project_id] != (@project ? @project.id : nil)
542 544 # Give it a name, required to be valid
543 545 @query = Query.new(:name => "_")
544 546 @query.project = @project
545 547 if params[:fields] and params[:fields].is_a? Array
546 548 params[:fields].each do |field|
547 549 @query.add_filter(field, params[:operators][field], params[:values][field])
548 550 end
549 551 else
550 552 @query.available_filters.keys.each do |field|
551 553 @query.add_short_filter(field, params[field]) if params[field]
552 554 end
553 555 end
554 556 @query.group_by = params[:group_by]
555 557 @query.column_names = params[:query] && params[:query][:column_names]
556 558 session[:query] = {:project_id => @query.project_id, :filters => @query.filters, :group_by => @query.group_by, :column_names => @query.column_names}
557 559 else
558 560 @query = Query.find_by_id(session[:query][:id]) if session[:query][:id]
559 561 @query ||= Query.new(:name => "_", :project => @project, :filters => session[:query][:filters], :group_by => session[:query][:group_by], :column_names => session[:query][:column_names])
560 562 @query.project = @project
561 563 end
562 564 end
563 565 end
564 566
565 567 # Rescues an invalid query statement. Just in case...
566 568 def query_statement_invalid(exception)
567 569 logger.error "Query::StatementInvalid: #{exception.message}" if logger
568 570 session.delete(:query)
569 571 sort_clear
570 572 render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator."
571 573 end
572 574 end
General Comments 0
You need to be logged in to leave comments. Login now