##// END OF EJS Templates
jro_apps » redmine
RSS
Refactor: extract test method...
Eric Davis -
r3659:cf334cee3189
parent child
Show More
Side by Side Unified
Context file:
r3659:cf334cee3189 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,21 +1,17
1 1 class Attachment < ActiveRecord::Base
2 2 generator_for :container, :method => :generate_project
3 3 generator_for :file, :method => :generate_file
4 4 generator_for :author, :method => :generate_author
5 5
6 6 def self.generate_project
7 7 Project.generate!
8 8 end
9 9
10 10 def self.generate_author
11 11 User.generate_with_protected!
12 12 end
13 13
14 14 def self.generate_file
15 @file = 'a_file.png'
16 @file.stubs(:original_filename).returns('a_file.png')
17 @file.stubs(:content_type).returns('image/png')
18 @file.stubs(:read).returns(false)
19 @file
15 @file = mock_file
20 16 end
21 17 end
Show file before | Show file after | Hide comments
@@ -1,155 +1,165
1 1 # redMine - project management software
2 2 # Copyright (C) 2006 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 ENV["RAILS_ENV"] ||= "test"
19 19 require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
20 20 require 'test_help'
21 21 require File.expand_path(File.dirname(__FILE__) + '/helper_testcase')
22 22 require File.join(RAILS_ROOT,'test', 'mocks', 'open_id_authentication_mock.rb')
23 23
24 24 require File.expand_path(File.dirname(__FILE__) + '/object_daddy_helpers')
25 25 include ObjectDaddyHelpers
26 26
27 27 class ActiveSupport::TestCase
28 28 # Transactional fixtures accelerate your tests by wrapping each test method
29 29 # in a transaction that's rolled back on completion. This ensures that the
30 30 # test database remains unchanged so your fixtures don't have to be reloaded
31 31 # between every test method. Fewer database queries means faster tests.
32 32 #
33 33 # Read Mike Clark's excellent walkthrough at
34 34 # http://clarkware.com/cgi/blosxom/2005/10/24#Rails10FastTesting
35 35 #
36 36 # Every Active Record database supports transactions except MyISAM tables
37 37 # in MySQL. Turn off transactional fixtures in this case; however, if you
38 38 # don't care one way or the other, switching from MyISAM to InnoDB tables
39 39 # is recommended.
40 40 self.use_transactional_fixtures = true
41 41
42 42 # Instantiated fixtures are slow, but give you @david where otherwise you
43 43 # would need people(:david). If you don't want to migrate your existing
44 44 # test cases which use the @david style and don't mind the speed hit (each
45 45 # instantiated fixtures translates to a database query per test method),
46 46 # then set this back to true.
47 47 self.use_instantiated_fixtures = false
48 48
49 49 # Add more helper methods to be used by all tests here...
50 50
51 51 def log_user(login, password)
52 52 User.anonymous
53 53 get "/login"
54 54 assert_equal nil, session[:user_id]
55 55 assert_response :success
56 56 assert_template "account/login"
57 57 post "/login", :username => login, :password => password
58 58 assert_equal login, User.find(session[:user_id]).login
59 59 end
60 60
61 61 def uploaded_test_file(name, mime)
62 62 ActionController::TestUploadedFile.new(ActiveSupport::TestCase.fixture_path + "/files/#{name}", mime)
63 63 end
64 64
65 # Mock out a file
66 def mock_file
67 file = 'a_file.png'
68 file.stubs(:size).returns(32)
69 file.stubs(:original_filename).returns('a_file.png')
70 file.stubs(:content_type).returns('image/png')
71 file.stubs(:read).returns(false)
72 file
73 end
74
65 75 # Use a temporary directory for attachment related tests
66 76 def set_tmp_attachments_directory
67 77 Dir.mkdir "#{RAILS_ROOT}/tmp/test" unless File.directory?("#{RAILS_ROOT}/tmp/test")
68 78 Dir.mkdir "#{RAILS_ROOT}/tmp/test/attachments" unless File.directory?("#{RAILS_ROOT}/tmp/test/attachments")
69 79 Attachment.storage_path = "#{RAILS_ROOT}/tmp/test/attachments"
70 80 end
71 81
72 82 def with_settings(options, &block)
73 83 saved_settings = options.keys.inject({}) {|h, k| h[k] = Setting[k].dup; h}
74 84 options.each {|k, v| Setting[k] = v}
75 85 yield
76 86 saved_settings.each {|k, v| Setting[k] = v}
77 87 end
78 88
79 89 def self.ldap_configured?
80 90 @test_ldap = Net::LDAP.new(:host => '127.0.0.1', :port => 389)
81 91 return @test_ldap.bind
82 92 rescue Exception => e
83 93 # LDAP is not listening
84 94 return nil
85 95 end
86 96
87 97 # Returns the path to the test +vendor+ repository
88 98 def self.repository_path(vendor)
89 99 File.join(RAILS_ROOT.gsub(%r{config\/\.\.}, ''), "/tmp/test/#{vendor.downcase}_repository")
90 100 end
91 101
92 102 # Returns true if the +vendor+ test repository is configured
93 103 def self.repository_configured?(vendor)
94 104 File.directory?(repository_path(vendor))
95 105 end
96 106
97 107 # Shoulda macros
98 108 def self.should_render_404
99 109 should_respond_with :not_found
100 110 should_render_template 'common/404'
101 111 end
102 112
103 113 def self.should_have_before_filter(expected_method, options = {})
104 114 should_have_filter('before', expected_method, options)
105 115 end
106 116
107 117 def self.should_have_after_filter(expected_method, options = {})
108 118 should_have_filter('after', expected_method, options)
109 119 end
110 120
111 121 def self.should_have_filter(filter_type, expected_method, options)
112 122 description = "have #{filter_type}_filter :#{expected_method}"
113 123 description << " with #{options.inspect}" unless options.empty?
114 124
115 125 should description do
116 126 klass = "action_controller/filters/#{filter_type}_filter".classify.constantize
117 127 expected = klass.new(:filter, expected_method.to_sym, options)
118 128 assert_equal 1, @controller.class.filter_chain.select { |filter|
119 129 filter.method == expected.method && filter.kind == expected.kind &&
120 130 filter.options == expected.options && filter.class == expected.class
121 131 }.size
122 132 end
123 133 end
124 134
125 135 def self.should_show_the_old_and_new_values_for(prop_key, model, &block)
126 136 context "" do
127 137 setup do
128 138 if block_given?
129 139 instance_eval &block
130 140 else
131 141 @old_value = model.generate!
132 142 @new_value = model.generate!
133 143 end
134 144 end
135 145
136 146 should "use the new value's name" do
137 147 @detail = JournalDetail.generate!(:property => 'attr',
138 148 :old_value => @old_value.id,
139 149 :value => @new_value.id,
140 150 :prop_key => prop_key)
141 151
142 152 assert_match @new_value.name, show_detail(@detail, true)
143 153 end
144 154
145 155 should "use the old value's name" do
146 156 @detail = JournalDetail.generate!(:property => 'attr',
147 157 :old_value => @old_value.id,
148 158 :value => @new_value.id,
149 159 :prop_key => prop_key)
150 160
151 161 assert_match @old_value.name, show_detail(@detail, true)
152 162 end
153 163 end
154 164 end
155 165 end
Show file before | Show file after | Hide comments
@@ -1,92 +1,85
1 1 # encoding: utf-8
2 2 #
3 3 # redMine - project management software
4 4 # Copyright (C) 2006-2007 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 require File.dirname(__FILE__) + '/../test_helper'
21 21
22 22 class AttachmentTest < ActiveSupport::TestCase
23 23 fixtures :issues, :users
24 24
25 25 def setup
26 26 end
27 27
28 28 def test_create
29 29 a = Attachment.new(:container => Issue.find(1),
30 30 :file => uploaded_test_file("testfile.txt", "text/plain"),
31 31 :author => User.find(1))
32 32 assert a.save
33 33 assert_equal 'testfile.txt', a.filename
34 34 assert_equal 59, a.filesize
35 35 assert_equal 'text/plain', a.content_type
36 36 assert_equal 0, a.downloads
37 37 assert_equal Digest::MD5.hexdigest(uploaded_test_file("testfile.txt", "text/plain").read), a.digest
38 38 assert File.exist?(a.diskfile)
39 39 end
40 40
41 41 def test_create_should_auto_assign_content_type
42 42 a = Attachment.new(:container => Issue.find(1),
43 43 :file => uploaded_test_file("testfile.txt", ""),
44 44 :author => User.find(1))
45 45 assert a.save
46 46 assert_equal 'text/plain', a.content_type
47 47 end
48 48
49 49 def test_identical_attachments_at_the_same_time_should_not_overwrite
50 50 a1 = Attachment.create!(:container => Issue.find(1),
51 51 :file => uploaded_test_file("testfile.txt", ""),
52 52 :author => User.find(1))
53 53 a2 = Attachment.create!(:container => Issue.find(1),
54 54 :file => uploaded_test_file("testfile.txt", ""),
55 55 :author => User.find(1))
56 56 assert a1.disk_filename != a2.disk_filename
57 57 end
58 58
59 59 def test_diskfilename
60 60 assert Attachment.disk_filename("test_file.txt") =~ /^\d{12}_test_file.txt$/
61 61 assert_equal 'test_file.txt', Attachment.disk_filename("test_file.txt")[13..-1]
62 62 assert_equal '770c509475505f37c2b8fb6030434d6b.txt', Attachment.disk_filename("test_accentué.txt")[13..-1]
63 63 assert_equal 'f8139524ebb8f32e51976982cd20a85d', Attachment.disk_filename("test_accentué")[13..-1]
64 64 assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', Attachment.disk_filename("test_accentué.ça")[13..-1]
65 65 end
66 66
67 67 context "Attachmnet#attach_files" do
68 68 should "add unsaved files to the object as unsaved attachments" do
69 69 # Max size of 0 to force Attachment creation failures
70 70 with_settings(:attachment_max_size => 0) do
71 # Mock out a file
72 @file = 'a_file.png'
73 @file.stubs(:size).returns(32)
74 @file.stubs(:original_filename).returns('a_file.png')
75 @file.stubs(:content_type).returns('image/png')
76 @file.stubs(:read).returns(false)
77
78 71 @project = Project.generate!
79 72 response = Attachment.attach_files(@project, {
80 '1' => {'file' => @file, 'description' => 'test'},
81 '2' => {'file' => @file, 'description' => 'test'}
73 '1' => {'file' => mock_file, 'description' => 'test'},
74 '2' => {'file' => mock_file, 'description' => 'test'}
82 75 })
83 76
84 77 assert response[:unsaved].present?
85 78 assert_equal 2, response[:unsaved].length
86 79 assert response[:unsaved].first.new_record?
87 80 assert response[:unsaved].second.new_record?
88 81 assert_equal response[:unsaved], @project.unsaved_attachments
89 82 end
90 83 end
91 84 end
92 85 end
General Comments 0
You need to be logged in to leave comments. Login now