jro_apps/redmine Commit - r13543:cb8639a7b22f

Don't change Setting.default_language in Mailer tests....

Jean-Philippe Lang -

r13543:cb8639a7b22f

parent child

Context file:

r13543:cb8639a7b22f

Collapse all files

test/unit/mailer_test.rb +18 -24

                  Setting.host_name = 'mydomain.foo'
                  Setting.protocol = 'http'
                  Setting.plain_text_mail = '0'
+                 Setting.default_language = 'en'
                  User.current = nil
                end
                def test_generated_links_in_emails
-                 Setting.default_language = 'en'
                  Setting.host_name = 'mydomain.foo'
                  Setting.protocol = 'https'
                end
                def test_generated_links_with_prefix
-                 Setting.default_language = 'en'
                  relative_url_root = Redmine::Utils.relative_url_root
                  Setting.host_name = 'mydomain.foo/rdm'
                  Setting.protocol = 'http'
                end
                def test_generated_links_with_prefix_and_no_relative_url_root
-                 Setting.default_language = 'en'
                  relative_url_root = Redmine::Utils.relative_url_root
                  Setting.host_name = 'mydomain.foo/rdm'
                  Setting.protocol = 'http'
                end
                def test_issue_add_should_include_enabled_fields
-                 Setting.default_language = 'en'
                  issue = Issue.find(2)
                  assert Mailer.deliver_issue_add(issue)
                  assert_mail_body_match '* Target version: 1.0', last_email
                end
                def test_issue_add_should_not_include_disabled_fields
-                 Setting.default_language = 'en'
                  issue = Issue.find(2)
                  tracker = issue.tracker
                  tracker.core_fields -= ['fixed_version_id']
                # test mailer methods for each language
                def test_issue_add
                  issue = Issue.find(1)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.deliver_issue_add(issue)
                  end
                end
                def test_issue_edit
                  journal = Journal.find(1)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.deliver_issue_edit(journal)
                  end
                end
                def test_document_added
                  document = Document.find(1)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.document_added(document).deliver
                  end
                end
                def test_attachments_added
                  attachements = [ Attachment.find_by_container_type('Document') ]
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.attachments_added(attachements).deliver
                  end
                end
                def test_news_added
                  news = News.first
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.news_added(news).deliver
                  end
                end
                def test_news_comment_added
                  comment = Comment.find(2)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.news_comment_added(comment).deliver
                  end
                end
                  message = Message.first
                  recipients = ([message.root] + message.root.children).collect {|m| m.author.mail if m.author}
                  recipients = recipients.compact.uniq
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert Mailer.message_posted(message).deliver
                  end
                end
                def test_wiki_content_added
                  content = WikiContent.find(1)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert_difference 'ActionMailer::Base.deliveries.size' do
                      assert Mailer.wiki_content_added(content).deliver
                      assert_select_email do
                def test_wiki_content_updated
                  content = WikiContent.find(1)
-                 valid_languages.each do |lang|
-                   Setting.default_language = lang.to_s
+                 with_each_language_as_default do
                    assert_difference 'ActionMailer::Base.deliveries.size' do
                      assert Mailer.wiki_content_updated(content).deliver
                      assert_select_email do
                end
                def test_mailer_should_not_change_locale
-                 Setting.default_language = 'en'
                  # Set current language to italian
                  set_language_if_valid 'it'
                  # Send an email to a french user
                def html_part
                  last_email.parts.detect {|part| part.content_type.include?('text/html')}
                end
+               def with_each_language_as_default(&block)
+                 valid_languages.each do |lang|
+                   with_settings :default_language => lang.to_s do
+                     yield lang
+                   end
+                 end
+               end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages