##// END OF EJS Templates
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
Jean-Philippe Lang -
r11283:caf61dc923cf
parent child
Show More
@@ -1,1424 +1,1431
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Issue < ActiveRecord::Base
18 class Issue < ActiveRecord::Base
19 include Redmine::SafeAttributes
19 include Redmine::SafeAttributes
20 include Redmine::Utils::DateCalculation
20 include Redmine::Utils::DateCalculation
21
21
22 belongs_to :project
22 belongs_to :project
23 belongs_to :tracker
23 belongs_to :tracker
24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30
30
31 has_many :journals, :as => :journalized, :dependent => :destroy
31 has_many :journals, :as => :journalized, :dependent => :destroy
32 has_many :visible_journals,
32 has_many :visible_journals,
33 :class_name => 'Journal',
33 :class_name => 'Journal',
34 :as => :journalized,
34 :as => :journalized,
35 :conditions => Proc.new {
35 :conditions => Proc.new {
36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 },
37 },
38 :readonly => true
38 :readonly => true
39
39
40 has_many :time_entries, :dependent => :delete_all
40 has_many :time_entries, :dependent => :delete_all
41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42
42
43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45
45
46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 acts_as_customizable
48 acts_as_customizable
49 acts_as_watchable
49 acts_as_watchable
50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 :include => [:project, :visible_journals],
51 :include => [:project, :visible_journals],
52 # sort by id so that limited eager loading doesn't break with postgresql
52 # sort by id so that limited eager loading doesn't break with postgresql
53 :order_column => "#{table_name}.id"
53 :order_column => "#{table_name}.id"
54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57
57
58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 :author_key => :author_id
59 :author_key => :author_id
60
60
61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62
62
63 attr_reader :current_journal
63 attr_reader :current_journal
64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65
65
66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67
67
68 validates_length_of :subject, :maximum => 255
68 validates_length_of :subject, :maximum => 255
69 validates_inclusion_of :done_ratio, :in => 0..100
69 validates_inclusion_of :done_ratio, :in => 0..100
70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 validates :start_date, :date => true
71 validates :start_date, :date => true
72 validates :due_date, :date => true
72 validates :due_date, :date => true
73 validate :validate_issue, :validate_required_fields
73 validate :validate_issue, :validate_required_fields
74
74
75 scope :visible, lambda {|*args|
75 scope :visible, lambda {|*args|
76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 }
77 }
78
78
79 scope :open, lambda {|*args|
79 scope :open, lambda {|*args|
80 is_closed = args.size > 0 ? !args.first : false
80 is_closed = args.size > 0 ? !args.first : false
81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 }
82 }
83
83
84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 scope :on_active_project, lambda {
85 scope :on_active_project, lambda {
86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 }
87 }
88 scope :fixed_version, lambda {|versions|
88 scope :fixed_version, lambda {|versions|
89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 }
91 }
92
92
93 before_create :default_assign
93 before_create :default_assign
94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 # Should be after_create but would be called before previous after_save callbacks
97 # Should be after_create but would be called before previous after_save callbacks
98 after_save :after_create_from_copy
98 after_save :after_create_from_copy
99 after_destroy :update_parent_attributes
99 after_destroy :update_parent_attributes
100
100
101 # Returns a SQL conditions string used to find all issues visible by the specified user
101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 def self.visible_condition(user, options={})
102 def self.visible_condition(user, options={})
103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 if user.logged?
104 if user.logged?
105 case role.issues_visibility
105 case role.issues_visibility
106 when 'all'
106 when 'all'
107 nil
107 nil
108 when 'default'
108 when 'default'
109 user_ids = [user.id] + user.groups.map(&:id)
109 user_ids = [user.id] + user.groups.map(&:id)
110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 when 'own'
111 when 'own'
112 user_ids = [user.id] + user.groups.map(&:id)
112 user_ids = [user.id] + user.groups.map(&:id)
113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 else
114 else
115 '1=0'
115 '1=0'
116 end
116 end
117 else
117 else
118 "(#{table_name}.is_private = #{connection.quoted_false})"
118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 end
119 end
120 end
120 end
121 end
121 end
122
122
123 # Returns true if usr or current user is allowed to view the issue
123 # Returns true if usr or current user is allowed to view the issue
124 def visible?(usr=nil)
124 def visible?(usr=nil)
125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 if user.logged?
126 if user.logged?
127 case role.issues_visibility
127 case role.issues_visibility
128 when 'all'
128 when 'all'
129 true
129 true
130 when 'default'
130 when 'default'
131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 when 'own'
132 when 'own'
133 self.author == user || user.is_or_belongs_to?(assigned_to)
133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 else
134 else
135 false
135 false
136 end
136 end
137 else
137 else
138 !self.is_private?
138 !self.is_private?
139 end
139 end
140 end
140 end
141 end
141 end
142
142
143 # Returns true if user or current user is allowed to edit or add a note to the issue
143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 def editable?(user=User.current)
144 def editable?(user=User.current)
145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 end
146 end
147
147
148 def initialize(attributes=nil, *args)
148 def initialize(attributes=nil, *args)
149 super
149 super
150 if new_record?
150 if new_record?
151 # set default values for new records only
151 # set default values for new records only
152 self.status ||= IssueStatus.default
152 self.status ||= IssueStatus.default
153 self.priority ||= IssuePriority.default
153 self.priority ||= IssuePriority.default
154 self.watcher_user_ids = []
154 self.watcher_user_ids = []
155 end
155 end
156 end
156 end
157
157
158 def create_or_update
158 def create_or_update
159 super
159 super
160 ensure
160 ensure
161 @status_was = nil
161 @status_was = nil
162 end
162 end
163 private :create_or_update
163 private :create_or_update
164
164
165 # AR#Persistence#destroy would raise and RecordNotFound exception
165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 # if the issue was already deleted or updated (non matching lock_version).
166 # if the issue was already deleted or updated (non matching lock_version).
167 # This is a problem when bulk deleting issues or deleting a project
167 # This is a problem when bulk deleting issues or deleting a project
168 # (because an issue may already be deleted if its parent was deleted
168 # (because an issue may already be deleted if its parent was deleted
169 # first).
169 # first).
170 # The issue is reloaded by the nested_set before being deleted so
170 # The issue is reloaded by the nested_set before being deleted so
171 # the lock_version condition should not be an issue but we handle it.
171 # the lock_version condition should not be an issue but we handle it.
172 def destroy
172 def destroy
173 super
173 super
174 rescue ActiveRecord::RecordNotFound
174 rescue ActiveRecord::RecordNotFound
175 # Stale or already deleted
175 # Stale or already deleted
176 begin
176 begin
177 reload
177 reload
178 rescue ActiveRecord::RecordNotFound
178 rescue ActiveRecord::RecordNotFound
179 # The issue was actually already deleted
179 # The issue was actually already deleted
180 @destroyed = true
180 @destroyed = true
181 return freeze
181 return freeze
182 end
182 end
183 # The issue was stale, retry to destroy
183 # The issue was stale, retry to destroy
184 super
184 super
185 end
185 end
186
186
187 alias :base_reload :reload
187 alias :base_reload :reload
188 def reload(*args)
188 def reload(*args)
189 @workflow_rule_by_attribute = nil
189 @workflow_rule_by_attribute = nil
190 @assignable_versions = nil
190 @assignable_versions = nil
191 @relations = nil
191 @relations = nil
192 base_reload(*args)
192 base_reload(*args)
193 end
193 end
194
194
195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
196 def available_custom_fields
196 def available_custom_fields
197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
198 end
198 end
199
199
200 # Copies attributes from another issue, arg can be an id or an Issue
200 # Copies attributes from another issue, arg can be an id or an Issue
201 def copy_from(arg, options={})
201 def copy_from(arg, options={})
202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
205 self.status = issue.status
205 self.status = issue.status
206 self.author = User.current
206 self.author = User.current
207 unless options[:attachments] == false
207 unless options[:attachments] == false
208 self.attachments = issue.attachments.map do |attachement|
208 self.attachments = issue.attachments.map do |attachement|
209 attachement.copy(:container => self)
209 attachement.copy(:container => self)
210 end
210 end
211 end
211 end
212 @copied_from = issue
212 @copied_from = issue
213 @copy_options = options
213 @copy_options = options
214 self
214 self
215 end
215 end
216
216
217 # Returns an unsaved copy of the issue
217 # Returns an unsaved copy of the issue
218 def copy(attributes=nil, copy_options={})
218 def copy(attributes=nil, copy_options={})
219 copy = self.class.new.copy_from(self, copy_options)
219 copy = self.class.new.copy_from(self, copy_options)
220 copy.attributes = attributes if attributes
220 copy.attributes = attributes if attributes
221 copy
221 copy
222 end
222 end
223
223
224 # Returns true if the issue is a copy
224 # Returns true if the issue is a copy
225 def copy?
225 def copy?
226 @copied_from.present?
226 @copied_from.present?
227 end
227 end
228
228
229 # Moves/copies an issue to a new project and tracker
229 # Moves/copies an issue to a new project and tracker
230 # Returns the moved/copied issue on success, false on failure
230 # Returns the moved/copied issue on success, false on failure
231 def move_to_project(new_project, new_tracker=nil, options={})
231 def move_to_project(new_project, new_tracker=nil, options={})
232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
233
233
234 if options[:copy]
234 if options[:copy]
235 issue = self.copy
235 issue = self.copy
236 else
236 else
237 issue = self
237 issue = self
238 end
238 end
239
239
240 issue.init_journal(User.current, options[:notes])
240 issue.init_journal(User.current, options[:notes])
241
241
242 # Preserve previous behaviour
242 # Preserve previous behaviour
243 # #move_to_project doesn't change tracker automatically
243 # #move_to_project doesn't change tracker automatically
244 issue.send :project=, new_project, true
244 issue.send :project=, new_project, true
245 if new_tracker
245 if new_tracker
246 issue.tracker = new_tracker
246 issue.tracker = new_tracker
247 end
247 end
248 # Allow bulk setting of attributes on the issue
248 # Allow bulk setting of attributes on the issue
249 if options[:attributes]
249 if options[:attributes]
250 issue.attributes = options[:attributes]
250 issue.attributes = options[:attributes]
251 end
251 end
252
252
253 issue.save ? issue : false
253 issue.save ? issue : false
254 end
254 end
255
255
256 def status_id=(sid)
256 def status_id=(sid)
257 self.status = nil
257 self.status = nil
258 result = write_attribute(:status_id, sid)
258 result = write_attribute(:status_id, sid)
259 @workflow_rule_by_attribute = nil
259 @workflow_rule_by_attribute = nil
260 result
260 result
261 end
261 end
262
262
263 def priority_id=(pid)
263 def priority_id=(pid)
264 self.priority = nil
264 self.priority = nil
265 write_attribute(:priority_id, pid)
265 write_attribute(:priority_id, pid)
266 end
266 end
267
267
268 def category_id=(cid)
268 def category_id=(cid)
269 self.category = nil
269 self.category = nil
270 write_attribute(:category_id, cid)
270 write_attribute(:category_id, cid)
271 end
271 end
272
272
273 def fixed_version_id=(vid)
273 def fixed_version_id=(vid)
274 self.fixed_version = nil
274 self.fixed_version = nil
275 write_attribute(:fixed_version_id, vid)
275 write_attribute(:fixed_version_id, vid)
276 end
276 end
277
277
278 def tracker_id=(tid)
278 def tracker_id=(tid)
279 self.tracker = nil
279 self.tracker = nil
280 result = write_attribute(:tracker_id, tid)
280 result = write_attribute(:tracker_id, tid)
281 @custom_field_values = nil
281 @custom_field_values = nil
282 @workflow_rule_by_attribute = nil
282 @workflow_rule_by_attribute = nil
283 result
283 result
284 end
284 end
285
285
286 def project_id=(project_id)
286 def project_id=(project_id)
287 if project_id.to_s != self.project_id.to_s
287 if project_id.to_s != self.project_id.to_s
288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
289 end
289 end
290 end
290 end
291
291
292 def project=(project, keep_tracker=false)
292 def project=(project, keep_tracker=false)
293 project_was = self.project
293 project_was = self.project
294 write_attribute(:project_id, project ? project.id : nil)
294 write_attribute(:project_id, project ? project.id : nil)
295 association_instance_set('project', project)
295 association_instance_set('project', project)
296 if project_was && project && project_was != project
296 if project_was && project && project_was != project
297 @assignable_versions = nil
297 @assignable_versions = nil
298
298
299 unless keep_tracker || project.trackers.include?(tracker)
299 unless keep_tracker || project.trackers.include?(tracker)
300 self.tracker = project.trackers.first
300 self.tracker = project.trackers.first
301 end
301 end
302 # Reassign to the category with same name if any
302 # Reassign to the category with same name if any
303 if category
303 if category
304 self.category = project.issue_categories.find_by_name(category.name)
304 self.category = project.issue_categories.find_by_name(category.name)
305 end
305 end
306 # Keep the fixed_version if it's still valid in the new_project
306 # Keep the fixed_version if it's still valid in the new_project
307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
308 self.fixed_version = nil
308 self.fixed_version = nil
309 end
309 end
310 # Clear the parent task if it's no longer valid
310 # Clear the parent task if it's no longer valid
311 unless valid_parent_project?
311 unless valid_parent_project?
312 self.parent_issue_id = nil
312 self.parent_issue_id = nil
313 end
313 end
314 @custom_field_values = nil
314 @custom_field_values = nil
315 end
315 end
316 end
316 end
317
317
318 def description=(arg)
318 def description=(arg)
319 if arg.is_a?(String)
319 if arg.is_a?(String)
320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
321 end
321 end
322 write_attribute(:description, arg)
322 write_attribute(:description, arg)
323 end
323 end
324
324
325 # Overrides assign_attributes so that project and tracker get assigned first
325 # Overrides assign_attributes so that project and tracker get assigned first
326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
327 return if new_attributes.nil?
327 return if new_attributes.nil?
328 attrs = new_attributes.dup
328 attrs = new_attributes.dup
329 attrs.stringify_keys!
329 attrs.stringify_keys!
330
330
331 %w(project project_id tracker tracker_id).each do |attr|
331 %w(project project_id tracker tracker_id).each do |attr|
332 if attrs.has_key?(attr)
332 if attrs.has_key?(attr)
333 send "#{attr}=", attrs.delete(attr)
333 send "#{attr}=", attrs.delete(attr)
334 end
334 end
335 end
335 end
336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
337 end
337 end
338 # Do not redefine alias chain on reload (see #4838)
338 # Do not redefine alias chain on reload (see #4838)
339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
340
340
341 def estimated_hours=(h)
341 def estimated_hours=(h)
342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
343 end
343 end
344
344
345 safe_attributes 'project_id',
345 safe_attributes 'project_id',
346 :if => lambda {|issue, user|
346 :if => lambda {|issue, user|
347 if issue.new_record?
347 if issue.new_record?
348 issue.copy?
348 issue.copy?
349 elsif user.allowed_to?(:move_issues, issue.project)
349 elsif user.allowed_to?(:move_issues, issue.project)
350 projects = Issue.allowed_target_projects_on_move(user)
350 projects = Issue.allowed_target_projects_on_move(user)
351 projects.include?(issue.project) && projects.size > 1
351 projects.include?(issue.project) && projects.size > 1
352 end
352 end
353 }
353 }
354
354
355 safe_attributes 'tracker_id',
355 safe_attributes 'tracker_id',
356 'status_id',
356 'status_id',
357 'category_id',
357 'category_id',
358 'assigned_to_id',
358 'assigned_to_id',
359 'priority_id',
359 'priority_id',
360 'fixed_version_id',
360 'fixed_version_id',
361 'subject',
361 'subject',
362 'description',
362 'description',
363 'start_date',
363 'start_date',
364 'due_date',
364 'due_date',
365 'done_ratio',
365 'done_ratio',
366 'estimated_hours',
366 'estimated_hours',
367 'custom_field_values',
367 'custom_field_values',
368 'custom_fields',
368 'custom_fields',
369 'lock_version',
369 'lock_version',
370 'notes',
370 'notes',
371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
372
372
373 safe_attributes 'status_id',
373 safe_attributes 'status_id',
374 'assigned_to_id',
374 'assigned_to_id',
375 'fixed_version_id',
375 'fixed_version_id',
376 'done_ratio',
376 'done_ratio',
377 'lock_version',
377 'lock_version',
378 'notes',
378 'notes',
379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
380
380
381 safe_attributes 'notes',
381 safe_attributes 'notes',
382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
383
383
384 safe_attributes 'private_notes',
384 safe_attributes 'private_notes',
385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
386
386
387 safe_attributes 'watcher_user_ids',
387 safe_attributes 'watcher_user_ids',
388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
389
389
390 safe_attributes 'is_private',
390 safe_attributes 'is_private',
391 :if => lambda {|issue, user|
391 :if => lambda {|issue, user|
392 user.allowed_to?(:set_issues_private, issue.project) ||
392 user.allowed_to?(:set_issues_private, issue.project) ||
393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
394 }
394 }
395
395
396 safe_attributes 'parent_issue_id',
396 safe_attributes 'parent_issue_id',
397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
398 user.allowed_to?(:manage_subtasks, issue.project)}
398 user.allowed_to?(:manage_subtasks, issue.project)}
399
399
400 def safe_attribute_names(user=nil)
400 def safe_attribute_names(user=nil)
401 names = super
401 names = super
402 names -= disabled_core_fields
402 names -= disabled_core_fields
403 names -= read_only_attribute_names(user)
403 names -= read_only_attribute_names(user)
404 names
404 names
405 end
405 end
406
406
407 # Safely sets attributes
407 # Safely sets attributes
408 # Should be called from controllers instead of #attributes=
408 # Should be called from controllers instead of #attributes=
409 # attr_accessible is too rough because we still want things like
409 # attr_accessible is too rough because we still want things like
410 # Issue.new(:project => foo) to work
410 # Issue.new(:project => foo) to work
411 def safe_attributes=(attrs, user=User.current)
411 def safe_attributes=(attrs, user=User.current)
412 return unless attrs.is_a?(Hash)
412 return unless attrs.is_a?(Hash)
413
413
414 attrs = attrs.dup
414 attrs = attrs.dup
415
415
416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
419 self.project_id = p
419 self.project_id = p
420 end
420 end
421 end
421 end
422
422
423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
424 self.tracker_id = t
424 self.tracker_id = t
425 end
425 end
426
426
427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
429 self.status_id = s
429 self.status_id = s
430 end
430 end
431 end
431 end
432
432
433 attrs = delete_unsafe_attributes(attrs, user)
433 attrs = delete_unsafe_attributes(attrs, user)
434 return if attrs.empty?
434 return if attrs.empty?
435
435
436 unless leaf?
436 unless leaf?
437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
438 end
438 end
439
439
440 if attrs['parent_issue_id'].present?
440 if attrs['parent_issue_id'].present?
441 s = attrs['parent_issue_id'].to_s
441 s = attrs['parent_issue_id'].to_s
442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
444 end
444 end
445 end
445 end
446
446
447 if attrs['custom_field_values'].present?
447 if attrs['custom_field_values'].present?
448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
449 end
449 end
450
450
451 if attrs['custom_fields'].present?
451 if attrs['custom_fields'].present?
452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
453 end
453 end
454
454
455 # mass-assignment security bypass
455 # mass-assignment security bypass
456 assign_attributes attrs, :without_protection => true
456 assign_attributes attrs, :without_protection => true
457 end
457 end
458
458
459 def disabled_core_fields
459 def disabled_core_fields
460 tracker ? tracker.disabled_core_fields : []
460 tracker ? tracker.disabled_core_fields : []
461 end
461 end
462
462
463 # Returns the custom_field_values that can be edited by the given user
463 # Returns the custom_field_values that can be edited by the given user
464 def editable_custom_field_values(user=nil)
464 def editable_custom_field_values(user=nil)
465 custom_field_values.reject do |value|
465 custom_field_values.reject do |value|
466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
467 end
467 end
468 end
468 end
469
469
470 # Returns the names of attributes that are read-only for user or the current user
470 # Returns the names of attributes that are read-only for user or the current user
471 # For users with multiple roles, the read-only fields are the intersection of
471 # For users with multiple roles, the read-only fields are the intersection of
472 # read-only fields of each role
472 # read-only fields of each role
473 # The result is an array of strings where sustom fields are represented with their ids
473 # The result is an array of strings where sustom fields are represented with their ids
474 #
474 #
475 # Examples:
475 # Examples:
476 # issue.read_only_attribute_names # => ['due_date', '2']
476 # issue.read_only_attribute_names # => ['due_date', '2']
477 # issue.read_only_attribute_names(user) # => []
477 # issue.read_only_attribute_names(user) # => []
478 def read_only_attribute_names(user=nil)
478 def read_only_attribute_names(user=nil)
479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
480 end
480 end
481
481
482 # Returns the names of required attributes for user or the current user
482 # Returns the names of required attributes for user or the current user
483 # For users with multiple roles, the required fields are the intersection of
483 # For users with multiple roles, the required fields are the intersection of
484 # required fields of each role
484 # required fields of each role
485 # The result is an array of strings where sustom fields are represented with their ids
485 # The result is an array of strings where sustom fields are represented with their ids
486 #
486 #
487 # Examples:
487 # Examples:
488 # issue.required_attribute_names # => ['due_date', '2']
488 # issue.required_attribute_names # => ['due_date', '2']
489 # issue.required_attribute_names(user) # => []
489 # issue.required_attribute_names(user) # => []
490 def required_attribute_names(user=nil)
490 def required_attribute_names(user=nil)
491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
492 end
492 end
493
493
494 # Returns true if the attribute is required for user
494 # Returns true if the attribute is required for user
495 def required_attribute?(name, user=nil)
495 def required_attribute?(name, user=nil)
496 required_attribute_names(user).include?(name.to_s)
496 required_attribute_names(user).include?(name.to_s)
497 end
497 end
498
498
499 # Returns a hash of the workflow rule by attribute for the given user
499 # Returns a hash of the workflow rule by attribute for the given user
500 #
500 #
501 # Examples:
501 # Examples:
502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
503 def workflow_rule_by_attribute(user=nil)
503 def workflow_rule_by_attribute(user=nil)
504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
505
505
506 user_real = user || User.current
506 user_real = user || User.current
507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
508 return {} if roles.empty?
508 return {} if roles.empty?
509
509
510 result = {}
510 result = {}
511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
512 if workflow_permissions.any?
512 if workflow_permissions.any?
513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
514 h[wp.field_name] ||= []
514 h[wp.field_name] ||= []
515 h[wp.field_name] << wp.rule
515 h[wp.field_name] << wp.rule
516 h
516 h
517 end
517 end
518 workflow_rules.each do |attr, rules|
518 workflow_rules.each do |attr, rules|
519 next if rules.size < roles.size
519 next if rules.size < roles.size
520 uniq_rules = rules.uniq
520 uniq_rules = rules.uniq
521 if uniq_rules.size == 1
521 if uniq_rules.size == 1
522 result[attr] = uniq_rules.first
522 result[attr] = uniq_rules.first
523 else
523 else
524 result[attr] = 'required'
524 result[attr] = 'required'
525 end
525 end
526 end
526 end
527 end
527 end
528 @workflow_rule_by_attribute = result if user.nil?
528 @workflow_rule_by_attribute = result if user.nil?
529 result
529 result
530 end
530 end
531 private :workflow_rule_by_attribute
531 private :workflow_rule_by_attribute
532
532
533 def done_ratio
533 def done_ratio
534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
535 status.default_done_ratio
535 status.default_done_ratio
536 else
536 else
537 read_attribute(:done_ratio)
537 read_attribute(:done_ratio)
538 end
538 end
539 end
539 end
540
540
541 def self.use_status_for_done_ratio?
541 def self.use_status_for_done_ratio?
542 Setting.issue_done_ratio == 'issue_status'
542 Setting.issue_done_ratio == 'issue_status'
543 end
543 end
544
544
545 def self.use_field_for_done_ratio?
545 def self.use_field_for_done_ratio?
546 Setting.issue_done_ratio == 'issue_field'
546 Setting.issue_done_ratio == 'issue_field'
547 end
547 end
548
548
549 def validate_issue
549 def validate_issue
550 if due_date && start_date && due_date < start_date
550 if due_date && start_date && due_date < start_date
551 errors.add :due_date, :greater_than_start_date
551 errors.add :due_date, :greater_than_start_date
552 end
552 end
553
553
554 if start_date && soonest_start && start_date < soonest_start
554 if start_date && soonest_start && start_date < soonest_start
555 errors.add :start_date, :invalid
555 errors.add :start_date, :invalid
556 end
556 end
557
557
558 if fixed_version
558 if fixed_version
559 if !assignable_versions.include?(fixed_version)
559 if !assignable_versions.include?(fixed_version)
560 errors.add :fixed_version_id, :inclusion
560 errors.add :fixed_version_id, :inclusion
561 elsif reopened? && fixed_version.closed?
561 elsif reopened? && fixed_version.closed?
562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
563 end
563 end
564 end
564 end
565
565
566 # Checks that the issue can not be added/moved to a disabled tracker
566 # Checks that the issue can not be added/moved to a disabled tracker
567 if project && (tracker_id_changed? || project_id_changed?)
567 if project && (tracker_id_changed? || project_id_changed?)
568 unless project.trackers.include?(tracker)
568 unless project.trackers.include?(tracker)
569 errors.add :tracker_id, :inclusion
569 errors.add :tracker_id, :inclusion
570 end
570 end
571 end
571 end
572
572
573 # Checks parent issue assignment
573 # Checks parent issue assignment
574 if @invalid_parent_issue_id.present?
574 if @invalid_parent_issue_id.present?
575 errors.add :parent_issue_id, :invalid
575 errors.add :parent_issue_id, :invalid
576 elsif @parent_issue
576 elsif @parent_issue
577 if !valid_parent_project?(@parent_issue)
577 if !valid_parent_project?(@parent_issue)
578 errors.add :parent_issue_id, :invalid
578 errors.add :parent_issue_id, :invalid
579 elsif !new_record?
579 elsif !new_record?
580 # moving an existing issue
580 # moving an existing issue
581 if @parent_issue.root_id != root_id
581 if @parent_issue.root_id != root_id
582 # we can always move to another tree
582 # we can always move to another tree
583 elsif move_possible?(@parent_issue)
583 elsif move_possible?(@parent_issue)
584 # move accepted inside tree
584 # move accepted inside tree
585 else
585 else
586 errors.add :parent_issue_id, :invalid
586 errors.add :parent_issue_id, :invalid
587 end
587 end
588 end
588 end
589 end
589 end
590 end
590 end
591
591
592 # Validates the issue against additional workflow requirements
592 # Validates the issue against additional workflow requirements
593 def validate_required_fields
593 def validate_required_fields
594 user = new_record? ? author : current_journal.try(:user)
594 user = new_record? ? author : current_journal.try(:user)
595
595
596 required_attribute_names(user).each do |attribute|
596 required_attribute_names(user).each do |attribute|
597 if attribute =~ /^\d+$/
597 if attribute =~ /^\d+$/
598 attribute = attribute.to_i
598 attribute = attribute.to_i
599 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
599 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
600 if v && v.value.blank?
600 if v && v.value.blank?
601 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
601 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
602 end
602 end
603 else
603 else
604 if respond_to?(attribute) && send(attribute).blank?
604 if respond_to?(attribute) && send(attribute).blank?
605 errors.add attribute, :blank
605 errors.add attribute, :blank
606 end
606 end
607 end
607 end
608 end
608 end
609 end
609 end
610
610
611 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
611 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
612 # even if the user turns off the setting later
612 # even if the user turns off the setting later
613 def update_done_ratio_from_issue_status
613 def update_done_ratio_from_issue_status
614 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
614 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
615 self.done_ratio = status.default_done_ratio
615 self.done_ratio = status.default_done_ratio
616 end
616 end
617 end
617 end
618
618
619 def init_journal(user, notes = "")
619 def init_journal(user, notes = "")
620 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
620 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
621 if new_record?
621 if new_record?
622 @current_journal.notify = false
622 @current_journal.notify = false
623 else
623 else
624 @attributes_before_change = attributes.dup
624 @attributes_before_change = attributes.dup
625 @custom_values_before_change = {}
625 @custom_values_before_change = {}
626 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
626 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
627 end
627 end
628 @current_journal
628 @current_journal
629 end
629 end
630
630
631 # Returns the id of the last journal or nil
631 # Returns the id of the last journal or nil
632 def last_journal_id
632 def last_journal_id
633 if new_record?
633 if new_record?
634 nil
634 nil
635 else
635 else
636 journals.maximum(:id)
636 journals.maximum(:id)
637 end
637 end
638 end
638 end
639
639
640 # Returns a scope for journals that have an id greater than journal_id
640 # Returns a scope for journals that have an id greater than journal_id
641 def journals_after(journal_id)
641 def journals_after(journal_id)
642 scope = journals.reorder("#{Journal.table_name}.id ASC")
642 scope = journals.reorder("#{Journal.table_name}.id ASC")
643 if journal_id.present?
643 if journal_id.present?
644 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
644 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
645 end
645 end
646 scope
646 scope
647 end
647 end
648
648
649 # Returns the initial status of the issue
649 # Returns the initial status of the issue
650 # Returns nil for a new issue
650 # Returns nil for a new issue
651 def status_was
651 def status_was
652 if status_id_was && status_id_was.to_i > 0
652 if status_id_was && status_id_was.to_i > 0
653 @status_was ||= IssueStatus.find_by_id(status_id_was)
653 @status_was ||= IssueStatus.find_by_id(status_id_was)
654 end
654 end
655 end
655 end
656
656
657 # Return true if the issue is closed, otherwise false
657 # Return true if the issue is closed, otherwise false
658 def closed?
658 def closed?
659 self.status.is_closed?
659 self.status.is_closed?
660 end
660 end
661
661
662 # Return true if the issue is being reopened
662 # Return true if the issue is being reopened
663 def reopened?
663 def reopened?
664 if !new_record? && status_id_changed?
664 if !new_record? && status_id_changed?
665 status_was = IssueStatus.find_by_id(status_id_was)
665 status_was = IssueStatus.find_by_id(status_id_was)
666 status_new = IssueStatus.find_by_id(status_id)
666 status_new = IssueStatus.find_by_id(status_id)
667 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
667 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
668 return true
668 return true
669 end
669 end
670 end
670 end
671 false
671 false
672 end
672 end
673
673
674 # Return true if the issue is being closed
674 # Return true if the issue is being closed
675 def closing?
675 def closing?
676 if !new_record? && status_id_changed?
676 if !new_record? && status_id_changed?
677 if status_was && status && !status_was.is_closed? && status.is_closed?
677 if status_was && status && !status_was.is_closed? && status.is_closed?
678 return true
678 return true
679 end
679 end
680 end
680 end
681 false
681 false
682 end
682 end
683
683
684 # Returns true if the issue is overdue
684 # Returns true if the issue is overdue
685 def overdue?
685 def overdue?
686 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
686 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
687 end
687 end
688
688
689 # Is the amount of work done less than it should for the due date
689 # Is the amount of work done less than it should for the due date
690 def behind_schedule?
690 def behind_schedule?
691 return false if start_date.nil? || due_date.nil?
691 return false if start_date.nil? || due_date.nil?
692 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
692 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
693 return done_date <= Date.today
693 return done_date <= Date.today
694 end
694 end
695
695
696 # Does this issue have children?
696 # Does this issue have children?
697 def children?
697 def children?
698 !leaf?
698 !leaf?
699 end
699 end
700
700
701 # Users the issue can be assigned to
701 # Users the issue can be assigned to
702 def assignable_users
702 def assignable_users
703 users = project.assignable_users
703 users = project.assignable_users
704 users << author if author
704 users << author if author
705 users << assigned_to if assigned_to
705 users << assigned_to if assigned_to
706 users.uniq.sort
706 users.uniq.sort
707 end
707 end
708
708
709 # Versions that the issue can be assigned to
709 # Versions that the issue can be assigned to
710 def assignable_versions
710 def assignable_versions
711 return @assignable_versions if @assignable_versions
711 return @assignable_versions if @assignable_versions
712
712
713 versions = project.shared_versions.open.all
713 versions = project.shared_versions.open.all
714 if fixed_version
714 if fixed_version
715 if fixed_version_id_changed?
715 if fixed_version_id_changed?
716 # nothing to do
716 # nothing to do
717 elsif project_id_changed?
717 elsif project_id_changed?
718 if project.shared_versions.include?(fixed_version)
718 if project.shared_versions.include?(fixed_version)
719 versions << fixed_version
719 versions << fixed_version
720 end
720 end
721 else
721 else
722 versions << fixed_version
722 versions << fixed_version
723 end
723 end
724 end
724 end
725 @assignable_versions = versions.uniq.sort
725 @assignable_versions = versions.uniq.sort
726 end
726 end
727
727
728 # Returns true if this issue is blocked by another issue that is still open
728 # Returns true if this issue is blocked by another issue that is still open
729 def blocked?
729 def blocked?
730 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
730 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
731 end
731 end
732
732
733 # Returns an array of statuses that user is able to apply
733 # Returns an array of statuses that user is able to apply
734 def new_statuses_allowed_to(user=User.current, include_default=false)
734 def new_statuses_allowed_to(user=User.current, include_default=false)
735 if new_record? && @copied_from
735 if new_record? && @copied_from
736 [IssueStatus.default, @copied_from.status].compact.uniq.sort
736 [IssueStatus.default, @copied_from.status].compact.uniq.sort
737 else
737 else
738 initial_status = nil
738 initial_status = nil
739 if new_record?
739 if new_record?
740 initial_status = IssueStatus.default
740 initial_status = IssueStatus.default
741 elsif status_id_was
741 elsif status_id_was
742 initial_status = IssueStatus.find_by_id(status_id_was)
742 initial_status = IssueStatus.find_by_id(status_id_was)
743 end
743 end
744 initial_status ||= status
744 initial_status ||= status
745
745
746 statuses = initial_status.find_new_statuses_allowed_to(
746 statuses = initial_status.find_new_statuses_allowed_to(
747 user.admin ? Role.all : user.roles_for_project(project),
747 user.admin ? Role.all : user.roles_for_project(project),
748 tracker,
748 tracker,
749 author == user,
749 author == user,
750 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
750 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
751 )
751 )
752 statuses << initial_status unless statuses.empty?
752 statuses << initial_status unless statuses.empty?
753 statuses << IssueStatus.default if include_default
753 statuses << IssueStatus.default if include_default
754 statuses = statuses.compact.uniq.sort
754 statuses = statuses.compact.uniq.sort
755 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
755 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
756 end
756 end
757 end
757 end
758
758
759 def assigned_to_was
759 def assigned_to_was
760 if assigned_to_id_changed? && assigned_to_id_was.present?
760 if assigned_to_id_changed? && assigned_to_id_was.present?
761 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
761 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
762 end
762 end
763 end
763 end
764
764
765 # Returns the users that should be notified
765 # Returns the users that should be notified
766 def notified_users
766 def notified_users
767 notified = []
767 notified = []
768 # Author and assignee are always notified unless they have been
768 # Author and assignee are always notified unless they have been
769 # locked or don't want to be notified
769 # locked or don't want to be notified
770 notified << author if author
770 notified << author if author
771 if assigned_to
771 if assigned_to
772 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
772 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
773 end
773 end
774 if assigned_to_was
774 if assigned_to_was
775 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
775 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
776 end
776 end
777 notified = notified.select {|u| u.active? && u.notify_about?(self)}
777 notified = notified.select {|u| u.active? && u.notify_about?(self)}
778
778
779 notified += project.notified_users
779 notified += project.notified_users
780 notified.uniq!
780 notified.uniq!
781 # Remove users that can not view the issue
781 # Remove users that can not view the issue
782 notified.reject! {|user| !visible?(user)}
782 notified.reject! {|user| !visible?(user)}
783 notified
783 notified
784 end
784 end
785
785
786 # Returns the email addresses that should be notified
786 # Returns the email addresses that should be notified
787 def recipients
787 def recipients
788 notified_users.collect(&:mail)
788 notified_users.collect(&:mail)
789 end
789 end
790
790
791 # Returns the number of hours spent on this issue
791 # Returns the number of hours spent on this issue
792 def spent_hours
792 def spent_hours
793 @spent_hours ||= time_entries.sum(:hours) || 0
793 @spent_hours ||= time_entries.sum(:hours) || 0
794 end
794 end
795
795
796 # Returns the total number of hours spent on this issue and its descendants
796 # Returns the total number of hours spent on this issue and its descendants
797 #
797 #
798 # Example:
798 # Example:
799 # spent_hours => 0.0
799 # spent_hours => 0.0
800 # spent_hours => 50.2
800 # spent_hours => 50.2
801 def total_spent_hours
801 def total_spent_hours
802 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
802 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
803 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
803 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
804 end
804 end
805
805
806 def relations
806 def relations
807 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
807 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
808 end
808 end
809
809
810 # Preloads relations for a collection of issues
810 # Preloads relations for a collection of issues
811 def self.load_relations(issues)
811 def self.load_relations(issues)
812 if issues.any?
812 if issues.any?
813 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
813 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
814 issues.each do |issue|
814 issues.each do |issue|
815 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
815 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
816 end
816 end
817 end
817 end
818 end
818 end
819
819
820 # Preloads visible spent time for a collection of issues
820 # Preloads visible spent time for a collection of issues
821 def self.load_visible_spent_hours(issues, user=User.current)
821 def self.load_visible_spent_hours(issues, user=User.current)
822 if issues.any?
822 if issues.any?
823 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
823 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
824 issues.each do |issue|
824 issues.each do |issue|
825 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
825 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
826 end
826 end
827 end
827 end
828 end
828 end
829
829
830 # Preloads visible relations for a collection of issues
830 # Preloads visible relations for a collection of issues
831 def self.load_visible_relations(issues, user=User.current)
831 def self.load_visible_relations(issues, user=User.current)
832 if issues.any?
832 if issues.any?
833 issue_ids = issues.map(&:id)
833 issue_ids = issues.map(&:id)
834 # Relations with issue_from in given issues and visible issue_to
834 # Relations with issue_from in given issues and visible issue_to
835 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
835 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
836 # Relations with issue_to in given issues and visible issue_from
836 # Relations with issue_to in given issues and visible issue_from
837 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
837 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
838
838
839 issues.each do |issue|
839 issues.each do |issue|
840 relations =
840 relations =
841 relations_from.select {|relation| relation.issue_from_id == issue.id} +
841 relations_from.select {|relation| relation.issue_from_id == issue.id} +
842 relations_to.select {|relation| relation.issue_to_id == issue.id}
842 relations_to.select {|relation| relation.issue_to_id == issue.id}
843
843
844 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
844 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
845 end
845 end
846 end
846 end
847 end
847 end
848
848
849 # Finds an issue relation given its id.
849 # Finds an issue relation given its id.
850 def find_relation(relation_id)
850 def find_relation(relation_id)
851 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
851 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
852 end
852 end
853
853
854 def all_dependent_issues(except=[])
854 def all_dependent_issues(except=[])
855 except << self
855 except << self
856 dependencies = []
856 dependencies = []
857 relations_from.each do |relation|
857 relations_from.each do |relation|
858 if relation.issue_to && !except.include?(relation.issue_to)
858 if relation.issue_to && !except.include?(relation.issue_to)
859 dependencies << relation.issue_to
859 dependencies << relation.issue_to
860 dependencies += relation.issue_to.all_dependent_issues(except)
860 dependencies += relation.issue_to.all_dependent_issues(except)
861 end
861 end
862 end
862 end
863 dependencies
863 dependencies
864 end
864 end
865
865
866 # Returns an array of issues that duplicate this one
866 # Returns an array of issues that duplicate this one
867 def duplicates
867 def duplicates
868 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
868 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
869 end
869 end
870
870
871 # Returns the due date or the target due date if any
871 # Returns the due date or the target due date if any
872 # Used on gantt chart
872 # Used on gantt chart
873 def due_before
873 def due_before
874 due_date || (fixed_version ? fixed_version.effective_date : nil)
874 due_date || (fixed_version ? fixed_version.effective_date : nil)
875 end
875 end
876
876
877 # Returns the time scheduled for this issue.
877 # Returns the time scheduled for this issue.
878 #
878 #
879 # Example:
879 # Example:
880 # Start Date: 2/26/09, End Date: 3/04/09
880 # Start Date: 2/26/09, End Date: 3/04/09
881 # duration => 6
881 # duration => 6
882 def duration
882 def duration
883 (start_date && due_date) ? due_date - start_date : 0
883 (start_date && due_date) ? due_date - start_date : 0
884 end
884 end
885
885
886 # Returns the duration in working days
886 # Returns the duration in working days
887 def working_duration
887 def working_duration
888 (start_date && due_date) ? working_days(start_date, due_date) : 0
888 (start_date && due_date) ? working_days(start_date, due_date) : 0
889 end
889 end
890
890
891 def soonest_start(reload=false)
891 def soonest_start(reload=false)
892 @soonest_start = nil if reload
892 @soonest_start = nil if reload
893 @soonest_start ||= (
893 @soonest_start ||= (
894 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
894 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
895 ancestors.collect(&:soonest_start)
895 ancestors.collect(&:soonest_start)
896 ).compact.max
896 ).compact.max
897 end
897 end
898
898
899 # Sets start_date on the given date or the next working day
899 # Sets start_date on the given date or the next working day
900 # and changes due_date to keep the same working duration.
900 # and changes due_date to keep the same working duration.
901 def reschedule_on(date)
901 def reschedule_on(date)
902 wd = working_duration
902 wd = working_duration
903 date = next_working_date(date)
903 date = next_working_date(date)
904 self.start_date = date
904 self.start_date = date
905 self.due_date = add_working_days(date, wd)
905 self.due_date = add_working_days(date, wd)
906 end
906 end
907
907
908 # Reschedules the issue on the given date or the next working day and saves the record.
908 # Reschedules the issue on the given date or the next working day and saves the record.
909 # If the issue is a parent task, this is done by rescheduling its subtasks.
909 # If the issue is a parent task, this is done by rescheduling its subtasks.
910 def reschedule_on!(date)
910 def reschedule_on!(date)
911 return if date.nil?
911 return if date.nil?
912 if leaf?
912 if leaf?
913 if start_date.nil? || start_date != date
913 if start_date.nil? || start_date != date
914 if start_date && start_date > date
914 if start_date && start_date > date
915 # Issue can not be moved earlier than its soonest start date
915 # Issue can not be moved earlier than its soonest start date
916 date = [soonest_start(true), date].compact.max
916 date = [soonest_start(true), date].compact.max
917 end
917 end
918 reschedule_on(date)
918 reschedule_on(date)
919 begin
919 begin
920 save
920 save
921 rescue ActiveRecord::StaleObjectError
921 rescue ActiveRecord::StaleObjectError
922 reload
922 reload
923 reschedule_on(date)
923 reschedule_on(date)
924 save
924 save
925 end
925 end
926 end
926 end
927 else
927 else
928 leaves.each do |leaf|
928 leaves.each do |leaf|
929 if leaf.start_date
929 if leaf.start_date
930 # Only move subtask if it starts at the same date as the parent
930 # Only move subtask if it starts at the same date as the parent
931 # or if it starts before the given date
931 # or if it starts before the given date
932 if start_date == leaf.start_date || date > leaf.start_date
932 if start_date == leaf.start_date || date > leaf.start_date
933 leaf.reschedule_on!(date)
933 leaf.reschedule_on!(date)
934 end
934 end
935 else
935 else
936 leaf.reschedule_on!(date)
936 leaf.reschedule_on!(date)
937 end
937 end
938 end
938 end
939 end
939 end
940 end
940 end
941
941
942 def <=>(issue)
942 def <=>(issue)
943 if issue.nil?
943 if issue.nil?
944 -1
944 -1
945 elsif root_id != issue.root_id
945 elsif root_id != issue.root_id
946 (root_id || 0) <=> (issue.root_id || 0)
946 (root_id || 0) <=> (issue.root_id || 0)
947 else
947 else
948 (lft || 0) <=> (issue.lft || 0)
948 (lft || 0) <=> (issue.lft || 0)
949 end
949 end
950 end
950 end
951
951
952 def to_s
952 def to_s
953 "#{tracker} ##{id}: #{subject}"
953 "#{tracker} ##{id}: #{subject}"
954 end
954 end
955
955
956 # Returns a string of css classes that apply to the issue
956 # Returns a string of css classes that apply to the issue
957 def css_classes
957 def css_classes
958 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
958 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
959 s << ' closed' if closed?
959 s << ' closed' if closed?
960 s << ' overdue' if overdue?
960 s << ' overdue' if overdue?
961 s << ' child' if child?
961 s << ' child' if child?
962 s << ' parent' unless leaf?
962 s << ' parent' unless leaf?
963 s << ' private' if is_private?
963 s << ' private' if is_private?
964 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
964 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
965 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
965 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
966 s
966 s
967 end
967 end
968
968
969 # Saves an issue and a time_entry from the parameters
969 # Saves an issue and a time_entry from the parameters
970 def save_issue_with_child_records(params, existing_time_entry=nil)
970 def save_issue_with_child_records(params, existing_time_entry=nil)
971 Issue.transaction do
971 Issue.transaction do
972 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
972 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
973 @time_entry = existing_time_entry || TimeEntry.new
973 @time_entry = existing_time_entry || TimeEntry.new
974 @time_entry.project = project
974 @time_entry.project = project
975 @time_entry.issue = self
975 @time_entry.issue = self
976 @time_entry.user = User.current
976 @time_entry.user = User.current
977 @time_entry.spent_on = User.current.today
977 @time_entry.spent_on = User.current.today
978 @time_entry.attributes = params[:time_entry]
978 @time_entry.attributes = params[:time_entry]
979 self.time_entries << @time_entry
979 self.time_entries << @time_entry
980 end
980 end
981
981
982 # TODO: Rename hook
982 # TODO: Rename hook
983 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
983 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
984 if save
984 if save
985 # TODO: Rename hook
985 # TODO: Rename hook
986 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
986 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
987 else
987 else
988 raise ActiveRecord::Rollback
988 raise ActiveRecord::Rollback
989 end
989 end
990 end
990 end
991 end
991 end
992
992
993 # Unassigns issues from +version+ if it's no longer shared with issue's project
993 # Unassigns issues from +version+ if it's no longer shared with issue's project
994 def self.update_versions_from_sharing_change(version)
994 def self.update_versions_from_sharing_change(version)
995 # Update issues assigned to the version
995 # Update issues assigned to the version
996 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
996 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
997 end
997 end
998
998
999 # Unassigns issues from versions that are no longer shared
999 # Unassigns issues from versions that are no longer shared
1000 # after +project+ was moved
1000 # after +project+ was moved
1001 def self.update_versions_from_hierarchy_change(project)
1001 def self.update_versions_from_hierarchy_change(project)
1002 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1002 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1003 # Update issues of the moved projects and issues assigned to a version of a moved project
1003 # Update issues of the moved projects and issues assigned to a version of a moved project
1004 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1004 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1005 end
1005 end
1006
1006
1007 def parent_issue_id=(arg)
1007 def parent_issue_id=(arg)
1008 s = arg.to_s.strip.presence
1008 s = arg.to_s.strip.presence
1009 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1009 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1010 @parent_issue.id
1010 @parent_issue.id
1011 else
1011 else
1012 @parent_issue = nil
1012 @parent_issue = nil
1013 @invalid_parent_issue_id = arg
1013 @invalid_parent_issue_id = arg
1014 end
1014 end
1015 end
1015 end
1016
1016
1017 def parent_issue_id
1017 def parent_issue_id
1018 if @invalid_parent_issue_id
1018 if @invalid_parent_issue_id
1019 @invalid_parent_issue_id
1019 @invalid_parent_issue_id
1020 elsif instance_variable_defined? :@parent_issue
1020 elsif instance_variable_defined? :@parent_issue
1021 @parent_issue.nil? ? nil : @parent_issue.id
1021 @parent_issue.nil? ? nil : @parent_issue.id
1022 else
1022 else
1023 parent_id
1023 parent_id
1024 end
1024 end
1025 end
1025 end
1026
1026
1027 # Returns true if issue's project is a valid
1027 # Returns true if issue's project is a valid
1028 # parent issue project
1028 # parent issue project
1029 def valid_parent_project?(issue=parent)
1029 def valid_parent_project?(issue=parent)
1030 return true if issue.nil? || issue.project_id == project_id
1030 return true if issue.nil? || issue.project_id == project_id
1031
1031
1032 case Setting.cross_project_subtasks
1032 case Setting.cross_project_subtasks
1033 when 'system'
1033 when 'system'
1034 true
1034 true
1035 when 'tree'
1035 when 'tree'
1036 issue.project.root == project.root
1036 issue.project.root == project.root
1037 when 'hierarchy'
1037 when 'hierarchy'
1038 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1038 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1039 when 'descendants'
1039 when 'descendants'
1040 issue.project.is_or_is_ancestor_of?(project)
1040 issue.project.is_or_is_ancestor_of?(project)
1041 else
1041 else
1042 false
1042 false
1043 end
1043 end
1044 end
1044 end
1045
1045
1046 # Extracted from the ReportsController.
1046 # Extracted from the ReportsController.
1047 def self.by_tracker(project)
1047 def self.by_tracker(project)
1048 count_and_group_by(:project => project,
1048 count_and_group_by(:project => project,
1049 :field => 'tracker_id',
1049 :field => 'tracker_id',
1050 :joins => Tracker.table_name)
1050 :joins => Tracker.table_name)
1051 end
1051 end
1052
1052
1053 def self.by_version(project)
1053 def self.by_version(project)
1054 count_and_group_by(:project => project,
1054 count_and_group_by(:project => project,
1055 :field => 'fixed_version_id',
1055 :field => 'fixed_version_id',
1056 :joins => Version.table_name)
1056 :joins => Version.table_name)
1057 end
1057 end
1058
1058
1059 def self.by_priority(project)
1059 def self.by_priority(project)
1060 count_and_group_by(:project => project,
1060 count_and_group_by(:project => project,
1061 :field => 'priority_id',
1061 :field => 'priority_id',
1062 :joins => IssuePriority.table_name)
1062 :joins => IssuePriority.table_name)
1063 end
1063 end
1064
1064
1065 def self.by_category(project)
1065 def self.by_category(project)
1066 count_and_group_by(:project => project,
1066 count_and_group_by(:project => project,
1067 :field => 'category_id',
1067 :field => 'category_id',
1068 :joins => IssueCategory.table_name)
1068 :joins => IssueCategory.table_name)
1069 end
1069 end
1070
1070
1071 def self.by_assigned_to(project)
1071 def self.by_assigned_to(project)
1072 count_and_group_by(:project => project,
1072 count_and_group_by(:project => project,
1073 :field => 'assigned_to_id',
1073 :field => 'assigned_to_id',
1074 :joins => User.table_name)
1074 :joins => User.table_name)
1075 end
1075 end
1076
1076
1077 def self.by_author(project)
1077 def self.by_author(project)
1078 count_and_group_by(:project => project,
1078 count_and_group_by(:project => project,
1079 :field => 'author_id',
1079 :field => 'author_id',
1080 :joins => User.table_name)
1080 :joins => User.table_name)
1081 end
1081 end
1082
1082
1083 def self.by_subproject(project)
1083 def self.by_subproject(project)
1084 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1084 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1085 s.is_closed as closed,
1085 s.is_closed as closed,
1086 #{Issue.table_name}.project_id as project_id,
1086 #{Issue.table_name}.project_id as project_id,
1087 count(#{Issue.table_name}.id) as total
1087 count(#{Issue.table_name}.id) as total
1088 from
1088 from
1089 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1089 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1090 where
1090 where
1091 #{Issue.table_name}.status_id=s.id
1091 #{Issue.table_name}.status_id=s.id
1092 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1092 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1093 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1093 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1094 and #{Issue.table_name}.project_id <> #{project.id}
1094 and #{Issue.table_name}.project_id <> #{project.id}
1095 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1095 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1096 end
1096 end
1097 # End ReportsController extraction
1097 # End ReportsController extraction
1098
1098
1099 # Returns an array of projects that user can assign the issue to
1099 # Returns an array of projects that user can assign the issue to
1100 def allowed_target_projects(user=User.current)
1100 def allowed_target_projects(user=User.current)
1101 if new_record?
1101 if new_record?
1102 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1102 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1103 else
1103 else
1104 self.class.allowed_target_projects_on_move(user)
1104 self.class.allowed_target_projects_on_move(user)
1105 end
1105 end
1106 end
1106 end
1107
1107
1108 # Returns an array of projects that user can move issues to
1108 # Returns an array of projects that user can move issues to
1109 def self.allowed_target_projects_on_move(user=User.current)
1109 def self.allowed_target_projects_on_move(user=User.current)
1110 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1110 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1111 end
1111 end
1112
1112
1113 private
1113 private
1114
1114
1115 def after_project_change
1115 def after_project_change
1116 # Update project_id on related time entries
1116 # Update project_id on related time entries
1117 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1117 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1118
1118
1119 # Delete issue relations
1119 # Delete issue relations
1120 unless Setting.cross_project_issue_relations?
1120 unless Setting.cross_project_issue_relations?
1121 relations_from.clear
1121 relations_from.clear
1122 relations_to.clear
1122 relations_to.clear
1123 end
1123 end
1124
1124
1125 # Move subtasks that were in the same project
1125 # Move subtasks that were in the same project
1126 children.each do |child|
1126 children.each do |child|
1127 next unless child.project_id == project_id_was
1127 next unless child.project_id == project_id_was
1128 # Change project and keep project
1128 # Change project and keep project
1129 child.send :project=, project, true
1129 child.send :project=, project, true
1130 unless child.save
1130 unless child.save
1131 raise ActiveRecord::Rollback
1131 raise ActiveRecord::Rollback
1132 end
1132 end
1133 end
1133 end
1134 end
1134 end
1135
1135
1136 # Callback for after the creation of an issue by copy
1136 # Callback for after the creation of an issue by copy
1137 # * adds a "copied to" relation with the copied issue
1137 # * adds a "copied to" relation with the copied issue
1138 # * copies subtasks from the copied issue
1138 # * copies subtasks from the copied issue
1139 def after_create_from_copy
1139 def after_create_from_copy
1140 return unless copy? && !@after_create_from_copy_handled
1140 return unless copy? && !@after_create_from_copy_handled
1141
1141
1142 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1142 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1143 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1143 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1144 unless relation.save
1144 unless relation.save
1145 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1145 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1146 end
1146 end
1147 end
1147 end
1148
1148
1149 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1149 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1150 @copied_from.children.each do |child|
1150 copy_options = (@copy_options || {}).merge(:subtasks => false)
1151 copied_issue_ids = {@copied_from.id => self.id}
1152 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1153 # Do not copy self when copying an issue as a descendant of the copied issue
1154 next if child == self
1155 # Do not copy subtasks of issues that were not copied
1156 next unless copied_issue_ids[child.parent_id]
1157 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1151 unless child.visible?
1158 unless child.visible?
1152 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1153 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1159 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1154 next
1160 next
1155 end
1161 end
1156 copy = Issue.new.copy_from(child, @copy_options)
1162 copy = Issue.new.copy_from(child, copy_options)
1157 copy.author = author
1163 copy.author = author
1158 copy.project = project
1164 copy.project = project
1159 copy.parent_issue_id = id
1165 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1160 # Children subtasks are copied recursively
1161 unless copy.save
1166 unless copy.save
1162 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1167 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1168 next
1163 end
1169 end
1170 copied_issue_ids[child.id] = copy.id
1164 end
1171 end
1165 end
1172 end
1166 @after_create_from_copy_handled = true
1173 @after_create_from_copy_handled = true
1167 end
1174 end
1168
1175
1169 def update_nested_set_attributes
1176 def update_nested_set_attributes
1170 if root_id.nil?
1177 if root_id.nil?
1171 # issue was just created
1178 # issue was just created
1172 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1179 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1173 set_default_left_and_right
1180 set_default_left_and_right
1174 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1181 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1175 if @parent_issue
1182 if @parent_issue
1176 move_to_child_of(@parent_issue)
1183 move_to_child_of(@parent_issue)
1177 end
1184 end
1178 elsif parent_issue_id != parent_id
1185 elsif parent_issue_id != parent_id
1179 former_parent_id = parent_id
1186 former_parent_id = parent_id
1180 # moving an existing issue
1187 # moving an existing issue
1181 if @parent_issue && @parent_issue.root_id == root_id
1188 if @parent_issue && @parent_issue.root_id == root_id
1182 # inside the same tree
1189 # inside the same tree
1183 move_to_child_of(@parent_issue)
1190 move_to_child_of(@parent_issue)
1184 else
1191 else
1185 # to another tree
1192 # to another tree
1186 unless root?
1193 unless root?
1187 move_to_right_of(root)
1194 move_to_right_of(root)
1188 end
1195 end
1189 old_root_id = root_id
1196 old_root_id = root_id
1190 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1197 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1191 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1198 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1192 offset = target_maxright + 1 - lft
1199 offset = target_maxright + 1 - lft
1193 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1200 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1194 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1201 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1195 self[left_column_name] = lft + offset
1202 self[left_column_name] = lft + offset
1196 self[right_column_name] = rgt + offset
1203 self[right_column_name] = rgt + offset
1197 if @parent_issue
1204 if @parent_issue
1198 move_to_child_of(@parent_issue)
1205 move_to_child_of(@parent_issue)
1199 end
1206 end
1200 end
1207 end
1201 # delete invalid relations of all descendants
1208 # delete invalid relations of all descendants
1202 self_and_descendants.each do |issue|
1209 self_and_descendants.each do |issue|
1203 issue.relations.each do |relation|
1210 issue.relations.each do |relation|
1204 relation.destroy unless relation.valid?
1211 relation.destroy unless relation.valid?
1205 end
1212 end
1206 end
1213 end
1207 # update former parent
1214 # update former parent
1208 recalculate_attributes_for(former_parent_id) if former_parent_id
1215 recalculate_attributes_for(former_parent_id) if former_parent_id
1209 end
1216 end
1210 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1217 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1211 end
1218 end
1212
1219
1213 def update_parent_attributes
1220 def update_parent_attributes
1214 recalculate_attributes_for(parent_id) if parent_id
1221 recalculate_attributes_for(parent_id) if parent_id
1215 end
1222 end
1216
1223
1217 def recalculate_attributes_for(issue_id)
1224 def recalculate_attributes_for(issue_id)
1218 if issue_id && p = Issue.find_by_id(issue_id)
1225 if issue_id && p = Issue.find_by_id(issue_id)
1219 # priority = highest priority of children
1226 # priority = highest priority of children
1220 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1227 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1221 p.priority = IssuePriority.find_by_position(priority_position)
1228 p.priority = IssuePriority.find_by_position(priority_position)
1222 end
1229 end
1223
1230
1224 # start/due dates = lowest/highest dates of children
1231 # start/due dates = lowest/highest dates of children
1225 p.start_date = p.children.minimum(:start_date)
1232 p.start_date = p.children.minimum(:start_date)
1226 p.due_date = p.children.maximum(:due_date)
1233 p.due_date = p.children.maximum(:due_date)
1227 if p.start_date && p.due_date && p.due_date < p.start_date
1234 if p.start_date && p.due_date && p.due_date < p.start_date
1228 p.start_date, p.due_date = p.due_date, p.start_date
1235 p.start_date, p.due_date = p.due_date, p.start_date
1229 end
1236 end
1230
1237
1231 # done ratio = weighted average ratio of leaves
1238 # done ratio = weighted average ratio of leaves
1232 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1239 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1233 leaves_count = p.leaves.count
1240 leaves_count = p.leaves.count
1234 if leaves_count > 0
1241 if leaves_count > 0
1235 average = p.leaves.average(:estimated_hours).to_f
1242 average = p.leaves.average(:estimated_hours).to_f
1236 if average == 0
1243 if average == 0
1237 average = 1
1244 average = 1
1238 end
1245 end
1239 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1246 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1240 progress = done / (average * leaves_count)
1247 progress = done / (average * leaves_count)
1241 p.done_ratio = progress.round
1248 p.done_ratio = progress.round
1242 end
1249 end
1243 end
1250 end
1244
1251
1245 # estimate = sum of leaves estimates
1252 # estimate = sum of leaves estimates
1246 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1253 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1247 p.estimated_hours = nil if p.estimated_hours == 0.0
1254 p.estimated_hours = nil if p.estimated_hours == 0.0
1248
1255
1249 # ancestors will be recursively updated
1256 # ancestors will be recursively updated
1250 p.save(:validate => false)
1257 p.save(:validate => false)
1251 end
1258 end
1252 end
1259 end
1253
1260
1254 # Update issues so their versions are not pointing to a
1261 # Update issues so their versions are not pointing to a
1255 # fixed_version that is not shared with the issue's project
1262 # fixed_version that is not shared with the issue's project
1256 def self.update_versions(conditions=nil)
1263 def self.update_versions(conditions=nil)
1257 # Only need to update issues with a fixed_version from
1264 # Only need to update issues with a fixed_version from
1258 # a different project and that is not systemwide shared
1265 # a different project and that is not systemwide shared
1259 Issue.scoped(:conditions => conditions).all(
1266 Issue.scoped(:conditions => conditions).all(
1260 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1267 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1261 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1268 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1262 " AND #{Version.table_name}.sharing <> 'system'",
1269 " AND #{Version.table_name}.sharing <> 'system'",
1263 :include => [:project, :fixed_version]
1270 :include => [:project, :fixed_version]
1264 ).each do |issue|
1271 ).each do |issue|
1265 next if issue.project.nil? || issue.fixed_version.nil?
1272 next if issue.project.nil? || issue.fixed_version.nil?
1266 unless issue.project.shared_versions.include?(issue.fixed_version)
1273 unless issue.project.shared_versions.include?(issue.fixed_version)
1267 issue.init_journal(User.current)
1274 issue.init_journal(User.current)
1268 issue.fixed_version = nil
1275 issue.fixed_version = nil
1269 issue.save
1276 issue.save
1270 end
1277 end
1271 end
1278 end
1272 end
1279 end
1273
1280
1274 # Callback on file attachment
1281 # Callback on file attachment
1275 def attachment_added(obj)
1282 def attachment_added(obj)
1276 if @current_journal && !obj.new_record?
1283 if @current_journal && !obj.new_record?
1277 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1284 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1278 end
1285 end
1279 end
1286 end
1280
1287
1281 # Callback on attachment deletion
1288 # Callback on attachment deletion
1282 def attachment_removed(obj)
1289 def attachment_removed(obj)
1283 if @current_journal && !obj.new_record?
1290 if @current_journal && !obj.new_record?
1284 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1291 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1285 @current_journal.save
1292 @current_journal.save
1286 end
1293 end
1287 end
1294 end
1288
1295
1289 # Default assignment based on category
1296 # Default assignment based on category
1290 def default_assign
1297 def default_assign
1291 if assigned_to.nil? && category && category.assigned_to
1298 if assigned_to.nil? && category && category.assigned_to
1292 self.assigned_to = category.assigned_to
1299 self.assigned_to = category.assigned_to
1293 end
1300 end
1294 end
1301 end
1295
1302
1296 # Updates start/due dates of following issues
1303 # Updates start/due dates of following issues
1297 def reschedule_following_issues
1304 def reschedule_following_issues
1298 if start_date_changed? || due_date_changed?
1305 if start_date_changed? || due_date_changed?
1299 relations_from.each do |relation|
1306 relations_from.each do |relation|
1300 relation.set_issue_to_dates
1307 relation.set_issue_to_dates
1301 end
1308 end
1302 end
1309 end
1303 end
1310 end
1304
1311
1305 # Closes duplicates if the issue is being closed
1312 # Closes duplicates if the issue is being closed
1306 def close_duplicates
1313 def close_duplicates
1307 if closing?
1314 if closing?
1308 duplicates.each do |duplicate|
1315 duplicates.each do |duplicate|
1309 # Reload is need in case the duplicate was updated by a previous duplicate
1316 # Reload is need in case the duplicate was updated by a previous duplicate
1310 duplicate.reload
1317 duplicate.reload
1311 # Don't re-close it if it's already closed
1318 # Don't re-close it if it's already closed
1312 next if duplicate.closed?
1319 next if duplicate.closed?
1313 # Same user and notes
1320 # Same user and notes
1314 if @current_journal
1321 if @current_journal
1315 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1322 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1316 end
1323 end
1317 duplicate.update_attribute :status, self.status
1324 duplicate.update_attribute :status, self.status
1318 end
1325 end
1319 end
1326 end
1320 end
1327 end
1321
1328
1322 # Make sure updated_on is updated when adding a note and set updated_on now
1329 # Make sure updated_on is updated when adding a note and set updated_on now
1323 # so we can set closed_on with the same value on closing
1330 # so we can set closed_on with the same value on closing
1324 def force_updated_on_change
1331 def force_updated_on_change
1325 if @current_journal || changed?
1332 if @current_journal || changed?
1326 self.updated_on = current_time_from_proper_timezone
1333 self.updated_on = current_time_from_proper_timezone
1327 if new_record?
1334 if new_record?
1328 self.created_on = updated_on
1335 self.created_on = updated_on
1329 end
1336 end
1330 end
1337 end
1331 end
1338 end
1332
1339
1333 # Callback for setting closed_on when the issue is closed.
1340 # Callback for setting closed_on when the issue is closed.
1334 # The closed_on attribute stores the time of the last closing
1341 # The closed_on attribute stores the time of the last closing
1335 # and is preserved when the issue is reopened.
1342 # and is preserved when the issue is reopened.
1336 def update_closed_on
1343 def update_closed_on
1337 if closing? || (new_record? && closed?)
1344 if closing? || (new_record? && closed?)
1338 self.closed_on = updated_on
1345 self.closed_on = updated_on
1339 end
1346 end
1340 end
1347 end
1341
1348
1342 # Saves the changes in a Journal
1349 # Saves the changes in a Journal
1343 # Called after_save
1350 # Called after_save
1344 def create_journal
1351 def create_journal
1345 if @current_journal
1352 if @current_journal
1346 # attributes changes
1353 # attributes changes
1347 if @attributes_before_change
1354 if @attributes_before_change
1348 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1355 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1349 before = @attributes_before_change[c]
1356 before = @attributes_before_change[c]
1350 after = send(c)
1357 after = send(c)
1351 next if before == after || (before.blank? && after.blank?)
1358 next if before == after || (before.blank? && after.blank?)
1352 @current_journal.details << JournalDetail.new(:property => 'attr',
1359 @current_journal.details << JournalDetail.new(:property => 'attr',
1353 :prop_key => c,
1360 :prop_key => c,
1354 :old_value => before,
1361 :old_value => before,
1355 :value => after)
1362 :value => after)
1356 }
1363 }
1357 end
1364 end
1358 if @custom_values_before_change
1365 if @custom_values_before_change
1359 # custom fields changes
1366 # custom fields changes
1360 custom_field_values.each {|c|
1367 custom_field_values.each {|c|
1361 before = @custom_values_before_change[c.custom_field_id]
1368 before = @custom_values_before_change[c.custom_field_id]
1362 after = c.value
1369 after = c.value
1363 next if before == after || (before.blank? && after.blank?)
1370 next if before == after || (before.blank? && after.blank?)
1364
1371
1365 if before.is_a?(Array) || after.is_a?(Array)
1372 if before.is_a?(Array) || after.is_a?(Array)
1366 before = [before] unless before.is_a?(Array)
1373 before = [before] unless before.is_a?(Array)
1367 after = [after] unless after.is_a?(Array)
1374 after = [after] unless after.is_a?(Array)
1368
1375
1369 # values removed
1376 # values removed
1370 (before - after).reject(&:blank?).each do |value|
1377 (before - after).reject(&:blank?).each do |value|
1371 @current_journal.details << JournalDetail.new(:property => 'cf',
1378 @current_journal.details << JournalDetail.new(:property => 'cf',
1372 :prop_key => c.custom_field_id,
1379 :prop_key => c.custom_field_id,
1373 :old_value => value,
1380 :old_value => value,
1374 :value => nil)
1381 :value => nil)
1375 end
1382 end
1376 # values added
1383 # values added
1377 (after - before).reject(&:blank?).each do |value|
1384 (after - before).reject(&:blank?).each do |value|
1378 @current_journal.details << JournalDetail.new(:property => 'cf',
1385 @current_journal.details << JournalDetail.new(:property => 'cf',
1379 :prop_key => c.custom_field_id,
1386 :prop_key => c.custom_field_id,
1380 :old_value => nil,
1387 :old_value => nil,
1381 :value => value)
1388 :value => value)
1382 end
1389 end
1383 else
1390 else
1384 @current_journal.details << JournalDetail.new(:property => 'cf',
1391 @current_journal.details << JournalDetail.new(:property => 'cf',
1385 :prop_key => c.custom_field_id,
1392 :prop_key => c.custom_field_id,
1386 :old_value => before,
1393 :old_value => before,
1387 :value => after)
1394 :value => after)
1388 end
1395 end
1389 }
1396 }
1390 end
1397 end
1391 @current_journal.save
1398 @current_journal.save
1392 # reset current journal
1399 # reset current journal
1393 init_journal @current_journal.user, @current_journal.notes
1400 init_journal @current_journal.user, @current_journal.notes
1394 end
1401 end
1395 end
1402 end
1396
1403
1397 # Query generator for selecting groups of issue counts for a project
1404 # Query generator for selecting groups of issue counts for a project
1398 # based on specific criteria
1405 # based on specific criteria
1399 #
1406 #
1400 # Options
1407 # Options
1401 # * project - Project to search in.
1408 # * project - Project to search in.
1402 # * field - String. Issue field to key off of in the grouping.
1409 # * field - String. Issue field to key off of in the grouping.
1403 # * joins - String. The table name to join against.
1410 # * joins - String. The table name to join against.
1404 def self.count_and_group_by(options)
1411 def self.count_and_group_by(options)
1405 project = options.delete(:project)
1412 project = options.delete(:project)
1406 select_field = options.delete(:field)
1413 select_field = options.delete(:field)
1407 joins = options.delete(:joins)
1414 joins = options.delete(:joins)
1408
1415
1409 where = "#{Issue.table_name}.#{select_field}=j.id"
1416 where = "#{Issue.table_name}.#{select_field}=j.id"
1410
1417
1411 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1418 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1412 s.is_closed as closed,
1419 s.is_closed as closed,
1413 j.id as #{select_field},
1420 j.id as #{select_field},
1414 count(#{Issue.table_name}.id) as total
1421 count(#{Issue.table_name}.id) as total
1415 from
1422 from
1416 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1423 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1417 where
1424 where
1418 #{Issue.table_name}.status_id=s.id
1425 #{Issue.table_name}.status_id=s.id
1419 and #{where}
1426 and #{where}
1420 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1427 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1421 and #{visible_condition(User.current, :project => project)}
1428 and #{visible_condition(User.current, :project => project)}
1422 group by s.id, s.is_closed, j.id")
1429 group by s.id, s.is_closed, j.id")
1423 end
1430 end
1424 end
1431 end
@@ -1,2015 +1,2058
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../../test_helper', __FILE__)
18 require File.expand_path('../../test_helper', __FILE__)
19
19
20 class IssueTest < ActiveSupport::TestCase
20 class IssueTest < ActiveSupport::TestCase
21 fixtures :projects, :users, :members, :member_roles, :roles,
21 fixtures :projects, :users, :members, :member_roles, :roles,
22 :groups_users,
22 :groups_users,
23 :trackers, :projects_trackers,
23 :trackers, :projects_trackers,
24 :enabled_modules,
24 :enabled_modules,
25 :versions,
25 :versions,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 :enumerations,
27 :enumerations,
28 :issues, :journals, :journal_details,
28 :issues, :journals, :journal_details,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 :time_entries
30 :time_entries
31
31
32 include Redmine::I18n
32 include Redmine::I18n
33
33
34 def teardown
34 def teardown
35 User.current = nil
35 User.current = nil
36 end
36 end
37
37
38 def test_initialize
38 def test_initialize
39 issue = Issue.new
39 issue = Issue.new
40
40
41 assert_nil issue.project_id
41 assert_nil issue.project_id
42 assert_nil issue.tracker_id
42 assert_nil issue.tracker_id
43 assert_nil issue.author_id
43 assert_nil issue.author_id
44 assert_nil issue.assigned_to_id
44 assert_nil issue.assigned_to_id
45 assert_nil issue.category_id
45 assert_nil issue.category_id
46
46
47 assert_equal IssueStatus.default, issue.status
47 assert_equal IssueStatus.default, issue.status
48 assert_equal IssuePriority.default, issue.priority
48 assert_equal IssuePriority.default, issue.priority
49 end
49 end
50
50
51 def test_create
51 def test_create
52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
52 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
53 :status_id => 1, :priority => IssuePriority.all.first,
53 :status_id => 1, :priority => IssuePriority.all.first,
54 :subject => 'test_create',
54 :subject => 'test_create',
55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
55 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
56 assert issue.save
56 assert issue.save
57 issue.reload
57 issue.reload
58 assert_equal 1.5, issue.estimated_hours
58 assert_equal 1.5, issue.estimated_hours
59 end
59 end
60
60
61 def test_create_minimal
61 def test_create_minimal
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
63 :status_id => 1, :priority => IssuePriority.all.first,
63 :status_id => 1, :priority => IssuePriority.all.first,
64 :subject => 'test_create')
64 :subject => 'test_create')
65 assert issue.save
65 assert issue.save
66 assert issue.description.nil?
66 assert issue.description.nil?
67 assert_nil issue.estimated_hours
67 assert_nil issue.estimated_hours
68 end
68 end
69
69
70 def test_start_date_format_should_be_validated
70 def test_start_date_format_should_be_validated
71 set_language_if_valid 'en'
71 set_language_if_valid 'en'
72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
72 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
73 issue = Issue.new(:start_date => invalid_date)
73 issue = Issue.new(:start_date => invalid_date)
74 assert !issue.valid?
74 assert !issue.valid?
75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
75 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
76 end
76 end
77 end
77 end
78
78
79 def test_due_date_format_should_be_validated
79 def test_due_date_format_should_be_validated
80 set_language_if_valid 'en'
80 set_language_if_valid 'en'
81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
81 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
82 issue = Issue.new(:due_date => invalid_date)
82 issue = Issue.new(:due_date => invalid_date)
83 assert !issue.valid?
83 assert !issue.valid?
84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
84 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
85 end
85 end
86 end
86 end
87
87
88 def test_due_date_lesser_than_start_date_should_not_validate
88 def test_due_date_lesser_than_start_date_should_not_validate
89 set_language_if_valid 'en'
89 set_language_if_valid 'en'
90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
90 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
91 assert !issue.valid?
91 assert !issue.valid?
92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
92 assert_include 'Due date must be greater than start date', issue.errors.full_messages
93 end
93 end
94
94
95 def test_estimated_hours_should_be_validated
95 def test_estimated_hours_should_be_validated
96 set_language_if_valid 'en'
96 set_language_if_valid 'en'
97 ['-2'].each do |invalid|
97 ['-2'].each do |invalid|
98 issue = Issue.new(:estimated_hours => invalid)
98 issue = Issue.new(:estimated_hours => invalid)
99 assert !issue.valid?
99 assert !issue.valid?
100 assert_include 'Estimated time is invalid', issue.errors.full_messages
100 assert_include 'Estimated time is invalid', issue.errors.full_messages
101 end
101 end
102 end
102 end
103
103
104 def test_create_with_required_custom_field
104 def test_create_with_required_custom_field
105 set_language_if_valid 'en'
105 set_language_if_valid 'en'
106 field = IssueCustomField.find_by_name('Database')
106 field = IssueCustomField.find_by_name('Database')
107 field.update_attribute(:is_required, true)
107 field.update_attribute(:is_required, true)
108
108
109 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
109 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
110 :status_id => 1, :subject => 'test_create',
110 :status_id => 1, :subject => 'test_create',
111 :description => 'IssueTest#test_create_with_required_custom_field')
111 :description => 'IssueTest#test_create_with_required_custom_field')
112 assert issue.available_custom_fields.include?(field)
112 assert issue.available_custom_fields.include?(field)
113 # No value for the custom field
113 # No value for the custom field
114 assert !issue.save
114 assert !issue.save
115 assert_equal ["Database can't be blank"], issue.errors.full_messages
115 assert_equal ["Database can't be blank"], issue.errors.full_messages
116 # Blank value
116 # Blank value
117 issue.custom_field_values = { field.id => '' }
117 issue.custom_field_values = { field.id => '' }
118 assert !issue.save
118 assert !issue.save
119 assert_equal ["Database can't be blank"], issue.errors.full_messages
119 assert_equal ["Database can't be blank"], issue.errors.full_messages
120 # Invalid value
120 # Invalid value
121 issue.custom_field_values = { field.id => 'SQLServer' }
121 issue.custom_field_values = { field.id => 'SQLServer' }
122 assert !issue.save
122 assert !issue.save
123 assert_equal ["Database is not included in the list"], issue.errors.full_messages
123 assert_equal ["Database is not included in the list"], issue.errors.full_messages
124 # Valid value
124 # Valid value
125 issue.custom_field_values = { field.id => 'PostgreSQL' }
125 issue.custom_field_values = { field.id => 'PostgreSQL' }
126 assert issue.save
126 assert issue.save
127 issue.reload
127 issue.reload
128 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
128 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
129 end
129 end
130
130
131 def test_create_with_group_assignment
131 def test_create_with_group_assignment
132 with_settings :issue_group_assignment => '1' do
132 with_settings :issue_group_assignment => '1' do
133 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
133 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
134 :subject => 'Group assignment',
134 :subject => 'Group assignment',
135 :assigned_to_id => 11).save
135 :assigned_to_id => 11).save
136 issue = Issue.first(:order => 'id DESC')
136 issue = Issue.first(:order => 'id DESC')
137 assert_kind_of Group, issue.assigned_to
137 assert_kind_of Group, issue.assigned_to
138 assert_equal Group.find(11), issue.assigned_to
138 assert_equal Group.find(11), issue.assigned_to
139 end
139 end
140 end
140 end
141
141
142 def test_create_with_parent_issue_id
142 def test_create_with_parent_issue_id
143 issue = Issue.new(:project_id => 1, :tracker_id => 1,
143 issue = Issue.new(:project_id => 1, :tracker_id => 1,
144 :author_id => 1, :subject => 'Group assignment',
144 :author_id => 1, :subject => 'Group assignment',
145 :parent_issue_id => 1)
145 :parent_issue_id => 1)
146 assert_save issue
146 assert_save issue
147 assert_equal 1, issue.parent_issue_id
147 assert_equal 1, issue.parent_issue_id
148 assert_equal Issue.find(1), issue.parent
148 assert_equal Issue.find(1), issue.parent
149 end
149 end
150
150
151 def test_create_with_sharp_parent_issue_id
151 def test_create_with_sharp_parent_issue_id
152 issue = Issue.new(:project_id => 1, :tracker_id => 1,
152 issue = Issue.new(:project_id => 1, :tracker_id => 1,
153 :author_id => 1, :subject => 'Group assignment',
153 :author_id => 1, :subject => 'Group assignment',
154 :parent_issue_id => "#1")
154 :parent_issue_id => "#1")
155 assert_save issue
155 assert_save issue
156 assert_equal 1, issue.parent_issue_id
156 assert_equal 1, issue.parent_issue_id
157 assert_equal Issue.find(1), issue.parent
157 assert_equal Issue.find(1), issue.parent
158 end
158 end
159
159
160 def test_create_with_invalid_parent_issue_id
160 def test_create_with_invalid_parent_issue_id
161 set_language_if_valid 'en'
161 set_language_if_valid 'en'
162 issue = Issue.new(:project_id => 1, :tracker_id => 1,
162 issue = Issue.new(:project_id => 1, :tracker_id => 1,
163 :author_id => 1, :subject => 'Group assignment',
163 :author_id => 1, :subject => 'Group assignment',
164 :parent_issue_id => '01ABC')
164 :parent_issue_id => '01ABC')
165 assert !issue.save
165 assert !issue.save
166 assert_equal '01ABC', issue.parent_issue_id
166 assert_equal '01ABC', issue.parent_issue_id
167 assert_include 'Parent task is invalid', issue.errors.full_messages
167 assert_include 'Parent task is invalid', issue.errors.full_messages
168 end
168 end
169
169
170 def test_create_with_invalid_sharp_parent_issue_id
170 def test_create_with_invalid_sharp_parent_issue_id
171 set_language_if_valid 'en'
171 set_language_if_valid 'en'
172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
173 :author_id => 1, :subject => 'Group assignment',
173 :author_id => 1, :subject => 'Group assignment',
174 :parent_issue_id => '#01ABC')
174 :parent_issue_id => '#01ABC')
175 assert !issue.save
175 assert !issue.save
176 assert_equal '#01ABC', issue.parent_issue_id
176 assert_equal '#01ABC', issue.parent_issue_id
177 assert_include 'Parent task is invalid', issue.errors.full_messages
177 assert_include 'Parent task is invalid', issue.errors.full_messages
178 end
178 end
179
179
180 def assert_visibility_match(user, issues)
180 def assert_visibility_match(user, issues)
181 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
181 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
182 end
182 end
183
183
184 def test_visible_scope_for_anonymous
184 def test_visible_scope_for_anonymous
185 # Anonymous user should see issues of public projects only
185 # Anonymous user should see issues of public projects only
186 issues = Issue.visible(User.anonymous).all
186 issues = Issue.visible(User.anonymous).all
187 assert issues.any?
187 assert issues.any?
188 assert_nil issues.detect {|issue| !issue.project.is_public?}
188 assert_nil issues.detect {|issue| !issue.project.is_public?}
189 assert_nil issues.detect {|issue| issue.is_private?}
189 assert_nil issues.detect {|issue| issue.is_private?}
190 assert_visibility_match User.anonymous, issues
190 assert_visibility_match User.anonymous, issues
191 end
191 end
192
192
193 def test_visible_scope_for_anonymous_without_view_issues_permissions
193 def test_visible_scope_for_anonymous_without_view_issues_permissions
194 # Anonymous user should not see issues without permission
194 # Anonymous user should not see issues without permission
195 Role.anonymous.remove_permission!(:view_issues)
195 Role.anonymous.remove_permission!(:view_issues)
196 issues = Issue.visible(User.anonymous).all
196 issues = Issue.visible(User.anonymous).all
197 assert issues.empty?
197 assert issues.empty?
198 assert_visibility_match User.anonymous, issues
198 assert_visibility_match User.anonymous, issues
199 end
199 end
200
200
201 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
201 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
202 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
202 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
203 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
203 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
204 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
204 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
205 assert !issue.visible?(User.anonymous)
205 assert !issue.visible?(User.anonymous)
206 end
206 end
207
207
208 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
208 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
209 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
209 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
210 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
210 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
211 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
211 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
212 assert !issue.visible?(User.anonymous)
212 assert !issue.visible?(User.anonymous)
213 end
213 end
214
214
215 def test_visible_scope_for_non_member
215 def test_visible_scope_for_non_member
216 user = User.find(9)
216 user = User.find(9)
217 assert user.projects.empty?
217 assert user.projects.empty?
218 # Non member user should see issues of public projects only
218 # Non member user should see issues of public projects only
219 issues = Issue.visible(user).all
219 issues = Issue.visible(user).all
220 assert issues.any?
220 assert issues.any?
221 assert_nil issues.detect {|issue| !issue.project.is_public?}
221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 assert_nil issues.detect {|issue| issue.is_private?}
222 assert_nil issues.detect {|issue| issue.is_private?}
223 assert_visibility_match user, issues
223 assert_visibility_match user, issues
224 end
224 end
225
225
226 def test_visible_scope_for_non_member_with_own_issues_visibility
226 def test_visible_scope_for_non_member_with_own_issues_visibility
227 Role.non_member.update_attribute :issues_visibility, 'own'
227 Role.non_member.update_attribute :issues_visibility, 'own'
228 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
228 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
229 user = User.find(9)
229 user = User.find(9)
230
230
231 issues = Issue.visible(user).all
231 issues = Issue.visible(user).all
232 assert issues.any?
232 assert issues.any?
233 assert_nil issues.detect {|issue| issue.author != user}
233 assert_nil issues.detect {|issue| issue.author != user}
234 assert_visibility_match user, issues
234 assert_visibility_match user, issues
235 end
235 end
236
236
237 def test_visible_scope_for_non_member_without_view_issues_permissions
237 def test_visible_scope_for_non_member_without_view_issues_permissions
238 # Non member user should not see issues without permission
238 # Non member user should not see issues without permission
239 Role.non_member.remove_permission!(:view_issues)
239 Role.non_member.remove_permission!(:view_issues)
240 user = User.find(9)
240 user = User.find(9)
241 assert user.projects.empty?
241 assert user.projects.empty?
242 issues = Issue.visible(user).all
242 issues = Issue.visible(user).all
243 assert issues.empty?
243 assert issues.empty?
244 assert_visibility_match user, issues
244 assert_visibility_match user, issues
245 end
245 end
246
246
247 def test_visible_scope_for_member
247 def test_visible_scope_for_member
248 user = User.find(9)
248 user = User.find(9)
249 # User should see issues of projects for which he has view_issues permissions only
249 # User should see issues of projects for which he has view_issues permissions only
250 Role.non_member.remove_permission!(:view_issues)
250 Role.non_member.remove_permission!(:view_issues)
251 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
251 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
252 issues = Issue.visible(user).all
252 issues = Issue.visible(user).all
253 assert issues.any?
253 assert issues.any?
254 assert_nil issues.detect {|issue| issue.project_id != 3}
254 assert_nil issues.detect {|issue| issue.project_id != 3}
255 assert_nil issues.detect {|issue| issue.is_private?}
255 assert_nil issues.detect {|issue| issue.is_private?}
256 assert_visibility_match user, issues
256 assert_visibility_match user, issues
257 end
257 end
258
258
259 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
259 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
260 user = User.find(8)
260 user = User.find(8)
261 assert user.groups.any?
261 assert user.groups.any?
262 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
262 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
263 Role.non_member.remove_permission!(:view_issues)
263 Role.non_member.remove_permission!(:view_issues)
264
264
265 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
265 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
266 :status_id => 1, :priority => IssuePriority.all.first,
266 :status_id => 1, :priority => IssuePriority.all.first,
267 :subject => 'Assignment test',
267 :subject => 'Assignment test',
268 :assigned_to => user.groups.first,
268 :assigned_to => user.groups.first,
269 :is_private => true)
269 :is_private => true)
270
270
271 Role.find(2).update_attribute :issues_visibility, 'default'
271 Role.find(2).update_attribute :issues_visibility, 'default'
272 issues = Issue.visible(User.find(8)).all
272 issues = Issue.visible(User.find(8)).all
273 assert issues.any?
273 assert issues.any?
274 assert issues.include?(issue)
274 assert issues.include?(issue)
275
275
276 Role.find(2).update_attribute :issues_visibility, 'own'
276 Role.find(2).update_attribute :issues_visibility, 'own'
277 issues = Issue.visible(User.find(8)).all
277 issues = Issue.visible(User.find(8)).all
278 assert issues.any?
278 assert issues.any?
279 assert issues.include?(issue)
279 assert issues.include?(issue)
280 end
280 end
281
281
282 def test_visible_scope_for_admin
282 def test_visible_scope_for_admin
283 user = User.find(1)
283 user = User.find(1)
284 user.members.each(&:destroy)
284 user.members.each(&:destroy)
285 assert user.projects.empty?
285 assert user.projects.empty?
286 issues = Issue.visible(user).all
286 issues = Issue.visible(user).all
287 assert issues.any?
287 assert issues.any?
288 # Admin should see issues on private projects that he does not belong to
288 # Admin should see issues on private projects that he does not belong to
289 assert issues.detect {|issue| !issue.project.is_public?}
289 assert issues.detect {|issue| !issue.project.is_public?}
290 # Admin should see private issues of other users
290 # Admin should see private issues of other users
291 assert issues.detect {|issue| issue.is_private? && issue.author != user}
291 assert issues.detect {|issue| issue.is_private? && issue.author != user}
292 assert_visibility_match user, issues
292 assert_visibility_match user, issues
293 end
293 end
294
294
295 def test_visible_scope_with_project
295 def test_visible_scope_with_project
296 project = Project.find(1)
296 project = Project.find(1)
297 issues = Issue.visible(User.find(2), :project => project).all
297 issues = Issue.visible(User.find(2), :project => project).all
298 projects = issues.collect(&:project).uniq
298 projects = issues.collect(&:project).uniq
299 assert_equal 1, projects.size
299 assert_equal 1, projects.size
300 assert_equal project, projects.first
300 assert_equal project, projects.first
301 end
301 end
302
302
303 def test_visible_scope_with_project_and_subprojects
303 def test_visible_scope_with_project_and_subprojects
304 project = Project.find(1)
304 project = Project.find(1)
305 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
305 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
306 projects = issues.collect(&:project).uniq
306 projects = issues.collect(&:project).uniq
307 assert projects.size > 1
307 assert projects.size > 1
308 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
308 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
309 end
309 end
310
310
311 def test_visible_and_nested_set_scopes
311 def test_visible_and_nested_set_scopes
312 assert_equal 0, Issue.find(1).descendants.visible.all.size
312 assert_equal 0, Issue.find(1).descendants.visible.all.size
313 end
313 end
314
314
315 def test_open_scope
315 def test_open_scope
316 issues = Issue.open.all
316 issues = Issue.open.all
317 assert_nil issues.detect(&:closed?)
317 assert_nil issues.detect(&:closed?)
318 end
318 end
319
319
320 def test_open_scope_with_arg
320 def test_open_scope_with_arg
321 issues = Issue.open(false).all
321 issues = Issue.open(false).all
322 assert_equal issues, issues.select(&:closed?)
322 assert_equal issues, issues.select(&:closed?)
323 end
323 end
324
324
325 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
325 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
326 version = Version.find(2)
326 version = Version.find(2)
327 assert version.fixed_issues.any?
327 assert version.fixed_issues.any?
328 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
328 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
329 end
329 end
330
330
331 def test_fixed_version_scope_with_empty_array_should_return_no_result
331 def test_fixed_version_scope_with_empty_array_should_return_no_result
332 assert_equal 0, Issue.fixed_version([]).count
332 assert_equal 0, Issue.fixed_version([]).count
333 end
333 end
334
334
335 def test_errors_full_messages_should_include_custom_fields_errors
335 def test_errors_full_messages_should_include_custom_fields_errors
336 field = IssueCustomField.find_by_name('Database')
336 field = IssueCustomField.find_by_name('Database')
337
337
338 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
338 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
339 :status_id => 1, :subject => 'test_create',
339 :status_id => 1, :subject => 'test_create',
340 :description => 'IssueTest#test_create_with_required_custom_field')
340 :description => 'IssueTest#test_create_with_required_custom_field')
341 assert issue.available_custom_fields.include?(field)
341 assert issue.available_custom_fields.include?(field)
342 # Invalid value
342 # Invalid value
343 issue.custom_field_values = { field.id => 'SQLServer' }
343 issue.custom_field_values = { field.id => 'SQLServer' }
344
344
345 assert !issue.valid?
345 assert !issue.valid?
346 assert_equal 1, issue.errors.full_messages.size
346 assert_equal 1, issue.errors.full_messages.size
347 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
347 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
348 issue.errors.full_messages.first
348 issue.errors.full_messages.first
349 end
349 end
350
350
351 def test_update_issue_with_required_custom_field
351 def test_update_issue_with_required_custom_field
352 field = IssueCustomField.find_by_name('Database')
352 field = IssueCustomField.find_by_name('Database')
353 field.update_attribute(:is_required, true)
353 field.update_attribute(:is_required, true)
354
354
355 issue = Issue.find(1)
355 issue = Issue.find(1)
356 assert_nil issue.custom_value_for(field)
356 assert_nil issue.custom_value_for(field)
357 assert issue.available_custom_fields.include?(field)
357 assert issue.available_custom_fields.include?(field)
358 # No change to custom values, issue can be saved
358 # No change to custom values, issue can be saved
359 assert issue.save
359 assert issue.save
360 # Blank value
360 # Blank value
361 issue.custom_field_values = { field.id => '' }
361 issue.custom_field_values = { field.id => '' }
362 assert !issue.save
362 assert !issue.save
363 # Valid value
363 # Valid value
364 issue.custom_field_values = { field.id => 'PostgreSQL' }
364 issue.custom_field_values = { field.id => 'PostgreSQL' }
365 assert issue.save
365 assert issue.save
366 issue.reload
366 issue.reload
367 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
367 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
368 end
368 end
369
369
370 def test_should_not_update_attributes_if_custom_fields_validation_fails
370 def test_should_not_update_attributes_if_custom_fields_validation_fails
371 issue = Issue.find(1)
371 issue = Issue.find(1)
372 field = IssueCustomField.find_by_name('Database')
372 field = IssueCustomField.find_by_name('Database')
373 assert issue.available_custom_fields.include?(field)
373 assert issue.available_custom_fields.include?(field)
374
374
375 issue.custom_field_values = { field.id => 'Invalid' }
375 issue.custom_field_values = { field.id => 'Invalid' }
376 issue.subject = 'Should be not be saved'
376 issue.subject = 'Should be not be saved'
377 assert !issue.save
377 assert !issue.save
378
378
379 issue.reload
379 issue.reload
380 assert_equal "Can't print recipes", issue.subject
380 assert_equal "Can't print recipes", issue.subject
381 end
381 end
382
382
383 def test_should_not_recreate_custom_values_objects_on_update
383 def test_should_not_recreate_custom_values_objects_on_update
384 field = IssueCustomField.find_by_name('Database')
384 field = IssueCustomField.find_by_name('Database')
385
385
386 issue = Issue.find(1)
386 issue = Issue.find(1)
387 issue.custom_field_values = { field.id => 'PostgreSQL' }
387 issue.custom_field_values = { field.id => 'PostgreSQL' }
388 assert issue.save
388 assert issue.save
389 custom_value = issue.custom_value_for(field)
389 custom_value = issue.custom_value_for(field)
390 issue.reload
390 issue.reload
391 issue.custom_field_values = { field.id => 'MySQL' }
391 issue.custom_field_values = { field.id => 'MySQL' }
392 assert issue.save
392 assert issue.save
393 issue.reload
393 issue.reload
394 assert_equal custom_value.id, issue.custom_value_for(field).id
394 assert_equal custom_value.id, issue.custom_value_for(field).id
395 end
395 end
396
396
397 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
397 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
398 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
398 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
399 :status_id => 1, :subject => 'Test',
399 :status_id => 1, :subject => 'Test',
400 :custom_field_values => {'2' => 'Test'})
400 :custom_field_values => {'2' => 'Test'})
401 assert !Tracker.find(2).custom_field_ids.include?(2)
401 assert !Tracker.find(2).custom_field_ids.include?(2)
402
402
403 issue = Issue.find(issue.id)
403 issue = Issue.find(issue.id)
404 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
404 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
405
405
406 issue = Issue.find(issue.id)
406 issue = Issue.find(issue.id)
407 custom_value = issue.custom_value_for(2)
407 custom_value = issue.custom_value_for(2)
408 assert_not_nil custom_value
408 assert_not_nil custom_value
409 assert_equal 'Test', custom_value.value
409 assert_equal 'Test', custom_value.value
410 end
410 end
411
411
412 def test_assigning_tracker_id_should_reload_custom_fields_values
412 def test_assigning_tracker_id_should_reload_custom_fields_values
413 issue = Issue.new(:project => Project.find(1))
413 issue = Issue.new(:project => Project.find(1))
414 assert issue.custom_field_values.empty?
414 assert issue.custom_field_values.empty?
415 issue.tracker_id = 1
415 issue.tracker_id = 1
416 assert issue.custom_field_values.any?
416 assert issue.custom_field_values.any?
417 end
417 end
418
418
419 def test_assigning_attributes_should_assign_project_and_tracker_first
419 def test_assigning_attributes_should_assign_project_and_tracker_first
420 seq = sequence('seq')
420 seq = sequence('seq')
421 issue = Issue.new
421 issue = Issue.new
422 issue.expects(:project_id=).in_sequence(seq)
422 issue.expects(:project_id=).in_sequence(seq)
423 issue.expects(:tracker_id=).in_sequence(seq)
423 issue.expects(:tracker_id=).in_sequence(seq)
424 issue.expects(:subject=).in_sequence(seq)
424 issue.expects(:subject=).in_sequence(seq)
425 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
425 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
426 end
426 end
427
427
428 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
428 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
429 attributes = ActiveSupport::OrderedHash.new
429 attributes = ActiveSupport::OrderedHash.new
430 attributes['custom_field_values'] = { '1' => 'MySQL' }
430 attributes['custom_field_values'] = { '1' => 'MySQL' }
431 attributes['tracker_id'] = '1'
431 attributes['tracker_id'] = '1'
432 issue = Issue.new(:project => Project.find(1))
432 issue = Issue.new(:project => Project.find(1))
433 issue.attributes = attributes
433 issue.attributes = attributes
434 assert_equal 'MySQL', issue.custom_field_value(1)
434 assert_equal 'MySQL', issue.custom_field_value(1)
435 end
435 end
436
436
437 def test_reload_should_reload_custom_field_values
437 def test_reload_should_reload_custom_field_values
438 issue = Issue.generate!
438 issue = Issue.generate!
439 issue.custom_field_values = {'2' => 'Foo'}
439 issue.custom_field_values = {'2' => 'Foo'}
440 issue.save!
440 issue.save!
441
441
442 issue = Issue.order('id desc').first
442 issue = Issue.order('id desc').first
443 assert_equal 'Foo', issue.custom_field_value(2)
443 assert_equal 'Foo', issue.custom_field_value(2)
444
444
445 issue.custom_field_values = {'2' => 'Bar'}
445 issue.custom_field_values = {'2' => 'Bar'}
446 assert_equal 'Bar', issue.custom_field_value(2)
446 assert_equal 'Bar', issue.custom_field_value(2)
447
447
448 issue.reload
448 issue.reload
449 assert_equal 'Foo', issue.custom_field_value(2)
449 assert_equal 'Foo', issue.custom_field_value(2)
450 end
450 end
451
451
452 def test_should_update_issue_with_disabled_tracker
452 def test_should_update_issue_with_disabled_tracker
453 p = Project.find(1)
453 p = Project.find(1)
454 issue = Issue.find(1)
454 issue = Issue.find(1)
455
455
456 p.trackers.delete(issue.tracker)
456 p.trackers.delete(issue.tracker)
457 assert !p.trackers.include?(issue.tracker)
457 assert !p.trackers.include?(issue.tracker)
458
458
459 issue.reload
459 issue.reload
460 issue.subject = 'New subject'
460 issue.subject = 'New subject'
461 assert issue.save
461 assert issue.save
462 end
462 end
463
463
464 def test_should_not_set_a_disabled_tracker
464 def test_should_not_set_a_disabled_tracker
465 p = Project.find(1)
465 p = Project.find(1)
466 p.trackers.delete(Tracker.find(2))
466 p.trackers.delete(Tracker.find(2))
467
467
468 issue = Issue.find(1)
468 issue = Issue.find(1)
469 issue.tracker_id = 2
469 issue.tracker_id = 2
470 issue.subject = 'New subject'
470 issue.subject = 'New subject'
471 assert !issue.save
471 assert !issue.save
472 assert_not_nil issue.errors[:tracker_id]
472 assert_not_nil issue.errors[:tracker_id]
473 end
473 end
474
474
475 def test_category_based_assignment
475 def test_category_based_assignment
476 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
476 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
477 :status_id => 1, :priority => IssuePriority.all.first,
477 :status_id => 1, :priority => IssuePriority.all.first,
478 :subject => 'Assignment test',
478 :subject => 'Assignment test',
479 :description => 'Assignment test', :category_id => 1)
479 :description => 'Assignment test', :category_id => 1)
480 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
480 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
481 end
481 end
482
482
483 def test_new_statuses_allowed_to
483 def test_new_statuses_allowed_to
484 WorkflowTransition.delete_all
484 WorkflowTransition.delete_all
485 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
485 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
486 :old_status_id => 1, :new_status_id => 2,
486 :old_status_id => 1, :new_status_id => 2,
487 :author => false, :assignee => false)
487 :author => false, :assignee => false)
488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
489 :old_status_id => 1, :new_status_id => 3,
489 :old_status_id => 1, :new_status_id => 3,
490 :author => true, :assignee => false)
490 :author => true, :assignee => false)
491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
491 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
492 :new_status_id => 4, :author => false,
492 :new_status_id => 4, :author => false,
493 :assignee => true)
493 :assignee => true)
494 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
494 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
495 :old_status_id => 1, :new_status_id => 5,
495 :old_status_id => 1, :new_status_id => 5,
496 :author => true, :assignee => true)
496 :author => true, :assignee => true)
497 status = IssueStatus.find(1)
497 status = IssueStatus.find(1)
498 role = Role.find(1)
498 role = Role.find(1)
499 tracker = Tracker.find(1)
499 tracker = Tracker.find(1)
500 user = User.find(2)
500 user = User.find(2)
501
501
502 issue = Issue.generate!(:tracker => tracker, :status => status,
502 issue = Issue.generate!(:tracker => tracker, :status => status,
503 :project_id => 1, :author_id => 1)
503 :project_id => 1, :author_id => 1)
504 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
504 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
505
505
506 issue = Issue.generate!(:tracker => tracker, :status => status,
506 issue = Issue.generate!(:tracker => tracker, :status => status,
507 :project_id => 1, :author => user)
507 :project_id => 1, :author => user)
508 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
508 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
509
509
510 issue = Issue.generate!(:tracker => tracker, :status => status,
510 issue = Issue.generate!(:tracker => tracker, :status => status,
511 :project_id => 1, :author_id => 1,
511 :project_id => 1, :author_id => 1,
512 :assigned_to => user)
512 :assigned_to => user)
513 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
513 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
514
514
515 issue = Issue.generate!(:tracker => tracker, :status => status,
515 issue = Issue.generate!(:tracker => tracker, :status => status,
516 :project_id => 1, :author => user,
516 :project_id => 1, :author => user,
517 :assigned_to => user)
517 :assigned_to => user)
518 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
518 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
519 end
519 end
520
520
521 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
521 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
522 admin = User.find(1)
522 admin = User.find(1)
523 issue = Issue.find(1)
523 issue = Issue.find(1)
524 assert !admin.member_of?(issue.project)
524 assert !admin.member_of?(issue.project)
525 expected_statuses = [issue.status] +
525 expected_statuses = [issue.status] +
526 WorkflowTransition.find_all_by_old_status_id(
526 WorkflowTransition.find_all_by_old_status_id(
527 issue.status_id).map(&:new_status).uniq.sort
527 issue.status_id).map(&:new_status).uniq.sort
528 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
528 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
529 end
529 end
530
530
531 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
531 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
532 issue = Issue.find(1).copy
532 issue = Issue.find(1).copy
533 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
533 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
534
534
535 issue = Issue.find(2).copy
535 issue = Issue.find(2).copy
536 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
536 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
537 end
537 end
538
538
539 def test_safe_attributes_names_should_not_include_disabled_field
539 def test_safe_attributes_names_should_not_include_disabled_field
540 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
540 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
541
541
542 issue = Issue.new(:tracker => tracker)
542 issue = Issue.new(:tracker => tracker)
543 assert_include 'tracker_id', issue.safe_attribute_names
543 assert_include 'tracker_id', issue.safe_attribute_names
544 assert_include 'status_id', issue.safe_attribute_names
544 assert_include 'status_id', issue.safe_attribute_names
545 assert_include 'subject', issue.safe_attribute_names
545 assert_include 'subject', issue.safe_attribute_names
546 assert_include 'description', issue.safe_attribute_names
546 assert_include 'description', issue.safe_attribute_names
547 assert_include 'custom_field_values', issue.safe_attribute_names
547 assert_include 'custom_field_values', issue.safe_attribute_names
548 assert_include 'custom_fields', issue.safe_attribute_names
548 assert_include 'custom_fields', issue.safe_attribute_names
549 assert_include 'lock_version', issue.safe_attribute_names
549 assert_include 'lock_version', issue.safe_attribute_names
550
550
551 tracker.core_fields.each do |field|
551 tracker.core_fields.each do |field|
552 assert_include field, issue.safe_attribute_names
552 assert_include field, issue.safe_attribute_names
553 end
553 end
554
554
555 tracker.disabled_core_fields.each do |field|
555 tracker.disabled_core_fields.each do |field|
556 assert_not_include field, issue.safe_attribute_names
556 assert_not_include field, issue.safe_attribute_names
557 end
557 end
558 end
558 end
559
559
560 def test_safe_attributes_should_ignore_disabled_fields
560 def test_safe_attributes_should_ignore_disabled_fields
561 tracker = Tracker.find(1)
561 tracker = Tracker.find(1)
562 tracker.core_fields = %w(assigned_to_id due_date)
562 tracker.core_fields = %w(assigned_to_id due_date)
563 tracker.save!
563 tracker.save!
564
564
565 issue = Issue.new(:tracker => tracker)
565 issue = Issue.new(:tracker => tracker)
566 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
566 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
567 assert_nil issue.start_date
567 assert_nil issue.start_date
568 assert_equal Date.parse('2012-07-14'), issue.due_date
568 assert_equal Date.parse('2012-07-14'), issue.due_date
569 end
569 end
570
570
571 def test_safe_attributes_should_accept_target_tracker_enabled_fields
571 def test_safe_attributes_should_accept_target_tracker_enabled_fields
572 source = Tracker.find(1)
572 source = Tracker.find(1)
573 source.core_fields = []
573 source.core_fields = []
574 source.save!
574 source.save!
575 target = Tracker.find(2)
575 target = Tracker.find(2)
576 target.core_fields = %w(assigned_to_id due_date)
576 target.core_fields = %w(assigned_to_id due_date)
577 target.save!
577 target.save!
578
578
579 issue = Issue.new(:tracker => source)
579 issue = Issue.new(:tracker => source)
580 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
580 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
581 assert_equal target, issue.tracker
581 assert_equal target, issue.tracker
582 assert_equal Date.parse('2012-07-14'), issue.due_date
582 assert_equal Date.parse('2012-07-14'), issue.due_date
583 end
583 end
584
584
585 def test_safe_attributes_should_not_include_readonly_fields
585 def test_safe_attributes_should_not_include_readonly_fields
586 WorkflowPermission.delete_all
586 WorkflowPermission.delete_all
587 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
587 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
588 :role_id => 1, :field_name => 'due_date',
588 :role_id => 1, :field_name => 'due_date',
589 :rule => 'readonly')
589 :rule => 'readonly')
590 user = User.find(2)
590 user = User.find(2)
591
591
592 issue = Issue.new(:project_id => 1, :tracker_id => 1)
592 issue = Issue.new(:project_id => 1, :tracker_id => 1)
593 assert_equal %w(due_date), issue.read_only_attribute_names(user)
593 assert_equal %w(due_date), issue.read_only_attribute_names(user)
594 assert_not_include 'due_date', issue.safe_attribute_names(user)
594 assert_not_include 'due_date', issue.safe_attribute_names(user)
595
595
596 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
596 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
597 assert_equal Date.parse('2012-07-14'), issue.start_date
597 assert_equal Date.parse('2012-07-14'), issue.start_date
598 assert_nil issue.due_date
598 assert_nil issue.due_date
599 end
599 end
600
600
601 def test_safe_attributes_should_not_include_readonly_custom_fields
601 def test_safe_attributes_should_not_include_readonly_custom_fields
602 cf1 = IssueCustomField.create!(:name => 'Writable field',
602 cf1 = IssueCustomField.create!(:name => 'Writable field',
603 :field_format => 'string',
603 :field_format => 'string',
604 :is_for_all => true, :tracker_ids => [1])
604 :is_for_all => true, :tracker_ids => [1])
605 cf2 = IssueCustomField.create!(:name => 'Readonly field',
605 cf2 = IssueCustomField.create!(:name => 'Readonly field',
606 :field_format => 'string',
606 :field_format => 'string',
607 :is_for_all => true, :tracker_ids => [1])
607 :is_for_all => true, :tracker_ids => [1])
608 WorkflowPermission.delete_all
608 WorkflowPermission.delete_all
609 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
609 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
610 :role_id => 1, :field_name => cf2.id.to_s,
610 :role_id => 1, :field_name => cf2.id.to_s,
611 :rule => 'readonly')
611 :rule => 'readonly')
612 user = User.find(2)
612 user = User.find(2)
613 issue = Issue.new(:project_id => 1, :tracker_id => 1)
613 issue = Issue.new(:project_id => 1, :tracker_id => 1)
614 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
614 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
615 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
615 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
616
616
617 issue.send :safe_attributes=, {'custom_field_values' => {
617 issue.send :safe_attributes=, {'custom_field_values' => {
618 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
618 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
619 }}, user
619 }}, user
620 assert_equal 'value1', issue.custom_field_value(cf1)
620 assert_equal 'value1', issue.custom_field_value(cf1)
621 assert_nil issue.custom_field_value(cf2)
621 assert_nil issue.custom_field_value(cf2)
622
622
623 issue.send :safe_attributes=, {'custom_fields' => [
623 issue.send :safe_attributes=, {'custom_fields' => [
624 {'id' => cf1.id.to_s, 'value' => 'valuea'},
624 {'id' => cf1.id.to_s, 'value' => 'valuea'},
625 {'id' => cf2.id.to_s, 'value' => 'valueb'}
625 {'id' => cf2.id.to_s, 'value' => 'valueb'}
626 ]}, user
626 ]}, user
627 assert_equal 'valuea', issue.custom_field_value(cf1)
627 assert_equal 'valuea', issue.custom_field_value(cf1)
628 assert_nil issue.custom_field_value(cf2)
628 assert_nil issue.custom_field_value(cf2)
629 end
629 end
630
630
631 def test_editable_custom_field_values_should_return_non_readonly_custom_values
631 def test_editable_custom_field_values_should_return_non_readonly_custom_values
632 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
632 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
633 :is_for_all => true, :tracker_ids => [1, 2])
633 :is_for_all => true, :tracker_ids => [1, 2])
634 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
634 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
635 :is_for_all => true, :tracker_ids => [1, 2])
635 :is_for_all => true, :tracker_ids => [1, 2])
636 WorkflowPermission.delete_all
636 WorkflowPermission.delete_all
637 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
637 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
638 :field_name => cf2.id.to_s, :rule => 'readonly')
638 :field_name => cf2.id.to_s, :rule => 'readonly')
639 user = User.find(2)
639 user = User.find(2)
640
640
641 issue = Issue.new(:project_id => 1, :tracker_id => 1)
641 issue = Issue.new(:project_id => 1, :tracker_id => 1)
642 values = issue.editable_custom_field_values(user)
642 values = issue.editable_custom_field_values(user)
643 assert values.detect {|value| value.custom_field == cf1}
643 assert values.detect {|value| value.custom_field == cf1}
644 assert_nil values.detect {|value| value.custom_field == cf2}
644 assert_nil values.detect {|value| value.custom_field == cf2}
645
645
646 issue.tracker_id = 2
646 issue.tracker_id = 2
647 values = issue.editable_custom_field_values(user)
647 values = issue.editable_custom_field_values(user)
648 assert values.detect {|value| value.custom_field == cf1}
648 assert values.detect {|value| value.custom_field == cf1}
649 assert values.detect {|value| value.custom_field == cf2}
649 assert values.detect {|value| value.custom_field == cf2}
650 end
650 end
651
651
652 def test_safe_attributes_should_accept_target_tracker_writable_fields
652 def test_safe_attributes_should_accept_target_tracker_writable_fields
653 WorkflowPermission.delete_all
653 WorkflowPermission.delete_all
654 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
654 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
655 :role_id => 1, :field_name => 'due_date',
655 :role_id => 1, :field_name => 'due_date',
656 :rule => 'readonly')
656 :rule => 'readonly')
657 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
657 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
658 :role_id => 1, :field_name => 'start_date',
658 :role_id => 1, :field_name => 'start_date',
659 :rule => 'readonly')
659 :rule => 'readonly')
660 user = User.find(2)
660 user = User.find(2)
661
661
662 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
662 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
663
663
664 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
664 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
665 'due_date' => '2012-07-14'}, user
665 'due_date' => '2012-07-14'}, user
666 assert_equal Date.parse('2012-07-12'), issue.start_date
666 assert_equal Date.parse('2012-07-12'), issue.start_date
667 assert_nil issue.due_date
667 assert_nil issue.due_date
668
668
669 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
669 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
670 'due_date' => '2012-07-16',
670 'due_date' => '2012-07-16',
671 'tracker_id' => 2}, user
671 'tracker_id' => 2}, user
672 assert_equal Date.parse('2012-07-12'), issue.start_date
672 assert_equal Date.parse('2012-07-12'), issue.start_date
673 assert_equal Date.parse('2012-07-16'), issue.due_date
673 assert_equal Date.parse('2012-07-16'), issue.due_date
674 end
674 end
675
675
676 def test_safe_attributes_should_accept_target_status_writable_fields
676 def test_safe_attributes_should_accept_target_status_writable_fields
677 WorkflowPermission.delete_all
677 WorkflowPermission.delete_all
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
679 :role_id => 1, :field_name => 'due_date',
679 :role_id => 1, :field_name => 'due_date',
680 :rule => 'readonly')
680 :rule => 'readonly')
681 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
681 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
682 :role_id => 1, :field_name => 'start_date',
682 :role_id => 1, :field_name => 'start_date',
683 :rule => 'readonly')
683 :rule => 'readonly')
684 user = User.find(2)
684 user = User.find(2)
685
685
686 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
686 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
687
687
688 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
688 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
689 'due_date' => '2012-07-14'},
689 'due_date' => '2012-07-14'},
690 user
690 user
691 assert_equal Date.parse('2012-07-12'), issue.start_date
691 assert_equal Date.parse('2012-07-12'), issue.start_date
692 assert_nil issue.due_date
692 assert_nil issue.due_date
693
693
694 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
694 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
695 'due_date' => '2012-07-16',
695 'due_date' => '2012-07-16',
696 'status_id' => 2},
696 'status_id' => 2},
697 user
697 user
698 assert_equal Date.parse('2012-07-12'), issue.start_date
698 assert_equal Date.parse('2012-07-12'), issue.start_date
699 assert_equal Date.parse('2012-07-16'), issue.due_date
699 assert_equal Date.parse('2012-07-16'), issue.due_date
700 end
700 end
701
701
702 def test_required_attributes_should_be_validated
702 def test_required_attributes_should_be_validated
703 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
703 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
704 :is_for_all => true, :tracker_ids => [1, 2])
704 :is_for_all => true, :tracker_ids => [1, 2])
705
705
706 WorkflowPermission.delete_all
706 WorkflowPermission.delete_all
707 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
707 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
708 :role_id => 1, :field_name => 'due_date',
708 :role_id => 1, :field_name => 'due_date',
709 :rule => 'required')
709 :rule => 'required')
710 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
710 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
711 :role_id => 1, :field_name => 'category_id',
711 :role_id => 1, :field_name => 'category_id',
712 :rule => 'required')
712 :rule => 'required')
713 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
713 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
714 :role_id => 1, :field_name => cf.id.to_s,
714 :role_id => 1, :field_name => cf.id.to_s,
715 :rule => 'required')
715 :rule => 'required')
716
716
717 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
717 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
718 :role_id => 1, :field_name => 'start_date',
718 :role_id => 1, :field_name => 'start_date',
719 :rule => 'required')
719 :rule => 'required')
720 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
720 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
721 :role_id => 1, :field_name => cf.id.to_s,
721 :role_id => 1, :field_name => cf.id.to_s,
722 :rule => 'required')
722 :rule => 'required')
723 user = User.find(2)
723 user = User.find(2)
724
724
725 issue = Issue.new(:project_id => 1, :tracker_id => 1,
725 issue = Issue.new(:project_id => 1, :tracker_id => 1,
726 :status_id => 1, :subject => 'Required fields',
726 :status_id => 1, :subject => 'Required fields',
727 :author => user)
727 :author => user)
728 assert_equal [cf.id.to_s, "category_id", "due_date"],
728 assert_equal [cf.id.to_s, "category_id", "due_date"],
729 issue.required_attribute_names(user).sort
729 issue.required_attribute_names(user).sort
730 assert !issue.save, "Issue was saved"
730 assert !issue.save, "Issue was saved"
731 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
731 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
732 issue.errors.full_messages.sort
732 issue.errors.full_messages.sort
733
733
734 issue.tracker_id = 2
734 issue.tracker_id = 2
735 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
735 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
736 assert !issue.save, "Issue was saved"
736 assert !issue.save, "Issue was saved"
737 assert_equal ["Foo can't be blank", "Start date can't be blank"],
737 assert_equal ["Foo can't be blank", "Start date can't be blank"],
738 issue.errors.full_messages.sort
738 issue.errors.full_messages.sort
739
739
740 issue.start_date = Date.today
740 issue.start_date = Date.today
741 issue.custom_field_values = {cf.id.to_s => 'bar'}
741 issue.custom_field_values = {cf.id.to_s => 'bar'}
742 assert issue.save
742 assert issue.save
743 end
743 end
744
744
745 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
745 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
746 WorkflowPermission.delete_all
746 WorkflowPermission.delete_all
747 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
747 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
748 :role_id => 1, :field_name => 'due_date',
748 :role_id => 1, :field_name => 'due_date',
749 :rule => 'required')
749 :rule => 'required')
750 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
750 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
751 :role_id => 1, :field_name => 'start_date',
751 :role_id => 1, :field_name => 'start_date',
752 :rule => 'required')
752 :rule => 'required')
753 user = User.find(2)
753 user = User.find(2)
754 member = Member.find(1)
754 member = Member.find(1)
755 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
755 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
756
756
757 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
757 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
758
758
759 member.role_ids = [1, 2]
759 member.role_ids = [1, 2]
760 member.save!
760 member.save!
761 assert_equal [], issue.required_attribute_names(user.reload)
761 assert_equal [], issue.required_attribute_names(user.reload)
762
762
763 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
763 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
764 :role_id => 2, :field_name => 'due_date',
764 :role_id => 2, :field_name => 'due_date',
765 :rule => 'required')
765 :rule => 'required')
766 assert_equal %w(due_date), issue.required_attribute_names(user)
766 assert_equal %w(due_date), issue.required_attribute_names(user)
767
767
768 member.role_ids = [1, 2, 3]
768 member.role_ids = [1, 2, 3]
769 member.save!
769 member.save!
770 assert_equal [], issue.required_attribute_names(user.reload)
770 assert_equal [], issue.required_attribute_names(user.reload)
771
771
772 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
772 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
773 :role_id => 2, :field_name => 'due_date',
773 :role_id => 2, :field_name => 'due_date',
774 :rule => 'readonly')
774 :rule => 'readonly')
775 # required + readonly => required
775 # required + readonly => required
776 assert_equal %w(due_date), issue.required_attribute_names(user)
776 assert_equal %w(due_date), issue.required_attribute_names(user)
777 end
777 end
778
778
779 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
779 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
780 WorkflowPermission.delete_all
780 WorkflowPermission.delete_all
781 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
781 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
782 :role_id => 1, :field_name => 'due_date',
782 :role_id => 1, :field_name => 'due_date',
783 :rule => 'readonly')
783 :rule => 'readonly')
784 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
784 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
785 :role_id => 1, :field_name => 'start_date',
785 :role_id => 1, :field_name => 'start_date',
786 :rule => 'readonly')
786 :rule => 'readonly')
787 user = User.find(2)
787 user = User.find(2)
788 member = Member.find(1)
788 member = Member.find(1)
789 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
789 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
790
790
791 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
791 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
792
792
793 member.role_ids = [1, 2]
793 member.role_ids = [1, 2]
794 member.save!
794 member.save!
795 assert_equal [], issue.read_only_attribute_names(user.reload)
795 assert_equal [], issue.read_only_attribute_names(user.reload)
796
796
797 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
797 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
798 :role_id => 2, :field_name => 'due_date',
798 :role_id => 2, :field_name => 'due_date',
799 :rule => 'readonly')
799 :rule => 'readonly')
800 assert_equal %w(due_date), issue.read_only_attribute_names(user)
800 assert_equal %w(due_date), issue.read_only_attribute_names(user)
801 end
801 end
802
802
803 def test_copy
803 def test_copy
804 issue = Issue.new.copy_from(1)
804 issue = Issue.new.copy_from(1)
805 assert issue.copy?
805 assert issue.copy?
806 assert issue.save
806 assert issue.save
807 issue.reload
807 issue.reload
808 orig = Issue.find(1)
808 orig = Issue.find(1)
809 assert_equal orig.subject, issue.subject
809 assert_equal orig.subject, issue.subject
810 assert_equal orig.tracker, issue.tracker
810 assert_equal orig.tracker, issue.tracker
811 assert_equal "125", issue.custom_value_for(2).value
811 assert_equal "125", issue.custom_value_for(2).value
812 end
812 end
813
813
814 def test_copy_should_copy_status
814 def test_copy_should_copy_status
815 orig = Issue.find(8)
815 orig = Issue.find(8)
816 assert orig.status != IssueStatus.default
816 assert orig.status != IssueStatus.default
817
817
818 issue = Issue.new.copy_from(orig)
818 issue = Issue.new.copy_from(orig)
819 assert issue.save
819 assert issue.save
820 issue.reload
820 issue.reload
821 assert_equal orig.status, issue.status
821 assert_equal orig.status, issue.status
822 end
822 end
823
823
824 def test_copy_should_add_relation_with_copied_issue
824 def test_copy_should_add_relation_with_copied_issue
825 copied = Issue.find(1)
825 copied = Issue.find(1)
826 issue = Issue.new.copy_from(copied)
826 issue = Issue.new.copy_from(copied)
827 assert issue.save
827 assert issue.save
828 issue.reload
828 issue.reload
829
829
830 assert_equal 1, issue.relations.size
830 assert_equal 1, issue.relations.size
831 relation = issue.relations.first
831 relation = issue.relations.first
832 assert_equal 'copied_to', relation.relation_type
832 assert_equal 'copied_to', relation.relation_type
833 assert_equal copied, relation.issue_from
833 assert_equal copied, relation.issue_from
834 assert_equal issue, relation.issue_to
834 assert_equal issue, relation.issue_to
835 end
835 end
836
836
837 def test_copy_should_copy_subtasks
837 def test_copy_should_copy_subtasks
838 issue = Issue.generate_with_descendants!
838 issue = Issue.generate_with_descendants!
839
839
840 copy = issue.reload.copy
840 copy = issue.reload.copy
841 copy.author = User.find(7)
841 copy.author = User.find(7)
842 assert_difference 'Issue.count', 1+issue.descendants.count do
842 assert_difference 'Issue.count', 1+issue.descendants.count do
843 assert copy.save
843 assert copy.save
844 end
844 end
845 copy.reload
845 copy.reload
846 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
846 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
847 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
847 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
848 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
848 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
849 assert_equal copy.author, child_copy.author
849 assert_equal copy.author, child_copy.author
850 end
850 end
851
851
852 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
853 parent = Issue.generate!
854 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
855 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
856
857 copy = parent.reload.copy
858 copy.parent_issue_id = parent.id
859 copy.author = User.find(7)
860 assert_difference 'Issue.count', 3 do
861 assert copy.save
862 end
863 parent.reload
864 copy.reload
865 assert_equal parent, copy.parent
866 assert_equal 3, parent.children.count
867 assert_equal 5, parent.descendants.count
868 assert_equal 2, copy.children.count
869 assert_equal 2, copy.descendants.count
870 end
871
872 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
873 parent = Issue.generate!
874 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
875 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
876
877 copy = parent.reload.copy
878 copy.parent_issue_id = child1.id
879 copy.author = User.find(7)
880 assert_difference 'Issue.count', 3 do
881 assert copy.save
882 end
883 parent.reload
884 child1.reload
885 copy.reload
886 assert_equal child1, copy.parent
887 assert_equal 2, parent.children.count
888 assert_equal 5, parent.descendants.count
889 assert_equal 1, child1.children.count
890 assert_equal 3, child1.descendants.count
891 assert_equal 2, copy.children.count
892 assert_equal 2, copy.descendants.count
893 end
894
852 def test_copy_should_copy_subtasks_to_target_project
895 def test_copy_should_copy_subtasks_to_target_project
853 issue = Issue.generate_with_descendants!
896 issue = Issue.generate_with_descendants!
854
897
855 copy = issue.copy(:project_id => 3)
898 copy = issue.copy(:project_id => 3)
856 assert_difference 'Issue.count', 1+issue.descendants.count do
899 assert_difference 'Issue.count', 1+issue.descendants.count do
857 assert copy.save
900 assert copy.save
858 end
901 end
859 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
902 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
860 end
903 end
861
904
862 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
905 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
863 issue = Issue.generate_with_descendants!
906 issue = Issue.generate_with_descendants!
864
907
865 copy = issue.reload.copy
908 copy = issue.reload.copy
866 assert_difference 'Issue.count', 1+issue.descendants.count do
909 assert_difference 'Issue.count', 1+issue.descendants.count do
867 assert copy.save
910 assert copy.save
868 assert copy.save
911 assert copy.save
869 end
912 end
870 end
913 end
871
914
872 def test_should_not_call_after_project_change_on_creation
915 def test_should_not_call_after_project_change_on_creation
873 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
916 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
874 :subject => 'Test', :author_id => 1)
917 :subject => 'Test', :author_id => 1)
875 issue.expects(:after_project_change).never
918 issue.expects(:after_project_change).never
876 issue.save!
919 issue.save!
877 end
920 end
878
921
879 def test_should_not_call_after_project_change_on_update
922 def test_should_not_call_after_project_change_on_update
880 issue = Issue.find(1)
923 issue = Issue.find(1)
881 issue.project = Project.find(1)
924 issue.project = Project.find(1)
882 issue.subject = 'No project change'
925 issue.subject = 'No project change'
883 issue.expects(:after_project_change).never
926 issue.expects(:after_project_change).never
884 issue.save!
927 issue.save!
885 end
928 end
886
929
887 def test_should_call_after_project_change_on_project_change
930 def test_should_call_after_project_change_on_project_change
888 issue = Issue.find(1)
931 issue = Issue.find(1)
889 issue.project = Project.find(2)
932 issue.project = Project.find(2)
890 issue.expects(:after_project_change).once
933 issue.expects(:after_project_change).once
891 issue.save!
934 issue.save!
892 end
935 end
893
936
894 def test_adding_journal_should_update_timestamp
937 def test_adding_journal_should_update_timestamp
895 issue = Issue.find(1)
938 issue = Issue.find(1)
896 updated_on_was = issue.updated_on
939 updated_on_was = issue.updated_on
897
940
898 issue.init_journal(User.first, "Adding notes")
941 issue.init_journal(User.first, "Adding notes")
899 assert_difference 'Journal.count' do
942 assert_difference 'Journal.count' do
900 assert issue.save
943 assert issue.save
901 end
944 end
902 issue.reload
945 issue.reload
903
946
904 assert_not_equal updated_on_was, issue.updated_on
947 assert_not_equal updated_on_was, issue.updated_on
905 end
948 end
906
949
907 def test_should_close_duplicates
950 def test_should_close_duplicates
908 # Create 3 issues
951 # Create 3 issues
909 issue1 = Issue.generate!
952 issue1 = Issue.generate!
910 issue2 = Issue.generate!
953 issue2 = Issue.generate!
911 issue3 = Issue.generate!
954 issue3 = Issue.generate!
912
955
913 # 2 is a dupe of 1
956 # 2 is a dupe of 1
914 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
957 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
915 :relation_type => IssueRelation::TYPE_DUPLICATES)
958 :relation_type => IssueRelation::TYPE_DUPLICATES)
916 # And 3 is a dupe of 2
959 # And 3 is a dupe of 2
917 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
960 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
918 :relation_type => IssueRelation::TYPE_DUPLICATES)
961 :relation_type => IssueRelation::TYPE_DUPLICATES)
919 # And 3 is a dupe of 1 (circular duplicates)
962 # And 3 is a dupe of 1 (circular duplicates)
920 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
963 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
921 :relation_type => IssueRelation::TYPE_DUPLICATES)
964 :relation_type => IssueRelation::TYPE_DUPLICATES)
922
965
923 assert issue1.reload.duplicates.include?(issue2)
966 assert issue1.reload.duplicates.include?(issue2)
924
967
925 # Closing issue 1
968 # Closing issue 1
926 issue1.init_journal(User.first, "Closing issue1")
969 issue1.init_journal(User.first, "Closing issue1")
927 issue1.status = IssueStatus.where(:is_closed => true).first
970 issue1.status = IssueStatus.where(:is_closed => true).first
928 assert issue1.save
971 assert issue1.save
929 # 2 and 3 should be also closed
972 # 2 and 3 should be also closed
930 assert issue2.reload.closed?
973 assert issue2.reload.closed?
931 assert issue3.reload.closed?
974 assert issue3.reload.closed?
932 end
975 end
933
976
934 def test_should_not_close_duplicated_issue
977 def test_should_not_close_duplicated_issue
935 issue1 = Issue.generate!
978 issue1 = Issue.generate!
936 issue2 = Issue.generate!
979 issue2 = Issue.generate!
937
980
938 # 2 is a dupe of 1
981 # 2 is a dupe of 1
939 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
982 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
940 :relation_type => IssueRelation::TYPE_DUPLICATES)
983 :relation_type => IssueRelation::TYPE_DUPLICATES)
941 # 2 is a dup of 1 but 1 is not a duplicate of 2
984 # 2 is a dup of 1 but 1 is not a duplicate of 2
942 assert !issue2.reload.duplicates.include?(issue1)
985 assert !issue2.reload.duplicates.include?(issue1)
943
986
944 # Closing issue 2
987 # Closing issue 2
945 issue2.init_journal(User.first, "Closing issue2")
988 issue2.init_journal(User.first, "Closing issue2")
946 issue2.status = IssueStatus.where(:is_closed => true).first
989 issue2.status = IssueStatus.where(:is_closed => true).first
947 assert issue2.save
990 assert issue2.save
948 # 1 should not be also closed
991 # 1 should not be also closed
949 assert !issue1.reload.closed?
992 assert !issue1.reload.closed?
950 end
993 end
951
994
952 def test_assignable_versions
995 def test_assignable_versions
953 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
996 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
954 :status_id => 1, :fixed_version_id => 1,
997 :status_id => 1, :fixed_version_id => 1,
955 :subject => 'New issue')
998 :subject => 'New issue')
956 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
999 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
957 end
1000 end
958
1001
959 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1002 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
960 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1003 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
961 :status_id => 1, :fixed_version_id => 1,
1004 :status_id => 1, :fixed_version_id => 1,
962 :subject => 'New issue')
1005 :subject => 'New issue')
963 assert !issue.save
1006 assert !issue.save
964 assert_not_nil issue.errors[:fixed_version_id]
1007 assert_not_nil issue.errors[:fixed_version_id]
965 end
1008 end
966
1009
967 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1010 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
968 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1011 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
969 :status_id => 1, :fixed_version_id => 2,
1012 :status_id => 1, :fixed_version_id => 2,
970 :subject => 'New issue')
1013 :subject => 'New issue')
971 assert !issue.save
1014 assert !issue.save
972 assert_not_nil issue.errors[:fixed_version_id]
1015 assert_not_nil issue.errors[:fixed_version_id]
973 end
1016 end
974
1017
975 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1018 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
976 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1019 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
977 :status_id => 1, :fixed_version_id => 3,
1020 :status_id => 1, :fixed_version_id => 3,
978 :subject => 'New issue')
1021 :subject => 'New issue')
979 assert issue.save
1022 assert issue.save
980 end
1023 end
981
1024
982 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1025 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
983 issue = Issue.find(11)
1026 issue = Issue.find(11)
984 assert_equal 'closed', issue.fixed_version.status
1027 assert_equal 'closed', issue.fixed_version.status
985 issue.subject = 'Subject changed'
1028 issue.subject = 'Subject changed'
986 assert issue.save
1029 assert issue.save
987 end
1030 end
988
1031
989 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1032 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
990 issue = Issue.find(11)
1033 issue = Issue.find(11)
991 issue.status_id = 1
1034 issue.status_id = 1
992 assert !issue.save
1035 assert !issue.save
993 assert_not_nil issue.errors[:base]
1036 assert_not_nil issue.errors[:base]
994 end
1037 end
995
1038
996 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1039 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
997 issue = Issue.find(11)
1040 issue = Issue.find(11)
998 issue.status_id = 1
1041 issue.status_id = 1
999 issue.fixed_version_id = 3
1042 issue.fixed_version_id = 3
1000 assert issue.save
1043 assert issue.save
1001 end
1044 end
1002
1045
1003 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1046 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1004 issue = Issue.find(12)
1047 issue = Issue.find(12)
1005 assert_equal 'locked', issue.fixed_version.status
1048 assert_equal 'locked', issue.fixed_version.status
1006 issue.status_id = 1
1049 issue.status_id = 1
1007 assert issue.save
1050 assert issue.save
1008 end
1051 end
1009
1052
1010 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1053 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1011 issue = Issue.find(2)
1054 issue = Issue.find(2)
1012 assert_equal 2, issue.fixed_version_id
1055 assert_equal 2, issue.fixed_version_id
1013 issue.project_id = 3
1056 issue.project_id = 3
1014 assert_nil issue.fixed_version_id
1057 assert_nil issue.fixed_version_id
1015 issue.fixed_version_id = 2
1058 issue.fixed_version_id = 2
1016 assert !issue.save
1059 assert !issue.save
1017 assert_include 'Target version is not included in the list', issue.errors.full_messages
1060 assert_include 'Target version is not included in the list', issue.errors.full_messages
1018 end
1061 end
1019
1062
1020 def test_should_keep_shared_version_when_changing_project
1063 def test_should_keep_shared_version_when_changing_project
1021 Version.find(2).update_attribute :sharing, 'tree'
1064 Version.find(2).update_attribute :sharing, 'tree'
1022
1065
1023 issue = Issue.find(2)
1066 issue = Issue.find(2)
1024 assert_equal 2, issue.fixed_version_id
1067 assert_equal 2, issue.fixed_version_id
1025 issue.project_id = 3
1068 issue.project_id = 3
1026 assert_equal 2, issue.fixed_version_id
1069 assert_equal 2, issue.fixed_version_id
1027 assert issue.save
1070 assert issue.save
1028 end
1071 end
1029
1072
1030 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
1073 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
1031 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1074 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1032 end
1075 end
1033
1076
1034 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
1077 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
1035 Project.find(2).disable_module! :issue_tracking
1078 Project.find(2).disable_module! :issue_tracking
1036 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1079 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
1037 end
1080 end
1038
1081
1039 def test_move_to_another_project_with_same_category
1082 def test_move_to_another_project_with_same_category
1040 issue = Issue.find(1)
1083 issue = Issue.find(1)
1041 issue.project = Project.find(2)
1084 issue.project = Project.find(2)
1042 assert issue.save
1085 assert issue.save
1043 issue.reload
1086 issue.reload
1044 assert_equal 2, issue.project_id
1087 assert_equal 2, issue.project_id
1045 # Category changes
1088 # Category changes
1046 assert_equal 4, issue.category_id
1089 assert_equal 4, issue.category_id
1047 # Make sure time entries were move to the target project
1090 # Make sure time entries were move to the target project
1048 assert_equal 2, issue.time_entries.first.project_id
1091 assert_equal 2, issue.time_entries.first.project_id
1049 end
1092 end
1050
1093
1051 def test_move_to_another_project_without_same_category
1094 def test_move_to_another_project_without_same_category
1052 issue = Issue.find(2)
1095 issue = Issue.find(2)
1053 issue.project = Project.find(2)
1096 issue.project = Project.find(2)
1054 assert issue.save
1097 assert issue.save
1055 issue.reload
1098 issue.reload
1056 assert_equal 2, issue.project_id
1099 assert_equal 2, issue.project_id
1057 # Category cleared
1100 # Category cleared
1058 assert_nil issue.category_id
1101 assert_nil issue.category_id
1059 end
1102 end
1060
1103
1061 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1104 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1062 issue = Issue.find(1)
1105 issue = Issue.find(1)
1063 issue.update_attribute(:fixed_version_id, 1)
1106 issue.update_attribute(:fixed_version_id, 1)
1064 issue.project = Project.find(2)
1107 issue.project = Project.find(2)
1065 assert issue.save
1108 assert issue.save
1066 issue.reload
1109 issue.reload
1067 assert_equal 2, issue.project_id
1110 assert_equal 2, issue.project_id
1068 # Cleared fixed_version
1111 # Cleared fixed_version
1069 assert_equal nil, issue.fixed_version
1112 assert_equal nil, issue.fixed_version
1070 end
1113 end
1071
1114
1072 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1115 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1073 issue = Issue.find(1)
1116 issue = Issue.find(1)
1074 issue.update_attribute(:fixed_version_id, 4)
1117 issue.update_attribute(:fixed_version_id, 4)
1075 issue.project = Project.find(5)
1118 issue.project = Project.find(5)
1076 assert issue.save
1119 assert issue.save
1077 issue.reload
1120 issue.reload
1078 assert_equal 5, issue.project_id
1121 assert_equal 5, issue.project_id
1079 # Keep fixed_version
1122 # Keep fixed_version
1080 assert_equal 4, issue.fixed_version_id
1123 assert_equal 4, issue.fixed_version_id
1081 end
1124 end
1082
1125
1083 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1126 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1084 issue = Issue.find(1)
1127 issue = Issue.find(1)
1085 issue.update_attribute(:fixed_version_id, 1)
1128 issue.update_attribute(:fixed_version_id, 1)
1086 issue.project = Project.find(5)
1129 issue.project = Project.find(5)
1087 assert issue.save
1130 assert issue.save
1088 issue.reload
1131 issue.reload
1089 assert_equal 5, issue.project_id
1132 assert_equal 5, issue.project_id
1090 # Cleared fixed_version
1133 # Cleared fixed_version
1091 assert_equal nil, issue.fixed_version
1134 assert_equal nil, issue.fixed_version
1092 end
1135 end
1093
1136
1094 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1137 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1095 issue = Issue.find(1)
1138 issue = Issue.find(1)
1096 issue.update_attribute(:fixed_version_id, 7)
1139 issue.update_attribute(:fixed_version_id, 7)
1097 issue.project = Project.find(2)
1140 issue.project = Project.find(2)
1098 assert issue.save
1141 assert issue.save
1099 issue.reload
1142 issue.reload
1100 assert_equal 2, issue.project_id
1143 assert_equal 2, issue.project_id
1101 # Keep fixed_version
1144 # Keep fixed_version
1102 assert_equal 7, issue.fixed_version_id
1145 assert_equal 7, issue.fixed_version_id
1103 end
1146 end
1104
1147
1105 def test_move_to_another_project_should_keep_parent_if_valid
1148 def test_move_to_another_project_should_keep_parent_if_valid
1106 issue = Issue.find(1)
1149 issue = Issue.find(1)
1107 issue.update_attribute(:parent_issue_id, 2)
1150 issue.update_attribute(:parent_issue_id, 2)
1108 issue.project = Project.find(3)
1151 issue.project = Project.find(3)
1109 assert issue.save
1152 assert issue.save
1110 issue.reload
1153 issue.reload
1111 assert_equal 2, issue.parent_id
1154 assert_equal 2, issue.parent_id
1112 end
1155 end
1113
1156
1114 def test_move_to_another_project_should_clear_parent_if_not_valid
1157 def test_move_to_another_project_should_clear_parent_if_not_valid
1115 issue = Issue.find(1)
1158 issue = Issue.find(1)
1116 issue.update_attribute(:parent_issue_id, 2)
1159 issue.update_attribute(:parent_issue_id, 2)
1117 issue.project = Project.find(2)
1160 issue.project = Project.find(2)
1118 assert issue.save
1161 assert issue.save
1119 issue.reload
1162 issue.reload
1120 assert_nil issue.parent_id
1163 assert_nil issue.parent_id
1121 end
1164 end
1122
1165
1123 def test_move_to_another_project_with_disabled_tracker
1166 def test_move_to_another_project_with_disabled_tracker
1124 issue = Issue.find(1)
1167 issue = Issue.find(1)
1125 target = Project.find(2)
1168 target = Project.find(2)
1126 target.tracker_ids = [3]
1169 target.tracker_ids = [3]
1127 target.save
1170 target.save
1128 issue.project = target
1171 issue.project = target
1129 assert issue.save
1172 assert issue.save
1130 issue.reload
1173 issue.reload
1131 assert_equal 2, issue.project_id
1174 assert_equal 2, issue.project_id
1132 assert_equal 3, issue.tracker_id
1175 assert_equal 3, issue.tracker_id
1133 end
1176 end
1134
1177
1135 def test_copy_to_the_same_project
1178 def test_copy_to_the_same_project
1136 issue = Issue.find(1)
1179 issue = Issue.find(1)
1137 copy = issue.copy
1180 copy = issue.copy
1138 assert_difference 'Issue.count' do
1181 assert_difference 'Issue.count' do
1139 copy.save!
1182 copy.save!
1140 end
1183 end
1141 assert_kind_of Issue, copy
1184 assert_kind_of Issue, copy
1142 assert_equal issue.project, copy.project
1185 assert_equal issue.project, copy.project
1143 assert_equal "125", copy.custom_value_for(2).value
1186 assert_equal "125", copy.custom_value_for(2).value
1144 end
1187 end
1145
1188
1146 def test_copy_to_another_project_and_tracker
1189 def test_copy_to_another_project_and_tracker
1147 issue = Issue.find(1)
1190 issue = Issue.find(1)
1148 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1191 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1149 assert_difference 'Issue.count' do
1192 assert_difference 'Issue.count' do
1150 copy.save!
1193 copy.save!
1151 end
1194 end
1152 copy.reload
1195 copy.reload
1153 assert_kind_of Issue, copy
1196 assert_kind_of Issue, copy
1154 assert_equal Project.find(3), copy.project
1197 assert_equal Project.find(3), copy.project
1155 assert_equal Tracker.find(2), copy.tracker
1198 assert_equal Tracker.find(2), copy.tracker
1156 # Custom field #2 is not associated with target tracker
1199 # Custom field #2 is not associated with target tracker
1157 assert_nil copy.custom_value_for(2)
1200 assert_nil copy.custom_value_for(2)
1158 end
1201 end
1159
1202
1160 test "#copy should not create a journal" do
1203 test "#copy should not create a journal" do
1161 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1204 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1162 copy.save!
1205 copy.save!
1163 assert_equal 0, copy.reload.journals.size
1206 assert_equal 0, copy.reload.journals.size
1164 end
1207 end
1165
1208
1166 test "#copy should allow assigned_to changes" do
1209 test "#copy should allow assigned_to changes" do
1167 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1210 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1168 assert_equal 3, copy.assigned_to_id
1211 assert_equal 3, copy.assigned_to_id
1169 end
1212 end
1170
1213
1171 test "#copy should allow status changes" do
1214 test "#copy should allow status changes" do
1172 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1215 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1173 assert_equal 2, copy.status_id
1216 assert_equal 2, copy.status_id
1174 end
1217 end
1175
1218
1176 test "#copy should allow start date changes" do
1219 test "#copy should allow start date changes" do
1177 date = Date.today
1220 date = Date.today
1178 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1221 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1179 assert_equal date, copy.start_date
1222 assert_equal date, copy.start_date
1180 end
1223 end
1181
1224
1182 test "#copy should allow due date changes" do
1225 test "#copy should allow due date changes" do
1183 date = Date.today
1226 date = Date.today
1184 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1227 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1185 assert_equal date, copy.due_date
1228 assert_equal date, copy.due_date
1186 end
1229 end
1187
1230
1188 test "#copy should set current user as author" do
1231 test "#copy should set current user as author" do
1189 User.current = User.find(9)
1232 User.current = User.find(9)
1190 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1233 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1191 assert_equal User.current, copy.author
1234 assert_equal User.current, copy.author
1192 end
1235 end
1193
1236
1194 test "#copy should create a journal with notes" do
1237 test "#copy should create a journal with notes" do
1195 date = Date.today
1238 date = Date.today
1196 notes = "Notes added when copying"
1239 notes = "Notes added when copying"
1197 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1240 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1198 copy.init_journal(User.current, notes)
1241 copy.init_journal(User.current, notes)
1199 copy.save!
1242 copy.save!
1200
1243
1201 assert_equal 1, copy.journals.size
1244 assert_equal 1, copy.journals.size
1202 journal = copy.journals.first
1245 journal = copy.journals.first
1203 assert_equal 0, journal.details.size
1246 assert_equal 0, journal.details.size
1204 assert_equal notes, journal.notes
1247 assert_equal notes, journal.notes
1205 end
1248 end
1206
1249
1207 def test_valid_parent_project
1250 def test_valid_parent_project
1208 issue = Issue.find(1)
1251 issue = Issue.find(1)
1209 issue_in_same_project = Issue.find(2)
1252 issue_in_same_project = Issue.find(2)
1210 issue_in_child_project = Issue.find(5)
1253 issue_in_child_project = Issue.find(5)
1211 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1254 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1212 issue_in_other_child_project = Issue.find(6)
1255 issue_in_other_child_project = Issue.find(6)
1213 issue_in_different_tree = Issue.find(4)
1256 issue_in_different_tree = Issue.find(4)
1214
1257
1215 with_settings :cross_project_subtasks => '' do
1258 with_settings :cross_project_subtasks => '' do
1216 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1259 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1217 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1260 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1218 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1261 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1219 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1262 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1220 end
1263 end
1221
1264
1222 with_settings :cross_project_subtasks => 'system' do
1265 with_settings :cross_project_subtasks => 'system' do
1223 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1266 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1224 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1267 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1225 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1268 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1226 end
1269 end
1227
1270
1228 with_settings :cross_project_subtasks => 'tree' do
1271 with_settings :cross_project_subtasks => 'tree' do
1229 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1272 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1230 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1273 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1231 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1274 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1232 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1275 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1233
1276
1234 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1277 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1235 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1278 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1236 end
1279 end
1237
1280
1238 with_settings :cross_project_subtasks => 'descendants' do
1281 with_settings :cross_project_subtasks => 'descendants' do
1239 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1282 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1240 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1283 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1241 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1284 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1242 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1285 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1243
1286
1244 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1287 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1245 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1288 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1246 end
1289 end
1247 end
1290 end
1248
1291
1249 def test_recipients_should_include_previous_assignee
1292 def test_recipients_should_include_previous_assignee
1250 user = User.find(3)
1293 user = User.find(3)
1251 user.members.update_all ["mail_notification = ?", false]
1294 user.members.update_all ["mail_notification = ?", false]
1252 user.update_attribute :mail_notification, 'only_assigned'
1295 user.update_attribute :mail_notification, 'only_assigned'
1253
1296
1254 issue = Issue.find(2)
1297 issue = Issue.find(2)
1255 issue.assigned_to = nil
1298 issue.assigned_to = nil
1256 assert_include user.mail, issue.recipients
1299 assert_include user.mail, issue.recipients
1257 issue.save!
1300 issue.save!
1258 assert !issue.recipients.include?(user.mail)
1301 assert !issue.recipients.include?(user.mail)
1259 end
1302 end
1260
1303
1261 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1304 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1262 issue = Issue.find(12)
1305 issue = Issue.find(12)
1263 assert issue.recipients.include?(issue.author.mail)
1306 assert issue.recipients.include?(issue.author.mail)
1264 # copy the issue to a private project
1307 # copy the issue to a private project
1265 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1308 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1266 # author is not a member of project anymore
1309 # author is not a member of project anymore
1267 assert !copy.recipients.include?(copy.author.mail)
1310 assert !copy.recipients.include?(copy.author.mail)
1268 end
1311 end
1269
1312
1270 def test_recipients_should_include_the_assigned_group_members
1313 def test_recipients_should_include_the_assigned_group_members
1271 group_member = User.generate!
1314 group_member = User.generate!
1272 group = Group.generate!
1315 group = Group.generate!
1273 group.users << group_member
1316 group.users << group_member
1274
1317
1275 issue = Issue.find(12)
1318 issue = Issue.find(12)
1276 issue.assigned_to = group
1319 issue.assigned_to = group
1277 assert issue.recipients.include?(group_member.mail)
1320 assert issue.recipients.include?(group_member.mail)
1278 end
1321 end
1279
1322
1280 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1323 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1281 user = User.find(3)
1324 user = User.find(3)
1282 issue = Issue.find(9)
1325 issue = Issue.find(9)
1283 Watcher.create!(:user => user, :watchable => issue)
1326 Watcher.create!(:user => user, :watchable => issue)
1284 assert issue.watched_by?(user)
1327 assert issue.watched_by?(user)
1285 assert !issue.watcher_recipients.include?(user.mail)
1328 assert !issue.watcher_recipients.include?(user.mail)
1286 end
1329 end
1287
1330
1288 def test_issue_destroy
1331 def test_issue_destroy
1289 Issue.find(1).destroy
1332 Issue.find(1).destroy
1290 assert_nil Issue.find_by_id(1)
1333 assert_nil Issue.find_by_id(1)
1291 assert_nil TimeEntry.find_by_issue_id(1)
1334 assert_nil TimeEntry.find_by_issue_id(1)
1292 end
1335 end
1293
1336
1294 def test_destroying_a_deleted_issue_should_not_raise_an_error
1337 def test_destroying_a_deleted_issue_should_not_raise_an_error
1295 issue = Issue.find(1)
1338 issue = Issue.find(1)
1296 Issue.find(1).destroy
1339 Issue.find(1).destroy
1297
1340
1298 assert_nothing_raised do
1341 assert_nothing_raised do
1299 assert_no_difference 'Issue.count' do
1342 assert_no_difference 'Issue.count' do
1300 issue.destroy
1343 issue.destroy
1301 end
1344 end
1302 assert issue.destroyed?
1345 assert issue.destroyed?
1303 end
1346 end
1304 end
1347 end
1305
1348
1306 def test_destroying_a_stale_issue_should_not_raise_an_error
1349 def test_destroying_a_stale_issue_should_not_raise_an_error
1307 issue = Issue.find(1)
1350 issue = Issue.find(1)
1308 Issue.find(1).update_attribute :subject, "Updated"
1351 Issue.find(1).update_attribute :subject, "Updated"
1309
1352
1310 assert_nothing_raised do
1353 assert_nothing_raised do
1311 assert_difference 'Issue.count', -1 do
1354 assert_difference 'Issue.count', -1 do
1312 issue.destroy
1355 issue.destroy
1313 end
1356 end
1314 assert issue.destroyed?
1357 assert issue.destroyed?
1315 end
1358 end
1316 end
1359 end
1317
1360
1318 def test_blocked
1361 def test_blocked
1319 blocked_issue = Issue.find(9)
1362 blocked_issue = Issue.find(9)
1320 blocking_issue = Issue.find(10)
1363 blocking_issue = Issue.find(10)
1321
1364
1322 assert blocked_issue.blocked?
1365 assert blocked_issue.blocked?
1323 assert !blocking_issue.blocked?
1366 assert !blocking_issue.blocked?
1324 end
1367 end
1325
1368
1326 def test_blocked_issues_dont_allow_closed_statuses
1369 def test_blocked_issues_dont_allow_closed_statuses
1327 blocked_issue = Issue.find(9)
1370 blocked_issue = Issue.find(9)
1328
1371
1329 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1372 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1330 assert !allowed_statuses.empty?
1373 assert !allowed_statuses.empty?
1331 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1374 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1332 assert closed_statuses.empty?
1375 assert closed_statuses.empty?
1333 end
1376 end
1334
1377
1335 def test_unblocked_issues_allow_closed_statuses
1378 def test_unblocked_issues_allow_closed_statuses
1336 blocking_issue = Issue.find(10)
1379 blocking_issue = Issue.find(10)
1337
1380
1338 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1381 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1339 assert !allowed_statuses.empty?
1382 assert !allowed_statuses.empty?
1340 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1383 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1341 assert !closed_statuses.empty?
1384 assert !closed_statuses.empty?
1342 end
1385 end
1343
1386
1344 def test_reschedule_an_issue_without_dates
1387 def test_reschedule_an_issue_without_dates
1345 with_settings :non_working_week_days => [] do
1388 with_settings :non_working_week_days => [] do
1346 issue = Issue.new(:start_date => nil, :due_date => nil)
1389 issue = Issue.new(:start_date => nil, :due_date => nil)
1347 issue.reschedule_on '2012-10-09'.to_date
1390 issue.reschedule_on '2012-10-09'.to_date
1348 assert_equal '2012-10-09'.to_date, issue.start_date
1391 assert_equal '2012-10-09'.to_date, issue.start_date
1349 assert_equal '2012-10-09'.to_date, issue.due_date
1392 assert_equal '2012-10-09'.to_date, issue.due_date
1350 end
1393 end
1351
1394
1352 with_settings :non_working_week_days => %w(6 7) do
1395 with_settings :non_working_week_days => %w(6 7) do
1353 issue = Issue.new(:start_date => nil, :due_date => nil)
1396 issue = Issue.new(:start_date => nil, :due_date => nil)
1354 issue.reschedule_on '2012-10-09'.to_date
1397 issue.reschedule_on '2012-10-09'.to_date
1355 assert_equal '2012-10-09'.to_date, issue.start_date
1398 assert_equal '2012-10-09'.to_date, issue.start_date
1356 assert_equal '2012-10-09'.to_date, issue.due_date
1399 assert_equal '2012-10-09'.to_date, issue.due_date
1357
1400
1358 issue = Issue.new(:start_date => nil, :due_date => nil)
1401 issue = Issue.new(:start_date => nil, :due_date => nil)
1359 issue.reschedule_on '2012-10-13'.to_date
1402 issue.reschedule_on '2012-10-13'.to_date
1360 assert_equal '2012-10-15'.to_date, issue.start_date
1403 assert_equal '2012-10-15'.to_date, issue.start_date
1361 assert_equal '2012-10-15'.to_date, issue.due_date
1404 assert_equal '2012-10-15'.to_date, issue.due_date
1362 end
1405 end
1363 end
1406 end
1364
1407
1365 def test_reschedule_an_issue_with_start_date
1408 def test_reschedule_an_issue_with_start_date
1366 with_settings :non_working_week_days => [] do
1409 with_settings :non_working_week_days => [] do
1367 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1410 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1368 issue.reschedule_on '2012-10-13'.to_date
1411 issue.reschedule_on '2012-10-13'.to_date
1369 assert_equal '2012-10-13'.to_date, issue.start_date
1412 assert_equal '2012-10-13'.to_date, issue.start_date
1370 assert_equal '2012-10-13'.to_date, issue.due_date
1413 assert_equal '2012-10-13'.to_date, issue.due_date
1371 end
1414 end
1372
1415
1373 with_settings :non_working_week_days => %w(6 7) do
1416 with_settings :non_working_week_days => %w(6 7) do
1374 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1417 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1375 issue.reschedule_on '2012-10-11'.to_date
1418 issue.reschedule_on '2012-10-11'.to_date
1376 assert_equal '2012-10-11'.to_date, issue.start_date
1419 assert_equal '2012-10-11'.to_date, issue.start_date
1377 assert_equal '2012-10-11'.to_date, issue.due_date
1420 assert_equal '2012-10-11'.to_date, issue.due_date
1378
1421
1379 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1422 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1380 issue.reschedule_on '2012-10-13'.to_date
1423 issue.reschedule_on '2012-10-13'.to_date
1381 assert_equal '2012-10-15'.to_date, issue.start_date
1424 assert_equal '2012-10-15'.to_date, issue.start_date
1382 assert_equal '2012-10-15'.to_date, issue.due_date
1425 assert_equal '2012-10-15'.to_date, issue.due_date
1383 end
1426 end
1384 end
1427 end
1385
1428
1386 def test_reschedule_an_issue_with_start_and_due_dates
1429 def test_reschedule_an_issue_with_start_and_due_dates
1387 with_settings :non_working_week_days => [] do
1430 with_settings :non_working_week_days => [] do
1388 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1431 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1389 issue.reschedule_on '2012-10-13'.to_date
1432 issue.reschedule_on '2012-10-13'.to_date
1390 assert_equal '2012-10-13'.to_date, issue.start_date
1433 assert_equal '2012-10-13'.to_date, issue.start_date
1391 assert_equal '2012-10-19'.to_date, issue.due_date
1434 assert_equal '2012-10-19'.to_date, issue.due_date
1392 end
1435 end
1393
1436
1394 with_settings :non_working_week_days => %w(6 7) do
1437 with_settings :non_working_week_days => %w(6 7) do
1395 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1438 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1396 issue.reschedule_on '2012-10-11'.to_date
1439 issue.reschedule_on '2012-10-11'.to_date
1397 assert_equal '2012-10-11'.to_date, issue.start_date
1440 assert_equal '2012-10-11'.to_date, issue.start_date
1398 assert_equal '2012-10-23'.to_date, issue.due_date
1441 assert_equal '2012-10-23'.to_date, issue.due_date
1399
1442
1400 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1443 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1401 issue.reschedule_on '2012-10-13'.to_date
1444 issue.reschedule_on '2012-10-13'.to_date
1402 assert_equal '2012-10-15'.to_date, issue.start_date
1445 assert_equal '2012-10-15'.to_date, issue.start_date
1403 assert_equal '2012-10-25'.to_date, issue.due_date
1446 assert_equal '2012-10-25'.to_date, issue.due_date
1404 end
1447 end
1405 end
1448 end
1406
1449
1407 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1450 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1408 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1451 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1409 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1452 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1410 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1453 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1411 :relation_type => IssueRelation::TYPE_PRECEDES)
1454 :relation_type => IssueRelation::TYPE_PRECEDES)
1412 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1455 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1413
1456
1414 issue1.reload
1457 issue1.reload
1415 issue1.due_date = '2012-10-23'
1458 issue1.due_date = '2012-10-23'
1416 issue1.save!
1459 issue1.save!
1417 issue2.reload
1460 issue2.reload
1418 assert_equal Date.parse('2012-10-24'), issue2.start_date
1461 assert_equal Date.parse('2012-10-24'), issue2.start_date
1419 assert_equal Date.parse('2012-10-26'), issue2.due_date
1462 assert_equal Date.parse('2012-10-26'), issue2.due_date
1420 end
1463 end
1421
1464
1422 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1465 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1423 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1466 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1424 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1467 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1425 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1468 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1426 :relation_type => IssueRelation::TYPE_PRECEDES)
1469 :relation_type => IssueRelation::TYPE_PRECEDES)
1427 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1470 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1428
1471
1429 issue1.reload
1472 issue1.reload
1430 issue1.start_date = '2012-09-17'
1473 issue1.start_date = '2012-09-17'
1431 issue1.due_date = '2012-09-18'
1474 issue1.due_date = '2012-09-18'
1432 issue1.save!
1475 issue1.save!
1433 issue2.reload
1476 issue2.reload
1434 assert_equal Date.parse('2012-09-19'), issue2.start_date
1477 assert_equal Date.parse('2012-09-19'), issue2.start_date
1435 assert_equal Date.parse('2012-09-21'), issue2.due_date
1478 assert_equal Date.parse('2012-09-21'), issue2.due_date
1436 end
1479 end
1437
1480
1438 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1481 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1439 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1482 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1440 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1483 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1441 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1484 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1442 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1485 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1443 :relation_type => IssueRelation::TYPE_PRECEDES)
1486 :relation_type => IssueRelation::TYPE_PRECEDES)
1444 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1487 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1445 :relation_type => IssueRelation::TYPE_PRECEDES)
1488 :relation_type => IssueRelation::TYPE_PRECEDES)
1446 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1489 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1447
1490
1448 issue1.reload
1491 issue1.reload
1449 issue1.start_date = '2012-09-17'
1492 issue1.start_date = '2012-09-17'
1450 issue1.due_date = '2012-09-18'
1493 issue1.due_date = '2012-09-18'
1451 issue1.save!
1494 issue1.save!
1452 issue2.reload
1495 issue2.reload
1453 # Issue 2 must start after Issue 3
1496 # Issue 2 must start after Issue 3
1454 assert_equal Date.parse('2012-10-03'), issue2.start_date
1497 assert_equal Date.parse('2012-10-03'), issue2.start_date
1455 assert_equal Date.parse('2012-10-05'), issue2.due_date
1498 assert_equal Date.parse('2012-10-05'), issue2.due_date
1456 end
1499 end
1457
1500
1458 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1501 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1459 with_settings :non_working_week_days => [] do
1502 with_settings :non_working_week_days => [] do
1460 stale = Issue.find(1)
1503 stale = Issue.find(1)
1461 issue = Issue.find(1)
1504 issue = Issue.find(1)
1462 issue.subject = "Updated"
1505 issue.subject = "Updated"
1463 issue.save!
1506 issue.save!
1464 date = 10.days.from_now.to_date
1507 date = 10.days.from_now.to_date
1465 assert_nothing_raised do
1508 assert_nothing_raised do
1466 stale.reschedule_on!(date)
1509 stale.reschedule_on!(date)
1467 end
1510 end
1468 assert_equal date, stale.reload.start_date
1511 assert_equal date, stale.reload.start_date
1469 end
1512 end
1470 end
1513 end
1471
1514
1472 def test_overdue
1515 def test_overdue
1473 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1516 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1474 assert !Issue.new(:due_date => Date.today).overdue?
1517 assert !Issue.new(:due_date => Date.today).overdue?
1475 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1518 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1476 assert !Issue.new(:due_date => nil).overdue?
1519 assert !Issue.new(:due_date => nil).overdue?
1477 assert !Issue.new(:due_date => 1.day.ago.to_date,
1520 assert !Issue.new(:due_date => 1.day.ago.to_date,
1478 :status => IssueStatus.where(:is_closed => true).first
1521 :status => IssueStatus.where(:is_closed => true).first
1479 ).overdue?
1522 ).overdue?
1480 end
1523 end
1481
1524
1482 test "#behind_schedule? should be false if the issue has no start_date" do
1525 test "#behind_schedule? should be false if the issue has no start_date" do
1483 assert !Issue.new(:start_date => nil,
1526 assert !Issue.new(:start_date => nil,
1484 :due_date => 1.day.from_now.to_date,
1527 :due_date => 1.day.from_now.to_date,
1485 :done_ratio => 0).behind_schedule?
1528 :done_ratio => 0).behind_schedule?
1486 end
1529 end
1487
1530
1488 test "#behind_schedule? should be false if the issue has no end_date" do
1531 test "#behind_schedule? should be false if the issue has no end_date" do
1489 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1532 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1490 :due_date => nil,
1533 :due_date => nil,
1491 :done_ratio => 0).behind_schedule?
1534 :done_ratio => 0).behind_schedule?
1492 end
1535 end
1493
1536
1494 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
1537 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
1495 assert !Issue.new(:start_date => 50.days.ago.to_date,
1538 assert !Issue.new(:start_date => 50.days.ago.to_date,
1496 :due_date => 50.days.from_now.to_date,
1539 :due_date => 50.days.from_now.to_date,
1497 :done_ratio => 90).behind_schedule?
1540 :done_ratio => 90).behind_schedule?
1498 end
1541 end
1499
1542
1500 test "#behind_schedule? should be true if the issue hasn't been started at all" do
1543 test "#behind_schedule? should be true if the issue hasn't been started at all" do
1501 assert Issue.new(:start_date => 1.day.ago.to_date,
1544 assert Issue.new(:start_date => 1.day.ago.to_date,
1502 :due_date => 1.day.from_now.to_date,
1545 :due_date => 1.day.from_now.to_date,
1503 :done_ratio => 0).behind_schedule?
1546 :done_ratio => 0).behind_schedule?
1504 end
1547 end
1505
1548
1506 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
1549 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
1507 assert Issue.new(:start_date => 100.days.ago.to_date,
1550 assert Issue.new(:start_date => 100.days.ago.to_date,
1508 :due_date => Date.today,
1551 :due_date => Date.today,
1509 :done_ratio => 90).behind_schedule?
1552 :done_ratio => 90).behind_schedule?
1510 end
1553 end
1511
1554
1512 test "#assignable_users should be Users" do
1555 test "#assignable_users should be Users" do
1513 assert_kind_of User, Issue.find(1).assignable_users.first
1556 assert_kind_of User, Issue.find(1).assignable_users.first
1514 end
1557 end
1515
1558
1516 test "#assignable_users should include the issue author" do
1559 test "#assignable_users should include the issue author" do
1517 non_project_member = User.generate!
1560 non_project_member = User.generate!
1518 issue = Issue.generate!(:author => non_project_member)
1561 issue = Issue.generate!(:author => non_project_member)
1519
1562
1520 assert issue.assignable_users.include?(non_project_member)
1563 assert issue.assignable_users.include?(non_project_member)
1521 end
1564 end
1522
1565
1523 test "#assignable_users should include the current assignee" do
1566 test "#assignable_users should include the current assignee" do
1524 user = User.generate!
1567 user = User.generate!
1525 issue = Issue.generate!(:assigned_to => user)
1568 issue = Issue.generate!(:assigned_to => user)
1526 user.lock!
1569 user.lock!
1527
1570
1528 assert Issue.find(issue.id).assignable_users.include?(user)
1571 assert Issue.find(issue.id).assignable_users.include?(user)
1529 end
1572 end
1530
1573
1531 test "#assignable_users should not show the issue author twice" do
1574 test "#assignable_users should not show the issue author twice" do
1532 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1575 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1533 assert_equal 2, assignable_user_ids.length
1576 assert_equal 2, assignable_user_ids.length
1534
1577
1535 assignable_user_ids.each do |user_id|
1578 assignable_user_ids.each do |user_id|
1536 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1579 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1537 "User #{user_id} appears more or less than once"
1580 "User #{user_id} appears more or less than once"
1538 end
1581 end
1539 end
1582 end
1540
1583
1541 test "#assignable_users with issue_group_assignment should include groups" do
1584 test "#assignable_users with issue_group_assignment should include groups" do
1542 issue = Issue.new(:project => Project.find(2))
1585 issue = Issue.new(:project => Project.find(2))
1543
1586
1544 with_settings :issue_group_assignment => '1' do
1587 with_settings :issue_group_assignment => '1' do
1545 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1588 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1546 assert issue.assignable_users.include?(Group.find(11))
1589 assert issue.assignable_users.include?(Group.find(11))
1547 end
1590 end
1548 end
1591 end
1549
1592
1550 test "#assignable_users without issue_group_assignment should not include groups" do
1593 test "#assignable_users without issue_group_assignment should not include groups" do
1551 issue = Issue.new(:project => Project.find(2))
1594 issue = Issue.new(:project => Project.find(2))
1552
1595
1553 with_settings :issue_group_assignment => '0' do
1596 with_settings :issue_group_assignment => '0' do
1554 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1597 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1555 assert !issue.assignable_users.include?(Group.find(11))
1598 assert !issue.assignable_users.include?(Group.find(11))
1556 end
1599 end
1557 end
1600 end
1558
1601
1559 def test_create_should_send_email_notification
1602 def test_create_should_send_email_notification
1560 ActionMailer::Base.deliveries.clear
1603 ActionMailer::Base.deliveries.clear
1561 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1604 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1562 :author_id => 3, :status_id => 1,
1605 :author_id => 3, :status_id => 1,
1563 :priority => IssuePriority.all.first,
1606 :priority => IssuePriority.all.first,
1564 :subject => 'test_create', :estimated_hours => '1:30')
1607 :subject => 'test_create', :estimated_hours => '1:30')
1565
1608
1566 assert issue.save
1609 assert issue.save
1567 assert_equal 1, ActionMailer::Base.deliveries.size
1610 assert_equal 1, ActionMailer::Base.deliveries.size
1568 end
1611 end
1569
1612
1570 def test_stale_issue_should_not_send_email_notification
1613 def test_stale_issue_should_not_send_email_notification
1571 ActionMailer::Base.deliveries.clear
1614 ActionMailer::Base.deliveries.clear
1572 issue = Issue.find(1)
1615 issue = Issue.find(1)
1573 stale = Issue.find(1)
1616 stale = Issue.find(1)
1574
1617
1575 issue.init_journal(User.find(1))
1618 issue.init_journal(User.find(1))
1576 issue.subject = 'Subjet update'
1619 issue.subject = 'Subjet update'
1577 assert issue.save
1620 assert issue.save
1578 assert_equal 1, ActionMailer::Base.deliveries.size
1621 assert_equal 1, ActionMailer::Base.deliveries.size
1579 ActionMailer::Base.deliveries.clear
1622 ActionMailer::Base.deliveries.clear
1580
1623
1581 stale.init_journal(User.find(1))
1624 stale.init_journal(User.find(1))
1582 stale.subject = 'Another subjet update'
1625 stale.subject = 'Another subjet update'
1583 assert_raise ActiveRecord::StaleObjectError do
1626 assert_raise ActiveRecord::StaleObjectError do
1584 stale.save
1627 stale.save
1585 end
1628 end
1586 assert ActionMailer::Base.deliveries.empty?
1629 assert ActionMailer::Base.deliveries.empty?
1587 end
1630 end
1588
1631
1589 def test_journalized_description
1632 def test_journalized_description
1590 IssueCustomField.delete_all
1633 IssueCustomField.delete_all
1591
1634
1592 i = Issue.first
1635 i = Issue.first
1593 old_description = i.description
1636 old_description = i.description
1594 new_description = "This is the new description"
1637 new_description = "This is the new description"
1595
1638
1596 i.init_journal(User.find(2))
1639 i.init_journal(User.find(2))
1597 i.description = new_description
1640 i.description = new_description
1598 assert_difference 'Journal.count', 1 do
1641 assert_difference 'Journal.count', 1 do
1599 assert_difference 'JournalDetail.count', 1 do
1642 assert_difference 'JournalDetail.count', 1 do
1600 i.save!
1643 i.save!
1601 end
1644 end
1602 end
1645 end
1603
1646
1604 detail = JournalDetail.first(:order => 'id DESC')
1647 detail = JournalDetail.first(:order => 'id DESC')
1605 assert_equal i, detail.journal.journalized
1648 assert_equal i, detail.journal.journalized
1606 assert_equal 'attr', detail.property
1649 assert_equal 'attr', detail.property
1607 assert_equal 'description', detail.prop_key
1650 assert_equal 'description', detail.prop_key
1608 assert_equal old_description, detail.old_value
1651 assert_equal old_description, detail.old_value
1609 assert_equal new_description, detail.value
1652 assert_equal new_description, detail.value
1610 end
1653 end
1611
1654
1612 def test_blank_descriptions_should_not_be_journalized
1655 def test_blank_descriptions_should_not_be_journalized
1613 IssueCustomField.delete_all
1656 IssueCustomField.delete_all
1614 Issue.update_all("description = NULL", "id=1")
1657 Issue.update_all("description = NULL", "id=1")
1615
1658
1616 i = Issue.find(1)
1659 i = Issue.find(1)
1617 i.init_journal(User.find(2))
1660 i.init_journal(User.find(2))
1618 i.subject = "blank description"
1661 i.subject = "blank description"
1619 i.description = "\r\n"
1662 i.description = "\r\n"
1620
1663
1621 assert_difference 'Journal.count', 1 do
1664 assert_difference 'Journal.count', 1 do
1622 assert_difference 'JournalDetail.count', 1 do
1665 assert_difference 'JournalDetail.count', 1 do
1623 i.save!
1666 i.save!
1624 end
1667 end
1625 end
1668 end
1626 end
1669 end
1627
1670
1628 def test_journalized_multi_custom_field
1671 def test_journalized_multi_custom_field
1629 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1672 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1630 :is_filter => true, :is_for_all => true,
1673 :is_filter => true, :is_for_all => true,
1631 :tracker_ids => [1],
1674 :tracker_ids => [1],
1632 :possible_values => ['value1', 'value2', 'value3'],
1675 :possible_values => ['value1', 'value2', 'value3'],
1633 :multiple => true)
1676 :multiple => true)
1634
1677
1635 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1678 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1636 :subject => 'Test', :author_id => 1)
1679 :subject => 'Test', :author_id => 1)
1637
1680
1638 assert_difference 'Journal.count' do
1681 assert_difference 'Journal.count' do
1639 assert_difference 'JournalDetail.count' do
1682 assert_difference 'JournalDetail.count' do
1640 issue.init_journal(User.first)
1683 issue.init_journal(User.first)
1641 issue.custom_field_values = {field.id => ['value1']}
1684 issue.custom_field_values = {field.id => ['value1']}
1642 issue.save!
1685 issue.save!
1643 end
1686 end
1644 assert_difference 'JournalDetail.count' do
1687 assert_difference 'JournalDetail.count' do
1645 issue.init_journal(User.first)
1688 issue.init_journal(User.first)
1646 issue.custom_field_values = {field.id => ['value1', 'value2']}
1689 issue.custom_field_values = {field.id => ['value1', 'value2']}
1647 issue.save!
1690 issue.save!
1648 end
1691 end
1649 assert_difference 'JournalDetail.count', 2 do
1692 assert_difference 'JournalDetail.count', 2 do
1650 issue.init_journal(User.first)
1693 issue.init_journal(User.first)
1651 issue.custom_field_values = {field.id => ['value3', 'value2']}
1694 issue.custom_field_values = {field.id => ['value3', 'value2']}
1652 issue.save!
1695 issue.save!
1653 end
1696 end
1654 assert_difference 'JournalDetail.count', 2 do
1697 assert_difference 'JournalDetail.count', 2 do
1655 issue.init_journal(User.first)
1698 issue.init_journal(User.first)
1656 issue.custom_field_values = {field.id => nil}
1699 issue.custom_field_values = {field.id => nil}
1657 issue.save!
1700 issue.save!
1658 end
1701 end
1659 end
1702 end
1660 end
1703 end
1661
1704
1662 def test_description_eol_should_be_normalized
1705 def test_description_eol_should_be_normalized
1663 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1706 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1664 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1707 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1665 end
1708 end
1666
1709
1667 def test_saving_twice_should_not_duplicate_journal_details
1710 def test_saving_twice_should_not_duplicate_journal_details
1668 i = Issue.first
1711 i = Issue.first
1669 i.init_journal(User.find(2), 'Some notes')
1712 i.init_journal(User.find(2), 'Some notes')
1670 # initial changes
1713 # initial changes
1671 i.subject = 'New subject'
1714 i.subject = 'New subject'
1672 i.done_ratio = i.done_ratio + 10
1715 i.done_ratio = i.done_ratio + 10
1673 assert_difference 'Journal.count' do
1716 assert_difference 'Journal.count' do
1674 assert i.save
1717 assert i.save
1675 end
1718 end
1676 # 1 more change
1719 # 1 more change
1677 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
1720 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
1678 assert_no_difference 'Journal.count' do
1721 assert_no_difference 'Journal.count' do
1679 assert_difference 'JournalDetail.count', 1 do
1722 assert_difference 'JournalDetail.count', 1 do
1680 i.save
1723 i.save
1681 end
1724 end
1682 end
1725 end
1683 # no more change
1726 # no more change
1684 assert_no_difference 'Journal.count' do
1727 assert_no_difference 'Journal.count' do
1685 assert_no_difference 'JournalDetail.count' do
1728 assert_no_difference 'JournalDetail.count' do
1686 i.save
1729 i.save
1687 end
1730 end
1688 end
1731 end
1689 end
1732 end
1690
1733
1691 def test_all_dependent_issues
1734 def test_all_dependent_issues
1692 IssueRelation.delete_all
1735 IssueRelation.delete_all
1693 assert IssueRelation.create!(:issue_from => Issue.find(1),
1736 assert IssueRelation.create!(:issue_from => Issue.find(1),
1694 :issue_to => Issue.find(2),
1737 :issue_to => Issue.find(2),
1695 :relation_type => IssueRelation::TYPE_PRECEDES)
1738 :relation_type => IssueRelation::TYPE_PRECEDES)
1696 assert IssueRelation.create!(:issue_from => Issue.find(2),
1739 assert IssueRelation.create!(:issue_from => Issue.find(2),
1697 :issue_to => Issue.find(3),
1740 :issue_to => Issue.find(3),
1698 :relation_type => IssueRelation::TYPE_PRECEDES)
1741 :relation_type => IssueRelation::TYPE_PRECEDES)
1699 assert IssueRelation.create!(:issue_from => Issue.find(3),
1742 assert IssueRelation.create!(:issue_from => Issue.find(3),
1700 :issue_to => Issue.find(8),
1743 :issue_to => Issue.find(8),
1701 :relation_type => IssueRelation::TYPE_PRECEDES)
1744 :relation_type => IssueRelation::TYPE_PRECEDES)
1702
1745
1703 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1746 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1704 end
1747 end
1705
1748
1706 def test_all_dependent_issues_with_persistent_circular_dependency
1749 def test_all_dependent_issues_with_persistent_circular_dependency
1707 IssueRelation.delete_all
1750 IssueRelation.delete_all
1708 assert IssueRelation.create!(:issue_from => Issue.find(1),
1751 assert IssueRelation.create!(:issue_from => Issue.find(1),
1709 :issue_to => Issue.find(2),
1752 :issue_to => Issue.find(2),
1710 :relation_type => IssueRelation::TYPE_PRECEDES)
1753 :relation_type => IssueRelation::TYPE_PRECEDES)
1711 assert IssueRelation.create!(:issue_from => Issue.find(2),
1754 assert IssueRelation.create!(:issue_from => Issue.find(2),
1712 :issue_to => Issue.find(3),
1755 :issue_to => Issue.find(3),
1713 :relation_type => IssueRelation::TYPE_PRECEDES)
1756 :relation_type => IssueRelation::TYPE_PRECEDES)
1714
1757
1715 r = IssueRelation.create!(:issue_from => Issue.find(3),
1758 r = IssueRelation.create!(:issue_from => Issue.find(3),
1716 :issue_to => Issue.find(7),
1759 :issue_to => Issue.find(7),
1717 :relation_type => IssueRelation::TYPE_PRECEDES)
1760 :relation_type => IssueRelation::TYPE_PRECEDES)
1718 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1761 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1719
1762
1720 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1763 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1721 end
1764 end
1722
1765
1723 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1766 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1724 IssueRelation.delete_all
1767 IssueRelation.delete_all
1725 assert IssueRelation.create!(:issue_from => Issue.find(1),
1768 assert IssueRelation.create!(:issue_from => Issue.find(1),
1726 :issue_to => Issue.find(2),
1769 :issue_to => Issue.find(2),
1727 :relation_type => IssueRelation::TYPE_RELATES)
1770 :relation_type => IssueRelation::TYPE_RELATES)
1728 assert IssueRelation.create!(:issue_from => Issue.find(2),
1771 assert IssueRelation.create!(:issue_from => Issue.find(2),
1729 :issue_to => Issue.find(3),
1772 :issue_to => Issue.find(3),
1730 :relation_type => IssueRelation::TYPE_RELATES)
1773 :relation_type => IssueRelation::TYPE_RELATES)
1731 assert IssueRelation.create!(:issue_from => Issue.find(3),
1774 assert IssueRelation.create!(:issue_from => Issue.find(3),
1732 :issue_to => Issue.find(8),
1775 :issue_to => Issue.find(8),
1733 :relation_type => IssueRelation::TYPE_RELATES)
1776 :relation_type => IssueRelation::TYPE_RELATES)
1734
1777
1735 r = IssueRelation.create!(:issue_from => Issue.find(8),
1778 r = IssueRelation.create!(:issue_from => Issue.find(8),
1736 :issue_to => Issue.find(7),
1779 :issue_to => Issue.find(7),
1737 :relation_type => IssueRelation::TYPE_RELATES)
1780 :relation_type => IssueRelation::TYPE_RELATES)
1738 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1781 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1739
1782
1740 r = IssueRelation.create!(:issue_from => Issue.find(3),
1783 r = IssueRelation.create!(:issue_from => Issue.find(3),
1741 :issue_to => Issue.find(7),
1784 :issue_to => Issue.find(7),
1742 :relation_type => IssueRelation::TYPE_RELATES)
1785 :relation_type => IssueRelation::TYPE_RELATES)
1743 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1786 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1744
1787
1745 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1788 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1746 end
1789 end
1747
1790
1748 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
1791 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
1749 @issue = Issue.find(1)
1792 @issue = Issue.find(1)
1750 @issue_status = IssueStatus.find(1)
1793 @issue_status = IssueStatus.find(1)
1751 @issue_status.update_attribute(:default_done_ratio, 50)
1794 @issue_status.update_attribute(:default_done_ratio, 50)
1752 @issue2 = Issue.find(2)
1795 @issue2 = Issue.find(2)
1753 @issue_status2 = IssueStatus.find(2)
1796 @issue_status2 = IssueStatus.find(2)
1754 @issue_status2.update_attribute(:default_done_ratio, 0)
1797 @issue_status2.update_attribute(:default_done_ratio, 0)
1755
1798
1756 with_settings :issue_done_ratio => 'issue_field' do
1799 with_settings :issue_done_ratio => 'issue_field' do
1757 assert_equal 0, @issue.done_ratio
1800 assert_equal 0, @issue.done_ratio
1758 assert_equal 30, @issue2.done_ratio
1801 assert_equal 30, @issue2.done_ratio
1759 end
1802 end
1760
1803
1761 with_settings :issue_done_ratio => 'issue_status' do
1804 with_settings :issue_done_ratio => 'issue_status' do
1762 assert_equal 50, @issue.done_ratio
1805 assert_equal 50, @issue.done_ratio
1763 assert_equal 0, @issue2.done_ratio
1806 assert_equal 0, @issue2.done_ratio
1764 end
1807 end
1765 end
1808 end
1766
1809
1767 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
1810 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
1768 @issue = Issue.find(1)
1811 @issue = Issue.find(1)
1769 @issue_status = IssueStatus.find(1)
1812 @issue_status = IssueStatus.find(1)
1770 @issue_status.update_attribute(:default_done_ratio, 50)
1813 @issue_status.update_attribute(:default_done_ratio, 50)
1771 @issue2 = Issue.find(2)
1814 @issue2 = Issue.find(2)
1772 @issue_status2 = IssueStatus.find(2)
1815 @issue_status2 = IssueStatus.find(2)
1773 @issue_status2.update_attribute(:default_done_ratio, 0)
1816 @issue_status2.update_attribute(:default_done_ratio, 0)
1774
1817
1775 with_settings :issue_done_ratio => 'issue_field' do
1818 with_settings :issue_done_ratio => 'issue_field' do
1776 @issue.update_done_ratio_from_issue_status
1819 @issue.update_done_ratio_from_issue_status
1777 @issue2.update_done_ratio_from_issue_status
1820 @issue2.update_done_ratio_from_issue_status
1778
1821
1779 assert_equal 0, @issue.read_attribute(:done_ratio)
1822 assert_equal 0, @issue.read_attribute(:done_ratio)
1780 assert_equal 30, @issue2.read_attribute(:done_ratio)
1823 assert_equal 30, @issue2.read_attribute(:done_ratio)
1781 end
1824 end
1782
1825
1783 with_settings :issue_done_ratio => 'issue_status' do
1826 with_settings :issue_done_ratio => 'issue_status' do
1784 @issue.update_done_ratio_from_issue_status
1827 @issue.update_done_ratio_from_issue_status
1785 @issue2.update_done_ratio_from_issue_status
1828 @issue2.update_done_ratio_from_issue_status
1786
1829
1787 assert_equal 50, @issue.read_attribute(:done_ratio)
1830 assert_equal 50, @issue.read_attribute(:done_ratio)
1788 assert_equal 0, @issue2.read_attribute(:done_ratio)
1831 assert_equal 0, @issue2.read_attribute(:done_ratio)
1789 end
1832 end
1790 end
1833 end
1791
1834
1792 test "#by_tracker" do
1835 test "#by_tracker" do
1793 User.current = User.anonymous
1836 User.current = User.anonymous
1794 groups = Issue.by_tracker(Project.find(1))
1837 groups = Issue.by_tracker(Project.find(1))
1795 assert_equal 3, groups.size
1838 assert_equal 3, groups.size
1796 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1839 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1797 end
1840 end
1798
1841
1799 test "#by_version" do
1842 test "#by_version" do
1800 User.current = User.anonymous
1843 User.current = User.anonymous
1801 groups = Issue.by_version(Project.find(1))
1844 groups = Issue.by_version(Project.find(1))
1802 assert_equal 3, groups.size
1845 assert_equal 3, groups.size
1803 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1846 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1804 end
1847 end
1805
1848
1806 test "#by_priority" do
1849 test "#by_priority" do
1807 User.current = User.anonymous
1850 User.current = User.anonymous
1808 groups = Issue.by_priority(Project.find(1))
1851 groups = Issue.by_priority(Project.find(1))
1809 assert_equal 4, groups.size
1852 assert_equal 4, groups.size
1810 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1853 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1811 end
1854 end
1812
1855
1813 test "#by_category" do
1856 test "#by_category" do
1814 User.current = User.anonymous
1857 User.current = User.anonymous
1815 groups = Issue.by_category(Project.find(1))
1858 groups = Issue.by_category(Project.find(1))
1816 assert_equal 2, groups.size
1859 assert_equal 2, groups.size
1817 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1860 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1818 end
1861 end
1819
1862
1820 test "#by_assigned_to" do
1863 test "#by_assigned_to" do
1821 User.current = User.anonymous
1864 User.current = User.anonymous
1822 groups = Issue.by_assigned_to(Project.find(1))
1865 groups = Issue.by_assigned_to(Project.find(1))
1823 assert_equal 2, groups.size
1866 assert_equal 2, groups.size
1824 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1867 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1825 end
1868 end
1826
1869
1827 test "#by_author" do
1870 test "#by_author" do
1828 User.current = User.anonymous
1871 User.current = User.anonymous
1829 groups = Issue.by_author(Project.find(1))
1872 groups = Issue.by_author(Project.find(1))
1830 assert_equal 4, groups.size
1873 assert_equal 4, groups.size
1831 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1874 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1832 end
1875 end
1833
1876
1834 test "#by_subproject" do
1877 test "#by_subproject" do
1835 User.current = User.anonymous
1878 User.current = User.anonymous
1836 groups = Issue.by_subproject(Project.find(1))
1879 groups = Issue.by_subproject(Project.find(1))
1837 # Private descendant not visible
1880 # Private descendant not visible
1838 assert_equal 1, groups.size
1881 assert_equal 1, groups.size
1839 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1882 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1840 end
1883 end
1841
1884
1842 def test_recently_updated_scope
1885 def test_recently_updated_scope
1843 #should return the last updated issue
1886 #should return the last updated issue
1844 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1887 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1845 end
1888 end
1846
1889
1847 def test_on_active_projects_scope
1890 def test_on_active_projects_scope
1848 assert Project.find(2).archive
1891 assert Project.find(2).archive
1849
1892
1850 before = Issue.on_active_project.length
1893 before = Issue.on_active_project.length
1851 # test inclusion to results
1894 # test inclusion to results
1852 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1895 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1853 assert_equal before + 1, Issue.on_active_project.length
1896 assert_equal before + 1, Issue.on_active_project.length
1854
1897
1855 # Move to an archived project
1898 # Move to an archived project
1856 issue.project = Project.find(2)
1899 issue.project = Project.find(2)
1857 assert issue.save
1900 assert issue.save
1858 assert_equal before, Issue.on_active_project.length
1901 assert_equal before, Issue.on_active_project.length
1859 end
1902 end
1860
1903
1861 test "Issue#recipients should include project recipients" do
1904 test "Issue#recipients should include project recipients" do
1862 issue = Issue.generate!
1905 issue = Issue.generate!
1863 assert issue.project.recipients.present?
1906 assert issue.project.recipients.present?
1864 issue.project.recipients.each do |project_recipient|
1907 issue.project.recipients.each do |project_recipient|
1865 assert issue.recipients.include?(project_recipient)
1908 assert issue.recipients.include?(project_recipient)
1866 end
1909 end
1867 end
1910 end
1868
1911
1869 test "Issue#recipients should include the author if the author is active" do
1912 test "Issue#recipients should include the author if the author is active" do
1870 issue = Issue.generate!(:author => User.generate!)
1913 issue = Issue.generate!(:author => User.generate!)
1871 assert issue.author, "No author set for Issue"
1914 assert issue.author, "No author set for Issue"
1872 assert issue.recipients.include?(issue.author.mail)
1915 assert issue.recipients.include?(issue.author.mail)
1873 end
1916 end
1874
1917
1875 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
1918 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
1876 issue = Issue.generate!(:assigned_to => User.generate!)
1919 issue = Issue.generate!(:assigned_to => User.generate!)
1877 assert issue.assigned_to, "No assigned_to set for Issue"
1920 assert issue.assigned_to, "No assigned_to set for Issue"
1878 assert issue.recipients.include?(issue.assigned_to.mail)
1921 assert issue.recipients.include?(issue.assigned_to.mail)
1879 end
1922 end
1880
1923
1881 test "Issue#recipients should not include users who opt out of all email" do
1924 test "Issue#recipients should not include users who opt out of all email" do
1882 issue = Issue.generate!(:author => User.generate!)
1925 issue = Issue.generate!(:author => User.generate!)
1883 issue.author.update_attribute(:mail_notification, :none)
1926 issue.author.update_attribute(:mail_notification, :none)
1884 assert !issue.recipients.include?(issue.author.mail)
1927 assert !issue.recipients.include?(issue.author.mail)
1885 end
1928 end
1886
1929
1887 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
1930 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
1888 issue = Issue.generate!(:author => User.generate!)
1931 issue = Issue.generate!(:author => User.generate!)
1889 issue.author.update_attribute(:mail_notification, :only_assigned)
1932 issue.author.update_attribute(:mail_notification, :only_assigned)
1890 assert !issue.recipients.include?(issue.author.mail)
1933 assert !issue.recipients.include?(issue.author.mail)
1891 end
1934 end
1892
1935
1893 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
1936 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
1894 issue = Issue.generate!(:assigned_to => User.generate!)
1937 issue = Issue.generate!(:assigned_to => User.generate!)
1895 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
1938 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
1896 assert !issue.recipients.include?(issue.assigned_to.mail)
1939 assert !issue.recipients.include?(issue.assigned_to.mail)
1897 end
1940 end
1898
1941
1899 def test_last_journal_id_with_journals_should_return_the_journal_id
1942 def test_last_journal_id_with_journals_should_return_the_journal_id
1900 assert_equal 2, Issue.find(1).last_journal_id
1943 assert_equal 2, Issue.find(1).last_journal_id
1901 end
1944 end
1902
1945
1903 def test_last_journal_id_without_journals_should_return_nil
1946 def test_last_journal_id_without_journals_should_return_nil
1904 assert_nil Issue.find(3).last_journal_id
1947 assert_nil Issue.find(3).last_journal_id
1905 end
1948 end
1906
1949
1907 def test_journals_after_should_return_journals_with_greater_id
1950 def test_journals_after_should_return_journals_with_greater_id
1908 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1951 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1909 assert_equal [], Issue.find(1).journals_after('2')
1952 assert_equal [], Issue.find(1).journals_after('2')
1910 end
1953 end
1911
1954
1912 def test_journals_after_with_blank_arg_should_return_all_journals
1955 def test_journals_after_with_blank_arg_should_return_all_journals
1913 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1956 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1914 end
1957 end
1915
1958
1916 def test_css_classes_should_include_tracker
1959 def test_css_classes_should_include_tracker
1917 issue = Issue.new(:tracker => Tracker.find(2))
1960 issue = Issue.new(:tracker => Tracker.find(2))
1918 classes = issue.css_classes.split(' ')
1961 classes = issue.css_classes.split(' ')
1919 assert_include 'tracker-2', classes
1962 assert_include 'tracker-2', classes
1920 end
1963 end
1921
1964
1922 def test_css_classes_should_include_priority
1965 def test_css_classes_should_include_priority
1923 issue = Issue.new(:priority => IssuePriority.find(8))
1966 issue = Issue.new(:priority => IssuePriority.find(8))
1924 classes = issue.css_classes.split(' ')
1967 classes = issue.css_classes.split(' ')
1925 assert_include 'priority-8', classes
1968 assert_include 'priority-8', classes
1926 assert_include 'priority-highest', classes
1969 assert_include 'priority-highest', classes
1927 end
1970 end
1928
1971
1929 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
1972 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
1930 set_tmp_attachments_directory
1973 set_tmp_attachments_directory
1931 issue = Issue.generate!
1974 issue = Issue.generate!
1932 issue.save_attachments({
1975 issue.save_attachments({
1933 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
1976 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
1934 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
1977 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
1935 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
1978 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
1936 })
1979 })
1937 issue.attach_saved_attachments
1980 issue.attach_saved_attachments
1938
1981
1939 assert_equal 3, issue.reload.attachments.count
1982 assert_equal 3, issue.reload.attachments.count
1940 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
1983 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
1941 end
1984 end
1942
1985
1943 def test_closed_on_should_be_nil_when_creating_an_open_issue
1986 def test_closed_on_should_be_nil_when_creating_an_open_issue
1944 issue = Issue.generate!(:status_id => 1).reload
1987 issue = Issue.generate!(:status_id => 1).reload
1945 assert !issue.closed?
1988 assert !issue.closed?
1946 assert_nil issue.closed_on
1989 assert_nil issue.closed_on
1947 end
1990 end
1948
1991
1949 def test_closed_on_should_be_set_when_creating_a_closed_issue
1992 def test_closed_on_should_be_set_when_creating_a_closed_issue
1950 issue = Issue.generate!(:status_id => 5).reload
1993 issue = Issue.generate!(:status_id => 5).reload
1951 assert issue.closed?
1994 assert issue.closed?
1952 assert_not_nil issue.closed_on
1995 assert_not_nil issue.closed_on
1953 assert_equal issue.updated_on, issue.closed_on
1996 assert_equal issue.updated_on, issue.closed_on
1954 assert_equal issue.created_on, issue.closed_on
1997 assert_equal issue.created_on, issue.closed_on
1955 end
1998 end
1956
1999
1957 def test_closed_on_should_be_nil_when_updating_an_open_issue
2000 def test_closed_on_should_be_nil_when_updating_an_open_issue
1958 issue = Issue.find(1)
2001 issue = Issue.find(1)
1959 issue.subject = 'Not closed yet'
2002 issue.subject = 'Not closed yet'
1960 issue.save!
2003 issue.save!
1961 issue.reload
2004 issue.reload
1962 assert_nil issue.closed_on
2005 assert_nil issue.closed_on
1963 end
2006 end
1964
2007
1965 def test_closed_on_should_be_set_when_closing_an_open_issue
2008 def test_closed_on_should_be_set_when_closing_an_open_issue
1966 issue = Issue.find(1)
2009 issue = Issue.find(1)
1967 issue.subject = 'Now closed'
2010 issue.subject = 'Now closed'
1968 issue.status_id = 5
2011 issue.status_id = 5
1969 issue.save!
2012 issue.save!
1970 issue.reload
2013 issue.reload
1971 assert_not_nil issue.closed_on
2014 assert_not_nil issue.closed_on
1972 assert_equal issue.updated_on, issue.closed_on
2015 assert_equal issue.updated_on, issue.closed_on
1973 end
2016 end
1974
2017
1975 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2018 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
1976 issue = Issue.open(false).first
2019 issue = Issue.open(false).first
1977 was_closed_on = issue.closed_on
2020 was_closed_on = issue.closed_on
1978 assert_not_nil was_closed_on
2021 assert_not_nil was_closed_on
1979 issue.subject = 'Updating a closed issue'
2022 issue.subject = 'Updating a closed issue'
1980 issue.save!
2023 issue.save!
1981 issue.reload
2024 issue.reload
1982 assert_equal was_closed_on, issue.closed_on
2025 assert_equal was_closed_on, issue.closed_on
1983 end
2026 end
1984
2027
1985 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2028 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
1986 issue = Issue.open(false).first
2029 issue = Issue.open(false).first
1987 was_closed_on = issue.closed_on
2030 was_closed_on = issue.closed_on
1988 assert_not_nil was_closed_on
2031 assert_not_nil was_closed_on
1989 issue.subject = 'Reopening a closed issue'
2032 issue.subject = 'Reopening a closed issue'
1990 issue.status_id = 1
2033 issue.status_id = 1
1991 issue.save!
2034 issue.save!
1992 issue.reload
2035 issue.reload
1993 assert !issue.closed?
2036 assert !issue.closed?
1994 assert_equal was_closed_on, issue.closed_on
2037 assert_equal was_closed_on, issue.closed_on
1995 end
2038 end
1996
2039
1997 def test_status_was_should_return_nil_for_new_issue
2040 def test_status_was_should_return_nil_for_new_issue
1998 issue = Issue.new
2041 issue = Issue.new
1999 assert_nil issue.status_was
2042 assert_nil issue.status_was
2000 end
2043 end
2001
2044
2002 def test_status_was_should_return_status_before_change
2045 def test_status_was_should_return_status_before_change
2003 issue = Issue.find(1)
2046 issue = Issue.find(1)
2004 issue.status = IssueStatus.find(2)
2047 issue.status = IssueStatus.find(2)
2005 assert_equal IssueStatus.find(1), issue.status_was
2048 assert_equal IssueStatus.find(1), issue.status_was
2006 end
2049 end
2007
2050
2008 def test_status_was_should_be_reset_on_save
2051 def test_status_was_should_be_reset_on_save
2009 issue = Issue.find(1)
2052 issue = Issue.find(1)
2010 issue.status = IssueStatus.find(2)
2053 issue.status = IssueStatus.find(2)
2011 assert_equal IssueStatus.find(1), issue.status_was
2054 assert_equal IssueStatus.find(1), issue.status_was
2012 assert issue.save!
2055 assert issue.save!
2013 assert_equal IssueStatus.find(2), issue.status_was
2056 assert_equal IssueStatus.find(2), issue.status_was
2014 end
2057 end
2015 end
2058 end
General Comments 0
You need to be logged in to leave comments. Login now