jro_apps/redmine Commit - r3164:cab99aa5adf9

Allow bulk edit custom fields of any type (#461)....

Jean-Philippe Lang -

r3164:cab99aa5adf9

parent child

Context file:

r3164:cab99aa5adf9

app/controllers/issues_controller.rb +1 -1

                   return
                 end
                 @available_statuses = Workflow.available_statuses(@project)
-                @custom_fields = @project.all_issue_custom_fields.select {|f| f.field_format == 'list'}
+                @custom_fields = @project.all_issue_custom_fields
               end
               def move

app/helpers/custom_fields_helper.rb +20 0

@@ -66,6 +66,26 module CustomFieldsHelper
66	def custom_field_tag_with_label(name, custom_value)	66	def custom_field_tag_with_label(name, custom_value)
67	custom_field_label_tag(name, custom_value) + custom_field_tag(name, custom_value)	67	custom_field_label_tag(name, custom_value) + custom_field_tag(name, custom_value)
68	end	68	end
		69
		70	def custom_field_tag_for_bulk_edit(custom_field)
		71	field_name = "custom_field_values[#{custom_field.id}]"
		72	field_id = "custom_field_values_#{custom_field.id}"
		73	case custom_field.field_format
		74	when "date"
		75	text_field_tag(field_name, '', :id => field_id, :size => 10) +
		76	calendar_for(field_id)
		77	when "text"
		78	text_area_tag(field_name, '', :id => field_id, :rows => 3, :style => 'width:90%')
		79	when "bool"
		80	select_tag(field_name, options_for_select([[l(:label_no_change_option), ''],
		81	[l(:general_text_yes), '1'],
		82	[l(:general_text_no), '0']]), :id => field_id)
		83	when "list"
		84	select_tag(field_name, options_for_select([[l(:label_no_change_option), '']] + custom_field.possible_values), :id => field_id)
		85	else
		86	text_field_tag(field_name, '', :id => field_id)
		87	end
		88	end
69		89
70	# Return a string used to display a custom value	90	# Return a string used to display a custom value
71	def show_value(custom_value)	91	def show_value(custom_value)

app/views/issues/bulk_edit.rhtml +1 -3

             </p>
             <% @custom_fields.each do |custom_field| %>
-            <p><label><%= h(custom_field.name) %>
+            <p><label><%= h(custom_field.name) %> <%= custom_field_tag_for_bulk_edit(custom_field) %></label></p>
-            <%= select_tag "custom_field_values[#{custom_field.id}]", options_for_select([[l(:label_no_change_option), '']] + custom_field.possible_values) %></label>
-            </p>
             <% end %>
             <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>

test/fixtures/custom_fields.yml +14 0

test/fixtures/custom_fields_projects.yml +4 -2

test/functional/issues_controller_test.rb +8 0

                 get :bulk_edit, :ids => [1, 2]
                 assert_response :success
                 assert_template 'bulk_edit'
+                # Project specific custom field, date type
+                field = CustomField.find(9)
+                assert !field.is_for_all?
+                assert_equal 'date', field.field_format
+                assert_tag :input, :attributes => {:name => 'custom_field_values[9]'}
                 # System wide custom field
+                assert CustomField.find(1).is_for_all?
                 assert_tag :select, :attributes => {:name => 'custom_field_values[1]'}
               end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages