##// END OF EJS Templates
jro_apps » redmine
RSS
Merged r11692 from trunk (#13586)....
Jean-Philippe Lang -
r11467:ca39b054208c
parent child
Show More
Side by Side Unified
Context file:
r11467:ca39b054208c Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1436 +1,1440
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21
22 22 belongs_to :project
23 23 belongs_to :tracker
24 24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30 30
31 31 has_many :journals, :as => :journalized, :dependent => :destroy
32 32 has_many :visible_journals,
33 33 :class_name => 'Journal',
34 34 :as => :journalized,
35 35 :conditions => Proc.new {
36 36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 37 },
38 38 :readonly => true
39 39
40 40 has_many :time_entries, :dependent => :delete_all
41 41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 48 acts_as_customizable
49 49 acts_as_watchable
50 50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 51 :include => [:project, :visible_journals],
52 52 # sort by id so that limited eager loading doesn't break with postgresql
53 53 :order_column => "#{table_name}.id"
54 54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57 57
58 58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 59 :author_key => :author_id
60 60
61 61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62 62
63 63 attr_reader :current_journal
64 64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65 65
66 66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67 67
68 68 validates_length_of :subject, :maximum => 255
69 69 validates_inclusion_of :done_ratio, :in => 0..100
70 70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 71 validates :start_date, :date => true
72 72 validates :due_date, :date => true
73 73 validate :validate_issue, :validate_required_fields
74 74
75 75 scope :visible, lambda {|*args|
76 76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 77 }
78 78
79 79 scope :open, lambda {|*args|
80 80 is_closed = args.size > 0 ? !args.first : false
81 81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 82 }
83 83
84 84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 85 scope :on_active_project, lambda {
86 86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 87 }
88 88 scope :fixed_version, lambda {|versions|
89 89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 91 }
92 92
93 93 before_create :default_assign
94 94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 97 # Should be after_create but would be called before previous after_save callbacks
98 98 after_save :after_create_from_copy
99 99 after_destroy :update_parent_attributes
100 100
101 101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 102 def self.visible_condition(user, options={})
103 103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 104 if user.logged?
105 105 case role.issues_visibility
106 106 when 'all'
107 107 nil
108 108 when 'default'
109 109 user_ids = [user.id] + user.groups.map(&:id)
110 110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 111 when 'own'
112 112 user_ids = [user.id] + user.groups.map(&:id)
113 113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 114 else
115 115 '1=0'
116 116 end
117 117 else
118 118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 119 end
120 120 end
121 121 end
122 122
123 123 # Returns true if usr or current user is allowed to view the issue
124 124 def visible?(usr=nil)
125 125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 126 if user.logged?
127 127 case role.issues_visibility
128 128 when 'all'
129 129 true
130 130 when 'default'
131 131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 132 when 'own'
133 133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 134 else
135 135 false
136 136 end
137 137 else
138 138 !self.is_private?
139 139 end
140 140 end
141 141 end
142 142
143 143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 144 def editable?(user=User.current)
145 145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 146 end
147 147
148 148 def initialize(attributes=nil, *args)
149 149 super
150 150 if new_record?
151 151 # set default values for new records only
152 152 self.status ||= IssueStatus.default
153 153 self.priority ||= IssuePriority.default
154 154 self.watcher_user_ids = []
155 155 end
156 156 end
157 157
158 158 def create_or_update
159 159 super
160 160 ensure
161 161 @status_was = nil
162 162 end
163 163 private :create_or_update
164 164
165 165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 166 # if the issue was already deleted or updated (non matching lock_version).
167 167 # This is a problem when bulk deleting issues or deleting a project
168 168 # (because an issue may already be deleted if its parent was deleted
169 169 # first).
170 170 # The issue is reloaded by the nested_set before being deleted so
171 171 # the lock_version condition should not be an issue but we handle it.
172 172 def destroy
173 173 super
174 174 rescue ActiveRecord::RecordNotFound
175 175 # Stale or already deleted
176 176 begin
177 177 reload
178 178 rescue ActiveRecord::RecordNotFound
179 179 # The issue was actually already deleted
180 180 @destroyed = true
181 181 return freeze
182 182 end
183 183 # The issue was stale, retry to destroy
184 184 super
185 185 end
186 186
187 187 alias :base_reload :reload
188 188 def reload(*args)
189 189 @workflow_rule_by_attribute = nil
190 190 @assignable_versions = nil
191 191 @relations = nil
192 192 base_reload(*args)
193 193 end
194 194
195 195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
196 196 def available_custom_fields
197 197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
198 198 end
199 199
200 200 # Copies attributes from another issue, arg can be an id or an Issue
201 201 def copy_from(arg, options={})
202 202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
203 203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
204 204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
205 205 self.status = issue.status
206 206 self.author = User.current
207 207 unless options[:attachments] == false
208 208 self.attachments = issue.attachments.map do |attachement|
209 209 attachement.copy(:container => self)
210 210 end
211 211 end
212 212 @copied_from = issue
213 213 @copy_options = options
214 214 self
215 215 end
216 216
217 217 # Returns an unsaved copy of the issue
218 218 def copy(attributes=nil, copy_options={})
219 219 copy = self.class.new.copy_from(self, copy_options)
220 220 copy.attributes = attributes if attributes
221 221 copy
222 222 end
223 223
224 224 # Returns true if the issue is a copy
225 225 def copy?
226 226 @copied_from.present?
227 227 end
228 228
229 229 # Moves/copies an issue to a new project and tracker
230 230 # Returns the moved/copied issue on success, false on failure
231 231 def move_to_project(new_project, new_tracker=nil, options={})
232 232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
233 233
234 234 if options[:copy]
235 235 issue = self.copy
236 236 else
237 237 issue = self
238 238 end
239 239
240 240 issue.init_journal(User.current, options[:notes])
241 241
242 242 # Preserve previous behaviour
243 243 # #move_to_project doesn't change tracker automatically
244 244 issue.send :project=, new_project, true
245 245 if new_tracker
246 246 issue.tracker = new_tracker
247 247 end
248 248 # Allow bulk setting of attributes on the issue
249 249 if options[:attributes]
250 250 issue.attributes = options[:attributes]
251 251 end
252 252
253 253 issue.save ? issue : false
254 254 end
255 255
256 256 def status_id=(sid)
257 257 self.status = nil
258 258 result = write_attribute(:status_id, sid)
259 259 @workflow_rule_by_attribute = nil
260 260 result
261 261 end
262 262
263 263 def priority_id=(pid)
264 264 self.priority = nil
265 265 write_attribute(:priority_id, pid)
266 266 end
267 267
268 268 def category_id=(cid)
269 269 self.category = nil
270 270 write_attribute(:category_id, cid)
271 271 end
272 272
273 273 def fixed_version_id=(vid)
274 274 self.fixed_version = nil
275 275 write_attribute(:fixed_version_id, vid)
276 276 end
277 277
278 278 def tracker_id=(tid)
279 279 self.tracker = nil
280 280 result = write_attribute(:tracker_id, tid)
281 281 @custom_field_values = nil
282 282 @workflow_rule_by_attribute = nil
283 283 result
284 284 end
285 285
286 286 def project_id=(project_id)
287 287 if project_id.to_s != self.project_id.to_s
288 288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
289 289 end
290 290 end
291 291
292 292 def project=(project, keep_tracker=false)
293 293 project_was = self.project
294 294 write_attribute(:project_id, project ? project.id : nil)
295 295 association_instance_set('project', project)
296 296 if project_was && project && project_was != project
297 297 @assignable_versions = nil
298 298
299 299 unless keep_tracker || project.trackers.include?(tracker)
300 300 self.tracker = project.trackers.first
301 301 end
302 302 # Reassign to the category with same name if any
303 303 if category
304 304 self.category = project.issue_categories.find_by_name(category.name)
305 305 end
306 306 # Keep the fixed_version if it's still valid in the new_project
307 307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
308 308 self.fixed_version = nil
309 309 end
310 310 # Clear the parent task if it's no longer valid
311 311 unless valid_parent_project?
312 312 self.parent_issue_id = nil
313 313 end
314 314 @custom_field_values = nil
315 315 end
316 316 end
317 317
318 318 def description=(arg)
319 319 if arg.is_a?(String)
320 320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
321 321 end
322 322 write_attribute(:description, arg)
323 323 end
324 324
325 325 # Overrides assign_attributes so that project and tracker get assigned first
326 326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
327 327 return if new_attributes.nil?
328 328 attrs = new_attributes.dup
329 329 attrs.stringify_keys!
330 330
331 331 %w(project project_id tracker tracker_id).each do |attr|
332 332 if attrs.has_key?(attr)
333 333 send "#{attr}=", attrs.delete(attr)
334 334 end
335 335 end
336 336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
337 337 end
338 338 # Do not redefine alias chain on reload (see #4838)
339 339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
340 340
341 341 def estimated_hours=(h)
342 342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
343 343 end
344 344
345 345 safe_attributes 'project_id',
346 346 :if => lambda {|issue, user|
347 347 if issue.new_record?
348 348 issue.copy?
349 349 elsif user.allowed_to?(:move_issues, issue.project)
350 350 projects = Issue.allowed_target_projects_on_move(user)
351 351 projects.include?(issue.project) && projects.size > 1
352 352 end
353 353 }
354 354
355 355 safe_attributes 'tracker_id',
356 356 'status_id',
357 357 'category_id',
358 358 'assigned_to_id',
359 359 'priority_id',
360 360 'fixed_version_id',
361 361 'subject',
362 362 'description',
363 363 'start_date',
364 364 'due_date',
365 365 'done_ratio',
366 366 'estimated_hours',
367 367 'custom_field_values',
368 368 'custom_fields',
369 369 'lock_version',
370 370 'notes',
371 371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
372 372
373 373 safe_attributes 'status_id',
374 374 'assigned_to_id',
375 375 'fixed_version_id',
376 376 'done_ratio',
377 377 'lock_version',
378 378 'notes',
379 379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
380 380
381 381 safe_attributes 'notes',
382 382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
383 383
384 384 safe_attributes 'private_notes',
385 385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
386 386
387 387 safe_attributes 'watcher_user_ids',
388 388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
389 389
390 390 safe_attributes 'is_private',
391 391 :if => lambda {|issue, user|
392 392 user.allowed_to?(:set_issues_private, issue.project) ||
393 393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
394 394 }
395 395
396 396 safe_attributes 'parent_issue_id',
397 397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
398 398 user.allowed_to?(:manage_subtasks, issue.project)}
399 399
400 400 def safe_attribute_names(user=nil)
401 401 names = super
402 402 names -= disabled_core_fields
403 403 names -= read_only_attribute_names(user)
404 404 names
405 405 end
406 406
407 407 # Safely sets attributes
408 408 # Should be called from controllers instead of #attributes=
409 409 # attr_accessible is too rough because we still want things like
410 410 # Issue.new(:project => foo) to work
411 411 def safe_attributes=(attrs, user=User.current)
412 412 return unless attrs.is_a?(Hash)
413 413
414 414 attrs = attrs.dup
415 415
416 416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
417 417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
418 418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
419 419 self.project_id = p
420 420 end
421 421 end
422 422
423 423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
424 424 self.tracker_id = t
425 425 end
426 426
427 427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
428 428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
429 429 self.status_id = s
430 430 end
431 431 end
432 432
433 433 attrs = delete_unsafe_attributes(attrs, user)
434 434 return if attrs.empty?
435 435
436 436 unless leaf?
437 437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
438 438 end
439 439
440 440 if attrs['parent_issue_id'].present?
441 441 s = attrs['parent_issue_id'].to_s
442 442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
443 443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
444 444 end
445 445 end
446 446
447 447 if attrs['custom_field_values'].present?
448 448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
449 449 end
450 450
451 451 if attrs['custom_fields'].present?
452 452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
453 453 end
454 454
455 455 # mass-assignment security bypass
456 456 assign_attributes attrs, :without_protection => true
457 457 end
458 458
459 459 def disabled_core_fields
460 460 tracker ? tracker.disabled_core_fields : []
461 461 end
462 462
463 463 # Returns the custom_field_values that can be edited by the given user
464 464 def editable_custom_field_values(user=nil)
465 465 custom_field_values.reject do |value|
466 466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
467 467 end
468 468 end
469 469
470 470 # Returns the names of attributes that are read-only for user or the current user
471 471 # For users with multiple roles, the read-only fields are the intersection of
472 472 # read-only fields of each role
473 473 # The result is an array of strings where sustom fields are represented with their ids
474 474 #
475 475 # Examples:
476 476 # issue.read_only_attribute_names # => ['due_date', '2']
477 477 # issue.read_only_attribute_names(user) # => []
478 478 def read_only_attribute_names(user=nil)
479 479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
480 480 end
481 481
482 482 # Returns the names of required attributes for user or the current user
483 483 # For users with multiple roles, the required fields are the intersection of
484 484 # required fields of each role
485 485 # The result is an array of strings where sustom fields are represented with their ids
486 486 #
487 487 # Examples:
488 488 # issue.required_attribute_names # => ['due_date', '2']
489 489 # issue.required_attribute_names(user) # => []
490 490 def required_attribute_names(user=nil)
491 491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
492 492 end
493 493
494 494 # Returns true if the attribute is required for user
495 495 def required_attribute?(name, user=nil)
496 496 required_attribute_names(user).include?(name.to_s)
497 497 end
498 498
499 499 # Returns a hash of the workflow rule by attribute for the given user
500 500 #
501 501 # Examples:
502 502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
503 503 def workflow_rule_by_attribute(user=nil)
504 504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
505 505
506 506 user_real = user || User.current
507 507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
508 508 return {} if roles.empty?
509 509
510 510 result = {}
511 511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
512 512 if workflow_permissions.any?
513 513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
514 514 h[wp.field_name] ||= []
515 515 h[wp.field_name] << wp.rule
516 516 h
517 517 end
518 518 workflow_rules.each do |attr, rules|
519 519 next if rules.size < roles.size
520 520 uniq_rules = rules.uniq
521 521 if uniq_rules.size == 1
522 522 result[attr] = uniq_rules.first
523 523 else
524 524 result[attr] = 'required'
525 525 end
526 526 end
527 527 end
528 528 @workflow_rule_by_attribute = result if user.nil?
529 529 result
530 530 end
531 531 private :workflow_rule_by_attribute
532 532
533 533 def done_ratio
534 534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
535 535 status.default_done_ratio
536 536 else
537 537 read_attribute(:done_ratio)
538 538 end
539 539 end
540 540
541 541 def self.use_status_for_done_ratio?
542 542 Setting.issue_done_ratio == 'issue_status'
543 543 end
544 544
545 545 def self.use_field_for_done_ratio?
546 546 Setting.issue_done_ratio == 'issue_field'
547 547 end
548 548
549 549 def validate_issue
550 550 if due_date && start_date && due_date < start_date
551 551 errors.add :due_date, :greater_than_start_date
552 552 end
553 553
554 554 if start_date && soonest_start && start_date < soonest_start
555 555 errors.add :start_date, :invalid
556 556 end
557 557
558 558 if fixed_version
559 559 if !assignable_versions.include?(fixed_version)
560 560 errors.add :fixed_version_id, :inclusion
561 561 elsif reopened? && fixed_version.closed?
562 562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
563 563 end
564 564 end
565 565
566 566 # Checks that the issue can not be added/moved to a disabled tracker
567 567 if project && (tracker_id_changed? || project_id_changed?)
568 568 unless project.trackers.include?(tracker)
569 569 errors.add :tracker_id, :inclusion
570 570 end
571 571 end
572 572
573 573 # Checks parent issue assignment
574 574 if @invalid_parent_issue_id.present?
575 575 errors.add :parent_issue_id, :invalid
576 576 elsif @parent_issue
577 577 if !valid_parent_project?(@parent_issue)
578 578 errors.add :parent_issue_id, :invalid
579 579 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
580 580 errors.add :parent_issue_id, :invalid
581 581 elsif !new_record?
582 582 # moving an existing issue
583 583 if @parent_issue.root_id != root_id
584 584 # we can always move to another tree
585 585 elsif move_possible?(@parent_issue)
586 586 # move accepted inside tree
587 587 else
588 588 errors.add :parent_issue_id, :invalid
589 589 end
590 590 end
591 591 end
592 592 end
593 593
594 594 # Validates the issue against additional workflow requirements
595 595 def validate_required_fields
596 596 user = new_record? ? author : current_journal.try(:user)
597 597
598 598 required_attribute_names(user).each do |attribute|
599 599 if attribute =~ /^\d+$/
600 600 attribute = attribute.to_i
601 601 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
602 602 if v && v.value.blank?
603 603 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
604 604 end
605 605 else
606 606 if respond_to?(attribute) && send(attribute).blank?
607 607 errors.add attribute, :blank
608 608 end
609 609 end
610 610 end
611 611 end
612 612
613 613 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
614 614 # even if the user turns off the setting later
615 615 def update_done_ratio_from_issue_status
616 616 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
617 617 self.done_ratio = status.default_done_ratio
618 618 end
619 619 end
620 620
621 621 def init_journal(user, notes = "")
622 622 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
623 623 if new_record?
624 624 @current_journal.notify = false
625 625 else
626 626 @attributes_before_change = attributes.dup
627 627 @custom_values_before_change = {}
628 628 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
629 629 end
630 630 @current_journal
631 631 end
632 632
633 633 # Returns the id of the last journal or nil
634 634 def last_journal_id
635 635 if new_record?
636 636 nil
637 637 else
638 638 journals.maximum(:id)
639 639 end
640 640 end
641 641
642 642 # Returns a scope for journals that have an id greater than journal_id
643 643 def journals_after(journal_id)
644 644 scope = journals.reorder("#{Journal.table_name}.id ASC")
645 645 if journal_id.present?
646 646 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
647 647 end
648 648 scope
649 649 end
650 650
651 651 # Returns the initial status of the issue
652 652 # Returns nil for a new issue
653 653 def status_was
654 654 if status_id_was && status_id_was.to_i > 0
655 655 @status_was ||= IssueStatus.find_by_id(status_id_was)
656 656 end
657 657 end
658 658
659 659 # Return true if the issue is closed, otherwise false
660 660 def closed?
661 661 self.status.is_closed?
662 662 end
663 663
664 664 # Return true if the issue is being reopened
665 665 def reopened?
666 666 if !new_record? && status_id_changed?
667 667 status_was = IssueStatus.find_by_id(status_id_was)
668 668 status_new = IssueStatus.find_by_id(status_id)
669 669 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
670 670 return true
671 671 end
672 672 end
673 673 false
674 674 end
675 675
676 676 # Return true if the issue is being closed
677 677 def closing?
678 678 if !new_record? && status_id_changed?
679 679 if status_was && status && !status_was.is_closed? && status.is_closed?
680 680 return true
681 681 end
682 682 end
683 683 false
684 684 end
685 685
686 686 # Returns true if the issue is overdue
687 687 def overdue?
688 688 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
689 689 end
690 690
691 691 # Is the amount of work done less than it should for the due date
692 692 def behind_schedule?
693 693 return false if start_date.nil? || due_date.nil?
694 694 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
695 695 return done_date <= Date.today
696 696 end
697 697
698 698 # Does this issue have children?
699 699 def children?
700 700 !leaf?
701 701 end
702 702
703 703 # Users the issue can be assigned to
704 704 def assignable_users
705 705 users = project.assignable_users
706 706 users << author if author
707 707 users << assigned_to if assigned_to
708 708 users.uniq.sort
709 709 end
710 710
711 711 # Versions that the issue can be assigned to
712 712 def assignable_versions
713 713 return @assignable_versions if @assignable_versions
714 714
715 715 versions = project.shared_versions.open.all
716 716 if fixed_version
717 717 if fixed_version_id_changed?
718 718 # nothing to do
719 719 elsif project_id_changed?
720 720 if project.shared_versions.include?(fixed_version)
721 721 versions << fixed_version
722 722 end
723 723 else
724 724 versions << fixed_version
725 725 end
726 726 end
727 727 @assignable_versions = versions.uniq.sort
728 728 end
729 729
730 730 # Returns true if this issue is blocked by another issue that is still open
731 731 def blocked?
732 732 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
733 733 end
734 734
735 735 # Returns an array of statuses that user is able to apply
736 736 def new_statuses_allowed_to(user=User.current, include_default=false)
737 737 if new_record? && @copied_from
738 738 [IssueStatus.default, @copied_from.status].compact.uniq.sort
739 739 else
740 740 initial_status = nil
741 741 if new_record?
742 742 initial_status = IssueStatus.default
743 743 elsif status_id_was
744 744 initial_status = IssueStatus.find_by_id(status_id_was)
745 745 end
746 746 initial_status ||= status
747 747
748 748 statuses = initial_status.find_new_statuses_allowed_to(
749 749 user.admin ? Role.all : user.roles_for_project(project),
750 750 tracker,
751 751 author == user,
752 752 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
753 753 )
754 754 statuses << initial_status unless statuses.empty?
755 755 statuses << IssueStatus.default if include_default
756 756 statuses = statuses.compact.uniq.sort
757 757 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
758 758 end
759 759 end
760 760
761 761 def assigned_to_was
762 762 if assigned_to_id_changed? && assigned_to_id_was.present?
763 763 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
764 764 end
765 765 end
766 766
767 767 # Returns the users that should be notified
768 768 def notified_users
769 769 notified = []
770 770 # Author and assignee are always notified unless they have been
771 771 # locked or don't want to be notified
772 772 notified << author if author
773 773 if assigned_to
774 774 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
775 775 end
776 776 if assigned_to_was
777 777 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
778 778 end
779 779 notified = notified.select {|u| u.active? && u.notify_about?(self)}
780 780
781 781 notified += project.notified_users
782 782 notified.uniq!
783 783 # Remove users that can not view the issue
784 784 notified.reject! {|user| !visible?(user)}
785 785 notified
786 786 end
787 787
788 788 # Returns the email addresses that should be notified
789 789 def recipients
790 790 notified_users.collect(&:mail)
791 791 end
792 792
793 793 # Returns the number of hours spent on this issue
794 794 def spent_hours
795 795 @spent_hours ||= time_entries.sum(:hours) || 0
796 796 end
797 797
798 798 # Returns the total number of hours spent on this issue and its descendants
799 799 #
800 800 # Example:
801 801 # spent_hours => 0.0
802 802 # spent_hours => 50.2
803 803 def total_spent_hours
804 804 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
805 805 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
806 806 end
807 807
808 808 def relations
809 809 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
810 810 end
811 811
812 812 # Preloads relations for a collection of issues
813 813 def self.load_relations(issues)
814 814 if issues.any?
815 815 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
816 816 issues.each do |issue|
817 817 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
818 818 end
819 819 end
820 820 end
821 821
822 822 # Preloads visible spent time for a collection of issues
823 823 def self.load_visible_spent_hours(issues, user=User.current)
824 824 if issues.any?
825 825 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
826 826 issues.each do |issue|
827 827 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
828 828 end
829 829 end
830 830 end
831 831
832 832 # Preloads visible relations for a collection of issues
833 833 def self.load_visible_relations(issues, user=User.current)
834 834 if issues.any?
835 835 issue_ids = issues.map(&:id)
836 836 # Relations with issue_from in given issues and visible issue_to
837 837 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
838 838 # Relations with issue_to in given issues and visible issue_from
839 839 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
840 840
841 841 issues.each do |issue|
842 842 relations =
843 843 relations_from.select {|relation| relation.issue_from_id == issue.id} +
844 844 relations_to.select {|relation| relation.issue_to_id == issue.id}
845 845
846 846 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
847 847 end
848 848 end
849 849 end
850 850
851 851 # Finds an issue relation given its id.
852 852 def find_relation(relation_id)
853 853 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
854 854 end
855 855
856 856 # Returns all the other issues that depend on the issue
857 857 def all_dependent_issues(except=[])
858 858 except << self
859 859 dependencies = []
860 860 dependencies += relations_from.map(&:issue_to)
861 861 dependencies += children unless leaf?
862 dependencies << parent
863 862 dependencies.compact!
864 863 dependencies -= except
865 dependencies + dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
864 dependencies += dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
865 if parent
866 dependencies << parent
867 dependencies += parent.all_dependent_issues(except + parent.descendants)
868 end
869 dependencies
866 870 end
867 871
868 872 # Returns an array of issues that duplicate this one
869 873 def duplicates
870 874 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
871 875 end
872 876
873 877 # Returns the due date or the target due date if any
874 878 # Used on gantt chart
875 879 def due_before
876 880 due_date || (fixed_version ? fixed_version.effective_date : nil)
877 881 end
878 882
879 883 # Returns the time scheduled for this issue.
880 884 #
881 885 # Example:
882 886 # Start Date: 2/26/09, End Date: 3/04/09
883 887 # duration => 6
884 888 def duration
885 889 (start_date && due_date) ? due_date - start_date : 0
886 890 end
887 891
888 892 # Returns the duration in working days
889 893 def working_duration
890 894 (start_date && due_date) ? working_days(start_date, due_date) : 0
891 895 end
892 896
893 897 def soonest_start(reload=false)
894 898 @soonest_start = nil if reload
895 899 @soonest_start ||= (
896 900 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
897 901 [(@parent_issue || parent).try(:soonest_start)]
898 902 ).compact.max
899 903 end
900 904
901 905 # Sets start_date on the given date or the next working day
902 906 # and changes due_date to keep the same working duration.
903 907 def reschedule_on(date)
904 908 wd = working_duration
905 909 date = next_working_date(date)
906 910 self.start_date = date
907 911 self.due_date = add_working_days(date, wd)
908 912 end
909 913
910 914 # Reschedules the issue on the given date or the next working day and saves the record.
911 915 # If the issue is a parent task, this is done by rescheduling its subtasks.
912 916 def reschedule_on!(date)
913 917 return if date.nil?
914 918 if leaf?
915 919 if start_date.nil? || start_date != date
916 920 if start_date && start_date > date
917 921 # Issue can not be moved earlier than its soonest start date
918 922 date = [soonest_start(true), date].compact.max
919 923 end
920 924 reschedule_on(date)
921 925 begin
922 926 save
923 927 rescue ActiveRecord::StaleObjectError
924 928 reload
925 929 reschedule_on(date)
926 930 save
927 931 end
928 932 end
929 933 else
930 934 leaves.each do |leaf|
931 935 if leaf.start_date
932 936 # Only move subtask if it starts at the same date as the parent
933 937 # or if it starts before the given date
934 938 if start_date == leaf.start_date || date > leaf.start_date
935 939 leaf.reschedule_on!(date)
936 940 end
937 941 else
938 942 leaf.reschedule_on!(date)
939 943 end
940 944 end
941 945 end
942 946 end
943 947
944 948 def <=>(issue)
945 949 if issue.nil?
946 950 -1
947 951 elsif root_id != issue.root_id
948 952 (root_id || 0) <=> (issue.root_id || 0)
949 953 else
950 954 (lft || 0) <=> (issue.lft || 0)
951 955 end
952 956 end
953 957
954 958 def to_s
955 959 "#{tracker} ##{id}: #{subject}"
956 960 end
957 961
958 962 # Returns a string of css classes that apply to the issue
959 963 def css_classes
960 964 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
961 965 s << ' closed' if closed?
962 966 s << ' overdue' if overdue?
963 967 s << ' child' if child?
964 968 s << ' parent' unless leaf?
965 969 s << ' private' if is_private?
966 970 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
967 971 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
968 972 s
969 973 end
970 974
971 975 # Saves an issue and a time_entry from the parameters
972 976 def save_issue_with_child_records(params, existing_time_entry=nil)
973 977 Issue.transaction do
974 978 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
975 979 @time_entry = existing_time_entry || TimeEntry.new
976 980 @time_entry.project = project
977 981 @time_entry.issue = self
978 982 @time_entry.user = User.current
979 983 @time_entry.spent_on = User.current.today
980 984 @time_entry.attributes = params[:time_entry]
981 985 self.time_entries << @time_entry
982 986 end
983 987
984 988 # TODO: Rename hook
985 989 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
986 990 if save
987 991 # TODO: Rename hook
988 992 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
989 993 else
990 994 raise ActiveRecord::Rollback
991 995 end
992 996 end
993 997 end
994 998
995 999 # Unassigns issues from +version+ if it's no longer shared with issue's project
996 1000 def self.update_versions_from_sharing_change(version)
997 1001 # Update issues assigned to the version
998 1002 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
999 1003 end
1000 1004
1001 1005 # Unassigns issues from versions that are no longer shared
1002 1006 # after +project+ was moved
1003 1007 def self.update_versions_from_hierarchy_change(project)
1004 1008 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1005 1009 # Update issues of the moved projects and issues assigned to a version of a moved project
1006 1010 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1007 1011 end
1008 1012
1009 1013 def parent_issue_id=(arg)
1010 1014 s = arg.to_s.strip.presence
1011 1015 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1012 1016 @parent_issue.id
1013 1017 else
1014 1018 @parent_issue = nil
1015 1019 @invalid_parent_issue_id = arg
1016 1020 end
1017 1021 end
1018 1022
1019 1023 def parent_issue_id
1020 1024 if @invalid_parent_issue_id
1021 1025 @invalid_parent_issue_id
1022 1026 elsif instance_variable_defined? :@parent_issue
1023 1027 @parent_issue.nil? ? nil : @parent_issue.id
1024 1028 else
1025 1029 parent_id
1026 1030 end
1027 1031 end
1028 1032
1029 1033 # Returns true if issue's project is a valid
1030 1034 # parent issue project
1031 1035 def valid_parent_project?(issue=parent)
1032 1036 return true if issue.nil? || issue.project_id == project_id
1033 1037
1034 1038 case Setting.cross_project_subtasks
1035 1039 when 'system'
1036 1040 true
1037 1041 when 'tree'
1038 1042 issue.project.root == project.root
1039 1043 when 'hierarchy'
1040 1044 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1041 1045 when 'descendants'
1042 1046 issue.project.is_or_is_ancestor_of?(project)
1043 1047 else
1044 1048 false
1045 1049 end
1046 1050 end
1047 1051
1048 1052 # Extracted from the ReportsController.
1049 1053 def self.by_tracker(project)
1050 1054 count_and_group_by(:project => project,
1051 1055 :field => 'tracker_id',
1052 1056 :joins => Tracker.table_name)
1053 1057 end
1054 1058
1055 1059 def self.by_version(project)
1056 1060 count_and_group_by(:project => project,
1057 1061 :field => 'fixed_version_id',
1058 1062 :joins => Version.table_name)
1059 1063 end
1060 1064
1061 1065 def self.by_priority(project)
1062 1066 count_and_group_by(:project => project,
1063 1067 :field => 'priority_id',
1064 1068 :joins => IssuePriority.table_name)
1065 1069 end
1066 1070
1067 1071 def self.by_category(project)
1068 1072 count_and_group_by(:project => project,
1069 1073 :field => 'category_id',
1070 1074 :joins => IssueCategory.table_name)
1071 1075 end
1072 1076
1073 1077 def self.by_assigned_to(project)
1074 1078 count_and_group_by(:project => project,
1075 1079 :field => 'assigned_to_id',
1076 1080 :joins => User.table_name)
1077 1081 end
1078 1082
1079 1083 def self.by_author(project)
1080 1084 count_and_group_by(:project => project,
1081 1085 :field => 'author_id',
1082 1086 :joins => User.table_name)
1083 1087 end
1084 1088
1085 1089 def self.by_subproject(project)
1086 1090 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1087 1091 s.is_closed as closed,
1088 1092 #{Issue.table_name}.project_id as project_id,
1089 1093 count(#{Issue.table_name}.id) as total
1090 1094 from
1091 1095 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1092 1096 where
1093 1097 #{Issue.table_name}.status_id=s.id
1094 1098 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1095 1099 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1096 1100 and #{Issue.table_name}.project_id <> #{project.id}
1097 1101 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1098 1102 end
1099 1103 # End ReportsController extraction
1100 1104
1101 1105 # Returns an array of projects that user can assign the issue to
1102 1106 def allowed_target_projects(user=User.current)
1103 1107 if new_record?
1104 1108 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1105 1109 else
1106 1110 self.class.allowed_target_projects_on_move(user)
1107 1111 end
1108 1112 end
1109 1113
1110 1114 # Returns an array of projects that user can move issues to
1111 1115 def self.allowed_target_projects_on_move(user=User.current)
1112 1116 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1113 1117 end
1114 1118
1115 1119 private
1116 1120
1117 1121 def after_project_change
1118 1122 # Update project_id on related time entries
1119 1123 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1120 1124
1121 1125 # Delete issue relations
1122 1126 unless Setting.cross_project_issue_relations?
1123 1127 relations_from.clear
1124 1128 relations_to.clear
1125 1129 end
1126 1130
1127 1131 # Move subtasks that were in the same project
1128 1132 children.each do |child|
1129 1133 next unless child.project_id == project_id_was
1130 1134 # Change project and keep project
1131 1135 child.send :project=, project, true
1132 1136 unless child.save
1133 1137 raise ActiveRecord::Rollback
1134 1138 end
1135 1139 end
1136 1140 end
1137 1141
1138 1142 # Callback for after the creation of an issue by copy
1139 1143 # * adds a "copied to" relation with the copied issue
1140 1144 # * copies subtasks from the copied issue
1141 1145 def after_create_from_copy
1142 1146 return unless copy? && !@after_create_from_copy_handled
1143 1147
1144 1148 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1145 1149 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1146 1150 unless relation.save
1147 1151 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1148 1152 end
1149 1153 end
1150 1154
1151 1155 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1152 1156 copy_options = (@copy_options || {}).merge(:subtasks => false)
1153 1157 copied_issue_ids = {@copied_from.id => self.id}
1154 1158 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1155 1159 # Do not copy self when copying an issue as a descendant of the copied issue
1156 1160 next if child == self
1157 1161 # Do not copy subtasks of issues that were not copied
1158 1162 next unless copied_issue_ids[child.parent_id]
1159 1163 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1160 1164 unless child.visible?
1161 1165 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1162 1166 next
1163 1167 end
1164 1168 copy = Issue.new.copy_from(child, copy_options)
1165 1169 copy.author = author
1166 1170 copy.project = project
1167 1171 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1168 1172 unless copy.save
1169 1173 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1170 1174 next
1171 1175 end
1172 1176 copied_issue_ids[child.id] = copy.id
1173 1177 end
1174 1178 end
1175 1179 @after_create_from_copy_handled = true
1176 1180 end
1177 1181
1178 1182 def update_nested_set_attributes
1179 1183 if root_id.nil?
1180 1184 # issue was just created
1181 1185 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1182 1186 set_default_left_and_right
1183 1187 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
1184 1188 if @parent_issue
1185 1189 move_to_child_of(@parent_issue)
1186 1190 end
1187 1191 reload
1188 1192 elsif parent_issue_id != parent_id
1189 1193 former_parent_id = parent_id
1190 1194 # moving an existing issue
1191 1195 if @parent_issue && @parent_issue.root_id == root_id
1192 1196 # inside the same tree
1193 1197 move_to_child_of(@parent_issue)
1194 1198 else
1195 1199 # to another tree
1196 1200 unless root?
1197 1201 move_to_right_of(root)
1198 1202 reload
1199 1203 end
1200 1204 old_root_id = root_id
1201 1205 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1202 1206 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1203 1207 offset = target_maxright + 1 - lft
1204 1208 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
1205 1209 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1206 1210 self[left_column_name] = lft + offset
1207 1211 self[right_column_name] = rgt + offset
1208 1212 if @parent_issue
1209 1213 move_to_child_of(@parent_issue)
1210 1214 end
1211 1215 end
1212 1216 reload
1213 1217 # delete invalid relations of all descendants
1214 1218 self_and_descendants.each do |issue|
1215 1219 issue.relations.each do |relation|
1216 1220 relation.destroy unless relation.valid?
1217 1221 end
1218 1222 end
1219 1223 # update former parent
1220 1224 recalculate_attributes_for(former_parent_id) if former_parent_id
1221 1225 end
1222 1226 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1223 1227 end
1224 1228
1225 1229 def update_parent_attributes
1226 1230 recalculate_attributes_for(parent_id) if parent_id
1227 1231 end
1228 1232
1229 1233 def recalculate_attributes_for(issue_id)
1230 1234 if issue_id && p = Issue.find_by_id(issue_id)
1231 1235 # priority = highest priority of children
1232 1236 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1233 1237 p.priority = IssuePriority.find_by_position(priority_position)
1234 1238 end
1235 1239
1236 1240 # start/due dates = lowest/highest dates of children
1237 1241 p.start_date = p.children.minimum(:start_date)
1238 1242 p.due_date = p.children.maximum(:due_date)
1239 1243 if p.start_date && p.due_date && p.due_date < p.start_date
1240 1244 p.start_date, p.due_date = p.due_date, p.start_date
1241 1245 end
1242 1246
1243 1247 # done ratio = weighted average ratio of leaves
1244 1248 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1245 1249 leaves_count = p.leaves.count
1246 1250 if leaves_count > 0
1247 1251 average = p.leaves.average(:estimated_hours).to_f
1248 1252 if average == 0
1249 1253 average = 1
1250 1254 end
1251 1255 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1252 1256 progress = done / (average * leaves_count)
1253 1257 p.done_ratio = progress.round
1254 1258 end
1255 1259 end
1256 1260
1257 1261 # estimate = sum of leaves estimates
1258 1262 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1259 1263 p.estimated_hours = nil if p.estimated_hours == 0.0
1260 1264
1261 1265 # ancestors will be recursively updated
1262 1266 p.save(:validate => false)
1263 1267 end
1264 1268 end
1265 1269
1266 1270 # Update issues so their versions are not pointing to a
1267 1271 # fixed_version that is not shared with the issue's project
1268 1272 def self.update_versions(conditions=nil)
1269 1273 # Only need to update issues with a fixed_version from
1270 1274 # a different project and that is not systemwide shared
1271 1275 Issue.scoped(:conditions => conditions).all(
1272 1276 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1273 1277 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1274 1278 " AND #{Version.table_name}.sharing <> 'system'",
1275 1279 :include => [:project, :fixed_version]
1276 1280 ).each do |issue|
1277 1281 next if issue.project.nil? || issue.fixed_version.nil?
1278 1282 unless issue.project.shared_versions.include?(issue.fixed_version)
1279 1283 issue.init_journal(User.current)
1280 1284 issue.fixed_version = nil
1281 1285 issue.save
1282 1286 end
1283 1287 end
1284 1288 end
1285 1289
1286 1290 # Callback on file attachment
1287 1291 def attachment_added(obj)
1288 1292 if @current_journal && !obj.new_record?
1289 1293 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1290 1294 end
1291 1295 end
1292 1296
1293 1297 # Callback on attachment deletion
1294 1298 def attachment_removed(obj)
1295 1299 if @current_journal && !obj.new_record?
1296 1300 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1297 1301 @current_journal.save
1298 1302 end
1299 1303 end
1300 1304
1301 1305 # Default assignment based on category
1302 1306 def default_assign
1303 1307 if assigned_to.nil? && category && category.assigned_to
1304 1308 self.assigned_to = category.assigned_to
1305 1309 end
1306 1310 end
1307 1311
1308 1312 # Updates start/due dates of following issues
1309 1313 def reschedule_following_issues
1310 1314 if start_date_changed? || due_date_changed?
1311 1315 relations_from.each do |relation|
1312 1316 relation.set_issue_to_dates
1313 1317 end
1314 1318 end
1315 1319 end
1316 1320
1317 1321 # Closes duplicates if the issue is being closed
1318 1322 def close_duplicates
1319 1323 if closing?
1320 1324 duplicates.each do |duplicate|
1321 1325 # Reload is need in case the duplicate was updated by a previous duplicate
1322 1326 duplicate.reload
1323 1327 # Don't re-close it if it's already closed
1324 1328 next if duplicate.closed?
1325 1329 # Same user and notes
1326 1330 if @current_journal
1327 1331 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1328 1332 end
1329 1333 duplicate.update_attribute :status, self.status
1330 1334 end
1331 1335 end
1332 1336 end
1333 1337
1334 1338 # Make sure updated_on is updated when adding a note and set updated_on now
1335 1339 # so we can set closed_on with the same value on closing
1336 1340 def force_updated_on_change
1337 1341 if @current_journal || changed?
1338 1342 self.updated_on = current_time_from_proper_timezone
1339 1343 if new_record?
1340 1344 self.created_on = updated_on
1341 1345 end
1342 1346 end
1343 1347 end
1344 1348
1345 1349 # Callback for setting closed_on when the issue is closed.
1346 1350 # The closed_on attribute stores the time of the last closing
1347 1351 # and is preserved when the issue is reopened.
1348 1352 def update_closed_on
1349 1353 if closing? || (new_record? && closed?)
1350 1354 self.closed_on = updated_on
1351 1355 end
1352 1356 end
1353 1357
1354 1358 # Saves the changes in a Journal
1355 1359 # Called after_save
1356 1360 def create_journal
1357 1361 if @current_journal
1358 1362 # attributes changes
1359 1363 if @attributes_before_change
1360 1364 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1361 1365 before = @attributes_before_change[c]
1362 1366 after = send(c)
1363 1367 next if before == after || (before.blank? && after.blank?)
1364 1368 @current_journal.details << JournalDetail.new(:property => 'attr',
1365 1369 :prop_key => c,
1366 1370 :old_value => before,
1367 1371 :value => after)
1368 1372 }
1369 1373 end
1370 1374 if @custom_values_before_change
1371 1375 # custom fields changes
1372 1376 custom_field_values.each {|c|
1373 1377 before = @custom_values_before_change[c.custom_field_id]
1374 1378 after = c.value
1375 1379 next if before == after || (before.blank? && after.blank?)
1376 1380
1377 1381 if before.is_a?(Array) || after.is_a?(Array)
1378 1382 before = [before] unless before.is_a?(Array)
1379 1383 after = [after] unless after.is_a?(Array)
1380 1384
1381 1385 # values removed
1382 1386 (before - after).reject(&:blank?).each do |value|
1383 1387 @current_journal.details << JournalDetail.new(:property => 'cf',
1384 1388 :prop_key => c.custom_field_id,
1385 1389 :old_value => value,
1386 1390 :value => nil)
1387 1391 end
1388 1392 # values added
1389 1393 (after - before).reject(&:blank?).each do |value|
1390 1394 @current_journal.details << JournalDetail.new(:property => 'cf',
1391 1395 :prop_key => c.custom_field_id,
1392 1396 :old_value => nil,
1393 1397 :value => value)
1394 1398 end
1395 1399 else
1396 1400 @current_journal.details << JournalDetail.new(:property => 'cf',
1397 1401 :prop_key => c.custom_field_id,
1398 1402 :old_value => before,
1399 1403 :value => after)
1400 1404 end
1401 1405 }
1402 1406 end
1403 1407 @current_journal.save
1404 1408 # reset current journal
1405 1409 init_journal @current_journal.user, @current_journal.notes
1406 1410 end
1407 1411 end
1408 1412
1409 1413 # Query generator for selecting groups of issue counts for a project
1410 1414 # based on specific criteria
1411 1415 #
1412 1416 # Options
1413 1417 # * project - Project to search in.
1414 1418 # * field - String. Issue field to key off of in the grouping.
1415 1419 # * joins - String. The table name to join against.
1416 1420 def self.count_and_group_by(options)
1417 1421 project = options.delete(:project)
1418 1422 select_field = options.delete(:field)
1419 1423 joins = options.delete(:joins)
1420 1424
1421 1425 where = "#{Issue.table_name}.#{select_field}=j.id"
1422 1426
1423 1427 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1424 1428 s.is_closed as closed,
1425 1429 j.id as #{select_field},
1426 1430 count(#{Issue.table_name}.id) as total
1427 1431 from
1428 1432 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1429 1433 where
1430 1434 #{Issue.table_name}.status_id=s.id
1431 1435 and #{where}
1432 1436 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1433 1437 and #{visible_condition(User.current, :project => project)}
1434 1438 group by s.id, s.is_closed, j.id")
1435 1439 end
1436 1440 end
Show file before | Show file after | Hide comments
@@ -1,157 +1,170
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueRelationTest < ActiveSupport::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :issue_relations,
29 29 :enabled_modules,
30 30 :enumerations,
31 31 :trackers
32 32
33 33 include Redmine::I18n
34 34
35 35 def test_create
36 36 from = Issue.find(1)
37 37 to = Issue.find(2)
38 38
39 39 relation = IssueRelation.new :issue_from => from, :issue_to => to,
40 40 :relation_type => IssueRelation::TYPE_PRECEDES
41 41 assert relation.save
42 42 relation.reload
43 43 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
44 44 assert_equal from, relation.issue_from
45 45 assert_equal to, relation.issue_to
46 46 end
47 47
48 48 def test_create_minimum
49 49 relation = IssueRelation.new :issue_from => Issue.find(1), :issue_to => Issue.find(2)
50 50 assert relation.save
51 51 assert_equal IssueRelation::TYPE_RELATES, relation.relation_type
52 52 end
53 53
54 54 def test_follows_relation_should_be_reversed
55 55 from = Issue.find(1)
56 56 to = Issue.find(2)
57 57
58 58 relation = IssueRelation.new :issue_from => from, :issue_to => to,
59 59 :relation_type => IssueRelation::TYPE_FOLLOWS
60 60 assert relation.save
61 61 relation.reload
62 62 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
63 63 assert_equal to, relation.issue_from
64 64 assert_equal from, relation.issue_to
65 65 end
66 66
67 67 def test_follows_relation_should_not_be_reversed_if_validation_fails
68 68 from = Issue.find(1)
69 69 to = Issue.find(2)
70 70
71 71 relation = IssueRelation.new :issue_from => from, :issue_to => to,
72 72 :relation_type => IssueRelation::TYPE_FOLLOWS,
73 73 :delay => 'xx'
74 74 assert !relation.save
75 75 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type
76 76 assert_equal from, relation.issue_from
77 77 assert_equal to, relation.issue_to
78 78 end
79 79
80 80 def test_relation_type_for
81 81 from = Issue.find(1)
82 82 to = Issue.find(2)
83 83
84 84 relation = IssueRelation.new :issue_from => from, :issue_to => to,
85 85 :relation_type => IssueRelation::TYPE_PRECEDES
86 86 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type_for(from)
87 87 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type_for(to)
88 88 end
89 89
90 90 def test_set_issue_to_dates_without_issue_to
91 91 r = IssueRelation.new(:issue_from => Issue.new(:start_date => Date.today),
92 92 :relation_type => IssueRelation::TYPE_PRECEDES,
93 93 :delay => 1)
94 94 assert_nil r.set_issue_to_dates
95 95 end
96 96
97 97 def test_set_issue_to_dates_without_issues
98 98 r = IssueRelation.new(:relation_type => IssueRelation::TYPE_PRECEDES, :delay => 1)
99 99 assert_nil r.set_issue_to_dates
100 100 end
101 101
102 102 def test_validates_circular_dependency
103 103 IssueRelation.delete_all
104 104 assert IssueRelation.create!(
105 105 :issue_from => Issue.find(1), :issue_to => Issue.find(2),
106 106 :relation_type => IssueRelation::TYPE_PRECEDES
107 107 )
108 108 assert IssueRelation.create!(
109 109 :issue_from => Issue.find(2), :issue_to => Issue.find(3),
110 110 :relation_type => IssueRelation::TYPE_PRECEDES
111 111 )
112 112 r = IssueRelation.new(
113 113 :issue_from => Issue.find(3), :issue_to => Issue.find(1),
114 114 :relation_type => IssueRelation::TYPE_PRECEDES
115 115 )
116 116 assert !r.save
117 117 assert_not_nil r.errors[:base]
118 118 end
119 119
120 120 def test_validates_circular_dependency_of_subtask
121 121 set_language_if_valid 'en'
122 122 issue1 = Issue.generate!
123 123 issue2 = Issue.generate!
124 124 IssueRelation.create!(
125 125 :issue_from => issue1, :issue_to => issue2,
126 126 :relation_type => IssueRelation::TYPE_PRECEDES
127 127 )
128 128 child = Issue.generate!(:parent_issue_id => issue2.id)
129 129 issue1.reload
130 130 child.reload
131 131
132 132 r = IssueRelation.new(
133 133 :issue_from => child, :issue_to => issue1,
134 134 :relation_type => IssueRelation::TYPE_PRECEDES
135 135 )
136 136 assert !r.save
137 137 assert_include 'This relation would create a circular dependency', r.errors.full_messages
138 138 end
139 139
140 def test_subtasks_should_allow_precedes_relation
141 parent = Issue.generate!
142 child1 = Issue.generate!(:parent_issue_id => parent.id)
143 child2 = Issue.generate!(:parent_issue_id => parent.id)
144
145 r = IssueRelation.new(
146 :issue_from => child1, :issue_to => child2,
147 :relation_type => IssueRelation::TYPE_PRECEDES
148 )
149 assert r.valid?
150 assert r.save
151 end
152
140 153 def test_validates_circular_dependency_on_reverse_relations
141 154 IssueRelation.delete_all
142 155 assert IssueRelation.create!(
143 156 :issue_from => Issue.find(1), :issue_to => Issue.find(3),
144 157 :relation_type => IssueRelation::TYPE_BLOCKS
145 158 )
146 159 assert IssueRelation.create!(
147 160 :issue_from => Issue.find(1), :issue_to => Issue.find(2),
148 161 :relation_type => IssueRelation::TYPE_BLOCKED
149 162 )
150 163 r = IssueRelation.new(
151 164 :issue_from => Issue.find(2), :issue_to => Issue.find(1),
152 165 :relation_type => IssueRelation::TYPE_BLOCKED
153 166 )
154 167 assert !r.save
155 168 assert_not_nil r.errors[:base]
156 169 end
157 170 end
General Comments 0
You need to be logged in to leave comments. Login now