jro_apps/redmine Commit - r11467:ca39b054208c

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class Issue < ActiveRecord::Base

18

class Issue < ActiveRecord::Base

19

include Redmine::SafeAttributes

19

include Redmine::SafeAttributes

20

include Redmine::Utils::DateCalculation

20

include Redmine::Utils::DateCalculation

21

22

belongs_to :project

22

belongs_to :project

23

belongs_to :tracker

23

belongs_to :tracker

24

belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'

24

belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'

25

belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'

25

belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'

26

belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'

26

belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'

27

belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'

27

belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'

28

belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'

28

belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'

29

belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'

29

belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'

30

31

has_many :journals, :as => :journalized, :dependent => :destroy

31

has_many :journals, :as => :journalized, :dependent => :destroy

32

has_many :visible_journals,

32

has_many :visible_journals,

33

:class_name => 'Journal',

33

:class_name => 'Journal',

34

:as => :journalized,

34

:as => :journalized,

35

:conditions => Proc.new {

35

:conditions => Proc.new {

36

["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]

36

["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]

37

},

37

},

38

:readonly => true

38

:readonly => true

39

40

has_many :time_entries, :dependent => :delete_all

40

has_many :time_entries, :dependent => :delete_all

41

has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"

41

has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"

42

43

has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all

43

has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all

44

has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all

44

has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all

45

46

acts_as_nested_set :scope => 'root_id', :dependent => :destroy

46

acts_as_nested_set :scope => 'root_id', :dependent => :destroy

47

acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed

47

acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed

48

acts_as_customizable

48

acts_as_customizable

49

acts_as_watchable

49

acts_as_watchable

50

acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],

50

acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],

51

:include => [:project, :visible_journals],

51

:include => [:project, :visible_journals],

52

# sort by id so that limited eager loading doesn't break with postgresql

52

# sort by id so that limited eager loading doesn't break with postgresql

53

:order_column => "#{table_name}.id"

53

:order_column => "#{table_name}.id"

54

acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},

54

acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},

55

:url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},

55

:url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},

56

:type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }

56

:type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }

57

58

acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},

58

acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},

59

:author_key => :author_id

59

:author_key => :author_id

60

61

DONE_RATIO_OPTIONS = %w(issue_field issue_status)

61

DONE_RATIO_OPTIONS = %w(issue_field issue_status)

62

63

attr_reader :current_journal

63

attr_reader :current_journal

64

delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true

64

delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true

65

66

validates_presence_of :subject, :priority, :project, :tracker, :author, :status

66

validates_presence_of :subject, :priority, :project, :tracker, :author, :status

67

68

validates_length_of :subject, :maximum => 255

68

validates_length_of :subject, :maximum => 255

69

validates_inclusion_of :done_ratio, :in => 0..100

69

validates_inclusion_of :done_ratio, :in => 0..100

70

validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}

70

validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}

71

validates :start_date, :date => true

71

validates :start_date, :date => true

72

validates :due_date, :date => true

72

validates :due_date, :date => true

73

validate :validate_issue, :validate_required_fields

73

validate :validate_issue, :validate_required_fields

74

75

scope :visible, lambda {|*args|

75

scope :visible, lambda {|*args|

76

includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))

76

includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))

77

}

77

}

78

79

scope :open, lambda {|*args|

79

scope :open, lambda {|*args|

80

is_closed = args.size > 0 ? !args.first : false

80

is_closed = args.size > 0 ? !args.first : false

81

includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)

81

includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)

82

}

82

}

83

84

scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }

84

scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }

85

scope :on_active_project, lambda {

85

scope :on_active_project, lambda {

86

includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)

86

includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)

87

}

87

}

88

scope :fixed_version, lambda {|versions|

88

scope :fixed_version, lambda {|versions|

89

ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}

89

ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}

90

ids.any? ? where(:fixed_version_id => ids) : where('1=0')

90

ids.any? ? where(:fixed_version_id => ids) : where('1=0')

91

}

91

}

92

93

before_create :default_assign

93

before_create :default_assign

94

before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on

94

before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on

95

after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

95

after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

96

after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal

96

after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal

97

# Should be after_create but would be called before previous after_save callbacks

97

# Should be after_create but would be called before previous after_save callbacks

98

after_save :after_create_from_copy

98

after_save :after_create_from_copy

99

after_destroy :update_parent_attributes

99

after_destroy :update_parent_attributes

100

101

# Returns a SQL conditions string used to find all issues visible by the specified user

101

# Returns a SQL conditions string used to find all issues visible by the specified user

102

def self.visible_condition(user, options={})

102

def self.visible_condition(user, options={})

103

Project.allowed_to_condition(user, :view_issues, options) do |role, user|

103

Project.allowed_to_condition(user, :view_issues, options) do |role, user|

104

if user.logged?

104

if user.logged?

105

case role.issues_visibility

105

case role.issues_visibility

106

when 'all'

106

when 'all'

107

nil

107

nil

108

when 'default'

108

when 'default'

109

user_ids = [user.id] + user.groups.map(&:id)

109

user_ids = [user.id] + user.groups.map(&:id)

110

"(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

110

"(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

111

when 'own'

111

when 'own'

112

user_ids = [user.id] + user.groups.map(&:id)

112

user_ids = [user.id] + user.groups.map(&:id)

113

"(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

113

"(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

114

else

114

else

115

'1=0'

115

'1=0'

116

end

116

end

117

else

117

else

118

"(#{table_name}.is_private = #{connection.quoted_false})"

118

"(#{table_name}.is_private = #{connection.quoted_false})"

119

end

119

end

120

end

120

end

121

end

121

end

122

123

# Returns true if usr or current user is allowed to view the issue

123

# Returns true if usr or current user is allowed to view the issue

124

def visible?(usr=nil)

124

def visible?(usr=nil)

125

(usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|

125

(usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|

126

if user.logged?

126

if user.logged?

127

case role.issues_visibility

127

case role.issues_visibility

128

when 'all'

128

when 'all'

129

true

129

true

130

when 'default'

130

when 'default'

131

!self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))

131

!self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))

132

when 'own'

132

when 'own'

133

self.author == user || user.is_or_belongs_to?(assigned_to)

133

self.author == user || user.is_or_belongs_to?(assigned_to)

134

else

134

else

135

false

135

false

136

end

136

end

137

else

137

else

138

!self.is_private?

138

!self.is_private?

139

end

139

end

140

end

140

end

141

end

141

end

142

143

# Returns true if user or current user is allowed to edit or add a note to the issue

143

# Returns true if user or current user is allowed to edit or add a note to the issue

144

def editable?(user=User.current)

144

def editable?(user=User.current)

145

user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)

145

user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)

146

end

146

end

147

148

def initialize(attributes=nil, *args)

148

def initialize(attributes=nil, *args)

149

super

149

super

150

if new_record?

150

if new_record?

151

# set default values for new records only

151

# set default values for new records only

152

self.status ||= IssueStatus.default

152

self.status ||= IssueStatus.default

153

self.priority ||= IssuePriority.default

153

self.priority ||= IssuePriority.default

154

self.watcher_user_ids = []

154

self.watcher_user_ids = []

155

end

155

end

156

end

156

end

157

158

def create_or_update

158

def create_or_update

159

super

159

super

160

ensure

160

ensure

161

@status_was = nil

161

@status_was = nil

162

end

162

end

163

private :create_or_update

163

private :create_or_update

164

165

# AR#Persistence#destroy would raise and RecordNotFound exception

165

# AR#Persistence#destroy would raise and RecordNotFound exception

166

# if the issue was already deleted or updated (non matching lock_version).

166

# if the issue was already deleted or updated (non matching lock_version).

167

# This is a problem when bulk deleting issues or deleting a project

167

# This is a problem when bulk deleting issues or deleting a project

168

# (because an issue may already be deleted if its parent was deleted

168

# (because an issue may already be deleted if its parent was deleted

169

# first).

169

# first).

170

# The issue is reloaded by the nested_set before being deleted so

170

# The issue is reloaded by the nested_set before being deleted so

171

# the lock_version condition should not be an issue but we handle it.

171

# the lock_version condition should not be an issue but we handle it.

172

def destroy

172

def destroy

173

super

173

super

174

rescue ActiveRecord::RecordNotFound

174

rescue ActiveRecord::RecordNotFound

175

# Stale or already deleted

175

# Stale or already deleted

176

begin

176

begin

177

reload

177

reload

178

rescue ActiveRecord::RecordNotFound

178

rescue ActiveRecord::RecordNotFound

179

# The issue was actually already deleted

179

# The issue was actually already deleted

180

@destroyed = true

180

@destroyed = true

181

return freeze

181

return freeze

182

end

182

end

183

# The issue was stale, retry to destroy

183

# The issue was stale, retry to destroy

184

super

184

super

185

end

185

end

186

187

alias :base_reload :reload

187

alias :base_reload :reload

188

def reload(*args)

188

def reload(*args)

189

@workflow_rule_by_attribute = nil

189

@workflow_rule_by_attribute = nil

190

@assignable_versions = nil

190

@assignable_versions = nil

191

@relations = nil

191

@relations = nil

192

base_reload(*args)

192

base_reload(*args)

193

end

193

end

194

195

# Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields

195

# Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields

196

def available_custom_fields

196

def available_custom_fields

197

(project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []

197

(project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []

198

end

198

end

199

200

# Copies attributes from another issue, arg can be an id or an Issue

200

# Copies attributes from another issue, arg can be an id or an Issue

201

def copy_from(arg, options={})

201

def copy_from(arg, options={})

202

issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)

202

issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)

203

self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")

203

self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")

204

self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}

204

self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}

205

self.status = issue.status

205

self.status = issue.status

206

self.author = User.current

206

self.author = User.current

207

unless options[:attachments] == false

207

unless options[:attachments] == false

208

self.attachments = issue.attachments.map do |attachement|

208

self.attachments = issue.attachments.map do |attachement|

209

attachement.copy(:container => self)

209

attachement.copy(:container => self)

210

end

210

end

211

end

211

end

212

@copied_from = issue

212

@copied_from = issue

213

@copy_options = options

213

@copy_options = options

214

self

214

self

215

end

215

end

216

217

# Returns an unsaved copy of the issue

217

# Returns an unsaved copy of the issue

218

def copy(attributes=nil, copy_options={})

218

def copy(attributes=nil, copy_options={})

219

copy = self.class.new.copy_from(self, copy_options)

219

copy = self.class.new.copy_from(self, copy_options)

220

copy.attributes = attributes if attributes

220

copy.attributes = attributes if attributes

221

copy

221

copy

222

end

222

end

223

224

# Returns true if the issue is a copy

224

# Returns true if the issue is a copy

225

def copy?

225

def copy?

226

@copied_from.present?

226

@copied_from.present?

227

end

227

end

228

229

# Moves/copies an issue to a new project and tracker

229

# Moves/copies an issue to a new project and tracker

230

# Returns the moved/copied issue on success, false on failure

230

# Returns the moved/copied issue on success, false on failure

231

def move_to_project(new_project, new_tracker=nil, options={})

231

def move_to_project(new_project, new_tracker=nil, options={})

232

ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."

232

ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."

233

234

if options[:copy]

234

if options[:copy]

235

issue = self.copy

235

issue = self.copy

236

else

236

else

237

issue = self

237

issue = self

238

end

238

end

239

240

issue.init_journal(User.current, options[:notes])

240

issue.init_journal(User.current, options[:notes])

241

242

# Preserve previous behaviour

242

# Preserve previous behaviour

243

# #move_to_project doesn't change tracker automatically

243

# #move_to_project doesn't change tracker automatically

244

issue.send :project=, new_project, true

244

issue.send :project=, new_project, true

245

if new_tracker

245

if new_tracker

246

issue.tracker = new_tracker

246

issue.tracker = new_tracker

247

end

247

end

248

# Allow bulk setting of attributes on the issue

248

# Allow bulk setting of attributes on the issue

249

if options[:attributes]

249

if options[:attributes]

250

issue.attributes = options[:attributes]

250

issue.attributes = options[:attributes]

251

end

251

end

252

253

issue.save ? issue : false

253

issue.save ? issue : false

254

end

254

end

255

256

def status_id=(sid)

256

def status_id=(sid)

257

self.status = nil

257

self.status = nil

258

result = write_attribute(:status_id, sid)

258

result = write_attribute(:status_id, sid)

259

@workflow_rule_by_attribute = nil

259

@workflow_rule_by_attribute = nil

260

result

260

result

261

end

261

end

262

263

def priority_id=(pid)

263

def priority_id=(pid)

264

self.priority = nil

264

self.priority = nil

265

write_attribute(:priority_id, pid)

265

write_attribute(:priority_id, pid)

266

end

266

end

267

268

def category_id=(cid)

268

def category_id=(cid)

269

self.category = nil

269

self.category = nil

270

write_attribute(:category_id, cid)

270

write_attribute(:category_id, cid)

271

end

271

end

272

273

def fixed_version_id=(vid)

273

def fixed_version_id=(vid)

274

self.fixed_version = nil

274

self.fixed_version = nil

275

write_attribute(:fixed_version_id, vid)

275

write_attribute(:fixed_version_id, vid)

276

end

276

end

277

278

def tracker_id=(tid)

278

def tracker_id=(tid)

279

self.tracker = nil

279

self.tracker = nil

280

result = write_attribute(:tracker_id, tid)

280

result = write_attribute(:tracker_id, tid)

281

@custom_field_values = nil

281

@custom_field_values = nil

282

@workflow_rule_by_attribute = nil

282

@workflow_rule_by_attribute = nil

283

result

283

result

284

end

284

end

285

286

def project_id=(project_id)

286

def project_id=(project_id)

287

if project_id.to_s != self.project_id.to_s

287

if project_id.to_s != self.project_id.to_s

288

self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)

288

self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)

289

end

289

end

290

end

290

end

291

292

def project=(project, keep_tracker=false)

292

def project=(project, keep_tracker=false)

293

project_was = self.project

293

project_was = self.project

294

write_attribute(:project_id, project ? project.id : nil)

294

write_attribute(:project_id, project ? project.id : nil)

295

association_instance_set('project', project)

295

association_instance_set('project', project)

296

if project_was && project && project_was != project

296

if project_was && project && project_was != project

297

@assignable_versions = nil

297

@assignable_versions = nil

298

299

unless keep_tracker || project.trackers.include?(tracker)

299

unless keep_tracker || project.trackers.include?(tracker)

300

self.tracker = project.trackers.first

300

self.tracker = project.trackers.first

301

end

301

end

302

# Reassign to the category with same name if any

302

# Reassign to the category with same name if any

303

if category

303

if category

304

self.category = project.issue_categories.find_by_name(category.name)

304

self.category = project.issue_categories.find_by_name(category.name)

305

end

305

end

306

# Keep the fixed_version if it's still valid in the new_project

306

# Keep the fixed_version if it's still valid in the new_project

307

if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)

307

if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)

308

self.fixed_version = nil

308

self.fixed_version = nil

309

end

309

end

310

# Clear the parent task if it's no longer valid

310

# Clear the parent task if it's no longer valid

311

unless valid_parent_project?

311

unless valid_parent_project?

312

self.parent_issue_id = nil

312

self.parent_issue_id = nil

313

end

313

end

314

@custom_field_values = nil

314

@custom_field_values = nil

315

end

315

end

316

end

316

end

317

318

def description=(arg)

318

def description=(arg)

319

if arg.is_a?(String)

319

if arg.is_a?(String)

320

arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")

320

arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")

321

end

321

end

322

write_attribute(:description, arg)

322

write_attribute(:description, arg)

323

end

323

end

324

325

# Overrides assign_attributes so that project and tracker get assigned first

325

# Overrides assign_attributes so that project and tracker get assigned first

326

def assign_attributes_with_project_and_tracker_first(new_attributes, *args)

326

def assign_attributes_with_project_and_tracker_first(new_attributes, *args)

327

return if new_attributes.nil?

327

return if new_attributes.nil?

328

attrs = new_attributes.dup

328

attrs = new_attributes.dup

329

attrs.stringify_keys!

329

attrs.stringify_keys!

330

331

%w(project project_id tracker tracker_id).each do |attr|

331

%w(project project_id tracker tracker_id).each do |attr|

332

if attrs.has_key?(attr)

332

if attrs.has_key?(attr)

333

send "#{attr}=", attrs.delete(attr)

333

send "#{attr}=", attrs.delete(attr)

334

end

334

end

335

end

335

end

336

send :assign_attributes_without_project_and_tracker_first, attrs, *args

336

send :assign_attributes_without_project_and_tracker_first, attrs, *args

337

end

337

end

338

# Do not redefine alias chain on reload (see #4838)

338

# Do not redefine alias chain on reload (see #4838)

339

alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)

339

alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)

340

341

def estimated_hours=(h)

341

def estimated_hours=(h)

342

write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)

342

write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)

343

end

343

end

344

345

safe_attributes 'project_id',

345

safe_attributes 'project_id',

346

:if => lambda {|issue, user|

346

:if => lambda {|issue, user|

347

if issue.new_record?

347

if issue.new_record?

348

issue.copy?

348

issue.copy?

349

elsif user.allowed_to?(:move_issues, issue.project)

349

elsif user.allowed_to?(:move_issues, issue.project)

350

projects = Issue.allowed_target_projects_on_move(user)

350

projects = Issue.allowed_target_projects_on_move(user)

351

projects.include?(issue.project) && projects.size > 1

351

projects.include?(issue.project) && projects.size > 1

352

end

352

end

353

}

353

}

354

355

safe_attributes 'tracker_id',

355

safe_attributes 'tracker_id',

356

'status_id',

356

'status_id',

357

'category_id',

357

'category_id',

358

'assigned_to_id',

358

'assigned_to_id',

359

'priority_id',

359

'priority_id',

360

'fixed_version_id',

360

'fixed_version_id',

361

'subject',

361

'subject',

362

'description',

362

'description',

363

'start_date',

363

'start_date',

364

'due_date',

364

'due_date',

365

'done_ratio',

365

'done_ratio',

366

'estimated_hours',

366

'estimated_hours',

367

'custom_field_values',

367

'custom_field_values',

368

'custom_fields',

368

'custom_fields',

369

'lock_version',

369

'lock_version',

370

'notes',

370

'notes',

371

:if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }

371

:if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }

372

373

safe_attributes 'status_id',

373

safe_attributes 'status_id',

374

'assigned_to_id',

374

'assigned_to_id',

375

'fixed_version_id',

375

'fixed_version_id',

376

'done_ratio',

376

'done_ratio',

377

'lock_version',

377

'lock_version',

378

'notes',

378

'notes',

379

:if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }

379

:if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }

380

381

safe_attributes 'notes',

381

safe_attributes 'notes',

382

:if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}

382

:if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}

383

384

safe_attributes 'private_notes',

384

safe_attributes 'private_notes',

385

:if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}

385

:if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}

386

387

safe_attributes 'watcher_user_ids',

387

safe_attributes 'watcher_user_ids',

388

:if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}

388

:if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}

389

390

safe_attributes 'is_private',

390

safe_attributes 'is_private',

391

:if => lambda {|issue, user|

391

:if => lambda {|issue, user|

392

user.allowed_to?(:set_issues_private, issue.project) ||

392

user.allowed_to?(:set_issues_private, issue.project) ||

393

(issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))

393

(issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))

394

}

394

}

395

396

safe_attributes 'parent_issue_id',

396

safe_attributes 'parent_issue_id',

397

:if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&

397

:if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&

398

user.allowed_to?(:manage_subtasks, issue.project)}

398

user.allowed_to?(:manage_subtasks, issue.project)}

399

400

def safe_attribute_names(user=nil)

400

def safe_attribute_names(user=nil)

401

names = super

401

names = super

402

names -= disabled_core_fields

402

names -= disabled_core_fields

403

names -= read_only_attribute_names(user)

403

names -= read_only_attribute_names(user)

404

names

404

names

405

end

405

end

406

407

# Safely sets attributes

407

# Safely sets attributes

408

# Should be called from controllers instead of #attributes=

408

# Should be called from controllers instead of #attributes=

409

# attr_accessible is too rough because we still want things like

409

# attr_accessible is too rough because we still want things like

410

# Issue.new(:project => foo) to work

410

# Issue.new(:project => foo) to work

411

def safe_attributes=(attrs, user=User.current)

411

def safe_attributes=(attrs, user=User.current)

412

return unless attrs.is_a?(Hash)

412

return unless attrs.is_a?(Hash)

413

414

attrs = attrs.dup

414

attrs = attrs.dup

415

416

# Project and Tracker must be set before since new_statuses_allowed_to depends on it.

416

# Project and Tracker must be set before since new_statuses_allowed_to depends on it.

417

if (p = attrs.delete('project_id')) && safe_attribute?('project_id')

417

if (p = attrs.delete('project_id')) && safe_attribute?('project_id')

418

if allowed_target_projects(user).collect(&:id).include?(p.to_i)

418

if allowed_target_projects(user).collect(&:id).include?(p.to_i)

419

self.project_id = p

419

self.project_id = p

420

end

420

end

421

end

421

end

422

423

if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')

423

if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')

424

self.tracker_id = t

424

self.tracker_id = t

425

end

425

end

426

427

if (s = attrs.delete('status_id')) && safe_attribute?('status_id')

427

if (s = attrs.delete('status_id')) && safe_attribute?('status_id')

428

if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)

428

if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)

429

self.status_id = s

429

self.status_id = s

430

end

430

end

431

end

431

end

432

433

attrs = delete_unsafe_attributes(attrs, user)

433

attrs = delete_unsafe_attributes(attrs, user)

434

return if attrs.empty?

434

return if attrs.empty?

435

436

unless leaf?

436

unless leaf?

437

attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}

437

attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}

438

end

438

end

439

440

if attrs['parent_issue_id'].present?

440

if attrs['parent_issue_id'].present?

441

s = attrs['parent_issue_id'].to_s

441

s = attrs['parent_issue_id'].to_s

442

unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))

442

unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))

443

@invalid_parent_issue_id = attrs.delete('parent_issue_id')

443

@invalid_parent_issue_id = attrs.delete('parent_issue_id')

444

end

444

end

445

end

445

end

446

447

if attrs['custom_field_values'].present?

447

if attrs['custom_field_values'].present?

448

attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}

448

attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}

449

end

449

end

450

451

if attrs['custom_fields'].present?

451

if attrs['custom_fields'].present?

452

attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}

452

attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}

453

end

453

end

454

455

# mass-assignment security bypass

455

# mass-assignment security bypass

456

assign_attributes attrs, :without_protection => true

456

assign_attributes attrs, :without_protection => true

457

end

457

end

458

459

def disabled_core_fields

459

def disabled_core_fields

460

tracker ? tracker.disabled_core_fields : []

460

tracker ? tracker.disabled_core_fields : []

461

end

461

end

462

463

# Returns the custom_field_values that can be edited by the given user

463

# Returns the custom_field_values that can be edited by the given user

464

def editable_custom_field_values(user=nil)

464

def editable_custom_field_values(user=nil)

465

custom_field_values.reject do |value|

465

custom_field_values.reject do |value|

466

read_only_attribute_names(user).include?(value.custom_field_id.to_s)

466

read_only_attribute_names(user).include?(value.custom_field_id.to_s)

467

end

467

end

468

end

468

end

469

470

# Returns the names of attributes that are read-only for user or the current user

470

# Returns the names of attributes that are read-only for user or the current user

471

# For users with multiple roles, the read-only fields are the intersection of

471

# For users with multiple roles, the read-only fields are the intersection of

472

# read-only fields of each role

472

# read-only fields of each role

473

# The result is an array of strings where sustom fields are represented with their ids

473

# The result is an array of strings where sustom fields are represented with their ids

474

#

474

#

475

# Examples:

475

# Examples:

476

# issue.read_only_attribute_names # => ['due_date', '2']

476

# issue.read_only_attribute_names # => ['due_date', '2']

477

# issue.read_only_attribute_names(user) # => []

477

# issue.read_only_attribute_names(user) # => []

478

def read_only_attribute_names(user=nil)

478

def read_only_attribute_names(user=nil)

479

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys

479

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys

480

end

480

end

481

482

# Returns the names of required attributes for user or the current user

482

# Returns the names of required attributes for user or the current user

483

# For users with multiple roles, the required fields are the intersection of

483

# For users with multiple roles, the required fields are the intersection of

484

# required fields of each role

484

# required fields of each role

485

# The result is an array of strings where sustom fields are represented with their ids

485

# The result is an array of strings where sustom fields are represented with their ids

486

#

486

#

487

# Examples:

487

# Examples:

488

# issue.required_attribute_names # => ['due_date', '2']

488

# issue.required_attribute_names # => ['due_date', '2']

489

# issue.required_attribute_names(user) # => []

489

# issue.required_attribute_names(user) # => []

490

def required_attribute_names(user=nil)

490

def required_attribute_names(user=nil)

491

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys

491

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys

492

end

492

end

493

494

# Returns true if the attribute is required for user

494

# Returns true if the attribute is required for user

495

def required_attribute?(name, user=nil)

495

def required_attribute?(name, user=nil)

496

required_attribute_names(user).include?(name.to_s)

496

required_attribute_names(user).include?(name.to_s)

497

end

497

end

498

499

# Returns a hash of the workflow rule by attribute for the given user

499

# Returns a hash of the workflow rule by attribute for the given user

500

#

500

#

501

# Examples:

501

# Examples:

502

# issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}

502

# issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}

503

def workflow_rule_by_attribute(user=nil)

503

def workflow_rule_by_attribute(user=nil)

504

return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?

504

return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?

505

506

user_real = user || User.current

506

user_real = user || User.current

507

roles = user_real.admin ? Role.all : user_real.roles_for_project(project)

507

roles = user_real.admin ? Role.all : user_real.roles_for_project(project)

508

return {} if roles.empty?

508

return {} if roles.empty?

509

510

result = {}

510

result = {}

511

workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all

511

workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all

512

if workflow_permissions.any?

512

if workflow_permissions.any?

513

workflow_rules = workflow_permissions.inject({}) do |h, wp|

513

workflow_rules = workflow_permissions.inject({}) do |h, wp|

514

h[wp.field_name] ||= []

514

h[wp.field_name] ||= []

515

h[wp.field_name] << wp.rule

515

h[wp.field_name] << wp.rule

516

h

516

h

517

end

517

end

518

workflow_rules.each do |attr, rules|

518

workflow_rules.each do |attr, rules|

519

next if rules.size < roles.size

519

next if rules.size < roles.size

520

uniq_rules = rules.uniq

520

uniq_rules = rules.uniq

521

if uniq_rules.size == 1

521

if uniq_rules.size == 1

522

result[attr] = uniq_rules.first

522

result[attr] = uniq_rules.first

523

else

523

else

524

result[attr] = 'required'

524

result[attr] = 'required'

525

end

525

end

526

end

526

end

527

end

527

end

528

@workflow_rule_by_attribute = result if user.nil?

528

@workflow_rule_by_attribute = result if user.nil?

529

result

529

result

530

end

530

end

531

private :workflow_rule_by_attribute

531

private :workflow_rule_by_attribute

532

533

def done_ratio

533

def done_ratio

534

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

534

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

535

status.default_done_ratio

535

status.default_done_ratio

536

else

536

else

537

read_attribute(:done_ratio)

537

read_attribute(:done_ratio)

538

end

538

end

539

end

539

end

540

541

def self.use_status_for_done_ratio?

541

def self.use_status_for_done_ratio?

542

Setting.issue_done_ratio == 'issue_status'

542

Setting.issue_done_ratio == 'issue_status'

543

end

543

end

544

545

def self.use_field_for_done_ratio?

545

def self.use_field_for_done_ratio?

546

Setting.issue_done_ratio == 'issue_field'

546

Setting.issue_done_ratio == 'issue_field'

547

end

547

end

548

549

def validate_issue

549

def validate_issue

550

if due_date && start_date && due_date < start_date

550

if due_date && start_date && due_date < start_date

551

errors.add :due_date, :greater_than_start_date

551

errors.add :due_date, :greater_than_start_date

552

end

552

end

553

554

if start_date && soonest_start && start_date < soonest_start

554

if start_date && soonest_start && start_date < soonest_start

555

errors.add :start_date, :invalid

555

errors.add :start_date, :invalid

556

end

556

end

557

558

if fixed_version

558

if fixed_version

559

if !assignable_versions.include?(fixed_version)

559

if !assignable_versions.include?(fixed_version)

560

errors.add :fixed_version_id, :inclusion

560

errors.add :fixed_version_id, :inclusion

561

elsif reopened? && fixed_version.closed?

561

elsif reopened? && fixed_version.closed?

562

errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)

562

errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)

563

end

563

end

564

end

564

end

565

566

# Checks that the issue can not be added/moved to a disabled tracker

566

# Checks that the issue can not be added/moved to a disabled tracker

567

if project && (tracker_id_changed? || project_id_changed?)

567

if project && (tracker_id_changed? || project_id_changed?)

568

unless project.trackers.include?(tracker)

568

unless project.trackers.include?(tracker)

569

errors.add :tracker_id, :inclusion

569

errors.add :tracker_id, :inclusion

570

end

570

end

571

end

571

end

572

573

# Checks parent issue assignment

573

# Checks parent issue assignment

574

if @invalid_parent_issue_id.present?

574

if @invalid_parent_issue_id.present?

575

errors.add :parent_issue_id, :invalid

575

errors.add :parent_issue_id, :invalid

576

elsif @parent_issue

576

elsif @parent_issue

577

if !valid_parent_project?(@parent_issue)

577

if !valid_parent_project?(@parent_issue)

578

errors.add :parent_issue_id, :invalid

578

errors.add :parent_issue_id, :invalid

579

elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))

579

elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))

580

errors.add :parent_issue_id, :invalid

580

errors.add :parent_issue_id, :invalid

581

elsif !new_record?

581

elsif !new_record?

582

# moving an existing issue

582

# moving an existing issue

583

if @parent_issue.root_id != root_id

583

if @parent_issue.root_id != root_id

584

# we can always move to another tree

584

# we can always move to another tree

585

elsif move_possible?(@parent_issue)

585

elsif move_possible?(@parent_issue)

586

# move accepted inside tree

586

# move accepted inside tree

587

else

587

else

588

errors.add :parent_issue_id, :invalid

588

errors.add :parent_issue_id, :invalid

589

end

589

end

590

end

590

end

591

end

591

end

592

end

592

end

593

594

# Validates the issue against additional workflow requirements

594

# Validates the issue against additional workflow requirements

595

def validate_required_fields

595

def validate_required_fields

596

user = new_record? ? author : current_journal.try(:user)

596

user = new_record? ? author : current_journal.try(:user)

597

598

required_attribute_names(user).each do |attribute|

598

required_attribute_names(user).each do |attribute|

599

if attribute =~ /^\d+$/

599

if attribute =~ /^\d+$/

600

attribute = attribute.to_i

600

attribute = attribute.to_i

601

v = custom_field_values.detect {|v| v.custom_field_id == attribute }

601

v = custom_field_values.detect {|v| v.custom_field_id == attribute }

602

if v && v.value.blank?

602

if v && v.value.blank?

603

errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')

603

errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')

604

end

604

end

605

else

605

else

606

if respond_to?(attribute) && send(attribute).blank?

606

if respond_to?(attribute) && send(attribute).blank?

607

errors.add attribute, :blank

607

errors.add attribute, :blank

608

end

608

end

609

end

609

end

610

end

610

end

611

end

611

end

612

613

# Set the done_ratio using the status if that setting is set. This will keep the done_ratios

613

# Set the done_ratio using the status if that setting is set. This will keep the done_ratios

614

# even if the user turns off the setting later

614

# even if the user turns off the setting later

615

def update_done_ratio_from_issue_status

615

def update_done_ratio_from_issue_status

616

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

616

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

617

self.done_ratio = status.default_done_ratio

617

self.done_ratio = status.default_done_ratio

618

end

618

end

619

end

619

end

620

621

def init_journal(user, notes = "")

621

def init_journal(user, notes = "")

622

@current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)

622

@current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)

623

if new_record?

623

if new_record?

624

@current_journal.notify = false

624

@current_journal.notify = false

625

else

625

else

626

@attributes_before_change = attributes.dup

626

@attributes_before_change = attributes.dup

627

@custom_values_before_change = {}

627

@custom_values_before_change = {}

628

self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }

628

self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }

629

end

629

end

630

@current_journal

630

@current_journal

631

end

631

end

632

633

# Returns the id of the last journal or nil

633

# Returns the id of the last journal or nil

634

def last_journal_id

634

def last_journal_id

635

if new_record?

635

if new_record?

636

nil

636

nil

637

else

637

else

638

journals.maximum(:id)

638

journals.maximum(:id)

639

end

639

end

640

end

640

end

641

642

# Returns a scope for journals that have an id greater than journal_id

642

# Returns a scope for journals that have an id greater than journal_id

643

def journals_after(journal_id)

643

def journals_after(journal_id)

644

scope = journals.reorder("#{Journal.table_name}.id ASC")

644

scope = journals.reorder("#{Journal.table_name}.id ASC")

645

if journal_id.present?

645

if journal_id.present?

646

scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)

646

scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)

647

end

647

end

648

scope

648

scope

649

end

649

end

650

651

# Returns the initial status of the issue

651

# Returns the initial status of the issue

652

# Returns nil for a new issue

652

# Returns nil for a new issue

653

def status_was

653

def status_was

654

if status_id_was && status_id_was.to_i > 0

654

if status_id_was && status_id_was.to_i > 0

655

@status_was ||= IssueStatus.find_by_id(status_id_was)

655

@status_was ||= IssueStatus.find_by_id(status_id_was)

656

end

656

end

657

end

657

end

658

659

# Return true if the issue is closed, otherwise false

659

# Return true if the issue is closed, otherwise false

660

def closed?

660

def closed?

661

self.status.is_closed?

661

self.status.is_closed?

662

end

662

end

663

664

# Return true if the issue is being reopened

664

# Return true if the issue is being reopened

665

def reopened?

665

def reopened?

666

if !new_record? && status_id_changed?

666

if !new_record? && status_id_changed?

667

status_was = IssueStatus.find_by_id(status_id_was)

667

status_was = IssueStatus.find_by_id(status_id_was)

668

status_new = IssueStatus.find_by_id(status_id)

668

status_new = IssueStatus.find_by_id(status_id)

669

if status_was && status_new && status_was.is_closed? && !status_new.is_closed?

669

if status_was && status_new && status_was.is_closed? && !status_new.is_closed?

670

return true

670

return true

671

end

671

end

672

end

672

end

673

false

673

false

674

end

674

end

675

676

# Return true if the issue is being closed

676

# Return true if the issue is being closed

677

def closing?

677

def closing?

678

if !new_record? && status_id_changed?

678

if !new_record? && status_id_changed?

679

if status_was && status && !status_was.is_closed? && status.is_closed?

679

if status_was && status && !status_was.is_closed? && status.is_closed?

680

return true

680

return true

681

end

681

end

682

end

682

end

683

false

683

false

684

end

684

end

685

686

# Returns true if the issue is overdue

686

# Returns true if the issue is overdue

687

def overdue?

687

def overdue?

688

!due_date.nil? && (due_date < Date.today) && !status.is_closed?

688

!due_date.nil? && (due_date < Date.today) && !status.is_closed?

689

end

689

end

690

691

# Is the amount of work done less than it should for the due date

691

# Is the amount of work done less than it should for the due date

692

def behind_schedule?

692

def behind_schedule?

693

return false if start_date.nil? || due_date.nil?

693

return false if start_date.nil? || due_date.nil?

694

done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor

694

done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor

695

return done_date <= Date.today

695

return done_date <= Date.today

696

end

696

end

697

698

# Does this issue have children?

698

# Does this issue have children?

699

def children?

699

def children?

700

!leaf?

700

!leaf?

701

end

701

end

702

703

# Users the issue can be assigned to

703

# Users the issue can be assigned to

704

def assignable_users

704

def assignable_users

705

users = project.assignable_users

705

users = project.assignable_users

706

users << author if author

706

users << author if author

707

users << assigned_to if assigned_to

707

users << assigned_to if assigned_to

708

users.uniq.sort

708

users.uniq.sort

709

end

709

end

710

711

# Versions that the issue can be assigned to

711

# Versions that the issue can be assigned to

712

def assignable_versions

712

def assignable_versions

713

return @assignable_versions if @assignable_versions

713

return @assignable_versions if @assignable_versions

714

715

versions = project.shared_versions.open.all

715

versions = project.shared_versions.open.all

716

if fixed_version

716

if fixed_version

717

if fixed_version_id_changed?

717

if fixed_version_id_changed?

718

# nothing to do

718

# nothing to do

719

elsif project_id_changed?

719

elsif project_id_changed?

720

if project.shared_versions.include?(fixed_version)

720

if project.shared_versions.include?(fixed_version)

721

versions << fixed_version

721

versions << fixed_version

722

end

722

end

723

else

723

else

724

versions << fixed_version

724

versions << fixed_version

725

end

725

end

726

end

726

end

727

@assignable_versions = versions.uniq.sort

727

@assignable_versions = versions.uniq.sort

728

end

728

end

729

730

# Returns true if this issue is blocked by another issue that is still open

730

# Returns true if this issue is blocked by another issue that is still open

731

def blocked?

731

def blocked?

732

!relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?

732

!relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?

733

end

733

end

734

735

# Returns an array of statuses that user is able to apply

735

# Returns an array of statuses that user is able to apply

736

def new_statuses_allowed_to(user=User.current, include_default=false)

736

def new_statuses_allowed_to(user=User.current, include_default=false)

737

if new_record? && @copied_from

737

if new_record? && @copied_from

738

[IssueStatus.default, @copied_from.status].compact.uniq.sort

738

[IssueStatus.default, @copied_from.status].compact.uniq.sort

739

else

739

else

740

initial_status = nil

740

initial_status = nil

741

if new_record?

741

if new_record?

742

initial_status = IssueStatus.default

742

initial_status = IssueStatus.default

743

elsif status_id_was

743

elsif status_id_was

744

initial_status = IssueStatus.find_by_id(status_id_was)

744

initial_status = IssueStatus.find_by_id(status_id_was)

745

end

745

end

746

initial_status ||= status

746

initial_status ||= status

747

748

statuses = initial_status.find_new_statuses_allowed_to(

748

statuses = initial_status.find_new_statuses_allowed_to(

749

user.admin ? Role.all : user.roles_for_project(project),

749

user.admin ? Role.all : user.roles_for_project(project),

750

tracker,

750

tracker,

751

author == user,

751

author == user,

752

assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id

752

assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id

753

)

753

)

754

statuses << initial_status unless statuses.empty?

754

statuses << initial_status unless statuses.empty?

755

statuses << IssueStatus.default if include_default

755

statuses << IssueStatus.default if include_default

756

statuses = statuses.compact.uniq.sort

756

statuses = statuses.compact.uniq.sort

757

blocked? ? statuses.reject {|s| s.is_closed?} : statuses

757

blocked? ? statuses.reject {|s| s.is_closed?} : statuses

758

end

758

end

759

end

759

end

760

761

def assigned_to_was

761

def assigned_to_was

762

if assigned_to_id_changed? && assigned_to_id_was.present?

762

if assigned_to_id_changed? && assigned_to_id_was.present?

763

@assigned_to_was ||= User.find_by_id(assigned_to_id_was)

763

@assigned_to_was ||= User.find_by_id(assigned_to_id_was)

764

end

764

end

765

end

765

end

766

767

# Returns the users that should be notified

767

# Returns the users that should be notified

768

def notified_users

768

def notified_users

769

notified = []

769

notified = []

770

# Author and assignee are always notified unless they have been

770

# Author and assignee are always notified unless they have been

771

# locked or don't want to be notified

771

# locked or don't want to be notified

772

notified << author if author

772

notified << author if author

773

if assigned_to

773

if assigned_to

774

notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])

774

notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])

775

end

775

end

776

if assigned_to_was

776

if assigned_to_was

777

notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])

777

notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])

778

end

778

end

779

notified = notified.select {|u| u.active? && u.notify_about?(self)}

779

notified = notified.select {|u| u.active? && u.notify_about?(self)}

780

781

notified += project.notified_users

781

notified += project.notified_users

782

notified.uniq!

782

notified.uniq!

783

# Remove users that can not view the issue

783

# Remove users that can not view the issue

784

notified.reject! {|user| !visible?(user)}

784

notified.reject! {|user| !visible?(user)}

785

notified

785

notified

786

end

786

end

787

788

# Returns the email addresses that should be notified

788

# Returns the email addresses that should be notified

789

def recipients

789

def recipients

790

notified_users.collect(&:mail)

790

notified_users.collect(&:mail)

791

end

791

end

792

793

# Returns the number of hours spent on this issue

793

# Returns the number of hours spent on this issue

794

def spent_hours

794

def spent_hours

795

@spent_hours ||= time_entries.sum(:hours) || 0

795

@spent_hours ||= time_entries.sum(:hours) || 0

796

end

796

end

797

798

# Returns the total number of hours spent on this issue and its descendants

798

# Returns the total number of hours spent on this issue and its descendants

799

#

799

#

800

# Example:

800

# Example:

801

# spent_hours => 0.0

801

# spent_hours => 0.0

802

# spent_hours => 50.2

802

# spent_hours => 50.2

803

def total_spent_hours

803

def total_spent_hours

804

@total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",

804

@total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",

805

:joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0

805

:joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0

806

end

806

end

807

808

def relations

808

def relations

809

@relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)

809

@relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)

810

end

810

end

811

812

# Preloads relations for a collection of issues

812

# Preloads relations for a collection of issues

813

def self.load_relations(issues)

813

def self.load_relations(issues)

814

if issues.any?

814

if issues.any?

815

relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])

815

relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])

816

issues.each do |issue|

816

issues.each do |issue|

817

issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}

817

issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}

818

end

818

end

819

end

819

end

820

end

820

end

821

822

# Preloads visible spent time for a collection of issues

822

# Preloads visible spent time for a collection of issues

823

def self.load_visible_spent_hours(issues, user=User.current)

823

def self.load_visible_spent_hours(issues, user=User.current)

824

if issues.any?

824

if issues.any?

825

hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)

825

hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)

826

issues.each do |issue|

826

issues.each do |issue|

827

issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)

827

issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)

828

end

828

end

829

end

829

end

830

end

830

end

831

832

# Preloads visible relations for a collection of issues

832

# Preloads visible relations for a collection of issues

833

def self.load_visible_relations(issues, user=User.current)

833

def self.load_visible_relations(issues, user=User.current)

834

if issues.any?

834

if issues.any?

835

issue_ids = issues.map(&:id)

835

issue_ids = issues.map(&:id)

836

# Relations with issue_from in given issues and visible issue_to

836

# Relations with issue_from in given issues and visible issue_to

837

relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all

837

relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all

838

# Relations with issue_to in given issues and visible issue_from

838

# Relations with issue_to in given issues and visible issue_from

839

relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all

839

relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all

840

841

issues.each do |issue|

841

issues.each do |issue|

842

relations =

842

relations =

843

relations_from.select {|relation| relation.issue_from_id == issue.id} +

843

relations_from.select {|relation| relation.issue_from_id == issue.id} +

844

relations_to.select {|relation| relation.issue_to_id == issue.id}

844

relations_to.select {|relation| relation.issue_to_id == issue.id}

845

846

issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)

846

issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)

847

end

847

end

848

end

848

end

849

end

849

end

850

851

# Finds an issue relation given its id.

851

# Finds an issue relation given its id.

852

def find_relation(relation_id)

852

def find_relation(relation_id)

853

IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])

853

IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])

854

end

854

end

855

856

# Returns all the other issues that depend on the issue

856

# Returns all the other issues that depend on the issue

857

def all_dependent_issues(except=[])

857

def all_dependent_issues(except=[])

858

except << self

858

except << self

859

dependencies = []

859

dependencies = []

860

dependencies += relations_from.map(&:issue_to)

860

dependencies += relations_from.map(&:issue_to)

861

dependencies += children unless leaf?

861

dependencies += children unless leaf?

862

dependencies << parent

863

dependencies.compact!

862

dependencies.compact!

864

dependencies -= except

863

dependencies -= except

865

dependencies + dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten

864

dependencies += dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten

865

if parent

866

dependencies << parent

867

dependencies += parent.all_dependent_issues(except + parent.descendants)

868

end

869

dependencies

866

end

870

end

867

871

868

# Returns an array of issues that duplicate this one

872

# Returns an array of issues that duplicate this one

869

def duplicates

873

def duplicates

870

relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}

874

relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}

871

end

875

end

872

876

873

# Returns the due date or the target due date if any

877

# Returns the due date or the target due date if any

874

# Used on gantt chart

878

# Used on gantt chart

875

def due_before

879

def due_before

876

due_date || (fixed_version ? fixed_version.effective_date : nil)

880

due_date || (fixed_version ? fixed_version.effective_date : nil)

877

end

881

end

878

882

879

# Returns the time scheduled for this issue.

883

# Returns the time scheduled for this issue.

880

#

884

#

881

# Example:

885

# Example:

882

# Start Date: 2/26/09, End Date: 3/04/09

886

# Start Date: 2/26/09, End Date: 3/04/09

883

# duration => 6

887

# duration => 6

884

def duration

888

def duration

885

(start_date && due_date) ? due_date - start_date : 0

889

(start_date && due_date) ? due_date - start_date : 0

886

end

890

end

887

891

888

# Returns the duration in working days

892

# Returns the duration in working days

889

def working_duration

893

def working_duration

890

(start_date && due_date) ? working_days(start_date, due_date) : 0

894

(start_date && due_date) ? working_days(start_date, due_date) : 0

891

end

895

end

892

896

893

def soonest_start(reload=false)

897

def soonest_start(reload=false)

894

@soonest_start = nil if reload

898

@soonest_start = nil if reload

895

@soonest_start ||= (

899

@soonest_start ||= (

896

relations_to(reload).collect{|relation| relation.successor_soonest_start} +

900

relations_to(reload).collect{|relation| relation.successor_soonest_start} +

897

[(@parent_issue || parent).try(:soonest_start)]

901

[(@parent_issue || parent).try(:soonest_start)]

898

).compact.max

902

).compact.max

899

end

903

end

900

904

901

# Sets start_date on the given date or the next working day

905

# Sets start_date on the given date or the next working day

902

# and changes due_date to keep the same working duration.

906

# and changes due_date to keep the same working duration.

903

def reschedule_on(date)

907

def reschedule_on(date)

904

wd = working_duration

908

wd = working_duration

905

date = next_working_date(date)

909

date = next_working_date(date)

906

self.start_date = date

910

self.start_date = date

907

self.due_date = add_working_days(date, wd)

911

self.due_date = add_working_days(date, wd)

908

end

912

end

909

913

910

# Reschedules the issue on the given date or the next working day and saves the record.

914

# Reschedules the issue on the given date or the next working day and saves the record.

911

# If the issue is a parent task, this is done by rescheduling its subtasks.

915

# If the issue is a parent task, this is done by rescheduling its subtasks.

912

def reschedule_on!(date)

916

def reschedule_on!(date)

913

return if date.nil?

917

return if date.nil?

914

if leaf?

918

if leaf?

915

if start_date.nil? || start_date != date

919

if start_date.nil? || start_date != date

916

if start_date && start_date > date

920

if start_date && start_date > date

917

# Issue can not be moved earlier than its soonest start date

921

# Issue can not be moved earlier than its soonest start date

918

date = [soonest_start(true), date].compact.max

922

date = [soonest_start(true), date].compact.max

919

end

923

end

920

reschedule_on(date)

924

reschedule_on(date)

921

begin

925

begin

922

save

926

save

923

rescue ActiveRecord::StaleObjectError

927

rescue ActiveRecord::StaleObjectError

924

reload

928

reload

925

reschedule_on(date)

929

reschedule_on(date)

926

save

930

save

927

end

931

end

928

end

932

end

929

else

933

else

930

leaves.each do |leaf|

934

leaves.each do |leaf|

931

if leaf.start_date

935

if leaf.start_date

932

# Only move subtask if it starts at the same date as the parent

936

# Only move subtask if it starts at the same date as the parent

933

# or if it starts before the given date

937

# or if it starts before the given date

934

if start_date == leaf.start_date || date > leaf.start_date

938

if start_date == leaf.start_date || date > leaf.start_date

935

leaf.reschedule_on!(date)

939

leaf.reschedule_on!(date)

936

end

940

end

937

else

941

else

938

leaf.reschedule_on!(date)

942

leaf.reschedule_on!(date)

939

end

943

end

940

end

944

end

941

end

945

end

942

end

946

end

943

947

944

def <=>(issue)

948

def <=>(issue)

945

if issue.nil?

949

if issue.nil?

946

-1

950

-1

947

elsif root_id != issue.root_id

951

elsif root_id != issue.root_id

948

(root_id || 0) <=> (issue.root_id || 0)

952

(root_id || 0) <=> (issue.root_id || 0)

949

else

953

else

950

(lft || 0) <=> (issue.lft || 0)

954

(lft || 0) <=> (issue.lft || 0)

951

end

955

end

952

end

956

end

953

957

954

def to_s

958

def to_s

955

"#{tracker} ##{id}: #{subject}"

959

"#{tracker} ##{id}: #{subject}"

956

end

960

end

957

961

958

# Returns a string of css classes that apply to the issue

962

# Returns a string of css classes that apply to the issue

959

def css_classes

963

def css_classes

960

s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"

964

s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"

961

s << ' closed' if closed?

965

s << ' closed' if closed?

962

s << ' overdue' if overdue?

966

s << ' overdue' if overdue?

963

s << ' child' if child?

967

s << ' child' if child?

964

s << ' parent' unless leaf?

968

s << ' parent' unless leaf?

965

s << ' private' if is_private?

969

s << ' private' if is_private?

966

s << ' created-by-me' if User.current.logged? && author_id == User.current.id

970

s << ' created-by-me' if User.current.logged? && author_id == User.current.id

967

s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id

971

s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id

968

s

972

s

969

end

973

end

970

974

971

# Saves an issue and a time_entry from the parameters

975

# Saves an issue and a time_entry from the parameters

972

def save_issue_with_child_records(params, existing_time_entry=nil)

976

def save_issue_with_child_records(params, existing_time_entry=nil)

973

Issue.transaction do

977

Issue.transaction do

974

if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)

978

if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)

975

@time_entry = existing_time_entry || TimeEntry.new

979

@time_entry = existing_time_entry || TimeEntry.new

976

@time_entry.project = project

980

@time_entry.project = project

977

@time_entry.issue = self

981

@time_entry.issue = self

978

@time_entry.user = User.current

982

@time_entry.user = User.current

979

@time_entry.spent_on = User.current.today

983

@time_entry.spent_on = User.current.today

980

@time_entry.attributes = params[:time_entry]

984

@time_entry.attributes = params[:time_entry]

981

self.time_entries << @time_entry

985

self.time_entries << @time_entry

982

end

986

end

983

987

984

# TODO: Rename hook

988

# TODO: Rename hook

985

Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

989

Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

986

if save

990

if save

987

# TODO: Rename hook

991

# TODO: Rename hook

988

Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

992

Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

989

else

993

else

990

raise ActiveRecord::Rollback

994

raise ActiveRecord::Rollback

991

end

995

end

992

end

996

end

993

end

997

end

994

998

995

# Unassigns issues from +version+ if it's no longer shared with issue's project

999

# Unassigns issues from +version+ if it's no longer shared with issue's project

996

def self.update_versions_from_sharing_change(version)

1000

def self.update_versions_from_sharing_change(version)

997

# Update issues assigned to the version

1001

# Update issues assigned to the version

998

update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])

1002

update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])

999

end

1003

end

1000

1004

1001

# Unassigns issues from versions that are no longer shared

1005

# Unassigns issues from versions that are no longer shared

1002

# after +project+ was moved

1006

# after +project+ was moved

1003

def self.update_versions_from_hierarchy_change(project)

1007

def self.update_versions_from_hierarchy_change(project)

1004

moved_project_ids = project.self_and_descendants.reload.collect(&:id)

1008

moved_project_ids = project.self_and_descendants.reload.collect(&:id)

1005

# Update issues of the moved projects and issues assigned to a version of a moved project

1009

# Update issues of the moved projects and issues assigned to a version of a moved project

1006

Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])

1010

Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])

1007

end

1011

end

1008

1012

1009

def parent_issue_id=(arg)

1013

def parent_issue_id=(arg)

1010

s = arg.to_s.strip.presence

1014

s = arg.to_s.strip.presence

1011

if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))

1015

if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))

1012

@parent_issue.id

1016

@parent_issue.id

1013

else

1017

else

1014

@parent_issue = nil

1018

@parent_issue = nil

1015

@invalid_parent_issue_id = arg

1019

@invalid_parent_issue_id = arg

1016

end

1020

end

1017

end

1021

end

1018

1022

1019

def parent_issue_id

1023

def parent_issue_id

1020

if @invalid_parent_issue_id

1024

if @invalid_parent_issue_id

1021

@invalid_parent_issue_id

1025

@invalid_parent_issue_id

1022

elsif instance_variable_defined? :@parent_issue

1026

elsif instance_variable_defined? :@parent_issue

1023

@parent_issue.nil? ? nil : @parent_issue.id

1027

@parent_issue.nil? ? nil : @parent_issue.id

1024

else

1028

else

1025

parent_id

1029

parent_id

1026

end

1030

end

1027

end

1031

end

1028

1032

1029

# Returns true if issue's project is a valid

1033

# Returns true if issue's project is a valid

1030

# parent issue project

1034

# parent issue project

1031

def valid_parent_project?(issue=parent)

1035

def valid_parent_project?(issue=parent)

1032

return true if issue.nil? || issue.project_id == project_id

1036

return true if issue.nil? || issue.project_id == project_id

1033

1037

1034

case Setting.cross_project_subtasks

1038

case Setting.cross_project_subtasks

1035

when 'system'

1039

when 'system'

1036

true

1040

true

1037

when 'tree'

1041

when 'tree'

1038

issue.project.root == project.root

1042

issue.project.root == project.root

1039

when 'hierarchy'

1043

when 'hierarchy'

1040

issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)

1044

issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)

1041

when 'descendants'

1045

when 'descendants'

1042

issue.project.is_or_is_ancestor_of?(project)

1046

issue.project.is_or_is_ancestor_of?(project)

1043

else

1047

else

1044

false

1048

false

1045

end

1049

end

1046

end

1050

end

1047

1051

1048

# Extracted from the ReportsController.

1052

# Extracted from the ReportsController.

1049

def self.by_tracker(project)

1053

def self.by_tracker(project)

1050

count_and_group_by(:project => project,

1054

count_and_group_by(:project => project,

1051

:field => 'tracker_id',

1055

:field => 'tracker_id',

1052

:joins => Tracker.table_name)

1056

:joins => Tracker.table_name)

1053

end

1057

end

1054

1058

1055

def self.by_version(project)

1059

def self.by_version(project)

1056

count_and_group_by(:project => project,

1060

count_and_group_by(:project => project,

1057

:field => 'fixed_version_id',

1061

:field => 'fixed_version_id',

1058

:joins => Version.table_name)

1062

:joins => Version.table_name)

1059

end

1063

end

1060

1064

1061

def self.by_priority(project)

1065

def self.by_priority(project)

1062

count_and_group_by(:project => project,

1066

count_and_group_by(:project => project,

1063

:field => 'priority_id',

1067

:field => 'priority_id',

1064

:joins => IssuePriority.table_name)

1068

:joins => IssuePriority.table_name)

1065

end

1069

end

1066

1070

1067

def self.by_category(project)

1071

def self.by_category(project)

1068

count_and_group_by(:project => project,

1072

count_and_group_by(:project => project,

1069

:field => 'category_id',

1073

:field => 'category_id',

1070

:joins => IssueCategory.table_name)

1074

:joins => IssueCategory.table_name)

1071

end

1075

end

1072

1076

1073

def self.by_assigned_to(project)

1077

def self.by_assigned_to(project)

1074

count_and_group_by(:project => project,

1078

count_and_group_by(:project => project,

1075

:field => 'assigned_to_id',

1079

:field => 'assigned_to_id',

1076

:joins => User.table_name)

1080

:joins => User.table_name)

1077

end

1081

end

1078

1082

1079

def self.by_author(project)

1083

def self.by_author(project)

1080

count_and_group_by(:project => project,

1084

count_and_group_by(:project => project,

1081

:field => 'author_id',

1085

:field => 'author_id',

1082

:joins => User.table_name)

1086

:joins => User.table_name)

1083

end

1087

end

1084

1088

1085

def self.by_subproject(project)

1089

def self.by_subproject(project)

1086

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1090

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1087

s.is_closed as closed,

1091

s.is_closed as closed,

1088

#{Issue.table_name}.project_id as project_id,

1092

#{Issue.table_name}.project_id as project_id,

1089

count(#{Issue.table_name}.id) as total

1093

count(#{Issue.table_name}.id) as total

1090

from

1094

from

1091

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s

1095

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s

1092

where

1096

where

1093

#{Issue.table_name}.status_id=s.id

1097

#{Issue.table_name}.status_id=s.id

1094

and #{Issue.table_name}.project_id = #{Project.table_name}.id

1098

and #{Issue.table_name}.project_id = #{Project.table_name}.id

1095

and #{visible_condition(User.current, :project => project, :with_subprojects => true)}

1099

and #{visible_condition(User.current, :project => project, :with_subprojects => true)}

1096

and #{Issue.table_name}.project_id <> #{project.id}

1100

and #{Issue.table_name}.project_id <> #{project.id}

1097

group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?

1101

group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?

1098

end

1102

end

1099

# End ReportsController extraction

1103

# End ReportsController extraction

1100

1104

1101

# Returns an array of projects that user can assign the issue to

1105

# Returns an array of projects that user can assign the issue to

1102

def allowed_target_projects(user=User.current)

1106

def allowed_target_projects(user=User.current)

1103

if new_record?

1107

if new_record?

1104

Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))

1108

Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))

1105

else

1109

else

1106

self.class.allowed_target_projects_on_move(user)

1110

self.class.allowed_target_projects_on_move(user)

1107

end

1111

end

1108

end

1112

end

1109

1113

1110

# Returns an array of projects that user can move issues to

1114

# Returns an array of projects that user can move issues to

1111

def self.allowed_target_projects_on_move(user=User.current)

1115

def self.allowed_target_projects_on_move(user=User.current)

1112

Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))

1116

Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))

1113

end

1117

end

1114

1118

1115

private

1119

private

1116

1120

1117

def after_project_change

1121

def after_project_change

1118

# Update project_id on related time entries

1122

# Update project_id on related time entries

1119

TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})

1123

TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})

1120

1124

1121

# Delete issue relations

1125

# Delete issue relations

1122

unless Setting.cross_project_issue_relations?

1126

unless Setting.cross_project_issue_relations?

1123

relations_from.clear

1127

relations_from.clear

1124

relations_to.clear

1128

relations_to.clear

1125

end

1129

end

1126

1130

1127

# Move subtasks that were in the same project

1131

# Move subtasks that were in the same project

1128

children.each do |child|

1132

children.each do |child|

1129

next unless child.project_id == project_id_was

1133

next unless child.project_id == project_id_was

1130

# Change project and keep project

1134

# Change project and keep project

1131

child.send :project=, project, true

1135

child.send :project=, project, true

1132

unless child.save

1136

unless child.save

1133

raise ActiveRecord::Rollback

1137

raise ActiveRecord::Rollback

1134

end

1138

end

1135

end

1139

end

1136

end

1140

end

1137

1141

1138

# Callback for after the creation of an issue by copy

1142

# Callback for after the creation of an issue by copy

1139

# * adds a "copied to" relation with the copied issue

1143

# * adds a "copied to" relation with the copied issue

1140

# * copies subtasks from the copied issue

1144

# * copies subtasks from the copied issue

1141

def after_create_from_copy

1145

def after_create_from_copy

1142

return unless copy? && !@after_create_from_copy_handled

1146

return unless copy? && !@after_create_from_copy_handled

1143

1147

1144

if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false

1148

if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false

1145

relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)

1149

relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)

1146

unless relation.save

1150

unless relation.save

1147

logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger

1151

logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger

1148

end

1152

end

1149

end

1153

end

1150

1154

1151

unless @copied_from.leaf? || @copy_options[:subtasks] == false

1155

unless @copied_from.leaf? || @copy_options[:subtasks] == false

1152

copy_options = (@copy_options || {}).merge(:subtasks => false)

1156

copy_options = (@copy_options || {}).merge(:subtasks => false)

1153

copied_issue_ids = {@copied_from.id => self.id}

1157

copied_issue_ids = {@copied_from.id => self.id}

1154

@copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|

1158

@copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|

1155

# Do not copy self when copying an issue as a descendant of the copied issue

1159

# Do not copy self when copying an issue as a descendant of the copied issue

1156

next if child == self

1160

next if child == self

1157

# Do not copy subtasks of issues that were not copied

1161

# Do not copy subtasks of issues that were not copied

1158

next unless copied_issue_ids[child.parent_id]

1162

next unless copied_issue_ids[child.parent_id]

1159

# Do not copy subtasks that are not visible to avoid potential disclosure of private data

1163

# Do not copy subtasks that are not visible to avoid potential disclosure of private data

1160

unless child.visible?

1164

unless child.visible?

1161

logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger

1165

logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger

1162

end

1167

end

1164

copy = Issue.new.copy_from(child, copy_options)

1168

copy = Issue.new.copy_from(child, copy_options)

1165

copy.author = author

1169

copy.author = author

1166

copy.project = project

1170

copy.project = project

1167

copy.parent_issue_id = copied_issue_ids[child.parent_id]

1171

copy.parent_issue_id = copied_issue_ids[child.parent_id]

1168

unless copy.save

1172

unless copy.save

1169

logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger

1173

logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger

1170

end

1175

end

1172

copied_issue_ids[child.id] = copy.id

1176

copied_issue_ids[child.id] = copy.id

1173

end

1177

end

1174

end

1178

end

1175

@after_create_from_copy_handled = true

1179

@after_create_from_copy_handled = true

1176

end

1180

end

1177

1181

1178

def update_nested_set_attributes

1182

def update_nested_set_attributes

1179

if root_id.nil?

1183

if root_id.nil?

1180

# issue was just created

1184

# issue was just created

1181

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)

1185

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)

1182

set_default_left_and_right

1186

set_default_left_and_right

1183

Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])

1187

Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])

1184

if @parent_issue

1188

if @parent_issue

1185

move_to_child_of(@parent_issue)

1189

move_to_child_of(@parent_issue)

1186

end

1190

end

1187

reload

1191

reload

1188

elsif parent_issue_id != parent_id

1192

elsif parent_issue_id != parent_id

1189

former_parent_id = parent_id

1193

former_parent_id = parent_id

1190

# moving an existing issue

1194

# moving an existing issue

1191

if @parent_issue && @parent_issue.root_id == root_id

1195

if @parent_issue && @parent_issue.root_id == root_id

1192

# inside the same tree

1196

# inside the same tree

1193

move_to_child_of(@parent_issue)

1197

move_to_child_of(@parent_issue)

1194

else

1198

else

1195

# to another tree

1199

# to another tree

1196

unless root?

1200

unless root?

1197

move_to_right_of(root)

1201

move_to_right_of(root)

1198

reload

1202

reload

1199

end

1203

end

1200

old_root_id = root_id

1204

old_root_id = root_id

1201

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )

1205

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )

1202

target_maxright = nested_set_scope.maximum(right_column_name) || 0

1206

target_maxright = nested_set_scope.maximum(right_column_name) || 0

1203

offset = target_maxright + 1 - lft

1207

offset = target_maxright + 1 - lft

1204

Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",

1208

Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",

1205

["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])

1209

["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])

1206

self[left_column_name] = lft + offset

1210

self[left_column_name] = lft + offset

1207

self[right_column_name] = rgt + offset

1211

self[right_column_name] = rgt + offset

1208

if @parent_issue

1212

if @parent_issue

1209

move_to_child_of(@parent_issue)

1213

move_to_child_of(@parent_issue)

1210

end

1214

end

1211

end

1215

end

1212

reload

1216

reload

1213

# delete invalid relations of all descendants

1217

# delete invalid relations of all descendants

1214

self_and_descendants.each do |issue|

1218

self_and_descendants.each do |issue|

1215

issue.relations.each do |relation|

1219

issue.relations.each do |relation|

1216

relation.destroy unless relation.valid?

1220

relation.destroy unless relation.valid?

1217

end

1221

end

1218

end

1222

end

1219

# update former parent

1223

# update former parent

1220

recalculate_attributes_for(former_parent_id) if former_parent_id

1224

recalculate_attributes_for(former_parent_id) if former_parent_id

1221

end

1225

end

1222

remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)

1226

remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)

1223

end

1227

end

1224

1228

1225

def update_parent_attributes

1229

def update_parent_attributes

1226

recalculate_attributes_for(parent_id) if parent_id

1230

recalculate_attributes_for(parent_id) if parent_id

1227

end

1231

end

1228

1232

1229

def recalculate_attributes_for(issue_id)

1233

def recalculate_attributes_for(issue_id)

1230

if issue_id && p = Issue.find_by_id(issue_id)

1234

if issue_id && p = Issue.find_by_id(issue_id)

1231

# priority = highest priority of children

1235

# priority = highest priority of children

1232

if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)

1236

if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)

1233

p.priority = IssuePriority.find_by_position(priority_position)

1237

p.priority = IssuePriority.find_by_position(priority_position)

1234

end

1238

end

1235

1239

1236

# start/due dates = lowest/highest dates of children

1240

# start/due dates = lowest/highest dates of children

1237

p.start_date = p.children.minimum(:start_date)

1241

p.start_date = p.children.minimum(:start_date)

1238

p.due_date = p.children.maximum(:due_date)

1242

p.due_date = p.children.maximum(:due_date)

1239

if p.start_date && p.due_date && p.due_date < p.start_date

1243

if p.start_date && p.due_date && p.due_date < p.start_date

1240

p.start_date, p.due_date = p.due_date, p.start_date

1244

p.start_date, p.due_date = p.due_date, p.start_date

1241

end

1245

end

1242

1246

1243

# done ratio = weighted average ratio of leaves

1247

# done ratio = weighted average ratio of leaves

1244

unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio

1248

unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio

1245

leaves_count = p.leaves.count

1249

leaves_count = p.leaves.count

1246

if leaves_count > 0

1250

if leaves_count > 0

1247

average = p.leaves.average(:estimated_hours).to_f

1251

average = p.leaves.average(:estimated_hours).to_f

1248

if average == 0

1252

if average == 0

1249

average = 1

1253

average = 1

1250

end

1254

end

1251

done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f

1255

done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f

1252

progress = done / (average * leaves_count)

1256

progress = done / (average * leaves_count)

1253

p.done_ratio = progress.round

1257

p.done_ratio = progress.round

1254

end

1258

end

1255

end

1259

end

1256

1260

1257

# estimate = sum of leaves estimates

1261

# estimate = sum of leaves estimates

1258

p.estimated_hours = p.leaves.sum(:estimated_hours).to_f

1262

p.estimated_hours = p.leaves.sum(:estimated_hours).to_f

1259

p.estimated_hours = nil if p.estimated_hours == 0.0

1263

p.estimated_hours = nil if p.estimated_hours == 0.0

1260

1264

1261

# ancestors will be recursively updated

1265

# ancestors will be recursively updated

1262

p.save(:validate => false)

1266

p.save(:validate => false)

1263

end

1267

end

1264

end

1268

end

1265

1269

1266

# Update issues so their versions are not pointing to a

1270

# Update issues so their versions are not pointing to a

1267

# fixed_version that is not shared with the issue's project

1271

# fixed_version that is not shared with the issue's project

1268

def self.update_versions(conditions=nil)

1272

def self.update_versions(conditions=nil)

1269

# Only need to update issues with a fixed_version from

1273

# Only need to update issues with a fixed_version from

1270

# a different project and that is not systemwide shared

1274

# a different project and that is not systemwide shared

1271

Issue.scoped(:conditions => conditions).all(

1275

Issue.scoped(:conditions => conditions).all(

1272

:conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +

1276

:conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +

1273

" AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +

1277

" AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +

1274

" AND #{Version.table_name}.sharing <> 'system'",

1278

" AND #{Version.table_name}.sharing <> 'system'",

1275

:include => [:project, :fixed_version]

1279

:include => [:project, :fixed_version]

1276

).each do |issue|

1280

).each do |issue|

1277

next if issue.project.nil? || issue.fixed_version.nil?

1281

next if issue.project.nil? || issue.fixed_version.nil?

1278

unless issue.project.shared_versions.include?(issue.fixed_version)

1282

unless issue.project.shared_versions.include?(issue.fixed_version)

1279

issue.init_journal(User.current)

1283

issue.init_journal(User.current)

1280

issue.fixed_version = nil

1284

issue.fixed_version = nil

1281

issue.save

1285

issue.save

1282

end

1286

end

1283

end

1287

end

1284

end

1288

end

1285

1289

1286

# Callback on file attachment

1290

# Callback on file attachment

1287

def attachment_added(obj)

1291

def attachment_added(obj)

1288

if @current_journal && !obj.new_record?

1292

if @current_journal && !obj.new_record?

1289

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)

1293

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)

1290

end

1294

end

1291

end

1295

end

1292

1296

1293

# Callback on attachment deletion

1297

# Callback on attachment deletion

1294

def attachment_removed(obj)

1298

def attachment_removed(obj)

1295

if @current_journal && !obj.new_record?

1299

if @current_journal && !obj.new_record?

1296

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)

1300

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)

1297

@current_journal.save

1301

@current_journal.save

1298

end

1302

end

1299

end

1303

end

1300

1304

1301

# Default assignment based on category

1305

# Default assignment based on category

1302

def default_assign

1306

def default_assign

1303

if assigned_to.nil? && category && category.assigned_to

1307

if assigned_to.nil? && category && category.assigned_to

1304

self.assigned_to = category.assigned_to

1308

self.assigned_to = category.assigned_to

1305

end

1309

end

1306

end

1310

end

1307

1311

1308

# Updates start/due dates of following issues

1312

# Updates start/due dates of following issues

1309

def reschedule_following_issues

1313

def reschedule_following_issues

1310

if start_date_changed? || due_date_changed?

1314

if start_date_changed? || due_date_changed?

1311

relations_from.each do |relation|

1315

relations_from.each do |relation|

1312

relation.set_issue_to_dates

1316

relation.set_issue_to_dates

1313

end

1317

end

1314

end

1318

end

1315

end

1319

end

1316

1320

1317

# Closes duplicates if the issue is being closed

1321

# Closes duplicates if the issue is being closed

1318

def close_duplicates

1322

def close_duplicates

1319

if closing?

1323

if closing?

1320

duplicates.each do |duplicate|

1324

duplicates.each do |duplicate|

1321

# Reload is need in case the duplicate was updated by a previous duplicate

1325

# Reload is need in case the duplicate was updated by a previous duplicate

1322

duplicate.reload

1326

duplicate.reload

1323

# Don't re-close it if it's already closed

1327

# Don't re-close it if it's already closed

1324

next if duplicate.closed?

1328

next if duplicate.closed?

1325

# Same user and notes

1329

# Same user and notes

1326

if @current_journal

1330

if @current_journal

1327

duplicate.init_journal(@current_journal.user, @current_journal.notes)

1331

duplicate.init_journal(@current_journal.user, @current_journal.notes)

1328

end

1332

end

1329

duplicate.update_attribute :status, self.status

1333

duplicate.update_attribute :status, self.status

1330

end

1334

end

1331

end

1335

end

1332

end

1336

end

1333

1337

1334

# Make sure updated_on is updated when adding a note and set updated_on now

1338

# Make sure updated_on is updated when adding a note and set updated_on now

1335

# so we can set closed_on with the same value on closing

1339

# so we can set closed_on with the same value on closing

1336

def force_updated_on_change

1340

def force_updated_on_change

1337

if @current_journal || changed?

1341

if @current_journal || changed?

1338

self.updated_on = current_time_from_proper_timezone

1342

self.updated_on = current_time_from_proper_timezone

1339

if new_record?

1343

if new_record?

1340

self.created_on = updated_on

1344

self.created_on = updated_on

1341

end

1345

end

1342

end

1346

end

1343

end

1347

end

1344

1348

1345

# Callback for setting closed_on when the issue is closed.

1349

# Callback for setting closed_on when the issue is closed.

1346

# The closed_on attribute stores the time of the last closing

1350

# The closed_on attribute stores the time of the last closing

1347

# and is preserved when the issue is reopened.

1351

# and is preserved when the issue is reopened.

1348

def update_closed_on

1352

def update_closed_on

1349

if closing? || (new_record? && closed?)

1353

if closing? || (new_record? && closed?)

1350

self.closed_on = updated_on

1354

self.closed_on = updated_on

1351

end

1355

end

1352

end

1356

end

1353

1357

1354

# Saves the changes in a Journal

1358

# Saves the changes in a Journal

1355

# Called after_save

1359

# Called after_save

1356

def create_journal

1360

def create_journal

1357

if @current_journal

1361

if @current_journal

1358

# attributes changes

1362

# attributes changes

1359

if @attributes_before_change

1363

if @attributes_before_change

1360

(Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|

1364

(Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|

1361

before = @attributes_before_change[c]

1365

before = @attributes_before_change[c]

1362

after = send(c)

1366

after = send(c)

1363

next if before == after || (before.blank? && after.blank?)

1367

next if before == after || (before.blank? && after.blank?)

1364

@current_journal.details << JournalDetail.new(:property => 'attr',

1368

@current_journal.details << JournalDetail.new(:property => 'attr',

1365

:prop_key => c,

1369

:prop_key => c,

1366

:old_value => before,

1370

:old_value => before,

1367

:value => after)

1371

:value => after)

1368

}

1372

}

1369

end

1373

end

1370

if @custom_values_before_change

1374

if @custom_values_before_change

1371

# custom fields changes

1375

# custom fields changes

1372

custom_field_values.each {|c|

1376

custom_field_values.each {|c|

1373

before = @custom_values_before_change[c.custom_field_id]

1377

before = @custom_values_before_change[c.custom_field_id]

1374

after = c.value

1378

after = c.value

1375

next if before == after || (before.blank? && after.blank?)

1379

next if before == after || (before.blank? && after.blank?)

1376

1380

1377

if before.is_a?(Array) || after.is_a?(Array)

1381

if before.is_a?(Array) || after.is_a?(Array)

1378

before = [before] unless before.is_a?(Array)

1382

before = [before] unless before.is_a?(Array)

1379

after = [after] unless after.is_a?(Array)

1383

after = [after] unless after.is_a?(Array)

1380

1384

1381

# values removed

1385

# values removed

1382

(before - after).reject(&:blank?).each do |value|

1386

(before - after).reject(&:blank?).each do |value|

1383

@current_journal.details << JournalDetail.new(:property => 'cf',

1387

@current_journal.details << JournalDetail.new(:property => 'cf',

1384

:prop_key => c.custom_field_id,

1388

:prop_key => c.custom_field_id,

1385

:old_value => value,

1389

:old_value => value,

1386

:value => nil)

1390

:value => nil)

1387

end

1391

end

1388

# values added

1392

# values added

1389

(after - before).reject(&:blank?).each do |value|

1393

(after - before).reject(&:blank?).each do |value|

1390

@current_journal.details << JournalDetail.new(:property => 'cf',

1394

@current_journal.details << JournalDetail.new(:property => 'cf',

1391

:prop_key => c.custom_field_id,

1395

:prop_key => c.custom_field_id,

1392

:old_value => nil,

1396

:old_value => nil,

1393

:value => value)

1397

:value => value)

1394

end

1398

end

1395

else

1399

else

1396

@current_journal.details << JournalDetail.new(:property => 'cf',

1400

@current_journal.details << JournalDetail.new(:property => 'cf',

1397

:prop_key => c.custom_field_id,

1401

:prop_key => c.custom_field_id,

1398

:old_value => before,

1402

:old_value => before,

1399

:value => after)

1403

:value => after)

1400

end

1404

end

1401

}

1405

}

1402

end

1406

end

1403

@current_journal.save

1407

@current_journal.save

1404

# reset current journal

1408

# reset current journal

1405

init_journal @current_journal.user, @current_journal.notes

1409

init_journal @current_journal.user, @current_journal.notes

1406

end

1410

end

1407

end

1411

end

1408

1412

1409

# Query generator for selecting groups of issue counts for a project

1413

# Query generator for selecting groups of issue counts for a project

1410

# based on specific criteria

1414

# based on specific criteria

1411

#

1415

#

1412

# Options

1416

# Options

1413

# * project - Project to search in.

1417

# * project - Project to search in.

1414

# * field - String. Issue field to key off of in the grouping.

1418

# * field - String. Issue field to key off of in the grouping.

1415

# * joins - String. The table name to join against.

1419

# * joins - String. The table name to join against.

1416

def self.count_and_group_by(options)

1420

def self.count_and_group_by(options)

1417

project = options.delete(:project)

1421

project = options.delete(:project)

1418

select_field = options.delete(:field)

1422

select_field = options.delete(:field)

1419

joins = options.delete(:joins)

1423

joins = options.delete(:joins)

1420

1424

1421

where = "#{Issue.table_name}.#{select_field}=j.id"

1425

where = "#{Issue.table_name}.#{select_field}=j.id"

1422

1426

1423

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1427

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1424

s.is_closed as closed,

1428

s.is_closed as closed,

1425

j.id as #{select_field},

1429

j.id as #{select_field},

1426

count(#{Issue.table_name}.id) as total

1430

count(#{Issue.table_name}.id) as total

1427

from

1431

from

1428

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j

1432

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j

1429

where

1433

where

1430

#{Issue.table_name}.status_id=s.id

1434

#{Issue.table_name}.status_id=s.id

1431

and #{where}

1435

and #{where}

1432

and #{Issue.table_name}.project_id=#{Project.table_name}.id

1436

and #{Issue.table_name}.project_id=#{Project.table_name}.id

1433

and #{visible_condition(User.current, :project => project)}

1437

and #{visible_condition(User.current, :project => project)}

1434

group by s.id, s.is_closed, j.id")

1438

group by s.id, s.is_closed, j.id")

1435

end

1439

end

1436

end

1440

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Issue < ActiveRecord::Base
               include Redmine::SafeAttributes
               include Redmine::Utils::DateCalculation
               belongs_to :project
               belongs_to :tracker
               belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
               belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
               belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
               belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
               belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
               belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
               has_many :journals, :as => :journalized, :dependent => :destroy
               has_many :visible_journals,
                 :class_name => 'Journal',
                 :as => :journalized,
                 :conditions => Proc.new {
                   ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
                 },
                 :readonly => true
               has_many :time_entries, :dependent => :delete_all
               has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
               has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
               has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
               acts_as_nested_set :scope => 'root_id', :dependent => :destroy
               acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
               acts_as_customizable
               acts_as_watchable
               acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                  :include => [:project, :visible_journals],
                                  # sort by id so that limited eager loading doesn't break with postgresql
                                  :order_column => "#{table_name}.id"
               acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                             :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                             :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
               acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                         :author_key => :author_id
               DONE_RATIO_OPTIONS = %w(issue_field issue_status)
               attr_reader :current_journal
               delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
               validates_presence_of :subject, :priority, :project, :tracker, :author, :status
               validates_length_of :subject, :maximum => 255
               validates_inclusion_of :done_ratio, :in => 0..100
               validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
               validates :start_date, :date => true
               validates :due_date, :date => true
               validate :validate_issue, :validate_required_fields
               scope :visible, lambda {|*args|
                 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
               }
               scope :open, lambda {|*args|
                 is_closed = args.size > 0 ? !args.first : false
                 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
               }
               scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
               scope :on_active_project, lambda {
                 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
               }
               scope :fixed_version, lambda {|versions|
                 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
                 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
               }
               before_create :default_assign
               before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
               after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
               after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
               # Should be after_create but would be called before previous after_save callbacks
               after_save :after_create_from_copy
               after_destroy :update_parent_attributes
               # Returns a SQL conditions string used to find all issues visible by the specified user
               def self.visible_condition(user, options={})
                 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                   if user.logged?
                     case role.issues_visibility
                     when 'all'
                       nil
                     when 'default'
                       user_ids = [user.id] + user.groups.map(&:id)
                       "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                     when 'own'
                       user_ids = [user.id] + user.groups.map(&:id)
                       "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                     else
                       '1=0'
                     end
                   else
                     "(#{table_name}.is_private = #{connection.quoted_false})"
                   end
                 end
               end
               # Returns true if usr or current user is allowed to view the issue
               def visible?(usr=nil)
                 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                   if user.logged?
                     case role.issues_visibility
                     when 'all'
                       true
                     when 'default'
                       !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
                     when 'own'
                       self.author == user || user.is_or_belongs_to?(assigned_to)
                     else
                       false
                     end
                   else
                     !self.is_private?
                   end
                 end
               end
               # Returns true if user or current user is allowed to edit or add a note to the issue
               def editable?(user=User.current)
                 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
               end
               def initialize(attributes=nil, *args)
                 super
                 if new_record?
                   # set default values for new records only
                   self.status ||= IssueStatus.default
                   self.priority ||= IssuePriority.default
                   self.watcher_user_ids = []
                 end
               end
               def create_or_update
                 super
               ensure
                 @status_was = nil
               end
               private :create_or_update
               # AR#Persistence#destroy would raise and RecordNotFound exception
               # if the issue was already deleted or updated (non matching lock_version).
               # This is a problem when bulk deleting issues or deleting a project
               # (because an issue may already be deleted if its parent was deleted
               # first).
               # The issue is reloaded by the nested_set before being deleted so
               # the lock_version condition should not be an issue but we handle it.
               def destroy
                 super
               rescue ActiveRecord::RecordNotFound
                 # Stale or already deleted
                 begin
                   reload
                 rescue ActiveRecord::RecordNotFound
                   # The issue was actually already deleted
                   @destroyed = true
                   return freeze
                 end
                 # The issue was stale, retry to destroy
                 super
               end
               alias :base_reload :reload
               def reload(*args)
                 @workflow_rule_by_attribute = nil
                 @assignable_versions = nil
                 @relations = nil
                 base_reload(*args)
               end
               # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
               def available_custom_fields
                 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
               end
               # Copies attributes from another issue, arg can be an id or an Issue
               def copy_from(arg, options={})
                 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                 self.status = issue.status
                 self.author = User.current
                 unless options[:attachments] == false
                   self.attachments = issue.attachments.map do |attachement|
                     attachement.copy(:container => self)
                   end
                 end
                 @copied_from = issue
                 @copy_options = options
                 self
               end
               # Returns an unsaved copy of the issue
               def copy(attributes=nil, copy_options={})
                 copy = self.class.new.copy_from(self, copy_options)
                 copy.attributes = attributes if attributes
                 copy
               end
               # Returns true if the issue is a copy
               def copy?
                 @copied_from.present?
               end
               # Moves/copies an issue to a new project and tracker
               # Returns the moved/copied issue on success, false on failure
               def move_to_project(new_project, new_tracker=nil, options={})
                 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
                 if options[:copy]
                   issue = self.copy
                 else
                   issue = self
                 end
                 issue.init_journal(User.current, options[:notes])
                 # Preserve previous behaviour
                 # #move_to_project doesn't change tracker automatically
                 issue.send :project=, new_project, true
                 if new_tracker
                   issue.tracker = new_tracker
                 end
                 # Allow bulk setting of attributes on the issue
                 if options[:attributes]
                   issue.attributes = options[:attributes]
                 end
                 issue.save ? issue : false
               end
               def status_id=(sid)
                 self.status = nil
                 result = write_attribute(:status_id, sid)
                 @workflow_rule_by_attribute = nil
                 result
               end
               def priority_id=(pid)
                 self.priority = nil
                 write_attribute(:priority_id, pid)
               end
               def category_id=(cid)
                 self.category = nil
                 write_attribute(:category_id, cid)
               end
               def fixed_version_id=(vid)
                 self.fixed_version = nil
                 write_attribute(:fixed_version_id, vid)
               end
               def tracker_id=(tid)
                 self.tracker = nil
                 result = write_attribute(:tracker_id, tid)
                 @custom_field_values = nil
                 @workflow_rule_by_attribute = nil
                 result
               end
               def project_id=(project_id)
                 if project_id.to_s != self.project_id.to_s
                   self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
                 end
               end
               def project=(project, keep_tracker=false)
                 project_was = self.project
                 write_attribute(:project_id, project ? project.id : nil)
                 association_instance_set('project', project)
                 if project_was && project && project_was != project
                   @assignable_versions = nil
                   unless keep_tracker || project.trackers.include?(tracker)
                     self.tracker = project.trackers.first
                   end
                   # Reassign to the category with same name if any
                   if category
                     self.category = project.issue_categories.find_by_name(category.name)
                   end
                   # Keep the fixed_version if it's still valid in the new_project
                   if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
                     self.fixed_version = nil
                   end
                   # Clear the parent task if it's no longer valid
                   unless valid_parent_project?
                     self.parent_issue_id = nil
                   end
                   @custom_field_values = nil
                 end
               end
               def description=(arg)
                 if arg.is_a?(String)
                   arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                 end
                 write_attribute(:description, arg)
               end
               # Overrides assign_attributes so that project and tracker get assigned first
               def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
                 return if new_attributes.nil?
                 attrs = new_attributes.dup
                 attrs.stringify_keys!
                 %w(project project_id tracker tracker_id).each do |attr|
                   if attrs.has_key?(attr)
                     send "#{attr}=", attrs.delete(attr)
                   end
                 end
                 send :assign_attributes_without_project_and_tracker_first, attrs, *args
               end
               # Do not redefine alias chain on reload (see #4838)
               alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
               def estimated_hours=(h)
                 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
               end
               safe_attributes 'project_id',
                 :if => lambda {|issue, user|
                   if issue.new_record?
                     issue.copy?
                   elsif user.allowed_to?(:move_issues, issue.project)
                     projects = Issue.allowed_target_projects_on_move(user)
                     projects.include?(issue.project) && projects.size > 1
                   end
                 }
               safe_attributes 'tracker_id',
                 'status_id',
                 'category_id',
                 'assigned_to_id',
                 'priority_id',
                 'fixed_version_id',
                 'subject',
                 'description',
                 'start_date',
                 'due_date',
                 'done_ratio',
                 'estimated_hours',
                 'custom_field_values',
                 'custom_fields',
                 'lock_version',
                 'notes',
                 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
               safe_attributes 'status_id',
                 'assigned_to_id',
                 'fixed_version_id',
                 'done_ratio',
                 'lock_version',
                 'notes',
                 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
               safe_attributes 'notes',
                 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
               safe_attributes 'private_notes',
                 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
               safe_attributes 'watcher_user_ids',
                 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
               safe_attributes 'is_private',
                 :if => lambda {|issue, user|
                   user.allowed_to?(:set_issues_private, issue.project) ||
                     (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                 }
               safe_attributes 'parent_issue_id',
                 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                   user.allowed_to?(:manage_subtasks, issue.project)}
               def safe_attribute_names(user=nil)
                 names = super
                 names -= disabled_core_fields
                 names -= read_only_attribute_names(user)
                 names
               end
               # Safely sets attributes
               # Should be called from controllers instead of #attributes=
               # attr_accessible is too rough because we still want things like
               # Issue.new(:project => foo) to work
               def safe_attributes=(attrs, user=User.current)
                 return unless attrs.is_a?(Hash)
                 attrs = attrs.dup
                 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
                   if allowed_target_projects(user).collect(&:id).include?(p.to_i)
                     self.project_id = p
                   end
                 end
                 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
                   self.tracker_id = t
                 end
                 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
                   if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
                     self.status_id = s
                   end
                 end
                 attrs = delete_unsafe_attributes(attrs, user)
                 return if attrs.empty?
                 unless leaf?
                   attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                 end
                 if attrs['parent_issue_id'].present?
                   s = attrs['parent_issue_id'].to_s
                   unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
                     @invalid_parent_issue_id = attrs.delete('parent_issue_id')
                   end
                 end
                 if attrs['custom_field_values'].present?
                   attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
                 end
                 if attrs['custom_fields'].present?
                   attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
                 end
                 # mass-assignment security bypass
                 assign_attributes attrs, :without_protection => true
               end
               def disabled_core_fields
                 tracker ? tracker.disabled_core_fields : []
               end
               # Returns the custom_field_values that can be edited by the given user
               def editable_custom_field_values(user=nil)
                 custom_field_values.reject do |value|
                   read_only_attribute_names(user).include?(value.custom_field_id.to_s)
                 end
               end
               # Returns the names of attributes that are read-only for user or the current user
               # For users with multiple roles, the read-only fields are the intersection of
               # read-only fields of each role
               # The result is an array of strings where sustom fields are represented with their ids
               #
               # Examples:
               #   issue.read_only_attribute_names # => ['due_date', '2']
               #   issue.read_only_attribute_names(user) # => []
               def read_only_attribute_names(user=nil)
                 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
               end
               # Returns the names of required attributes for user or the current user
               # For users with multiple roles, the required fields are the intersection of
               # required fields of each role
               # The result is an array of strings where sustom fields are represented with their ids
               #
               # Examples:
               #   issue.required_attribute_names # => ['due_date', '2']
               #   issue.required_attribute_names(user) # => []
               def required_attribute_names(user=nil)
                 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
               end
               # Returns true if the attribute is required for user
               def required_attribute?(name, user=nil)
                 required_attribute_names(user).include?(name.to_s)
               end
               # Returns a hash of the workflow rule by attribute for the given user
               #
               # Examples:
               #   issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
               def workflow_rule_by_attribute(user=nil)
                 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
                 user_real = user || User.current
                 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
                 return {} if roles.empty?
                 result = {}
                 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
                 if workflow_permissions.any?
                   workflow_rules = workflow_permissions.inject({}) do |h, wp|
                     h[wp.field_name] ||= []
                     h[wp.field_name] << wp.rule
                     h
                   end
                   workflow_rules.each do |attr, rules|
                     next if rules.size < roles.size
                     uniq_rules = rules.uniq
                     if uniq_rules.size == 1
                       result[attr] = uniq_rules.first
                     else
                       result[attr] = 'required'
                     end
                   end
                 end
                 @workflow_rule_by_attribute = result if user.nil?
                 result
               end
               private :workflow_rule_by_attribute
               def done_ratio
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   status.default_done_ratio
                 else
                   read_attribute(:done_ratio)
                 end
               end
               def self.use_status_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_status'
               end
               def self.use_field_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_field'
               end
               def validate_issue
                 if due_date && start_date && due_date < start_date
                   errors.add :due_date, :greater_than_start_date
                 end
                 if start_date && soonest_start && start_date < soonest_start
                   errors.add :start_date, :invalid
                 end
                 if fixed_version
                   if !assignable_versions.include?(fixed_version)
                     errors.add :fixed_version_id, :inclusion
                   elsif reopened? && fixed_version.closed?
                     errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                   end
                 end
                 # Checks that the issue can not be added/moved to a disabled tracker
                 if project && (tracker_id_changed? || project_id_changed?)
                   unless project.trackers.include?(tracker)
                     errors.add :tracker_id, :inclusion
                   end
                 end
                 # Checks parent issue assignment
                 if @invalid_parent_issue_id.present?
                   errors.add :parent_issue_id, :invalid
                 elsif @parent_issue
                   if !valid_parent_project?(@parent_issue)
                     errors.add :parent_issue_id, :invalid
                   elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
                     errors.add :parent_issue_id, :invalid
                   elsif !new_record?
                     # moving an existing issue
                     if @parent_issue.root_id != root_id
                       # we can always move to another tree
                     elsif move_possible?(@parent_issue)
                       # move accepted inside tree
                     else
                       errors.add :parent_issue_id, :invalid
                     end
                   end
                 end
               end
               # Validates the issue against additional workflow requirements
               def validate_required_fields
                 user = new_record? ? author : current_journal.try(:user)
                 required_attribute_names(user).each do |attribute|
                   if attribute =~ /^\d+$/
                     attribute = attribute.to_i
                     v = custom_field_values.detect {|v| v.custom_field_id == attribute }
                     if v && v.value.blank?
                       errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
                     end
                   else
                     if respond_to?(attribute) && send(attribute).blank?
                       errors.add attribute, :blank
                     end
                   end
                 end
               end
               # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
               # even if the user turns off the setting later
               def update_done_ratio_from_issue_status
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   self.done_ratio = status.default_done_ratio
                 end
               end
               def init_journal(user, notes = "")
                 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                 if new_record?
                   @current_journal.notify = false
                 else
                   @attributes_before_change = attributes.dup
                   @custom_values_before_change = {}
                   self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                 end
                 @current_journal
               end
               # Returns the id of the last journal or nil
               def last_journal_id
                 if new_record?
                   nil
                 else
                   journals.maximum(:id)
                 end
               end
               # Returns a scope for journals that have an id greater than journal_id
               def journals_after(journal_id)
                 scope = journals.reorder("#{Journal.table_name}.id ASC")
                 if journal_id.present?
                   scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
                 end
                 scope
               end
               # Returns the initial status of the issue
               # Returns nil for a new issue
               def status_was
                 if status_id_was && status_id_was.to_i > 0
                   @status_was ||= IssueStatus.find_by_id(status_id_was)
                 end
               end
               # Return true if the issue is closed, otherwise false
               def closed?
                 self.status.is_closed?
               end
               # Return true if the issue is being reopened
               def reopened?
                 if !new_record? && status_id_changed?
                   status_was = IssueStatus.find_by_id(status_id_was)
                   status_new = IssueStatus.find_by_id(status_id)
                   if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Return true if the issue is being closed
               def closing?
                 if !new_record? && status_id_changed?
                   if status_was && status && !status_was.is_closed? && status.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Returns true if the issue is overdue
               def overdue?
                 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
               end
               # Is the amount of work done less than it should for the due date
               def behind_schedule?
                 return false if start_date.nil? || due_date.nil?
                 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                 return done_date <= Date.today
               end
               # Does this issue have children?
               def children?
                 !leaf?
               end
               # Users the issue can be assigned to
               def assignable_users
                 users = project.assignable_users
                 users << author if author
                 users << assigned_to if assigned_to
                 users.uniq.sort
               end
               # Versions that the issue can be assigned to
               def assignable_versions
                 return @assignable_versions if @assignable_versions
                 versions = project.shared_versions.open.all
                 if fixed_version
                   if fixed_version_id_changed?
                     # nothing to do
                   elsif project_id_changed?
                     if project.shared_versions.include?(fixed_version)
                       versions << fixed_version
                     end
                   else
                     versions << fixed_version
                   end
                 end
                 @assignable_versions = versions.uniq.sort
               end
               # Returns true if this issue is blocked by another issue that is still open
               def blocked?
                 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
               end
               # Returns an array of statuses that user is able to apply
               def new_statuses_allowed_to(user=User.current, include_default=false)
                 if new_record? && @copied_from
                   [IssueStatus.default, @copied_from.status].compact.uniq.sort
                 else
                   initial_status = nil
                   if new_record?
                     initial_status = IssueStatus.default
                   elsif status_id_was
                     initial_status = IssueStatus.find_by_id(status_id_was)
                   end
                   initial_status ||= status
                   statuses = initial_status.find_new_statuses_allowed_to(
                     user.admin ? Role.all : user.roles_for_project(project),
                     tracker,
                     author == user,
                     assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                     )
                   statuses << initial_status unless statuses.empty?
                   statuses << IssueStatus.default if include_default
                   statuses = statuses.compact.uniq.sort
                   blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                 end
               end
               def assigned_to_was
                 if assigned_to_id_changed? && assigned_to_id_was.present?
                   @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
                 end
               end
               # Returns the users that should be notified
               def notified_users
                 notified = []
                 # Author and assignee are always notified unless they have been
                 # locked or don't want to be notified
                 notified << author if author
                 if assigned_to
                   notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
                 end
                 if assigned_to_was
                   notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
                 end
                 notified = notified.select {|u| u.active? && u.notify_about?(self)}
                 notified += project.notified_users
                 notified.uniq!
                 # Remove users that can not view the issue
                 notified.reject! {|user| !visible?(user)}
                 notified
               end
               # Returns the email addresses that should be notified
               def recipients
                 notified_users.collect(&:mail)
               end
               # Returns the number of hours spent on this issue
               def spent_hours
                 @spent_hours ||= time_entries.sum(:hours) || 0
               end
               # Returns the total number of hours spent on this issue and its descendants
               #
               # Example:
               #   spent_hours => 0.0
               #   spent_hours => 50.2
               def total_spent_hours
                 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
                   :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
               end
               def relations
                 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
               end
               # Preloads relations for a collection of issues
               def self.load_relations(issues)
                 if issues.any?
                   relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
                   issues.each do |issue|
                     issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                   end
                 end
               end
               # Preloads visible spent time for a collection of issues
               def self.load_visible_spent_hours(issues, user=User.current)
                 if issues.any?
                   hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
                   issues.each do |issue|
                     issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                   end
                 end
               end
               # Preloads visible relations for a collection of issues
               def self.load_visible_relations(issues, user=User.current)
                 if issues.any?
                   issue_ids = issues.map(&:id)
                   # Relations with issue_from in given issues and visible issue_to
                   relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
                   # Relations with issue_to in given issues and visible issue_from
                   relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
                   issues.each do |issue|
                     relations =
                       relations_from.select {|relation| relation.issue_from_id == issue.id} +
                       relations_to.select {|relation| relation.issue_to_id == issue.id}
                     issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
                   end
                 end
               end
               # Finds an issue relation given its id.
               def find_relation(relation_id)
                 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
               end
               # Returns all the other issues that depend on the issue
               def all_dependent_issues(except=[])
                 except << self
                 dependencies = []
                 dependencies += relations_from.map(&:issue_to)
                 dependencies += children unless leaf?
-                dependencies << parent
                 dependencies.compact!
                 dependencies -= except
-                dependencies + dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
+                dependencies += dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
+                if parent
+                  dependencies << parent
+                  dependencies += parent.all_dependent_issues(except + parent.descendants)
+                end
+                dependencies
               end
               # Returns an array of issues that duplicate this one
               def duplicates
                 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
               end
               # Returns the due date or the target due date if any
               # Used on gantt chart
               def due_before
                 due_date || (fixed_version ? fixed_version.effective_date : nil)
               end
               # Returns the time scheduled for this issue.
               #
               # Example:
               #   Start Date: 2/26/09, End Date: 3/04/09
               #   duration => 6
               def duration
                 (start_date && due_date) ? due_date - start_date : 0
               end
               # Returns the duration in working days
               def working_duration
                 (start_date && due_date) ? working_days(start_date, due_date) : 0
               end
               def soonest_start(reload=false)
                 @soonest_start = nil if reload
                 @soonest_start ||= (
                     relations_to(reload).collect{|relation| relation.successor_soonest_start} +
                     [(@parent_issue || parent).try(:soonest_start)]
                   ).compact.max
               end
               # Sets start_date on the given date or the next working day
               # and changes due_date to keep the same working duration.
               def reschedule_on(date)
                 wd = working_duration
                 date = next_working_date(date)
                 self.start_date = date
                 self.due_date = add_working_days(date, wd)
               end
               # Reschedules the issue on the given date or the next working day and saves the record.
               # If the issue is a parent task, this is done by rescheduling its subtasks.
               def reschedule_on!(date)
                 return if date.nil?
                 if leaf?
                   if start_date.nil? || start_date != date
                     if start_date && start_date > date
                       # Issue can not be moved earlier than its soonest start date
                       date = [soonest_start(true), date].compact.max
                     end
                     reschedule_on(date)
                     begin
                       save
                     rescue ActiveRecord::StaleObjectError
                       reload
                       reschedule_on(date)
                       save
                     end
                   end
                 else
                   leaves.each do |leaf|
                     if leaf.start_date
                       # Only move subtask if it starts at the same date as the parent
                       # or if it starts before the given date
                       if start_date == leaf.start_date || date > leaf.start_date
                         leaf.reschedule_on!(date)
                       end
                     else
                       leaf.reschedule_on!(date)
                     end
                   end
                 end
               end
               def <=>(issue)
                 if issue.nil?
                   -1
                 elsif root_id != issue.root_id
                   (root_id || 0) <=> (issue.root_id || 0)
                 else
                   (lft || 0) <=> (issue.lft || 0)
                 end
               end
               def to_s
                 "#{tracker} ##{id}: #{subject}"
               end
               # Returns a string of css classes that apply to the issue
               def css_classes
                 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
                 s << ' closed' if closed?
                 s << ' overdue' if overdue?
                 s << ' child' if child?
                 s << ' parent' unless leaf?
                 s << ' private' if is_private?
                 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                 s
               end
               # Saves an issue and a time_entry from the parameters
               def save_issue_with_child_records(params, existing_time_entry=nil)
                 Issue.transaction do
                   if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                     @time_entry = existing_time_entry || TimeEntry.new
                     @time_entry.project = project
                     @time_entry.issue = self
                     @time_entry.user = User.current
                     @time_entry.spent_on = User.current.today
                     @time_entry.attributes = params[:time_entry]
                     self.time_entries << @time_entry
                   end
                   # TODO: Rename hook
                   Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                   if save
                     # TODO: Rename hook
                     Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                   else
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               # Unassigns issues from +version+ if it's no longer shared with issue's project
               def self.update_versions_from_sharing_change(version)
                 # Update issues assigned to the version
                 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
               end
               # Unassigns issues from versions that are no longer shared
               # after +project+ was moved
               def self.update_versions_from_hierarchy_change(project)
                 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                 # Update issues of the moved projects and issues assigned to a version of a moved project
                 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
               end
               def parent_issue_id=(arg)
                 s = arg.to_s.strip.presence
                 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
                   @parent_issue.id
                 else
                   @parent_issue = nil
                   @invalid_parent_issue_id = arg
                 end
               end
               def parent_issue_id
                 if @invalid_parent_issue_id
                   @invalid_parent_issue_id
                 elsif instance_variable_defined? :@parent_issue
                   @parent_issue.nil? ? nil : @parent_issue.id
                 else
                   parent_id
                 end
               end
               # Returns true if issue's project is a valid
               # parent issue project
               def valid_parent_project?(issue=parent)
                 return true if issue.nil? || issue.project_id == project_id
                 case Setting.cross_project_subtasks
                 when 'system'
                   true
                 when 'tree'
                   issue.project.root == project.root
                 when 'hierarchy'
                   issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
                 when 'descendants'
                   issue.project.is_or_is_ancestor_of?(project)
                 else
                   false
                 end
               end
               # Extracted from the ReportsController.
               def self.by_tracker(project)
                 count_and_group_by(:project => project,
                                    :field => 'tracker_id',
                                    :joins => Tracker.table_name)
               end
               def self.by_version(project)
                 count_and_group_by(:project => project,
                                    :field => 'fixed_version_id',
                                    :joins => Version.table_name)
               end
               def self.by_priority(project)
                 count_and_group_by(:project => project,
                                    :field => 'priority_id',
                                    :joins => IssuePriority.table_name)
               end
               def self.by_category(project)
                 count_and_group_by(:project => project,
                                    :field => 'category_id',
                                    :joins => IssueCategory.table_name)
               end
               def self.by_assigned_to(project)
                 count_and_group_by(:project => project,
                                    :field => 'assigned_to_id',
                                    :joins => User.table_name)
               end
               def self.by_author(project)
                 count_and_group_by(:project => project,
                                    :field => 'author_id',
                                    :joins => User.table_name)
               end
               def self.by_subproject(project)
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             #{Issue.table_name}.project_id as project_id,
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                             #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                             and #{Issue.table_name}.project_id <> #{project.id}
                                                           group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
               end
               # End ReportsController extraction
               # Returns an array of projects that user can assign the issue to
               def allowed_target_projects(user=User.current)
                 if new_record?
                   Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
                 else
                   self.class.allowed_target_projects_on_move(user)
                 end
               end
               # Returns an array of projects that user can move issues to
               def self.allowed_target_projects_on_move(user=User.current)
                 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
               end
               private
               def after_project_change
                 # Update project_id on related time entries
                 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
                 # Delete issue relations
                 unless Setting.cross_project_issue_relations?
                   relations_from.clear
                   relations_to.clear
                 end
                 # Move subtasks that were in the same project
                 children.each do |child|
                   next unless child.project_id == project_id_was
                   # Change project and keep project
                   child.send :project=, project, true
                   unless child.save
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               # Callback for after the creation of an issue by copy
               # * adds a "copied to" relation with the copied issue
               # * copies subtasks from the copied issue
               def after_create_from_copy
                 return unless copy? && !@after_create_from_copy_handled
                 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
                   relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
                   unless relation.save
                     logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
                   end
                 end
                 unless @copied_from.leaf? || @copy_options[:subtasks] == false
                   copy_options = (@copy_options || {}).merge(:subtasks => false)
                   copied_issue_ids = {@copied_from.id => self.id}
                   @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
                     # Do not copy self when copying an issue as a descendant of the copied issue
                     next if child == self
                     # Do not copy subtasks of issues that were not copied
                     next unless copied_issue_ids[child.parent_id]
                     # Do not copy subtasks that are not visible to avoid potential disclosure of private data
                     unless child.visible?
                       logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
                       next
                     end
                     copy = Issue.new.copy_from(child, copy_options)
                     copy.author = author
                     copy.project = project
                     copy.parent_issue_id = copied_issue_ids[child.parent_id]
                     unless copy.save
                       logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
                       next
                     end
                     copied_issue_ids[child.id] = copy.id
                   end
                 end
                 @after_create_from_copy_handled = true
               end
               def update_nested_set_attributes
                 if root_id.nil?
                   # issue was just created
                   self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                   set_default_left_and_right
                   Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                   if @parent_issue
                     move_to_child_of(@parent_issue)
                   end
                   reload
                 elsif parent_issue_id != parent_id
                   former_parent_id = parent_id
                   # moving an existing issue
                   if @parent_issue && @parent_issue.root_id == root_id
                     # inside the same tree
                     move_to_child_of(@parent_issue)
                   else
                     # to another tree
                     unless root?
                       move_to_right_of(root)
                       reload
                     end
                     old_root_id = root_id
                     self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                     target_maxright = nested_set_scope.maximum(right_column_name) || 0
                     offset = target_maxright + 1 - lft
                     Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                       ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                     self[left_column_name] = lft + offset
                     self[right_column_name] = rgt + offset
                     if @parent_issue
                       move_to_child_of(@parent_issue)
                     end
                   end
                   reload
                   # delete invalid relations of all descendants
                   self_and_descendants.each do |issue|
                     issue.relations.each do |relation|
                       relation.destroy unless relation.valid?
                     end
                   end
                   # update former parent
                   recalculate_attributes_for(former_parent_id) if former_parent_id
                 end
                 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
               end
               def update_parent_attributes
                 recalculate_attributes_for(parent_id) if parent_id
               end
               def recalculate_attributes_for(issue_id)
                 if issue_id && p = Issue.find_by_id(issue_id)
                   # priority = highest priority of children
                   if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
                     p.priority = IssuePriority.find_by_position(priority_position)
                   end
                   # start/due dates = lowest/highest dates of children
                   p.start_date = p.children.minimum(:start_date)
                   p.due_date = p.children.maximum(:due_date)
                   if p.start_date && p.due_date && p.due_date < p.start_date
                     p.start_date, p.due_date = p.due_date, p.start_date
                   end
                   # done ratio = weighted average ratio of leaves
                   unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                     leaves_count = p.leaves.count
                     if leaves_count > 0
                       average = p.leaves.average(:estimated_hours).to_f
                       if average == 0
                         average = 1
                       end
                       done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
                       progress = done / (average * leaves_count)
                       p.done_ratio = progress.round
                     end
                   end
                   # estimate = sum of leaves estimates
                   p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                   p.estimated_hours = nil if p.estimated_hours == 0.0
                   # ancestors will be recursively updated
                   p.save(:validate => false)
                 end
               end
               # Update issues so their versions are not pointing to a
               # fixed_version that is not shared with the issue's project
               def self.update_versions(conditions=nil)
                 # Only need to update issues with a fixed_version from
                 # a different project and that is not systemwide shared
                 Issue.scoped(:conditions => conditions).all(
                   :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                     " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                     " AND #{Version.table_name}.sharing <> 'system'",
                   :include => [:project, :fixed_version]
                 ).each do |issue|
                   next if issue.project.nil? || issue.fixed_version.nil?
                   unless issue.project.shared_versions.include?(issue.fixed_version)
                     issue.init_journal(User.current)
                     issue.fixed_version = nil
                     issue.save
                   end
                 end
               end
               # Callback on file attachment
               def attachment_added(obj)
                 if @current_journal && !obj.new_record?
                   @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
                 end
               end
               # Callback on attachment deletion
               def attachment_removed(obj)
                 if @current_journal && !obj.new_record?
                   @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
                   @current_journal.save
                 end
               end
               # Default assignment based on category
               def default_assign
                 if assigned_to.nil? && category && category.assigned_to
                   self.assigned_to = category.assigned_to
                 end
               end
               # Updates start/due dates of following issues
               def reschedule_following_issues
                 if start_date_changed? || due_date_changed?
                   relations_from.each do |relation|
                     relation.set_issue_to_dates
                   end
                 end
               end
               # Closes duplicates if the issue is being closed
               def close_duplicates
                 if closing?
                   duplicates.each do |duplicate|
                     # Reload is need in case the duplicate was updated by a previous duplicate
                     duplicate.reload
                     # Don't re-close it if it's already closed
                     next if duplicate.closed?
                     # Same user and notes
                     if @current_journal
                       duplicate.init_journal(@current_journal.user, @current_journal.notes)
                     end
                     duplicate.update_attribute :status, self.status
                   end
                 end
               end
               # Make sure updated_on is updated when adding a note and set updated_on now
               # so we can set closed_on with the same value on closing
               def force_updated_on_change
                 if @current_journal || changed?
                   self.updated_on = current_time_from_proper_timezone
                   if new_record?
                     self.created_on = updated_on
                   end
                 end
               end
               # Callback for setting closed_on when the issue is closed.
               # The closed_on attribute stores the time of the last closing
               # and is preserved when the issue is reopened.
               def update_closed_on
                 if closing? || (new_record? && closed?)
                   self.closed_on = updated_on
                 end
               end
               # Saves the changes in a Journal
               # Called after_save
               def create_journal
                 if @current_journal
                   # attributes changes
                   if @attributes_before_change
                     (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
                       before = @attributes_before_change[c]
                       after = send(c)
                       next if before == after || (before.blank? && after.blank?)
                       @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                     :prop_key => c,
                                                                     :old_value => before,
                                                                     :value => after)
                     }
                   end
                   if @custom_values_before_change
                     # custom fields changes
                     custom_field_values.each {|c|
                       before = @custom_values_before_change[c.custom_field_id]
                       after = c.value
                       next if before == after || (before.blank? && after.blank?)
                       if before.is_a?(Array) || after.is_a?(Array)
                         before = [before] unless before.is_a?(Array)
                         after = [after] unless after.is_a?(Array)
                         # values removed
                         (before - after).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => value,
                                                                         :value => nil)
                         end
                         # values added
                         (after - before).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => nil,
                                                                         :value => value)
                         end
                       else
                         @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                       :prop_key => c.custom_field_id,
                                                                       :old_value => before,
                                                                       :value => after)
                       end
                     }
                   end
                   @current_journal.save
                   # reset current journal
                   init_journal @current_journal.user, @current_journal.notes
                 end
               end
               # Query generator for selecting groups of issue counts for a project
               # based on specific criteria
               #
               # Options
               # * project - Project to search in.
               # * field - String. Issue field to key off of in the grouping.
               # * joins - String. The table name to join against.
               def self.count_and_group_by(options)
                 project = options.delete(:project)
                 select_field = options.delete(:field)
                 joins = options.delete(:joins)
                 where = "#{Issue.table_name}.#{select_field}=j.id"
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             j.id as #{select_field},
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                               #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{where}
                                                             and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project)}
                                                           group by s.id, s.is_closed, j.id")
               end
             end

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class IssueRelationTest < ActiveSupport::TestCase
               fixtures :projects,
                        :users,
                        :roles,
                        :members,
                        :member_roles,
                        :issues,
                        :issue_statuses,
                        :issue_relations,
                        :enabled_modules,
                        :enumerations,
                        :trackers
               include Redmine::I18n
               def test_create
                 from = Issue.find(1)
                 to = Issue.find(2)
                 relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                              :relation_type => IssueRelation::TYPE_PRECEDES
                 assert relation.save
                 relation.reload
                 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
                 assert_equal from, relation.issue_from
                 assert_equal to, relation.issue_to
               end
               def test_create_minimum
                 relation = IssueRelation.new :issue_from => Issue.find(1), :issue_to => Issue.find(2)
                 assert relation.save
                 assert_equal IssueRelation::TYPE_RELATES, relation.relation_type
               end
               def test_follows_relation_should_be_reversed
                 from = Issue.find(1)
                 to = Issue.find(2)
                 relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                              :relation_type => IssueRelation::TYPE_FOLLOWS
                 assert relation.save
                 relation.reload
                 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
                 assert_equal to, relation.issue_from
                 assert_equal from, relation.issue_to
               end
               def test_follows_relation_should_not_be_reversed_if_validation_fails
                 from = Issue.find(1)
                 to = Issue.find(2)
                 relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                              :relation_type => IssueRelation::TYPE_FOLLOWS,
                                              :delay => 'xx'
                 assert !relation.save
                 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type
                 assert_equal from, relation.issue_from
                 assert_equal to, relation.issue_to
               end
               def test_relation_type_for
                 from = Issue.find(1)
                 to = Issue.find(2)
                 relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                              :relation_type => IssueRelation::TYPE_PRECEDES
                 assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type_for(from)
                 assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type_for(to)
               end
               def test_set_issue_to_dates_without_issue_to
                 r = IssueRelation.new(:issue_from => Issue.new(:start_date => Date.today),
                                       :relation_type => IssueRelation::TYPE_PRECEDES,
                                       :delay => 1)
                 assert_nil r.set_issue_to_dates
               end
               def test_set_issue_to_dates_without_issues
                 r = IssueRelation.new(:relation_type => IssueRelation::TYPE_PRECEDES, :delay => 1)
                 assert_nil r.set_issue_to_dates
               end
               def test_validates_circular_dependency
                 IssueRelation.delete_all
                 assert IssueRelation.create!(
                          :issue_from => Issue.find(1), :issue_to => Issue.find(2),
                          :relation_type => IssueRelation::TYPE_PRECEDES
                        )
                 assert IssueRelation.create!(
                          :issue_from => Issue.find(2), :issue_to => Issue.find(3),
                          :relation_type => IssueRelation::TYPE_PRECEDES
                        )
                 r = IssueRelation.new(
                       :issue_from => Issue.find(3), :issue_to => Issue.find(1),
                       :relation_type => IssueRelation::TYPE_PRECEDES
                     )
                 assert !r.save
                 assert_not_nil r.errors[:base]
               end
               def test_validates_circular_dependency_of_subtask
                 set_language_if_valid 'en'
                 issue1 = Issue.generate!
                 issue2 = Issue.generate!
                 IssueRelation.create!(
                   :issue_from => issue1, :issue_to => issue2,
                   :relation_type => IssueRelation::TYPE_PRECEDES
                 )
                 child = Issue.generate!(:parent_issue_id => issue2.id)
                 issue1.reload
                 child.reload
                 r = IssueRelation.new(
                       :issue_from => child, :issue_to => issue1,
                       :relation_type => IssueRelation::TYPE_PRECEDES
                     )
                 assert !r.save
                 assert_include 'This relation would create a circular dependency', r.errors.full_messages
               end
+              def test_subtasks_should_allow_precedes_relation
+                parent = Issue.generate!
+                child1 = Issue.generate!(:parent_issue_id => parent.id)
+                child2 = Issue.generate!(:parent_issue_id => parent.id)
+                r = IssueRelation.new(
+                      :issue_from => child1, :issue_to => child2,
+                      :relation_type => IssueRelation::TYPE_PRECEDES
+                    )
+                assert r.valid?
+                assert r.save
+              end
               def test_validates_circular_dependency_on_reverse_relations
                 IssueRelation.delete_all
                 assert IssueRelation.create!(
                          :issue_from => Issue.find(1), :issue_to => Issue.find(3),
                          :relation_type => IssueRelation::TYPE_BLOCKS
                        )
                 assert IssueRelation.create!(
                          :issue_from => Issue.find(1), :issue_to => Issue.find(2),
                          :relation_type => IssueRelation::TYPE_BLOCKED
                        )
                 r = IssueRelation.new(
                       :issue_from => Issue.find(2), :issue_to => Issue.find(1),
                       :relation_type => IssueRelation::TYPE_BLOCKED
                     )
                 assert !r.save
                 assert_not_nil r.errors[:base]
               end
             end