jro_apps/redmine Commit - r12244:c92f4253097f

Rails4: replace deprecated Relation#update_all at IssuesControllerTest...

Toshi MARUYAMA -

r12244:c92f4253097f

parent child

Context file:

r12244:c92f4253097f

Collapse all files

test/functional/issues_controller_test.rb +6 -6

               end
               def test_show_should_deny_anonymous_access_to_private_issue
-                Issue.update_all(["is_private = ?", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?", true])
                 get :show, :id => 1
                 assert_response :redirect
               end
               end
               def test_show_should_deny_non_member_access_to_private_issue
-                Issue.update_all(["is_private = ?", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?", true])
                 @request.session[:user_id] = 9
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_deny_member_access_to_private_issue_without_permission
-                Issue.update_all(["is_private = ?", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?", true])
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response 403
               end
               def test_show_should_allow_author_access_to_private_issue
-                Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?, author_id = 3", true])
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response :success
               end
               def test_show_should_allow_assignee_access_to_private_issue
-                Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?, assigned_to_id = 3", true])
                 @request.session[:user_id] = 3
                 get :show, :id => 1
                 assert_response :success
               end
               def test_show_should_allow_member_access_to_private_issue_with_permission
-                Issue.update_all(["is_private = ?", true], "id = 1")
+                Issue.where(:id => 1).update_all(["is_private = ?", true])
                 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
                 @request.session[:user_id] = 3
                 get :show, :id => 1

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages