##// END OF EJS Templates
jro_apps » redmine
RSS
Log an error when trying to send an attachment that cannot be read....
Jean-Philippe Lang -
r10854:c87f36d20b26
parent child
Show More
Side by Side Unified
Context file:
r10854:c87f36d20b26 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,149 +1,154
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class AttachmentsController < ApplicationController
19 19 before_filter :find_project, :except => :upload
20 20 before_filter :file_readable, :read_authorize, :only => [:show, :download, :thumbnail]
21 21 before_filter :delete_authorize, :only => :destroy
22 22 before_filter :authorize_global, :only => :upload
23 23
24 24 accept_api_auth :show, :download, :upload
25 25
26 26 def show
27 27 respond_to do |format|
28 28 format.html {
29 29 if @attachment.is_diff?
30 30 @diff = File.new(@attachment.diskfile, "rb").read
31 31 @diff_type = params[:type] || User.current.pref[:diff_type] || 'inline'
32 32 @diff_type = 'inline' unless %w(inline sbs).include?(@diff_type)
33 33 # Save diff type as user preference
34 34 if User.current.logged? && @diff_type != User.current.pref[:diff_type]
35 35 User.current.pref[:diff_type] = @diff_type
36 36 User.current.preference.save
37 37 end
38 38 render :action => 'diff'
39 39 elsif @attachment.is_text? && @attachment.filesize <= Setting.file_max_size_displayed.to_i.kilobyte
40 40 @content = File.new(@attachment.diskfile, "rb").read
41 41 render :action => 'file'
42 42 else
43 43 download
44 44 end
45 45 }
46 46 format.api
47 47 end
48 48 end
49 49
50 50 def download
51 51 if @attachment.container.is_a?(Version) || @attachment.container.is_a?(Project)
52 52 @attachment.increment_download
53 53 end
54 54
55 55 if stale?(:etag => @attachment.digest)
56 56 # images are sent inline
57 57 send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
58 58 :type => detect_content_type(@attachment),
59 59 :disposition => (@attachment.image? ? 'inline' : 'attachment')
60 60 end
61 61 end
62 62
63 63 def thumbnail
64 64 if @attachment.thumbnailable? && thumbnail = @attachment.thumbnail(:size => params[:size])
65 65 if stale?(:etag => thumbnail)
66 66 send_file thumbnail,
67 67 :filename => filename_for_content_disposition(@attachment.filename),
68 68 :type => detect_content_type(@attachment),
69 69 :disposition => 'inline'
70 70 end
71 71 else
72 72 # No thumbnail for the attachment or thumbnail could not be created
73 73 render :nothing => true, :status => 404
74 74 end
75 75 end
76 76
77 77 def upload
78 78 # Make sure that API users get used to set this content type
79 79 # as it won't trigger Rails' automatic parsing of the request body for parameters
80 80 unless request.content_type == 'application/octet-stream'
81 81 render :nothing => true, :status => 406
82 82 return
83 83 end
84 84
85 85 @attachment = Attachment.new(:file => request.raw_post)
86 86 @attachment.author = User.current
87 87 @attachment.filename = params[:filename].presence || Redmine::Utils.random_hex(16)
88 88 saved = @attachment.save
89 89
90 90 respond_to do |format|
91 91 format.js
92 92 format.api {
93 93 if saved
94 94 render :action => 'upload', :status => :created
95 95 else
96 96 render_validation_errors(@attachment)
97 97 end
98 98 }
99 99 end
100 100 end
101 101
102 102 def destroy
103 103 if @attachment.container.respond_to?(:init_journal)
104 104 @attachment.container.init_journal(User.current)
105 105 end
106 106 if @attachment.container
107 107 # Make sure association callbacks are called
108 108 @attachment.container.attachments.delete(@attachment)
109 109 else
110 110 @attachment.destroy
111 111 end
112 112
113 113 respond_to do |format|
114 114 format.html { redirect_to_referer_or project_path(@project) }
115 115 format.js
116 116 end
117 117 end
118 118
119 119 private
120 120 def find_project
121 121 @attachment = Attachment.find(params[:id])
122 122 # Show 404 if the filename in the url is wrong
123 123 raise ActiveRecord::RecordNotFound if params[:filename] && params[:filename] != @attachment.filename
124 124 @project = @attachment.project
125 125 rescue ActiveRecord::RecordNotFound
126 126 render_404
127 127 end
128 128
129 129 # Checks that the file exists and is readable
130 130 def file_readable
131 @attachment.readable? ? true : render_404
131 if @attachment.readable?
132 true
133 else
134 logger.error "Cannot send attachment, #{@attachment.diskfile} does not exist or is unreadable."
135 render_404
136 end
132 137 end
133 138
134 139 def read_authorize
135 140 @attachment.visible? ? true : deny_access
136 141 end
137 142
138 143 def delete_authorize
139 144 @attachment.deletable? ? true : deny_access
140 145 end
141 146
142 147 def detect_content_type(attachment)
143 148 content_type = attachment.content_type
144 149 if content_type.blank?
145 150 content_type = Redmine::MimeType.of(attachment.filename)
146 151 end
147 152 content_type.to_s
148 153 end
149 154 end
General Comments 0
You need to be logged in to leave comments. Login now