jro_apps/redmine Commit - r5154:c6e34b0c1135

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class IssuesController < ApplicationController

18

class IssuesController < ApplicationController

19

menu_item :new_issue, :only => [:new, :create]

19

menu_item :new_issue, :only => [:new, :create]

20

default_search_scope :issues

20

default_search_scope :issues

21

22

before_filter :find_issue, :only => [:show, :edit, :update]

22

before_filter :find_issue, :only => [:show, :edit, :update]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

24

before_filter :check_project_uniqueness, :only => [:move, :perform_move]

24

before_filter :check_project_uniqueness, :only => [:move, :perform_move]

25

before_filter :find_project, :only => [:new, :create]

25

before_filter :find_project, :only => [:new, :create]

26

before_filter :authorize, :except => [:index]

26

before_filter :authorize, :except => [:index]

27

before_filter :find_optional_project, :only => [:index]

27

before_filter :find_optional_project, :only => [:index]

28

before_filter :check_for_default_issue_status, :only => [:new, :create]

28

before_filter :check_for_default_issue_status, :only => [:new, :create]

29

before_filter :build_new_issue_from_params, :only => [:new, :create]

29

before_filter :build_new_issue_from_params, :only => [:new, :create]

30

accept_key_auth :index, :show, :create, :update, :destroy

30

accept_key_auth :index, :show, :create, :update, :destroy

31

32

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

32

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

33

34

helper :journals

34

helper :journals

35

helper :projects

35

helper :projects

36

include ProjectsHelper

36

include ProjectsHelper

37

helper :custom_fields

37

helper :custom_fields

38

include CustomFieldsHelper

38

include CustomFieldsHelper

39

helper :issue_relations

39

helper :issue_relations

40

include IssueRelationsHelper

40

include IssueRelationsHelper

41

helper :watchers

41

helper :watchers

42

include WatchersHelper

42

include WatchersHelper

43

helper :attachments

43

helper :attachments

44

include AttachmentsHelper

44

include AttachmentsHelper

45

helper :queries

45

helper :queries

46

include QueriesHelper

46

include QueriesHelper

47

helper :repositories

47

helper :repositories

48

include RepositoriesHelper

48

include RepositoriesHelper

49

helper :sort

49

helper :sort

50

include SortHelper

50

include SortHelper

51

include IssuesHelper

51

include IssuesHelper

52

helper :timelog

52

helper :timelog

53

helper :gantt

53

helper :gantt

54

include Redmine::Export::PDF

54

include Redmine::Export::PDF

55

56

verify :method => [:post, :delete],

56

verify :method => [:post, :delete],

57

:only => :destroy,

57

:only => :destroy,

58

:render => { :nothing => true, :status => :method_not_allowed }

58

:render => { :nothing => true, :status => :method_not_allowed }

59

60

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

60

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

61

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

61

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

62

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

62

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

63

64

def index

64

def index

65

retrieve_query

65

retrieve_query

66

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

66

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

67

sort_update(@query.sortable_columns)

67

sort_update(@query.sortable_columns)

68

69

if @query.valid?

69

if @query.valid?

70

case params[:format]

70

case params[:format]

71

when 'csv', 'pdf'

71

when 'csv', 'pdf'

72

@limit = Setting.issues_export_limit.to_i

72

@limit = Setting.issues_export_limit.to_i

73

when 'atom'

73

when 'atom'

74

@limit = Setting.feeds_limit.to_i

74

@limit = Setting.feeds_limit.to_i

75

when 'xml', 'json'

75

when 'xml', 'json'

76

@offset, @limit = api_offset_and_limit

76

@offset, @limit = api_offset_and_limit

77

else

77

else

78

@limit = per_page_option

78

@limit = per_page_option

79

end

79

end

80

81

@issue_count = @query.issue_count

81

@issue_count = @query.issue_count

82

@issue_pages = Paginator.new self, @issue_count, @limit, params['page']

82

@issue_pages = Paginator.new self, @issue_count, @limit, params['page']

83

@offset ||= @issue_pages.current.offset

83

@offset ||= @issue_pages.current.offset

84

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

84

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

85

:order => sort_clause,

85

:order => sort_clause,

86

:offset => @offset,

86

:offset => @offset,

87

:limit => @limit)

87

:limit => @limit)

88

@issue_count_by_group = @query.issue_count_by_group

88

@issue_count_by_group = @query.issue_count_by_group

89

90

respond_to do |format|

90

respond_to do |format|

91

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

91

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

92

format.api

92

format.api

93

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

93

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

94

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

94

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

95

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

95

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

96

end

96

end

97

else

97

else

98

# Send html if the query is not valid

98

# Send html if the query is not valid

99

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

99

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

100

end

100

end

101

rescue ActiveRecord::RecordNotFound

101

rescue ActiveRecord::RecordNotFound

102

render_404

102

render_404

103

end

103

end

104

105

def show

105

def show

106

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

106

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

107

@journals.each_with_index {|j,i| j.indice = i+1}

107

@journals.each_with_index {|j,i| j.indice = i+1}

108

@journals.reverse! if User.current.wants_comments_in_reverse_order?

108

@journals.reverse! if User.current.wants_comments_in_reverse_order?

109

@changesets = @issue.changesets.visible.all

109

@changesets = @issue.changesets.visible.all

110

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

110

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

111

@relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }

111

@relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }

112

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

112

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

113

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

113

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

114

@priorities = IssuePriority.all

114

@priorities = IssuePriority.all

115

@time_entry = TimeEntry.new

115

@time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)

116

respond_to do |format|

116

respond_to do |format|

117

format.html { render :template => 'issues/show.rhtml' }

117

format.html { render :template => 'issues/show.rhtml' }

118

format.api

118

format.api

119

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

119

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

120

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

120

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

121

end

121

end

122

end

122

end

123

124

# Add a new issue

124

# Add a new issue

125

# The new issue will be created from an existing one if copy_from parameter is given

125

# The new issue will be created from an existing one if copy_from parameter is given

126

def new

126

def new

127

respond_to do |format|

127

respond_to do |format|

128

format.html { render :action => 'new', :layout => !request.xhr? }

128

format.html { render :action => 'new', :layout => !request.xhr? }

129

format.js { render :partial => 'attributes' }

129

format.js { render :partial => 'attributes' }

130

end

130

end

131

end

131

end

132

133

def create

133

def create

134

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

134

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

135

if @issue.save

135

if @issue.save

136

attachments = Attachment.attach_files(@issue, params[:attachments])

136

attachments = Attachment.attach_files(@issue, params[:attachments])

137

render_attachment_warning_if_needed(@issue)

137

render_attachment_warning_if_needed(@issue)

138

flash[:notice] = l(:notice_successful_create)

138

flash[:notice] = l(:notice_successful_create)

139

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

139

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

140

respond_to do |format|

140

respond_to do |format|

141

format.html {

141

format.html {

142

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

142

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

143

{ :action => 'show', :id => @issue })

143

{ :action => 'show', :id => @issue })

144

}

144

}

145

format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }

145

format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }

146

end

146

end

147

return

147

return

148

else

148

else

149

respond_to do |format|

149

respond_to do |format|

150

format.html { render :action => 'new' }

150

format.html { render :action => 'new' }

151

format.api { render_validation_errors(@issue) }

151

format.api { render_validation_errors(@issue) }

152

end

152

end

153

end

153

end

154

end

154

end

155

156

def edit

156

def edit

157

update_issue_from_params

157

update_issue_from_params

158

159

@journal = @issue.current_journal

159

@journal = @issue.current_journal

160

161

respond_to do |format|

161

respond_to do |format|

162

format.html { }

162

format.html { }

163

format.xml { }

163

format.xml { }

164

end

164

end

165

end

165

end

166

167

def update

167

def update

168

update_issue_from_params

168

update_issue_from_params

169

170

if @issue.save_issue_with_child_records(params, @time_entry)

170

if @issue.save_issue_with_child_records(params, @time_entry)

171

render_attachment_warning_if_needed(@issue)

171

render_attachment_warning_if_needed(@issue)

172

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

172

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

173

174

respond_to do |format|

174

respond_to do |format|

175

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

175

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

176

format.api { head :ok }

176

format.api { head :ok }

177

end

177

end

178

else

178

else

179

render_attachment_warning_if_needed(@issue)

179

render_attachment_warning_if_needed(@issue)

180

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

180

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

181

@journal = @issue.current_journal

181

@journal = @issue.current_journal

182

183

respond_to do |format|

183

respond_to do |format|

184

format.html { render :action => 'edit' }

184

format.html { render :action => 'edit' }

185

format.api { render_validation_errors(@issue) }

185

format.api { render_validation_errors(@issue) }

186

end

186

end

187

end

187

end

188

end

188

end

189

190

# Bulk edit a set of issues

190

# Bulk edit a set of issues

191

def bulk_edit

191

def bulk_edit

192

@issues.sort!

192

@issues.sort!

193

@available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}

193

@available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}

194

@custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}

194

@custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}

195

@assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}

195

@assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}

196

@trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}

196

@trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}

197

end

197

end

198

199

def bulk_update

199

def bulk_update

200

@issues.sort!

200

@issues.sort!

201

attributes = parse_params_for_bulk_issue_attributes(params)

201

attributes = parse_params_for_bulk_issue_attributes(params)

202

203

unsaved_issue_ids = []

203

unsaved_issue_ids = []

204

@issues.each do |issue|

204

@issues.each do |issue|

205

issue.reload

205

issue.reload

206

journal = issue.init_journal(User.current, params[:notes])

206

journal = issue.init_journal(User.current, params[:notes])

207

issue.safe_attributes = attributes

207

issue.safe_attributes = attributes

208

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

208

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

209

unless issue.save

209

unless issue.save

210

# Keep unsaved issue ids to display them in flash error

210

# Keep unsaved issue ids to display them in flash error

211

unsaved_issue_ids << issue.id

211

unsaved_issue_ids << issue.id

212

end

212

end

213

end

213

end

214

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

214

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

215

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

215

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

216

end

216

end

217

218

def destroy

218

def destroy

219

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

219

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

220

if @hours > 0

220

if @hours > 0

221

case params[:todo]

221

case params[:todo]

222

when 'destroy'

222

when 'destroy'

223

# nothing to do

223

# nothing to do

224

when 'nullify'

224

when 'nullify'

225

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

225

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

226

when 'reassign'

226

when 'reassign'

227

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

227

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

228

if reassign_to.nil?

228

if reassign_to.nil?

229

flash.now[:error] = l(:error_issue_not_found_in_project)

229

flash.now[:error] = l(:error_issue_not_found_in_project)

230

return

230

return

231

else

231

else

232

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

232

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

233

end

233

end

234

else

234

else

235

# display the destroy form if it's a user request

235

# display the destroy form if it's a user request

236

return unless api_request?

236

return unless api_request?

237

end

237

end

238

end

238

end

239

@issues.each(&:destroy)

239

@issues.each(&:destroy)

240

respond_to do |format|

240

respond_to do |format|

241

format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }

241

format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }

242

format.api { head :ok }

242

format.api { head :ok }

243

end

243

end

244

end

244

end

245

246

private

246

private

247

def find_issue

247

def find_issue

248

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

248

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

249

@project = @issue.project

249

@project = @issue.project

250

rescue ActiveRecord::RecordNotFound

250

rescue ActiveRecord::RecordNotFound

251

render_404

251

render_404

252

end

252

end

253

254

def find_project

254

def find_project

255

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

255

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

256

@project = Project.find(project_id)

256

@project = Project.find(project_id)

257

rescue ActiveRecord::RecordNotFound

257

rescue ActiveRecord::RecordNotFound

258

render_404

258

render_404

259

end

259

end

260

261

# Used by #edit and #update to set some common instance variables

261

# Used by #edit and #update to set some common instance variables

262

# from the params

262

# from the params

263

# TODO: Refactor, not everything in here is needed by #edit

263

# TODO: Refactor, not everything in here is needed by #edit

264

def update_issue_from_params

264

def update_issue_from_params

265

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

265

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

266

@priorities = IssuePriority.all

266

@priorities = IssuePriority.all

267

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

267

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

268

@time_entry = TimeEntry.new

268

@time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)

269

@time_entry.attributes = params[:time_entry]

269

@time_entry.attributes = params[:time_entry]

270

271

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

271

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

272

@issue.init_journal(User.current, @notes)

272

@issue.init_journal(User.current, @notes)

273

@issue.safe_attributes = params[:issue]

273

@issue.safe_attributes = params[:issue]

274

end

274

end

275

276

# TODO: Refactor, lots of extra code in here

276

# TODO: Refactor, lots of extra code in here

277

# TODO: Changing tracker on an existing issue should not trigger this

277

# TODO: Changing tracker on an existing issue should not trigger this

278

def build_new_issue_from_params

278

def build_new_issue_from_params

279

if params[:id].blank?

279

if params[:id].blank?

280

@issue = Issue.new

280

@issue = Issue.new

281

@issue.copy_from(params[:copy_from]) if params[:copy_from]

281

@issue.copy_from(params[:copy_from]) if params[:copy_from]

282

@issue.project = @project

282

@issue.project = @project

283

else

283

else

284

@issue = @project.issues.visible.find(params[:id])

284

@issue = @project.issues.visible.find(params[:id])

285

end

285

end

286

287

@issue.project = @project

287

@issue.project = @project

288

# Tracker must be set before custom field values

288

# Tracker must be set before custom field values

289

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

289

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

290

if @issue.tracker.nil?

290

if @issue.tracker.nil?

291

render_error l(:error_no_tracker_in_project)

291

render_error l(:error_no_tracker_in_project)

292

return false

292

return false

293

end

293

end

294

@issue.start_date ||= Date.today

294

@issue.start_date ||= Date.today

295

if params[:issue].is_a?(Hash)

295

if params[:issue].is_a?(Hash)

296

@issue.safe_attributes = params[:issue]

296

@issue.safe_attributes = params[:issue]

297

if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?

297

if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?

298

@issue.watcher_user_ids = params[:issue]['watcher_user_ids']

298

@issue.watcher_user_ids = params[:issue]['watcher_user_ids']

299

end

299

end

300

end

300

end

301

@issue.author = User.current

301

@issue.author = User.current

302

@priorities = IssuePriority.all

302

@priorities = IssuePriority.all

303

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

303

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

304

end

304

end

305

306

def check_for_default_issue_status

306

def check_for_default_issue_status

307

if IssueStatus.default.nil?

307

if IssueStatus.default.nil?

308

render_error l(:error_no_default_issue_status)

308

render_error l(:error_no_default_issue_status)

309

return false

309

return false

310

end

310

end

311

end

311

end

312

313

def parse_params_for_bulk_issue_attributes(params)

313

def parse_params_for_bulk_issue_attributes(params)

314

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

314

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

315

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

315

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

316

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

316

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

317

attributes

317

attributes

318

end

318

end

319

end

319

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
               menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
               before_filter :check_project_uniqueness, :only => [:move, :perform_move]
               before_filter :find_project, :only => [:new, :create]
               before_filter :authorize, :except => [:index]
               before_filter :find_optional_project, :only => [:index]
               before_filter :check_for_default_issue_status, :only => [:new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_key_auth :index, :show, :create, :update, :destroy
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               include ProjectsHelper
               helper :custom_fields
               include CustomFieldsHelper
               helper :issue_relations
               include IssueRelationsHelper
               helper :watchers
               include WatchersHelper
               helper :attachments
               include AttachmentsHelper
               helper :queries
               include QueriesHelper
               helper :repositories
               include RepositoriesHelper
               helper :sort
               include SortHelper
               include IssuesHelper
               helper :timelog
               helper :gantt
               include Redmine::Export::PDF
               verify :method => [:post, :delete],
                      :only => :destroy,
                      :render => { :nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   case params[:format]
                   when 'csv', 'pdf'
                     @limit = Setting.issues_export_limit.to_i
                   when 'atom'
                     @limit = Setting.feeds_limit.to_i
                   when 'xml', 'json'
                     @offset, @limit = api_offset_and_limit
                   else
                     @limit = per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
                   @offset ||= @issue_pages.current.offset
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @offset,
                                           :limit => @limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
                     format.api
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
                     format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                   end
                 else
                   # Send html if the query is not valid
                   render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.all
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @priorities = IssuePriority.all
-                @time_entry = TimeEntry.new
+                @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 respond_to do |format|
                   format.html { render :template => 'issues/show.rhtml' }
                   format.api
                   format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                 end
               end
               # Add a new issue
               # The new issue will be created from an existing one if copy_from parameter is given
               def new
                 respond_to do |format|
                   format.html { render :action => 'new', :layout => !request.xhr? }
                   format.js { render :partial => 'attributes' }
                 end
               end
               def create
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                 if @issue.save
                   attachments = Attachment.attach_files(@issue, params[:attachments])
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_create)
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       redirect_to(params[:continue] ?  { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
                                   { :action => 'show', :id => @issue })
                     }
                     format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html { render :action => 'new' }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               def edit
                 update_issue_from_params
                 @journal = @issue.current_journal
                 respond_to do |format|
                   format.html { }
                   format.xml  { }
                 end
               end
               def update
                 update_issue_from_params
                 if @issue.save_issue_with_child_records(params, @time_entry)
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                     format.api  { head :ok }
                   end
                 else
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   @journal = @issue.current_journal
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.api  { render_validation_errors(@issue) }
                   end
                 end
               end
               # Bulk edit a set of issues
               def bulk_edit
                 @issues.sort!
                 @available_statuses = @projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
                 @custom_fields = @projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
                 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
                 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
               end
               def bulk_update
                 @issues.sort!
                 attributes = parse_params_for_bulk_issue_attributes(params)
                 unsaved_issue_ids = []
                 @issues.each do |issue|
                   issue.reload
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                   unless issue.save
                     # Keep unsaved issue ids to display them in flash error
                     unsaved_issue_ids << issue.id
                   end
                 end
                 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
                 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
               end
               def destroy
                 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                     end
                   else
                     # display the destroy form if it's a user request
                     return unless api_request?
                   end
                 end
                 @issues.each(&:destroy)
                 respond_to do |format|
                   format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
                   format.api  { head :ok }
                 end
               end
             private
               def find_issue
                 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                 @project = @issue.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
                 @project = Project.find(project_id)
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               # TODO: Refactor, not everything in here is needed by #edit
               def update_issue_from_params
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.all
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
-                @time_entry = TimeEntry.new
+                @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                 @time_entry.attributes = params[:time_entry]
                 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
                 @issue.init_journal(User.current, @notes)
                 @issue.safe_attributes = params[:issue]
               end
               # TODO: Refactor, lots of extra code in here
               # TODO: Changing tracker on an existing issue should not trigger this
               def build_new_issue_from_params
                 if params[:id].blank?
                   @issue = Issue.new
                   @issue.copy_from(params[:copy_from]) if params[:copy_from]
                   @issue.project = @project
                 else
                   @issue = @project.issues.visible.find(params[:id])
                 end
                 @issue.project = @project
                 # Tracker must be set before custom field values
                 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                 if @issue.tracker.nil?
                   render_error l(:error_no_tracker_in_project)
                   return false
                 end
                 @issue.start_date ||= Date.today
                 if params[:issue].is_a?(Hash)
                   @issue.safe_attributes = params[:issue]
                   if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
                     @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
                   end
                 end
                 @issue.author = User.current
                 @priorities = IssuePriority.all
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
               end
               def check_for_default_issue_status
                 if IssueStatus.default.nil?
                   render_error l(:error_no_default_issue_status)
                   return false
                 end
               end
               def parse_params_for_bulk_issue_attributes(params)
                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                 attributes
               end
             end