jro_apps/redmine Commit - r9927:c6106543e1c5

html5 compliance....

Jean-Philippe Lang -

r9927:c6106543e1c5

parent child

Context file:

r9927:c6106543e1c5

app/helpers/issues_helper.rb +1 -1

                 unless no_html
                   label = content_tag('strong', label)
                   old_value = content_tag("i", h(old_value)) if detail.old_value
-                  old_value = content_tag("strike", old_value) if detail.old_value and detail.value.blank?
+                  old_value = content_tag("del", old_value) if detail.old_value and detail.value.blank?
                   if detail.property == 'attachment' && !value.blank? && atta = Attachment.find_by_id(detail.prop_key)
                     # Link to the attachment if it has not been removed
                     value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])

app/views/attachments/_form.html.erb +1 -1

             <% end %>
             <span id="attachments_fields">
               <span>
-                <%= file_field_tag 'attachments[1][file]', :size => 30, :id => nil, :class => 'file',
+                <%= file_field_tag 'attachments[1][file]', :id => nil, :class => 'file',
                       :onchange => "checkFileSize(this, #{Setting.attachment_max_size.to_i.kilobytes}, '#{escape_javascript(l(:error_attachment_too_big, :max_size => number_to_human_size(Setting.attachment_max_size.to_i.kilobytes)))}');"  -%>
                 <%= text_field_tag 'attachments[1][description]', '', :id => nil, :class => 'description', :maxlength => 255, :placeholder => l(:label_optional_description) %>
                 <%= link_to_function(image_tag('delete.png'), 'removeFileField(this)', :title => (l(:button_delete))) %>

test/unit/helpers/issues_helper_test.rb +3 -2

                        :enabled_modules,
                        :workflows,
                        :custom_fields,
-                       :attachments
+                       :attachments,
+                       :versions
               def setup
                 super
                     html = show_detail(@detail, false)
                     assert_include '<strong>% Done</strong>', html
-                    assert_include '<strike><i>50</i></strike>', html
+                    assert_include '<del><i>50</i></del>', html
                   end
                 end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages