jro_apps/redmine Commit - r4253:c55e060bab62

Allow key authentication when deleting issues (with tests) #6447...

Eric Davis -

r4253:c55e060bab62

parent child

Context file:

r4253:c55e060bab62

Collapse all files

app/controllers/issues_controller.rb +1 -1

                before_filter :find_optional_project, :only => [:index]
                before_filter :check_for_default_issue_status, :only => [:new, :create]
                before_filter :build_new_issue_from_params, :only => [:new, :create]
-               accept_key_auth :index, :show, :create, :update
+               accept_key_auth :index, :show, :create, :update, :destroy
                rescue_from Query::StatementInvalid, :with => :query_statement_invalid

test/integration/api_test/issues_test.rb +18 -18

                end
                context "DELETE /issues/1.xml" do
-                 setup do
-                   @issue_count = Issue.count
-                   delete '/issues/1.xml', {}, :authorization => credentials('jsmith')
-                 end
-                 should_respond_with :ok
-                 should_respond_with_content_type 'application/xml'
+                 should_allow_api_authentication(:delete,
+                                                 '/issues/6.xml',
+                                                 {},
+                                                 {:success_code => :ok})
                  should "delete the issue" do
-                   assert_equal Issue.count, @issue_count -1
-                   assert_nil Issue.find_by_id(1)
-                 end
+                   assert_difference('Issue.count',-1) do
+                     delete '/issues/6.xml', {}, :authorization => credentials('jsmith')
                end
-               context "DELETE /issues/1.json" do
-                 setup do
-                   @issue_count = Issue.count
-                   delete '/issues/1.json', {}, :authorization => credentials('jsmith')
+                   assert_nil Issue.find_by_id(6)
+                 end
-                 end
-                 should_respond_with :ok
-                 should_respond_with_content_type 'application/json'
+               context "DELETE /issues/1.json" do
+                 should_allow_api_authentication(:delete,
+                                                 '/issues/6.json',
+                                                 {},
+                                                 {:success_code => :ok})
                  should "delete the issue" do
-                   assert_equal Issue.count, @issue_count -1
-                   assert_nil Issue.find_by_id(1)
+                   assert_difference('Issue.count',-1) do
+                     delete '/issues/6.json', {}, :authorization => credentials('jsmith')
+                   end
+                   assert_nil Issue.find_by_id(6)
                  end
                end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages