jro_apps/redmine Commit - r4086:c4e123b2f002

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class IssuesController < ApplicationController

18

class IssuesController < ApplicationController

19

menu_item :new_issue, :only => [:new, :create]

19

menu_item :new_issue, :only => [:new, :create]

20

default_search_scope :issues

20

default_search_scope :issues

21

22

before_filter :find_issue, :only => [:show, :edit, :update]

22

before_filter :find_issue, :only => [:show, :edit, :update]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

24

before_filter :find_project, :only => [:new, :create]

24

before_filter :find_project, :only => [:new, :create]

25

before_filter :authorize, :except => [:index]

25

before_filter :authorize, :except => [:index]

26

before_filter :find_optional_project, :only => [:index]

26

before_filter :find_optional_project, :only => [:index]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

29

accept_key_auth :index, :show

29

accept_key_auth :index, :show

30

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

32

33

helper :journals

33

helper :journals

34

helper :projects

34

helper :projects

35

include ProjectsHelper

35

include ProjectsHelper

36

helper :custom_fields

36

helper :custom_fields

37

include CustomFieldsHelper

37

include CustomFieldsHelper

38

helper :issue_relations

38

helper :issue_relations

39

include IssueRelationsHelper

39

include IssueRelationsHelper

40

helper :watchers

40

helper :watchers

41

include WatchersHelper

41

include WatchersHelper

42

helper :attachments

42

helper :attachments

43

include AttachmentsHelper

43

include AttachmentsHelper

44

helper :queries

44

helper :queries

45

include QueriesHelper

45

include QueriesHelper

46

helper :sort

46

helper :sort

47

include SortHelper

47

include SortHelper

48

include IssuesHelper

48

include IssuesHelper

49

helper :timelog

49

helper :timelog

50

include Redmine::Export::PDF

50

include Redmine::Export::PDF

51

52

verify :method => [:post, :delete],

52

verify :method => [:post, :delete],

53

:only => :destroy,

53

:only => :destroy,

54

:render => { :nothing => true, :status => :method_not_allowed }

54

:render => { :nothing => true, :status => :method_not_allowed }

55

56

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

56

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

57

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

57

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

58

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

58

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

59

60

def index

60

def index

61

retrieve_query

61

retrieve_query

62

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

62

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

63

sort_update(@query.sortable_columns)

63

sort_update(@query.sortable_columns)

64

65

if @query.valid?

65

if @query.valid?

66

limit = case params[:format]

66

limit = case params[:format]

67

when 'csv', 'pdf'

67

when 'csv', 'pdf'

68

Setting.issues_export_limit.to_i

68

Setting.issues_export_limit.to_i

69

when 'atom'

69

when 'atom'

70

Setting.feeds_limit.to_i

70

Setting.feeds_limit.to_i

71

else

71

else

72

per_page_option

72

per_page_option

73

end

73

end

74

75

@issue_count = @query.issue_count

75

@issue_count = @query.issue_count

76

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

76

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

77

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

77

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

78

:order => sort_clause,

78

:order => sort_clause,

79

:offset => @issue_pages.current.offset,

79

:offset => @issue_pages.current.offset,

80

:limit => limit)

80

:limit => limit)

81

@issue_count_by_group = @query.issue_count_by_group

81

@issue_count_by_group = @query.issue_count_by_group

82

83

respond_to do |format|

83

respond_to do |format|

84

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

84

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

85

format.xml { render :layout => false }

85

format.xml { render :layout => false }

86

format.json { render :text => @issues.to_json, :layout => false }

86

format.json { render :text => @issues.to_json, :layout => false }

87

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

87

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

88

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

88

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

89

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

89

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

90

end

90

end

91

else

91

else

92

# Send html if the query is not valid

92

# Send html if the query is not valid

93

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

93

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

94

end

94

end

95

rescue ActiveRecord::RecordNotFound

95

rescue ActiveRecord::RecordNotFound

96

render_404

96

render_404

97

end

97

end

98

99

def show

99

def show

100

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

100

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

101

@journals.each_with_index {|j,i| j.indice = i+1}

101

@journals.each_with_index {|j,i| j.indice = i+1}

102

@journals.reverse! if User.current.wants_comments_in_reverse_order?

102

@journals.reverse! if User.current.wants_comments_in_reverse_order?

103

@changesets = @issue.changesets.visible.all

103

@changesets = @issue.changesets.visible.all

104

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

104

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

105

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

105

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

106

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

106

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

107

@priorities = IssuePriority.all

107

@priorities = IssuePriority.all

108

@time_entry = TimeEntry.new

108

@time_entry = TimeEntry.new

109

respond_to do |format|

109

respond_to do |format|

110

format.html { render :template => 'issues/show.rhtml' }

110

format.html { render :template => 'issues/show.rhtml' }

111

format.xml { render :layout => false }

111

format.xml { render :layout => false }

112

format.json { render :text => @issue.to_json, :layout => false }

112

format.json { render :text => @issue.to_json, :layout => false }

113

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

113

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

114

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

114

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

115

end

115

end

116

end

116

end

117

118

# Add a new issue

118

# Add a new issue

119

# The new issue will be created from an existing one if copy_from parameter is given

119

# The new issue will be created from an existing one if copy_from parameter is given

120

def new

120

def new

121

respond_to do |format|

121

respond_to do |format|

122

format.html { render :action => 'new', :layout => !request.xhr? }

122

format.html { render :action => 'new', :layout => !request.xhr? }

123

format.js { render :partial => 'attributes' }

123

format.js { render :partial => 'attributes' }

124

end

124

end

125

end

125

end

126

127

def create

127

def create

128

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

128

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

129

if @issue.save

129

if @issue.save

130

attachments = Attachment.attach_files(@issue, params[:attachments])

130

attachments = Attachment.attach_files(@issue, params[:attachments])

131

render_attachment_warning_if_needed(@issue)

131

render_attachment_warning_if_needed(@issue)

132

flash[:notice] = l(:notice_successful_create)

132

flash[:notice] = l(:notice_successful_create)

133

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

133

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

134

respond_to do |format|

134

respond_to do |format|

135

format.html {

135

format.html {

136

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

136

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

137

{ :action => 'show', :id => @issue })

137

{ :action => 'show', :id => @issue })

138

}

138

}

139

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

139

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

140

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

140

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

141

end

141

end

142

return

142

return

143

else

143

else

144

respond_to do |format|

144

respond_to do |format|

145

format.html { render :action => 'new' }

145

format.html { render :action => 'new' }

146

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

146

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

147

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

147

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

148

end

148

end

149

end

149

end

150

end

150

end

151

152

# Attributes that can be updated on workflow transition (without :edit permission)

152

# Attributes that can be updated on workflow transition (without :edit permission)

153

# TODO: make it configurable (at least per role)

153

# TODO: make it configurable (at least per role)

154

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

154

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

155

156

def edit

156

def edit

157

update_issue_from_params

157

update_issue_from_params

158

159

@journal = @issue.current_journal

159

@journal = @issue.current_journal

160

161

respond_to do |format|

161

respond_to do |format|

162

format.html { }

162

format.html { }

163

format.xml { }

163

format.xml { }

164

end

164

end

165

end

165

end

166

167

def update

167

def update

168

update_issue_from_params

168

update_issue_from_params

169

170

if @issue.save_issue_with_child_records(params, @time_entry)

170

if @issue.save_issue_with_child_records(params, @time_entry)

171

render_attachment_warning_if_needed(@issue)

171

render_attachment_warning_if_needed(@issue)

172

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

172

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

173

174

respond_to do |format|

174

respond_to do |format|

175

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

175

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

176

format.xml { head :ok }

176

format.xml { head :ok }

177

format.json { head :ok }

177

format.json { head :ok }

178

end

178

end

179

else

179

else

180

render_attachment_warning_if_needed(@issue)

180

render_attachment_warning_if_needed(@issue)

181

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

181

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

182

@journal = @issue.current_journal

182

@journal = @issue.current_journal

183

184

respond_to do |format|

184

respond_to do |format|

185

format.html { render :action => 'edit' }

185

format.html { render :action => 'edit' }

186

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

186

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

187

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

187

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

188

end

188

end

189

end

189

end

190

end

190

end

191

192

# Bulk edit a set of issues

192

# Bulk edit a set of issues

193

def bulk_edit

193

def bulk_edit

194

@issues.sort!

194

@issues.sort!

195

@available_statuses = Workflow.available_statuses(@project)

195

@available_statuses = Workflow.available_statuses(@project)

196

@custom_fields = @project.all_issue_custom_fields

196

@custom_fields = @project.all_issue_custom_fields

197

end

197

end

198

199

def bulk_update

199

def bulk_update

200

@issues.sort!

200

@issues.sort!

201

attributes = parse_params_for_bulk_issue_attributes(params)

201

attributes = parse_params_for_bulk_issue_attributes(params)

202

203

unsaved_issue_ids = []

203

unsaved_issue_ids = []

204

@issues.each do |issue|

204

@issues.each do |issue|

205

issue.reload

205

issue.reload

206

journal = issue.init_journal(User.current, params[:notes])

206

journal = issue.init_journal(User.current, params[:notes])

207

issue.safe_attributes = attributes

207

issue.safe_attributes = attributes

208

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

208

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

209

unless issue.save

209

unless issue.save

210

# Keep unsaved issue ids to display them in flash error

210

# Keep unsaved issue ids to display them in flash error

211

unsaved_issue_ids << issue.id

211

unsaved_issue_ids << issue.id

212

end

212

end

213

end

213

end

214

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

214

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

215

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

215

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

216

end

216

end

217

218

def destroy

218

def destroy

219

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

219

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

220

if @hours > 0

220

if @hours > 0

221

case params[:todo]

221

case params[:todo]

222

when 'destroy'

222

when 'destroy'

223

# nothing to do

223

# nothing to do

224

when 'nullify'

224

when 'nullify'

225

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

225

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

226

when 'reassign'

226

when 'reassign'

227

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

227

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

228

if reassign_to.nil?

228

if reassign_to.nil?

229

flash.now[:error] = l(:error_issue_not_found_in_project)

229

flash.now[:error] = l(:error_issue_not_found_in_project)

230

return

230

return

231

else

231

else

232

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

232

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

233

end

233

end

234

else

234

else

235

unless params[:format] == 'xml' || params[:format] == 'json'

235

unless params[:format] == 'xml' || params[:format] == 'json'

236

# display the destroy form if it's a user request

236

# display the destroy form if it's a user request

237

return

237

return

238

end

238

end

239

end

239

end

240

end

240

end

241

@issues.each(&:destroy)

241

@issues.each(&:destroy)

242

respond_to do |format|

242

respond_to do |format|

243

format.html { redirect_to :action => 'index', :project_id => @project }

243

format.html { redirect_to :action => 'index', :project_id => @project }

244

format.xml { head :ok }

244

format.xml { head :ok }

245

format.json { head :ok }

245

format.json { head :ok }

246

end

246

end

247

end

247

end

248

249

private

249

private

250

def find_issue

250

def find_issue

251

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

251

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

252

@project = @issue.project

252

@project = @issue.project

253

rescue ActiveRecord::RecordNotFound

253

rescue ActiveRecord::RecordNotFound

254

render_404

254

render_404

255

end

255

end

256

257

def find_project

257

def find_project

258

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

258

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

259

@project = Project.find(project_id)

259

@project = Project.find(project_id)

260

rescue ActiveRecord::RecordNotFound

260

rescue ActiveRecord::RecordNotFound

261

render_404

261

render_404

262

end

262

end

263

264

# Used by #edit and #update to set some common instance variables

264

# Used by #edit and #update to set some common instance variables

265

# from the params

265

# from the params

266

# TODO: Refactor, not everything in here is needed by #edit

266

# TODO: Refactor, not everything in here is needed by #edit

267

def update_issue_from_params

267

def update_issue_from_params

268

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

268

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

269

@priorities = IssuePriority.all

269

@priorities = IssuePriority.all

270

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

270

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

271

@time_entry = TimeEntry.new

271

@time_entry = TimeEntry.new

272

273

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

273

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

274

@issue.init_journal(User.current, @notes)

274

@issue.init_journal(User.current, @notes)

275

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

275

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

276

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

276

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

277

attrs = params[:issue].dup

277

attrs = params[:issue].dup

278

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

278

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

279

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

279

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

280

@issue.safe_attributes = attrs

280

@issue.safe_attributes = attrs

281

end

281

end

282

283

end

283

end

284

285

# TODO: Refactor, lots of extra code in here

285

# TODO: Refactor, lots of extra code in here

286

# TODO: Changing tracker on an existing issue should not trigger this

286

def build_new_issue_from_params

287

def build_new_issue_from_params

287

if params[:id].blank?

288

if params[:id].blank?

288

@issue = Issue.new

289

@issue = Issue.new

289

@issue.copy_from(params[:copy_from]) if params[:copy_from]

290

@issue.copy_from(params[:copy_from]) if params[:copy_from]

290

@issue.project = @project

291

@issue.project = @project

291

else

292

else

292

@issue = @project.issues.visible.find(params[:id])

293

@issue = @project.issues.visible.find(params[:id])

293

end

294

end

294

295

@issue.project = @project

296

@issue.project = @project

296

# Tracker must be set before custom field values

297

# Tracker must be set before custom field values

297

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

298

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

298

if @issue.tracker.nil?

299

if @issue.tracker.nil?

299

render_error l(:error_no_tracker_in_project)

300

render_error l(:error_no_tracker_in_project)

300

return false

301

return false

301

end

302

end

302

if params[:issue].is_a?(Hash)

303

if params[:issue].is_a?(Hash)

303

@issue.safe_attributes = params[:issue]

304

@issue.safe_attributes = params[:issue]

304

~~@issue~~.~~watcher_user_ids~~ = ~~params~~[~~:issue~~][~~'watcher_user_ids'~~] if User.current.allowed_to?(:add_issue_watchers, @project)

305

if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?

306

@issue.watcher_user_ids = params[:issue]['watcher_user_ids']

307

end

305

end

308

end

306

@issue.author = User.current

309

@issue.author = User.current

307

@issue.start_date ||= Date.today

310

@issue.start_date ||= Date.today

308

@priorities = IssuePriority.all

311

@priorities = IssuePriority.all

309

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

312

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

310

end

313

end

311

314

312

def check_for_default_issue_status

315

def check_for_default_issue_status

313

if IssueStatus.default.nil?

316

if IssueStatus.default.nil?

314

render_error l(:error_no_default_issue_status)

317

render_error l(:error_no_default_issue_status)

315

return false

318

return false

316

end

319

end

317

end

320

end

318

321

319

def parse_params_for_bulk_issue_attributes(params)

322

def parse_params_for_bulk_issue_attributes(params)

320

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

323

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

321

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

324

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

322

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

325

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

323

attributes

326

attributes

324

end

327

end

325

end

328

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
               menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
               before_filter :find_project, :only => [:new, :create]
               before_filter :authorize, :except => [:index]
               before_filter :find_optional_project, :only => [:index]
               before_filter :check_for_default_issue_status, :only => [:new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_key_auth :index, :show
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               include ProjectsHelper
               helper :custom_fields
               include CustomFieldsHelper
               helper :issue_relations
               include IssueRelationsHelper
               helper :watchers
               include WatchersHelper
               helper :attachments
               include AttachmentsHelper
               helper :queries
               include QueriesHelper
               helper :sort
               include SortHelper
               include IssuesHelper
               helper :timelog
               include Redmine::Export::PDF
               verify :method => [:post, :delete],
                      :only => :destroy,
                      :render => { :nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   limit = case params[:format]
                   when 'csv', 'pdf'
                     Setting.issues_export_limit.to_i
                   when 'atom'
                     Setting.feeds_limit.to_i
                   else
                     per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new self, @issue_count, limit, params['page']
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @issue_pages.current.offset,
                                           :limit => limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
                     format.xml  { render :layout => false }
                     format.json { render :text => @issues.to_json, :layout => false }
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
                     format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                   end
                 else
                   # Send html if the query is not valid
                   render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.all
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @priorities = IssuePriority.all
                 @time_entry = TimeEntry.new
                 respond_to do |format|
                   format.html { render :template => 'issues/show.rhtml' }
                   format.xml  { render :layout => false }
                   format.json { render :text => @issue.to_json, :layout => false }
                   format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                 end
               end
               # Add a new issue
               # The new issue will be created from an existing one if copy_from parameter is given
               def new
                 respond_to do |format|
                   format.html { render :action => 'new', :layout => !request.xhr? }
                   format.js { render :partial => 'attributes' }
                 end
               end
               def create
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                 if @issue.save
                   attachments = Attachment.attach_files(@issue, params[:attachments])
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_create)
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       redirect_to(params[:continue] ?  { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
                                   { :action => 'show', :id => @issue })
                     }
                     format.xml  { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
                     format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html { render :action => 'new' }
                     format.xml  { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Attributes that can be updated on workflow transition (without :edit permission)
               # TODO: make it configurable (at least per role)
               UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
               def edit
                 update_issue_from_params
                 @journal = @issue.current_journal
                 respond_to do |format|
                   format.html { }
                   format.xml  { }
                 end
               end
               def update
                 update_issue_from_params
                 if @issue.save_issue_with_child_records(params, @time_entry)
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                     format.xml  { head :ok }
                     format.json  { head :ok }
                   end
                 else
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   @journal = @issue.current_journal
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.xml  { render :xml => @issue.errors, :status => :unprocessable_entity }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Bulk edit a set of issues
               def bulk_edit
                 @issues.sort!
                 @available_statuses = Workflow.available_statuses(@project)
                 @custom_fields = @project.all_issue_custom_fields
               end
               def bulk_update
                 @issues.sort!
                 attributes = parse_params_for_bulk_issue_attributes(params)
                 unsaved_issue_ids = []
                 @issues.each do |issue|
                   issue.reload
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                   unless issue.save
                     # Keep unsaved issue ids to display them in flash error
                     unsaved_issue_ids << issue.id
                   end
                 end
                 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
                 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
               end
               def destroy
                 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                     end
                   else
                     unless params[:format] == 'xml' || params[:format] == 'json'
                       # display the destroy form if it's a user request
                       return
                     end
                   end
                 end
                 @issues.each(&:destroy)
                 respond_to do |format|
                   format.html { redirect_to :action => 'index', :project_id => @project }
                   format.xml  { head :ok }
                   format.json  { head :ok }
                 end
               end
             private
               def find_issue
                 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                 @project = @issue.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
                 @project = Project.find(project_id)
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               # TODO: Refactor, not everything in here is needed by #edit
               def update_issue_from_params
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.all
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @time_entry = TimeEntry.new
                 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
                 @issue.init_journal(User.current, @notes)
                 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
                   attrs = params[:issue].dup
                   attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
                   attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
                   @issue.safe_attributes = attrs
                 end
               end
               # TODO: Refactor, lots of extra code in here
+              # TODO: Changing tracker on an existing issue should not trigger this
               def build_new_issue_from_params
                 if params[:id].blank?
                   @issue = Issue.new
                   @issue.copy_from(params[:copy_from]) if params[:copy_from]
                   @issue.project = @project
                 else
                   @issue = @project.issues.visible.find(params[:id])
                 end
                 @issue.project = @project
                 # Tracker must be set before custom field values
                 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                 if @issue.tracker.nil?
                   render_error l(:error_no_tracker_in_project)
                   return false
                 end
                 if params[:issue].is_a?(Hash)
                   @issue.safe_attributes = params[:issue]
-                  @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
+                  if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
+                    @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
+                  end
                 end
                 @issue.author = User.current
                 @issue.start_date ||= Date.today
                 @priorities = IssuePriority.all
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
               end
               def check_for_default_issue_status
                 if IssueStatus.default.nil?
                   render_error l(:error_no_default_issue_status)
                   return false
                 end
               end
               def parse_params_for_bulk_issue_attributes(params)
                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                 attributes
               end
             end