jro_apps/redmine Commit - r8828:c49ef8e543c4

Adds functional tests....

Jean-Philippe Lang -

r8828:c49ef8e543c4

parent child

Context file:

r8828:c49ef8e543c4

Collapse all files

test/functional/attachments_controller_test.rb +5 0

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'attachments_controller'
             # Re-raise errors caught by the controller.
             class AttachmentsController; def rescue_action(e) raise e end; end
             class AttachmentsControllerTest < ActionController::TestCase
               fixtures :users, :projects, :roles, :members, :member_roles,
                        :enabled_modules, :issues, :trackers, :attachments,
                        :versions, :wiki_pages, :wikis, :documents
               def setup
                 @controller = AttachmentsController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 set_fixtures_attachments_directory
               end
               def teardown
                 set_tmp_attachments_directory
               end
               def test_show_diff
                 ['inline', 'sbs'].each do |dt|
                   # 060719210727_changeset_utf8.diff
                   get :show, :id => 14, :type => dt
                   assert_response :success
                   assert_template 'diff'
                   assert_equal 'text/html', @response.content_type
                   assert_tag 'th',
                     :attributes => {:class => /filename/},
                     :content => /issues_controller.rb\t\(révision 1484\)/
                   assert_tag 'td',
                     :attributes => {:class => /line-code/},
                     :content => /Demande créée avec succès/
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_replcace_cannot_convert_content
                 with_settings :repositories_encodings => 'UTF-8' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_tag 'th',
                       :attributes => {:class => "filename"},
                       :content => /issues_controller.rb\t\(r\?vision 1484\)/
                     assert_tag 'td',
                       :attributes => {:class => /line-code/},
                       :content => /Demande cr\?\?e avec succ\?s/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_latin_1
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_tag 'th',
                       :attributes => {:class => "filename"},
                       :content => /issues_controller.rb\t\(révision 1484\)/
                     assert_tag 'td',
                       :attributes => {:class => /line-code/},
                       :content => /Demande créée avec succès/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_save_diff_type
                 @request.session[:user_id] = 1 # admin
                 user = User.find(1)
                 get :show, :id => 5
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "inline", user.pref[:diff_type]
                 get :show, :id => 5, :type => 'sbs'
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "sbs", user.pref[:diff_type]
               end
               def test_show_text_file
                 get :show, :id => 4
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_text_file_utf_8
                 set_tmp_attachments_directory
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'japanese-utf-8.txt', a.filename
                 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
                 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
                 get :show, :id => a.id
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 assert_tag :tag => 'th',
                            :content => '1',
                            :attributes => { :class => 'line-num' },
                            :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
               end
               def test_show_text_file_replcace_cannot_convert_content
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_tag :tag => 'th',
                              :content => '7',
                              :attributes => { :class => 'line-num' },
                              :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
                 end
               end
               def test_show_text_file_latin_1
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_tag :tag => 'th',
                              :content => '7',
                              :attributes => { :class => 'line-num' },
                              :sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
                   end
               end
               def test_show_text_file_should_send_if_too_big
                 Setting.file_max_size_displayed = 512
                 Attachment.find(4).update_attribute :filesize, 754.kilobyte
                 get :show, :id => 4
                 assert_response :success
                 assert_equal 'application/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_other
                 get :show, :id => 6
                 assert_response :success
                 assert_equal 'application/octet-stream', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_without_permission
                 get :show, :id => 15
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_with_permission
                 @request.session[:user_id] = 2
                 get :show, :id => 15
                 assert_response :success
                 assert_tag 'h2', :content => /private.diff/
                 set_tmp_attachments_directory
               end
               def test_show_file_without_container_should_be_denied
                 set_tmp_attachments_directory
                 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
                 @request.session[:user_id] = 2
                 get :show, :id => attachment.id
                 assert_response 403
               end
+              def test_show_invalid_should_respond_with_404
+                get :show, :id => 999
+                assert_response 404
+              end
               def test_download_text_file
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'application/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_version_file_with_issue_tracking_disabled
                 Project.find(1).disable_module! :issue_tracking
                 get :download, :id => 9
                 assert_response :success
               end
               def test_download_should_assign_content_type_if_blank
                 Attachment.find(4).update_attribute(:content_type, '')
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'text/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_missing_file
                 get :download, :id => 2
                 assert_response 404
                 set_tmp_attachments_directory
               end
               def test_anonymous_on_private_private
                 get :download, :id => 7
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
                 set_tmp_attachments_directory
               end
               def test_destroy_issue_attachment
                 set_tmp_attachments_directory
                 issue = Issue.find(3)
                 @request.session[:user_id] = 2
                 assert_difference 'issue.attachments.count', -1 do
                   delete :destroy, :id => 1
                 end
                 # no referrer
                 assert_redirected_to '/projects/ecookbook'
                 assert_nil Attachment.find_by_id(1)
                 j = issue.journals.find(:first, :order => 'created_on DESC')
                 assert_equal 'attachment', j.details.first.property
                 assert_equal '1', j.details.first.prop_key
                 assert_equal 'error281.txt', j.details.first.old_value
               end
               def test_destroy_wiki_page_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 3
                   assert_response 302
                 end
               end
               def test_destroy_project_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 8
                   assert_response 302
                 end
               end
               def test_destroy_version_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 9
                   assert_response 302
                 end
               end
               def test_destroy_without_permission
                 set_tmp_attachments_directory
                 assert_no_difference 'Attachment.count' do
                   delete :destroy, :id => 3
                 end
                 assert_response 302
                 assert Attachment.find_by_id(3)
               end
             end

test/functional/issue_categories_controller_test.rb +24 0

             # Redmine - project management software
             # Copyright (C) 2006-2011  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'issue_categories_controller'
             # Re-raise errors caught by the controller.
             class IssueCategoriesController; def rescue_action(e) raise e end; end
             class IssueCategoriesControllerTest < ActionController::TestCase
               fixtures :projects, :users, :members, :member_roles, :roles, :enabled_modules, :issue_categories
               def setup
                 @controller = IssueCategoriesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 @request.session[:user_id] = 2
               end
               def test_new
                 @request.session[:user_id] = 2 # manager
                 get :new, :project_id => '1'
                 assert_response :success
                 assert_template 'new'
               end
               def test_create
                 @request.session[:user_id] = 2 # manager
                 assert_difference 'IssueCategory.count' do
                   post :create, :project_id => '1', :issue_category => {:name => 'New category'}
                 end
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 category = IssueCategory.find_by_name('New category')
                 assert_not_nil category
                 assert_equal 1, category.project_id
               end
               def test_create_failure
                 @request.session[:user_id] = 2
                 post :create, :project_id => '1', :issue_category => {:name => ''}
                 assert_response :success
                 assert_template 'new'
               end
+              def test_create_from_issue_form
+                @request.session[:user_id] = 2 # manager
+                assert_difference 'IssueCategory.count' do
+                  xhr :post, :create, :project_id => '1', :issue_category => {:name => 'New category'}
+                end
+                category = IssueCategory.first(:order => 'id DESC')
+                assert_equal 'New category', category.name
+                assert_response :success
+                assert_select_rjs :replace, 'issue_category_id' do
+                  assert_select "option[value=#{category.id}][selected=selected]"
+                end
+              end
+              def test_create_from_issue_form_with_failure
+                @request.session[:user_id] = 2 # manager
+                assert_no_difference 'IssueCategory.count' do
+                  xhr :post, :create, :project_id => '1', :issue_category => {:name => ''}
+                end
+                assert_response :success
+                assert_match /alert/, @response.body
+              end
               def test_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 2
                 assert_response :success
                 assert_template 'edit'
               end
               def test_update
                 assert_no_difference 'IssueCategory.count' do
                   put :update, :id => 2, :issue_category => { :name => 'Testing' }
                 end
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_equal 'Testing', IssueCategory.find(2).name
               end
               def test_update_failure
                 put :update, :id => 2, :issue_category => { :name => '' }
                 assert_response :success
                 assert_template 'edit'
               end
               def test_update_not_found
                 put :update, :id => 97, :issue_category => { :name => 'Testing' }
                 assert_response 404
               end
               def test_destroy_category_not_in_use
                 delete :destroy, :id => 2
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(2)
               end
               def test_destroy_category_in_use
                 delete :destroy, :id => 1
                 assert_response :success
                 assert_template 'destroy'
                 assert_not_nil IssueCategory.find_by_id(1)
               end
               def test_destroy_category_in_use_with_reassignment
                 issue = Issue.find(:first, :conditions => {:category_id => 1})
                 delete :destroy, :id => 1, :todo => 'reassign', :reassign_to_id => 2
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(1)
                 # check that the issue was reassign
                 assert_equal 2, issue.reload.category_id
               end
               def test_destroy_category_in_use_without_reassignment
                 issue = Issue.find(:first, :conditions => {:category_id => 1})
                 delete :destroy, :id => 1, :todo => 'nullify'
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(1)
                 # check that the issue category was nullified
                 assert_nil issue.reload.category_id
               end
             end

test/functional/issue_statuses_controller_test.rb +14 0

             require File.expand_path('../../test_helper', __FILE__)
             require 'issue_statuses_controller'
             # Re-raise errors caught by the controller.
             class IssueStatusesController; def rescue_action(e) raise e end; end
             class IssueStatusesControllerTest < ActionController::TestCase
               fixtures :issue_statuses, :issues
               def setup
                 @controller = IssueStatusesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 @request.session[:user_id] = 1 # admin
               end
               def test_index
                 get :index
                 assert_response :success
                 assert_template 'index'
               end
               def test_index_by_anonymous_should_redirect_to_login_form
                 @request.session[:user_id] = nil
                 get :index
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fissue_statuses'
               end
               def test_index_by_user_should_respond_with_406
                 @request.session[:user_id] = 2
                 get :index
                 assert_response 406
               end
               def test_new
                 get :new
                 assert_response :success
                 assert_template 'new'
               end
               def test_create
                 assert_difference 'IssueStatus.count' do
                   post :create, :issue_status => {:name => 'New status'}
                 end
                 assert_redirected_to :action => 'index'
                 status = IssueStatus.find(:first, :order => 'id DESC')
                 assert_equal 'New status', status.name
               end
+              def test_create_with_failure
+                post :create, :issue_status => {:name => ''}
+                assert_response :success
+                assert_template 'new'
+                assert_error_tag :content => /name can't be blank/i
+              end
               def test_edit
                 get :edit, :id => '3'
                 assert_response :success
                 assert_template 'edit'
               end
               def test_update
                 put :update, :id => '3', :issue_status => {:name => 'Renamed status'}
                 assert_redirected_to :action => 'index'
                 status = IssueStatus.find(3)
                 assert_equal 'Renamed status', status.name
               end
+              def test_update_with_failure
+                put :update, :id => '3', :issue_status => {:name => ''}
+                assert_response :success
+                assert_template 'edit'
+                assert_error_tag :content => /name can't be blank/i
+              end
               def test_destroy
                 Issue.delete_all("status_id = 1")
                 assert_difference 'IssueStatus.count', -1 do
                   delete :destroy, :id => '1'
                 end
                 assert_redirected_to :action => 'index'
                 assert_nil IssueStatus.find_by_id(1)
               end
               def test_destroy_should_block_if_status_in_use
                 assert_not_nil Issue.find_by_status_id(1)
                 assert_no_difference 'IssueStatus.count' do
                   delete :destroy, :id => '1'
                 end
                 assert_redirected_to :action => 'index'
                 assert_not_nil IssueStatus.find_by_id(1)
               end
               def test_update_issue_done_ratio_with_issue_done_ratio_set_to_issue_field
                 with_settings :issue_done_ratio => 'issue_field' do
                   post :update_issue_done_ratio
                   assert_match /not updated/, flash[:error].to_s
                   assert_redirected_to '/issue_statuses'
                 end
               end
               def test_update_issue_done_ratio_with_issue_done_ratio_set_to_issue_status
                 with_settings :issue_done_ratio => 'issue_status' do
                   post :update_issue_done_ratio
                   assert_match /Issue done ratios updated/, flash[:notice].to_s
                   assert_redirected_to '/issue_statuses'
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages