jro_apps/redmine Commit - r11840:c49451eb102d

not use assert_not_nil in Errors#[]...

Toshi MARUYAMA -

r11840:c49451eb102d

parent child

Context file:

r11840:c49451eb102d

Collapse all files

test/functional/projects_controller_test.rb +3 -3

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class ProjectsControllerTest < ActionController::TestCase
                fixtures :projects, :versions, :users, :roles, :members, :member_roles, :issues, :journals, :journal_details,
                         :trackers, :projects_trackers, :issue_statuses, :enabled_modules, :enumerations, :boards, :messages,
                         :attachments, :custom_fields, :custom_values, :time_entries
                def setup
                  @request.session[:user_id] = nil
                  Setting.default_language = 'en'
                end
                def test_index_by_anonymous_should_not_show_private_projects
                  get :index
                  assert_response :success
                  assert_template 'index'
                  projects = assigns(:projects)
                  assert_not_nil projects
                  assert projects.all?(&:is_public?)
                  assert_select 'ul' do
                    assert_select 'li' do
                      assert_select 'a', :text => 'eCookbook'
                      assert_select 'ul' do
                        assert_select 'a', :text => 'Child of private child'
                      end
                    end
                  end
                  assert_select 'a', :text => /Private child of eCookbook/, :count => 0
                end
                def test_index_atom
                  get :index, :format => 'atom'
                  assert_response :success
                  assert_template 'common/feed'
                  assert_select 'feed>title', :text => 'Redmine: Latest projects'
                  assert_select 'feed>entry', :count => Project.visible(User.current).count
                end
                test "#index by non-admin user with view_time_entries permission should show overall spent time link" do
                  @request.session[:user_id] = 3
                  get :index
                  assert_template 'index'
                  assert_select 'a[href=?]', '/time_entries'
                end
                test "#index by non-admin user without view_time_entries permission should not show overall spent time link" do
                  Role.find(2).remove_permission! :view_time_entries
                  Role.non_member.remove_permission! :view_time_entries
                  Role.anonymous.remove_permission! :view_time_entries
                  @request.session[:user_id] = 3
                  get :index
                  assert_template 'index'
                  assert_select 'a[href=?]', '/time_entries', 0
                end
                test "#new by admin user should accept get" do
                  @request.session[:user_id] = 1
                  get :new
                  assert_response :success
                  assert_template 'new'
                end
                test "#new by non-admin user with add_project permission should accept get" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  get :new
                  assert_response :success
                  assert_template 'new'
                  assert_select 'select[name=?]', 'project[parent_id]', 0
                end
                test "#new by non-admin user with add_subprojects permission should accept get" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  get :new, :parent_id => 'ecookbook'
                  assert_response :success
                  assert_template 'new'
                  assert_select 'select[name=?]', 'project[parent_id]' do
                    # parent project selected
                    assert_select 'option[value=1][selected=selected]'
                    # no empty value
                    assert_select 'option[value=]', 0
                  end
                end
                test "#create by admin user should create a new project" do
                  @request.session[:user_id] = 1
                  post :create,
                    :project => {
                      :name => "blog",
                      :description => "weblog",
                      :homepage => 'http://weblog',
                      :identifier => "blog",
                      :is_public => 1,
                      :custom_field_values => { '3' => 'Beta' },
                      :tracker_ids => ['1', '3'],
                      # an issue custom field that is not for all project
                      :issue_custom_field_ids => ['9'],
                      :enabled_module_names => ['issue_tracking', 'news', 'repository']
                    }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert project.active?
                  assert_equal 'weblog', project.description
                  assert_equal 'http://weblog', project.homepage
                  assert_equal true, project.is_public?
                  assert_nil project.parent
                  assert_equal 'Beta', project.custom_value_for(3).value
                  assert_equal [1, 3], project.trackers.map(&:id).sort
                  assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                  assert project.issue_custom_fields.include?(IssueCustomField.find(9))
                end
                test "#create by admin user should create a new subproject" do
                  @request.session[:user_id] = 1
                  assert_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 1
                                            }
                    assert_redirected_to '/projects/blog/settings'
                  end
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert_equal Project.find(1), project.parent
                end
                test "#create by admin user should continue" do
                  @request.session[:user_id] = 1
                  assert_difference 'Project.count' do
                    post :create, :project => {:name => "blog", :identifier => "blog"}, :continue => 'Create and continue'
                  end
                  assert_redirected_to '/projects/new'
                end
                test "#create by non-admin user with add_project permission should create a new project" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  post :create, :project => { :name => "blog",
                                           :description => "weblog",
                                           :identifier => "blog",
                                           :is_public => 1,
                                           :custom_field_values => { '3' => 'Beta' },
                                           :tracker_ids => ['1', '3'],
                                           :enabled_module_names => ['issue_tracking', 'news', 'repository']
                                          }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                  assert_kind_of Project, project
                  assert_equal 'weblog', project.description
                  assert_equal true, project.is_public?
                  assert_equal [1, 3], project.trackers.map(&:id).sort
                  assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                  # User should be added as a project member
                  assert User.find(9).member_of?(project)
                  assert_equal 1, project.members.size
                end
                test "#create by non-admin user with add_project permission should fail with parent_id" do
                  Role.non_member.add_permission! :add_project
                  @request.session[:user_id] = 9
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 1
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
-                 assert_not_nil project.errors[:parent_id]
+                 assert_not_equal [], project.errors[:parent_id]
                end
                test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  post :create, :project => { :name => "blog",
                                           :description => "weblog",
                                           :identifier => "blog",
                                           :is_public => 1,
                                           :custom_field_values => { '3' => 'Beta' },
                                           :parent_id => 1
                                          }
                  assert_redirected_to '/projects/blog/settings'
                  project = Project.find_by_name('blog')
                end
                test "#create by non-admin user with add_subprojects permission should fail without parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' }
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
-                 assert_not_nil project.errors[:parent_id]
+                 assert_not_equal [], project.errors[:parent_id]
                end
                test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do
                  Role.find(1).remove_permission! :add_project
                  Role.find(1).add_permission! :add_subprojects
                  @request.session[:user_id] = 2
                  assert !User.find(2).member_of?(Project.find(6))
                  assert_no_difference 'Project.count' do
                    post :create, :project => { :name => "blog",
                                             :description => "weblog",
                                             :identifier => "blog",
                                             :is_public => 1,
                                             :custom_field_values => { '3' => 'Beta' },
                                             :parent_id => 6
                                            }
                  end
                  assert_response :success
                  project = assigns(:project)
                  assert_kind_of Project, project
-                 assert_not_nil project.errors[:parent_id]
+                 assert_not_equal [], project.errors[:parent_id]
                end
                def test_create_subproject_with_inherit_members_should_inherit_members
                  Role.find_by_name('Manager').add_permission! :add_subprojects
                  parent = Project.find(1)
                  @request.session[:user_id] = 2
                  assert_difference 'Project.count' do
                    post :create, :project => {
                      :name => 'inherited', :identifier => 'inherited', :parent_id => parent.id, :inherit_members => '1'
                    }
                    assert_response 302
                  end
                  project = Project.order('id desc').first
                  assert_equal 'inherited', project.name
                  assert_equal parent, project.parent
                  assert project.memberships.count > 0
                  assert_equal parent.memberships.count, project.memberships.count
                end
                def test_create_should_preserve_modules_on_validation_failure
                  with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                    @request.session[:user_id] = 1
                    assert_no_difference 'Project.count' do
                      post :create, :project => {
                        :name => "blog",
                        :identifier => "",
                        :enabled_module_names => %w(issue_tracking news)
                      }
                    end
                    assert_response :success
                    project = assigns(:project)
                    assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                  end
                end
                def test_show_by_id
                  get :show, :id => 1
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                end
                def test_show_by_identifier
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                  assert_select 'li', :text => /Development status/
                end
                def test_show_should_not_display_hidden_custom_fields
                  ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_select 'li', :text => /Development status/, :count => 0
                end
                def test_show_should_not_fail_when_custom_values_are_nil
                  project = Project.find_by_identifier('ecookbook')
                  project.custom_values.first.update_attribute(:value, nil)
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:project)
                  assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                end
                def show_archived_project_should_be_denied
                  project = Project.find_by_identifier('ecookbook')
                  project.archive!
                  get :show, :id => 'ecookbook'
                  assert_response 403
                  assert_nil assigns(:project)
                  assert_select 'p', :text => /archived/
                end
                def test_show_should_not_show_private_subprojects_that_are_not_visible
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_select 'a', :text => /Private child/, :count => 0
                end
                def test_show_should_show_private_subprojects_that_are_visible
                  @request.session[:user_id] = 2 # manager who is a member of the private subproject
                  get :show, :id => 'ecookbook'
                  assert_response :success
                  assert_template 'show'
                  assert_select 'a', :text => /Private child/
                end
                def test_settings
                  @request.session[:user_id] = 2 # manager
                  get :settings, :id => 1
                  assert_response :success
                  assert_template 'settings'
                end
                def test_settings_of_subproject
                  @request.session[:user_id] = 2
                  get :settings, :id => 'private-child'
                  assert_response :success
                  assert_template 'settings'
                  assert_select 'input[type=checkbox][name=?]', 'project[inherit_members]'
                end
                def test_settings_should_be_denied_for_member_on_closed_project
                  Project.find(1).close
                  @request.session[:user_id] = 2 # manager
                  get :settings, :id => 1
                  assert_response 403
                end
                def test_settings_should_be_denied_for_anonymous_on_closed_project
                  Project.find(1).close
                  get :settings, :id => 1
                  assert_response 302
                end
                def test_update
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => 'Test changed name',
                                                     :issue_custom_field_ids => ['']}
                  assert_redirected_to '/projects/ecookbook/settings'
                  project = Project.find(1)
                  assert_equal 'Test changed name', project.name
                end
                def test_update_with_failure
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => ''}
                  assert_response :success
                  assert_template 'settings'
                  assert_error_tag :content => /name can&#x27;t be blank/i
                end
                def test_update_should_be_denied_for_member_on_closed_project
                  Project.find(1).close
                  @request.session[:user_id] = 2 # manager
                  post :update, :id => 1, :project => {:name => 'Closed'}
                  assert_response 403
                  assert_equal 'eCookbook', Project.find(1).name
                end
                def test_update_should_be_denied_for_anonymous_on_closed_project
                  Project.find(1).close
                  post :update, :id => 1, :project => {:name => 'Closed'}
                  assert_response 302
                  assert_equal 'eCookbook', Project.find(1).name
                end
                def test_modules
                  @request.session[:user_id] = 2
                  Project.find(1).enabled_module_names = ['issue_tracking', 'news']
                  post :modules, :id => 1, :enabled_module_names => ['issue_tracking', 'repository', 'documents']
                  assert_redirected_to '/projects/ecookbook/settings/modules'
                  assert_equal ['documents', 'issue_tracking', 'repository'], Project.find(1).enabled_module_names.sort
                end
                def test_destroy_leaf_project_without_confirmation_should_show_confirmation
                  @request.session[:user_id] = 1 # admin
                  assert_no_difference 'Project.count' do
                    delete :destroy, :id => 2
                    assert_response :success
                    assert_template 'destroy'
                  end
                end
                def test_destroy_without_confirmation_should_show_confirmation_with_subprojects
                  @request.session[:user_id] = 1 # admin
                  assert_no_difference 'Project.count' do
                    delete :destroy, :id => 1
                    assert_response :success
                    assert_template 'destroy'
                  end
                  assert_select 'strong',
                                :text => ['Private child of eCookbook',
                                          'Child of private child, eCookbook Subproject 1',
                                          'eCookbook Subproject 2'].join(', ')
                end
                def test_destroy_with_confirmation_should_destroy_the_project_and_subprojects
                  @request.session[:user_id] = 1 # admin
                  assert_difference 'Project.count', -5 do
                    delete :destroy, :id => 1, :confirm => 1
                    assert_redirected_to '/admin/projects'
                  end
                  assert_nil Project.find_by_id(1)
                end
                def test_archive
                  @request.session[:user_id] = 1 # admin
                  post :archive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert !Project.find(1).active?
                end
                def test_archive_with_failure
                  @request.session[:user_id] = 1
                  Project.any_instance.stubs(:archive).returns(false)
                  post :archive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert_match /project cannot be archived/i, flash[:error]
                end
                def test_unarchive
                  @request.session[:user_id] = 1 # admin
                  Project.find(1).archive
                  post :unarchive, :id => 1
                  assert_redirected_to '/admin/projects'
                  assert Project.find(1).active?
                end
                def test_close
                  @request.session[:user_id] = 2
                  post :close, :id => 1
                  assert_redirected_to '/projects/ecookbook'
                  assert_equal Project::STATUS_CLOSED, Project.find(1).status
                end
                def test_reopen
                  Project.find(1).close
                  @request.session[:user_id] = 2
                  post :reopen, :id => 1
                  assert_redirected_to '/projects/ecookbook'
                  assert Project.find(1).active?
                end
                def test_project_breadcrumbs_should_be_limited_to_3_ancestors
                  CustomField.delete_all
                  parent = nil
 .times do |i|
                    p = Project.generate_with_parent!(parent)
                    get :show, :id => p
                    assert_select '#header h1' do
                      assert_select 'a', :count => [i, 3].min
                    end
                    parent = p
                  end
                end
                def test_get_copy
                  @request.session[:user_id] = 1 # admin
                  get :copy, :id => 1
                  assert_response :success
                  assert_template 'copy'
                  assert assigns(:project)
                  assert_equal Project.find(1).description, assigns(:project).description
                  assert_nil assigns(:project).id
                  assert_select 'input[name=?][value=?]', 'project[enabled_module_names][]', 'issue_tracking', 1
                end
                def test_get_copy_with_invalid_source_should_respond_with_404
                  @request.session[:user_id] = 1
                  get :copy, :id => 99
                  assert_response 404
                end
                def test_post_copy_should_copy_requested_items
                  @request.session[:user_id] = 1 # admin
                  CustomField.delete_all
                  assert_difference 'Project.count' do
                    post :copy, :id => 1,
                      :project => {
                        :name => 'Copy',
                        :identifier => 'unique-copy',
                        :tracker_ids => ['1', '2', '3', ''],
                        :enabled_module_names => %w(issue_tracking time_tracking)
                      },
                      :only => %w(issues versions)
                  end
                  project = Project.find('unique-copy')
                  source = Project.find(1)
                  assert_equal %w(issue_tracking time_tracking), project.enabled_module_names.sort
                  assert_equal source.versions.count, project.versions.count, "All versions were not copied"
                  assert_equal source.issues.count, project.issues.count, "All issues were not copied"
                  assert_equal 0, project.members.count
                end
                def test_post_copy_should_redirect_to_settings_when_successful
                  @request.session[:user_id] = 1 # admin
                  post :copy, :id => 1, :project => {:name => 'Copy', :identifier => 'unique-copy'}
                  assert_response :redirect
                  assert_redirected_to :controller => 'projects', :action => 'settings', :id => 'unique-copy'
                end
                def test_jump_should_redirect_to_active_tab
                  get :show, :id => 1, :jump => 'issues'
                  assert_redirected_to '/projects/ecookbook/issues'
                end
                def test_jump_should_not_redirect_to_inactive_tab
                  get :show, :id => 3, :jump => 'documents'
                  assert_response :success
                  assert_template 'show'
                end
                def test_jump_should_not_redirect_to_unknown_tab
                  get :show, :id => 3, :jump => 'foobar'
                  assert_response :success
                  assert_template 'show'
                end
              end

test/unit/attachment_test.rb +1 -1

              # encoding: utf-8
              #
              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class AttachmentTest < ActiveSupport::TestCase
                fixtures :users, :projects, :roles, :members, :member_roles,
                         :enabled_modules, :issues, :trackers, :attachments
                class MockFile
                  attr_reader :original_filename, :content_type, :content, :size
                  def initialize(attributes)
                    @original_filename = attributes[:original_filename]
                    @content_type = attributes[:content_type]
                    @content = attributes[:content] || "Content"
                    @size = content.size
                  end
                end
                def setup
                  set_tmp_attachments_directory
                end
                def test_container_for_new_attachment_should_be_nil
                  assert_nil Attachment.new.container
                end
                def test_create
                  a = Attachment.new(:container => Issue.find(1),
                                     :file => uploaded_test_file("testfile.txt", "text/plain"),
                                     :author => User.find(1))
                  assert a.save
                  assert_equal 'testfile.txt', a.filename
                  assert_equal 59, a.filesize
                  assert_equal 'text/plain', a.content_type
                  assert_equal 0, a.downloads
                  assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
                  assert a.disk_directory
                  assert_match %r{\A\d{4}/\d{2}\z}, a.disk_directory
                  assert File.exist?(a.diskfile)
                  assert_equal 59, File.size(a.diskfile)
                end
                def test_copy_should_preserve_attributes
                  a = Attachment.find(1)
                  copy = a.copy
                  assert_save copy
                  copy = Attachment.order('id DESC').first
                  %w(filename filesize content_type author_id created_on description digest disk_filename disk_directory diskfile).each do |attribute|
                    assert_equal a.send(attribute), copy.send(attribute), "#{attribute} was different"
                  end
                end
                def test_size_should_be_validated_for_new_file
                  with_settings :attachment_max_size => 0 do
                    a = Attachment.new(:container => Issue.find(1),
                                       :file => uploaded_test_file("testfile.txt", "text/plain"),
                                       :author => User.find(1))
                    assert !a.save
                  end
                end
                def test_size_should_not_be_validated_when_copying
                  a = Attachment.create!(:container => Issue.find(1),
                                         :file => uploaded_test_file("testfile.txt", "text/plain"),
                                         :author => User.find(1))
                  with_settings :attachment_max_size => 0 do
                    copy = a.copy
                    assert copy.save
                  end
                end
                def test_description_length_should_be_validated
                  a = Attachment.new(:description => 'a' * 300)
                  assert !a.save
-                 assert_not_nil a.errors[:description]
+                 assert_not_equal [], a.errors[:description]
                end
                def test_destroy
                  a = Attachment.new(:container => Issue.find(1),
                                     :file => uploaded_test_file("testfile.txt", "text/plain"),
                                     :author => User.find(1))
                  assert a.save
                  assert_equal 'testfile.txt', a.filename
                  assert_equal 59, a.filesize
                  assert_equal 'text/plain', a.content_type
                  assert_equal 0, a.downloads
                  assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
                  diskfile = a.diskfile
                  assert File.exist?(diskfile)
                  assert_equal 59, File.size(a.diskfile)
                  assert a.destroy
                  assert !File.exist?(diskfile)
                end
                def test_destroy_should_not_delete_file_referenced_by_other_attachment
                  a = Attachment.create!(:container => Issue.find(1),
                                         :file => uploaded_test_file("testfile.txt", "text/plain"),
                                         :author => User.find(1))
                  diskfile = a.diskfile
                  copy = a.copy
                  copy.save!
                  assert File.exists?(diskfile)
                  a.destroy
                  assert File.exists?(diskfile)
                  copy.destroy
                  assert !File.exists?(diskfile)
                end
                def test_create_should_auto_assign_content_type
                  a = Attachment.new(:container => Issue.find(1),
                                     :file => uploaded_test_file("testfile.txt", ""),
                                     :author => User.find(1))
                  assert a.save
                  assert_equal 'text/plain', a.content_type
                end
                def test_identical_attachments_at_the_same_time_should_not_overwrite
                  a1 = Attachment.create!(:container => Issue.find(1),
                                          :file => uploaded_test_file("testfile.txt", ""),
                                          :author => User.find(1))
                  a2 = Attachment.create!(:container => Issue.find(1),
                                          :file => uploaded_test_file("testfile.txt", ""),
                                          :author => User.find(1))
                  assert a1.disk_filename != a2.disk_filename
                end
                def test_filename_should_be_basenamed
                  a = Attachment.new(:file => MockFile.new(:original_filename => "path/to/the/file"))
                  assert_equal 'file', a.filename
                end
                def test_filename_should_be_sanitized
                  a = Attachment.new(:file => MockFile.new(:original_filename => "valid:[] invalid:?%*|\"'<>chars"))
                  assert_equal 'valid_[] invalid_chars', a.filename
                end
                def test_diskfilename
                  assert Attachment.disk_filename("test_file.txt") =~ /^\d{12}_test_file.txt$/
                  assert_equal 'test_file.txt', Attachment.disk_filename("test_file.txt")[13..-1]
                  assert_equal '770c509475505f37c2b8fb6030434d6b.txt', Attachment.disk_filename("test_accentué.txt")[13..-1]
                  assert_equal 'f8139524ebb8f32e51976982cd20a85d', Attachment.disk_filename("test_accentué")[13..-1]
                  assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', Attachment.disk_filename("test_accentué.ça")[13..-1]
                end
                def test_title
                  a = Attachment.new(:filename => "test.png")
                  assert_equal "test.png", a.title
                  a = Attachment.new(:filename => "test.png", :description => "Cool image")
                  assert_equal "test.png (Cool image)", a.title
                end
                def test_prune_should_destroy_old_unattached_attachments
                  Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1, :created_on => 2.days.ago)
                  Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1, :created_on => 2.days.ago)
                  Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1)
                  assert_difference 'Attachment.count', -2 do
                    Attachment.prune
                  end
                end
                def test_move_from_root_to_target_directory_should_move_root_files
                  a = Attachment.find(20)
                  assert a.disk_directory.blank?
                  # Create a real file for this fixture
                  File.open(a.diskfile, "w") do |f|
                    f.write "test file at the root of files directory"
                  end
                  assert a.readable?
                  Attachment.move_from_root_to_target_directory
                  a.reload
                  assert_equal '2012/05', a.disk_directory
                  assert a.readable?
                end
                test "Attachmnet.attach_files should attach the file" do
                  issue = Issue.first
                  assert_difference 'Attachment.count' do
                    Attachment.attach_files(issue,
                      '1' => {
                        'file' => uploaded_test_file('testfile.txt', 'text/plain'),
                        'description' => 'test'
                      })
                  end
                  attachment = Attachment.first(:order => 'id DESC')
                  assert_equal issue, attachment.container
                  assert_equal 'testfile.txt', attachment.filename
                  assert_equal 59, attachment.filesize
                  assert_equal 'test', attachment.description
                  assert_equal 'text/plain', attachment.content_type
                  assert File.exists?(attachment.diskfile)
                  assert_equal 59, File.size(attachment.diskfile)
                end
                test "Attachmnet.attach_files should add unsaved files to the object as unsaved attachments" do
                  # Max size of 0 to force Attachment creation failures
                  with_settings(:attachment_max_size => 0) do
                    @project = Project.find(1)
                    response = Attachment.attach_files(@project, {
                                                         '1' => {'file' => mock_file, 'description' => 'test'},
                                                         '2' => {'file' => mock_file, 'description' => 'test'}
                                                       })
                    assert response[:unsaved].present?
                    assert_equal 2, response[:unsaved].length
                    assert response[:unsaved].first.new_record?
                    assert response[:unsaved].second.new_record?
                    assert_equal response[:unsaved], @project.unsaved_attachments
                  end
                end
                def test_latest_attach
                  set_fixtures_attachments_directory
                  a1 = Attachment.find(16)
                  assert_equal "testfile.png", a1.filename
                  assert a1.readable?
                  assert (! a1.visible?(User.anonymous))
                  assert a1.visible?(User.find(2))
                  a2 = Attachment.find(17)
                  assert_equal "testfile.PNG", a2.filename
                  assert a2.readable?
                  assert (! a2.visible?(User.anonymous))
                  assert a2.visible?(User.find(2))
                  assert a1.created_on < a2.created_on
                  la1 = Attachment.latest_attach([a1, a2], "testfile.png")
                  assert_equal 17, la1.id
                  la2 = Attachment.latest_attach([a1, a2], "Testfile.PNG")
                  assert_equal 17, la2.id
                  set_tmp_attachments_directory
                end
                def test_thumbnailable_should_be_true_for_images
                  assert_equal true, Attachment.new(:filename => 'test.jpg').thumbnailable?
                end
                def test_thumbnailable_should_be_true_for_non_images
                  assert_equal false, Attachment.new(:filename => 'test.txt').thumbnailable?
                end
                if convert_installed?
                  def test_thumbnail_should_generate_the_thumbnail
                    set_fixtures_attachments_directory
                    attachment = Attachment.find(16)
                    Attachment.clear_thumbnails
                    assert_difference "Dir.glob(File.join(Attachment.thumbnails_storage_path, '*.thumb')).size" do
                      thumbnail = attachment.thumbnail
                      assert_equal "16_8e0294de2441577c529f170b6fb8f638_100.thumb", File.basename(thumbnail)
                      assert File.exists?(thumbnail)
                    end
                  end
                else
                  puts '(ImageMagick convert not available)'
                end
              end

test/unit/issue_nested_set_test.rb +2 -2

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueNestedSetTest < ActiveSupport::TestCase
                fixtures :projects, :users, :roles,
                         :trackers, :projects_trackers,
                         :issue_statuses, :issue_categories, :issue_relations,
                         :enumerations,
                         :issues
                def test_create_root_issue
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue1.reload
                  issue2.reload
                  assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
                  assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
                end
                def test_create_child_issue
                  parent = Issue.generate!
                  child =  Issue.generate!(:parent_issue_id => parent.id)
                  parent.reload
                  child.reload
                  assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
                  assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
                end
                def test_creating_a_child_in_a_subproject_should_validate
                  issue = Issue.generate!
                  child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1,
                                    :subject => 'child', :parent_issue_id => issue.id)
                  assert_save child
                  assert_equal issue, child.reload.parent
                end
                def test_creating_a_child_in_an_invalid_project_should_not_validate
                  issue = Issue.generate!
                  child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                                    :subject => 'child', :parent_issue_id => issue.id)
                  assert !child.save
-                 assert_not_nil child.errors[:parent_issue_id]
+                 assert_not_equal [], child.errors[:parent_issue_id]
                end
                def test_move_a_root_to_child
                  parent1 = Issue.generate!
                  parent2 = Issue.generate!
                  child = Issue.generate!(:parent_issue_id => parent1.id)
                  parent2.parent_issue_id = parent1.id
                  parent2.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_to_root
                  parent1 = Issue.generate!
                  parent2 = Issue.generate!
                  child =   Issue.generate!(:parent_issue_id => parent1.id)
                  child.parent_issue_id = nil
                  child.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_to_another_issue
                  parent1 = Issue.generate!
                  parent2 = Issue.generate!
                  child =   Issue.generate!(:parent_issue_id => parent1.id)
                  child.parent_issue_id = parent2.id
                  child.save!
                  child.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
                end
                def test_move_a_child_with_descendants_to_another_issue
                  parent1 = Issue.generate!
                  parent2 = Issue.generate!
                  child =   Issue.generate!(:parent_issue_id => parent1.id)
                  grandchild = Issue.generate!(:parent_issue_id => child.id)
                  parent1.reload
                  parent2.reload
                  child.reload
                  grandchild.reload
                  assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
                  assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                  child.reload.parent_issue_id = parent2.id
                  child.save!
                  child.reload
                  grandchild.reload
                  parent1.reload
                  parent2.reload
                  assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
                  assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
                  assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
                end
                def test_move_a_child_with_descendants_to_another_project
                  parent1 = Issue.generate!
                  child =   Issue.generate!(:parent_issue_id => parent1.id)
                  grandchild = Issue.generate!(:parent_issue_id => child.id)
                  child.reload
                  child.project = Project.find(2)
                  assert child.save
                  child.reload
                  grandchild.reload
                  parent1.reload
                  assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
                  assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
                  assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
                end
                def test_moving_an_issue_to_a_descendant_should_not_validate
                  parent1 = Issue.generate!
                  parent2 = Issue.generate!
                  child =   Issue.generate!(:parent_issue_id => parent1.id)
                  grandchild = Issue.generate!(:parent_issue_id => child.id)
                  child.reload
                  child.parent_issue_id = grandchild.id
                  assert !child.save
-                 assert_not_nil child.errors[:parent_issue_id]
+                 assert_not_equal [], child.errors[:parent_issue_id]
                end
                def test_destroy_should_destroy_children
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue3 = Issue.generate!(:parent_issue_id => issue2.id)
                  issue4 = Issue.generate!(:parent_issue_id => issue1.id)
                  issue3.init_journal(User.find(2))
                  issue3.subject = 'child with journal'
                  issue3.save!
                  assert_difference 'Issue.count', -2 do
                    assert_difference 'Journal.count', -1 do
                      assert_difference 'JournalDetail.count', -1 do
                        Issue.find(issue2.id).destroy
                      end
                    end
                  end
                  issue1.reload
                  issue4.reload
                  assert !Issue.exists?(issue2.id)
                  assert !Issue.exists?(issue3.id)
                  assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
                  assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
                end
                def test_destroy_child_should_update_parent
                  issue = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => issue.id)
                  child2 = Issue.generate!(:parent_issue_id => issue.id)
                  issue.reload
                  assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
                  child2.reload.destroy
                  issue.reload
                  assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
                end
                def test_destroy_parent_issue_updated_during_children_destroy
                  parent = Issue.generate!
                  Issue.generate!(:start_date => Date.today, :parent_issue_id => parent.id)
                  Issue.generate!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
                  assert_difference 'Issue.count', -3 do
                    Issue.find(parent.id).destroy
                  end
                end
                def test_destroy_child_issue_with_children
                  root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
                  child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
                  leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
                  leaf.init_journal(User.find(2))
                  leaf.subject = 'leaf with journal'
                  leaf.save!
                  assert_difference 'Issue.count', -2 do
                    assert_difference 'Journal.count', -1 do
                      assert_difference 'JournalDetail.count', -1 do
                        Issue.find(child.id).destroy
                      end
                    end
                  end
                  root = Issue.find(root.id)
                  assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
                end
                def test_destroy_issue_with_grand_child
                  parent = Issue.generate!
                  issue = Issue.generate!(:parent_issue_id => parent.id)
                  child = Issue.generate!(:parent_issue_id => issue.id)
                  grandchild1 = Issue.generate!(:parent_issue_id => child.id)
                  grandchild2 = Issue.generate!(:parent_issue_id => child.id)
                  assert_difference 'Issue.count', -4 do
                    Issue.find(issue.id).destroy
                    parent.reload
                    assert_equal [1, 2], [parent.lft, parent.rgt]
                  end
                end
                def test_parent_priority_should_be_the_highest_child_priority
                  parent = Issue.generate!(:priority => IssuePriority.find_by_name('Normal'))
                  # Create children
                  child1 = Issue.generate!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
                  assert_equal 'High', parent.reload.priority.name
                  child2 = Issue.generate!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
                  assert_equal 'Immediate', child1.reload.priority.name
                  assert_equal 'Immediate', parent.reload.priority.name
                  child3 = Issue.generate!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
                  assert_equal 'Immediate', parent.reload.priority.name
                  # Destroy a child
                  child1.destroy
                  assert_equal 'Low', parent.reload.priority.name
                  # Update a child
                  child3.reload.priority = IssuePriority.find_by_name('Normal')
                  child3.save!
                  assert_equal 'Normal', parent.reload.priority.name
                end
                def test_parent_dates_should_be_lowest_start_and_highest_due_dates
                  parent = Issue.generate!
                  Issue.generate!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
                  Issue.generate!(                             :due_date => '2010-02-13', :parent_issue_id => parent.id)
                  Issue.generate!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
                  parent.reload
                  assert_equal Date.parse('2010-01-25'), parent.start_date
                  assert_equal Date.parse('2010-02-22'), parent.due_date
                end
                def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
                  parent = Issue.generate!
                  Issue.generate!(:done_ratio => 20, :parent_issue_id => parent.id)
                  assert_equal 20, parent.reload.done_ratio
                  Issue.generate!(:done_ratio => 70, :parent_issue_id => parent.id)
                  assert_equal 45, parent.reload.done_ratio
                  child = Issue.generate!(:done_ratio => 0, :parent_issue_id => parent.id)
                  assert_equal 30, parent.reload.done_ratio
                  Issue.generate!(:done_ratio => 30, :parent_issue_id => child.id)
                  assert_equal 30, child.reload.done_ratio
                  assert_equal 40, parent.reload.done_ratio
                end
                def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
                  parent = Issue.generate!
                  Issue.generate!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
                  assert_equal 20, parent.reload.done_ratio
                  Issue.generate!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
                  assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
                end
                def test_parent_estimate_should_be_sum_of_leaves
                  parent = Issue.generate!
                  Issue.generate!(:estimated_hours => nil, :parent_issue_id => parent.id)
                  assert_equal nil, parent.reload.estimated_hours
                  Issue.generate!(:estimated_hours => 5, :parent_issue_id => parent.id)
                  assert_equal 5, parent.reload.estimated_hours
                  Issue.generate!(:estimated_hours => 7, :parent_issue_id => parent.id)
                  assert_equal 12, parent.reload.estimated_hours
                end
                def test_move_parent_updates_old_parent_attributes
                  first_parent = Issue.generate!
                  second_parent = Issue.generate!
                  child = Issue.generate!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
                  assert_equal 5, first_parent.reload.estimated_hours
                  child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
                  assert_equal 7, second_parent.reload.estimated_hours
                  assert_nil first_parent.reload.estimated_hours
                end
                def test_reschuling_a_parent_should_reschedule_subtasks
                  parent = Issue.generate!
                  c1 = Issue.generate!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
                  c2 = Issue.generate!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
                  parent.reload
                  parent.reschedule_on!(Date.parse('2010-06-02'))
                  c1.reload
                  assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
                  c2.reload
                  assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
                  parent.reload
                  assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
                end
                def test_project_copy_should_copy_issue_tree
                  p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
                  i1 = Issue.generate!(:project => p, :subject => 'i1')
                  i2 = Issue.generate!(:project => p, :subject => 'i2', :parent_issue_id => i1.id)
                  i3 = Issue.generate!(:project => p, :subject => 'i3', :parent_issue_id => i1.id)
                  i4 = Issue.generate!(:project => p, :subject => 'i4', :parent_issue_id => i2.id)
                  i5 = Issue.generate!(:project => p, :subject => 'i5')
                  c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
                  c.copy(p, :only => 'issues')
                  c.reload
                  assert_equal 5, c.issues.count
                  ic1, ic2, ic3, ic4, ic5 = c.issues.order('subject').all
                  assert ic1.root?
                  assert_equal ic1, ic2.parent
                  assert_equal ic1, ic3.parent
                  assert_equal ic2, ic4.parent
                  assert ic5.root?
                end
              end

test/unit/issue_relation_test.rb +2 -2

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueRelationTest < ActiveSupport::TestCase
                fixtures :projects,
                         :users,
                         :roles,
                         :members,
                         :member_roles,
                         :issues,
                         :issue_statuses,
                         :issue_relations,
                         :enabled_modules,
                         :enumerations,
                         :trackers,
                         :projects_trackers
                include Redmine::I18n
                def test_create
                  from = Issue.find(1)
                  to = Issue.find(2)
                  relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                               :relation_type => IssueRelation::TYPE_PRECEDES
                  assert relation.save
                  relation.reload
                  assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
                  assert_equal from, relation.issue_from
                  assert_equal to, relation.issue_to
                end
                def test_create_minimum
                  relation = IssueRelation.new :issue_from => Issue.find(1), :issue_to => Issue.find(2)
                  assert relation.save
                  assert_equal IssueRelation::TYPE_RELATES, relation.relation_type
                end
                def test_follows_relation_should_be_reversed
                  from = Issue.find(1)
                  to = Issue.find(2)
                  relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                               :relation_type => IssueRelation::TYPE_FOLLOWS
                  assert relation.save
                  relation.reload
                  assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type
                  assert_equal to, relation.issue_from
                  assert_equal from, relation.issue_to
                end
                def test_follows_relation_should_not_be_reversed_if_validation_fails
                  from = Issue.find(1)
                  to = Issue.find(2)
                  relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                               :relation_type => IssueRelation::TYPE_FOLLOWS,
                                               :delay => 'xx'
                  assert !relation.save
                  assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type
                  assert_equal from, relation.issue_from
                  assert_equal to, relation.issue_to
                end
                def test_relation_type_for
                  from = Issue.find(1)
                  to = Issue.find(2)
                  relation = IssueRelation.new :issue_from => from, :issue_to => to,
                                               :relation_type => IssueRelation::TYPE_PRECEDES
                  assert_equal IssueRelation::TYPE_PRECEDES, relation.relation_type_for(from)
                  assert_equal IssueRelation::TYPE_FOLLOWS, relation.relation_type_for(to)
                end
                def test_set_issue_to_dates_without_issue_to
                  r = IssueRelation.new(:issue_from => Issue.new(:start_date => Date.today),
                                        :relation_type => IssueRelation::TYPE_PRECEDES,
                                        :delay => 1)
                  assert_nil r.set_issue_to_dates
                end
                def test_set_issue_to_dates_without_issues
                  r = IssueRelation.new(:relation_type => IssueRelation::TYPE_PRECEDES, :delay => 1)
                  assert_nil r.set_issue_to_dates
                end
                def test_validates_circular_dependency
                  IssueRelation.delete_all
                  assert IssueRelation.create!(
                           :issue_from => Issue.find(1), :issue_to => Issue.find(2),
                           :relation_type => IssueRelation::TYPE_PRECEDES
                         )
                  assert IssueRelation.create!(
                           :issue_from => Issue.find(2), :issue_to => Issue.find(3),
                           :relation_type => IssueRelation::TYPE_PRECEDES
                         )
                  r = IssueRelation.new(
                        :issue_from => Issue.find(3), :issue_to => Issue.find(1),
                        :relation_type => IssueRelation::TYPE_PRECEDES
                      )
                  assert !r.save
-                 assert_not_nil r.errors[:base]
+                 assert_not_equal [], r.errors[:base]
                end
                def test_validates_circular_dependency_of_subtask
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  IssueRelation.create!(
                    :issue_from => issue1, :issue_to => issue2,
                    :relation_type => IssueRelation::TYPE_PRECEDES
                  )
                  child = Issue.generate!(:parent_issue_id => issue2.id)
                  issue1.reload
                  child.reload
                  r = IssueRelation.new(
                        :issue_from => child, :issue_to => issue1,
                        :relation_type => IssueRelation::TYPE_PRECEDES
                      )
                  assert !r.save
                  assert_include 'This relation would create a circular dependency', r.errors.full_messages
                end
                def test_subtasks_should_allow_precedes_relation
                  parent = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => parent.id)
                  child2 = Issue.generate!(:parent_issue_id => parent.id)
                  r = IssueRelation.new(
                        :issue_from => child1, :issue_to => child2,
                        :relation_type => IssueRelation::TYPE_PRECEDES
                      )
                  assert r.valid?
                  assert r.save
                end
                def test_validates_circular_dependency_on_reverse_relations
                  IssueRelation.delete_all
                  assert IssueRelation.create!(
                           :issue_from => Issue.find(1), :issue_to => Issue.find(3),
                           :relation_type => IssueRelation::TYPE_BLOCKS
                         )
                  assert IssueRelation.create!(
                           :issue_from => Issue.find(1), :issue_to => Issue.find(2),
                           :relation_type => IssueRelation::TYPE_BLOCKED
                         )
                  r = IssueRelation.new(
                        :issue_from => Issue.find(2), :issue_to => Issue.find(1),
                        :relation_type => IssueRelation::TYPE_BLOCKED
                      )
                  assert !r.save
-                 assert_not_nil r.errors[:base]
+                 assert_not_equal [], r.errors[:base]
                end
                def test_create_should_make_journal_entry
                  from = Issue.find(1)
                  to   = Issue.find(2)
                  from_journals = from.journals.size
                  to_journals   = to.journals.size
                  relation = IssueRelation.new(:issue_from => from, :issue_to => to,
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert relation.save
                  from.reload
                  to.reload
                  relation.reload
                  assert_equal from.journals.size, (from_journals + 1)
                  assert_equal to.journals.size, (to_journals + 1)
                  assert_equal 'relation', from.journals.last.details.last.property
                  assert_equal 'label_precedes', from.journals.last.details.last.prop_key
                  assert_equal '2', from.journals.last.details.last.value
                  assert_nil   from.journals.last.details.last.old_value
                  assert_equal 'relation', to.journals.last.details.last.property
                  assert_equal 'label_follows', to.journals.last.details.last.prop_key
                  assert_equal '1', to.journals.last.details.last.value
                  assert_nil   to.journals.last.details.last.old_value
                end
                def test_delete_should_make_journal_entry
                  relation = IssueRelation.find(1)
                  id = relation.id
                  from = relation.issue_from
                  to   = relation.issue_to
                  from_journals = from.journals.size
                  to_journals   = to.journals.size
                  assert relation.destroy
                  from.reload
                  to.reload
                  assert_equal from.journals.size, (from_journals + 1)
                  assert_equal to.journals.size, (to_journals + 1)
                  assert_equal 'relation', from.journals.last.details.last.property
                  assert_equal 'label_blocks', from.journals.last.details.last.prop_key
                  assert_equal '9', from.journals.last.details.last.old_value
                  assert_nil   from.journals.last.details.last.value
                  assert_equal 'relation', to.journals.last.details.last.property
                  assert_equal 'label_blocked_by', to.journals.last.details.last.prop_key
                  assert_equal '10', to.journals.last.details.last.old_value
                  assert_nil   to.journals.last.details.last.value
                end
              end

test/unit/issue_test.rb +4 -4

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueTest < ActiveSupport::TestCase
                fixtures :projects, :users, :members, :member_roles, :roles,
                         :groups_users,
                         :trackers, :projects_trackers,
                         :enabled_modules,
                         :versions,
                         :issue_statuses, :issue_categories, :issue_relations, :workflows,
                         :enumerations,
                         :issues, :journals, :journal_details,
                         :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                         :time_entries
                include Redmine::I18n
                def teardown
                  User.current = nil
                end
                def test_initialize
                  issue = Issue.new
                  assert_nil issue.project_id
                  assert_nil issue.tracker_id
                  assert_nil issue.author_id
                  assert_nil issue.assigned_to_id
                  assert_nil issue.category_id
                  assert_equal IssueStatus.default, issue.status
                  assert_equal IssuePriority.default, issue.priority
                end
                def test_create
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                    :status_id => 1, :priority => IssuePriority.all.first,
                                    :subject => 'test_create',
                                    :description => 'IssueTest#test_create', :estimated_hours => '1:30')
                  assert issue.save
                  issue.reload
                  assert_equal 1.5, issue.estimated_hours
                end
                def test_create_minimal
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                    :status_id => 1, :priority => IssuePriority.all.first,
                                    :subject => 'test_create')
                  assert issue.save
                  assert issue.description.nil?
                  assert_nil issue.estimated_hours
                end
                def test_start_date_format_should_be_validated
                  set_language_if_valid 'en'
                  ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
                    issue = Issue.new(:start_date => invalid_date)
                    assert !issue.valid?
                    assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
                  end
                end
                def test_due_date_format_should_be_validated
                  set_language_if_valid 'en'
                  ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
                    issue = Issue.new(:due_date => invalid_date)
                    assert !issue.valid?
                    assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
                  end
                end
                def test_due_date_lesser_than_start_date_should_not_validate
                  set_language_if_valid 'en'
                  issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
                  assert !issue.valid?
                  assert_include 'Due date must be greater than start date', issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
                  issue = Issue.generate(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  assert !issue.valid?
                  assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
                  issue = Issue.generate!(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  issue.start_date = '2013-06-07'
                  assert !issue.valid?
                  assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
                  issue = Issue.generate!(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  assert issue.valid?
                end
                def test_estimated_hours_should_be_validated
                  set_language_if_valid 'en'
                  ['-2'].each do |invalid|
                    issue = Issue.new(:estimated_hours => invalid)
                    assert !issue.valid?
                    assert_include 'Estimated time is invalid', issue.errors.full_messages
                  end
                end
                def test_create_with_required_custom_field
                  set_language_if_valid 'en'
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :subject => 'test_create',
                                    :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # No value for the custom field
                  assert !issue.save
                  assert_equal ["Database can't be blank"], issue.errors.full_messages
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  assert_equal ["Database can't be blank"], issue.errors.full_messages
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.save
                  assert_equal ["Database is not included in the list"], issue.errors.full_messages
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def test_create_with_group_assignment
                  with_settings :issue_group_assignment => '1' do
                    assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                                     :subject => 'Group assignment',
                                     :assigned_to_id => 11).save
                    issue = Issue.first(:order => 'id DESC')
                    assert_kind_of Group, issue.assigned_to
                    assert_equal Group.find(11), issue.assigned_to
                  end
                end
                def test_create_with_parent_issue_id
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => 1)
                  assert_save issue
                  assert_equal 1, issue.parent_issue_id
                  assert_equal Issue.find(1), issue.parent
                end
                def test_create_with_sharp_parent_issue_id
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => "#1")
                  assert_save issue
                  assert_equal 1, issue.parent_issue_id
                  assert_equal Issue.find(1), issue.parent
                end
                def test_create_with_invalid_parent_issue_id
                  set_language_if_valid 'en'
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => '01ABC')
                  assert !issue.save
                  assert_equal '01ABC', issue.parent_issue_id
                  assert_include 'Parent task is invalid', issue.errors.full_messages
                end
                def test_create_with_invalid_sharp_parent_issue_id
                  set_language_if_valid 'en'
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => '#01ABC')
                  assert !issue.save
                  assert_equal '#01ABC', issue.parent_issue_id
                  assert_include 'Parent task is invalid', issue.errors.full_messages
                end
                def assert_visibility_match(user, issues)
                  assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
                end
                def test_visible_scope_for_anonymous
                  # Anonymous user should see issues of public projects only
                  issues = Issue.visible(User.anonymous).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_anonymous_without_view_issues_permissions
                  # Anonymous user should not see issues without permission
                  Role.anonymous.remove_permission!(:view_issues)
                  issues = Issue.visible(User.anonymous).all
                  assert issues.empty?
                  assert_visibility_match User.anonymous, issues
                end
                def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
                  assert Role.anonymous.update_attribute(:issues_visibility, 'default')
                  issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
                  assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
                  assert !issue.visible?(User.anonymous)
                end
                def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
                  assert Role.anonymous.update_attribute(:issues_visibility, 'own')
                  issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
                  assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
                  assert !issue.visible?(User.anonymous)
                end
                def test_visible_scope_for_non_member
                  user = User.find(9)
                  assert user.projects.empty?
                  # Non member user should see issues of public projects only
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_with_own_issues_visibility
                  Role.non_member.update_attribute :issues_visibility, 'own'
                  Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
                  user = User.find(9)
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_without_view_issues_permissions
                  # Non member user should not see issues without permission
                  Role.non_member.remove_permission!(:view_issues)
                  user = User.find(9)
                  assert user.projects.empty?
                  issues = Issue.visible(user).all
                  assert issues.empty?
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_member
                  user = User.find(9)
                  # User should see issues of projects for which user has view_issues permissions only
                  Role.non_member.remove_permission!(:view_issues)
                  Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.project_id != 3}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_member_with_groups_should_return_assigned_issues
                  user = User.find(8)
                  assert user.groups.any?
                  Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
                  Role.non_member.remove_permission!(:view_issues)
                  issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                    :status_id => 1, :priority => IssuePriority.all.first,
                    :subject => 'Assignment test',
                    :assigned_to => user.groups.first,
                    :is_private => true)
                  Role.find(2).update_attribute :issues_visibility, 'default'
                  issues = Issue.visible(User.find(8)).all
                  assert issues.any?
                  assert issues.include?(issue)
                  Role.find(2).update_attribute :issues_visibility, 'own'
                  issues = Issue.visible(User.find(8)).all
                  assert issues.any?
                  assert issues.include?(issue)
                end
                def test_visible_scope_for_admin
                  user = User.find(1)
                  user.members.each(&:destroy)
                  assert user.projects.empty?
                  issues = Issue.visible(user).all
                  assert issues.any?
                  # Admin should see issues on private projects that admin does not belong to
                  assert issues.detect {|issue| !issue.project.is_public?}
                  # Admin should see private issues of other users
                  assert issues.detect {|issue| issue.is_private? && issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_with_project
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project).all
                  projects = issues.collect(&:project).uniq
                  assert_equal 1, projects.size
                  assert_equal project, projects.first
                end
                def test_visible_scope_with_project_and_subprojects
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
                  projects = issues.collect(&:project).uniq
                  assert projects.size > 1
                  assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
                end
                def test_visible_and_nested_set_scopes
                  assert_equal 0, Issue.find(1).descendants.visible.all.size
                end
                def test_open_scope
                  issues = Issue.open.all
                  assert_nil issues.detect(&:closed?)
                end
                def test_open_scope_with_arg
                  issues = Issue.open(false).all
                  assert_equal issues, issues.select(&:closed?)
                end
                def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
                  version = Version.find(2)
                  assert version.fixed_issues.any?
                  assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
                end
                def test_fixed_version_scope_with_empty_array_should_return_no_result
                  assert_equal 0, Issue.fixed_version([]).count
                end
                def test_errors_full_messages_should_include_custom_fields_errors
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :subject => 'test_create',
                                    :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.valid?
                  assert_equal 1, issue.errors.full_messages.size
                  assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                               issue.errors.full_messages.first
                end
                def test_update_issue_with_required_custom_field
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.find(1)
                  assert_nil issue.custom_value_for(field)
                  assert issue.available_custom_fields.include?(field)
                  # No change to custom values, issue can be saved
                  assert issue.save
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def test_should_not_update_attributes_if_custom_fields_validation_fails
                  issue = Issue.find(1)
                  field = IssueCustomField.find_by_name('Database')
                  assert issue.available_custom_fields.include?(field)
                  issue.custom_field_values = { field.id => 'Invalid' }
                  issue.subject = 'Should be not be saved'
                  assert !issue.save
                  issue.reload
                  assert_equal "Can't print recipes", issue.subject
                end
                def test_should_not_recreate_custom_values_objects_on_update
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.find(1)
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  custom_value = issue.custom_value_for(field)
                  issue.reload
                  issue.custom_field_values = { field.id => 'MySQL' }
                  assert issue.save
                  issue.reload
                  assert_equal custom_value.id, issue.custom_value_for(field).id
                end
                def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
                  issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                        :status_id => 1, :subject => 'Test',
                                        :custom_field_values => {'2' => 'Test'})
                  assert !Tracker.find(2).custom_field_ids.include?(2)
                  issue = Issue.find(issue.id)
                  issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
                  issue = Issue.find(issue.id)
                  custom_value = issue.custom_value_for(2)
                  assert_not_nil custom_value
                  assert_equal 'Test', custom_value.value
                end
                def test_assigning_tracker_id_should_reload_custom_fields_values
                  issue = Issue.new(:project => Project.find(1))
                  assert issue.custom_field_values.empty?
                  issue.tracker_id = 1
                  assert issue.custom_field_values.any?
                end
                def test_assigning_attributes_should_assign_project_and_tracker_first
                  seq = sequence('seq')
                  issue = Issue.new
                  issue.expects(:project_id=).in_sequence(seq)
                  issue.expects(:tracker_id=).in_sequence(seq)
                  issue.expects(:subject=).in_sequence(seq)
                  issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
                end
                def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
                  attributes = ActiveSupport::OrderedHash.new
                  attributes['custom_field_values'] = { '1' => 'MySQL' }
                  attributes['tracker_id'] = '1'
                  issue = Issue.new(:project => Project.find(1))
                  issue.attributes = attributes
                  assert_equal 'MySQL', issue.custom_field_value(1)
                end
                def test_reload_should_reload_custom_field_values
                  issue = Issue.generate!
                  issue.custom_field_values = {'2' => 'Foo'}
                  issue.save!
                  issue = Issue.order('id desc').first
                  assert_equal 'Foo', issue.custom_field_value(2)
                  issue.custom_field_values = {'2' => 'Bar'}
                  assert_equal 'Bar', issue.custom_field_value(2)
                  issue.reload
                  assert_equal 'Foo', issue.custom_field_value(2)
                end
                def test_should_update_issue_with_disabled_tracker
                  p = Project.find(1)
                  issue = Issue.find(1)
                  p.trackers.delete(issue.tracker)
                  assert !p.trackers.include?(issue.tracker)
                  issue.reload
                  issue.subject = 'New subject'
                  assert issue.save
                end
                def test_should_not_set_a_disabled_tracker
                  p = Project.find(1)
                  p.trackers.delete(Tracker.find(2))
                  issue = Issue.find(1)
                  issue.tracker_id = 2
                  issue.subject = 'New subject'
                  assert !issue.save
-                 assert_not_nil issue.errors[:tracker_id]
+                 assert_not_equal [], issue.errors[:tracker_id]
                end
                def test_category_based_assignment
                  issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                       :status_id => 1, :priority => IssuePriority.all.first,
                                       :subject => 'Assignment test',
                                       :description => 'Assignment test', :category_id => 1)
                  assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
                end
                def test_new_statuses_allowed_to
                  WorkflowTransition.delete_all
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 2,
                                             :author => false, :assignee => false)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 3,
                                             :author => true, :assignee => false)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 4,
                                             :author => false, :assignee => true)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 5,
                                             :author => true, :assignee => true)
                  status = IssueStatus.find(1)
                  role = Role.find(1)
                  tracker = Tracker.find(1)
                  user = User.find(2)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author_id => 1)
                  assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user)
                  assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author_id => 1,
                                          :assigned_to => user)
                  assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user,
                                          :assigned_to => user)
                  assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  group = Group.generate!
                  group.users << user
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user,
                                          :assigned_to => group)
                  assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                end
                def test_new_statuses_allowed_to_should_consider_group_assignment
                  WorkflowTransition.delete_all
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 4,
                                             :author => false, :assignee => true)
                  user = User.find(2)
                  group = Group.generate!
                  group.users << user
                  issue = Issue.generate!(:author_id => 1, :assigned_to => group)
                  assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
                end
                def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
                  admin = User.find(1)
                  issue = Issue.find(1)
                  assert !admin.member_of?(issue.project)
                  expected_statuses = [issue.status] +
                                          WorkflowTransition.find_all_by_old_status_id(
                                              issue.status_id).map(&:new_status).uniq.sort
                  assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
                end
                def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
                  issue = Issue.find(1).copy
                  assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
                  issue = Issue.find(2).copy
                  assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
                end
                def test_safe_attributes_names_should_not_include_disabled_field
                  tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
                  issue = Issue.new(:tracker => tracker)
                  assert_include 'tracker_id', issue.safe_attribute_names
                  assert_include 'status_id', issue.safe_attribute_names
                  assert_include 'subject', issue.safe_attribute_names
                  assert_include 'description', issue.safe_attribute_names
                  assert_include 'custom_field_values', issue.safe_attribute_names
                  assert_include 'custom_fields', issue.safe_attribute_names
                  assert_include 'lock_version', issue.safe_attribute_names
                  tracker.core_fields.each do |field|
                    assert_include field, issue.safe_attribute_names
                  end
                  tracker.disabled_core_fields.each do |field|
                    assert_not_include field, issue.safe_attribute_names
                  end
                end
                def test_safe_attributes_should_ignore_disabled_fields
                  tracker = Tracker.find(1)
                  tracker.core_fields = %w(assigned_to_id due_date)
                  tracker.save!
                  issue = Issue.new(:tracker => tracker)
                  issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
                  assert_nil issue.start_date
                  assert_equal Date.parse('2012-07-14'), issue.due_date
                end
                def test_safe_attributes_should_accept_target_tracker_enabled_fields
                  source = Tracker.find(1)
                  source.core_fields = []
                  source.save!
                  target = Tracker.find(2)
                  target.core_fields = %w(assigned_to_id due_date)
                  target.save!
                  issue = Issue.new(:tracker => source)
                  issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
                  assert_equal target, issue.tracker
                  assert_equal Date.parse('2012-07-14'), issue.due_date
                end
                def test_safe_attributes_should_not_include_readonly_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  assert_equal %w(due_date), issue.read_only_attribute_names(user)
                  assert_not_include 'due_date', issue.safe_attribute_names(user)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
                  assert_equal Date.parse('2012-07-14'), issue.start_date
                  assert_nil issue.due_date
                end
                def test_safe_attributes_should_not_include_readonly_custom_fields
                  cf1 = IssueCustomField.create!(:name => 'Writable field',
                                                 :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1])
                  cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                                 :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => cf2.id.to_s,
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
                  assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
                  issue.send :safe_attributes=, {'custom_field_values' => {
                                                     cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                                   }}, user
                  assert_equal 'value1', issue.custom_field_value(cf1)
                  assert_nil issue.custom_field_value(cf2)
                  issue.send :safe_attributes=, {'custom_fields' => [
                                                    {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                                    {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                                  ]}, user
                  assert_equal 'valuea', issue.custom_field_value(cf1)
                  assert_nil issue.custom_field_value(cf2)
                end
                def test_editable_custom_field_values_should_return_non_readonly_custom_values
                  cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1, 2])
                  cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1, 2])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                                             :field_name => cf2.id.to_s, :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  values = issue.editable_custom_field_values(user)
                  assert values.detect {|value| value.custom_field == cf1}
                  assert_nil values.detect {|value| value.custom_field == cf2}
                  issue.tracker_id = 2
                  values = issue.editable_custom_field_values(user)
                  assert values.detect {|value| value.custom_field == cf1}
                  assert values.detect {|value| value.custom_field == cf2}
                end
                def test_safe_attributes_should_accept_target_tracker_writable_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                                 'due_date' => '2012-07-14'}, user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_nil issue.due_date
                  issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                                 'due_date' => '2012-07-16',
                                                 'tracker_id' => 2}, user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_equal Date.parse('2012-07-16'), issue.due_date
                end
                def test_safe_attributes_should_accept_target_status_writable_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                                 'due_date' => '2012-07-14'},
                                                 user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_nil issue.due_date
                  issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                                  'due_date' => '2012-07-16',
                                                  'status_id' => 2},
                                                user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_equal Date.parse('2012-07-16'), issue.due_date
                end
                def test_required_attributes_should_be_validated
                  cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                                :is_for_all => true, :tracker_ids => [1, 2])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'category_id',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => cf.id.to_s,
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => cf.id.to_s,
                                             :rule => 'required')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :status_id => 1, :subject => 'Required fields',
                                    :author => user)
                  assert_equal [cf.id.to_s, "category_id", "due_date"],
                               issue.required_attribute_names(user).sort
                  assert !issue.save, "Issue was saved"
                  assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
                                issue.errors.full_messages.sort
                  issue.tracker_id = 2
                  assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
                  assert !issue.save, "Issue was saved"
                  assert_equal ["Foo can't be blank", "Start date can't be blank"],
                               issue.errors.full_messages.sort
                  issue.start_date = Date.today
                  issue.custom_field_values = {cf.id.to_s => 'bar'}
                  assert issue.save
                end
                def test_required_attribute_names_for_multiple_roles_should_intersect_rules
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'required')
                  user = User.find(2)
                  member = Member.find(1)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
                  member.role_ids = [1, 2]
                  member.save!
                  assert_equal [], issue.required_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 2, :field_name => 'due_date',
                                             :rule => 'required')
                  assert_equal %w(due_date), issue.required_attribute_names(user)
                  member.role_ids = [1, 2, 3]
                  member.save!
                  assert_equal [], issue.required_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 2, :field_name => 'due_date',
                                             :rule => 'readonly')
                  # required + readonly => required
                  assert_equal %w(due_date), issue.required_attribute_names(user)
                end
                def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  member = Member.find(1)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
                  member.role_ids = [1, 2]
                  member.save!
                  assert_equal [], issue.read_only_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                            :role_id => 2, :field_name => 'due_date',
                                            :rule => 'readonly')
                  assert_equal %w(due_date), issue.read_only_attribute_names(user)
                end
                def test_copy
                  issue = Issue.new.copy_from(1)
                  assert issue.copy?
                  assert issue.save
                  issue.reload
                  orig = Issue.find(1)
                  assert_equal orig.subject, issue.subject
                  assert_equal orig.tracker, issue.tracker
                  assert_equal "125", issue.custom_value_for(2).value
                end
                def test_copy_should_copy_status
                  orig = Issue.find(8)
                  assert orig.status != IssueStatus.default
                  issue = Issue.new.copy_from(orig)
                  assert issue.save
                  issue.reload
                  assert_equal orig.status, issue.status
                end
                def test_copy_should_add_relation_with_copied_issue
                  copied = Issue.find(1)
                  issue = Issue.new.copy_from(copied)
                  assert issue.save
                  issue.reload
                  assert_equal 1, issue.relations.size
                  relation = issue.relations.first
                  assert_equal 'copied_to', relation.relation_type
                  assert_equal copied, relation.issue_from
                  assert_equal issue, relation.issue_to
                end
                def test_copy_should_copy_subtasks
                  issue = Issue.generate_with_descendants!
                  copy = issue.reload.copy
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                  end
                  copy.reload
                  assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
                  child_copy = copy.children.detect {|c| c.subject == 'Child1'}
                  assert_equal %w(Child11), child_copy.children.map(&:subject).sort
                  assert_equal copy.author, child_copy.author
                end
                def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
                  parent = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
                  child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
                  copy = parent.reload.copy
                  copy.parent_issue_id = parent.id
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 3 do
                    assert copy.save
                  end
                  parent.reload
                  copy.reload
                  assert_equal parent, copy.parent
                  assert_equal 3, parent.children.count
                  assert_equal 5, parent.descendants.count
                  assert_equal 2, copy.children.count
                  assert_equal 2, copy.descendants.count
                end
                def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
                  parent = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
                  child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
                  copy = parent.reload.copy
                  copy.parent_issue_id = child1.id
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 3 do
                    assert copy.save
                  end
                  parent.reload
                  child1.reload
                  copy.reload
                  assert_equal child1, copy.parent
                  assert_equal 2, parent.children.count
                  assert_equal 5, parent.descendants.count
                  assert_equal 1, child1.children.count
                  assert_equal 3, child1.descendants.count
                  assert_equal 2, copy.children.count
                  assert_equal 2, copy.descendants.count
                end
                def test_copy_should_copy_subtasks_to_target_project
                  issue = Issue.generate_with_descendants!
                  copy = issue.copy(:project_id => 3)
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                  end
                  assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
                end
                def test_copy_should_not_copy_subtasks_twice_when_saving_twice
                  issue = Issue.generate_with_descendants!
                  copy = issue.reload.copy
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                    assert copy.save
                  end
                end
                def test_should_not_call_after_project_change_on_creation
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Test', :author_id => 1)
                  issue.expects(:after_project_change).never
                  issue.save!
                end
                def test_should_not_call_after_project_change_on_update
                  issue = Issue.find(1)
                  issue.project = Project.find(1)
                  issue.subject = 'No project change'
                  issue.expects(:after_project_change).never
                  issue.save!
                end
                def test_should_call_after_project_change_on_project_change
                  issue = Issue.find(1)
                  issue.project = Project.find(2)
                  issue.expects(:after_project_change).once
                  issue.save!
                end
                def test_adding_journal_should_update_timestamp
                  issue = Issue.find(1)
                  updated_on_was = issue.updated_on
                  issue.init_journal(User.first, "Adding notes")
                  assert_difference 'Journal.count' do
                    assert issue.save
                  end
                  issue.reload
                  assert_not_equal updated_on_was, issue.updated_on
                end
                def test_should_close_duplicates
                  # Create 3 issues
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue3 = Issue.generate!
                  # 2 is a dupe of 1
                  IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
                                        :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 2
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 1 (circular duplicates)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
                                        :relation_type => IssueRelation::TYPE_DUPLICATES)
                  assert issue1.reload.duplicates.include?(issue2)
                  # Closing issue 1
                  issue1.init_journal(User.first, "Closing issue1")
                  issue1.status = IssueStatus.where(:is_closed => true).first
                  assert issue1.save
                  # 2 and 3 should be also closed
                  assert issue2.reload.closed?
                  assert issue3.reload.closed?
                end
                def test_should_not_close_duplicated_issue
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  # 2 is a dupe of 1
                  IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
                                       :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # 2 is a dup of 1 but 1 is not a duplicate of 2
                  assert !issue2.reload.duplicates.include?(issue1)
                  # Closing issue 2
                  issue2.init_journal(User.first, "Closing issue2")
                  issue2.status = IssueStatus.where(:is_closed => true).first
                  assert issue2.save
                  # 1 should not be also closed
                  assert !issue1.reload.closed?
                end
                def test_assignable_versions
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 1,
                                    :subject => 'New issue')
                  assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 1,
                                    :subject => 'New issue')
                  assert !issue.save
-                 assert_not_nil issue.errors[:fixed_version_id]
+                 assert_not_equal [], issue.errors[:fixed_version_id]
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 2,
                                    :subject => 'New issue')
                  assert !issue.save
-                 assert_not_nil issue.errors[:fixed_version_id]
+                 assert_not_equal [], issue.errors[:fixed_version_id]
                end
                def test_should_be_able_to_assign_a_new_issue_to_an_open_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 3,
                                    :subject => 'New issue')
                  assert issue.save
                end
                def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  assert_equal 'closed', issue.fixed_version.status
                  issue.subject = 'Subject changed'
                  assert issue.save
                end
                def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  assert !issue.save
-                 assert_not_nil issue.errors[:base]
+                 assert_not_equal [], issue.errors[:base]
                end
                def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  issue.fixed_version_id = 3
                  assert issue.save
                end
                def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
                  issue = Issue.find(12)
                  assert_equal 'locked', issue.fixed_version.status
                  issue.status_id = 1
                  assert issue.save
                end
                def test_should_not_be_able_to_keep_unshared_version_when_changing_project
                  issue = Issue.find(2)
                  assert_equal 2, issue.fixed_version_id
                  issue.project_id = 3
                  assert_nil issue.fixed_version_id
                  issue.fixed_version_id = 2
                  assert !issue.save
                  assert_include 'Target version is not included in the list', issue.errors.full_messages
                end
                def test_should_keep_shared_version_when_changing_project
                  Version.find(2).update_attribute :sharing, 'tree'
                  issue = Issue.find(2)
                  assert_equal 2, issue.fixed_version_id
                  issue.project_id = 3
                  assert_equal 2, issue.fixed_version_id
                  assert issue.save
                end
                def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
                  assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
                end
                def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
                  Project.find(2).disable_module! :issue_tracking
                  assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
                end
                def test_move_to_another_project_with_same_category
                  issue = Issue.find(1)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category changes
                  assert_equal 4, issue.category_id
                  # Make sure time entries were move to the target project
                  assert_equal 2, issue.time_entries.first.project_id
                end
                def test_move_to_another_project_without_same_category
                  issue = Issue.find(2)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category cleared
                  assert_nil issue.category_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 4)
                  issue.project = Project.find(5)
                  assert issue.save
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Keep fixed_version
                  assert_equal 4, issue.fixed_version_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  issue.project = Project.find(5)
                  assert issue.save
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 7)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Keep fixed_version
                  assert_equal 7, issue.fixed_version_id
                end
                def test_move_to_another_project_should_keep_parent_if_valid
                  issue = Issue.find(1)
                  issue.update_attribute(:parent_issue_id, 2)
                  issue.project = Project.find(3)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.parent_id
                end
                def test_move_to_another_project_should_clear_parent_if_not_valid
                  issue = Issue.find(1)
                  issue.update_attribute(:parent_issue_id, 2)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_nil issue.parent_id
                end
                def test_move_to_another_project_with_disabled_tracker
                  issue = Issue.find(1)
                  target = Project.find(2)
                  target.tracker_ids = [3]
                  target.save
                  issue.project = target
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  assert_equal 3, issue.tracker_id
                end
                def test_copy_to_the_same_project
                  issue = Issue.find(1)
                  copy = issue.copy
                  assert_difference 'Issue.count' do
                    copy.save!
                  end
                  assert_kind_of Issue, copy
                  assert_equal issue.project, copy.project
                  assert_equal "125", copy.custom_value_for(2).value
                end
                def test_copy_to_another_project_and_tracker
                  issue = Issue.find(1)
                  copy = issue.copy(:project_id => 3, :tracker_id => 2)
                  assert_difference 'Issue.count' do
                    copy.save!
                  end
                  copy.reload
                  assert_kind_of Issue, copy
                  assert_equal Project.find(3), copy.project
                  assert_equal Tracker.find(2), copy.tracker
                  # Custom field #2 is not associated with target tracker
                  assert_nil copy.custom_value_for(2)
                end
                test "#copy should not create a journal" do
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
                  copy.save!
                  assert_equal 0, copy.reload.journals.size
                end
                test "#copy should allow assigned_to changes" do
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
                  assert_equal 3, copy.assigned_to_id
                end
                test "#copy should allow status changes" do
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
                  assert_equal 2, copy.status_id
                end
                test "#copy should allow start date changes" do
                  date = Date.today
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
                  assert_equal date, copy.start_date
                end
                test "#copy should allow due date changes" do
                  date = Date.today
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
                  assert_equal date, copy.due_date
                end
                test "#copy should set current user as author" do
                  User.current = User.find(9)
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
                  assert_equal User.current, copy.author
                end
                test "#copy should create a journal with notes" do
                  date = Date.today
                  notes = "Notes added when copying"
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
                  copy.init_journal(User.current, notes)
                  copy.save!
                  assert_equal 1, copy.journals.size
                  journal = copy.journals.first
                  assert_equal 0, journal.details.size
                  assert_equal notes, journal.notes
                end
                def test_valid_parent_project
                  issue = Issue.find(1)
                  issue_in_same_project = Issue.find(2)
                  issue_in_child_project = Issue.find(5)
                  issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
                  issue_in_other_child_project = Issue.find(6)
                  issue_in_different_tree = Issue.find(4)
                  with_settings :cross_project_subtasks => '' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                  end
                  with_settings :cross_project_subtasks => 'system' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
                  end
                  with_settings :cross_project_subtasks => 'tree' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
                  end
                  with_settings :cross_project_subtasks => 'descendants' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue)
                    assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
                  end
                end
                def test_recipients_should_include_previous_assignee
                  user = User.find(3)
                  user.members.update_all ["mail_notification = ?", false]
                  user.update_attribute :mail_notification, 'only_assigned'
                  issue = Issue.find(2)
                  issue.assigned_to = nil
                  assert_include user.mail, issue.recipients
                  issue.save!
                  assert !issue.recipients.include?(user.mail)
                end
                def test_recipients_should_not_include_users_that_cannot_view_the_issue
                  issue = Issue.find(12)
                  assert issue.recipients.include?(issue.author.mail)
                  # copy the issue to a private project
                  copy  = issue.copy(:project_id => 5, :tracker_id => 2)
                  # author is not a member of project anymore
                  assert !copy.recipients.include?(copy.author.mail)
                end
                def test_recipients_should_include_the_assigned_group_members
                  group_member = User.generate!
                  group = Group.generate!
                  group.users << group_member
                  issue = Issue.find(12)
                  issue.assigned_to = group
                  assert issue.recipients.include?(group_member.mail)
                end
                def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
                  user = User.find(3)
                  issue = Issue.find(9)
                  Watcher.create!(:user => user, :watchable => issue)
                  assert issue.watched_by?(user)
                  assert !issue.watcher_recipients.include?(user.mail)
                end
                def test_issue_destroy
                  Issue.find(1).destroy
                  assert_nil Issue.find_by_id(1)
                  assert_nil TimeEntry.find_by_issue_id(1)
                end
                def test_destroying_a_deleted_issue_should_not_raise_an_error
                  issue = Issue.find(1)
                  Issue.find(1).destroy
                  assert_nothing_raised do
                    assert_no_difference 'Issue.count' do
                      issue.destroy
                    end
                    assert issue.destroyed?
                  end
                end
                def test_destroying_a_stale_issue_should_not_raise_an_error
                  issue = Issue.find(1)
                  Issue.find(1).update_attribute :subject, "Updated"
                  assert_nothing_raised do
                    assert_difference 'Issue.count', -1 do
                      issue.destroy
                    end
                    assert issue.destroyed?
                  end
                end
                def test_blocked
                  blocked_issue = Issue.find(9)
                  blocking_issue = Issue.find(10)
                  assert blocked_issue.blocked?
                  assert !blocking_issue.blocked?
                end
                def test_blocked_issues_dont_allow_closed_statuses
                  blocked_issue = Issue.find(9)
                  allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert closed_statuses.empty?
                end
                def test_unblocked_issues_allow_closed_statuses
                  blocking_issue = Issue.find(10)
                  allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert !closed_statuses.empty?
                end
                def test_reschedule_an_issue_without_dates
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-09'.to_date
                    assert_equal '2012-10-09'.to_date, issue.start_date
                    assert_equal '2012-10-09'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-09'.to_date
                    assert_equal '2012-10-09'.to_date, issue.start_date
                    assert_equal '2012-10-09'.to_date, issue.due_date
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-15'.to_date, issue.due_date
                  end
                end
                def test_reschedule_an_issue_with_start_date
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-13'.to_date, issue.start_date
                    assert_equal '2012-10-13'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-11'.to_date
                    assert_equal '2012-10-11'.to_date, issue.start_date
                    assert_equal '2012-10-11'.to_date, issue.due_date
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-15'.to_date, issue.due_date
                  end
                end
                def test_reschedule_an_issue_with_start_and_due_dates
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-13'.to_date, issue.start_date
                    assert_equal '2012-10-19'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
                    issue.reschedule_on '2012-10-11'.to_date
                    assert_equal '2012-10-11'.to_date, issue.start_date
                    assert_equal '2012-10-23'.to_date, issue.due_date
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-25'.to_date, issue.due_date
                  end
                end
                def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.due_date = '2012-10-23'
                  issue1.save!
                  issue2.reload
                  assert_equal Date.parse('2012-10-24'), issue2.start_date
                  assert_equal Date.parse('2012-10-26'), issue2.due_date
                end
                def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.start_date = '2012-09-17'
                  issue1.due_date = '2012-09-18'
                  issue1.save!
                  issue2.reload
                  assert_equal Date.parse('2012-09-19'), issue2.start_date
                  assert_equal Date.parse('2012-09-21'), issue2.due_date
                end
                def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.start_date = '2012-09-17'
                  issue1.due_date = '2012-09-18'
                  issue1.save!
                  issue2.reload
                  # Issue 2 must start after Issue 3
                  assert_equal Date.parse('2012-10-03'), issue2.start_date
                  assert_equal Date.parse('2012-10-05'), issue2.due_date
                end
                def test_rescheduling_a_stale_issue_should_not_raise_an_error
                  with_settings :non_working_week_days => [] do
                    stale = Issue.find(1)
                    issue = Issue.find(1)
                    issue.subject = "Updated"
                    issue.save!
                    date = 10.days.from_now.to_date
                    assert_nothing_raised do
                      stale.reschedule_on!(date)
                    end
                    assert_equal date, stale.reload.start_date
                  end
                end
                def test_child_issue_should_consider_parent_soonest_start_on_create
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue1.reload
                  issue2.reload
                  assert_equal Date.parse('2012-10-18'), issue2.start_date
                  child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
                    :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
                  assert !child.valid?
                  assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
                  assert_equal Date.parse('2012-10-18'), child.soonest_start
                  child.start_date = '2012-10-18'
                  assert child.save
                end
                def test_setting_parent_to_a_dependent_issue_should_not_validate
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue3 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue3.reload
                  issue3.parent_issue_id = issue2.id
                  assert !issue3.valid?
                  assert_include 'Parent task is invalid', issue3.errors.full_messages
                end
                def test_setting_parent_should_not_allow_circular_dependency
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue3 = Issue.generate!
                  issue2.reload
                  issue2.parent_issue_id = issue3.id
                  issue2.save!
                  issue4 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue4.reload
                  issue4.parent_issue_id = issue1.id
                  assert !issue4.valid?
                  assert_include 'Parent task is invalid', issue4.errors.full_messages
                end
                def test_overdue
                  assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
                  assert !Issue.new(:due_date => Date.today).overdue?
                  assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
                  assert !Issue.new(:due_date => nil).overdue?
                  assert !Issue.new(:due_date => 1.day.ago.to_date,
                                    :status => IssueStatus.where(:is_closed => true).first
                                    ).overdue?
                end
                test "#behind_schedule? should be false if the issue has no start_date" do
                  assert !Issue.new(:start_date => nil,
                                    :due_date => 1.day.from_now.to_date,
                                    :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be false if the issue has no end_date" do
                  assert !Issue.new(:start_date => 1.day.from_now.to_date,
                                    :due_date => nil,
                                    :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
                  assert !Issue.new(:start_date => 50.days.ago.to_date,
                                    :due_date => 50.days.from_now.to_date,
                                    :done_ratio => 90).behind_schedule?
                end
                test "#behind_schedule? should be true if the issue hasn't been started at all" do
                  assert Issue.new(:start_date => 1.day.ago.to_date,
                                   :due_date => 1.day.from_now.to_date,
                                   :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
                  assert Issue.new(:start_date => 100.days.ago.to_date,
                                   :due_date => Date.today,
                                   :done_ratio => 90).behind_schedule?
                end
                test "#assignable_users should be Users" do
                  assert_kind_of User, Issue.find(1).assignable_users.first
                end
                test "#assignable_users should include the issue author" do
                  non_project_member = User.generate!
                  issue = Issue.generate!(:author => non_project_member)
                  assert issue.assignable_users.include?(non_project_member)
                end
                test "#assignable_users should include the current assignee" do
                  user = User.generate!
                  issue = Issue.generate!(:assigned_to => user)
                  user.lock!
                  assert Issue.find(issue.id).assignable_users.include?(user)
                end
                test "#assignable_users should not show the issue author twice" do
                  assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
                  assert_equal 2, assignable_user_ids.length
                  assignable_user_ids.each do |user_id|
                    assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
                                 "User #{user_id} appears more or less than once"
                  end
                end
                test "#assignable_users with issue_group_assignment should include groups" do
                  issue = Issue.new(:project => Project.find(2))
                  with_settings :issue_group_assignment => '1' do
                    assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
                    assert issue.assignable_users.include?(Group.find(11))
                  end
                end
                test "#assignable_users without issue_group_assignment should not include groups" do
                  issue = Issue.new(:project => Project.find(2))
                  with_settings :issue_group_assignment => '0' do
                    assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
                    assert !issue.assignable_users.include?(Group.find(11))
                  end
                end
                def test_create_should_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 3, :status_id => 1,
                                    :priority => IssuePriority.all.first,
                                    :subject => 'test_create', :estimated_hours => '1:30')
                  assert issue.save
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_stale_issue_should_not_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  stale = Issue.find(1)
                  issue.init_journal(User.find(1))
                  issue.subject = 'Subjet update'
                  assert issue.save
                  assert_equal 1, ActionMailer::Base.deliveries.size
                  ActionMailer::Base.deliveries.clear
                  stale.init_journal(User.find(1))
                  stale.subject = 'Another subjet update'
                  assert_raise ActiveRecord::StaleObjectError do
                    stale.save
                  end
                  assert ActionMailer::Base.deliveries.empty?
                end
                def test_journalized_description
                  IssueCustomField.delete_all
                  i = Issue.first
                  old_description = i.description
                  new_description = "This is the new description"
                  i.init_journal(User.find(2))
                  i.description = new_description
                  assert_difference 'Journal.count', 1 do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save!
                    end
                  end
                  detail = JournalDetail.first(:order => 'id DESC')
                  assert_equal i, detail.journal.journalized
                  assert_equal 'attr', detail.property
                  assert_equal 'description', detail.prop_key
                  assert_equal old_description, detail.old_value
                  assert_equal new_description, detail.value
                end
                def test_blank_descriptions_should_not_be_journalized
                  IssueCustomField.delete_all
                  Issue.update_all("description = NULL", "id=1")
                  i = Issue.find(1)
                  i.init_journal(User.find(2))
                  i.subject = "blank description"
                  i.description = "\r\n"
                  assert_difference 'Journal.count', 1 do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save!
                    end
                  end
                end
                def test_journalized_multi_custom_field
                  field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
                                                   :is_filter => true, :is_for_all => true,
                                                   :tracker_ids => [1],
                                                   :possible_values => ['value1', 'value2', 'value3'],
                                                   :multiple => true)
                  issue = Issue.create!(:project_id => 1, :tracker_id => 1,
                                        :subject => 'Test', :author_id => 1)
                  assert_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count' do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value1']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count' do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value1', 'value2']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count', 2 do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value3', 'value2']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count', 2 do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => nil}
                      issue.save!
                    end
                  end
                end
                def test_description_eol_should_be_normalized
                  i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
                  assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
                end
                def test_saving_twice_should_not_duplicate_journal_details
                  i = Issue.first
                  i.init_journal(User.find(2), 'Some notes')
                  # initial changes
                  i.subject = 'New subject'
                  i.done_ratio = i.done_ratio + 10
                  assert_difference 'Journal.count' do
                    assert i.save
                  end
                  # 1 more change
                  i.priority = IssuePriority.where("id <> ?", i.priority_id).first
                  assert_no_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save
                    end
                  end
                  # no more change
                  assert_no_difference 'Journal.count' do
                    assert_no_difference 'JournalDetail.count' do
                      i.save
                    end
                  end
                end
                def test_all_dependent_issues
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3),
                                               :issue_to   => Issue.find(8),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_subtask
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_does_not_include_self
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
                end
                def test_all_dependent_issues_with_parenttask_and_sibling
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
                end
                def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => childIssue2_2,
                                              :relation_type => IssueRelation::TYPE_BLOCKS)
                  assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_relation_to_parent_in_other_tree
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => parentIssue2,
                                              :relation_type => IssueRelation::TYPE_BLOCKS)
                  assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_transitive_relation
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  independentIssue = Issue.generate!(:project => project)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => childIssue2_1,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create(:issue_from => childIssue2_1,
                                              :issue_to   => independentIssue,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_transitive_relation2
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  independentIssue = Issue.generate!(:project => project)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => independentIssue,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create(:issue_from => independentIssue,
                                              :issue_to   => childIssue2_1,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_persistent_circular_dependency
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  r = IssueRelation.create!(:issue_from => Issue.find(3),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
                  assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3),
                                               :issue_to   => Issue.find(8),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  r = IssueRelation.create!(:issue_from => Issue.find(8),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_RELATES)
                  IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
                  r = IssueRelation.create!(:issue_from => Issue.find(3),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_RELATES)
                  IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
                  @issue = Issue.find(1)
                  @issue_status = IssueStatus.find(1)
                  @issue_status.update_attribute(:default_done_ratio, 50)
                  @issue2 = Issue.find(2)
                  @issue_status2 = IssueStatus.find(2)
                  @issue_status2.update_attribute(:default_done_ratio, 0)
                  with_settings :issue_done_ratio => 'issue_field' do
                    assert_equal 0, @issue.done_ratio
                    assert_equal 30, @issue2.done_ratio
                  end
                  with_settings :issue_done_ratio => 'issue_status' do
                    assert_equal 50, @issue.done_ratio
                    assert_equal 0, @issue2.done_ratio
                  end
                end
                test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
                  @issue = Issue.find(1)
                  @issue_status = IssueStatus.find(1)
                  @issue_status.update_attribute(:default_done_ratio, 50)
                  @issue2 = Issue.find(2)
                  @issue_status2 = IssueStatus.find(2)
                  @issue_status2.update_attribute(:default_done_ratio, 0)
                  with_settings :issue_done_ratio => 'issue_field' do
                    @issue.update_done_ratio_from_issue_status
                    @issue2.update_done_ratio_from_issue_status
                    assert_equal 0, @issue.read_attribute(:done_ratio)
                    assert_equal 30, @issue2.read_attribute(:done_ratio)
                  end
                  with_settings :issue_done_ratio => 'issue_status' do
                    @issue.update_done_ratio_from_issue_status
                    @issue2.update_done_ratio_from_issue_status
                    assert_equal 50, @issue.read_attribute(:done_ratio)
                    assert_equal 0, @issue2.read_attribute(:done_ratio)
                  end
                end
                test "#by_tracker" do
                  User.current = User.anonymous
                  groups = Issue.by_tracker(Project.find(1))
                  assert_equal 3, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_version" do
                  User.current = User.anonymous
                  groups = Issue.by_version(Project.find(1))
                  assert_equal 3, groups.count
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_priority" do
                  User.current = User.anonymous
                  groups = Issue.by_priority(Project.find(1))
                  assert_equal 4, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_category" do
                  User.current = User.anonymous
                  groups = Issue.by_category(Project.find(1))
                  assert_equal 2, groups.count
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_assigned_to" do
                  User.current = User.anonymous
                  groups = Issue.by_assigned_to(Project.find(1))
                  assert_equal 2, groups.count
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_author" do
                  User.current = User.anonymous
                  groups = Issue.by_author(Project.find(1))
                  assert_equal 4, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_subproject" do
                  User.current = User.anonymous
                  groups = Issue.by_subproject(Project.find(1))
                  # Private descendant not visible
                  assert_equal 1, groups.count
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                def test_recently_updated_scope
                  #should return the last updated issue
                  assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
                end
                def test_on_active_projects_scope
                  assert Project.find(2).archive
                  before = Issue.on_active_project.length
                  # test inclusion to results
                  issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
                  assert_equal before + 1, Issue.on_active_project.length
                  # Move to an archived project
                  issue.project = Project.find(2)
                  assert issue.save
                  assert_equal before, Issue.on_active_project.length
                end
                test "Issue#recipients should include project recipients" do
                  issue = Issue.generate!
                  assert issue.project.recipients.present?
                  issue.project.recipients.each do |project_recipient|
                    assert issue.recipients.include?(project_recipient)
                  end
                end
                test "Issue#recipients should include the author if the author is active" do
                  issue = Issue.generate!(:author => User.generate!)
                  assert issue.author, "No author set for Issue"
                  assert issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should include the assigned to user if the assigned to user is active" do
                  issue = Issue.generate!(:assigned_to => User.generate!)
                  assert issue.assigned_to, "No assigned_to set for Issue"
                  assert issue.recipients.include?(issue.assigned_to.mail)
                end
                test "Issue#recipients should not include users who opt out of all email" do
                  issue = Issue.generate!(:author => User.generate!)
                  issue.author.update_attribute(:mail_notification, :none)
                  assert !issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
                  issue = Issue.generate!(:author => User.generate!)
                  issue.author.update_attribute(:mail_notification, :only_assigned)
                  assert !issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
                  issue = Issue.generate!(:assigned_to => User.generate!)
                  issue.assigned_to.update_attribute(:mail_notification, :only_owner)
                  assert !issue.recipients.include?(issue.assigned_to.mail)
                end
                def test_last_journal_id_with_journals_should_return_the_journal_id
                  assert_equal 2, Issue.find(1).last_journal_id
                end
                def test_last_journal_id_without_journals_should_return_nil
                  assert_nil Issue.find(3).last_journal_id
                end
                def test_journals_after_should_return_journals_with_greater_id
                  assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
                  assert_equal [], Issue.find(1).journals_after('2')
                end
                def test_journals_after_with_blank_arg_should_return_all_journals
                  assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
                end
                def test_css_classes_should_include_tracker
                  issue = Issue.new(:tracker => Tracker.find(2))
                  classes = issue.css_classes.split(' ')
                  assert_include 'tracker-2', classes
                end
                def test_css_classes_should_include_priority
                  issue = Issue.new(:priority => IssuePriority.find(8))
                  classes = issue.css_classes.split(' ')
                  assert_include 'priority-8', classes
                  assert_include 'priority-highest', classes
                end
                def test_css_classes_should_include_user_assignment
                  issue = Issue.generate(:assigned_to_id => 2)
                  assert_include 'assigned-to-me', issue.css_classes(User.find(2))
                  assert_not_include 'assigned-to-me', issue.css_classes(User.find(3))
                end
                def test_css_classes_should_include_user_group_assignment
                  issue = Issue.generate(:assigned_to_id => 10)
                  assert_include 'assigned-to-my-group', issue.css_classes(Group.find(10).users.first)
                  assert_not_include 'assigned-to-my-group', issue.css_classes(User.find(3))
                end
                def test_save_attachments_with_hash_should_save_attachments_in_keys_order
                  set_tmp_attachments_directory
                  issue = Issue.generate!
                  issue.save_attachments({
                    'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
                    '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
                    '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
                  })
                  issue.attach_saved_attachments
                  assert_equal 3, issue.reload.attachments.count
                  assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
                end
                def test_closed_on_should_be_nil_when_creating_an_open_issue
                  issue = Issue.generate!(:status_id => 1).reload
                  assert !issue.closed?
                  assert_nil issue.closed_on
                end
                def test_closed_on_should_be_set_when_creating_a_closed_issue
                  issue = Issue.generate!(:status_id => 5).reload
                  assert issue.closed?
                  assert_not_nil issue.closed_on
                  assert_equal issue.updated_on, issue.closed_on
                  assert_equal issue.created_on, issue.closed_on
                end
                def test_closed_on_should_be_nil_when_updating_an_open_issue
                  issue = Issue.find(1)
                  issue.subject = 'Not closed yet'
                  issue.save!
                  issue.reload
                  assert_nil issue.closed_on
                end
                def test_closed_on_should_be_set_when_closing_an_open_issue
                  issue = Issue.find(1)
                  issue.subject = 'Now closed'
                  issue.status_id = 5
                  issue.save!
                  issue.reload
                  assert_not_nil issue.closed_on
                  assert_equal issue.updated_on, issue.closed_on
                end
                def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
                  issue = Issue.open(false).first
                  was_closed_on = issue.closed_on
                  assert_not_nil was_closed_on
                  issue.subject = 'Updating a closed issue'
                  issue.save!
                  issue.reload
                  assert_equal was_closed_on, issue.closed_on
                end
                def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
                  issue = Issue.open(false).first
                  was_closed_on = issue.closed_on
                  assert_not_nil was_closed_on
                  issue.subject = 'Reopening a closed issue'
                  issue.status_id = 1
                  issue.save!
                  issue.reload
                  assert !issue.closed?
                  assert_equal was_closed_on, issue.closed_on
                end
                def test_status_was_should_return_nil_for_new_issue
                  issue = Issue.new
                  assert_nil issue.status_was
                end
                def test_status_was_should_return_status_before_change
                  issue = Issue.find(1)
                  issue.status = IssueStatus.find(2)
                  assert_equal IssueStatus.find(1), issue.status_was
                end
                def test_status_was_should_be_reset_on_save
                  issue = Issue.find(1)
                  issue.status = IssueStatus.find(2)
                  assert_equal IssueStatus.find(1), issue.status_was
                  assert issue.save!
                  assert_equal IssueStatus.find(2), issue.status_was
                end
              end

test/unit/user_test.rb +1 -1

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class UserTest < ActiveSupport::TestCase
                fixtures :users, :members, :projects, :roles, :member_roles, :auth_sources,
                          :trackers, :issue_statuses,
                          :projects_trackers,
                          :watchers,
                          :issue_categories, :enumerations, :issues,
                          :journals, :journal_details,
                          :groups_users,
                          :enabled_modules
                def setup
                  @admin = User.find(1)
                  @jsmith = User.find(2)
                  @dlopper = User.find(3)
                end
                def test_sorted_scope_should_sort_user_by_display_name
                  assert_equal User.all.map(&:name).map(&:downcase).sort, User.sorted.all.map(&:name).map(&:downcase)
                end
                def test_generate
                  User.generate!(:firstname => 'Testing connection')
                  User.generate!(:firstname => 'Testing connection')
                  assert_equal 2, User.where(:firstname => 'Testing connection').count
                end
                def test_truth
                  assert_kind_of User, @jsmith
                end
                def test_mail_should_be_stripped
                  u = User.new
                  u.mail = " foo@bar.com  "
                  assert_equal "foo@bar.com", u.mail
                end
                def test_mail_validation
                  u = User.new
                  u.mail = ''
                  assert !u.valid?
                  assert_include I18n.translate('activerecord.errors.messages.blank'), u.errors[:mail]
                end
                def test_login_length_validation
                  user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                  user.login = "x" * (User::LOGIN_LENGTH_LIMIT+1)
                  assert !user.valid?
                  user.login = "x" * (User::LOGIN_LENGTH_LIMIT)
                  assert user.valid?
                  assert user.save
                end
                def test_generate_password_should_respect_minimum_password_length
                  with_settings :password_min_length => 15 do
                    user = User.generate!(:generate_password => true)
                    assert user.password.length >= 15
                  end
                end
                def test_generate_password_should_not_generate_password_with_less_than_10_characters
                  with_settings :password_min_length => 4 do
                    user = User.generate!(:generate_password => true)
                    assert user.password.length >= 10
                  end
                end
                def test_generate_password_on_create_should_set_password
                  user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                  user.login = "newuser"
                  user.generate_password = true
                  assert user.save
                  password = user.password
                  assert user.check_password?(password)
                end
                def test_generate_password_on_update_should_update_password
                  user = User.find(2)
                  hash = user.hashed_password
                  user.generate_password = true
                  assert user.save
                  password = user.password
                  assert user.check_password?(password)
                  assert_not_equal hash, user.reload.hashed_password
                end
                def test_create
                  user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                  user.login = "jsmith"
                  user.password, user.password_confirmation = "password", "password"
                  # login uniqueness
                  assert !user.save
                  assert_equal 1, user.errors.count
                  user.login = "newuser"
                  user.password, user.password_confirmation = "password", "pass"
                  # password confirmation
                  assert !user.save
                  assert_equal 1, user.errors.count
                  user.password, user.password_confirmation = "password", "password"
                  assert user.save
                end
                def test_user_before_create_should_set_the_mail_notification_to_the_default_setting
                  @user1 = User.generate!
                  assert_equal 'only_my_events', @user1.mail_notification
                  with_settings :default_notification_option => 'all' do
                    @user2 = User.generate!
                    assert_equal 'all', @user2.mail_notification
                  end
                end
                def test_user_login_should_be_case_insensitive
                  u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                  u.login = 'newuser'
                  u.password, u.password_confirmation = "password", "password"
                  assert u.save
                  u = User.new(:firstname => "Similar", :lastname => "User", :mail => "similaruser@somenet.foo")
                  u.login = 'NewUser'
                  u.password, u.password_confirmation = "password", "password"
                  assert !u.save
                  assert_include I18n.translate('activerecord.errors.messages.taken'), u.errors[:login]
                end
                def test_mail_uniqueness_should_not_be_case_sensitive
                  u = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                  u.login = 'newuser1'
                  u.password, u.password_confirmation = "password", "password"
                  assert u.save
                  u = User.new(:firstname => "new", :lastname => "user", :mail => "newUser@Somenet.foo")
                  u.login = 'newuser2'
                  u.password, u.password_confirmation = "password", "password"
                  assert !u.save
                  assert_include I18n.translate('activerecord.errors.messages.taken'), u.errors[:mail]
                end
                def test_update
                  assert_equal "admin", @admin.login
                  @admin.login = "john"
                  assert @admin.save, @admin.errors.full_messages.join("; ")
                  @admin.reload
                  assert_equal "john", @admin.login
                end
                def test_update_should_not_fail_for_legacy_user_with_different_case_logins
                  u1 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser1@somenet.foo")
                  u1.login = 'newuser1'
                  assert u1.save
                  u2 = User.new(:firstname => "new", :lastname => "user", :mail => "newuser2@somenet.foo")
                  u2.login = 'newuser1'
                  assert u2.save(:validate => false)
                  user = User.find(u2.id)
                  user.firstname = "firstname"
                  assert user.save, "Save failed"
                end
                def test_destroy_should_delete_members_and_roles
                  members = Member.find_all_by_user_id(2)
                  ms = members.size
                  rs = members.collect(&:roles).flatten.size
                  assert_difference 'Member.count', - ms do
                    assert_difference 'MemberRole.count', - rs do
                      User.find(2).destroy
                    end
                  end
                  assert_nil User.find_by_id(2)
                  assert Member.find_all_by_user_id(2).empty?
                end
                def test_destroy_should_update_attachments
                  attachment = Attachment.create!(:container => Project.find(1),
                    :file => uploaded_test_file("testfile.txt", "text/plain"),
                    :author_id => 2)
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, attachment.reload.author
                end
                def test_destroy_should_update_comments
                  comment = Comment.create!(
                    :commented => News.create!(:project_id => 1, :author_id => 1, :title => 'foo', :description => 'foo'),
                    :author => User.find(2),
                    :comments => 'foo'
                  )
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, comment.reload.author
                end
                def test_destroy_should_update_issues
                  issue = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'foo')
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, issue.reload.author
                end
                def test_destroy_should_unassign_issues
                  issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil issue.reload.assigned_to
                end
                def test_destroy_should_update_journals
                  issue = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'foo')
                  issue.init_journal(User.find(2), "update")
                  issue.save!
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, issue.journals.first.reload.user
                end
                def test_destroy_should_update_journal_details_old_value
                  issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo', :assigned_to_id => 2)
                  issue.init_journal(User.find(1), "update")
                  issue.assigned_to_id = nil
                  assert_difference 'JournalDetail.count' do
                    issue.save!
                  end
                  journal_detail = JournalDetail.first(:order => 'id DESC')
                  assert_equal '2', journal_detail.old_value
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous.id.to_s, journal_detail.reload.old_value
                end
                def test_destroy_should_update_journal_details_value
                  issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo')
                  issue.init_journal(User.find(1), "update")
                  issue.assigned_to_id = 2
                  assert_difference 'JournalDetail.count' do
                    issue.save!
                  end
                  journal_detail = JournalDetail.first(:order => 'id DESC')
                  assert_equal '2', journal_detail.value
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous.id.to_s, journal_detail.reload.value
                end
                def test_destroy_should_update_messages
                  board = Board.create!(:project_id => 1, :name => 'Board', :description => 'Board')
                  message = Message.create!(:board_id => board.id, :author_id => 2, :subject => 'foo', :content => 'foo')
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, message.reload.author
                end
                def test_destroy_should_update_news
                  news = News.create!(:project_id => 1, :author_id => 2, :title => 'foo', :description => 'foo')
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, news.reload.author
                end
                def test_destroy_should_delete_private_queries
                  query = Query.new(:name => 'foo', :visibility => Query::VISIBILITY_PRIVATE)
                  query.project_id = 1
                  query.user_id = 2
                  query.save!
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil Query.find_by_id(query.id)
                end
                def test_destroy_should_update_public_queries
                  query = Query.new(:name => 'foo', :visibility => Query::VISIBILITY_PUBLIC)
                  query.project_id = 1
                  query.user_id = 2
                  query.save!
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, query.reload.user
                end
                def test_destroy_should_update_time_entries
                  entry = TimeEntry.new(:hours => '2', :spent_on => Date.today, :activity => TimeEntryActivity.create!(:name => 'foo'))
                  entry.project_id = 1
                  entry.user_id = 2
                  entry.save!
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, entry.reload.user
                end
                def test_destroy_should_delete_tokens
                  token = Token.create!(:user_id => 2, :value => 'foo')
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil Token.find_by_id(token.id)
                end
                def test_destroy_should_delete_watchers
                  issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'foo')
                  watcher = Watcher.create!(:user_id => 2, :watchable => issue)
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil Watcher.find_by_id(watcher.id)
                end
                def test_destroy_should_update_wiki_contents
                  wiki_content = WikiContent.create!(
                    :text => 'foo',
                    :author_id => 2,
                    :page => WikiPage.create!(:title => 'Foo', :wiki => Wiki.create!(:project_id => 1, :start_page => 'Start'))
                  )
                  wiki_content.text = 'bar'
                  assert_difference 'WikiContent::Version.count' do
                    wiki_content.save!
                  end
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_equal User.anonymous, wiki_content.reload.author
                  wiki_content.versions.each do |version|
                    assert_equal User.anonymous, version.reload.author
                  end
                end
                def test_destroy_should_nullify_issue_categories
                  category = IssueCategory.create!(:project_id => 1, :assigned_to_id => 2, :name => 'foo')
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil category.reload.assigned_to_id
                end
                def test_destroy_should_nullify_changesets
                  changeset = Changeset.create!(
                    :repository => Repository::Subversion.create!(
                      :project_id => 1,
                      :url => 'file:///tmp',
                      :identifier => 'tmp'
                    ),
                    :revision => '12',
                    :committed_on => Time.now,
                    :committer => 'jsmith'
                    )
                  assert_equal 2, changeset.user_id
                  User.find(2).destroy
                  assert_nil User.find_by_id(2)
                  assert_nil changeset.reload.user_id
                end
                def test_anonymous_user_should_not_be_destroyable
                  assert_no_difference 'User.count' do
                    assert_equal false, User.anonymous.destroy
                  end
                end
                def test_validate_login_presence
                  @admin.login = ""
                  assert !@admin.save
                  assert_equal 1, @admin.errors.count
                end
                def test_validate_mail_notification_inclusion
                  u = User.new
                  u.mail_notification = 'foo'
                  u.save
-                 assert_not_nil u.errors[:mail_notification]
+                 assert_not_equal [], u.errors[:mail_notification]
                end
                def test_password
                  user = User.try_to_login("admin", "admin")
                  assert_kind_of User, user
                  assert_equal "admin", user.login
                  user.password = "hello123"
                  assert user.save
                  user = User.try_to_login("admin", "hello123")
                  assert_kind_of User, user
                  assert_equal "admin", user.login
                end
                def test_validate_password_length
                  with_settings :password_min_length => '100' do
                    user = User.new(:firstname => "new100", :lastname => "user100", :mail => "newuser100@somenet.foo")
                    user.login = "newuser100"
                    user.password, user.password_confirmation = "password100", "password100"
                    assert !user.save
                    assert_equal 1, user.errors.count
                  end
                end
                def test_name_format
                  assert_equal 'John S.', @jsmith.name(:firstname_lastinitial)
                  assert_equal 'Smith, John', @jsmith.name(:lastname_coma_firstname)
                  with_settings :user_format => :firstname_lastname do
                    assert_equal 'John Smith', @jsmith.reload.name
                  end
                  with_settings :user_format => :username do
                    assert_equal 'jsmith', @jsmith.reload.name
                  end
                  with_settings :user_format => :lastname do
                    assert_equal 'Smith', @jsmith.reload.name
                  end
                end
                def test_today_should_return_the_day_according_to_user_time_zone
                  preference = User.find(1).pref
                  date = Date.new(2012, 05, 15)
                  time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                  Date.stubs(:today).returns(date)
                  Time.stubs(:now).returns(time)
                  preference.update_attribute :time_zone, 'Baku' # UTC+4
                  assert_equal '2012-05-16', User.find(1).today.to_s
                  preference.update_attribute :time_zone, 'La Paz' # UTC-4
                  assert_equal '2012-05-15', User.find(1).today.to_s
                  preference.update_attribute :time_zone, ''
                  assert_equal '2012-05-15', User.find(1).today.to_s
                end
                def test_time_to_date_should_return_the_date_according_to_user_time_zone
                  preference = User.find(1).pref
                  time = Time.gm(2012, 05, 15, 23, 30).utc # 2012-05-15 23:30 UTC
                  preference.update_attribute :time_zone, 'Baku' # UTC+4
                  assert_equal '2012-05-16', User.find(1).time_to_date(time).to_s
                  preference.update_attribute :time_zone, 'La Paz' # UTC-4
                  assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
                  preference.update_attribute :time_zone, ''
                  assert_equal '2012-05-15', User.find(1).time_to_date(time).to_s
                end
                def test_fields_for_order_statement_should_return_fields_according_user_format_setting
                  with_settings :user_format => 'lastname_coma_firstname' do
                    assert_equal ['users.lastname', 'users.firstname', 'users.id'], User.fields_for_order_statement
                  end
                end
                def test_fields_for_order_statement_width_table_name_should_prepend_table_name
                  with_settings :user_format => 'lastname_firstname' do
                    assert_equal ['authors.lastname', 'authors.firstname', 'authors.id'], User.fields_for_order_statement('authors')
                  end
                end
                def test_fields_for_order_statement_with_blank_format_should_return_default
                  with_settings :user_format => '' do
                    assert_equal ['users.firstname', 'users.lastname', 'users.id'], User.fields_for_order_statement
                  end
                end
                def test_fields_for_order_statement_with_invalid_format_should_return_default
                  with_settings :user_format => 'foo' do
                    assert_equal ['users.firstname', 'users.lastname', 'users.id'], User.fields_for_order_statement
                  end
                end
                test ".try_to_login with good credentials should return the user" do
                  user = User.try_to_login("admin", "admin")
                  assert_kind_of User, user
                  assert_equal "admin", user.login
                end
                test ".try_to_login with wrong credentials should return nil" do
                  assert_nil User.try_to_login("admin", "foo")
                end
                def test_try_to_login_with_locked_user_should_return_nil
                  @jsmith.status = User::STATUS_LOCKED
                  @jsmith.save!
                  user = User.try_to_login("jsmith", "jsmith")
                  assert_equal nil, user
                end
                def test_try_to_login_with_locked_user_and_not_active_only_should_return_user
                  @jsmith.status = User::STATUS_LOCKED
                  @jsmith.save!
                  user = User.try_to_login("jsmith", "jsmith", false)
                  assert_equal @jsmith, user
                end
                test ".try_to_login should fall-back to case-insensitive if user login is not found as-typed" do
                  user = User.try_to_login("AdMin", "admin")
                  assert_kind_of User, user
                  assert_equal "admin", user.login
                end
                test ".try_to_login should select the exact matching user first" do
                  case_sensitive_user = User.generate! do |user|
                    user.password = "admin123"
                  end
                  # bypass validations to make it appear like existing data
                  case_sensitive_user.update_attribute(:login, 'ADMIN')
                  user = User.try_to_login("ADMIN", "admin123")
                  assert_kind_of User, user
                  assert_equal "ADMIN", user.login
                end
                if ldap_configured?
                  context "#try_to_login using LDAP" do
                    context "with failed connection to the LDAP server" do
                      should "return nil" do
                        @auth_source = AuthSourceLdap.find(1)
                        AuthSource.any_instance.stubs(:initialize_ldap_con).raises(Net::LDAP::LdapError, 'Cannot connect')
                        assert_equal nil, User.try_to_login('edavis', 'wrong')
                      end
                    end
                    context "with an unsuccessful authentication" do
                      should "return nil" do
                        assert_equal nil, User.try_to_login('edavis', 'wrong')
                      end
                    end
                    context "binding with user's account" do
                      setup do
                        @auth_source = AuthSourceLdap.find(1)
                        @auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                        @auth_source.account_password = ''
                        @auth_source.save!
                        @ldap_user = User.new(:mail => 'example1@redmine.org', :firstname => 'LDAP', :lastname => 'user', :auth_source_id => 1)
                        @ldap_user.login = 'example1'
                        @ldap_user.save!
                      end
                      context "with a successful authentication" do
                        should "return the user" do
                          assert_equal @ldap_user, User.try_to_login('example1', '123456')
                        end
                      end
                      context "with an unsuccessful authentication" do
                        should "return nil" do
                          assert_nil User.try_to_login('example1', '11111')
                        end
                      end
                    end
                    context "on the fly registration" do
                      setup do
                        @auth_source = AuthSourceLdap.find(1)
                        @auth_source.update_attribute :onthefly_register, true
                      end
                      context "with a successful authentication" do
                        should "create a new user account if it doesn't exist" do
                          assert_difference('User.count') do
                            user = User.try_to_login('edavis', '123456')
                            assert !user.admin?
                          end
                        end
                        should "retrieve existing user" do
                          user = User.try_to_login('edavis', '123456')
                          user.admin = true
                          user.save!
                          assert_no_difference('User.count') do
                            user = User.try_to_login('edavis', '123456')
                            assert user.admin?
                          end
                        end
                      end
                      context "binding with user's account" do
                        setup do
                          @auth_source = AuthSourceLdap.find(1)
                          @auth_source.account = "uid=$login,ou=Person,dc=redmine,dc=org"
                          @auth_source.account_password = ''
                          @auth_source.save!
                        end
                        context "with a successful authentication" do
                          should "create a new user account if it doesn't exist" do
                            assert_difference('User.count') do
                              user = User.try_to_login('example1', '123456')
                              assert_kind_of User, user
                            end
                          end
                        end
                        context "with an unsuccessful authentication" do
                          should "return nil" do
                            assert_nil User.try_to_login('example1', '11111')
                          end
                        end
                      end
                    end
                  end
                else
                  puts "Skipping LDAP tests."
                end
                def test_create_anonymous
                  AnonymousUser.delete_all
                  anon = User.anonymous
                  assert !anon.new_record?
                  assert_kind_of AnonymousUser, anon
                end
                def test_ensure_single_anonymous_user
                  AnonymousUser.delete_all
                  anon1 = User.anonymous
                  assert !anon1.new_record?
                  assert_kind_of AnonymousUser, anon1
                  anon2 = AnonymousUser.create(
                              :lastname => 'Anonymous', :firstname => '',
                              :mail => '', :login => '', :status => 0)
                  assert_equal 1, anon2.errors.count
                end
                def test_rss_key
                  assert_nil @jsmith.rss_token
                  key = @jsmith.rss_key
                  assert_equal 40, key.length
                  @jsmith.reload
                  assert_equal key, @jsmith.rss_key
                end
                def test_rss_key_should_not_be_generated_twice
                  assert_difference 'Token.count', 1 do
                    key1 = @jsmith.rss_key
                    key2 = @jsmith.rss_key
                    assert_equal key1, key2
                  end
                end
                def test_api_key_should_not_be_generated_twice
                  assert_difference 'Token.count', 1 do
                    key1 = @jsmith.api_key
                    key2 = @jsmith.api_key
                    assert_equal key1, key2
                  end
                end
                test "#api_key should generate a new one if the user doesn't have one" do
                  user = User.generate!(:api_token => nil)
                  assert_nil user.api_token
                  key = user.api_key
                  assert_equal 40, key.length
                  user.reload
                  assert_equal key, user.api_key
                end
                test "#api_key should return the existing api token value" do
                  user = User.generate!
                  token = Token.create!(:action => 'api')
                  user.api_token = token
                  assert user.save
                  assert_equal token.value, user.api_key
                end
                test "#find_by_api_key should return nil if no matching key is found" do
                  assert_nil User.find_by_api_key('zzzzzzzzz')
                end
                test "#find_by_api_key should return nil if the key is found for an inactive user" do
                  user = User.generate!
                  user.status = User::STATUS_LOCKED
                  token = Token.create!(:action => 'api')
                  user.api_token = token
                  user.save
                  assert_nil User.find_by_api_key(token.value)
                end
                test "#find_by_api_key should return the user if the key is found for an active user" do
                  user = User.generate!
                  token = Token.create!(:action => 'api')
                  user.api_token = token
                  user.save
                  assert_equal user, User.find_by_api_key(token.value)
                end
                def test_default_admin_account_changed_should_return_false_if_account_was_not_changed
                  user = User.find_by_login("admin")
                  user.password = "admin"
                  assert user.save(:validate => false)
                  assert_equal false, User.default_admin_account_changed?
                end
                def test_default_admin_account_changed_should_return_true_if_password_was_changed
                  user = User.find_by_login("admin")
                  user.password = "newpassword"
                  user.save!
                  assert_equal true, User.default_admin_account_changed?
                end
                def test_default_admin_account_changed_should_return_true_if_account_is_disabled
                  user = User.find_by_login("admin")
                  user.password = "admin"
                  user.status = User::STATUS_LOCKED
                  assert user.save(:validate => false)
                  assert_equal true, User.default_admin_account_changed?
                end
                def test_default_admin_account_changed_should_return_true_if_account_does_not_exist
                  user = User.find_by_login("admin")
                  user.destroy
                  assert_equal true, User.default_admin_account_changed?
                end
                def test_membership_with_project_should_return_membership
                  project = Project.find(1)
                  membership = @jsmith.membership(project)
                  assert_kind_of Member, membership
                  assert_equal @jsmith, membership.user
                  assert_equal project, membership.project
                end
                def test_membership_with_project_id_should_return_membership
                  project = Project.find(1)
                  membership = @jsmith.membership(1)
                  assert_kind_of Member, membership
                  assert_equal @jsmith, membership.user
                  assert_equal project, membership.project
                end
                def test_membership_for_non_member_should_return_nil
                  project = Project.find(1)
                  user = User.generate!
                  membership = user.membership(1)
                  assert_nil membership
                end
                def test_roles_for_project
                  # user with a role
                  roles = @jsmith.roles_for_project(Project.find(1))
                  assert_kind_of Role, roles.first
                  assert_equal "Manager", roles.first.name
                  # user with no role
                  assert_nil @dlopper.roles_for_project(Project.find(2)).detect {|role| role.member?}
                end
                def test_projects_by_role_for_user_with_role
                  user = User.find(2)
                  assert_kind_of Hash, user.projects_by_role
                  assert_equal 2, user.projects_by_role.size
                  assert_equal [1,5], user.projects_by_role[Role.find(1)].collect(&:id).sort
                  assert_equal [2], user.projects_by_role[Role.find(2)].collect(&:id).sort
                end
                def test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array
                  user = User.find(2)
                  assert_equal [], user.projects_by_role[Role.find(3)]
                  # should not update the hash
                  assert_nil user.projects_by_role.values.detect(&:blank?)
                end
                def test_projects_by_role_for_user_with_no_role
                  user = User.generate!
                  assert_equal({}, user.projects_by_role)
                end
                def test_projects_by_role_for_anonymous
                  assert_equal({}, User.anonymous.projects_by_role)
                end
                def test_valid_notification_options
                  # without memberships
                  assert_equal 5, User.find(7).valid_notification_options.size
                  # with memberships
                  assert_equal 6, User.find(2).valid_notification_options.size
                end
                def test_valid_notification_options_class_method
                  assert_equal 5, User.valid_notification_options.size
                  assert_equal 5, User.valid_notification_options(User.find(7)).size
                  assert_equal 6, User.valid_notification_options(User.find(2)).size
                end
                def test_mail_notification_all
                  @jsmith.mail_notification = 'all'
                  @jsmith.notified_project_ids = []
                  @jsmith.save
                  @jsmith.reload
                  assert @jsmith.projects.first.recipients.include?(@jsmith.mail)
                end
                def test_mail_notification_selected
                  @jsmith.mail_notification = 'selected'
                  @jsmith.notified_project_ids = [1]
                  @jsmith.save
                  @jsmith.reload
                  assert Project.find(1).recipients.include?(@jsmith.mail)
                end
                def test_mail_notification_only_my_events
                  @jsmith.mail_notification = 'only_my_events'
                  @jsmith.notified_project_ids = []
                  @jsmith.save
                  @jsmith.reload
                  assert !@jsmith.projects.first.recipients.include?(@jsmith.mail)
                end
                def test_comments_sorting_preference
                  assert !@jsmith.wants_comments_in_reverse_order?
                  @jsmith.pref.comments_sorting = 'asc'
                  assert !@jsmith.wants_comments_in_reverse_order?
                  @jsmith.pref.comments_sorting = 'desc'
                  assert @jsmith.wants_comments_in_reverse_order?
                end
                def test_find_by_mail_should_be_case_insensitive
                  u = User.find_by_mail('JSmith@somenet.foo')
                  assert_not_nil u
                  assert_equal 'jsmith@somenet.foo', u.mail
                end
                def test_random_password
                  u = User.new
                  u.random_password
                  assert !u.password.blank?
                  assert !u.password_confirmation.blank?
                end
                test "#change_password_allowed? should be allowed if no auth source is set" do
                  user = User.generate!
                  assert user.change_password_allowed?
                end
                test "#change_password_allowed? should delegate to the auth source" do
                  user = User.generate!
                  allowed_auth_source = AuthSource.generate!
                  def allowed_auth_source.allow_password_changes?; true; end
                  denied_auth_source = AuthSource.generate!
                  def denied_auth_source.allow_password_changes?; false; end
                  assert user.change_password_allowed?
                  user.auth_source = allowed_auth_source
                  assert user.change_password_allowed?, "User not allowed to change password, though auth source does"
                  user.auth_source = denied_auth_source
                  assert !user.change_password_allowed?, "User allowed to change password, though auth source does not"
                end
                def test_own_account_deletable_should_be_true_with_unsubscrive_enabled
                  with_settings :unsubscribe => '1' do
                    assert_equal true, User.find(2).own_account_deletable?
                  end
                end
                def test_own_account_deletable_should_be_false_with_unsubscrive_disabled
                  with_settings :unsubscribe => '0' do
                    assert_equal false, User.find(2).own_account_deletable?
                  end
                end
                def test_own_account_deletable_should_be_false_for_a_single_admin
                  User.delete_all(["admin = ? AND id <> ?", true, 1])
                  with_settings :unsubscribe => '1' do
                    assert_equal false, User.find(1).own_account_deletable?
                  end
                end
                def test_own_account_deletable_should_be_true_for_an_admin_if_other_admin_exists
                  User.generate! do |user|
                    user.admin = true
                  end
                  with_settings :unsubscribe => '1' do
                    assert_equal true, User.find(1).own_account_deletable?
                  end
                end
                context "#allowed_to?" do
                  context "with a unique project" do
                    should "return false if project is archived" do
                      project = Project.find(1)
                      Project.any_instance.stubs(:status).returns(Project::STATUS_ARCHIVED)
                      assert_equal false, @admin.allowed_to?(:view_issues, Project.find(1))
                    end
                    should "return false for write action if project is closed" do
                      project = Project.find(1)
                      Project.any_instance.stubs(:status).returns(Project::STATUS_CLOSED)
                      assert_equal false, @admin.allowed_to?(:edit_project, Project.find(1))
                    end
                    should "return true for read action if project is closed" do
                      project = Project.find(1)
                      Project.any_instance.stubs(:status).returns(Project::STATUS_CLOSED)
                      assert_equal true, @admin.allowed_to?(:view_project, Project.find(1))
                    end
                    should "return false if related module is disabled" do
                      project = Project.find(1)
                      project.enabled_module_names = ["issue_tracking"]
                      assert_equal true, @admin.allowed_to?(:add_issues, project)
                      assert_equal false, @admin.allowed_to?(:view_wiki_pages, project)
                    end
                    should "authorize nearly everything for admin users" do
                      project = Project.find(1)
                      assert ! @admin.member_of?(project)
                      %w(edit_issues delete_issues manage_news add_documents manage_wiki).each do |p|
                        assert_equal true, @admin.allowed_to?(p.to_sym, project)
                      end
                    end
                    should "authorize normal users depending on their roles" do
                      project = Project.find(1)
                      assert_equal true, @jsmith.allowed_to?(:delete_messages, project)    #Manager
                      assert_equal false, @dlopper.allowed_to?(:delete_messages, project) #Developper
                    end
                  end
                  context "with multiple projects" do
                    should "return false if array is empty" do
                      assert_equal false, @admin.allowed_to?(:view_project, [])
                    end
                    should "return true only if user has permission on all these projects" do
                      assert_equal true, @admin.allowed_to?(:view_project, Project.all)
                      assert_equal false, @dlopper.allowed_to?(:view_project, Project.all) #cannot see Project(2)
                      assert_equal true, @jsmith.allowed_to?(:edit_issues, @jsmith.projects) #Manager or Developer everywhere
                      assert_equal false, @jsmith.allowed_to?(:delete_issue_watchers, @jsmith.projects) #Dev cannot delete_issue_watchers
                    end
                    should "behave correctly with arrays of 1 project" do
                      assert_equal false, User.anonymous.allowed_to?(:delete_issues, [Project.first])
                    end
                  end
                  context "with options[:global]" do
                    should "authorize if user has at least one role that has this permission" do
                      @dlopper2 = User.find(5) #only Developper on a project, not Manager anywhere
                      @anonymous = User.find(6)
                      assert_equal true, @jsmith.allowed_to?(:delete_issue_watchers, nil, :global => true)
                      assert_equal false, @dlopper2.allowed_to?(:delete_issue_watchers, nil, :global => true)
                      assert_equal true, @dlopper2.allowed_to?(:add_issues, nil, :global => true)
                      assert_equal false, @anonymous.allowed_to?(:add_issues, nil, :global => true)
                      assert_equal true, @anonymous.allowed_to?(:view_issues, nil, :global => true)
                    end
                  end
                end
                context "User#notify_about?" do
                  context "Issues" do
                    setup do
                      @project = Project.find(1)
                      @author = User.generate!
                      @assignee = User.generate!
                      @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
                    end
                    should "be true for a user with :all" do
                      @author.update_attribute(:mail_notification, 'all')
                      assert @author.notify_about?(@issue)
                    end
                    should "be false for a user with :none" do
                      @author.update_attribute(:mail_notification, 'none')
                      assert ! @author.notify_about?(@issue)
                    end
                    should "be false for a user with :only_my_events and isn't an author, creator, or assignee" do
                      @user = User.generate!(:mail_notification => 'only_my_events')
                      Member.create!(:user => @user, :project => @project, :role_ids => [1])
                      assert ! @user.notify_about?(@issue)
                    end
                    should "be true for a user with :only_my_events and is the author" do
                      @author.update_attribute(:mail_notification, 'only_my_events')
                      assert @author.notify_about?(@issue)
                    end
                    should "be true for a user with :only_my_events and is the assignee" do
                      @assignee.update_attribute(:mail_notification, 'only_my_events')
                      assert @assignee.notify_about?(@issue)
                    end
                    should "be true for a user with :only_assigned and is the assignee" do
                      @assignee.update_attribute(:mail_notification, 'only_assigned')
                      assert @assignee.notify_about?(@issue)
                    end
                    should "be false for a user with :only_assigned and is not the assignee" do
                      @author.update_attribute(:mail_notification, 'only_assigned')
                      assert ! @author.notify_about?(@issue)
                    end
                    should "be true for a user with :only_owner and is the author" do
                      @author.update_attribute(:mail_notification, 'only_owner')
                      assert @author.notify_about?(@issue)
                    end
                    should "be false for a user with :only_owner and is not the author" do
                      @assignee.update_attribute(:mail_notification, 'only_owner')
                      assert ! @assignee.notify_about?(@issue)
                    end
                    should "be true for a user with :selected and is the author" do
                      @author.update_attribute(:mail_notification, 'selected')
                      assert @author.notify_about?(@issue)
                    end
                    should "be true for a user with :selected and is the assignee" do
                      @assignee.update_attribute(:mail_notification, 'selected')
                      assert @assignee.notify_about?(@issue)
                    end
                    should "be false for a user with :selected and is not the author or assignee" do
                      @user = User.generate!(:mail_notification => 'selected')
                      Member.create!(:user => @user, :project => @project, :role_ids => [1])
                      assert ! @user.notify_about?(@issue)
                    end
                  end
                end
                def test_notify_about_news
                  user = User.generate!
                  news = News.new
                  User::MAIL_NOTIFICATION_OPTIONS.map(&:first).each do |option|
                    user.mail_notification = option
                    assert_equal (option != 'none'), user.notify_about?(news)
                  end
                end
                def test_salt_unsalted_passwords
                  # Restore a user with an unsalted password
                  user = User.find(1)
                  user.salt = nil
                  user.hashed_password = User.hash_password("unsalted")
                  user.save!
                  User.salt_unsalted_passwords!
                  user.reload
                  # Salt added
                  assert !user.salt.blank?
                  # Password still valid
                  assert user.check_password?("unsalted")
                  assert_equal user, User.try_to_login(user.login, "unsalted")
                end
                if Object.const_defined?(:OpenID)
                def test_setting_identity_url
                  normalized_open_id_url = 'http://example.com/'
                  u = User.new( :identity_url => 'http://example.com/' )
                  assert_equal normalized_open_id_url, u.identity_url
                end
                def test_setting_identity_url_without_trailing_slash
                  normalized_open_id_url = 'http://example.com/'
                  u = User.new( :identity_url => 'http://example.com' )
                  assert_equal normalized_open_id_url, u.identity_url
                end
                def test_setting_identity_url_without_protocol
                  normalized_open_id_url = 'http://example.com/'
                  u = User.new( :identity_url => 'example.com' )
                  assert_equal normalized_open_id_url, u.identity_url
                end
                def test_setting_blank_identity_url
                  u = User.new( :identity_url => 'example.com' )
                  u.identity_url = ''
                  assert u.identity_url.blank?
                end
                def test_setting_invalid_identity_url
                  u = User.new( :identity_url => 'this is not an openid url' )
                  assert u.identity_url.blank?
                end
                else
                  puts "Skipping openid tests."
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages