jro_apps/redmine Commit - r4120:c43ef6e7696e

Code cleanup: renamed variables in User#allowed_to? with explicit names...

Jean-Baptiste Barth -

r4120:c43ef6e7696e

parent child

Context file:

r4120:c43ef6e7696e

Collapse all files

app/models/user.rb +11 -11

                # * a group of projects : returns true if user is allowed on every project
                # * nil with options[:global] set : check if user has at least one role allowed for this action,
                #   or falls back to Non Member / Anonymous permissions depending if the user is logged
-               def allowed_to?(action, project, options={})
-                 if project && project.is_a?(Project)
+               def allowed_to?(action, context, options={})
+                 if context && context.is_a?(Project)
                    # No action allowed on archived projects
-                   return false unless project.active?
+                   return false unless context.active?
                    # No action allowed on disabled modules
-                   return false unless project.allows_to?(action)
+                   return false unless context.allows_to?(action)
                    # Admin users are authorized for anything else
                    return true if admin?
-                   roles = roles_for_project(project)
+                   roles = roles_for_project(context)
                    return false unless roles
-                   roles.detect {|role| (project.is_public? || role.member?) && role.allowed_to?(action)}
+                   roles.detect {|role| (context.is_public? || role.member?) && role.allowed_to?(action)}
-                 elsif project && project.is_a?(Array)
+                 elsif context && context.is_a?(Array)
                    # Authorize if user is authorized on every element of the array
-                   project.map do |p|
-                     allowed_to?(action,p,options)
-                   end.inject do |memo,p|
-                     memo && p
+                   context.map do |project|
+                     allowed_to?(action,project,options)
+                   end.inject do |memo,allowed|
+                     memo && allowed
                    end
                  elsif options[:global]
                    # Admin users are always authorized

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages