##// END OF EJS Templates
attachment: add a functional test to show an ISO-8859-1 content file (#2371)...
Toshi MARUYAMA -
r7748:c1ed67c74178
parent child
Show More
@@ -1,234 +1,254
1 # encoding: utf-8
1 # encoding: utf-8
2 #
2 #
3 # Redmine - project management software
3 # Redmine - project management software
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
5 #
5 #
6 # This program is free software; you can redistribute it and/or
6 # This program is free software; you can redistribute it and/or
7 # modify it under the terms of the GNU General Public License
7 # modify it under the terms of the GNU General Public License
8 # as published by the Free Software Foundation; either version 2
8 # as published by the Free Software Foundation; either version 2
9 # of the License, or (at your option) any later version.
9 # of the License, or (at your option) any later version.
10 #
10 #
11 # This program is distributed in the hope that it will be useful,
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
14 # GNU General Public License for more details.
15 #
15 #
16 # You should have received a copy of the GNU General Public License
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19
19
20 require File.expand_path('../../test_helper', __FILE__)
20 require File.expand_path('../../test_helper', __FILE__)
21 require 'attachments_controller'
21 require 'attachments_controller'
22
22
23 # Re-raise errors caught by the controller.
23 # Re-raise errors caught by the controller.
24 class AttachmentsController; def rescue_action(e) raise e end; end
24 class AttachmentsController; def rescue_action(e) raise e end; end
25
25
26 class AttachmentsControllerTest < ActionController::TestCase
26 class AttachmentsControllerTest < ActionController::TestCase
27 fixtures :users, :projects, :roles, :members, :member_roles,
27 fixtures :users, :projects, :roles, :members, :member_roles,
28 :enabled_modules, :issues, :trackers, :attachments,
28 :enabled_modules, :issues, :trackers, :attachments,
29 :versions, :wiki_pages, :wikis, :documents
29 :versions, :wiki_pages, :wikis, :documents
30
30
31 def setup
31 def setup
32 @controller = AttachmentsController.new
32 @controller = AttachmentsController.new
33 @request = ActionController::TestRequest.new
33 @request = ActionController::TestRequest.new
34 @response = ActionController::TestResponse.new
34 @response = ActionController::TestResponse.new
35 Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
35 Attachment.storage_path = "#{Rails.root}/test/fixtures/files"
36 User.current = nil
36 User.current = nil
37 end
37 end
38
38
39 def test_show_diff
39 def test_show_diff
40 ['inline', 'sbs'].each do |dt|
40 ['inline', 'sbs'].each do |dt|
41 # 060719210727_changeset_utf8.diff
41 # 060719210727_changeset_utf8.diff
42 get :show, :id => 14, :type => dt
42 get :show, :id => 14, :type => dt
43 assert_response :success
43 assert_response :success
44 assert_template 'diff'
44 assert_template 'diff'
45 assert_equal 'text/html', @response.content_type
45 assert_equal 'text/html', @response.content_type
46 assert_tag 'th',
46 assert_tag 'th',
47 :attributes => {:class => /filename/},
47 :attributes => {:class => /filename/},
48 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
48 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
49 assert_tag 'td',
49 assert_tag 'td',
50 :attributes => {:class => /line-code/},
50 :attributes => {:class => /line-code/},
51 :content => /Demande créée avec succès/
51 :content => /Demande créée avec succès/
52 end
52 end
53 end
53 end
54
54
55 def test_show_diff_replcace_cannot_convert_content
55 def test_show_diff_replcace_cannot_convert_content
56 with_settings :repositories_encodings => 'UTF-8' do
56 with_settings :repositories_encodings => 'UTF-8' do
57 ['inline', 'sbs'].each do |dt|
57 ['inline', 'sbs'].each do |dt|
58 # 060719210727_changeset_iso8859-1.diff
58 # 060719210727_changeset_iso8859-1.diff
59 get :show, :id => 5
59 get :show, :id => 5
60 assert_response :success
60 assert_response :success
61 assert_template 'diff'
61 assert_template 'diff'
62 assert_equal 'text/html', @response.content_type
62 assert_equal 'text/html', @response.content_type
63 assert_tag 'th',
63 assert_tag 'th',
64 :attributes => {:class => "filename"},
64 :attributes => {:class => "filename"},
65 :content => /issues_controller.rb\t\(r\?vision 1484\)/
65 :content => /issues_controller.rb\t\(r\?vision 1484\)/
66 assert_tag 'td',
66 assert_tag 'td',
67 :attributes => {:class => /line-code/},
67 :attributes => {:class => /line-code/},
68 :content => /Demande cr\?\?e avec succ\?s/
68 :content => /Demande cr\?\?e avec succ\?s/
69 end
69 end
70 end
70 end
71 end
71 end
72
72
73 def test_show_diff_latin_1
73 def test_show_diff_latin_1
74 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
74 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
75 # 060719210727_changeset_iso8859-1.diff
75 # 060719210727_changeset_iso8859-1.diff
76 get :show, :id => 5
76 get :show, :id => 5
77 assert_response :success
77 assert_response :success
78 assert_template 'diff'
78 assert_template 'diff'
79 assert_equal 'text/html', @response.content_type
79 assert_equal 'text/html', @response.content_type
80
80
81 assert_tag 'th',
81 assert_tag 'th',
82 :attributes => {:class => "filename"},
82 :attributes => {:class => "filename"},
83 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
83 :content => /issues_controller.rb\t\(rΓ©vision 1484\)/
84 assert_tag 'td',
84 assert_tag 'td',
85 :attributes => {:class => /line-code/},
85 :attributes => {:class => /line-code/},
86 :content => /Demande créée avec succès/
86 :content => /Demande créée avec succès/
87 end
87 end
88 end
88 end
89
89
90 def test_show_text_file
90 def test_show_text_file
91 get :show, :id => 4
91 get :show, :id => 4
92 assert_response :success
92 assert_response :success
93 assert_template 'file'
93 assert_template 'file'
94 assert_equal 'text/html', @response.content_type
94 assert_equal 'text/html', @response.content_type
95 end
95 end
96
96
97 def test_show_text_file_utf_8
97 def test_show_text_file_utf_8
98 set_tmp_attachments_directory
98 set_tmp_attachments_directory
99 a = Attachment.new(:container => Issue.find(1),
99 a = Attachment.new(:container => Issue.find(1),
100 :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
100 :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
101 :author => User.find(1))
101 :author => User.find(1))
102 assert a.save
102 assert a.save
103 assert_equal 'japanese-utf-8.txt', a.filename
103 assert_equal 'japanese-utf-8.txt', a.filename
104
104
105 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
105 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e"
106 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
106 str_japanese.force_encoding('UTF-8') if str_japanese.respond_to?(:force_encoding)
107
107
108 get :show, :id => a.id
108 get :show, :id => a.id
109 assert_response :success
109 assert_response :success
110 assert_template 'file'
110 assert_template 'file'
111 assert_equal 'text/html', @response.content_type
111 assert_equal 'text/html', @response.content_type
112 assert_tag :tag => 'th',
112 assert_tag :tag => 'th',
113 :content => '1',
113 :content => '1',
114 :attributes => { :class => 'line-num' },
114 :attributes => { :class => 'line-num' },
115 :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
115 :sibling => { :tag => 'td', :content => /#{str_japanese}/ }
116 end
116 end
117
117
118 def test_show_text_file_replcace_cannot_convert_content
118 def test_show_text_file_replcace_cannot_convert_content
119 set_tmp_attachments_directory
119 set_tmp_attachments_directory
120 with_settings :repositories_encodings => 'UTF-8' do
120 with_settings :repositories_encodings => 'UTF-8' do
121 a = Attachment.new(:container => Issue.find(1),
121 a = Attachment.new(:container => Issue.find(1),
122 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
122 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
123 :author => User.find(1))
123 :author => User.find(1))
124 assert a.save
124 assert a.save
125 assert_equal 'iso8859-1.txt', a.filename
125 assert_equal 'iso8859-1.txt', a.filename
126
126
127 get :show, :id => a.id
127 get :show, :id => a.id
128 assert_response :success
128 assert_response :success
129 assert_template 'file'
129 assert_template 'file'
130 assert_equal 'text/html', @response.content_type
130 assert_equal 'text/html', @response.content_type
131 assert_tag :tag => 'th',
131 assert_tag :tag => 'th',
132 :content => '7',
132 :content => '7',
133 :attributes => { :class => 'line-num' },
133 :attributes => { :class => 'line-num' },
134 :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
134 :sibling => { :tag => 'td', :content => /Demande cr\?\?e avec succ\?s/ }
135 end
135 end
136 end
136 end
137
137
138 def test_show_text_file_latin_1
139 set_tmp_attachments_directory
140 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
141 a = Attachment.new(:container => Issue.find(1),
142 :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
143 :author => User.find(1))
144 assert a.save
145 assert_equal 'iso8859-1.txt', a.filename
146
147 get :show, :id => a.id
148 assert_response :success
149 assert_template 'file'
150 assert_equal 'text/html', @response.content_type
151 assert_tag :tag => 'th',
152 :content => '7',
153 :attributes => { :class => 'line-num' },
154 :sibling => { :tag => 'td', :content => /Demande créée avec succès/ }
155 end
156 end
157
138 def test_show_text_file_should_send_if_too_big
158 def test_show_text_file_should_send_if_too_big
139 Setting.file_max_size_displayed = 512
159 Setting.file_max_size_displayed = 512
140 Attachment.find(4).update_attribute :filesize, 754.kilobyte
160 Attachment.find(4).update_attribute :filesize, 754.kilobyte
141
161
142 get :show, :id => 4
162 get :show, :id => 4
143 assert_response :success
163 assert_response :success
144 assert_equal 'application/x-ruby', @response.content_type
164 assert_equal 'application/x-ruby', @response.content_type
145 end
165 end
146
166
147 def test_show_other
167 def test_show_other
148 get :show, :id => 6
168 get :show, :id => 6
149 assert_response :success
169 assert_response :success
150 assert_equal 'application/octet-stream', @response.content_type
170 assert_equal 'application/octet-stream', @response.content_type
151 end
171 end
152
172
153 def test_show_file_from_private_issue_without_permission
173 def test_show_file_from_private_issue_without_permission
154 get :show, :id => 15
174 get :show, :id => 15
155 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
175 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
156 end
176 end
157
177
158 def test_show_file_from_private_issue_with_permission
178 def test_show_file_from_private_issue_with_permission
159 @request.session[:user_id] = 2
179 @request.session[:user_id] = 2
160 get :show, :id => 15
180 get :show, :id => 15
161 assert_response :success
181 assert_response :success
162 assert_tag 'h2', :content => /private.diff/
182 assert_tag 'h2', :content => /private.diff/
163 end
183 end
164
184
165 def test_download_text_file
185 def test_download_text_file
166 get :download, :id => 4
186 get :download, :id => 4
167 assert_response :success
187 assert_response :success
168 assert_equal 'application/x-ruby', @response.content_type
188 assert_equal 'application/x-ruby', @response.content_type
169 end
189 end
170
190
171 def test_download_should_assign_content_type_if_blank
191 def test_download_should_assign_content_type_if_blank
172 Attachment.find(4).update_attribute(:content_type, '')
192 Attachment.find(4).update_attribute(:content_type, '')
173
193
174 get :download, :id => 4
194 get :download, :id => 4
175 assert_response :success
195 assert_response :success
176 assert_equal 'text/x-ruby', @response.content_type
196 assert_equal 'text/x-ruby', @response.content_type
177 end
197 end
178
198
179 def test_download_missing_file
199 def test_download_missing_file
180 get :download, :id => 2
200 get :download, :id => 2
181 assert_response 404
201 assert_response 404
182 end
202 end
183
203
184 def test_anonymous_on_private_private
204 def test_anonymous_on_private_private
185 get :download, :id => 7
205 get :download, :id => 7
186 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
206 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
187 end
207 end
188
208
189 def test_destroy_issue_attachment
209 def test_destroy_issue_attachment
190 issue = Issue.find(3)
210 issue = Issue.find(3)
191 @request.session[:user_id] = 2
211 @request.session[:user_id] = 2
192
212
193 assert_difference 'issue.attachments.count', -1 do
213 assert_difference 'issue.attachments.count', -1 do
194 post :destroy, :id => 1
214 post :destroy, :id => 1
195 end
215 end
196 # no referrer
216 # no referrer
197 assert_redirected_to '/projects/ecookbook'
217 assert_redirected_to '/projects/ecookbook'
198 assert_nil Attachment.find_by_id(1)
218 assert_nil Attachment.find_by_id(1)
199 j = issue.journals.find(:first, :order => 'created_on DESC')
219 j = issue.journals.find(:first, :order => 'created_on DESC')
200 assert_equal 'attachment', j.details.first.property
220 assert_equal 'attachment', j.details.first.property
201 assert_equal '1', j.details.first.prop_key
221 assert_equal '1', j.details.first.prop_key
202 assert_equal 'error281.txt', j.details.first.old_value
222 assert_equal 'error281.txt', j.details.first.old_value
203 end
223 end
204
224
205 def test_destroy_wiki_page_attachment
225 def test_destroy_wiki_page_attachment
206 @request.session[:user_id] = 2
226 @request.session[:user_id] = 2
207 assert_difference 'Attachment.count', -1 do
227 assert_difference 'Attachment.count', -1 do
208 post :destroy, :id => 3
228 post :destroy, :id => 3
209 assert_response 302
229 assert_response 302
210 end
230 end
211 end
231 end
212
232
213 def test_destroy_project_attachment
233 def test_destroy_project_attachment
214 @request.session[:user_id] = 2
234 @request.session[:user_id] = 2
215 assert_difference 'Attachment.count', -1 do
235 assert_difference 'Attachment.count', -1 do
216 post :destroy, :id => 8
236 post :destroy, :id => 8
217 assert_response 302
237 assert_response 302
218 end
238 end
219 end
239 end
220
240
221 def test_destroy_version_attachment
241 def test_destroy_version_attachment
222 @request.session[:user_id] = 2
242 @request.session[:user_id] = 2
223 assert_difference 'Attachment.count', -1 do
243 assert_difference 'Attachment.count', -1 do
224 post :destroy, :id => 9
244 post :destroy, :id => 9
225 assert_response 302
245 assert_response 302
226 end
246 end
227 end
247 end
228
248
229 def test_destroy_without_permission
249 def test_destroy_without_permission
230 post :destroy, :id => 3
250 post :destroy, :id => 3
231 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdestroy%2F3'
251 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdestroy%2F3'
232 assert Attachment.find_by_id(3)
252 assert Attachment.find_by_id(3)
233 end
253 end
234 end
254 end
General Comments 0
You need to be logged in to leave comments. Login now