##// END OF EJS Templates
jro_apps » redmine
RSS
The descendant count in the issues delete confirmation message is wrong if issues share some descendants....
Jean-Philippe Lang -
r13436:bfdd9f7c295d
parent child
Show More
Side by Side Unified
Context file:
r13436:bfdd9f7c295d Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,430 +1,430
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2014 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 module IssuesHelper
21 21 include ApplicationHelper
22 22
23 23 def issue_list(issues, &block)
24 24 ancestors = []
25 25 issues.each do |issue|
26 26 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
27 27 ancestors.pop
28 28 end
29 29 yield issue, ancestors.size
30 30 ancestors << issue unless issue.leaf?
31 31 end
32 32 end
33 33
34 34 # Renders a HTML/CSS tooltip
35 35 #
36 36 # To use, a trigger div is needed. This is a div with the class of "tooltip"
37 37 # that contains this method wrapped in a span with the class of "tip"
38 38 #
39 39 # <div class="tooltip"><%= link_to_issue(issue) %>
40 40 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
41 41 # </div>
42 42 #
43 43 def render_issue_tooltip(issue)
44 44 @cached_label_status ||= l(:field_status)
45 45 @cached_label_start_date ||= l(:field_start_date)
46 46 @cached_label_due_date ||= l(:field_due_date)
47 47 @cached_label_assigned_to ||= l(:field_assigned_to)
48 48 @cached_label_priority ||= l(:field_priority)
49 49 @cached_label_project ||= l(:field_project)
50 50
51 51 link_to_issue(issue) + "<br /><br />".html_safe +
52 52 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
53 53 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
54 54 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
55 55 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
56 56 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
57 57 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
58 58 end
59 59
60 60 def issue_heading(issue)
61 61 h("#{issue.tracker} ##{issue.id}")
62 62 end
63 63
64 64 def render_issue_subject_with_tree(issue)
65 65 s = ''
66 66 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
67 67 ancestors.each do |ancestor|
68 68 s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
69 69 end
70 70 s << '<div>'
71 71 subject = h(issue.subject)
72 72 if issue.is_private?
73 73 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
74 74 end
75 75 s << content_tag('h3', subject)
76 76 s << '</div>' * (ancestors.size + 1)
77 77 s.html_safe
78 78 end
79 79
80 80 def render_descendants_tree(issue)
81 81 s = '<form><table class="list issues">'
82 82 issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
83 83 css = "issue issue-#{child.id} hascontextmenu"
84 84 css << " idnt idnt-#{level}" if level > 0
85 85 s << content_tag('tr',
86 86 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
87 87 content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
88 88 content_tag('td', h(child.status)) +
89 89 content_tag('td', link_to_user(child.assigned_to)) +
90 90 content_tag('td', progress_bar(child.done_ratio, :width => '80px')),
91 91 :class => css)
92 92 end
93 93 s << '</table></form>'
94 94 s.html_safe
95 95 end
96 96
97 97 # Returns an array of error messages for bulk edited issues
98 98 def bulk_edit_error_messages(issues)
99 99 messages = {}
100 100 issues.each do |issue|
101 101 issue.errors.full_messages.each do |message|
102 102 messages[message] ||= []
103 103 messages[message] << issue
104 104 end
105 105 end
106 106 messages.map { |message, issues|
107 107 "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
108 108 }
109 109 end
110 110
111 111 # Returns a link for adding a new subtask to the given issue
112 112 def link_to_new_subtask(issue)
113 113 attrs = {
114 114 :tracker_id => issue.tracker,
115 115 :parent_issue_id => issue
116 116 }
117 117 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
118 118 end
119 119
120 120 class IssueFieldsRows
121 121 include ActionView::Helpers::TagHelper
122 122
123 123 def initialize
124 124 @left = []
125 125 @right = []
126 126 end
127 127
128 128 def left(*args)
129 129 args.any? ? @left << cells(*args) : @left
130 130 end
131 131
132 132 def right(*args)
133 133 args.any? ? @right << cells(*args) : @right
134 134 end
135 135
136 136 def size
137 137 @left.size > @right.size ? @left.size : @right.size
138 138 end
139 139
140 140 def to_html
141 141 html = ''.html_safe
142 142 blank = content_tag('th', '') + content_tag('td', '')
143 143 size.times do |i|
144 144 left = @left[i] || blank
145 145 right = @right[i] || blank
146 146 html << content_tag('tr', left + right)
147 147 end
148 148 html
149 149 end
150 150
151 151 def cells(label, text, options={})
152 152 content_tag('th', "#{label}:", options) + content_tag('td', text, options)
153 153 end
154 154 end
155 155
156 156 def issue_fields_rows
157 157 r = IssueFieldsRows.new
158 158 yield r
159 159 r.to_html
160 160 end
161 161
162 162 def render_custom_fields_rows(issue)
163 163 values = issue.visible_custom_field_values
164 164 return if values.empty?
165 165 ordered_values = []
166 166 half = (values.size / 2.0).ceil
167 167 half.times do |i|
168 168 ordered_values << values[i]
169 169 ordered_values << values[i + half]
170 170 end
171 171 s = "<tr>\n"
172 172 n = 0
173 173 ordered_values.compact.each do |value|
174 174 css = "cf_#{value.custom_field.id}"
175 175 s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
176 176 s << "\t<th class=\"#{css}\">#{ h(value.custom_field.name) }:</th><td class=\"#{css}\">#{ h(show_value(value)) }</td>\n"
177 177 n += 1
178 178 end
179 179 s << "</tr>\n"
180 180 s.html_safe
181 181 end
182 182
183 # Returns the number of descendants for an array of issues
184 def issues_descendant_count(issues)
185 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
186 ids -= issues.map(&:id)
187 ids.size
188 end
189
183 190 def issues_destroy_confirmation_message(issues)
184 191 issues = [issues] unless issues.is_a?(Array)
185 192 message = l(:text_issues_destroy_confirmation)
186 descendant_count = issues.inject(0) {|memo, i| memo += (i.right - i.left - 1)/2}
187 if descendant_count > 0
188 issues.each do |issue|
189 next if issue.root?
190 issues.each do |other_issue|
191 descendant_count -= 1 if issue.is_descendant_of?(other_issue)
192 end
193 end
193
194 descendant_count = issues_descendant_count(issues)
194 195 if descendant_count > 0
195 196 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
196 197 end
197 end
198 198 message
199 199 end
200 200
201 201 def sidebar_queries
202 202 unless @sidebar_queries
203 203 @sidebar_queries = IssueQuery.visible.
204 204 order("#{Query.table_name}.name ASC").
205 205 # Project specific queries and global queries
206 206 where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).
207 207 to_a
208 208 end
209 209 @sidebar_queries
210 210 end
211 211
212 212 def query_links(title, queries)
213 213 return '' if queries.empty?
214 214 # links to #index on issues/show
215 215 url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
216 216
217 217 content_tag('h3', title) + "\n" +
218 218 content_tag('ul',
219 219 queries.collect {|query|
220 220 css = 'query'
221 221 css << ' selected' if query == @query
222 222 content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))
223 223 }.join("\n").html_safe,
224 224 :class => 'queries'
225 225 ) + "\n"
226 226 end
227 227
228 228 def render_sidebar_queries
229 229 out = ''.html_safe
230 230 out << query_links(l(:label_my_queries), sidebar_queries.select(&:is_private?))
231 231 out << query_links(l(:label_query_plural), sidebar_queries.reject(&:is_private?))
232 232 out
233 233 end
234 234
235 235 def email_issue_attributes(issue, user)
236 236 items = []
237 237 %w(author status priority assigned_to category fixed_version).each do |attribute|
238 238 unless issue.disabled_core_fields.include?(attribute+"_id")
239 239 items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
240 240 end
241 241 end
242 242 issue.visible_custom_field_values(user).each do |value|
243 243 items << "#{value.custom_field.name}: #{show_value(value, false)}"
244 244 end
245 245 items
246 246 end
247 247
248 248 def render_email_issue_attributes(issue, user, html=false)
249 249 items = email_issue_attributes(issue, user)
250 250 if html
251 251 content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)
252 252 else
253 253 items.map{|s| "* #{s}"}.join("\n")
254 254 end
255 255 end
256 256
257 257 # Returns the textual representation of a journal details
258 258 # as an array of strings
259 259 def details_to_strings(details, no_html=false, options={})
260 260 options[:only_path] = (options[:only_path] == false ? false : true)
261 261 strings = []
262 262 values_by_field = {}
263 263 details.each do |detail|
264 264 if detail.property == 'cf'
265 265 field = detail.custom_field
266 266 if field && field.multiple?
267 267 values_by_field[field] ||= {:added => [], :deleted => []}
268 268 if detail.old_value
269 269 values_by_field[field][:deleted] << detail.old_value
270 270 end
271 271 if detail.value
272 272 values_by_field[field][:added] << detail.value
273 273 end
274 274 next
275 275 end
276 276 end
277 277 strings << show_detail(detail, no_html, options)
278 278 end
279 279 values_by_field.each do |field, changes|
280 280 detail = JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s)
281 281 detail.instance_variable_set "@custom_field", field
282 282 if changes[:added].any?
283 283 detail.value = changes[:added]
284 284 strings << show_detail(detail, no_html, options)
285 285 elsif changes[:deleted].any?
286 286 detail.old_value = changes[:deleted]
287 287 strings << show_detail(detail, no_html, options)
288 288 end
289 289 end
290 290 strings
291 291 end
292 292
293 293 # Returns the textual representation of a single journal detail
294 294 def show_detail(detail, no_html=false, options={})
295 295 multiple = false
296 296 case detail.property
297 297 when 'attr'
298 298 field = detail.prop_key.to_s.gsub(/\_id$/, "")
299 299 label = l(("field_" + field).to_sym)
300 300 case detail.prop_key
301 301 when 'due_date', 'start_date'
302 302 value = format_date(detail.value.to_date) if detail.value
303 303 old_value = format_date(detail.old_value.to_date) if detail.old_value
304 304
305 305 when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
306 306 'priority_id', 'category_id', 'fixed_version_id'
307 307 value = find_name_by_reflection(field, detail.value)
308 308 old_value = find_name_by_reflection(field, detail.old_value)
309 309
310 310 when 'estimated_hours'
311 311 value = "%0.02f" % detail.value.to_f unless detail.value.blank?
312 312 old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
313 313
314 314 when 'parent_id'
315 315 label = l(:field_parent_issue)
316 316 value = "##{detail.value}" unless detail.value.blank?
317 317 old_value = "##{detail.old_value}" unless detail.old_value.blank?
318 318
319 319 when 'is_private'
320 320 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
321 321 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
322 322 end
323 323 when 'cf'
324 324 custom_field = detail.custom_field
325 325 if custom_field
326 326 multiple = custom_field.multiple?
327 327 label = custom_field.name
328 328 value = format_value(detail.value, custom_field) if detail.value
329 329 old_value = format_value(detail.old_value, custom_field) if detail.old_value
330 330 end
331 331 when 'attachment'
332 332 label = l(:label_attachment)
333 333 when 'relation'
334 334 if detail.value && !detail.old_value
335 335 rel_issue = Issue.visible.find_by_id(detail.value)
336 336 value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
337 337 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
338 338 elsif detail.old_value && !detail.value
339 339 rel_issue = Issue.visible.find_by_id(detail.old_value)
340 340 old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
341 341 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
342 342 end
343 343 relation_type = IssueRelation::TYPES[detail.prop_key]
344 344 label = l(relation_type[:name]) if relation_type
345 345 end
346 346 call_hook(:helper_issues_show_detail_after_setting,
347 347 {:detail => detail, :label => label, :value => value, :old_value => old_value })
348 348
349 349 label ||= detail.prop_key
350 350 value ||= detail.value
351 351 old_value ||= detail.old_value
352 352
353 353 unless no_html
354 354 label = content_tag('strong', label)
355 355 old_value = content_tag("i", h(old_value)) if detail.old_value
356 356 if detail.old_value && detail.value.blank? && detail.property != 'relation'
357 357 old_value = content_tag("del", old_value)
358 358 end
359 359 if detail.property == 'attachment' && !value.blank? && atta = Attachment.find_by_id(detail.prop_key)
360 360 # Link to the attachment if it has not been removed
361 361 value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
362 362 if options[:only_path] != false && atta.is_text?
363 363 value += link_to(
364 364 image_tag('magnifier.png'),
365 365 :controller => 'attachments', :action => 'show',
366 366 :id => atta, :filename => atta.filename
367 367 )
368 368 end
369 369 else
370 370 value = content_tag("i", h(value)) if value
371 371 end
372 372 end
373 373
374 374 if detail.property == 'attr' && detail.prop_key == 'description'
375 375 s = l(:text_journal_changed_no_detail, :label => label)
376 376 unless no_html
377 377 diff_link = link_to 'diff',
378 378 {:controller => 'journals', :action => 'diff', :id => detail.journal_id,
379 379 :detail_id => detail.id, :only_path => options[:only_path]},
380 380 :title => l(:label_view_diff)
381 381 s << " (#{ diff_link })"
382 382 end
383 383 s.html_safe
384 384 elsif detail.value.present?
385 385 case detail.property
386 386 when 'attr', 'cf'
387 387 if detail.old_value.present?
388 388 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
389 389 elsif multiple
390 390 l(:text_journal_added, :label => label, :value => value).html_safe
391 391 else
392 392 l(:text_journal_set_to, :label => label, :value => value).html_safe
393 393 end
394 394 when 'attachment', 'relation'
395 395 l(:text_journal_added, :label => label, :value => value).html_safe
396 396 end
397 397 else
398 398 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
399 399 end
400 400 end
401 401
402 402 # Find the name of an associated record stored in the field attribute
403 403 def find_name_by_reflection(field, id)
404 404 unless id.present?
405 405 return nil
406 406 end
407 407 association = Issue.reflect_on_association(field.to_sym)
408 408 if association
409 409 record = association.class_name.constantize.find_by_id(id)
410 410 if record
411 411 record.name.force_encoding('UTF-8')
412 412 return record.name
413 413 end
414 414 end
415 415 end
416 416
417 417 # Renders issue children recursively
418 418 def render_api_issue_children(issue, api)
419 419 return if issue.leaf?
420 420 api.array :children do
421 421 issue.children.each do |child|
422 422 api.issue(:id => child.id) do
423 423 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
424 424 api.subject child.subject
425 425 render_api_issue_children(child, api)
426 426 end
427 427 end
428 428 end
429 429 end
430 430 end
Show file before | Show file after | Hide comments
@@ -1,275 +1,285
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2014 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../../test_helper', __FILE__)
19 19
20 20 class IssuesHelperTest < ActionView::TestCase
21 21 include Redmine::I18n
22 22 include IssuesHelper
23 23 include CustomFieldsHelper
24 24 include ERB::Util
25 25 include Rails.application.routes.url_helpers
26 26
27 27 fixtures :projects, :trackers, :issue_statuses, :issues,
28 28 :enumerations, :users, :issue_categories,
29 29 :projects_trackers,
30 30 :roles,
31 31 :member_roles,
32 32 :members,
33 33 :enabled_modules,
34 34 :custom_fields,
35 35 :attachments,
36 36 :versions
37 37
38 38 def setup
39 39 super
40 40 set_language_if_valid('en')
41 41 User.current = nil
42 42 end
43 43
44 44 def test_issue_heading
45 45 assert_equal "Bug #1", issue_heading(Issue.find(1))
46 46 end
47 47
48 48 def test_issues_destroy_confirmation_message_with_one_root_issue
49 49 assert_equal l(:text_issues_destroy_confirmation),
50 50 issues_destroy_confirmation_message(Issue.find(1))
51 51 end
52 52
53 53 def test_issues_destroy_confirmation_message_with_an_arrayt_of_root_issues
54 54 assert_equal l(:text_issues_destroy_confirmation),
55 55 issues_destroy_confirmation_message(Issue.find([1, 2]))
56 56 end
57 57
58 58 def test_issues_destroy_confirmation_message_with_one_parent_issue
59 59 Issue.find(2).update_attribute :parent_issue_id, 1
60 60 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
61 61 l(:text_issues_destroy_descendants_confirmation, :count => 1),
62 62 issues_destroy_confirmation_message(Issue.find(1))
63 63 end
64 64
65 65 def test_issues_destroy_confirmation_message_with_one_parent_issue_and_its_child
66 66 Issue.find(2).update_attribute :parent_issue_id, 1
67 67 assert_equal l(:text_issues_destroy_confirmation),
68 68 issues_destroy_confirmation_message(Issue.find([1, 2]))
69 69 end
70 70
71 def test_issues_destroy_confirmation_message_with_issues_that_share_descendants
72 root = Issue.generate!
73 child = Issue.generate!(:parent_issue_id => root.id)
74 Issue.generate!(:parent_issue_id => child.id)
75
76 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
77 l(:text_issues_destroy_descendants_confirmation, :count => 1),
78 issues_destroy_confirmation_message([root.reload, child.reload])
79 end
80
71 81 test 'show_detail with no_html should show a changing attribute' do
72 82 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
73 83 :value => '100', :prop_key => 'done_ratio')
74 84 assert_equal "% Done changed from 40 to 100", show_detail(detail, true)
75 85 end
76 86
77 87 test 'show_detail with no_html should show a new attribute' do
78 88 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
79 89 :value => '100', :prop_key => 'done_ratio')
80 90 assert_equal "% Done set to 100", show_detail(detail, true)
81 91 end
82 92
83 93 test 'show_detail with no_html should show a deleted attribute' do
84 94 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
85 95 :value => nil, :prop_key => 'done_ratio')
86 96 assert_equal "% Done deleted (50)", show_detail(detail, true)
87 97 end
88 98
89 99 test 'show_detail with html should show a changing attribute with HTML highlights' do
90 100 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
91 101 :value => '100', :prop_key => 'done_ratio')
92 102 html = show_detail(detail, false)
93 103 assert_include '<strong>% Done</strong>', html
94 104 assert_include '<i>40</i>', html
95 105 assert_include '<i>100</i>', html
96 106 end
97 107
98 108 test 'show_detail with html should show a new attribute with HTML highlights' do
99 109 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
100 110 :value => '100', :prop_key => 'done_ratio')
101 111 html = show_detail(detail, false)
102 112 assert_include '<strong>% Done</strong>', html
103 113 assert_include '<i>100</i>', html
104 114 end
105 115
106 116 test 'show_detail with html should show a deleted attribute with HTML highlights' do
107 117 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
108 118 :value => nil, :prop_key => 'done_ratio')
109 119 html = show_detail(detail, false)
110 120 assert_include '<strong>% Done</strong>', html
111 121 assert_include '<del><i>50</i></del>', html
112 122 end
113 123
114 124 test 'show_detail with a start_date attribute should format the dates' do
115 125 detail = JournalDetail.new(
116 126 :property => 'attr',
117 127 :old_value => '2010-01-01',
118 128 :value => '2010-01-31',
119 129 :prop_key => 'start_date'
120 130 )
121 131 with_settings :date_format => '%m/%d/%Y' do
122 132 assert_match "01/31/2010", show_detail(detail, true)
123 133 assert_match "01/01/2010", show_detail(detail, true)
124 134 end
125 135 end
126 136
127 137 test 'show_detail with a due_date attribute should format the dates' do
128 138 detail = JournalDetail.new(
129 139 :property => 'attr',
130 140 :old_value => '2010-01-01',
131 141 :value => '2010-01-31',
132 142 :prop_key => 'due_date'
133 143 )
134 144 with_settings :date_format => '%m/%d/%Y' do
135 145 assert_match "01/31/2010", show_detail(detail, true)
136 146 assert_match "01/01/2010", show_detail(detail, true)
137 147 end
138 148 end
139 149
140 150 test 'show_detail should show old and new values with a project attribute' do
141 151 detail = JournalDetail.new(:property => 'attr', :prop_key => 'project_id',
142 152 :old_value => 1, :value => 2)
143 153 assert_match 'eCookbook', show_detail(detail, true)
144 154 assert_match 'OnlineStore', show_detail(detail, true)
145 155 end
146 156
147 157 test 'show_detail should show old and new values with a issue status attribute' do
148 158 detail = JournalDetail.new(:property => 'attr', :prop_key => 'status_id',
149 159 :old_value => 1, :value => 2)
150 160 assert_match 'New', show_detail(detail, true)
151 161 assert_match 'Assigned', show_detail(detail, true)
152 162 end
153 163
154 164 test 'show_detail should show old and new values with a tracker attribute' do
155 165 detail = JournalDetail.new(:property => 'attr', :prop_key => 'tracker_id',
156 166 :old_value => 1, :value => 2)
157 167 assert_match 'Bug', show_detail(detail, true)
158 168 assert_match 'Feature request', show_detail(detail, true)
159 169 end
160 170
161 171 test 'show_detail should show old and new values with a assigned to attribute' do
162 172 detail = JournalDetail.new(:property => 'attr', :prop_key => 'assigned_to_id',
163 173 :old_value => 1, :value => 2)
164 174 assert_match 'Redmine Admin', show_detail(detail, true)
165 175 assert_match 'John Smith', show_detail(detail, true)
166 176 end
167 177
168 178 test 'show_detail should show old and new values with a priority attribute' do
169 179 detail = JournalDetail.new(:property => 'attr', :prop_key => 'priority_id',
170 180 :old_value => 4, :value => 5)
171 181 assert_match 'Low', show_detail(detail, true)
172 182 assert_match 'Normal', show_detail(detail, true)
173 183 end
174 184
175 185 test 'show_detail should show old and new values with a category attribute' do
176 186 detail = JournalDetail.new(:property => 'attr', :prop_key => 'category_id',
177 187 :old_value => 1, :value => 2)
178 188 assert_match 'Printing', show_detail(detail, true)
179 189 assert_match 'Recipes', show_detail(detail, true)
180 190 end
181 191
182 192 test 'show_detail should show old and new values with a fixed version attribute' do
183 193 detail = JournalDetail.new(:property => 'attr', :prop_key => 'fixed_version_id',
184 194 :old_value => 1, :value => 2)
185 195 assert_match '0.1', show_detail(detail, true)
186 196 assert_match '1.0', show_detail(detail, true)
187 197 end
188 198
189 199 test 'show_detail should show old and new values with a estimated hours attribute' do
190 200 detail = JournalDetail.new(:property => 'attr', :prop_key => 'estimated_hours',
191 201 :old_value => '5', :value => '6.3')
192 202 assert_match '5.00', show_detail(detail, true)
193 203 assert_match '6.30', show_detail(detail, true)
194 204 end
195 205
196 206 test 'show_detail should show old and new values with a custom field' do
197 207 detail = JournalDetail.new(:property => 'cf', :prop_key => '1',
198 208 :old_value => 'MySQL', :value => 'PostgreSQL')
199 209 assert_equal 'Database changed from MySQL to PostgreSQL', show_detail(detail, true)
200 210 end
201 211
202 212 test 'show_detail should show added file' do
203 213 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
204 214 :old_value => nil, :value => 'error281.txt')
205 215 assert_match 'error281.txt', show_detail(detail, true)
206 216 end
207 217
208 218 test 'show_detail should show removed file' do
209 219 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
210 220 :old_value => 'error281.txt', :value => nil)
211 221 assert_match 'error281.txt', show_detail(detail, true)
212 222 end
213 223
214 224 def test_show_detail_relation_added
215 225 detail = JournalDetail.new(:property => 'relation',
216 226 :prop_key => 'precedes',
217 227 :value => 1)
218 228 assert_equal "Precedes Bug #1: Cannot print recipes added", show_detail(detail, true)
219 229 str = link_to("Bug #1", "/issues/1", :class => Issue.find(1).css_classes)
220 230 assert_equal "<strong>Precedes</strong> <i>#{str}: Cannot print recipes</i> added",
221 231 show_detail(detail, false)
222 232 end
223 233
224 234 def test_show_detail_relation_added_with_inexistant_issue
225 235 inexistant_issue_number = 9999
226 236 assert_nil Issue.find_by_id(inexistant_issue_number)
227 237 detail = JournalDetail.new(:property => 'relation',
228 238 :prop_key => 'precedes',
229 239 :value => inexistant_issue_number)
230 240 assert_equal "Precedes Issue ##{inexistant_issue_number} added", show_detail(detail, true)
231 241 assert_equal "<strong>Precedes</strong> <i>Issue ##{inexistant_issue_number}</i> added", show_detail(detail, false)
232 242 end
233 243
234 244 def test_show_detail_relation_added_should_not_disclose_issue_that_is_not_visible
235 245 issue = Issue.generate!(:is_private => true)
236 246 detail = JournalDetail.new(:property => 'relation',
237 247 :prop_key => 'precedes',
238 248 :value => issue.id)
239 249
240 250 assert_equal "Precedes Issue ##{issue.id} added", show_detail(detail, true)
241 251 assert_equal "<strong>Precedes</strong> <i>Issue ##{issue.id}</i> added", show_detail(detail, false)
242 252 end
243 253
244 254 def test_show_detail_relation_deleted
245 255 detail = JournalDetail.new(:property => 'relation',
246 256 :prop_key => 'precedes',
247 257 :old_value => 1)
248 258 assert_equal "Precedes deleted (Bug #1: Cannot print recipes)", show_detail(detail, true)
249 259 str = link_to("Bug #1",
250 260 "/issues/1",
251 261 :class => Issue.find(1).css_classes)
252 262 assert_equal "<strong>Precedes</strong> deleted (<i>#{str}: Cannot print recipes</i>)",
253 263 show_detail(detail, false)
254 264 end
255 265
256 266 def test_show_detail_relation_deleted_with_inexistant_issue
257 267 inexistant_issue_number = 9999
258 268 assert_nil Issue.find_by_id(inexistant_issue_number)
259 269 detail = JournalDetail.new(:property => 'relation',
260 270 :prop_key => 'precedes',
261 271 :old_value => inexistant_issue_number)
262 272 assert_equal "Precedes deleted (Issue #9999)", show_detail(detail, true)
263 273 assert_equal "<strong>Precedes</strong> deleted (<i>Issue #9999</i>)", show_detail(detail, false)
264 274 end
265 275
266 276 def test_show_detail_relation_deleted_should_not_disclose_issue_that_is_not_visible
267 277 issue = Issue.generate!(:is_private => true)
268 278 detail = JournalDetail.new(:property => 'relation',
269 279 :prop_key => 'precedes',
270 280 :old_value => issue.id)
271 281
272 282 assert_equal "Precedes deleted (Issue ##{issue.id})", show_detail(detail, true)
273 283 assert_equal "<strong>Precedes</strong> deleted (<i>Issue ##{issue.id}</i>)", show_detail(detail, false)
274 284 end
275 285 end
General Comments 0
You need to be logged in to leave comments. Login now