jro_apps/redmine Commit - r13412:bfd811304601

Adds p/n access keys for previous/next links (#18692)....

Jean-Philippe Lang -

r13412:bfd811304601

parent child

Context file:

r13412:bfd811304601

app/helpers/application_helper.rb +2 -1

                 link_to(
                     h(text),
                     {:controller => 'repositories', :action => 'revision', :id => repository.project, :repository_id => repository.identifier_param, :rev => rev},
-                    :title => l(:label_revision_id, format_revision(revision))
+                    :title => l(:label_revision_id, format_revision(revision)),
+                    :accesskey => options[:accesskey]
                   )
               end

app/helpers/calendars_helper.rb +1 -1

               end
               def link_to_month(link_name, year, month, options={})
-                link_to_content_update(h(link_name), params.merge(:year => year, :month => month))
+                link_to_content_update(h(link_name), params.merge(:year => year, :month => month), options)
               end
             end

app/views/activities/index.html.erb +4 -2

             <div style="float:left;">
             <%= link_to_content_update("\xc2\xab " + l(:label_previous),
                                params.merge(:from => @date_to - @days - 1),
-                               :title => l(:label_date_from_to, :start => format_date(@date_to - 2*@days), :end => format_date(@date_to - @days - 1))) %>
+                               :title => l(:label_date_from_to, :start => format_date(@date_to - 2*@days), :end => format_date(@date_to - @days - 1)),
+                               :accesskey => accesskey(:previous)) %>
             </div>
             <div style="float:right;">
             <%= link_to_content_update(l(:label_next) + " \xc2\xbb",
                                params.merge(:from => @date_to + @days - 1),
-                               :title => l(:label_date_from_to, :start => format_date(@date_to), :end => format_date(@date_to + @days - 1))) unless @date_to >= Date.today %>
+                               :title => l(:label_date_from_to, :start => format_date(@date_to), :end => format_date(@date_to + @days - 1)),
+                               :accesskey => accesskey(:next)) unless @date_to >= Date.today %>
             </div>
             &nbsp;
             <% other_formats_links do |f| %>

app/views/calendars/show.html.erb +1 -1

             </fieldset>
             <p style="float:right;">
-              <%= link_to_previous_month(@year, @month) %> | <%= link_to_next_month(@year, @month) %>
+              <%= link_to_previous_month(@year, @month, :accesskey => accesskey(:previous)) %> | <%= link_to_next_month(@year, @month, :accesskey => accesskey(:next)) %>
             </p>
             <p class="buttons">

app/views/gantts/show.html.erb +4 -2

             <tr>
               <td style="text-align:left;">
                 <%= link_to_content_update("\xc2\xab " + l(:label_previous),
-                                           params.merge(@gantt.params_previous)) %>
+                                           params.merge(@gantt.params_previous),
+                                           :accesskey => accesskey(:previous)) %>
               </td>
               <td style="text-align:right;">
                 <%= link_to_content_update(l(:label_next) + " \xc2\xbb",
-                                           params.merge(@gantt.params_next)) %>
+                                           params.merge(@gantt.params_next),
+                                           :accesskey => accesskey(:next)) %>
               </td>
             </tr>
             </table>

app/views/issues/show.html.erb +4 -2

                   <%= link_to_if @prev_issue_id,
                                  "\xc2\xab #{l(:label_previous)}",
                                  (@prev_issue_id ? issue_path(@prev_issue_id) : nil),
-                                 :title => "##{@prev_issue_id}" %> |
+                                 :title => "##{@prev_issue_id}",
+                                 :accesskey => accesskey(:previous) %> |
                   <% if @issue_position && @issue_count %>
                     <span class="position"><%= l(:label_item_position, :position => @issue_position, :count => @issue_count) %></span> |
                   <% end %>
                   <%= link_to_if @next_issue_id,
                                  "#{l(:label_next)} \xc2\xbb",
                                  (@next_issue_id ? issue_path(@next_issue_id) : nil),
-                                 :title => "##{@next_issue_id}" %>
+                                 :title => "##{@next_issue_id}",
+                                 :accesskey => accesskey(:next) %>
                 </div>
               <% end %>

app/views/repositories/revision.html.erb +4 -2

             <div class="contextual">
               &#171;
               <% unless @changeset.previous.nil? -%>
-                <%= link_to_revision(@changeset.previous, @repository, :text => l(:label_previous)) %>
+                <%= link_to_revision(@changeset.previous, @repository,
+                  :text => l(:label_previous), :accesskey => accesskey(:previous)) %>
               <% else -%>
                 <%= l(:label_previous) %>
               <% end -%>
             |
               <% unless @changeset.next.nil? -%>
-                <%= link_to_revision(@changeset.next, @repository, :text => l(:label_next)) %>
+                <%= link_to_revision(@changeset.next, @repository,
+                  :text => l(:label_next), :accesskey => accesskey(:next)) %>
               <% else -%>
                 <%= l(:label_next) %>
               <% end -%>

lib/redmine/access_keys.rb +3 -1

                               :preview => 'r',
                               :quick_search => 'f',
                               :search => '4',
-                              :new_issue => '7'
+                              :new_issue => '7',
+                              :previous => 'p',
+                              :next => 'n'
                              }.freeze unless const_defined?(:ACCESSKEYS)
                 def self.key_for(action)

lib/redmine/pagination.rb +4 -2

                     if paginator.previous_page
                       # \xc2\xab(utf-8) = &#171;
                       text = "\xc2\xab " + l(:label_previous)
-                      html << yield(text, {page_param => paginator.previous_page}, :class => 'previous') + ' '
+                      html << yield(text, {page_param => paginator.previous_page},
+                        :class => 'previous', :accesskey => accesskey(:previous)) + ' '
                     end
                     previous = nil
                     if paginator.next_page
                       # \xc2\xbb(utf-8) = &#187;
                       text = l(:label_next) + " \xc2\xbb"
-                      html << yield(text, {page_param => paginator.next_page}, :class => 'next') + ' '
+                      html << yield(text, {page_param => paginator.next_page},
+                        :class => 'next', :accesskey => accesskey(:next)) + ' '
                     end
                     html << content_tag('span', "(#{paginator.first_item}-#{paginator.last_item}/#{paginator.item_count})", :class => 'items') + ' '

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages