jro_apps/redmine Commit - r4603:befd725b8b24

Prevent SystemStackError on Issue#all_dependent_issues with circular dependency (#7320)....

Jean-Philippe Lang -

r4603:befd725b8b24

parent child

Context file:

r4603:befd725b8b24

Collapse all files

app/models/issue.rb +5 -2

                  (relations_from + relations_to).sort
                end
-               def all_dependent_issues
+               def all_dependent_issues(except=nil)
+                 except ||= self
                  dependencies = []
                  relations_from.each do |relation|
+                   if relation.issue_to && relation.issue_to != except
                    dependencies << relation.issue_to
-                   dependencies += relation.issue_to.all_dependent_issues
+                     dependencies += relation.issue_to.all_dependent_issues(except)
+                   end
                  end
                  dependencies
                end

test/unit/issue_test.rb +19 0

                  end
                end
+               def test_all_dependent_issues
+                 IssueRelation.delete_all
+                 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
+                 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
+                 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
+                 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
+               end
+               def test_all_dependent_issues_with_persistent_circular_dependency
+                 IssueRelation.delete_all
+                 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
+                 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
+                 # Validation skipping
+                 assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
+                 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
+               end
                context "#done_ratio" do
                  setup do
                    @issue = Issue.find(1)

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages