##// END OF EJS Templates
jro_apps » redmine
RSS
Do not create projects in alphabetical order in nested set tests (#12431)....
Jean-Philippe Lang -
r10638:be7895e04ec0
parent child
Show More
Side by Side Unified
Context file:
r10638:be7895e04ec0 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,167 +1,167
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class ProjectNestedSetTest < ActiveSupport::TestCase
21 21
22 22 def setup
23 23 Project.delete_all
24 24
25 25 @a = Project.create!(:name => 'A', :identifier => 'projecta')
26 26 @a1 = Project.create!(:name => 'A1', :identifier => 'projecta1')
27 27 @a1.set_parent!(@a)
28 28 @a2 = Project.create!(:name => 'A2', :identifier => 'projecta2')
29 29 @a2.set_parent!(@a)
30 30
31 @c = Project.create!(:name => 'C', :identifier => 'projectc')
32 @c1 = Project.create!(:name => 'C1', :identifier => 'projectc1')
33 @c1.set_parent!(@c)
34
31 35 @b = Project.create!(:name => 'B', :identifier => 'projectb')
36 @b2 = Project.create!(:name => 'B2', :identifier => 'projectb2')
37 @b2.set_parent!(@b)
32 38 @b1 = Project.create!(:name => 'B1', :identifier => 'projectb1')
33 39 @b1.set_parent!(@b)
34 40 @b11 = Project.create!(:name => 'B11', :identifier => 'projectb11')
35 41 @b11.set_parent!(@b1)
36 @b2 = Project.create!(:name => 'B2', :identifier => 'projectb2')
37 @b2.set_parent!(@b)
38
39 @c = Project.create!(:name => 'C', :identifier => 'projectc')
40 @c1 = Project.create!(:name => 'C1', :identifier => 'projectc1')
41 @c1.set_parent!(@c)
42 42
43 43 @a, @a1, @a2, @b, @b1, @b11, @b2, @c, @c1 = *(Project.all.sort_by(&:name))
44 44 end
45 45
46 46 def test_valid_tree
47 47 assert_valid_nested_set
48 48 end
49 49
50 50 def test_moving_a_child_to_a_different_parent_should_keep_valid_tree
51 51 assert_no_difference 'Project.count' do
52 52 Project.find_by_name('B1').set_parent!(Project.find_by_name('A2'))
53 53 end
54 54 assert_valid_nested_set
55 55 end
56 56
57 57 def test_renaming_a_root_to_first_position_should_update_nested_set_order
58 58 @c.name = '1'
59 59 @c.save!
60 60 assert_valid_nested_set
61 61 end
62 62
63 63 def test_renaming_a_root_to_middle_position_should_update_nested_set_order
64 64 @a.name = 'BA'
65 65 @a.save!
66 66 assert_valid_nested_set
67 67 end
68 68
69 69 def test_renaming_a_root_to_last_position_should_update_nested_set_order
70 70 @a.name = 'D'
71 71 @a.save!
72 72 assert_valid_nested_set
73 73 end
74 74
75 75 def test_renaming_a_root_to_same_position_should_update_nested_set_order
76 76 @c.name = 'D'
77 77 @c.save!
78 78 assert_valid_nested_set
79 79 end
80 80
81 81 def test_renaming_a_child_should_update_nested_set_order
82 82 @a1.name = 'A3'
83 83 @a1.save!
84 84 assert_valid_nested_set
85 85 end
86 86
87 87 def test_renaming_a_child_with_child_should_update_nested_set_order
88 88 @b1.name = 'B3'
89 89 @b1.save!
90 90 assert_valid_nested_set
91 91 end
92 92
93 93 def test_adding_a_root_to_first_position_should_update_nested_set_order
94 94 project = Project.create!(:name => '1', :identifier => 'projectba')
95 95 assert_valid_nested_set
96 96 end
97 97
98 98 def test_adding_a_root_to_middle_position_should_update_nested_set_order
99 99 project = Project.create!(:name => 'BA', :identifier => 'projectba')
100 100 assert_valid_nested_set
101 101 end
102 102
103 103 def test_adding_a_root_to_last_position_should_update_nested_set_order
104 104 project = Project.create!(:name => 'Z', :identifier => 'projectba')
105 105 assert_valid_nested_set
106 106 end
107 107
108 108 def test_destroying_a_root_with_children_should_keep_valid_tree
109 109 assert_difference 'Project.count', -4 do
110 110 Project.find_by_name('B').destroy
111 111 end
112 112 assert_valid_nested_set
113 113 end
114 114
115 115 def test_destroying_a_child_with_children_should_keep_valid_tree
116 116 assert_difference 'Project.count', -2 do
117 117 Project.find_by_name('B1').destroy
118 118 end
119 119 assert_valid_nested_set
120 120 end
121 121
122 122 private
123 123
124 124 def assert_nested_set_values(h)
125 125 assert Project.valid?
126 126 h.each do |project, expected|
127 127 project.reload
128 128 assert_equal expected, [project.parent_id, project.lft, project.rgt], "Unexpected nested set values for #{project.name}"
129 129 end
130 130 end
131 131
132 132 def assert_valid_nested_set
133 133 projects = Project.all
134 134 lft_rgt = projects.map {|p| [p.lft, p.rgt]}.flatten
135 135 assert_equal projects.size * 2, lft_rgt.uniq.size
136 136 assert_equal 1, lft_rgt.min
137 137 assert_equal projects.size * 2, lft_rgt.max
138 138
139 139 projects.each do |project|
140 140 # lft should always be < rgt
141 141 assert project.lft < project.rgt, "lft=#{project.lft} was not < rgt=#{project.rgt} for project #{project.name}"
142 142 if project.parent_id
143 143 # child lft/rgt values must be greater/lower
144 144 assert_not_nil project.parent, "parent was nil for project #{project.name}"
145 145 assert project.lft > project.parent.lft, "lft=#{project.lft} was not > parent.lft=#{project.parent.lft} for project #{project.name}"
146 146 assert project.rgt < project.parent.rgt, "rgt=#{project.rgt} was not < parent.rgt=#{project.parent.rgt} for project #{project.name}"
147 147 end
148 148 # no overlapping lft/rgt values
149 149 overlapping = projects.detect {|other|
150 150 other != project && (
151 151 (other.lft > project.lft && other.lft < project.rgt && other.rgt > project.rgt) ||
152 152 (other.rgt > project.lft && other.rgt < project.rgt && other.lft < project.lft)
153 153 )
154 154 }
155 155 assert_nil overlapping, (overlapping && "Project #{overlapping.name} (#{overlapping.lft}/#{overlapping.rgt}) overlapped #{project.name} (#{project.lft}/#{project.rgt})")
156 156 end
157 157
158 158 # root projects sorted alphabetically
159 159 assert_equal Project.roots.map(&:name).sort, Project.roots.sort_by(&:lft).map(&:name), "Root projects were not properly sorted"
160 160 projects.each do |project|
161 161 if project.children.any?
162 162 # sibling projects sorted alphabetically
163 163 assert_equal project.children.map(&:name).sort, project.children.order('lft').map(&:name), "Project #{project.name}'s children were not properly sorted"
164 164 end
165 165 end
166 166 end
167 167 end
General Comments 0
You need to be logged in to leave comments. Login now