jro_apps/redmine Commit - r3422:be20d9804078

Refactor: Extract methods to before_filters...

Eric Davis -

r3422:be20d9804078

parent child

Context file:

r3422:be20d9804078

app/controllers/workflows_controller.rb +13 -5

               layout 'admin'
               before_filter :require_admin
+              before_filter :find_roles
+              before_filter :find_trackers
               def index
                 @workflow_counts = Workflow.count_by_tracker_and_role
               end
                     redirect_to :action => 'edit', :role_id => @role, :tracker_id => @tracker
                   end
                 end
-                @roles = Role.find(:all, :order => 'builtin, position')
-                @trackers = Tracker.find(:all, :order => 'position')
                 @used_statuses_only = (params[:used_statuses_only] == '0' ? false : true)
                 if @tracker && @used_statuses_only && @tracker.issue_statuses.any?
               end
               def copy
-                @trackers = Tracker.find(:all, :order => 'position')
-                @roles = Role.find(:all, :order => 'builtin, position')
                 if params[:source_tracker_id].blank? || params[:source_tracker_id] == 'any'
                   @source_tracker = nil
                   end
                 end
               end
+              private
+              def find_roles
+                @roles = Role.find(:all, :order => 'builtin, position')
+              end
+              def find_trackers
+                @trackers = Tracker.find(:all, :order => 'position')
+              end
             end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages