jro_apps/redmine Commit - r13994:bc9ca5fcfd74

Disallow users to delete a version referenced by a custom field (#20159)....

Jean-Philippe Lang -

r13994:bc9ca5fcfd74

parent child

Context file:

r13994:bc9ca5fcfd74

app/controllers/versions_controller.rb +1 -1

                end
                def destroy
-                 if @version.fixed_issues.empty?
+                 if @version.deletable?
                    @version.destroy
                    respond_to do |format|
                      format.html { redirect_back_or_default settings_project_path(@project, :tab => 'versions') }

app/models/version.rb +9 0

                  sharing != 'none'
                end
+               def deletable?
+                 fixed_issues.empty? && !referenced_by_a_custom_field?
+               end
                private
                def load_issue_counts
                    progress
                  end
                end
+               def referenced_by_a_custom_field?
+                 CustomValue.joins(:custom_field).
+                   where(:value => id.to_s, :custom_fields => {:field_format => 'version'}).any?
+               end
              end

test/object_helpers.rb +1 0

                  @generated_version_name.succ!
                  version = Version.new(attributes)
                  version.name = @generated_version_name.dup if version.name.blank?
+                 version.project ||= Project.find(1)
                  yield version if block_given?
                  version.save!
                  version

test/unit/version_test.rb +21 0

                  assert_equal @version, project_2_issue.fixed_version
                end
+               def test_deletable_should_return_true_when_not_referenced
+                 version = Version.generate!
+                 assert_equal true, version.deletable?
+               end
+               def test_deletable_should_return_false_when_referenced_by_an_issue
+                 version = Version.generate!
+                 Issue.generate!(:fixed_version => version)
+                 assert_equal false, version.deletable?
+               end
+               def test_deletable_should_return_false_when_referenced_by_a_custom_field
+                 version = Version.generate!
+                 field = IssueCustomField.generate!(:field_format => 'version')
+                 value = CustomValue.create!(:custom_field => field, :customized => Issue.first, :value => version.id)
+                 assert_equal false, version.deletable?
+               end
                private
                def add_issue(version, attributes={})

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages