jro_apps/redmine Commit - r13994:bc9ca5fcfd74

Disallow users to delete a version referenced by a custom field (#20159)....

Jean-Philippe Lang -

r13994:bc9ca5fcfd74

parent child

Context file:

r13994:bc9ca5fcfd74

Collapse all files

app/controllers/versions_controller.rb +1 -1

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class VersionsController < ApplicationController
               menu_item :roadmap
               model_object Version
               before_filter :find_model_object, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project_from_association, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project_by_project_id, :only => [:index, :new, :create, :close_completed]
               before_filter :authorize
               accept_api_auth :index, :show, :create, :update, :destroy
               helper :custom_fields
               helper :projects
               def index
                 respond_to do |format|
                   format.html {
                     @trackers = @project.trackers.sorted.to_a
                     retrieve_selected_tracker_ids(@trackers, @trackers.select {|t| t.is_in_roadmap?})
                     @with_subprojects = params[:with_subprojects].nil? ? Setting.display_subprojects_issues? : (params[:with_subprojects] == '1')
                     project_ids = @with_subprojects ? @project.self_and_descendants.collect(&:id) : [@project.id]
                     @versions = @project.shared_versions || []
                     @versions += @project.rolled_up_versions.visible if @with_subprojects
                     @versions = @versions.uniq.sort
                     unless params[:completed]
                       @completed_versions = @versions.select {|version| version.closed? || version.completed? }
                       @versions -= @completed_versions
                     end
                     @issues_by_version = {}
                     if @selected_tracker_ids.any? && @versions.any?
                       issues = Issue.visible.
                         includes(:project, :tracker).
                         preload(:status, :priority, :fixed_version).
                         where(:tracker_id => @selected_tracker_ids, :project_id => project_ids, :fixed_version_id => @versions.map(&:id)).
                         order("#{Project.table_name}.lft, #{Tracker.table_name}.position, #{Issue.table_name}.id")
                       @issues_by_version = issues.group_by(&:fixed_version)
                     end
                     @versions.reject! {|version| !project_ids.include?(version.project_id) && @issues_by_version[version].blank?}
                   }
                   format.api {
                     @versions = @project.shared_versions.to_a
                   }
                 end
               end
               def show
                 respond_to do |format|
                   format.html {
                     @issues = @version.fixed_issues.visible.
                       includes(:status, :tracker, :priority).
                       reorder("#{Tracker.table_name}.position, #{Issue.table_name}.id").
                       to_a
                   }
                   format.api
                 end
               end
               def new
                 @version = @project.versions.build
                 @version.safe_attributes = params[:version]
                 respond_to do |format|
                   format.html
                   format.js
                 end
               end
               def create
                 @version = @project.versions.build
                 if params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless attributes.nil? || @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                 end
                 if request.post?
                   if @version.save
                     respond_to do |format|
                       format.html do
                         flash[:notice] = l(:notice_successful_create)
                         redirect_back_or_default settings_project_path(@project, :tab => 'versions')
                       end
                       format.js
                       format.api do
                         render :action => 'show', :status => :created, :location => version_url(@version)
                       end
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'new' }
                       format.js   { render :action => 'new' }
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def edit
               end
               def update
                 if params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                   if @version.save
                     respond_to do |format|
                       format.html {
                         flash[:notice] = l(:notice_successful_update)
                         redirect_back_or_default settings_project_path(@project, :tab => 'versions')
                       }
                       format.api  { render_api_ok }
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'edit' }
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def close_completed
                 if request.put?
                   @project.close_completed_versions
                 end
                 redirect_to settings_project_path(@project, :tab => 'versions')
               end
               def destroy
-                if @version.fixed_issues.empty?
+                if @version.deletable?
                   @version.destroy
                   respond_to do |format|
                     format.html { redirect_back_or_default settings_project_path(@project, :tab => 'versions') }
                     format.api  { render_api_ok }
                   end
                 else
                   respond_to do |format|
                     format.html {
                       flash[:error] = l(:notice_unable_delete_version)
                       redirect_to settings_project_path(@project, :tab => 'versions')
                     }
                     format.api  { head :unprocessable_entity }
                   end
                 end
               end
               def status_by
                 respond_to do |format|
                   format.html { render :action => 'show' }
                   format.js
                 end
               end
               private
               def retrieve_selected_tracker_ids(selectable_trackers, default_trackers=nil)
                 if ids = params[:tracker_ids]
                   @selected_tracker_ids = (ids.is_a? Array) ? ids.collect { |id| id.to_i.to_s } : ids.split('/').collect { |id| id.to_i.to_s }
                 else
                   @selected_tracker_ids = (default_trackers || selectable_trackers).collect {|t| t.id.to_s }
                 end
               end
             end

app/models/version.rb +9 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Version < ActiveRecord::Base
               include Redmine::SafeAttributes
               after_update :update_issues_from_sharing_change
               belongs_to :project
               has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id', :dependent => :nullify
               acts_as_customizable
               acts_as_attachable :view_permission => :view_files,
                                  :edit_permission => :manage_files,
                                  :delete_permission => :manage_files
               VERSION_STATUSES = %w(open locked closed)
               VERSION_SHARINGS = %w(none descendants hierarchy tree system)
               validates_presence_of :name
               validates_uniqueness_of :name, :scope => [:project_id]
               validates_length_of :name, :maximum => 60
               validates_length_of :description, :maximum => 255
               validates :effective_date, :date => true
               validates_inclusion_of :status, :in => VERSION_STATUSES
               validates_inclusion_of :sharing, :in => VERSION_SHARINGS
               attr_protected :id
               scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
               scope :open, lambda { where(:status => 'open') }
               scope :visible, lambda {|*args|
                 joins(:project).
                 where(Project.allowed_to_condition(args.first || User.current, :view_issues))
               }
               safe_attributes 'name',
                 'description',
                 'effective_date',
                 'due_date',
                 'wiki_page_title',
                 'status',
                 'sharing',
                 'custom_field_values',
                 'custom_fields'
               # Returns true if +user+ or current user is allowed to view the version
               def visible?(user=User.current)
                 user.allowed_to?(:view_issues, self.project)
               end
               # Version files have same visibility as project files
               def attachments_visible?(*args)
                 project.present? && project.attachments_visible?(*args)
               end
               def attachments_deletable?(usr=User.current)
                 project.present? && project.attachments_deletable?(usr)
               end
               def start_date
                 @start_date ||= fixed_issues.minimum('start_date')
               end
               def due_date
                 effective_date
               end
               def due_date=(arg)
                 self.effective_date=(arg)
               end
               # Returns the total estimated time for this version
               # (sum of leaves estimated_hours)
               def estimated_hours
                 @estimated_hours ||= fixed_issues.sum(:estimated_hours).to_f
               end
               # Returns the total reported time for this version
               def spent_hours
                 @spent_hours ||= TimeEntry.joins(:issue).where("#{Issue.table_name}.fixed_version_id = ?", id).sum(:hours).to_f
               end
               def closed?
                 status == 'closed'
               end
               def open?
                 status == 'open'
               end
               # Returns true if the version is completed: due date reached and no open issues
               def completed?
                 effective_date && (effective_date < Date.today) && (open_issues_count == 0)
               end
               def behind_schedule?
                 if completed_percent == 100
                   return false
                 elsif due_date && start_date
                   done_date = start_date + ((due_date - start_date+1)* completed_percent/100).floor
                   return done_date <= Date.today
                 else
                   false # No issues so it's not late
                 end
               end
               # Returns the completion percentage of this version based on the amount of open/closed issues
               # and the time spent on the open issues.
               def completed_percent
                 if issues_count == 0
                 elsif open_issues_count == 0
                 else
                   issues_progress(false) + issues_progress(true)
                 end
               end
               # Returns the percentage of issues that have been marked as 'closed'.
               def closed_percent
                 if issues_count == 0
                 else
                   issues_progress(false)
                 end
               end
               # Returns true if the version is overdue: due date reached and some open issues
               def overdue?
                 effective_date && (effective_date < Date.today) && (open_issues_count > 0)
               end
               # Returns assigned issues count
               def issues_count
                 load_issue_counts
                 @issue_count
               end
               # Returns the total amount of open issues for this version.
               def open_issues_count
                 load_issue_counts
                 @open_issues_count
               end
               # Returns the total amount of closed issues for this version.
               def closed_issues_count
                 load_issue_counts
                 @closed_issues_count
               end
               def wiki_page
                 if project.wiki && !wiki_page_title.blank?
                   @wiki_page ||= project.wiki.find_page(wiki_page_title)
                 end
                 @wiki_page
               end
               def to_s; name end
               def to_s_with_project
                 "#{project} - #{name}"
               end
               # Versions are sorted by effective_date and name
               # Those with no effective_date are at the end, sorted by name
               def <=>(version)
                 if self.effective_date
                   if version.effective_date
                     if self.effective_date == version.effective_date
                       name == version.name ? id <=> version.id : name <=> version.name
                     else
                       self.effective_date <=> version.effective_date
                     end
                   else
                     -1
                   end
                 else
                   if version.effective_date
                   else
                     name == version.name ? id <=> version.id : name <=> version.name
                   end
                 end
               end
               def self.fields_for_order_statement(table=nil)
                 table ||= table_name
                 ["(CASE WHEN #{table}.effective_date IS NULL THEN 1 ELSE 0 END)", "#{table}.effective_date", "#{table}.name", "#{table}.id"]
               end
               scope :sorted, lambda { order(fields_for_order_statement) }
               # Returns the sharings that +user+ can set the version to
               def allowed_sharings(user = User.current)
                 VERSION_SHARINGS.select do |s|
                   if sharing == s
                     true
                   else
                     case s
                     when 'system'
                       # Only admin users can set a systemwide sharing
                       user.admin?
                     when 'hierarchy', 'tree'
                       # Only users allowed to manage versions of the root project can
                       # set sharing to hierarchy or tree
                       project.nil? || user.allowed_to?(:manage_versions, project.root)
                     else
                       true
                     end
                   end
                 end
               end
               # Returns true if the version is shared, otherwise false
               def shared?
                 sharing != 'none'
               end
+              def deletable?
+                fixed_issues.empty? && !referenced_by_a_custom_field?
+              end
               private
               def load_issue_counts
                 unless @issue_count
                   @open_issues_count = 0
                   @closed_issues_count = 0
                   fixed_issues.group(:status).count.each do |status, count|
                     if status.is_closed?
                       @closed_issues_count += count
                     else
                       @open_issues_count += count
                     end
                   end
                   @issue_count = @open_issues_count + @closed_issues_count
                 end
               end
               # Update the issue's fixed versions. Used if a version's sharing changes.
               def update_issues_from_sharing_change
                 if sharing_changed?
                   if VERSION_SHARINGS.index(sharing_was).nil? ||
                       VERSION_SHARINGS.index(sharing).nil? ||
                       VERSION_SHARINGS.index(sharing_was) > VERSION_SHARINGS.index(sharing)
                     Issue.update_versions_from_sharing_change self
                   end
                 end
               end
               # Returns the average estimated time of assigned issues
               # or 1 if no issue has an estimated time
               # Used to weight unestimated issues in progress calculation
               def estimated_average
                 if @estimated_average.nil?
                   average = fixed_issues.average(:estimated_hours).to_f
                   if average == 0
                     average = 1
                   end
                   @estimated_average = average
                 end
                 @estimated_average
               end
               # Returns the total progress of open or closed issues.  The returned percentage takes into account
               # the amount of estimated time set for this version.
               #
               # Examples:
               # issues_progress(true)   => returns the progress percentage for open issues.
               # issues_progress(false)  => returns the progress percentage for closed issues.
               def issues_progress(open)
                 @issues_progress ||= {}
                 @issues_progress[open] ||= begin
                   progress = 0
                   if issues_count > 0
                     ratio = open ? 'done_ratio' : 100
                     done = fixed_issues.open(open).sum("COALESCE(estimated_hours, #{estimated_average}) * #{ratio}").to_f
                     progress = done / (estimated_average * issues_count)
                   end
                   progress
                 end
               end
+              def referenced_by_a_custom_field?
+                CustomValue.joins(:custom_field).
+                  where(:value => id.to_s, :custom_fields => {:field_format => 'version'}).any?
+              end
             end

test/object_helpers.rb +1 0

             module ObjectHelpers
               def User.generate!(attributes={})
                 @generated_user_login ||= 'user0'
                 @generated_user_login.succ!
                 user = User.new(attributes)
                 user.login = @generated_user_login.dup if user.login.blank?
                 user.mail = "#{@generated_user_login}@example.com" if user.mail.blank?
                 user.firstname = "Bob" if user.firstname.blank?
                 user.lastname = "Doe" if user.lastname.blank?
                 yield user if block_given?
                 user.save!
                 user
               end
               def User.add_to_project(user, project, roles=nil)
                 roles = Role.find(1) if roles.nil?
                 roles = [roles] if roles.is_a?(Role)
                 Member.create!(:principal => user, :project => project, :roles => roles)
               end
               def Group.generate!(attributes={})
                 @generated_group_name ||= 'Group 0'
                 @generated_group_name.succ!
                 group = Group.new(attributes)
                 group.name = @generated_group_name.dup if group.name.blank?
                 yield group if block_given?
                 group.save!
                 group
               end
               def Project.generate!(attributes={})
                 @generated_project_identifier ||= 'project-0000'
                 @generated_project_identifier.succ!
                 project = Project.new(attributes)
                 project.name = @generated_project_identifier.dup if project.name.blank?
                 project.identifier = @generated_project_identifier.dup if project.identifier.blank?
                 yield project if block_given?
                 project.save!
                 project
               end
               def Project.generate_with_parent!(parent, attributes={})
                 project = Project.generate!(attributes) do |p|
                   p.parent = parent
                 end
                 parent.reload if parent
                 project
               end
               def IssueStatus.generate!(attributes={})
                 @generated_status_name ||= 'Status 0'
                 @generated_status_name.succ!
                 status = IssueStatus.new(attributes)
                 status.name = @generated_status_name.dup if status.name.blank?
                 yield status if block_given?
                 status.save!
                 status
               end
               def Tracker.generate!(attributes={})
                 @generated_tracker_name ||= 'Tracker 0'
                 @generated_tracker_name.succ!
                 tracker = Tracker.new(attributes)
                 tracker.name = @generated_tracker_name.dup if tracker.name.blank?
                 tracker.default_status ||= IssueStatus.order('position').first || IssueStatus.generate!
                 yield tracker if block_given?
                 tracker.save!
                 tracker
               end
               def Role.generate!(attributes={})
                 @generated_role_name ||= 'Role 0'
                 @generated_role_name.succ!
                 role = Role.new(attributes)
                 role.name = @generated_role_name.dup if role.name.blank?
                 yield role if block_given?
                 role.save!
                 role
               end
               # Generates an unsaved Issue
               def Issue.generate(attributes={})
                 issue = Issue.new(attributes)
                 issue.project ||= Project.find(1)
                 issue.tracker ||= issue.project.trackers.first
                 issue.subject = 'Generated' if issue.subject.blank?
                 issue.author ||= User.find(2)
                 yield issue if block_given?
                 issue
               end
               # Generates a saved Issue
               def Issue.generate!(attributes={}, &block)
                 issue = Issue.generate(attributes, &block)
                 issue.save!
                 issue
               end
               # Generates an issue with 2 children and a grandchild
               def Issue.generate_with_descendants!(attributes={})
                 issue = Issue.generate!(attributes)
                 child = Issue.generate!(:project => issue.project, :subject => 'Child1', :parent_issue_id => issue.id)
                 Issue.generate!(:project => issue.project, :subject => 'Child2', :parent_issue_id => issue.id)
                 Issue.generate!(:project => issue.project, :subject => 'Child11', :parent_issue_id => child.id)
                 issue.reload
               end
               def Issue.generate_with_child!(attributes={})
                 issue = Issue.generate!(attributes)
                 Issue.generate!(:parent_issue_id => issue.id)
                 issue.reload
               end
               def Journal.generate!(attributes={})
                 journal = Journal.new(attributes)
                 journal.user ||= User.first
                 journal.journalized ||= Issue.first
                 yield journal if block_given?
                 journal.save!
                 journal
               end
               def Version.generate!(attributes={})
                 @generated_version_name ||= 'Version 0'
                 @generated_version_name.succ!
                 version = Version.new(attributes)
                 version.name = @generated_version_name.dup if version.name.blank?
+                version.project ||= Project.find(1)
                 yield version if block_given?
                 version.save!
                 version
               end
               def TimeEntry.generate!(attributes={})
                 entry = TimeEntry.new(attributes)
                 entry.user ||= User.find(2)
                 entry.issue ||= Issue.find(1) unless entry.project
                 entry.project ||= entry.issue.project
                 entry.activity ||= TimeEntryActivity.first
                 entry.spent_on ||= Date.today
                 entry.hours ||= 1.0
                 entry.save!
                 entry
               end
               def AuthSource.generate!(attributes={})
                 @generated_auth_source_name ||= 'Auth 0'
                 @generated_auth_source_name.succ!
                 source = AuthSource.new(attributes)
                 source.name = @generated_auth_source_name.dup if source.name.blank?
                 yield source if block_given?
                 source.save!
                 source
               end
               def Board.generate!(attributes={})
                 @generated_board_name ||= 'Forum 0'
                 @generated_board_name.succ!
                 board = Board.new(attributes)
                 board.name = @generated_board_name.dup if board.name.blank?
                 board.description = @generated_board_name.dup if board.description.blank?
                 yield board if block_given?
                 board.save!
                 board
               end
               def Attachment.generate!(attributes={})
                 @generated_filename ||= 'testfile0'
                 @generated_filename.succ!
                 attributes = attributes.dup
                 attachment = Attachment.new(attributes)
                 attachment.container ||= Issue.find(1)
                 attachment.author ||= User.find(2)
                 attachment.filename = @generated_filename.dup if attachment.filename.blank?
                 attachment.save!
                 attachment
               end
               def CustomField.generate!(attributes={})
                 @generated_custom_field_name ||= 'Custom field 0'
                 @generated_custom_field_name.succ!
                 field = new(attributes)
                 field.name = @generated_custom_field_name.dup if field.name.blank?
                 field.field_format = 'string' if field.field_format.blank?
                 yield field if block_given?
                 field.save!
                 field
               end
               def Changeset.generate!(attributes={})
                 @generated_changeset_rev ||= '123456'
                 @generated_changeset_rev.succ!
                 changeset = new(attributes)
                 changeset.repository ||= Project.find(1).repository
                 changeset.revision ||= @generated_changeset_rev
                 changeset.committed_on ||= Time.now
                 yield changeset if block_given?
                 changeset.save!
                 changeset
               end
               def Query.generate!(attributes={})
                 query = new(attributes)
                 query.name = "Generated query" if query.name.blank?
                 query.user ||= User.find(1)
                 query.save!
                 query
               end
             end
             module TrackerObjectHelpers
               def generate_transitions!(*args)
                 options = args.last.is_a?(Hash) ? args.pop : {}
                 if args.size == 1
                   args << args.first
                 end
                 if options[:clear]
                   WorkflowTransition.where(:tracker_id => id).delete_all
                 end
                 args.each_cons(2) do |old_status_id, new_status_id|
                   WorkflowTransition.create!(
                     :tracker => self,
                     :role_id => (options[:role_id] || 1),
                     :old_status_id => old_status_id,
                     :new_status_id => new_status_id
                   )
                 end
               end
             end
             Tracker.send :include, TrackerObjectHelpers
             module IssueObjectHelpers
               def close!
                 self.status = IssueStatus.where(:is_closed => true).first
                 save!
               end
               def generate_child!(attributes={})
                 Issue.generate!(attributes.merge(:parent_issue_id => self.id))
               end
             end
             Issue.send :include, IssueObjectHelpers

test/unit/version_test.rb +21 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class VersionTest < ActiveSupport::TestCase
               fixtures :projects, :users, :issues, :issue_statuses, :trackers,
                        :enumerations, :versions, :projects_trackers
               def test_create
                 v = Version.new(:project => Project.find(1), :name => '1.1',
                                 :effective_date => '2011-03-25')
                 assert v.save
                 assert_equal 'open', v.status
                 assert_equal 'none', v.sharing
               end
               def test_invalid_effective_date_validation
                 v = Version.new(:project => Project.find(1), :name => '1.1',
                                 :effective_date => '99999-01-01')
                 assert !v.valid?
                 v.effective_date = '2012-11-33'
                 assert !v.valid?
                 v.effective_date = '2012-31-11'
                 assert !v.valid?
                 v.effective_date = '-2012-31-11'
                 assert !v.valid?
                 v.effective_date = 'ABC'
                 assert !v.valid?
                 assert_include I18n.translate('activerecord.errors.messages.not_a_date'),
                                v.errors[:effective_date]
               end
               def test_progress_should_be_0_with_no_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 assert_equal 0, v.completed_percent
                 assert_equal 0, v.closed_percent
               end
               def test_progress_should_be_0_with_unbegun_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 0)
                 assert_progress_equal 0, v.completed_percent
                 assert_progress_equal 0, v.closed_percent
               end
               def test_progress_should_be_100_with_closed_assigned_issues
                 project = Project.find(1)
                 status = IssueStatus.where(:is_closed => true).first
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :status => status)
                 add_issue(v, :status => status, :done_ratio => 20)
                 add_issue(v, :status => status, :done_ratio => 70, :estimated_hours => 25)
                 add_issue(v, :status => status, :estimated_hours => 15)
                 assert_progress_equal 100.0, v.completed_percent
                 assert_progress_equal 100.0, v.closed_percent
               end
               def test_progress_should_consider_done_ratio_of_open_assigned_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :done_ratio => 70)
                 assert_progress_equal (0.0 + 20.0 + 70.0)/3, v.completed_percent
                 assert_progress_equal 0, v.closed_percent
               end
               def test_progress_should_consider_closed_issues_as_completed
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v)
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :status => IssueStatus.where(:is_closed => true).first)
                 assert_progress_equal (0.0 + 20.0 + 100.0)/3, v.completed_percent
                 assert_progress_equal (100.0)/3, v.closed_percent
               end
               def test_progress_should_consider_estimated_hours_to_weight_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :estimated_hours => 10)
                 add_issue(v, :estimated_hours => 20, :done_ratio => 30)
                 add_issue(v, :estimated_hours => 40, :done_ratio => 10)
                 add_issue(v, :estimated_hours => 25, :status => IssueStatus.where(:is_closed => true).first)
                 assert_progress_equal (10.0*0 + 20.0*0.3 + 40*0.1 + 25.0*1)/95.0*100, v.completed_percent
                 assert_progress_equal 25.0/95.0*100, v.closed_percent
               end
               def test_progress_should_consider_average_estimated_hours_to_weight_unestimated_issues
                 project = Project.find(1)
                 v = Version.create!(:project => project, :name => 'Progress')
                 add_issue(v, :done_ratio => 20)
                 add_issue(v, :status => IssueStatus.where(:is_closed => true).first)
                 add_issue(v, :estimated_hours => 10, :done_ratio => 30)
                 add_issue(v, :estimated_hours => 40, :done_ratio => 10)
                 assert_progress_equal (25.0*0.2 + 25.0*1 + 10.0*0.3 + 40.0*0.1)/100.0*100, v.completed_percent
                 assert_progress_equal 25.0/100.0*100, v.closed_percent
               end
               def test_should_sort_scheduled_then_unscheduled_versions
                 Version.delete_all
                 v4 = Version.create!(:project_id => 1, :name => 'v4')
                 v3 = Version.create!(:project_id => 1, :name => 'v2', :effective_date => '2012-07-14')
                 v2 = Version.create!(:project_id => 1, :name => 'v1')
                 v1 = Version.create!(:project_id => 1, :name => 'v3', :effective_date => '2012-08-02')
                 v5 = Version.create!(:project_id => 1, :name => 'v5', :effective_date => '2012-07-02')
                 assert_equal [v5, v3, v1, v2, v4], [v1, v2, v3, v4, v5].sort
                 assert_equal [v5, v3, v1, v2, v4], Version.sorted.to_a
               end
               def test_should_sort_versions_with_same_date_by_name
                 v1 = Version.new(:effective_date => '2014-12-03', :name => 'v2')
                 v2 = Version.new(:effective_date => '2014-12-03', :name => 'v1')
                 assert_equal [v2, v1], [v1, v2].sort
               end
               def test_completed_should_be_false_when_due_today
                 version = Version.create!(:project_id => 1, :effective_date => Date.today, :name => 'Due today')
                 assert_equal false, version.completed?
               end
               test "#behind_schedule? should be false if there are no issues assigned" do
                 version = Version.generate!(:effective_date => Date.yesterday)
                 assert_equal false, version.behind_schedule?
               end
               test "#behind_schedule? should be false if there is no effective_date" do
                 version = Version.generate!(:effective_date => nil)
                 assert_equal false, version.behind_schedule?
               end
               test "#behind_schedule? should be false if all of the issues are ahead of schedule" do
                 version = Version.create!(:project_id => 1, :name => 'test', :effective_date => 7.days.from_now.to_date)
                 add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
                 add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
                 assert_equal 60, version.completed_percent
                 assert_equal false, version.behind_schedule?
               end
               test "#behind_schedule? should be true if any of the issues are behind schedule" do
                 version = Version.create!(:project_id => 1, :name => 'test', :effective_date => 7.days.from_now.to_date)
                 add_issue(version, :start_date => 7.days.ago, :done_ratio => 60) # 14 day span, 60% done, 50% time left
                 add_issue(version, :start_date => 7.days.ago, :done_ratio => 20) # 14 day span, 20% done, 50% time left
                 assert_equal 40, version.completed_percent
                 assert_equal true, version.behind_schedule?
               end
               test "#behind_schedule? should be false if all of the issues are complete" do
                 version = Version.create!(:project_id => 1, :name => 'test', :effective_date => 7.days.from_now.to_date)
                 add_issue(version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
                 add_issue(version, :start_date => 14.days.ago, :done_ratio => 100, :status => IssueStatus.find(5)) # 7 day span
                 assert_equal 100, version.completed_percent
                 assert_equal false, version.behind_schedule?
               end
               test "#estimated_hours should return 0 with no assigned issues" do
                 version = Version.generate!
                 assert_equal 0, version.estimated_hours
               end
               test "#estimated_hours should return 0 with no estimated hours" do
                 version = Version.create!(:project_id => 1, :name => 'test')
                 add_issue(version)
                 assert_equal 0, version.estimated_hours
               end
               test "#estimated_hours should return return the sum of estimated hours" do
                 version = Version.create!(:project_id => 1, :name => 'test')
                 add_issue(version, :estimated_hours => 2.5)
                 add_issue(version, :estimated_hours => 5)
                 assert_equal 7.5, version.estimated_hours
               end
               test "#estimated_hours should return the sum of leaves estimated hours" do
                 version = Version.create!(:project_id => 1, :name => 'test')
                 parent = add_issue(version)
                 add_issue(version, :estimated_hours => 2.5, :parent_issue_id => parent.id)
                 add_issue(version, :estimated_hours => 5, :parent_issue_id => parent.id)
                 assert_equal 7.5, version.estimated_hours
               end
               test "should update all issue's fixed_version associations in case the hierarchy changed XXX" do
                 User.current = User.find(1) # Need the admin's permissions
                 @version = Version.find(7)
                 # Separate hierarchy
                 project_1_issue = Issue.find(1)
                 project_1_issue.fixed_version = @version
                 assert project_1_issue.save, project_1_issue.errors.full_messages.to_s
                 project_5_issue = Issue.find(6)
                 project_5_issue.fixed_version = @version
                 assert project_5_issue.save
                 # Project
                 project_2_issue = Issue.find(4)
                 project_2_issue.fixed_version = @version
                 assert project_2_issue.save
                 # Update the sharing
                 @version.sharing = 'none'
                 assert @version.save
                 # Project 1 now out of the shared scope
                 project_1_issue.reload
                 assert_equal nil, project_1_issue.fixed_version,
                             "Fixed version is still set after changing the Version's sharing"
                 # Project 5 now out of the shared scope
                 project_5_issue.reload
                 assert_equal nil, project_5_issue.fixed_version,
                             "Fixed version is still set after changing the Version's sharing"
                 # Project 2 issue remains
                 project_2_issue.reload
                 assert_equal @version, project_2_issue.fixed_version
               end
+              def test_deletable_should_return_true_when_not_referenced
+                version = Version.generate!
+                assert_equal true, version.deletable?
+              end
+              def test_deletable_should_return_false_when_referenced_by_an_issue
+                version = Version.generate!
+                Issue.generate!(:fixed_version => version)
+                assert_equal false, version.deletable?
+              end
+              def test_deletable_should_return_false_when_referenced_by_a_custom_field
+                version = Version.generate!
+                field = IssueCustomField.generate!(:field_format => 'version')
+                value = CustomValue.create!(:custom_field => field, :customized => Issue.first, :value => version.id)
+                assert_equal false, version.deletable?
+              end
               private
               def add_issue(version, attributes={})
                 Issue.create!({:project => version.project,
                                :fixed_version => version,
                                :subject => 'Test',
                                :author => User.first,
                                :tracker => version.project.trackers.first}.merge(attributes))
               end
               def assert_progress_equal(expected_float, actual_float, message="")
                 assert_in_delta(expected_float, actual_float, 0.000001, message="")
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages