jro_apps/redmine Commit - r8107:b6e6f557f01b

Display issue form fields according to permissions....

Jean-Philippe Lang -

r8107:b6e6f557f01b

parent child

Context file:

r8107:b6e6f557f01b

Collapse all files

app/models/issue.rb +1 0

              # Redmine - project management software
              # Copyright (C) 2006-2011  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Issue < ActiveRecord::Base
                include Redmine::SafeAttributes
                belongs_to :project
                belongs_to :tracker
                belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
                belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
                belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
                belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
                belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
                belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
                has_many :journals, :as => :journalized, :dependent => :destroy
                has_many :time_entries, :dependent => :delete_all
                has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
                has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
                has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
                acts_as_nested_set :scope => 'root_id', :dependent => :destroy
                acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
                acts_as_customizable
                acts_as_watchable
                acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                   :include => [:project, :journals],
                                   # sort by id so that limited eager loading doesn't break with postgresql
                                   :order_column => "#{table_name}.id"
                acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                              :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                              :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
                acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                          :author_key => :author_id
                DONE_RATIO_OPTIONS = %w(issue_field issue_status)
                attr_reader :current_journal
                validates_presence_of :subject, :priority, :project, :tracker, :author, :status
                validates_length_of :subject, :maximum => 255
                validates_inclusion_of :done_ratio, :in => 0..100
                validates_numericality_of :estimated_hours, :allow_nil => true
                validate :validate_issue
                named_scope :visible, lambda {|*args| { :include => :project,
                                                        :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
                named_scope :open, :conditions => ["#{IssueStatus.table_name}.is_closed = ?", false], :include => :status
                named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
                named_scope :with_limit, lambda { |limit| { :limit => limit} }
                named_scope :on_active_project, :include => [:status, :project, :tracker],
                                                :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
                named_scope :without_version, lambda {
                  {
                    :conditions => { :fixed_version_id => nil}
                  }
                }
                named_scope :with_query, lambda {|query|
                  {
                    :conditions => Query.merge_conditions(query.statement)
                  }
                }
                before_create :default_assign
                before_save :close_duplicates, :update_done_ratio_from_issue_status
                after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
                after_destroy :update_parent_attributes
                # Returns a SQL conditions string used to find all issues visible by the specified user
                def self.visible_condition(user, options={})
                  Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      nil
                    when 'default'
                      user_ids = [user.id] + user.groups.map(&:id)
                      "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                    when 'own'
                      user_ids = [user.id] + user.groups.map(&:id)
                      "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                    else
                      '1=0'
                    end
                  end
                end
                # Returns true if usr or current user is allowed to view the issue
                def visible?(usr=nil)
                  (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      true
                    when 'default'
                      !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
                    when 'own'
                      self.author == user || user.is_or_belongs_to?(assigned_to)
                    else
                      false
                    end
                  end
                end
                def after_initialize
                  if new_record?
                    # set default values for new records only
                    self.status ||= IssueStatus.default
                    self.priority ||= IssuePriority.default
                  end
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
                def available_custom_fields
                  (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
                end
                def copy_from(arg)
                  issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                  self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                  self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                  self.status = issue.status
                  self
                end
                # Moves/copies an issue to a new project and tracker
                # Returns the moved/copied issue on success, false on failure
                def move_to_project(*args)
                  ret = Issue.transaction do
                    move_to_project_without_transaction(*args) || raise(ActiveRecord::Rollback)
                  end || false
                end
                def move_to_project_without_transaction(new_project, new_tracker = nil, options = {})
                  options ||= {}
                  if options[:copy]
                    issue = self.class.new.copy_from(self)
                  else
                    issue = self
                    issue.init_journal(User.current, options[:notes])
                  end
                  if new_project && issue.project_id != new_project.id
                    # delete issue relations
                    unless Setting.cross_project_issue_relations?
                      issue.relations_from.clear
                      issue.relations_to.clear
                    end
                    # issue is moved to another project
                    # reassign to the category with same name if any
                    new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name)
                    issue.category = new_category
                    # Keep the fixed_version if it's still valid in the new_project
                    unless new_project.shared_versions.include?(issue.fixed_version)
                      issue.fixed_version = nil
                    end
                    issue.project = new_project
                    if issue.parent && issue.parent.project_id != issue.project_id
                      issue.parent_issue_id = nil
                    end
                  end
                  if new_tracker
                    issue.tracker = new_tracker
                    issue.reset_custom_values!
                  end
                  if options[:copy]
                    issue.author = User.current
                    issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                    issue.status = if options[:attributes] && options[:attributes][:status_id]
                                     IssueStatus.find_by_id(options[:attributes][:status_id])
                                   else
                                     self.status
                                   end
                  end
                  # Allow bulk setting of attributes on the issue
                  if options[:attributes]
                    issue.attributes = options[:attributes]
                  end
                  if options[:copy] && options[:notes].present?
                    issue.init_journal(User.current, options[:notes])
                    issue.current_journal.notify = false
                  end
                  if issue.save
                    unless options[:copy]
                      # Manually update project_id on related time entries
                      TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
                      issue.children.each do |child|
                        unless child.move_to_project_without_transaction(new_project)
                          # Move failed and transaction was rollback'd
                          return false
                        end
                      end
                    end
                  else
                    return false
                  end
                  issue
                end
                def status_id=(sid)
                  self.status = nil
                  write_attribute(:status_id, sid)
                end
                def priority_id=(pid)
                  self.priority = nil
                  write_attribute(:priority_id, pid)
                end
                def tracker_id=(tid)
                  self.tracker = nil
                  result = write_attribute(:tracker_id, tid)
                  @custom_field_values = nil
                  result
                end
                def description=(arg)
                  if arg.is_a?(String)
                    arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                  end
                  write_attribute(:description, arg)
                end
                # Overrides attributes= so that project and tracker get assigned first
                def attributes_with_project_and_tracker_first=(new_attributes, *args)
                  return if new_attributes.nil?
                  attrs = new_attributes.dup
                  attrs.stringify_keys!
                  %w(project project_id tracker tracker_id).each do |attr|
                    if attrs.has_key?(attr)
                      send "#{attr}=", attrs.delete(attr)
                    end
                  end
                  send :attributes_without_project_and_tracker_first=, attrs, *args
                end
                # Do not redefine alias chain on reload (see #4838)
                alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
                def estimated_hours=(h)
                  write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
                end
                safe_attributes 'tracker_id',
                  'status_id',
                  'category_id',
                  'assigned_to_id',
                  'priority_id',
                  'fixed_version_id',
                  'subject',
                  'description',
                  'start_date',
                  'due_date',
                  'done_ratio',
                  'estimated_hours',
                  'custom_field_values',
                  'custom_fields',
                  'lock_version',
                  :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
                safe_attributes 'status_id',
                  'assigned_to_id',
                  'fixed_version_id',
                  'done_ratio',
+                 'lock_version',
                  :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
                safe_attributes 'watcher_user_ids',
                  :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
                safe_attributes 'is_private',
                  :if => lambda {|issue, user|
                    user.allowed_to?(:set_issues_private, issue.project) ||
                      (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                  }
                safe_attributes 'parent_issue_id',
                  :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                    user.allowed_to?(:manage_subtasks, issue.project)}
                # Safely sets attributes
                # Should be called from controllers instead of #attributes=
                # attr_accessible is too rough because we still want things like
                # Issue.new(:project => foo) to work
                # TODO: move workflow/permission checks from controllers to here
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                  attrs = delete_unsafe_attributes(attrs, user)
                  return if attrs.empty?
                  # Tracker must be set before since new_statuses_allowed_to depends on it.
                  if t = attrs.delete('tracker_id')
                    self.tracker_id = t
                  end
                  if attrs['status_id']
                    unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
                      attrs.delete('status_id')
                    end
                  end
                  unless leaf?
                    attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                  end
                  if attrs['parent_issue_id'].present?
                    attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
                  end
                  # mass-assignment security bypass
                  self.send :attributes=, attrs, false
                end
                def done_ratio
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    status.default_done_ratio
                  else
                    read_attribute(:done_ratio)
                  end
                end
                def self.use_status_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_status'
                end
                def self.use_field_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_field'
                end
                def validate_issue
                  if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
                    errors.add :due_date, :not_a_date
                  end
                  if self.due_date and self.start_date and self.due_date < self.start_date
                    errors.add :due_date, :greater_than_start_date
                  end
                  if start_date && soonest_start && start_date < soonest_start
                    errors.add :start_date, :invalid
                  end
                  if fixed_version
                    if !assignable_versions.include?(fixed_version)
                      errors.add :fixed_version_id, :inclusion
                    elsif reopened? && fixed_version.closed?
                      errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                    end
                  end
                  # Checks that the issue can not be added/moved to a disabled tracker
                  if project && (tracker_id_changed? || project_id_changed?)
                    unless project.trackers.include?(tracker)
                      errors.add :tracker_id, :inclusion
                    end
                  end
                  # Checks parent issue assignment
                  if @parent_issue
                    if @parent_issue.project_id != project_id
                      errors.add :parent_issue_id, :not_same_project
                    elsif !new_record?
                      # moving an existing issue
                      if @parent_issue.root_id != root_id
                        # we can always move to another tree
                      elsif move_possible?(@parent_issue)
                        # move accepted inside tree
                      else
                        errors.add :parent_issue_id, :not_a_valid_parent
                      end
                    end
                  end
                end
                # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
                # even if the user turns off the setting later
                def update_done_ratio_from_issue_status
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    self.done_ratio = status.default_done_ratio
                  end
                end
                def init_journal(user, notes = "")
                  @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                  @issue_before_change = self.clone
                  @issue_before_change.status = self.status
                  @custom_values_before_change = {}
                  self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                  # Make sure updated_on is updated when adding a note.
                  updated_on_will_change!
                  @current_journal
                end
                # Return true if the issue is closed, otherwise false
                def closed?
                  self.status.is_closed?
                end
                # Return true if the issue is being reopened
                def reopened?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Return true if the issue is being closed
                def closing?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Returns true if the issue is overdue
                def overdue?
                  !due_date.nil? && (due_date < Date.today) && !status.is_closed?
                end
                # Is the amount of work done less than it should for the due date
                def behind_schedule?
                  return false if start_date.nil? || due_date.nil?
                  done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                  return done_date <= Date.today
                end
                # Does this issue have children?
                def children?
                  !leaf?
                end
                # Users the issue can be assigned to
                def assignable_users
                  users = project.assignable_users
                  users << author if author
                  users << assigned_to if assigned_to
                  users.uniq.sort
                end
                # Versions that the issue can be assigned to
                def assignable_versions
                  @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
                end
                # Returns true if this issue is blocked by another issue that is still open
                def blocked?
                  !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
                end
                # Returns an array of status that user is able to apply
                def new_statuses_allowed_to(user, include_default=false)
                  statuses = status.find_new_statuses_allowed_to(
                    user.roles_for_project(project),
                    tracker,
                    author == user,
                    assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                    )
                  statuses << status unless statuses.empty?
                  statuses << IssueStatus.default if include_default
                  statuses = statuses.uniq.sort
                  blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                end
                # Returns the mail adresses of users that should be notified
                def recipients
                  notified = project.notified_users
                  # Author and assignee are always notified unless they have been
                  # locked or don't want to be notified
                  notified << author if author && author.active? && author.notify_about?(self)
                  if assigned_to
                    if assigned_to.is_a?(Group)
                      notified += assigned_to.users.select {|u| u.active? && u.notify_about?(self)}
                    else
                      notified << assigned_to if assigned_to.active? && assigned_to.notify_about?(self)
                    end
                  end
                  notified.uniq!
                  # Remove users that can not view the issue
                  notified.reject! {|user| !visible?(user)}
                  notified.collect(&:mail)
                end
                # Returns the number of hours spent on this issue
                def spent_hours
                  @spent_hours ||= time_entries.sum(:hours) || 0
                end
                # Returns the total number of hours spent on this issue and its descendants
                #
                # Example:
                #   spent_hours => 0.0
                #   spent_hours => 50.2
                def total_spent_hours
                  @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours", :include => :time_entries).to_f || 0.0
                end
                def relations
                  @relations ||= (relations_from + relations_to).sort
                end
                # Preloads relations for a collection of issues
                def self.load_relations(issues)
                  if issues.any?
                    relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
                    issues.each do |issue|
                      issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                    end
                  end
                end
                # Preloads visible spent time for a collection of issues
                def self.load_visible_spent_hours(issues, user=User.current)
                  if issues.any?
                    hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
                    issues.each do |issue|
                      issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                    end
                  end
                end
                # Finds an issue relation given its id.
                def find_relation(relation_id)
                  IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
                end
                def all_dependent_issues(except=[])
                  except << self
                  dependencies = []
                  relations_from.each do |relation|
                    if relation.issue_to && !except.include?(relation.issue_to)
                      dependencies << relation.issue_to
                      dependencies += relation.issue_to.all_dependent_issues(except)
                    end
                  end
                  dependencies
                end
                # Returns an array of issues that duplicate this one
                def duplicates
                  relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
                end
                # Returns the due date or the target due date if any
                # Used on gantt chart
                def due_before
                  due_date || (fixed_version ? fixed_version.effective_date : nil)
                end
                # Returns the time scheduled for this issue.
                #
                # Example:
                #   Start Date: 2/26/09, End Date: 3/04/09
                #   duration => 6
                def duration
                  (start_date && due_date) ? due_date - start_date : 0
                end
                def soonest_start
                  @soonest_start ||= (
                      relations_to.collect{|relation| relation.successor_soonest_start} +
                      ancestors.collect(&:soonest_start)
                    ).compact.max
                end
                def reschedule_after(date)
                  return if date.nil?
                  if leaf?
                    if start_date.nil? || start_date < date
                      self.start_date, self.due_date = date, date + duration
                      save
                    end
                  else
                    leaves.each do |leaf|
                      leaf.reschedule_after(date)
                    end
                  end
                end
                def <=>(issue)
                  if issue.nil?
                    -1
                  elsif root_id != issue.root_id
                    (root_id || 0) <=> (issue.root_id || 0)
                  else
                    (lft || 0) <=> (issue.lft || 0)
                  end
                end
                def to_s
                  "#{tracker} ##{id}: #{subject}"
                end
                # Returns a string of css classes that apply to the issue
                def css_classes
                  s = "issue status-#{status.position} priority-#{priority.position}"
                  s << ' closed' if closed?
                  s << ' overdue' if overdue?
                  s << ' child' if child?
                  s << ' parent' unless leaf?
                  s << ' private' if is_private?
                  s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                  s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                  s
                end
                # Saves an issue, time_entry, attachments, and a journal from the parameters
                # Returns false if save fails
                def save_issue_with_child_records(params, existing_time_entry=nil)
                  Issue.transaction do
                    if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                      @time_entry = existing_time_entry || TimeEntry.new
                      @time_entry.project = project
                      @time_entry.issue = self
                      @time_entry.user = User.current
                      @time_entry.spent_on = User.current.today
                      @time_entry.attributes = params[:time_entry]
                      self.time_entries << @time_entry
                    end
                    if valid?
                      attachments = Attachment.attach_files(self, params[:attachments])
                      # TODO: Rename hook
                      Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                      begin
                        if save
                          # TODO: Rename hook
                          Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                        else
                          raise ActiveRecord::Rollback
                        end
                      rescue ActiveRecord::StaleObjectError
                        attachments[:files].each(&:destroy)
                        errors.add :base, l(:notice_locking_conflict)
                        raise ActiveRecord::Rollback
                      end
                    end
                  end
                end
                # Unassigns issues from +version+ if it's no longer shared with issue's project
                def self.update_versions_from_sharing_change(version)
                  # Update issues assigned to the version
                  update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
                end
                # Unassigns issues from versions that are no longer shared
                # after +project+ was moved
                def self.update_versions_from_hierarchy_change(project)
                  moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                  # Update issues of the moved projects and issues assigned to a version of a moved project
                  Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
                end
                def parent_issue_id=(arg)
                  parent_issue_id = arg.blank? ? nil : arg.to_i
                  if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
                    @parent_issue.id
                  else
                    @parent_issue = nil
                    nil
                  end
                end
                def parent_issue_id
                  if instance_variable_defined? :@parent_issue
                    @parent_issue.nil? ? nil : @parent_issue.id
                  else
                    parent_id
                  end
                end
                # Extracted from the ReportsController.
                def self.by_tracker(project)
                  count_and_group_by(:project => project,
                                     :field => 'tracker_id',
                                     :joins => Tracker.table_name)
                end
                def self.by_version(project)
                  count_and_group_by(:project => project,
                                     :field => 'fixed_version_id',
                                     :joins => Version.table_name)
                end
                def self.by_priority(project)
                  count_and_group_by(:project => project,
                                     :field => 'priority_id',
                                     :joins => IssuePriority.table_name)
                end
                def self.by_category(project)
                  count_and_group_by(:project => project,
                                     :field => 'category_id',
                                     :joins => IssueCategory.table_name)
                end
                def self.by_assigned_to(project)
                  count_and_group_by(:project => project,
                                     :field => 'assigned_to_id',
                                     :joins => User.table_name)
                end
                def self.by_author(project)
                  count_and_group_by(:project => project,
                                     :field => 'author_id',
                                     :joins => User.table_name)
                end
                def self.by_subproject(project)
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              #{Issue.table_name}.project_id as project_id,
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                              #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                              and #{Issue.table_name}.project_id <> #{project.id}
                                                            group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
                end
                # End ReportsController extraction
                # Returns an array of projects that current user can move issues to
                def self.allowed_target_projects_on_move
                  projects = []
                  if User.current.admin?
                    # admin is allowed to move issues to any active (visible) project
                    projects = Project.visible.all
                  elsif User.current.logged?
                    if Role.non_member.allowed_to?(:move_issues)
                      projects = Project.visible.all
                    else
                      User.current.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
                    end
                  end
                  projects
                end
                private
                def update_nested_set_attributes
                  if root_id.nil?
                    # issue was just created
                    self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                    set_default_left_and_right
                    Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                    if @parent_issue
                      move_to_child_of(@parent_issue)
                    end
                    reload
                  elsif parent_issue_id != parent_id
                    former_parent_id = parent_id
                    # moving an existing issue
                    if @parent_issue && @parent_issue.root_id == root_id
                      # inside the same tree
                      move_to_child_of(@parent_issue)
                    else
                      # to another tree
                      unless root?
                        move_to_right_of(root)
                        reload
                      end
                      old_root_id = root_id
                      self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                      target_maxright = nested_set_scope.maximum(right_column_name) || 0
                      offset = target_maxright + 1 - lft
                      Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                        ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                      self[left_column_name] = lft + offset
                      self[right_column_name] = rgt + offset
                      if @parent_issue
                        move_to_child_of(@parent_issue)
                      end
                    end
                    reload
                    # delete invalid relations of all descendants
                    self_and_descendants.each do |issue|
                      issue.relations.each do |relation|
                        relation.destroy unless relation.valid?
                      end
                    end
                    # update former parent
                    recalculate_attributes_for(former_parent_id) if former_parent_id
                  end
                  remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
                end
                def update_parent_attributes
                  recalculate_attributes_for(parent_id) if parent_id
                end
                def recalculate_attributes_for(issue_id)
                  if issue_id && p = Issue.find_by_id(issue_id)
                    # priority = highest priority of children
                    if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :include => :priority)
                      p.priority = IssuePriority.find_by_position(priority_position)
                    end
                    # start/due dates = lowest/highest dates of children
                    p.start_date = p.children.minimum(:start_date)
                    p.due_date = p.children.maximum(:due_date)
                    if p.start_date && p.due_date && p.due_date < p.start_date
                      p.start_date, p.due_date = p.due_date, p.start_date
                    end
                    # done ratio = weighted average ratio of leaves
                    unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                      leaves_count = p.leaves.count
                      if leaves_count > 0
                        average = p.leaves.average(:estimated_hours).to_f
                        if average == 0
                          average = 1
                        end
                        done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :include => :status).to_f
                        progress = done / (average * leaves_count)
                        p.done_ratio = progress.round
                      end
                    end
                    # estimate = sum of leaves estimates
                    p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                    p.estimated_hours = nil if p.estimated_hours == 0.0
                    # ancestors will be recursively updated
                    p.save(false)
                  end
                end
                # Update issues so their versions are not pointing to a
                # fixed_version that is not shared with the issue's project
                def self.update_versions(conditions=nil)
                  # Only need to update issues with a fixed_version from
                  # a different project and that is not systemwide shared
                  Issue.all(:conditions => merge_conditions("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                                                              " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                                                              " AND #{Version.table_name}.sharing <> 'system'",
                                                              conditions),
                            :include => [:project, :fixed_version]
                            ).each do |issue|
                    next if issue.project.nil? || issue.fixed_version.nil?
                    unless issue.project.shared_versions.include?(issue.fixed_version)
                      issue.init_journal(User.current)
                      issue.fixed_version = nil
                      issue.save
                    end
                  end
                end
                # Callback on attachment deletion
                def attachment_added(obj)
                  if @current_journal && !obj.new_record?
                    @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
                  end
                end
                # Callback on attachment deletion
                def attachment_removed(obj)
                  journal = init_journal(User.current)
                  journal.details << JournalDetail.new(:property => 'attachment',
                                                       :prop_key => obj.id,
                                                       :old_value => obj.filename)
                  journal.save
                end
                # Default assignment based on category
                def default_assign
                  if assigned_to.nil? && category && category.assigned_to
                    self.assigned_to = category.assigned_to
                  end
                end
                # Updates start/due dates of following issues
                def reschedule_following_issues
                  if start_date_changed? || due_date_changed?
                    relations_from.each do |relation|
                      relation.set_issue_to_dates
                    end
                  end
                end
                # Closes duplicates if the issue is being closed
                def close_duplicates
                  if closing?
                    duplicates.each do |duplicate|
                      # Reload is need in case the duplicate was updated by a previous duplicate
                      duplicate.reload
                      # Don't re-close it if it's already closed
                      next if duplicate.closed?
                      # Same user and notes
                      if @current_journal
                        duplicate.init_journal(@current_journal.user, @current_journal.notes)
                      end
                      duplicate.update_attribute :status, self.status
                    end
                  end
                end
                # Saves the changes in a Journal
                # Called after_save
                def create_journal
                  if @current_journal
                    # attributes changes
                    (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
                      before = @issue_before_change.send(c)
                      after = send(c)
                      next if before == after || (before.blank? && after.blank?)
                      @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                    :prop_key => c,
                                                                    :old_value => @issue_before_change.send(c),
                                                                    :value => send(c))
                    }
                    # custom fields changes
                    custom_values.each {|c|
                      next if (@custom_values_before_change[c.custom_field_id]==c.value ||
                                (@custom_values_before_change[c.custom_field_id].blank? && c.value.blank?))
                      @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                    :prop_key => c.custom_field_id,
                                                                    :old_value => @custom_values_before_change[c.custom_field_id],
                                                                    :value => c.value)
                    }
                    @current_journal.save
                    # reset current journal
                    init_journal @current_journal.user, @current_journal.notes
                  end
                end
                # Query generator for selecting groups of issue counts for a project
                # based on specific criteria
                #
                # Options
                # * project - Project to search in.
                # * field - String. Issue field to key off of in the grouping.
                # * joins - String. The table name to join against.
                def self.count_and_group_by(options)
                  project = options.delete(:project)
                  select_field = options.delete(:field)
                  joins = options.delete(:joins)
                  where = "#{Issue.table_name}.#{select_field}=j.id"
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              j.id as #{select_field},
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                                #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{where}
                                                              and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project)}
                                                            group by s.id, s.is_closed, j.id")
                end
              end

app/views/issues/_attributes.html.erb +23 -4

              <% labelled_fields_for :issue, @issue do |f| %>
              <div class="splitcontentleft">
-             <% if @issue.new_record? || @allowed_statuses.any? %>
+             <% if @issue.safe_attribute? 'status_id'  %>
              <p><%= f.select :status_id, (@allowed_statuses.collect {|p| [p.name, p.id]}), :required => true %></p>
              <% else %>
              <p><label><%= l(:field_status) %></label> <%= h(@issue.status.name) %></p>
              <% end %>
+             <% if @issue.safe_attribute? 'priority_id' %>
              <p><%= f.select :priority_id, (@priorities.collect {|p| [p.name, p.id]}), {:required => true}, :disabled => !@issue.leaf? %></p>
+             <% end %>
+             <% if @issue.safe_attribute? 'assigned_to_id' %>
              <p><%= f.select :assigned_to_id, principals_options_for_select(@issue.assignable_users, @issue.assigned_to), :include_blank => true %></p>
-             <% unless @project.issue_categories.empty? %>
+             <% end %>
+             <% if @issue.safe_attribute?('category_id') && @project.issue_categories.any? %>
              <p><%= f.select :category_id, (@project.issue_categories.collect {|c| [c.name, c.id]}), :include_blank => true %>
              <%= prompt_to_remote(image_tag('add.png', :style => 'vertical-align: middle;'),
                                   l(:label_issue_category_new),
                                   'issue_category[name]',
                                   {:controller => 'issue_categories', :action => 'create', :project_id => @project},
                                   :title => l(:label_issue_category_new),
                                   :tabindex => 199) if authorize_for('issue_categories', 'new') %></p>
              <% end %>
-             <% unless @issue.assignable_versions.empty? %>
+             <% if @issue.safe_attribute?('fixed_version_id') && @issue.assignable_versions.any? %>
              <p><%= f.select :fixed_version_id, version_options_for_select(@issue.assignable_versions, @issue.fixed_version), :include_blank => true %>
              <%= prompt_to_remote(image_tag('add.png', :style => 'vertical-align: middle;'),
                                   l(:label_version_new),
                                   'version[name]',
                                   {:controller => 'versions', :action => 'create', :project_id => @project},
                                   :title => l(:label_version_new),
                                   :tabindex => 200) if authorize_for('versions', 'new') %>
              </p>
              <% end %>
              </div>
              <div class="splitcontentright">
              <% if @issue.safe_attribute? 'parent_issue_id' %>
              <p id="parent_issue"><%= f.text_field :parent_issue_id, :size => 10 %></p>
              <div id="parent_issue_candidates" class="autocomplete"></div>
              <%= javascript_tag "observeParentIssueField('#{auto_complete_issues_path(:id => @issue, :project_id => @project) }')" %>
              <% end %>
+             <% if @issue.safe_attribute? 'start_date' %>
              <p><%= f.text_field :start_date, :size => 10, :disabled => !@issue.leaf? %><%= calendar_for('issue_start_date') if @issue.leaf? %></p>
+             <% end %>
+             <% if @issue.safe_attribute? 'due_date' %>
              <p><%= f.text_field :due_date, :size => 10, :disabled => !@issue.leaf? %><%= calendar_for('issue_due_date') if @issue.leaf? %></p>
+             <% end %>
+             <% if @issue.safe_attribute? 'estimated_hours' %>
              <p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf? %> <%= l(:field_hours) %></p>
-             <% if @issue.leaf? && Issue.use_field_for_done_ratio? %>
+             <% end %>
+             <% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>
              <p><%= f.select :done_ratio, ((0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %></p>
              <% end %>
              </div>
              <div style="clear:both;"> </div>
+             <% if @issue.safe_attribute? 'custom_field_values' %>
              <%= render :partial => 'issues/form_custom_fields' %>
+             <% end %>
              <% end %>

app/views/issues/_edit.html.erb +1 -1

              <% labelled_form_for @issue, :html => {:id => 'issue-form', :multipart => true} do |f| %>
                  <%= error_messages_for 'issue', 'time_entry' %>
                  <div class="box">
                  <% if @edit_allowed || !@allowed_statuses.empty? %>
                      <fieldset class="tabular"><legend><%= l(:label_change_properties) %></legend>
-                     <%= render :partial => (@edit_allowed ? 'form' : 'form_update'), :locals => {:f => f} %>
+                     <%= render :partial => 'form', :locals => {:f => f} %>
                      </fieldset>
                  <% end %>
                  <% if User.current.allowed_to?(:log_time, @project) %>
                      <fieldset class="tabular"><legend><%= l(:button_log_time) %></legend>
                      <% labelled_fields_for :time_entry, @time_entry do |time_entry| %>
                      <div class="splitcontentleft">
                      <p><%= time_entry.text_field :hours, :size => 6, :label => :label_spent_time %> <%= l(:field_hours) %></p>
                      </div>
                      <div class="splitcontentright">
                      <p><%= time_entry.select :activity_id, activity_collection_for_select_options %></p>
                      </div>
                      <p><%= time_entry.text_field :comments, :size => 60 %></p>
                      <% @time_entry.custom_field_values.each do |value| %>
                        <p><%= custom_field_tag_with_label :time_entry, value %></p>
                      <% end %>
                      <% end %>
                  </fieldset>
                  <% end %>
                  <fieldset><legend><%= l(:field_notes) %></legend>
                  <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
                  <%= wikitoolbar_for 'notes' %>
                  <%= call_hook(:view_issues_edit_notes_bottom, { :issue => @issue, :notes => @notes, :form => f }) %>
                  <p><%=l(:label_attachment_plural)%><br /><%= render :partial => 'attachments/form' %></p>
                  </fieldset>
                  </div>
                  <%= f.hidden_field :lock_version %>
                  <%= submit_tag l(:button_submit) %>
                  <%= link_to_remote l(:label_preview),
                                     { :url => preview_issue_path(:project_id => @project, :id => @issue),
                                       :method => 'post',
                                       :update => 'preview',
                                       :with => 'Form.serialize("issue-form")',
                                       :complete => "Element.scrollTo('preview')"
                                     }, :accesskey => accesskey(:preview) %>
              <% end %>
              <div id="preview" class="wiki"></div>

app/views/issues/_form.html.erb +9 -2

              <%= call_hook(:view_issues_form_details_top, { :issue => @issue, :form => f }) %>
              <% if @issue.safe_attribute? 'is_private' %>
              <p style="float:right; margin-right:1em;">
                <label class="inline" for="issue_is_private" id="issue_is_private_label"><%= f.check_box :is_private, :no_label => true %> <%= l(:field_is_private) %></label>
              </p>
              <% end %>
+             <% if @issue.safe_attribute? 'tracker_id' %>
              <p><%= f.select :tracker_id, @project.trackers.collect {|t| [t.name, t.id]}, :required => true %></p>
              <%= observe_field :issue_tracker_id, :url => project_issue_form_path(@project, :id => @issue),
                                                   :update => :attributes,
                                                   :with => "Form.serialize('issue-form')" %>
+             <% end %>
+             <% if @issue.safe_attribute? 'subject' %>
              <p><%= f.text_field :subject, :size => 80, :required => true %></p>
+             <% end %>
+             <% if @issue.safe_attribute? 'description' %>
              <p>
                <label><%= l(:field_description) %></label>
                <%= link_to_function image_tag('edit.png'),
                  'Element.hide(this); Effect.toggle("issue_description_and_toolbar", "appear", {duration:0.3})' unless @issue.new_record? %>
                <% content_tag 'span', :id => "issue_description_and_toolbar", :style => (@issue.new_record? ? nil : 'display:none') do %>
                  <%= f.text_area :description,
                                 :cols => 60,
                                 :rows => (@issue.description.blank? ? 10 : [[10, @issue.description.length / 50].max, 100].min),
                                 :accesskey => accesskey(:edit),
                                 :class => 'wiki-edit',
                                 :no_label => true %>
                <% end %>
              </p>
+             <%= wikitoolbar_for 'issue_description' %>
+             <% end %>
              <div id="attributes" class="attributes">
                <%= render :partial => 'issues/attributes' %>
              </div>
              <%= call_hook(:view_issues_form_details_bottom, { :issue => @issue, :form => f }) %>
-             <%= wikitoolbar_for 'issue_description' %>

test/functional/issues_controller_test.rb +128 -2

              # Redmine - project management software
              # Copyright (C) 2006-2011  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              require 'issues_controller'
              class IssuesControllerTest < ActionController::TestCase
                fixtures :projects,
                         :users,
                         :roles,
                         :members,
                         :member_roles,
                         :issues,
                         :issue_statuses,
                         :versions,
                         :trackers,
                         :projects_trackers,
                         :issue_categories,
                         :enabled_modules,
                         :enumerations,
                         :attachments,
                         :workflows,
                         :custom_fields,
                         :custom_values,
                         :custom_fields_projects,
                         :custom_fields_trackers,
                         :time_entries,
                         :journals,
                         :journal_details,
                         :queries
                include Redmine::I18n
                def setup
                  @controller = IssuesController.new
                  @request    = ActionController::TestRequest.new
                  @response   = ActionController::TestResponse.new
                  User.current = nil
                end
                def test_index
                  Setting.default_language = 'en'
                  get :index
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:project)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  # private projects hidden
                  assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                  assert_no_tag :tag => 'a', :content => /Issue on project 2/
                  # project column
                  assert_tag :tag => 'th', :content => /Project/
                end
                def test_index_should_not_list_issues_when_module_disabled
                  EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
                  get :index
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:project)
                  assert_no_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                end
                def test_index_should_list_visible_issues_only
                  get :index, :per_page => 100
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:issues).detect {|issue| !issue.visible?}
                end
                def test_index_with_project
                  Setting.display_subprojects_issues = 0
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_no_tag :tag => 'a', :content => /Subproject issue/
                end
                def test_index_with_project_and_subprojects
                  Setting.display_subprojects_issues = 1
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                end
                def test_index_with_project_and_subprojects_should_show_private_subprojects
                  @request.session[:user_id] = 2
                  Setting.display_subprojects_issues = 1
                  get :index, :project_id => 1
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_tag :tag => 'a', :content => /Can't print recipes/
                  assert_tag :tag => 'a', :content => /Subproject issue/
                  assert_tag :tag => 'a', :content => /Issue of a private subproject/
                end
                def test_index_with_project_and_default_filter
                  get :index, :project_id => 1, :set_filter => 1
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  query = assigns(:query)
                  assert_not_nil query
                  # default filter
                  assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
                end
                def test_index_with_project_and_filter
                  get :index, :project_id => 1, :set_filter => 1,
                    :f => ['tracker_id'],
                    :op => {'tracker_id' => '='},
                    :v => {'tracker_id' => ['1']}
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  query = assigns(:query)
                  assert_not_nil query
                  assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
                end
                def test_index_with_short_filters
                  to_test = {
                    'status_id' => {
                      'o' => { :op => 'o', :values => [''] },
                      'c' => { :op => 'c', :values => [''] },
                      '7' => { :op => '=', :values => ['7'] },
                      '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
                      '=7' => { :op => '=', :values => ['7'] },
                      '!3' => { :op => '!', :values => ['3'] },
                      '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
                    'subject' => {
                      'This is a subject' => { :op => '=', :values => ['This is a subject'] },
                      'o' => { :op => '=', :values => ['o'] },
                      '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
                      '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
                    'tracker_id' => {
                      '3' => { :op => '=', :values => ['3'] },
                      '=3' => { :op => '=', :values => ['3'] }},
                    'start_date' => {
                      '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
                      '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
                      '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
                      '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
                      '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
                      '<t+2' => { :op => '<t+', :values => ['2'] },
                      '>t+2' => { :op => '>t+', :values => ['2'] },
                      't+2' => { :op => 't+', :values => ['2'] },
                      't' => { :op => 't', :values => [''] },
                      'w' => { :op => 'w', :values => [''] },
                      '>t-2' => { :op => '>t-', :values => ['2'] },
                      '<t-2' => { :op => '<t-', :values => ['2'] },
                      't-2' => { :op => 't-', :values => ['2'] }},
                    'created_on' => {
                      '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
                      '<t+2' => { :op => '=', :values => ['<t+2'] },
                      '>t+2' => { :op => '=', :values => ['>t+2'] },
                      't+2' => { :op => 't', :values => ['+2'] }},
                    'cf_1' => {
                      'c' => { :op => '=', :values => ['c'] },
                      '!c' => { :op => '!', :values => ['c'] },
                      '!*' => { :op => '!*', :values => [''] },
                      '*' => { :op => '*', :values => [''] }},
                    'estimated_hours' => {
                      '=13.4' => { :op => '=', :values => ['13.4'] },
                      '>=45' => { :op => '>=', :values => ['45'] },
                      '<=125' => { :op => '<=', :values => ['125'] },
                      '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
                      '!*' => { :op => '!*', :values => [''] },
                      '*' => { :op => '*', :values => [''] }}
                  }
                  default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
                  to_test.each do |field, expression_and_expected|
                    expression_and_expected.each do |filter_expression, expected|
                      get :index, :set_filter => 1, field => filter_expression
                      assert_response :success
                      assert_template 'index'
                      assert_not_nil assigns(:issues)
                      query = assigns(:query)
                      assert_not_nil query
                      assert query.has_filter?(field)
                      assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
                    end
                  end
                end
                def test_index_with_project_and_empty_filters
                  get :index, :project_id => 1, :set_filter => 1, :fields => ['']
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  query = assigns(:query)
                  assert_not_nil query
                  # no filter
                  assert_equal({}, query.filters)
                end
                def test_index_with_query
                  get :index, :project_id => 1, :query_id => 5
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_nil assigns(:issue_count_by_group)
                end
                def test_index_with_query_grouped_by_tracker
                  get :index, :project_id => 1, :query_id => 6
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                end
                def test_index_with_query_grouped_by_list_custom_field
                  get :index, :project_id => 1, :query_id => 9
                  assert_response :success
                  assert_template 'index'
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                end
                def test_index_with_query_id_and_project_id_should_set_session_query
                  get :index, :project_id => 1, :query_id => 4
                  assert_response :success
                  assert_kind_of Hash, session[:query]
                  assert_equal 4, session[:query][:id]
                  assert_equal 1, session[:query][:project_id]
                end
                def test_index_with_cross_project_query_in_session_should_show_project_issues
                  q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
                  @request.session[:query] = {:id => q.id, :project_id => 1}
                  with_settings :display_subprojects_issues => '0' do
                    get :index, :project_id => 1
                  end
                  assert_response :success
                  assert_not_nil assigns(:query)
                  assert_equal q.id, assigns(:query).id
                  assert_equal 1, assigns(:query).project_id
                  assert_equal [1], assigns(:issues).map(&:project_id).uniq
                end
                def test_private_query_should_not_be_available_to_other_users
                  q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
                  @request.session[:user_id] = 3
                  get :index, :query_id => q.id
                  assert_response 403
                end
                def test_private_query_should_be_available_to_its_user
                  q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
                  @request.session[:user_id] = 2
                  get :index, :query_id => q.id
                  assert_response :success
                end
                def test_public_query_should_be_available_to_other_users
                  q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
                  @request.session[:user_id] = 3
                  get :index, :query_id => q.id
                  assert_response :success
                end
                def test_index_csv
                  get :index, :format => 'csv'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                  assert @response.body.starts_with?("#,")
                  lines = @response.body.chomp.split("\n")
                  assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
                end
                def test_index_csv_with_project
                  get :index, :project_id => 1, :format => 'csv'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                end
                def test_index_csv_with_description
                  get :index, :format => 'csv', :description => '1'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                  assert @response.body.starts_with?("#,")
                  lines = @response.body.chomp.split("\n")
                  assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
                end
                def test_index_csv_with_all_columns
                  get :index, :format => 'csv', :columns => 'all'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_equal 'text/csv', @response.content_type
                  assert @response.body.starts_with?("#,")
                  lines = @response.body.chomp.split("\n")
                  assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
                end
                def test_index_csv_big_5
                  with_settings :default_language => "zh-TW" do
                    str_utf8  = "\xe4\xb8\x80\xe6\x9c\x88"
                    str_big5  = "\xa4@\xa4\xeb"
                    if str_utf8.respond_to?(:force_encoding)
                      str_utf8.force_encoding('UTF-8')
                      str_big5.force_encoding('Big5')
                    end
                    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                      :status_id => 1, :priority => IssuePriority.all.first,
                                      :subject => str_utf8)
                    assert issue.save
                    get :index, :project_id => 1,
                                :f => ['subject'],
                                :op => '=', :values => [str_utf8],
                                :format => 'csv'
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
                    s1 = "\xaa\xac\xbaA"
                    if str_utf8.respond_to?(:force_encoding)
                      s1.force_encoding('Big5')
                    end
                    assert lines[0].include?(s1)
                    assert lines[1].include?(str_big5)
                  end
                end
                def test_index_csv_cannot_convert_should_be_replaced_big_5
                  with_settings :default_language => "zh-TW" do
                    str_utf8  = "\xe4\xbb\xa5\xe5\x86\x85"
                    if str_utf8.respond_to?(:force_encoding)
                      str_utf8.force_encoding('UTF-8')
                    end
                    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                      :status_id => 1, :priority => IssuePriority.all.first,
                                      :subject => str_utf8)
                    assert issue.save
                    get :index, :project_id => 1,
                                :f => ['subject'],
                                :op => '=', :values => [str_utf8],
                                :c => ['status', 'subject'],
                                :format => 'csv',
                                :set_filter => 1
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
                    s1 = "\xaa\xac\xbaA" # status
                    if str_utf8.respond_to?(:force_encoding)
                      s1.force_encoding('Big5')
                    end
                    assert lines[0].include?(s1)
                    s2 = lines[1].split(",")[2]
                    if s1.respond_to?(:force_encoding)
                      s3 = "\xa5H?" # subject
                      s3.force_encoding('Big5')
                      assert_equal s3, s2
                    elsif RUBY_PLATFORM == 'java'
                      assert_equal "??", s2
                    else
                      assert_equal "\xa5H???", s2
                    end
                  end
                end
                def test_index_csv_tw
                  with_settings :default_language => "zh-TW" do
                    str1  = "test_index_csv_tw"
                    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                      :status_id => 1, :priority => IssuePriority.all.first,
                                      :subject => str1, :estimated_hours => '1234.5')
                    assert issue.save
                    assert_equal 1234.5, issue.estimated_hours
                    get :index, :project_id => 1,
                                :f => ['subject'],
                                :op => '=', :values => [str1],
                                :c => ['estimated_hours', 'subject'],
                                :format => 'csv',
                                :set_filter => 1
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
                    assert_equal "#{issue.id},1234.5,#{str1}", lines[1]
                    str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
                    if str_tw.respond_to?(:force_encoding)
                      str_tw.force_encoding('UTF-8')
                    end
                    assert_equal str_tw, l(:general_lang_name)
                    assert_equal ',', l(:general_csv_separator)
                    assert_equal '.', l(:general_csv_decimal_separator)
                  end
                end
                def test_index_csv_fr
                  with_settings :default_language => "fr" do
                    str1  = "test_index_csv_fr"
                    issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                      :status_id => 1, :priority => IssuePriority.all.first,
                                      :subject => str1, :estimated_hours => '1234.5')
                    assert issue.save
                    assert_equal 1234.5, issue.estimated_hours
                    get :index, :project_id => 1,
                                :f => ['subject'],
                                :op => '=', :values => [str1],
                                :c => ['estimated_hours', 'subject'],
                                :format => 'csv',
                                :set_filter => 1
                    assert_equal 'text/csv', @response.content_type
                    lines = @response.body.chomp.split("\n")
                    assert_equal "#{issue.id};1234,5;#{str1}", lines[1]
                    str_fr = "Fran\xc3\xa7ais"
                    if str_fr.respond_to?(:force_encoding)
                      str_fr.force_encoding('UTF-8')
                    end
                    assert_equal str_fr, l(:general_lang_name)
                    assert_equal ';', l(:general_csv_separator)
                    assert_equal ',', l(:general_csv_decimal_separator)
                  end
                end
                def test_index_pdf
                  ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
                    with_settings :default_language => lang do
                      get :index
                      assert_response :success
                      assert_template 'index'
                      if lang == "ja"
                        if RUBY_PLATFORM != 'java'
                          assert_equal "CP932", l(:general_pdf_encoding)
                        end
                        if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
                          next
                        end
                      end
                      get :index, :format => 'pdf'
                      assert_response :success
                      assert_not_nil assigns(:issues)
                      assert_equal 'application/pdf', @response.content_type
                      get :index, :project_id => 1, :format => 'pdf'
                      assert_response :success
                      assert_not_nil assigns(:issues)
                      assert_equal 'application/pdf', @response.content_type
                      get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
                      assert_response :success
                      assert_not_nil assigns(:issues)
                      assert_equal 'application/pdf', @response.content_type
                    end
                  end
                end
                def test_index_pdf_with_query_grouped_by_list_custom_field
                  get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
                  assert_response :success
                  assert_not_nil assigns(:issues)
                  assert_not_nil assigns(:issue_count_by_group)
                  assert_equal 'application/pdf', @response.content_type
                end
                def test_index_sort
                  get :index, :sort => 'tracker,id:desc'
                  assert_response :success
                  sort_params = @request.session['issues_index_sort']
                  assert sort_params.is_a?(String)
                  assert_equal 'tracker,id:desc', sort_params
                  issues = assigns(:issues)
                  assert_not_nil issues
                  assert !issues.empty?
                  assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
                end
                def test_index_sort_by_field_not_included_in_columns
                  Setting.issue_list_default_columns = %w(subject author)
                  get :index, :sort => 'tracker'
                end
                def test_index_sort_by_assigned_to
                  get :index, :sort => 'assigned_to'
                  assert_response :success
                  assignees = assigns(:issues).collect(&:assigned_to).compact
                  assert_equal assignees.sort, assignees
                end
                def test_index_sort_by_assigned_to_desc
                  get :index, :sort => 'assigned_to:desc'
                  assert_response :success
                  assignees = assigns(:issues).collect(&:assigned_to).compact
                  assert_equal assignees.sort.reverse, assignees
                end
                def test_index_group_by_assigned_to
                  get :index, :group_by => 'assigned_to', :sort => 'priority'
                  assert_response :success
                end
                def test_index_sort_by_author
                  get :index, :sort => 'author'
                  assert_response :success
                  authors = assigns(:issues).collect(&:author)
                  assert_equal authors.sort, authors
                end
                def test_index_sort_by_author_desc
                  get :index, :sort => 'author:desc'
                  assert_response :success
                  authors = assigns(:issues).collect(&:author)
                  assert_equal authors.sort.reverse, authors
                end
                def test_index_group_by_author
                  get :index, :group_by => 'author', :sort => 'priority'
                  assert_response :success
                end
                def test_index_sort_by_spent_hours
                  get :index, :sort => 'spent_hours:desc'
                  assert_response :success
                  hours = assigns(:issues).collect(&:spent_hours)
                  assert_equal hours.sort.reverse, hours
                end
                def test_index_with_columns
                  columns = ['tracker', 'subject', 'assigned_to']
                  get :index, :set_filter => 1, :c => columns
                  assert_response :success
                  # query should use specified columns
                  query = assigns(:query)
                  assert_kind_of Query, query
                  assert_equal columns, query.column_names.map(&:to_s)
                  # columns should be stored in session
                  assert_kind_of Hash, session[:query]
                  assert_kind_of Array, session[:query][:column_names]
                  assert_equal columns, session[:query][:column_names].map(&:to_s)
                  # ensure only these columns are kept in the selected columns list
                  assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
                                               :children => { :count => 3 }
                  assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
                                                  :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
                end
                def test_index_without_project_should_implicitly_add_project_column_to_default_columns
                  Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
                  get :index, :set_filter => 1
                  # query should use specified columns
                  query = assigns(:query)
                  assert_kind_of Query, query
                  assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
                end
                def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
                  Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
                  columns = ['tracker', 'subject', 'assigned_to']
                  get :index, :set_filter => 1, :c => columns
                  # query should use specified columns
                  query = assigns(:query)
                  assert_kind_of Query, query
                  assert_equal columns.map(&:to_sym), query.columns.map(&:name)
                end
                def test_index_with_custom_field_column
                  columns = %w(tracker subject cf_2)
                  get :index, :set_filter => 1, :c => columns
                  assert_response :success
                  # query should use specified columns
                  query = assigns(:query)
                  assert_kind_of Query, query
                  assert_equal columns, query.column_names.map(&:to_s)
                  assert_tag :td,
                    :attributes => {:class => 'cf_2 string'},
                    :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
                end
                def test_index_with_date_column
                  Issue.find(1).update_attribute :start_date, '1987-08-24'
                  with_settings :date_format => '%d/%m/%Y' do
                    get :index, :set_filter => 1, :c => %w(start_date)
                    assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
                  end
                end
                def test_index_with_done_ratio
                  Issue.find(1).update_attribute :done_ratio, 40
                  get :index, :set_filter => 1, :c => %w(done_ratio)
                  assert_tag 'td', :attributes => {:class => /done_ratio/},
                    :child => {:tag => 'table', :attributes => {:class => 'progress'},
                      :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
                    }
                end
                def test_index_with_spent_hours_column
                  get :index, :set_filter => 1, :c => %w(subject spent_hours)
                  assert_tag 'tr', :attributes => {:id => 'issue-3'},
                    :child => {
                      :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
                    }
                end
                def test_index_should_not_show_spent_hours_column_without_permission
                  Role.anonymous.remove_permission! :view_time_entries
                  get :index, :set_filter => 1, :c => %w(subject spent_hours)
                  assert_no_tag 'td', :attributes => {:class => /spent_hours/}
                end
                def test_index_with_fixed_version
                  get :index, :set_filter => 1, :c => %w(fixed_version)
                  assert_tag 'td', :attributes => {:class => /fixed_version/},
                    :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
                end
                def test_index_send_html_if_query_is_invalid
                  get :index, :f => ['start_date'], :op => {:start_date => '='}
                  assert_equal 'text/html', @response.content_type
                  assert_template 'index'
                end
                def test_index_send_nothing_if_query_is_invalid
                  get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
                  assert_equal 'text/csv', @response.content_type
                  assert @response.body.blank?
                end
                def test_show_by_anonymous
                  get :show, :id => 1
                  assert_response :success
                  assert_template 'show'
                  assert_not_nil assigns(:issue)
                  assert_equal Issue.find(1), assigns(:issue)
                  # anonymous role is allowed to add a note
                  assert_tag :tag => 'form',
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Notes/ } }
                  assert_tag :tag => 'title',
                    :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
                end
                def test_show_by_manager
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_response :success
                  assert_tag :tag => 'a',
                    :content => /Quote/
                  assert_tag :tag => 'form',
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Change properties/ } },
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Log time/ } },
                             :descendant => { :tag => 'fieldset',
                                              :child => { :tag => 'legend',
                                                          :content => /Notes/ } }
                end
+               def test_show_should_display_update_form
+                 @request.session[:user_id] = 2
+                 get :show, :id => 1
+                 assert_response :success
+                 assert_tag 'form', :attributes => {:id => 'issue-form'}
+                 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
+                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
+                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
+                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
+                 assert_tag 'textarea', :attributes => {:name => 'notes'}
+               end
+               def test_show_should_display_update_form_with_minimal_permissions
+                 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
+                 Workflow.delete_all :role_id => 1
+                 @request.session[:user_id] = 2
+                 get :show, :id => 1
+                 assert_response :success
+                 assert_tag 'form', :attributes => {:id => 'issue-form'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
+                 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
+                 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
+                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
+                 assert_tag 'textarea', :attributes => {:name => 'notes'}
+               end
+               def test_show_should_display_update_form_with_workflow_permissions
+                 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
+                 @request.session[:user_id] = 2
+                 get :show, :id => 1
+                 assert_response :success
+                 assert_tag 'form', :attributes => {:id => 'issue-form'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
+                 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
+                 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
+                 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
+                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
+                 assert_tag 'textarea', :attributes => {:name => 'notes'}
+               end
+               def test_show_should_not_display_update_form_without_permissions
+                 Role.find(1).update_attribute :permissions, [:view_issues]
+                 @request.session[:user_id] = 2
+                 get :show, :id => 1
+                 assert_response :success
+                 assert_no_tag 'form', :attributes => {:id => 'issue-form'}
+               end
                def test_update_form_should_not_display_inactive_enumerations
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_response :success
                  assert ! IssuePriority.find(15).active?
                  assert_no_tag :option, :attributes => {:value => '15'},
                                         :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
                end
                def test_update_form_should_allow_attachment_upload
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_tag :tag => 'form',
                    :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
                    :descendant => {
                      :tag => 'input',
                      :attributes => {:type => 'file', :name => 'attachments[1][file]'}
                    }
                end
                def test_show_should_deny_anonymous_access_without_permission
                  Role.anonymous.remove_permission!(:view_issues)
                  get :show, :id => 1
                  assert_response :redirect
                end
                def test_show_should_deny_anonymous_access_to_private_issue
                  Issue.update_all(["is_private = ?", true], "id = 1")
                  get :show, :id => 1
                  assert_response :redirect
                end
                def test_show_should_deny_non_member_access_without_permission
                  Role.non_member.remove_permission!(:view_issues)
                  @request.session[:user_id] = 9
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_deny_non_member_access_to_private_issue
                  Issue.update_all(["is_private = ?", true], "id = 1")
                  @request.session[:user_id] = 9
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_deny_member_access_without_permission
                  Role.find(1).remove_permission!(:view_issues)
                  @request.session[:user_id] = 2
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_deny_member_access_to_private_issue_without_permission
                  Issue.update_all(["is_private = ?", true], "id = 1")
                  @request.session[:user_id] = 3
                  get :show, :id => 1
                  assert_response 403
                end
                def test_show_should_allow_author_access_to_private_issue
                  Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
                  @request.session[:user_id] = 3
                  get :show, :id => 1
                  assert_response :success
                end
                def test_show_should_allow_assignee_access_to_private_issue
                  Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
                  @request.session[:user_id] = 3
                  get :show, :id => 1
                  assert_response :success
                end
                def test_show_should_allow_member_access_to_private_issue_with_permission
                  Issue.update_all(["is_private = ?", true], "id = 1")
                  User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
                  @request.session[:user_id] = 3
                  get :show, :id => 1
                  assert_response :success
                end
                def test_show_should_not_disclose_relations_to_invisible_issues
                  Setting.cross_project_issue_relations = '1'
                  IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
                  # Relation to a private project issue
                  IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
                  get :show, :id => 1
                  assert_response :success
                  assert_tag :div, :attributes => { :id => 'relations' },
                                   :descendant => { :tag => 'a', :content => /#2$/ }
                  assert_no_tag :div, :attributes => { :id => 'relations' },
                                      :descendant => { :tag => 'a', :content => /#4$/ }
                end
                def test_show_should_list_subtasks
                  Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
                  get :show, :id => 1
                  assert_response :success
                  assert_tag 'div', :attributes => {:id => 'issue_tree'},
                    :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
                end
                def test_show_should_list_parents
                  issue = Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
                  get :show, :id => issue.id
                  assert_response :success
                  assert_tag 'div', :attributes => {:class => 'subject'},
                    :descendant => {:tag => 'h3', :content => 'Child Issue'}
                  assert_tag 'div', :attributes => {:class => 'subject'},
                    :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
                end
                def test_show_atom
                  get :show, :id => 2, :format => 'atom'
                  assert_response :success
                  assert_template 'journals/index'
                  # Inline image
                  assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
                end
                def test_show_export_to_pdf
                  get :show, :id => 3, :format => 'pdf'
                  assert_response :success
                  assert_equal 'application/pdf', @response.content_type
                  assert @response.body.starts_with?('%PDF')
                  assert_not_nil assigns(:issue)
                end
                def test_get_new
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :tracker_id => 1
                  assert_response :success
                  assert_template 'new'
-                 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
-                                                              :value => 'Default string' }
+                 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
+                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
+                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
+                 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
                  # Be sure we don't display inactive IssuePriorities
                  assert ! IssuePriority.find(15).active?
                  assert_no_tag :option, :attributes => {:value => '15'},
                                         :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
                end
+               def test_get_new_with_minimal_permissions
+                 Role.find(1).update_attribute :permissions, [:add_issues]
+                 Workflow.delete_all :role_id => 1
+                 @request.session[:user_id] = 2
+                 get :new, :project_id => 1, :tracker_id => 1
+                 assert_response :success
+                 assert_template 'new'
+                 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
+                 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
+                 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
+                 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
+                 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
+                 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
+                 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
+               end
                def test_get_new_without_default_start_date_is_creation_date
                  Setting.default_issue_start_date_to_creation_date = 0
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :tracker_id => 1
                  assert_response :success
                  assert_template 'new'
                  assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
                                                               :value => nil }
                end
                def test_get_new_with_default_start_date_is_creation_date
                  Setting.default_issue_start_date_to_creation_date = 1
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :tracker_id => 1
                  assert_response :success
                  assert_template 'new'
                  assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
                                                               :value => Date.today.to_s }
                end
                def test_get_new_form_should_allow_attachment_upload
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :tracker_id => 1
                  assert_tag :tag => 'form',
                    :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
                    :descendant => {
                      :tag => 'input',
                      :attributes => {:type => 'file', :name => 'attachments[1][file]'}
                    }
                end
                def test_get_new_without_tracker_id
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1
                  assert_response :success
                  assert_template 'new'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal Project.find(1).trackers.first, issue.tracker
                end
                def test_get_new_with_no_default_status_should_display_an_error
                  @request.session[:user_id] = 2
                  IssueStatus.delete_all
                  get :new, :project_id => 1
                  assert_response 500
                  assert_error_tag :content => /No default issue/
                end
                def test_get_new_with_no_tracker_should_display_an_error
                  @request.session[:user_id] = 2
                  Tracker.delete_all
                  get :new, :project_id => 1
                  assert_response 500
                  assert_error_tag :content => /No tracker/
                end
                def test_update_new_form
                  @request.session[:user_id] = 2
                  xhr :post, :new, :project_id => 1,
                                   :issue => {:tracker_id => 2,
                                              :subject => 'This is the test_new issue',
                                              :description => 'This is the description',
                                              :priority_id => 5}
                  assert_response :success
                  assert_template 'attributes'
                  issue = assigns(:issue)
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.project_id
                  assert_equal 2, issue.tracker_id
                  assert_equal 'This is the test_new issue', issue.subject
                end
                def test_post_create
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :status_id => 2,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :start_date => '2010-11-07',
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  issue = Issue.find_by_subject('This is the test_new issue')
                  assert_not_nil issue
                  assert_equal 2, issue.author_id
                  assert_equal 3, issue.tracker_id
                  assert_equal 2, issue.status_id
                  assert_equal Date.parse('2010-11-07'), issue.start_date
                  assert_nil issue.estimated_hours
                  v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
                  assert_not_nil v
                  assert_equal 'Value for field 2', v.value
                end
                def test_post_new_with_group_assignment
                  group = Group.find(11)
                  project = Project.find(1)
                  project.members << Member.new(:principal => group, :roles => [Role.first])
                  with_settings :issue_group_assignment => '1' do
                    @request.session[:user_id] = 2
                    assert_difference 'Issue.count' do
                      post :create, :project_id => project.id,
                                    :issue => {:tracker_id => 3,
                                               :status_id => 1,
                                               :subject => 'This is the test_new_with_group_assignment issue',
                                               :assigned_to_id => group.id}
                    end
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
                  assert_not_nil issue
                  assert_equal group, issue.assigned_to
                end
                def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
                  Setting.default_issue_start_date_to_creation_date = 0
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :status_id => 2,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  issue = Issue.find_by_subject('This is the test_new issue')
                  assert_not_nil issue
                  assert_nil issue.start_date
                end
                def test_post_create_without_start_date_and_default_start_date_is_creation_date
                  Setting.default_issue_start_date_to_creation_date = 1
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :status_id => 2,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  issue = Issue.find_by_subject('This is the test_new issue')
                  assert_not_nil issue
                  assert_equal Date.today, issue.start_date
                end
                def test_post_create_and_continue
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                      :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
                      :continue => ''
                  end
                  issue = Issue.first(:order => 'id DESC')
                  assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
                  assert_not_nil flash[:notice], "flash was not set"
                  assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
                end
                def test_post_create_without_custom_fields_param
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                end
                def test_post_create_with_required_custom_field_and_without_custom_fields_param
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  @request.session[:user_id] = 2
                  post :create, :project_id => 1,
                             :issue => {:tracker_id => 1,
                                        :subject => 'This is the test_new issue',
                                        :description => 'This is the description',
                                        :priority_id => 5}
                  assert_response :success
                  assert_template 'new'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal I18n.translate('activerecord.errors.messages.invalid'),
                               issue.errors[:custom_values].to_s
                end
                def test_post_create_with_watchers
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  assert_difference 'Watcher.count', 2 do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a new issue with watchers',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :watcher_user_ids => ['2', '3']}
                  end
                  issue = Issue.find_by_subject('This is a new issue with watchers')
                  assert_not_nil issue
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
                  # Watchers added
                  assert_equal [2, 3], issue.watcher_user_ids.sort
                  assert issue.watched_by?(User.find(3))
                  # Watchers notified
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
                end
                def test_post_create_subissue
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a child issue',
                                          :parent_issue_id => 2}
                  end
                  issue = Issue.find_by_subject('This is a child issue')
                  assert_not_nil issue
                  assert_equal Issue.find(2), issue.parent
                end
                def test_post_create_subissue_with_non_numeric_parent_id
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a child issue',
                                          :parent_issue_id => 'ABC'}
                  end
                  issue = Issue.find_by_subject('This is a child issue')
                  assert_not_nil issue
                  assert_nil issue.parent
                end
                def test_post_create_private
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a private issue',
                                          :is_private => '1'}
                  end
                  issue = Issue.first(:order => 'id DESC')
                  assert issue.is_private?
                end
                def test_post_create_private_with_set_own_issues_private_permission
                  role = Role.find(1)
                  role.remove_permission! :set_issues_private
                  role.add_permission! :set_own_issues_private
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 1,
                                          :subject => 'This is a private issue',
                                          :is_private => '1'}
                  end
                  issue = Issue.first(:order => 'id DESC')
                  assert issue.is_private?
                end
                def test_post_create_should_send_a_notification
                  ActionMailer::Base.deliveries.clear
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    post :create, :project_id => 1,
                               :issue => {:tracker_id => 3,
                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_post_create_should_preserve_fields_values_on_validation_failure
                  @request.session[:user_id] = 2
                  post :create, :project_id => 1,
                             :issue => {:tracker_id => 1,
                                        # empty subject
                                        :subject => '',
                                        :description => 'This is a description',
                                        :priority_id => 6,
                                        :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
                  assert_response :success
                  assert_template 'new'
                  assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                                        :content => 'This is a description'
                  assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                      :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                     :value => '6' },
                                                                    :content => 'High' }
                  # Custom fields
                  assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                                      :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                     :value => 'Oracle' },
                                                                    :content => 'Oracle' }
                  assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                                      :value => 'Value for field 2'}
                end
                def test_post_create_should_ignore_non_safe_attributes
                  @request.session[:user_id] = 2
                  assert_nothing_raised do
                    post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
                  end
                end
                def test_post_create_with_attachment
                  set_tmp_attachments_directory
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count' do
                    assert_difference 'Attachment.count' do
                      post :create, :project_id => 1,
                        :issue => { :tracker_id => '1', :subject => 'With attachment' },
                        :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
                    end
                  end
                  issue = Issue.first(:order => 'id DESC')
                  attachment = Attachment.first(:order => 'id DESC')
                  assert_equal issue, attachment.container
                  assert_equal 2, attachment.author_id
                  assert_equal 'testfile.txt', attachment.filename
                  assert_equal 'text/plain', attachment.content_type
                  assert_equal 'test file', attachment.description
                  assert_equal 59, attachment.filesize
                  assert File.exists?(attachment.diskfile)
                  assert_equal 59, File.size(attachment.diskfile)
                end
                context "without workflow privilege" do
                  setup do
                    Workflow.delete_all(["role_id = ?", Role.anonymous.id])
                    Role.anonymous.add_permission! :add_issues, :add_issue_notes
                  end
                  context "#new" do
                    should "propose default status only" do
                      get :new, :project_id => 1
                      assert_response :success
                      assert_template 'new'
                      assert_tag :tag => 'select',
                        :attributes => {:name => 'issue[status_id]'},
                        :children => {:count => 1},
                        :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
                    end
                    should "accept default status" do
                      assert_difference 'Issue.count' do
                        post :create, :project_id => 1,
                                   :issue => {:tracker_id => 1,
                                              :subject => 'This is an issue',
                                              :status_id => 1}
                      end
                      issue = Issue.last(:order => 'id')
                      assert_equal IssueStatus.default, issue.status
                    end
                    should "ignore unauthorized status" do
                      assert_difference 'Issue.count' do
                        post :create, :project_id => 1,
                                   :issue => {:tracker_id => 1,
                                              :subject => 'This is an issue',
                                              :status_id => 3}
                      end
                      issue = Issue.last(:order => 'id')
                      assert_equal IssueStatus.default, issue.status
                    end
                  end
                  context "#update" do
                    should "ignore status change" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                      end
                      assert_equal 1, Issue.find(1).status_id
                    end
                    should "ignore attributes changes" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
                      end
                      issue = Issue.find(1)
                      assert_equal "Can't print recipes", issue.subject
                      assert_nil issue.assigned_to
                    end
                  end
                end
                context "with workflow privilege" do
                  setup do
                    Workflow.delete_all(["role_id = ?", Role.anonymous.id])
                    Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
                    Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
                    Role.anonymous.add_permission! :add_issues, :add_issue_notes
                  end
                  context "#update" do
                    should "accept authorized status" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                      end
                      assert_equal 3, Issue.find(1).status_id
                    end
                    should "ignore unauthorized status" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
                      end
                      assert_equal 1, Issue.find(1).status_id
                    end
                    should "accept authorized attributes changes" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
                      end
                      issue = Issue.find(1)
                      assert_equal 2, issue.assigned_to_id
                    end
                    should "ignore unauthorized attributes changes" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
                      end
                      issue = Issue.find(1)
                      assert_equal "Can't print recipes", issue.subject
                    end
                  end
                  context "and :edit_issues permission" do
                    setup do
                      Role.anonymous.add_permission! :add_issues, :edit_issues
                    end
                    should "accept authorized status" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
                      end
                      assert_equal 3, Issue.find(1).status_id
                    end
                    should "ignore unauthorized status" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
                      end
                      assert_equal 1, Issue.find(1).status_id
                    end
                    should "accept authorized attributes changes" do
                      assert_difference 'Journal.count' do
                        put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
                      end
                      issue = Issue.find(1)
                      assert_equal "changed", issue.subject
                      assert_equal 2, issue.assigned_to_id
                    end
                  end
                end
                def test_copy_issue
                  @request.session[:user_id] = 2
                  get :new, :project_id => 1, :copy_from => 1
                  assert_template 'new'
                  assert_not_nil assigns(:issue)
                  orig = Issue.find(1)
                  assert_equal orig.subject, assigns(:issue).subject
                end
                def test_get_edit
                  @request.session[:user_id] = 2
                  get :edit, :id => 1
                  assert_response :success
                  assert_template 'edit'
                  assert_not_nil assigns(:issue)
                  assert_equal Issue.find(1), assigns(:issue)
                  # Be sure we don't display inactive IssuePriorities
                  assert ! IssuePriority.find(15).active?
                  assert_no_tag :option, :attributes => {:value => '15'},
                                         :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
                end
                def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
                  @request.session[:user_id] = 2
                  Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
                  get :edit, :id => 1
                  assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
                end
                def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
                  @request.session[:user_id] = 2
                  Role.find_by_name('Manager').remove_permission! :log_time
                  get :edit, :id => 1
                  assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
                end
                def test_get_edit_with_params
                  @request.session[:user_id] = 2
                  get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
                      :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
                  assert_response :success
                  assert_template 'edit'
                  issue = assigns(:issue)
                  assert_not_nil issue
                  assert_equal 5, issue.status_id
                  assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                                      :child => { :tag => 'option',
                                                  :content => 'Closed',
                                                  :attributes => { :selected => 'selected' } }
                  assert_equal 7, issue.priority_id
                  assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                      :child => { :tag => 'option',
                                                  :content => 'Urgent',
                                                  :attributes => { :selected => 'selected' } }
                  assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
                  assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
                                      :child => { :tag => 'option',
                                                  :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
                  assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
                end
                def test_update_edit_form
                  @request.session[:user_id] = 2
                  xhr :post, :new, :project_id => 1,
                                           :id => 1,
                                           :issue => {:tracker_id => 2,
                                                      :subject => 'This is the test_new issue',
                                                      :description => 'This is the description',
                                                      :priority_id => 5}
                  assert_response :success
                  assert_template 'attributes'
                  issue = assigns(:issue)
                  assert_kind_of Issue, issue
                  assert_equal 1, issue.id
                  assert_equal 1, issue.project_id
                  assert_equal 2, issue.tracker_id
                  assert_equal 'This is the test_new issue', issue.subject
                end
                def test_update_using_invalid_http_verbs
                  @request.session[:user_id] = 2
                  subject = 'Updated by an invalid http verb'
                  get :update, :id => 1, :issue => {:subject => subject}
                  assert_not_equal subject, Issue.find(1).subject
                  post :update, :id => 1, :issue => {:subject => subject}
                  assert_not_equal subject, Issue.find(1).subject
                  delete :update, :id => 1, :issue => {:subject => subject}
                  assert_not_equal subject, Issue.find(1).subject
                end
                def test_put_update_without_custom_fields_param
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  assert_equal '125', issue.custom_value_for(2).value
                  old_subject = issue.subject
                  new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                  assert_difference('Journal.count') do
                    assert_difference('JournalDetail.count', 2) do
                      put :update, :id => 1, :issue => {:subject => new_subject,
                                                       :priority_id => '6',
                                                       :category_id => '1' # no change
                                                      }
                    end
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal new_subject, issue.subject
                  # Make sure custom fields were not cleared
                  assert_equal '125', issue.custom_value_for(2).value
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                  assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
                end
                def test_put_update_with_custom_field_change
                  @request.session[:user_id] = 2
                  issue = Issue.find(1)
                  assert_equal '125', issue.custom_value_for(2).value
                  assert_difference('Journal.count') do
                    assert_difference('JournalDetail.count', 3) do
                      put :update, :id => 1, :issue => {:subject => 'Custom field change',
                                                       :priority_id => '6',
                                                       :category_id => '1', # no change
                                                       :custom_field_values => { '2' => 'New custom value' }
                                                      }
                    end
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal 'New custom value', issue.custom_value_for(2).value
                  mail = ActionMailer::Base.deliveries.last
                  assert_kind_of TMail::Mail, mail
                  assert mail.body.include?("Searchable field changed from 125 to New custom value")
                end
                def test_put_update_with_status_and_assignee_change
                  issue = Issue.find(1)
                  assert_equal 1, issue.status_id
                  @request.session[:user_id] = 2
                  assert_difference('TimeEntry.count', 0) do
                    put :update,
                         :id => 1,
                         :issue => { :status_id => 2, :assigned_to_id => 3 },
                         :notes => 'Assigned to dlopper',
                         :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert_equal 2, issue.status_id
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal 'Assigned to dlopper', j.notes
                  assert_equal 2, j.details.size
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?("Status changed from New to Assigned")
                  # subject should contain the new status
                  assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
                end
                def test_put_update_with_note_only
                  notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
                  # anonymous user
                  put :update,
                       :id => 1,
                       :notes => notes
                  assert_redirected_to :action => 'show', :id => '1'
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal notes, j.notes
                  assert_equal 0, j.details.size
                  assert_equal User.anonymous, j.user
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?(notes)
                end
                def test_put_update_with_note_and_spent_time
                  @request.session[:user_id] = 2
                  spent_hours_before = Issue.find(1).spent_hours
                  assert_difference('TimeEntry.count') do
                    put :update,
                         :id => 1,
                         :notes => '2.5 hours added',
                         :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  issue = Issue.find(1)
                  j = Journal.find(:first, :order => 'id DESC')
                  assert_equal '2.5 hours added', j.notes
                  assert_equal 0, j.details.size
                  t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
                  assert_not_nil t
                  assert_equal 2.5, t.hours
                  assert_equal spent_hours_before + 2.5, issue.spent_hours
                end
                def test_put_update_with_attachment_only
                  set_tmp_attachments_directory
                  # Delete all fixtured journals, a race condition can occur causing the wrong
                  # journal to get fetched in the next find.
                  Journal.delete_all
                  # anonymous user
                  assert_difference 'Attachment.count' do
                    put :update, :id => 1,
                      :notes => '',
                      :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
                  end
                  assert_redirected_to :action => 'show', :id => '1'
                  j = Issue.find(1).journals.find(:first, :order => 'id DESC')
                  assert j.notes.blank?
                  assert_equal 1, j.details.size
                  assert_equal 'testfile.txt', j.details.first.value
                  assert_equal User.anonymous, j.user
                  attachment = Attachment.first(:order => 'id DESC')
                  assert_equal Issue.find(1), attachment.container
                  assert_equal User.anonymous, attachment.author
                  assert_equal 'testfile.txt', attachment.filename
                  assert_equal 'text/plain', attachment.content_type
                  assert_equal 'test file', attachment.description
                  assert_equal 59, attachment.filesize
                  assert File.exists?(attachment.diskfile)
                  assert_equal 59, File.size(attachment.diskfile)
                  mail = ActionMailer::Base.deliveries.last
                  assert mail.body.include?('testfile.txt')
                end
                def test_put_update_with_attachment_that_fails_to_save
                  set_tmp_attachments_directory
                  # Delete all fixtured journals, a race condition can occur causing the wrong
                  # journal to get fetched in the next find.
                  Journal.delete_all
                  # Mock out the unsaved attachment
                  Attachment.any_instance.stubs(:create).returns(Attachment.new)
                  # anonymous user
                  put :update,
                       :id => 1,
                       :notes => '',
                       :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
                  assert_redirected_to :action => 'show', :id => '1'
                  assert_equal '1 file(s) could not be saved.', flash[:warning]
                end if Object.const_defined?(:Mocha)
                def test_put_update_with_no_change
                  issue = Issue.find(1)
                  issue.journals.clear
                  ActionMailer::Base.deliveries.clear
                  put :update,
                       :id => 1,
                       :notes => ''
                  assert_redirected_to :action => 'show', :id => '1'
                  issue.reload
                  assert issue.journals.empty?
                  # No email should be sent
                  assert ActionMailer::Base.deliveries.empty?
                end
                def test_put_update_should_send_a_notification
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  old_subject = issue.subject
                  new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                  put :update, :id => 1, :issue => {:subject => new_subject,
                                                   :priority_id => '6',
                                                   :category_id => '1' # no change
                                                  }
                  assert_equal 1, ActionMailer::Base.deliveries.size
                end
                def test_put_update_with_invalid_spent_time_hours_only
                  @request.session[:user_id] = 2
                  notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                  assert_no_difference('Journal.count') do
                    put :update,
                         :id => 1,
                         :notes => notes,
                         :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
                  end
                  assert_response :success
                  assert_template 'edit'
                  assert_error_tag :descendant => {:content => /Activity can't be blank/}
                  assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
                  assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
                end
                def test_put_update_with_invalid_spent_time_comments_only
                  @request.session[:user_id] = 2
                  notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                  assert_no_difference('Journal.count') do
                    put :update,
                         :id => 1,
                         :notes => notes,
                         :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
                  end
                  assert_response :success
                  assert_template 'edit'
                  assert_error_tag :descendant => {:content => /Activity can't be blank/}
                  assert_error_tag :descendant => {:content => /Hours can't be blank/}
                  assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
                  assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
                end
                def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       }
                  assert_response :redirect
                  issue.reload
                  assert_equal 4, issue.fixed_version_id
                  assert_not_equal issue.project_id, issue.fixed_version.project_id
                end
                def test_put_update_should_redirect_back_using_the_back_url_parameter
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       },
                       :back_url => '/issues'
                  assert_response :redirect
                  assert_redirected_to '/issues'
                end
                def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                  issue = Issue.find(2)
                  @request.session[:user_id] = 2
                  put :update,
                       :id => issue.id,
                       :issue => {
                         :fixed_version_id => 4
                       },
                       :back_url => 'http://google.com'
                  assert_response :redirect
                  assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
                end
                def test_get_bulk_edit
                  @request.session[:user_id] = 2
                  get :bulk_edit, :ids => [1, 2]
                  assert_response :success
                  assert_template 'bulk_edit'
                  assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
                  # Project specific custom field, date type
                  field = CustomField.find(9)
                  assert !field.is_for_all?
                  assert_equal 'date', field.field_format
                  assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
                  # System wide custom field
                  assert CustomField.find(1).is_for_all?
                  assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
                  # Be sure we don't display inactive IssuePriorities
                  assert ! IssuePriority.find(15).active?
                  assert_no_tag :option, :attributes => {:value => '15'},
                                         :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
                end
                def test_get_bulk_edit_on_different_projects
                  @request.session[:user_id] = 2
                  get :bulk_edit, :ids => [1, 2, 6]
                  assert_response :success
                  assert_template 'bulk_edit'
                  # Can not set issues from different projects as children of an issue
                  assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
                  # Project specific custom field, date type
                  field = CustomField.find(9)
                  assert !field.is_for_all?
                  assert !field.project_ids.include?(Issue.find(6).project_id)
                  assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
                end
                def test_get_bulk_edit_with_user_custom_field
                  field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
                  @request.session[:user_id] = 2
                  get :bulk_edit, :ids => [1, 2]
                  assert_response :success
                  assert_template 'bulk_edit'
                  assert_tag :select,
                    :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
                    :children => {
                      :only => {:tag => 'option'},
                      :count => Project.find(1).users.count + 1
                    }
                end
                def test_get_bulk_edit_with_version_custom_field
                  field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
                  @request.session[:user_id] = 2
                  get :bulk_edit, :ids => [1, 2]
                  assert_response :success
                  assert_template 'bulk_edit'
                  assert_tag :select,
                    :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
                    :children => {
                      :only => {:tag => 'option'},
                      :count => Project.find(1).shared_versions.count + 1
                    }
                end
                def test_bulk_update
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
                                                   :issue => {:priority_id => 7,
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => ''}}
                  assert_response 302
                  # check that the issues were updated
                  assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
                  issue = Issue.find(1)
                  journal = issue.journals.find(:first, :order => 'created_on DESC')
                  assert_equal '125', issue.custom_value_for(2).value
                  assert_equal 'Bulk editing', journal.notes
                  assert_equal 1, journal.details.size
                end
                def test_bulk_update_with_group_assignee
                  group = Group.find(11)
                  project = Project.find(1)
                  project.members << Member.new(:principal => group, :roles => [Role.first])
                  @request.session[:user_id] = 2
                  # update issues assignee
                  post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
                                                   :issue => {:priority_id => '',
                                                              :assigned_to_id => group.id,
                                                              :custom_field_values => {'2' => ''}}
                  assert_response 302
                  assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
                end
                def test_bulk_update_on_different_projects
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
                                                   :issue => {:priority_id => 7,
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => ''}}
                  assert_response 302
                  # check that the issues were updated
                  assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
                  issue = Issue.find(1)
                  journal = issue.journals.find(:first, :order => 'created_on DESC')
                  assert_equal '125', issue.custom_value_for(2).value
                  assert_equal 'Bulk editing', journal.notes
                  assert_equal 1, journal.details.size
                end
                def test_bulk_update_on_different_projects_without_rights
                  @request.session[:user_id] = 3
                  user = User.find(3)
                  action = { :controller => "issues", :action => "bulk_update" }
                  assert user.allowed_to?(action, Issue.find(1).project)
                  assert ! user.allowed_to?(action, Issue.find(6).project)
                  post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
                                                   :issue => {:priority_id => 7,
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => ''}}
                  assert_response 403
                  assert_not_equal "Bulk should fail", Journal.last.notes
                end
                def test_bullk_update_should_send_a_notification
                  @request.session[:user_id] = 2
                  ActionMailer::Base.deliveries.clear
                  post(:bulk_update,
                       {
                         :ids => [1, 2],
                         :notes => 'Bulk editing',
                         :issue => {
                           :priority_id => 7,
                           :assigned_to_id => '',
                           :custom_field_values => {'2' => ''}
                         }
                       })
                  assert_response 302
                  assert_equal 2, ActionMailer::Base.deliveries.size
                end
                def test_bulk_update_status
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
                                                   :issue => {:priority_id => '',
                                                              :assigned_to_id => '',
                                                              :status_id => '5'}
                  assert_response 302
                  issue = Issue.find(1)
                  assert issue.closed?
                end
                def test_bulk_update_parent_id
                  @request.session[:user_id] = 2
                  post :bulk_update, :ids => [1, 3],
                    :notes => 'Bulk editing parent',
                    :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
                  assert_response 302
                  parent = Issue.find(2)
                  assert_equal parent.id, Issue.find(1).parent_id
                  assert_equal parent.id, Issue.find(3).parent_id
                  assert_equal [1, 3], parent.children.collect(&:id).sort
                end
                def test_bulk_update_custom_field
                  @request.session[:user_id] = 2
                  # update issues priority
                  post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
                                                   :issue => {:priority_id => '',
                                                              :assigned_to_id => '',
                                                              :custom_field_values => {'2' => '777'}}
                  assert_response 302
                  issue = Issue.find(1)
                  journal = issue.journals.find(:first, :order => 'created_on DESC')
                  assert_equal '777', issue.custom_value_for(2).value
                  assert_equal 1, journal.details.size
                  assert_equal '125', journal.details.first.old_value
                  assert_equal '777', journal.details.first.value
                end
                def test_bulk_update_unassign
                  assert_not_nil Issue.find(2).assigned_to
                  @request.session[:user_id] = 2
                  # unassign issues
                  post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
                  assert_response 302
                  # check that the issues were updated
                  assert_nil Issue.find(2).assigned_to
                end
                def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
                  @request.session[:user_id] = 2
                  post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
                  assert_response :redirect
                  issues = Issue.find([1,2])
                  issues.each do |issue|
                    assert_equal 4, issue.fixed_version_id
                    assert_not_equal issue.project_id, issue.fixed_version.project_id
                  end
                end
                def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
                  @request.session[:user_id] = 2
                  post :bulk_update, :ids => [1,2], :back_url => '/issues'
                  assert_response :redirect
                  assert_redirected_to '/issues'
                end
                def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
                  @request.session[:user_id] = 2
                  post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
                  assert_response :redirect
                  assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
                end
                def test_destroy_issue_with_no_time_entries
                  assert_nil TimeEntry.find_by_issue_id(2)
                  @request.session[:user_id] = 2
                  delete :destroy, :id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert_nil Issue.find_by_id(2)
                end
                def test_destroy_issues_with_time_entries
                  @request.session[:user_id] = 2
                  delete :destroy, :ids => [1, 3]
                  assert_response :success
                  assert_template 'destroy'
                  assert_not_nil assigns(:hours)
                  assert Issue.find_by_id(1) && Issue.find_by_id(3)
                end
                def test_destroy_issues_and_destroy_time_entries
                  @request.session[:user_id] = 2
                  delete :destroy, :ids => [1, 3], :todo => 'destroy'
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_nil TimeEntry.find_by_id([1, 2])
                end
                def test_destroy_issues_and_assign_time_entries_to_project
                  @request.session[:user_id] = 2
                  delete :destroy, :ids => [1, 3], :todo => 'nullify'
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_nil TimeEntry.find(1).issue_id
                  assert_nil TimeEntry.find(2).issue_id
                end
                def test_destroy_issues_and_reassign_time_entries_to_another_issue
                  @request.session[:user_id] = 2
                  delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
                  assert_redirected_to :action => 'index', :project_id => 'ecookbook'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                  assert_equal 2, TimeEntry.find(1).issue_id
                  assert_equal 2, TimeEntry.find(2).issue_id
                end
                def test_destroy_issues_from_different_projects
                  @request.session[:user_id] = 2
                  delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
                  assert_redirected_to :controller => 'issues', :action => 'index'
                  assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
                end
                def test_destroy_parent_and_child_issues
                  parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
                  child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
                  assert child.is_descendant_of?(parent.reload)
                  @request.session[:user_id] = 2
                  assert_difference 'Issue.count', -2 do
                    delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
                  end
                  assert_response 302
                end
                def test_default_search_scope
                  get :index
                  assert_tag :div, :attributes => {:id => 'quick-search'},
                                   :child => {:tag => 'form',
                                              :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
                end
              end

app/views/issues/_form_update.html.erb removed 0 -14

NO CONTENT: file was removed

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages