jro_apps/redmine Commit - r9965:b603aa74f9ea

Adds sharing attribute to the versions API (#11541)....

Jean-Philippe Lang -

r9965:b603aa74f9ea

parent child

Context file:

r9965:b603aa74f9ea

Collapse all files

app/views/versions/index.api.rsb +1 0

             api.array :versions, api_meta(:total_count => @versions.size) do
               @versions.each do |version|
                 api.version do
                   api.id version.id
                   api.project(:id => version.project_id, :name => version.project.name) unless version.project.nil?
                   api.name        version.name
                   api.description version.description
                   api.status      version.status
                   api.due_date    version.effective_date
+                  api.sharing     version.sharing
                   render_api_custom_values version.custom_field_values, api
                   api.created_on version.created_on
                   api.updated_on version.updated_on
                 end
               end
             end

app/views/versions/show.api.rsb +1 0

             api.version do
               api.id @version.id
               api.project(:id => @version.project_id, :name => @version.project.name) unless @version.project.nil?
               api.name        @version.name
               api.description @version.description
               api.status      @version.status
               api.due_date    @version.effective_date
+              api.sharing     @version.sharing
               render_api_custom_values @version.custom_field_values, api
               api.created_on @version.created_on
               api.updated_on @version.updated_on
             end

test/integration/api_test/versions_test.rb +5 -9

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../../test_helper', __FILE__)
             class ApiTest::VersionsTest < ActionController::IntegrationTest
               fixtures :projects, :trackers, :issue_statuses, :issues,
                        :enumerations, :users, :issue_categories,
                        :projects_trackers,
                        :roles,
                        :member_roles,
                        :members,
                        :enabled_modules,
                        :workflows,
                        :versions
               def setup
                 Setting.rest_api_enabled = '1'
               end
               context "/projects/:project_id/versions" do
                 context "GET" do
                   should "return project versions" do
                     get '/projects/1/versions.xml'
                     assert_response :success
                     assert_equal 'application/xml', @response.content_type
                     assert_tag :tag => 'versions',
                       :attributes => {:type => 'array'},
                       :child => {
                         :tag => 'version',
                         :child => {
                           :tag => 'id',
                           :content => '2',
                           :sibling => {
                             :tag => 'name',
                             :content => '1.0'
                           }
                         }
                       }
                   end
                 end
                 context "POST" do
                   should "create the version" do
                     assert_difference 'Version.count' do
                       post '/projects/1/versions.xml', {:version => {:name => 'API test'}}, credentials('jsmith')
                     end
                     version = Version.first(:order => 'id DESC')
                     assert_equal 'API test', version.name
                     assert_response :created
                     assert_equal 'application/xml', @response.content_type
                     assert_tag 'version', :child => {:tag => 'id', :content => version.id.to_s}
                   end
                   should "create the version with due date" do
                     assert_difference 'Version.count' do
                       post '/projects/1/versions.xml', {:version => {:name => 'API test', :due_date => '2012-01-24'}}, credentials('jsmith')
                     end
                     version = Version.first(:order => 'id DESC')
                     assert_equal 'API test', version.name
                     assert_equal Date.parse('2012-01-24'), version.due_date
                     assert_response :created
                     assert_equal 'application/xml', @response.content_type
                     assert_tag 'version', :child => {:tag => 'id', :content => version.id.to_s}
                   end
                   context "with failure" do
                     should "return the errors" do
                       assert_no_difference('Version.count') do
                         post '/projects/1/versions.xml', {:version => {:name => ''}}, credentials('jsmith')
                       end
                       assert_response :unprocessable_entity
                       assert_tag :errors, :child => {:tag => 'error', :content => "Name can't be blank"}
                     end
                   end
                 end
               end
               context "/versions/:id" do
                 context "GET" do
                   should "return the version" do
                     get '/versions/2.xml'
                     assert_response :success
                     assert_equal 'application/xml', @response.content_type
-                    assert_tag 'version',
+                    assert_select 'version' do
-                      :child => {
+                      assert_select 'id', :text => '2'
-                        :tag => 'id',
+                      assert_select 'name', :text => '1.0'
-                        :content => '2',
+                      assert_select 'sharing', :text => 'none'
-                        :sibling => {
+                    end
-                          :tag => 'name',
-                          :content => '1.0'
                   end
                 end
                 context "PUT" do
                   should "update the version" do
                     put '/versions/2.xml', {:version => {:name => 'API update'}}, credentials('jsmith')
                     assert_response :ok
                     assert_equal '', @response.body
                     assert_equal 'API update', Version.find(2).name
                   end
                 end
                 context "DELETE" do
                   should "destroy the version" do
                     assert_difference 'Version.count', -1 do
                       delete '/versions/3.xml', {}, credentials('jsmith')
                     end
                     assert_response :ok
                     assert_equal '', @response.body
                     assert_nil Version.find_by_id(3)
                   end
                 end
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages