jro_apps/redmine Commit - r15016:b553b23e6b9d

1

# encoding: utf-8

1

# encoding: utf-8

2

#

2

#

3

# Redmine - project management software

3

# Redmine - project management software

4

5

#

5

#

6

# This program is free software; you can redistribute it and/or

6

# This program is free software; you can redistribute it and/or

7

# modify it under the terms of the GNU General Public License

7

# modify it under the terms of the GNU General Public License

8

# as published by the Free Software Foundation; either version 2

8

# as published by the Free Software Foundation; either version 2

9

# of the License, or (at your option) any later version.

9

# of the License, or (at your option) any later version.

10

#

10

#

11

# This program is distributed in the hope that it will be useful,

11

# This program is distributed in the hope that it will be useful,

12

# but WITHOUT ANY WARRANTY; without even the implied warranty of

12

# but WITHOUT ANY WARRANTY; without even the implied warranty of

13

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

14

# GNU General Public License for more details.

14

# GNU General Public License for more details.

15

#

15

#

16

# You should have received a copy of the GNU General Public License

16

# You should have received a copy of the GNU General Public License

17

# along with this program; if not, write to the Free Software

17

# along with this program; if not, write to the Free Software

18

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

18

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

19

20

require File.expand_path('../../test_helper', __FILE__)

20

require File.expand_path('../../test_helper', __FILE__)

21

22

class AttachmentsControllerTest < ActionController::TestCase

22

class AttachmentsControllerTest < ActionController::TestCase

23

fixtures :users, :projects, :roles, :members, :member_roles,

23

fixtures :users, :projects, :roles, :members, :member_roles,

24

:enabled_modules, :issues, :trackers, :attachments,

24

:enabled_modules, :issues, :trackers, :attachments,

25

:versions, :wiki_pages, :wikis, :documents

25

:versions, :wiki_pages, :wikis, :documents

26

27

def setup

27

def setup

28

User.current = nil

28

User.current = nil

29

set_fixtures_attachments_directory

29

set_fixtures_attachments_directory

30

end

30

end

31

32

def teardown

32

def teardown

33

set_tmp_attachments_directory

33

set_tmp_attachments_directory

34

end

34

end

35

36

def test_show_diff

36

def test_show_diff

37

['inline', 'sbs'].each do |dt|

37

['inline', 'sbs'].each do |dt|

38

# 060719210727_changeset_utf8.diff

38

# 060719210727_changeset_utf8.diff

39

get :show, :id => 14, :type => dt

39

get :show, :id => 14, :type => dt

40

assert_response :success

40

assert_response :success

41

assert_template 'diff'

41

assert_template 'diff'

42

assert_equal 'text/html', @response.content_type

42

assert_equal 'text/html', @response.content_type

43

assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/

43

assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/

44

assert_select 'td.line-code', :text => /Demande créée avec succès/

44

assert_select 'td.line-code', :text => /Demande créée avec succès/

45

end

45

end

46

set_tmp_attachments_directory

46

set_tmp_attachments_directory

47

end

47

end

48

49

def test_show_diff_replace_cannot_convert_content

49

def test_show_diff_replace_cannot_convert_content

50

with_settings :repositories_encodings => 'UTF-8' do

50

with_settings :repositories_encodings => 'UTF-8' do

51

['inline', 'sbs'].each do |dt|

51

['inline', 'sbs'].each do |dt|

52

# 060719210727_changeset_iso8859-1.diff

52

# 060719210727_changeset_iso8859-1.diff

53

get :show, :id => 5, :type => dt

53

get :show, :id => 5, :type => dt

54

assert_response :success

54

assert_response :success

55

assert_template 'diff'

55

assert_template 'diff'

56

assert_equal 'text/html', @response.content_type

56

assert_equal 'text/html', @response.content_type

57

assert_select 'th.filename', :text => /issues_controller.rb\t\(r\?vision 1484\)/

57

assert_select 'th.filename', :text => /issues_controller.rb\t\(r\?vision 1484\)/

58

assert_select 'td.line-code', :text => /Demande cr\?\?e avec succ\?s/

58

assert_select 'td.line-code', :text => /Demande cr\?\?e avec succ\?s/

59

end

59

end

60

end

60

end

61

set_tmp_attachments_directory

61

set_tmp_attachments_directory

62

end

62

end

63

64

def test_show_diff_latin_1

64

def test_show_diff_latin_1

65

with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do

65

with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do

66

['inline', 'sbs'].each do |dt|

66

['inline', 'sbs'].each do |dt|

67

# 060719210727_changeset_iso8859-1.diff

67

# 060719210727_changeset_iso8859-1.diff

68

get :show, :id => 5, :type => dt

68

get :show, :id => 5, :type => dt

69

assert_response :success

69

assert_response :success

70

assert_template 'diff'

70

assert_template 'diff'

71

assert_equal 'text/html', @response.content_type

71

assert_equal 'text/html', @response.content_type

72

assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/

72

assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/

73

assert_select 'td.line-code', :text => /Demande créée avec succès/

73

assert_select 'td.line-code', :text => /Demande créée avec succès/

74

end

74

end

75

end

75

end

76

set_tmp_attachments_directory

76

set_tmp_attachments_directory

77

end

77

end

78

79

def test_save_diff_type

79

def test_save_diff_type

80

user1 = User.find(1)

80

user1 = User.find(1)

81

user1.pref[:diff_type] = nil

81

user1.pref[:diff_type] = nil

82

user1.preference.save

82

user1.preference.save

83

user = User.find(1)

83

user = User.find(1)

84

assert_nil user.pref[:diff_type]

84

assert_nil user.pref[:diff_type]

85

86

@request.session[:user_id] = 1 # admin

86

@request.session[:user_id] = 1 # admin

87

get :show, :id => 5

87

get :show, :id => 5

88

assert_response :success

88

assert_response :success

89

assert_template 'diff'

89

assert_template 'diff'

90

user.reload

90

user.reload

91

assert_equal "inline", user.pref[:diff_type]

91

assert_equal "inline", user.pref[:diff_type]

92

get :show, :id => 5, :type => 'sbs'

92

get :show, :id => 5, :type => 'sbs'

93

assert_response :success

93

assert_response :success

94

assert_template 'diff'

94

assert_template 'diff'

95

user.reload

95

user.reload

96

assert_equal "sbs", user.pref[:diff_type]

96

assert_equal "sbs", user.pref[:diff_type]

97

end

97

end

98

99

def test_diff_show_filename_in_mercurial_export

99

def test_diff_show_filename_in_mercurial_export

100

set_tmp_attachments_directory

100

set_tmp_attachments_directory

101

a = Attachment.new(:container => Issue.find(1),

101

a = Attachment.new(:container => Issue.find(1),

102

:file => uploaded_test_file("hg-export.diff", "text/plain"),

102

:file => uploaded_test_file("hg-export.diff", "text/plain"),

103

:author => User.find(1))

103

:author => User.find(1))

104

assert a.save

104

assert a.save

105

assert_equal 'hg-export.diff', a.filename

105

assert_equal 'hg-export.diff', a.filename

106

107

get :show, :id => a.id, :type => 'inline'

107

get :show, :id => a.id, :type => 'inline'

108

assert_response :success

108

assert_response :success

109

assert_template 'diff'

109

assert_template 'diff'

110

assert_equal 'text/html', @response.content_type

110

assert_equal 'text/html', @response.content_type

111

assert_select 'th.filename', :text => 'test1.txt'

111

assert_select 'th.filename', :text => 'test1.txt'

112

end

112

end

113

114

def test_show_text_file

114

def test_show_text_file

115

get :show, :id => 4

115

get :show, :id => 4

116

assert_response :success

116

assert_response :success

117

assert_template 'file'

117

assert_template 'file'

118

assert_equal 'text/html', @response.content_type

118

assert_equal 'text/html', @response.content_type

119

set_tmp_attachments_directory

119

set_tmp_attachments_directory

120

end

120

end

121

122

def test_show_text_file_utf_8

122

def test_show_text_file_utf_8

123

set_tmp_attachments_directory

123

set_tmp_attachments_directory

124

a = Attachment.new(:container => Issue.find(1),

124

a = Attachment.new(:container => Issue.find(1),

125

:file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),

125

:file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),

126

:author => User.find(1))

126

:author => User.find(1))

127

assert a.save

127

assert a.save

128

assert_equal 'japanese-utf-8.txt', a.filename

128

assert_equal 'japanese-utf-8.txt', a.filename

129

130

str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e".force_encoding('UTF-8')

130

str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e".force_encoding('UTF-8')

131

132

get :show, :id => a.id

132

get :show, :id => a.id

133

assert_response :success

133

assert_response :success

134

assert_template 'file'

134

assert_template 'file'

135

assert_equal 'text/html', @response.content_type

135

assert_equal 'text/html', @response.content_type

136

assert_select 'tr#L1' do

136

assert_select 'tr#L1' do

137

assert_select 'th.line-num', :text => '1'

137

assert_select 'th.line-num', :text => '1'

138

assert_select 'td', :text => /#{str_japanese}/

138

assert_select 'td', :text => /#{str_japanese}/

139

end

139

end

140

end

140

end

141

142

def test_show_text_file_replace_cannot_convert_content

142

def test_show_text_file_replace_cannot_convert_content

143

set_tmp_attachments_directory

143

set_tmp_attachments_directory

144

with_settings :repositories_encodings => 'UTF-8' do

144

with_settings :repositories_encodings => 'UTF-8' do

145

a = Attachment.new(:container => Issue.find(1),

145

a = Attachment.new(:container => Issue.find(1),

146

:file => uploaded_test_file("iso8859-1.txt", "text/plain"),

146

:file => uploaded_test_file("iso8859-1.txt", "text/plain"),

147

:author => User.find(1))

147

:author => User.find(1))

148

assert a.save

148

assert a.save

149

assert_equal 'iso8859-1.txt', a.filename

149

assert_equal 'iso8859-1.txt', a.filename

150

151

get :show, :id => a.id

151

get :show, :id => a.id

152

assert_response :success

152

assert_response :success

153

assert_template 'file'

153

assert_template 'file'

154

assert_equal 'text/html', @response.content_type

154

assert_equal 'text/html', @response.content_type

155

assert_select 'tr#L7' do

155

assert_select 'tr#L7' do

156

assert_select 'th.line-num', :text => '7'

156

assert_select 'th.line-num', :text => '7'

157

assert_select 'td', :text => /Demande cr\?\?e avec succ\?s/

157

assert_select 'td', :text => /Demande cr\?\?e avec succ\?s/

158

end

158

end

159

end

159

end

160

end

160

end

161

162

def test_show_text_file_latin_1

162

def test_show_text_file_latin_1

163

set_tmp_attachments_directory

163

set_tmp_attachments_directory

164

with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do

164

with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do

165

a = Attachment.new(:container => Issue.find(1),

165

a = Attachment.new(:container => Issue.find(1),

166

:file => uploaded_test_file("iso8859-1.txt", "text/plain"),

166

:file => uploaded_test_file("iso8859-1.txt", "text/plain"),

167

:author => User.find(1))

167

:author => User.find(1))

168

assert a.save

168

assert a.save

169

assert_equal 'iso8859-1.txt', a.filename

169

assert_equal 'iso8859-1.txt', a.filename

170

171

get :show, :id => a.id

171

get :show, :id => a.id

172

assert_response :success

172

assert_response :success

173

assert_template 'file'

173

assert_template 'file'

174

assert_equal 'text/html', @response.content_type

174

assert_equal 'text/html', @response.content_type

175

assert_select 'tr#L7' do

175

assert_select 'tr#L7' do

176

assert_select 'th.line-num', :text => '7'

176

assert_select 'th.line-num', :text => '7'

177

assert_select 'td', :text => /Demande créée avec succès/

177

assert_select 'td', :text => /Demande créée avec succès/

178

end

178

end

179

end

179

end

180

end

180

end

181

182

def test_show_text_file_should_s~~end~~_if_too_big

182

def test_show_text_file_should_show_other_if_too_big

183

with_settings :file_max_size_displayed => 512 do

183

with_settings :file_max_size_displayed => 512 do

184

Attachment.find(4).update_attribute :filesize, 754.kilobyte

184

Attachment.find(4).update_attribute :filesize, 754.kilobyte

185

get :show, :id => 4

185

get :show, :id => 4

186

assert_response :success

186

assert_response :success

187

assert_equal 'application/x-ruby', @response.content_type

187

assert_template 'other'

188

assert_equal 'text/html', @response.content_type

188

end

189

end

189

set_tmp_attachments_directory

190

set_tmp_attachments_directory

190

end

191

end

191

192

def test_show_image

193

def test_show_image

193

@request.session[:user_id] = 2

194

@request.session[:user_id] = 2

194

get :show, :id => 16

195

get :show, :id => 16

195

assert_response :success

196

assert_response :success

196

assert_template 'image'

197

assert_template 'image'

197

assert_equal 'text/html', @response.content_type

198

assert_equal 'text/html', @response.content_type

198

assert_select 'img.filecontent', :src => attachments(:attachments_010).filename

199

assert_select 'img.filecontent', :src => attachments(:attachments_010).filename

199

end

200

end

200

201

def test_show_other

202

def test_show_other

202

get :show, :id => 6

203

get :show, :id => 6

203

assert_response :success

204

assert_template 'other'

204

assert_equal '~~application/zip~~', @response.content_type

205

assert_equal 'text/html', @response.content_type

206

assert_select '.nodata', :text => 'No preview available'

205

set_tmp_attachments_directory

207

set_tmp_attachments_directory

206

end

208

end

207

209

208

def test_show_file_from_private_issue_without_permission

210

def test_show_file_from_private_issue_without_permission

209

get :show, :id => 15

211

get :show, :id => 15

210

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'

212

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'

211

set_tmp_attachments_directory

213

set_tmp_attachments_directory

212

end

214

end

213

215

214

def test_show_file_from_private_issue_with_permission

216

def test_show_file_from_private_issue_with_permission

215

@request.session[:user_id] = 2

217

@request.session[:user_id] = 2

216

get :show, :id => 15

218

get :show, :id => 15

217

assert_response :success

219

assert_response :success

218

assert_select 'h2', :text => /private.diff/

220

assert_select 'h2', :text => /private.diff/

219

set_tmp_attachments_directory

221

set_tmp_attachments_directory

220

end

222

end

221

223

222

def test_show_file_without_container_should_be_allowed_to_author

224

def test_show_file_without_container_should_be_allowed_to_author

223

set_tmp_attachments_directory

225

set_tmp_attachments_directory

224

attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)

226

attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)

225

227

226

@request.session[:user_id] = 2

228

@request.session[:user_id] = 2

227

get :show, :id => attachment.id

229

get :show, :id => attachment.id

228

assert_response 200

230

assert_response 200

229

end

231

end

230

232

231

def test_show_file_without_container_should_be_denied_to_other_users

233

def test_show_file_without_container_should_be_denied_to_other_users

232

set_tmp_attachments_directory

234

set_tmp_attachments_directory

233

attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)

235

attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)

234

236

235

@request.session[:user_id] = 3

237

@request.session[:user_id] = 3

236

get :show, :id => attachment.id

238

get :show, :id => attachment.id

237

assert_response 403

239

assert_response 403

238

end

240

end

239

241

240

def test_show_invalid_should_respond_with_404

242

def test_show_invalid_should_respond_with_404

241

get :show, :id => 999

243

get :show, :id => 999

242

assert_response 404

244

assert_response 404

243

end

245

end

244

246

245

def test_download_text_file

247

def test_download_text_file

246

get :download, :id => 4

248

get :download, :id => 4

247

assert_response :success

249

assert_response :success

248

assert_equal 'application/x-ruby', @response.content_type

250

assert_equal 'application/x-ruby', @response.content_type

249

etag = @response.etag

251

etag = @response.etag

250

assert_not_nil etag

252

assert_not_nil etag

251

253

252

@request.env["HTTP_IF_NONE_MATCH"] = etag

254

@request.env["HTTP_IF_NONE_MATCH"] = etag

253

get :download, :id => 4

255

get :download, :id => 4

254

assert_response 304

256

assert_response 304

255

257

256

set_tmp_attachments_directory

258

set_tmp_attachments_directory

257

end

259

end

258

260

259

def test_download_version_file_with_issue_tracking_disabled

261

def test_download_version_file_with_issue_tracking_disabled

260

Project.find(1).disable_module! :issue_tracking

262

Project.find(1).disable_module! :issue_tracking

261

get :download, :id => 9

263

get :download, :id => 9

262

assert_response :success

264

assert_response :success

263

end

265

end

264

266

265

def test_download_should_assign_content_type_if_blank

267

def test_download_should_assign_content_type_if_blank

266

Attachment.find(4).update_attribute(:content_type, '')

268

Attachment.find(4).update_attribute(:content_type, '')

267

269

268

get :download, :id => 4

270

get :download, :id => 4

269

assert_response :success

271

assert_response :success

270

assert_equal 'text/x-ruby', @response.content_type

272

assert_equal 'text/x-ruby', @response.content_type

271

set_tmp_attachments_directory

273

set_tmp_attachments_directory

272

end

274

end

273

275

274

def test_download_should_assign_better_content_type_than_application_octet_stream

276

def test_download_should_assign_better_content_type_than_application_octet_stream

275

Attachment.find(4).update! :content_type => "application/octet-stream"

277

Attachment.find(4).update! :content_type => "application/octet-stream"

276

278

277

get :download, :id => 4

279

get :download, :id => 4

278

assert_response :success

280

assert_response :success

279

assert_equal 'text/x-ruby', @response.content_type

281

assert_equal 'text/x-ruby', @response.content_type

280

set_tmp_attachments_directory

282

set_tmp_attachments_directory

281

end

283

end

282

284

283

def test_download_missing_file

285

def test_download_missing_file

284

get :download, :id => 2

286

get :download, :id => 2

285

assert_response 404

287

assert_response 404

286

set_tmp_attachments_directory

288

set_tmp_attachments_directory

287

end

289

end

288

290

289

def test_download_should_be_denied_without_permission

291

def test_download_should_be_denied_without_permission

290

get :download, :id => 7

292

get :download, :id => 7

291

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'

293

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'

292

set_tmp_attachments_directory

294

set_tmp_attachments_directory

293

end

295

end

294

296

295

if convert_installed?

297

if convert_installed?

296

def test_thumbnail

298

def test_thumbnail

297

Attachment.clear_thumbnails

299

Attachment.clear_thumbnails

298

@request.session[:user_id] = 2

300

@request.session[:user_id] = 2

299

get :thumbnail, :id => 16

301

get :thumbnail, :id => 16

300

assert_response :success

302

assert_response :success

301

assert_equal 'image/png', response.content_type

303

assert_equal 'image/png', response.content_type

302

304

303

etag = @response.etag

305

etag = @response.etag

304

assert_not_nil etag

306

assert_not_nil etag

305

307

306

@request.env["HTTP_IF_NONE_MATCH"] = etag

308

@request.env["HTTP_IF_NONE_MATCH"] = etag

307

get :thumbnail, :id => 16

309

get :thumbnail, :id => 16

308

assert_response 304

310

assert_response 304

309

end

311

end

310

312

311

def test_thumbnail_should_not_exceed_maximum_size

313

def test_thumbnail_should_not_exceed_maximum_size

312

Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 800}

314

Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 800}

313

315

314

@request.session[:user_id] = 2

316

@request.session[:user_id] = 2

315

get :thumbnail, :id => 16, :size => 2000

317

get :thumbnail, :id => 16, :size => 2000

316

end

318

end

317

319

318

def test_thumbnail_should_round_size

320

def test_thumbnail_should_round_size

319

Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 250}

321

Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 250}

320

322

321

@request.session[:user_id] = 2

323

@request.session[:user_id] = 2

322

get :thumbnail, :id => 16, :size => 260

324

get :thumbnail, :id => 16, :size => 260

323

end

325

end

324

326

325

def test_thumbnail_should_return_404_for_non_image_attachment

327

def test_thumbnail_should_return_404_for_non_image_attachment

326

@request.session[:user_id] = 2

328

@request.session[:user_id] = 2

327

329

328

get :thumbnail, :id => 15

330

get :thumbnail, :id => 15

329

assert_response 404

331

assert_response 404

330

end

332

end

331

333

332

def test_thumbnail_should_return_404_if_thumbnail_generation_failed

334

def test_thumbnail_should_return_404_if_thumbnail_generation_failed

333

Attachment.any_instance.stubs(:thumbnail).returns(nil)

335

Attachment.any_instance.stubs(:thumbnail).returns(nil)

334

@request.session[:user_id] = 2

336

@request.session[:user_id] = 2

335

337

336

get :thumbnail, :id => 16

338

get :thumbnail, :id => 16

337

assert_response 404

339

assert_response 404

338

end

340

end

339

341

340

def test_thumbnail_should_be_denied_without_permission

342

def test_thumbnail_should_be_denied_without_permission

341

get :thumbnail, :id => 16

343

get :thumbnail, :id => 16

342

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fthumbnail%2F16'

344

assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fthumbnail%2F16'

343

end

345

end

344

else

346

else

345

puts '(ImageMagick convert not available)'

347

puts '(ImageMagick convert not available)'

346

end

348

end

347

349

348

def test_edit

350

def test_edit

349

@request.session[:user_id] = 2

351

@request.session[:user_id] = 2

350

get :edit, :object_type => 'issues', :object_id => '2'

352

get :edit, :object_type => 'issues', :object_id => '2'

351

assert_response :success

353

assert_response :success

352

assert_template 'edit'

354

assert_template 'edit'

353

355

354

container = Issue.find(2)

356

container = Issue.find(2)

355

assert_equal container, assigns(:container)

357

assert_equal container, assigns(:container)

356

assert_equal container.attachments.size, assigns(:attachments).size

358

assert_equal container.attachments.size, assigns(:attachments).size

357

359

358

assert_select 'form[action=?]', '/attachments/issues/2' do

360

assert_select 'form[action=?]', '/attachments/issues/2' do

359

assert_select 'tr#attachment-4' do

361

assert_select 'tr#attachment-4' do

360

assert_select 'input[name=?][value=?]', 'attachments[4][filename]', 'source.rb'

362

assert_select 'input[name=?][value=?]', 'attachments[4][filename]', 'source.rb'

361

assert_select 'input[name=?][value=?]', 'attachments[4][description]', 'This is a Ruby source file'

363

assert_select 'input[name=?][value=?]', 'attachments[4][description]', 'This is a Ruby source file'

362

end

364

end

363

end

365

end

364

end

366

end

365

367

366

def test_edit_invalid_container_class_should_return_404

368

def test_edit_invalid_container_class_should_return_404

367

get :edit, :object_type => 'nuggets', :object_id => '3'

369

get :edit, :object_type => 'nuggets', :object_id => '3'

368

assert_response 404

370

assert_response 404

369

end

371

end

370

372

371

def test_edit_invalid_object_should_return_404

373

def test_edit_invalid_object_should_return_404

372

get :edit, :object_type => 'issues', :object_id => '999'

374

get :edit, :object_type => 'issues', :object_id => '999'

373

assert_response 404

375

assert_response 404

374

end

376

end

375

377

376

def test_edit_for_object_that_is_not_visible_should_return_403

378

def test_edit_for_object_that_is_not_visible_should_return_403

377

get :edit, :object_type => 'issues', :object_id => '4'

379

get :edit, :object_type => 'issues', :object_id => '4'

378

assert_response 403

380

assert_response 403

379

end

381

end

380

382

381

def test_update

383

def test_update

382

@request.session[:user_id] = 2

384

@request.session[:user_id] = 2

383

patch :update, :object_type => 'issues', :object_id => '2', :attachments => {

385

patch :update, :object_type => 'issues', :object_id => '2', :attachments => {

384

'1' => {:filename => 'newname.text', :description => ''},

386

'1' => {:filename => 'newname.text', :description => ''},

385

'4' => {:filename => 'newname.rb', :description => 'Renamed'},

387

'4' => {:filename => 'newname.rb', :description => 'Renamed'},

386

}

388

}

387

389

388

assert_response 302

390

assert_response 302

389

attachment = Attachment.find(4)

391

attachment = Attachment.find(4)

390

assert_equal 'newname.rb', attachment.filename

392

assert_equal 'newname.rb', attachment.filename

391

assert_equal 'Renamed', attachment.description

393

assert_equal 'Renamed', attachment.description

392

end

394

end

393

395

394

def test_update_with_failure

396

def test_update_with_failure

395

@request.session[:user_id] = 2

397

@request.session[:user_id] = 2

396

patch :update, :object_type => 'issues', :object_id => '3', :attachments => {

398

patch :update, :object_type => 'issues', :object_id => '3', :attachments => {

397

'1' => {:filename => '', :description => ''},

399

'1' => {:filename => '', :description => ''},

398

'4' => {:filename => 'newname.rb', :description => 'Renamed'},

400

'4' => {:filename => 'newname.rb', :description => 'Renamed'},

399

}

401

}

400

402

401

assert_response :success

403

assert_response :success

402

assert_template 'edit'

404

assert_template 'edit'

403

assert_select_error /file cannot be blank/i

405

assert_select_error /file cannot be blank/i

404

406

405

# The other attachment should not be updated

407

# The other attachment should not be updated

406

attachment = Attachment.find(4)

408

attachment = Attachment.find(4)

407

assert_equal 'source.rb', attachment.filename

409

assert_equal 'source.rb', attachment.filename

408

assert_equal 'This is a Ruby source file', attachment.description

410

assert_equal 'This is a Ruby source file', attachment.description

409

end

411

end

410

412

411

def test_destroy_issue_attachment

413

def test_destroy_issue_attachment

412

set_tmp_attachments_directory

414

set_tmp_attachments_directory

413

issue = Issue.find(3)

415

issue = Issue.find(3)

414

@request.session[:user_id] = 2

416

@request.session[:user_id] = 2

415

417

416

assert_difference 'issue.attachments.count', -1 do

418

assert_difference 'issue.attachments.count', -1 do

417

assert_difference 'Journal.count' do

419

assert_difference 'Journal.count' do

418

delete :destroy, :id => 1

420

delete :destroy, :id => 1

419

assert_redirected_to '/projects/ecookbook'

421

assert_redirected_to '/projects/ecookbook'

420

end

422

end

421

end

423

end

422

assert_nil Attachment.find_by_id(1)

424

assert_nil Attachment.find_by_id(1)

423

j = Journal.order('id DESC').first

425

j = Journal.order('id DESC').first

424

assert_equal issue, j.journalized

426

assert_equal issue, j.journalized

425

assert_equal 'attachment', j.details.first.property

427

assert_equal 'attachment', j.details.first.property

426

assert_equal '1', j.details.first.prop_key

428

assert_equal '1', j.details.first.prop_key

427

assert_equal 'error281.txt', j.details.first.old_value

429

assert_equal 'error281.txt', j.details.first.old_value

428

assert_equal User.find(2), j.user

430

assert_equal User.find(2), j.user

429

end

431

end

430

432

431

def test_destroy_wiki_page_attachment

433

def test_destroy_wiki_page_attachment

432

set_tmp_attachments_directory

434

set_tmp_attachments_directory

433

@request.session[:user_id] = 2

435

@request.session[:user_id] = 2

434

assert_difference 'Attachment.count', -1 do

436

assert_difference 'Attachment.count', -1 do

435

delete :destroy, :id => 3

437

delete :destroy, :id => 3

436

assert_response 302

438

assert_response 302

437

end

439

end

438

end

440

end

439

441

440

def test_destroy_project_attachment

442

def test_destroy_project_attachment

441

set_tmp_attachments_directory

443

set_tmp_attachments_directory

442

@request.session[:user_id] = 2

444

@request.session[:user_id] = 2

443

assert_difference 'Attachment.count', -1 do

445

assert_difference 'Attachment.count', -1 do

444

delete :destroy, :id => 8

446

delete :destroy, :id => 8

445

assert_response 302

447

assert_response 302

446

end

448

end

447

end

449

end

448

450

449

def test_destroy_version_attachment

451

def test_destroy_version_attachment

450

set_tmp_attachments_directory

452

set_tmp_attachments_directory

451

@request.session[:user_id] = 2

453

@request.session[:user_id] = 2

452

assert_difference 'Attachment.count', -1 do

454

assert_difference 'Attachment.count', -1 do

453

delete :destroy, :id => 9

455

delete :destroy, :id => 9

454

assert_response 302

456

assert_response 302

455

end

457

end

456

end

458

end

457

459

458

def test_destroy_version_attachment_with_issue_tracking_disabled

460

def test_destroy_version_attachment_with_issue_tracking_disabled

459

Project.find(1).disable_module! :issue_tracking

461

Project.find(1).disable_module! :issue_tracking

460

set_tmp_attachments_directory

462

set_tmp_attachments_directory

461

@request.session[:user_id] = 2

463

@request.session[:user_id] = 2

462

assert_difference 'Attachment.count', -1 do

464

assert_difference 'Attachment.count', -1 do

463

delete :destroy, :id => 9

465

delete :destroy, :id => 9

464

assert_response 302

466

assert_response 302

465

end

467

end

466

end

468

end

467

469

468

def test_destroy_without_permission

470

def test_destroy_without_permission

469

set_tmp_attachments_directory

471

set_tmp_attachments_directory

470

assert_no_difference 'Attachment.count' do

472

assert_no_difference 'Attachment.count' do

471

delete :destroy, :id => 3

473

delete :destroy, :id => 3

472

end

474

end

473

assert_response 302

475

assert_response 302

474

assert Attachment.find_by_id(3)

476

assert Attachment.find_by_id(3)

475

end

477

end

476

end

478

end

@@ -0,0 +1,3
	1	<%= render :layout => 'layouts/file' do %>
	2	<%= render :partial => 'common/other' %>
	3	<% end %>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class AttachmentsController < ApplicationController
               before_filter :find_attachment, :only => [:show, :download, :thumbnail, :destroy]
               before_filter :find_editable_attachments, :only => [:edit, :update]
               before_filter :file_readable, :read_authorize, :only => [:show, :download, :thumbnail]
               before_filter :delete_authorize, :only => :destroy
               before_filter :authorize_global, :only => :upload
               accept_api_auth :show, :download, :thumbnail, :upload, :destroy
               def show
                 respond_to do |format|
                   format.html {
                     if @attachment.is_diff?
                       @diff = File.read(@attachment.diskfile, :mode => "rb")
                       @diff_type = params[:type] || User.current.pref[:diff_type] || 'inline'
                       @diff_type = 'inline' unless %w(inline sbs).include?(@diff_type)
                       # Save diff type as user preference
                       if User.current.logged? && @diff_type != User.current.pref[:diff_type]
                         User.current.pref[:diff_type] = @diff_type
                         User.current.preference.save
                       end
                       render :action => 'diff'
                     elsif @attachment.is_text? && @attachment.filesize <= Setting.file_max_size_displayed.to_i.kilobyte
                       @content = File.read(@attachment.diskfile, :mode => "rb")
                       render :action => 'file'
                     elsif @attachment.is_image?
                       render :action => 'image'
                     else
-                      download
+                      render :action => 'other'
                     end
                   }
                   format.api
                 end
               end
               def download
                 if @attachment.container.is_a?(Version) || @attachment.container.is_a?(Project)
                   @attachment.increment_download
                 end
                 if stale?(:etag => @attachment.digest)
                   # images are sent inline
                   send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
                                                   :type => detect_content_type(@attachment),
                                                   :disposition => (@attachment.image? ? 'inline' : 'attachment')
                 end
               end
               def thumbnail
                 if @attachment.thumbnailable? && tbnail = @attachment.thumbnail(:size => params[:size])
                   if stale?(:etag => tbnail)
                     send_file tbnail,
                       :filename => filename_for_content_disposition(@attachment.filename),
                       :type => detect_content_type(@attachment),
                       :disposition => 'inline'
                   end
                 else
                   # No thumbnail for the attachment or thumbnail could not be created
                   render :nothing => true, :status => 404
                 end
               end
               def upload
                 # Make sure that API users get used to set this content type
                 # as it won't trigger Rails' automatic parsing of the request body for parameters
                 unless request.content_type == 'application/octet-stream'
                   render :nothing => true, :status => 406
                   return
                 end
                 @attachment = Attachment.new(:file => request.raw_post)
                 @attachment.author = User.current
                 @attachment.filename = params[:filename].presence || Redmine::Utils.random_hex(16)
                 @attachment.content_type = params[:content_type].presence
                 saved = @attachment.save
                 respond_to do |format|
                   format.js
                   format.api {
                     if saved
                       render :action => 'upload', :status => :created
                     else
                       render_validation_errors(@attachment)
                     end
                   }
                 end
               end
               def edit
               end
               def update
                 if params[:attachments].is_a?(Hash)
                   if Attachment.update_attachments(@attachments, params[:attachments])
                     redirect_back_or_default home_path
                     return
                   end
                 end
                 render :action => 'edit'
               end
               def destroy
                 if @attachment.container.respond_to?(:init_journal)
                   @attachment.container.init_journal(User.current)
                 end
                 if @attachment.container
                   # Make sure association callbacks are called
                   @attachment.container.attachments.delete(@attachment)
                 else
                   @attachment.destroy
                 end
                 respond_to do |format|
                   format.html { redirect_to_referer_or project_path(@project) }
                   format.js
                   format.api { render_api_ok }
                 end
               end
               private
               def find_attachment
                 @attachment = Attachment.find(params[:id])
                 # Show 404 if the filename in the url is wrong
                 raise ActiveRecord::RecordNotFound if params[:filename] && params[:filename] != @attachment.filename
                 @project = @attachment.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_editable_attachments
                 klass = params[:object_type].to_s.singularize.classify.constantize rescue nil
                 unless klass && klass.reflect_on_association(:attachments)
                   render_404
                   return
                 end
                 @container = klass.find(params[:object_id])
                 if @container.respond_to?(:visible?) && !@container.visible?
                   render_403
                   return
                 end
                 @attachments = @container.attachments.select(&:editable?)
                 if @container.respond_to?(:project)
                   @project = @container.project
                 end
                 render_404 if @attachments.empty?
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Checks that the file exists and is readable
               def file_readable
                 if @attachment.readable?
                   true
                 else
                   logger.error "Cannot send attachment, #{@attachment.diskfile} does not exist or is unreadable."
                   render_404
                 end
               end
               def read_authorize
                 @attachment.visible? ? true : deny_access
               end
               def delete_authorize
                 @attachment.deletable? ? true : deny_access
               end
               def detect_content_type(attachment)
                 content_type = attachment.content_type
                 if content_type.blank? || content_type == "application/octet-stream"
                   content_type = Redmine::MimeType.of(attachment.filename)
                 end
                 content_type.to_s
               end
             end

             # encoding: utf-8
             #
             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class AttachmentsControllerTest < ActionController::TestCase
               fixtures :users, :projects, :roles, :members, :member_roles,
                        :enabled_modules, :issues, :trackers, :attachments,
                        :versions, :wiki_pages, :wikis, :documents
               def setup
                 User.current = nil
                 set_fixtures_attachments_directory
               end
               def teardown
                 set_tmp_attachments_directory
               end
               def test_show_diff
                 ['inline', 'sbs'].each do |dt|
                   # 060719210727_changeset_utf8.diff
                   get :show, :id => 14, :type => dt
                   assert_response :success
                   assert_template 'diff'
                   assert_equal 'text/html', @response.content_type
                   assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/
                   assert_select 'td.line-code', :text => /Demande créée avec succès/
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_replace_cannot_convert_content
                 with_settings :repositories_encodings => 'UTF-8' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_select 'th.filename', :text => /issues_controller.rb\t\(r\?vision 1484\)/
                     assert_select 'td.line-code', :text => /Demande cr\?\?e avec succ\?s/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_show_diff_latin_1
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   ['inline', 'sbs'].each do |dt|
                     # 060719210727_changeset_iso8859-1.diff
                     get :show, :id => 5, :type => dt
                     assert_response :success
                     assert_template 'diff'
                     assert_equal 'text/html', @response.content_type
                     assert_select 'th.filename', :text => /issues_controller.rb\t\(révision 1484\)/
                     assert_select 'td.line-code', :text => /Demande créée avec succès/
                   end
                 end
                 set_tmp_attachments_directory
               end
               def test_save_diff_type
                 user1 = User.find(1)
                 user1.pref[:diff_type] = nil
                 user1.preference.save
                 user = User.find(1)
                 assert_nil user.pref[:diff_type]
                 @request.session[:user_id] = 1 # admin
                 get :show, :id => 5
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "inline", user.pref[:diff_type]
                 get :show, :id => 5, :type => 'sbs'
                 assert_response :success
                 assert_template 'diff'
                 user.reload
                 assert_equal "sbs", user.pref[:diff_type]
               end
               def test_diff_show_filename_in_mercurial_export
                 set_tmp_attachments_directory
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("hg-export.diff", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'hg-export.diff', a.filename
                 get :show, :id => a.id, :type => 'inline'
                 assert_response :success
                 assert_template 'diff'
                 assert_equal 'text/html', @response.content_type
                 assert_select 'th.filename', :text => 'test1.txt'
               end
               def test_show_text_file
                 get :show, :id => 4
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_show_text_file_utf_8
                 set_tmp_attachments_directory
                 a = Attachment.new(:container => Issue.find(1),
                                    :file => uploaded_test_file("japanese-utf-8.txt", "text/plain"),
                                    :author => User.find(1))
                 assert a.save
                 assert_equal 'japanese-utf-8.txt', a.filename
                 str_japanese = "\xe6\x97\xa5\xe6\x9c\xac\xe8\xaa\x9e".force_encoding('UTF-8')
                 get :show, :id => a.id
                 assert_response :success
                 assert_template 'file'
                 assert_equal 'text/html', @response.content_type
                 assert_select 'tr#L1' do
                   assert_select 'th.line-num', :text => '1'
                   assert_select 'td', :text => /#{str_japanese}/
                 end
               end
               def test_show_text_file_replace_cannot_convert_content
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_select 'tr#L7' do
                     assert_select 'th.line-num', :text => '7'
                     assert_select 'td', :text => /Demande cr\?\?e avec succ\?s/
                   end
                 end
               end
               def test_show_text_file_latin_1
                 set_tmp_attachments_directory
                 with_settings :repositories_encodings => 'UTF-8,ISO-8859-1' do
                   a = Attachment.new(:container => Issue.find(1),
                                      :file => uploaded_test_file("iso8859-1.txt", "text/plain"),
                                      :author => User.find(1))
                   assert a.save
                   assert_equal 'iso8859-1.txt', a.filename
                   get :show, :id => a.id
                   assert_response :success
                   assert_template 'file'
                   assert_equal 'text/html', @response.content_type
                   assert_select 'tr#L7' do
                     assert_select 'th.line-num', :text => '7'
                     assert_select 'td', :text => /Demande créée avec succès/
                   end
                 end
               end
-              def test_show_text_file_should_send_if_too_big
+              def test_show_text_file_should_show_other_if_too_big
                 with_settings :file_max_size_displayed => 512 do
                   Attachment.find(4).update_attribute :filesize, 754.kilobyte
                   get :show, :id => 4
                   assert_response :success
-                  assert_equal 'application/x-ruby', @response.content_type
+                  assert_template 'other'
+                  assert_equal 'text/html', @response.content_type
                 end
                 set_tmp_attachments_directory
               end
               def test_show_image
                 @request.session[:user_id] = 2
                 get :show, :id => 16
                 assert_response :success
                 assert_template 'image'
                 assert_equal 'text/html', @response.content_type
                 assert_select 'img.filecontent', :src => attachments(:attachments_010).filename
               end
               def test_show_other
                 get :show, :id => 6
-                assert_response :success
+                assert_template 'other'
-                assert_equal 'application/zip', @response.content_type
+                assert_equal 'text/html', @response.content_type
+                assert_select '.nodata', :text => 'No preview available'
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_without_permission
                 get :show, :id => 15
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2F15'
                 set_tmp_attachments_directory
               end
               def test_show_file_from_private_issue_with_permission
                 @request.session[:user_id] = 2
                 get :show, :id => 15
                 assert_response :success
                 assert_select 'h2', :text => /private.diff/
                 set_tmp_attachments_directory
               end
               def test_show_file_without_container_should_be_allowed_to_author
                 set_tmp_attachments_directory
                 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
                 @request.session[:user_id] = 2
                 get :show, :id => attachment.id
                 assert_response 200
               end
               def test_show_file_without_container_should_be_denied_to_other_users
                 set_tmp_attachments_directory
                 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
                 @request.session[:user_id] = 3
                 get :show, :id => attachment.id
                 assert_response 403
               end
               def test_show_invalid_should_respond_with_404
                 get :show, :id => 999
                 assert_response 404
               end
               def test_download_text_file
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'application/x-ruby', @response.content_type
                 etag = @response.etag
                 assert_not_nil etag
                 @request.env["HTTP_IF_NONE_MATCH"] = etag
                 get :download, :id => 4
                 assert_response 304
                 set_tmp_attachments_directory
               end
               def test_download_version_file_with_issue_tracking_disabled
                 Project.find(1).disable_module! :issue_tracking
                 get :download, :id => 9
                 assert_response :success
               end
               def test_download_should_assign_content_type_if_blank
                 Attachment.find(4).update_attribute(:content_type, '')
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'text/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_should_assign_better_content_type_than_application_octet_stream
                 Attachment.find(4).update! :content_type => "application/octet-stream"
                 get :download, :id => 4
                 assert_response :success
                 assert_equal 'text/x-ruby', @response.content_type
                 set_tmp_attachments_directory
               end
               def test_download_missing_file
                 get :download, :id => 2
                 assert_response 404
                 set_tmp_attachments_directory
               end
               def test_download_should_be_denied_without_permission
                 get :download, :id => 7
                 assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fdownload%2F7'
                 set_tmp_attachments_directory
               end
               if convert_installed?
                 def test_thumbnail
                   Attachment.clear_thumbnails
                   @request.session[:user_id] = 2
                   get :thumbnail, :id => 16
                   assert_response :success
                   assert_equal 'image/png', response.content_type
                   etag = @response.etag
                   assert_not_nil etag
                   @request.env["HTTP_IF_NONE_MATCH"] = etag
                   get :thumbnail, :id => 16
                   assert_response 304
                 end
                 def test_thumbnail_should_not_exceed_maximum_size
                   Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 800}
                   @request.session[:user_id] = 2
                   get :thumbnail, :id => 16, :size => 2000
                 end
                 def test_thumbnail_should_round_size
                   Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 250}
                   @request.session[:user_id] = 2
                   get :thumbnail, :id => 16, :size => 260
                 end
                 def test_thumbnail_should_return_404_for_non_image_attachment
                   @request.session[:user_id] = 2
                   get :thumbnail, :id => 15
                   assert_response 404
                 end
                 def test_thumbnail_should_return_404_if_thumbnail_generation_failed
                   Attachment.any_instance.stubs(:thumbnail).returns(nil)
                   @request.session[:user_id] = 2
                   get :thumbnail, :id => 16
                   assert_response 404
                 end
                 def test_thumbnail_should_be_denied_without_permission
                   get :thumbnail, :id => 16
                   assert_redirected_to '/login?back_url=http%3A%2F%2Ftest.host%2Fattachments%2Fthumbnail%2F16'
                 end
               else
                 puts '(ImageMagick convert not available)'
               end
               def test_edit
                 @request.session[:user_id] = 2
                 get :edit, :object_type => 'issues', :object_id => '2'
                 assert_response :success
                 assert_template 'edit'
                 container = Issue.find(2)
                 assert_equal container, assigns(:container)
                 assert_equal container.attachments.size, assigns(:attachments).size
                 assert_select 'form[action=?]', '/attachments/issues/2' do
                   assert_select 'tr#attachment-4' do
                     assert_select 'input[name=?][value=?]', 'attachments[4][filename]', 'source.rb'
                     assert_select 'input[name=?][value=?]', 'attachments[4][description]', 'This is a Ruby source file'
                   end
                 end
               end
               def test_edit_invalid_container_class_should_return_404
                 get :edit, :object_type => 'nuggets', :object_id => '3'
                 assert_response 404
               end
               def test_edit_invalid_object_should_return_404
                 get :edit, :object_type => 'issues', :object_id => '999'
                 assert_response 404
               end
               def test_edit_for_object_that_is_not_visible_should_return_403
                 get :edit, :object_type => 'issues', :object_id => '4'
                 assert_response 403
               end
               def test_update
                 @request.session[:user_id] = 2
                 patch :update, :object_type => 'issues', :object_id => '2', :attachments => {
                     '1' => {:filename => 'newname.text', :description => ''},
                     '4' => {:filename => 'newname.rb', :description => 'Renamed'},
                   }
                 assert_response 302
                 attachment = Attachment.find(4)
                 assert_equal 'newname.rb', attachment.filename
                 assert_equal 'Renamed', attachment.description
               end
               def test_update_with_failure
                 @request.session[:user_id] = 2
                 patch :update, :object_type => 'issues', :object_id => '3', :attachments => {
                     '1' => {:filename => '', :description => ''},
                     '4' => {:filename => 'newname.rb', :description => 'Renamed'},
                   }
                 assert_response :success
                 assert_template 'edit'
                 assert_select_error /file cannot be blank/i
                 # The other attachment should not be updated
                 attachment = Attachment.find(4)
                 assert_equal 'source.rb', attachment.filename
                 assert_equal 'This is a Ruby source file', attachment.description
               end
               def test_destroy_issue_attachment
                 set_tmp_attachments_directory
                 issue = Issue.find(3)
                 @request.session[:user_id] = 2
                 assert_difference 'issue.attachments.count', -1 do
                   assert_difference 'Journal.count' do
                     delete :destroy, :id => 1
                     assert_redirected_to '/projects/ecookbook'
                   end
                 end
                 assert_nil Attachment.find_by_id(1)
                 j = Journal.order('id DESC').first
                 assert_equal issue, j.journalized
                 assert_equal 'attachment', j.details.first.property
                 assert_equal '1', j.details.first.prop_key
                 assert_equal 'error281.txt', j.details.first.old_value
                 assert_equal User.find(2), j.user
               end
               def test_destroy_wiki_page_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 3
                   assert_response 302
                 end
               end
               def test_destroy_project_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 8
                   assert_response 302
                 end
               end
               def test_destroy_version_attachment
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 9
                   assert_response 302
                 end
               end
               def test_destroy_version_attachment_with_issue_tracking_disabled
                 Project.find(1).disable_module! :issue_tracking
                 set_tmp_attachments_directory
                 @request.session[:user_id] = 2
                 assert_difference 'Attachment.count', -1 do
                   delete :destroy, :id => 9
                   assert_response 302
                 end
               end
               def test_destroy_without_permission
                 set_tmp_attachments_directory
                 assert_no_difference 'Attachment.count' do
                   delete :destroy, :id => 3
                 end
                 assert_response 302
                 assert Attachment.find_by_id(3)
               end
             end