jro_apps/redmine Commit - r12710:b29c48717d8d

Fixed: Error generated on 'search for watchers to add' after clicking add without selected users (#14298)....

Jean-Philippe Lang -

r12710:b29c48717d8d

parent child

Context file:

r12710:b29c48717d8d

app/controllers/watchers_controller.rb +3 0

                    user_ids = params[:watcher][:user_ids] || [params[:watcher][:user_id]]
                    @users = User.active.where(:id => user_ids).all
                  end
+                 if @users.blank?
+                   render :nothing => true
+                 end
                end
                def destroy

test/functional/watchers_controller_test.rb +7 0

                  end
                end
+               def test_append_without_user_should_render_nothing
+                 @request.session[:user_id] = 2
+                 xhr :post, :append, :project_id => 'ecookbook'
+                 assert_response :success
+                 assert response.body.blank?
+               end
                def test_remove_watcher
                  @request.session[:user_id] = 2
                  assert_difference('Watcher.count', -1) do

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages