jro_apps/redmine Commit - r890:b0a8888e356a

Fixed: admin should be able to move issues to any project....

Jean-Philippe Lang -

r890:b0a8888e356a

parent child

Context file:

r890:b0a8888e356a

app/controllers/projects_controller.rb +7 -2

                 redirect_to :controller => 'issues', :action => 'index', :project_id => @project and return unless @issues
                 @projects = []
                 # find projects to which the user is allowed to move the issue
-                User.current.memberships.each {|m| @projects << m.project if m.role.allowed_to?(:controller => 'projects', :action => 'move_issues')}
+                if User.current.admin?
+                  # admin is allowed to move issues to any active (visible) project
+                  @projects = Project.find(:all, :conditions => Project.visible_by(User.current), :order => 'name')
+                else
+                  User.current.memberships.each {|m| @projects << m.project if m.role.allowed_to?(:controller => 'projects', :action => 'move_issues')}
+                end
                 # issue can be moved to any tracker
                 @trackers = Tracker.find(:all)
-                if request.post? and params[:new_project_id] and params[:new_tracker_id]
+                if request.post? && params[:new_project_id] && @projects.collect(&:id).include?(params[:new_project_id].to_i) && params[:new_tracker_id]
                   new_project = Project.find_by_id(params[:new_project_id])
                   new_tracker = Tracker.find_by_id(params[:new_tracker_id])
                   @issues.each do |i|

app/views/projects/move_issues.rhtml +1 -1

             <%= select_tag "new_project_id", options_from_collection_for_select(@projects, "id", "name", @project.id) %></p>
             <p><label for="new_tracker_id"><%=l(:field_tracker)%> :</label>
-            <%= select_tag "new_tracker_id", '<option></option>' + options_from_collection_for_select(@trackers, "id", "name") %></p>
+            <%= select_tag "new_tracker_id", "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, "id", "name") %></p>
             </div>
             <%= submit_tag l(:button_move) %>
             <% end %>

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages