jro_apps/redmine Commit - r10409:ad94777d9c24

Expose roles details via REST API (#11502)....

Jean-Philippe Lang -

r10409:ad94777d9c24

parent child

Context file:

r10409:ad94777d9c24

app/views/roles/show.api.rsb created 644 +9 0

@@ -0,0 +1,9
	1	api.role do
	2	api.id @role.id
	3	api.name @role.name
	4	api.array :permissions do
	5	@role.permissions.each do \|perm\|
	6	api.permission(perm.to_s)
	7	end
	8	end
	9	end

app/controllers/roles_controller.rb +9 -4

             class RolesController < ApplicationController
               layout 'admin'
-              before_filter :require_admin, :except => :index
+              before_filter :require_admin, :except => [:index, :show]
-              before_filter :require_admin_or_api_request, :only => :index
+              before_filter :require_admin_or_api_request, :only => [:index, :show]
-              before_filter :find_role, :only => [:edit, :update, :destroy]
+              before_filter :find_role, :only => [:show, :edit, :update, :destroy]
-              accept_api_auth :index
               def index
                 respond_to do |format|
                 end
               end
+              def show
+                respond_to do |format|
+                  format.api
+                end
+              end
               def new
                 # Prefills the form with 'Non member' role permissions by default
                 @role = Role.new(params[:role] || {:permissions => Role.non_member.permissions})

config/routes.rb +1 -1

                 end
               end
               resources :custom_fields, :except => :show
-              resources :roles, :except => :show do
+              resources :roles do
                 collection do
                   match 'permissions', :via => [:get, :post]
                 end

test/integration/api_test/roles_test.rb +21 0

@@ -66,4 +66,25 class ApiTest::RolesTest < ActionController::IntegrationTest
66	end	66	end
67	end	67	end
68	end	68	end
		69
		70	context "/roles/:id" do
		71	context "GET" do
		72	context "xml" do
		73	should "return the role" do
		74	get '/roles/1.xml'
		75
		76	assert_response :success
		77	assert_equal 'application/xml', @response.content_type
		78
		79	assert_select 'role' do
		80	assert_select 'name', :text => 'Manager'
		81	assert_select 'role permissions[type=array]' do
		82	assert_select 'permission', Role.find(1).permissions.size
		83	assert_select 'permission', :text => 'view_issues'
		84	end
		85	end
		86	end
		87	end
		88	end
		89	end
69	end	90	end

test/integration/routing/roles_test.rb +4 0

                     { :controller => 'roles', :action => 'index', :format => 'xml' }
                   )
                 assert_routing(
+                    { :method => 'get', :path => "/roles/2.xml" },
+                    { :controller => 'roles', :action => 'show', :id => '2', :format => 'xml' }
+                  )
+                assert_routing(
                     { :method => 'get', :path => "/roles/new" },
                     { :controller => 'roles', :action => 'new' }
                   )

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages