jro_apps/redmine Commit - r14592:ad8a529c8dbe

Option to show email adresses by default for new users (#21447)....

Jean-Philippe Lang -

r14592:ad8a529c8dbe

parent child

Context file:

r14592:ad8a529c8dbe

app/models/user_preference.rb +3 0

               def initialize(attributes=nil, *args)
                 super
+                if new_record? && !(attributes && attributes.key?(:hide_mail))
+                  self.hide_mail = Setting.default_users_hide_mail?
+                end
                 self.others ||= {}
               end

app/views/settings/_authentication.html.erb +8 0

@@ -36,5 +36,13
36	<p><em class="info"><%= l(:text_session_expiration_settings) %></em></p>	36	<p><em class="info"><%= l(:text_session_expiration_settings) %></em></p>
37	</fieldset>	37	</fieldset>
38		38
		39	<fieldset class="box">
		40	<legend><%= l(:label_default_values_for_new_users) %></legend>
		41
		42	<div class="tabular settings">
		43	<p><%= setting_check_box :default_users_hide_mail, :label => :field_hide_mail %></p>
		44	</div>
		45	</fieldset>
		46
39	<%= submit_tag l(:button_save) %>	47	<%= submit_tag l(:button_save) %>
40	<% end %>	48	<% end %>

config/locales/en.yml +1 0

               label_create_missing_values: Create missing values
               label_api: API
               label_field_format_enumeration: Key/value list
+              label_default_values_for_new_users: Default values for new users
               button_login: Login
               button_submit: Submit

config/locales/fr.yml +1 0

               label_create_missing_values: Créer les valeurs manquantes
               label_api: API
               label_field_format_enumeration: Liste clé/valeur
+              label_default_values_for_new_users: Valeurs par défaut pour les nouveaux utilisateurs
               button_login: Connexion
               button_submit: Soumettre

config/settings.yml +2 0

               default: 0
             # encodings used to convert repository files content to UTF-8
             # multiple values accepted, comma separated
+            default_users_hide_mail:
+              default: 1
             repositories_encodings:
               default: ''
             # encoding used to convert commit logs to UTF-8

test/unit/user_preference_test.rb +7 0

                 assert_equal true, preference.hide_mail
               end
+              def test_hide_mail_should_default_to_false_with_setting
+                with_settings :default_users_hide_mail => '0' do
+                  preference = UserPreference.new
+                  assert_equal false, preference.hide_mail
+                end
+              end
               def test_create
                 user = User.new(:firstname => "new", :lastname => "user", :mail => "newuser@somenet.foo")
                 user.login = "newuser"

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages