##// END OF EJS Templates
jro_apps » redmine
RSS
Code cleanup, use named routes....
Jean-Philippe Lang -
r10841:ad246e81ad52
parent child
Show More
Side by Side Unified
Context file:
r10841:ad246e81ad52 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,150 +1,150
1 1 <h2><%= @copy ? l(:button_copy) : l(:label_bulk_edit_selected_issues) %></h2>
2 2
3 <ul>
3 <ul id="bulk-selection">
4 4 <% @issues.each do |issue| %>
5 5 <%= content_tag 'li', link_to_issue(issue) %>
6 6 <% end %>
7 7 </ul>
8 8
9 <%= form_tag({:action => 'bulk_update'}, :id => 'bulk_edit_form') do %>
9 <%= form_tag(bulk_update_issues_path, :id => 'bulk_edit_form') do %>
10 10 <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join("\n").html_safe %>
11 11 <div class="box tabular">
12 12 <fieldset class="attributes">
13 13 <legend><%= l(:label_change_properties) %></legend>
14 14
15 15 <div class="splitcontentleft">
16 16 <% if @allowed_projects.present? %>
17 17 <p>
18 18 <label for="issue_project_id"><%= l(:field_project) %></label>
19 19 <%= select_tag('issue[project_id]', content_tag('option', l(:label_no_change_option), :value => '') + project_tree_options_for_select(@allowed_projects, :selected => @target_project),
20 20 :onchange => "updateBulkEditFrom('#{escape_javascript url_for(:action => 'bulk_edit', :format => 'js')}')") %>
21 21 </p>
22 22 <% end %>
23 23 <p>
24 24 <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
25 25 <%= select_tag('issue[tracker_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@trackers, :id, :name)) %>
26 26 </p>
27 27 <% if @available_statuses.any? %>
28 28 <p>
29 29 <label for='issue_status_id'><%= l(:field_status) %></label>
30 30 <%= select_tag('issue[status_id]',content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@available_statuses, :id, :name)) %>
31 31 </p>
32 32 <% end %>
33 33
34 34 <% if @safe_attributes.include?('priority_id') -%>
35 35 <p>
36 36 <label for='issue_priority_id'><%= l(:field_priority) %></label>
37 37 <%= select_tag('issue[priority_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
38 38 </p>
39 39 <% end %>
40 40
41 41 <% if @safe_attributes.include?('assigned_to_id') -%>
42 42 <p>
43 43 <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
44 44 <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
45 45 content_tag('option', l(:label_nobody), :value => 'none') +
46 46 principals_options_for_select(@assignables)) %>
47 47 </p>
48 48 <% end %>
49 49
50 50 <% if @safe_attributes.include?('category_id') -%>
51 51 <p>
52 52 <label for='issue_category_id'><%= l(:field_category) %></label>
53 53 <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
54 54 content_tag('option', l(:label_none), :value => 'none') +
55 55 options_from_collection_for_select(@categories, :id, :name)) %>
56 56 </p>
57 57 <% end %>
58 58
59 59 <% if @safe_attributes.include?('fixed_version_id') -%>
60 60 <p>
61 61 <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
62 62 <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
63 63 content_tag('option', l(:label_none), :value => 'none') +
64 64 version_options_for_select(@versions.sort)) %>
65 65 </p>
66 66 <% end %>
67 67
68 68 <% @custom_fields.each do |custom_field| %>
69 69 <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
70 70 <% end %>
71 71
72 72 <% if @copy && @attachments_present %>
73 73 <p>
74 74 <label for='copy_attachments'><%= l(:label_copy_attachments) %></label>
75 75 <%= check_box_tag 'copy_attachments', '1', true %>
76 76 </p>
77 77 <% end %>
78 78
79 79 <% if @copy && @subtasks_present %>
80 80 <p>
81 81 <label for='copy_subtasks'><%= l(:label_copy_subtasks) %></label>
82 82 <%= check_box_tag 'copy_subtasks', '1', true %>
83 83 </p>
84 84 <% end %>
85 85
86 86 <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
87 87 </div>
88 88
89 89 <div class="splitcontentright">
90 90 <% if @safe_attributes.include?('is_private') %>
91 91 <p>
92 92 <label for='issue_is_private'><%= l(:field_is_private) %></label>
93 93 <%= select_tag('issue[is_private]', content_tag('option', l(:label_no_change_option), :value => '') +
94 94 content_tag('option', l(:general_text_Yes), :value => '1') +
95 95 content_tag('option', l(:general_text_No), :value => '0')) %>
96 96 </p>
97 97 <% end %>
98 98
99 99 <% if @safe_attributes.include?('parent_issue_id') && @project %>
100 100 <p>
101 101 <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
102 102 <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
103 103 </p>
104 104 <%= javascript_tag "observeAutocompleteField('issue_parent_issue_id', '#{escape_javascript auto_complete_issues_path(:project_id => @project)}')" %>
105 105 <% end %>
106 106
107 107 <% if @safe_attributes.include?('start_date') %>
108 108 <p>
109 109 <label for='issue_start_date'><%= l(:field_start_date) %></label>
110 110 <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
111 111 </p>
112 112 <% end %>
113 113
114 114 <% if @safe_attributes.include?('due_date') %>
115 115 <p>
116 116 <label for='issue_due_date'><%= l(:field_due_date) %></label>
117 117 <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
118 118 </p>
119 119 <% end %>
120 120
121 121 <% if @safe_attributes.include?('done_ratio') && Issue.use_field_for_done_ratio? %>
122 122 <p>
123 123 <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
124 124 <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
125 125 </p>
126 126 <% end %>
127 127 </div>
128 128
129 129 </fieldset>
130 130
131 131 <fieldset><legend><%= l(:field_notes) %></legend>
132 132 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
133 133 <%= wikitoolbar_for 'notes' %>
134 134 </fieldset>
135 135 </div>
136 136
137 137 <p>
138 138 <% if @copy %>
139 139 <%= hidden_field_tag 'copy', '1' %>
140 140 <%= submit_tag l(:button_copy) %>
141 141 <%= submit_tag l(:button_copy_and_follow), :name => 'follow' %>
142 142 <% elsif @target_project %>
143 143 <%= submit_tag l(:button_move) %>
144 144 <%= submit_tag l(:button_move_and_follow), :name => 'follow' %>
145 145 <% else %>
146 146 <%= submit_tag l(:button_submit) %>
147 147 <% end %>
148 148 </p>
149 149
150 150 <% end %>
Show file before | Show file after | Hide comments
@@ -1,50 +1,50
1 1 <h2><%= l(:label_bulk_edit_selected_time_entries) %></h2>
2 2
3 <ul>
3 <ul id="bulk-selection">
4 4 <% @time_entries.each do |entry| %>
5 5 <%= content_tag 'li',
6 6 link_to("#{format_date(entry.spent_on)} - #{entry.project}: #{l(:label_f_hour_plural, :value => entry.hours)}", edit_time_entry_path(entry)) %>
7 7 <% end %>
8 8 </ul>
9 9
10 <%= form_tag(:action => 'bulk_update') do %>
10 <%= form_tag(bulk_update_time_entries_path, :id => 'bulk_edit_form') do %>
11 11 <%= @time_entries.collect {|i| hidden_field_tag('ids[]', i.id)}.join.html_safe %>
12 12 <div class="box tabular">
13 13 <div>
14 14 <p>
15 15 <label><%= l(:field_issue) %></label>
16 16 <%= text_field :time_entry, :issue_id, :size => 6 %>
17 17 </p>
18 18
19 19 <p>
20 20 <label><%= l(:field_spent_on) %></label>
21 21 <%= text_field :time_entry, :spent_on, :size => 10 %><%= calendar_for('time_entry_spent_on') %>
22 22 </p>
23 23
24 24 <p>
25 25 <label><%= l(:field_hours) %></label>
26 26 <%= text_field :time_entry, :hours, :size => 6 %>
27 27 </p>
28 28
29 29 <% if @available_activities.any? %>
30 30 <p>
31 31 <label><%= l(:field_activity) %></label>
32 32 <%= select_tag('time_entry[activity_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@available_activities, :id, :name)) %>
33 33 </p>
34 34 <% end %>
35 35
36 36 <p>
37 37 <label><%= l(:field_comments) %></label>
38 38 <%= text_field(:time_entry, :comments, :size => 100) %>
39 39 </p>
40 40
41 41 <% @custom_fields.each do |custom_field| %>
42 42 <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('time_entry', custom_field, @projects) %></p>
43 43 <% end %>
44 44
45 45 <%= call_hook(:view_time_entries_bulk_edit_details_bottom, { :time_entries => @time_entries }) %>
46 46 </div>
47 47 </div>
48 48
49 49 <p><%= submit_tag l(:button_submit) %></p>
50 50 <% end %>
Show file before | Show file after | Hide comments
@@ -1,3848 +1,3858
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :versions,
29 29 :trackers,
30 30 :projects_trackers,
31 31 :issue_categories,
32 32 :enabled_modules,
33 33 :enumerations,
34 34 :attachments,
35 35 :workflows,
36 36 :custom_fields,
37 37 :custom_values,
38 38 :custom_fields_projects,
39 39 :custom_fields_trackers,
40 40 :time_entries,
41 41 :journals,
42 42 :journal_details,
43 43 :queries,
44 44 :repositories,
45 45 :changesets
46 46
47 47 include Redmine::I18n
48 48
49 49 def setup
50 50 User.current = nil
51 51 end
52 52
53 53 def test_index
54 54 with_settings :default_language => "en" do
55 55 get :index
56 56 assert_response :success
57 57 assert_template 'index'
58 58 assert_not_nil assigns(:issues)
59 59 assert_nil assigns(:project)
60 60
61 61 # links to visible issues
62 62 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
63 63 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
64 64 # private projects hidden
65 65 assert_select 'a[href=/issues/6]', 0
66 66 assert_select 'a[href=/issues/4]', 0
67 67 # project column
68 68 assert_select 'th', :text => /Project/
69 69 end
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79
80 80 assert_select 'a[href=/issues/1]', 0
81 81 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_list_visible_issues_only
85 85 get :index, :per_page => 100
86 86 assert_response :success
87 87 assert_not_nil assigns(:issues)
88 88 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
89 89 end
90 90
91 91 def test_index_with_project
92 92 Setting.display_subprojects_issues = 0
93 93 get :index, :project_id => 1
94 94 assert_response :success
95 95 assert_template 'index'
96 96 assert_not_nil assigns(:issues)
97 97
98 98 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
99 99 assert_select 'a[href=/issues/5]', 0
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108
109 109 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
110 110 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
111 111 assert_select 'a[href=/issues/6]', 0
112 112 end
113 113
114 114 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
115 115 @request.session[:user_id] = 2
116 116 Setting.display_subprojects_issues = 1
117 117 get :index, :project_id => 1
118 118 assert_response :success
119 119 assert_template 'index'
120 120 assert_not_nil assigns(:issues)
121 121
122 122 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
123 123 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
124 124 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
125 125 end
126 126
127 127 def test_index_with_project_and_default_filter
128 128 get :index, :project_id => 1, :set_filter => 1
129 129 assert_response :success
130 130 assert_template 'index'
131 131 assert_not_nil assigns(:issues)
132 132
133 133 query = assigns(:query)
134 134 assert_not_nil query
135 135 # default filter
136 136 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
137 137 end
138 138
139 139 def test_index_with_project_and_filter
140 140 get :index, :project_id => 1, :set_filter => 1,
141 141 :f => ['tracker_id'],
142 142 :op => {'tracker_id' => '='},
143 143 :v => {'tracker_id' => ['1']}
144 144 assert_response :success
145 145 assert_template 'index'
146 146 assert_not_nil assigns(:issues)
147 147
148 148 query = assigns(:query)
149 149 assert_not_nil query
150 150 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
151 151 end
152 152
153 153 def test_index_with_short_filters
154 154 to_test = {
155 155 'status_id' => {
156 156 'o' => { :op => 'o', :values => [''] },
157 157 'c' => { :op => 'c', :values => [''] },
158 158 '7' => { :op => '=', :values => ['7'] },
159 159 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
160 160 '=7' => { :op => '=', :values => ['7'] },
161 161 '!3' => { :op => '!', :values => ['3'] },
162 162 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
163 163 'subject' => {
164 164 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
165 165 'o' => { :op => '=', :values => ['o'] },
166 166 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
167 167 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
168 168 'tracker_id' => {
169 169 '3' => { :op => '=', :values => ['3'] },
170 170 '=3' => { :op => '=', :values => ['3'] }},
171 171 'start_date' => {
172 172 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
175 175 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
176 176 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
177 177 '<t+2' => { :op => '<t+', :values => ['2'] },
178 178 '>t+2' => { :op => '>t+', :values => ['2'] },
179 179 't+2' => { :op => 't+', :values => ['2'] },
180 180 't' => { :op => 't', :values => [''] },
181 181 'w' => { :op => 'w', :values => [''] },
182 182 '>t-2' => { :op => '>t-', :values => ['2'] },
183 183 '<t-2' => { :op => '<t-', :values => ['2'] },
184 184 't-2' => { :op => 't-', :values => ['2'] }},
185 185 'created_on' => {
186 186 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
187 187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 188 '>t-2' => { :op => '>t-', :values => ['2'] },
189 189 't-2' => { :op => 't-', :values => ['2'] }},
190 190 'cf_1' => {
191 191 'c' => { :op => '=', :values => ['c'] },
192 192 '!c' => { :op => '!', :values => ['c'] },
193 193 '!*' => { :op => '!*', :values => [''] },
194 194 '*' => { :op => '*', :values => [''] }},
195 195 'estimated_hours' => {
196 196 '=13.4' => { :op => '=', :values => ['13.4'] },
197 197 '>=45' => { :op => '>=', :values => ['45'] },
198 198 '<=125' => { :op => '<=', :values => ['125'] },
199 199 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
200 200 '!*' => { :op => '!*', :values => [''] },
201 201 '*' => { :op => '*', :values => [''] }}
202 202 }
203 203
204 204 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
205 205
206 206 to_test.each do |field, expression_and_expected|
207 207 expression_and_expected.each do |filter_expression, expected|
208 208
209 209 get :index, :set_filter => 1, field => filter_expression
210 210
211 211 assert_response :success
212 212 assert_template 'index'
213 213 assert_not_nil assigns(:issues)
214 214
215 215 query = assigns(:query)
216 216 assert_not_nil query
217 217 assert query.has_filter?(field)
218 218 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
219 219 end
220 220 end
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_project_custom_field_filter
236 236 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
237 237 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
239 239 filter_name = "project.cf_#{field.id}"
240 240 @request.session[:user_id] = 1
241 241
242 242 get :index, :set_filter => 1,
243 243 :f => [filter_name],
244 244 :op => {filter_name => '='},
245 245 :v => {filter_name => ['Foo']}
246 246 assert_response :success
247 247 assert_template 'index'
248 248 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
249 249 end
250 250
251 251 def test_index_with_query
252 252 get :index, :project_id => 1, :query_id => 5
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_grouped_by_tracker
260 260 get :index, :project_id => 1, :query_id => 6
261 261 assert_response :success
262 262 assert_template 'index'
263 263 assert_not_nil assigns(:issues)
264 264 assert_not_nil assigns(:issue_count_by_group)
265 265 end
266 266
267 267 def test_index_with_query_grouped_by_list_custom_field
268 268 get :index, :project_id => 1, :query_id => 9
269 269 assert_response :success
270 270 assert_template 'index'
271 271 assert_not_nil assigns(:issues)
272 272 assert_not_nil assigns(:issue_count_by_group)
273 273 end
274 274
275 275 def test_index_with_query_grouped_by_user_custom_field
276 276 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
279 279 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
280 280 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
281 281
282 282 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
283 283 assert_response :success
284 284
285 285 assert_select 'tr.group', 3
286 286 assert_select 'tr.group' do
287 287 assert_select 'a', :text => 'John Smith'
288 288 assert_select 'span.count', :text => '1'
289 289 end
290 290 assert_select 'tr.group' do
291 291 assert_select 'a', :text => 'Dave Lopper'
292 292 assert_select 'span.count', :text => '2'
293 293 end
294 294 end
295 295
296 296 def test_index_with_query_grouped_by_tracker
297 297 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
298 298
299 299 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
300 300 assert_response :success
301 301
302 302 trackers = assigns(:issues).map(&:tracker).uniq
303 303 assert_equal [1, 2, 3], trackers.map(&:id)
304 304 end
305 305
306 306 def test_index_with_query_grouped_by_tracker_in_reverse_order
307 307 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
308 308
309 309 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
310 310 assert_response :success
311 311
312 312 trackers = assigns(:issues).map(&:tracker).uniq
313 313 assert_equal [3, 2, 1], trackers.map(&:id)
314 314 end
315 315
316 316 def test_index_with_query_id_and_project_id_should_set_session_query
317 317 get :index, :project_id => 1, :query_id => 4
318 318 assert_response :success
319 319 assert_kind_of Hash, session[:query]
320 320 assert_equal 4, session[:query][:id]
321 321 assert_equal 1, session[:query][:project_id]
322 322 end
323 323
324 324 def test_index_with_invalid_query_id_should_respond_404
325 325 get :index, :project_id => 1, :query_id => 999
326 326 assert_response 404
327 327 end
328 328
329 329 def test_index_with_cross_project_query_in_session_should_show_project_issues
330 330 q = IssueQuery.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
331 331 @request.session[:query] = {:id => q.id, :project_id => 1}
332 332
333 333 with_settings :display_subprojects_issues => '0' do
334 334 get :index, :project_id => 1
335 335 end
336 336 assert_response :success
337 337 assert_not_nil assigns(:query)
338 338 assert_equal q.id, assigns(:query).id
339 339 assert_equal 1, assigns(:query).project_id
340 340 assert_equal [1], assigns(:issues).map(&:project_id).uniq
341 341 end
342 342
343 343 def test_private_query_should_not_be_available_to_other_users
344 344 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
345 345 @request.session[:user_id] = 3
346 346
347 347 get :index, :query_id => q.id
348 348 assert_response 403
349 349 end
350 350
351 351 def test_private_query_should_be_available_to_its_user
352 352 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
353 353 @request.session[:user_id] = 2
354 354
355 355 get :index, :query_id => q.id
356 356 assert_response :success
357 357 end
358 358
359 359 def test_public_query_should_be_available_to_other_users
360 360 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
361 361 @request.session[:user_id] = 3
362 362
363 363 get :index, :query_id => q.id
364 364 assert_response :success
365 365 end
366 366
367 367 def test_index_should_omit_page_param_in_export_links
368 368 get :index, :page => 2
369 369 assert_response :success
370 370 assert_select 'a.atom[href=/issues.atom]'
371 371 assert_select 'a.csv[href=/issues.csv]'
372 372 assert_select 'a.pdf[href=/issues.pdf]'
373 373 assert_select 'form#csv-export-form[action=/issues.csv]'
374 374 end
375 375
376 376 def test_index_csv
377 377 get :index, :format => 'csv'
378 378 assert_response :success
379 379 assert_not_nil assigns(:issues)
380 380 assert_equal 'text/csv; header=present', @response.content_type
381 381 assert @response.body.starts_with?("#,")
382 382 lines = @response.body.chomp.split("\n")
383 383 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
384 384 end
385 385
386 386 def test_index_csv_with_project
387 387 get :index, :project_id => 1, :format => 'csv'
388 388 assert_response :success
389 389 assert_not_nil assigns(:issues)
390 390 assert_equal 'text/csv; header=present', @response.content_type
391 391 end
392 392
393 393 def test_index_csv_with_description
394 394 get :index, :format => 'csv', :description => '1'
395 395 assert_response :success
396 396 assert_not_nil assigns(:issues)
397 397 assert_equal 'text/csv; header=present', @response.content_type
398 398 assert @response.body.starts_with?("#,")
399 399 lines = @response.body.chomp.split("\n")
400 400 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
401 401 end
402 402
403 403 def test_index_csv_with_spent_time_column
404 404 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
405 405 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
406 406
407 407 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
408 408 assert_response :success
409 409 assert_equal 'text/csv; header=present', @response.content_type
410 410 lines = @response.body.chomp.split("\n")
411 411 assert_include "#{issue.id},#{issue.subject},7.33", lines
412 412 end
413 413
414 414 def test_index_csv_with_all_columns
415 415 get :index, :format => 'csv', :columns => 'all'
416 416 assert_response :success
417 417 assert_not_nil assigns(:issues)
418 418 assert_equal 'text/csv; header=present', @response.content_type
419 419 assert @response.body.starts_with?("#,")
420 420 lines = @response.body.chomp.split("\n")
421 421 assert_equal assigns(:query).available_inline_columns.size + 1, lines[0].split(',').size
422 422 end
423 423
424 424 def test_index_csv_with_multi_column_field
425 425 CustomField.find(1).update_attribute :multiple, true
426 426 issue = Issue.find(1)
427 427 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
428 428 issue.save!
429 429
430 430 get :index, :format => 'csv', :columns => 'all'
431 431 assert_response :success
432 432 lines = @response.body.chomp.split("\n")
433 433 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
434 434 end
435 435
436 436 def test_index_csv_big_5
437 437 with_settings :default_language => "zh-TW" do
438 438 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
439 439 str_big5 = "\xa4@\xa4\xeb"
440 440 if str_utf8.respond_to?(:force_encoding)
441 441 str_utf8.force_encoding('UTF-8')
442 442 str_big5.force_encoding('Big5')
443 443 end
444 444 issue = Issue.generate!(:subject => str_utf8)
445 445
446 446 get :index, :project_id => 1,
447 447 :f => ['subject'],
448 448 :op => '=', :values => [str_utf8],
449 449 :format => 'csv'
450 450 assert_equal 'text/csv; header=present', @response.content_type
451 451 lines = @response.body.chomp.split("\n")
452 452 s1 = "\xaa\xac\xbaA"
453 453 if str_utf8.respond_to?(:force_encoding)
454 454 s1.force_encoding('Big5')
455 455 end
456 456 assert lines[0].include?(s1)
457 457 assert lines[1].include?(str_big5)
458 458 end
459 459 end
460 460
461 461 def test_index_csv_cannot_convert_should_be_replaced_big_5
462 462 with_settings :default_language => "zh-TW" do
463 463 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
464 464 if str_utf8.respond_to?(:force_encoding)
465 465 str_utf8.force_encoding('UTF-8')
466 466 end
467 467 issue = Issue.generate!(:subject => str_utf8)
468 468
469 469 get :index, :project_id => 1,
470 470 :f => ['subject'],
471 471 :op => '=', :values => [str_utf8],
472 472 :c => ['status', 'subject'],
473 473 :format => 'csv',
474 474 :set_filter => 1
475 475 assert_equal 'text/csv; header=present', @response.content_type
476 476 lines = @response.body.chomp.split("\n")
477 477 s1 = "\xaa\xac\xbaA" # status
478 478 if str_utf8.respond_to?(:force_encoding)
479 479 s1.force_encoding('Big5')
480 480 end
481 481 assert lines[0].include?(s1)
482 482 s2 = lines[1].split(",")[2]
483 483 if s1.respond_to?(:force_encoding)
484 484 s3 = "\xa5H?" # subject
485 485 s3.force_encoding('Big5')
486 486 assert_equal s3, s2
487 487 elsif RUBY_PLATFORM == 'java'
488 488 assert_equal "??", s2
489 489 else
490 490 assert_equal "\xa5H???", s2
491 491 end
492 492 end
493 493 end
494 494
495 495 def test_index_csv_tw
496 496 with_settings :default_language => "zh-TW" do
497 497 str1 = "test_index_csv_tw"
498 498 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
499 499
500 500 get :index, :project_id => 1,
501 501 :f => ['subject'],
502 502 :op => '=', :values => [str1],
503 503 :c => ['estimated_hours', 'subject'],
504 504 :format => 'csv',
505 505 :set_filter => 1
506 506 assert_equal 'text/csv; header=present', @response.content_type
507 507 lines = @response.body.chomp.split("\n")
508 508 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
509 509 end
510 510 end
511 511
512 512 def test_index_csv_fr
513 513 with_settings :default_language => "fr" do
514 514 str1 = "test_index_csv_fr"
515 515 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
516 516
517 517 get :index, :project_id => 1,
518 518 :f => ['subject'],
519 519 :op => '=', :values => [str1],
520 520 :c => ['estimated_hours', 'subject'],
521 521 :format => 'csv',
522 522 :set_filter => 1
523 523 assert_equal 'text/csv; header=present', @response.content_type
524 524 lines = @response.body.chomp.split("\n")
525 525 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
526 526 end
527 527 end
528 528
529 529 def test_index_pdf
530 530 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
531 531 with_settings :default_language => lang do
532 532
533 533 get :index
534 534 assert_response :success
535 535 assert_template 'index'
536 536
537 537 if lang == "ja"
538 538 if RUBY_PLATFORM != 'java'
539 539 assert_equal "CP932", l(:general_pdf_encoding)
540 540 end
541 541 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
542 542 next
543 543 end
544 544 end
545 545
546 546 get :index, :format => 'pdf'
547 547 assert_response :success
548 548 assert_not_nil assigns(:issues)
549 549 assert_equal 'application/pdf', @response.content_type
550 550
551 551 get :index, :project_id => 1, :format => 'pdf'
552 552 assert_response :success
553 553 assert_not_nil assigns(:issues)
554 554 assert_equal 'application/pdf', @response.content_type
555 555
556 556 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
557 557 assert_response :success
558 558 assert_not_nil assigns(:issues)
559 559 assert_equal 'application/pdf', @response.content_type
560 560 end
561 561 end
562 562 end
563 563
564 564 def test_index_pdf_with_query_grouped_by_list_custom_field
565 565 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
566 566 assert_response :success
567 567 assert_not_nil assigns(:issues)
568 568 assert_not_nil assigns(:issue_count_by_group)
569 569 assert_equal 'application/pdf', @response.content_type
570 570 end
571 571
572 572 def test_index_atom
573 573 get :index, :project_id => 'ecookbook', :format => 'atom'
574 574 assert_response :success
575 575 assert_template 'common/feed'
576 576 assert_equal 'application/atom+xml', response.content_type
577 577
578 578 assert_select 'feed' do
579 579 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
580 580 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
581 581 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
582 582 end
583 583 end
584 584
585 585 def test_index_sort
586 586 get :index, :sort => 'tracker,id:desc'
587 587 assert_response :success
588 588
589 589 sort_params = @request.session['issues_index_sort']
590 590 assert sort_params.is_a?(String)
591 591 assert_equal 'tracker,id:desc', sort_params
592 592
593 593 issues = assigns(:issues)
594 594 assert_not_nil issues
595 595 assert !issues.empty?
596 596 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
597 597 end
598 598
599 599 def test_index_sort_by_field_not_included_in_columns
600 600 Setting.issue_list_default_columns = %w(subject author)
601 601 get :index, :sort => 'tracker'
602 602 end
603 603
604 604 def test_index_sort_by_assigned_to
605 605 get :index, :sort => 'assigned_to'
606 606 assert_response :success
607 607 assignees = assigns(:issues).collect(&:assigned_to).compact
608 608 assert_equal assignees.sort, assignees
609 609 end
610 610
611 611 def test_index_sort_by_assigned_to_desc
612 612 get :index, :sort => 'assigned_to:desc'
613 613 assert_response :success
614 614 assignees = assigns(:issues).collect(&:assigned_to).compact
615 615 assert_equal assignees.sort.reverse, assignees
616 616 end
617 617
618 618 def test_index_group_by_assigned_to
619 619 get :index, :group_by => 'assigned_to', :sort => 'priority'
620 620 assert_response :success
621 621 end
622 622
623 623 def test_index_sort_by_author
624 624 get :index, :sort => 'author'
625 625 assert_response :success
626 626 authors = assigns(:issues).collect(&:author)
627 627 assert_equal authors.sort, authors
628 628 end
629 629
630 630 def test_index_sort_by_author_desc
631 631 get :index, :sort => 'author:desc'
632 632 assert_response :success
633 633 authors = assigns(:issues).collect(&:author)
634 634 assert_equal authors.sort.reverse, authors
635 635 end
636 636
637 637 def test_index_group_by_author
638 638 get :index, :group_by => 'author', :sort => 'priority'
639 639 assert_response :success
640 640 end
641 641
642 642 def test_index_sort_by_spent_hours
643 643 get :index, :sort => 'spent_hours:desc'
644 644 assert_response :success
645 645 hours = assigns(:issues).collect(&:spent_hours)
646 646 assert_equal hours.sort.reverse, hours
647 647 end
648 648
649 649 def test_index_sort_by_user_custom_field
650 650 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
651 651 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
652 652 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
653 653 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
654 654 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
655 655
656 656 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
657 657 assert_response :success
658 658
659 659 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
660 660 end
661 661
662 662 def test_index_with_columns
663 663 columns = ['tracker', 'subject', 'assigned_to']
664 664 get :index, :set_filter => 1, :c => columns
665 665 assert_response :success
666 666
667 667 # query should use specified columns
668 668 query = assigns(:query)
669 669 assert_kind_of IssueQuery, query
670 670 assert_equal columns, query.column_names.map(&:to_s)
671 671
672 672 # columns should be stored in session
673 673 assert_kind_of Hash, session[:query]
674 674 assert_kind_of Array, session[:query][:column_names]
675 675 assert_equal columns, session[:query][:column_names].map(&:to_s)
676 676
677 677 # ensure only these columns are kept in the selected columns list
678 678 assert_select 'select#selected_columns option' do
679 679 assert_select 'option', 3
680 680 assert_select 'option[value=tracker]'
681 681 assert_select 'option[value=project]', 0
682 682 end
683 683 end
684 684
685 685 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
686 686 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
687 687 get :index, :set_filter => 1
688 688
689 689 # query should use specified columns
690 690 query = assigns(:query)
691 691 assert_kind_of IssueQuery, query
692 692 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
693 693 end
694 694
695 695 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
696 696 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
697 697 columns = ['tracker', 'subject', 'assigned_to']
698 698 get :index, :set_filter => 1, :c => columns
699 699
700 700 # query should use specified columns
701 701 query = assigns(:query)
702 702 assert_kind_of IssueQuery, query
703 703 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
704 704 end
705 705
706 706 def test_index_with_custom_field_column
707 707 columns = %w(tracker subject cf_2)
708 708 get :index, :set_filter => 1, :c => columns
709 709 assert_response :success
710 710
711 711 # query should use specified columns
712 712 query = assigns(:query)
713 713 assert_kind_of IssueQuery, query
714 714 assert_equal columns, query.column_names.map(&:to_s)
715 715
716 716 assert_select 'table.issues td.cf_2.string'
717 717 end
718 718
719 719 def test_index_with_multi_custom_field_column
720 720 field = CustomField.find(1)
721 721 field.update_attribute :multiple, true
722 722 issue = Issue.find(1)
723 723 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
724 724 issue.save!
725 725
726 726 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
727 727 assert_response :success
728 728
729 729 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
730 730 end
731 731
732 732 def test_index_with_multi_user_custom_field_column
733 733 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
734 734 :tracker_ids => [1], :is_for_all => true)
735 735 issue = Issue.find(1)
736 736 issue.custom_field_values = {field.id => ['2', '3']}
737 737 issue.save!
738 738
739 739 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
740 740 assert_response :success
741 741
742 742 assert_select "table.issues td.cf_#{field.id}" do
743 743 assert_select 'a', 2
744 744 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
745 745 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
746 746 end
747 747 end
748 748
749 749 def test_index_with_date_column
750 750 with_settings :date_format => '%d/%m/%Y' do
751 751 Issue.find(1).update_attribute :start_date, '1987-08-24'
752 752
753 753 get :index, :set_filter => 1, :c => %w(start_date)
754 754
755 755 assert_select "table.issues td.start_date", :text => '24/08/1987'
756 756 end
757 757 end
758 758
759 759 def test_index_with_done_ratio_column
760 760 Issue.find(1).update_attribute :done_ratio, 40
761 761
762 762 get :index, :set_filter => 1, :c => %w(done_ratio)
763 763
764 764 assert_select 'table.issues td.done_ratio' do
765 765 assert_select 'table.progress' do
766 766 assert_select 'td.closed[style=?]', 'width: 40%;'
767 767 end
768 768 end
769 769 end
770 770
771 771 def test_index_with_spent_hours_column
772 772 get :index, :set_filter => 1, :c => %w(subject spent_hours)
773 773
774 774 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
775 775 end
776 776
777 777 def test_index_should_not_show_spent_hours_column_without_permission
778 778 Role.anonymous.remove_permission! :view_time_entries
779 779 get :index, :set_filter => 1, :c => %w(subject spent_hours)
780 780
781 781 assert_select 'td.spent_hours', 0
782 782 end
783 783
784 784 def test_index_with_fixed_version_column
785 785 get :index, :set_filter => 1, :c => %w(fixed_version)
786 786
787 787 assert_select 'table.issues td.fixed_version' do
788 788 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
789 789 end
790 790 end
791 791
792 792 def test_index_with_relations_column
793 793 IssueRelation.delete_all
794 794 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
795 795 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
796 796 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
797 797 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
798 798
799 799 get :index, :set_filter => 1, :c => %w(subject relations)
800 800 assert_response :success
801 801 assert_select "tr#issue-1 td.relations" do
802 802 assert_select "span", 3
803 803 assert_select "span", :text => "Related to #7"
804 804 assert_select "span", :text => "Related to #8"
805 805 assert_select "span", :text => "Blocks #11"
806 806 end
807 807 assert_select "tr#issue-2 td.relations" do
808 808 assert_select "span", 1
809 809 assert_select "span", :text => "Blocked by #12"
810 810 end
811 811 assert_select "tr#issue-3 td.relations" do
812 812 assert_select "span", 0
813 813 end
814 814
815 815 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
816 816 assert_response :success
817 817 assert_equal 'text/csv; header=present', response.content_type
818 818 lines = response.body.chomp.split("\n")
819 819 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
820 820 assert_include '2,Blocked by #12', lines
821 821 assert_include '3,""', lines
822 822
823 823 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
824 824 assert_response :success
825 825 assert_equal 'application/pdf', response.content_type
826 826 end
827 827
828 828 def test_index_with_description_column
829 829 get :index, :set_filter => 1, :c => %w(subject description)
830 830
831 831 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
832 832 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
833 833
834 834 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
835 835 assert_response :success
836 836 assert_equal 'application/pdf', response.content_type
837 837 end
838 838
839 839 def test_index_send_html_if_query_is_invalid
840 840 get :index, :f => ['start_date'], :op => {:start_date => '='}
841 841 assert_equal 'text/html', @response.content_type
842 842 assert_template 'index'
843 843 end
844 844
845 845 def test_index_send_nothing_if_query_is_invalid
846 846 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
847 847 assert_equal 'text/csv', @response.content_type
848 848 assert @response.body.blank?
849 849 end
850 850
851 851 def test_show_by_anonymous
852 852 get :show, :id => 1
853 853 assert_response :success
854 854 assert_template 'show'
855 855 assert_equal Issue.find(1), assigns(:issue)
856 856
857 857 assert_select 'div.issue div.description', :text => /Unable to print recipes/
858 858
859 859 # anonymous role is allowed to add a note
860 860 assert_select 'form#issue-form' do
861 861 assert_select 'fieldset' do
862 862 assert_select 'legend', :text => 'Notes'
863 863 assert_select 'textarea[name=?]', 'issue[notes]'
864 864 end
865 865 end
866 866
867 867 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
868 868 end
869 869
870 870 def test_show_by_manager
871 871 @request.session[:user_id] = 2
872 872 get :show, :id => 1
873 873 assert_response :success
874 874
875 875 assert_select 'a', :text => /Quote/
876 876
877 877 assert_select 'form#issue-form' do
878 878 assert_select 'fieldset' do
879 879 assert_select 'legend', :text => 'Change properties'
880 880 assert_select 'input[name=?]', 'issue[subject]'
881 881 end
882 882 assert_select 'fieldset' do
883 883 assert_select 'legend', :text => 'Log time'
884 884 assert_select 'input[name=?]', 'time_entry[hours]'
885 885 end
886 886 assert_select 'fieldset' do
887 887 assert_select 'legend', :text => 'Notes'
888 888 assert_select 'textarea[name=?]', 'issue[notes]'
889 889 end
890 890 end
891 891 end
892 892
893 893 def test_show_should_display_update_form
894 894 @request.session[:user_id] = 2
895 895 get :show, :id => 1
896 896 assert_response :success
897 897
898 898 assert_select 'form#issue-form' do
899 899 assert_select 'input[name=?]', 'issue[is_private]'
900 900 assert_select 'select[name=?]', 'issue[project_id]'
901 901 assert_select 'select[name=?]', 'issue[tracker_id]'
902 902 assert_select 'input[name=?]', 'issue[subject]'
903 903 assert_select 'textarea[name=?]', 'issue[description]'
904 904 assert_select 'select[name=?]', 'issue[status_id]'
905 905 assert_select 'select[name=?]', 'issue[priority_id]'
906 906 assert_select 'select[name=?]', 'issue[assigned_to_id]'
907 907 assert_select 'select[name=?]', 'issue[category_id]'
908 908 assert_select 'select[name=?]', 'issue[fixed_version_id]'
909 909 assert_select 'input[name=?]', 'issue[parent_issue_id]'
910 910 assert_select 'input[name=?]', 'issue[start_date]'
911 911 assert_select 'input[name=?]', 'issue[due_date]'
912 912 assert_select 'select[name=?]', 'issue[done_ratio]'
913 913 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
914 914 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
915 915 assert_select 'textarea[name=?]', 'issue[notes]'
916 916 end
917 917 end
918 918
919 919 def test_show_should_display_update_form_with_minimal_permissions
920 920 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
921 921 WorkflowTransition.delete_all :role_id => 1
922 922
923 923 @request.session[:user_id] = 2
924 924 get :show, :id => 1
925 925 assert_response :success
926 926
927 927 assert_select 'form#issue-form' do
928 928 assert_select 'input[name=?]', 'issue[is_private]', 0
929 929 assert_select 'select[name=?]', 'issue[project_id]', 0
930 930 assert_select 'select[name=?]', 'issue[tracker_id]', 0
931 931 assert_select 'input[name=?]', 'issue[subject]', 0
932 932 assert_select 'textarea[name=?]', 'issue[description]', 0
933 933 assert_select 'select[name=?]', 'issue[status_id]', 0
934 934 assert_select 'select[name=?]', 'issue[priority_id]', 0
935 935 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
936 936 assert_select 'select[name=?]', 'issue[category_id]', 0
937 937 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
938 938 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
939 939 assert_select 'input[name=?]', 'issue[start_date]', 0
940 940 assert_select 'input[name=?]', 'issue[due_date]', 0
941 941 assert_select 'select[name=?]', 'issue[done_ratio]', 0
942 942 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
943 943 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
944 944 assert_select 'textarea[name=?]', 'issue[notes]'
945 945 end
946 946 end
947 947
948 948 def test_show_should_display_update_form_with_workflow_permissions
949 949 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
950 950
951 951 @request.session[:user_id] = 2
952 952 get :show, :id => 1
953 953 assert_response :success
954 954
955 955 assert_select 'form#issue-form' do
956 956 assert_select 'input[name=?]', 'issue[is_private]', 0
957 957 assert_select 'select[name=?]', 'issue[project_id]', 0
958 958 assert_select 'select[name=?]', 'issue[tracker_id]', 0
959 959 assert_select 'input[name=?]', 'issue[subject]', 0
960 960 assert_select 'textarea[name=?]', 'issue[description]', 0
961 961 assert_select 'select[name=?]', 'issue[status_id]'
962 962 assert_select 'select[name=?]', 'issue[priority_id]', 0
963 963 assert_select 'select[name=?]', 'issue[assigned_to_id]'
964 964 assert_select 'select[name=?]', 'issue[category_id]', 0
965 965 assert_select 'select[name=?]', 'issue[fixed_version_id]'
966 966 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
967 967 assert_select 'input[name=?]', 'issue[start_date]', 0
968 968 assert_select 'input[name=?]', 'issue[due_date]', 0
969 969 assert_select 'select[name=?]', 'issue[done_ratio]'
970 970 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
971 971 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
972 972 assert_select 'textarea[name=?]', 'issue[notes]'
973 973 end
974 974 end
975 975
976 976 def test_show_should_not_display_update_form_without_permissions
977 977 Role.find(1).update_attribute :permissions, [:view_issues]
978 978
979 979 @request.session[:user_id] = 2
980 980 get :show, :id => 1
981 981 assert_response :success
982 982
983 983 assert_select 'form#issue-form', 0
984 984 end
985 985
986 986 def test_update_form_should_not_display_inactive_enumerations
987 987 assert !IssuePriority.find(15).active?
988 988
989 989 @request.session[:user_id] = 2
990 990 get :show, :id => 1
991 991 assert_response :success
992 992
993 993 assert_select 'form#issue-form' do
994 994 assert_select 'select[name=?]', 'issue[priority_id]' do
995 995 assert_select 'option[value=4]'
996 996 assert_select 'option[value=15]', 0
997 997 end
998 998 end
999 999 end
1000 1000
1001 1001 def test_update_form_should_allow_attachment_upload
1002 1002 @request.session[:user_id] = 2
1003 1003 get :show, :id => 1
1004 1004
1005 1005 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1006 1006 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1007 1007 end
1008 1008 end
1009 1009
1010 1010 def test_show_should_deny_anonymous_access_without_permission
1011 1011 Role.anonymous.remove_permission!(:view_issues)
1012 1012 get :show, :id => 1
1013 1013 assert_response :redirect
1014 1014 end
1015 1015
1016 1016 def test_show_should_deny_anonymous_access_to_private_issue
1017 1017 Issue.update_all(["is_private = ?", true], "id = 1")
1018 1018 get :show, :id => 1
1019 1019 assert_response :redirect
1020 1020 end
1021 1021
1022 1022 def test_show_should_deny_non_member_access_without_permission
1023 1023 Role.non_member.remove_permission!(:view_issues)
1024 1024 @request.session[:user_id] = 9
1025 1025 get :show, :id => 1
1026 1026 assert_response 403
1027 1027 end
1028 1028
1029 1029 def test_show_should_deny_non_member_access_to_private_issue
1030 1030 Issue.update_all(["is_private = ?", true], "id = 1")
1031 1031 @request.session[:user_id] = 9
1032 1032 get :show, :id => 1
1033 1033 assert_response 403
1034 1034 end
1035 1035
1036 1036 def test_show_should_deny_member_access_without_permission
1037 1037 Role.find(1).remove_permission!(:view_issues)
1038 1038 @request.session[:user_id] = 2
1039 1039 get :show, :id => 1
1040 1040 assert_response 403
1041 1041 end
1042 1042
1043 1043 def test_show_should_deny_member_access_to_private_issue_without_permission
1044 1044 Issue.update_all(["is_private = ?", true], "id = 1")
1045 1045 @request.session[:user_id] = 3
1046 1046 get :show, :id => 1
1047 1047 assert_response 403
1048 1048 end
1049 1049
1050 1050 def test_show_should_allow_author_access_to_private_issue
1051 1051 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1052 1052 @request.session[:user_id] = 3
1053 1053 get :show, :id => 1
1054 1054 assert_response :success
1055 1055 end
1056 1056
1057 1057 def test_show_should_allow_assignee_access_to_private_issue
1058 1058 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1059 1059 @request.session[:user_id] = 3
1060 1060 get :show, :id => 1
1061 1061 assert_response :success
1062 1062 end
1063 1063
1064 1064 def test_show_should_allow_member_access_to_private_issue_with_permission
1065 1065 Issue.update_all(["is_private = ?", true], "id = 1")
1066 1066 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1067 1067 @request.session[:user_id] = 3
1068 1068 get :show, :id => 1
1069 1069 assert_response :success
1070 1070 end
1071 1071
1072 1072 def test_show_should_not_disclose_relations_to_invisible_issues
1073 1073 Setting.cross_project_issue_relations = '1'
1074 1074 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1075 1075 # Relation to a private project issue
1076 1076 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1077 1077
1078 1078 get :show, :id => 1
1079 1079 assert_response :success
1080 1080
1081 1081 assert_select 'div#relations' do
1082 1082 assert_select 'a', :text => /#2$/
1083 1083 assert_select 'a', :text => /#4$/, :count => 0
1084 1084 end
1085 1085 end
1086 1086
1087 1087 def test_show_should_list_subtasks
1088 1088 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1089 1089
1090 1090 get :show, :id => 1
1091 1091 assert_response :success
1092 1092
1093 1093 assert_select 'div#issue_tree' do
1094 1094 assert_select 'td.subject', :text => /Child Issue/
1095 1095 end
1096 1096 end
1097 1097
1098 1098 def test_show_should_list_parents
1099 1099 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1100 1100
1101 1101 get :show, :id => issue.id
1102 1102 assert_response :success
1103 1103
1104 1104 assert_select 'div.subject' do
1105 1105 assert_select 'h3', 'Child Issue'
1106 1106 assert_select 'a[href=/issues/1]'
1107 1107 end
1108 1108 end
1109 1109
1110 1110 def test_show_should_not_display_prev_next_links_without_query_in_session
1111 1111 get :show, :id => 1
1112 1112 assert_response :success
1113 1113 assert_nil assigns(:prev_issue_id)
1114 1114 assert_nil assigns(:next_issue_id)
1115 1115
1116 1116 assert_select 'div.next-prev-links', 0
1117 1117 end
1118 1118
1119 1119 def test_show_should_display_prev_next_links_with_query_in_session
1120 1120 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1121 1121 @request.session['issues_index_sort'] = 'id'
1122 1122
1123 1123 with_settings :display_subprojects_issues => '0' do
1124 1124 get :show, :id => 3
1125 1125 end
1126 1126
1127 1127 assert_response :success
1128 1128 # Previous and next issues for all projects
1129 1129 assert_equal 2, assigns(:prev_issue_id)
1130 1130 assert_equal 5, assigns(:next_issue_id)
1131 1131
1132 1132 count = Issue.open.visible.count
1133 1133
1134 1134 assert_select 'div.next-prev-links' do
1135 1135 assert_select 'a[href=/issues/2]', :text => /Previous/
1136 1136 assert_select 'a[href=/issues/5]', :text => /Next/
1137 1137 assert_select 'span.position', :text => "3 of #{count}"
1138 1138 end
1139 1139 end
1140 1140
1141 1141 def test_show_should_display_prev_next_links_with_saved_query_in_session
1142 1142 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1,
1143 1143 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1144 1144 :sort_criteria => [['id', 'asc']])
1145 1145 @request.session[:query] = {:id => query.id, :project_id => nil}
1146 1146
1147 1147 get :show, :id => 11
1148 1148
1149 1149 assert_response :success
1150 1150 assert_equal query, assigns(:query)
1151 1151 # Previous and next issues for all projects
1152 1152 assert_equal 8, assigns(:prev_issue_id)
1153 1153 assert_equal 12, assigns(:next_issue_id)
1154 1154
1155 1155 assert_select 'div.next-prev-links' do
1156 1156 assert_select 'a[href=/issues/8]', :text => /Previous/
1157 1157 assert_select 'a[href=/issues/12]', :text => /Next/
1158 1158 end
1159 1159 end
1160 1160
1161 1161 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1162 1162 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1163 1163
1164 1164 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1165 1165 @request.session['issues_index_sort'] = assoc_sort
1166 1166
1167 1167 get :show, :id => 3
1168 1168 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1169 1169
1170 1170 assert_select 'div.next-prev-links' do
1171 1171 assert_select 'a', :text => /(Previous|Next)/
1172 1172 end
1173 1173 end
1174 1174 end
1175 1175
1176 1176 def test_show_should_display_prev_next_links_with_project_query_in_session
1177 1177 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1178 1178 @request.session['issues_index_sort'] = 'id'
1179 1179
1180 1180 with_settings :display_subprojects_issues => '0' do
1181 1181 get :show, :id => 3
1182 1182 end
1183 1183
1184 1184 assert_response :success
1185 1185 # Previous and next issues inside project
1186 1186 assert_equal 2, assigns(:prev_issue_id)
1187 1187 assert_equal 7, assigns(:next_issue_id)
1188 1188
1189 1189 assert_select 'div.next-prev-links' do
1190 1190 assert_select 'a[href=/issues/2]', :text => /Previous/
1191 1191 assert_select 'a[href=/issues/7]', :text => /Next/
1192 1192 end
1193 1193 end
1194 1194
1195 1195 def test_show_should_not_display_prev_link_for_first_issue
1196 1196 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1197 1197 @request.session['issues_index_sort'] = 'id'
1198 1198
1199 1199 with_settings :display_subprojects_issues => '0' do
1200 1200 get :show, :id => 1
1201 1201 end
1202 1202
1203 1203 assert_response :success
1204 1204 assert_nil assigns(:prev_issue_id)
1205 1205 assert_equal 2, assigns(:next_issue_id)
1206 1206
1207 1207 assert_select 'div.next-prev-links' do
1208 1208 assert_select 'a', :text => /Previous/, :count => 0
1209 1209 assert_select 'a[href=/issues/2]', :text => /Next/
1210 1210 end
1211 1211 end
1212 1212
1213 1213 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1214 1214 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1215 1215 @request.session['issues_index_sort'] = 'id'
1216 1216
1217 1217 get :show, :id => 1
1218 1218
1219 1219 assert_response :success
1220 1220 assert_nil assigns(:prev_issue_id)
1221 1221 assert_nil assigns(:next_issue_id)
1222 1222
1223 1223 assert_select 'a', :text => /Previous/, :count => 0
1224 1224 assert_select 'a', :text => /Next/, :count => 0
1225 1225 end
1226 1226
1227 1227 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1228 1228 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1229 1229 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1230 1230 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1231 1231 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1232 1232 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1233 1233
1234 1234 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1, :filters => {},
1235 1235 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1236 1236 @request.session[:query] = {:id => query.id, :project_id => nil}
1237 1237
1238 1238 get :show, :id => 3
1239 1239 assert_response :success
1240 1240
1241 1241 assert_equal 2, assigns(:prev_issue_id)
1242 1242 assert_equal 1, assigns(:next_issue_id)
1243 1243
1244 1244 assert_select 'div.next-prev-links' do
1245 1245 assert_select 'a[href=/issues/2]', :text => /Previous/
1246 1246 assert_select 'a[href=/issues/1]', :text => /Next/
1247 1247 end
1248 1248 end
1249 1249
1250 1250 def test_show_should_display_link_to_the_assignee
1251 1251 get :show, :id => 2
1252 1252 assert_response :success
1253 1253 assert_select '.assigned-to' do
1254 1254 assert_select 'a[href=/users/3]'
1255 1255 end
1256 1256 end
1257 1257
1258 1258 def test_show_should_display_visible_changesets_from_other_projects
1259 1259 project = Project.find(2)
1260 1260 issue = project.issues.first
1261 1261 issue.changeset_ids = [102]
1262 1262 issue.save!
1263 1263 # changesets from other projects should be displayed even if repository
1264 1264 # is disabled on issue's project
1265 1265 project.disable_module! :repository
1266 1266
1267 1267 @request.session[:user_id] = 2
1268 1268 get :show, :id => issue.id
1269 1269
1270 1270 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1271 1271 end
1272 1272
1273 1273 def test_show_should_display_watchers
1274 1274 @request.session[:user_id] = 2
1275 1275 Issue.find(1).add_watcher User.find(2)
1276 1276
1277 1277 get :show, :id => 1
1278 1278 assert_select 'div#watchers ul' do
1279 1279 assert_select 'li' do
1280 1280 assert_select 'a[href=/users/2]'
1281 1281 assert_select 'a img[alt=Delete]'
1282 1282 end
1283 1283 end
1284 1284 end
1285 1285
1286 1286 def test_show_should_display_watchers_with_gravatars
1287 1287 @request.session[:user_id] = 2
1288 1288 Issue.find(1).add_watcher User.find(2)
1289 1289
1290 1290 with_settings :gravatar_enabled => '1' do
1291 1291 get :show, :id => 1
1292 1292 end
1293 1293
1294 1294 assert_select 'div#watchers ul' do
1295 1295 assert_select 'li' do
1296 1296 assert_select 'img.gravatar'
1297 1297 assert_select 'a[href=/users/2]'
1298 1298 assert_select 'a img[alt=Delete]'
1299 1299 end
1300 1300 end
1301 1301 end
1302 1302
1303 1303 def test_show_with_thumbnails_enabled_should_display_thumbnails
1304 1304 @request.session[:user_id] = 2
1305 1305
1306 1306 with_settings :thumbnails_enabled => '1' do
1307 1307 get :show, :id => 14
1308 1308 assert_response :success
1309 1309 end
1310 1310
1311 1311 assert_select 'div.thumbnails' do
1312 1312 assert_select 'a[href=/attachments/16/testfile.png]' do
1313 1313 assert_select 'img[src=/attachments/thumbnail/16]'
1314 1314 end
1315 1315 end
1316 1316 end
1317 1317
1318 1318 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1319 1319 @request.session[:user_id] = 2
1320 1320
1321 1321 with_settings :thumbnails_enabled => '0' do
1322 1322 get :show, :id => 14
1323 1323 assert_response :success
1324 1324 end
1325 1325
1326 1326 assert_select 'div.thumbnails', 0
1327 1327 end
1328 1328
1329 1329 def test_show_with_multi_custom_field
1330 1330 field = CustomField.find(1)
1331 1331 field.update_attribute :multiple, true
1332 1332 issue = Issue.find(1)
1333 1333 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1334 1334 issue.save!
1335 1335
1336 1336 get :show, :id => 1
1337 1337 assert_response :success
1338 1338
1339 1339 assert_select 'td', :text => 'MySQL, Oracle'
1340 1340 end
1341 1341
1342 1342 def test_show_with_multi_user_custom_field
1343 1343 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1344 1344 :tracker_ids => [1], :is_for_all => true)
1345 1345 issue = Issue.find(1)
1346 1346 issue.custom_field_values = {field.id => ['2', '3']}
1347 1347 issue.save!
1348 1348
1349 1349 get :show, :id => 1
1350 1350 assert_response :success
1351 1351
1352 1352 # TODO: should display links
1353 1353 assert_select 'td', :text => 'Dave Lopper, John Smith'
1354 1354 end
1355 1355
1356 1356 def test_show_should_display_private_notes_with_permission_only
1357 1357 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1358 1358 @request.session[:user_id] = 2
1359 1359
1360 1360 get :show, :id => 2
1361 1361 assert_response :success
1362 1362 assert_include journal, assigns(:journals)
1363 1363
1364 1364 Role.find(1).remove_permission! :view_private_notes
1365 1365 get :show, :id => 2
1366 1366 assert_response :success
1367 1367 assert_not_include journal, assigns(:journals)
1368 1368 end
1369 1369
1370 1370 def test_show_atom
1371 1371 get :show, :id => 2, :format => 'atom'
1372 1372 assert_response :success
1373 1373 assert_template 'journals/index'
1374 1374 # Inline image
1375 1375 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1376 1376 end
1377 1377
1378 1378 def test_show_export_to_pdf
1379 1379 get :show, :id => 3, :format => 'pdf'
1380 1380 assert_response :success
1381 1381 assert_equal 'application/pdf', @response.content_type
1382 1382 assert @response.body.starts_with?('%PDF')
1383 1383 assert_not_nil assigns(:issue)
1384 1384 end
1385 1385
1386 1386 def test_show_export_to_pdf_with_ancestors
1387 1387 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1388 1388
1389 1389 get :show, :id => issue.id, :format => 'pdf'
1390 1390 assert_response :success
1391 1391 assert_equal 'application/pdf', @response.content_type
1392 1392 assert @response.body.starts_with?('%PDF')
1393 1393 end
1394 1394
1395 1395 def test_show_export_to_pdf_with_descendants
1396 1396 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1397 1397 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1398 1398 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1399 1399
1400 1400 get :show, :id => 1, :format => 'pdf'
1401 1401 assert_response :success
1402 1402 assert_equal 'application/pdf', @response.content_type
1403 1403 assert @response.body.starts_with?('%PDF')
1404 1404 end
1405 1405
1406 1406 def test_show_export_to_pdf_with_journals
1407 1407 get :show, :id => 1, :format => 'pdf'
1408 1408 assert_response :success
1409 1409 assert_equal 'application/pdf', @response.content_type
1410 1410 assert @response.body.starts_with?('%PDF')
1411 1411 end
1412 1412
1413 1413 def test_show_export_to_pdf_with_changesets
1414 1414 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1415 1415
1416 1416 get :show, :id => 3, :format => 'pdf'
1417 1417 assert_response :success
1418 1418 assert_equal 'application/pdf', @response.content_type
1419 1419 assert @response.body.starts_with?('%PDF')
1420 1420 end
1421 1421
1422 1422 def test_show_invalid_should_respond_with_404
1423 1423 get :show, :id => 999
1424 1424 assert_response 404
1425 1425 end
1426 1426
1427 1427 def test_get_new
1428 1428 @request.session[:user_id] = 2
1429 1429 get :new, :project_id => 1, :tracker_id => 1
1430 1430 assert_response :success
1431 1431 assert_template 'new'
1432 1432
1433 1433 assert_select 'form#issue-form' do
1434 1434 assert_select 'input[name=?]', 'issue[is_private]'
1435 1435 assert_select 'select[name=?]', 'issue[project_id]', 0
1436 1436 assert_select 'select[name=?]', 'issue[tracker_id]'
1437 1437 assert_select 'input[name=?]', 'issue[subject]'
1438 1438 assert_select 'textarea[name=?]', 'issue[description]'
1439 1439 assert_select 'select[name=?]', 'issue[status_id]'
1440 1440 assert_select 'select[name=?]', 'issue[priority_id]'
1441 1441 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1442 1442 assert_select 'select[name=?]', 'issue[category_id]'
1443 1443 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1444 1444 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1445 1445 assert_select 'input[name=?]', 'issue[start_date]'
1446 1446 assert_select 'input[name=?]', 'issue[due_date]'
1447 1447 assert_select 'select[name=?]', 'issue[done_ratio]'
1448 1448 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1449 1449 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1450 1450 end
1451 1451
1452 1452 # Be sure we don't display inactive IssuePriorities
1453 1453 assert ! IssuePriority.find(15).active?
1454 1454 assert_select 'select[name=?]', 'issue[priority_id]' do
1455 1455 assert_select 'option[value=15]', 0
1456 1456 end
1457 1457 end
1458 1458
1459 1459 def test_get_new_with_minimal_permissions
1460 1460 Role.find(1).update_attribute :permissions, [:add_issues]
1461 1461 WorkflowTransition.delete_all :role_id => 1
1462 1462
1463 1463 @request.session[:user_id] = 2
1464 1464 get :new, :project_id => 1, :tracker_id => 1
1465 1465 assert_response :success
1466 1466 assert_template 'new'
1467 1467
1468 1468 assert_select 'form#issue-form' do
1469 1469 assert_select 'input[name=?]', 'issue[is_private]', 0
1470 1470 assert_select 'select[name=?]', 'issue[project_id]', 0
1471 1471 assert_select 'select[name=?]', 'issue[tracker_id]'
1472 1472 assert_select 'input[name=?]', 'issue[subject]'
1473 1473 assert_select 'textarea[name=?]', 'issue[description]'
1474 1474 assert_select 'select[name=?]', 'issue[status_id]'
1475 1475 assert_select 'select[name=?]', 'issue[priority_id]'
1476 1476 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1477 1477 assert_select 'select[name=?]', 'issue[category_id]'
1478 1478 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1479 1479 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1480 1480 assert_select 'input[name=?]', 'issue[start_date]'
1481 1481 assert_select 'input[name=?]', 'issue[due_date]'
1482 1482 assert_select 'select[name=?]', 'issue[done_ratio]'
1483 1483 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1484 1484 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1485 1485 end
1486 1486 end
1487 1487
1488 1488 def test_get_new_with_list_custom_field
1489 1489 @request.session[:user_id] = 2
1490 1490 get :new, :project_id => 1, :tracker_id => 1
1491 1491 assert_response :success
1492 1492 assert_template 'new'
1493 1493
1494 1494 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1495 1495 assert_select 'option', 4
1496 1496 assert_select 'option[value=MySQL]', :text => 'MySQL'
1497 1497 end
1498 1498 end
1499 1499
1500 1500 def test_get_new_with_multi_custom_field
1501 1501 field = IssueCustomField.find(1)
1502 1502 field.update_attribute :multiple, true
1503 1503
1504 1504 @request.session[:user_id] = 2
1505 1505 get :new, :project_id => 1, :tracker_id => 1
1506 1506 assert_response :success
1507 1507 assert_template 'new'
1508 1508
1509 1509 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1510 1510 assert_select 'option', 3
1511 1511 assert_select 'option[value=MySQL]', :text => 'MySQL'
1512 1512 end
1513 1513 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1514 1514 end
1515 1515
1516 1516 def test_get_new_with_multi_user_custom_field
1517 1517 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1518 1518 :tracker_ids => [1], :is_for_all => true)
1519 1519
1520 1520 @request.session[:user_id] = 2
1521 1521 get :new, :project_id => 1, :tracker_id => 1
1522 1522 assert_response :success
1523 1523 assert_template 'new'
1524 1524
1525 1525 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1526 1526 assert_select 'option', Project.find(1).users.count
1527 1527 assert_select 'option[value=2]', :text => 'John Smith'
1528 1528 end
1529 1529 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1530 1530 end
1531 1531
1532 1532 def test_get_new_with_date_custom_field
1533 1533 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1534 1534
1535 1535 @request.session[:user_id] = 2
1536 1536 get :new, :project_id => 1, :tracker_id => 1
1537 1537 assert_response :success
1538 1538
1539 1539 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1540 1540 end
1541 1541
1542 1542 def test_get_new_with_text_custom_field
1543 1543 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1544 1544
1545 1545 @request.session[:user_id] = 2
1546 1546 get :new, :project_id => 1, :tracker_id => 1
1547 1547 assert_response :success
1548 1548
1549 1549 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1550 1550 end
1551 1551
1552 1552 def test_get_new_without_default_start_date_is_creation_date
1553 1553 Setting.default_issue_start_date_to_creation_date = 0
1554 1554
1555 1555 @request.session[:user_id] = 2
1556 1556 get :new, :project_id => 1, :tracker_id => 1
1557 1557 assert_response :success
1558 1558 assert_template 'new'
1559 1559
1560 1560 assert_select 'input[name=?]', 'issue[start_date]'
1561 1561 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1562 1562 end
1563 1563
1564 1564 def test_get_new_with_default_start_date_is_creation_date
1565 1565 Setting.default_issue_start_date_to_creation_date = 1
1566 1566
1567 1567 @request.session[:user_id] = 2
1568 1568 get :new, :project_id => 1, :tracker_id => 1
1569 1569 assert_response :success
1570 1570 assert_template 'new'
1571 1571
1572 1572 assert_select 'input[name=?][value=?]', 'issue[start_date]', Date.today.to_s
1573 1573 end
1574 1574
1575 1575 def test_get_new_form_should_allow_attachment_upload
1576 1576 @request.session[:user_id] = 2
1577 1577 get :new, :project_id => 1, :tracker_id => 1
1578 1578
1579 1579 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1580 1580 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1581 1581 end
1582 1582 end
1583 1583
1584 1584 def test_get_new_should_prefill_the_form_from_params
1585 1585 @request.session[:user_id] = 2
1586 1586 get :new, :project_id => 1,
1587 1587 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1588 1588
1589 1589 issue = assigns(:issue)
1590 1590 assert_equal 3, issue.tracker_id
1591 1591 assert_equal 'Prefilled', issue.description
1592 1592 assert_equal 'Custom field value', issue.custom_field_value(2)
1593 1593
1594 1594 assert_select 'select[name=?]', 'issue[tracker_id]' do
1595 1595 assert_select 'option[value=3][selected=selected]'
1596 1596 end
1597 1597 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1598 1598 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1599 1599 end
1600 1600
1601 1601 def test_get_new_should_mark_required_fields
1602 1602 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1603 1603 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1604 1604 WorkflowPermission.delete_all
1605 1605 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1606 1606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1607 1607 @request.session[:user_id] = 2
1608 1608
1609 1609 get :new, :project_id => 1
1610 1610 assert_response :success
1611 1611 assert_template 'new'
1612 1612
1613 1613 assert_select 'label[for=issue_start_date]' do
1614 1614 assert_select 'span[class=required]', 0
1615 1615 end
1616 1616 assert_select 'label[for=issue_due_date]' do
1617 1617 assert_select 'span[class=required]'
1618 1618 end
1619 1619 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1620 1620 assert_select 'span[class=required]', 0
1621 1621 end
1622 1622 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1623 1623 assert_select 'span[class=required]'
1624 1624 end
1625 1625 end
1626 1626
1627 1627 def test_get_new_should_not_display_readonly_fields
1628 1628 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1629 1629 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1630 1630 WorkflowPermission.delete_all
1631 1631 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1632 1632 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1633 1633 @request.session[:user_id] = 2
1634 1634
1635 1635 get :new, :project_id => 1
1636 1636 assert_response :success
1637 1637 assert_template 'new'
1638 1638
1639 1639 assert_select 'input[name=?]', 'issue[start_date]'
1640 1640 assert_select 'input[name=?]', 'issue[due_date]', 0
1641 1641 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1642 1642 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1643 1643 end
1644 1644
1645 1645 def test_get_new_without_tracker_id
1646 1646 @request.session[:user_id] = 2
1647 1647 get :new, :project_id => 1
1648 1648 assert_response :success
1649 1649 assert_template 'new'
1650 1650
1651 1651 issue = assigns(:issue)
1652 1652 assert_not_nil issue
1653 1653 assert_equal Project.find(1).trackers.first, issue.tracker
1654 1654 end
1655 1655
1656 1656 def test_get_new_with_no_default_status_should_display_an_error
1657 1657 @request.session[:user_id] = 2
1658 1658 IssueStatus.delete_all
1659 1659
1660 1660 get :new, :project_id => 1
1661 1661 assert_response 500
1662 1662 assert_error_tag :content => /No default issue/
1663 1663 end
1664 1664
1665 1665 def test_get_new_with_no_tracker_should_display_an_error
1666 1666 @request.session[:user_id] = 2
1667 1667 Tracker.delete_all
1668 1668
1669 1669 get :new, :project_id => 1
1670 1670 assert_response 500
1671 1671 assert_error_tag :content => /No tracker/
1672 1672 end
1673 1673
1674 1674 def test_update_new_form
1675 1675 @request.session[:user_id] = 2
1676 1676 xhr :post, :new, :project_id => 1,
1677 1677 :issue => {:tracker_id => 2,
1678 1678 :subject => 'This is the test_new issue',
1679 1679 :description => 'This is the description',
1680 1680 :priority_id => 5}
1681 1681 assert_response :success
1682 1682 assert_template 'update_form'
1683 1683 assert_template 'form'
1684 1684 assert_equal 'text/javascript', response.content_type
1685 1685
1686 1686 issue = assigns(:issue)
1687 1687 assert_kind_of Issue, issue
1688 1688 assert_equal 1, issue.project_id
1689 1689 assert_equal 2, issue.tracker_id
1690 1690 assert_equal 'This is the test_new issue', issue.subject
1691 1691 end
1692 1692
1693 1693 def test_update_new_form_should_propose_transitions_based_on_initial_status
1694 1694 @request.session[:user_id] = 2
1695 1695 WorkflowTransition.delete_all
1696 1696 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1697 1697 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1698 1698 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1699 1699
1700 1700 xhr :post, :new, :project_id => 1,
1701 1701 :issue => {:tracker_id => 1,
1702 1702 :status_id => 5,
1703 1703 :subject => 'This is an issue'}
1704 1704
1705 1705 assert_equal 5, assigns(:issue).status_id
1706 1706 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1707 1707 end
1708 1708
1709 1709 def test_post_create
1710 1710 @request.session[:user_id] = 2
1711 1711 assert_difference 'Issue.count' do
1712 1712 post :create, :project_id => 1,
1713 1713 :issue => {:tracker_id => 3,
1714 1714 :status_id => 2,
1715 1715 :subject => 'This is the test_new issue',
1716 1716 :description => 'This is the description',
1717 1717 :priority_id => 5,
1718 1718 :start_date => '2010-11-07',
1719 1719 :estimated_hours => '',
1720 1720 :custom_field_values => {'2' => 'Value for field 2'}}
1721 1721 end
1722 1722 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1723 1723
1724 1724 issue = Issue.find_by_subject('This is the test_new issue')
1725 1725 assert_not_nil issue
1726 1726 assert_equal 2, issue.author_id
1727 1727 assert_equal 3, issue.tracker_id
1728 1728 assert_equal 2, issue.status_id
1729 1729 assert_equal Date.parse('2010-11-07'), issue.start_date
1730 1730 assert_nil issue.estimated_hours
1731 1731 v = issue.custom_values.where(:custom_field_id => 2).first
1732 1732 assert_not_nil v
1733 1733 assert_equal 'Value for field 2', v.value
1734 1734 end
1735 1735
1736 1736 def test_post_new_with_group_assignment
1737 1737 group = Group.find(11)
1738 1738 project = Project.find(1)
1739 1739 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1740 1740
1741 1741 with_settings :issue_group_assignment => '1' do
1742 1742 @request.session[:user_id] = 2
1743 1743 assert_difference 'Issue.count' do
1744 1744 post :create, :project_id => project.id,
1745 1745 :issue => {:tracker_id => 3,
1746 1746 :status_id => 1,
1747 1747 :subject => 'This is the test_new_with_group_assignment issue',
1748 1748 :assigned_to_id => group.id}
1749 1749 end
1750 1750 end
1751 1751 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1752 1752
1753 1753 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1754 1754 assert_not_nil issue
1755 1755 assert_equal group, issue.assigned_to
1756 1756 end
1757 1757
1758 1758 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1759 1759 Setting.default_issue_start_date_to_creation_date = 0
1760 1760
1761 1761 @request.session[:user_id] = 2
1762 1762 assert_difference 'Issue.count' do
1763 1763 post :create, :project_id => 1,
1764 1764 :issue => {:tracker_id => 3,
1765 1765 :status_id => 2,
1766 1766 :subject => 'This is the test_new issue',
1767 1767 :description => 'This is the description',
1768 1768 :priority_id => 5,
1769 1769 :estimated_hours => '',
1770 1770 :custom_field_values => {'2' => 'Value for field 2'}}
1771 1771 end
1772 1772 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1773 1773
1774 1774 issue = Issue.find_by_subject('This is the test_new issue')
1775 1775 assert_not_nil issue
1776 1776 assert_nil issue.start_date
1777 1777 end
1778 1778
1779 1779 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1780 1780 Setting.default_issue_start_date_to_creation_date = 1
1781 1781
1782 1782 @request.session[:user_id] = 2
1783 1783 assert_difference 'Issue.count' do
1784 1784 post :create, :project_id => 1,
1785 1785 :issue => {:tracker_id => 3,
1786 1786 :status_id => 2,
1787 1787 :subject => 'This is the test_new issue',
1788 1788 :description => 'This is the description',
1789 1789 :priority_id => 5,
1790 1790 :estimated_hours => '',
1791 1791 :custom_field_values => {'2' => 'Value for field 2'}}
1792 1792 end
1793 1793 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1794 1794
1795 1795 issue = Issue.find_by_subject('This is the test_new issue')
1796 1796 assert_not_nil issue
1797 1797 assert_equal Date.today, issue.start_date
1798 1798 end
1799 1799
1800 1800 def test_post_create_and_continue
1801 1801 @request.session[:user_id] = 2
1802 1802 assert_difference 'Issue.count' do
1803 1803 post :create, :project_id => 1,
1804 1804 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1805 1805 :continue => ''
1806 1806 end
1807 1807
1808 1808 issue = Issue.first(:order => 'id DESC')
1809 1809 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1810 1810 assert_not_nil flash[:notice], "flash was not set"
1811 1811 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1812 1812 end
1813 1813
1814 1814 def test_post_create_without_custom_fields_param
1815 1815 @request.session[:user_id] = 2
1816 1816 assert_difference 'Issue.count' do
1817 1817 post :create, :project_id => 1,
1818 1818 :issue => {:tracker_id => 1,
1819 1819 :subject => 'This is the test_new issue',
1820 1820 :description => 'This is the description',
1821 1821 :priority_id => 5}
1822 1822 end
1823 1823 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1824 1824 end
1825 1825
1826 1826 def test_post_create_with_multi_custom_field
1827 1827 field = IssueCustomField.find_by_name('Database')
1828 1828 field.update_attribute(:multiple, true)
1829 1829
1830 1830 @request.session[:user_id] = 2
1831 1831 assert_difference 'Issue.count' do
1832 1832 post :create, :project_id => 1,
1833 1833 :issue => {:tracker_id => 1,
1834 1834 :subject => 'This is the test_new issue',
1835 1835 :description => 'This is the description',
1836 1836 :priority_id => 5,
1837 1837 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1838 1838 end
1839 1839 assert_response 302
1840 1840 issue = Issue.first(:order => 'id DESC')
1841 1841 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1842 1842 end
1843 1843
1844 1844 def test_post_create_with_empty_multi_custom_field
1845 1845 field = IssueCustomField.find_by_name('Database')
1846 1846 field.update_attribute(:multiple, true)
1847 1847
1848 1848 @request.session[:user_id] = 2
1849 1849 assert_difference 'Issue.count' do
1850 1850 post :create, :project_id => 1,
1851 1851 :issue => {:tracker_id => 1,
1852 1852 :subject => 'This is the test_new issue',
1853 1853 :description => 'This is the description',
1854 1854 :priority_id => 5,
1855 1855 :custom_field_values => {'1' => ['']}}
1856 1856 end
1857 1857 assert_response 302
1858 1858 issue = Issue.first(:order => 'id DESC')
1859 1859 assert_equal [''], issue.custom_field_value(1).sort
1860 1860 end
1861 1861
1862 1862 def test_post_create_with_multi_user_custom_field
1863 1863 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1864 1864 :tracker_ids => [1], :is_for_all => true)
1865 1865
1866 1866 @request.session[:user_id] = 2
1867 1867 assert_difference 'Issue.count' do
1868 1868 post :create, :project_id => 1,
1869 1869 :issue => {:tracker_id => 1,
1870 1870 :subject => 'This is the test_new issue',
1871 1871 :description => 'This is the description',
1872 1872 :priority_id => 5,
1873 1873 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1874 1874 end
1875 1875 assert_response 302
1876 1876 issue = Issue.first(:order => 'id DESC')
1877 1877 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1878 1878 end
1879 1879
1880 1880 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1881 1881 field = IssueCustomField.find_by_name('Database')
1882 1882 field.update_attribute(:is_required, true)
1883 1883
1884 1884 @request.session[:user_id] = 2
1885 1885 assert_no_difference 'Issue.count' do
1886 1886 post :create, :project_id => 1,
1887 1887 :issue => {:tracker_id => 1,
1888 1888 :subject => 'This is the test_new issue',
1889 1889 :description => 'This is the description',
1890 1890 :priority_id => 5}
1891 1891 end
1892 1892 assert_response :success
1893 1893 assert_template 'new'
1894 1894 issue = assigns(:issue)
1895 1895 assert_not_nil issue
1896 1896 assert_error_tag :content => /Database can&#x27;t be blank/
1897 1897 end
1898 1898
1899 1899 def test_create_should_validate_required_fields
1900 1900 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1901 1901 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1902 1902 WorkflowPermission.delete_all
1903 1903 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1904 1904 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1905 1905 @request.session[:user_id] = 2
1906 1906
1907 1907 assert_no_difference 'Issue.count' do
1908 1908 post :create, :project_id => 1, :issue => {
1909 1909 :tracker_id => 2,
1910 1910 :status_id => 1,
1911 1911 :subject => 'Test',
1912 1912 :start_date => '',
1913 1913 :due_date => '',
1914 1914 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1915 1915 }
1916 1916 assert_response :success
1917 1917 assert_template 'new'
1918 1918 end
1919 1919
1920 1920 assert_error_tag :content => /Due date can&#x27;t be blank/i
1921 1921 assert_error_tag :content => /Bar can&#x27;t be blank/i
1922 1922 end
1923 1923
1924 1924 def test_create_should_ignore_readonly_fields
1925 1925 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1926 1926 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1927 1927 WorkflowPermission.delete_all
1928 1928 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1929 1929 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1930 1930 @request.session[:user_id] = 2
1931 1931
1932 1932 assert_difference 'Issue.count' do
1933 1933 post :create, :project_id => 1, :issue => {
1934 1934 :tracker_id => 2,
1935 1935 :status_id => 1,
1936 1936 :subject => 'Test',
1937 1937 :start_date => '2012-07-14',
1938 1938 :due_date => '2012-07-16',
1939 1939 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1940 1940 }
1941 1941 assert_response 302
1942 1942 end
1943 1943
1944 1944 issue = Issue.first(:order => 'id DESC')
1945 1945 assert_equal Date.parse('2012-07-14'), issue.start_date
1946 1946 assert_nil issue.due_date
1947 1947 assert_equal 'value1', issue.custom_field_value(cf1)
1948 1948 assert_nil issue.custom_field_value(cf2)
1949 1949 end
1950 1950
1951 1951 def test_post_create_with_watchers
1952 1952 @request.session[:user_id] = 2
1953 1953 ActionMailer::Base.deliveries.clear
1954 1954
1955 1955 assert_difference 'Watcher.count', 2 do
1956 1956 post :create, :project_id => 1,
1957 1957 :issue => {:tracker_id => 1,
1958 1958 :subject => 'This is a new issue with watchers',
1959 1959 :description => 'This is the description',
1960 1960 :priority_id => 5,
1961 1961 :watcher_user_ids => ['2', '3']}
1962 1962 end
1963 1963 issue = Issue.find_by_subject('This is a new issue with watchers')
1964 1964 assert_not_nil issue
1965 1965 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1966 1966
1967 1967 # Watchers added
1968 1968 assert_equal [2, 3], issue.watcher_user_ids.sort
1969 1969 assert issue.watched_by?(User.find(3))
1970 1970 # Watchers notified
1971 1971 mail = ActionMailer::Base.deliveries.last
1972 1972 assert_not_nil mail
1973 1973 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1974 1974 end
1975 1975
1976 1976 def test_post_create_subissue
1977 1977 @request.session[:user_id] = 2
1978 1978
1979 1979 assert_difference 'Issue.count' do
1980 1980 post :create, :project_id => 1,
1981 1981 :issue => {:tracker_id => 1,
1982 1982 :subject => 'This is a child issue',
1983 1983 :parent_issue_id => '2'}
1984 1984 assert_response 302
1985 1985 end
1986 1986 issue = Issue.order('id DESC').first
1987 1987 assert_equal Issue.find(2), issue.parent
1988 1988 end
1989 1989
1990 1990 def test_post_create_subissue_with_sharp_parent_id
1991 1991 @request.session[:user_id] = 2
1992 1992
1993 1993 assert_difference 'Issue.count' do
1994 1994 post :create, :project_id => 1,
1995 1995 :issue => {:tracker_id => 1,
1996 1996 :subject => 'This is a child issue',
1997 1997 :parent_issue_id => '#2'}
1998 1998 assert_response 302
1999 1999 end
2000 2000 issue = Issue.order('id DESC').first
2001 2001 assert_equal Issue.find(2), issue.parent
2002 2002 end
2003 2003
2004 2004 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2005 2005 @request.session[:user_id] = 2
2006 2006
2007 2007 assert_no_difference 'Issue.count' do
2008 2008 post :create, :project_id => 1,
2009 2009 :issue => {:tracker_id => 1,
2010 2010 :subject => 'This is a child issue',
2011 2011 :parent_issue_id => '4'}
2012 2012
2013 2013 assert_response :success
2014 2014 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2015 2015 assert_error_tag :content => /Parent task is invalid/i
2016 2016 end
2017 2017 end
2018 2018
2019 2019 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2020 2020 @request.session[:user_id] = 2
2021 2021
2022 2022 assert_no_difference 'Issue.count' do
2023 2023 post :create, :project_id => 1,
2024 2024 :issue => {:tracker_id => 1,
2025 2025 :subject => 'This is a child issue',
2026 2026 :parent_issue_id => '01ABC'}
2027 2027
2028 2028 assert_response :success
2029 2029 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2030 2030 assert_error_tag :content => /Parent task is invalid/i
2031 2031 end
2032 2032 end
2033 2033
2034 2034 def test_post_create_private
2035 2035 @request.session[:user_id] = 2
2036 2036
2037 2037 assert_difference 'Issue.count' do
2038 2038 post :create, :project_id => 1,
2039 2039 :issue => {:tracker_id => 1,
2040 2040 :subject => 'This is a private issue',
2041 2041 :is_private => '1'}
2042 2042 end
2043 2043 issue = Issue.first(:order => 'id DESC')
2044 2044 assert issue.is_private?
2045 2045 end
2046 2046
2047 2047 def test_post_create_private_with_set_own_issues_private_permission
2048 2048 role = Role.find(1)
2049 2049 role.remove_permission! :set_issues_private
2050 2050 role.add_permission! :set_own_issues_private
2051 2051
2052 2052 @request.session[:user_id] = 2
2053 2053
2054 2054 assert_difference 'Issue.count' do
2055 2055 post :create, :project_id => 1,
2056 2056 :issue => {:tracker_id => 1,
2057 2057 :subject => 'This is a private issue',
2058 2058 :is_private => '1'}
2059 2059 end
2060 2060 issue = Issue.first(:order => 'id DESC')
2061 2061 assert issue.is_private?
2062 2062 end
2063 2063
2064 2064 def test_post_create_should_send_a_notification
2065 2065 ActionMailer::Base.deliveries.clear
2066 2066 @request.session[:user_id] = 2
2067 2067 assert_difference 'Issue.count' do
2068 2068 post :create, :project_id => 1,
2069 2069 :issue => {:tracker_id => 3,
2070 2070 :subject => 'This is the test_new issue',
2071 2071 :description => 'This is the description',
2072 2072 :priority_id => 5,
2073 2073 :estimated_hours => '',
2074 2074 :custom_field_values => {'2' => 'Value for field 2'}}
2075 2075 end
2076 2076 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2077 2077
2078 2078 assert_equal 1, ActionMailer::Base.deliveries.size
2079 2079 end
2080 2080
2081 2081 def test_post_create_should_preserve_fields_values_on_validation_failure
2082 2082 @request.session[:user_id] = 2
2083 2083 post :create, :project_id => 1,
2084 2084 :issue => {:tracker_id => 1,
2085 2085 # empty subject
2086 2086 :subject => '',
2087 2087 :description => 'This is a description',
2088 2088 :priority_id => 6,
2089 2089 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2090 2090 assert_response :success
2091 2091 assert_template 'new'
2092 2092
2093 2093 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2094 2094 assert_select 'select[name=?]', 'issue[priority_id]' do
2095 2095 assert_select 'option[value=6][selected=selected]', :text => 'High'
2096 2096 end
2097 2097 # Custom fields
2098 2098 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2099 2099 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2100 2100 end
2101 2101 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2102 2102 end
2103 2103
2104 2104 def test_post_create_with_failure_should_preserve_watchers
2105 2105 assert !User.find(8).member_of?(Project.find(1))
2106 2106
2107 2107 @request.session[:user_id] = 2
2108 2108 post :create, :project_id => 1,
2109 2109 :issue => {:tracker_id => 1,
2110 2110 :watcher_user_ids => ['3', '8']}
2111 2111 assert_response :success
2112 2112 assert_template 'new'
2113 2113
2114 2114 assert_select 'input[name=?][value=2]:not(checked)', 'issue[watcher_user_ids][]'
2115 2115 assert_select 'input[name=?][value=3][checked=checked]', 'issue[watcher_user_ids][]'
2116 2116 assert_select 'input[name=?][value=8][checked=checked]', 'issue[watcher_user_ids][]'
2117 2117 end
2118 2118
2119 2119 def test_post_create_should_ignore_non_safe_attributes
2120 2120 @request.session[:user_id] = 2
2121 2121 assert_nothing_raised do
2122 2122 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2123 2123 end
2124 2124 end
2125 2125
2126 2126 def test_post_create_with_attachment
2127 2127 set_tmp_attachments_directory
2128 2128 @request.session[:user_id] = 2
2129 2129
2130 2130 assert_difference 'Issue.count' do
2131 2131 assert_difference 'Attachment.count' do
2132 2132 post :create, :project_id => 1,
2133 2133 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2134 2134 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2135 2135 end
2136 2136 end
2137 2137
2138 2138 issue = Issue.first(:order => 'id DESC')
2139 2139 attachment = Attachment.first(:order => 'id DESC')
2140 2140
2141 2141 assert_equal issue, attachment.container
2142 2142 assert_equal 2, attachment.author_id
2143 2143 assert_equal 'testfile.txt', attachment.filename
2144 2144 assert_equal 'text/plain', attachment.content_type
2145 2145 assert_equal 'test file', attachment.description
2146 2146 assert_equal 59, attachment.filesize
2147 2147 assert File.exists?(attachment.diskfile)
2148 2148 assert_equal 59, File.size(attachment.diskfile)
2149 2149 end
2150 2150
2151 2151 def test_post_create_with_failure_should_save_attachments
2152 2152 set_tmp_attachments_directory
2153 2153 @request.session[:user_id] = 2
2154 2154
2155 2155 assert_no_difference 'Issue.count' do
2156 2156 assert_difference 'Attachment.count' do
2157 2157 post :create, :project_id => 1,
2158 2158 :issue => { :tracker_id => '1', :subject => '' },
2159 2159 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2160 2160 assert_response :success
2161 2161 assert_template 'new'
2162 2162 end
2163 2163 end
2164 2164
2165 2165 attachment = Attachment.first(:order => 'id DESC')
2166 2166 assert_equal 'testfile.txt', attachment.filename
2167 2167 assert File.exists?(attachment.diskfile)
2168 2168 assert_nil attachment.container
2169 2169
2170 2170 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2171 2171 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2172 2172 end
2173 2173
2174 2174 def test_post_create_with_failure_should_keep_saved_attachments
2175 2175 set_tmp_attachments_directory
2176 2176 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2177 2177 @request.session[:user_id] = 2
2178 2178
2179 2179 assert_no_difference 'Issue.count' do
2180 2180 assert_no_difference 'Attachment.count' do
2181 2181 post :create, :project_id => 1,
2182 2182 :issue => { :tracker_id => '1', :subject => '' },
2183 2183 :attachments => {'p0' => {'token' => attachment.token}}
2184 2184 assert_response :success
2185 2185 assert_template 'new'
2186 2186 end
2187 2187 end
2188 2188
2189 2189 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2190 2190 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2191 2191 end
2192 2192
2193 2193 def test_post_create_should_attach_saved_attachments
2194 2194 set_tmp_attachments_directory
2195 2195 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2196 2196 @request.session[:user_id] = 2
2197 2197
2198 2198 assert_difference 'Issue.count' do
2199 2199 assert_no_difference 'Attachment.count' do
2200 2200 post :create, :project_id => 1,
2201 2201 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2202 2202 :attachments => {'p0' => {'token' => attachment.token}}
2203 2203 assert_response 302
2204 2204 end
2205 2205 end
2206 2206
2207 2207 issue = Issue.first(:order => 'id DESC')
2208 2208 assert_equal 1, issue.attachments.count
2209 2209
2210 2210 attachment.reload
2211 2211 assert_equal issue, attachment.container
2212 2212 end
2213 2213
2214 2214 context "without workflow privilege" do
2215 2215 setup do
2216 2216 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2217 2217 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2218 2218 end
2219 2219
2220 2220 context "#new" do
2221 2221 should "propose default status only" do
2222 2222 get :new, :project_id => 1
2223 2223 assert_response :success
2224 2224 assert_template 'new'
2225 2225 assert_select 'select[name=?]', 'issue[status_id]' do
2226 2226 assert_select 'option', 1
2227 2227 assert_select 'option[value=?]', IssueStatus.default.id.to_s
2228 2228 end
2229 2229 end
2230 2230
2231 2231 should "accept default status" do
2232 2232 assert_difference 'Issue.count' do
2233 2233 post :create, :project_id => 1,
2234 2234 :issue => {:tracker_id => 1,
2235 2235 :subject => 'This is an issue',
2236 2236 :status_id => 1}
2237 2237 end
2238 2238 issue = Issue.last(:order => 'id')
2239 2239 assert_equal IssueStatus.default, issue.status
2240 2240 end
2241 2241
2242 2242 should "ignore unauthorized status" do
2243 2243 assert_difference 'Issue.count' do
2244 2244 post :create, :project_id => 1,
2245 2245 :issue => {:tracker_id => 1,
2246 2246 :subject => 'This is an issue',
2247 2247 :status_id => 3}
2248 2248 end
2249 2249 issue = Issue.last(:order => 'id')
2250 2250 assert_equal IssueStatus.default, issue.status
2251 2251 end
2252 2252 end
2253 2253
2254 2254 context "#update" do
2255 2255 should "ignore status change" do
2256 2256 assert_difference 'Journal.count' do
2257 2257 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2258 2258 end
2259 2259 assert_equal 1, Issue.find(1).status_id
2260 2260 end
2261 2261
2262 2262 should "ignore attributes changes" do
2263 2263 assert_difference 'Journal.count' do
2264 2264 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2265 2265 end
2266 2266 issue = Issue.find(1)
2267 2267 assert_equal "Can't print recipes", issue.subject
2268 2268 assert_nil issue.assigned_to
2269 2269 end
2270 2270 end
2271 2271 end
2272 2272
2273 2273 context "with workflow privilege" do
2274 2274 setup do
2275 2275 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2276 2276 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2277 2277 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2278 2278 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2279 2279 end
2280 2280
2281 2281 context "#update" do
2282 2282 should "accept authorized status" do
2283 2283 assert_difference 'Journal.count' do
2284 2284 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2285 2285 end
2286 2286 assert_equal 3, Issue.find(1).status_id
2287 2287 end
2288 2288
2289 2289 should "ignore unauthorized status" do
2290 2290 assert_difference 'Journal.count' do
2291 2291 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2292 2292 end
2293 2293 assert_equal 1, Issue.find(1).status_id
2294 2294 end
2295 2295
2296 2296 should "accept authorized attributes changes" do
2297 2297 assert_difference 'Journal.count' do
2298 2298 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2299 2299 end
2300 2300 issue = Issue.find(1)
2301 2301 assert_equal 2, issue.assigned_to_id
2302 2302 end
2303 2303
2304 2304 should "ignore unauthorized attributes changes" do
2305 2305 assert_difference 'Journal.count' do
2306 2306 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2307 2307 end
2308 2308 issue = Issue.find(1)
2309 2309 assert_equal "Can't print recipes", issue.subject
2310 2310 end
2311 2311 end
2312 2312
2313 2313 context "and :edit_issues permission" do
2314 2314 setup do
2315 2315 Role.anonymous.add_permission! :add_issues, :edit_issues
2316 2316 end
2317 2317
2318 2318 should "accept authorized status" do
2319 2319 assert_difference 'Journal.count' do
2320 2320 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2321 2321 end
2322 2322 assert_equal 3, Issue.find(1).status_id
2323 2323 end
2324 2324
2325 2325 should "ignore unauthorized status" do
2326 2326 assert_difference 'Journal.count' do
2327 2327 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2328 2328 end
2329 2329 assert_equal 1, Issue.find(1).status_id
2330 2330 end
2331 2331
2332 2332 should "accept authorized attributes changes" do
2333 2333 assert_difference 'Journal.count' do
2334 2334 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2335 2335 end
2336 2336 issue = Issue.find(1)
2337 2337 assert_equal "changed", issue.subject
2338 2338 assert_equal 2, issue.assigned_to_id
2339 2339 end
2340 2340 end
2341 2341 end
2342 2342
2343 2343 def test_new_as_copy
2344 2344 @request.session[:user_id] = 2
2345 2345 get :new, :project_id => 1, :copy_from => 1
2346 2346
2347 2347 assert_response :success
2348 2348 assert_template 'new'
2349 2349
2350 2350 assert_not_nil assigns(:issue)
2351 2351 orig = Issue.find(1)
2352 2352 assert_equal 1, assigns(:issue).project_id
2353 2353 assert_equal orig.subject, assigns(:issue).subject
2354 2354 assert assigns(:issue).copy?
2355 2355
2356 2356 assert_select 'form[id=issue-form][action=/projects/ecookbook/issues]' do
2357 2357 assert_select 'select[name=?]', 'issue[project_id]' do
2358 2358 assert_select 'option[value=1][selected=selected]', :text => 'eCookbook'
2359 2359 assert_select 'option[value=2]:not([selected])', :text => 'OnlineStore'
2360 2360 end
2361 2361 assert_select 'input[name=copy_from][value=1]'
2362 2362 end
2363 2363
2364 2364 # "New issue" menu item should not link to copy
2365 2365 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2366 2366 end
2367 2367
2368 2368 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2369 2369 @request.session[:user_id] = 2
2370 2370 issue = Issue.find(3)
2371 2371 assert issue.attachments.count > 0
2372 2372 get :new, :project_id => 1, :copy_from => 3
2373 2373
2374 2374 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value=1]'
2375 2375 end
2376 2376
2377 2377 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2378 2378 @request.session[:user_id] = 2
2379 2379 issue = Issue.find(3)
2380 2380 issue.attachments.delete_all
2381 2381 get :new, :project_id => 1, :copy_from => 3
2382 2382
2383 2383 assert_select 'input[name=copy_attachments]', 0
2384 2384 end
2385 2385
2386 2386 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2387 2387 @request.session[:user_id] = 2
2388 2388 issue = Issue.generate_with_descendants!
2389 2389 get :new, :project_id => 1, :copy_from => issue.id
2390 2390
2391 2391 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2392 2392 end
2393 2393
2394 2394 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2395 2395 @request.session[:user_id] = 2
2396 2396 get :new, :project_id => 1, :copy_from => 99999
2397 2397 assert_response 404
2398 2398 end
2399 2399
2400 2400 def test_create_as_copy_on_different_project
2401 2401 @request.session[:user_id] = 2
2402 2402 assert_difference 'Issue.count' do
2403 2403 post :create, :project_id => 1, :copy_from => 1,
2404 2404 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2405 2405
2406 2406 assert_not_nil assigns(:issue)
2407 2407 assert assigns(:issue).copy?
2408 2408 end
2409 2409 issue = Issue.first(:order => 'id DESC')
2410 2410 assert_redirected_to "/issues/#{issue.id}"
2411 2411
2412 2412 assert_equal 2, issue.project_id
2413 2413 assert_equal 3, issue.tracker_id
2414 2414 assert_equal 'Copy', issue.subject
2415 2415 end
2416 2416
2417 2417 def test_create_as_copy_should_copy_attachments
2418 2418 @request.session[:user_id] = 2
2419 2419 issue = Issue.find(3)
2420 2420 count = issue.attachments.count
2421 2421 assert count > 0
2422 2422
2423 2423 assert_difference 'Issue.count' do
2424 2424 assert_difference 'Attachment.count', count do
2425 2425 assert_no_difference 'Journal.count' do
2426 2426 post :create, :project_id => 1, :copy_from => 3,
2427 2427 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2428 2428 :copy_attachments => '1'
2429 2429 end
2430 2430 end
2431 2431 end
2432 2432 copy = Issue.first(:order => 'id DESC')
2433 2433 assert_equal count, copy.attachments.count
2434 2434 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2435 2435 end
2436 2436
2437 2437 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2438 2438 @request.session[:user_id] = 2
2439 2439 issue = Issue.find(3)
2440 2440 count = issue.attachments.count
2441 2441 assert count > 0
2442 2442
2443 2443 assert_difference 'Issue.count' do
2444 2444 assert_no_difference 'Attachment.count' do
2445 2445 assert_no_difference 'Journal.count' do
2446 2446 post :create, :project_id => 1, :copy_from => 3,
2447 2447 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
2448 2448 end
2449 2449 end
2450 2450 end
2451 2451 copy = Issue.first(:order => 'id DESC')
2452 2452 assert_equal 0, copy.attachments.count
2453 2453 end
2454 2454
2455 2455 def test_create_as_copy_with_attachments_should_add_new_files
2456 2456 @request.session[:user_id] = 2
2457 2457 issue = Issue.find(3)
2458 2458 count = issue.attachments.count
2459 2459 assert count > 0
2460 2460
2461 2461 assert_difference 'Issue.count' do
2462 2462 assert_difference 'Attachment.count', count + 1 do
2463 2463 assert_no_difference 'Journal.count' do
2464 2464 post :create, :project_id => 1, :copy_from => 3,
2465 2465 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2466 2466 :copy_attachments => '1',
2467 2467 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2468 2468 end
2469 2469 end
2470 2470 end
2471 2471 copy = Issue.first(:order => 'id DESC')
2472 2472 assert_equal count + 1, copy.attachments.count
2473 2473 end
2474 2474
2475 2475 def test_create_as_copy_should_add_relation_with_copied_issue
2476 2476 @request.session[:user_id] = 2
2477 2477
2478 2478 assert_difference 'Issue.count' do
2479 2479 assert_difference 'IssueRelation.count' do
2480 2480 post :create, :project_id => 1, :copy_from => 1,
2481 2481 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2482 2482 end
2483 2483 end
2484 2484 copy = Issue.first(:order => 'id DESC')
2485 2485 assert_equal 1, copy.relations.size
2486 2486 end
2487 2487
2488 2488 def test_create_as_copy_should_copy_subtasks
2489 2489 @request.session[:user_id] = 2
2490 2490 issue = Issue.generate_with_descendants!
2491 2491 count = issue.descendants.count
2492 2492
2493 2493 assert_difference 'Issue.count', count+1 do
2494 2494 assert_no_difference 'Journal.count' do
2495 2495 post :create, :project_id => 1, :copy_from => issue.id,
2496 2496 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'},
2497 2497 :copy_subtasks => '1'
2498 2498 end
2499 2499 end
2500 2500 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2501 2501 assert_equal count, copy.descendants.count
2502 2502 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2503 2503 end
2504 2504
2505 2505 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2506 2506 @request.session[:user_id] = 2
2507 2507 issue = Issue.generate_with_descendants!
2508 2508
2509 2509 assert_difference 'Issue.count', 1 do
2510 2510 assert_no_difference 'Journal.count' do
2511 2511 post :create, :project_id => 1, :copy_from => 3,
2512 2512 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'}
2513 2513 end
2514 2514 end
2515 2515 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2516 2516 assert_equal 0, copy.descendants.count
2517 2517 end
2518 2518
2519 2519 def test_create_as_copy_with_failure
2520 2520 @request.session[:user_id] = 2
2521 2521 post :create, :project_id => 1, :copy_from => 1,
2522 2522 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2523 2523
2524 2524 assert_response :success
2525 2525 assert_template 'new'
2526 2526
2527 2527 assert_not_nil assigns(:issue)
2528 2528 assert assigns(:issue).copy?
2529 2529
2530 2530 assert_select 'form#issue-form[action=/projects/ecookbook/issues]' do
2531 2531 assert_select 'select[name=?]', 'issue[project_id]' do
2532 2532 assert_select 'option[value=1]:not([selected])', :text => 'eCookbook'
2533 2533 assert_select 'option[value=2][selected=selected]', :text => 'OnlineStore'
2534 2534 end
2535 2535 assert_select 'input[name=copy_from][value=1]'
2536 2536 end
2537 2537 end
2538 2538
2539 2539 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2540 2540 @request.session[:user_id] = 2
2541 2541 assert !User.find(2).member_of?(Project.find(4))
2542 2542
2543 2543 assert_difference 'Issue.count' do
2544 2544 post :create, :project_id => 1, :copy_from => 1,
2545 2545 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2546 2546 end
2547 2547 issue = Issue.first(:order => 'id DESC')
2548 2548 assert_equal 1, issue.project_id
2549 2549 end
2550 2550
2551 2551 def test_get_edit
2552 2552 @request.session[:user_id] = 2
2553 2553 get :edit, :id => 1
2554 2554 assert_response :success
2555 2555 assert_template 'edit'
2556 2556 assert_not_nil assigns(:issue)
2557 2557 assert_equal Issue.find(1), assigns(:issue)
2558 2558
2559 2559 # Be sure we don't display inactive IssuePriorities
2560 2560 assert ! IssuePriority.find(15).active?
2561 2561 assert_select 'select[name=?]', 'issue[priority_id]' do
2562 2562 assert_select 'option[value=15]', 0
2563 2563 end
2564 2564 end
2565 2565
2566 2566 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2567 2567 @request.session[:user_id] = 2
2568 2568 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2569 2569
2570 2570 get :edit, :id => 1
2571 2571 assert_select 'input[name=?]', 'time_entry[hours]'
2572 2572 end
2573 2573
2574 2574 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2575 2575 @request.session[:user_id] = 2
2576 2576 Role.find_by_name('Manager').remove_permission! :log_time
2577 2577
2578 2578 get :edit, :id => 1
2579 2579 assert_select 'input[name=?]', 'time_entry[hours]', 0
2580 2580 end
2581 2581
2582 2582 def test_get_edit_with_params
2583 2583 @request.session[:user_id] = 2
2584 2584 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2585 2585 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2586 2586 assert_response :success
2587 2587 assert_template 'edit'
2588 2588
2589 2589 issue = assigns(:issue)
2590 2590 assert_not_nil issue
2591 2591
2592 2592 assert_equal 5, issue.status_id
2593 2593 assert_select 'select[name=?]', 'issue[status_id]' do
2594 2594 assert_select 'option[value=5][selected=selected]', :text => 'Closed'
2595 2595 end
2596 2596
2597 2597 assert_equal 7, issue.priority_id
2598 2598 assert_select 'select[name=?]', 'issue[priority_id]' do
2599 2599 assert_select 'option[value=7][selected=selected]', :text => 'Urgent'
2600 2600 end
2601 2601
2602 2602 assert_select 'input[name=?][value=2.5]', 'time_entry[hours]'
2603 2603 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2604 2604 assert_select 'option[value=10][selected=selected]', :text => 'Development'
2605 2605 end
2606 2606 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2607 2607 end
2608 2608
2609 2609 def test_get_edit_with_multi_custom_field
2610 2610 field = CustomField.find(1)
2611 2611 field.update_attribute :multiple, true
2612 2612 issue = Issue.find(1)
2613 2613 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2614 2614 issue.save!
2615 2615
2616 2616 @request.session[:user_id] = 2
2617 2617 get :edit, :id => 1
2618 2618 assert_response :success
2619 2619 assert_template 'edit'
2620 2620
2621 2621 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2622 2622 assert_select 'option', 3
2623 2623 assert_select 'option[value=MySQL][selected=selected]'
2624 2624 assert_select 'option[value=Oracle][selected=selected]'
2625 2625 assert_select 'option[value=PostgreSQL]:not([selected])'
2626 2626 end
2627 2627 end
2628 2628
2629 2629 def test_update_edit_form
2630 2630 @request.session[:user_id] = 2
2631 2631 xhr :put, :new, :project_id => 1,
2632 2632 :id => 1,
2633 2633 :issue => {:tracker_id => 2,
2634 2634 :subject => 'This is the test_new issue',
2635 2635 :description => 'This is the description',
2636 2636 :priority_id => 5}
2637 2637 assert_response :success
2638 2638 assert_equal 'text/javascript', response.content_type
2639 2639 assert_template 'update_form'
2640 2640 assert_template 'form'
2641 2641
2642 2642 issue = assigns(:issue)
2643 2643 assert_kind_of Issue, issue
2644 2644 assert_equal 1, issue.id
2645 2645 assert_equal 1, issue.project_id
2646 2646 assert_equal 2, issue.tracker_id
2647 2647 assert_equal 'This is the test_new issue', issue.subject
2648 2648 end
2649 2649
2650 2650 def test_update_edit_form_should_keep_issue_author
2651 2651 @request.session[:user_id] = 3
2652 2652 xhr :put, :new, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2653 2653 assert_response :success
2654 2654 assert_equal 'text/javascript', response.content_type
2655 2655
2656 2656 issue = assigns(:issue)
2657 2657 assert_equal User.find(2), issue.author
2658 2658 assert_equal 2, issue.author_id
2659 2659 assert_not_equal User.current, issue.author
2660 2660 end
2661 2661
2662 2662 def test_update_edit_form_should_propose_transitions_based_on_initial_status
2663 2663 @request.session[:user_id] = 2
2664 2664 WorkflowTransition.delete_all
2665 2665 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2666 2666 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2667 2667 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2668 2668
2669 2669 xhr :put, :new, :project_id => 1,
2670 2670 :id => 2,
2671 2671 :issue => {:tracker_id => 2,
2672 2672 :status_id => 5,
2673 2673 :subject => 'This is an issue'}
2674 2674
2675 2675 assert_equal 5, assigns(:issue).status_id
2676 2676 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2677 2677 end
2678 2678
2679 2679 def test_update_edit_form_with_project_change
2680 2680 @request.session[:user_id] = 2
2681 2681 xhr :put, :new, :project_id => 1,
2682 2682 :id => 1,
2683 2683 :issue => {:project_id => 2,
2684 2684 :tracker_id => 2,
2685 2685 :subject => 'This is the test_new issue',
2686 2686 :description => 'This is the description',
2687 2687 :priority_id => 5}
2688 2688 assert_response :success
2689 2689 assert_template 'form'
2690 2690
2691 2691 issue = assigns(:issue)
2692 2692 assert_kind_of Issue, issue
2693 2693 assert_equal 1, issue.id
2694 2694 assert_equal 2, issue.project_id
2695 2695 assert_equal 2, issue.tracker_id
2696 2696 assert_equal 'This is the test_new issue', issue.subject
2697 2697 end
2698 2698
2699 2699 def test_put_update_without_custom_fields_param
2700 2700 @request.session[:user_id] = 2
2701 2701 ActionMailer::Base.deliveries.clear
2702 2702
2703 2703 issue = Issue.find(1)
2704 2704 assert_equal '125', issue.custom_value_for(2).value
2705 2705 old_subject = issue.subject
2706 2706 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2707 2707
2708 2708 assert_difference('Journal.count') do
2709 2709 assert_difference('JournalDetail.count', 2) do
2710 2710 put :update, :id => 1, :issue => {:subject => new_subject,
2711 2711 :priority_id => '6',
2712 2712 :category_id => '1' # no change
2713 2713 }
2714 2714 end
2715 2715 end
2716 2716 assert_redirected_to :action => 'show', :id => '1'
2717 2717 issue.reload
2718 2718 assert_equal new_subject, issue.subject
2719 2719 # Make sure custom fields were not cleared
2720 2720 assert_equal '125', issue.custom_value_for(2).value
2721 2721
2722 2722 mail = ActionMailer::Base.deliveries.last
2723 2723 assert_not_nil mail
2724 2724 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2725 2725 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2726 2726 end
2727 2727
2728 2728 def test_put_update_with_project_change
2729 2729 @request.session[:user_id] = 2
2730 2730 ActionMailer::Base.deliveries.clear
2731 2731
2732 2732 assert_difference('Journal.count') do
2733 2733 assert_difference('JournalDetail.count', 3) do
2734 2734 put :update, :id => 1, :issue => {:project_id => '2',
2735 2735 :tracker_id => '1', # no change
2736 2736 :priority_id => '6',
2737 2737 :category_id => '3'
2738 2738 }
2739 2739 end
2740 2740 end
2741 2741 assert_redirected_to :action => 'show', :id => '1'
2742 2742 issue = Issue.find(1)
2743 2743 assert_equal 2, issue.project_id
2744 2744 assert_equal 1, issue.tracker_id
2745 2745 assert_equal 6, issue.priority_id
2746 2746 assert_equal 3, issue.category_id
2747 2747
2748 2748 mail = ActionMailer::Base.deliveries.last
2749 2749 assert_not_nil mail
2750 2750 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2751 2751 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2752 2752 end
2753 2753
2754 2754 def test_put_update_with_tracker_change
2755 2755 @request.session[:user_id] = 2
2756 2756 ActionMailer::Base.deliveries.clear
2757 2757
2758 2758 assert_difference('Journal.count') do
2759 2759 assert_difference('JournalDetail.count', 2) do
2760 2760 put :update, :id => 1, :issue => {:project_id => '1',
2761 2761 :tracker_id => '2',
2762 2762 :priority_id => '6'
2763 2763 }
2764 2764 end
2765 2765 end
2766 2766 assert_redirected_to :action => 'show', :id => '1'
2767 2767 issue = Issue.find(1)
2768 2768 assert_equal 1, issue.project_id
2769 2769 assert_equal 2, issue.tracker_id
2770 2770 assert_equal 6, issue.priority_id
2771 2771 assert_equal 1, issue.category_id
2772 2772
2773 2773 mail = ActionMailer::Base.deliveries.last
2774 2774 assert_not_nil mail
2775 2775 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2776 2776 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2777 2777 end
2778 2778
2779 2779 def test_put_update_with_custom_field_change
2780 2780 @request.session[:user_id] = 2
2781 2781 issue = Issue.find(1)
2782 2782 assert_equal '125', issue.custom_value_for(2).value
2783 2783
2784 2784 assert_difference('Journal.count') do
2785 2785 assert_difference('JournalDetail.count', 3) do
2786 2786 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2787 2787 :priority_id => '6',
2788 2788 :category_id => '1', # no change
2789 2789 :custom_field_values => { '2' => 'New custom value' }
2790 2790 }
2791 2791 end
2792 2792 end
2793 2793 assert_redirected_to :action => 'show', :id => '1'
2794 2794 issue.reload
2795 2795 assert_equal 'New custom value', issue.custom_value_for(2).value
2796 2796
2797 2797 mail = ActionMailer::Base.deliveries.last
2798 2798 assert_not_nil mail
2799 2799 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2800 2800 end
2801 2801
2802 2802 def test_put_update_with_multi_custom_field_change
2803 2803 field = CustomField.find(1)
2804 2804 field.update_attribute :multiple, true
2805 2805 issue = Issue.find(1)
2806 2806 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2807 2807 issue.save!
2808 2808
2809 2809 @request.session[:user_id] = 2
2810 2810 assert_difference('Journal.count') do
2811 2811 assert_difference('JournalDetail.count', 3) do
2812 2812 put :update, :id => 1,
2813 2813 :issue => {
2814 2814 :subject => 'Custom field change',
2815 2815 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2816 2816 }
2817 2817 end
2818 2818 end
2819 2819 assert_redirected_to :action => 'show', :id => '1'
2820 2820 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2821 2821 end
2822 2822
2823 2823 def test_put_update_with_status_and_assignee_change
2824 2824 issue = Issue.find(1)
2825 2825 assert_equal 1, issue.status_id
2826 2826 @request.session[:user_id] = 2
2827 2827 assert_difference('TimeEntry.count', 0) do
2828 2828 put :update,
2829 2829 :id => 1,
2830 2830 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2831 2831 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2832 2832 end
2833 2833 assert_redirected_to :action => 'show', :id => '1'
2834 2834 issue.reload
2835 2835 assert_equal 2, issue.status_id
2836 2836 j = Journal.order('id DESC').first
2837 2837 assert_equal 'Assigned to dlopper', j.notes
2838 2838 assert_equal 2, j.details.size
2839 2839
2840 2840 mail = ActionMailer::Base.deliveries.last
2841 2841 assert_mail_body_match "Status changed from New to Assigned", mail
2842 2842 # subject should contain the new status
2843 2843 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2844 2844 end
2845 2845
2846 2846 def test_put_update_with_note_only
2847 2847 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2848 2848 # anonymous user
2849 2849 put :update,
2850 2850 :id => 1,
2851 2851 :issue => { :notes => notes }
2852 2852 assert_redirected_to :action => 'show', :id => '1'
2853 2853 j = Journal.order('id DESC').first
2854 2854 assert_equal notes, j.notes
2855 2855 assert_equal 0, j.details.size
2856 2856 assert_equal User.anonymous, j.user
2857 2857
2858 2858 mail = ActionMailer::Base.deliveries.last
2859 2859 assert_mail_body_match notes, mail
2860 2860 end
2861 2861
2862 2862 def test_put_update_with_private_note_only
2863 2863 notes = 'Private note'
2864 2864 @request.session[:user_id] = 2
2865 2865
2866 2866 assert_difference 'Journal.count' do
2867 2867 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2868 2868 assert_redirected_to :action => 'show', :id => '1'
2869 2869 end
2870 2870
2871 2871 j = Journal.order('id DESC').first
2872 2872 assert_equal notes, j.notes
2873 2873 assert_equal true, j.private_notes
2874 2874 end
2875 2875
2876 2876 def test_put_update_with_private_note_and_changes
2877 2877 notes = 'Private note'
2878 2878 @request.session[:user_id] = 2
2879 2879
2880 2880 assert_difference 'Journal.count', 2 do
2881 2881 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2882 2882 assert_redirected_to :action => 'show', :id => '1'
2883 2883 end
2884 2884
2885 2885 j = Journal.order('id DESC').first
2886 2886 assert_equal notes, j.notes
2887 2887 assert_equal true, j.private_notes
2888 2888 assert_equal 0, j.details.count
2889 2889
2890 2890 j = Journal.order('id DESC').offset(1).first
2891 2891 assert_nil j.notes
2892 2892 assert_equal false, j.private_notes
2893 2893 assert_equal 1, j.details.count
2894 2894 end
2895 2895
2896 2896 def test_put_update_with_note_and_spent_time
2897 2897 @request.session[:user_id] = 2
2898 2898 spent_hours_before = Issue.find(1).spent_hours
2899 2899 assert_difference('TimeEntry.count') do
2900 2900 put :update,
2901 2901 :id => 1,
2902 2902 :issue => { :notes => '2.5 hours added' },
2903 2903 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2904 2904 end
2905 2905 assert_redirected_to :action => 'show', :id => '1'
2906 2906
2907 2907 issue = Issue.find(1)
2908 2908
2909 2909 j = Journal.order('id DESC').first
2910 2910 assert_equal '2.5 hours added', j.notes
2911 2911 assert_equal 0, j.details.size
2912 2912
2913 2913 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2914 2914 assert_not_nil t
2915 2915 assert_equal 2.5, t.hours
2916 2916 assert_equal spent_hours_before + 2.5, issue.spent_hours
2917 2917 end
2918 2918
2919 2919 def test_put_update_with_attachment_only
2920 2920 set_tmp_attachments_directory
2921 2921
2922 2922 # Delete all fixtured journals, a race condition can occur causing the wrong
2923 2923 # journal to get fetched in the next find.
2924 2924 Journal.delete_all
2925 2925
2926 2926 # anonymous user
2927 2927 assert_difference 'Attachment.count' do
2928 2928 put :update, :id => 1,
2929 2929 :issue => {:notes => ''},
2930 2930 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2931 2931 end
2932 2932
2933 2933 assert_redirected_to :action => 'show', :id => '1'
2934 2934 j = Issue.find(1).journals.reorder('id DESC').first
2935 2935 assert j.notes.blank?
2936 2936 assert_equal 1, j.details.size
2937 2937 assert_equal 'testfile.txt', j.details.first.value
2938 2938 assert_equal User.anonymous, j.user
2939 2939
2940 2940 attachment = Attachment.first(:order => 'id DESC')
2941 2941 assert_equal Issue.find(1), attachment.container
2942 2942 assert_equal User.anonymous, attachment.author
2943 2943 assert_equal 'testfile.txt', attachment.filename
2944 2944 assert_equal 'text/plain', attachment.content_type
2945 2945 assert_equal 'test file', attachment.description
2946 2946 assert_equal 59, attachment.filesize
2947 2947 assert File.exists?(attachment.diskfile)
2948 2948 assert_equal 59, File.size(attachment.diskfile)
2949 2949
2950 2950 mail = ActionMailer::Base.deliveries.last
2951 2951 assert_mail_body_match 'testfile.txt', mail
2952 2952 end
2953 2953
2954 2954 def test_put_update_with_failure_should_save_attachments
2955 2955 set_tmp_attachments_directory
2956 2956 @request.session[:user_id] = 2
2957 2957
2958 2958 assert_no_difference 'Journal.count' do
2959 2959 assert_difference 'Attachment.count' do
2960 2960 put :update, :id => 1,
2961 2961 :issue => { :subject => '' },
2962 2962 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2963 2963 assert_response :success
2964 2964 assert_template 'edit'
2965 2965 end
2966 2966 end
2967 2967
2968 2968 attachment = Attachment.first(:order => 'id DESC')
2969 2969 assert_equal 'testfile.txt', attachment.filename
2970 2970 assert File.exists?(attachment.diskfile)
2971 2971 assert_nil attachment.container
2972 2972
2973 2973 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2974 2974 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2975 2975 end
2976 2976
2977 2977 def test_put_update_with_failure_should_keep_saved_attachments
2978 2978 set_tmp_attachments_directory
2979 2979 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2980 2980 @request.session[:user_id] = 2
2981 2981
2982 2982 assert_no_difference 'Journal.count' do
2983 2983 assert_no_difference 'Attachment.count' do
2984 2984 put :update, :id => 1,
2985 2985 :issue => { :subject => '' },
2986 2986 :attachments => {'p0' => {'token' => attachment.token}}
2987 2987 assert_response :success
2988 2988 assert_template 'edit'
2989 2989 end
2990 2990 end
2991 2991
2992 2992 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2993 2993 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2994 2994 end
2995 2995
2996 2996 def test_put_update_should_attach_saved_attachments
2997 2997 set_tmp_attachments_directory
2998 2998 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2999 2999 @request.session[:user_id] = 2
3000 3000
3001 3001 assert_difference 'Journal.count' do
3002 3002 assert_difference 'JournalDetail.count' do
3003 3003 assert_no_difference 'Attachment.count' do
3004 3004 put :update, :id => 1,
3005 3005 :issue => {:notes => 'Attachment added'},
3006 3006 :attachments => {'p0' => {'token' => attachment.token}}
3007 3007 assert_redirected_to '/issues/1'
3008 3008 end
3009 3009 end
3010 3010 end
3011 3011
3012 3012 attachment.reload
3013 3013 assert_equal Issue.find(1), attachment.container
3014 3014
3015 3015 journal = Journal.first(:order => 'id DESC')
3016 3016 assert_equal 1, journal.details.size
3017 3017 assert_equal 'testfile.txt', journal.details.first.value
3018 3018 end
3019 3019
3020 3020 def test_put_update_with_attachment_that_fails_to_save
3021 3021 set_tmp_attachments_directory
3022 3022
3023 3023 # Delete all fixtured journals, a race condition can occur causing the wrong
3024 3024 # journal to get fetched in the next find.
3025 3025 Journal.delete_all
3026 3026
3027 3027 # Mock out the unsaved attachment
3028 3028 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3029 3029
3030 3030 # anonymous user
3031 3031 put :update,
3032 3032 :id => 1,
3033 3033 :issue => {:notes => ''},
3034 3034 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3035 3035 assert_redirected_to :action => 'show', :id => '1'
3036 3036 assert_equal '1 file(s) could not be saved.', flash[:warning]
3037 3037 end
3038 3038
3039 3039 def test_put_update_with_no_change
3040 3040 issue = Issue.find(1)
3041 3041 issue.journals.clear
3042 3042 ActionMailer::Base.deliveries.clear
3043 3043
3044 3044 put :update,
3045 3045 :id => 1,
3046 3046 :issue => {:notes => ''}
3047 3047 assert_redirected_to :action => 'show', :id => '1'
3048 3048
3049 3049 issue.reload
3050 3050 assert issue.journals.empty?
3051 3051 # No email should be sent
3052 3052 assert ActionMailer::Base.deliveries.empty?
3053 3053 end
3054 3054
3055 3055 def test_put_update_should_send_a_notification
3056 3056 @request.session[:user_id] = 2
3057 3057 ActionMailer::Base.deliveries.clear
3058 3058 issue = Issue.find(1)
3059 3059 old_subject = issue.subject
3060 3060 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3061 3061
3062 3062 put :update, :id => 1, :issue => {:subject => new_subject,
3063 3063 :priority_id => '6',
3064 3064 :category_id => '1' # no change
3065 3065 }
3066 3066 assert_equal 1, ActionMailer::Base.deliveries.size
3067 3067 end
3068 3068
3069 3069 def test_put_update_with_invalid_spent_time_hours_only
3070 3070 @request.session[:user_id] = 2
3071 3071 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3072 3072
3073 3073 assert_no_difference('Journal.count') do
3074 3074 put :update,
3075 3075 :id => 1,
3076 3076 :issue => {:notes => notes},
3077 3077 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3078 3078 end
3079 3079 assert_response :success
3080 3080 assert_template 'edit'
3081 3081
3082 3082 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3083 3083 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3084 3084 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3085 3085 end
3086 3086
3087 3087 def test_put_update_with_invalid_spent_time_comments_only
3088 3088 @request.session[:user_id] = 2
3089 3089 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3090 3090
3091 3091 assert_no_difference('Journal.count') do
3092 3092 put :update,
3093 3093 :id => 1,
3094 3094 :issue => {:notes => notes},
3095 3095 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3096 3096 end
3097 3097 assert_response :success
3098 3098 assert_template 'edit'
3099 3099
3100 3100 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3101 3101 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3102 3102 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3103 3103 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3104 3104 end
3105 3105
3106 3106 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3107 3107 issue = Issue.find(2)
3108 3108 @request.session[:user_id] = 2
3109 3109
3110 3110 put :update,
3111 3111 :id => issue.id,
3112 3112 :issue => {
3113 3113 :fixed_version_id => 4
3114 3114 }
3115 3115
3116 3116 assert_response :redirect
3117 3117 issue.reload
3118 3118 assert_equal 4, issue.fixed_version_id
3119 3119 assert_not_equal issue.project_id, issue.fixed_version.project_id
3120 3120 end
3121 3121
3122 3122 def test_put_update_should_redirect_back_using_the_back_url_parameter
3123 3123 issue = Issue.find(2)
3124 3124 @request.session[:user_id] = 2
3125 3125
3126 3126 put :update,
3127 3127 :id => issue.id,
3128 3128 :issue => {
3129 3129 :fixed_version_id => 4
3130 3130 },
3131 3131 :back_url => '/issues'
3132 3132
3133 3133 assert_response :redirect
3134 3134 assert_redirected_to '/issues'
3135 3135 end
3136 3136
3137 3137 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3138 3138 issue = Issue.find(2)
3139 3139 @request.session[:user_id] = 2
3140 3140
3141 3141 put :update,
3142 3142 :id => issue.id,
3143 3143 :issue => {
3144 3144 :fixed_version_id => 4
3145 3145 },
3146 3146 :back_url => 'http://google.com'
3147 3147
3148 3148 assert_response :redirect
3149 3149 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3150 3150 end
3151 3151
3152 3152 def test_get_bulk_edit
3153 3153 @request.session[:user_id] = 2
3154 3154 get :bulk_edit, :ids => [1, 2]
3155 3155 assert_response :success
3156 3156 assert_template 'bulk_edit'
3157 3157
3158 assert_select 'select[name=?]', 'issue[project_id]'
3159 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3160
3161 # Project specific custom field, date type
3162 field = CustomField.find(9)
3163 assert !field.is_for_all?
3164 assert_equal 'date', field.field_format
3165 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3158 assert_select 'ul#bulk-selection' do
3159 assert_select 'li', 2
3160 assert_select 'li a', :text => 'Bug #1'
3161 end
3166 3162
3167 # System wide custom field
3168 assert CustomField.find(1).is_for_all?
3169 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3163 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3164 assert_select 'input[name=?]', 'ids[]', 2
3165 assert_select 'input[name=?][value=1][type=hidden]', 'ids[]'
3170 3166
3171 # Be sure we don't display inactive IssuePriorities
3172 assert ! IssuePriority.find(15).active?
3173 assert_select 'select[name=?]', 'issue[priority_id]' do
3174 assert_select 'option[value=15]', 0
3167 assert_select 'select[name=?]', 'issue[project_id]'
3168 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3169
3170 # Project specific custom field, date type
3171 field = CustomField.find(9)
3172 assert !field.is_for_all?
3173 assert_equal 'date', field.field_format
3174 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3175
3176 # System wide custom field
3177 assert CustomField.find(1).is_for_all?
3178 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3179
3180 # Be sure we don't display inactive IssuePriorities
3181 assert ! IssuePriority.find(15).active?
3182 assert_select 'select[name=?]', 'issue[priority_id]' do
3183 assert_select 'option[value=15]', 0
3184 end
3175 3185 end
3176 3186 end
3177 3187
3178 3188 def test_get_bulk_edit_on_different_projects
3179 3189 @request.session[:user_id] = 2
3180 3190 get :bulk_edit, :ids => [1, 2, 6]
3181 3191 assert_response :success
3182 3192 assert_template 'bulk_edit'
3183 3193
3184 3194 # Can not set issues from different projects as children of an issue
3185 3195 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3186 3196
3187 3197 # Project specific custom field, date type
3188 3198 field = CustomField.find(9)
3189 3199 assert !field.is_for_all?
3190 3200 assert !field.project_ids.include?(Issue.find(6).project_id)
3191 3201 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3192 3202 end
3193 3203
3194 3204 def test_get_bulk_edit_with_user_custom_field
3195 3205 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3196 3206
3197 3207 @request.session[:user_id] = 2
3198 3208 get :bulk_edit, :ids => [1, 2]
3199 3209 assert_response :success
3200 3210 assert_template 'bulk_edit'
3201 3211
3202 3212 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3203 3213 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3204 3214 end
3205 3215 end
3206 3216
3207 3217 def test_get_bulk_edit_with_version_custom_field
3208 3218 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3209 3219
3210 3220 @request.session[:user_id] = 2
3211 3221 get :bulk_edit, :ids => [1, 2]
3212 3222 assert_response :success
3213 3223 assert_template 'bulk_edit'
3214 3224
3215 3225 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3216 3226 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3217 3227 end
3218 3228 end
3219 3229
3220 3230 def test_get_bulk_edit_with_multi_custom_field
3221 3231 field = CustomField.find(1)
3222 3232 field.update_attribute :multiple, true
3223 3233
3224 3234 @request.session[:user_id] = 2
3225 3235 get :bulk_edit, :ids => [1, 2]
3226 3236 assert_response :success
3227 3237 assert_template 'bulk_edit'
3228 3238
3229 3239 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3230 3240 assert_select 'option', field.possible_values.size + 1 # "none" options
3231 3241 end
3232 3242 end
3233 3243
3234 3244 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3235 3245 WorkflowTransition.delete_all
3236 3246 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
3237 3247 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
3238 3248 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
3239 3249 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
3240 3250 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3241 3251 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
3242 3252 @request.session[:user_id] = 2
3243 3253 get :bulk_edit, :ids => [1, 2]
3244 3254
3245 3255 assert_response :success
3246 3256 statuses = assigns(:available_statuses)
3247 3257 assert_not_nil statuses
3248 3258 assert_equal [1, 3], statuses.map(&:id).sort
3249 3259
3250 3260 assert_select 'select[name=?]', 'issue[status_id]' do
3251 3261 assert_select 'option', 3 # 2 statuses + "no change" option
3252 3262 end
3253 3263 end
3254 3264
3255 3265 def test_bulk_edit_should_propose_target_project_open_shared_versions
3256 3266 @request.session[:user_id] = 2
3257 3267 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3258 3268 assert_response :success
3259 3269 assert_template 'bulk_edit'
3260 3270 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3261 3271
3262 3272 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3263 3273 assert_select 'option', :text => '2.0'
3264 3274 end
3265 3275 end
3266 3276
3267 3277 def test_bulk_edit_should_propose_target_project_categories
3268 3278 @request.session[:user_id] = 2
3269 3279 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3270 3280 assert_response :success
3271 3281 assert_template 'bulk_edit'
3272 3282 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3273 3283
3274 3284 assert_select 'select[name=?]', 'issue[category_id]' do
3275 3285 assert_select 'option', :text => 'Recipes'
3276 3286 end
3277 3287 end
3278 3288
3279 3289 def test_bulk_update
3280 3290 @request.session[:user_id] = 2
3281 3291 # update issues priority
3282 3292 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3283 3293 :issue => {:priority_id => 7,
3284 3294 :assigned_to_id => '',
3285 3295 :custom_field_values => {'2' => ''}}
3286 3296
3287 3297 assert_response 302
3288 3298 # check that the issues were updated
3289 3299 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3290 3300
3291 3301 issue = Issue.find(1)
3292 3302 journal = issue.journals.reorder('created_on DESC').first
3293 3303 assert_equal '125', issue.custom_value_for(2).value
3294 3304 assert_equal 'Bulk editing', journal.notes
3295 3305 assert_equal 1, journal.details.size
3296 3306 end
3297 3307
3298 3308 def test_bulk_update_with_group_assignee
3299 3309 group = Group.find(11)
3300 3310 project = Project.find(1)
3301 3311 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3302 3312
3303 3313 @request.session[:user_id] = 2
3304 3314 # update issues assignee
3305 3315 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3306 3316 :issue => {:priority_id => '',
3307 3317 :assigned_to_id => group.id,
3308 3318 :custom_field_values => {'2' => ''}}
3309 3319
3310 3320 assert_response 302
3311 3321 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3312 3322 end
3313 3323
3314 3324 def test_bulk_update_on_different_projects
3315 3325 @request.session[:user_id] = 2
3316 3326 # update issues priority
3317 3327 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3318 3328 :issue => {:priority_id => 7,
3319 3329 :assigned_to_id => '',
3320 3330 :custom_field_values => {'2' => ''}}
3321 3331
3322 3332 assert_response 302
3323 3333 # check that the issues were updated
3324 3334 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3325 3335
3326 3336 issue = Issue.find(1)
3327 3337 journal = issue.journals.reorder('created_on DESC').first
3328 3338 assert_equal '125', issue.custom_value_for(2).value
3329 3339 assert_equal 'Bulk editing', journal.notes
3330 3340 assert_equal 1, journal.details.size
3331 3341 end
3332 3342
3333 3343 def test_bulk_update_on_different_projects_without_rights
3334 3344 @request.session[:user_id] = 3
3335 3345 user = User.find(3)
3336 3346 action = { :controller => "issues", :action => "bulk_update" }
3337 3347 assert user.allowed_to?(action, Issue.find(1).project)
3338 3348 assert ! user.allowed_to?(action, Issue.find(6).project)
3339 3349 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3340 3350 :issue => {:priority_id => 7,
3341 3351 :assigned_to_id => '',
3342 3352 :custom_field_values => {'2' => ''}}
3343 3353 assert_response 403
3344 3354 assert_not_equal "Bulk should fail", Journal.last.notes
3345 3355 end
3346 3356
3347 3357 def test_bullk_update_should_send_a_notification
3348 3358 @request.session[:user_id] = 2
3349 3359 ActionMailer::Base.deliveries.clear
3350 3360 post(:bulk_update,
3351 3361 {
3352 3362 :ids => [1, 2],
3353 3363 :notes => 'Bulk editing',
3354 3364 :issue => {
3355 3365 :priority_id => 7,
3356 3366 :assigned_to_id => '',
3357 3367 :custom_field_values => {'2' => ''}
3358 3368 }
3359 3369 })
3360 3370
3361 3371 assert_response 302
3362 3372 assert_equal 2, ActionMailer::Base.deliveries.size
3363 3373 end
3364 3374
3365 3375 def test_bulk_update_project
3366 3376 @request.session[:user_id] = 2
3367 3377 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3368 3378 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3369 3379 # Issues moved to project 2
3370 3380 assert_equal 2, Issue.find(1).project_id
3371 3381 assert_equal 2, Issue.find(2).project_id
3372 3382 # No tracker change
3373 3383 assert_equal 1, Issue.find(1).tracker_id
3374 3384 assert_equal 2, Issue.find(2).tracker_id
3375 3385 end
3376 3386
3377 3387 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3378 3388 @request.session[:user_id] = 2
3379 3389 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3380 3390 assert_redirected_to '/issues/1'
3381 3391 end
3382 3392
3383 3393 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3384 3394 @request.session[:user_id] = 2
3385 3395 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3386 3396 assert_redirected_to '/projects/onlinestore/issues'
3387 3397 end
3388 3398
3389 3399 def test_bulk_update_tracker
3390 3400 @request.session[:user_id] = 2
3391 3401 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3392 3402 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3393 3403 assert_equal 2, Issue.find(1).tracker_id
3394 3404 assert_equal 2, Issue.find(2).tracker_id
3395 3405 end
3396 3406
3397 3407 def test_bulk_update_status
3398 3408 @request.session[:user_id] = 2
3399 3409 # update issues priority
3400 3410 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3401 3411 :issue => {:priority_id => '',
3402 3412 :assigned_to_id => '',
3403 3413 :status_id => '5'}
3404 3414
3405 3415 assert_response 302
3406 3416 issue = Issue.find(1)
3407 3417 assert issue.closed?
3408 3418 end
3409 3419
3410 3420 def test_bulk_update_priority
3411 3421 @request.session[:user_id] = 2
3412 3422 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3413 3423
3414 3424 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3415 3425 assert_equal 6, Issue.find(1).priority_id
3416 3426 assert_equal 6, Issue.find(2).priority_id
3417 3427 end
3418 3428
3419 3429 def test_bulk_update_with_notes
3420 3430 @request.session[:user_id] = 2
3421 3431 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3422 3432
3423 3433 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3424 3434 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3425 3435 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3426 3436 end
3427 3437
3428 3438 def test_bulk_update_parent_id
3429 3439 @request.session[:user_id] = 2
3430 3440 post :bulk_update, :ids => [1, 3],
3431 3441 :notes => 'Bulk editing parent',
3432 3442 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
3433 3443
3434 3444 assert_response 302
3435 3445 parent = Issue.find(2)
3436 3446 assert_equal parent.id, Issue.find(1).parent_id
3437 3447 assert_equal parent.id, Issue.find(3).parent_id
3438 3448 assert_equal [1, 3], parent.children.collect(&:id).sort
3439 3449 end
3440 3450
3441 3451 def test_bulk_update_custom_field
3442 3452 @request.session[:user_id] = 2
3443 3453 # update issues priority
3444 3454 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3445 3455 :issue => {:priority_id => '',
3446 3456 :assigned_to_id => '',
3447 3457 :custom_field_values => {'2' => '777'}}
3448 3458
3449 3459 assert_response 302
3450 3460
3451 3461 issue = Issue.find(1)
3452 3462 journal = issue.journals.reorder('created_on DESC').first
3453 3463 assert_equal '777', issue.custom_value_for(2).value
3454 3464 assert_equal 1, journal.details.size
3455 3465 assert_equal '125', journal.details.first.old_value
3456 3466 assert_equal '777', journal.details.first.value
3457 3467 end
3458 3468
3459 3469 def test_bulk_update_custom_field_to_blank
3460 3470 @request.session[:user_id] = 2
3461 3471 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3462 3472 :issue => {:priority_id => '',
3463 3473 :assigned_to_id => '',
3464 3474 :custom_field_values => {'1' => '__none__'}}
3465 3475 assert_response 302
3466 3476 assert_equal '', Issue.find(1).custom_field_value(1)
3467 3477 assert_equal '', Issue.find(3).custom_field_value(1)
3468 3478 end
3469 3479
3470 3480 def test_bulk_update_multi_custom_field
3471 3481 field = CustomField.find(1)
3472 3482 field.update_attribute :multiple, true
3473 3483
3474 3484 @request.session[:user_id] = 2
3475 3485 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3476 3486 :issue => {:priority_id => '',
3477 3487 :assigned_to_id => '',
3478 3488 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3479 3489
3480 3490 assert_response 302
3481 3491
3482 3492 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3483 3493 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3484 3494 # the custom field is not associated with the issue tracker
3485 3495 assert_nil Issue.find(2).custom_field_value(1)
3486 3496 end
3487 3497
3488 3498 def test_bulk_update_multi_custom_field_to_blank
3489 3499 field = CustomField.find(1)
3490 3500 field.update_attribute :multiple, true
3491 3501
3492 3502 @request.session[:user_id] = 2
3493 3503 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3494 3504 :issue => {:priority_id => '',
3495 3505 :assigned_to_id => '',
3496 3506 :custom_field_values => {'1' => ['__none__']}}
3497 3507 assert_response 302
3498 3508 assert_equal [''], Issue.find(1).custom_field_value(1)
3499 3509 assert_equal [''], Issue.find(3).custom_field_value(1)
3500 3510 end
3501 3511
3502 3512 def test_bulk_update_unassign
3503 3513 assert_not_nil Issue.find(2).assigned_to
3504 3514 @request.session[:user_id] = 2
3505 3515 # unassign issues
3506 3516 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3507 3517 assert_response 302
3508 3518 # check that the issues were updated
3509 3519 assert_nil Issue.find(2).assigned_to
3510 3520 end
3511 3521
3512 3522 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3513 3523 @request.session[:user_id] = 2
3514 3524
3515 3525 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3516 3526
3517 3527 assert_response :redirect
3518 3528 issues = Issue.find([1,2])
3519 3529 issues.each do |issue|
3520 3530 assert_equal 4, issue.fixed_version_id
3521 3531 assert_not_equal issue.project_id, issue.fixed_version.project_id
3522 3532 end
3523 3533 end
3524 3534
3525 3535 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3526 3536 @request.session[:user_id] = 2
3527 3537 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3528 3538
3529 3539 assert_response :redirect
3530 3540 assert_redirected_to '/issues'
3531 3541 end
3532 3542
3533 3543 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3534 3544 @request.session[:user_id] = 2
3535 3545 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3536 3546
3537 3547 assert_response :redirect
3538 3548 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3539 3549 end
3540 3550
3541 3551 def test_bulk_update_with_failure_should_set_flash
3542 3552 @request.session[:user_id] = 2
3543 3553 Issue.update_all("subject = ''", "id = 2") # Make it invalid
3544 3554 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3545 3555
3546 3556 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3547 3557 assert_equal 'Failed to save 1 issue(s) on 2 selected: #2.', flash[:error]
3548 3558 end
3549 3559
3550 3560 def test_get_bulk_copy
3551 3561 @request.session[:user_id] = 2
3552 3562 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3553 3563 assert_response :success
3554 3564 assert_template 'bulk_edit'
3555 3565
3556 3566 issues = assigns(:issues)
3557 3567 assert_not_nil issues
3558 3568 assert_equal [1, 2, 3], issues.map(&:id).sort
3559 3569
3560 3570 assert_select 'input[name=copy_attachments]'
3561 3571 end
3562 3572
3563 3573 def test_bulk_copy_to_another_project
3564 3574 @request.session[:user_id] = 2
3565 3575 assert_difference 'Issue.count', 2 do
3566 3576 assert_no_difference 'Project.find(1).issues.count' do
3567 3577 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3568 3578 end
3569 3579 end
3570 3580 assert_redirected_to '/projects/ecookbook/issues'
3571 3581
3572 3582 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3573 3583 copies.each do |copy|
3574 3584 assert_equal 2, copy.project_id
3575 3585 end
3576 3586 end
3577 3587
3578 3588 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3579 3589 @request.session[:user_id] = 2
3580 3590 issues = [
3581 3591 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1, :priority_id => 2, :subject => 'issue 1', :author_id => 1, :assigned_to_id => nil),
3582 3592 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2, :priority_id => 1, :subject => 'issue 2', :author_id => 2, :assigned_to_id => 3)
3583 3593 ]
3584 3594
3585 3595 assert_difference 'Issue.count', issues.size do
3586 3596 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3587 3597 :issue => {
3588 3598 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3589 3599 :status_id => '', :start_date => '', :due_date => ''
3590 3600 }
3591 3601 end
3592 3602
3593 3603 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3594 3604 issues.each do |orig|
3595 3605 copy = copies.detect {|c| c.subject == orig.subject}
3596 3606 assert_not_nil copy
3597 3607 assert_equal orig.project_id, copy.project_id
3598 3608 assert_equal orig.tracker_id, copy.tracker_id
3599 3609 assert_equal orig.status_id, copy.status_id
3600 3610 assert_equal orig.assigned_to_id, copy.assigned_to_id
3601 3611 assert_equal orig.priority_id, copy.priority_id
3602 3612 end
3603 3613 end
3604 3614
3605 3615 def test_bulk_copy_should_allow_changing_the_issue_attributes
3606 3616 # Fixes random test failure with Mysql
3607 3617 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3608 3618 # doesn't return the expected results
3609 3619 Issue.delete_all("project_id=2")
3610 3620
3611 3621 @request.session[:user_id] = 2
3612 3622 assert_difference 'Issue.count', 2 do
3613 3623 assert_no_difference 'Project.find(1).issues.count' do
3614 3624 post :bulk_update, :ids => [1, 2], :copy => '1',
3615 3625 :issue => {
3616 3626 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3617 3627 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3618 3628 }
3619 3629 end
3620 3630 end
3621 3631
3622 3632 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3623 3633 assert_equal 2, copied_issues.size
3624 3634 copied_issues.each do |issue|
3625 3635 assert_equal 2, issue.project_id, "Project is incorrect"
3626 3636 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3627 3637 assert_equal 1, issue.status_id, "Status is incorrect"
3628 3638 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3629 3639 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3630 3640 end
3631 3641 end
3632 3642
3633 3643 def test_bulk_copy_should_allow_adding_a_note
3634 3644 @request.session[:user_id] = 2
3635 3645 assert_difference 'Issue.count', 1 do
3636 3646 post :bulk_update, :ids => [1], :copy => '1',
3637 3647 :notes => 'Copying one issue',
3638 3648 :issue => {
3639 3649 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3640 3650 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3641 3651 }
3642 3652 end
3643 3653
3644 3654 issue = Issue.first(:order => 'id DESC')
3645 3655 assert_equal 1, issue.journals.size
3646 3656 journal = issue.journals.first
3647 3657 assert_equal 0, journal.details.size
3648 3658 assert_equal 'Copying one issue', journal.notes
3649 3659 end
3650 3660
3651 3661 def test_bulk_copy_should_allow_not_copying_the_attachments
3652 3662 attachment_count = Issue.find(3).attachments.size
3653 3663 assert attachment_count > 0
3654 3664 @request.session[:user_id] = 2
3655 3665
3656 3666 assert_difference 'Issue.count', 1 do
3657 3667 assert_no_difference 'Attachment.count' do
3658 3668 post :bulk_update, :ids => [3], :copy => '1',
3659 3669 :issue => {
3660 3670 :project_id => ''
3661 3671 }
3662 3672 end
3663 3673 end
3664 3674 end
3665 3675
3666 3676 def test_bulk_copy_should_allow_copying_the_attachments
3667 3677 attachment_count = Issue.find(3).attachments.size
3668 3678 assert attachment_count > 0
3669 3679 @request.session[:user_id] = 2
3670 3680
3671 3681 assert_difference 'Issue.count', 1 do
3672 3682 assert_difference 'Attachment.count', attachment_count do
3673 3683 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3674 3684 :issue => {
3675 3685 :project_id => ''
3676 3686 }
3677 3687 end
3678 3688 end
3679 3689 end
3680 3690
3681 3691 def test_bulk_copy_should_add_relations_with_copied_issues
3682 3692 @request.session[:user_id] = 2
3683 3693
3684 3694 assert_difference 'Issue.count', 2 do
3685 3695 assert_difference 'IssueRelation.count', 2 do
3686 3696 post :bulk_update, :ids => [1, 3], :copy => '1',
3687 3697 :issue => {
3688 3698 :project_id => '1'
3689 3699 }
3690 3700 end
3691 3701 end
3692 3702 end
3693 3703
3694 3704 def test_bulk_copy_should_allow_not_copying_the_subtasks
3695 3705 issue = Issue.generate_with_descendants!
3696 3706 @request.session[:user_id] = 2
3697 3707
3698 3708 assert_difference 'Issue.count', 1 do
3699 3709 post :bulk_update, :ids => [issue.id], :copy => '1',
3700 3710 :issue => {
3701 3711 :project_id => ''
3702 3712 }
3703 3713 end
3704 3714 end
3705 3715
3706 3716 def test_bulk_copy_should_allow_copying_the_subtasks
3707 3717 issue = Issue.generate_with_descendants!
3708 3718 count = issue.descendants.count
3709 3719 @request.session[:user_id] = 2
3710 3720
3711 3721 assert_difference 'Issue.count', count+1 do
3712 3722 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3713 3723 :issue => {
3714 3724 :project_id => ''
3715 3725 }
3716 3726 end
3717 3727 copy = Issue.where(:parent_id => nil).order("id DESC").first
3718 3728 assert_equal count, copy.descendants.count
3719 3729 end
3720 3730
3721 3731 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3722 3732 issue = Issue.generate_with_descendants!
3723 3733 count = issue.descendants.count
3724 3734 @request.session[:user_id] = 2
3725 3735
3726 3736 assert_difference 'Issue.count', count+1 do
3727 3737 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3728 3738 :issue => {
3729 3739 :project_id => ''
3730 3740 }
3731 3741 end
3732 3742 copy = Issue.where(:parent_id => nil).order("id DESC").first
3733 3743 assert_equal count, copy.descendants.count
3734 3744 end
3735 3745
3736 3746 def test_bulk_copy_to_another_project_should_follow_when_needed
3737 3747 @request.session[:user_id] = 2
3738 3748 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3739 3749 issue = Issue.first(:order => 'id DESC')
3740 3750 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3741 3751 end
3742 3752
3743 3753 def test_destroy_issue_with_no_time_entries
3744 3754 assert_nil TimeEntry.find_by_issue_id(2)
3745 3755 @request.session[:user_id] = 2
3746 3756
3747 3757 assert_difference 'Issue.count', -1 do
3748 3758 delete :destroy, :id => 2
3749 3759 end
3750 3760 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3751 3761 assert_nil Issue.find_by_id(2)
3752 3762 end
3753 3763
3754 3764 def test_destroy_issues_with_time_entries
3755 3765 @request.session[:user_id] = 2
3756 3766
3757 3767 assert_no_difference 'Issue.count' do
3758 3768 delete :destroy, :ids => [1, 3]
3759 3769 end
3760 3770 assert_response :success
3761 3771 assert_template 'destroy'
3762 3772 assert_not_nil assigns(:hours)
3763 3773 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3764 3774
3765 3775 assert_select 'form' do
3766 3776 assert_select 'input[name=_method][value=delete]'
3767 3777 end
3768 3778 end
3769 3779
3770 3780 def test_destroy_issues_and_destroy_time_entries
3771 3781 @request.session[:user_id] = 2
3772 3782
3773 3783 assert_difference 'Issue.count', -2 do
3774 3784 assert_difference 'TimeEntry.count', -3 do
3775 3785 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3776 3786 end
3777 3787 end
3778 3788 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3779 3789 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3780 3790 assert_nil TimeEntry.find_by_id([1, 2])
3781 3791 end
3782 3792
3783 3793 def test_destroy_issues_and_assign_time_entries_to_project
3784 3794 @request.session[:user_id] = 2
3785 3795
3786 3796 assert_difference 'Issue.count', -2 do
3787 3797 assert_no_difference 'TimeEntry.count' do
3788 3798 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3789 3799 end
3790 3800 end
3791 3801 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3792 3802 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3793 3803 assert_nil TimeEntry.find(1).issue_id
3794 3804 assert_nil TimeEntry.find(2).issue_id
3795 3805 end
3796 3806
3797 3807 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3798 3808 @request.session[:user_id] = 2
3799 3809
3800 3810 assert_difference 'Issue.count', -2 do
3801 3811 assert_no_difference 'TimeEntry.count' do
3802 3812 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3803 3813 end
3804 3814 end
3805 3815 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3806 3816 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3807 3817 assert_equal 2, TimeEntry.find(1).issue_id
3808 3818 assert_equal 2, TimeEntry.find(2).issue_id
3809 3819 end
3810 3820
3811 3821 def test_destroy_issues_from_different_projects
3812 3822 @request.session[:user_id] = 2
3813 3823
3814 3824 assert_difference 'Issue.count', -3 do
3815 3825 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3816 3826 end
3817 3827 assert_redirected_to :controller => 'issues', :action => 'index'
3818 3828 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3819 3829 end
3820 3830
3821 3831 def test_destroy_parent_and_child_issues
3822 3832 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3823 3833 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3824 3834 assert child.is_descendant_of?(parent.reload)
3825 3835
3826 3836 @request.session[:user_id] = 2
3827 3837 assert_difference 'Issue.count', -2 do
3828 3838 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3829 3839 end
3830 3840 assert_response 302
3831 3841 end
3832 3842
3833 3843 def test_destroy_invalid_should_respond_with_404
3834 3844 @request.session[:user_id] = 2
3835 3845 assert_no_difference 'Issue.count' do
3836 3846 delete :destroy, :id => 999
3837 3847 end
3838 3848 assert_response 404
3839 3849 end
3840 3850
3841 3851 def test_default_search_scope
3842 3852 get :index
3843 3853
3844 3854 assert_select 'div#quick-search form' do
3845 3855 assert_select 'input[name=issues][value=1][type=hidden]'
3846 3856 end
3847 3857 end
3848 3858 end
Show file before | Show file after | Hide comments
@@ -1,705 +1,712
1 1 # -*- coding: utf-8 -*-
2 2 # Redmine - project management software
3 3 # Copyright (C) 2006-2012 Jean-Philippe Lang
4 4 #
5 5 # This program is free software; you can redistribute it and/or
6 6 # modify it under the terms of the GNU General Public License
7 7 # as published by the Free Software Foundation; either version 2
8 8 # of the License, or (at your option) any later version.
9 9 #
10 10 # This program is distributed in the hope that it will be useful,
11 11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 13 # GNU General Public License for more details.
14 14 #
15 15 # You should have received a copy of the GNU General Public License
16 16 # along with this program; if not, write to the Free Software
17 17 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 18
19 19 require File.expand_path('../../test_helper', __FILE__)
20 20
21 21 class TimelogControllerTest < ActionController::TestCase
22 22 fixtures :projects, :enabled_modules, :roles, :members,
23 23 :member_roles, :issues, :time_entries, :users,
24 24 :trackers, :enumerations, :issue_statuses,
25 25 :custom_fields, :custom_values
26 26
27 27 include Redmine::I18n
28 28
29 29 def test_new_with_project_id
30 30 @request.session[:user_id] = 3
31 31 get :new, :project_id => 1
32 32 assert_response :success
33 33 assert_template 'new'
34 34 assert_select 'select[name=?]', 'time_entry[project_id]', 0
35 35 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
36 36 end
37 37
38 38 def test_new_with_issue_id
39 39 @request.session[:user_id] = 3
40 40 get :new, :issue_id => 2
41 41 assert_response :success
42 42 assert_template 'new'
43 43 assert_select 'select[name=?]', 'time_entry[project_id]', 0
44 44 assert_select 'input[name=?][value=1][type=hidden]', 'time_entry[project_id]'
45 45 end
46 46
47 47 def test_new_without_project
48 48 @request.session[:user_id] = 3
49 49 get :new
50 50 assert_response :success
51 51 assert_template 'new'
52 52 assert_select 'select[name=?]', 'time_entry[project_id]'
53 53 assert_select 'input[name=?]', 'time_entry[project_id]', 0
54 54 end
55 55
56 56 def test_new_without_project_should_prefill_the_form
57 57 @request.session[:user_id] = 3
58 58 get :new, :time_entry => {:project_id => '1'}
59 59 assert_response :success
60 60 assert_template 'new'
61 61 assert_select 'select[name=?]', 'time_entry[project_id]' do
62 62 assert_select 'option[value=1][selected=selected]'
63 63 end
64 64 assert_select 'input[name=?]', 'time_entry[project_id]', 0
65 65 end
66 66
67 67 def test_new_without_project_should_deny_without_permission
68 68 Role.all.each {|role| role.remove_permission! :log_time}
69 69 @request.session[:user_id] = 3
70 70
71 71 get :new
72 72 assert_response 403
73 73 end
74 74
75 75 def test_new_should_select_default_activity
76 76 @request.session[:user_id] = 3
77 77 get :new, :project_id => 1
78 78 assert_response :success
79 79 assert_select 'select[name=?]', 'time_entry[activity_id]' do
80 80 assert_select 'option[selected=selected]', :text => 'Development'
81 81 end
82 82 end
83 83
84 84 def test_new_should_only_show_active_time_entry_activities
85 85 @request.session[:user_id] = 3
86 86 get :new, :project_id => 1
87 87 assert_response :success
88 88 assert_no_tag 'option', :content => 'Inactive Activity'
89 89 end
90 90
91 91 def test_get_edit_existing_time
92 92 @request.session[:user_id] = 2
93 93 get :edit, :id => 2, :project_id => nil
94 94 assert_response :success
95 95 assert_template 'edit'
96 96 # Default activity selected
97 97 assert_tag :tag => 'form', :attributes => { :action => '/projects/ecookbook/time_entries/2' }
98 98 end
99 99
100 100 def test_get_edit_with_an_existing_time_entry_with_inactive_activity
101 101 te = TimeEntry.find(1)
102 102 te.activity = TimeEntryActivity.find_by_name("Inactive Activity")
103 103 te.save!
104 104
105 105 @request.session[:user_id] = 1
106 106 get :edit, :project_id => 1, :id => 1
107 107 assert_response :success
108 108 assert_template 'edit'
109 109 # Blank option since nothing is pre-selected
110 110 assert_tag :tag => 'option', :content => '--- Please select ---'
111 111 end
112 112
113 113 def test_post_create
114 114 # TODO: should POST to issues’ time log instead of project. change form
115 115 # and routing
116 116 @request.session[:user_id] = 3
117 117 post :create, :project_id => 1,
118 118 :time_entry => {:comments => 'Some work on TimelogControllerTest',
119 119 # Not the default activity
120 120 :activity_id => '11',
121 121 :spent_on => '2008-03-14',
122 122 :issue_id => '1',
123 123 :hours => '7.3'}
124 124 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
125 125
126 126 i = Issue.find(1)
127 127 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
128 128 assert_not_nil t
129 129 assert_equal 11, t.activity_id
130 130 assert_equal 7.3, t.hours
131 131 assert_equal 3, t.user_id
132 132 assert_equal i, t.issue
133 133 assert_equal i.project, t.project
134 134 end
135 135
136 136 def test_post_create_with_blank_issue
137 137 # TODO: should POST to issues’ time log instead of project. change form
138 138 # and routing
139 139 @request.session[:user_id] = 3
140 140 post :create, :project_id => 1,
141 141 :time_entry => {:comments => 'Some work on TimelogControllerTest',
142 142 # Not the default activity
143 143 :activity_id => '11',
144 144 :issue_id => '',
145 145 :spent_on => '2008-03-14',
146 146 :hours => '7.3'}
147 147 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
148 148
149 149 t = TimeEntry.find_by_comments('Some work on TimelogControllerTest')
150 150 assert_not_nil t
151 151 assert_equal 11, t.activity_id
152 152 assert_equal 7.3, t.hours
153 153 assert_equal 3, t.user_id
154 154 end
155 155
156 156 def test_create_and_continue
157 157 @request.session[:user_id] = 2
158 158 post :create, :project_id => 1,
159 159 :time_entry => {:activity_id => '11',
160 160 :issue_id => '',
161 161 :spent_on => '2008-03-14',
162 162 :hours => '7.3'},
163 163 :continue => '1'
164 164 assert_redirected_to '/projects/ecookbook/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D='
165 165 end
166 166
167 167 def test_create_and_continue_with_issue_id
168 168 @request.session[:user_id] = 2
169 169 post :create, :project_id => 1,
170 170 :time_entry => {:activity_id => '11',
171 171 :issue_id => '1',
172 172 :spent_on => '2008-03-14',
173 173 :hours => '7.3'},
174 174 :continue => '1'
175 175 assert_redirected_to '/projects/ecookbook/issues/1/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=1'
176 176 end
177 177
178 178 def test_create_and_continue_without_project
179 179 @request.session[:user_id] = 2
180 180 post :create, :time_entry => {:project_id => '1',
181 181 :activity_id => '11',
182 182 :issue_id => '',
183 183 :spent_on => '2008-03-14',
184 184 :hours => '7.3'},
185 185 :continue => '1'
186 186
187 187 assert_redirected_to '/time_entries/new?time_entry%5Bactivity_id%5D=11&time_entry%5Bissue_id%5D=&time_entry%5Bproject_id%5D=1'
188 188 end
189 189
190 190 def test_create_without_log_time_permission_should_be_denied
191 191 @request.session[:user_id] = 2
192 192 Role.find_by_name('Manager').remove_permission! :log_time
193 193 post :create, :project_id => 1,
194 194 :time_entry => {:activity_id => '11',
195 195 :issue_id => '',
196 196 :spent_on => '2008-03-14',
197 197 :hours => '7.3'}
198 198
199 199 assert_response 403
200 200 end
201 201
202 202 def test_create_with_failure
203 203 @request.session[:user_id] = 2
204 204 post :create, :project_id => 1,
205 205 :time_entry => {:activity_id => '',
206 206 :issue_id => '',
207 207 :spent_on => '2008-03-14',
208 208 :hours => '7.3'}
209 209
210 210 assert_response :success
211 211 assert_template 'new'
212 212 end
213 213
214 214 def test_create_without_project
215 215 @request.session[:user_id] = 2
216 216 assert_difference 'TimeEntry.count' do
217 217 post :create, :time_entry => {:project_id => '1',
218 218 :activity_id => '11',
219 219 :issue_id => '',
220 220 :spent_on => '2008-03-14',
221 221 :hours => '7.3'}
222 222 end
223 223
224 224 assert_redirected_to '/projects/ecookbook/time_entries'
225 225 time_entry = TimeEntry.first(:order => 'id DESC')
226 226 assert_equal 1, time_entry.project_id
227 227 end
228 228
229 229 def test_create_without_project_should_fail_with_issue_not_inside_project
230 230 @request.session[:user_id] = 2
231 231 assert_no_difference 'TimeEntry.count' do
232 232 post :create, :time_entry => {:project_id => '1',
233 233 :activity_id => '11',
234 234 :issue_id => '5',
235 235 :spent_on => '2008-03-14',
236 236 :hours => '7.3'}
237 237 end
238 238
239 239 assert_response :success
240 240 assert assigns(:time_entry).errors[:issue_id].present?
241 241 end
242 242
243 243 def test_create_without_project_should_deny_without_permission
244 244 @request.session[:user_id] = 2
245 245 Project.find(3).disable_module!(:time_tracking)
246 246
247 247 assert_no_difference 'TimeEntry.count' do
248 248 post :create, :time_entry => {:project_id => '3',
249 249 :activity_id => '11',
250 250 :issue_id => '',
251 251 :spent_on => '2008-03-14',
252 252 :hours => '7.3'}
253 253 end
254 254
255 255 assert_response 403
256 256 end
257 257
258 258 def test_create_without_project_with_failure
259 259 @request.session[:user_id] = 2
260 260 assert_no_difference 'TimeEntry.count' do
261 261 post :create, :time_entry => {:project_id => '1',
262 262 :activity_id => '11',
263 263 :issue_id => '',
264 264 :spent_on => '2008-03-14',
265 265 :hours => ''}
266 266 end
267 267
268 268 assert_response :success
269 269 assert_tag 'select', :attributes => {:name => 'time_entry[project_id]'},
270 270 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}}
271 271 end
272 272
273 273 def test_update
274 274 entry = TimeEntry.find(1)
275 275 assert_equal 1, entry.issue_id
276 276 assert_equal 2, entry.user_id
277 277
278 278 @request.session[:user_id] = 1
279 279 put :update, :id => 1,
280 280 :time_entry => {:issue_id => '2',
281 281 :hours => '8'}
282 282 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
283 283 entry.reload
284 284
285 285 assert_equal 8, entry.hours
286 286 assert_equal 2, entry.issue_id
287 287 assert_equal 2, entry.user_id
288 288 end
289 289
290 290 def test_get_bulk_edit
291 291 @request.session[:user_id] = 2
292 292 get :bulk_edit, :ids => [1, 2]
293 293 assert_response :success
294 294 assert_template 'bulk_edit'
295 295
296 # System wide custom field
297 assert_tag :select, :attributes => {:name => 'time_entry[custom_field_values][10]'}
296 assert_select 'ul#bulk-selection' do
297 assert_select 'li', 2
298 assert_select 'li a', :text => '03/23/2007 - eCookbook: 4.25 hours'
299 end
298 300
299 # Activities
300 assert_select 'select[name=?]', 'time_entry[activity_id]' do
301 assert_select 'option[value=]', :text => '(No change)'
302 assert_select 'option[value=9]', :text => 'Design'
301 assert_select 'form#bulk_edit_form[action=?]', '/time_entries/bulk_update' do
302 # System wide custom field
303 assert_select 'select[name=?]', 'time_entry[custom_field_values][10]'
304
305 # Activities
306 assert_select 'select[name=?]', 'time_entry[activity_id]' do
307 assert_select 'option[value=]', :text => '(No change)'
308 assert_select 'option[value=9]', :text => 'Design'
309 end
303 310 end
304 311 end
305 312
306 313 def test_get_bulk_edit_on_different_projects
307 314 @request.session[:user_id] = 2
308 315 get :bulk_edit, :ids => [1, 2, 6]
309 316 assert_response :success
310 317 assert_template 'bulk_edit'
311 318 end
312 319
313 320 def test_bulk_update
314 321 @request.session[:user_id] = 2
315 322 # update time entry activity
316 323 post :bulk_update, :ids => [1, 2], :time_entry => { :activity_id => 9}
317 324
318 325 assert_response 302
319 326 # check that the issues were updated
320 327 assert_equal [9, 9], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.activity_id}
321 328 end
322 329
323 330 def test_bulk_update_with_failure
324 331 @request.session[:user_id] = 2
325 332 post :bulk_update, :ids => [1, 2], :time_entry => { :hours => 'A'}
326 333
327 334 assert_response 302
328 335 assert_match /Failed to save 2 time entrie/, flash[:error]
329 336 end
330 337
331 338 def test_bulk_update_on_different_projects
332 339 @request.session[:user_id] = 2
333 340 # makes user a manager on the other project
334 341 Member.create!(:user_id => 2, :project_id => 3, :role_ids => [1])
335 342
336 343 # update time entry activity
337 344 post :bulk_update, :ids => [1, 2, 4], :time_entry => { :activity_id => 9 }
338 345
339 346 assert_response 302
340 347 # check that the issues were updated
341 348 assert_equal [9, 9, 9], TimeEntry.find_all_by_id([1, 2, 4]).collect {|i| i.activity_id}
342 349 end
343 350
344 351 def test_bulk_update_on_different_projects_without_rights
345 352 @request.session[:user_id] = 3
346 353 user = User.find(3)
347 354 action = { :controller => "timelog", :action => "bulk_update" }
348 355 assert user.allowed_to?(action, TimeEntry.find(1).project)
349 356 assert ! user.allowed_to?(action, TimeEntry.find(5).project)
350 357 post :bulk_update, :ids => [1, 5], :time_entry => { :activity_id => 9 }
351 358 assert_response 403
352 359 end
353 360
354 361 def test_bulk_update_custom_field
355 362 @request.session[:user_id] = 2
356 363 post :bulk_update, :ids => [1, 2], :time_entry => { :custom_field_values => {'10' => '0'} }
357 364
358 365 assert_response 302
359 366 assert_equal ["0", "0"], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.custom_value_for(10).value}
360 367 end
361 368
362 369 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
363 370 @request.session[:user_id] = 2
364 371 post :bulk_update, :ids => [1,2], :back_url => '/time_entries'
365 372
366 373 assert_response :redirect
367 374 assert_redirected_to '/time_entries'
368 375 end
369 376
370 377 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
371 378 @request.session[:user_id] = 2
372 379 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
373 380
374 381 assert_response :redirect
375 382 assert_redirected_to :controller => 'timelog', :action => 'index', :project_id => Project.find(1).identifier
376 383 end
377 384
378 385 def test_post_bulk_update_without_edit_permission_should_be_denied
379 386 @request.session[:user_id] = 2
380 387 Role.find_by_name('Manager').remove_permission! :edit_time_entries
381 388 post :bulk_update, :ids => [1,2]
382 389
383 390 assert_response 403
384 391 end
385 392
386 393 def test_destroy
387 394 @request.session[:user_id] = 2
388 395 delete :destroy, :id => 1
389 396 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
390 397 assert_equal I18n.t(:notice_successful_delete), flash[:notice]
391 398 assert_nil TimeEntry.find_by_id(1)
392 399 end
393 400
394 401 def test_destroy_should_fail
395 402 # simulate that this fails (e.g. due to a plugin), see #5700
396 403 TimeEntry.any_instance.expects(:destroy).returns(false)
397 404
398 405 @request.session[:user_id] = 2
399 406 delete :destroy, :id => 1
400 407 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
401 408 assert_equal I18n.t(:notice_unable_delete_time_entry), flash[:error]
402 409 assert_not_nil TimeEntry.find_by_id(1)
403 410 end
404 411
405 412 def test_index_all_projects
406 413 get :index
407 414 assert_response :success
408 415 assert_template 'index'
409 416 assert_not_nil assigns(:total_hours)
410 417 assert_equal "162.90", "%.2f" % assigns(:total_hours)
411 418 assert_tag :form,
412 419 :attributes => {:action => "/time_entries", :id => 'query_form'}
413 420 end
414 421
415 422 def test_index_all_projects_should_show_log_time_link
416 423 @request.session[:user_id] = 2
417 424 get :index
418 425 assert_response :success
419 426 assert_template 'index'
420 427 assert_tag 'a', :attributes => {:href => '/time_entries/new'}, :content => /Log time/
421 428 end
422 429
423 430 def test_index_at_project_level
424 431 get :index, :project_id => 'ecookbook'
425 432 assert_response :success
426 433 assert_template 'index'
427 434 assert_not_nil assigns(:entries)
428 435 assert_equal 4, assigns(:entries).size
429 436 # project and subproject
430 437 assert_equal [1, 3], assigns(:entries).collect(&:project_id).uniq.sort
431 438 assert_not_nil assigns(:total_hours)
432 439 assert_equal "162.90", "%.2f" % assigns(:total_hours)
433 440 assert_tag :form,
434 441 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
435 442 end
436 443
437 444 def test_index_at_project_level_with_date_range
438 445 get :index, :project_id => 'ecookbook',
439 446 :f => ['spent_on'],
440 447 :op => {'spent_on' => '><'},
441 448 :v => {'spent_on' => ['2007-03-20', '2007-04-30']}
442 449 assert_response :success
443 450 assert_template 'index'
444 451 assert_not_nil assigns(:entries)
445 452 assert_equal 3, assigns(:entries).size
446 453 assert_not_nil assigns(:total_hours)
447 454 assert_equal "12.90", "%.2f" % assigns(:total_hours)
448 455 assert_tag :form,
449 456 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
450 457 end
451 458
452 459 def test_index_at_project_level_with_date_range_using_from_and_to_params
453 460 get :index, :project_id => 'ecookbook', :from => '2007-03-20', :to => '2007-04-30'
454 461 assert_response :success
455 462 assert_template 'index'
456 463 assert_not_nil assigns(:entries)
457 464 assert_equal 3, assigns(:entries).size
458 465 assert_not_nil assigns(:total_hours)
459 466 assert_equal "12.90", "%.2f" % assigns(:total_hours)
460 467 assert_tag :form,
461 468 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
462 469 end
463 470
464 471 def test_index_at_project_level_with_period
465 472 get :index, :project_id => 'ecookbook',
466 473 :f => ['spent_on'],
467 474 :op => {'spent_on' => '>t-'},
468 475 :v => {'spent_on' => ['7']}
469 476 assert_response :success
470 477 assert_template 'index'
471 478 assert_not_nil assigns(:entries)
472 479 assert_not_nil assigns(:total_hours)
473 480 assert_tag :form,
474 481 :attributes => {:action => "/projects/ecookbook/time_entries", :id => 'query_form'}
475 482 end
476 483
477 484 def test_index_at_issue_level
478 485 get :index, :issue_id => 1
479 486 assert_response :success
480 487 assert_template 'index'
481 488 assert_not_nil assigns(:entries)
482 489 assert_equal 2, assigns(:entries).size
483 490 assert_not_nil assigns(:total_hours)
484 491 assert_equal 154.25, assigns(:total_hours)
485 492 # display all time
486 493 assert_nil assigns(:from)
487 494 assert_nil assigns(:to)
488 495 # TODO: remove /projects/:project_id/issues/:issue_id/time_entries routes
489 496 # to use /issues/:issue_id/time_entries
490 497 assert_tag :form,
491 498 :attributes => {:action => "/projects/ecookbook/issues/1/time_entries", :id => 'query_form'}
492 499 end
493 500
494 501 def test_index_should_sort_by_spent_on_and_created_on
495 502 t1 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:00:00', :activity_id => 10)
496 503 t2 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-16', :created_on => '2012-06-16 20:05:00', :activity_id => 10)
497 504 t3 = TimeEntry.create!(:user => User.find(1), :project => Project.find(1), :hours => 1, :spent_on => '2012-06-15', :created_on => '2012-06-16 20:10:00', :activity_id => 10)
498 505
499 506 get :index, :project_id => 1,
500 507 :f => ['spent_on'],
501 508 :op => {'spent_on' => '><'},
502 509 :v => {'spent_on' => ['2012-06-15', '2012-06-16']}
503 510 assert_response :success
504 511 assert_equal [t2, t1, t3], assigns(:entries)
505 512
506 513 get :index, :project_id => 1,
507 514 :f => ['spent_on'],
508 515 :op => {'spent_on' => '><'},
509 516 :v => {'spent_on' => ['2012-06-15', '2012-06-16']},
510 517 :sort => 'spent_on'
511 518 assert_response :success
512 519 assert_equal [t3, t1, t2], assigns(:entries)
513 520 end
514 521
515 522 def test_index_atom_feed
516 523 get :index, :project_id => 1, :format => 'atom'
517 524 assert_response :success
518 525 assert_equal 'application/atom+xml', @response.content_type
519 526 assert_not_nil assigns(:items)
520 527 assert assigns(:items).first.is_a?(TimeEntry)
521 528 end
522 529
523 530 def test_index_all_projects_csv_export
524 531 Setting.date_format = '%m/%d/%Y'
525 532 get :index, :format => 'csv'
526 533 assert_response :success
527 534 assert_equal 'text/csv; header=present', @response.content_type
528 535 assert @response.body.include?("Date,User,Activity,Project,Issue,Tracker,Subject,Hours,Comment,Overtime\n")
529 536 assert @response.body.include?("\n04/21/2007,redMine Admin,Design,eCookbook,3,Bug,Error 281 when updating a recipe,1.0,\"\",\"\"\n")
530 537 end
531 538
532 539 def test_index_csv_export
533 540 Setting.date_format = '%m/%d/%Y'
534 541 get :index, :project_id => 1, :format => 'csv'
535 542 assert_response :success
536 543 assert_equal 'text/csv; header=present', @response.content_type
537 544 assert @response.body.include?("Date,User,Activity,Project,Issue,Tracker,Subject,Hours,Comment,Overtime\n")
538 545 assert @response.body.include?("\n04/21/2007,redMine Admin,Design,eCookbook,3,Bug,Error 281 when updating a recipe,1.0,\"\",\"\"\n")
539 546 end
540 547
541 548 def test_index_csv_export_with_multi_custom_field
542 549 field = TimeEntryCustomField.create!(:name => 'Test', :field_format => 'list',
543 550 :multiple => true, :possible_values => ['value1', 'value2'])
544 551 entry = TimeEntry.find(1)
545 552 entry.custom_field_values = {field.id => ['value1', 'value2']}
546 553 entry.save!
547 554
548 555 get :index, :project_id => 1, :format => 'csv'
549 556 assert_response :success
550 557 assert_include '"value1, value2"', @response.body
551 558 end
552 559
553 560 def test_csv_big_5
554 561 user = User.find_by_id(3)
555 562 user.language = "zh-TW"
556 563 assert user.save
557 564 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
558 565 str_big5 = "\xa4@\xa4\xeb"
559 566 if str_utf8.respond_to?(:force_encoding)
560 567 str_utf8.force_encoding('UTF-8')
561 568 str_big5.force_encoding('Big5')
562 569 end
563 570 @request.session[:user_id] = 3
564 571 post :create, :project_id => 1,
565 572 :time_entry => {:comments => str_utf8,
566 573 # Not the default activity
567 574 :activity_id => '11',
568 575 :issue_id => '',
569 576 :spent_on => '2011-11-10',
570 577 :hours => '7.3'}
571 578 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
572 579
573 580 t = TimeEntry.find_by_comments(str_utf8)
574 581 assert_not_nil t
575 582 assert_equal 11, t.activity_id
576 583 assert_equal 7.3, t.hours
577 584 assert_equal 3, t.user_id
578 585
579 586 get :index, :project_id => 1, :format => 'csv',
580 587 :from => '2011-11-10', :to => '2011-11-10'
581 588 assert_response :success
582 589 assert_equal 'text/csv; header=present', @response.content_type
583 590 ar = @response.body.chomp.split("\n")
584 591 s1 = "\xa4\xe9\xb4\xc1"
585 592 if str_utf8.respond_to?(:force_encoding)
586 593 s1.force_encoding('Big5')
587 594 end
588 595 assert ar[0].include?(s1)
589 596 assert ar[1].include?(str_big5)
590 597 end
591 598
592 599 def test_csv_cannot_convert_should_be_replaced_big_5
593 600 user = User.find_by_id(3)
594 601 user.language = "zh-TW"
595 602 assert user.save
596 603 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
597 604 if str_utf8.respond_to?(:force_encoding)
598 605 str_utf8.force_encoding('UTF-8')
599 606 end
600 607 @request.session[:user_id] = 3
601 608 post :create, :project_id => 1,
602 609 :time_entry => {:comments => str_utf8,
603 610 # Not the default activity
604 611 :activity_id => '11',
605 612 :issue_id => '',
606 613 :spent_on => '2011-11-10',
607 614 :hours => '7.3'}
608 615 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
609 616
610 617 t = TimeEntry.find_by_comments(str_utf8)
611 618 assert_not_nil t
612 619 assert_equal 11, t.activity_id
613 620 assert_equal 7.3, t.hours
614 621 assert_equal 3, t.user_id
615 622
616 623 get :index, :project_id => 1, :format => 'csv',
617 624 :from => '2011-11-10', :to => '2011-11-10'
618 625 assert_response :success
619 626 assert_equal 'text/csv; header=present', @response.content_type
620 627 ar = @response.body.chomp.split("\n")
621 628 s1 = "\xa4\xe9\xb4\xc1"
622 629 if str_utf8.respond_to?(:force_encoding)
623 630 s1.force_encoding('Big5')
624 631 end
625 632 assert ar[0].include?(s1)
626 633 s2 = ar[1].split(",")[8]
627 634 if s2.respond_to?(:force_encoding)
628 635 s3 = "\xa5H?"
629 636 s3.force_encoding('Big5')
630 637 assert_equal s3, s2
631 638 elsif RUBY_PLATFORM == 'java'
632 639 assert_equal "??", s2
633 640 else
634 641 assert_equal "\xa5H???", s2
635 642 end
636 643 end
637 644
638 645 def test_csv_tw
639 646 with_settings :default_language => "zh-TW" do
640 647 str1 = "test_csv_tw"
641 648 user = User.find_by_id(3)
642 649 te1 = TimeEntry.create(:spent_on => '2011-11-10',
643 650 :hours => 999.9,
644 651 :project => Project.find(1),
645 652 :user => user,
646 653 :activity => TimeEntryActivity.find_by_name('Design'),
647 654 :comments => str1)
648 655 te2 = TimeEntry.find_by_comments(str1)
649 656 assert_not_nil te2
650 657 assert_equal 999.9, te2.hours
651 658 assert_equal 3, te2.user_id
652 659
653 660 get :index, :project_id => 1, :format => 'csv',
654 661 :from => '2011-11-10', :to => '2011-11-10'
655 662 assert_response :success
656 663 assert_equal 'text/csv; header=present', @response.content_type
657 664
658 665 ar = @response.body.chomp.split("\n")
659 666 s2 = ar[1].split(",")[7]
660 667 assert_equal '999.9', s2
661 668
662 669 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
663 670 if str_tw.respond_to?(:force_encoding)
664 671 str_tw.force_encoding('UTF-8')
665 672 end
666 673 assert_equal str_tw, l(:general_lang_name)
667 674 assert_equal ',', l(:general_csv_separator)
668 675 assert_equal '.', l(:general_csv_decimal_separator)
669 676 end
670 677 end
671 678
672 679 def test_csv_fr
673 680 with_settings :default_language => "fr" do
674 681 str1 = "test_csv_fr"
675 682 user = User.find_by_id(3)
676 683 te1 = TimeEntry.create(:spent_on => '2011-11-10',
677 684 :hours => 999.9,
678 685 :project => Project.find(1),
679 686 :user => user,
680 687 :activity => TimeEntryActivity.find_by_name('Design'),
681 688 :comments => str1)
682 689 te2 = TimeEntry.find_by_comments(str1)
683 690 assert_not_nil te2
684 691 assert_equal 999.9, te2.hours
685 692 assert_equal 3, te2.user_id
686 693
687 694 get :index, :project_id => 1, :format => 'csv',
688 695 :from => '2011-11-10', :to => '2011-11-10'
689 696 assert_response :success
690 697 assert_equal 'text/csv; header=present', @response.content_type
691 698
692 699 ar = @response.body.chomp.split("\n")
693 700 s2 = ar[1].split(";")[7]
694 701 assert_equal '999,9', s2
695 702
696 703 str_fr = "Fran\xc3\xa7ais"
697 704 if str_fr.respond_to?(:force_encoding)
698 705 str_fr.force_encoding('UTF-8')
699 706 end
700 707 assert_equal str_fr, l(:general_lang_name)
701 708 assert_equal ';', l(:general_csv_separator)
702 709 assert_equal ',', l(:general_csv_decimal_separator)
703 710 end
704 711 end
705 712 end
General Comments 0
You need to be logged in to leave comments. Login now