jro_apps/redmine Commit - r14236:aa096cb0cc96

Project copy does not copy custom field settings (#20360)....

Jean-Philippe Lang -

r14236:aa096cb0cc96

parent child

Context file:

r14236:aa096cb0cc96

app/models/project.rb +6 0

               # Returns a scope of all custom fields enabled for project issues
               # (explicitly associated custom fields and custom fields enabled for all projects)
               def all_issue_custom_fields
+                if new_record?
+                  @all_issue_custom_fields ||= IssueCustomField.
+                    sorted.
+                    where("is_for_all = ? OR id IN (?)", true, issue_custom_field_ids)
+                else
                   @all_issue_custom_fields ||= IssueCustomField.
                     sorted.
                     where("is_for_all = ? OR id IN (SELECT DISTINCT cfp.custom_field_id" +
                       " FROM #{table_name_prefix}custom_fields_projects#{table_name_suffix} cfp" +
                       " WHERE cfp.project_id = ?)", true, id)
                 end
+              end
               def project
                 self

test/functional/projects_controller_test.rb +14 0

@@ -608,6 +608,20 class ProjectsControllerTest < ActionController::TestCase
608	assert_response 404	608	assert_response 404
609	end	609	end
610		610
		611	def test_get_copy_should_preselect_custom_fields
		612	field1 = IssueCustomField.generate!(:is_for_all => false)
		613	field2 = IssueCustomField.generate!(:is_for_all => false)
		614	source = Project.generate!(:issue_custom_fields => [field1])
		615	@request.session[:user_id] = 1
		616
		617	get :copy, :id => source.id
		618	assert_response :success
		619	assert_select 'fieldset#project_issue_custom_fields' do
		620	assert_select 'input[type=checkbox][value=?][checked=checked]', field1.id.to_s
		621	assert_select 'input[type=checkbox][value=?]:not([checked])', field2.id.to_s
		622	end
		623	end
		624
611	def test_post_copy_should_copy_requested_items	625	def test_post_copy_should_copy_requested_items
612	@request.session[:user_id] = 1 # admin	626	@request.session[:user_id] = 1 # admin
613	CustomField.delete_all	627	CustomField.delete_all

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages