jro_apps/redmine Commit - r15781:aa030bf39ac6

Adds a tooltip to cells on workflow page (#12598)....

Jean-Philippe Lang -

r15781:aa030bf39ac6

parent child

Context file:

r15781:aa030bf39ac6

Collapse all files

app/views/workflows/_form.html.erb +8 -3

             <table class="list workflows transitions transitions-<%= name %>">
             <thead>
               <tr>
                 <th>
                   <%= link_to_function('', "toggleCheckboxesBySelector('table.transitions-#{name} input')",
                                        :title => "#{l(:button_check_all)}/#{l(:button_uncheck_all)}",
                                        :class => 'icon-only icon-checked') %>
                   <%=l(:label_current_status)%>
                 </th>
                 <th colspan="<%= @statuses.length %>"><%=l(:label_new_statuses_allowed)%></th>
               </tr>
               <tr>
                 <td></td>
                 <% for new_status in @statuses %>
                 <td style="width:<%= 75 / @statuses.size %>%;">
                   <%= link_to_function('', "toggleCheckboxesBySelector('table.transitions-#{name} input.new-status-#{new_status.id}')",
                                        :title => "#{l(:button_check_all)}/#{l(:button_uncheck_all)}",
                                        :class => 'icon-only icon-checked') %>
                   <%= new_status.name %>
                 </td>
                 <% end %>
               </tr>
             </thead>
             <tbody>
               <% for old_status in [nil] + @statuses %>
               <% next if old_status.nil? && name != 'always' %>
               <tr class="<%= cycle("odd", "even") %>">
                 <td class="name">
                   <%= link_to_function('', "toggleCheckboxesBySelector('table.transitions-#{name} input.old-status-#{old_status.try(:id) || 0}')",
                                        :title => "#{l(:button_check_all)}/#{l(:button_uncheck_all)}",
                                        :class => 'icon-only icon-checked') %>
+                  <% if old_status %>
-                  <%= old_status ? old_status.name : content_tag('em', l(:label_issue_new)) %>
+                    <% old_status_name = old_status.name %>
+                    <%= old_status_name %>
+                  <% else %>
+                    <% old_status_name = l(:label_issue_new) %>
+                    <%= content_tag('em', old_status_name) %>
+                  <% end %>
                 </td>
                 <% for new_status in @statuses -%>
                 <% checked = workflows.detect {|w| w.old_status == old_status && w.new_status == new_status} %>
-                <td class="<%= checked ? 'enabled' : '' %>">
+                <td class="<%= checked ? 'enabled' : '' %>" title="<%= old_status_name %> &#187; <%= new_status.name %>">
                   <%= transition_tag workflows, old_status, new_status, name %>
                 </td>
                 <% end -%>
               </tr>
               <% end %>
             </tbody>
             </table>

app/views/workflows/permissions.html.erb +2 -2

             <%= render :partial => 'action_menu' %>
             <%= title l(:label_workflow) %>
             <div class="tabs">
               <ul>
                 <li><%= link_to l(:label_status_transitions), workflows_edit_path(:role_id => @roles, :tracker_id => @trackers) %></li>
                 <li><%= link_to l(:label_fields_permissions), workflows_permissions_path(:role_id => @roles, :tracker_id => @trackers), :class => 'selected' %></li>
               </ul>
             </div>
             <p><%=l(:text_workflow_edit)%>:</p>
             <%= form_tag({}, :method => 'get') do %>
             <p>
               <label><%=l(:label_role)%>:
               <%= options_for_workflow_select 'role_id[]', Role.sorted.select(&:consider_workflow?), @roles, :id => 'role_id', :class => 'expandable' %>
               </label>
               <a href="#" data-expands="#role_id"><span class="toggle-multiselect"></a>
               <label><%=l(:label_tracker)%>:
               <%= options_for_workflow_select 'tracker_id[]', Tracker.sorted, @trackers, :id => 'tracker_id', :class => 'expandable' %>
               </label>
               <a href="#" data-expands="#tracker_id"><span class="toggle-multiselect"></a>
               <%= submit_tag l(:button_edit), :name => nil %>
               <%= hidden_field_tag 'used_statuses_only', '0', :id => nil %>
               <label><%= check_box_tag 'used_statuses_only', '1', @used_statuses_only %> <%= l(:label_display_used_statuses_only) %></label>
             </p>
             <% end %>
             <% if @trackers && @roles && @statuses.any? %>
               <%= form_tag({}, :id => 'workflow_form' ) do %>
                 <%= @trackers.map {|tracker| hidden_field_tag 'tracker_id[]', tracker.id, :id => nil}.join.html_safe %>
                 <%= @roles.map {|role| hidden_field_tag 'role_id[]', role.id, :id => nil}.join.html_safe %>
                 <%= hidden_field_tag 'used_statuses_only', params[:used_statuses_only], :id => nil %>
                 <div class="autoscroll">
                 <table class="list workflows fields_permissions">
                 <thead>
                   <tr>
                     <th>
                     </th>
                     <th colspan="<%= @statuses.length %>"><%=l(:label_issue_status)%></th>
                   </tr>
                   <tr>
                     <td></td>
                     <% for status in @statuses %>
                     <td style="width:<%= 75 / @statuses.size %>%;">
                       <%= status.name %>
                     </td>
                     <% end %>
                   </tr>
                 </thead>
                 <tbody>
                   <tr class="group open">
                     <td colspan="<%= @statuses.size + 1 %>">
                       <span class="expander" onclick="toggleRowGroup(this);">&nbsp;</span>
                       <%= l(:field_core_fields) %>
                     </td>
                   </tr>
                   <% @fields.each do |field, name| %>
                   <tr class="<%= cycle("odd", "even") %>">
                     <td class="name">
                       <%= name %> <%= content_tag('span', '*', :class => 'required') if field_required?(field) %>
                     </td>
                     <% for status in @statuses -%>
-                    <td class="<%= @permissions[status.id][field].try(:join, ' ') %>">
+                    <td class="<%= @permissions[status.id][field].try(:join, ' ') %>" title="<%= name %> (<%= status.name %>)">
                       <%= field_permission_tag(@permissions, status, field, @roles) %>
                       <% unless status == @statuses.last %><a href="#" class="repeat-value">&#187;</a><% end %>
                     </td>
                     <% end -%>
                   </tr>
                   <% end %>
                   <% if @custom_fields.any? %>
                     <tr class="group open">
                       <td colspan="<%= @statuses.size + 1 %>">
                         <span class="expander" onclick="toggleRowGroup(this);">&nbsp;</span>
                         <%= l(:label_custom_field_plural) %>
                       </td>
                     </tr>
                     <% @custom_fields.each do |field| %>
                     <tr class="<%= cycle("odd", "even") %>">
                       <td class="name">
                         <%= field.name %> <%= content_tag('span', '*', :class => 'required') if field_required?(field) %>
                       </td>
                       <% for status in @statuses -%>
-                      <td class="<%= @permissions[status.id][field.id.to_s].try(:join, ' ') %>">
+                      <td class="<%= @permissions[status.id][field.id.to_s].try(:join, ' ') %>" title="<%= field.name %> (<%= status.name %>)">
                         <%= field_permission_tag(@permissions, status, field, @roles) %>
                         <% unless status == @statuses.last %><a href="#" class="repeat-value">&#187;</a><% end %>
                       </td>
                       <% end -%>
                     </tr>
                     <% end %>
                   <% end %>
                 </tbody>
                 </table>
                 </div>
                 <%= submit_tag l(:button_save) %>
               <% end %>
             <% end %>
             <%= javascript_tag do %>
             $("a.repeat-value").click(function(e){
               e.preventDefault();
               var td = $(this).closest('td');
               var selected = td.find("select").find(":selected").val();
               td.nextAll('td').find("select").val(selected);
             });
             $("a[data-expands]").click(function(e){
               e.preventDefault();
               var target = $($(this).attr("data-expands"));
               if (target.attr("multiple")) {
                 target.attr("multiple", false);
                 target.find("option[value=all]").show();
               } else {
                 target.attr("multiple", true);
                 target.find("option[value=all]").attr("selected", false).hide();
               }
             });
             <% end %>

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages