jro_apps/redmine Commit - r2696:a7bb63a18280

Fixed: case sensitivity in issue subject filtering (#3536)....

Jean-Philippe Lang -

r2696:a7bb63a18280

parent child

Context file:

r2696:a7bb63a18280

app/models/query.rb +2 -2

                     Time.now.at_beginning_of_week
                   sql = "#{db_table}.#{db_field} BETWEEN '%s' AND '%s'" % [connection.quoted_date(from), connection.quoted_date(from + 7.days)]
                 when "~"
-                  sql = "#{db_table}.#{db_field} LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 when "!~"
-                  sql = "#{db_table}.#{db_field} NOT LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) NOT LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 end
                 return sql

test/unit/query_test.rb +7 -5

               def test_operator_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '~', ['string'])
+                query.add_filter('subject', '~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) LIKE '%unable%'")
-                find_issues_with_query(query)
+                result = find_issues_with_query(query)
+                assert result.empty?
+                result.each {|issue| assert issue.subject.downcase.include?('unable') }
               end
               def test_operator_does_not_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '!~', ['string'])
+                query.add_filter('subject', '!~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject NOT LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) NOT LIKE '%unable%'")
                 find_issues_with_query(query)
               end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages