jro_apps/redmine Commit - r10703:a7023dfa9b8e

Replaces find(:first) calls....

Jean-Philippe Lang -

r10703:a7023dfa9b8e

parent child

Context file:

r10703:a7023dfa9b8e

lib/plugins/acts_as_list/lib/active_record/acts/list.rb +4 -4

                     # Return the next higher item in the list.
                     def higher_item
                       return nil unless in_list?
-                      acts_as_list_class.find(:first, :conditions =>
+                      acts_as_list_class.where(
                         "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i - 1).to_s}"
+                      ).first
                     end
                     # Return the next lower item in the list.
                     def lower_item
                       return nil unless in_list?
-                      acts_as_list_class.find(:first, :conditions =>
+                      acts_as_list_class.where(
                         "#{scope_condition} AND #{position_column} = #{(send(position_column).to_i + 1).to_s}"
+                      ).first
                     end
                     # Test if this record is in a list

lib/plugins/acts_as_versioned/lib/acts_as_versioned.rb +2 -2

                         has_many :versions, version_association_options do
                           # finds earliest version of this record
                           def earliest
-                            @earliest ||= find(:first, :order => 'version')
+                            @earliest ||= order('version').first
                           end
                           # find latest version of this record
                           def latest
-                            @latest ||= find(:first, :order => 'version desc')
+                            @latest ||= order('version desc').first
                           end
                         end
                         before_save  :set_new_version

lib/plugins/awesome_nested_set/lib/awesome_nested_set/awesome_nested_set.rb +6 -6

                     # on creation, set automatically lft and rgt to the end of the tree
                     def set_default_left_and_right
-                      highest_right_row = nested_set_scope(:order => "#{quoted_right_column_name} desc").find(:first, :limit => 1,:lock => true )
+                      highest_right_row = nested_set_scope(:order => "#{quoted_right_column_name} desc").limit(1).lock(true).first
                       maxright = highest_right_row ? (highest_right_row[right_column_name] || 0) : 0
                       # adds the new node to the right of all existing nodes
                       self[left_column_name] = maxright + 1
                       in_tenacious_transaction do
                         reload_nested_set
                         # select the rows in the model that extend past the deletion point and apply a lock
-                        self.class.base_class.find(:all,
+                        self.class.base_class.
-                          :select => "id",
+                          select("id").
-                          :conditions => ["#{quoted_left_column_name} >= ?", left],
+                          where("#{quoted_left_column_name} >= ?", left).
-                          :lock => true
+                          lock(true).
+                          all
                         if acts_as_nested_set_options[:dependent] == :destroy
                           descendants.each do |model|

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages