jro_apps/redmine Commit - r14364:a3efaceb8fd9

Redirect to custom field after create or update....

Jean-Philippe Lang -

r14364:a3efaceb8fd9

parent child

Context file:

r14364:a3efaceb8fd9

app/controllers/custom_fields_controller.rb +2 -2

                 if @custom_field.save
                   flash[:notice] = l(:notice_successful_create)
                   call_hook(:controller_custom_fields_new_after_save, :params => params, :custom_field => @custom_field)
-                  redirect_to custom_fields_path(:tab => @custom_field.class.name)
+                  redirect_to edit_custom_field_path(@custom_field)
                 else
                   render :action => 'new'
                 end
                 if @custom_field.update_attributes(params[:custom_field])
                   flash[:notice] = l(:notice_successful_update)
                   call_hook(:controller_custom_fields_edit_after_save, :params => params, :custom_field => @custom_field)
-                  redirect_to custom_fields_path(:tab => @custom_field.class.name)
+                  redirect_to edit_custom_field_path(@custom_field)
                 else
                   render :action => 'edit'
                 end

test/functional/custom_fields_controller_test.rb +4 -5

               end
               def test_create_list_custom_field
-                assert_difference 'CustomField.count' do
+                field = new_record(IssueCustomField) do
                   post :create, :type => "IssueCustomField",
                              :custom_field => {:name => "test_post_new_list",
                                                :default_value => "",
                                                :field_format => "list",
                                                :tracker_ids => ["1", ""]}
                 end
-                assert_redirected_to '/custom_fields?tab=IssueCustomField'
+                assert_redirected_to "/custom_fields/#{field.id}/edit"
-                field = IssueCustomField.find_by_name('test_post_new_list')
+                assert_equal "test_post_new_list", field.name
-                assert_not_nil field
                 assert_equal ["0.1", "0.2"], field.possible_values
                 assert_equal 1, field.trackers.size
               end
               def test_update
                 put :update, :id => 1, :custom_field => {:name => 'New name'}
-                assert_redirected_to '/custom_fields?tab=IssueCustomField'
+                assert_redirected_to '/custom_fields/1/edit'
                 field = CustomField.find(1)
                 assert_equal 'New name', field.name

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages