##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_should_close_duplicates at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7361:a281752e4f20
parent child
Show More
Side by Side Unified
Context file:
r7361:a281752e4f20 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1106 +1,1108
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
33 33 :status_id => 1, :priority => IssuePriority.all.first,
34 34 :subject => 'test_create',
35 35 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 36 assert issue.save
37 37 issue.reload
38 38 assert_equal 1.5, issue.estimated_hours
39 39 end
40 40
41 41 def test_create_minimal
42 42 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
43 43 :status_id => 1, :priority => IssuePriority.all.first,
44 44 :subject => 'test_create')
45 45 assert issue.save
46 46 assert issue.description.nil?
47 47 end
48 48
49 49 def test_create_with_required_custom_field
50 50 field = IssueCustomField.find_by_name('Database')
51 51 field.update_attribute(:is_required, true)
52 52
53 53 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
54 54 :status_id => 1, :subject => 'test_create',
55 55 :description => 'IssueTest#test_create_with_required_custom_field')
56 56 assert issue.available_custom_fields.include?(field)
57 57 # No value for the custom field
58 58 assert !issue.save
59 59 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 60 # Blank value
61 61 issue.custom_field_values = { field.id => '' }
62 62 assert !issue.save
63 63 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 64 # Invalid value
65 65 issue.custom_field_values = { field.id => 'SQLServer' }
66 66 assert !issue.save
67 67 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 68 # Valid value
69 69 issue.custom_field_values = { field.id => 'PostgreSQL' }
70 70 assert issue.save
71 71 issue.reload
72 72 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
73 73 end
74 74
75 75 def test_create_with_group_assignment
76 76 with_settings :issue_group_assignment => '1' do
77 77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
78 78 :subject => 'Group assignment',
79 79 :assigned_to_id => 11).save
80 80 issue = Issue.first(:order => 'id DESC')
81 81 assert_kind_of Group, issue.assigned_to
82 82 assert_equal Group.find(11), issue.assigned_to
83 83 end
84 84 end
85 85
86 86 def assert_visibility_match(user, issues)
87 87 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous
91 91 # Anonymous user should see issues of public projects only
92 92 issues = Issue.visible(User.anonymous).all
93 93 assert issues.any?
94 94 assert_nil issues.detect {|issue| !issue.project.is_public?}
95 95 assert_nil issues.detect {|issue| issue.is_private?}
96 96 assert_visibility_match User.anonymous, issues
97 97 end
98 98
99 99 def test_visible_scope_for_anonymous_with_own_issues_visibility
100 100 Role.anonymous.update_attribute :issues_visibility, 'own'
101 101 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
102 102
103 103 issues = Issue.visible(User.anonymous).all
104 104 assert issues.any?
105 105 assert_nil issues.detect {|issue| issue.author != User.anonymous}
106 106 assert_visibility_match User.anonymous, issues
107 107 end
108 108
109 109 def test_visible_scope_for_anonymous_without_view_issues_permissions
110 110 # Anonymous user should not see issues without permission
111 111 Role.anonymous.remove_permission!(:view_issues)
112 112 issues = Issue.visible(User.anonymous).all
113 113 assert issues.empty?
114 114 assert_visibility_match User.anonymous, issues
115 115 end
116 116
117 117 def test_visible_scope_for_non_member
118 118 user = User.find(9)
119 119 assert user.projects.empty?
120 120 # Non member user should see issues of public projects only
121 121 issues = Issue.visible(user).all
122 122 assert issues.any?
123 123 assert_nil issues.detect {|issue| !issue.project.is_public?}
124 124 assert_nil issues.detect {|issue| issue.is_private?}
125 125 assert_visibility_match user, issues
126 126 end
127 127
128 128 def test_visible_scope_for_non_member_with_own_issues_visibility
129 129 Role.non_member.update_attribute :issues_visibility, 'own'
130 130 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
131 131 user = User.find(9)
132 132
133 133 issues = Issue.visible(user).all
134 134 assert issues.any?
135 135 assert_nil issues.detect {|issue| issue.author != user}
136 136 assert_visibility_match user, issues
137 137 end
138 138
139 139 def test_visible_scope_for_non_member_without_view_issues_permissions
140 140 # Non member user should not see issues without permission
141 141 Role.non_member.remove_permission!(:view_issues)
142 142 user = User.find(9)
143 143 assert user.projects.empty?
144 144 issues = Issue.visible(user).all
145 145 assert issues.empty?
146 146 assert_visibility_match user, issues
147 147 end
148 148
149 149 def test_visible_scope_for_member
150 150 user = User.find(9)
151 151 # User should see issues of projects for which he has view_issues permissions only
152 152 Role.non_member.remove_permission!(:view_issues)
153 153 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
154 154 issues = Issue.visible(user).all
155 155 assert issues.any?
156 156 assert_nil issues.detect {|issue| issue.project_id != 3}
157 157 assert_nil issues.detect {|issue| issue.is_private?}
158 158 assert_visibility_match user, issues
159 159 end
160 160
161 161 def test_visible_scope_for_admin
162 162 user = User.find(1)
163 163 user.members.each(&:destroy)
164 164 assert user.projects.empty?
165 165 issues = Issue.visible(user).all
166 166 assert issues.any?
167 167 # Admin should see issues on private projects that he does not belong to
168 168 assert issues.detect {|issue| !issue.project.is_public?}
169 169 # Admin should see private issues of other users
170 170 assert issues.detect {|issue| issue.is_private? && issue.author != user}
171 171 assert_visibility_match user, issues
172 172 end
173 173
174 174 def test_visible_scope_with_project
175 175 project = Project.find(1)
176 176 issues = Issue.visible(User.find(2), :project => project).all
177 177 projects = issues.collect(&:project).uniq
178 178 assert_equal 1, projects.size
179 179 assert_equal project, projects.first
180 180 end
181 181
182 182 def test_visible_scope_with_project_and_subprojects
183 183 project = Project.find(1)
184 184 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
185 185 projects = issues.collect(&:project).uniq
186 186 assert projects.size > 1
187 187 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
188 188 end
189 189
190 190 def test_visible_and_nested_set_scopes
191 191 assert_equal 0, Issue.find(1).descendants.visible.all.size
192 192 end
193 193
194 194 def test_errors_full_messages_should_include_custom_fields_errors
195 195 field = IssueCustomField.find_by_name('Database')
196 196
197 197 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
198 198 :status_id => 1, :subject => 'test_create',
199 199 :description => 'IssueTest#test_create_with_required_custom_field')
200 200 assert issue.available_custom_fields.include?(field)
201 201 # Invalid value
202 202 issue.custom_field_values = { field.id => 'SQLServer' }
203 203
204 204 assert !issue.valid?
205 205 assert_equal 1, issue.errors.full_messages.size
206 206 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
207 207 end
208 208
209 209 def test_update_issue_with_required_custom_field
210 210 field = IssueCustomField.find_by_name('Database')
211 211 field.update_attribute(:is_required, true)
212 212
213 213 issue = Issue.find(1)
214 214 assert_nil issue.custom_value_for(field)
215 215 assert issue.available_custom_fields.include?(field)
216 216 # No change to custom values, issue can be saved
217 217 assert issue.save
218 218 # Blank value
219 219 issue.custom_field_values = { field.id => '' }
220 220 assert !issue.save
221 221 # Valid value
222 222 issue.custom_field_values = { field.id => 'PostgreSQL' }
223 223 assert issue.save
224 224 issue.reload
225 225 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
226 226 end
227 227
228 228 def test_should_not_update_attributes_if_custom_fields_validation_fails
229 229 issue = Issue.find(1)
230 230 field = IssueCustomField.find_by_name('Database')
231 231 assert issue.available_custom_fields.include?(field)
232 232
233 233 issue.custom_field_values = { field.id => 'Invalid' }
234 234 issue.subject = 'Should be not be saved'
235 235 assert !issue.save
236 236
237 237 issue.reload
238 238 assert_equal "Can't print recipes", issue.subject
239 239 end
240 240
241 241 def test_should_not_recreate_custom_values_objects_on_update
242 242 field = IssueCustomField.find_by_name('Database')
243 243
244 244 issue = Issue.find(1)
245 245 issue.custom_field_values = { field.id => 'PostgreSQL' }
246 246 assert issue.save
247 247 custom_value = issue.custom_value_for(field)
248 248 issue.reload
249 249 issue.custom_field_values = { field.id => 'MySQL' }
250 250 assert issue.save
251 251 issue.reload
252 252 assert_equal custom_value.id, issue.custom_value_for(field).id
253 253 end
254 254
255 255 def test_assigning_tracker_id_should_reload_custom_fields_values
256 256 issue = Issue.new(:project => Project.find(1))
257 257 assert issue.custom_field_values.empty?
258 258 issue.tracker_id = 1
259 259 assert issue.custom_field_values.any?
260 260 end
261 261
262 262 def test_assigning_attributes_should_assign_tracker_id_first
263 263 attributes = ActiveSupport::OrderedHash.new
264 264 attributes['custom_field_values'] = { '1' => 'MySQL' }
265 265 attributes['tracker_id'] = '1'
266 266 issue = Issue.new(:project => Project.find(1))
267 267 issue.attributes = attributes
268 268 assert_not_nil issue.custom_value_for(1)
269 269 assert_equal 'MySQL', issue.custom_value_for(1).value
270 270 end
271 271
272 272 def test_should_update_issue_with_disabled_tracker
273 273 p = Project.find(1)
274 274 issue = Issue.find(1)
275 275
276 276 p.trackers.delete(issue.tracker)
277 277 assert !p.trackers.include?(issue.tracker)
278 278
279 279 issue.reload
280 280 issue.subject = 'New subject'
281 281 assert issue.save
282 282 end
283 283
284 284 def test_should_not_set_a_disabled_tracker
285 285 p = Project.find(1)
286 286 p.trackers.delete(Tracker.find(2))
287 287
288 288 issue = Issue.find(1)
289 289 issue.tracker_id = 2
290 290 issue.subject = 'New subject'
291 291 assert !issue.save
292 292 assert_not_nil issue.errors.on(:tracker_id)
293 293 end
294 294
295 295 def test_category_based_assignment
296 296 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
297 297 :status_id => 1, :priority => IssuePriority.all.first,
298 298 :subject => 'Assignment test',
299 299 :description => 'Assignment test', :category_id => 1)
300 300 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
301 301 end
302 302
303 303 def test_new_statuses_allowed_to
304 304 Workflow.delete_all
305 305
306 306 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
307 307 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
308 308 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
309 309 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
310 310 status = IssueStatus.find(1)
311 311 role = Role.find(1)
312 312 tracker = Tracker.find(1)
313 313 user = User.find(2)
314 314
315 315 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
316 316 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
317 317
318 318 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
319 319 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
320 320
321 321 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
322 322 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
323 323
324 324 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
325 325 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
326 326 end
327 327
328 328 def test_copy
329 329 issue = Issue.new.copy_from(1)
330 330 assert issue.save
331 331 issue.reload
332 332 orig = Issue.find(1)
333 333 assert_equal orig.subject, issue.subject
334 334 assert_equal orig.tracker, issue.tracker
335 335 assert_equal "125", issue.custom_value_for(2).value
336 336 end
337 337
338 338 def test_copy_should_copy_status
339 339 orig = Issue.find(8)
340 340 assert orig.status != IssueStatus.default
341 341
342 342 issue = Issue.new.copy_from(orig)
343 343 assert issue.save
344 344 issue.reload
345 345 assert_equal orig.status, issue.status
346 346 end
347 347
348 348 def test_should_close_duplicates
349 349 # Create 3 issues
350 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
350 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
351 :status_id => 1, :priority => IssuePriority.all.first,
352 :subject => 'Duplicates test', :description => 'Duplicates test')
351 353 assert issue1.save
352 354 issue2 = issue1.clone
353 355 assert issue2.save
354 356 issue3 = issue1.clone
355 357 assert issue3.save
356 358
357 359 # 2 is a dupe of 1
358 360 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
359 361 # And 3 is a dupe of 2
360 362 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
361 363 # And 3 is a dupe of 1 (circular duplicates)
362 364 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
363 365
364 366 assert issue1.reload.duplicates.include?(issue2)
365 367
366 368 # Closing issue 1
367 369 issue1.init_journal(User.find(:first), "Closing issue1")
368 370 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
369 371 assert issue1.save
370 372 # 2 and 3 should be also closed
371 373 assert issue2.reload.closed?
372 374 assert issue3.reload.closed?
373 375 end
374 376
375 377 def test_should_not_close_duplicated_issue
376 378 # Create 3 issues
377 379 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
378 380 :status_id => 1, :priority => IssuePriority.all.first,
379 381 :subject => 'Duplicates test', :description => 'Duplicates test')
380 382 assert issue1.save
381 383 issue2 = issue1.clone
382 384 assert issue2.save
383 385
384 386 # 2 is a dupe of 1
385 387 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
386 388 # 2 is a dup of 1 but 1 is not a duplicate of 2
387 389 assert !issue2.reload.duplicates.include?(issue1)
388 390
389 391 # Closing issue 2
390 392 issue2.init_journal(User.find(:first), "Closing issue2")
391 393 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
392 394 assert issue2.save
393 395 # 1 should not be also closed
394 396 assert !issue1.reload.closed?
395 397 end
396 398
397 399 def test_assignable_versions
398 400 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
399 401 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
400 402 end
401 403
402 404 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
403 405 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
404 406 assert !issue.save
405 407 assert_not_nil issue.errors.on(:fixed_version_id)
406 408 end
407 409
408 410 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
409 411 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
410 412 assert !issue.save
411 413 assert_not_nil issue.errors.on(:fixed_version_id)
412 414 end
413 415
414 416 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
415 417 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
416 418 assert issue.save
417 419 end
418 420
419 421 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
420 422 issue = Issue.find(11)
421 423 assert_equal 'closed', issue.fixed_version.status
422 424 issue.subject = 'Subject changed'
423 425 assert issue.save
424 426 end
425 427
426 428 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
427 429 issue = Issue.find(11)
428 430 issue.status_id = 1
429 431 assert !issue.save
430 432 assert_not_nil issue.errors.on_base
431 433 end
432 434
433 435 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
434 436 issue = Issue.find(11)
435 437 issue.status_id = 1
436 438 issue.fixed_version_id = 3
437 439 assert issue.save
438 440 end
439 441
440 442 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
441 443 issue = Issue.find(12)
442 444 assert_equal 'locked', issue.fixed_version.status
443 445 issue.status_id = 1
444 446 assert issue.save
445 447 end
446 448
447 449 def test_move_to_another_project_with_same_category
448 450 issue = Issue.find(1)
449 451 assert issue.move_to_project(Project.find(2))
450 452 issue.reload
451 453 assert_equal 2, issue.project_id
452 454 # Category changes
453 455 assert_equal 4, issue.category_id
454 456 # Make sure time entries were move to the target project
455 457 assert_equal 2, issue.time_entries.first.project_id
456 458 end
457 459
458 460 def test_move_to_another_project_without_same_category
459 461 issue = Issue.find(2)
460 462 assert issue.move_to_project(Project.find(2))
461 463 issue.reload
462 464 assert_equal 2, issue.project_id
463 465 # Category cleared
464 466 assert_nil issue.category_id
465 467 end
466 468
467 469 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
468 470 issue = Issue.find(1)
469 471 issue.update_attribute(:fixed_version_id, 1)
470 472 assert issue.move_to_project(Project.find(2))
471 473 issue.reload
472 474 assert_equal 2, issue.project_id
473 475 # Cleared fixed_version
474 476 assert_equal nil, issue.fixed_version
475 477 end
476 478
477 479 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
478 480 issue = Issue.find(1)
479 481 issue.update_attribute(:fixed_version_id, 4)
480 482 assert issue.move_to_project(Project.find(5))
481 483 issue.reload
482 484 assert_equal 5, issue.project_id
483 485 # Keep fixed_version
484 486 assert_equal 4, issue.fixed_version_id
485 487 end
486 488
487 489 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
488 490 issue = Issue.find(1)
489 491 issue.update_attribute(:fixed_version_id, 1)
490 492 assert issue.move_to_project(Project.find(5))
491 493 issue.reload
492 494 assert_equal 5, issue.project_id
493 495 # Cleared fixed_version
494 496 assert_equal nil, issue.fixed_version
495 497 end
496 498
497 499 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
498 500 issue = Issue.find(1)
499 501 issue.update_attribute(:fixed_version_id, 7)
500 502 assert issue.move_to_project(Project.find(2))
501 503 issue.reload
502 504 assert_equal 2, issue.project_id
503 505 # Keep fixed_version
504 506 assert_equal 7, issue.fixed_version_id
505 507 end
506 508
507 509 def test_move_to_another_project_with_disabled_tracker
508 510 issue = Issue.find(1)
509 511 target = Project.find(2)
510 512 target.tracker_ids = [3]
511 513 target.save
512 514 assert_equal false, issue.move_to_project(target)
513 515 issue.reload
514 516 assert_equal 1, issue.project_id
515 517 end
516 518
517 519 def test_copy_to_the_same_project
518 520 issue = Issue.find(1)
519 521 copy = nil
520 522 assert_difference 'Issue.count' do
521 523 copy = issue.move_to_project(issue.project, nil, :copy => true)
522 524 end
523 525 assert_kind_of Issue, copy
524 526 assert_equal issue.project, copy.project
525 527 assert_equal "125", copy.custom_value_for(2).value
526 528 end
527 529
528 530 def test_copy_to_another_project_and_tracker
529 531 issue = Issue.find(1)
530 532 copy = nil
531 533 assert_difference 'Issue.count' do
532 534 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
533 535 end
534 536 copy.reload
535 537 assert_kind_of Issue, copy
536 538 assert_equal Project.find(3), copy.project
537 539 assert_equal Tracker.find(2), copy.tracker
538 540 # Custom field #2 is not associated with target tracker
539 541 assert_nil copy.custom_value_for(2)
540 542 end
541 543
542 544 context "#move_to_project" do
543 545 context "as a copy" do
544 546 setup do
545 547 @issue = Issue.find(1)
546 548 @copy = nil
547 549 end
548 550
549 551 should "not create a journal" do
550 552 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
551 553 assert_equal 0, @copy.reload.journals.size
552 554 end
553 555
554 556 should "allow assigned_to changes" do
555 557 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
556 558 assert_equal 3, @copy.assigned_to_id
557 559 end
558 560
559 561 should "allow status changes" do
560 562 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
561 563 assert_equal 2, @copy.status_id
562 564 end
563 565
564 566 should "allow start date changes" do
565 567 date = Date.today
566 568 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
567 569 assert_equal date, @copy.start_date
568 570 end
569 571
570 572 should "allow due date changes" do
571 573 date = Date.today
572 574 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
573 575
574 576 assert_equal date, @copy.due_date
575 577 end
576 578
577 579 should "set current user as author" do
578 580 User.current = User.find(9)
579 581 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
580 582
581 583 assert_equal User.current, @copy.author
582 584 end
583 585
584 586 should "keep journal notes" do
585 587 date = Date.today
586 588 notes = "Notes added when copying"
587 589 User.current = User.find(9)
588 590 @issue.init_journal(User.current, notes)
589 591 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
590 592
591 593 assert_equal 1, @copy.journals.size
592 594 journal = @copy.journals.first
593 595 assert_equal 0, journal.details.size
594 596 assert_equal notes, journal.notes
595 597 end
596 598 end
597 599 end
598 600
599 601 def test_recipients_should_not_include_users_that_cannot_view_the_issue
600 602 issue = Issue.find(12)
601 603 assert issue.recipients.include?(issue.author.mail)
602 604 # move the issue to a private project
603 605 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
604 606 # author is not a member of project anymore
605 607 assert !copy.recipients.include?(copy.author.mail)
606 608 end
607 609
608 610 def test_recipients_should_include_the_assigned_group_members
609 611 group_member = User.generate_with_protected!
610 612 group = Group.generate!
611 613 group.users << group_member
612 614
613 615 issue = Issue.find(12)
614 616 issue.assigned_to = group
615 617 assert issue.recipients.include?(group_member.mail)
616 618 end
617 619
618 620 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
619 621 user = User.find(3)
620 622 issue = Issue.find(9)
621 623 Watcher.create!(:user => user, :watchable => issue)
622 624 assert issue.watched_by?(user)
623 625 assert !issue.watcher_recipients.include?(user.mail)
624 626 end
625 627
626 628 def test_issue_destroy
627 629 Issue.find(1).destroy
628 630 assert_nil Issue.find_by_id(1)
629 631 assert_nil TimeEntry.find_by_issue_id(1)
630 632 end
631 633
632 634 def test_blocked
633 635 blocked_issue = Issue.find(9)
634 636 blocking_issue = Issue.find(10)
635 637
636 638 assert blocked_issue.blocked?
637 639 assert !blocking_issue.blocked?
638 640 end
639 641
640 642 def test_blocked_issues_dont_allow_closed_statuses
641 643 blocked_issue = Issue.find(9)
642 644
643 645 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
644 646 assert !allowed_statuses.empty?
645 647 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
646 648 assert closed_statuses.empty?
647 649 end
648 650
649 651 def test_unblocked_issues_allow_closed_statuses
650 652 blocking_issue = Issue.find(10)
651 653
652 654 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
653 655 assert !allowed_statuses.empty?
654 656 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
655 657 assert !closed_statuses.empty?
656 658 end
657 659
658 660 def test_rescheduling_an_issue_should_reschedule_following_issue
659 661 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
660 662 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
661 663 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
662 664 assert_equal issue1.due_date + 1, issue2.reload.start_date
663 665
664 666 issue1.due_date = Date.today + 5
665 667 issue1.save!
666 668 assert_equal issue1.due_date + 1, issue2.reload.start_date
667 669 end
668 670
669 671 def test_overdue
670 672 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
671 673 assert !Issue.new(:due_date => Date.today).overdue?
672 674 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
673 675 assert !Issue.new(:due_date => nil).overdue?
674 676 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
675 677 end
676 678
677 679 context "#behind_schedule?" do
678 680 should "be false if the issue has no start_date" do
679 681 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
680 682 end
681 683
682 684 should "be false if the issue has no end_date" do
683 685 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
684 686 end
685 687
686 688 should "be false if the issue has more done than it's calendar time" do
687 689 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
688 690 end
689 691
690 692 should "be true if the issue hasn't been started at all" do
691 693 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
692 694 end
693 695
694 696 should "be true if the issue has used more calendar time than it's done ratio" do
695 697 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
696 698 end
697 699 end
698 700
699 701 context "#assignable_users" do
700 702 should "be Users" do
701 703 assert_kind_of User, Issue.find(1).assignable_users.first
702 704 end
703 705
704 706 should "include the issue author" do
705 707 project = Project.find(1)
706 708 non_project_member = User.generate!
707 709 issue = Issue.generate_for_project!(project, :author => non_project_member)
708 710
709 711 assert issue.assignable_users.include?(non_project_member)
710 712 end
711 713
712 714 should "include the current assignee" do
713 715 project = Project.find(1)
714 716 user = User.generate!
715 717 issue = Issue.generate_for_project!(project, :assigned_to => user)
716 718 user.lock!
717 719
718 720 assert Issue.find(issue.id).assignable_users.include?(user)
719 721 end
720 722
721 723 should "not show the issue author twice" do
722 724 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
723 725 assert_equal 2, assignable_user_ids.length
724 726
725 727 assignable_user_ids.each do |user_id|
726 728 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
727 729 end
728 730 end
729 731
730 732 context "with issue_group_assignment" do
731 733 should "include groups" do
732 734 issue = Issue.new(:project => Project.find(2))
733 735
734 736 with_settings :issue_group_assignment => '1' do
735 737 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
736 738 assert issue.assignable_users.include?(Group.find(11))
737 739 end
738 740 end
739 741 end
740 742
741 743 context "without issue_group_assignment" do
742 744 should "not include groups" do
743 745 issue = Issue.new(:project => Project.find(2))
744 746
745 747 with_settings :issue_group_assignment => '0' do
746 748 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
747 749 assert !issue.assignable_users.include?(Group.find(11))
748 750 end
749 751 end
750 752 end
751 753 end
752 754
753 755 def test_create_should_send_email_notification
754 756 ActionMailer::Base.deliveries.clear
755 757 issue = Issue.new(:project_id => 1, :tracker_id => 1,
756 758 :author_id => 3, :status_id => 1,
757 759 :priority => IssuePriority.all.first,
758 760 :subject => 'test_create', :estimated_hours => '1:30')
759 761
760 762 assert issue.save
761 763 assert_equal 1, ActionMailer::Base.deliveries.size
762 764 end
763 765
764 766 def test_stale_issue_should_not_send_email_notification
765 767 ActionMailer::Base.deliveries.clear
766 768 issue = Issue.find(1)
767 769 stale = Issue.find(1)
768 770
769 771 issue.init_journal(User.find(1))
770 772 issue.subject = 'Subjet update'
771 773 assert issue.save
772 774 assert_equal 1, ActionMailer::Base.deliveries.size
773 775 ActionMailer::Base.deliveries.clear
774 776
775 777 stale.init_journal(User.find(1))
776 778 stale.subject = 'Another subjet update'
777 779 assert_raise ActiveRecord::StaleObjectError do
778 780 stale.save
779 781 end
780 782 assert ActionMailer::Base.deliveries.empty?
781 783 end
782 784
783 785 def test_journalized_description
784 786 IssueCustomField.delete_all
785 787
786 788 i = Issue.first
787 789 old_description = i.description
788 790 new_description = "This is the new description"
789 791
790 792 i.init_journal(User.find(2))
791 793 i.description = new_description
792 794 assert_difference 'Journal.count', 1 do
793 795 assert_difference 'JournalDetail.count', 1 do
794 796 i.save!
795 797 end
796 798 end
797 799
798 800 detail = JournalDetail.first(:order => 'id DESC')
799 801 assert_equal i, detail.journal.journalized
800 802 assert_equal 'attr', detail.property
801 803 assert_equal 'description', detail.prop_key
802 804 assert_equal old_description, detail.old_value
803 805 assert_equal new_description, detail.value
804 806 end
805 807
806 808 def test_blank_descriptions_should_not_be_journalized
807 809 IssueCustomField.delete_all
808 810 Issue.update_all("description = NULL", "id=1")
809 811
810 812 i = Issue.find(1)
811 813 i.init_journal(User.find(2))
812 814 i.subject = "blank description"
813 815 i.description = "\r\n"
814 816
815 817 assert_difference 'Journal.count', 1 do
816 818 assert_difference 'JournalDetail.count', 1 do
817 819 i.save!
818 820 end
819 821 end
820 822 end
821 823
822 824 def test_description_eol_should_be_normalized
823 825 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
824 826 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
825 827 end
826 828
827 829 def test_saving_twice_should_not_duplicate_journal_details
828 830 i = Issue.find(:first)
829 831 i.init_journal(User.find(2), 'Some notes')
830 832 # initial changes
831 833 i.subject = 'New subject'
832 834 i.done_ratio = i.done_ratio + 10
833 835 assert_difference 'Journal.count' do
834 836 assert i.save
835 837 end
836 838 # 1 more change
837 839 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
838 840 assert_no_difference 'Journal.count' do
839 841 assert_difference 'JournalDetail.count', 1 do
840 842 i.save
841 843 end
842 844 end
843 845 # no more change
844 846 assert_no_difference 'Journal.count' do
845 847 assert_no_difference 'JournalDetail.count' do
846 848 i.save
847 849 end
848 850 end
849 851 end
850 852
851 853 def test_all_dependent_issues
852 854 IssueRelation.delete_all
853 855 assert IssueRelation.create!(:issue_from => Issue.find(1),
854 856 :issue_to => Issue.find(2),
855 857 :relation_type => IssueRelation::TYPE_PRECEDES)
856 858 assert IssueRelation.create!(:issue_from => Issue.find(2),
857 859 :issue_to => Issue.find(3),
858 860 :relation_type => IssueRelation::TYPE_PRECEDES)
859 861 assert IssueRelation.create!(:issue_from => Issue.find(3),
860 862 :issue_to => Issue.find(8),
861 863 :relation_type => IssueRelation::TYPE_PRECEDES)
862 864
863 865 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
864 866 end
865 867
866 868 def test_all_dependent_issues_with_persistent_circular_dependency
867 869 IssueRelation.delete_all
868 870 assert IssueRelation.create!(:issue_from => Issue.find(1),
869 871 :issue_to => Issue.find(2),
870 872 :relation_type => IssueRelation::TYPE_PRECEDES)
871 873 assert IssueRelation.create!(:issue_from => Issue.find(2),
872 874 :issue_to => Issue.find(3),
873 875 :relation_type => IssueRelation::TYPE_PRECEDES)
874 876 # Validation skipping
875 877 assert IssueRelation.new(:issue_from => Issue.find(3),
876 878 :issue_to => Issue.find(1),
877 879 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
878 880
879 881 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
880 882 end
881 883
882 884 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
883 885 IssueRelation.delete_all
884 886 assert IssueRelation.create!(:issue_from => Issue.find(1),
885 887 :issue_to => Issue.find(2),
886 888 :relation_type => IssueRelation::TYPE_RELATES)
887 889 assert IssueRelation.create!(:issue_from => Issue.find(2),
888 890 :issue_to => Issue.find(3),
889 891 :relation_type => IssueRelation::TYPE_RELATES)
890 892 assert IssueRelation.create!(:issue_from => Issue.find(3),
891 893 :issue_to => Issue.find(8),
892 894 :relation_type => IssueRelation::TYPE_RELATES)
893 895 # Validation skipping
894 896 assert IssueRelation.new(:issue_from => Issue.find(8),
895 897 :issue_to => Issue.find(2),
896 898 :relation_type => IssueRelation::TYPE_RELATES).save(false)
897 899 assert IssueRelation.new(:issue_from => Issue.find(3),
898 900 :issue_to => Issue.find(1),
899 901 :relation_type => IssueRelation::TYPE_RELATES).save(false)
900 902
901 903 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
902 904 end
903 905
904 906 context "#done_ratio" do
905 907 setup do
906 908 @issue = Issue.find(1)
907 909 @issue_status = IssueStatus.find(1)
908 910 @issue_status.update_attribute(:default_done_ratio, 50)
909 911 @issue2 = Issue.find(2)
910 912 @issue_status2 = IssueStatus.find(2)
911 913 @issue_status2.update_attribute(:default_done_ratio, 0)
912 914 end
913 915
914 916 context "with Setting.issue_done_ratio using the issue_field" do
915 917 setup do
916 918 Setting.issue_done_ratio = 'issue_field'
917 919 end
918 920
919 921 should "read the issue's field" do
920 922 assert_equal 0, @issue.done_ratio
921 923 assert_equal 30, @issue2.done_ratio
922 924 end
923 925 end
924 926
925 927 context "with Setting.issue_done_ratio using the issue_status" do
926 928 setup do
927 929 Setting.issue_done_ratio = 'issue_status'
928 930 end
929 931
930 932 should "read the Issue Status's default done ratio" do
931 933 assert_equal 50, @issue.done_ratio
932 934 assert_equal 0, @issue2.done_ratio
933 935 end
934 936 end
935 937 end
936 938
937 939 context "#update_done_ratio_from_issue_status" do
938 940 setup do
939 941 @issue = Issue.find(1)
940 942 @issue_status = IssueStatus.find(1)
941 943 @issue_status.update_attribute(:default_done_ratio, 50)
942 944 @issue2 = Issue.find(2)
943 945 @issue_status2 = IssueStatus.find(2)
944 946 @issue_status2.update_attribute(:default_done_ratio, 0)
945 947 end
946 948
947 949 context "with Setting.issue_done_ratio using the issue_field" do
948 950 setup do
949 951 Setting.issue_done_ratio = 'issue_field'
950 952 end
951 953
952 954 should "not change the issue" do
953 955 @issue.update_done_ratio_from_issue_status
954 956 @issue2.update_done_ratio_from_issue_status
955 957
956 958 assert_equal 0, @issue.read_attribute(:done_ratio)
957 959 assert_equal 30, @issue2.read_attribute(:done_ratio)
958 960 end
959 961 end
960 962
961 963 context "with Setting.issue_done_ratio using the issue_status" do
962 964 setup do
963 965 Setting.issue_done_ratio = 'issue_status'
964 966 end
965 967
966 968 should "change the issue's done ratio" do
967 969 @issue.update_done_ratio_from_issue_status
968 970 @issue2.update_done_ratio_from_issue_status
969 971
970 972 assert_equal 50, @issue.read_attribute(:done_ratio)
971 973 assert_equal 0, @issue2.read_attribute(:done_ratio)
972 974 end
973 975 end
974 976 end
975 977
976 978 test "#by_tracker" do
977 979 User.current = User.anonymous
978 980 groups = Issue.by_tracker(Project.find(1))
979 981 assert_equal 3, groups.size
980 982 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
981 983 end
982 984
983 985 test "#by_version" do
984 986 User.current = User.anonymous
985 987 groups = Issue.by_version(Project.find(1))
986 988 assert_equal 3, groups.size
987 989 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
988 990 end
989 991
990 992 test "#by_priority" do
991 993 User.current = User.anonymous
992 994 groups = Issue.by_priority(Project.find(1))
993 995 assert_equal 4, groups.size
994 996 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
995 997 end
996 998
997 999 test "#by_category" do
998 1000 User.current = User.anonymous
999 1001 groups = Issue.by_category(Project.find(1))
1000 1002 assert_equal 2, groups.size
1001 1003 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1002 1004 end
1003 1005
1004 1006 test "#by_assigned_to" do
1005 1007 User.current = User.anonymous
1006 1008 groups = Issue.by_assigned_to(Project.find(1))
1007 1009 assert_equal 2, groups.size
1008 1010 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1009 1011 end
1010 1012
1011 1013 test "#by_author" do
1012 1014 User.current = User.anonymous
1013 1015 groups = Issue.by_author(Project.find(1))
1014 1016 assert_equal 4, groups.size
1015 1017 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1016 1018 end
1017 1019
1018 1020 test "#by_subproject" do
1019 1021 User.current = User.anonymous
1020 1022 groups = Issue.by_subproject(Project.find(1))
1021 1023 # Private descendant not visible
1022 1024 assert_equal 1, groups.size
1023 1025 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1024 1026 end
1025 1027
1026 1028 context ".allowed_target_projects_on_move" do
1027 1029 should "return all active projects for admin users" do
1028 1030 User.current = User.find(1)
1029 1031 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1030 1032 end
1031 1033
1032 1034 should "return allowed projects for non admin users" do
1033 1035 User.current = User.find(2)
1034 1036 Role.non_member.remove_permission! :move_issues
1035 1037 assert_equal 3, Issue.allowed_target_projects_on_move.size
1036 1038
1037 1039 Role.non_member.add_permission! :move_issues
1038 1040 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1039 1041 end
1040 1042 end
1041 1043
1042 1044 def test_recently_updated_with_limit_scopes
1043 1045 #should return the last updated issue
1044 1046 assert_equal 1, Issue.recently_updated.with_limit(1).length
1045 1047 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1046 1048 end
1047 1049
1048 1050 def test_on_active_projects_scope
1049 1051 assert Project.find(2).archive
1050 1052
1051 1053 before = Issue.on_active_project.length
1052 1054 # test inclusion to results
1053 1055 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1054 1056 assert_equal before + 1, Issue.on_active_project.length
1055 1057
1056 1058 # Move to an archived project
1057 1059 issue.project = Project.find(2)
1058 1060 assert issue.save
1059 1061 assert_equal before, Issue.on_active_project.length
1060 1062 end
1061 1063
1062 1064 context "Issue#recipients" do
1063 1065 setup do
1064 1066 @project = Project.find(1)
1065 1067 @author = User.generate_with_protected!
1066 1068 @assignee = User.generate_with_protected!
1067 1069 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1068 1070 end
1069 1071
1070 1072 should "include project recipients" do
1071 1073 assert @project.recipients.present?
1072 1074 @project.recipients.each do |project_recipient|
1073 1075 assert @issue.recipients.include?(project_recipient)
1074 1076 end
1075 1077 end
1076 1078
1077 1079 should "include the author if the author is active" do
1078 1080 assert @issue.author, "No author set for Issue"
1079 1081 assert @issue.recipients.include?(@issue.author.mail)
1080 1082 end
1081 1083
1082 1084 should "include the assigned to user if the assigned to user is active" do
1083 1085 assert @issue.assigned_to, "No assigned_to set for Issue"
1084 1086 assert @issue.recipients.include?(@issue.assigned_to.mail)
1085 1087 end
1086 1088
1087 1089 should "not include users who opt out of all email" do
1088 1090 @author.update_attribute(:mail_notification, :none)
1089 1091
1090 1092 assert !@issue.recipients.include?(@issue.author.mail)
1091 1093 end
1092 1094
1093 1095 should "not include the issue author if they are only notified of assigned issues" do
1094 1096 @author.update_attribute(:mail_notification, :only_assigned)
1095 1097
1096 1098 assert !@issue.recipients.include?(@issue.author.mail)
1097 1099 end
1098 1100
1099 1101 should "not include the assigned user if they are only notified of owned issues" do
1100 1102 @assignee.update_attribute(:mail_notification, :only_owner)
1101 1103
1102 1104 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1103 1105 end
1104 1106
1105 1107 end
1106 1108 end
General Comments 0
You need to be logged in to leave comments. Login now