jro_apps/redmine Commit - r681:a2439f3b34c3

Trac importer now checks the existence of trac.db and attachments directory before processing....

Jean-Philippe Lang -

r681:a2439f3b34c3

parent child

Context file:

r681:a2439f3b34c3

Collapse all files

lib/tasks/migrate_from_trac.rake +34 -22

                     def trac_fullpath
                       attachment_type = read_attribute(:type)
                       trac_file = filename.gsub( /[^a-zA-Z0-9\-_\.!~*']/n ) {|x| sprintf('%%%02x', x[0]) }
-                      "#{TracMigrate.trac_directory}/attachments/#{attachment_type}/#{id}/#{trac_file}"
+                      "#{TracMigrate.trac_attachments_directory}/#{attachment_type}/#{id}/#{trac_file}"
                     end
                   end
                   def self.encoding(charset)
                     @ic = Iconv.new('UTF-8', charset)
                   rescue Iconv::InvalidEncoding
+                    puts "Invalid encoding!"
                     return false
                   end
-                  def self.trac_directory=(path)
+                  def self.set_trac_directory(path)
-                    @trac_directory = path if File.directory?(path)
+                    @trac_directory = path
+                    raise "This directory doesn't exist!" unless File.directory?(path)
+                    raise "#{trac_db_path} doesn't exist!" unless File.exist?(trac_db_path)
+                    raise "#{trac_attachments_directory} doesn't exist!" unless File.directory?(trac_attachments_directory)
+                    @trac_directory
+                  rescue Exception => e
+                    puts e
+                    return false
                   end
                   def self.trac_directory
                     @trac_directory
                   end
+                  def self.trac_db_path; "#{trac_directory}/db/trac.db" end
+                  def self.trac_attachments_directory; "#{trac_directory}/attachments" end
                   def self.target_project_identifier(identifier)
-                    @target_project = Project.find_by_identifier(identifier)
+                    project = Project.find_by_identifier(identifier)
+                    if !project
+                      # create the target project
+                      project = Project.new :name => identifier.humanize,
+                                            :description => identifier.humanize
+                      project.identifier = identifier
+                      puts "Unable to create a project with identifier '#{identifier}'!" unless project.save
+                    end
+                    @target_project = project.new_record? ? nil : project
                   end
                   def self.establish_connection(params)
                 break unless STDIN.gets.match(/^y$/i)
                 puts
+                def prompt(text, options = {}, &block)
+                  default = options[:default] || ''
                   while true
-                  print "Trac directory: "
+                    print "#{text} [#{default}]: "
-                  directory = STDIN.gets.chomp!
+                    value = STDIN.gets.chomp!
-                  TracMigrate.trac_directory = directory
+                    value = default if value.blank?
-                  break if TracMigrate.trac_directory
+                    break if yield value
-                  puts "  This directory doesn't exist!"
                   end
-                while true
-                  print "Database encoding [UTF-8]: "
-                  encoding = STDIN.gets.chomp!
-                  encoding = 'UTF-8' if encoding.blank?
-                  break if TracMigrate.encoding encoding
-                  puts "  Invalid encoding!"
-                end
-                while true
-                  print "Target project identifier: "
-                  identifier = STDIN.gets.chomp!
-                  break if TracMigrate.target_project_identifier identifier
-                  puts "  Project not found in Redmine database!"
                 end
+                prompt('Trac directory') {|directory| TracMigrate.set_trac_directory directory}
+                prompt('Database encoding', :default => 'UTF-8') {|encoding| TracMigrate.encoding encoding}
+                prompt('Target project identifier') {|identifier| TracMigrate.target_project_identifier identifier}
                 puts
                 TracMigrate.establish_connection({:adapter => 'sqlite',
-                                                  :database => "#{TracMigrate.trac_directory}/db/trac.db"})
+                                                  :database => "#{TracMigrate.trac_db_path}"})
                 TracMigrate.migrate
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages