jro_apps/redmine Commit - r9733:a1f17b982c72

Perf: use a custom decoder for Role#permissions instead of YAML.load....

Jean-Philippe Lang -

r9733:a1f17b982c72

parent child

Context file:

r9733:a1f17b982c72

app/models/role.rb +14 -5

             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Role < ActiveRecord::Base
+              # Custom coder for the permissions attribute that should be an
+              # array of symbols. Rails 3 uses Psych which can be *unbelievably*
+              # slow on some platforms (eg. mingw32).
+              class PermissionsAttributeCoder
+                def self.load(str)
+                  str.to_s.scan(/:([a-z0-9_]+)/).flatten.map(&:to_sym)
+                end
+                def self.dump(value)
+                  YAML.dump(value)
+                end
+              end
               # Built-in roles
               BUILTIN_NON_MEMBER = 1
               BUILTIN_ANONYMOUS  = 2
               has_many :members, :through => :member_roles
               acts_as_list
-              serialize :permissions, Array
+              serialize :permissions, ::Role::PermissionsAttributeCoder
               attr_protected :builtin
               validates_presence_of :name
                 :in => ISSUES_VISIBILITY_OPTIONS.collect(&:first),
                 :if => lambda {|role| role.respond_to?(:issues_visibility)}
-              def permissions
-                read_attribute(:permissions) || []
-              end
               def permissions=(perms)
                 perms = perms.collect {|p| p.to_sym unless p.blank? }.compact.uniq if perms
                 write_attribute(:permissions, perms)

test/unit/role_test.rb +5 0

                 assert_equal 90, target.workflows.size
               end
+              def test_permissions_should_be_unserialized_with_its_coder
+                Role::PermissionsAttributeCoder.expects(:load).once
+                Role.find(1).permissions
+              end
               def test_add_permission
                 role = Role.find(1)
                 size = role.permissions.size

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages