##// END OF EJS Templates
Filter on issue ID with between/lesser/greater operator does not work (#23596)....
Jean-Philippe Lang -
r15369:9f9232381ab6
parent child
Show More
@@ -1,519 +1,524
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2016 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssueQuery < Query
19 19
20 20 self.queried_class = Issue
21 21 self.view_permission = :view_issues
22 22
23 23 self.available_columns = [
24 24 QueryColumn.new(:id, :sortable => "#{Issue.table_name}.id", :default_order => 'desc', :caption => '#', :frozen => true),
25 25 QueryColumn.new(:project, :sortable => "#{Project.table_name}.name", :groupable => true),
26 26 QueryColumn.new(:tracker, :sortable => "#{Tracker.table_name}.position", :groupable => true),
27 27 QueryColumn.new(:parent, :sortable => ["#{Issue.table_name}.root_id", "#{Issue.table_name}.lft ASC"], :default_order => 'desc', :caption => :field_parent_issue),
28 28 QueryColumn.new(:status, :sortable => "#{IssueStatus.table_name}.position", :groupable => true),
29 29 QueryColumn.new(:priority, :sortable => "#{IssuePriority.table_name}.position", :default_order => 'desc', :groupable => true),
30 30 QueryColumn.new(:subject, :sortable => "#{Issue.table_name}.subject"),
31 31 QueryColumn.new(:author, :sortable => lambda {User.fields_for_order_statement("authors")}, :groupable => true),
32 32 QueryColumn.new(:assigned_to, :sortable => lambda {User.fields_for_order_statement}, :groupable => true),
33 33 QueryColumn.new(:updated_on, :sortable => "#{Issue.table_name}.updated_on", :default_order => 'desc'),
34 34 QueryColumn.new(:category, :sortable => "#{IssueCategory.table_name}.name", :groupable => true),
35 35 QueryColumn.new(:fixed_version, :sortable => lambda {Version.fields_for_order_statement}, :groupable => true),
36 36 QueryColumn.new(:start_date, :sortable => "#{Issue.table_name}.start_date"),
37 37 QueryColumn.new(:due_date, :sortable => "#{Issue.table_name}.due_date"),
38 38 QueryColumn.new(:estimated_hours, :sortable => "#{Issue.table_name}.estimated_hours", :totalable => true),
39 39 QueryColumn.new(:total_estimated_hours,
40 40 :sortable => "COALESCE((SELECT SUM(estimated_hours) FROM #{Issue.table_name} subtasks" +
41 41 " WHERE subtasks.root_id = #{Issue.table_name}.root_id AND subtasks.lft >= #{Issue.table_name}.lft AND subtasks.rgt <= #{Issue.table_name}.rgt), 0)",
42 42 :default_order => 'desc'),
43 43 QueryColumn.new(:done_ratio, :sortable => "#{Issue.table_name}.done_ratio", :groupable => true),
44 44 QueryColumn.new(:created_on, :sortable => "#{Issue.table_name}.created_on", :default_order => 'desc'),
45 45 QueryColumn.new(:closed_on, :sortable => "#{Issue.table_name}.closed_on", :default_order => 'desc'),
46 46 QueryColumn.new(:relations, :caption => :label_related_issues),
47 47 QueryColumn.new(:description, :inline => false)
48 48 ]
49 49
50 50 def initialize(attributes=nil, *args)
51 51 super attributes
52 52 self.filters ||= { 'status_id' => {:operator => "o", :values => [""]} }
53 53 end
54 54
55 55 def draw_relations
56 56 r = options[:draw_relations]
57 57 r.nil? || r == '1'
58 58 end
59 59
60 60 def draw_relations=(arg)
61 61 options[:draw_relations] = (arg == '0' ? '0' : nil)
62 62 end
63 63
64 64 def draw_progress_line
65 65 r = options[:draw_progress_line]
66 66 r == '1'
67 67 end
68 68
69 69 def draw_progress_line=(arg)
70 70 options[:draw_progress_line] = (arg == '1' ? '1' : nil)
71 71 end
72 72
73 73 def build_from_params(params)
74 74 super
75 75 self.draw_relations = params[:draw_relations] || (params[:query] && params[:query][:draw_relations])
76 76 self.draw_progress_line = params[:draw_progress_line] || (params[:query] && params[:query][:draw_progress_line])
77 77 self
78 78 end
79 79
80 80 def initialize_available_filters
81 81 principals = []
82 82 subprojects = []
83 83 versions = []
84 84 categories = []
85 85 issue_custom_fields = []
86 86
87 87 if project
88 88 principals += project.principals.visible
89 89 unless project.leaf?
90 90 subprojects = project.descendants.visible.to_a
91 91 principals += Principal.member_of(subprojects).visible
92 92 end
93 93 versions = project.shared_versions.to_a
94 94 categories = project.issue_categories.to_a
95 95 issue_custom_fields = project.all_issue_custom_fields
96 96 else
97 97 if all_projects.any?
98 98 principals += Principal.member_of(all_projects).visible
99 99 end
100 100 versions = Version.visible.where(:sharing => 'system').to_a
101 101 issue_custom_fields = IssueCustomField.where(:is_for_all => true)
102 102 end
103 103 principals.uniq!
104 104 principals.sort!
105 105 principals.reject! {|p| p.is_a?(GroupBuiltin)}
106 106 users = principals.select {|p| p.is_a?(User)}
107 107
108 108 add_available_filter "status_id",
109 109 :type => :list_status, :values => IssueStatus.sorted.collect{|s| [s.name, s.id.to_s] }
110 110
111 111 if project.nil?
112 112 project_values = []
113 113 if User.current.logged? && User.current.memberships.any?
114 114 project_values << ["<< #{l(:label_my_projects).downcase} >>", "mine"]
115 115 end
116 116 project_values += all_projects_values
117 117 add_available_filter("project_id",
118 118 :type => :list, :values => project_values
119 119 ) unless project_values.empty?
120 120 end
121 121
122 122 add_available_filter "tracker_id",
123 123 :type => :list, :values => trackers.collect{|s| [s.name, s.id.to_s] }
124 124 add_available_filter "priority_id",
125 125 :type => :list, :values => IssuePriority.all.collect{|s| [s.name, s.id.to_s] }
126 126
127 127 author_values = []
128 128 author_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
129 129 author_values += users.collect{|s| [s.name, s.id.to_s] }
130 130 add_available_filter("author_id",
131 131 :type => :list, :values => author_values
132 132 ) unless author_values.empty?
133 133
134 134 assigned_to_values = []
135 135 assigned_to_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
136 136 assigned_to_values += (Setting.issue_group_assignment? ?
137 137 principals : users).collect{|s| [s.name, s.id.to_s] }
138 138 add_available_filter("assigned_to_id",
139 139 :type => :list_optional, :values => assigned_to_values
140 140 ) unless assigned_to_values.empty?
141 141
142 142 group_values = Group.givable.visible.collect {|g| [g.name, g.id.to_s] }
143 143 add_available_filter("member_of_group",
144 144 :type => :list_optional, :values => group_values
145 145 ) unless group_values.empty?
146 146
147 147 role_values = Role.givable.collect {|r| [r.name, r.id.to_s] }
148 148 add_available_filter("assigned_to_role",
149 149 :type => :list_optional, :values => role_values
150 150 ) unless role_values.empty?
151 151
152 152 add_available_filter "fixed_version_id",
153 153 :type => :list_optional,
154 154 :values => Version.sort_by_status(versions).collect{|s| ["#{s.project.name} - #{s.name}", s.id.to_s, l("version_status_#{s.status}")] }
155 155
156 156 add_available_filter "category_id",
157 157 :type => :list_optional,
158 158 :values => categories.collect{|s| [s.name, s.id.to_s] }
159 159
160 160 add_available_filter "subject", :type => :text
161 161 add_available_filter "description", :type => :text
162 162 add_available_filter "created_on", :type => :date_past
163 163 add_available_filter "updated_on", :type => :date_past
164 164 add_available_filter "closed_on", :type => :date_past
165 165 add_available_filter "start_date", :type => :date
166 166 add_available_filter "due_date", :type => :date
167 167 add_available_filter "estimated_hours", :type => :float
168 168 add_available_filter "done_ratio", :type => :integer
169 169
170 170 if User.current.allowed_to?(:set_issues_private, nil, :global => true) ||
171 171 User.current.allowed_to?(:set_own_issues_private, nil, :global => true)
172 172 add_available_filter "is_private",
173 173 :type => :list,
174 174 :values => [[l(:general_text_yes), "1"], [l(:general_text_no), "0"]]
175 175 end
176 176
177 177 if User.current.logged?
178 178 add_available_filter "watcher_id",
179 179 :type => :list, :values => [["<< #{l(:label_me)} >>", "me"]]
180 180 end
181 181
182 182 if subprojects.any?
183 183 add_available_filter "subproject_id",
184 184 :type => :list_subprojects,
185 185 :values => subprojects.collect{|s| [s.name, s.id.to_s] }
186 186 end
187 187
188 188 add_custom_fields_filters(issue_custom_fields)
189 189
190 190 add_associations_custom_fields_filters :project, :author, :assigned_to, :fixed_version
191 191
192 192 IssueRelation::TYPES.each do |relation_type, options|
193 193 add_available_filter relation_type, :type => :relation, :label => options[:name]
194 194 end
195 195 add_available_filter "parent_id", :type => :tree, :label => :field_parent_issue
196 196 add_available_filter "child_id", :type => :tree, :label => :label_subtask_plural
197 197
198 198 add_available_filter "issue_id", :type => :integer, :label => :label_issue
199 199
200 200 Tracker.disabled_core_fields(trackers).each {|field|
201 201 delete_available_filter field
202 202 }
203 203 end
204 204
205 205 def available_columns
206 206 return @available_columns if @available_columns
207 207 @available_columns = self.class.available_columns.dup
208 208 @available_columns += (project ?
209 209 project.all_issue_custom_fields :
210 210 IssueCustomField
211 211 ).visible.collect {|cf| QueryCustomFieldColumn.new(cf) }
212 212
213 213 if User.current.allowed_to?(:view_time_entries, project, :global => true)
214 214 index = @available_columns.find_index {|column| column.name == :total_estimated_hours}
215 215 index = (index ? index + 1 : -1)
216 216 # insert the column after total_estimated_hours or at the end
217 217 @available_columns.insert index, QueryColumn.new(:spent_hours,
218 218 :sortable => "COALESCE((SELECT SUM(hours) FROM #{TimeEntry.table_name} WHERE #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id), 0)",
219 219 :default_order => 'desc',
220 220 :caption => :label_spent_time,
221 221 :totalable => true
222 222 )
223 223 @available_columns.insert index+1, QueryColumn.new(:total_spent_hours,
224 224 :sortable => "COALESCE((SELECT SUM(hours) FROM #{TimeEntry.table_name} JOIN #{Issue.table_name} subtasks ON subtasks.id = #{TimeEntry.table_name}.issue_id" +
225 225 " WHERE subtasks.root_id = #{Issue.table_name}.root_id AND subtasks.lft >= #{Issue.table_name}.lft AND subtasks.rgt <= #{Issue.table_name}.rgt), 0)",
226 226 :default_order => 'desc',
227 227 :caption => :label_total_spent_time
228 228 )
229 229 end
230 230
231 231 if User.current.allowed_to?(:set_issues_private, nil, :global => true) ||
232 232 User.current.allowed_to?(:set_own_issues_private, nil, :global => true)
233 233 @available_columns << QueryColumn.new(:is_private, :sortable => "#{Issue.table_name}.is_private")
234 234 end
235 235
236 236 disabled_fields = Tracker.disabled_core_fields(trackers).map {|field| field.sub(/_id$/, '')}
237 237 @available_columns.reject! {|column|
238 238 disabled_fields.include?(column.name.to_s)
239 239 }
240 240
241 241 @available_columns
242 242 end
243 243
244 244 def default_columns_names
245 245 @default_columns_names ||= begin
246 246 default_columns = Setting.issue_list_default_columns.map(&:to_sym)
247 247
248 248 project.present? ? default_columns : [:project] | default_columns
249 249 end
250 250 end
251 251
252 252 def default_totalable_names
253 253 Setting.issue_list_default_totals.map(&:to_sym)
254 254 end
255 255
256 256 def base_scope
257 257 Issue.visible.joins(:status, :project).where(statement)
258 258 end
259 259
260 260 # Returns the issue count
261 261 def issue_count
262 262 base_scope.count
263 263 rescue ::ActiveRecord::StatementInvalid => e
264 264 raise StatementInvalid.new(e.message)
265 265 end
266 266
267 267 # Returns the issue count by group or nil if query is not grouped
268 268 def issue_count_by_group
269 269 grouped_query do |scope|
270 270 scope.count
271 271 end
272 272 end
273 273
274 274 # Returns sum of all the issue's estimated_hours
275 275 def total_for_estimated_hours(scope)
276 276 map_total(scope.sum(:estimated_hours)) {|t| t.to_f.round(2)}
277 277 end
278 278
279 279 # Returns sum of all the issue's time entries hours
280 280 def total_for_spent_hours(scope)
281 281 total = if group_by_column.try(:name) == :project
282 282 # TODO: remove this when https://github.com/rails/rails/issues/21922 is fixed
283 283 # We have to do a custom join without the time_entries.project_id column
284 284 # that would trigger a ambiguous column name error
285 285 scope.joins("JOIN (SELECT issue_id, hours FROM #{TimeEntry.table_name}) AS joined_time_entries ON joined_time_entries.issue_id = #{Issue.table_name}.id").
286 286 sum("joined_time_entries.hours")
287 287 else
288 288 scope.joins(:time_entries).sum("#{TimeEntry.table_name}.hours")
289 289 end
290 290 map_total(total) {|t| t.to_f.round(2)}
291 291 end
292 292
293 293 # Returns the issues
294 294 # Valid options are :order, :offset, :limit, :include, :conditions
295 295 def issues(options={})
296 296 order_option = [group_by_sort_order, options[:order]].flatten.reject(&:blank?)
297 297
298 298 scope = Issue.visible.
299 299 joins(:status, :project).
300 300 where(statement).
301 301 includes(([:status, :project] + (options[:include] || [])).uniq).
302 302 where(options[:conditions]).
303 303 order(order_option).
304 304 joins(joins_for_order_statement(order_option.join(','))).
305 305 limit(options[:limit]).
306 306 offset(options[:offset])
307 307
308 308 scope = scope.preload(:custom_values)
309 309 if has_column?(:author)
310 310 scope = scope.preload(:author)
311 311 end
312 312
313 313 issues = scope.to_a
314 314
315 315 if has_column?(:spent_hours)
316 316 Issue.load_visible_spent_hours(issues)
317 317 end
318 318 if has_column?(:total_spent_hours)
319 319 Issue.load_visible_total_spent_hours(issues)
320 320 end
321 321 if has_column?(:relations)
322 322 Issue.load_visible_relations(issues)
323 323 end
324 324 issues
325 325 rescue ::ActiveRecord::StatementInvalid => e
326 326 raise StatementInvalid.new(e.message)
327 327 end
328 328
329 329 # Returns the issues ids
330 330 def issue_ids(options={})
331 331 order_option = [group_by_sort_order, options[:order]].flatten.reject(&:blank?)
332 332
333 333 Issue.visible.
334 334 joins(:status, :project).
335 335 where(statement).
336 336 includes(([:status, :project] + (options[:include] || [])).uniq).
337 337 references(([:status, :project] + (options[:include] || [])).uniq).
338 338 where(options[:conditions]).
339 339 order(order_option).
340 340 joins(joins_for_order_statement(order_option.join(','))).
341 341 limit(options[:limit]).
342 342 offset(options[:offset]).
343 343 pluck(:id)
344 344 rescue ::ActiveRecord::StatementInvalid => e
345 345 raise StatementInvalid.new(e.message)
346 346 end
347 347
348 348 # Returns the journals
349 349 # Valid options are :order, :offset, :limit
350 350 def journals(options={})
351 351 Journal.visible.
352 352 joins(:issue => [:project, :status]).
353 353 where(statement).
354 354 order(options[:order]).
355 355 limit(options[:limit]).
356 356 offset(options[:offset]).
357 357 preload(:details, :user, {:issue => [:project, :author, :tracker, :status]}).
358 358 to_a
359 359 rescue ::ActiveRecord::StatementInvalid => e
360 360 raise StatementInvalid.new(e.message)
361 361 end
362 362
363 363 # Returns the versions
364 364 # Valid options are :conditions
365 365 def versions(options={})
366 366 Version.visible.
367 367 where(project_statement).
368 368 where(options[:conditions]).
369 369 includes(:project).
370 370 references(:project).
371 371 to_a
372 372 rescue ::ActiveRecord::StatementInvalid => e
373 373 raise StatementInvalid.new(e.message)
374 374 end
375 375
376 376 def sql_for_watcher_id_field(field, operator, value)
377 377 db_table = Watcher.table_name
378 378 "#{Issue.table_name}.id #{ operator == '=' ? 'IN' : 'NOT IN' } (SELECT #{db_table}.watchable_id FROM #{db_table} WHERE #{db_table}.watchable_type='Issue' AND " +
379 379 sql_for_field(field, '=', value, db_table, 'user_id') + ')'
380 380 end
381 381
382 382 def sql_for_member_of_group_field(field, operator, value)
383 383 if operator == '*' # Any group
384 384 groups = Group.givable
385 385 operator = '=' # Override the operator since we want to find by assigned_to
386 386 elsif operator == "!*"
387 387 groups = Group.givable
388 388 operator = '!' # Override the operator since we want to find by assigned_to
389 389 else
390 390 groups = Group.where(:id => value).to_a
391 391 end
392 392 groups ||= []
393 393
394 394 members_of_groups = groups.inject([]) {|user_ids, group|
395 395 user_ids + group.user_ids + [group.id]
396 396 }.uniq.compact.sort.collect(&:to_s)
397 397
398 398 '(' + sql_for_field("assigned_to_id", operator, members_of_groups, Issue.table_name, "assigned_to_id", false) + ')'
399 399 end
400 400
401 401 def sql_for_assigned_to_role_field(field, operator, value)
402 402 case operator
403 403 when "*", "!*" # Member / Not member
404 404 sw = operator == "!*" ? 'NOT' : ''
405 405 nl = operator == "!*" ? "#{Issue.table_name}.assigned_to_id IS NULL OR" : ''
406 406 "(#{nl} #{Issue.table_name}.assigned_to_id #{sw} IN (SELECT DISTINCT #{Member.table_name}.user_id FROM #{Member.table_name}" +
407 407 " WHERE #{Member.table_name}.project_id = #{Issue.table_name}.project_id))"
408 408 when "=", "!"
409 409 role_cond = value.any? ?
410 410 "#{MemberRole.table_name}.role_id IN (" + value.collect{|val| "'#{self.class.connection.quote_string(val)}'"}.join(",") + ")" :
411 411 "1=0"
412 412
413 413 sw = operator == "!" ? 'NOT' : ''
414 414 nl = operator == "!" ? "#{Issue.table_name}.assigned_to_id IS NULL OR" : ''
415 415 "(#{nl} #{Issue.table_name}.assigned_to_id #{sw} IN (SELECT DISTINCT #{Member.table_name}.user_id FROM #{Member.table_name}, #{MemberRole.table_name}" +
416 416 " WHERE #{Member.table_name}.project_id = #{Issue.table_name}.project_id AND #{Member.table_name}.id = #{MemberRole.table_name}.member_id AND #{role_cond}))"
417 417 end
418 418 end
419 419
420 420 def sql_for_is_private_field(field, operator, value)
421 421 op = (operator == "=" ? 'IN' : 'NOT IN')
422 422 va = value.map {|v| v == '0' ? self.class.connection.quoted_false : self.class.connection.quoted_true}.uniq.join(',')
423 423
424 424 "#{Issue.table_name}.is_private #{op} (#{va})"
425 425 end
426 426
427 427 def sql_for_parent_id_field(field, operator, value)
428 428 case operator
429 429 when "="
430 430 "#{Issue.table_name}.parent_id = #{value.first.to_i}"
431 431 when "~"
432 432 root_id, lft, rgt = Issue.where(:id => value.first.to_i).pluck(:root_id, :lft, :rgt).first
433 433 if root_id && lft && rgt
434 434 "#{Issue.table_name}.root_id = #{root_id} AND #{Issue.table_name}.lft > #{lft} AND #{Issue.table_name}.rgt < #{rgt}"
435 435 else
436 436 "1=0"
437 437 end
438 438 when "!*"
439 439 "#{Issue.table_name}.parent_id IS NULL"
440 440 when "*"
441 441 "#{Issue.table_name}.parent_id IS NOT NULL"
442 442 end
443 443 end
444 444
445 445 def sql_for_child_id_field(field, operator, value)
446 446 case operator
447 447 when "="
448 448 parent_id = Issue.where(:id => value.first.to_i).pluck(:parent_id).first
449 449 if parent_id
450 450 "#{Issue.table_name}.id = #{parent_id}"
451 451 else
452 452 "1=0"
453 453 end
454 454 when "~"
455 455 root_id, lft, rgt = Issue.where(:id => value.first.to_i).pluck(:root_id, :lft, :rgt).first
456 456 if root_id && lft && rgt
457 457 "#{Issue.table_name}.root_id = #{root_id} AND #{Issue.table_name}.lft < #{lft} AND #{Issue.table_name}.rgt > #{rgt}"
458 458 else
459 459 "1=0"
460 460 end
461 461 when "!*"
462 462 "#{Issue.table_name}.rgt - #{Issue.table_name}.lft = 1"
463 463 when "*"
464 464 "#{Issue.table_name}.rgt - #{Issue.table_name}.lft > 1"
465 465 end
466 466 end
467 467
468 468 def sql_for_issue_id_field(field, operator, value)
469 ids = value.first.to_s.scan(/\d+/).map(&:to_i).join(",")
470 if ids.present?
471 "#{Issue.table_name}.id IN (#{ids})"
469 if operator == "="
470 # accepts a comma separated list of ids
471 ids = value.first.to_s.scan(/\d+/).map(&:to_i)
472 if ids.present?
473 "#{Issue.table_name}.id IN (#{ids.join(",")})"
474 else
475 "1=0"
476 end
472 477 else
473 "1=0"
478 sql_for_field("id", operator, value, Issue.table_name, "id")
474 479 end
475 480 end
476 481
477 482 def sql_for_relations(field, operator, value, options={})
478 483 relation_options = IssueRelation::TYPES[field]
479 484 return relation_options unless relation_options
480 485
481 486 relation_type = field
482 487 join_column, target_join_column = "issue_from_id", "issue_to_id"
483 488 if relation_options[:reverse] || options[:reverse]
484 489 relation_type = relation_options[:reverse] || relation_type
485 490 join_column, target_join_column = target_join_column, join_column
486 491 end
487 492
488 493 sql = case operator
489 494 when "*", "!*"
490 495 op = (operator == "*" ? 'IN' : 'NOT IN')
491 496 "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name} WHERE #{IssueRelation.table_name}.relation_type = '#{self.class.connection.quote_string(relation_type)}')"
492 497 when "=", "!"
493 498 op = (operator == "=" ? 'IN' : 'NOT IN')
494 499 "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name} WHERE #{IssueRelation.table_name}.relation_type = '#{self.class.connection.quote_string(relation_type)}' AND #{IssueRelation.table_name}.#{target_join_column} = #{value.first.to_i})"
495 500 when "=p", "=!p", "!p"
496 501 op = (operator == "!p" ? 'NOT IN' : 'IN')
497 502 comp = (operator == "=!p" ? '<>' : '=')
498 503 "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name}, #{Issue.table_name} relissues WHERE #{IssueRelation.table_name}.relation_type = '#{self.class.connection.quote_string(relation_type)}' AND #{IssueRelation.table_name}.#{target_join_column} = relissues.id AND relissues.project_id #{comp} #{value.first.to_i})"
499 504 when "*o", "!o"
500 505 op = (operator == "!o" ? 'NOT IN' : 'IN')
501 506 "#{Issue.table_name}.id #{op} (SELECT DISTINCT #{IssueRelation.table_name}.#{join_column} FROM #{IssueRelation.table_name}, #{Issue.table_name} relissues WHERE #{IssueRelation.table_name}.relation_type = '#{self.class.connection.quote_string(relation_type)}' AND #{IssueRelation.table_name}.#{target_join_column} = relissues.id AND relissues.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{self.class.connection.quoted_false}))"
502 507 end
503 508
504 509 if relation_options[:sym] == field && !options[:reverse]
505 510 sqls = [sql, sql_for_relations(field, operator, value, :reverse => true)]
506 511 sql = sqls.join(["!", "!*", "!p"].include?(operator) ? " AND " : " OR ")
507 512 end
508 513 "(#{sql})"
509 514 end
510 515
511 516 def find_assigned_to_id_filter_values(values)
512 517 Principal.visible.where(:id => values).map {|p| [p.name, p.id.to_s]}
513 518 end
514 519 alias :find_author_id_filter_values :find_assigned_to_id_filter_values
515 520
516 521 IssueRelation::TYPES.keys.each do |relation_type|
517 522 alias_method "sql_for_#{relation_type}_field".to_sym, :sql_for_relations
518 523 end
519 524 end
@@ -1,1769 +1,1777
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2016 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 require File.expand_path('../../test_helper', __FILE__)
21 21
22 22 class QueryTest < ActiveSupport::TestCase
23 23 include Redmine::I18n
24 24
25 25 fixtures :projects, :enabled_modules, :users, :members,
26 26 :member_roles, :roles, :trackers, :issue_statuses,
27 27 :issue_categories, :enumerations, :issues,
28 28 :watchers, :custom_fields, :custom_values, :versions,
29 29 :queries,
30 30 :projects_trackers,
31 31 :custom_fields_trackers,
32 32 :workflows
33 33
34 34 def setup
35 35 User.current = nil
36 36 end
37 37
38 38 def test_query_with_roles_visibility_should_validate_roles
39 39 set_language_if_valid 'en'
40 40 query = IssueQuery.new(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES)
41 41 assert !query.save
42 42 assert_include "Roles cannot be blank", query.errors.full_messages
43 43 query.role_ids = [1, 2]
44 44 assert query.save
45 45 end
46 46
47 47 def test_changing_roles_visibility_should_clear_roles
48 48 query = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES, :role_ids => [1, 2])
49 49 assert_equal 2, query.roles.count
50 50
51 51 query.visibility = IssueQuery::VISIBILITY_PUBLIC
52 52 query.save!
53 53 assert_equal 0, query.roles.count
54 54 end
55 55
56 56 def test_available_filters_should_be_ordered
57 57 set_language_if_valid 'en'
58 58 query = IssueQuery.new
59 59 assert_equal 0, query.available_filters.keys.index('status_id')
60 60 expected_order = [
61 61 "Status",
62 62 "Project",
63 63 "Tracker",
64 64 "Priority"
65 65 ]
66 66 assert_equal expected_order,
67 67 (query.available_filters.values.map{|v| v[:name]} & expected_order)
68 68 end
69 69
70 70 def test_available_filters_with_custom_fields_should_be_ordered
71 71 set_language_if_valid 'en'
72 72 UserCustomField.create!(
73 73 :name => 'order test', :field_format => 'string',
74 74 :is_for_all => true, :is_filter => true
75 75 )
76 76 query = IssueQuery.new
77 77 expected_order = [
78 78 "Searchable field",
79 79 "Database",
80 80 "Project's Development status",
81 81 "Author's order test",
82 82 "Assignee's order test"
83 83 ]
84 84 assert_equal expected_order,
85 85 (query.available_filters.values.map{|v| v[:name]} & expected_order)
86 86 end
87 87
88 88 def test_custom_fields_for_all_projects_should_be_available_in_global_queries
89 89 query = IssueQuery.new(:project => nil, :name => '_')
90 90 assert query.available_filters.has_key?('cf_1')
91 91 assert !query.available_filters.has_key?('cf_3')
92 92 end
93 93
94 94 def test_system_shared_versions_should_be_available_in_global_queries
95 95 Version.find(2).update_attribute :sharing, 'system'
96 96 query = IssueQuery.new(:project => nil, :name => '_')
97 97 assert query.available_filters.has_key?('fixed_version_id')
98 98 assert query.available_filters['fixed_version_id'][:values].detect {|v| v[1] == '2'}
99 99 end
100 100
101 101 def test_project_filter_in_global_queries
102 102 query = IssueQuery.new(:project => nil, :name => '_')
103 103 project_filter = query.available_filters["project_id"]
104 104 assert_not_nil project_filter
105 105 project_ids = project_filter[:values].map{|p| p[1]}
106 106 assert project_ids.include?("1") #public project
107 107 assert !project_ids.include?("2") #private project user cannot see
108 108 end
109 109
110 110 def test_available_filters_should_not_include_fields_disabled_on_all_trackers
111 111 Tracker.all.each do |tracker|
112 112 tracker.core_fields = Tracker::CORE_FIELDS - ['start_date']
113 113 tracker.save!
114 114 end
115 115
116 116 query = IssueQuery.new(:name => '_')
117 117 assert_include 'due_date', query.available_filters
118 118 assert_not_include 'start_date', query.available_filters
119 119 end
120 120
121 121 def find_issues_with_query(query)
122 122 Issue.joins(:status, :tracker, :project, :priority).where(
123 123 query.statement
124 124 ).to_a
125 125 end
126 126
127 127 def assert_find_issues_with_query_is_successful(query)
128 128 assert_nothing_raised do
129 129 find_issues_with_query(query)
130 130 end
131 131 end
132 132
133 133 def assert_query_statement_includes(query, condition)
134 134 assert_include condition, query.statement
135 135 end
136 136
137 137 def assert_query_result(expected, query)
138 138 assert_nothing_raised do
139 139 assert_equal expected.map(&:id).sort, query.issues.map(&:id).sort
140 140 assert_equal expected.size, query.issue_count
141 141 end
142 142 end
143 143
144 144 def test_query_should_allow_shared_versions_for_a_project_query
145 145 subproject_version = Version.find(4)
146 146 query = IssueQuery.new(:project => Project.find(1), :name => '_')
147 147 filter = query.available_filters["fixed_version_id"]
148 148 assert_not_nil filter
149 149 assert_include subproject_version.id.to_s, filter[:values].map(&:second)
150 150 end
151 151
152 152 def test_query_with_multiple_custom_fields
153 153 query = IssueQuery.find(1)
154 154 assert query.valid?
155 155 issues = find_issues_with_query(query)
156 156 assert_equal 1, issues.length
157 157 assert_equal Issue.find(3), issues.first
158 158 end
159 159
160 160 def test_operator_none
161 161 query = IssueQuery.new(:project => Project.find(1), :name => '_')
162 162 query.add_filter('fixed_version_id', '!*', [''])
163 163 query.add_filter('cf_1', '!*', [''])
164 164 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NULL")
165 165 assert query.statement.include?("#{CustomValue.table_name}.value IS NULL OR #{CustomValue.table_name}.value = ''")
166 166 find_issues_with_query(query)
167 167 end
168 168
169 169 def test_operator_none_for_integer
170 170 query = IssueQuery.new(:project => Project.find(1), :name => '_')
171 171 query.add_filter('estimated_hours', '!*', [''])
172 172 issues = find_issues_with_query(query)
173 173 assert !issues.empty?
174 174 assert issues.all? {|i| !i.estimated_hours}
175 175 end
176 176
177 177 def test_operator_none_for_date
178 178 query = IssueQuery.new(:project => Project.find(1), :name => '_')
179 179 query.add_filter('start_date', '!*', [''])
180 180 issues = find_issues_with_query(query)
181 181 assert !issues.empty?
182 182 assert issues.all? {|i| i.start_date.nil?}
183 183 end
184 184
185 185 def test_operator_none_for_string_custom_field
186 186 CustomField.find(2).update_attribute :default_value, ""
187 187 query = IssueQuery.new(:project => Project.find(1), :name => '_')
188 188 query.add_filter('cf_2', '!*', [''])
189 189 assert query.has_filter?('cf_2')
190 190 issues = find_issues_with_query(query)
191 191 assert !issues.empty?
192 192 assert issues.all? {|i| i.custom_field_value(2).blank?}
193 193 end
194 194
195 195 def test_operator_all
196 196 query = IssueQuery.new(:project => Project.find(1), :name => '_')
197 197 query.add_filter('fixed_version_id', '*', [''])
198 198 query.add_filter('cf_1', '*', [''])
199 199 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NOT NULL")
200 200 assert query.statement.include?("#{CustomValue.table_name}.value IS NOT NULL AND #{CustomValue.table_name}.value <> ''")
201 201 find_issues_with_query(query)
202 202 end
203 203
204 204 def test_operator_all_for_date
205 205 query = IssueQuery.new(:project => Project.find(1), :name => '_')
206 206 query.add_filter('start_date', '*', [''])
207 207 issues = find_issues_with_query(query)
208 208 assert !issues.empty?
209 209 assert issues.all? {|i| i.start_date.present?}
210 210 end
211 211
212 212 def test_operator_all_for_string_custom_field
213 213 query = IssueQuery.new(:project => Project.find(1), :name => '_')
214 214 query.add_filter('cf_2', '*', [''])
215 215 assert query.has_filter?('cf_2')
216 216 issues = find_issues_with_query(query)
217 217 assert !issues.empty?
218 218 assert issues.all? {|i| i.custom_field_value(2).present?}
219 219 end
220 220
221 221 def test_numeric_filter_should_not_accept_non_numeric_values
222 222 query = IssueQuery.new(:name => '_')
223 223 query.add_filter('estimated_hours', '=', ['a'])
224 224
225 225 assert query.has_filter?('estimated_hours')
226 226 assert !query.valid?
227 227 end
228 228
229 229 def test_operator_is_on_float
230 230 Issue.where(:id => 2).update_all("estimated_hours = 171.2")
231 231 query = IssueQuery.new(:name => '_')
232 232 query.add_filter('estimated_hours', '=', ['171.20'])
233 233 issues = find_issues_with_query(query)
234 234 assert_equal 1, issues.size
235 235 assert_equal 2, issues.first.id
236 236 end
237 237
238 def test_operator_is_on_integer_should_accept_comma_separated_values
238 def test_operator_is_on_issue_id_should_accept_comma_separated_values
239 239 query = IssueQuery.new(:name => '_')
240 240 query.add_filter("issue_id", '=', ['1,3'])
241 241 issues = find_issues_with_query(query)
242 242 assert_equal 2, issues.size
243 243 assert_equal [1,3], issues.map(&:id).sort
244 244 end
245 245
246 def test_operator_between_on_issue_id_should_return_range
247 query = IssueQuery.new(:name => '_')
248 query.add_filter("issue_id", '><', ['2','3'])
249 issues = find_issues_with_query(query)
250 assert_equal 2, issues.size
251 assert_equal [2,3], issues.map(&:id).sort
252 end
253
246 254 def test_operator_is_on_integer_custom_field
247 255 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_for_all => true, :is_filter => true, :trackers => Tracker.all)
248 256 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
249 257 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12')
250 258 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
251 259
252 260 query = IssueQuery.new(:name => '_')
253 261 query.add_filter("cf_#{f.id}", '=', ['12'])
254 262 issues = find_issues_with_query(query)
255 263 assert_equal 1, issues.size
256 264 assert_equal 2, issues.first.id
257 265 end
258 266
259 267 def test_operator_is_on_integer_custom_field_should_accept_negative_value
260 268 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_for_all => true, :is_filter => true, :trackers => Tracker.all)
261 269 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
262 270 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12')
263 271 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
264 272
265 273 query = IssueQuery.new(:name => '_')
266 274 query.add_filter("cf_#{f.id}", '=', ['-12'])
267 275 assert query.valid?
268 276 issues = find_issues_with_query(query)
269 277 assert_equal 1, issues.size
270 278 assert_equal 2, issues.first.id
271 279 end
272 280
273 281 def test_operator_is_on_float_custom_field
274 282 f = IssueCustomField.create!(:name => 'filter', :field_format => 'float', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
275 283 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7.3')
276 284 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12.7')
277 285 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
278 286
279 287 query = IssueQuery.new(:name => '_')
280 288 query.add_filter("cf_#{f.id}", '=', ['12.7'])
281 289 issues = find_issues_with_query(query)
282 290 assert_equal 1, issues.size
283 291 assert_equal 2, issues.first.id
284 292 end
285 293
286 294 def test_operator_is_on_float_custom_field_should_accept_negative_value
287 295 f = IssueCustomField.create!(:name => 'filter', :field_format => 'float', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
288 296 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7.3')
289 297 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '-12.7')
290 298 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
291 299
292 300 query = IssueQuery.new(:name => '_')
293 301 query.add_filter("cf_#{f.id}", '=', ['-12.7'])
294 302 assert query.valid?
295 303 issues = find_issues_with_query(query)
296 304 assert_equal 1, issues.size
297 305 assert_equal 2, issues.first.id
298 306 end
299 307
300 308 def test_operator_is_on_multi_list_custom_field
301 309 f = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
302 310 :possible_values => ['value1', 'value2', 'value3'], :multiple => true, :trackers => Tracker.all)
303 311 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value1')
304 312 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2')
305 313 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1')
306 314
307 315 query = IssueQuery.new(:name => '_')
308 316 query.add_filter("cf_#{f.id}", '=', ['value1'])
309 317 issues = find_issues_with_query(query)
310 318 assert_equal [1, 3], issues.map(&:id).sort
311 319
312 320 query = IssueQuery.new(:name => '_')
313 321 query.add_filter("cf_#{f.id}", '=', ['value2'])
314 322 issues = find_issues_with_query(query)
315 323 assert_equal [1], issues.map(&:id).sort
316 324 end
317 325
318 326 def test_operator_is_not_on_multi_list_custom_field
319 327 f = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
320 328 :possible_values => ['value1', 'value2', 'value3'], :multiple => true, :trackers => Tracker.all)
321 329 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value1')
322 330 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'value2')
323 331 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => 'value1')
324 332
325 333 query = IssueQuery.new(:name => '_')
326 334 query.add_filter("cf_#{f.id}", '!', ['value1'])
327 335 issues = find_issues_with_query(query)
328 336 assert !issues.map(&:id).include?(1)
329 337 assert !issues.map(&:id).include?(3)
330 338
331 339 query = IssueQuery.new(:name => '_')
332 340 query.add_filter("cf_#{f.id}", '!', ['value2'])
333 341 issues = find_issues_with_query(query)
334 342 assert !issues.map(&:id).include?(1)
335 343 assert issues.map(&:id).include?(3)
336 344 end
337 345
338 346 def test_operator_is_on_string_custom_field_with_utf8_value
339 347 f = IssueCustomField.create!(:name => 'filter', :field_format => 'string', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
340 348 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => 'KiÑ»ƒm')
341 349
342 350 query = IssueQuery.new(:name => '_')
343 351 query.add_filter("cf_#{f.id}", '=', ['KiÑ»ƒm'])
344 352 issues = find_issues_with_query(query)
345 353 assert_equal [1], issues.map(&:id).sort
346 354 end
347 355
348 356 def test_operator_is_on_is_private_field
349 357 # is_private filter only available for those who can set issues private
350 358 User.current = User.find(2)
351 359
352 360 query = IssueQuery.new(:name => '_')
353 361 assert query.available_filters.key?('is_private')
354 362
355 363 query.add_filter("is_private", '=', ['1'])
356 364 issues = find_issues_with_query(query)
357 365 assert issues.any?
358 366 assert_nil issues.detect {|issue| !issue.is_private?}
359 367 ensure
360 368 User.current = nil
361 369 end
362 370
363 371 def test_operator_is_not_on_is_private_field
364 372 # is_private filter only available for those who can set issues private
365 373 User.current = User.find(2)
366 374
367 375 query = IssueQuery.new(:name => '_')
368 376 assert query.available_filters.key?('is_private')
369 377
370 378 query.add_filter("is_private", '!', ['1'])
371 379 issues = find_issues_with_query(query)
372 380 assert issues.any?
373 381 assert_nil issues.detect {|issue| issue.is_private?}
374 382 ensure
375 383 User.current = nil
376 384 end
377 385
378 386 def test_operator_greater_than
379 387 query = IssueQuery.new(:project => Project.find(1), :name => '_')
380 388 query.add_filter('done_ratio', '>=', ['40'])
381 389 assert query.statement.include?("#{Issue.table_name}.done_ratio >= 40.0")
382 390 find_issues_with_query(query)
383 391 end
384 392
385 393 def test_operator_greater_than_a_float
386 394 query = IssueQuery.new(:project => Project.find(1), :name => '_')
387 395 query.add_filter('estimated_hours', '>=', ['40.5'])
388 396 assert query.statement.include?("#{Issue.table_name}.estimated_hours >= 40.5")
389 397 find_issues_with_query(query)
390 398 end
391 399
392 400 def test_operator_greater_than_on_int_custom_field
393 401 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
394 402 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '7')
395 403 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '12')
396 404 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
397 405
398 406 query = IssueQuery.new(:project => Project.find(1), :name => '_')
399 407 query.add_filter("cf_#{f.id}", '>=', ['8'])
400 408 issues = find_issues_with_query(query)
401 409 assert_equal 1, issues.size
402 410 assert_equal 2, issues.first.id
403 411 end
404 412
405 413 def test_operator_lesser_than
406 414 query = IssueQuery.new(:project => Project.find(1), :name => '_')
407 415 query.add_filter('done_ratio', '<=', ['30'])
408 416 assert query.statement.include?("#{Issue.table_name}.done_ratio <= 30.0")
409 417 find_issues_with_query(query)
410 418 end
411 419
412 420 def test_operator_lesser_than_on_custom_field
413 421 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
414 422 query = IssueQuery.new(:project => Project.find(1), :name => '_')
415 423 query.add_filter("cf_#{f.id}", '<=', ['30'])
416 424 assert_match /CAST.+ <= 30\.0/, query.statement
417 425 find_issues_with_query(query)
418 426 end
419 427
420 428 def test_operator_lesser_than_on_date_custom_field
421 429 f = IssueCustomField.create!(:name => 'filter', :field_format => 'date', :is_filter => true, :is_for_all => true, :trackers => Tracker.all)
422 430 CustomValue.create!(:custom_field => f, :customized => Issue.find(1), :value => '2013-04-11')
423 431 CustomValue.create!(:custom_field => f, :customized => Issue.find(2), :value => '2013-05-14')
424 432 CustomValue.create!(:custom_field => f, :customized => Issue.find(3), :value => '')
425 433
426 434 query = IssueQuery.new(:project => Project.find(1), :name => '_')
427 435 query.add_filter("cf_#{f.id}", '<=', ['2013-05-01'])
428 436 issue_ids = find_issues_with_query(query).map(&:id)
429 437 assert_include 1, issue_ids
430 438 assert_not_include 2, issue_ids
431 439 assert_not_include 3, issue_ids
432 440 end
433 441
434 442 def test_operator_between
435 443 query = IssueQuery.new(:project => Project.find(1), :name => '_')
436 444 query.add_filter('done_ratio', '><', ['30', '40'])
437 445 assert_include "#{Issue.table_name}.done_ratio BETWEEN 30.0 AND 40.0", query.statement
438 446 find_issues_with_query(query)
439 447 end
440 448
441 449 def test_operator_between_on_custom_field
442 450 f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
443 451 query = IssueQuery.new(:project => Project.find(1), :name => '_')
444 452 query.add_filter("cf_#{f.id}", '><', ['30', '40'])
445 453 assert_match /CAST.+ BETWEEN 30.0 AND 40.0/, query.statement
446 454 find_issues_with_query(query)
447 455 end
448 456
449 457 def test_date_filter_should_not_accept_non_date_values
450 458 query = IssueQuery.new(:name => '_')
451 459 query.add_filter('created_on', '=', ['a'])
452 460
453 461 assert query.has_filter?('created_on')
454 462 assert !query.valid?
455 463 end
456 464
457 465 def test_date_filter_should_not_accept_invalid_date_values
458 466 query = IssueQuery.new(:name => '_')
459 467 query.add_filter('created_on', '=', ['2011-01-34'])
460 468
461 469 assert query.has_filter?('created_on')
462 470 assert !query.valid?
463 471 end
464 472
465 473 def test_relative_date_filter_should_not_accept_non_integer_values
466 474 query = IssueQuery.new(:name => '_')
467 475 query.add_filter('created_on', '>t-', ['a'])
468 476
469 477 assert query.has_filter?('created_on')
470 478 assert !query.valid?
471 479 end
472 480
473 481 def test_operator_date_equals
474 482 query = IssueQuery.new(:name => '_')
475 483 query.add_filter('due_date', '=', ['2011-07-10'])
476 484 assert_match /issues\.due_date > '#{quoted_date "2011-07-09"} 23:59:59(\.\d+)?' AND issues\.due_date <= '#{quoted_date "2011-07-10"} 23:59:59(\.\d+)?/,
477 485 query.statement
478 486 find_issues_with_query(query)
479 487 end
480 488
481 489 def test_operator_date_lesser_than
482 490 query = IssueQuery.new(:name => '_')
483 491 query.add_filter('due_date', '<=', ['2011-07-10'])
484 492 assert_match /issues\.due_date <= '#{quoted_date "2011-07-10"} 23:59:59(\.\d+)?/, query.statement
485 493 find_issues_with_query(query)
486 494 end
487 495
488 496 def test_operator_date_lesser_than_with_timestamp
489 497 query = IssueQuery.new(:name => '_')
490 498 query.add_filter('updated_on', '<=', ['2011-07-10T19:13:52'])
491 499 assert_match /issues\.updated_on <= '#{quoted_date "2011-07-10"} 19:13:52/, query.statement
492 500 find_issues_with_query(query)
493 501 end
494 502
495 503 def test_operator_date_greater_than
496 504 query = IssueQuery.new(:name => '_')
497 505 query.add_filter('due_date', '>=', ['2011-07-10'])
498 506 assert_match /issues\.due_date > '#{quoted_date "2011-07-09"} 23:59:59(\.\d+)?'/, query.statement
499 507 find_issues_with_query(query)
500 508 end
501 509
502 510 def test_operator_date_greater_than_with_timestamp
503 511 query = IssueQuery.new(:name => '_')
504 512 query.add_filter('updated_on', '>=', ['2011-07-10T19:13:52'])
505 513 assert_match /issues\.updated_on > '#{quoted_date "2011-07-10"} 19:13:51(\.0+)?'/, query.statement
506 514 find_issues_with_query(query)
507 515 end
508 516
509 517 def test_operator_date_between
510 518 query = IssueQuery.new(:name => '_')
511 519 query.add_filter('due_date', '><', ['2011-06-23', '2011-07-10'])
512 520 assert_match /issues\.due_date > '#{quoted_date "2011-06-22"} 23:59:59(\.\d+)?' AND issues\.due_date <= '#{quoted_date "2011-07-10"} 23:59:59(\.\d+)?'/,
513 521 query.statement
514 522 find_issues_with_query(query)
515 523 end
516 524
517 525 def test_operator_in_more_than
518 526 Issue.find(7).update_attribute(:due_date, (Date.today + 15))
519 527 query = IssueQuery.new(:project => Project.find(1), :name => '_')
520 528 query.add_filter('due_date', '>t+', ['15'])
521 529 issues = find_issues_with_query(query)
522 530 assert !issues.empty?
523 531 issues.each {|issue| assert(issue.due_date >= (Date.today + 15))}
524 532 end
525 533
526 534 def test_operator_in_less_than
527 535 query = IssueQuery.new(:project => Project.find(1), :name => '_')
528 536 query.add_filter('due_date', '<t+', ['15'])
529 537 issues = find_issues_with_query(query)
530 538 assert !issues.empty?
531 539 issues.each {|issue| assert(issue.due_date <= (Date.today + 15))}
532 540 end
533 541
534 542 def test_operator_in_the_next_days
535 543 query = IssueQuery.new(:project => Project.find(1), :name => '_')
536 544 query.add_filter('due_date', '><t+', ['15'])
537 545 issues = find_issues_with_query(query)
538 546 assert !issues.empty?
539 547 issues.each {|issue| assert(issue.due_date >= Date.today && issue.due_date <= (Date.today + 15))}
540 548 end
541 549
542 550 def test_operator_less_than_ago
543 551 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
544 552 query = IssueQuery.new(:project => Project.find(1), :name => '_')
545 553 query.add_filter('due_date', '>t-', ['3'])
546 554 issues = find_issues_with_query(query)
547 555 assert !issues.empty?
548 556 issues.each {|issue| assert(issue.due_date >= (Date.today - 3))}
549 557 end
550 558
551 559 def test_operator_in_the_past_days
552 560 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
553 561 query = IssueQuery.new(:project => Project.find(1), :name => '_')
554 562 query.add_filter('due_date', '><t-', ['3'])
555 563 issues = find_issues_with_query(query)
556 564 assert !issues.empty?
557 565 issues.each {|issue| assert(issue.due_date >= (Date.today - 3) && issue.due_date <= Date.today)}
558 566 end
559 567
560 568 def test_operator_more_than_ago
561 569 Issue.find(7).update_attribute(:due_date, (Date.today - 10))
562 570 query = IssueQuery.new(:project => Project.find(1), :name => '_')
563 571 query.add_filter('due_date', '<t-', ['10'])
564 572 assert query.statement.include?("#{Issue.table_name}.due_date <=")
565 573 issues = find_issues_with_query(query)
566 574 assert !issues.empty?
567 575 issues.each {|issue| assert(issue.due_date <= (Date.today - 10))}
568 576 end
569 577
570 578 def test_operator_in
571 579 Issue.find(7).update_attribute(:due_date, (Date.today + 2))
572 580 query = IssueQuery.new(:project => Project.find(1), :name => '_')
573 581 query.add_filter('due_date', 't+', ['2'])
574 582 issues = find_issues_with_query(query)
575 583 assert !issues.empty?
576 584 issues.each {|issue| assert_equal((Date.today + 2), issue.due_date)}
577 585 end
578 586
579 587 def test_operator_ago
580 588 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
581 589 query = IssueQuery.new(:project => Project.find(1), :name => '_')
582 590 query.add_filter('due_date', 't-', ['3'])
583 591 issues = find_issues_with_query(query)
584 592 assert !issues.empty?
585 593 issues.each {|issue| assert_equal((Date.today - 3), issue.due_date)}
586 594 end
587 595
588 596 def test_operator_today
589 597 query = IssueQuery.new(:project => Project.find(1), :name => '_')
590 598 query.add_filter('due_date', 't', [''])
591 599 issues = find_issues_with_query(query)
592 600 assert !issues.empty?
593 601 issues.each {|issue| assert_equal Date.today, issue.due_date}
594 602 end
595 603
596 604 def test_operator_date_periods
597 605 %w(t ld w lw l2w m lm y).each do |operator|
598 606 query = IssueQuery.new(:name => '_')
599 607 query.add_filter('due_date', operator, [''])
600 608 assert query.valid?
601 609 assert query.issues
602 610 end
603 611 end
604 612
605 613 def test_operator_datetime_periods
606 614 %w(t ld w lw l2w m lm y).each do |operator|
607 615 query = IssueQuery.new(:name => '_')
608 616 query.add_filter('created_on', operator, [''])
609 617 assert query.valid?
610 618 assert query.issues
611 619 end
612 620 end
613 621
614 622 def test_operator_contains
615 623 issue = Issue.generate!(:subject => 'AbCdEfG')
616 624
617 625 query = IssueQuery.new(:name => '_')
618 626 query.add_filter('subject', '~', ['cdeF'])
619 627 result = find_issues_with_query(query)
620 628 assert_include issue, result
621 629 result.each {|issue| assert issue.subject.downcase.include?('cdef') }
622 630 end
623 631
624 632 def test_operator_contains_with_utf8_string
625 633 issue = Issue.generate!(:subject => 'Subject contains Kiểm')
626 634
627 635 query = IssueQuery.new(:name => '_')
628 636 query.add_filter('subject', '~', ['Kiểm'])
629 637 result = find_issues_with_query(query)
630 638 assert_include issue, result
631 639 assert_equal 1, result.size
632 640 end
633 641
634 642 def test_operator_does_not_contain
635 643 issue = Issue.generate!(:subject => 'AbCdEfG')
636 644
637 645 query = IssueQuery.new(:name => '_')
638 646 query.add_filter('subject', '!~', ['cdeF'])
639 647 result = find_issues_with_query(query)
640 648 assert_not_include issue, result
641 649 end
642 650
643 651 def test_range_for_this_week_with_week_starting_on_monday
644 652 I18n.locale = :fr
645 653 assert_equal '1', I18n.t(:general_first_day_of_week)
646 654
647 655 Date.stubs(:today).returns(Date.parse('2011-04-29'))
648 656
649 657 query = IssueQuery.new(:project => Project.find(1), :name => '_')
650 658 query.add_filter('due_date', 'w', [''])
651 659 assert_match /issues\.due_date > '#{quoted_date "2011-04-24"} 23:59:59(\.\d+)?' AND issues\.due_date <= '#{quoted_date "2011-05-01"} 23:59:59(\.\d+)?/,
652 660 query.statement
653 661 I18n.locale = :en
654 662 end
655 663
656 664 def test_range_for_this_week_with_week_starting_on_sunday
657 665 I18n.locale = :en
658 666 assert_equal '7', I18n.t(:general_first_day_of_week)
659 667
660 668 Date.stubs(:today).returns(Date.parse('2011-04-29'))
661 669
662 670 query = IssueQuery.new(:project => Project.find(1), :name => '_')
663 671 query.add_filter('due_date', 'w', [''])
664 672 assert_match /issues\.due_date > '#{quoted_date "2011-04-23"} 23:59:59(\.\d+)?' AND issues\.due_date <= '#{quoted_date "2011-04-30"} 23:59:59(\.\d+)?/,
665 673 query.statement
666 674 end
667 675
668 676 def test_filter_assigned_to_me
669 677 user = User.find(2)
670 678 group = Group.find(10)
671 679 User.current = user
672 680 i1 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => user)
673 681 i2 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => group)
674 682 i3 = Issue.generate!(:project_id => 1, :tracker_id => 1, :assigned_to => Group.find(11))
675 683 group.users << user
676 684
677 685 query = IssueQuery.new(:name => '_', :filters => { 'assigned_to_id' => {:operator => '=', :values => ['me']}})
678 686 result = query.issues
679 687 assert_equal Issue.visible.where(:assigned_to_id => ([2] + user.reload.group_ids)).sort_by(&:id), result.sort_by(&:id)
680 688
681 689 assert result.include?(i1)
682 690 assert result.include?(i2)
683 691 assert !result.include?(i3)
684 692 end
685 693
686 694 def test_user_custom_field_filtered_on_me
687 695 User.current = User.find(2)
688 696 cf = IssueCustomField.create!(:field_format => 'user', :is_for_all => true, :is_filter => true, :name => 'User custom field', :tracker_ids => [1])
689 697 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '2'}, :subject => 'Test', :author_id => 1)
690 698 issue2 = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {cf.id.to_s => '3'})
691 699
692 700 query = IssueQuery.new(:name => '_', :project => Project.find(1))
693 701 filter = query.available_filters["cf_#{cf.id}"]
694 702 assert_not_nil filter
695 703 assert_include 'me', filter[:values].map{|v| v[1]}
696 704
697 705 query.filters = { "cf_#{cf.id}" => {:operator => '=', :values => ['me']}}
698 706 result = query.issues
699 707 assert_equal 1, result.size
700 708 assert_equal issue1, result.first
701 709 end
702 710
703 711 def test_filter_on_me_by_anonymous_user
704 712 User.current = nil
705 713 query = IssueQuery.new(:name => '_', :filters => { 'assigned_to_id' => {:operator => '=', :values => ['me']}})
706 714 assert_equal [], query.issues
707 715 end
708 716
709 717 def test_filter_my_projects
710 718 User.current = User.find(2)
711 719 query = IssueQuery.new(:name => '_')
712 720 filter = query.available_filters['project_id']
713 721 assert_not_nil filter
714 722 assert_include 'mine', filter[:values].map{|v| v[1]}
715 723
716 724 query.filters = { 'project_id' => {:operator => '=', :values => ['mine']}}
717 725 result = query.issues
718 726 assert_nil result.detect {|issue| !User.current.member_of?(issue.project)}
719 727 end
720 728
721 729 def test_filter_watched_issues
722 730 User.current = User.find(1)
723 731 query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '=', :values => ['me']}})
724 732 result = find_issues_with_query(query)
725 733 assert_not_nil result
726 734 assert !result.empty?
727 735 assert_equal Issue.visible.watched_by(User.current).sort_by(&:id), result.sort_by(&:id)
728 736 User.current = nil
729 737 end
730 738
731 739 def test_filter_unwatched_issues
732 740 User.current = User.find(1)
733 741 query = IssueQuery.new(:name => '_', :filters => { 'watcher_id' => {:operator => '!', :values => ['me']}})
734 742 result = find_issues_with_query(query)
735 743 assert_not_nil result
736 744 assert !result.empty?
737 745 assert_equal((Issue.visible - Issue.watched_by(User.current)).sort_by(&:id).size, result.sort_by(&:id).size)
738 746 User.current = nil
739 747 end
740 748
741 749 def test_filter_on_custom_field_should_ignore_projects_with_field_disabled
742 750 field = IssueCustomField.generate!(:trackers => Tracker.all, :project_ids => [1, 3, 4], :is_for_all => false, :is_filter => true)
743 751 Issue.generate!(:project_id => 3, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
744 752 Issue.generate!(:project_id => 4, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
745 753
746 754 query = IssueQuery.new(:name => '_', :project => Project.find(1))
747 755 query.filters = {"cf_#{field.id}" => {:operator => '=', :values => ['Foo']}}
748 756 assert_equal 2, find_issues_with_query(query).size
749 757
750 758 field.project_ids = [1, 3] # Disable the field for project 4
751 759 field.save!
752 760 assert_equal 1, find_issues_with_query(query).size
753 761 end
754 762
755 763 def test_filter_on_custom_field_should_ignore_trackers_with_field_disabled
756 764 field = IssueCustomField.generate!(:tracker_ids => [1, 2], :is_for_all => true, :is_filter => true)
757 765 Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id.to_s => 'Foo'})
758 766 Issue.generate!(:project_id => 1, :tracker_id => 2, :custom_field_values => {field.id.to_s => 'Foo'})
759 767
760 768 query = IssueQuery.new(:name => '_', :project => Project.find(1))
761 769 query.filters = {"cf_#{field.id}" => {:operator => '=', :values => ['Foo']}}
762 770 assert_equal 2, find_issues_with_query(query).size
763 771
764 772 field.tracker_ids = [1] # Disable the field for tracker 2
765 773 field.save!
766 774 assert_equal 1, find_issues_with_query(query).size
767 775 end
768 776
769 777 def test_filter_on_project_custom_field
770 778 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
771 779 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
772 780 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
773 781
774 782 query = IssueQuery.new(:name => '_')
775 783 filter_name = "project.cf_#{field.id}"
776 784 assert_include filter_name, query.available_filters.keys
777 785 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
778 786 assert_equal [3, 5], find_issues_with_query(query).map(&:project_id).uniq.sort
779 787 end
780 788
781 789 def test_filter_on_author_custom_field
782 790 field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
783 791 CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo')
784 792
785 793 query = IssueQuery.new(:name => '_')
786 794 filter_name = "author.cf_#{field.id}"
787 795 assert_include filter_name, query.available_filters.keys
788 796 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
789 797 assert_equal [3], find_issues_with_query(query).map(&:author_id).uniq.sort
790 798 end
791 799
792 800 def test_filter_on_assigned_to_custom_field
793 801 field = UserCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
794 802 CustomValue.create!(:custom_field => field, :customized => User.find(3), :value => 'Foo')
795 803
796 804 query = IssueQuery.new(:name => '_')
797 805 filter_name = "assigned_to.cf_#{field.id}"
798 806 assert_include filter_name, query.available_filters.keys
799 807 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
800 808 assert_equal [3], find_issues_with_query(query).map(&:assigned_to_id).uniq.sort
801 809 end
802 810
803 811 def test_filter_on_fixed_version_custom_field
804 812 field = VersionCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
805 813 CustomValue.create!(:custom_field => field, :customized => Version.find(2), :value => 'Foo')
806 814
807 815 query = IssueQuery.new(:name => '_')
808 816 filter_name = "fixed_version.cf_#{field.id}"
809 817 assert_include filter_name, query.available_filters.keys
810 818 query.filters = {filter_name => {:operator => '=', :values => ['Foo']}}
811 819 assert_equal [2], find_issues_with_query(query).map(&:fixed_version_id).uniq.sort
812 820 end
813 821
814 822 def test_filter_on_relations_with_a_specific_issue
815 823 IssueRelation.delete_all
816 824 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
817 825 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
818 826
819 827 query = IssueQuery.new(:name => '_')
820 828 query.filters = {"relates" => {:operator => '=', :values => ['1']}}
821 829 assert_equal [2, 3], find_issues_with_query(query).map(&:id).sort
822 830
823 831 query = IssueQuery.new(:name => '_')
824 832 query.filters = {"relates" => {:operator => '=', :values => ['2']}}
825 833 assert_equal [1], find_issues_with_query(query).map(&:id).sort
826 834 end
827 835
828 836 def test_filter_on_relations_with_any_issues_in_a_project
829 837 IssueRelation.delete_all
830 838 with_settings :cross_project_issue_relations => '1' do
831 839 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
832 840 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(2).issues.first)
833 841 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first)
834 842 end
835 843
836 844 query = IssueQuery.new(:name => '_')
837 845 query.filters = {"relates" => {:operator => '=p', :values => ['2']}}
838 846 assert_equal [1, 2], find_issues_with_query(query).map(&:id).sort
839 847
840 848 query = IssueQuery.new(:name => '_')
841 849 query.filters = {"relates" => {:operator => '=p', :values => ['3']}}
842 850 assert_equal [1], find_issues_with_query(query).map(&:id).sort
843 851
844 852 query = IssueQuery.new(:name => '_')
845 853 query.filters = {"relates" => {:operator => '=p', :values => ['4']}}
846 854 assert_equal [], find_issues_with_query(query).map(&:id).sort
847 855 end
848 856
849 857 def test_filter_on_relations_with_any_issues_not_in_a_project
850 858 IssueRelation.delete_all
851 859 with_settings :cross_project_issue_relations => '1' do
852 860 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
853 861 #IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(1).issues.first)
854 862 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(3).issues.first)
855 863 end
856 864
857 865 query = IssueQuery.new(:name => '_')
858 866 query.filters = {"relates" => {:operator => '=!p', :values => ['1']}}
859 867 assert_equal [1], find_issues_with_query(query).map(&:id).sort
860 868 end
861 869
862 870 def test_filter_on_relations_with_no_issues_in_a_project
863 871 IssueRelation.delete_all
864 872 with_settings :cross_project_issue_relations => '1' do
865 873 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Project.find(2).issues.first)
866 874 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(2), :issue_to => Project.find(3).issues.first)
867 875 IssueRelation.create!(:relation_type => "relates", :issue_to => Project.find(2).issues.first, :issue_from => Issue.find(3))
868 876 end
869 877
870 878 query = IssueQuery.new(:name => '_')
871 879 query.filters = {"relates" => {:operator => '!p', :values => ['2']}}
872 880 ids = find_issues_with_query(query).map(&:id).sort
873 881 assert_include 2, ids
874 882 assert_not_include 1, ids
875 883 assert_not_include 3, ids
876 884 end
877 885
878 886 def test_filter_on_relations_with_any_open_issues
879 887 IssueRelation.delete_all
880 888 # Issue 1 is blocked by 8, which is closed
881 889 IssueRelation.create!(:relation_type => "blocked", :issue_from => Issue.find(1), :issue_to => Issue.find(8))
882 890 # Issue 2 is blocked by 3, which is open
883 891 IssueRelation.create!(:relation_type => "blocked", :issue_from => Issue.find(2), :issue_to => Issue.find(3))
884 892
885 893 query = IssueQuery.new(:name => '_')
886 894 query.filters = {"blocked" => {:operator => "*o", :values => ['']}}
887 895 ids = find_issues_with_query(query).map(&:id)
888 896 assert_equal [], ids & [1]
889 897 assert_include 2, ids
890 898 end
891 899
892 900 def test_filter_on_relations_with_no_open_issues
893 901 IssueRelation.delete_all
894 902 # Issue 1 is blocked by 8, which is closed
895 903 IssueRelation.create!(:relation_type => "blocked", :issue_from => Issue.find(1), :issue_to => Issue.find(8))
896 904 # Issue 2 is blocked by 3, which is open
897 905 IssueRelation.create!(:relation_type => "blocked", :issue_from => Issue.find(2), :issue_to => Issue.find(3))
898 906
899 907 query = IssueQuery.new(:name => '_')
900 908 query.filters = {"blocked" => {:operator => "!o", :values => ['']}}
901 909 ids = find_issues_with_query(query).map(&:id)
902 910 assert_equal [], ids & [2]
903 911 assert_include 1, ids
904 912 end
905 913
906 914 def test_filter_on_relations_with_no_issues
907 915 IssueRelation.delete_all
908 916 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
909 917 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
910 918
911 919 query = IssueQuery.new(:name => '_')
912 920 query.filters = {"relates" => {:operator => '!*', :values => ['']}}
913 921 ids = find_issues_with_query(query).map(&:id)
914 922 assert_equal [], ids & [1, 2, 3]
915 923 assert_include 4, ids
916 924 end
917 925
918 926 def test_filter_on_relations_with_any_issues
919 927 IssueRelation.delete_all
920 928 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2))
921 929 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(3), :issue_to => Issue.find(1))
922 930
923 931 query = IssueQuery.new(:name => '_')
924 932 query.filters = {"relates" => {:operator => '*', :values => ['']}}
925 933 assert_equal [1, 2, 3], find_issues_with_query(query).map(&:id).sort
926 934 end
927 935
928 936 def test_filter_on_relations_should_not_ignore_other_filter
929 937 issue = Issue.generate!
930 938 issue1 = Issue.generate!(:status_id => 1)
931 939 issue2 = Issue.generate!(:status_id => 2)
932 940 IssueRelation.create!(:relation_type => "relates", :issue_from => issue, :issue_to => issue1)
933 941 IssueRelation.create!(:relation_type => "relates", :issue_from => issue, :issue_to => issue2)
934 942
935 943 query = IssueQuery.new(:name => '_')
936 944 query.filters = {
937 945 "status_id" => {:operator => '=', :values => ['1']},
938 946 "relates" => {:operator => '=', :values => [issue.id.to_s]}
939 947 }
940 948 assert_equal [issue1], find_issues_with_query(query)
941 949 end
942 950
943 951 def test_filter_on_parent
944 952 Issue.delete_all
945 953 parent = Issue.generate_with_descendants!
946 954
947 955
948 956 query = IssueQuery.new(:name => '_')
949 957 query.filters = {"parent_id" => {:operator => '=', :values => [parent.id.to_s]}}
950 958 assert_equal parent.children.map(&:id).sort, find_issues_with_query(query).map(&:id).sort
951 959
952 960 query.filters = {"parent_id" => {:operator => '~', :values => [parent.id.to_s]}}
953 961 assert_equal parent.descendants.map(&:id).sort, find_issues_with_query(query).map(&:id).sort
954 962
955 963 query.filters = {"parent_id" => {:operator => '*', :values => ['']}}
956 964 assert_equal parent.descendants.map(&:id).sort, find_issues_with_query(query).map(&:id).sort
957 965
958 966 query.filters = {"parent_id" => {:operator => '!*', :values => ['']}}
959 967 assert_equal [parent.id], find_issues_with_query(query).map(&:id).sort
960 968 end
961 969
962 970 def test_filter_on_invalid_parent_should_return_no_results
963 971 query = IssueQuery.new(:name => '_')
964 972 query.filters = {"parent_id" => {:operator => '=', :values => '99999999999'}}
965 973 assert_equal [], find_issues_with_query(query).map(&:id).sort
966 974
967 975 query.filters = {"parent_id" => {:operator => '~', :values => '99999999999'}}
968 976 assert_equal [], find_issues_with_query(query)
969 977 end
970 978
971 979 def test_filter_on_child
972 980 Issue.delete_all
973 981 parent = Issue.generate_with_descendants!
974 982 child, leaf = parent.children.sort_by(&:id)
975 983 grandchild = child.children.first
976 984
977 985
978 986 query = IssueQuery.new(:name => '_')
979 987 query.filters = {"child_id" => {:operator => '=', :values => [grandchild.id.to_s]}}
980 988 assert_equal [child.id], find_issues_with_query(query).map(&:id).sort
981 989
982 990 query.filters = {"child_id" => {:operator => '~', :values => [grandchild.id.to_s]}}
983 991 assert_equal [parent, child].map(&:id).sort, find_issues_with_query(query).map(&:id).sort
984 992
985 993 query.filters = {"child_id" => {:operator => '*', :values => ['']}}
986 994 assert_equal [parent, child].map(&:id).sort, find_issues_with_query(query).map(&:id).sort
987 995
988 996 query.filters = {"child_id" => {:operator => '!*', :values => ['']}}
989 997 assert_equal [grandchild, leaf].map(&:id).sort, find_issues_with_query(query).map(&:id).sort
990 998 end
991 999
992 1000 def test_filter_on_invalid_child_should_return_no_results
993 1001 query = IssueQuery.new(:name => '_')
994 1002 query.filters = {"child_id" => {:operator => '=', :values => '99999999999'}}
995 1003 assert_equal [], find_issues_with_query(query)
996 1004
997 1005 query.filters = {"child_id" => {:operator => '~', :values => '99999999999'}}
998 1006 assert_equal [].map(&:id).sort, find_issues_with_query(query)
999 1007 end
1000 1008
1001 1009 def test_statement_should_be_nil_with_no_filters
1002 1010 q = IssueQuery.new(:name => '_')
1003 1011 q.filters = {}
1004 1012
1005 1013 assert q.valid?
1006 1014 assert_nil q.statement
1007 1015 end
1008 1016
1009 1017 def test_available_filters_as_json_should_include_missing_assigned_to_id_values
1010 1018 user = User.generate!
1011 1019 with_current_user User.find(1) do
1012 1020 q = IssueQuery.new
1013 1021 q.filters = {"assigned_to_id" => {:operator => '=', :values => user.id.to_s}}
1014 1022
1015 1023 filters = q.available_filters_as_json
1016 1024 assert_include [user.name, user.id.to_s], filters['assigned_to_id']['values']
1017 1025 end
1018 1026 end
1019 1027
1020 1028 def test_available_filters_as_json_should_include_missing_author_id_values
1021 1029 user = User.generate!
1022 1030 with_current_user User.find(1) do
1023 1031 q = IssueQuery.new
1024 1032 q.filters = {"author_id" => {:operator => '=', :values => user.id.to_s}}
1025 1033
1026 1034 filters = q.available_filters_as_json
1027 1035 assert_include [user.name, user.id.to_s], filters['author_id']['values']
1028 1036 end
1029 1037 end
1030 1038
1031 1039 def test_default_columns
1032 1040 q = IssueQuery.new
1033 1041 assert q.columns.any?
1034 1042 assert q.inline_columns.any?
1035 1043 assert q.block_columns.empty?
1036 1044 end
1037 1045
1038 1046 def test_set_column_names
1039 1047 q = IssueQuery.new
1040 1048 q.column_names = ['tracker', :subject, '', 'unknonw_column']
1041 1049 assert_equal [:id, :tracker, :subject], q.columns.collect {|c| c.name}
1042 1050 end
1043 1051
1044 1052 def test_has_column_should_accept_a_column_name
1045 1053 q = IssueQuery.new
1046 1054 q.column_names = ['tracker', :subject]
1047 1055 assert q.has_column?(:tracker)
1048 1056 assert !q.has_column?(:category)
1049 1057 end
1050 1058
1051 1059 def test_has_column_should_accept_a_column
1052 1060 q = IssueQuery.new
1053 1061 q.column_names = ['tracker', :subject]
1054 1062
1055 1063 tracker_column = q.available_columns.detect {|c| c.name==:tracker}
1056 1064 assert_kind_of QueryColumn, tracker_column
1057 1065 category_column = q.available_columns.detect {|c| c.name==:category}
1058 1066 assert_kind_of QueryColumn, category_column
1059 1067
1060 1068 assert q.has_column?(tracker_column)
1061 1069 assert !q.has_column?(category_column)
1062 1070 end
1063 1071
1064 1072 def test_inline_and_block_columns
1065 1073 q = IssueQuery.new
1066 1074 q.column_names = ['subject', 'description', 'tracker']
1067 1075
1068 1076 assert_equal [:id, :subject, :tracker], q.inline_columns.map(&:name)
1069 1077 assert_equal [:description], q.block_columns.map(&:name)
1070 1078 end
1071 1079
1072 1080 def test_custom_field_columns_should_be_inline
1073 1081 q = IssueQuery.new
1074 1082 columns = q.available_columns.select {|column| column.is_a? QueryCustomFieldColumn}
1075 1083 assert columns.any?
1076 1084 assert_nil columns.detect {|column| !column.inline?}
1077 1085 end
1078 1086
1079 1087 def test_query_should_preload_spent_hours
1080 1088 q = IssueQuery.new(:name => '_', :column_names => [:subject, :spent_hours])
1081 1089 assert q.has_column?(:spent_hours)
1082 1090 issues = q.issues
1083 1091 assert_not_nil issues.first.instance_variable_get("@spent_hours")
1084 1092 end
1085 1093
1086 1094 def test_groupable_columns_should_include_custom_fields
1087 1095 q = IssueQuery.new
1088 1096 column = q.groupable_columns.detect {|c| c.name == :cf_1}
1089 1097 assert_not_nil column
1090 1098 assert_kind_of QueryCustomFieldColumn, column
1091 1099 end
1092 1100
1093 1101 def test_groupable_columns_should_not_include_multi_custom_fields
1094 1102 field = CustomField.find(1)
1095 1103 field.update_attribute :multiple, true
1096 1104
1097 1105 q = IssueQuery.new
1098 1106 column = q.groupable_columns.detect {|c| c.name == :cf_1}
1099 1107 assert_nil column
1100 1108 end
1101 1109
1102 1110 def test_groupable_columns_should_include_user_custom_fields
1103 1111 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'user')
1104 1112
1105 1113 q = IssueQuery.new
1106 1114 assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym}
1107 1115 end
1108 1116
1109 1117 def test_groupable_columns_should_include_version_custom_fields
1110 1118 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1], :field_format => 'version')
1111 1119
1112 1120 q = IssueQuery.new
1113 1121 assert q.groupable_columns.detect {|c| c.name == "cf_#{cf.id}".to_sym}
1114 1122 end
1115 1123
1116 1124 def test_grouped_with_valid_column
1117 1125 q = IssueQuery.new(:group_by => 'status')
1118 1126 assert q.grouped?
1119 1127 assert_not_nil q.group_by_column
1120 1128 assert_equal :status, q.group_by_column.name
1121 1129 assert_not_nil q.group_by_statement
1122 1130 assert_equal 'status', q.group_by_statement
1123 1131 end
1124 1132
1125 1133 def test_grouped_with_invalid_column
1126 1134 q = IssueQuery.new(:group_by => 'foo')
1127 1135 assert !q.grouped?
1128 1136 assert_nil q.group_by_column
1129 1137 assert_nil q.group_by_statement
1130 1138 end
1131 1139
1132 1140 def test_sortable_columns_should_sort_assignees_according_to_user_format_setting
1133 1141 with_settings :user_format => 'lastname_comma_firstname' do
1134 1142 q = IssueQuery.new
1135 1143 assert q.sortable_columns.has_key?('assigned_to')
1136 1144 assert_equal %w(users.lastname users.firstname users.id), q.sortable_columns['assigned_to']
1137 1145 end
1138 1146 end
1139 1147
1140 1148 def test_sortable_columns_should_sort_authors_according_to_user_format_setting
1141 1149 with_settings :user_format => 'lastname_comma_firstname' do
1142 1150 q = IssueQuery.new
1143 1151 assert q.sortable_columns.has_key?('author')
1144 1152 assert_equal %w(authors.lastname authors.firstname authors.id), q.sortable_columns['author']
1145 1153 end
1146 1154 end
1147 1155
1148 1156 def test_sortable_columns_should_include_custom_field
1149 1157 q = IssueQuery.new
1150 1158 assert q.sortable_columns['cf_1']
1151 1159 end
1152 1160
1153 1161 def test_sortable_columns_should_not_include_multi_custom_field
1154 1162 field = CustomField.find(1)
1155 1163 field.update_attribute :multiple, true
1156 1164
1157 1165 q = IssueQuery.new
1158 1166 assert !q.sortable_columns['cf_1']
1159 1167 end
1160 1168
1161 1169 def test_default_sort
1162 1170 q = IssueQuery.new
1163 1171 assert_equal [], q.sort_criteria
1164 1172 end
1165 1173
1166 1174 def test_set_sort_criteria_with_hash
1167 1175 q = IssueQuery.new
1168 1176 q.sort_criteria = {'0' => ['priority', 'desc'], '2' => ['tracker']}
1169 1177 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
1170 1178 end
1171 1179
1172 1180 def test_set_sort_criteria_with_array
1173 1181 q = IssueQuery.new
1174 1182 q.sort_criteria = [['priority', 'desc'], 'tracker']
1175 1183 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
1176 1184 end
1177 1185
1178 1186 def test_create_query_with_sort
1179 1187 q = IssueQuery.new(:name => 'Sorted')
1180 1188 q.sort_criteria = [['priority', 'desc'], 'tracker']
1181 1189 assert q.save
1182 1190 q.reload
1183 1191 assert_equal [['priority', 'desc'], ['tracker', 'asc']], q.sort_criteria
1184 1192 end
1185 1193
1186 1194 def test_sort_by_string_custom_field_asc
1187 1195 q = IssueQuery.new
1188 1196 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' }
1189 1197 assert c
1190 1198 assert c.sortable
1191 1199 issues = q.issues(:order => "#{c.sortable} ASC")
1192 1200 values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s}
1193 1201 assert !values.empty?
1194 1202 assert_equal values.sort, values
1195 1203 end
1196 1204
1197 1205 def test_sort_by_string_custom_field_desc
1198 1206 q = IssueQuery.new
1199 1207 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'string' }
1200 1208 assert c
1201 1209 assert c.sortable
1202 1210 issues = q.issues(:order => "#{c.sortable} DESC")
1203 1211 values = issues.collect {|i| i.custom_value_for(c.custom_field).to_s}
1204 1212 assert !values.empty?
1205 1213 assert_equal values.sort.reverse, values
1206 1214 end
1207 1215
1208 1216 def test_sort_by_float_custom_field_asc
1209 1217 q = IssueQuery.new
1210 1218 c = q.available_columns.find {|col| col.is_a?(QueryCustomFieldColumn) && col.custom_field.field_format == 'float' }
1211 1219 assert c
1212 1220 assert c.sortable
1213 1221 issues = q.issues(:order => "#{c.sortable} ASC")
1214 1222 values = issues.collect {|i| begin; Kernel.Float(i.custom_value_for(c.custom_field).to_s); rescue; nil; end}.compact
1215 1223 assert !values.empty?
1216 1224 assert_equal values.sort, values
1217 1225 end
1218 1226
1219 1227 def test_set_totalable_names
1220 1228 q = IssueQuery.new
1221 1229 q.totalable_names = ['estimated_hours', :spent_hours, '']
1222 1230 assert_equal [:estimated_hours, :spent_hours], q.totalable_columns.map(&:name)
1223 1231 end
1224 1232
1225 1233 def test_totalable_columns_should_default_to_settings
1226 1234 with_settings :issue_list_default_totals => ['estimated_hours'] do
1227 1235 q = IssueQuery.new
1228 1236 assert_equal [:estimated_hours], q.totalable_columns.map(&:name)
1229 1237 end
1230 1238 end
1231 1239
1232 1240 def test_available_totalable_columns_should_include_estimated_hours
1233 1241 q = IssueQuery.new
1234 1242 assert_include :estimated_hours, q.available_totalable_columns.map(&:name)
1235 1243 end
1236 1244
1237 1245 def test_available_totalable_columns_should_include_spent_hours
1238 1246 User.current = User.find(1)
1239 1247
1240 1248 q = IssueQuery.new
1241 1249 assert_include :spent_hours, q.available_totalable_columns.map(&:name)
1242 1250 end
1243 1251
1244 1252 def test_available_totalable_columns_should_include_int_custom_field
1245 1253 field = IssueCustomField.generate!(:field_format => 'int', :is_for_all => true)
1246 1254 q = IssueQuery.new
1247 1255 assert_include "cf_#{field.id}".to_sym, q.available_totalable_columns.map(&:name)
1248 1256 end
1249 1257
1250 1258 def test_available_totalable_columns_should_include_float_custom_field
1251 1259 field = IssueCustomField.generate!(:field_format => 'float', :is_for_all => true)
1252 1260 q = IssueQuery.new
1253 1261 assert_include "cf_#{field.id}".to_sym, q.available_totalable_columns.map(&:name)
1254 1262 end
1255 1263
1256 1264 def test_total_for_estimated_hours
1257 1265 Issue.delete_all
1258 1266 Issue.generate!(:estimated_hours => 5.5)
1259 1267 Issue.generate!(:estimated_hours => 1.1)
1260 1268 Issue.generate!
1261 1269
1262 1270 q = IssueQuery.new
1263 1271 assert_equal 6.6, q.total_for(:estimated_hours)
1264 1272 end
1265 1273
1266 1274 def test_total_by_group_for_estimated_hours
1267 1275 Issue.delete_all
1268 1276 Issue.generate!(:estimated_hours => 5.5, :assigned_to_id => 2)
1269 1277 Issue.generate!(:estimated_hours => 1.1, :assigned_to_id => 3)
1270 1278 Issue.generate!(:estimated_hours => 3.5)
1271 1279
1272 1280 q = IssueQuery.new(:group_by => 'assigned_to')
1273 1281 assert_equal(
1274 1282 {nil => 3.5, User.find(2) => 5.5, User.find(3) => 1.1},
1275 1283 q.total_by_group_for(:estimated_hours)
1276 1284 )
1277 1285 end
1278 1286
1279 1287 def test_total_for_spent_hours
1280 1288 TimeEntry.delete_all
1281 1289 TimeEntry.generate!(:hours => 5.5)
1282 1290 TimeEntry.generate!(:hours => 1.1)
1283 1291
1284 1292 q = IssueQuery.new
1285 1293 assert_equal 6.6, q.total_for(:spent_hours)
1286 1294 end
1287 1295
1288 1296 def test_total_by_group_for_spent_hours
1289 1297 TimeEntry.delete_all
1290 1298 TimeEntry.generate!(:hours => 5.5, :issue_id => 1)
1291 1299 TimeEntry.generate!(:hours => 1.1, :issue_id => 2)
1292 1300 Issue.where(:id => 1).update_all(:assigned_to_id => 2)
1293 1301 Issue.where(:id => 2).update_all(:assigned_to_id => 3)
1294 1302
1295 1303 q = IssueQuery.new(:group_by => 'assigned_to')
1296 1304 assert_equal(
1297 1305 {User.find(2) => 5.5, User.find(3) => 1.1},
1298 1306 q.total_by_group_for(:spent_hours)
1299 1307 )
1300 1308 end
1301 1309
1302 1310 def test_total_by_project_group_for_spent_hours
1303 1311 TimeEntry.delete_all
1304 1312 TimeEntry.generate!(:hours => 5.5, :issue_id => 1)
1305 1313 TimeEntry.generate!(:hours => 1.1, :issue_id => 2)
1306 1314 Issue.where(:id => 1).update_all(:assigned_to_id => 2)
1307 1315 Issue.where(:id => 2).update_all(:assigned_to_id => 3)
1308 1316
1309 1317 q = IssueQuery.new(:group_by => 'project')
1310 1318 assert_equal(
1311 1319 {Project.find(1) => 6.6},
1312 1320 q.total_by_group_for(:spent_hours)
1313 1321 )
1314 1322 end
1315 1323
1316 1324 def test_total_for_int_custom_field
1317 1325 field = IssueCustomField.generate!(:field_format => 'int', :is_for_all => true)
1318 1326 CustomValue.create!(:customized => Issue.find(1), :custom_field => field, :value => '2')
1319 1327 CustomValue.create!(:customized => Issue.find(2), :custom_field => field, :value => '7')
1320 1328 CustomValue.create!(:customized => Issue.find(3), :custom_field => field, :value => '')
1321 1329
1322 1330 q = IssueQuery.new
1323 1331 assert_equal 9, q.total_for("cf_#{field.id}")
1324 1332 end
1325 1333
1326 1334 def test_total_by_group_for_int_custom_field
1327 1335 field = IssueCustomField.generate!(:field_format => 'int', :is_for_all => true)
1328 1336 CustomValue.create!(:customized => Issue.find(1), :custom_field => field, :value => '2')
1329 1337 CustomValue.create!(:customized => Issue.find(2), :custom_field => field, :value => '7')
1330 1338 Issue.where(:id => 1).update_all(:assigned_to_id => 2)
1331 1339 Issue.where(:id => 2).update_all(:assigned_to_id => 3)
1332 1340
1333 1341 q = IssueQuery.new(:group_by => 'assigned_to')
1334 1342 assert_equal(
1335 1343 {User.find(2) => 2, User.find(3) => 7},
1336 1344 q.total_by_group_for("cf_#{field.id}")
1337 1345 )
1338 1346 end
1339 1347
1340 1348 def test_total_for_float_custom_field
1341 1349 field = IssueCustomField.generate!(:field_format => 'float', :is_for_all => true)
1342 1350 CustomValue.create!(:customized => Issue.find(1), :custom_field => field, :value => '2.3')
1343 1351 CustomValue.create!(:customized => Issue.find(2), :custom_field => field, :value => '7')
1344 1352 CustomValue.create!(:customized => Issue.find(3), :custom_field => field, :value => '')
1345 1353
1346 1354 q = IssueQuery.new
1347 1355 assert_equal 9.3, q.total_for("cf_#{field.id}")
1348 1356 end
1349 1357
1350 1358 def test_invalid_query_should_raise_query_statement_invalid_error
1351 1359 q = IssueQuery.new
1352 1360 assert_raise Query::StatementInvalid do
1353 1361 q.issues(:conditions => "foo = 1")
1354 1362 end
1355 1363 end
1356 1364
1357 1365 def test_issue_count
1358 1366 q = IssueQuery.new(:name => '_')
1359 1367 issue_count = q.issue_count
1360 1368 assert_equal q.issues.size, issue_count
1361 1369 end
1362 1370
1363 1371 def test_issue_count_with_archived_issues
1364 1372 p = Project.generate! do |project|
1365 1373 project.status = Project::STATUS_ARCHIVED
1366 1374 end
1367 1375 i = Issue.generate!( :project => p, :tracker => p.trackers.first )
1368 1376 assert !i.visible?
1369 1377
1370 1378 test_issue_count
1371 1379 end
1372 1380
1373 1381 def test_issue_count_by_association_group
1374 1382 q = IssueQuery.new(:name => '_', :group_by => 'assigned_to')
1375 1383 count_by_group = q.issue_count_by_group
1376 1384 assert_kind_of Hash, count_by_group
1377 1385 assert_equal %w(NilClass User), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1378 1386 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1379 1387 assert count_by_group.has_key?(User.find(3))
1380 1388 end
1381 1389
1382 1390 def test_issue_count_by_list_custom_field_group
1383 1391 q = IssueQuery.new(:name => '_', :group_by => 'cf_1')
1384 1392 count_by_group = q.issue_count_by_group
1385 1393 assert_kind_of Hash, count_by_group
1386 1394 assert_equal %w(NilClass String), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1387 1395 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1388 1396 assert count_by_group.has_key?('MySQL')
1389 1397 end
1390 1398
1391 1399 def test_issue_count_by_date_custom_field_group
1392 1400 q = IssueQuery.new(:name => '_', :group_by => 'cf_8')
1393 1401 count_by_group = q.issue_count_by_group
1394 1402 assert_kind_of Hash, count_by_group
1395 1403 assert_equal %w(Date NilClass), count_by_group.keys.collect {|k| k.class.name}.uniq.sort
1396 1404 assert_equal %w(Fixnum), count_by_group.values.collect {|k| k.class.name}.uniq
1397 1405 end
1398 1406
1399 1407 def test_issue_count_with_nil_group_only
1400 1408 Issue.update_all("assigned_to_id = NULL")
1401 1409
1402 1410 q = IssueQuery.new(:name => '_', :group_by => 'assigned_to')
1403 1411 count_by_group = q.issue_count_by_group
1404 1412 assert_kind_of Hash, count_by_group
1405 1413 assert_equal 1, count_by_group.keys.size
1406 1414 assert_nil count_by_group.keys.first
1407 1415 end
1408 1416
1409 1417 def test_issue_ids
1410 1418 q = IssueQuery.new(:name => '_')
1411 1419 order = "issues.subject, issues.id"
1412 1420 issues = q.issues(:order => order)
1413 1421 assert_equal issues.map(&:id), q.issue_ids(:order => order)
1414 1422 end
1415 1423
1416 1424 def test_label_for
1417 1425 set_language_if_valid 'en'
1418 1426 q = IssueQuery.new
1419 1427 assert_equal 'Assignee', q.label_for('assigned_to_id')
1420 1428 end
1421 1429
1422 1430 def test_label_for_fr
1423 1431 set_language_if_valid 'fr'
1424 1432 q = IssueQuery.new
1425 1433 assert_equal "Assign\xc3\xa9 \xc3\xa0".force_encoding('UTF-8'), q.label_for('assigned_to_id')
1426 1434 end
1427 1435
1428 1436 def test_editable_by
1429 1437 admin = User.find(1)
1430 1438 manager = User.find(2)
1431 1439 developer = User.find(3)
1432 1440
1433 1441 # Public query on project 1
1434 1442 q = IssueQuery.find(1)
1435 1443 assert q.editable_by?(admin)
1436 1444 assert q.editable_by?(manager)
1437 1445 assert !q.editable_by?(developer)
1438 1446
1439 1447 # Private query on project 1
1440 1448 q = IssueQuery.find(2)
1441 1449 assert q.editable_by?(admin)
1442 1450 assert !q.editable_by?(manager)
1443 1451 assert q.editable_by?(developer)
1444 1452
1445 1453 # Private query for all projects
1446 1454 q = IssueQuery.find(3)
1447 1455 assert q.editable_by?(admin)
1448 1456 assert !q.editable_by?(manager)
1449 1457 assert q.editable_by?(developer)
1450 1458
1451 1459 # Public query for all projects
1452 1460 q = IssueQuery.find(4)
1453 1461 assert q.editable_by?(admin)
1454 1462 assert !q.editable_by?(manager)
1455 1463 assert !q.editable_by?(developer)
1456 1464 end
1457 1465
1458 1466 def test_visible_scope
1459 1467 query_ids = IssueQuery.visible(User.anonymous).map(&:id)
1460 1468
1461 1469 assert query_ids.include?(1), 'public query on public project was not visible'
1462 1470 assert query_ids.include?(4), 'public query for all projects was not visible'
1463 1471 assert !query_ids.include?(2), 'private query on public project was visible'
1464 1472 assert !query_ids.include?(3), 'private query for all projects was visible'
1465 1473 assert !query_ids.include?(7), 'public query on private project was visible'
1466 1474 end
1467 1475
1468 1476 def test_query_with_public_visibility_should_be_visible_to_anyone
1469 1477 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_PUBLIC)
1470 1478
1471 1479 assert q.visible?(User.anonymous)
1472 1480 assert IssueQuery.visible(User.anonymous).find_by_id(q.id)
1473 1481
1474 1482 assert q.visible?(User.find(7))
1475 1483 assert IssueQuery.visible(User.find(7)).find_by_id(q.id)
1476 1484
1477 1485 assert q.visible?(User.find(2))
1478 1486 assert IssueQuery.visible(User.find(2)).find_by_id(q.id)
1479 1487
1480 1488 assert q.visible?(User.find(1))
1481 1489 assert IssueQuery.visible(User.find(1)).find_by_id(q.id)
1482 1490 end
1483 1491
1484 1492 def test_query_with_roles_visibility_should_be_visible_to_user_with_role
1485 1493 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_ROLES, :role_ids => [1,2])
1486 1494
1487 1495 assert !q.visible?(User.anonymous)
1488 1496 assert_nil IssueQuery.visible(User.anonymous).find_by_id(q.id)
1489 1497
1490 1498 assert !q.visible?(User.find(7))
1491 1499 assert_nil IssueQuery.visible(User.find(7)).find_by_id(q.id)
1492 1500
1493 1501 assert q.visible?(User.find(2))
1494 1502 assert IssueQuery.visible(User.find(2)).find_by_id(q.id)
1495 1503
1496 1504 assert q.visible?(User.find(1))
1497 1505 assert IssueQuery.visible(User.find(1)).find_by_id(q.id)
1498 1506 end
1499 1507
1500 1508 def test_query_with_private_visibility_should_be_visible_to_owner
1501 1509 q = IssueQuery.create!(:name => 'Query', :visibility => IssueQuery::VISIBILITY_PRIVATE, :user => User.find(7))
1502 1510
1503 1511 assert !q.visible?(User.anonymous)
1504 1512 assert_nil IssueQuery.visible(User.anonymous).find_by_id(q.id)
1505 1513
1506 1514 assert q.visible?(User.find(7))
1507 1515 assert IssueQuery.visible(User.find(7)).find_by_id(q.id)
1508 1516
1509 1517 assert !q.visible?(User.find(2))
1510 1518 assert_nil IssueQuery.visible(User.find(2)).find_by_id(q.id)
1511 1519
1512 1520 assert q.visible?(User.find(1))
1513 1521 assert_nil IssueQuery.visible(User.find(1)).find_by_id(q.id)
1514 1522 end
1515 1523
1516 1524 test "#available_filters should include users of visible projects in cross-project view" do
1517 1525 users = IssueQuery.new.available_filters["assigned_to_id"]
1518 1526 assert_not_nil users
1519 1527 assert users[:values].map{|u|u[1]}.include?("3")
1520 1528 end
1521 1529
1522 1530 test "#available_filters should include users of subprojects" do
1523 1531 user1 = User.generate!
1524 1532 user2 = User.generate!
1525 1533 project = Project.find(1)
1526 1534 Member.create!(:principal => user1, :project => project.children.visible.first, :role_ids => [1])
1527 1535
1528 1536 users = IssueQuery.new(:project => project).available_filters["assigned_to_id"]
1529 1537 assert_not_nil users
1530 1538 assert users[:values].map{|u|u[1]}.include?(user1.id.to_s)
1531 1539 assert !users[:values].map{|u|u[1]}.include?(user2.id.to_s)
1532 1540 end
1533 1541
1534 1542 test "#available_filters should include visible projects in cross-project view" do
1535 1543 projects = IssueQuery.new.available_filters["project_id"]
1536 1544 assert_not_nil projects
1537 1545 assert projects[:values].map{|u|u[1]}.include?("1")
1538 1546 end
1539 1547
1540 1548 test "#available_filters should include 'member_of_group' filter" do
1541 1549 query = IssueQuery.new
1542 1550 assert query.available_filters.keys.include?("member_of_group")
1543 1551 assert_equal :list_optional, query.available_filters["member_of_group"][:type]
1544 1552 assert query.available_filters["member_of_group"][:values].present?
1545 1553 assert_equal Group.givable.sort.map {|g| [g.name, g.id.to_s]},
1546 1554 query.available_filters["member_of_group"][:values].sort
1547 1555 end
1548 1556
1549 1557 test "#available_filters should include 'assigned_to_role' filter" do
1550 1558 query = IssueQuery.new
1551 1559 assert query.available_filters.keys.include?("assigned_to_role")
1552 1560 assert_equal :list_optional, query.available_filters["assigned_to_role"][:type]
1553 1561
1554 1562 assert query.available_filters["assigned_to_role"][:values].include?(['Manager','1'])
1555 1563 assert query.available_filters["assigned_to_role"][:values].include?(['Developer','2'])
1556 1564 assert query.available_filters["assigned_to_role"][:values].include?(['Reporter','3'])
1557 1565
1558 1566 assert ! query.available_filters["assigned_to_role"][:values].include?(['Non member','4'])
1559 1567 assert ! query.available_filters["assigned_to_role"][:values].include?(['Anonymous','5'])
1560 1568 end
1561 1569
1562 1570 def test_available_filters_should_include_custom_field_according_to_user_visibility
1563 1571 visible_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => true)
1564 1572 hidden_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => false, :role_ids => [1])
1565 1573
1566 1574 with_current_user User.find(3) do
1567 1575 query = IssueQuery.new
1568 1576 assert_include "cf_#{visible_field.id}", query.available_filters.keys
1569 1577 assert_not_include "cf_#{hidden_field.id}", query.available_filters.keys
1570 1578 end
1571 1579 end
1572 1580
1573 1581 def test_available_columns_should_include_custom_field_according_to_user_visibility
1574 1582 visible_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => true)
1575 1583 hidden_field = IssueCustomField.generate!(:is_for_all => true, :is_filter => true, :visible => false, :role_ids => [1])
1576 1584
1577 1585 with_current_user User.find(3) do
1578 1586 query = IssueQuery.new
1579 1587 assert_include :"cf_#{visible_field.id}", query.available_columns.map(&:name)
1580 1588 assert_not_include :"cf_#{hidden_field.id}", query.available_columns.map(&:name)
1581 1589 end
1582 1590 end
1583 1591
1584 1592 def setup_member_of_group
1585 1593 Group.destroy_all # No fixtures
1586 1594 @user_in_group = User.generate!
1587 1595 @second_user_in_group = User.generate!
1588 1596 @user_in_group2 = User.generate!
1589 1597 @user_not_in_group = User.generate!
1590 1598
1591 1599 @group = Group.generate!.reload
1592 1600 @group.users << @user_in_group
1593 1601 @group.users << @second_user_in_group
1594 1602
1595 1603 @group2 = Group.generate!.reload
1596 1604 @group2.users << @user_in_group2
1597 1605
1598 1606 @query = IssueQuery.new(:name => '_')
1599 1607 end
1600 1608
1601 1609 test "member_of_group filter should search assigned to for users in the group" do
1602 1610 setup_member_of_group
1603 1611 @query.add_filter('member_of_group', '=', [@group.id.to_s])
1604 1612
1605 1613 assert_find_issues_with_query_is_successful @query
1606 1614 end
1607 1615
1608 1616 test "member_of_group filter should search not assigned to any group member (none)" do
1609 1617 setup_member_of_group
1610 1618 @query.add_filter('member_of_group', '!*', [''])
1611 1619
1612 1620 assert_find_issues_with_query_is_successful @query
1613 1621 end
1614 1622
1615 1623 test "member_of_group filter should search assigned to any group member (all)" do
1616 1624 setup_member_of_group
1617 1625 @query.add_filter('member_of_group', '*', [''])
1618 1626
1619 1627 assert_find_issues_with_query_is_successful @query
1620 1628 end
1621 1629
1622 1630 test "member_of_group filter should return an empty set with = empty group" do
1623 1631 setup_member_of_group
1624 1632 @empty_group = Group.generate!
1625 1633 @query.add_filter('member_of_group', '=', [@empty_group.id.to_s])
1626 1634
1627 1635 assert_equal [], find_issues_with_query(@query)
1628 1636 end
1629 1637
1630 1638 test "member_of_group filter should return issues with ! empty group" do
1631 1639 setup_member_of_group
1632 1640 @empty_group = Group.generate!
1633 1641 @query.add_filter('member_of_group', '!', [@empty_group.id.to_s])
1634 1642
1635 1643 assert_find_issues_with_query_is_successful @query
1636 1644 end
1637 1645
1638 1646 def setup_assigned_to_role
1639 1647 @manager_role = Role.find_by_name('Manager')
1640 1648 @developer_role = Role.find_by_name('Developer')
1641 1649
1642 1650 @project = Project.generate!
1643 1651 @manager = User.generate!
1644 1652 @developer = User.generate!
1645 1653 @boss = User.generate!
1646 1654 @guest = User.generate!
1647 1655 User.add_to_project(@manager, @project, @manager_role)
1648 1656 User.add_to_project(@developer, @project, @developer_role)
1649 1657 User.add_to_project(@boss, @project, [@manager_role, @developer_role])
1650 1658
1651 1659 @issue1 = Issue.generate!(:project => @project, :assigned_to_id => @manager.id)
1652 1660 @issue2 = Issue.generate!(:project => @project, :assigned_to_id => @developer.id)
1653 1661 @issue3 = Issue.generate!(:project => @project, :assigned_to_id => @boss.id)
1654 1662 @issue4 = Issue.generate!(:project => @project, :assigned_to_id => @guest.id)
1655 1663 @issue5 = Issue.generate!(:project => @project)
1656 1664
1657 1665 @query = IssueQuery.new(:name => '_', :project => @project)
1658 1666 end
1659 1667
1660 1668 test "assigned_to_role filter should search assigned to for users with the Role" do
1661 1669 setup_assigned_to_role
1662 1670 @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
1663 1671
1664 1672 assert_query_result [@issue1, @issue3], @query
1665 1673 end
1666 1674
1667 1675 test "assigned_to_role filter should search assigned to for users with the Role on the issue project" do
1668 1676 setup_assigned_to_role
1669 1677 other_project = Project.generate!
1670 1678 User.add_to_project(@developer, other_project, @manager_role)
1671 1679 @query.add_filter('assigned_to_role', '=', [@manager_role.id.to_s])
1672 1680
1673 1681 assert_query_result [@issue1, @issue3], @query
1674 1682 end
1675 1683
1676 1684 test "assigned_to_role filter should return an empty set with empty role" do
1677 1685 setup_assigned_to_role
1678 1686 @empty_role = Role.generate!
1679 1687 @query.add_filter('assigned_to_role', '=', [@empty_role.id.to_s])
1680 1688
1681 1689 assert_query_result [], @query
1682 1690 end
1683 1691
1684 1692 test "assigned_to_role filter should search assigned to for users without the Role" do
1685 1693 setup_assigned_to_role
1686 1694 @query.add_filter('assigned_to_role', '!', [@manager_role.id.to_s])
1687 1695
1688 1696 assert_query_result [@issue2, @issue4, @issue5], @query
1689 1697 end
1690 1698
1691 1699 test "assigned_to_role filter should search assigned to for users not assigned to any Role (none)" do
1692 1700 setup_assigned_to_role
1693 1701 @query.add_filter('assigned_to_role', '!*', [''])
1694 1702
1695 1703 assert_query_result [@issue4, @issue5], @query
1696 1704 end
1697 1705
1698 1706 test "assigned_to_role filter should search assigned to for users assigned to any Role (all)" do
1699 1707 setup_assigned_to_role
1700 1708 @query.add_filter('assigned_to_role', '*', [''])
1701 1709
1702 1710 assert_query_result [@issue1, @issue2, @issue3], @query
1703 1711 end
1704 1712
1705 1713 test "assigned_to_role filter should return issues with ! empty role" do
1706 1714 setup_assigned_to_role
1707 1715 @empty_role = Role.generate!
1708 1716 @query.add_filter('assigned_to_role', '!', [@empty_role.id.to_s])
1709 1717
1710 1718 assert_query_result [@issue1, @issue2, @issue3, @issue4, @issue5], @query
1711 1719 end
1712 1720
1713 1721 def test_query_column_should_accept_a_symbol_as_caption
1714 1722 set_language_if_valid 'en'
1715 1723 c = QueryColumn.new('foo', :caption => :general_text_Yes)
1716 1724 assert_equal 'Yes', c.caption
1717 1725 end
1718 1726
1719 1727 def test_query_column_should_accept_a_proc_as_caption
1720 1728 c = QueryColumn.new('foo', :caption => lambda {'Foo'})
1721 1729 assert_equal 'Foo', c.caption
1722 1730 end
1723 1731
1724 1732 def test_date_clause_should_respect_user_time_zone_with_local_default
1725 1733 @query = IssueQuery.new(:name => '_')
1726 1734
1727 1735 # user is in Hawaii (-10)
1728 1736 User.current = users(:users_001)
1729 1737 User.current.pref.update_attribute :time_zone, 'Hawaii'
1730 1738
1731 1739 # assume timestamps are stored in server local time
1732 1740 local_zone = Time.zone
1733 1741
1734 1742 from = Date.parse '2016-03-20'
1735 1743 to = Date.parse '2016-03-22'
1736 1744 assert c = @query.send(:date_clause, 'table', 'field', from, to, false)
1737 1745
1738 1746 # the dates should have been interpreted in the user's time zone and
1739 1747 # converted to local time
1740 1748 # what we get exactly in the sql depends on the local time zone, therefore
1741 1749 # it's computed here.
1742 1750 f = User.current.time_zone.local(from.year, from.month, from.day).yesterday.end_of_day.in_time_zone(local_zone)
1743 1751 t = User.current.time_zone.local(to.year, to.month, to.day).end_of_day.in_time_zone(local_zone)
1744 1752 assert_equal "table.field > '#{Query.connection.quoted_date f}' AND table.field <= '#{Query.connection.quoted_date t}'", c
1745 1753 end
1746 1754
1747 1755 def test_date_clause_should_respect_user_time_zone_with_utc_default
1748 1756 @query = IssueQuery.new(:name => '_')
1749 1757
1750 1758 # user is in Hawaii (-10)
1751 1759 User.current = users(:users_001)
1752 1760 User.current.pref.update_attribute :time_zone, 'Hawaii'
1753 1761
1754 1762 # assume timestamps are stored as utc
1755 1763 ActiveRecord::Base.default_timezone = :utc
1756 1764
1757 1765 from = Date.parse '2016-03-20'
1758 1766 to = Date.parse '2016-03-22'
1759 1767 assert c = @query.send(:date_clause, 'table', 'field', from, to, false)
1760 1768 # the dates should have been interpreted in the user's time zone and
1761 1769 # converted to utc. March 20 in Hawaii begins at 10am UTC.
1762 1770 f = Time.new(2016, 3, 20, 9, 59, 59, 0).end_of_hour
1763 1771 t = Time.new(2016, 3, 23, 9, 59, 59, 0).end_of_hour
1764 1772 assert_equal "table.field > '#{Query.connection.quoted_date f}' AND table.field <= '#{Query.connection.quoted_date t}'", c
1765 1773 ensure
1766 1774 ActiveRecord::Base.default_timezone = :local # restore Redmine default
1767 1775 end
1768 1776
1769 1777 end
General Comments 0
You need to be logged in to leave comments. Login now